From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 05:30:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 03:30:58 +0000 Subject: [Koha-bugs] [Bug 11357] biblio.size value not correctly displayed in list emails sent from OPAC and intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11357 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Small fix, pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 05:53:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 03:53:31 +0000 Subject: [Koha-bugs] [Bug 12507] New: Don't show News in Staff and opac in 3.16.0 / 3.16.1 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Bug ID: 12507 Summary: Don't show News in Staff and opac in 3.16.0 / 3.16.1 Change sponsored?: --- Product: Koha Version: 3.14 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: felipe.gomez3 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In these versions news HOMEPAGE staff and OPAC disappear. I have the error un the NewsChannels.pm file. /usr/share/koha/lib/C4/NewsChannels.pm the error is solved by simply changing the quotes in the line 200: OLD: AND `timestamp` < CURRENT_DATE()+1 NEW: AND 'timestamp' < CURRENT_DATE()+1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 05:54:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 03:54:34 +0000 Subject: [Koha-bugs] [Bug 12507] Don't show News in Staff and opac in 3.16.0 / 3.16.1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 MetaBiblioteca Colombia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 06:44:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 04:44:10 +0000 Subject: [Koha-bugs] [Bug 12429] patron seeing fines codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12186 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 06:44:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 04:44:10 +0000 Subject: [Koha-bugs] [Bug 12186] Duplicate TT code for account payments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12186 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12429 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 06:49:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 04:49:42 +0000 Subject: [Koha-bugs] [Bug 12386] 'Days in advance' pull down in bootstrap OPAC is huge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12386 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #5 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 06:49:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 04:49:58 +0000 Subject: [Koha-bugs] [Bug 12386] 'Days in advance' pull down in bootstrap OPAC is huge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12386 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29381|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 06:50:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 04:50:06 +0000 Subject: [Koha-bugs] [Bug 12386] 'Days in advance' pull down in bootstrap OPAC is huge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12386 --- Comment #6 from sandboxes at biblibre.com --- Created attachment 29388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29388&action=edit Bug 12386 - 'Days in advance' pull down in bootstrap OPAC is huge The "days in advance" form field on the "Your messaging settings" page in the OPAC has a Bootstrap-default width which is too wide. This patch adds a class to give it a more reasonable size. To test you must have the EnhancedMessagingPreferences preference set to "Allow." Log in to the OPAC and view the messaging settings page. The dropdown menu of numbers should look correct. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 07:02:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 05:02:41 +0000 Subject: [Koha-bugs] [Bug 12429] patron seeing fines codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #5 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 07:02:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 05:02:56 +0000 Subject: [Koha-bugs] [Bug 12429] patron seeing fines codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29369|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 07:03:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 05:03:01 +0000 Subject: [Koha-bugs] [Bug 12429] patron seeing fines codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29370|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 07:03:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 05:03:07 +0000 Subject: [Koha-bugs] [Bug 12429] patron seeing fines codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 --- Comment #6 from sandboxes at biblibre.com --- Created attachment 29389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29389&action=edit Bug 12429 [staff client] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the staff client. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and view fines page (Patron details -> Fines) and the pay fines page (Patron details -> Fines -> Pay fines). You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 07:03:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 05:03:10 +0000 Subject: [Koha-bugs] [Bug 12429] patron seeing fines codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 29390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29390&action=edit Bug 12429 [OPAC] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the bootstrap OPAC. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and log in to the OPAC as a user who has existing fines and charges. View the "Your fines" page. You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 07:41:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 05:41:40 +0000 Subject: [Koha-bugs] [Bug 12494] Remove yuipath system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 07:41:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 05:41:51 +0000 Subject: [Koha-bugs] [Bug 12494] Remove yuipath system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29330|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 07:41:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 05:41:58 +0000 Subject: [Koha-bugs] [Bug 12494] Remove yuipath system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 29391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29391&action=edit Bug 12494 - Remove yuipath system preference With the OPAC prog template going away, the only remaining use of the yuipath preference is on the basketgroups template. The yuipath preference should be removed and the local path hard-coded. This patch: - removes yuipath handling from C4/Templates.pm - removes the preference from sysprefs.sql - deletes the preference via updatedatabase.pl - removes the preference from the staff client preferences file - removes unused references to the YUI assets from the help file header include - adds the local YUI asset path to acqui/basketgroup.tt To test, apply the patch and run the database update. View some online help pages and confirm that they function correctly. View the basketgroups page (Acquisition -> Vendor -> Basket groups), edit a basket group, and confirm that basket drag and drop operations work correctly. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 08:34:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 06:34:11 +0000 Subject: [Koha-bugs] [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481 --- Comment #12 from Juhani Sepp?l? --- (In reply to Marc V?ron from comment #11) > Created attachment 29386 [details] [review] > Bug 12481 - Follow up: Link to results is not refreshed when item is on > next or prev result page > > Test plan for this follow up > > Reproduce issue without patch: > > Do a search that results in 3 or more pages. > Print out list or do the same search in an other browser (to have a > reference for the following) > Go to a detail view and step through details to a detail that ist on result > #3 > Click on Link "Return to details" > Result: The first page will display (instead of page #2) > > With patch, the correct page should display. Hi, I'm unable to reproduce what you're describing with only my patch applied. What I'm doing: 1. Do a search with 3 or more pages of results. 2. Select a result from the first page and navigate into the third page using the detail-view. 3. Select "return to results" on a results on the third page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 09:20:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 07:20:48 +0000 Subject: [Koha-bugs] [Bug 12508] New: The removal of a contract which is linked to a basket does not display an error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Bug ID: 12508 Summary: The removal of a contract which is linked to a basket does not display an error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: yohann.dufour at biblibre.com QA Contact: testopia at bugs.koha-community.org When we delete a contract which is linked to a basket, the removal is not done but no errors is displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 09:21:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 07:21:26 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 Yohann Dufour changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12508 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 09:21:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 07:21:26 +0000 Subject: [Koha-bugs] [Bug 12508] The removal of a contract which is linked to a basket does not display an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Yohann Dufour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |12493 Assignee|koha-bugs at lists.koha-commun |yohann.dufour at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 09:21:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 07:21:49 +0000 Subject: [Koha-bugs] [Bug 12508] The removal of a contract which is linked to a basket does not display an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Yohann Dufour changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12487 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 09:21:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 07:21:49 +0000 Subject: [Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487 Yohann Dufour changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12508 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:05:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:05:27 +0000 Subject: [Koha-bugs] [Bug 12508] The removal of a contract which is linked to a basket does not display an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Yohann Dufour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:05:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:05:29 +0000 Subject: [Koha-bugs] [Bug 12508] The removal of a contract which is linked to a basket does not display an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 --- Comment #1 from Yohann Dufour --- Created attachment 29392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29392&action=edit Bug 12508: adding an error message if a contract cannot be removed If a contract cannot be removed, no errors is displayed. Now, it displays an dialog messag error and the list of contracts. Test plan: 1) Log on with a superlibrarian permission 2) Go on the page acqui/supplier.pl (Acquisitions > Button "New vendor") 3) Record a vendor with a nonzero "name" 4) Go on the page admin/aqcontract.pl (click on the "Contracts" item in the menu) 5) Click on the button "New" > "Contract" and record a new one 6) Click on "New" > "Basket" and record a basket by selectioning the created contract 7) Click on the contract name, then click on the "Contracts" item in the left menu 8) Try to delete this contract, an error is displayed : "Contract has not been deleted. Maybe a basket linked to this contract exists." 9) Delete the basket linked to the contract 10) Delete the contract, no errors is displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:15:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:15:41 +0000 Subject: [Koha-bugs] [Bug 12429] patron seeing fines codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12415 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:15:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:15:41 +0000 Subject: [Koha-bugs] [Bug 12415] Fee receipt: description of charges is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12415 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12429 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:52:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:52:54 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28595|0 |1 is obsolete| | --- Comment #23 from Holger Mei?ner --- Created attachment 29393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29393&action=edit Bug 11577: Add auto_renew flags to the database - issues.auto_renew - old_issues.auto_renew - issuingrules.auto_renew Default value is zero. To test: 1) Run installer/data/mysql/updatedatabase.pl 2) Create SQL reports like: SELECT * FROM issues LIMIT 0,1 3) Confirm that a column auto_renew was added to each of the three tables. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:52:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:52:57 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28596|0 |1 is obsolete| | --- Comment #24 from Holger Mei?ner --- Created attachment 29394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29394&action=edit Bug 11577: Add "Automatic renewal" to the circulation and fine rules This patch adds a column "Automatic renewal" to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that "Automatic Renewal" is set to "No" by default and can be switched to "Yes". Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:53:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:53:00 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28597|0 |1 is obsolete| | --- Comment #25 from Holger Mei?ner --- Created attachment 29395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29395&action=edit Bug 11577: Code and intranet template changes This patch adds a checkbox for "Automatic renewal" to the checkout page. CanBookBeRenewed is modified to include two new errors: - auto_renew (renewal shouldn't be done manually) - auto_too_soon (renewal is premature and shouldn't be done manually) To test: 1) Add or edit an issuing rule with "Automatic renewal" and another one without it. 2) Issue at least three items: - automatic renewal by issuing rule - automatic renewal by Checkbox on the checkout page - no automatic renewal 3) Test the following steps for both: Home > Circulation > Checkouts Home > Patrons > Patron details 4) Confirm that issues with automatic renewal cannot be renewed manually, even if there are still renewals left and it's not too soon to renew. 5) Confirm that "Automatic renewal" and the remaining renewals are displayed. If no renewals are left "Not renewable" should be displayed. 6) Confirm that issues without automatic renewal behave as usual. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:53:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:53:03 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28598|0 |1 is obsolete| | --- Comment #26 from Holger Mei?ner --- Created attachment 29396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29396&action=edit Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon' to the renewal interface. To test: 1) Issue two items: - one with automatic renewal and no value for "No renewal before" - another with automatic renewal and a value for "No renewal before" 2) Try to renew: Home > Circulation > Renew 3) Confirm there are error messages explaining that the items have been sheduled for automatic renewal and that one of the renewals is also premature. 4) If global syspref AllowRenewalLimitOverride is set to "Allow" you should be given the option to override. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:53:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:53:06 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28599|0 |1 is obsolete| | --- Comment #27 from Holger Mei?ner --- Created attachment 29397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29397&action=edit Bug 11577: Expand description of AllowRenewalLimitOverride With the introduction of the new automatic renewal feature global syspref AllowRenewalLimitOverride is expanded in meaning. It now gives the option to override blocks if: - the number of allowed renewals is exceeded - the renewal is premature (No renewal before) - the item is sheduled for automatic renewal - the renewal is premature and the item is sheduled for automatic renewal Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:53:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:53:12 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28601|0 |1 is obsolete| | --- Comment #29 from Holger Mei?ner --- Created attachment 29399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29399&action=edit Bug 11577: OPAC prog theme changes This patch makes the prog version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to prog. 2) Test the same things as in previous patch. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:53:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:53:09 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28600|0 |1 is obsolete| | --- Comment #28 from Holger Mei?ner --- Created attachment 29398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29398&action=edit Bug 11577: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:53:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:53:15 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28602|0 |1 is obsolete| | --- Comment #30 from Holger Mei?ner --- Created attachment 29400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29400&action=edit Bug 11577: Add an automatic renewal cronjob This patch adds a new cron script automatic_renewals.pl and a new entry in crontab.example. To test: 1) You need a few issues, some with automatic renewal and some without. 2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl those issues are renewed that meet all of the following criteria: - automatic renewal has been sheduled either by issuing rule or by checkbox on the checkout page - the number of allowed renewals isn't exceeded - renewal isn't premature (No renewal before) 3) Confirm that all other issues are not affected. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:53:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:53:18 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28603|0 |1 is obsolete| | --- Comment #31 from Holger Mei?ner --- Created attachment 29401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29401&action=edit Bug 11577: Unit tests This patch fixes a few unit tests that broke because of the new feature. To test: 1) prove t/db_dependent/Circulation.t 2) prove t/db_dependent/Circulation_Issuingrule.t 3) prove t/db_dependent/Circulation_issue.t Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:53:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:53:21 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #32 from Holger Mei?ner --- Created attachment 29402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29402&action=edit Bug 11577: Add Hochschule f?r Gesundheit to contributing institutions Automatic renewal is the second feature sponsored by the hsg. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 10:55:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 08:55:11 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28604|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 11:47:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 09:47:41 +0000 Subject: [Koha-bugs] [Bug 12386] 'Days in advance' pull down in bootstrap OPAC is huge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12386 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29387|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Comment on attachment 29387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29387 Class input-mini has no effect Obsoleting this screenshot - It was a mistake (Entry in OPACUserCSS) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 12:12:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 10:12:30 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #132 from Katrin Fischer --- I was worried that these changes might have an impact on accessibility and asked one of our libraries with a blind staff member to test this on a sandbox. The test has turned up 2 major problems for her: 1) In IE checking out books is broken. Under some circumstances, if you checkout a book, it won't show up on the patron account. If it happens, it doesn't matter how often you reload the page or switch tabs or whatever, it won't show up. The number of checkouts on top of the tab changes and is always correct. (Version: IE 9) To test: - Use IE. - check out book - check out a book that is checked out to someone else, confirm with yes - Verify this book doesn't show up in the list of checkouts - check out a book that is on hold for someone else, confirm with yes > Check for each of those, if the list of checkouts is correctly displayed. For me, normal checkouts worked sometimes, but the other 2 cases never worked. Often things got stuck after the first successful checkout. If you have an account with a wrong list of checkouts, try: - Switching to the details tab and back to checkouts - Shift/ctrl+reload - Verify the list is still not correct. Sometimes, when you go back to an account after having checked in all items, the old checkouts still show up! I know we are not officially supporting IE on the staff side, but I think this problem is major enough that it really needs to be fixed. Also, switching browsers is not an option for this library as there are existing problems in using FF. 2) In IE and FF if you use keyboard shortcuts to move between the tabs, the tables for holds and relative's checkouts are not loaded. All you see is the table headers, but no contents. Only when you can click on the tab, the tables are loaded. So if you don't have a mouse, you can't see the holds and relative's checkouts. To test: - Click on the "checkouts" tab, then use arrow keys to move between them. - Verify that the relatives checkouts and holds tables don't display the entries, but just the table header. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 12:18:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 10:18:31 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #133 from Katrin Fischer --- I am setting to 'In Discussion' for the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 12:50:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 10:50:29 +0000 Subject: [Koha-bugs] [Bug 12509] New: Untranslatable "Restriction added by overdues process" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509 Bug ID: 12509 Summary: Untranslatable "Restriction added by overdues process" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr misc/cronjobs/overdue_notices.pl adds a debarment with an untranslatable comment "Restriction added by overdues process" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 13:19:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 11:19:42 +0000 Subject: [Koha-bugs] [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29386|0 |1 is obsolete| | --- Comment #13 from Marc V?ron --- Comment on attachment 29386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29386 Bug 12481 - Follow up: Link to results is not refreshed when item is on next or prev result page Hi Juhani, Strange, I tested again with your patch only and can not longer reproduce the behaviour. I used a result set with about 10 pages. Yesterday, I had two tabs open, in one I had the result list (>10 pages) and in the other, I stepped through the single views andgot the odd behaviour. I obsolete now my follow up patch and will sign-off your patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 13:25:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 11:25:31 +0000 Subject: [Koha-bugs] [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29276|0 |1 is obsolete| | --- Comment #14 from Marc V?ron --- Created attachment 29403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29403&action=edit Bug 12481: Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into When doing a staff client catalog search with more than 1 page of results and clicking the last result on any search result page, the top-left navigation button for "next" is greyed out. Tested on newest Firefox & Chromium. Attempts to restore originally planned checks for navigation with the exception of not using results.length due to buggy behaviour where the results get concatenated upon page reload & "return to results" navigation - a separate issue? To test: 1) Do an intranet catalog search that has more than 1 page of results. 2) Click on the last result on a page that is not the last one & confirm that the navigation button "next" is greyed out. 4) Apply patch. 5) Do an intranet search with more than 1 but less results than fit on a single page. 6) Click on the last result on the page and confirm that the "Next" navigation button is greyed out. 6) Do an intranet search with more than 1 page of results. 7) Click on the last result of a page that's not the final page of the results & confirm that "Next" is not grey out. 8) Navigate to the last page of the results and click on the final result & confirm that "Next" is greyd out. http://bugs.koha-community.org/show_bug.cgi?id=12481 This patch prevents the "Next" button on detail view to be grayed out at the end of e result page. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 13:26:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 11:26:59 +0000 Subject: [Koha-bugs] [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 13:31:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 11:31:22 +0000 Subject: [Koha-bugs] [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481 --- Comment #15 from Marc V?ron --- (In reply to Juhani Sepp?l? from comment #9) (...) > This is not the only interesting behaviour I've come across with the > navigation. There's another issue where the results of the page get > concatenated infinitely on page reload, which originally led me to believe > the results-array in the cookie was the whole results set. These should > probably be reported separately? I propose that you report this separately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 13:43:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 11:43:10 +0000 Subject: [Koha-bugs] [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481 --- Comment #16 from Juhani Sepp?l? --- (In reply to Marc V?ron from comment #15) > (In reply to Juhani Sepp?l? from comment #9) > > (...) > > This is not the only interesting behaviour I've come across with the > > navigation. There's another issue where the results of the page get > > concatenated infinitely on page reload, which originally led me to believe > > the results-array in the cookie was the whole results set. These should > > probably be reported separately? > > I propose that you report this separately. Thanks for looking into this Marc and helping with my regression. I should've been more precise there: it's the result array in the search cookie that's getting concatenated needlessly on page reloads - not sure if this can actually cause any harm currently, but the concatenation on page reloads doesn't look intentional in any case. I can create a new bug for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 13:57:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 11:57:09 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29120|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 29404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29404&action=edit Bug 11431 [6] - Add the ability to specify arbitrary audio alerts This patch further enhances our control over Koha audio alerts by allowing a library to specify custom audio events. A new system preference is added the combines the functions of the Selector and Override systems preferences in a list of selector:sound combinations. These definitions override the default sounds and thus gives the library a way to completely redefine what events trigger and audio alert, and what sounds are played! Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit the new AudioAlertsCustom system preference and enter the following: "body:contains('Check in message')": "IM_notification.ogg" 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 14:05:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 12:05:00 +0000 Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel --- Testing, no errors. But: 1) Copyright to "Mark Tompsett" :), think that you must change that to yourself. 2) Validation outputs 2 warnings using http://feedvalidator.org/ Don't know if those can be solved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 14:26:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 12:26:23 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 14:26:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 12:26:26 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24468|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 29405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29405&action=edit Bug 10877 - Add "Order Record" processing Order Record Processing will allow a library to stage an "order record" file which is a standard marc file with some additional information in it about how to create items automatically ( quantity, itemtype, etc ). The location of these fields is defined in the system preference MarcFieldsToOrder from bug 7180. The workflow is thus: 1) A librarian uploads an "order record" file, and marks the batch as an order file during the staging process. 2) The librarian selects an acquisitions basket and chooses "from a staged order file" 3) From here, the librarian can view all the records that will be created, along with quantity and other data ( from bug 7180 ). The librarian will *not* see the item fields, as those are automatically created using the minimum data needed ( branches, itype ). 4) The librarian hits "save" and the items are automatically generated on order. Later ( using features not directly tied to this feature ), the librarian will receive a new marc batch file with items attached ( including itemnumbers ). The vendor will have this information because it was sent via EDI ( bug 7736 ). The librarian will then use the marc record staging feature to overlay those bare bones item records with the full data ( via bug 7131 ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 14:32:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 12:32:11 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29405|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 29406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29406&action=edit Bug 10877 - Add "Order Record" processing Order Record Processing will allow a library to stage an "order record" file which is a standard marc file with some additional information in it about how to create items automatically ( quantity, itemtype, etc ). The location of these fields is defined in the system preference MarcFieldsToOrder from bug 7180. The workflow is thus: 1) A librarian uploads an "order record" file, and marks the batch as an order file during the staging process. 2) The librarian selects an acquisitions basket and chooses "from a staged order file" 3) From here, the librarian can view all the records that will be created, along with quantity and other data ( from bug 7180 ). The librarian will *not* see the item fields, as those are automatically created using the minimum data needed ( branches, itype ). 4) The librarian hits "save" and the items are automatically generated on order. Later ( using features not directly tied to this feature ), the librarian will receive a new marc batch file with items attached ( including itemnumbers ). The vendor will have this information because it was sent via EDI ( bug 7736 ). The librarian will then use the marc record staging feature to overlay those bare bones item records with the full data ( via bug 7131 ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 14:37:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 12:37:25 +0000 Subject: [Koha-bugs] [Bug 12507] Don't show News in Staff and opac in 3.16.0 / 3.16.1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |3.16 --- Comment #1 from Owen Leonard --- Please paste the error. The news feature works fine for me in the OPAC and staff client in version 3.16.01. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 14:37:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 12:37:43 +0000 Subject: [Koha-bugs] [Bug 12507] Don't show News in Staff and opac in 3.16.0 / 3.16.1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 14:41:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 12:41:37 +0000 Subject: [Koha-bugs] [Bug 12509] Untranslatable "Restriction added by overdues process" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 14:46:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 12:46:23 +0000 Subject: [Koha-bugs] [Bug 12492] Package dependency changes to account for bug 12393 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12492 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|master |3.16 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 14:58:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 12:58:58 +0000 Subject: [Koha-bugs] [Bug 12504] Opac search by Language of the item and zebra @attr 1=54 Broken for Unimarc ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12504 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.16 Summary|Version 3.16.xx Opac search |Opac search by Language of |by Language of the item and |the item and zebra @attr |zebra @attr 1=54 Broken for |1=54 Broken for Unimarc ? |Unimarc ? | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 15:03:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 13:03:35 +0000 Subject: [Koha-bugs] [Bug 12414] Late orders display showing non-late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12414 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.16 Summary|Late Order Result Display - |Late orders display showing |koha 3.16 |non-late orders Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 15:41:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 13:41:45 +0000 Subject: [Koha-bugs] [Bug 12510] New: In staff client search, per-page search results (cookie) get concatenated needlessly on page reload Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12510 Bug ID: 12510 Summary: In staff client search, per-page search results (cookie) get concatenated needlessly on page reload Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: jseppal at student.uef.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 29407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29407&action=edit Per-page results array concatenation (search cookie) When doing a staff client search, clicking on a result and returning to the results using the "return to results" from the top-left navigation, the per-page results array in the search cookie gets concatenated once upon returning to the search results and then every time the page is reloaded. See the attached screenshot. I noticed this behaviour while working on bug 12261. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:00:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:00:52 +0000 Subject: [Koha-bugs] [Bug 12373] yuipath system preference affects OPAC but is filed under Staff Client: Appearance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12373 --- Comment #1 from Owen Leonard --- I've submitted a patch for master (Bug 12494) to remove the yuipath preference altogether. I think this issue is "WONTFIX" because the kind of change described above is not likely to be made to stable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:12:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:12:49 +0000 Subject: [Koha-bugs] [Bug 12358] patrons can't see hold notes in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12358 --- Comment #1 from Owen Leonard --- I don't have any idea how libraries use hold notes (we don't use them at all), but it seems likely that some libraries are currently using notes in a way which is meant only for the staff. For these libraries, making the notes available to the patron might be a problem. To fix this bug properly we would probably have to add a "public note" field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:13:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:13:36 +0000 Subject: [Koha-bugs] [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29403|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 29408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29408&action=edit Bug 12481: Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into When doing a staff client catalog search with more than 1 page of results and clicking the last result on any search result page, the top-left navigation button for "next" is greyed out. Tested on newest Firefox & Chromium. Attempts to restore originally planned checks for navigation with the exception of not using results.length due to buggy behaviour where the results get concatenated upon page reload & "return to results" navigation - a separate issue? To test: 1) Do an intranet catalog search that has more than 1 page of results. 2) Click on the last result on a page that is not the last one & confirm that the navigation button "next" is greyed out. 4) Apply patch. 5) Do an intranet search with more than 1 but less results than fit on a single page. 6) Click on the last result on the page and confirm that the "Next" navigation button is greyed out. 6) Do an intranet search with more than 1 page of results. 7) Click on the last result of a page that's not the final page of the results & confirm that "Next" is not grey out. 8) Navigate to the last page of the results and click on the final result & confirm that "Next" is greyd out. http://bugs.koha-community.org/show_bug.cgi?id=12481 This patch prevents the "Next" button on detail view to be grayed out at the end of e result page. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:16:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:16:24 +0000 Subject: [Koha-bugs] [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Jonathan Druart --- (In reply to Juhani Sepp?l? from comment #16) > I can create a new bug for this. Did you create it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:29:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:29:21 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #134 from Christopher Brannon --- Katrin, IE9 is two major versions back. IE10 introduced a big jump in fixing a lot of issues and being more compliant than previous versions. I'm wondering if these issues are persistent with current versions. Because this is an accessibility discussion, is there a reason they need to stick with an older version of IE? I really don't recommend use of anything earlier than IE10 here. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:34:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:34:48 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #135 from Katrin Fischer --- Hi Christopher, I am normally not using IE - IE9 is what we appear to have available at work. I will check with the library for the version they use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:35:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:35:21 +0000 Subject: [Koha-bugs] [Bug 12386] 'Days in advance' pull down in bootstrap OPAC is huge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:35:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:35:25 +0000 Subject: [Koha-bugs] [Bug 12386] 'Days in advance' pull down in bootstrap OPAC is huge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29388|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 29409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29409&action=edit Bug 12386 - 'Days in advance' pull down in bootstrap OPAC is huge The "days in advance" form field on the "Your messaging settings" page in the OPAC has a Bootstrap-default width which is too wide. This patch adds a class to give it a more reasonable size. To test you must have the EnhancedMessagingPreferences preference set to "Allow." Log in to the OPAC and view the messaging settings page. The dropdown menu of numbers should look correct. Signed-off-by: Aleisha Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:36:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:36:15 +0000 Subject: [Koha-bugs] [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481 --- Comment #19 from Juhani Sepp?l? --- (In reply to Jonathan Druart from comment #18) > (In reply to Juhani Sepp?l? from comment #16) > > I can create a new bug for this. > > Did you create it? Yes, was about to post it here for Marc as well: Bug 12510(In reply to Jonathan Druart from comment #18) > (In reply to Juhani Sepp?l? from comment #16) > > I can create a new bug for this. > > Did you create it? Yes, sorry, was about to post it here for Marc as well, see Bug 12510. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:36:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:36:28 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #136 from Owen Leonard --- (In reply to Christopher Brannon from comment #134) > IE9 is two major versions back. ...and we have never guaranteed that the staff client would work in Internet Explorer. I think that this shouldn't be a blocking issue for this bug unless there is good evidence that some users have to use Internet Explorer for accessibility reasons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:41:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:41:28 +0000 Subject: [Koha-bugs] [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12510 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:41:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:41:28 +0000 Subject: [Koha-bugs] [Bug 12510] In staff client search, per-page search results (cookie) get concatenated needlessly on page reload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12510 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12481 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:47:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:47:52 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #137 from Katrin Fischer --- I know I am biased here, but we have a library where this is the case. I will hear back from them tomorrow about the exact browser version they tested with. But I think between not officially supporting a browser and making a whole module unusuable is quite a big step and we should at least discuss this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 16:57:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 14:57:29 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #138 from Christopher Brannon --- Aside from my previous comment, I can confirm the problem where the checkout list does not refresh in IE11 either. So it isn't just an IE9 thing. Does not seem to be related to whether the item is already checked out. IE just does not refresh. I can confirm that the holds list does not appear in FF or IE unless you physically click on the tab. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:01:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:01:45 +0000 Subject: [Koha-bugs] [Bug 12510] In staff client search, per-page search results (cookie) get concatenated needlessly on page reload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12510 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:02:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:02:54 +0000 Subject: [Koha-bugs] [Bug 10618] Acq claim email not formatting correctly and missing information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10618 --- Comment #2 from Holger Mei?ner --- I took a look at this and found out where it goes wrong. But I have no idea how to fix it. The problem is in C4::Letters. In sub SendAlerts there's this bit of SQL: SELECT aqorders.*,aqbasket.*,biblio.*,biblioitems.*,aqbooksellers.*, aqbooksellers.id AS booksellerid FROM aqorders LEFT JOIN aqbasket ON aqbasket.basketno=aqorders.basketno LEFT JOIN biblio ON aqorders.biblionumber=biblio.biblionumber LEFT JOIN biblioitems ON aqorders.biblionumber=biblioitems.biblionumber LEFT JOIN aqbooksellers ON aqbasket.booksellerid=aqbooksellers.id WHERE aqorders.ordernumber IN ( The result of this query is stored in hash refs. my $dataorders = $sthorders->fetchall_arrayref( {} ); But among the resulting columns there are aqorders.listprice and aqbooksellers.listprice. And the hash keys only consist of field names, without the table names, so one of them gets lost. So in Katrins example, it's really aqbooksellers.listprice that is displayed instead of aqorders.listprice, which is dropped. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:09:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:09:36 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:10:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:10:12 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #139 from Katrin Fischer --- Hi Christopher, thx for taking the time to confirm the problem in the current IE version! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:11:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:11:49 +0000 Subject: [Koha-bugs] [Bug 10618] Acq claim email not formatting correctly and missing information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12505 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:11:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:11:49 +0000 Subject: [Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10618 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:12:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:12:03 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #140 from Christopher Brannon --- (In reply to Katrin Fischer from comment #137) > I know I am biased here, but we have a library where this is the case. > I will hear back from them tomorrow about the exact browser version they > tested with. But I think between not officially supporting a browser and > making a whole module unusuable is quite a big step and we should at least > discuss this. This was a huge issue for our library when we moved to Koha. Being a city owned and managed library, we had to convince IT to let us use FF. They don't want to maintain multiple browsers, and they don't want to make the entire city change to FF because the library needs it for one application. I am sure this is a discussion for another place and another time, but IE comes with Windows and is a default (and sometimes only supported) browser in many places. Ignoring that doesn't make it go away. I have to agree with Katrin...leaving the module unusable in any browser is an issue. If it is cosmetics, that's one thing. But not unusable. We've had to address and correct issues with other browsers, and IE should be no different. Especially IE. That's my opinion. Sorry if this comes off too strong. It's been a harsh week so far. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:14:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:14:48 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #141 from Christopher Brannon --- I can confirm that tables fail to populate in Chrome as well, unless clicked on. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:15:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:15:18 +0000 Subject: [Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 --- Comment #2 from Owen Leonard --- > [3] At the same time, we announce that prog and CCSR will be removed in > 3.18. Done. > [4] The RM will assist in getting OPAC template patches in the pipeline > that were written for prog updated to support Bootstrap as well. Done? > [5] Starting with the 3.16, new OPAC patches should be targeted for > Bootstrap first. Done. > [6] During the 3.18 cycle, no patches will be pushed for prog except > insofar as they may be needed to fix security issues in the maintenance > releases. Done? > Before 3.18 is released, prog and CCSR will be taken out > entirely. Bug 12233. Can this bug be considered fixed and dependent bugs be made dependent on Bug 12233 instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:28:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:28:30 +0000 Subject: [Koha-bugs] [Bug 12511] New: Novelist Select not using https in bootstrap Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Bug ID: 12511 Summary: Novelist Select not using https in bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In prog we have: [% IF ( NovelistSelectProfile ) %] [% END %] but in bootstrap we have [% IF ( NovelistSelectProfile ) %] [% END %] Because bootstrap isn't using https, we get an error like this: [blocked] The page at 'https://koha.mylibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=105315&query_desc=kw%2Cwrdl%3A%20home' was loaded over HTTPS, but ran insecure content from 'http://imageserver.ebscohost.com/novelistselect/ns2init.js': this content should also be loaded over HTTPS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:28:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:28:49 +0000 Subject: [Koha-bugs] [Bug 12511] Novelist Select not using https in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:30:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:30:46 +0000 Subject: [Koha-bugs] [Bug 12511] Novelist Select not using https in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:30:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:30:48 +0000 Subject: [Koha-bugs] [Bug 12511] Novelist Select not using https in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 --- Comment #1 from Kyle M Hall --- Created attachment 29410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29410&action=edit Bug 12511 - Novelist Select not using https in bootstrap In prog we have: [% IF ( NovelistSelectProfile ) %] [% END %] but in bootstrap we have [% IF ( NovelistSelectProfile ) %] [% END %] Because bootstrap isn't using https, we get an error like this: [blocked] The page at 'https://koha.mylibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=105315&query_desc=kw%2Cwrdl%3A%20home' was loaded over HTTPS, but ran insecure content from 'http://imageserver.ebscohost.com/novelistselect/ns2init.js': this content should also be loaded over HTTPS. Test plan would require having a subscription to Novelist Select. I think this is trivial enough to go without. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:31:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:31:21 +0000 Subject: [Koha-bugs] [Bug 12511] Novelist Select not using https in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:33:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:33:33 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 --- Comment #6 from Gaetan Boisson --- Created attachment 29411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29411&action=edit Bug 11030 - Add 359, 947 and 969 fields in french unimarc_complete framework - followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:36:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:36:19 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 --- Comment #7 from Gaetan Boisson --- Created attachment 29412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29412&action=edit Bug 11030 : add fields 947,969,359 in unimarc_complete french framework This patch must be tested on top of bug 11021 This patch adds 3 fields to unimarc_complete french framework - 359 (2-a-b-c-d-e-f-g-h-i-p-u-v) used by Sudoc network, to be displayed in tab 3 - 947 (c) used by Electre - 969 (a-h) used by Electre I don't know the difference between 969a and 969h so I gave them quite the same name To test : 1) take a fresh Koha with unimarc marcflavor 2) in web installer, select french language, unimarc marflavor and "Grilles de catalogage compl?tes". 3) check default framework in Administration > MARC Frameworks : it should contains 359/947/969 fields Signed-off-by: Gaetan Boisson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:37:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:37:04 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21930|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:38:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:38:32 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29411|0 |1 is obsolete| | --- Comment #8 from Gaetan Boisson --- Created attachment 29413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29413&action=edit Bug 11030 - Add 359, 947 and 969 fields in french unimarc_complete framework - followup Signed-off-by: Gaetan Boisson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:41:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:41:46 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #142 from Christopher Brannon --- (In reply to Katrin Fischer from comment #132) > 1) In IE checking out books is broken. Under some circumstances, if you > checkout a book, it won't show up on the patron account. If it happens, it > doesn't matter how often you reload the page or switch tabs or whatever, it > won't show up. The number of checkouts on top of the tab changes and is > always correct. (Version: IE 9) It seems the problem is bigger than items not showing up for IE. In IE: - Check out 3 items. - Refresh the screen. You can't get an accurate table in IE without refreshing the page (F5). It doesn't matter if you navigate away from the patron and load the patron again. It is as if an ajax table won't even be touched unless the page is refreshed from the browser refresh button. (I don't claim to know anything about how the table is populated via ajax.) - Check the items in. - Now check the first item out. It loads the table that was showing all three items before. However, looking at the account from another browser shows that just the one item is checked out. You have to refresh the page in IE for the correct information to come up. Of course, you run into problems where it will resubmit checkouts and ask if you want to check it out again. :/ If this were just a cosmetic thing, I would be on the fence about it. But this needs to function properly, even in IE. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:42:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:42:03 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Gaetan Boisson --- I submitted a followup and marked as signed off as my first test was ok and i only wanted to add a very minor change in wording. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:49:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:49:37 +0000 Subject: [Koha-bugs] [Bug 12245] PROG/CCSR deprecation: Remove OPACMobileUserCSS system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12245 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |12233 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:49:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:49:37 +0000 Subject: [Koha-bugs] [Bug 12233] remove prog and CCSR OPAC themes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12233 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12245 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:49:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:49:43 +0000 Subject: [Koha-bugs] [Bug 12245] PROG/CCSR deprecation: Remove OPACMobileUserCSS system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12245 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:50:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:50:15 +0000 Subject: [Koha-bugs] [Bug 12245] PROG/CCSR deprecation: Remove OPACMobileUserCSS system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12245 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 17:50:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 15:50:20 +0000 Subject: [Koha-bugs] [Bug 12245] PROG/CCSR deprecation: Remove OPACMobileUserCSS system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12245 --- Comment #1 from Owen Leonard --- Created attachment 29414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29414&action=edit Bug 12245 - PROG/CCSR deprecation: Remove OPACMobileUserCSS system preference With CCSR now deprecated there is no longer a need for the OPACMobileUserCSS system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:04:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:04:46 +0000 Subject: [Koha-bugs] [Bug 12233] remove prog and CCSR OPAC themes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12233 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12246 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:04:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:04:46 +0000 Subject: [Koha-bugs] [Bug 12246] PROG/CCSR deprecation: Remove OpacMainUserBlockMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12246 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |12233 Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:05:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:05:15 +0000 Subject: [Koha-bugs] [Bug 12246] PROG/CCSR deprecation: Remove OpacMainUserBlockMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12246 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:05:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:05:17 +0000 Subject: [Koha-bugs] [Bug 12246] PROG/CCSR deprecation: Remove OpacMainUserBlockMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12246 --- Comment #1 from Owen Leonard --- Created attachment 29415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29415&action=edit Bug 12246 - PROG/CCSR deprecation: Remove OpacMainUserBlockMobile system preference With CCSR having been deprecated there is no longer a use for the OpacMainUserBlockMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:08:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:08:21 +0000 Subject: [Koha-bugs] [Bug 12512] New: PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Bug ID: 12512 Summary: PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 12233 The Bootstrap theme doesn't have a binary distinction between "desktop" and "mobile," so the OpacShowFiltersPulldownMobile system preference doesn't make sense to have anymore. With CCSR deprecated the OpacShowFiltersPulldownMobile system preference can be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:08:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:08:21 +0000 Subject: [Koha-bugs] [Bug 12233] remove prog and CCSR OPAC themes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12233 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12512 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:09:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:09:24 +0000 Subject: [Koha-bugs] [Bug 12233] remove prog and CCSR OPAC themes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12233 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12513 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:09:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:09:24 +0000 Subject: [Koha-bugs] [Bug 12513] New: PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12513 Bug ID: 12513 Summary: PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 12233 The Bootstrap theme doesn't have a binary distinction between "desktop" and "mobile," so the OpacShowLibrariesPulldownMobile system preference doesn't make sense to have anymore. With CCSR deprecated the OpacShowLibrariesPulldownMobile system preference can be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:13:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:13:43 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #143 from Katrin Fischer --- Hi Christopher, thx again for giving this more testing! I tried again in the old version and maybe there is some difference - for me the first item checks out ok (visible in table), but the second doesn't show up. Then hitting F5 or clicking on the reload icon doesn't help it. I just can't get the correct list to show. The only indication is the number in the tab description - that is always correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:22:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:22:53 +0000 Subject: [Koha-bugs] [Bug 12513] PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12513 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:22:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:22:56 +0000 Subject: [Koha-bugs] [Bug 12513] PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12513 --- Comment #1 from Owen Leonard --- Created attachment 29416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29416&action=edit Bug 12513 - PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference With CCSR having been deprecated there is no longer a use for the OpacShowLibrariesPulldownMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:31:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:31:57 +0000 Subject: [Koha-bugs] [Bug 12512] PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:32:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:32:01 +0000 Subject: [Koha-bugs] [Bug 12512] PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 --- Comment #1 from Owen Leonard --- Created attachment 29417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29417&action=edit Bug 12512 - PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference CCSR having been deprecated there is no longer a use for the OpacShowFiltersPulldownMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:33:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:33:11 +0000 Subject: [Koha-bugs] [Bug 11347] PROG/CCSR deprecation: Remove opacsmallimage system-preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:47:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:47:35 +0000 Subject: [Koha-bugs] [Bug 11347] PROG/CCSR deprecation: Remove opacsmallimage system-preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:47:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:47:39 +0000 Subject: [Koha-bugs] [Bug 11347] PROG/CCSR deprecation: Remove opacsmallimage system-preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 --- Comment #3 from Owen Leonard --- Created attachment 29418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29418&action=edit Bug 11347 - PROG/CCSR deprecation: Remove opacsmallimage system-preference The opacsmallimage system preference is unused in the bootstrap theme. It can be removed now that prog and ccsr are deprecated. This patch does so. To test, apply the patch and run updatedatabase. Confirm that the OPAC works properly and the preference can no longer be found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:48:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:48:03 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #66 from Kyle M Hall --- I don't think this should fail qa for not being a complete fix. A partial fix is better than no fix at all! Kyle (In reply to Christopher Brannon from comment #65) > Got the sandbox to work this time around. > > The limit works great for individually placed holds, but still gives no > warning and places holds over limit if holding multiple items. > > Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:52:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:52:33 +0000 Subject: [Koha-bugs] [Bug 10717] no way to sort search results in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10717 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Owen Leonard --- CCSR is now deprecated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:55:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:55:28 +0000 Subject: [Koha-bugs] [Bug 12514] New: Pressing 'print and confirm hold' on check in triggers race condition Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12514 Bug ID: 12514 Summary: Pressing 'print and confirm hold' on check in triggers race condition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Library has the following set for RESERVESLIP:

<>

Transfer to/Hold in <>


ITEM ON HOLD

<>

  • <>
  • <>
  • <>
  • <>

Notes:

<>

When an item filling a hold is checked in, the circ staff clicks the 'print and confirm' button. Borrower and biblio information is printed on the slip, but item and reserve information is not. If the circ staff re-scans the barcode for the item, the confirm hold dialog boxes will re-appear; clicking 'print and confirm' a second time will print correctly, because by that time the reserves record will be populated. All holds filled at this library process slowly enough to trigger this bug. Unlike bug 11621, this is *not* an intermittent condition. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:57:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:57:21 +0000 Subject: [Koha-bugs] [Bug 9542] link to regular site from ccsr mobile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9542 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Owen Leonard --- CCSR is now deprecated so I consider this "WONTFIX." It's possible that this same issue could be raised with regard to bootstrap, but I hope that because bootstrap offers more complete functionality at smaller sizes than CCSR did that there will not be a need for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 18:59:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 16:59:59 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 --- Comment #67 from Christopher Brannon --- (In reply to Kyle M Hall from comment #66) > I don't think this should fail qa for not being a complete fix. A partial > fix is better than no fix at all! > > Kyle > > (In reply to Christopher Brannon from comment #65) > > Got the sandbox to work this time around. > > > > The limit works great for individually placed holds, but still gives no > > warning and places holds over limit if holding multiple items. > > > > Christopher I respectfully disagree. You placed the multi-hold as a test condition. > 9) Attempt to place 3 or more holds as a multi-hold The patch does not pass your test. If the patch is only to test items placed on hold one at a time, then it works just fine. I don't think this should pass, based on your parameters. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:03:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:03:34 +0000 Subject: [Koha-bugs] [Bug 9195] nav overlaps lists in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9195 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #10 from Owen Leonard --- This is a customization issue which is probably also present in bootstrap but I don't think the solution is a change to the OPAC's template or CSS. I think it's probably better addressed on a case-by-case basis. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:05:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:05:57 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:07:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:07:16 +0000 Subject: [Koha-bugs] [Bug 9829] Star ratings broken in CCSR search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9829 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:07:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:07:16 +0000 Subject: [Koha-bugs] [Bug 9197] opacnav shows below tabs on opac-user.pl in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9197 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:07:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:07:16 +0000 Subject: [Koha-bugs] [Bug 9934] OPAC info tooltip doesn't appear in CCSR theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9934 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:07:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:07:16 +0000 Subject: [Koha-bugs] [Bug 10122] jQueryUI tabs on my summary page not highlighted in CCSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10122 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:07:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:07:16 +0000 Subject: [Koha-bugs] [Bug 9194] browse search aligned funny in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9194 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:07:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:07:17 +0000 Subject: [Koha-bugs] [Bug 10228] cart and list download/email background sloppy in CCSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10228 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:07:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:07:16 +0000 Subject: [Koha-bugs] [Bug 9199] comments template could use some clean up in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9199 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:07:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:07:17 +0000 Subject: [Koha-bugs] [Bug 9601] ccsr opac no results found ugly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9601 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:13:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:13:18 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #144 from Kyle M Hall --- Created attachment 29419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29419&action=edit Bug 11703 [QA Followup] - Stop IE from caching ajax request -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:17:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:17:24 +0000 Subject: [Koha-bugs] [Bug 9558] Customize CSS for mobile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9558 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #6 from Owen Leonard --- CCSR is now deprecated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:17:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:17:24 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:19:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:19:56 +0000 Subject: [Koha-bugs] [Bug 11306] Login bar over news in Mobile CCSR OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11306 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 10722 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:19:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:19:56 +0000 Subject: [Koha-bugs] [Bug 10722] The log in bar "Log in to your account" floats incorrectly in the middle of the page on iPhone In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10722 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #3 from Owen Leonard --- *** Bug 11306 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:21:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:21:10 +0000 Subject: [Koha-bugs] [Bug 10722] CCSR log in bar floats incorrectly in the middle of the page on iPhone In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10722 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 Summary|The log in bar "Log in to |CCSR log in bar floats |your account" floats |incorrectly in the middle |incorrectly in the middle |of the page on iPhone |of the page on iPhone | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:26:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:26:38 +0000 Subject: [Koha-bugs] [Bug 12189] Untranslatable page title in print slip template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12189 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:30:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:30:46 +0000 Subject: [Koha-bugs] [Bug 10469] display more in frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469 --- Comment #1 from Owen Leonard --- Does this bug refer to the process of editing a subfield structure? /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=XXX&frameworkcode=XXX If so I agree. I don't know why we couldn't just show the whole form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 19:55:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 17:55:37 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #145 from Kyle M Hall --- Created attachment 29420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29420&action=edit Bug 11703 [QA Followup] - Allow keyboard navigation of tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 20:14:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 18:14:13 +0000 Subject: [Koha-bugs] [Bug 4463] Expose {AMAZONASSOCID} for usage in things like "More Searches" just like {TITLE}. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4463 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |master Depends on| |4460 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 20:14:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 18:14:13 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon's AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4463 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 20:25:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 18:25:11 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #146 from Christopher Brannon --- Kyle, Thanks for addressing both issues Katrin brought up so quickly. Looks great in IE11. :) As a side note, there is only a couple cosmetic things I have a comment about. When the checkout tab is being loaded, the table reads: "No data available in table" When the holds tab is being loaded, it reads: "Loading..." I like the "Loading...". Could you do that for any other tables? Also, I notice that printing a slip prints current, up-to-date information, despite what the table might be currently showing (i.e. someone checked in an item from the book drop in the back room). Do you think this might lead to confusion? I'm wondering if the tables should be updated if information is being printed, for more consistency. Just a thought. Other than those things, it is looking really good. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 20:58:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 18:58:48 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 21:48:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 19:48:39 +0000 Subject: [Koha-bugs] [Bug 12422] Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12422 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 11663 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 21:48:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 19:48:39 +0000 Subject: [Koha-bugs] [Bug 11663] Bootstap theme opac holding tab improperly displayed when opacbookbag syspref is disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #7 from Owen Leonard --- *** Bug 12422 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 1 23:24:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 21:24:04 +0000 Subject: [Koha-bugs] [Bug 12468] copyright symbol not translating right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12468 Larry Baerveldt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larry at bywatersolutions.com --- Comment #3 from Larry Baerveldt --- I suspect this bug may affect OCLC Connexion imports as well. We have records of several imports failing with this error in intranet-error.log: import_bib: "\\x{00a9}" does not map to utf8 at /var/lib/koha/coos/kohaclone/svc/import_bib line 55. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 00:14:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 22:14:54 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #128 from Heather Braum --- Kyle, did you see Christopher's comments/concerns? Otherwise, I'd also be happy to sign off on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 00:17:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 22:17:19 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA CC| |liz at catalyst.net.nz --- Comment #6 from Liz Rea --- I confirm that this fixes this issue, and also fixes another issue with syspref setting in IE9. I don't think I personally mind if this patch gets superseded in the future, I'd like to see it in. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 01:27:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jul 2014 23:27:25 +0000 Subject: [Koha-bugs] [Bug 12511] Novelist Select not using https in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Chris Rohde changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |crohde at roseville.ca.us --- Comment #2 from Chris Rohde --- We have NoveList Select, are running Bootstrap, on an https server. The patch works on our server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 04:53:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 02:53:30 +0000 Subject: [Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443 --- Comment #13 from David Cook --- PSA on truncation with Zebra: It appears that the @truncation directive in ccl.properties doesn't work in versions before Yaz 4.2.21 (going back to an indeterminate time). "yaz-client -V" will tell you what version of Yaz you have. Debian Squeeze uses Yaz 4.0.11-1 Debian Wheezy uses Yaz 4.2.30 So...if you're on Wheezy, you're probably fine. If you're on Squeeze, your @truncation directive isn't working, which means the truncation character is the default "?" no matter what you put in ccl.properties. It does appear that you can provide multiple truncation characters based on the reference to "truncation_aliases" in the following code though: http://www.indexdata.com/yaz/dox/html/cclfind_8c_source.html --- 4.2.21 2011/11/23 Fix cql_sortby_to_sortkeys. Completely broken before. Make CCL's @truncation work again. Source: http://www.indexdata.com/yaz/doc/NEWS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:19:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:19:03 +0000 Subject: [Koha-bugs] [Bug 12431] Relevance does not work properly when using QueryParser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12431 --- Comment #2 from David Cook --- The following references should probably be either removed or have 2: 102 commented out. This adds relevance to the entire query, which is probably not what we want to do, since adding relevance to a query containing date indexes/sub-queries causes unexpected results or no results for that date sub-query. If we do a callnumber search, we might also get distorted results where records with lots of items with that callnumber undesirably rise to the top. relevance: bib1_mapping: biblioserver: 2: 102 enabled: 1 label: Relevance relevance_dsc: bib1_mapping: biblioserver: 2: 102 enabled: 1 label: Relevance_dsc relevance_asc: bib1_mapping: biblioserver: 2: 102 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:37:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:37:12 +0000 Subject: [Koha-bugs] [Bug 12508] The removal of a contract which is linked to a basket does not display an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Juhani Sepp?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jseppal at student.uef.fi --- Comment #2 from Juhani Sepp?l? --- Hi, I tested this first without the patch and confirmed the behaviour (usability issue). Trying to remove a contract pre-patch is pretty confusing, much clearer after this patch - I'm signing off. On succesful contract removal: would it be against the guidelines to have a success message here (e.g. "contract removed succesfully")? Currently it's a bit vague. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:39:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:39:37 +0000 Subject: [Koha-bugs] [Bug 12515] New: Partial receive status not correctly populated on updating from older Koha version Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12515 Bug ID: 12515 Summary: Partial receive status not correctly populated on updating from older Koha version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Filing this quickly, before I forget, some more testing needed: I just updated an old database dump to recent Koha in order to do some acquisition testing. The dump was from a version before the aqorders.orderstatus column existed. The database update created the column and set the status for all orders. This seems to work nicely, with the exception of partial orders. After updating, the partially unreceived orders have the status "ordered" instead of "partial". The parent_ordernumber is correctly set to the parent order with the received items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:40:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:40:59 +0000 Subject: [Koha-bugs] [Bug 12508] The removal of a contract which is linked to a basket does not display an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Juhani Sepp?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29392|0 |1 is obsolete| | --- Comment #3 from Juhani Sepp?l? --- Created attachment 29421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29421&action=edit Bug 12508: adding an error message if a contract cannot be removed If a contract cannot be removed, no errors is displayed. Now, it displays an dialog messag error and the list of contracts. Test plan: 1) Log on with a superlibrarian permission 2) Go on the page acqui/supplier.pl (Acquisitions > Button "New vendor") 3) Record a vendor with a nonzero "name" 4) Go on the page admin/aqcontract.pl (click on the "Contracts" item in the menu) 5) Click on the button "New" > "Contract" and record a new one 6) Click on "New" > "Basket" and record a basket by selectioning the created contract 7) Click on the contract name, then click on the "Contracts" item in the left menu 8) Try to delete this contract, an error is displayed : "Contract has not been deleted. Maybe a basket linked to this contract exists." 9) Delete the basket linked to the contract 10) Delete the contract, no errors is displayed Signed-off-by: Juhani Sepp?l? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:55:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:55:09 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #34 from Katrin Fischer --- Created attachment 29422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29422&action=edit [PASSED QA] Bug 12164: Move the budget period clone logic into C4::Budgets Note the typo InsertInTable "aqcudgets", note sure about the existing behavior before this patch! This patch adds a link "Duplicate" in the action list for budget periods (budgets). Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:55:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:55:12 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #35 from Katrin Fischer --- Created attachment 29423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29423&action=edit [PASSED QA] Bug 12164: On cloning budget period, mark original budget as inactive This patch adds a checkbox "mark original budget as inactive" (budget period). If it is checked, the original budget will be marked as inactive. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:55:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:55:16 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #36 from Katrin Fischer --- Created attachment 29424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29424&action=edit [PASSED QA] Bug 12164: On cloning budget periods, add a "reset all funds" option This patch adds a checkbox "reset all funds" (budgets). If it is checked, the new created budgets (funds) will be reset. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:55:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:55:20 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #37 from Katrin Fischer --- Created attachment 29425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29425&action=edit [PASSED QA] Bug 12164: Close a budget period (budget) This is the main patch. On closing a budget period, all unreceived orders are moved from the old/previous fiscal year into the new fiscal year. You can rollover funds unused in the previous fiscal year to the new fiscal year. This patch set is based on bug 12168 (bugfix) and can be tested on top of bug 11578 (easier to see the fund structure). The patch set is cut in 6 main patches: - Move the budget period clone logic into C4::Budgets The code is moved from the pl to Budgets.pm and unit tests are provided. The original code should certainly be buggy since a typo existed. - On cloning budget period, mark original budget as inactive Cloning a budget period is already possible in Koha, this patch adds a checkbox to mark as inactive the original budget. That avoids to edit the budget and click the "inactive" checkbox. Both do the same action. - On cloning budget periods, add a "reset all funds" option Same as before, a new checkbox is added on cloning a budget period. If you check it, all fund amounts will be set to 0. Otherwise, no change compared to the existing behavior. - Close a budget period (budget) The goal of this patch set is to move unreceived orders from a budget to another. This patch adds a C4::Budgets::MoveOrders routine which does this job. This action is only possible if the fund structure is the same for both budgets, the budget_code field should be the same. - On closing budget period, move unspent amount Unspent amount will be move from the previous budget structure to the new one. - Add UI report This patch only adds a report when closing a budget is done. Test plan: Wording: below, budget is a "budget period" and fund is a "budget". Prerequisite: Having 1 active budget with some funds (with different levels and different amounts). Order and receive some orders (not all). 1/ Go on the budgets administration page (admin/aqbudgetperiods.pl) and duplicate the structure of this budget ("Duplicate" link in the "Actions" column). 2/ Enter start and end date for this budget and mark the original budget as inactive. 3/ Note that a new budget is created, with the same fund structures (and same value) and that the old one is marked as inactive (see admin/aqbudgets.pl page with patches from bug 11578). 4/ Try to close the new budget: it is not possible, there is no unreceived orders for this budget. 5/ You can close the inactive budget ("Close" link in the "Actions" column). 6/ Verify the number of "Unreceived orders" is correct and select the new budget in the budget list. Click on the "Move remaining unspent funds" if you want to move unspent amounts. 7/ A report view is displayed and show you the ordernumber which have been impacted (grouped by fund). 8/ Try different configuration, depending on the selected checkboxes. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:55:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:55:23 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #38 from Katrin Fischer --- Created attachment 29426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29426&action=edit [PASSED QA] Bug 12164: On closing budget period, move unspent amount On closing a budget (budget period), the user will be presented with an option to move remaining unspent funds from the previous budget to the newly created one - adding to the amounts already entered in those funds. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:55:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:55:26 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #39 from Katrin Fischer --- Created attachment 29427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29427&action=edit [PASSED QA] Bug 12164: Add UI report Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:55:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:55:30 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #40 from Katrin Fischer --- Created attachment 29428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29428&action=edit [PASSED QA] Bug 12164: follow-up: various fixes This follow-up fixes issues raised on bug 12164 comment 17. 1/ The unreceived orders columns should only display "pending" orders 2/ Fix some typo from_budget_period_id vs budget_period_id vs to_budget_period_id Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:55:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:55:33 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #41 from Katrin Fischer --- Created attachment 29429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29429&action=edit [PASSED QA] Bug 12164: Fix some typos Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:55:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:55:37 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #42 from Katrin Fischer --- Created attachment 29430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29430&action=edit [PASSED QA] Bug 12164: Fix decimal number display If the funds are not moved, the amount is display like 123.000000. This patch hardcodes the number of decimal numbers to display (2). Signed-off-by: Katrin Fischer Passes QA script and tests, especially all acquisition tests. New routines in Budgets.pm: - CloneBudgetPeriod - CloneBudgetHierarchy - MoveOrders OK t/db_dependent/Budgets.t Some of the tests done: 1) Duplicate an existing budget - OK Existing budget is active, duplicate it and mark it inactive - OK Existing budget is inactive, duplicate and mark it inactive 2) Close budget - OK Budget was created without funds - no changes are made - OK Budget was created with funds, all orders moved correctly - moving the available money to the new budget is optional - OK Budget was created with funds, but one fund deleted, all orders moved correctly, one missing fund reported, orders unchanged 3) Partial receiced undone - OK Partial receive from last budget is undone, order lines are correctly recombined and fund is set to the current budget -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:57:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:57:43 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:57:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:57:45 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28704|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:57:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:57:47 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28705|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:57:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:57:49 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28706|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:57:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:57:52 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28707|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:57:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:57:54 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28708|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:57:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:57:56 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29355|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:57:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:57:58 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29356|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:58:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:58:01 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28702|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:58:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:58:03 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28703|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 08:58:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 06:58:39 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #43 from Katrin Fischer --- Nice new feature! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 09:14:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 07:14:58 +0000 Subject: [Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443 --- Comment #14 from David Cook --- More thoughts on C4::Search::buildQuery and Koha::QueryParser... C4::Search::buildQuery: PRO: Right/left/right&&left truncation, QueryFuzzy appears to work, QueryWeightFields works (except when QueryAutoTruncate is on), QueryStemming works with wordlists. CON: No support for phrases, lots of ugly spaghetti code which is mutually exclusive, incorrectly defines variables, etc. FUTURE: Planning to integrate "QueryWeightFields", "QueryFuzzy", "QueryAutoTruncate", and "QueryStemming" into _build_initial_query(). "QueryWeightFields" and "QueryFuzzy" could be improved. "QueryStemming" is a tough one...as it really is only useful for Word Lists...so we'll have to check the structure and make sure there are no quotation marks sneaking in as they'll cause problems. That should work all right. -- Koha::QueryParser: PRO: Automatically detects phrases, automatically detects right truncation. "Koha::QueryParser::Driver::PQF::query_plan::node" already uses "QueryAutoTruncate", some "QueryWeightFields"-like functionality (which needs a more configuration and possibly some code tweaks). CON: No left truncation, no left && right truncation, no easy way to designate a phrase (except by wrapping in quotes or by providing an alias) FUTURE: "Koha::QueryParser::Driver::PQF::query_plan::node" could make it easy to add "QueryStemming" and "QueryFuzzy". We could also add support for left truncation and left && right truncation using that same module. Improve relevance bumps (aka QueryWeightFields functionality) in queryparser.yaml. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 09:18:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 07:18:07 +0000 Subject: [Koha-bugs] [Bug 12499] The module C4::Letters.t needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12499 Yohann Dufour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 09:18:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 07:18:09 +0000 Subject: [Koha-bugs] [Bug 12499] The module C4::Letters.t needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12499 --- Comment #1 from Yohann Dufour --- Created attachment 29431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29431&action=edit Bug 12499: adding units tests for C4::Letters The tests for the subroutines : GetMessageTransportType, EnqueueLetter, SendQueuedMessages, GetQueuedMessages, GetLetters, getletter, addalert, getalert, delalert and GetPreparedLetter of the module C4::Letters have been added. Test plan: 1) Apply the patch 2) Execute the unit tests by launching : prove t/db_dependent/Letters.t 3) The result has to be a success without error or warning : t/db_dependent/Letters.t .. ok All tests successful. Files=1, Tests=45, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.44 cusr 0.08 csys = 1.57 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 09:26:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 07:26:15 +0000 Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 --- Comment #44 from Fridolin SOMERS --- All this needs to be considered in the QueryParser. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 09:45:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 07:45:39 +0000 Subject: [Koha-bugs] [Bug 12516] New: The module C4::Tags needs more unit tests Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516 Bug ID: 12516 Summary: The module C4::Tags needs more unit tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: yohann.dufour at biblibre.com QA Contact: gmcharlt at gmail.com Some subroutines of the module C4::Tags are not tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 09:45:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 07:45:48 +0000 Subject: [Koha-bugs] [Bug 12516] The module C4::Tags needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516 Yohann Dufour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |yohann.dufour at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 09:48:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 07:48:26 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #147 from Jonathan Druart --- Last 2 patches need a signoff, I'm changing the status according that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 11:22:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 09:22:54 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 11:22:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 09:22:59 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29419|0 |1 is obsolete| | Attachment #29420|0 |1 is obsolete| | --- Comment #148 from Katrin Fischer --- Created attachment 29432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29432&action=edit [SIGNED OFF] Bug 11703 [QA Followup] - Stop IE from caching ajax request Signed-off-by: Britta Cramer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 11:23:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 09:23:15 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #149 from Katrin Fischer --- Created attachment 29433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29433&action=edit [SIGNED OFF] Bug 11703 [QA Followup] - Allow keyboard navigation of tabs Signed-off-by: Britta Cramer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 12:39:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 10:39:21 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #3 from Barton Chittenden --- I have replicated this issue at a partner's library, in this case the full search showed both books and audio disks available. When the 'limit to available' facet is selected, only available audio books are returned by the search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 12:46:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 10:46:06 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 --- Comment #4 from Barton Chittenden --- Examples from OPAC: Search for "Alex+Rider+Horowitz" shows records of type "book" and "sound", both available and un-available. http://catalog.losgatosca.gov/cgi-bin/koha/opac-search.pl?q=Alex+Rider+Horowitz Clicking "Limit to currently available items." Shows only available items of type "sound". http://catalog.losgatosca.gov/cgi-bin/koha/opac-search.pl?idx=kw&q=Alex%20Rider%20Horowitz&sort_by=relevance_dsc&limit=available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 13:12:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 11:12:20 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #150 from Kyle M Hall --- Created attachment 29434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29434&action=edit Bug 11703 [QA Followup] - Change "No data available in table" to "Loading..." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 13:13:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 11:13:54 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #151 from Kyle M Hall --- (In reply to Christopher Brannon from comment #146) > When the checkout tab is being loaded, the table reads: "No data available > in table" > > When the holds tab is being loaded, it reads: "Loading..." > > I like the "Loading...". Could you do that for any other tables? I have added a followup for this. > Also, I notice that printing a slip prints current, up-to-date information, > despite what the table might be currently showing (i.e. someone checked in > an item from the book drop in the back room). Do you think this might lead > to confusion? I'm wondering if the tables should be updated if information > is being printed, for more consistency. Just a thought. This is no less in issue with Koha currently than it is with these patches. This is definitely outside the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 14:35:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 12:35:27 +0000 Subject: [Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira at inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 14:51:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 12:51:51 +0000 Subject: [Koha-bugs] [Bug 12468] copyright symbol not translating right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12468 --- Comment #4 from Owen Leonard --- (In reply to Nicole C. Engard from comment #2) > For testing you can use ISBN: 9781451695182 That ISBN will return a variety of records depending on the Z39.50 source. I've run into what looks like the same issue though. I'm seeing stuff like this in some MARC records we get from OCLC: =264 \4$c�2001 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 14:58:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 12:58:17 +0000 Subject: [Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from simith.doliveira at inlibro.com --- *** Bug 10618 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 14:58:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 12:58:17 +0000 Subject: [Koha-bugs] [Bug 10618] Acq claim email not formatting correctly and missing information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10618 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |simith.doliveira at inlibro.co | |m Resolution|--- |DUPLICATE --- Comment #3 from simith.doliveira at inlibro.com --- *** This bug has been marked as a duplicate of bug 12505 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:08:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:08:04 +0000 Subject: [Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Kyle M Hall --- The issue is that the extra message is incorrect! However, I think maybe my first patch was too aggressive. I'm going to file a new patch that only affects the "Too many holds" and "No items are available" sections. (In reply to Katrin Fischer from comment #7) > I am not sure about this patch - if there are multiple reasons why a hold is > not possible, should we not display all of them instead of giving one reason > preference of another? It seems like this patch will make the error message > less accurate (elsif instead of if)? > > + [% ELSIF ( maxreserves ) %] > +
  • Too many holds: href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber > %]">[% borrowerfirstname %] [% borrowersurname %] has too many > holds.
  • > + [% ELSIF ( alreadyreserved ) %] > +
  • href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber > %]">[% borrowerfirstname %] [% borrowersurname %] already has a > hold on this item
  • > + [% ELSIF ( alreadypossession ) %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:08:20 +0000 Subject: [Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:08:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:08:22 +0000 Subject: [Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29342|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 29435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29435&action=edit Bug 10912 - Streamline hold error messages in staff interface Right now, if a patron cannot place a hold on any items on a record, the error in the staff intranet looks like this: Cannot place hold Too Many Holds: Kyle Hall has too many holds. No copies are available to be placed on hold This can confuse some librarians, because the reason the patron cannot place the hold is not because the patron has too many holds, but only because there are no copies available. Test Plan: 1) Apply this patch 2) Set the number of holds allowed to 1 3) Disable AllowOnShelfHolds 4) Place a hold for a patron 5) Attempt to place a second hold for the patron 6) You should see the "Too many holds" message 7) Set the number of holds allowed to 2 8) Repeat 5, you should be allowed to place the hold, but don't 9) Attempt to place a hold on a record with only checked in items 10) You should get a "No items are available" message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:09:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:09:22 +0000 Subject: [Koha-bugs] [Bug 12517] New: Download and send list popups broken in bootstrap OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Bug ID: 12517 Summary: Download and send list popups broken in bootstrap OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org In the bootstrap OPAC the download list and send list links do not trigger the correct popups because of a JavaScript error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:09:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:09:31 +0000 Subject: [Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29435|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 29436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29436&action=edit Bug 10912 - Streamline hold error messages in staff interface Right now, if a patron cannot place a hold on any items on a record, the error in the staff intranet looks like this: Cannot place hold Too Many Holds: Kyle Hall has too many holds. No copies are available to be placed on hold This can confuse some librarians, because the reason the patron cannot place the hold is not because the patron has too many holds, but only because there are no copies available. Test Plan: 1) Apply this patch 2) Set the number of holds allowed to 1 3) Disable AllowOnShelfHolds 4) Place a hold for a patron 5) Attempt to place a second hold for the patron 6) You should see the "Too many holds" message 7) Set the number of holds allowed to 2 8) Repeat 5, you should be allowed to place the hold, but don't 9) Attempt to place a hold on a record with only checked in items 10) You should get a "No items are available" message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:14:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:14:38 +0000 Subject: [Koha-bugs] [Bug 12517] Download and send list popups broken in bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:14:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:14:40 +0000 Subject: [Koha-bugs] [Bug 12517] Download and send list popups broken in bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 --- Comment #1 from Owen Leonard --- Created attachment 29437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29437&action=edit Bug 12517 - Download and send list popups broken in bootstrap OPAC A JavaScript error prevents the download list and send list links in the bootstrap OPAC from functioning correctly. A variable declaration was removed from basket.js during the creation of the theme but opac-shelves.tt was not changed accordingly. This patch corrects it. To test, view an existing shelf in the bootstrap OPAC and test the "download list" and "send list" links. They should each trigger popups without any errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:24:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:24:10 +0000 Subject: [Koha-bugs] [Bug 12489] Ajax checkout table: no "loading..." popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12489 --- Comment #1 from Jonathan Druart --- Actually it's not "Loading..." but "Processing...". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:41:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:41:23 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:41:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:41:28 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #152 from Jonathan Druart --- Created attachment 29438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29438&action=edit Bug 11703 [QA Followup] - Stop IE from caching ajax request Signed-off-by: Britta Cramer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:41:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:41:37 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #153 from Jonathan Druart --- Created attachment 29439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29439&action=edit Bug 11703 [QA Followup] - Allow keyboard navigation of tabs Signed-off-by: Britta Cramer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:41:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:41:44 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29434|0 |1 is obsolete| | --- Comment #154 from Jonathan Druart --- Created attachment 29440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29440&action=edit Bug 11703 [QA Followup] - Change "No data available in table" to "Loading..." Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:43:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:43:17 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #155 from Jonathan Druart --- I did not found any regression with the 3 last patches (using FF). I don't have any IE versions to test if they fix the described issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 15:49:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 13:49:48 +0000 Subject: [Koha-bugs] [Bug 12518] New: gather_print_notices.pl doesn't respect hold/reserve pickup location Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12518 Bug ID: 12518 Summary: gather_print_notices.pl doesn't respect hold/reserve pickup location Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org Created attachment 29441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29441&action=edit Initial commit from our issue tracker. gather_print_notices.pl gathers HOLD-letters based on the borrowers' homebranch. Our librarians find it hard to send hold notices for Items present in other branches. This patch gathers print notices for HOLD-letter_code to the Items' reserves.branchcode (pickup location) instead. This is achieved by using a customizable regexp in the gather_print_notices-script, which picks the barcode from the letter content. --------------- -- TEST PLAN -- --------------- 0. Have a HOLD-letter template with each Items' barcodes somewhere, for ex. Barcode: <> 1. Create a reservation for a borrower with no other message delivery option than printing. Set the pickup location to other (branch P) than the borrowers homebranch (branch H). 2. Check the item in and confirm reservation. This enques a letter in the message_queue-table. 3. run the gather_print_notices.pl -cronjobs with the following parameters gather_print_notices.pl --split --holdbarcode 'Barcode: (\S+)
    ' You will find the letter generated to the branch P, instead of the branch H if you hadn't used the --holdbarcode -parameter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:18:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:18:43 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #134 from Kyle M Hall --- Created attachment 29442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29442&action=edit Bug 9811 [QA Followup] - Enable bProcessing It's a bit disconcerting to not have any feedback while paging through the patrons. Enabling bProcessing helps resolve that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:19:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:19:23 +0000 Subject: [Koha-bugs] [Bug 12517] Download and send list popups broken in bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29437|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 29443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29443&action=edit [SIGNED-OFF] Bug 12517 - Download and send list popups broken in bootstrap OPAC A JavaScript error prevents the download list and send list links in the bootstrap OPAC from functioning correctly. A variable declaration was removed from basket.js during the creation of the theme but opac-shelves.tt was not changed accordingly. This patch corrects it. To test, view an existing shelf in the bootstrap OPAC and test the "download list" and "send list" links. They should each trigger popups without any errors. Signed-off-by: Bernardo Gonzalez Kriegel Popups pops again, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:19:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:19:36 +0000 Subject: [Koha-bugs] [Bug 12517] Download and send list popups broken in bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:28:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:28:45 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |sandboxes at biblibre.com --- Comment #156 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:29:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:29:52 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29279|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:30:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:30:00 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29280|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:30:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:30:09 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:30:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:30:17 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29282|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:30:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:30:27 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29283|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:30:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:30:40 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29284|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:30:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:30:48 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29432|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:30:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:30:55 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29433|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:31:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:31:03 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29438|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:31:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:31:11 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29439|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:31:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:31:19 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29440|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:31:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:31:51 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #157 from sandboxes at biblibre.com --- Created attachment 29444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29444&action=edit Bug 11810: Input fields in OPAC suggestion form are a bit short (Bootstrap) The default Bootstrap input size (absent any specific input size or class) is too short for the suggestion form. This patch adds a Bootstrap class to fields which need more room and adjusts the OPAC CSS to allow for better handling of input width at lower screen widths. To test apply the patch and clear your browser cache if necessary. Open the "new suggestion" form in the OPAC and confirm that the entry fields for title, author, publisher, and collection title are sized well. Adjust the width of your browser window up and down to confirm that the field sizes adjust well at various screen widths. Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Works nicely, no problems found. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:31:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:31:58 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #158 from sandboxes at biblibre.com --- Created attachment 29445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29445&action=edit Bug 11810: (followup) regenerate CSS due to conflict Signed-off-by: Tomas Cohen Arazi Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:32:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:32:05 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #159 from sandboxes at biblibre.com --- Created attachment 29446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29446&action=edit Bug 11703 - Convert checkouts table to ajax datatable When a patron has many checked out items, circulation.pl can take a very long time to load ( on the order of minutes in some cases ). This is primarily due to the processing of the previous checkouts list. If we convert to this table to a datatable that fetches its data via ajax, we can make circulation.pl far more responsive. The same should be done with relative's checkouts as well. Test Plan: 1) Apply this patch 2) Observe that the checkouts and relatives' checkouts tables are now loaded asynchronously 3) Observe and verify the renew and return actions are now ajax based and function in a manner equivilent to how they used to. This bug had quite a few followups, so I squashed all of them into one change so that code is easier to follow. Original commit messages are below: Bug 11703 - Use the ajax datatables on patron details page Bug 11703 - Convert holds tables to ajax datatables Bug 11703 [QA Followup 1] - Center bProcessing message over table Bug 11703 [QA Followup 2] - Remove icons from checkout and clear buttons Bug 11703 [QA Followup 3] - Remove references to UseTablesortForCirc Bug 11703 [QA Followup 4] - Add back in Today's checkouts/Previous checkouts rows Bug 11703 [QA Followup 5] Bug 11703 [QA Followup 6] - Move strings to an include file for translation purposes Bug 11703 [QA Followup 7] - Fix issues spotted by koha-qa.pl Bug 11703 [QA Followup 8] - Speed up api/checkouts.pl as much as possible Bug 11703 [QA Followup 9] - Move scripts from api directory to svc directory Bug 11703 [QA Followup 10] - Fix errors caused by rebase Bug 11703 [QA Followup 11] - Prevent multiple fetchs from ajax source Bug 11703 [QA Followup 12] - Fix problem detected by koha-qa.pl Bug 11703 [QA Followup 13] - Removed uneccessary data from renewal box during renewal Bug 11703 [QA Followup 14] - Fix table column span Signed-off-by: Dobrica Pavlinusic Signed-off-by: Katrin Fischer Passes all tests and QA script. Test plan on bug report: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703#c98 Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:32:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:32:10 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #160 from sandboxes at biblibre.com --- Created attachment 29447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29447&action=edit Bug 11703 [QA Followup] * Bold record title, fix table width * Change output_pref_due to output_pref * Retain functionality of IssuesDefaultSortOrder system preferences * Use datatables.inc in circulation.tt * Fix up holds table details * Add plugin to about * fix relatives' checkouts * add too_many string * remove dead syspref from db * Sort relatives' checkouts and holds tables client side * Provide context for translation of strings * Fix unterminated string literal, add missing paren * Add replacement of _AUTHOR_ with title's author for holds * Format prices correctly * Format checkout dates correctly Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:32:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:32:15 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #161 from sandboxes at biblibre.com --- Created attachment 29448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29448&action=edit Bug 11703 [QA Followup] - Use format instead of replace for string translation Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:32:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:32:20 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #162 from sandboxes at biblibre.com --- Created attachment 29449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29449&action=edit Bug 11703 [QA Followup] - Use interface instead of themelang for checkboxes plugin Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:32:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:32:25 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #163 from sandboxes at biblibre.com --- Created attachment 29450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29450&action=edit Bug 11703 [QA Followup] - Restore showing earliest renewal date for 'too early' renewals Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:32:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:32:31 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #164 from sandboxes at biblibre.com --- Created attachment 29451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29451&action=edit Bug 11703: (qa-followup) fix update database entry Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:32:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:32:36 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #165 from sandboxes at biblibre.com --- Created attachment 29452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29452&action=edit Bug 11703 [QA Followup] - Stop IE from caching ajax request Signed-off-by: Britta Cramer Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:32:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:32:40 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #166 from sandboxes at biblibre.com --- Created attachment 29453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29453&action=edit Bug 11703 [QA Followup] - Allow keyboard navigation of tabs Signed-off-by: Britta Cramer Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:32:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:32:45 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #167 from sandboxes at biblibre.com --- Created attachment 29454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29454&action=edit Bug 11703 [QA Followup] - Change "No data available in table" to "Loading..." Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:34:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:34:26 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|unspecified |master Assignee|kohapatch at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:50:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:50:52 +0000 Subject: [Koha-bugs] [Bug 12499] The module C4::Letters.t needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12499 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29431|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 29455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29455&action=edit [SIGNED-OFF] Bug 12499: adding units tests for C4::Letters The tests for the subroutines : GetMessageTransportType, EnqueueLetter, SendQueuedMessages, GetQueuedMessages, GetLetters, getletter, addalert, getalert, delalert and GetPreparedLetter of the module C4::Letters have been added. Test plan: 1) Apply the patch 2) Execute the unit tests by launching : prove t/db_dependent/Letters.t 3) The result has to be a success without error or warning : t/db_dependent/Letters.t .. ok All tests successful. Files=1, Tests=45, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.44 cusr 0.08 csys = 1.57 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel All test pass, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 16:51:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 14:51:08 +0000 Subject: [Koha-bugs] [Bug 12499] The module C4::Letters.t needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12499 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 17:09:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 15:09:07 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Julian Maurice --- By "both translated", you mean you have translated the string in fr-FR-messages.po and es-ES-messages.po ? I just retried, applying patches on current master, and the translation works for me. Can you look at the log file ? Maybe there's a clue in it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 17:24:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 15:24:52 +0000 Subject: [Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 --- Comment #12 from Nick Clemens --- Hi Kyle, I want to test this but I cannot produce the original error in master. If I try to place a hold on an item with no defined rules I can get the "Too many/no available" message, adding a rule that states number of allowed holds gets rid of the 'Too Many' With this patch I do see only one message, but the 'too many' seems valid if I don't have any rules defined. Can you let me know if you can reproduce this? Thanks, Nick Tangent: I thought this was related to us seeing "Too many holds" in VOKAL, however we only get that one message even though rules are defined for all categories but playing in master, I cannot get any warning boxes if I turn on 'AllowHoldsOverride' and our system has that on so I don't know if something changed there too. Been puzzling over recreating the error we see but I am guessing it was already fixed in master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 18:04:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 16:04:44 +0000 Subject: [Koha-bugs] [Bug 12519] New: Convert list download pop-up to modal dialog Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12519 Bug ID: 12519 Summary: Convert list download pop-up to modal dialog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The list download process could happen inside a modal dialog instead of in a popup. This would make it a smoother process especially on mobile devices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 18:05:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 16:05:06 +0000 Subject: [Koha-bugs] [Bug 12519] Convert OPAC list download pop-up to modal dialog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12519 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Convert list download |Convert OPAC list download |pop-up to modal dialog |pop-up to modal dialog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 18:05:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 16:05:44 +0000 Subject: [Koha-bugs] [Bug 12520] New: Add DBIx::Class::ResultClass::HashRefInflator to list of Koha dependencies Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12520 Bug ID: 12520 Summary: Add DBIx::Class::ResultClass::HashRefInflator to list of Koha dependencies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org DBIx::Class::ResultClass::HashRefInflator is a nice stopgap for out move from DBI to DBIx::Class. It allows us to return hashrefs like DBI, rather then DBIC objects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 18:06:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 16:06:00 +0000 Subject: [Koha-bugs] [Bug 12520] Add DBIx::Class::ResultClass::HashRefInflator to list of Koha dependencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12520 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12482, 12487 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 18:06:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 16:06:00 +0000 Subject: [Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 18:06:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 16:06:00 +0000 Subject: [Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 18:08:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 16:08:12 +0000 Subject: [Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482 Bug 12482 depends on bug 12520, which changed state. Bug 12520 Summary: Add DBIx::Class::ResultClass::HashRefInflator to list of Koha dependencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12520 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 18:08:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 16:08:12 +0000 Subject: [Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487 Bug 12487 depends on bug 12520, which changed state. Bug 12520 Summary: Add DBIx::Class::ResultClass::HashRefInflator to list of Koha dependencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12520 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 18:08:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 16:08:11 +0000 Subject: [Koha-bugs] [Bug 12520] Add DBIx::Class::ResultClass::HashRefInflator to list of Koha dependencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12520 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Kyle M Hall --- Looks like I was mistaken. It's already part of the DBIx module set. No need to install it separately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 18:08:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 16:08:22 +0000 Subject: [Koha-bugs] [Bug 12520] Add DBIx::Class::ResultClass::HashRefInflator to list of Koha dependencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12520 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12482, 12487 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 18:08:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 16:08:22 +0000 Subject: [Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|12520 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 18:08:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 16:08:22 +0000 Subject: [Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|12520 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 19:06:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 17:06:40 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 19:08:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 17:08:08 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #14 from Olli-Antti Kivilahti --- lol -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 19:09:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 17:09:43 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #15 from Olli-Antti Kivilahti --- Created attachment 29456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29456&action=edit Bug_7021-Add_borrowers_category_to_statistics_usercode Stumbled upon this issue and thought it would be nice to improve it a bit. Hope it helps. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 19:13:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 17:13:12 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #16 from Olli-Antti Kivilahti --- BTW. I am not very keen on adding lots of content to statistics-table. Because it already is gettting verrrrry large. I am not looking forward to it getting larger than absolutely necessary. We already have old_issues and deleted* to keep as history. Our SSD for the DB is only 100GB ;) However I have no data to back up anything. It is possible that suggested modifications won't enlargen the statistics table significantly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 20:11:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 18:11:20 +0000 Subject: [Koha-bugs] [Bug 12337] Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12337 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 20:14:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 18:14:32 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #135 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan and everyone involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 20:18:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 18:18:07 +0000 Subject: [Koha-bugs] [Bug 12304] Creating a user via LDAP doesn't populate message preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12304 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Martin! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 20:18:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 18:18:29 +0000 Subject: [Koha-bugs] [Bug 12456] The file C4/Maintainance.pm can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 20:20:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 18:20:00 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 20:55:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 18:55:27 +0000 Subject: [Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482 --- Comment #3 from Kyle M Hall --- Created attachment 29457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29457&action=edit Bug 12482 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 20:56:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 18:56:05 +0000 Subject: [Koha-bugs] [Bug 12386] 'Days in advance' pull down in bootstrap OPAC is huge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12386 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 20:56:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 18:56:31 +0000 Subject: [Koha-bugs] [Bug 8566] Enable koha-foreach to insert the instancename into commands In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8566 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Reed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 20:56:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 18:56:54 +0000 Subject: [Koha-bugs] [Bug 11857] Number of patrons on a patron list not accurate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11857 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 21:02:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 19:02:15 +0000 Subject: [Koha-bugs] [Bug 12463] Capitalization: Calendar tool, headings for different types of holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12463 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 21:04:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 19:04:40 +0000 Subject: [Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482 --- Comment #4 from Kyle M Hall --- Created attachment 29458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29458&action=edit [PASSED QA] Bug 12482: removing the use of the module C4::SQLHelper.pm, it is replaced by DBIx::Class This patch includes: - removing the use of subroutines InsertInTable, UpdateInTable, SearchInTable replaced by subroutines of DBIx::Class in the subroutines AddBudget, ModBudget, GetBudgets, AddBudgetPeriods, ModBudgetPeriod and GetBudgetPeriods and admin/aqbudgetperiods.pl - removing old database fields in OrderFromSubscription.t, Bookseller.t, Budgets.t, Serials.t, Serials_2.t - improvement of unit tests in t/db_dependent/Budgets.t - adaptation of calls to the subroutines AddBudget, ModBudget, GetBudgets, AddBudgetPeriods, ModBudgetPeriod and GetBudgetPeriods in order to match with the use of DBIx::Class Test plan: 1) Execute the UT of all of files wich uses AddBudget, ModBudget, GetBudgets, AddBudgetPeriods, ModBudgetPeriod or GetBudgetPeriods by launching the command : prove t/Budgets/ t/Budgets.t t/db_dependent/Budgets.t t/db_dependent/Acquisition.t t/db_dependent/Acquisition/ t/db_dependent/Bookseller.t t/db_dependent/Serials.t t/db_dependent/Serials_2.t 2) The result has to be a success : t/Budgets/CanUserModifyBudget.t ........................... ok t/Budgets/CanUserUseBudget.t .............................. ok t/Budgets.t ............................................... ok t/db_dependent/Budgets.t .................................. ok t/db_dependent/Acquisition.t .............................. ok t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. ok t/db_dependent/Acquisition/GetOrdersByBiblionumber.t ...... ok t/db_dependent/Acquisition/Invoices.t ..................... ok t/db_dependent/Acquisition/OrderFromSubscription.t ........ ok t/db_dependent/Acquisition/TransferOrder.t ................ 1/11 # Transfering order to basket2 t/db_dependent/Acquisition/TransferOrder.t ................ ok t/db_dependent/Acquisition/close_reopen_basket.t .......... ok t/db_dependent/Bookseller.t ............................... 16/72 WARNING: GetBooksellerWithLateOrders is called with a negative value at /home/yohann/koha/C4/Bookseller.pm line 135. t/db_dependent/Bookseller.t ............................... ok t/db_dependent/Serials.t .................................. ok t/db_dependent/Serials_2.t ................................ ok All tests successful. Files=14, Tests=571, 22 wallclock secs ( 0.17 usr 0.03 sys + 20.26 cusr 1.10 csys = 21.56 CPU) Result: PASS 3) Go on the page admin/aqbudgetperiods.pl : Koha Administration > Budgets 4) Click on the button "New Budget" and record a new budget with a "nonzero amount" and "make budget active" 5) Click on the button "New Budget" and record another budget without "make budget active" 6) Verify there is the firt budget displayed in "Active budgets" and the second budget in "Inactive budgets" 7) Edit a budget and verify the new values are updated 8) Click on the budget active name in order to go on the page admin/aqbudgets.pl 9) Click on the button "New fund for ..." and record a new fund 10) Click on the button "Edit" then "Duplicate budget ..." in order to duplicate the budget 11) Verify there are two budgets in "Active Budgets" and one in "Inactive Budgets" 12) Click on "Funds" in the menu and verify there are two identical funds and each is associated to a different budget. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 21:04:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 19:04:48 +0000 Subject: [Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482 --- Comment #5 from Kyle M Hall --- Created attachment 29459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29459&action=edit [PASSED QA] Bug 12482 [QA Followup] Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 21:05:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 19:05:05 +0000 Subject: [Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29314|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 21:05:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 19:05:10 +0000 Subject: [Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29457|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 21:05:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 19:05:23 +0000 Subject: [Koha-bugs] [Bug 7667] add a koha-setenv or an improved koha-foreach In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7667 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |tomascohen at gmail.com Resolution|--- |WORKSFORME --- Comment #2 from Tom?s Cohen Arazi --- This is the functionality 'koha-shell' provides already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 21:05:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 19:05:25 +0000 Subject: [Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 21:07:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 19:07:28 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #205 from Tom?s Cohen Arazi --- *** Bug 10068 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 21:07:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 19:07:28 +0000 Subject: [Koha-bugs] [Bug 10068] Move from the utf8:: pragma methods to Encode:: In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10068 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 11944 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 21:26:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 19:26:10 +0000 Subject: [Koha-bugs] [Bug 12519] Convert OPAC list download pop-up to modal dialog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12519 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 21:26:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 19:26:12 +0000 Subject: [Koha-bugs] [Bug 12519] Convert OPAC list download pop-up to modal dialog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12519 --- Comment #1 from Owen Leonard --- Created attachment 29460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29460&action=edit Bug 12519 - Convert OPAC list download pop-up to modal dialog This patch changes the OPAC list download process so that the download link triggers a modal dialog instead of a pop-up window. This streamlines the process a little bit and makes it work better on mobile devices. The download list page has been altered so that it works better as a standalone page, as it might be seen if JavaScript is disabled. Simple form validation has been added to help prevent submission of the form without choosing a format. To test the virtualshelves system preference must be enabled. - View an existing list in the OPAC and click the "download list" link. - A modal dialog should be displayed with the download form. - Submitting the form without selecting a format should trigger either a browser-based form validation error (in HTML5-supporting browsers) or a JavaScript alert (if your browser doesn't support the "required" attribute. - Choosing a download format and submitting the form should close the dialog and trigger the correct download. - Clicking the "Cancel" link should close the dialog. Test with JavaScript disabled: - Clicking the "download list" link should take you to a page which contains the same form which appeared in the modal dialog. - Submitting the form without selecting a format should trigger either a browser-based form validation error (in HTML5-supporting browsers) or a JavaScript alert (if your browser doesn't support the "required" attribute.. - Choosing a download format and submitting the form should result in the corect download. - Clicking the "Cancel" link should return you to the correct list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 2 22:45:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 20:45:07 +0000 Subject: [Koha-bugs] [Bug 12485] Show OPAC search history when opacuserlogin is OFF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12485 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Template only change, works as advertised, pushed as Module Maintainer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 00:09:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 22:09:11 +0000 Subject: [Koha-bugs] [Bug 12521] New: Arrangement of divs on opac-advsearch.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Bug ID: 12521 Summary: Arrangement of divs on opac-advsearch.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Was having a talk with one of our designers here, she had a concern about the div-happiness of the advanced search page. I had a look, and tend to agree with her - without so many container-fluids, and putting everything in the main div, the page is easier to style. The extra container-fluid divs seem superfluous - they don't have extra classes on them for targeting with CSS. The page is broken up in a rather strange way - while talking with her I realised that I had simply gotten used to the way it looks, and hadn't given it any thought at all that it could be different or better. The attached patch I have run past her, and she finds it more pleasing to style than the old structure. The patch doesn't change any functionality - only layout. I'd especially like to hear from Owen on this, please. :) Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 00:10:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jul 2014 22:10:37 +0000 Subject: [Koha-bugs] [Bug 12521] Arrangement of divs on opac-advsearch.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 --- Comment #1 from Liz Rea --- Created attachment 29461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29461&action=edit Bug 12521 - Change layout a bit of the opac advanced search To test: Load up the advanced search and make sure it displays properly, with all of the elements within the main div, and only one container-fluid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 04:52:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 02:52:45 +0000 Subject: [Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 --- Comment #13 from David Cook --- (In reply to Kyle M Hall from comment #10) > NOTE: It would be desirable to update LEADER values > to reflect changes on 008. > Unfortunately, I don't think that's possible, since it's a one way mapping. You can arrive at the same material type via multiple different Leader value combinations, so you can't reverse engineer a material type to get the Leader values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 07:10:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 05:10:33 +0000 Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 07:10:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 05:10:39 +0000 Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27928|0 |1 is obsolete| | --- Comment #9 from Chris Cormack --- Created attachment 29462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29462&action=edit Bug 11638 - Remove HTML from addbiblio.pl This patch extracts variables with HTML from addbiblio.pl and an instance of CGI::scrolling_list As it changes how MARC editor show input fields, I prefer not add patches for other cases mentioned on Comment #1 To test: 1. Verify there are no regressions on MARC editor Add/Edit records, modify values 2. Update translation file for a language, check new string 'Tag editor' About the error message on error when deleting biblio, it must be localized but the script is not trying to use a template file, only prints a basic html and aborts. Perhaps a way of handling errors more gracefully is needed, but again it need to be solved on it's own bug. Updated test plan Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 07:19:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 05:19:34 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 07:23:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 05:23:48 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 07:23:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 05:23:55 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27818|0 |1 is obsolete| | --- Comment #13 from Chris Cormack --- Created attachment 29463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29463&action=edit Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 08:21:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 06:21:36 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|new feature |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 08:30:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 06:30:32 +0000 Subject: [Koha-bugs] [Bug 12522] New: Fatal database error when viewing Holds for Bib with no Items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12522 Bug ID: 12522 Summary: Fatal database error when viewing Holds for Bib with no Items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently, if you have the environmental variable set (via "SetEnv DEBUG 1"), you can trigger a fatal database error in the staff client by clicking "Holds" on a bib record if it has no items attached. If you don't have DEBUG set, you'll get database error warning messages in your logs but it won't be enough to bring down Koha. I doubt many people are running in production with DEBUG turned on, and I doubt that many people try to view the Holds tab on a bib record that doesn't have any items. That said, it's a good idea to reduce errors and warnings... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 08:42:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 06:42:25 +0000 Subject: [Koha-bugs] [Bug 12522] Fatal database error when viewing Holds for Bib with no Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12522 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 08:42:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 06:42:28 +0000 Subject: [Koha-bugs] [Bug 12522] Fatal database error when viewing Holds for Bib with no Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12522 --- Comment #1 from David Cook --- Created attachment 29464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29464&action=edit Bug 12522 - Fatal database error when viewing Holds for Bib with no Items This patch fixes some potential SQL syntax errors, which can cause fatal software errors in Koha when the environmental variable DEBUG is on. _TEST PLAN_ Before applying: 0) Ensure that you don't have "SetEnv DEBUG 1" in your Apache config 1) Create a new bib record 2) Click on the "Holds" tab before creating any items 3) Note the message "Cannot place hold: this record has no items attached." 4) Add "SetEnv DEBUG 1" to your Apache config 5) Restart Apache 6) Refresh your page 7) Note the following Software Error: "DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ')' at line 3 at /koha/lib/C4/Koha.pm line 835. 8) Apply the patch 9) Refresh your page 10) Note the message from Step 3 Thorough tester: 11) Remove "SetEnv DEBUG 1" from your Apache config, restart Apache, and refresh your page. You should see the message from Step 3. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 08:46:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 06:46:45 +0000 Subject: [Koha-bugs] [Bug 12522] Fatal database error when viewing Holds for Bib with no Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12522 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | --- Comment #2 from David Cook --- I suppose I should note that "Koha::get_infos_of" should probably be removed, and "C4::Items::GetItemInfosOf", and "C4::Biblio::GetBiblioItemInfosOf" should be refactored. (I should have probably included some explanatory comments in my patch as well, but...oh well.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 10:16:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 08:16:52 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 10:16:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 08:16:56 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22304|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 29465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29465&action=edit Bug 11120: FIX the --date option for overdue_notices cronjob Bug 7447 introduces the --date option for overdue notices. This option has never worked: the code is waiting for a value but the option is defined as a boolean. This patch fixes the option and change the way to calculate the range of dates. This range is now managed in Perl instead of in the SQL query. To do it in Perl allows to build dates simply using the DateTime and DateTime::Duration modules. To test this patch you should have a DB with a lot of overdues, (I tested on a DB with 512 overdues). A test plan could be: 1/ Dump your message_queue table 2/ Verify the number of overdues in the database before applying the patch: mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v -t (the triggered option will generate overdue for today) mysql> SELECT COUNT(*) FROM message_queue; Note this value 2A mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v mysql> SELECT COUNT(*) FROM message_queue; Note this value 2B 2/ Apply the patch 4/ Verify the number of overdues generated by the patched script: mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v -t mysql> SELECT COUNT(*) FROM message_queue; Note this value 4A mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v mysql> SELECT COUNT(*) FROM message_queue; Note this value 4B mysql> DELETE FROM message_queue; # The date should be defined depending your dateformat preference # and should be the date of the current day perl misc/cronjobs/overdue_notices.pl -v -t --date="YYYY-MM-DD" mysql> SELECT COUNT(*) FROM message_queue; Note this value 4C mysql> DELETE FROM message_queue; # The date should be defined depending your dateformat preference # and should be the date of the current day perl misc/cronjobs/overdue_notices.pl -v --date="YYYY-MM-DD" mysql> SELECT COUNT(*) FROM message_queue; Note this value 4D 5/ Compare the values: All values generated with the -t options should be equals. Same for values without the -t options. => 2A == 4A == 4C and 2B == 4B == 4D 6/ Go back to a normal activity for 3 days or manually change the date_due for issues in the DB: mysql> update issues SET date_due = DATE_SUB(date_due, INTERVAL 3 DAY); Do again step 4C and 4D with a date equals to today - 3 days. Values should be the same as 4C and 4D. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 10:17:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 08:17:31 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #4 from Jonathan Druart --- Rebased patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 13:24:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 11:24:14 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #17 from mathieu saby --- (In reply to Olli-Antti Kivilahti from comment #16) > BTW. > I am not very keen on adding lots of content to statistics-table. > Because it already is gettting verrrrry large. > I am not looking forward to it getting larger than absolutely necessary. > > We already have old_issues and deleted* to keep as history. > > Our SSD for the DB is only 100GB ;) > > > However I have no data to back up anything. It is possible that suggested > modifications won't enlargen the statistics table significantly. The way Koha is storing statistics is not sufficient at all for a lot of libraries : if you delete some borrower's account, if a borrower's category changes (common in academic libraries), or if you anonymize transactions after a few months (mandatory in some countries), the information stored in statistics table is not sufficient to calculate some figures needed in our annual reports. However, I'm concerned with the "DB size" issue... Do you know if creating columns in a table but NOT filling them (it could depend on the activation of a syspref) will have a significant effect on the size of the database? Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 13:25:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 11:25:27 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #18 from mathieu saby --- By the way, bug 11230 has been signed off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:11:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:11:43 +0000 Subject: [Koha-bugs] [Bug 12513] PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12513 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29416|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 29466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29466&action=edit [SIGNED-OFF] Bug 12513 - PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference With CCSR having been deprecated there is no longer a use for the OpacShowLibrariesPulldownMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. Signed-off-by: Bernardo Gonzalez Kriegel Preference removed, no koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:11:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:11:58 +0000 Subject: [Koha-bugs] [Bug 12513] PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12513 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:17:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:17:15 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29444|0 |1 is obsolete| | --- Comment #168 from Owen Leonard --- Comment on attachment 29444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29444 Bug 11810: Input fields in OPAC suggestion form are a bit short (Bootstrap) Wrong bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:17:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:17:20 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29445|0 |1 is obsolete| | --- Comment #169 from Owen Leonard --- Comment on attachment 29445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29445 Bug 11810: (followup) regenerate CSS due to conflict Wrong bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:17:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:17:18 +0000 Subject: [Koha-bugs] [Bug 12245] PROG/CCSR deprecation: Remove OPACMobileUserCSS system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12245 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29414|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 29467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29467&action=edit [SIGNED-OFF] Bug 12245 - PROG/CCSR deprecation: Remove OPACMobileUserCSS system preference With CCSR now deprecated there is no longer a need for the OPACMobileUserCSS system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. Signed-off-by: Bernardo Gonzalez Kriegel Preference removed, no koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:17:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:17:39 +0000 Subject: [Koha-bugs] [Bug 12245] PROG/CCSR deprecation: Remove OPACMobileUserCSS system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12245 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:21:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:21:02 +0000 Subject: [Koha-bugs] [Bug 12246] PROG/CCSR deprecation: Remove OpacMainUserBlockMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12246 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29415|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 29468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29468&action=edit [SIGNED-OFF] Bug 12246 - PROG/CCSR deprecation: Remove OpacMainUserBlockMobile system preference With CCSR having been deprecated there is no longer a use for the OpacMainUserBlockMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. Signed-off-by: Bernardo Gonzalez Kriegel Preference removed, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:21:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:21:14 +0000 Subject: [Koha-bugs] [Bug 12246] PROG/CCSR deprecation: Remove OpacMainUserBlockMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12246 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:24:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:24:27 +0000 Subject: [Koha-bugs] [Bug 12523] New: Add patron email in Holds awaiting pickup circulation rapport. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12523 Bug ID: 12523 Summary: Add patron email in Holds awaiting pickup circulation rapport. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: simith.doliveira at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Our sponsor require an adjustment to allow patron email in Holds awaiting pickup circulation rapport. Sponsor by: ville de victoriaville -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:27:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:27:23 +0000 Subject: [Koha-bugs] [Bug 12524] New: Patron Lists created from patron search are saved with URL encoded names Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12524 Bug ID: 12524 Summary: Patron Lists created from patron search are saved with URL encoded names Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Patron Lists created from patron search are now saved with URL encoded names. I believe this is related to the new patron search. To reproduce: 1) Search for patrons 2) Select some patrons 3) Choose "New list" from the patron lists pulldown. 4) Name the new list "Test List" 5) Save the list 6) Note the list is named "Test%20List" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:27:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:27:31 +0000 Subject: [Koha-bugs] [Bug 12524] Patron Lists created from patron search are saved with URL encoded names In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:27:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:27:40 +0000 Subject: [Koha-bugs] [Bug 12524] Patron Lists created from patron search are saved with URL encoded names In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:30:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:30:51 +0000 Subject: [Koha-bugs] [Bug 12525] New: Patron Lists aren't added to list pulldown when created from Patron search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Bug ID: 12525 Summary: Patron Lists aren't added to list pulldown when created from Patron search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The new ajax patron search needs to add newly created patron lists to the pulldown dynamically since the page is no longer reloaded. In addition, the notice should fade out after a given amount of time so another addition of patrons to a list is more prominent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:30:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:30:56 +0000 Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown when created from Patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:34:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:34:15 +0000 Subject: [Koha-bugs] [Bug 12523] Add patron email in Holds awaiting pickup circulation rapport. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12523 --- Comment #1 from simith.doliveira at inlibro.com --- Created attachment 29469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29469&action=edit Bug 12523 - Add patron email in Holds awaiting pickup circulation rapport Modified: circ/waitingreservers.pl - added GetFirstValidEmailAddress Testing: I Apply the patch 0) Put an item in hold for pickup; 1) In Circulation -> Holds awaiting pickup, validate email (column Patron); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:34:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:34:59 +0000 Subject: [Koha-bugs] [Bug 12523] Add patron email in Holds awaiting pickup circulation rapport. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12523 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:36:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:36:40 +0000 Subject: [Koha-bugs] [Bug 8466] Holds on MARC records with no item causes silent error in koha-error_log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8466 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 12522 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 14:36:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 12:36:40 +0000 Subject: [Koha-bugs] [Bug 12522] Fatal database error when viewing Holds for Bib with no Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12522 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kolpen at o2.pl --- Comment #3 from Owen Leonard --- *** Bug 8466 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:03:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:03:49 +0000 Subject: [Koha-bugs] [Bug 11347] PROG/CCSR deprecation: Remove opacsmallimage system-preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29418|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 29470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29470&action=edit [SIGNED-OFF] Bug 11347 - PROG/CCSR deprecation: Remove opacsmallimage system-preference The opacsmallimage system preference is unused in the bootstrap theme. It can be removed now that prog and ccsr are deprecated. This patch does so. To test, apply the patch and run updatedatabase. Confirm that the OPAC works properly and the preference can no longer be found. Signed-off-by: Bernardo Gonzalez Kriegel Preference removed, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:04:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:04:06 +0000 Subject: [Koha-bugs] [Bug 11347] PROG/CCSR deprecation: Remove opacsmallimage system-preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:09:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:09:39 +0000 Subject: [Koha-bugs] [Bug 12512] PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29417|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 29471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29471&action=edit [SIGNED-OFF] Bug 12512 - PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference CCSR having been deprecated there is no longer a use for the OpacShowFiltersPulldownMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. Signed-off-by: Bernardo Gonzalez Kriegel Preference removed, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:09:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:09:55 +0000 Subject: [Koha-bugs] [Bug 12512] PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:18:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:18:17 +0000 Subject: [Koha-bugs] [Bug 12526] New: Update shipped Ajaxfileupload.js to latest upstream Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12526 Bug ID: 12526 Summary: Update shipped Ajaxfileupload.js to latest upstream Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org While bug 10652 fixed a problem with this JS lib in Internet Explorer, we should stick to following upstream changes on thrid-party libs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:18:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:18:33 +0000 Subject: [Koha-bugs] [Bug 12526] Update shipped Ajaxfileupload.js to latest upstream In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12526 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10652 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:18:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:18:33 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12526 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:19:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:19:02 +0000 Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown when created from Patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #1 from Kyle M Hall --- It also appears that existing patron lists don't always show in the pulldown. Increasing severity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:20:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:20:01 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks David! Note: new bug for updating Ajaxfileupload.js from upstream created (bug 12526) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:21:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:21:13 +0000 Subject: [Koha-bugs] [Bug 12150] Use more placeholders in translatable javascript strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- No regressions found, patches pushed to master. Thanks paxed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:22:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:22:00 +0000 Subject: [Koha-bugs] [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com Blocks|12261 | Depends on| |12261 --- Comment #20 from Tom?s Cohen Arazi --- Pushed to master. Thanks Juhani! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:22:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:22:00 +0000 Subject: [Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12481 Depends on|12481 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:35:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:35:55 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29446|0 |1 is obsolete| | Attachment #29447|0 |1 is obsolete| | Attachment #29448|0 |1 is obsolete| | Attachment #29449|0 |1 is obsolete| | Attachment #29450|0 |1 is obsolete| | Attachment #29451|0 |1 is obsolete| | Attachment #29452|0 |1 is obsolete| | Attachment #29453|0 |1 is obsolete| | Attachment #29454|0 |1 is obsolete| | --- Comment #170 from Kyle M Hall --- Created attachment 29472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29472&action=edit Bug 11703 - Convert checkouts table to ajax datatable When a patron has many checked out items, circulation.pl can take a very long time to load ( on the order of minutes in some cases ). This is primarily due to the processing of the previous checkouts list. If we convert to this table to a datatable that fetches its data via ajax, we can make circulation.pl far more responsive. The same should be done with relative's checkouts as well. Test Plan: 1) Apply this patch 2) Observe that the checkouts and relatives' checkouts tables are now loaded asynchronously 3) Observe and verify the renew and return actions are now ajax based and function in a manner equivilent to how they used to. This bug had quite a few followups, so I squashed all of them into one change so that code is easier to follow. Original commit messages are below: Bug 11703 - Use the ajax datatables on patron details page Bug 11703 - Convert holds tables to ajax datatables Bug 11703 [QA Followup 1] - Center bProcessing message over table Bug 11703 [QA Followup 2] - Remove icons from checkout and clear buttons Bug 11703 [QA Followup 3] - Remove references to UseTablesortForCirc Bug 11703 [QA Followup 4] - Add back in Today's checkouts/Previous checkouts rows Bug 11703 [QA Followup 5] Bug 11703 [QA Followup 6] - Move strings to an include file for translation purposes Bug 11703 [QA Followup 7] - Fix issues spotted by koha-qa.pl Bug 11703 [QA Followup 8] - Speed up api/checkouts.pl as much as possible Bug 11703 [QA Followup 9] - Move scripts from api directory to svc directory Bug 11703 [QA Followup 10] - Fix errors caused by rebase Bug 11703 [QA Followup 11] - Prevent multiple fetchs from ajax source Bug 11703 [QA Followup 12] - Fix problem detected by koha-qa.pl Bug 11703 [QA Followup 13] - Removed uneccessary data from renewal box during renewal Bug 11703 [QA Followup 14] - Fix table column span Signed-off-by: Dobrica Pavlinusic Signed-off-by: Katrin Fischer Passes all tests and QA script. Test plan on bug report: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703#c98 Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:36:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:36:12 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #171 from Kyle M Hall --- Created attachment 29473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29473&action=edit Bug 11703 [QA Followup] * Bold record title, fix table width * Change output_pref_due to output_pref * Retain functionality of IssuesDefaultSortOrder system preferences * Use datatables.inc in circulation.tt * Fix up holds table details * Add plugin to about * fix relatives' checkouts * add too_many string * remove dead syspref from db * Sort relatives' checkouts and holds tables client side * Provide context for translation of strings * Fix unterminated string literal, add missing paren * Add replacement of _AUTHOR_ with title's author for holds * Format prices correctly * Format checkout dates correctly Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:36:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:36:17 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #172 from Kyle M Hall --- Created attachment 29474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29474&action=edit Bug 11703 [QA Followup] - Use format instead of replace for string translation Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:36:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:36:22 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #173 from Kyle M Hall --- Created attachment 29475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29475&action=edit Bug 11703 [QA Followup] - Use interface instead of themelang for checkboxes plugin Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:36:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:36:27 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #174 from Kyle M Hall --- Created attachment 29476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29476&action=edit Bug 11703 [QA Followup] - Restore showing earliest renewal date for 'too early' renewals Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:36:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:36:31 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #175 from Kyle M Hall --- Created attachment 29477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29477&action=edit Bug 11703: (qa-followup) fix update database entry Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:36:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:36:36 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #176 from Kyle M Hall --- Created attachment 29478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29478&action=edit Bug 11703 [QA Followup] - Stop IE from caching ajax request Signed-off-by: Britta Cramer Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:36:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:36:42 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #177 from Kyle M Hall --- Created attachment 29479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29479&action=edit Bug 11703 [QA Followup] - Allow keyboard navigation of tabs Signed-off-by: Britta Cramer Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:36:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:36:46 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #178 from Kyle M Hall --- Created attachment 29480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29480&action=edit Bug 11703 [QA Followup] - Change "No data available in table" to "Loading..." Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:40:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:40:40 +0000 Subject: [Koha-bugs] [Bug 12220] bootstrap not responsive on all devices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:41:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:41:26 +0000 Subject: [Koha-bugs] [Bug 12237] Remove the "horrible hack" in C4::Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12237 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:46:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:46:18 +0000 Subject: [Koha-bugs] [Bug 8567] Set output directory for fines.pl in cron config created by the packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Reed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 15:51:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 13:51:14 +0000 Subject: [Koha-bugs] [Bug 12451] circulation rule cant be edited if itemtype contains a space character In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12451 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Fridolin! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:21:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:21:14 +0000 Subject: [Koha-bugs] [Bug 12517] Download and send list popups broken in bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:21:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:21:16 +0000 Subject: [Koha-bugs] [Bug 12517] Download and send list popups broken in bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 --- Comment #3 from Kyle M Hall --- Created attachment 29481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29481&action=edit [PASSED QA] Bug 12517 - Download and send list popups broken in bootstrap OPAC A JavaScript error prevents the download list and send list links in the bootstrap OPAC from functioning correctly. A variable declaration was removed from basket.js during the creation of the theme but opac-shelves.tt was not changed accordingly. This patch corrects it. To test, view an existing shelf in the bootstrap OPAC and test the "download list" and "send list" links. They should each trigger popups without any errors. Signed-off-by: Bernardo Gonzalez Kriegel Popups pops again, no koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:23:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:23:44 +0000 Subject: [Koha-bugs] [Bug 12527] New: The z39.50 authority search to create new auth record doesn't works on UNIMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12527 Bug ID: 12527 Summary: The z39.50 authority search to create new auth record doesn't works on UNIMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org Hi, If i try to use the z39.50 authority search to create new auth record in UNIMARC I receive this error in intranet: Software error: Unsupported UNIMARC character encoding [ ] for XML output for UNIMARCAUTH; 100$a -> 20140703 frey50 at /usr/share/perl5/MARC/File/XML.pm line 568. I use this z39.50 server for unimarc authority: catalogue.bu.univ-rennes2.fr:9999/authorities It is a Koha server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:27:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:27:04 +0000 Subject: [Koha-bugs] [Bug 12512] PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:27:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:27:06 +0000 Subject: [Koha-bugs] [Bug 12512] PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29471|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 29482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29482&action=edit [PASSED QA] Bug 12512 - PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference CCSR having been deprecated there is no longer a use for the OpacShowFiltersPulldownMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. Signed-off-by: Bernardo Gonzalez Kriegel Preference removed, no koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:30:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:30:58 +0000 Subject: [Koha-bugs] [Bug 11347] PROG/CCSR deprecation: Remove opacsmallimage system-preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:31:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:31:00 +0000 Subject: [Koha-bugs] [Bug 11347] PROG/CCSR deprecation: Remove opacsmallimage system-preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29470|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 29483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29483&action=edit [PASSED QA] Bug 11347 - PROG/CCSR deprecation: Remove opacsmallimage system-preference The opacsmallimage system preference is unused in the bootstrap theme. It can be removed now that prog and ccsr are deprecated. This patch does so. To test, apply the patch and run updatedatabase. Confirm that the OPAC works properly and the preference can no longer be found. Signed-off-by: Bernardo Gonzalez Kriegel Preference removed, no koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:35:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:35:36 +0000 Subject: [Koha-bugs] [Bug 12246] PROG/CCSR deprecation: Remove OpacMainUserBlockMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12246 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:35:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:35:38 +0000 Subject: [Koha-bugs] [Bug 12246] PROG/CCSR deprecation: Remove OpacMainUserBlockMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12246 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29468|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 29484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29484&action=edit [PASSED QA] Bug 12246 - PROG/CCSR deprecation: Remove OpacMainUserBlockMobile system preference With CCSR having been deprecated there is no longer a use for the OpacMainUserBlockMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. Signed-off-by: Bernardo Gonzalez Kriegel Preference removed, no koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:41:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:41:35 +0000 Subject: [Koha-bugs] [Bug 12245] PROG/CCSR deprecation: Remove OPACMobileUserCSS system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12245 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:41:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:41:38 +0000 Subject: [Koha-bugs] [Bug 12245] PROG/CCSR deprecation: Remove OPACMobileUserCSS system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12245 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29467|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 29485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29485&action=edit [PASSED QA] Bug 12245 - PROG/CCSR deprecation: Remove OPACMobileUserCSS system preference With CCSR now deprecated there is no longer a need for the OPACMobileUserCSS system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. Signed-off-by: Bernardo Gonzalez Kriegel Preference removed, no koha-qa errors. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:43:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:43:26 +0000 Subject: [Koha-bugs] [Bug 12513] PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12513 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:43:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:43:29 +0000 Subject: [Koha-bugs] [Bug 12513] PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12513 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29466|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 29486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29486&action=edit [PASSED QA] Bug 12513 - PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference With CCSR having been deprecated there is no longer a use for the OpacShowLibrariesPulldownMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. Signed-off-by: Bernardo Gonzalez Kriegel Preference removed, no koha-qa errors. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:49:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:49:19 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply Version|3.14 |master --- Comment #69 from Nick Clemens --- Patch no longer applies, I also see this problem in master so updating both status and version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:50:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:50:11 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 --- Comment #13 from Kyle M Hall --- Created attachment 29487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29487&action=edit [SIGNED-OFF] Bug 12151: Remove uses of smartmatch operator in Search.pm and opac-search.pl This patch removes the use of smartmatch operators in the search code. Regards To+ Edit: this revision uses 'grep' instead of Lists::MoreUtils::any Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall Passes koha-qa.pl, all affected scripts appear to work properly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:50:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:50:36 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29013|0 |1 is obsolete| | Attachment #29014|0 |1 is obsolete| | Attachment #29015|0 |1 is obsolete| | Attachment #29016|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 29488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29488&action=edit [SIGNED-OFF] Bug 12151: Remove uses of smartmatch operator in report scripts This patch removes the use of smartmatch operators in report scripts. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:51:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:51:51 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 --- Comment #15 from Kyle M Hall --- Created attachment 29489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29489&action=edit [SIGNED-OFF] Bug 12151: Remove uses of smartmatch operator from Koha/Solr/QueryBuilder.pm Just that. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:51:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:51:54 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 --- Comment #16 from Kyle M Hall --- Created attachment 29490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29490&action=edit [SIGNED-OFF] Bug 12151: Remove use of smartmatch operator in tools/batchMod.pl The '~~' smartmatch operator is used to compare MARC::Field->subfield(code) (i.e. a string) and the text element of each MARC::Field->subfields() which is also plain text. Substituting '~~' for 'eq' should be harmless then. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 16:53:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 14:53:40 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:00:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:00:16 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #28 from Kyle M Hall --- Applying: Bug 11395: Fix return for ModifyRecordWithTemplate fatal: sha1 information is lacking or useless (C4/MarcModificationTemplates.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:00:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:00:46 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |pianohacker at gmail.com --- Comment #31 from Jonathan Druart --- I mark this patch set as does not apply since bug 11703 is going to be pushed. Jesse, Kyle told me you are working on ajaxify checkouts. Please let me know what you are doing. I would prefer to base a rebase of this feature on top of your work :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:03:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:03:14 +0000 Subject: [Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle at bywatersolutions.com --- Comment #2 from Kyle M Hall --- Applying: Bug 12487: SQLHelper replacement - C4::Contract fatal: sha1 information is lacking or useless (C4/Contract.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12487: SQLHelper replacement - C4::Contract When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12487-SQLHelper-replacement---C4Contract-XbEHYe.patch kohaqa-koha at koha-dev:~/kohaclone$ patch -p1 < /tmp/Bug-12487-SQLHelper-replacement---C4Contract-XbEHYe.patch patching file C4/Contract.pm Hunk #1 FAILED at 21. Hunk #2 FAILED at 78. Hunk #3 FAILED at 113. 3 out of 3 hunks FAILED -- saving rejects to file C4/Contract.pm.rej patching file t/db_dependent/Contract.t Hunk #1 FAILED at 21. Hunk #2 FAILED at 42. Hunk #3 FAILED at 50. Hunk #4 FAILED at 70. Hunk #5 FAILED at 96. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:15:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:15:36 +0000 Subject: [Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 --- Comment #5 from Nick Clemens --- Created attachment 29491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29491&action=edit [SIGNED OFF] Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status The template markup that controls that status column for the items table in catalogue/detail.pl does not account for the itemtypes.notforloan flag. Test Plan: 1) Find an item that is currently available 2) Go to the itemtype editor and mark that itemtype of that item as being not for loan 3) Browse to the catalog details page for that item's record 4) Note the item status is still "Available" 5) Apply this patch 6) Reload the catalog details page 7) Note the item status is now "Not for loan" Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:15:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:15:47 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:16:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:16:00 +0000 Subject: [Koha-bugs] [Bug 12407] phone label or data switched In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- This looks similar to bug 8760 - maybe someone can take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:16:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:16:10 +0000 Subject: [Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28420|0 |1 is obsolete| | CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:16:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:16:31 +0000 Subject: [Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:19:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:19:21 +0000 Subject: [Koha-bugs] [Bug 12420] syndetics content broken in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12420 --- Comment #7 from Nicole C. Engard --- MARC from Al Capone Does My Shirts (paperback): 020 _a978014240370 _c(pbk.) 020 _a9780142403709 _c(pbk.) 020 _a0142403709 _c(pbk.) MARC from Al Capone Does My Shirts (hardcover): 020 _a0399238611 (hc) : _c$15.99 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:20:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:20:39 +0000 Subject: [Koha-bugs] [Bug 12418] show patron barcode on their list of checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12418 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Nicole C. Engard --- *** This bug has been marked as a duplicate of bug 11768 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:20:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:20:39 +0000 Subject: [Koha-bugs] [Bug 11768] Show patron cardnumber in opac personal details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11768 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #7 from Nicole C. Engard --- *** Bug 12418 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:22:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:22:00 +0000 Subject: [Koha-bugs] [Bug 12331] can't save results to zotero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12331 --- Comment #2 from Nicole C. Engard --- I don't really understand all that - can you explain it such that I could report the bug to them - or could you report the bug to them? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:25:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:25:52 +0000 Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:25:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:25:54 +0000 Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29462|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 29492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29492&action=edit [PASSED QA] Bug 11638 - Remove HTML from addbiblio.pl This patch extracts variables with HTML from addbiblio.pl and an instance of CGI::scrolling_list As it changes how MARC editor show input fields, I prefer not add patches for other cases mentioned on Comment #1 To test: 1. Verify there are no regressions on MARC editor Add/Edit records, modify values 2. Update translation file for a language, check new string 'Tag editor' About the error message on error when deleting biblio, it must be localized but the script is not trying to use a template file, only prints a basic html and aborts. Perhaps a way of handling errors more gracefully is needed, but again it need to be solved on it's own bug. Updated test plan Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:26:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:26:30 +0000 Subject: [Koha-bugs] [Bug 12358] patrons can't see hold notes in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12358 --- Comment #2 from Nicole C. Engard --- The problem here is that patrons are allowed to leave notes and then they don't see the notes they leave. Here's the preference: http://manual.koha-community.org/3.14/en/administration.html#OpacHoldNotes Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:28:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:28:33 +0000 Subject: [Koha-bugs] [Bug 10469] display more in frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469 --- Comment #2 from Nicole C. Engard --- Yes, that's the URL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:36:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:36:30 +0000 Subject: [Koha-bugs] [Bug 12358] patrons can't see hold notes in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12358 --- Comment #3 from Owen Leonard --- (In reply to Nicole C. Engard from comment #2) > The problem here is that patrons are allowed to leave notes and then they > don't see the notes they leave. I don't misunderstand what the bug is about, I just contend that it wouldn't be appropriate to simply make the notes information public without accommodating libraries who may have been using the notes field--via the staff client--for information which they don't want the patron to see. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:42:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:42:11 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #179 from Tom?s Cohen Arazi --- Created attachment 29493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29493&action=edit Bug 11703: (qa followup) consistency in svc This patch removes the trailing .pl from the introduced svc scripts. Also removes a leftover (wrong license text) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:45:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:45:02 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #180 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle and everyone involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:55:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:55:38 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nick at quecheelibrary.org --- Comment #23 from Nick Clemens --- I got some odd results when testing: 1 Added four patrons to the list: One with a checkout One with a fine Two with empty accounts Patron modification link seemed to work as expected Patron deletion link said 3 patrons would be deleted, I deleted, it said 3 were gone, 2 were left in list (one with checkout, one with fine) I would be nice on the deletion screen to know who was going to be deleted/who was deleted, I can't tell from my results which patron (issue or fine) it was planning to delete. If not a list before deletion, maybe a results list after the action. I also found that I had two identical lists, both affected by deletion, but don't know if that is from this patch (In reply to Kyle M Hall from comment #1) > Created attachment 19766 [details] [review] > Bug 10612 - Add ability to delete patrons with batch patron modification tool > > The batch patron deletion/anonymization does not allow for batch > deletion of arbitrary lists of patrons. The batch patron modification > tool allows for modification of arbitrary lists of patrons, but not > deletion. If would be highly beneficial to add patron deletion to the > batch patron modification tool. > > Test Plan: > 1) Apply all dependencies for this patch > 2) Apply this patch > 3) Create a list of patrons with the new Patron Lists feature > a) Include at least one patron owing fines > b) Include at least one patron with items currently checked out > c) Include at least one patron not falling into a) or b) > 4) Browse to the batch patron modifications tool > 5) Select your list from the pulldown, and submit > 6) Check the "Delete patrons" checkbox, the click the submit button > 7) You should a list of errors for the patrons with fines or issues > and a table of patrons that were deleted successfully. > 8) Click the link for a deleted patron, you should get a "patron not > found" message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:55:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:55:55 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29329|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 29494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29494&action=edit [SIGNED-OFF] Bug 12493: moving the subroutines GetContract and GetContracts from C4::Acquisition.pm to C4::Contract.pm This patch includes: - the subroutines GetContract and GetContracts has been moved from C4::Acquisition.pm to C4::Contract.pm and adapted for a general use - adaptation of acqui/basket.pl, acqui/basketheader.pl, acqui/neworderempty.pl, acqui/supplier.pl and admin/aqcontract.pl - the unit tests for the module C4::Contract.pm Test plan: 1) Apply the patch 2) Execute the unit tests by launching: prove t/db_dependent/Contract.t t/Acquisition/ t/db_dependent/Acquisition/ t/db_dependent/Acquisition.t 3) The command has to be a success : t/db_dependent/Contract.t ................................. ok t/Acquisition/CanUserManageBasket.t ....................... ok t/Acquisition/Invoice.t ................................... ok t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. ok t/db_dependent/Acquisition/GetOrdersByBiblionumber.t ...... ok t/db_dependent/Acquisition/Invoices.t ..................... ok t/db_dependent/Acquisition/OrderFromSubscription.t ........ ok t/db_dependent/Acquisition/TransferOrder.t ................ 1/11 # Transfering order to basket2 t/db_dependent/Acquisition/TransferOrder.t ................ ok t/db_dependent/Acquisition/close_reopen_basket.t .......... ok t/db_dependent/Acquisition.t .............................. ok All tests successful. Files=10, Tests=284, 15 wallclock secs ( 0.11 usr 0.02 sys + 12.88 cusr 0.77 csys = 13.78 CPU) Result: PASS 4) Log on with a superlibrarian permission 5) Go on the page acqui/supplier.pl (Acquisitions > Button "New vendor") 6) Record a vendor with a nonzero "name" 7) Go on the page admin/aqcontract.pl (click on the "Contracts" item in the menu) 8) Click on the button "New" > "Contract" and record a new one 9) Verify the displayed data are correct about the contract 10) "Edit" the contract with different values and verify the data are updated 11) Click on "Delete" in order to delete the contract, verify the displayed data are correct but cancel the operation 12) Click on "New" > "Basket" and verify there is the created contract in field "Contract", then record a basket by selectioning the created contract 13) Verify the contract name displayed is correct 14) Record an active budget and a fund linked to this budget 15) Go on the new basket (Home > Acquisitions > Search the created vendor) 16) Click on "Add to basket" then "From a new (empty) record" and verify the displayed contract name is correct Signed-off-by: Bernardo Gonzalez Kriegel Tested with both patches applied. Works as described following test plan, all points (I did 14 first) All test pass No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:56:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:56:02 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29353|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 29495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29495&action=edit [SIGNED-OFF] Bug 12493: unit tests for the module C4::Contract.pm This patch are the unit tests of the previous patch Test plan : Same as the previous patch Signed-off-by: Bernardo Gonzalez Kriegel Comments on previous patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 17:56:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 15:56:28 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 18:41:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 16:41:00 +0000 Subject: [Koha-bugs] [Bug 12420] syndetics content broken in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12420 --- Comment #8 from Owen Leonard --- (In reply to Nicole C. Engard from comment #7) > MARC from Al Capone Does My Shirts (paperback): > > 020 _a0142403709 > _c(pbk.) This works fine for me. The cover image from Syndetics loads. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 18:45:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 16:45:48 +0000 Subject: [Koha-bugs] [Bug 12331] can't save results to zotero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12331 --- Comment #3 from Bernardo Gonzalez Kriegel --- (In reply to Nicole C. Engard from comment #2) > I don't really understand all that - can you explain it such that I could > report the bug to them - or could you report the bug to them? I'm not a user of Zotero :(, will try to explain. Zotero uses "translators"[1] to detect and add records/objects. They are JavaScript functions, and there are plenty of them [2] In the case of Koha Zotero translator [3], they have a function to detect a single record (opac-detail in url) or multiple (opac-results in url). For multiple results, they parse the html looking for something with structure but we don't have that. perhaps something like My hope was that Owen could take a look and perhaps suggest a correct XPath expression so Mr. Sebastian Karcher (creator) could fix the translator. In summary, I think the problem they have is an incorrect XPath expression when parsing multiple results. [1] https://www.zotero.org/support/translators [2] https://github.com/zotero/translators [3] https://github.com/zotero/translators/blob/master/Library%20Catalog%20(Koha).js -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 18:56:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 16:56:23 +0000 Subject: [Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29365|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 29496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29496&action=edit [SIGNED-OFF] Bug 12487: SQLHelper replacement - C4::Contract With this patch, the subroutines GetContract, GetContracts, AddContract, ModContract and DelContract uses DBIx::Class instead of C4::SQLHelper Test plan: 1) Apply the patch 2) Execute the unit tests by launching: prove t/db_dependent/Contract.t 3) The command has to be a success : t/db_dependent/Contract.t .. ok All tests successful. Files=1, Tests=43, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.49 cusr 0.05 csys = 1.59 CPU) Result: PASS 4) Log on with a superlibrarian permission 5) Go on the page acqui/supplier.pl (Acquisitions > Button "New vendor") 6) Record a vendor with a nonzero "name" 7) Go on the page admin/aqcontract.pl (click on the "Contracts" item in the menu) 8) Click on the button "New" > "Contract" and record a new one 9) Verify the displayed data are correct about the contract 10) "Edit" the contract with different values and verify the data are updated 11) Click on "Delete" in order to delete the contract, verify the displayed data are correct but cancel the operation 12) Click on "New" > "Basket" and verify there is the created contract in field "Contract", then record a basket by selectioning the created contract 13) Verify the contract name displayed is correct 14) Record an active budget and a fund linked to this budget 15) Go on the new basket (Home > Acquisitions > Search the created vendor) 16) Click on "Add to basket" then "From a new (empty) record" and verify the displayed contract name is correct, then cancel 17) Click on "Delete this basket" 18) Click on "Contracts" (in the left menu) in order to go on aqcontract.pl, then "Delete" the created contract 19) The contract is not displayed anymore in the vendor page Signed-off-by: Bernardo Gonzalez Kriegel Work as described following test plan. Tested on top of Bug 12493 Tests pass No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 18:57:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 16:57:16 +0000 Subject: [Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 18:58:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 16:58:15 +0000 Subject: [Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487 --- Comment #4 from Bernardo Gonzalez Kriegel --- (In reply to Kyle M Hall from comment #2) > Applying: Bug 12487: SQLHelper replacement - C4::Contract Hi, on top of 12493 it applies correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:01:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:01:14 +0000 Subject: [Koha-bugs] [Bug 12508] The removal of a contract which is linked to a basket does not display an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel --- About to test, already signed. Status changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:23:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:23:41 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:23:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:23:44 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28988|0 |1 is obsolete| | Attachment #28989|0 |1 is obsolete| | Attachment #28990|0 |1 is obsolete| | Attachment #28991|0 |1 is obsolete| | Attachment #28992|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 29497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29497&action=edit [PASSED QA] Bug 11319: Koha::SimpleMARC should take a hashref for parameters In order to avoid a long list of parameters, it should be better to pass all of them into a hashref. This patch does not add or modify a behavior. Test plan: Verify the unit tests still pass - prove t/SimpleMARC.t - prove t/db_dependent/MarcModificationTemplates.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:32:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:32:39 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #27 from Kyle M Hall --- Created attachment 29498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29498&action=edit [PASSED QA] Bug 11319: Add UT for the fields management Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:32:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:32:43 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #28 from Kyle M Hall --- Created attachment 29499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29499&action=edit [PASSED QA] Bug 11319: Add the field management for Koha::SimpleMARC Currently the Koha::SimpleMARC module call a "field" a "subfield". And the way to manage field is not implemented for all routines. This patch does not modify the API. The routine's names are kept. It just creates 2 privates routines for each action (e.g. delete_field will call _delete_field if the action affects field and _delete_subfield if the action affects subfields). Before this patch the move action was authorised by the interface but caused an error if executed. Note: I don't see the meaning for the add/update action if no subfield is given. So the call without subfield raises an error. Test plan: - apply all patches - create or modify an existent template - try at least the correct behavior for the following actions: * delete subfield and field * add new subfield to an existing field * add new subfield to an nonexisting field * move a subfield * move an entire field * copy a subfield * copy an entire field - import a biblio and use this template - verify the imported biblio matches actions defined. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:32:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:32:45 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #29 from Kyle M Hall --- Created attachment 29500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29500&action=edit [PASSED QA] Bug 11319: Add specific UT for nonexistent field/subfield This patch only adds unit tests for the copy and move actions. They test if the action does not create a field/subfield if the source did not exist. Also it adds a unit tests for the existing behavior (in order not to lost it): we can use the '^' and the '$' character in regex for substituing. For example: Copy 245$a to 245$a with the regex s/^/BEGIN / This will add the string "BEGIN " at the beginning of the 245$a fields. To test: prove t/SimpleMARC.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:32:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:32:48 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #30 from Kyle M Hall --- Created attachment 29501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29501&action=edit [PASSED QA] Bug 11319: Template modifications This patch add template modifications for the restrictions: - the source field is always mandatory - on move and copy, the source and destination subfield should be both filled or blank. - on move and copy, the destination subfield should be filled. - on update, the subfield value should be filled. Test plan: Verify you are not able to create/modify template actions according to these restrictions. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:44:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:44:29 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29497|[PASSED QA] Bug 11319: |Bug 11319: Koha::SimpleMARC description|Koha::SimpleMARC should |should take a hashref for |take a hashref for |parameters |parameters | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:44:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:44:38 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29498|[PASSED QA] Bug 11319: Add |Bug 11319: Add UT for the description|UT for the fields |fields management |management | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:45:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:45:02 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29499|[PASSED QA] Bug 11319: Add |Bug 11319: Add the field description|the field management for |management for |Koha::SimpleMARC |Koha::SimpleMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:45:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:45:12 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29500|[PASSED QA] Bug 11319: Add |Bug 11319: Add specific UT description|specific UT for nonexistent |for nonexistent |field/subfield |field/subfield -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:45:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:45:24 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29501|[PASSED QA] Bug 11319: |Bug 11319: Template description|Template modifications |modifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:45:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:45:58 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:46:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:46:00 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28996|0 |1 is obsolete| | Attachment #28997|0 |1 is obsolete| | Attachment #28998|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 29502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29502&action=edit [SIGNED-OFF] Bug 11413: Change the field number logic This patch series is a bugfix for the Marc modification templates tool. Bug description: If you want to do an action (delete/update/move/...) on a multivalued field and if a condition is defined on the same field, it is highly probable the resulted record will not be what you expect. For example: Deleting All (or the first) fields 650 if 245$a="Bad title" works with the current code. BUT if you want to delete All (or the first) fields 650 with a condition on 650$9=42, and if at least one field matches the condition : - if you have selected all, all fields 650 will be deleted, even the ones who do not match the condition. - if you have selected first, the first 650 field will be deleted, even if it does not match the condition. The expected behavior is to delete the fields matching the condition (and not all the 650 fields). What this patch does: This patch introduces 2 changes in the logic of Koha::SimpleMARC. The first change is a change of the prototypes for the 2 routines field_exists and field_equals. Now they return the "field number" of the matching fields. The second change is the type of the "n" parameter for all routines using it in Koha::SimpleMARC. Before this patch, the "n" parameter was a boolean in most cases. If 0, the action was done on all fields, if 1 on the first one only. Now it is possible to specify the "field numbers" (so the array of field numbers which is returned by field_exists or field_equals) for all routines which had the n parameter. Test plan for the patch series: Note: This test plan describes a specific example, feel free to create your own one. 0/ Define a marc modification template with the following action: Delete field 245 if 245$9 = 42 1/ choose and export a record with several 245 fields. For ex: 245 $a The art of computer programming $c Donald E. Knuth. $9 41 245 $a Bad title $c Bad author $9 42 2/ import it using the Stage MARC for import tool. 3/ verify the imported record does not contain any 245 field. 4/ apply all the patches from this bug report 5/ do again steps 2 and 3 6/ verify the imported record contains only one 245 field, the one with 245$9=41 7/ verify the unit tests passed: prove t/SimpleMARC.t prove t/db_dependent/MarcModificationTemplates.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:46:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:46:20 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #23 from Kyle M Hall --- Created attachment 29503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29503&action=edit [SIGNED-OFF] Bug 11413: UT to show up the issue These UT reflect this change: - deletion of the field 245 if 245$a='Bad title' - move of the 650 field to 651 if 650$9=499 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:46:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:46:23 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #24 from Kyle M Hall --- Created attachment 29504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29504&action=edit [SIGNED-OFF] Bug 11413: Reflect the changes to the interface Test plan: - add/edit an action on the marc modification templates tools - choose an action and define a condition - define the source field as same as the condition field - verify the All/1st dropdown list is changed to Every/1st Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:49:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:49:31 +0000 Subject: [Koha-bugs] [Bug 12528] New: Enable staff to deny message setting access to patrons on the OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bug ID: 12528 Summary: Enable staff to deny message setting access to patrons on the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: simith.doliveira at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Enable staff to deny message setting access to patrons on the OPAC The problem: The preference EnhancedMessagingPreferences control access to patron message setting in both intranet (Patrons -> Details or Patrons -> Edit) and OPAC ( user's settings - > your messaging). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:50:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:50:31 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com | |, | |simith.doliveira at inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 19:51:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 17:51:47 +0000 Subject: [Koha-bugs] [Bug 5956] Highlight holds on check-in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5956 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |nick at quecheelibrary.org --- Comment #5 from Nick Clemens --- I tested on a sandbox and found that the highlighting (note in red, not highlighting of row) only occurs on confirmation of a hold. I think the intention is that if someone checks in a reserved book, doesn't see the message, then checks in a book with no reserves, they would still see the highlighting even without having confirmed the hold. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 20:00:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 18:00:38 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #29 from Kyle M Hall --- * Select All / Clear All links do not work * Links should probably be "Select all" and "Clear all" * Preview MARC does not open record in a modal window * When I click the "Modify selected records" button, nothing happens. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 20:01:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 18:01:15 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #30 from Kyle M Hall --- GET http://staff-kohaqa.koha-dev.com/intranettmpl/prog/en/lib/jquery/plugins/jquery.checkboxes.min.js 404 (Not Found) batch_record_modification.pl:113 Uncaught TypeError: undefined is not a function batch_record_modification.pl:120 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 20:05:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 18:05:11 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #1 from simith.doliveira at inlibro.com --- Created attachment 29505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29505&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Modified: installer/data/mysql/sysprefs.sql -OPACEnhancedMessagingPreferences preference added koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -OPACEnhancedMessagingPreferences preference added koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -access to message setting changed Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 20:05:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 18:05:47 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 20:08:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 18:08:55 +0000 Subject: [Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482 --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 29506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29506&action=edit Bug 12482: (QA followup) coding guidelines for hashrefs As of the public coding guidelines, $$variable{key} usage is discouraged. $variable->{key} should be used instead. Btw, honour the "FIXME - Bug 2505" line :-D Regards To+ Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 20:10:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 18:10:43 +0000 Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 20:11:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 18:11:22 +0000 Subject: [Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 20:42:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 18:42:12 +0000 Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff client cart has been deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|paul.poulain at biblibre.com |tomascohen at gmail.com Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 21:16:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 19:16:28 +0000 Subject: [Koha-bugs] [Bug 11064] batch import ignoring framework choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 21:40:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 19:40:59 +0000 Subject: [Koha-bugs] [Bug 5956] Highlight holds on check-in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5956 --- Comment #6 from Viktor Sarge --- Thanks for catching this Nick - that makes revisiting the code a must. I'll look into it but as I'm on vacation right now it might be a while, so if feel free if anyone sees where the patch is lacking. (In reply to Nick Clemens from comment #5) > I tested on a sandbox and found that the highlighting (note in red, not > highlighting of row) only occurs on confirmation of a hold. > > I think the intention is that if someone checks in a reserved book, doesn't > see the message, then checks in a book with no reserves, they would still > see the highlighting even without having confirmed the hold. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 22:04:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 20:04:10 +0000 Subject: [Koha-bugs] [Bug 8567] Set output directory for fines.pl in cron config created by the packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- I know I am a bit late to this, but fines.pl used to always output log files noone knew about, and then we changed it to be optional and driven by a parameter: bug 9656 I am not sure we should bring it back as default for package installations, that are used by a variety of users who will not be aware that patron sensitive data is stored in files somewhere on their servers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 23:09:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 21:09:51 +0000 Subject: [Koha-bugs] [Bug 12529] New: Overdue notices do not respect holidays Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 Bug ID: 12529 Summary: Overdue notices do not respect holidays Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: chris at bigballofwax.co.nz QA Contact: testopia at bugs.koha-community.org If you have holidays defined, and the syspref set, fines will not acrue for overdues when its a holiday. Notices however do not take holidays into account, so they will be sent even if holidays have meant the item is not actually overdue yet This will introduce a syspref, to make the overdue notices take the calendar into account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 23:16:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 21:16:03 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 --- Comment #1 from Chris Cormack --- Created attachment 29507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29507&action=edit Bug 12529: Add a syspref to make overdue notices respect holidays Test Plan Set up some overdue triggers, for example 5,10,15 Set up some holidays Create some items that are past due (one due 5 days, 10 days ago etc) Run the overdue notices script (misc/cronjobs/overdue_notices.pl) Notice holidays are ignored Apply the patch, Switch the OverdueNoticeCalendar syspref to Use calendar Run the overdue notices again Notice holidays are now taken into account Sponsored-by: BSZ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 23:16:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 21:16:00 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 23:25:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 21:25:15 +0000 Subject: [Koha-bugs] [Bug 11426] Make HighlightOwnItemsOnOPAC work with XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11426 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 3 23:46:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 21:46:41 +0000 Subject: [Koha-bugs] [Bug 3013] Value builder for 006 and 008 need choices for all format types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3013 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #26 from Mason James --- (In reply to Ian Walls from comment #25) > Resetting status, as we don't have an updated patch to address the issues > I've noted in comment 23 some good news here... i just searched thru 1 years worth of Koha 'production' error logs (v3.14.6), and could not find Ian's error. perhaps this bug has been somehow resolved? is anyone from Bywater still getting these errors? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 00:47:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 22:47:13 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #35 from Bernardo Gonzalez Kriegel --- (In reply to M. Tompsett from comment #34) > I'd start at comment 25. :) Mmmm, I can finish right now. My friends, what I expect is a clear list of what needs to be tested, or run, and what to expect as result. In that way it's easier. In it's current state is discouraging. Anyway, 1) In it's current state patch doesn't apply. Some patches have been pushed that gave conflicts. I solved all but I prefer the author have the last word on this 2) I run this tests, 2 Ok OK t/db_dependent/Items.t OK t/db_dependent/Search.t but this one not prove t/db_dependent/VirtualShelves_Page.t t/db_dependent/VirtualShelves_Page.t .. 1/3 # Failed test 'opac items XSLT' # at t/db_dependent/VirtualShelves_Page.t line 48. # Failed test 'intranet items XSLT' # at t/db_dependent/VirtualShelves_Page.t line 52. # Looks like you failed 2 tests of 3. t/db_dependent/VirtualShelves_Page.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/3 subtests Test Summary Report ------------------- t/db_dependent/VirtualShelves_Page.t (Wstat: 512 Tests: 3 Failed: 2) Failed tests: 2-3 Non-zero exit status: 2 Files=1, Tests=3, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.68 cusr 0.10 csys = 1.82 CPU) Result: FAIL Please fix and resubmit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 01:34:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jul 2014 23:34:12 +0000 Subject: [Koha-bugs] [Bug 8567] Set output directory for fines.pl in cron config created by the packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 --- Comment #8 from Robin Sheat --- That's a good point, I just remembered the logs in /tmp, I didn't realise they'd gone. The two resolutions would be to revert this, or to modify fines.pl so that just specifying --out doesn't cause logs to be written (i.e. it requires the --log option.) I'm not sure which is the most correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 02:12:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 00:12:04 +0000 Subject: [Koha-bugs] [Bug 12432] Saved reports tabs not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com --- Comment #2 from bondiurbano --- 3.14.8 doesn't work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 03:10:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 01:10:08 +0000 Subject: [Koha-bugs] [Bug 12526] Update shipped Ajaxfileupload.js to latest upstream In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12526 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 03:29:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 01:29:47 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #181 from David Cook --- Comment on attachment 29472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29472 Bug 11703 - Convert checkouts table to ajax datatable Review of attachment 29472: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11703&attachment=29472) ----------------------------------------------------------------- ::: svc/checkouts.pl @@ +3,5 @@ > +# This software is placed under the gnu General Public License, v2 (http://www.gnu.org/licenses/gpl.html) > + > +# Copyright 2014 ByWater Solutions > +# > +# This file is part of Koha. What does this service do exactly? Does it just list current checkouts? Is Jesse going to develop this service further to perform actual checkouts or is he creating a new service for that? If so, I think this service name might be confusing... @@ +19,5 @@ > +# with Koha; if not, write to the Free Software Foundation, Inc., > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > + > +use strict; > +use warnings; Probably should've used Modern::Perl here instead. @@ +94,5 @@ > +if ( @borrowernumber == 1 ) { > + $sql .= '= ?'; > +} > +else { > + $sql = ' IN (' . join( ',', ('?') x @borrowernumber ) . ') '; If @borrowernumber is empty and the environmental variable DEBUG is active, this SQL query would trigger a fatal software error in MySQL/MariaDB. I doubt that many people run with DEBUG on, and this service "should" always be called with at least one borrowernumber parameter, but I think it makes sense to remove the possibility of generating invalid SQL in the first place. Even without DEBUG on, the logs will still contain MySQL errors for invalid SQL syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 03:32:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 01:32:45 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #182 from David Cook --- My question about what this service does was supported to segue into asking for some internal documentation explaining what this service does so that other developers don't necessarily have to read through the code to know its purpose. I don't mean to sound snarky. I need to include more inline comments as well. I just thought I'd point out that that the services could use some more comments :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 03:45:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 01:45:38 +0000 Subject: [Koha-bugs] [Bug 3013] Value builder for 006 and 008 need choices for all format types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3013 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 04:33:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 02:33:10 +0000 Subject: [Koha-bugs] [Bug 12530] New: Remove "reserves" column from "items"/"deleteditems" tables if no longer used Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12530 Bug ID: 12530 Summary: Remove "reserves" column from "items"/"deleteditems" tables if no longer used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Need to check through the code, but I don't think the "reserves" column (which was a counter) is used anymore. We may as well remove it from the schema if it's no longer required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 08:50:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 06:50:53 +0000 Subject: [Koha-bugs] [Bug 8567] Set output directory for fines.pl in cron config created by the packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 --- Comment #9 from Katrin Fischer --- Hi Robin, I am not sure either. Maybe it would be confusing, to have an --out set, but no files would be written. Also, this change could break logging for people who have currently activated it. Maybe we could undo the change? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 09:01:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 07:01:17 +0000 Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition module could order by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Samuel Martin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samuel.n.martin at gmail.com --- Comment #17 from Samuel Martin --- (In reply to mathieu saby from comment #16) > I rebased everything and clean tabs and trailing whistepaces. > It applies, but probably won't work well, as master has evolved since 2011. > So, setting it in dissussion for the moment. > > Mathieu I would say that this bug is very relevant to all larger Libraries. Is it going to be released anytime soon? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 09:21:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 07:21:19 +0000 Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition module could order by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 09:28:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 07:28:40 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Samuel Martin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samuel.n.martin at gmail.com --- Comment #12 from Samuel Martin --- Ran a test on this patch. And I had some issues. I'm no good at programming. But a friend of mine helped me. I thought I could post this to help out others. I hope you'll understand what I mean. I'm new here and more of a librarian than a programmer. So... Here's what we found out: In the file: usr/share/koha/opac/cgi-bin/opac/svc/googleoauth2 there appeared to be some lines missing in the patch at the very beginning of the file. Though the code is available here in this bug. So that was easy to fix. And then we still had some issues. At that time I still had an error 400 straight from google this time. We had to set up the opac URL in: /etc/apache2/conf.d/ I'm not sure if this was supposed to be done before or not. But I had to do it at that time. Also: in the opac-main there is no hint where to log in with the google account. It would be a nice feature that once you use Google Oauth it would say which log in link to use to do that. Maybe even with a google logo? Other than that the patch is working perfectly though I didn't test it extensively. It's only running on my test server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 09:39:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 07:39:15 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #19 from Olli-Antti Kivilahti --- Created attachment 29508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29508&action=edit Bug 7021 - patron category in the statistics table This patch populates the koha.statistics.usercode with borrowers.categorycode where it is easily available. Currently for statistics.type 'issue' OR 'localuse' OR 'renew'. Supplied a script to UPDATE the old statistics records. Have fun! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 09:40:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 07:40:19 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29456|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 10:43:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 08:43:25 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 10:43:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 08:43:33 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #31 from Jonathan Druart --- Created attachment 29509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29509&action=edit Bug 11395: Fix path for the checkboxes jQuery plugin This patch fixes a bad resolution conflict (bug 12107). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 10:45:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 08:45:34 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #32 from Jonathan Druart --- (In reply to Kyle M Hall from comment #30) > GET > http://staff-kohaqa.koha-dev.com/intranettmpl/prog/en/lib/jquery/plugins/ > jquery.checkboxes.min.js 404 (Not Found) batch_record_modification.pl:113 > > Uncaught TypeError: undefined is not a function > batch_record_modification.pl:120 Kyle, thank you for testing! The JS error caused unexpected behaviors. Last patch fixes the path (and the wording issue). All issues you raised should be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 10:46:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 08:46:49 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #20 from Olli-Antti Kivilahti --- Sorry, we are using some ancient version of master by now (but are looking forward to rebasing :) Simply attached this patch in hopes of it being usefull. Looking forward to rebasing into Bug 11230! > However, I'm concerned with the "DB size" issue... Do you know if creating > columns in a table but NOT filling them (it could depend on the activation of a > syspref) will have a significant effect on the size of the database? I recall from my lessons that if you set a static size for a column, it always uses that much space. That way searches are super fast. But I am not a DB specialist. Varchar columns need a separate map to find in which sector/address they reside in. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 10:49:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 08:49:08 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #21 from Olli-Antti Kivilahti --- BTW. We could possibly have a separate Database inside Koha's MySQL/MariaDB just for statistics. That could be easily separated from the main DB and put somewhere with lots of hard drive space. Also that wouldn't complicate Koha installation one bit because we can use same credentials for both DB's by default. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 11:48:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 09:48:45 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 --- Comment #64 from Paola Rossi --- Today I've tried against master 3.17.00.009 After I've replaced [in th 5-th patch to apply, line 274]: "acquisitionprimary" with "acqprimary", "issuesprimary" with "serialsprimary", updating the DB was OK. I've kept the "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 13:16:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 11:16:38 +0000 Subject: [Koha-bugs] [Bug 12531] New: Navigating tabs with keyboard and screen reader Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12531 Bug ID: 12531 Summary: Navigating tabs with keyboard and screen reader Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org While testing bug 11703 with screen reader and braille line, the library reported a problem with navigationt the jQuery UI tabs with the keyboard: What the librarian expected was to jump from one tab heading to the next using shift, then select one with enter. Tab navigation now seems to require that you use the arrow keys, then you can select the tab with enter. But additionally you then have to use 'arrow down' in order for the screen reader to read the contents of the selected tab. Else it will appear that there is no content. This was tested with the tabs on the staff detail page item form and with the tabs in the new 'ajaxy' circulation (holds, relative's checkouts, restrictions). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 14:19:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 12:19:11 +0000 Subject: [Koha-bugs] [Bug 8246] can't delete bibs in big batch delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 14:21:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 12:21:36 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 15:55:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 13:55:05 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #25 from Koha Team Lyon 3 --- I'm disappointed, because I made a lot of tests and everything is OK except I can't see the openurl link when I Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default". It works very well when this sysprefs are empty (tested with two different open resolvers with electronic journals and ebooks.) Two more remarks : I agree with David Cook (Comment 18) : we usually use open url for 2 item types, it would be easier to list only those two and not all the others. It is possible to open the link in a new tab (I activate the syspref OPACOpenInNewWindow, but there is no difference) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 15:56:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 13:56:49 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #26 from Koha Team Lyon 3 --- One detail : I have tested only with the bootstrap theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 16:58:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 14:58:05 +0000 Subject: [Koha-bugs] [Bug 12532] New: Redirect guarantee email to guarantor Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Bug ID: 12532 Summary: Redirect guarantee email to guarantor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: simith.doliveira at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Our sponsor require an adjustment to redirect guarantee email messages to guarantor. All email message placed in message_queue table will be affected: ODUE, HOLD, DUE, PREDUE, CHECKIN, CHECKOUT, RLIST, ACCTDETAILS Sponsor by: ville de victoriaville -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 16:58:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 14:58:40 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com | |, | |simith.doliveira at inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 17:03:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 15:03:39 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #1 from simith.doliveira at inlibro.com --- Created attachment 29510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29510&action=edit Bug 12532 - Redirect guarantee email to guarantor email garantor Modified: C4/Letters.pm -- _send_message_by_email check guarantor C4/Members.pm -- GetNoticeEmailAddress return email guarantor Testing: 0) Enable EnhancedMessagingPreferences preference; 1) Select a patron with child; 2) Enable Item checkout -> email in patron messaging preferences; 3) Select the patron's child; 4) Checkout an item; 5) Valide child checkout message in patron's inbox; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 17:04:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 15:04:04 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 17:04:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 15:04:15 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 17:25:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 15:25:20 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 --- Comment #65 from Jared Camins-Esakov --- (In reply to Paola Rossi from comment #63) > Going on, on editing a vendor an empty contact was always listed before the > filled contacts. So "Save" could add a further contact, whilest "Add another > contact" didn't seem to be needed. > I have not been able to delete one contact from a vendor with multiple > contacts selecting "x Delete contact". I have a patch which fixes the update and the contact deleting. The empty contact is intentional- there should always be one contact visible when you open up the form, because otherwise you might forget to enter any contact information you might have. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 17:42:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 15:42:53 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 17:42:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 15:42:57 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29227|0 |1 is obsolete| | --- Comment #66 from Jared Camins-Esakov --- Created attachment 29511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29511&action=edit Bug 10402 follow-up: choose contacts for claims This patch makes it possible to choose a particular contact for acquisitions and serials claims. To test: 1) Select a contact to use for claiming late orders and a contact to use for claiming late issues. 2) Send a claim for a late order and a claim for a late issue. 3) Note that the claims went out to the proper people. 4) Run the unit test with: > prove t/db_dependent/Letters.t 5) Sign off. Note: the claim messages are recorded in the logs in the *Acquisitions* module, not the Letters module as you might expect This patch also fixes several perlcritic violations and centralizes contact-related unit testing in Bookseller.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 4 20:26:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jul 2014 18:26:16 +0000 Subject: [Koha-bugs] [Bug 12420] syndetics content broken in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12420 --- Comment #9 from Nicole C. Engard --- (In reply to Owen Leonard from comment #8) > (In reply to Nicole C. Engard from comment #7) > > MARC from Al Capone Does My Shirts (paperback): > > > > 020 _a0142403709 > > _c(pbk.) > > This works fine for me. The cover image from Syndetics loads. So - the 10 digit works and the 13 doesn't? Is that what this boils down to? Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 5 16:41:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jul 2014 14:41:14 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I feel like this change of behaviour needs to be optional and needs a bit more thought. Would it be desirable to only cc the guarantor if the guarantee has a real email address? Should an email address on the guarantee record be ignored or take precedence? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 5 16:46:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jul 2014 14:46:45 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer --- I think we won't get around a pref here as people have been using relationships in different ways. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 12:25:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 10:25:36 +0000 Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition module could order by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #18 from mathieu saby --- Hello I'm not working on it anymore. If you or someone else is interested, you can maybe use the existing patch as a base or a source of inspiration. Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 13:37:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 11:37:11 +0000 Subject: [Koha-bugs] [Bug 12533] New: Improve authority search result display Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 Bug ID: 12533 Summary: Improve authority search result display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The current authority search result display can be improved by: 1. Relocate Heading Type (i.e. Personal name, Geographic name) to its own column; 2. Introduce hyperlink to each heading, so users can click them for more information. This will then free up the existing "Detail" column for "Heading Type" above. 3. Rename column heading "Used in" to "Record(s)", and the column simply show number of linked bibliographic record(s). Click on this number will take to the bibliographic concerned, unless there are more than one, then a result summary list will display instead. 4. Column heading name "Action" to replace blank space/missing label above Edit/Merge column. 5. If applicable, insert double dashes (--) between main and subfield headings, so they are displayed like "Australia--History--21st century" instead of "Australia History 21st century"! So much better for reading when doing authority works. 6. The final result will have columns (from left to right): Heading | Type | Record(s) | Action (Edit/Merge) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 18:47:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 16:47:33 +0000 Subject: [Koha-bugs] [Bug 12508] The removal of a contract which is linked to a basket does not display an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 --- Comment #5 from Katrin Fischer --- Created attachment 29512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29512&action=edit [PASSED QA] Bug 12508: adding an error message if a contract cannot be removed If a contract cannot be removed, no errors is displayed. Now, it displays an dialog messag error and the list of contracts. Test plan: 1) Log on with a superlibrarian permission 2) Go on the page acqui/supplier.pl (Acquisitions > Button "New vendor") 3) Record a vendor with a nonzero "name" 4) Go on the page admin/aqcontract.pl (click on the "Contracts" item in the menu) 5) Click on the button "New" > "Contract" and record a new one 6) Click on "New" > "Basket" and record a basket by selectioning the created contract 7) Click on the contract name, then click on the "Contracts" item in the left menu 8) Try to delete this contract, an error is displayed : "Contract has not been deleted. Maybe a basket linked to this contract exists." 9) Delete the basket linked to the contract 10) Delete the contract, no errors is displayed Signed-off-by: Juhani Sepp?l? Signed-off-by: Katrin Fischer Passes QA script an tests. Also tested adding, editing and deleting unused contracts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 18:47:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 16:47:37 +0000 Subject: [Koha-bugs] [Bug 12508] The removal of a contract which is linked to a basket does not display an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 --- Comment #6 from Katrin Fischer --- Created attachment 29513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29513&action=edit Bug 12508: Follow up - corrects capitalization Corrects 2 strings: - 'Delete this contract' - 'Contract deleted' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 18:48:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 16:48:05 +0000 Subject: [Koha-bugs] [Bug 12508] The removal of a contract which is linked to a basket does not display an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 18:48:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 16:48:07 +0000 Subject: [Koha-bugs] [Bug 12508] The removal of a contract which is linked to a basket does not display an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29421|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 18:57:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 16:57:36 +0000 Subject: [Koha-bugs] [Bug 12494] Remove yuipath system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 18:57:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 16:57:38 +0000 Subject: [Koha-bugs] [Bug 12494] Remove yuipath system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29391|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 29514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29514&action=edit [PASSED QA] Bug 12494 - Remove yuipath system preference With the OPAC prog template going away, the only remaining use of the yuipath preference is on the basketgroups template. The yuipath preference should be removed and the local path hard-coded. This patch: - removes yuipath handling from C4/Templates.pm - removes the preference from sysprefs.sql - deletes the preference via updatedatabase.pl - removes the preference from the staff client preferences file - removes unused references to the YUI assets from the help file header include - adds the local YUI asset path to acqui/basketgroup.tt To test, apply the patch and run the database update. View some online help pages and confirm that they function correctly. View the basketgroups page (Acquisition -> Vendor -> Basket groups), edit a basket group, and confirm that basket drag and drop operations work correctly. Signed-off-by: Aleisha Signed-off-by: Katrin Fischer Passes all tests and QA script. Online help and basket group drag&drop functionality still work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:03:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:03:41 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #14 from Katrin Fischer --- The QA script points out a problem with these patches: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt OK tt_valid FAIL valid_template parse error - /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt line 3: unexpected end of directive [% IF ( caller = 'hold-transfer' %] I am fixing this in a follow up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:20:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:20:25 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:20:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:20:28 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27430|0 |1 is obsolete| | Attachment #29463|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 29515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29515&action=edit [PASSED QA] Bug 12062 - Untranslatable "Reserve not found" This patch rewrites transfer slip code to make some strings translatable. Also simplifies some code and parameters. To test: 1) Produce a transfer slip, no changes must be noted. 2) Update PO file, new strings msgid "%s %s%s%sNo hold found%s %s %s " msgid "%s%s%sNo hold found%s " msgid "Koha › Circulation › Transfers" Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:20:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:20:33 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #16 from Katrin Fischer --- Created attachment 29516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29516&action=edit [PASSED QA] Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:20:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:20:37 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 --- Comment #17 from Katrin Fischer --- Created attachment 29517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29517&action=edit Bug 12062: Follow up - adds missing ) With this patch, patches pass QA script and unit tests. Tested printing different slips successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:24:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:24:37 +0000 Subject: [Koha-bugs] [Bug 12499] The module C4::Letters.t needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12499 --- Comment #3 from Katrin Fischer --- Created attachment 29518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29518&action=edit [PASSED QA] Bug 12499: adding units tests for C4::Letters The tests for the subroutines : GetMessageTransportType, EnqueueLetter, SendQueuedMessages, GetQueuedMessages, GetLetters, getletter, addalert, getalert, delalert and GetPreparedLetter of the module C4::Letters have been added. Test plan: 1) Apply the patch 2) Execute the unit tests by launching : prove t/db_dependent/Letters.t 3) The result has to be a success without error or warning : t/db_dependent/Letters.t .. ok All tests successful. Files=1, Tests=45, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.44 cusr 0.08 csys = 1.57 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel All test pass, no errors. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:25:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:25:00 +0000 Subject: [Koha-bugs] [Bug 12499] The module C4::Letters.t needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:25:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:25:03 +0000 Subject: [Koha-bugs] [Bug 12499] The module C4::Letters.t needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29455|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:39:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:39:14 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 --- Comment #17 from Katrin Fischer --- Created attachment 29519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29519&action=edit [PASSED QA] Bug 12151: Remove uses of smartmatch operator in Search.pm and opac-search.pl This patch removes the use of smartmatch operators in the search code. Regards To+ Edit: this revision uses 'grep' instead of Lists::MoreUtils::any Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and QA script. Tested search, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:39:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:39:18 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 --- Comment #18 from Katrin Fischer --- Created attachment 29520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29520&action=edit [PASSED QA] Bug 12151: Remove uses of smartmatch operator in report scripts This patch removes the use of smartmatch operators in report scripts. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes QA script and tests. Acquisition and Patron statistics wizard tested, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:39:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:39:21 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 --- Comment #19 from Katrin Fischer --- Created attachment 29521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29521&action=edit Bug 12151: Remove uses of smartmatch operator from Koha/Solr/QueryBuilder.pm Just that. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes QA script and tests. Could only verify by reading the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:39:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:39:24 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 --- Comment #20 from Katrin Fischer --- Created attachment 29522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29522&action=edit [PASSED QA] Bug 12151: Remove use of smartmatch operator in tools/batchMod.pl The '~~' smartmatch operator is used to compare MARC::Field->subfield(code) (i.e. a string) and the text element of each MARC::Field->subfields() which is also plain text. Substituting '~~' for 'eq' should be harmless then. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes QA script and tests. Tested batch modification of items, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:40:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:40:26 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:40:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:40:28 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29488|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:40:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:40:30 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29489|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:40:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:40:32 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29490|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:40:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:40:34 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29487|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:41:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:41:41 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29521|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 29523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29523&action=edit [PASSED QA] Bug 12151: Remove uses of smartmatch operator from Koha/Solr/QueryBuilder.pm Just that. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes QA script and tests. Could only verify by reading the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 19:53:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 17:53:32 +0000 Subject: [Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #32 from Katrin Fischer --- I feel like it would be better to check for the preference first, so the database is only queried for the rental fee, if it's needed. What do you think? This is the code from the squashed patches: + # + # CHECK IF THERE IS RENTAL CHARGES. RENTAL MUST BE CONFIRMED BY THE BORROWER + # + my ($rentalCharge) = GetIssuingCharges( $item->{'itemnumber'}, $borrower->{'borrowernumber'} ); + my $rentalConfirmation = C4::Context->preference("RentalFeesCheckoutConfirmation"); + + if ( $rentalConfirmation && $rentalCharge != 0 ) + { + $rentalCharge = sprintf("%.02f", $rentalCharge); + $needsconfirmation{RENTALCHARGE} = $rentalCharge; + } For the pref description I think maybe it should be: ask/don't ask 'for confirmation' instead of 'a confirmation'. But as I am not a native speaker myself, you might want to check that with one :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:03:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:03:31 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 --- Comment #10 from Katrin Fischer --- Created attachment 29524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29524&action=edit [PASSED QA] Bug 11030 : add fields 947,969,359 in unimarc_complete french framework This patch must be tested on top of bug 11021 This patch adds 3 fields to unimarc_complete french framework - 359 (2-a-b-c-d-e-f-g-h-i-p-u-v) used by Sudoc network, to be displayed in tab 3 - 947 (c) used by Electre - 969 (a-h) used by Electre I don't know the difference between 969a and 969h so I gave them quite the same name To test : 1) take a fresh Koha with unimarc marcflavor 2) in web installer, select french language, unimarc marflavor and "Grilles de catalogage compl?tes". 3) check default framework in Administration > MARC Frameworks : it should contains 359/947/969 fields Signed-off-by: Gaetan Boisson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:03:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:03:41 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 --- Comment #11 from Katrin Fischer --- Created attachment 29525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29525&action=edit [PASSED QA] Bug 11030 - Add 359, 947 and 969 fields in french unimarc_complete framework - followup Signed-off-by: Gaetan Boisson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:04:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:04:12 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:04:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:04:14 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29412|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:04:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:04:16 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29413|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:05:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:05:54 +0000 Subject: [Koha-bugs] [Bug 12495] Street number missing from hold alert on checkin page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:29:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:29:13 +0000 Subject: [Koha-bugs] [Bug 12495] Street number missing from hold alert on checkin page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:29:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:29:16 +0000 Subject: [Koha-bugs] [Bug 12495] Street number missing from hold alert on checkin page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29380|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 29526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29526&action=edit [PASSED QA] Bug 12495 - Include streetnumber in hold alert address Steetnumber is not included in the addess in the hold alert add the field to those displayed To test this, place a hold on an item that is on-loan, having first made sure that the requesting user has a value in the street number field of his address. Check the item in, and an alert should appear giving the name and address of the requesting user. This address should include the contents of the street number address field. Signed-off-by: Owen Leonard I was able to confirm three of the four template changes for the following cases: - Item placed on hold for a patron at the current library, not waiting - Item placed on hold for a patron at the current library, already waiting - Item placed on hold for a patron at another library, not waiting I don't know how to trigger the case [% IF ( diffbranch ) %]. Signed-off-by: Katrin Fischer Passes QA script and tests. Note: Maybe sample slip templates should also include street number? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:31:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:31:03 +0000 Subject: [Koha-bugs] [Bug 12495] Street number missing from hold alert on checkin page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 --- Comment #7 from Katrin Fischer --- Hi David, I believe this is your first patch - thanks and congratulations :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:37:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:37:25 +0000 Subject: [Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:37:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:37:27 +0000 Subject: [Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29491|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 29527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29527&action=edit [PASSED QA] Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status The template markup that controls that status column for the items table in catalogue/detail.pl does not account for the itemtypes.notforloan flag. Test Plan: 1) Find an item that is currently available 2) Go to the itemtype editor and mark that itemtype of that item as being not for loan 3) Browse to the catalog details page for that item's record 4) Note the item status is still "Available" 5) Apply this patch 6) Reload the catalog details page 7) Note the item status is now "Not for loan" Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Good catch! Works as described, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:43:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:43:00 +0000 Subject: [Koha-bugs] [Bug 12511] Novelist Select not using https in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:43:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:43:03 +0000 Subject: [Koha-bugs] [Bug 12511] Novelist Select not using https in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29410|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 29528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29528&action=edit [PASSED QA] Bug 12511 - Novelist Select not using https in bootstrap In prog we have: [% IF ( NovelistSelectProfile ) %] [% END %] but in bootstrap we have [% IF ( NovelistSelectProfile ) %] [% END %] Because bootstrap isn't using https, we get an error like this: [blocked] The page at 'https://koha.mylibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=105315&query_desc=kw%2Cwrdl%3A%20home' was loaded over HTTPS, but ran insecure content from 'http://imageserver.ebscohost.com/novelistselect/ns2init.js': this content should also be loaded over HTTPS. Test plan would require having a subscription to Novelist Select. I think this is trivial enough to go without. Signed-off-by: Katrin Fischer Very small change, trusting Kyle and the sign-off here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:53:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:53:32 +0000 Subject: [Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- (In reply to Kyle M Hall from comment #2) > Note: UseQueryParser needs to be disabled. I have tested this and with QueryParser set to "Try" my search results are NOT sorted by biblionumber. With QueryParser set to "Do not try" the results are sorted. Is this the expected behaviour? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 20:54:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 18:54:23 +0000 Subject: [Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- Setting to "Failed" - waiting for an answer from Kyle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 21:04:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 19:04:50 +0000 Subject: [Koha-bugs] [Bug 12409] The test t/db_dependent/Record.t fails with Perl 5.18.2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12409 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 21:04:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 19:04:53 +0000 Subject: [Koha-bugs] [Bug 12409] The test t/db_dependent/Record.t fails with Perl 5.18.2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12409 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28848|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 29529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29529&action=edit [PASSED QA] Bug 12409: Fix fields order on exporting to bibtex The C4::Record::marc2bibtex subroutine supposes hashref keys are sorted which is wrong with perl 5.18 Note that the t/db_dependent/Record.t fails without this patch. Test plan (for perl >= 5.18 only): 1/ prove t/db_dependent/Record.t should return green 2/ Try to export a record to bibtex and verify the order is correct (should be author, title, year, published, etc.). http://bugs.koha-community.org/show_bug.cgi?id=12409 Signed-off-by: Bernardo Gonzalez Kriegel Wrong Bug number on heading. Work as described, test pass, no koha-qa errors. The problem is to think that a hash returns keys in a particular order, that's not true and no matter which perl version. Code as was left is... misleading. Comments talks about a hash, which is no more. On array asignment "a => b" is equivalent to "a, b", but the former is usually used on hashes, so a replacement of '=>' by ',' could clarify what are we storing. Signed-off-by: Katrin Fischer Fixing the comments in a follow-up patch. Tests pass now without problems and records export ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 21:05:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 19:05:03 +0000 Subject: [Koha-bugs] [Bug 12409] The test t/db_dependent/Record.t fails with Perl 5.18.2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12409 --- Comment #6 from Katrin Fischer --- Created attachment 29530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29530&action=edit Bug 12409: Follow up - Reflect from hash to array in comments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 21:34:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 19:34:00 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 --- Comment #5 from Katrin Fischer --- Comment on attachment 29494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29494 [SIGNED-OFF] Bug 12493: moving the subroutines GetContract and GetContracts from C4::Acquisition.pm to C4::Contract.pm Review of attachment 29494: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12493&attachment=29494) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +363,5 @@ > my @rows; > for my $basket (@$baskets) { > my @orders = GetOrders( $$basket{basketno} ); > + my $contract = GetContract({ > + contractnumber => $$basket{contractnumber} I know this line existed before, but see here for future reference: http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL5:_Disagreements And maybe fix in a follow up? ::: C4/Contract.pm @@ +21,1 @@ > use strict; When using Modern::Perl you can delete the use strict; and use warnings; lines here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 21:38:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 19:38:26 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Creating a new file like Contract.pm is a good time to perltidy it - there is some mixup between tabs and spaces right at the beginning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 21:45:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 19:45:33 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- I started fixing this, but don't want to touch too many lines, so maybe it's better you do a follow up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 22:12:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 20:12:42 +0000 Subject: [Koha-bugs] [Bug 12429] patron seeing fines codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 22:12:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 20:12:45 +0000 Subject: [Koha-bugs] [Bug 12429] patron seeing fines codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29389|0 |1 is obsolete| | Attachment #29390|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 29531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29531&action=edit [PASSED QA] Bug 12429 [staff client] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the staff client. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and view fines page (Patron details -> Fines) and the pay fines page (Patron details -> Fines -> Pay fines). You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 22:13:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 20:13:01 +0000 Subject: [Koha-bugs] [Bug 12429] patron seeing fines codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 --- Comment #9 from Katrin Fischer --- Created attachment 29532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29532&action=edit [PASSED QA] Bug 12429 [OPAC] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the bootstrap OPAC. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and log in to the OPAC as a user who has existing fines and charges. View the "Your fines" page. You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 22:18:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 20:18:10 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de --- Comment #68 from Katrin Fischer --- Working on this now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 22:25:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 20:25:44 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #69 from Katrin Fischer --- Starting with QA script, unit tests and code review: 1) QA script: FAIL t/db_dependent/Acquisition.t FAIL valid "my" variable $order2 masks earlier declaration in same scope "my" variable $error masks earlier declaration in same scope OK critic OK pod OK forbidden patterns FAIL acqui/cancelorder.pl OK valid FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 8) OK pod OK critic FAIL acqui/addorder.pl OK valid FAIL forbidden patterns forbidden pattern: tab char (line 126) OK pod OK critic 2) Code review a) Not sure here, but should the copyright year be updated? +# Copyright 2011 BibLibre SARL b) Capitalization + + Could you please fix in a follow up? I will then try to come back to this as soon as possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 22:34:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 20:34:25 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #52 from Katrin Fischer --- I am sorry Jonathan, with the changes to circ this will no longer apply :( Maybe another table could be used for the POC to avoid more conflicts while we are tying to work through this? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10212: Columns configuration for tables - Add Colvis files Applying: Bug 10212: Columns configuration for tables Using index info to reconstruct a base tree... M circ/circulation.pl M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/js/datatables.js M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt :223: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/datatables.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/js/datatables.js Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging circ/circulation.pl CONFLICT (content): Merge conflict in circ/circulation.pl Failed to merge in the changes. Patch failed at 0001 Bug 10212: Columns configuration for tables The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-10212-Columns-configuration-for-tables-o21Nap.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 22:43:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 20:43:25 +0000 Subject: [Koha-bugs] [Bug 11399] batch Rebuild Items Tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399 --- Comment #7 from Katrin Fischer --- Comment on attachment 29156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29156 [SIGNED-OFF] Bug 11399: batch Rebuild Items Tables Review of attachment 29156: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11399&attachment=29156) ----------------------------------------------------------------- 2 small things from code review: ::: misc/batchRebuildItemsTables.pl @@ +1,4 @@ > +#!/usr/bin/perl > +use 5.10.0; > +use strict; > +use warnings; Please switch to: use Modern::Perl; :) @@ +94,5 @@ > + } > +} > + > +$dbh->do("UPDATE systempreferences SET value=$CataloguingLog WHERE variable='CataloguingLog'"); > +$dbh->do("UPDATE systempreferences SET value=$dontmerge where variable='dontmerge'"); Please switch to using placeholders instead of variables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 22:43:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 20:43:33 +0000 Subject: [Koha-bugs] [Bug 11399] batch Rebuild Items Tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 22:52:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 20:52:49 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer --- Doing some first tests on this, noticing a few things: 1) The unit tests (yay!) are in a new file Overdues.pl - I think they need to be integrated into Overdues.t or the file should be renamed to be a .t file. 2) While t/db_dependent/Overdues.t passes with the tests, Ovedues.pl does not: bumblebee:~/kohaclone (19-9180-defaultoverduerules) $ perl t/db_dependent/Overdues.pl 1..4 not ok 1 - If a default rule exists, all branches should be returned # Failed test 'If a default rule exists, all branches should be returned' # at t/db_dependent/Overdues.pl line 26. # Structures begin differing at: # $got->[0] = 'TPL' # $expected->[0] = 'FRL' not ok 2 - If a default rule exists and a specific rule exists, all branches should be returned # Failed test 'If a default rule exists and a specific rule exists, all branches should be returned' # at t/db_dependent/Overdues.pl line 36. # Structures begin differing at: # $got->[0] = 'RPL' # $expected->[0] = 'FRL' ok 3 - If only a specific rule exist, only 1 branch should be returned ok 4 - If only 2 specific rules exist, 2 branches should be returned # Looks like you failed 2 tests of 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 22:54:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 20:54:44 +0000 Subject: [Koha-bugs] [Bug 11872] Lost overdue items should not generate fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- Kyle, could you please take a look at Jonathan's and my comments? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 23:14:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 21:14:29 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer --- I took a look at the code (at all 3 patches together) and noticed some small things: 1) Plase use the new isSuperlibrarian instead: unless ($userflags->{superlibrarian} 2) Please update the database update comment: + print "Upgrade to $DBversion done (Add aqorders.branch and permission order_receive_all)\n"; 3) Capitalization I know it's an old line, but could you please fix? + Duplicate Barcode 4) The new test file (thx!) doesn't output any comments. It would be nice to see some more documentation there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 23:17:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 21:17:44 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Katrin Fischer --- Same here as for the other permission, could you please update to use the new superlibrarian check? +if ($userflags->{superlibrarian} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 23:27:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 21:27:09 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #69 from Katrin Fischer --- I fixed the conflicts, but don't want to make too many changes and maybe mistakes. One of the tests fails: # Failed test 'No user permissions to add' # at xt/permissions.t line 95. # User permissions to add in uk-UA/mandatory/permissions_and_user_flags.sql: delete_all_items, edit_items_restricted, items_batchmod_restricted # Failed test 'No user permissions to add' # at xt/permissions.t line 95. # User permissions to add in ru-RU/mandatory/permissions_and_user_flags.sql: delete_all_items, edit_items_restricted, items_batchmod_restricted # Looks like you failed 2 tests of 34. Could you take a look Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 23:29:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 21:29:44 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #60 from Katrin Fischer --- Patch doesn't apply currently: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8064: Merge several biblios Applying: Bug 8064: Change the way target record is built. Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/merge-record-strings.inc M koha-tmpl/intranet-tmpl/prog/en/js/merge-record.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/merge-record.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/js/merge-record.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/merge-record-strings.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/merge-record-strings.inc Failed to merge in the changes. Patch failed at 0001 Bug 8064: Change the way target record is built. The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/SIGNED-OFF-Bug-8064-Change-the-way-target-record-i-ze4drL.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 6 23:30:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jul 2014 21:30:58 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|mtj at kohaaloha.com |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 02:01:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 00:01:04 +0000 Subject: [Koha-bugs] [Bug 12534] New: PROG/CCSR deprecation: Make getlanguages() theme independent for opac Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Bug ID: 12534 Summary: PROG/CCSR deprecation: Make getlanguages() theme independent for opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr getlanguages() function on C4/Languages.pm has a hardcoded reference to 'prog' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 02:04:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 00:04:37 +0000 Subject: [Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323 --- Comment #9 from David Cook --- (In reply to Katrin Fischer from comment #7) > (In reply to Kyle M Hall from comment #2) > > Note: UseQueryParser needs to be disabled. > > I have tested this and with QueryParser set to "Try" my search results are > NOT sorted by biblionumber. > > With QueryParser set to "Do not try" the results are sorted. > > Is this the expected behaviour? This should be the expected behaviour, as the QueryParser doesn't rely on buildQuery for performing relevance searching (relevance searching is built into the QP config). So the QP will have the same results before and after this patch, while non-QP will be very different (i.e. relevance only added when using this patch). Ideally, we would just use QueryParser here (as buildQuery isn't very good at parsing free-form searches), but until we transition more completely to QueryParser, I suppose this makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 02:19:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 00:19:07 +0000 Subject: [Koha-bugs] [Bug 12534] PROG/CCSR deprecation: Make getlanguages() theme independent for opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 29533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29533&action=edit Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac This patch removes a reference to prog theme on getlanguages() for opac when ENV var HTTP_ACCEPT_LANGUAGE is checked. Changed to use 'opacthemes' syspref. To test: 1) Apply the patch 2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc 3) Enable those languages for OPAC on I18N prefs 4) Using Firefox, clean all history/cookies 5) Change variable intl.accept_languages (will do several times) a) got to about:config b) search 'lang' c) look for the variable, double click, change to 'de-DE' 6) Go to opac page, must load in german 7) Repeat for each translated lang: clean > change val > reload opac On each case opac must load on configured language 8) Just to test, set variable on untranslated lang, opac page must load on first value of list of enabled languages 9) prove t/Languages.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 02:20:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 00:20:17 +0000 Subject: [Koha-bugs] [Bug 12534] PROG/CCSR deprecation: Make getlanguages() theme independent for opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 02:24:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 00:24:38 +0000 Subject: [Koha-bugs] [Bug 12534] PROG/CCSR deprecation: Make getlanguages() theme independent for opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 03:39:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 01:39:03 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #37 from M. Tompsett --- Please re-test on something with lots of results. Your result set size is 40 by default, I think. So your results are always going to be less than 40, even if there are thousands of matches. This is the case I am worried about, but don't have time to test. This is what the first tweak worries me about, the second line change looks fine to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 05:37:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 03:37:32 +0000 Subject: [Koha-bugs] [Bug 12535] New: PROG/CCSR Deprecation: Make opac translation theme independent Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Bug ID: 12535 Summary: PROG/CCSR Deprecation: Make opac translation theme independent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Translation scripts have 'prog' hardcoded for OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 05:40:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 03:40:43 +0000 Subject: [Koha-bugs] [Bug 12535] PROG/CCSR Deprecation: Make opac translation theme independent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 29534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29534&action=edit Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent This patch makes opac translation files theme independent A side effect is that current prog translation file is renamed. But the renaming is not added, that gives a patch of ~60M! Current list of languages are now obtained from pref files. To test: 1) Apply the patch 2) For your preferred language, rename opac prog file from 'xx-YY-i-opac-t-prog-v-3006000.po' to 'xx-YY-opac-prog.po' 3) Update that language, there must be no errors cd misc/translation ./translate update xx-YY [-v] Check updated po files 4) Install any language, there must be no errors ./translate install xx-YY Check prog theme for that language 5) Create translation files. Remove a language or create new lang files ./translate create zz-WW ls -l po/zz-WW*po check there are 3 files (and *~) for opac 6) Check updated pod for LangInstaler.pm and translate script When PROG/CCSR themes are removed, I'll add a Bug to remove corresponding files. Perhaps RM could add a followup to rename all files, cd misc/translator/po for old in $(ls *opac-t*); do new=$(echo $old | sed 's/-i-opac-t-prog-v-3006000/-opac-prog/'); git mv $old $new; done -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 05:41:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 03:41:28 +0000 Subject: [Koha-bugs] [Bug 12535] PROG/CCSR Deprecation: Make opac translation theme independent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 06:31:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 04:31:05 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #38 from Katrin Fischer --- Mark, should this be reset to 'needs signoff' then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 09:08:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 07:08:04 +0000 Subject: [Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607 Derryn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |derrynj at gmail.com --- Comment #1 from Derryn --- I was just about to file a bug for this when I saw you had already done so. Just in case anyone needs clarification: To reproduce 1. Tools -> Notices 2. Edit 'Item Due Reminder (Digest)' 3. Tick 'HTML message' 4. Enter <> in the message body. 5. Save 6. Borrow 2 items on an account set up to receive item due email notifications and set the due date as today. 7. Run advance_notices.pl 8. Run process_message_queue.pl 9. Check your email - there will be 2 items on one line, rather than a line break between them. If you repeat the above steps without checking 'HTML message' it does include line breaks. This issue is still present in 3.16 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 09:24:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 07:24:11 +0000 Subject: [Koha-bugs] [Bug 12494] Remove yuipath system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- In my opinion, this patch should not be pushed before bug 12233. It will break ccsr and prog themes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 09:28:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 07:28:48 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #70 from Julian Maurice --- Created attachment 29535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29535&action=edit Bug 7162: Factorize code for order cancellation (QA fixes) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 09:29:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 07:29:19 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 09:50:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 07:50:04 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29535|0 |1 is obsolete| | --- Comment #71 from Julian Maurice --- Created attachment 29536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29536&action=edit Bug 7162: Factorize code for order cancellation (QA fixes) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 10:47:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 08:47:24 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #4 from Olli-Antti Kivilahti --- Hi there Jonathan! Great to be signing off your patches again! I am building batch removal of component parts on top of this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 11:12:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 09:12:48 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #5 from Olli-Antti Kivilahti --- Could you make a C4/Koha-module out of ($op eq 'delete') feature in batch_delete_records.pl? So it would be easier to reuse that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 13:17:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 11:17:22 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29075|0 |1 is obsolete| | Attachment #29076|0 |1 is obsolete| | Attachment #29077|0 |1 is obsolete| | Attachment #29078|0 |1 is obsolete| | Attachment #29079|0 |1 is obsolete| | Attachment #29080|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart --- Created attachment 29537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29537&action=edit Bug 10212: Columns configuration for tables This development introduces ColVis into Koha and provides a configuration page for columns visibility. ColVis is a plugin for DataTables. It allows to change the visibility of the columns in the table. * This development adds: - the js and css file for ColVis - a new DB table 'columns_settings' - a new template plugin 'ColumnsSettings' - a new package C4::Utils::DataTables::ColumnsSettings - a new admin page admin/columns_settings.pl * How it works: A yaml file is created (admin/columns_settings.yml) in order to take an inventory of all tables where ColVis is implemented. This file is read to create the list of modules, pages and tables in the configuration page. There are 3 possible keys in the yml: - is_hidden: default is 0 The column will be hidden. - cannot_be_toggled: default is 0. ColVis will allow to hide/show the column. - cannot_be_modified: default is 0 Default values (in the yml) won't be modifiable. When a user changes (or saves) the configuration for one module, all columns are added to the DB table. The values in the DB get the upper hand on the yaml values. * Humm, strange? It seems weird to have 2 storages for the same values. But I think it will be easy to add an entry and maintain the yaml rather than adding a new row (and new entry in updatedatabase script) in the DB. * To go further: We can imagine that the configuration is saved for each user (and not globally like it is made with this patch). This patch cannot be tested as it, you need to apply the "POC" patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 13:17:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 11:17:30 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #54 from Jonathan Druart --- Created attachment 29538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29538&action=edit Bug 10212: Columns configuration for tables - DB changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 13:17:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 11:17:35 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #55 from Jonathan Druart --- Created attachment 29539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29539&action=edit Bug 10212: Columns configuration for tables - Unit tests test plan: Verify the prove t/db_dependent/ColumnsSettings.t returns green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 13:17:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 11:17:40 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #56 from Jonathan Druart --- Created attachment 29540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29540&action=edit Bug 10212: Columns configuration for tables - Add Colvis files This patch only adds Colvis js and css files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 13:17:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 11:17:45 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #57 from Jonathan Druart --- Created attachment 29541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29541&action=edit Bug 10212: Columns configuration for tables - POC This patch proves that this feature is useful with a concret use case. Test plan: 1/ Execute the updatedatabase in order to create the new table. 2/ Take a look to the yml structure. 3/ Go on the admin currency page (admin/currency.pl). 4/ Check that you cannot hide the 2 first columns on the table. 5/ Try to hide/show columns. 6/ Go on the columns configuration page (admin/columns_settings.pl). 7/ Only the admin tab are filled with data. Check/uncheck checkboxes and save. 8/ Go on the admin currency page and check that the behavior is what you expected. 9/ Give me some feedback :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 13:21:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 11:21:05 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #58 from Jonathan Druart --- I add some significant changes in the last patch set : 1/ Use DBIC 2/ Reorganize patches for a better readability 3/ Remove changes in circ/circulation.pl|tt. I now use admin/currency.tt. Hopefully, this will be easier to maintain (less conflict). This new patch set needs a (quick?) new signoff please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 13:39:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 11:39:28 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #6 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #5) > Could you make a C4/Koha-module out of ($op eq 'delete') feature in > batch_delete_records.pl? > > So it would be easier to reuse that. Hi Olli, There is no important logic in the pl file. Most of the code is error encapsulation. Where do you want to reuse this part of code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 13:53:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 11:53:50 +0000 Subject: [Koha-bugs] [Bug 12536] New: Incorrect number of irregularity issues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12536 Bug ID: 12536 Summary: Incorrect number of irregularity issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: simith.doliveira at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com In Serials -> Planning tab, irregularity is always 1 issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 14:08:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 12:08:59 +0000 Subject: [Koha-bugs] [Bug 12536] Incorrect number of irregularity issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12536 --- Comment #1 from simith.doliveira at inlibro.com --- Created attachment 29542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29542&action=edit Bug 12536 - Incorrect number of irregularity issues Modified: serials/subscription-detail.pl - fix split command Testing: I Apply the patch 0) Select a serial subscription; 1) Click Edit -> Edit subscription; 2) Click Next; 3) Click Test prediction pattern; 4) Select 3 Vols; 5) Save subscription; 6) Select Planing tab; 7) Valide "Irregularity: 3 issues". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 14:09:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 12:09:49 +0000 Subject: [Koha-bugs] [Bug 12536] Incorrect number of irregularity issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12536 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |philippe.blouin at inlibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 14:12:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 12:12:46 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 14:47:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 12:47:20 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #7 from Olli-Antti Kivilahti --- Error encapsulation is important logic. :) Just automatically make a Z39.50 search to find all component parts for a record, then ask does the user want to remove all of them, then remove all of them + parent record. But I got it covered. Component parts don't have items so there are no different states to check for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 14:47:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 12:47:28 +0000 Subject: [Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448 --- Comment #33 from Maxime Beaulieu --- Created attachment 29543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29543&action=edit Bug 12448 - Follow-up to Comment 32. In C4/Circulation.pm, 'GetIssuingCharges' is now called after the syspref is checked. The text for the system preference now reads "When checking out an item with rental fees [ask/don't ask]?for confirmation. modified: C4/Circulation.pm modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 14:48:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 12:48:26 +0000 Subject: [Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 14:56:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 12:56:25 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #23 from Jonathan Druart --- I really don't understand the complexity of this patch. Why do we want to add extra constraints? In my opinion, the fk constraints exist in DB and we don't want to add more. If we keep the constraints introduced by these patch, we get a 1-n and a 1-1 relations for the same field. I know the current structure (biblio/biblioitems/items) has a lack but I don't think it is the good way to solve it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 14:56:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 12:56:58 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 14:59:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 12:59:50 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #24 from Jonathan Druart --- Created attachment 29544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29544&action=edit Bug 11518: WIP - Remove useless constraints previously added This patch removes the 3 constraints added by patch from bug 11518. Having 1-n + 1-1 relations for the same field is a non-sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 15:00:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 13:00:15 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29544|Bug 11518: WIP - Remove |[NOT-PUSHED]Bug 11518: WIP description|useless constraints |- Remove useless |previously added |constraints previously | |added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 15:03:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 13:03:23 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #14 from Bernardo Gonzalez Kriegel --- (In reply to Julian Maurice from comment #13) > Can you look at the log file ? Maybe there's a clue in it. Julian, tested and works well. Test pass and no koha-qa errors. (was a problem on my side) But... you are touching some opac prog files As we are on PROG/CCSR deprecation, and this is a new feature, those will never be included. Could you reset those files? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 15:19:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 13:19:08 +0000 Subject: [Koha-bugs] [Bug 12499] The module C4::Letters.t needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12499 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 15:19:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 13:19:27 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Tom?s Cohen Arazi --- Patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 15:20:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 13:20:32 +0000 Subject: [Koha-bugs] [Bug 12409] The test t/db_dependent/Record.t fails with Perl 5.18.2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12409 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 15:39:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 13:39:51 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27940|0 |1 is obsolete| | Attachment #27941|0 |1 is obsolete| | Attachment #27942|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 29545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29545&action=edit Bug 11904: New module Koha::Messages This patch provides a uniform way to send messages to user interface. It uses CGI::Session to store messages and allow to render them thanks to a Template::Toolkit plugin (Koha::Template::Plugin::Messages) and a template include file (messages.inc) This patch doesn't introduce the new template include file anywhere. It will require additional patches to make it work. To use it, simply call messages_set() in a Perl script or module, then put [% INCLUDE 'messages.inc' %] at the right place in the right template file. See POD documentation of Koha::Messages for more information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 15:39:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 13:39:59 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #16 from Jonathan Druart --- Created attachment 29546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29546&action=edit Bug 11904: Unit tests for Koha::Messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 15:40:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 13:40:06 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #17 from Jonathan Druart --- Created attachment 29547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29547&action=edit Bug 11904: Example usage of new module Koha::Messages Test plan: 1/ Go to members/moremember.pl 2/ Click on "More" -> "Renew patron" and confirm 3/ A message should appear "Patron's account has been renewed until ..." 4/ In a shell, go to misc/translator and run ./translate create fr-FR (or ./translate update fr-FR) ./translate install fr-FR (you can use your own language of course) 5/ Edit po/fr-FR-messages.po and translate the string "Patron's account has been renewed until ..." 6/ In staff interface change language to French and renew patron once again. 7/ The translated message should appear. Needs patches from bugs 8044 and 11848 for string translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 15:41:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 13:41:06 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #18 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #14) > But... you are touching some opac prog files > As we are on PROG/CCSR deprecation, and this is a new feature, > those will never be included. > > Could you reset those files? Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 15:59:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 13:59:36 +0000 Subject: [Koha-bugs] [Bug 12495] Street number missing from hold alert on checkin page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:01:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:01:26 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:01:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:01:27 +0000 Subject: [Koha-bugs] [Bug 12495] Street number missing from hold alert on checkin page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks, and congratulations David! Note: a discussion on how to compose addresses with different naming schemas (a.k.a. 'localized') is in place, but belongs to another bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:01:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:01:29 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25947|0 |1 is obsolete| | Attachment #27427|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 29548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29548&action=edit Bug 9180: All branches should be returned if a default rule exists The C4::Overdues::GetBranchcodesWithOverdueRules routine has a bug. If a default rule *and* a specific rule exist, only the branchcode for the specific rule is returned. Test plan: prove t/db_dependent/Overdues.t and verify the unit tests are consistent. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:01:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:01:44 +0000 Subject: [Koha-bugs] [Bug 12511] Novelist Select not using https in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:02:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:02:07 +0000 Subject: [Koha-bugs] [Bug 12062] Untranslatable "Reserve not found" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #18 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Bernardo and Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:03:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:03:07 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl | --- Comment #25 from Jonathan Druart --- (In reply to Katrin Fischer from comment #23) > Doing some first tests on this, noticing a few things: > > 1) The unit tests (yay!) are in a new file Overdues.pl - I think they need > to be integrated into Overdues.t or the file should be renamed to be a .t > file. I really don't understand what I did... I squashed the patches, rename the unit tests file and added a "sort" on comparing the array (this fixes the test failures). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:14:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:14:45 +0000 Subject: [Koha-bugs] [Bug 12537] New: editions tab showing on bibs with more than one ISBN Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 Bug ID: 12537 Summary: editions tab showing on bibs with more than one ISBN Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 29549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29549&action=edit editions tab showing When a record has more than one ISBN it shows the Editions tab in the OPAC and it links to the exact same record. It's not a different edition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:16:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:16:23 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:16:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:16:28 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #70 from Jonathan Druart --- Created attachment 29550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29550&action=edit Bug 7673: DB changes - (follow-up) Add permissions Add permissions for ru-RU and uk-UA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:20:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:20:27 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #39 from M. Tompsett --- I haven't tested, so I can't say whether or not I am right or wrong. I'm just providing a test case in which I think it will fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:44:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:44:07 +0000 Subject: [Koha-bugs] [Bug 12538] New: Solr removal Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 Bug ID: 12538 Summary: Solr removal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Since nobody is currently working on the zebra layer introduced by bug 8233, Solr won't never work. Some code has been introduced in 3.10 to prove several search engines can cohabit into Koha but no help/fund has been found to go ahead. It is useless to keep this code and to maintain an ambiguous situation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:44:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:44:26 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |8233 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:44:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:44:26 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12538 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:54:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:54:56 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:54:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:54:59 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 --- Comment #1 from Jonathan Druart --- Created attachment 29551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29551&action=edit Bug 12538: Remove Solr without breaking anything else Since nobody is currently working on the zebra layer introduced by bug 8233, Solr won't never work. Some code has been introduced in 3.10 to prove several search engines can cohabit into Koha but no help/fund has been found to go ahead. It is useless to keep this code and to maintain an ambiguous situation. I think the indexes configuration page could be restore later if someone else introduces a new search engine into Koha. Test plan: Look at the code introduced by bug 8233 and verify all is removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:55:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:55:39 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29545|0 |1 is obsolete| | --- Comment #19 from Bernardo Gonzalez Kriegel --- Created attachment 29552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29552&action=edit [SIGNED-OFF] Bug 11904: New module Koha::Messages This patch provides a uniform way to send messages to user interface. It uses CGI::Session to store messages and allow to render them thanks to a Template::Toolkit plugin (Koha::Template::Plugin::Messages) and a template include file (messages.inc) This patch doesn't introduce the new template include file anywhere. It will require additional patches to make it work. To use it, simply call messages_set() in a Perl script or module, then put [% INCLUDE 'messages.inc' %] at the right place in the right template file. See POD documentation of Koha::Messages for more information. Signed-off-by: Bernardo Gonzalez Kriegel Originally there was a conflict on bootstrap less/opac.less and css/opac.css, not now, but can't access git at this moment. No errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:55:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:55:48 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29546|0 |1 is obsolete| | --- Comment #20 from Bernardo Gonzalez Kriegel --- Created attachment 29553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29553&action=edit [SIGNED-OFF] Bug 11904: Unit tests for Koha::Messages Signed-off-by: Bernardo Gonzalez Kriegel Test pass, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 16:55:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 14:55:56 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29547|0 |1 is obsolete| | --- Comment #21 from Bernardo Gonzalez Kriegel --- Created attachment 29554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29554&action=edit [SIGNED-OFF] Bug 11904: Example usage of new module Koha::Messages Test plan: 1/ Go to members/moremember.pl 2/ Click on "More" -> "Renew patron" and confirm 3/ A message should appear "Patron's account has been renewed until ..." 4/ In a shell, go to misc/translator and run ./translate create fr-FR (or ./translate update fr-FR) ./translate install fr-FR (you can use your own language of course) 5/ Edit po/fr-FR-messages.po and translate the string "Patron's account has been renewed until ..." 6/ In staff interface change language to French and renew patron once again. 7/ The translated message should appear. Needs patches from bugs 8044 and 11848 for string translation Signed-off-by: Bernardo Gonzalez Kriegel Bugs 8044 and 11484 already in master Tested using es-ES, works as described. No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 17:00:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 15:00:16 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 17:14:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 15:14:44 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |z.tajoli at cineca.it --- Comment #2 from Zeno Tajoli --- Hi, it is not to coordinate this bug with 12478 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 17:35:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 15:35:33 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12538 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 17:35:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 15:35:33 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12478 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 17:44:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 15:44:51 +0000 Subject: [Koha-bugs] [Bug 12429] patron seeing fines codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 17:46:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 15:46:24 +0000 Subject: [Koha-bugs] [Bug 11650] multiplicated authorities after link_bibs_to_authorities.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11650 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Janusz! Note: we need unit tests for this kind of patches. The change looks simple and easy to spot. I pushed it because it was simple, and noticed we don't have the glue to write tests for this in t/db_dependent/Biblio.t (yet :-D) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 17:56:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 15:56:46 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Hi Jonathan, FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 6) Captured by your own code :) [http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868#c4] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 18:09:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 16:09:57 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi at cineca.it --- Comment #33 from Paola Rossi --- Today I've tried to test the patches against master 3.17.00.009 I've applied: 5 patches of 11319, 3 patches of 11914, and the 8 patches of the current 11395. I've found three errors. 1) ERROR on MARC modification templates: unavailable "Every" option: I've edited this action: Copy field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / Then I've changed all the 650-s into 750-s. I see "All" becoming "Every" (I have not understood why it has happened). I've saved, and I've editing the action again: now "All" is shown. I've not been able to set "Every" option. I think that showing "Every" is an error, or there's a lack in managing that option (see C) below). So I've passed the patch to "Failed QA" status. -------------------------------------------------------------------- 2) On Batch record modification [and on cart Action Modify too], I've cleared all the listed records. I've selected "Modify the selected records". Instead of "No record was selected", the program has started, and then has ended showing: "All records have successfully been modified! ". -------------------------------------------------------------------- 3) ERROR on batch_record_modification.pl [I've checked only "Preview MARC"]: case of repeteable subfield [x] in repeteable fields [650]: My biblio record had 3 fields 650, each one had 3 $x: 650 0 ...... _x1-650 x 1 Digital techniques 1 _xfirst 650, second $x _x1-650 x 3 Digital techniques 3 650 0 ........ _x2-650 x 1 Digital techniques 1 _xsecond 650, second $x _x2-650 x 3 Digital techniques 3 650 0 ...... _x3-650 x 1 Digital techniques 1 _xthird 650, second $x _x3-650 x 3 Digital techniques 3 I wanted to delete only the second occurrence of $x, only in the second occurrence of 650 field. So my action was: (A) Delete field 650$x if 650$x matches RegEx m/ ^second 650 / On preview MARC the result is not what I wanted, but: 650 0 ... _x1-650 x 1 Digital techniques 1 _xfirst 650, second $x _x1-650 x 3 Digital techniques 3 650 0 .... 650 0 .... _x3-650 x 1 Digital techniques 1 _xthird 650, second $x _x3-650 x 3 Digital techniques 3 Then I've tried another action, selecting the "first" option: B) Delete 1st field 650$x if 650$x matches RegEx m/ ^second 650 / but the result remained the same as for "All" (A). Neither the 2 negative forms gave me what I wanted: C) Delete field 650$x unless 650$x does not match RegEx m/ ^second 650 / D) Delete 1st field 650$x unless 650$x does not match RegEx m/ ^second 650 / Similar behaviours occurred in Copy, Update and Move cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 19:24:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 17:24:46 +0000 Subject: [Koha-bugs] [Bug 12534] PROG/CCSR deprecation: Make getlanguages() theme independent for opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29533|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 29555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29555&action=edit Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac This patch removes a reference to prog theme on getlanguages() when ENV var HTTP_ACCEPT_LANGUAGE is checked. Changed to use sysprefs to find theme for opac and intranet To test: 1) Apply the patch 2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc 3) Enable those languages for OPAC on I18N prefs 4) Using Firefox, clean all history/cookies 5) Change variable intl.accept_languages (will do several times) a) got to about:config b) search 'lang' c) look for the variable, double click, change to 'de-DE' 6) Go to opac page, must load in german 7) Repeat for each translated lang: clean > change val > reload opac On each case opac must load on configured language 8) Just to test, set variable on untranslated lang, opac page must load on first value of list of enabled languages 9) prove t/Languages.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 19:32:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 17:32:24 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 20:32:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 18:32:41 +0000 Subject: [Koha-bugs] [Bug 9245] Visual Bug under fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Viktor! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 21:15:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 19:15:27 +0000 Subject: [Koha-bugs] [Bug 12494] Remove yuipath system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Oh, what did I miss? I had tested a few pages in staff, are we still using yui in OPAC? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 22:16:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 20:16:00 +0000 Subject: [Koha-bugs] [Bug 12539] New: PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12539 Bug ID: 12539 Summary: PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org C4/Templates.pm has hardcoded theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 22:21:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 20:21:35 +0000 Subject: [Koha-bugs] [Bug 12539] PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12539 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 29556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29556&action=edit Bug 12539: PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm This patch removes hardcoded 'prog' from themelanguage on C4/Templates.pm Now that function only provides a fallback to 'en' on active theme (opac & intranet) Also removes a test already done on themelanguage This also breaks definitely CCSR To test: 1) Apply the patch 2) CCSR is now broken, prog & bootstrap must work as usual 3) Need to test language fallback a) translate for your preferred language (xx-YY) b) enable language on opac c) go to opac, select that language d) login on opac, go to personal details e) remove koha-tmpl/opac-tmpl/bootstrap/xx-YY/modules/opac-memberentry.tt d) reload page, must load in English f) click other member options, must load on translated language (can use other pages, prog or bootstrap) 4) Do a similar test but for a staff page, enable lang, switch to it, rm koha-tmpl/intranet-tmpl/prog/xx-YY/modules/admin/admin-home.tt, any page must be translated except for admin home. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 7 22:22:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 20:22:09 +0000 Subject: [Koha-bugs] [Bug 12539] PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12539 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 01:21:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jul 2014 23:21:23 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 02:34:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 00:34:42 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- I think it will need to take 12478 into consideration, the code for which is in a public branch already. But I dont think this is contigent on that, it just should make sure that removing the Solr code doesnt break the Elasticsearch stuff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 06:11:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 04:11:37 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26499|0 |1 is obsolete| | --- Comment #36 from Srdjan Jankovic --- Created attachment 29557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29557&action=edit bug_11213: Changed XSLTParse4Display() interface The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. * XSLT::XSLTParse4Display() - supply the items list as input param - removed hidden items list param - hidden should not be in the items list - changed buildKohaItemsNamespace() accordingly * Items - removed GetItemsLocationInfo() - added sort_by input param to GetItemsInfo() - VirtualShelves::Page::shelfpage() - replaced GetItemsLocationInfo() call with GetItemsInfo() call, passing order_by "cn_sort" * catalogue/detail.pl, opac/opac-detail.pl, shelfpage() - added items list to the XSLTParse4Display() call * Search::searchResults() - include all available info when building items lists - added combined items list (available, on loan, other) to the XSLTParse4Display() call To test: This change is a noop, so following screens need to be checked against any changes: * Intranet: - catalogue/search.pl (results) - catalogue/detail.pl - virtualshelves/shelves.pl * Opac - opac-search.pl (results, hidelostitems syspref on and off) - opac-detail.pl - opac-shelves.pl The display should stay the same before and after patch. The speed should increase though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 06:12:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 04:12:14 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26500|0 |1 is obsolete| | --- Comment #37 from Srdjan Jankovic --- Created attachment 29558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29558&action=edit bug_11213: whitespace correction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 06:12:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 04:12:29 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26695|0 |1 is obsolete| | --- Comment #38 from Srdjan Jankovic --- Created attachment 29559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29559&action=edit bug_11213: Include XSLT processing for searchResults() test * Added template paths to temp test dir, so XSLT templates can be picked up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 06:12:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 04:12:39 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26713|0 |1 is obsolete| | --- Comment #39 from Srdjan Jankovic --- Created attachment 29560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29560&action=edit bug_11213: C4::VirtualShelves::Page::shelf_contents() * Extracted shelf items processing from shelfpage() into a separate sub shelf_contents() in order to be able to test it * Added tests for shelf_contents() with XSLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 06:12:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 04:12:49 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26718|0 |1 is obsolete| | --- Comment #40 from Srdjan Jankovic --- Created attachment 29561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29561&action=edit bug_11213: Use branch codes from the database rather than hardcoded CPL and MPL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 06:13:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 04:13:03 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26719|0 |1 is obsolete| | --- Comment #41 from Srdjan Jankovic --- Created attachment 29562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29562&action=edit bug_11213: GetItemsInfo() test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 06:13:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 04:13:18 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26720|0 |1 is obsolete| | --- Comment #42 from Srdjan Jankovic --- Created attachment 29563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29563&action=edit bug_11213: Added XSLTParse4Display() to Items test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 06:15:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 04:15:32 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 06:15:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 04:15:35 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26721|0 |1 is obsolete| | --- Comment #43 from Srdjan Jankovic --- Created attachment 29564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29564&action=edit bug_11213: Check for $item->{itype} presence to avoid warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 06:41:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 04:41:17 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 --- Comment #4 from Zeno Tajoli --- Yes, for example bug 12478 uses the system preference 'SearchEngine' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 06:47:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 04:47:38 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #44 from Srdjan Jankovic --- (In reply to Bernardo Gonzalez Kriegel from comment #35) > (In reply to M. Tompsett from comment #34) > > I'd start at comment 25. :) * GetItemsInfo() is getting called in t/db_dependent/Items.t: bug_11213: GetItemsInfo() test * searchResults() is already being called from t/db_dependent/Search.t; XSLTResultsDisplay pref handling in the test should make sure the code is visited: bug_11213: Include XSLT processing for searchResults() test * shelfpage() did not have a test, and I can add one * XSLTParse4Display() is being explicitly called in t/db_dependent/Items.t > > Mmmm, I can finish right now. > > My friends, what I expect is a clear list of what needs to be tested, > or run, and what to expect as result. In that way it's easier. > In it's current state is discouraging. Clear list of what is expected is impossible, at least for me, to give. I cannot even imagine in what different ways particular configs can affect XSLT display. The best I can do is: * Create tests that should pass. In this case we have (in t/db_dependent): Items.t Search.t VirtualShelves_Page.t (will add shelfpage() call) * Ask for XSLT display on OPAC and Intranet related pages to be checked, which includes: - search results - individual biblio + items display - virtual shelves > > Anyway, > 1) In it's current state patch doesn't apply. Some patches have been pushed > that gave conflicts. I solved all but I prefer the author have the last word > on this Rebased > > 2) prove t/db_dependent/VirtualShelves_Page.t > t/db_dependent/VirtualShelves_Page.t .. 1/3 > # Failed test 'opac items XSLT' > # at t/db_dependent/VirtualShelves_Page.t line 48. > Please fix and resubmit. That one worked for me after rebase. Can you please try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 07:54:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 05:54:36 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 --- Comment #8 from mathieu saby --- In fact I already made a bug for this issue in 2013 : Bug 11229 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 07:54:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 05:54:57 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11229 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 07:54:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 05:54:57 +0000 Subject: [Koha-bugs] [Bug 11229] Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment and makepayment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11230 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 07:55:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 05:55:07 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 08:58:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 06:58:59 +0000 Subject: [Koha-bugs] [Bug 12494] Remove yuipath system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 --- Comment #7 from Jonathan Druart --- git grep yuipath returns: koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc: koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc: koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc: koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc: koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc: koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc: koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt: koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt: koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 09:00:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 07:00:52 +0000 Subject: [Koha-bugs] [Bug 12494] Remove yuipath system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 --- Comment #8 from Katrin Fischer --- I need to get better with grep - thx for catching this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 09:11:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 07:11:18 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28764|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 29565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29565&action=edit Bug 12403: Add a batch record deletion This patch offers a new tool for deleting records. Biblios and authorities will can to be deleted with a simple list of biblionumber or authid. This feature adds: - a new pl/tt files tools/batch_delete_records - a new permission: tools > records_batchdel Test plan for biblios: 1/ There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Delete" - generating a list from a report 2/ On the "Batch record deletion" tool verify: - biblios with issues cannot be deleted (checkbox disabled and line in red). - information is correct. - sort functions work on each columns. - the items, reserves and issues values are correct. 3/ After clicking on the "Delete selected recors" button, verify: - reserves, items and biblio have successful been deleted. - if an error occurs, the tool display an error message. Test plan for authority: 1/ Generate a list of authid using a report: 2/ On the "Batch record deletion" tool verify: - authorities are display with the summary. - the count usage (used in X biblios) is correct. 3/ After clicking on the "Delete selected recors" button, verify: - The authorities have successful been deleted. - if an error occurs, the tool display an error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 09:11:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 07:11:22 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28765|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 29566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29566&action=edit Bug 12403: Add the new permission tools_records_batchdelitem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 09:11:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 07:11:27 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28766|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 29567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29567&action=edit Bug 12403: Don't check disabled checkboxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 09:17:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 07:17:40 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #8) > Captured by your own code :) > [http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868#c4] Ooops :) Actually I rebased this patch from an old version and I forgot to launch the qa script. Note that the qa script still raises an error: FAIL tools/batch_delete_records.pl FAIL valid Smartmatch is experimental Useless use of '\'; doesn't escape metacharacter '(' But it is not relevant, it's just because the script uses C4::Authorities (which raises this warning). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 09:23:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 07:23:26 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 Yohann Dufour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 09:23:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 07:23:29 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 --- Comment #8 from Yohann Dufour --- Created attachment 29568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29568&action=edit [FOLLOW UP] Bug 12493 : moving the subroutines GetContract and GetContracts from C4::Acquisition.pm to C4::Contract.pm Fix in order to respect the coding guidelines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 09:25:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 07:25:57 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 --- Comment #9 from Yohann Dufour --- Katrin, I've tested my commit with the tools koha-qa.pl but it doesn't detect tabs or spaces, and I've not found the mixup you said. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 09:38:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 07:38:41 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 --- Comment #10 from Katrin Fischer --- Hi Yohann, you are right, I thought Contract.pm was new, but it isn't - sorry for that and thx for your follow-up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 10:16:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 08:16:46 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #34 from Jonathan Druart --- (In reply to Paola Rossi from comment #33) > Today I've tried to test the patches against master 3.17.00.009 Paola, Thank you for testing! > 1) ERROR on MARC modification templates: unavailable "Every" option: Yes, maybe it's is not obvious. Actually if the condition is on the same field, the tool won't process "all" field, but only the ones matching the condition. I preferred to change to "all" value with something clearer. I consider what you described as a very minor issue (it's just ergonomic). So I prefer not to fix it for now but I keep it in my mind. > 2) On Batch record modification [and on cart Action Modify too], I've > cleared all the listed records. > I've selected "Modify the selected records". Instead of "No record was > selected", the program has started, and then has ended showing: > "All records have successfully been modified! ". It's definitely an issue for this bug report, patch coming... > 3) ERROR on batch_record_modification.pl [I've checked only "Preview MARC"]: > case of repeteable subfield [x] in repeteable fields [650]: I will have a look at this but it's not for this bug report. I will open a new bug for that (linked to bug 11413 and bug 11319). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 10:17:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 08:17:21 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 10:17:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 08:17:34 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #35 from Jonathan Druart --- Created attachment 29569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29569&action=edit Bug 11395: prevent processing no record If no record is selected, the modification should not be launched. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 10:21:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 08:21:55 +0000 Subject: [Koha-bugs] [Bug 12540] New: Batch modifications for records - unavailable "Every" option Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Bug ID: 12540 Summary: Batch modifications for records - unavailable "Every" option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Paola found the following error on testing bug 11395 comment 33: ERROR on MARC modification templates: unavailable "Every" option: I've edited this action: Copy field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / Then I've changed all the 650-s into 750-s. I see "All" becoming "Every" (I have not understood why it has happened). I've saved, and I've editing the action again: now "All" is shown. I've not been able to set "Every" option. I think that showing "Every" is an error, or there's a lack in managing that option (see C) below). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 10:22:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 08:22:07 +0000 Subject: [Koha-bugs] [Bug 12540] Batch modifications for records - unavailable "Every" option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11395 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 10:22:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 08:22:07 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12540 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 10:26:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 08:26:40 +0000 Subject: [Koha-bugs] [Bug 12541] New: Marc modification template - empty field Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541 Bug ID: 12541 Summary: Marc modification template - empty field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Paola found the following bug on testing bug 11395 comment 33: ERROR on batch_record_modification.pl [I've checked only "Preview MARC"]: case of repeteable subfield [x] in repeteable fields [650]: My biblio record had 3 fields 650, each one had 3 $x: 650 0 ...... _x1-650 x 1 Digital techniques 1 _xfirst 650, second $x _x1-650 x 3 Digital techniques 3 650 0 ........ _x2-650 x 1 Digital techniques 1 _xsecond 650, second $x _x2-650 x 3 Digital techniques 3 650 0 ...... _x3-650 x 1 Digital techniques 1 _xthird 650, second $x _x3-650 x 3 Digital techniques 3 I wanted to delete only the second occurrence of $x, only in the second occurrence of 650 field. So my action was: (A) Delete field 650$x if 650$x matches RegEx m/ ^second 650 / On preview MARC the result is not what I wanted, but: 650 0 ... _x1-650 x 1 Digital techniques 1 _xfirst 650, second $x _x1-650 x 3 Digital techniques 3 650 0 .... 650 0 .... _x3-650 x 1 Digital techniques 1 _xthird 650, second $x _x3-650 x 3 Digital techniques 3 Then I've tried another action, selecting the "first" option: B) Delete 1st field 650$x if 650$x matches RegEx m/ ^second 650 / but the result remained the same as for "All" (A). Neither the 2 negative forms gave me what I wanted: C) Delete field 650$x unless 650$x does not match RegEx m/ ^second 650 / D) Delete 1st field 650$x unless 650$x does not match RegEx m/ ^second 650 / Similar behaviours occurred in Copy, Update and Move cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 10:27:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 08:27:38 +0000 Subject: [Koha-bugs] [Bug 12541] Marc modification template - empty field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |11413, 11319 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 10:27:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 08:27:38 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12541 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 10:27:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 08:27:38 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12541 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 10:27:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 08:27:45 +0000 Subject: [Koha-bugs] [Bug 12541] Marc modification template - empty field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 10:45:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 08:45:00 +0000 Subject: [Koha-bugs] [Bug 12541] Marc modification template - multivalued subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |paola.rossi at cineca.it Resolution|--- |LATER Summary|Marc modification template |Marc modification template |- empty field |- multivalued subfields --- Comment #1 from Jonathan Druart --- Paola, This is the expected behavior. In master (without bug 11319 and bug 11413), your action will delete *all* 650$x if at least one 650$x matches the condition (even 650$x from other 650 fields). What you try to do is a special case (at least for the code), you want to delete/update/move a multivalued subfield containing a specific value. This special could be take into account later, but it is not in my todo list for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 11:16:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 09:16:23 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #67 from Paola Rossi --- I've tried to apply against master 3.17.00.009 Applying: Bug 10402 follow-up: choose contacts for claims Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Letters.t CONFLICT (content): Merge conflict in t/db_dependent/Letters.t Auto-merging t/db_dependent/Bookseller.t Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Failed to merge in the changes. So I've passed the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 12:07:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 10:07:28 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #68 from Paola Rossi --- [I beg your pardon.] I've tried to apply against master 3.17.00.009 Applying: Bug 10402 follow-up: choose contacts for claims Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Letters.t CONFLICT (content): Merge conflict in t/db_dependent/Letters.t Auto-merging t/db_dependent/Bookseller.t Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Failed to merge in the changes. I've passed the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 12:37:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 10:37:28 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28951|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart --- Created attachment 29570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29570&action=edit BZ7677: New areas in subscriptions and new functions when receiving. When enabling the makePreviousSerialAvailable syspref, the previously received serial's itemtype is set as defined in the subscription. (Please note that the item-level_itypes syspref must be set to specific item.) It is also made available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 12:37:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 10:37:35 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28952|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart --- Created attachment 29571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29571&action=edit Bug 7677: FIX QA issues FAIL C4/Serials.pm FAIL forbidden patterns forbidden pattern: trailing space char (line 1501) forbidden pattern: trailing space char (line 921) FAIL serials/serials-edit.pl FAIL valid "my" variable $dbh masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 12:37:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 10:37:41 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28953|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart --- Created attachment 29572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29572&action=edit BZ7677 [Follow-up]: New areas in subscriptions and new functions when receiving. - Make the newly received serial gets its default itemtype from the subscription. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 12:38:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 10:38:21 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #37 from Jonathan Druart --- rebased patches (updatedatabase conflict). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 14:59:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 12:59:01 +0000 Subject: [Koha-bugs] [Bug 12494] Remove yuipath system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 --- Comment #9 from Owen Leonard --- This patch doesn't touch the prog and ccsr templates because it is dependent on their removal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 15:31:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 13:31:12 +0000 Subject: [Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #13 from Jonathan Druart --- (In reply to David Cook from comment #12) > Should this be marked as Passed QA now? Yes, sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 15:47:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 13:47:11 +0000 Subject: [Koha-bugs] [Bug 12542] New: Tabs inconsistency in different circ-menu.inc uses Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 Bug ID: 12542 Summary: Tabs inconsistency in different circ-menu.inc uses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com There is a high degree of inconsistency in the circulation tabs. Pick anyone and some new will appear or dissapear. To reproduce: - Go to a user's detail page - Change tab (the vertical ones). - Notice that each time you choose another tab, some dissapear, some show. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 15:47:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 13:47:20 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 15:48:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 13:48:29 +0000 Subject: [Koha-bugs] [Bug 12332] purchase-suggestions.pl tabs do not show selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com Version|unspecified |master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Viktor! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 15:53:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 13:53:07 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #2 from Kyle M Hall --- Created attachment 29573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29573&action=edit Bug 1861 - Unique patrons logins not (totally) enforced The Koha 3.0 patron admin page will prevent you from creating a user who has an identical OPAC login as someone else (though I would change the error message from "Login/password already exists." to "Login already exists.", since it's not the password that's the problem). However, there's nothing enforced in the MySQL database to prevent patrons from being imported or manually inserted with duplicate logins. Would it be better to change the MySQL spec from this: KEY `userid` (`userid`) to this: UNIQUE KEY `userid` (`userid`) Test plan: 1) Enter mysql console 2) Attempt to create two borrowers with identical user id's 3) Note you are able to do so 4) Delete these bororwers 5) Apply this patch 6) Run updatedatabase.pl 7) Repeat step 2 8) Note you are now unable to do so -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 15:53:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 13:53:21 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle at bywatersolutions.com Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 16:00:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 14:00:07 +0000 Subject: [Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Are we introducing problems for Plack? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 16:25:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 14:25:28 +0000 Subject: [Koha-bugs] [Bug 12543] New: Add userid as matchpoint for "Import patrons" tool Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543 Bug ID: 12543 Summary: Add userid as matchpoint for "Import patrons" tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The a patron's userid should be a matchpoint in the same manner as cardnumber. Though not enforced as a unique key by the database yet ( pending bug 1861 ), this field is effectively unique as uniqueness is enforced by Koha itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 16:25:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 14:25:37 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12543 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 16:25:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 14:25:37 +0000 Subject: [Koha-bugs] [Bug 12543] Add userid as matchpoint for "Import patrons" tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1861 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 16:25:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 14:25:42 +0000 Subject: [Koha-bugs] [Bug 12543] Add userid as matchpoint for "Import patrons" tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 16:28:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 14:28:47 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|oleonard at myacpl.org |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 16:28:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 14:28:54 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 16:34:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 14:34:45 +0000 Subject: [Koha-bugs] [Bug 12543] Add userid as matchpoint for "Import patrons" tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543 --- Comment #1 from Kyle M Hall --- Created attachment 29574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29574&action=edit Bug 12543 - Add userid as matchpoint for "Import patrons" tool The a patron's userid should be a matchpoint in the same manner as cardnumber. Though not enforced as a unique key by the database yet ( pending bug 1861 ), this field is effectively unique as uniqueness is enforced by Koha itself. Test Plan: 1) Apply this patch 2) Browse to tools/import_borrowers.pl 3) Download the starter CSV file 4) Edit the csv file to include 1 or more patrons * Make sure to leave the borrowernumber field empty * Make sure the userid field matches the patrons you wish to overwrite 5) From import_borrowers.pl, upload your file * Set "Field to use for record matching" to "Username" * Set "If matching record is already in the borrowers table" to "Overwrite the existing one with this" 6) Click "Import" 7) Verify the patrons in your file have been updated in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 16:40:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 14:40:08 +0000 Subject: [Koha-bugs] [Bug 12543] Add userid as matchpoint for "Import patrons" tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 16:43:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 14:43:15 +0000 Subject: [Koha-bugs] [Bug 12541] Marc modification template - multivalued subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541 --- Comment #2 from Paola Rossi --- Tx, Jonathan. For later works I add the following question about the form. And in the end I add some cases. I've applied the following actions (case of 'All" option): --Delete field 650$x if 650$x matches RegEx m/ ^second 650 / --Copy field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / --Move field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / and the following actions (case of "First" option): --Delete 1st field 650$x if 650$x matches RegEx m/ ^second 650 / --Copy 1st field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / --Move 1st field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / to my test biblio record. No difference has appeared in the results between the corresponding "All/First" actions. The action "Add/Update" has no "All/First" option. [For example: --Update field 650$x with value new-value-updated if 650$x matches RegEx m/ ^second 650 / ]. So, no difference for all the 4 actions applying "All" or "First" option. Is the "All/First" option not usefull? Is the form wrong? In the action "Add/Update" the subfield before the "if" is mandatory. It could be that the "All/First" option be not concerning the subfields [it seemes so at least in cases of rep fields/rep subfields] The "All/First" option is surely usefull for the fields. I think the page is not very friendly in some cases. Perhaps, as for "Add/Update": *** in case the user fills the subfield before the "if", the option "All/First" could be hidden in COPY/MOVE/DELETE actions *** otherwise, in case the user doesn't fill the subfield before the "if", the option "All/First" is shown, concerning the fields only. --------------------------------------------------------- Another way could be change the order of the input fields in the form: Delete/Copy/Add subfield ? of "All/First" field ? .... --------------------------------------------------------- Or, perhaps, the fields could be shown in the form as mandatory ----------------------------------------------------------------------- The 4 actions, run to my test biblio record, give the following results: ********Delete field 650$x if 650$x matches RegEx m/ ^second 650 / 650 0 ..... _x1-650 x 1 Digital techniques 1 _xfirst 650, second $x _x1-650 x 3 Digital techniques 3 650 0 _.... 650 0 _.... _x3-650 x 1 Digital techniques 1 _xthird 650, second $x _x3-650 x 3 Digital techniques 3 ********Copy field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / 650 0 _aSignal processing _x1-650 x 1 Digital techniques 1 _xfirst 650, second $x _x1-650 x 3 Digital techniques 3 _yfirst 650, second $x 650 0 _aImage processing _x2-650 x 1 Digital techniques 1 _xsecond 650, second $x _x2-650 x 3 Digital techniques 3 _yfirst 650, second $x 650 0 _x3-650 x 1 Digital techniques 1 _xthird 650, second $x _x3-650 x 3 Digital techniques 3 _yfirst 650, second $x ********Update field 650$x with value new-value-updated if 650$x matches RegEx m/ ^second 650 / 650 0 _aSignal processing _x1-650 x 1 Digital techniques 1 _xfirst 650, second $x _x1-650 x 3 Digital techniques 3 650 0 _aImage processing _xnew-value-updated _xsecond 650, second $x _x2-650 x 3 Digital techniques 3 650 0 _x3-650 x 1 Digital techniques 1 _xthird 650, second $x _x3-650 x 3 Digital techniques 3 ********Move field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / 650 0 _aSignal processing _x1-650 x 1 Digital techniques 1 _xfirst 650, second $x _x1-650 x 3 Digital techniques 3 _yfirst 650, second $x 650 0 _aImage processing _yfirst 650, second $x 650 0 _x3-650 x 1 Digital techniques 1 _xthird 650, second $x _x3-650 x 3 Digital techniques 3 _yfirst 650, second $x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 16:45:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 14:45:53 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #45 from Martin Renvoize --- Created attachment 29575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29575&action=edit [SIGNED OFF] Bug 8773 - Start per-instance koha-index-daemon in .deb setup Short: Launch an indexing daemon (rebuild_zebra.pl -daemon) process for each enabled instance. Enabling/disabling the use of the indexer is handled by global configuration variables in /etc/default/koha-common. Also provides command line tools to manage the running indexer daemons for your instances. Long: Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute incremental reindexing, a requirement from our librarians.[1] Using the indexer daemon could remain "experimental" until it gets more testing; so is disabled by default initially. To enable the use of the indexer the user has to tweak the /etc/default/koha-common config file. Specifically the USE_INDEXER_DAEMON variable, which is clearly explained in the file. Frecquency defaults to 5 sec, and can be changed by tweaking the /etc/default/koha-common config file too. This patch uses rebuild_zebra.pl in daemon mode, but it is crafted to allow changing the indexing daemon and passing specific option switches it might need. Regards To+ [1] This is the .deb version of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 16:46:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 14:46:42 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29194|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize --- Comment on attachment 29194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29194 Bug 8773 - Start per-instance koha-index-daemon in .deb setup Fantastic work Tomas, so glad to see this working it's way in! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 16:50:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 14:50:18 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 17:06:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 15:06:31 +0000 Subject: [Koha-bugs] [Bug 12287] Hold priority for new hold incorrect if record has holds in transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12287 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Don't you think it's safer to test the 'T' value? Something like if ( defined $res->{found} and ( $res->{found} eq 'W' or $res->{found} eq 'T' ) ) { $count--; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 19:04:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 17:04:51 +0000 Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Bernardo Gonzalez Kriegel --- Hi, some conflicts :( Auto-merging installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql CONFLICT (content): Merge conflict in installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql Auto-merging installer/data/mysql/en/marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql CONFLICT (content): Merge conflict in installer/data/mysql/en/marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 19:31:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 17:31:44 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #11 from Kyle M Hall --- Maxime, Is the patch a followup to Jesse's patches? Or an alternative solution? If it is the latter, does it depend on bug 11211? I'm having a hard time applying your patch to test! Kyle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 19:53:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 17:53:50 +0000 Subject: [Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |bgkriegel at gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel --- Yohann, you need to swap this two lines on the two files. $dbh->do(q|DELETE FROM items|); $dbh->do(q|DELETE FROM issues|); Both tests fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 19:56:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 17:56:46 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 --- Comment #12 from Blou --- I can help there. I asked Maxime to provide an alternative solution to Jesse's. We've had this solution ready for over a year now, but put it aside with the objective to use the community's instead (at that point Jesse had started working on it) Our solution is not as ambitious as Jesse's, and does not offer the same amount of flexibility. But it's available. And it was required for use to push our "minute loans" patch (see #11055). I see that the old patches are still there, so this creates confusion. Maxime's patch is "standalone". This provides a calendar, and the overdue calculation function are modified to use the hours to determines the fines. In short. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 20:27:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 18:27:31 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 --- Comment #13 from Blou --- And to be clear (after being short) I was not aware that #11211 had moved forward (although still not through). I suppose that long term, there is more benefit to go ahead with Jesse's complete solution. But some ETA would be nice... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 20:42:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 18:42:31 +0000 Subject: [Koha-bugs] [Bug 12544] New: Send scheduled reports as an attachment Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Bug ID: 12544 Summary: Send scheduled reports as an attachment Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: p.thrasher at dover.nh.gov QA Contact: testopia at bugs.koha-community.org Currently, a scheduled report is emailed with the report in the body of the email. If an option was added to allow the report to be sent as a .csv attachment, then these reports could be more easily used in automated ways. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 21:53:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 19:53:54 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #425 from Jesse Maseto --- Kyle, I think these patches need to be rebased. -Jesse -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 8 22:38:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 20:38:57 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Aaron Sakovich changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |asakovich at hmcpl.org --- Comment #16 from Aaron Sakovich --- We've tested this extensively and have seen no problems with the upload and automatic order generation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 01:14:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 23:14:03 +0000 Subject: [Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575 --- Comment #15 from Robin Sheat --- (In reply to Tom?s Cohen Arazi from comment #14) > Are we introducing problems for Plack? Probably not. Really, OPACBaseURL should include the method so there's no need for any of that $using_https crap. But that's a story for another day. Also, as this promotes the use of the syspref over the envvar, it's probably better for plack. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 01:38:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 23:38:46 +0000 Subject: [Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575 --- Comment #16 from David Cook --- (In reply to Tom?s Cohen Arazi from comment #14) > Are we introducing problems for Plack? I don't think so. Rather, we're highlighting an existing problem that Marcel noted in bug 8952. (Marcel added the FIXME in bug 8952 and I'm just copying it over to some relevant areas.) I imagine that most people are using proxies in front of Plack so this might be relevant for fixing this issue: https://github.com/plack/Plack/wiki/How-to-detect-reverse-proxy-and-SSL-frontend Plack::Middleware::ReverseProxy seems to just reset environmental variables depending on the headers it gets from the reverse proxy (so long as they're configured). http://cpansearch.perl.org/src/MIYAGAWA/Plack-Middleware-ReverseProxy-0.15/lib/Plack/Middleware/ReverseProxy.pm I suppose another alternative might be just to set the environmental variable explicitly in the vhost (if you're using Apache) or whatever else you need to with another proxy. This may or may not be relevant: http://httpd.apache.org/docs/2.2/mod/mod_ssl.html We don't use Apache for our proxy server, so I'm not really sure, but this info might give other people (who are using Plack and a front end proxy) some ideas. I haven't played with Plack yet but I've done a fair bit of reading. By the way, here is the CGI->https() method from 5.16: #### Method: https # Return the value of HTTPS, or # the value of an HTTPS variable, or # the list of variables #### 'https' => <<'END_OF_FUNC', sub https { my ($self,$parameter) = self_or_CGI(@_); if ( defined($parameter) ) { $parameter =~ tr/-a-z/_A-Z/; if ( $parameter =~ /^HTTPS(?:_|$)/ ) { return $ENV{$parameter}; } return $ENV{"HTTPS_$parameter"}; } return wantarray ? grep { /^HTTPS(?:_|$)/ } keys %ENV : $ENV{'HTTPS'}; } END_OF_FUNC It looks like it's just looking for a HTTPS environmental variable, which Plack::Middleware::ReverseProxy can provide. Otherwise, I suppose it depends on how you've configured Plack? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 01:54:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jul 2014 23:54:51 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 --- Comment #5 from David Cook --- I wonder if Moose should be removed from C4/Installer/PerlDependencies.pm as well? Was it used anywhere else but in the Solr stuff? As for removing Solr code breaking ElasticSearch stuff, I'd love to hear Robin weigh in. I imagine it might be an idea to keep the system preference (while removing the Solr reference) and perhaps that's it. I imagine the search engine switching in the current ES code could be updated to use a new model. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 04:11:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 02:11:19 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 --- Comment #6 from Robin Sheat --- There's very little overlap between them really, I'd be more inclined to have Jonathan remove everything, and I'll go through and un-revert the bits I want to keep. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 09:26:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 07:26:55 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 --- Comment #10 from Yohann Dufour --- Created attachment 29576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29576&action=edit Bug 12111: (follow-up) fix breadcrumbs wording for vendor note As asked by QAer, this followup fixes wording in modordernotes.tt for vendor note (Change order vendor note vendor note => Change order vendor note) It also uses [%- and -%] to make code more readable Test plan : try to edit a vendor note, check the wording is correct in breadcrumbs Signed-off-by: Katrin Fischer Works as described, should be nicely translatable now. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 09:27:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 07:27:40 +0000 Subject: [Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470 Yohann Dufour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 09:27:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 07:27:43 +0000 Subject: [Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470 --- Comment #5 from Yohann Dufour --- Created attachment 29577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29577&action=edit Bug 12470: Allow execution of UTs on a DB with items (fix the order) Fix of the order of the removal of items and issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 09:29:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 07:29:10 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 Yohann Dufour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29576|1 |0 is patch| | Attachment #29576|0 |1 is obsolete| | CC| |yohann.dufour at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 09:29:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 07:29:50 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 --- Comment #11 from Yohann Dufour --- I'm sorry for the last comment, I've done a mistake with git bz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 09:46:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 07:46:02 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 09:50:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 07:50:39 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 09:50:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 07:50:42 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22878|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 29578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29578&action=edit Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions Bug 7688 does now allow patrons with serials permissions to edit subscription frequencies/numbering patterns. Test plan: Try to access to serials/subscription-frequencies.pl and serials/subscription-numberpatterns.pl with the "serials" permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 09:51:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 07:51:30 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- Sorry, I completely forgot this patch. I resubmitted without the po changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 09:54:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 07:54:28 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 12:22:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 10:22:55 +0000 Subject: [Koha-bugs] [Bug 7149] authorized values for indicators don't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7149 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:24:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:24:09 +0000 Subject: [Koha-bugs] [Bug 12043] Popup when reserved item checked in at wrong branch should generate transfer slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:25:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:25:02 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:25:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:25:46 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:26:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:26:28 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:28:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:28:24 +0000 Subject: [Koha-bugs] [Bug 12263] SIPServer does not respond correctly to signals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12263 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch --- Comment #4 from M. de Rooy --- Should the status of this report be already Passed QA? Looking at the attachment name and two sign-offs.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:28:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:28:56 +0000 Subject: [Koha-bugs] [Bug 12294] Revert BZ9372 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:29:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:29:34 +0000 Subject: [Koha-bugs] [Bug 10308] Authorities linker should handle the "local subject added entry" fields. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:30:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:30:20 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:31:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:31:09 +0000 Subject: [Koha-bugs] [Bug 12407] phone label or data switched In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:32:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:32:01 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:33:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:33:01 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:33:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:33:35 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:34:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:34:33 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 13:48:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 11:48:45 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 14:10:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 12:10:53 +0000 Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11453 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 14:10:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 12:10:53 +0000 Subject: [Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10726 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 14:16:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 12:16:48 +0000 Subject: [Koha-bugs] [Bug 7667] add a koha-setenv or an improved koha-foreach In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7667 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |DUPLICATE --- Comment #3 from MJ Ray (software.coop) --- koha-shell was added on 2012-12-20 (9 months after this report) for Bug 8878, but thanks for tidying this up. Changing the resolution to match. *** This bug has been marked as a duplicate of bug 8878 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 14:16:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 12:16:48 +0000 Subject: [Koha-bugs] [Bug 8878] koha-shell: a command to make using koha commands easier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8878 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr at software.coop --- Comment #16 from MJ Ray (software.coop) --- *** Bug 7667 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 14:46:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 12:46:57 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16402|0 |1 is obsolete| | Attachment #28526|0 |1 is obsolete| | --- Comment #12 from M. de Rooy --- Created attachment 29579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29579&action=edit Bug 9810 - Search limit 'available' does not hide damaged or withdrawn items Test Plan: 1) Perform a search that will return an a damaged item and a withdrawn item ( for simplicity, have those items be the only one on each record, respectively ) 2) Run the same search but limit to available items only 3) Note those items still appear in the search results 4) Apply this patch 5) Run the search again 6) Note the items no longer appear in the search results Signed-off-by: Matthias Meusburger Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 14:47:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 12:47:05 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #13 from M. de Rooy --- Created attachment 29580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29580&action=edit Bug 9810 [Followup] - Hide items with notforloan < 0 when limiting to available items Not for loan statuses of less then 0 are considered 'unavailable' in Koha parlance, whereas items with a not for loan status greater than 0 are considered available, but not checkout-able ( i.g. reference items ). This should be taken into account by the availability filter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 14:49:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 12:49:25 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from M. de Rooy --- Both patches work fine for me. But I wonder if the second patch will work for UNIMARC. (I do not find notforloan in the record.abs of UNIMARC) Could a UNIMARC user confirm this please? No problems for qa tools. Changing status to Failed QA for need of clarification. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 14:55:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 12:55:15 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from M. de Rooy --- Interesting: Status is Signed off, but all patches are obsolete. Changing status to Failed QA. Author or signer: Please correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 15:01:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 13:01:01 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #15 from M. de Rooy --- Small additional remark (apparently outside the scope of this report but observed while testing it): If I toggle the status of Available items and All items, the first time it works but the second time it does no longer work. As you can see below, the query contains kw: the second time, resulting in 0 hits. First URL for limiting to available: /cgi-bin/koha/catalogue/search.pl?q=london%20india%20%23relevance_dsc&sort_by=relevance_dsc&limit=available Second URL: /cgi-bin/koha/catalogue/search.pl?q=kw%3Alondon%20india%20%23relevance_dsc&sort_by=relevance_dsc&limit=available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 15:04:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 13:04:55 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23877|1 |0 is obsolete| | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 15:05:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 13:05:16 +0000 Subject: [Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470 --- Comment #6 from Bernardo Gonzalez Kriegel --- Hi Yohan, ready to be signed, works well :) But... can you squash and resubmit? Or add your fixes to first patch and obsolete last two. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 15:06:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 13:06:03 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 15:06:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 13:06:07 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23877|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 29581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29581&action=edit Bug 10648 - In records merge greatest field can not be added When merging 2 records (/cgi-bin/koha/cataloguing/merge.pl), the destination record is build using the fields and subfields checked in source records. When a field is checked, the javascript code searches in destination record a field with a greater tag number to insert new field before. When the new field tag number is greater than all existing field tag numbers, the field is not added. This patch corrects this by adding at end if no greater field tag number exists. Also adds a sort of fields by tag number because all mergo code is based on this. Test plan : - Add to a framework a repeatable field with the greater non existing tag number. For example 998. - Edit 2 records with this framework and add them a value in this tag. - Put those records is a list - Go to this list and check the two records - Click on "Merge selected" - Click on next - Go to second source record - Click on the greatest tag number. for example 998. => The field is added at the end of destination record Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 15:07:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 13:07:17 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 --- Comment #26 from Jonathan Druart --- (In reply to M. de Rooy from comment #24) > Interesting: Status is Signed off, but all patches are obsolete. > Changing status to Failed QA. > Author or signer: Please correct. The git-bz on sandboxes were not up-to-date, they were not able to sent patches. I added the signoff line on the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 15:32:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 13:32:50 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 --- Comment #68 from Kyle M Hall --- I see now that it did work for multi-holds in the past. Considering I started this patch 2 years ago I'm not surprised I forgot ; ) (In reply to Christopher Brannon from comment #67) > (In reply to Kyle M Hall from comment #66) > > I don't think this should fail qa for not being a complete fix. A partial > > fix is better than no fix at all! > > > > Kyle > > > > (In reply to Christopher Brannon from comment #65) > > > Got the sandbox to work this time around. > > > > > > The limit works great for individually placed holds, but still gives no > > > warning and places holds over limit if holding multiple items. > > > > > > Christopher > > I respectfully disagree. You placed the multi-hold as a test condition. > > > 9) Attempt to place 3 or more holds as a multi-hold > > The patch does not pass your test. If the patch is only to test items > placed on hold one at a time, then it works just fine. I don't think this > should pass, based on your parameters. > > Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 15:44:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 13:44:41 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #16 from Jonathan Druart --- (In reply to M. de Rooy from comment #14) > Both patches work fine for me. But I wonder if the second patch will work > for UNIMARC. (I do not find notforloan in the record.abs of UNIMARC) > Could a UNIMARC user confirm this please? The notforloan index does not seem to exist, I confirm. I added a patch for withdrawn and damaged indexes (see comment 6). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:06:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:06:45 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:06:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:06:51 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 29582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29582&action=edit Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:06:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:06:58 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 29583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29583&action=edit Bug 11349: Remove unnecesary name translation Since all scripts use the '.tt' sufix for template names there's no need for and regexp that changes from '.tmpl' to '.tt'. Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:07:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:07:03 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 29584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29584&action=edit Bug 11349: Make the QA script happy This patch just adjusts several POD stuff, and in a few cases reorganizes a hash definition in order to use spaces instead of tabs for the QA script to be happy. Nothing important, really. This patch series just changes '.tmpl' for '.tt'. Regards To+ PS beware that running the koha-qa.pl script can take lots of time on this one :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:11:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:11:34 +0000 Subject: [Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 --- Comment #12 from M. de Rooy --- Created attachment 29585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29585&action=edit Bug 12330: OpacHiddenItems not affecting Advanced Search This patch affects only the area displayed on Advanced Search by setting the AdvancedSearchTypes OPAC system preference accordingly. Prior to this patch, no filtering based on OpacHiddenItems was done. This patch determines if itemtypes, collections, or shelving locations are hidden and prevents them from being shown. TEST PLAN --------- 1) Back up your DB (always handy) 2) Set the Searching system preference AdvancedSearchTypes to: 'itemtypes|ccode|loc' (without the single quotes). 3) Set the OPAC system preference OpacHiddenItems to include the lines: itype: [{list of itemtype codes separated by commas}] location: [{list of comma delimited shelving location codes}] ccode: [{list of comma delimited collection codes}] Make sure to exclude one value for each, so there will be at least one known thing on each tab. 4) Open the OPAC. 5) Click on 'Advanced Search' -- three tabs appear: Itemtypes, Collection, Shelving location -- Everything is visible 6) Set the Searching system preference AdvancedSearchTypes to: 'itemtypes | ccode | loc' (without the single quotes). 7) Refresh the OPAC. -- There will be three tabs, but ugliness ensues. 8) Apply the patch 9) Refresh the OPAC. -- You will see: Itemtypes, Collection, Shelving location -- Only excluded values from OpacHiddenItems will be seen. 10) Run koha qa test tools Signed-off-by: Nicole C. Engard All tests pass Signed-off-by: Marcel de Rooy Small rewording in comment only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:12:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:12:11 +0000 Subject: [Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28570|0 |1 is obsolete| | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:12:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:12:32 +0000 Subject: [Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:12:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:12:34 +0000 Subject: [Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 --- Comment #13 from M. de Rooy --- Created attachment 29586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29586&action=edit Bug 12330: [QA Follow-up] Consistency between opac-search and staff client In opac-search two regexes are added for the results of splitting the pref AdvancedSearchTypes, allowing spaces before and after the names. The same regexes should be added to catalogue/search.pl to have the same behavior there. Test plan: Set AdvancedSearchTypes to "itemtypes | ccode | loc " (no quotes). Check OPAC and staff with and without this patch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:12:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:12:46 +0000 Subject: [Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:17:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:17:53 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|gmcharlt at gmail.com |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:18:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:18:58 +0000 Subject: [Koha-bugs] [Bug 12545] New: Add EditorConfig file to the source tree Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545 Bug ID: 12545 Summary: Add EditorConfig file to the source tree Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org It'd be usefull to have a .editorconfig [1] file, that enforces some of our coding guidelines, in the source tree top level. Those developers that have their editors configured to honour the file, will benefit. Those that wouldn't use it, won't get bothered by the addition. So, a harmless addition that would benefit those that are interested. There are plugins for several major editors: - Emacs - Vim - SublimeText - and so on... [1] http://editorconfig.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:19:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:19:06 +0000 Subject: [Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:24:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:24:52 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from M. de Rooy --- QA Comment: Supportdir does not exist in the standard koha-conf.xml. Referring to it in the codebase does not look good. I also see the hardcoded /usr/share/koha/bin. This is a package related fallback, but will not work in other installs. Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:28:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:28:56 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #17 from Kyle M Hall --- Jonathan, with no notforloan index, does the feature fail gracefully for unimarc? That is, it may not resolve the issue, but it doesn't break anything. If so, I think we can push the patch and file a separate bug to add the notforloan index for unimarc users. (In reply to Jonathan Druart from comment #16) > (In reply to M. de Rooy from comment #14) > > Both patches work fine for me. But I wonder if the second patch will work > > for UNIMARC. (I do not find notforloan in the record.abs of UNIMARC) > > Could a UNIMARC user confirm this please? > > The notforloan index does not seem to exist, I confirm. > I added a patch for withdrawn and damaged indexes (see comment 6). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:29:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:29:15 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:30:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:30:27 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 --- Comment #17 from Jonathan Druart --- Comment on attachment 29406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29406 Bug 10877 - Add "Order Record" processing Review of attachment 29406: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10877&attachment=29406) ----------------------------------------------------------------- ::: C4/ImportBatch.pm @@ +967,3 @@ > =cut > > sub GetImportBatchRangeDesc { You should provide unit test here, but it seems to be quite difficult here (no test exists for this module). ::: acqui/addorderiso2709.pl @@ +270,5 @@ > my @serials = $input->param('serial'); > my @ind_tag = $input->param('ind_tag'); > my @indicator = $input->param('indicator'); > + > + if ($is_order) { Could you detail why you process these 4 fields? @@ +295,5 @@ > + GetMarcFromKohaField('items.itype'); > + push( @tags, $itype_field ); > + push( @subfields, $itype_subfield ); > + push( @field_values, $infos->{itype} ); > + warn "ITYPE: " . $infos->{itype}; useless warn @@ +359,1 @@ > hum, good candidate for an hashref param. @@ +450,5 @@ > item_action => $item_action > ); > batch_info($template, $batch); > + > + return \@list; Why did you change this return? ::: installer/data/mysql/updatedatabase.pl @@ +8565,5 @@ > + $dbh->do("ALTER TABLE import_batches ADD is_order BOOLEAN NOT NULL DEFAULT '0' AFTER comments"); > + print "Upgrade to $DBversion done (Bug 10877 - Add 'Order Record' processing)\n"; > + SetVersion ($DBversion); > + > +} FAIL pod *** WARNING: =head2 without preceding higher level in file installer/data/mysql/updatedatabase.pl Just add an blank line before =head1 ::: koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-add-to-basket.inc @@ +18,4 @@ >
  • From an external source
  • >
  • From a staged file
  • > [% IF ( CAN_user_circulate ) %]
  • From titles with highest hold ratios
  • [% END %] > +
  • From a staged order file
  • Maybe should be put just after "from a staged file"? ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt @@ +145,5 @@ > + $("#checkAll").click(); > + > + $("#all_budget_id").hide(); > + $('label[for="all_budget_id"]').hide(); > + [% END %] I don't understand the trick here. Please check because the behavior is buggy (try to check/uncheck "Show all fund", the fund list will become empty). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:30:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:30:36 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:31:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:31:10 +0000 Subject: [Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:31:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:31:13 +0000 Subject: [Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 29587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29587&action=edit Bug 12545: Add EditorConfig.org file to the source tree This patch adds a .editorconfig file to the source tree, that enforces some of our coding guidelines. Some editors try to detect the desired configurations from the currently opened file. As we have tons of old code that doesn't follow our current coding guidelines, this can lead to unintended QA problmes. To test: - Apply the patch - Verify the .editorconfig file is in the top-level directory - See the .editorconfig file expresses our coding guidelines Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:32:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:32:49 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:46:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:46:16 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer at bsz-bw.de |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 16:55:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 14:55:31 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #18 from Jonathan Druart --- (In reply to Kyle M Hall from comment #17) > Jonathan, with no notforloan index, does the feature fail gracefully for > unimarc? I don't get an "internal server error", but the result list is empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 17:00:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 15:00:13 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #37 from M. de Rooy --- Will finish this QA soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 17:31:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 15:31:13 +0000 Subject: [Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29152|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 29588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29588&action=edit [SIGNED-OFF] Bug 12417: adding the units tests of the module Koha::Borrower::Files.pm The module Koha::Borrower::Files.pm was not tested To test: 1/ Execute the command: prove t/db_dependent/Borrower_Files.t 2/ The command has to print: t/db_dependent/Borrower_Files.t .. ok All tests successful. Files=1, Tests=23, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.47 cusr 0.08 csys = 1.60 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Squashed patches. Now test pass No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 17:31:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 15:31:39 +0000 Subject: [Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 17:32:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 15:32:10 +0000 Subject: [Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 17:49:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 15:49:01 +0000 Subject: [Koha-bugs] [Bug 12472] Unit Tests failing with "MySQL server has gone away" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- I don't reproduce the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 17:59:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 15:59:22 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel at gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel --- Second patch does not apply fatal: sha1 information is lacking or useless (t/db_dependent/Members.t). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12457: Adding unit tests for the routines AddMessage, GetMessages, GetMessagesCount, DeleteMessage, GetPendingIssues, GetAllIssues of the module C4/Members.pm and modification of the routine GetAllIssues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 18:06:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 16:06:30 +0000 Subject: [Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29189|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 29589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29589&action=edit [SIGNED-OFF] Bug 12470: adding unit tests for the routines CheckValidBarCode and CheckIfIssuedToPatron of the module C4::Circulation.pm The routines CheckValidBarcode and CheckIfIssuedToPatron were not tested Test plan: 1/ Apply the patch 2/ Execute : prove t/db_dependent/Circulation/CheckValidBarcode.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t 3/ The result of the command has to be a success without error or warning : t/db_dependent/Circulation/CheckValidBarcode.t ...... ok t/db_dependent/Circulation/CheckIfIssuedToPatron.t .. ok All tests successful. Files=2, Tests=32, 3 wallclock secs ( 0.04 usr 0.01 sys + 2.88 cusr 0.17 csys = 3.10 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Patches squashed Tests pass, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 18:06:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 16:06:55 +0000 Subject: [Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29321|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 18:07:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 16:07:09 +0000 Subject: [Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29577|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 18:07:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 16:07:30 +0000 Subject: [Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 18:12:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 16:12:36 +0000 Subject: [Koha-bugs] [Bug 12537] editions tab showing on bibs with more than one ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 --- Comment #1 from Owen Leonard --- Correction: When a record has more than one ISBN it *sometimes* shows the Editions tab and links to the same record. The reason why it only happens sometimes is probably significant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 18:18:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 16:18:09 +0000 Subject: [Koha-bugs] [Bug 12522] Fatal database error when viewing Holds for Bib with no Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12522 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29464|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 29590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29590&action=edit [SIGNED-OFF] Bug 12522 - Fatal database error when viewing Holds for Bib with no Items This patch fixes some potential SQL syntax errors, which can cause fatal software errors in Koha when the environmental variable DEBUG is on. _TEST PLAN_ Before applying: 0) Ensure that you don't have "SetEnv DEBUG 1" in your Apache config 1) Create a new bib record 2) Click on the "Holds" tab before creating any items 3) Note the message "Cannot place hold: this record has no items attached." 4) Add "SetEnv DEBUG 1" to your Apache config 5) Restart Apache 6) Refresh your page 7) Note the following Software Error: "DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ')' at line 3 at /koha/lib/C4/Koha.pm line 835. 8) Apply the patch 9) Refresh your page 10) Note the message from Step 3 Thorough tester: 11) Remove "SetEnv DEBUG 1" from your Apache config, restart Apache, and refresh your page. You should see the message from Step 3. Signed-off-by: Bernardo Gonzalez Kriegel Error reproduced, patch fixes it. Tested following test plan, no koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 18:18:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 16:18:24 +0000 Subject: [Koha-bugs] [Bug 12522] Fatal database error when viewing Holds for Bib with no Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12522 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 18:22:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 16:22:28 +0000 Subject: [Koha-bugs] [Bug 12420] syndetics content broken in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12420 --- Comment #10 from Owen Leonard --- > Is that what this boils down to? It boils down to I can't reproduce the problem with any of the ISBNs provided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 19:48:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 17:48:26 +0000 Subject: [Koha-bugs] [Bug 6499] OCLC # Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 --- Comment #1 from Barton Chittenden --- Created attachment 29591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29591&action=edit Bug 6499 - OCLC # Indexing & Matching etc/zebradb/marc_defs/marc21/biblios/record.abs Add 035$a, 035$z and 035 as zebra index 'OCLC-Number' etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml Add 035$a, 035$z and 035 as zebra index 'OCLC-Number' Note that all changes were made via make_zebra_dom_cfg_from_record_abs; these changes were merged with the existing biblio-koha-indexdefs.xml. All changes in the file are a) logic adding OCLC-Number as a zebra index or b) Updates to line numbers in comments reflecting the current record.abs. All other changes made by make_zebra_dom_cfg_from_record_abs were discarded. See http://wiki.koha-community.org/wiki/MRenvoize/zebra#DOM_indexing. etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl Reflects changes made by applying koha-indexdefs-to-zebra.xsl to biblio-koha-indexdefs.xml. C4/Search.pm Add OCLC-Number to getIndexes() etc/zebradb/ccl.properties Set OCLC-Number 1=1211 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 20:15:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 18:15:12 +0000 Subject: [Koha-bugs] [Bug 6499] OCLC # Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #2 from Barton Chittenden --- Testing: 1) Make sure that you have a bib that has MARC21 035$a (and possibly also 035$z) populated. 2) Rebuild zebra: misc/migration_tools/rebuild_zebra.pl -x -b -z 3) Add the following to the intranetuserjs syspref: $(document).ready(function(){ // Add OCLC Number to advanced search if (window.location.href.indexOf("catalogue/search.pl") > -1) { $(".advsearch").append(''); } } Do an advanced search, select OCLC Number from the search menu, then add the OCLC Number in 035$a for the bib specified in step 1. The advanced search should return that biblio record. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 20:25:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 18:25:09 +0000 Subject: [Koha-bugs] [Bug 12546] New: Add 'OCLC Number' as search item for staff client and OPAC advanced search pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12546 Bug ID: 12546 Summary: Add 'OCLC Number' as search item for staff client and OPAC advanced search pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Zebra search index was added in Bug 6499. Need to modify ./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt ./koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt In order to add 'OCLC Number' as an option in advanced search in the OPAC and staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 20:26:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 18:26:02 +0000 Subject: [Koha-bugs] [Bug 12546] Add 'OCLC Number' as search item for staff client and OPAC advanced search pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12546 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6499 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 20:26:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 18:26:02 +0000 Subject: [Koha-bugs] [Bug 6499] OCLC # Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12546 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 20:30:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 18:30:47 +0000 Subject: [Koha-bugs] [Bug 12546] Add 'OCLC Number' as search item for staff client and OPAC advanced search pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12546 --- Comment #1 from Barton Chittenden --- Don't need to update ./koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 22:06:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 20:06:31 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 22:06:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 20:06:34 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #53 from Owen Leonard --- Created attachment 29592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29592&action=edit Bug 11430 [Follow-up] Search history: Delete selected lines This follow-up for Bug 11430 makes some changes to the template to make it more useful when JavaScript is turned off: - Hide the toolbar containing select all/clear all links if JS is off - Add buttons to submit the forms if the delete link in the toolbar is unavailable (or if the user has scrolled all the way to the bottom of a long list) Also changed: Corrected indentation from 2-space to 4-space, added comments to the markup to help document page structure; changed the class of the delete link to match other similar interfaces. Note: This patch contains whitespace changes. Please diff accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 22:25:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 20:25:20 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #29 from M. Tompsett --- Even if 10589 and 10895 don't make it into Koha, I think this refactor/clean up is still useful to do. There are some "works by mistake" changes in here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 22:35:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 20:35:18 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11909 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 9 22:35:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 20:35:18 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8462 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 01:08:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 23:08:16 +0000 Subject: [Koha-bugs] [Bug 6499] OCLC # Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hm, I am not happy with naming this index oclc-number - 035 is not only the OCLC number, although it can contain one. For example in our database one 035 always contains the PPN - the unique identifier from our union catalog SWB. 035 A control number of a system other than the one whose control number is contained in field 001 (Control Number), field 010 (Library of Congress Control Number) or field 016 (National Bibliographic Agency Control Number). (Repeatable) [a,z,6,8] -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 01:12:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 23:12:36 +0000 Subject: [Koha-bugs] [Bug 6499] OCLC # Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 --- Comment #4 from Katrin Fischer --- I think a better name might be other-control-number? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 01:31:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jul 2014 23:31:41 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 --- Comment #7 from David Cook --- (In reply to Robin Sheat from comment #6) > There's very little overlap between them really, I'd be more inclined to > have Jonathan remove everything, and I'll go through and un-revert the bits > I want to keep. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 02:09:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 00:09:49 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 02:09:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 00:09:54 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #26 from Liz Rea --- Created attachment 29593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29593&action=edit QA followup 12031 - adding supportdir to koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 04:23:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 02:23:46 +0000 Subject: [Koha-bugs] [Bug 3237] OpenID patron authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3237 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- I was going to say that I'm doing work on OpenID...but I realized that I'm actually working on "OpenID Connect Core 1.0" which is a veneer over OAuth2.0 rather than being an implementation of "OpenID Authentication 2.0". I assume that you're talking about "OpenID Authentication 2.0". In any case, I think that Koha needs a better API for handling external authentication... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 04:35:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 02:35:30 +0000 Subject: [Koha-bugs] [Bug 12547] New: Create better API for handling external authentication Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 Bug ID: 12547 Summary: Create better API for handling external authentication Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org At the moment, authentication is really handled all that consistently. There is Auth_with_cas.pm, Auth_with_ldap.pm, and perhaps one day Auth_with_Shibboleth.pm. There is also Persona which relies on a DOM API and Javascript on some OPAC pages. All of these different methods also hook into Auth.pm. They all work but it's not really that easy to see how they work nor is it straightforward to add new forms of external authentication. I don't have a plan of how to improve C4::Auth::checkauth() or C4::Auth, but I think it's worth thinking about. Obviously, it would require a ton of testing, but perhaps we could have incremental improvements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 04:55:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 02:55:38 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #27 from Liz Rea --- Should probably add that the last patch will only add the supportdir configuration option for new installs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 04:58:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 02:58:31 +0000 Subject: [Koha-bugs] [Bug 12547] Create better API for handling external authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3237 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 04:58:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 02:58:31 +0000 Subject: [Koha-bugs] [Bug 3237] OpenID patron authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3237 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12547 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 04:59:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 02:59:00 +0000 Subject: [Koha-bugs] [Bug 12547] Create better API for handling external authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8446 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 04:59:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 02:59:00 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12547 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 04:59:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 02:59:55 +0000 Subject: [Koha-bugs] [Bug 12547] Create better API for handling external authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 --- Comment #1 from David Cook --- "At the moment, authentication isn't really handled all that consistently"* It's also not documented very well, but I'll create a new bug for that... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 05:08:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 03:08:18 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25684|0 |1 is obsolete| | CC| |vanoudt at gmail.com --- Comment #13 from Nicholas van Oudtshoorn --- Created attachment 29594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29594&action=edit Allow Google OAuth2 Login Fixed the patch so that it again cleanly applies. Adds googleoauth2 login to koha. Adds applicable system preferences Modifies templates to support oauth2 login failures changes the login links to use googleoauth2 when oauth2 is enabled. Test Plan: 1) Apply this patch 2) Update the database (this is the bit I'm not sure about - I've added the SQL into the atomicupdates directory - is this right?) 3) Create a web app in the google cloud console: - Go to https://cloud.google.com/console - Create a project, and give it some details - Open the Project by clicking on it - Under APIs & auth menu, open "Registered Apps" and click "Register App" - Give it a name and make sure you select "Web app", click ok - Under OAuth 2.0 Client ID, - under web origin, type - in the redirect uri enter /cgi-bin/koha/svc/googleoauth2 - click Generate 4) Set the GoogleOAuth2ClientID and GoogleOAuth2ClientSecret according to the values generated above 5) Test that clicking login intiates an oauth2 login 6) Try logging in with an email that is not registered to a library user. It should fail and offer either to retry or to login manually. 7) Try logging in with an email that is registered to a library user. You should be logged in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 05:08:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 03:08:58 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #14 from Nicholas van Oudtshoorn --- (In reply to Marc V?ron from comment #10) > Patch did not apply. Merge conflict in > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Should apply cleanly with the latest patch... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 05:32:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 03:32:23 +0000 Subject: [Koha-bugs] [Bug 12548] New: Auth::checkauth() needs more in-line comments Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548 Bug ID: 12548 Summary: Auth::checkauth() needs more in-line comments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org C4::Auth::checkauth() can be a bit difficult to read. Take for instance the following code snippet unless ($userid || $sessionID) { ... } That makes it seem like this block will be executed if we haven't sent a userid in the CGI object passed to checkauth(). On the contrary, the userid in the CGI object has been defined as "$q_userid" so this block of code is actually what will be executed when we're logging in with a userid and password. The $userid mentioned in this condition refers to the "id" retrieved from an existing session or from "$userid = $ENV{'REMOTE_USER'}" (which is an environmental variable set via SIP?). So that's confusing. The whitespace is also inconsistent with the actual flow of logic, so that should be fixed up too. There are all sorts of little bits that need some explanatory comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 05:32:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 03:32:36 +0000 Subject: [Koha-bugs] [Bug 12548] Auth::checkauth() needs more in-line comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 05:35:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 03:35:02 +0000 Subject: [Koha-bugs] [Bug 12547] Create better API for handling external authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12548 --- Comment #2 from David Cook --- (In reply to David Cook from comment #1) > "At the moment, authentication isn't really handled all that consistently"* > > It's also not documented very well, but I'll create a new bug for that... http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 05:35:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 03:35:02 +0000 Subject: [Koha-bugs] [Bug 12548] Auth::checkauth() needs more in-line comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12547 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 05:39:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 03:39:44 +0000 Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 --- Comment #28 from M. Tompsett --- Actually, if you look at ...net-tmpl/prog/en/modules/tools/scheduler.tt you will see: [% IF ( job_add_failed ) %]
    Failed to add scheduled task
    [% END %] I think something could be added into tools/scheduler that displays a configuration required type message when the defaulting $base directory doesn't exist. This would then cause people to look at the koha-conf.xml which now has that useful message in it based on your latest patch. Leaving status untouched, because I'm not sure if Marcel would consider the new patch alone sufficient, or if implementing this idea I just gave would be required too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 05:44:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 03:44:42 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25570|0 |1 is obsolete| | --- Comment #15 from Nicholas van Oudtshoorn --- Created attachment 29595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29595&action=edit For updating an INSTALLED 3.14.03 to use GoogleOAuth2 (In reply to Samuel Martin from comment #12) I assume you're talking about the patch to jerry-rig OAuth2 into an already installed system? > In the file: usr/share/koha/opac/cgi-bin/opac/svc/googleoauth2 > there appeared to be some lines missing in the patch at the very beginning > of the file. Though the code is available here in this bug. So that was easy > to fix. Thanks for that. I've updated the INSTALLED patch with the missing lines! > > And then we still had some issues. At that time I still had an error 400 > straight from google this time. We had to set up the opac URL in: > /etc/apache2/conf.d/ Hmmm - that's strange. What exactly did you change? > Also: in the opac-main there is no hint where to log in with the google > account. It would be a nice feature that once you use Google Oauth it would > say which log in link to use to do that. Maybe even with a google logo? Agreed. The main patch has been changed so that the top-left login link works for oauth2 if that is set up. Here at PBC we've changed our templates to show a button for OAuth2 login, and another for manual logins. I can provide the patch, if it would be useful... > Other than that the patch is working perfectly though I didn't test it > extensively. It's only running on my test server. Glad to hear it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 06:01:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 04:01:19 +0000 Subject: [Koha-bugs] [Bug 12547] Create better API for handling external authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 --- Comment #3 from David Cook --- (In reply to David Cook from comment #2) > (In reply to David Cook from comment #1) > > "At the moment, authentication isn't really handled all that consistently"* > > > > It's also not documented very well, but I'll create a new bug for that... > > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548 Actually, the more I review C4::Auth::checkauth(), maybe more in-line documentation and better indenting is all that is required at the moment... it probably would be a good idea to switch to Koha::Auth at some point, but a good first step would be to get a better handle on the existing situation, I think... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 07:29:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 05:29:44 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #5 from Srdjan Jankovic --- Created attachment 29596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29596&action=edit Use branch codes from the database rather than hardcoded CPL and MPL -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 07:30:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 05:30:38 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 07:30:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 05:30:40 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #6 from Srdjan Jankovic --- Created attachment 29597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29597&action=edit bug_5304: GetItemsInfo() - moved issues and serials query from the results loop to the main query -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 07:33:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 05:33:55 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #7 from Srdjan Jankovic --- Testing: Biblio details pages with items need to be visited for regression check, eg opac-detail.pl and ./catalogue/detail.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 08:47:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 06:47:32 +0000 Subject: [Koha-bugs] [Bug 12549] New: Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 Bug ID: 12549 Summary: Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: vanoudt at gmail.com QA Contact: testopia at bugs.koha-community.org In Koha-conf.xml, the font paths for the DejaVu fonts are hardcoded. Unfortunately, the paths don't match the installed font locations in other distributions (such as Fedora). Ideally, the system should enquire of fontconfig where the fonts are installed. Something like: fc-list : file | grep Deja spits out the correct paths, and should work across distributions. Just spent quite a long time trying to figure out why the Creators.t test was continually failing during make test even though they ran fine manually. Problem seems to have been this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 09:01:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 07:01:55 +0000 Subject: [Koha-bugs] [Bug 12549] Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 --- Comment #1 from Nicholas van Oudtshoorn --- It's not in perl, but the following bash snippet (hacky, but works!) could set the proper paths... #!/bin/bash tr=$(fc-list : file | grep DejaVuSerif.ttf) tb=$(fc-list : file | grep DejaVuSerif-Bold.ttf) ti=$(fc-list : file | grep DejaVuSerif-Italic.ttf) tbi=$(fc-list : file | grep DejaVuSerif-BoldItalic.ttf) c=$(fc-list : file | grep DejaVuSansMono.ttf) cb=$(fc-list : file | grep DejaVuSansMono-Bold.ttf) co=$(fc-list : file | grep DejaVuSansMono-Oblique.ttf) cbo=$(fc-list : file | grep DejaVuSansMono-BoldOblique.ttf) h=$(fc-list : file | grep DejaVuSans.ttf) ho=$(fc-list : file | grep DejaVuSans-Oblique.ttf) hb=$(fc-list : file | grep DejaVuSans-Bold.ttf) hbo=$(fc-list : file | grep DejaVuSans-BoldOblique.ttf) echo "${tr%??}" echo "${tb%??}" echo "${ti%??}" echo "${tbi%??}" echo "${c%??}" echo "${cb%??}" echo "${co%??}" echo "${cbo%??}" echo "${h%??}" echo "${ho%??}" echo "${hb%??}" echo "${hbo%??}" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 10:32:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 08:32:06 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 10:34:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 08:34:00 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 --- Comment #8 from Fridolin SOMERS --- # TODO: get hidden tag mapping Indeed, I think we need a mapping in biblio or biblioitems like opachidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 11:11:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 09:11:31 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from M. de Rooy --- (In reply to Jonathan Druart from comment #18) > (In reply to Kyle M Hall from comment #17) > > Jonathan, with no notforloan index, does the feature fail gracefully for > > unimarc? > > I don't get an "internal server error", but the result list is empty. Thanks, Jonathan. Sorry, Kyle, but that means that this cannot pass qa in the current form. We would introduce more misinformation (no hits) for unimarc users than only showing a damaged item or so too much. Could you adjust the follow-up and make this notforloan part non-unimarc specific? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 11:44:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 09:44:05 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 11:44:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 09:44:08 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28851|0 |1 is obsolete| | Attachment #28852|0 |1 is obsolete| | --- Comment #38 from M. de Rooy --- Created attachment 29598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29598&action=edit Bug 10519 - Suggestions: 'Organize by' and correct display of tab descriptions broken The tabbed display in suggestions offers different options to organize the tabs. The descriptions on the tabs and some of the search options were not working correctly, displaying as "Unknown". To test: - Add several suggestions to your installation, make sure you have: - suggestions from different users - suggestions managed by different users - suggestions with different statuses - suggestions with different selected item types Test all the 'organize by' options (except "Organize by: Library" - see note below), make sure that the tabs and search options have correct descriptions and do no longer display as "Unknown". - Add 1 or 2 custom status to SUGGEST_STATUS authorized value. - Verify display is still correct and your new status are displayed. Note: "Organize by: Library" option is currently severely broken (and not easily fixable, especially for 'IndependentBranches' enabled). But this turns out to be a separate issue, with a different underlaying causes, and it's outside the scope of this patch. This should be dealt with later, in it's own bug report. Signed-off-by: Christopher Brannon Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 11:44:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 09:44:15 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #39 from M. de Rooy --- Created attachment 29599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29599&action=edit Bug 10519 - Suggestions: 'Organize by' and correct display of tab descriptions broken Follow-up to fix additional suggestion statuses, which are not working properly due to 416: borrowernumber => $input->param('borrowernumber'), being evaluated in list context inside $template->param() call arguments. Signed-off-by: Christopher Brannon Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 11:48:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 09:48:02 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #40 from M. de Rooy --- QA Comment: Improves display of tab headings (especially Ordered). Also resolves display of additional suggestion statuses in combo box for Mark selected as. Code looks good to me. No complaints from qa tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 14:47:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 12:47:37 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29223|0 |1 is obsolete| | --- Comment #69 from Jared Camins-Esakov --- Created attachment 29600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29600&action=edit Bug 10402: Use an object for contacts In preparation for adding the ability to handle multiple contacts, this patch moves booksellers' contacts into their own class, C4::Bookseller::Contact. To test: 1) Apply patch. 2) Run database update. 3) Edit a bookseller, making sure to add a contact. 4) View the bookseller's information, making sure the contact information is there. 5) Run the unit test: > prove t/db_dependent/Bookseller.t Signed-off-by: Owen Leonard Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 14:47:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 12:47:49 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29224|0 |1 is obsolete| | --- Comment #70 from Jared Camins-Esakov --- Created attachment 29601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29601&action=edit Bug 10402: Move contacts to separate table This patch normalizes the data structures used for bookseller contacts. To test: 1) Repeat tests described on previous patch. Signed-off-by: Owen Leonard Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 14:48:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 12:48:00 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29225|0 |1 is obsolete| | --- Comment #71 from Jared Camins-Esakov --- Created attachment 29602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29602&action=edit Bug 10402: Add ability to enter multiple contacts Some vendors may have more than one contact. For example, a technical contact and a billing contact, or a contact for journals and a contact for monographs. Rather than require that each contact be either made into a separate vendor or recorded somewhere outside of Koha, it would be really useful of Koha had the ability to add multiple additional contacts to vendors in the Acquisitions module. To test: 1) Apply patch. 2) Edit a bookseller, making sure to add a contact. 3) View the bookseller's information, making sure the contact information is there. 4) Run the unit test: > prove t/db_dependent/Bookseller.t 5) Add multiple contacts to a vendor, see that they show up. 6) Delete one contact from a vendor with multiple contacts, see that the result is correct. 7) Sign off. Note: This test plan can supersede that on the previous two patches, as all functionality of the previous two patches is required by this one. Signed-off-by: Owen Leonard Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 14:48:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 12:48:12 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29226|0 |1 is obsolete| | --- Comment #72 from Jared Camins-Esakov --- Created attachment 29603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29603&action=edit Bug 10402 [Template follow-up] Add multiple contacts for vendors This template-only follow-up tweaks the button labels and restructures the vendor view layout a little bit to make it more amenable to multiple contacts: - Add spaces after button icons - Change "Add contact" to "Add another contact" in hopes of making it less ambiguous whether clicking it will submit the whole form. - Eliminate duplicate headers on the vendor view page by making the contact name the subheading for each individual contact. To test, view details for vendors with one or more contacts, and try editing to add additional contacts. Everything should look good and work correctly. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 14:48:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 12:48:27 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 14:48:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 12:48:29 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29511|0 |1 is obsolete| | --- Comment #73 from Jared Camins-Esakov --- Created attachment 29604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29604&action=edit Bug 10402 follow-up: choose contacts for claims This patch makes it possible to choose a particular contact for acquisitions and serials claims. To test: 1) Select a contact to use for claiming late orders and a contact to use for claiming late issues. 2) Send a claim for a late order and a claim for a late issue. 3) Note that the claims went out to the proper people. 4) Run the unit test with: > prove t/db_dependent/Letters.t 5) Sign off. Note: the claim messages are recorded in the logs in the *Acquisitions* module, not the Letters module as you might expect This patch also fixes several perlcritic violations and centralizes contact-related unit testing in Bookseller.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 15:26:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 13:26:39 +0000 Subject: [Koha-bugs] [Bug 6499] OCLC # Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|koha.sekjal at gmail.com |barton at bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 15:32:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 13:32:29 +0000 Subject: [Koha-bugs] [Bug 6499] OCLC # Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:02:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:02:38 +0000 Subject: [Koha-bugs] [Bug 6499] OCLC # Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 --- Comment #5 from Barton Chittenden --- Created attachment 29605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29605&action=edit Change zebra index "OCLC-Number" to "Other-control-number" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:03:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:03:42 +0000 Subject: [Koha-bugs] [Bug 12550] New: Add ability to delay loading of patron's checkouts in circulation and patron details Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Bug ID: 12550 Summary: Add ability to delay loading of patron's checkouts in circulation and patron details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Now that a patron's checkouts are loaded asynchronously, we can further improve Koha's performance by not loading the checkouts table when it is not needed. For example, if a librarian is checking out 5 items to a patron, we really don't need to load the table during the scanning of items 1 to 4, just for item 5. Another example would be browsing to the patron details table in order to change a patron's password. I propose we add two separate system preferences to add a timer for loading the patron's checkouts table, one for circulation and one for patron details. That way a library can choose to have enough delay so that most librarians can scan items repeatedly without loading the checkouts table, and can have the patron details table load more quickly if they wish. In addition, setting one or both timeouts to 0 will cause the system to act as it currently does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:04:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:04:37 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:15:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:15:37 +0000 Subject: [Koha-bugs] [Bug 12508] The removal of a contract which is linked to a basket does not display an error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:16:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:16:54 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29596|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 29606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29606&action=edit [SIGNED-OFF] Bug 5304: Use branch codes from the database rather than hardcoded CPL and MPL http://bugs.koha-community.org/show_bug.cgi?id=5304 Signed-off-by: Bernardo Gonzalez Kriegel No commit message No test plan. prove t/db_dependent/Items.t pass No koha-qa errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:17:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:17:02 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29597|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 29607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29607&action=edit [SIGNED-oFF] Bug 5304: GetItemsInfo() - moved issues and serials query from the results loop to the main query Signed-off-by: Bernardo Gonzalez Kriegel No commit message No test plan. No regressions found on opac/staff item display No improvements either, but could be just my test data No koha-qa errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:17:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:17:16 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:21:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:21:41 +0000 Subject: [Koha-bugs] [Bug 12534] PROG/CCSR deprecation: Make getlanguages() theme independent for opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:21:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:21:44 +0000 Subject: [Koha-bugs] [Bug 12534] PROG/CCSR deprecation: Make getlanguages() theme independent for opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29555|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 29608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29608&action=edit Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac This patch removes a reference to prog theme on getlanguages() when ENV var HTTP_ACCEPT_LANGUAGE is checked. Changed to use sysprefs to find theme for opac and intranet To test: 1) Apply the patch 2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc 3) Enable those languages for OPAC on I18N prefs 4) Using Firefox, clean all history/cookies 5) Change variable intl.accept_languages (will do several times) a) got to about:config b) search 'lang' c) look for the variable, double click, change to 'de-DE' 6) Go to opac page, must load in german 7) Repeat for each translated lang: clean > change val > reload opac On each case opac must load on configured language 8) Just to test, set variable on untranslated lang, opac page must load on first value of list of enabled languages 9) prove t/Languages.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:30:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:30:36 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 --- Comment #1 from Kyle M Hall --- Created attachment 29609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29609&action=edit Bug 12550 - Add ability to delay loading of patron's checkouts in circulation and patron details Now that a patron's checkouts are loaded asynchronously, we can further improve Koha's performance by not loading the checkouts table when it is not needed. For example, if a librarian is checking out 5 items to a patron, we really don't need to load the table during the scanning of items 1 to 4, just for item 5. Another example would be browsing to the patron details table in order to change a patron's password. I propose we add two separate system preferences to add a timer for loading the patron's checkouts table, one for circulation and one for patron details. That way a library can choose to have enough delay so that most librarians can scan items repeatedly without loading the checkouts table, and can have the patron details table load more quickly if they wish. In addition, setting one or both timeouts to 0 will cause the system to act as it currently does. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Test circulation and patron details, no changes should be noted 4) Set CheckoutsTableSecondsToLoadCirculation and CheckoutsTableSecondsToLoadPatronDetails to some number of seconds. 5) Test again, note tables load after the set number of seconds 6) Test the "Load now" button, note it triggers the table to load immediately -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:35:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:35:55 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:35:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:35:57 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29609|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 29610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29610&action=edit Bug 12550 - Add ability to delay loading of patron's checkouts in circulation and patron details Now that a patron's checkouts are loaded asynchronously, we can further improve Koha's performance by not loading the checkouts table when it is not needed. For example, if a librarian is checking out 5 items to a patron, we really don't need to load the table during the scanning of items 1 to 4, just for item 5. Another example would be browsing to the patron details table in order to change a patron's password. I propose we add two separate system preferences to add a timer for loading the patron's checkouts table, one for circulation and one for patron details. That way a library can choose to have enough delay so that most librarians can scan items repeatedly without loading the checkouts table, and can have the patron details table load more quickly if they wish. In addition, setting one or both timeouts to 0 will cause the system to act as it currently does. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Test circulation and patron details, no changes should be noted 4) Set CheckoutsTableSecondsToLoadCirculation and CheckoutsTableSecondsToLoadPatronDetails to some number of seconds. 5) Test again, note tables load after the set number of seconds 6) Test the "Load now" button, note it triggers the table to load immediately -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:36:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:36:02 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:36:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:36:05 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27502|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 29611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29611&action=edit Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off If the user knows the URL for OPAC lists they can access them even with the virtualshelves preference turned off. This patch copies the solution added to opac-topissues.pl by Bug 10595 and applies it to OPAC lists pages. To test, apply the patch and set the virtualshelves system preference to "don't allow." - Navigate to /cgi-bin/koha/opac-shelves.pl. You should be redirected to an Error 404 page. - Also check: - /cgi-bin/koha/opac-shareshelf.pl. - /cgi-bin/koha/opac-downloadshelf.pl - /cgi-bin/koha/opac-sendshelf.pl - /cgi-bin/koha/opac-addbybiblionumber.pl - Turn virtualshelves back on. Access to lists and list sharing should be restored. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:45:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:45:21 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #54 from Jonathan Druart --- (In reply to Owen Leonard from comment #53) > Created attachment 29592 [details] [review] > Note: This patch contains whitespace changes. Please diff accordingly. Hi Owen, What is the problem with the space alignment? There already are 2-space indentation in templates (and actually I have been using 2 spaces for at least 2 years). I had the discussion with Kyle and he uses 2 spaces too. I am not sure we had this king of requirement in the coding guidelines for template. Since we regularly have a big amount of level in template, I think 2 spaces will avoid long lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:46:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:46:45 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:48:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:48:29 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22623|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Comment on attachment 22623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22623 how to take Instead of uploading a file, capture the image directly from a webcam As said before, the attached file is not a patch or usable. Obsoleted then -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:51:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:51:37 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #55 from Owen Leonard --- (In reply to Jonathan Druart from comment #54) > What is the problem with the space alignment? There already are 2-space > indentation in templates I am certainly willing to be overruled, but I thought 4 spaces was a rule across Perl scripts and templates. It was in the Coding Guidelines for Perl scripts and I added it to the template guidelines yesterday because I thought the rule applied to both. The Bootstrap theme templates were all created with 4-space indentation so I thought it was worth changing for consistency's sake. As for long lines, I think consistent indentation (whether it follow a 2-space or 4-space rule) should be preferred over concerns about long lines. I consider long lines an issue that one's preferred editor should handle for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:57:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:57:33 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29578|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 29612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29612&action=edit [SIGNED-OFF] Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions Bug 7688 does now allow patrons with serials permissions to edit subscription frequencies/numbering patterns. Test plan: Try to access to serials/subscription-frequencies.pl and serials/subscription-numberpatterns.pl with the "serials" permissions. Signed-off-by: Bernardo Gonzalez Kriegel With patch and only serial permissions can now access frequences and patterns. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 16:57:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 14:57:49 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 17:15:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 15:15:17 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- Created attachment 29613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29613&action=edit Readable, but not useable attachment This will get obsoleted as well. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 17:17:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 15:17:07 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29613|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Comment on attachment 29613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29613 Readable, but not useable attachment I'm pretty sure it won't apply, even if I tried to make it a nice patch. Don't like the proprietary requirement either. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 17:46:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 15:46:29 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 --- Comment #14 from Charles Farmer --- Created attachment 29614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29614&action=edit Bug 7498 - Cloning a budget, enable change of description Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) This patch allows to enter a new name for the duplicate budget and adds an option to transfer the not received orders in the budget copy. Took the previous patch, adapted it to the current master branch and made the tests work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 17:48:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 15:48:50 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com, | |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 17:50:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 15:50:03 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 17:59:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 15:59:36 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Quick feedback: Joubu: khall: don't you think it would be better to display the tables on demand? Joubu: with a link "load checkout table" gmcharlt: I agree with Joubu - and maybe make it so that a circ desk operator can use a checkbox or a toggle that sets a cookie to determine if the table displays automatically when a patron is retrieved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 18:02:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 16:02:11 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.10 --- Comment #8 from M. Tompsett --- This was likely against 3.10.x or earlier. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 18:09:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 16:09:04 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master --- Comment #9 from Owen Leonard --- (In reply to M. Tompsett from comment #8) > This was likely against 3.10.x or earlier. tcohen has re-assigned this bug to himself because he is working on a new version. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 18:10:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 16:10:01 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 18:18:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 16:18:36 +0000 Subject: [Koha-bugs] [Bug 12551] New: Special due date not cleared after item added through fast catalgoing is checked out. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12551 Bug ID: 12551 Summary: Special due date not cleared after item added through fast catalgoing is checked out. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a date is added in the 'Specify due date' field of circulation.pm, then an item is added via the fast-add framework, the due date is re-populated for the next patron. Was able to re-create on http://intranet.bywatersolutions.com/cgi-bin/koha/circ/circulation.pl (user: bywater password: bywater) Steps to re-create: 1) Navigate to http://intranet.bywatersolutions.com/cgi-bin/koha/circ/circulation.pl 2) Enter barcode 24535000001969 [Laura Johnson] 3) Add tomorrow's date in the 'Specify due date (MM/DD/YYYY)' text box. 4) Add a non-existent barcode and click 'Check Out' 5) Click the 'Fast cataloging' link on the yellow warning bar. 6) On the 'Add MARC record (fast cataloging)' screen: -- Add title "ASDF ASDF ASDF" -- Change Koha [default] item type to 'Book' -- click 'Save' button. 7) Click 'Add item' -- This will check out the newly added item. 8) Un-check 'Remember for session' 9) Click 'Clear' -- This will clear the special due date. 10) Enter barcode '24535000001971' [Ann Smith] 11) Note that Due-date is re-populated. It doesn't seem to matter whether 'Remember for session' is un-checked in step 8, the Due-date will be re-populated for the next patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 18:24:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 16:24:19 +0000 Subject: [Koha-bugs] [Bug 12551] Special due date not cleared after item added through fast cataloging is checked out. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12551 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Special due date not |Special due date not |cleared after item added |cleared after item added |through fast catalgoing is |through fast cataloging is |checked out. |checked out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 18:43:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 16:43:29 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29610|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 29615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29615&action=edit Bug 12550 - Add ability to delay loading of patron's checkouts in circulation and patron details Now that a patron's checkouts are loaded asynchronously, we can further improve Koha's performance by not loading the checkouts table when it is not needed. For example, if a librarian is checking out 5 items to a patron, we really don't need to load the table during the scanning of items 1 to 4, just for item 5. Another example would be browsing to the patron details table in order to change a patron's password. Test Plan: 1) Apply this patch 2) Browse to circulation.pl for a patron 3) Note the table is not loaded automatically 4) Click the "Show checkouts" button 5) Note the checkouts table loads 6) Check the "Always show checkouts immediately" checkbox 7) Reload the page, the checkouts should now load immediately 8) Repeat steps 3-7 for the patron details page ( moremember.pl ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 18:59:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 16:59:59 +0000 Subject: [Koha-bugs] [Bug 12397] Can't find some books keyed already In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12397 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard --- This sounds like a support request rather than a bug report. Please consult your options for getting Koha support: http://koha-community.org/support/ ...particularly the Koha mailing list. Keep in mind that any requests for help should include the version of Koha you are using. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 19:10:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 17:10:20 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- A counter patch migut easily change the syntax and avoid loosing the feature that seems to be used by some libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 19:22:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 17:22:33 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29573|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 29616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29616&action=edit Bug 1861 - Unique patrons logins not (totally) enforced The Koha 3.0 patron admin page will prevent you from creating a user who has an identical OPAC login as someone else (though I would change the error message from "Login/password already exists." to "Login already exists.", since it's not the password that's the problem). However, there's nothing enforced in the MySQL database to prevent patrons from being imported or manually inserted with duplicate logins. Would it be better to change the MySQL spec from this: KEY `userid` (`userid`) to this: UNIQUE KEY `userid` (`userid`) Test plan: 1) Enter mysql console 2) Attempt to create two borrowers with identical user id's 3) Note you are able to do so 4) Delete these bororwers 5) Apply this patch 6) Run updatedatabase.pl 7) Repeat step 2 8) Note you are now unable to do so -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 19:25:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 17:25:20 +0000 Subject: [Koha-bugs] [Bug 4430] Staff Results Display Showing Wrong Numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4430 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Owen Leonard --- As far as I can tell this is no longer an issue in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 19:27:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 17:27:19 +0000 Subject: [Koha-bugs] [Bug 5847] Manage Staged MARC Records stuck at 0% if isbn matching rule selected. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5847 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Owen Leonard --- Unless we can get new data on how to reproduce this problem I think we can consider this to be working. We use an ISBN matching rule for importing records on a regular basis without problems. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 19:32:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 17:32:35 +0000 Subject: [Koha-bugs] [Bug 6993] Incorrect data type in auth_subfield_structure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6993 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master --- Comment #2 from Owen Leonard --- The files described here appear to remain unchanged from when this bug was reported but obviously there are not critical consequences since the bug has not been touched in years. Is this bug really valid? If so, is it really a critical bug? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 19:34:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 17:34:02 +0000 Subject: [Koha-bugs] [Bug 7635] ignoring hold still marks it in transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7635 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #6 from Owen Leonard --- No one seems to be able to reproduce this issue, and the report refers to a version which is no longer maintained. Closing as invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 20:23:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 18:23:38 +0000 Subject: [Koha-bugs] [Bug 12552] New: Forward slash in payment note causes error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 Bug ID: 12552 Summary: Forward slash in payment note causes error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com A forward slash (/) in a payment note will trigger the following error: usi_escape: Unmatched [ in regex; marked by <-- HERE in m/([ <-- HERE ])/ at (eval 133) line 1. The issue is the use of uri_escape at line 174 of members/pay.pl, where a forward slash is a reserved character. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 20:30:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 18:30:13 +0000 Subject: [Koha-bugs] [Bug 12552] Forward slash in payment note causes error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 --- Comment #1 from Kyle M Hall --- I cannot reproduce the issue, I suspect the issue may be URI::Escape version 3.30. I'm running version 3.31 and do not see the issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 20:50:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 18:50:45 +0000 Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Hardware|PC |All --- Comment #18 from Owen Leonard --- This bug appears to be valid in current master. Searching doesn't appear to work and the library selection dropdown is empty. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 20:56:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 18:56:59 +0000 Subject: [Koha-bugs] [Bug 5552] circ dates in the past In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5552 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Owen Leonard --- This appears to be fixed now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 21:32:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 19:32:53 +0000 Subject: [Koha-bugs] [Bug 5757] Checking in a waiting item again does not trigger hold prompt. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5757 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- I can no longer reproduce this problem in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 21:35:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 19:35:05 +0000 Subject: [Koha-bugs] [Bug 6896] searching an acq date finds due date instead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6896 --- Comment #1 from Owen Leonard --- I would like to test this bug but it's not clear from the description where the problematic search is being done. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 21:52:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 19:52:05 +0000 Subject: [Koha-bugs] [Bug 10202] series searching searches author In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10202 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- This appears to be fixed in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 22:03:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 20:03:44 +0000 Subject: [Koha-bugs] [Bug 7806] Illegal dates are used to signal non existing dates. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Severity|major |normal --- Comment #1 from Owen Leonard --- My search of Koha code returns only instances where checks are being done for a '0000-00-00' value but no instances where a '0000-00-00' value is being set, with one exception: sample_quotes.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 10 23:49:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 21:49:24 +0000 Subject: [Koha-bugs] [Bug 12553] New: copynumber, location not printing correctly on spine labels. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12553 Bug ID: 12553 Summary: copynumber, location not printing correctly on spine labels. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 29617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29617&action=edit label_batch_8.pdf -- spine label output. I have verified that the problem exists on the bywater example site. Here are the steps that I used to replicate the problem: 1) Log in to http://intranet.bywatersolutions.com username: bywater password:bywater 2) Go to Home > Tools > Labels home > Manage label Templates: ( http://intranet.bywatersolutions.com/cgi-bin/koha/labels/label-manage.pl?label_element=template ) 3) Create a new template with the following fields template_code: GAYLORD_20000590_SL units: INCH template_desc: 1 5/8'' x 7/8'' Spine labels page_width: 8.5 page_height: 11 label_width: 0.875 label_height: 1.625 top_text_margin: 0.31 left_text_margin: 0.3 top_margin: 0.13 left_margin: 0.1 cols: 2 rows: 6 col_gap: 3.3 row_gap: 0.29 creator: Labels 4) Click 'Manage layouts' 5) Check the 'select' box for 'spine' layout, then click 'edit' 6) Check 'List Fields' radio button, then enter itemcallnumber, copynumber, location In the 'Data fields' text box. 7) Click the 'New Batch' button 8) Add the barcodes TVSN5000326266 and TVSN5000226254 to the 'Add by barcode(s)' text box, click the 'Add item(s)' button. 9) Click the 'Export batch' button 10) Select GAYLORD_20000590_SL as 'template to be applied' 11) Select 'spine' as 'layout to be applied' 12) Click 'Export' 13) Click 'Download as PDF' The resulting pdf Will have two labels, which read as follows: 598 Aud 0 0 JBIO Opp 0 0 These should read: 598 Aud 1 AUD and JBIO Opp 1 BIO Respectively. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 01:05:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 23:05:57 +0000 Subject: [Koha-bugs] [Bug 12521] Arrangement of divs on opac-advsearch.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 01:11:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jul 2014 23:11:37 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #10 from Srdjan Jankovic --- I forgot to add - it may be worth changing GetItemsInfo() return value to an arrayref instead of array. No big deal for biblios with a small number of items, but makes huge difference for serials with hundreds. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 08:34:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 06:34:51 +0000 Subject: [Koha-bugs] [Bug 12458] Holidays calendar has wrong colors for weekly and yearly repeatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12458 --- Comment #8 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 08:38:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 06:38:54 +0000 Subject: [Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text "Select titles to: " in bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.09 In fact it looks like a minor bug, not an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 08:41:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 06:41:05 +0000 Subject: [Koha-bugs] [Bug 12292] Members are restricted even if the debarment is ended - moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12292 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 08:45:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 06:45:35 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 --- Comment #15 from Katrin Fischer --- Hi Charles, from the description of this, it seems to be a partial duplicate to bug 12164. 12164 adds options to move unreceived funds into the next year, but does not offer to rename the budget at time of duplication. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 08:45:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 06:45:46 +0000 Subject: [Koha-bugs] [Bug 12292] Members are restricted even if the debarment is ended - moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12292 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 08:48:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 06:48:32 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #13 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 08:52:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 06:52:44 +0000 Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for improved usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #10 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 08:54:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 06:54:28 +0000 Subject: [Koha-bugs] [Bug 11786] Improve RDFa schema.org mappings in prog and bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11786 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 08:57:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 06:57:37 +0000 Subject: [Koha-bugs] [Bug 12034] MSG_REMOVE_FROM_LIST different wording between OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 08:59:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 06:59:06 +0000 Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 09:16:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 07:16:28 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #44 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.09 (very nice, thanks all) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 09:17:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 07:17:59 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 09:18:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 07:18:02 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29615|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 29618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29618&action=edit Bug 12550 - Add ability to delay loading of patron's checkouts in circulation and patron details Now that a patron's checkouts are loaded asynchronously, we can further improve Koha's performance by not loading the checkouts table when it is not needed. For example, if a librarian is checking out 5 items to a patron, we really don't need to load the table during the scanning of items 1 to 4, just for item 5. Another example would be browsing to the patron details table in order to change a patron's password. Test Plan: 1) Apply this patch 2) Browse to circulation.pl for a patron 3) Note the table is not loaded automatically 4) Click the "Show checkouts" button 5) Note the checkouts table loads 6) Check the "Always show checkouts immediately" checkbox 7) Reload the page, the checkouts should now load immediately 8) Repeat steps 3-7 for the patron details page ( moremember.pl ) Signed-off-by: Jonathan Druart Amended patch: remove trailing spaces. Note: I am not sure the checkbox is at the best place, but I don't have a better suggestion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 09:18:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 07:18:37 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11703 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 09:18:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 07:18:37 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12550 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 09:42:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 07:42:40 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #56 from Jonathan Druart --- Owen, Your patch adds a new button "delete selected", do you think it's a good idea to have 2 links for the same action? Maybe should we remove the one in the toolbar? I searched for "#selections-toolbar" and I found opac-basket.pl. On the basket page, the links in the toolbar are displayed (but disabled), and there is no action button at the bottom. Moreover the following links "More details Send Download Print Empty and close" are clickable but don't work. I am not sure what we should do here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 10:21:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 08:21:03 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #206 from Zeno Tajoli --- A General Bug Sign off Day only for this bug is planned for 23/July/2014 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 10:49:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 08:49:12 +0000 Subject: [Koha-bugs] [Bug 12554] New: C4::Biblio GetMarcPrice does not handle NORMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Bug ID: 12554 Summary: C4::Biblio GetMarcPrice does not handle NORMARC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: boutrosboutrosboutros at gmail.com QA Contact: testopia at bugs.koha-community.org When doing aquisitions and ordering from external z3950 targes, the item price is not inferred from the MARC record when the NORMARC framework is set. The fix is easy, because the price is stored in the same field in NORMARC as in MARC21. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 10:55:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 08:55:32 +0000 Subject: [Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 --- Comment #1 from Petter Goks?yr ?sen --- Created attachment 29619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29619&action=edit When doing aquisitions and ordering from external z3950 targes, the item price is not inferred from the MARC record when the NORMARC framework is set. This patch makes GetMarcPrice treat NORMARC the same as MARC21. Test plan * Setup Koha with NORMARC framework * Add a norwegian z3950 search target (ex: z3950.bibsys.no:2100, database=BIBSYS) * Create a new basket, and add order to basket from external source * Search for a tile (ex: ISBN 8205341834) from the bibsys z3950 server * Click to order the title * Observe that vendor price is not set * Apply patch, repeat search for same book * Order, and observe the vendor price is filled in from the MARC record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 10:56:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 08:56:55 +0000 Subject: [Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 11:17:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 09:17:21 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #20 from Jonathan Druart --- *** Bug 11323 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 11:17:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 09:17:21 +0000 Subject: [Koha-bugs] [Bug 11323] AcqItemSetSubfieldsWhenReceived set to 0 on a fresh install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11323 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 11237 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 11:39:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 09:39:49 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #21 from Jonathan Druart --- QAers, could you reconsider this bug please? This major is blocked for 3 months. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 11:48:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 09:48:30 +0000 Subject: [Koha-bugs] [Bug 12555] New: Call DelItem on cancelling a receipt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Bug ID: 12555 Summary: Call DelItem on cancelling a receipt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 11744 needs some additional work. The routine _cancel_items_receipt should call C4::Items::DelItem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 11:48:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 09:48:44 +0000 Subject: [Koha-bugs] [Bug 12555] Call DelItem on cancelling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11744 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 11:48:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 09:48:44 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12555 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 11:54:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 09:54:52 +0000 Subject: [Koha-bugs] [Bug 12556] New: SelfCheck machine starts the hold instantly with an email sent out Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Bug ID: 12556 Summary: SelfCheck machine starts the hold instantly with an email sent out Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.field at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Currently when a reserved book is returned on a SelfCheck machine the hold starts the hold instantly with an email sent out. It would be preferable if the hold started once it had been taken out of the SelfCheck bins and checked in by reservations staff at the counter. Current suggestion: Possible time delay on the message - may help if after 8 at night and 9 the following morning if delayed until following morning still a workaround if looked at account on OPAC they would see a hold e.g. so theoretically it could still be in the bin - it is difficult to find a correct time delay because of the number of variables - a bit more of a task to put in functionality change Possible Ideal Process: Requested item is returned via SelfService machine - for the patron the process remains the same (they are directed to put it in the RED slot) Instead of an email being sent immediately at that point to the patron next in line for the request, the item would have a new circulation status e.g. ?In SelfService? this removes the item from the patron?s record but does not trigger the next hold until it is checked-in by a member of the library, at which point the item moves onto the next circulation status that it would have had before going into ?In SelfService? (e.g. ?On hold? or ?in transit? etc.) There could be different variations of this process based on what is easiest to incorporate into Koha e.g. the item could possibly go into a transit status to a new Shelving Location or Branch - again ?SelfService etc.? - before returning to the correct next circulation status as described before - once it is checked-in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 11:55:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 09:55:11 +0000 Subject: [Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 12:05:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 10:05:22 +0000 Subject: [Koha-bugs] [Bug 12557] New: Cannot revert the changes done by AcqItemSetSubfieldsWhenReceived on canceling a receipt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12557 Bug ID: 12557 Summary: Cannot revert the changes done by AcqItemSetSubfieldsWhenReceived on canceling a receipt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 8307 introduces the AcqItemSetSubfieldsWhenReceived pref. You can now update an item field on receiving (if you create items on ordering). But if the receipt is cancel, there is no way to revert these changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 12:05:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 10:05:32 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12557 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 12:05:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 10:05:32 +0000 Subject: [Koha-bugs] [Bug 12557] Cannot revert the changes done by AcqItemSetSubfieldsWhenReceived on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |8307 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 12:14:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 10:14:25 +0000 Subject: [Koha-bugs] [Bug 12557] Cannot revert the changes done by AcqItemSetSubfieldsWhenReceived on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 12:14:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 10:14:27 +0000 Subject: [Koha-bugs] [Bug 12557] Cannot revert the changes done by AcqItemSetSubfieldsWhenReceived on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12557 --- Comment #1 from Jonathan Druart --- Created attachment 29620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29620&action=edit Bug 12557: DB changes - Add the AcqItemSetSubfieldsWhenReceiptIsCancelled pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 12:14:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 10:14:32 +0000 Subject: [Koha-bugs] [Bug 12557] Cannot revert the changes done by AcqItemSetSubfieldsWhenReceived on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12557 --- Comment #2 from Jonathan Druart --- Created attachment 29621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29621&action=edit Bug 12557: Add a way to revert the changes made on items on receving Bug 8307 introduces the AcqItemSetSubfieldsWhenReceived pref. You can now update an item field on receiving (if you create items on ordering). But if the receipt is cancel, there is no way to revert these changes. This patch adds a new pref AcqItemSetSubfieldsWhenReceiptIsCancelled to allow to revert changes previously done on receiving Test plan: 0/ Set the AcqCreateItems to 'ordering' 1/ Fill AcqItemSetSubfieldsWhenReceived with o=1 (UNIMARC) or 7=1 (MARC21). 2/ Fill AcqItemSetSubfieldsWhenReceiptIsCancelled with o=2 (UNIMARC) or 7=2 (MARC21) 3/ Create an order with some items 4/ Receive the order and verify the notforloan value is set to 1 5/ Cancel the receipt and verify the notforloan value is set to 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 12:16:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 10:16:48 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25682|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 29622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29622&action=edit Bug 11744: Add regression tests Before the patch: prove t/db_dependent/Acquisition/CancelReceipt.t returns 1 failure. After the patch, the 2 tests pass. Signed-off-by: marjorie barry-vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 12:18:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 10:18:34 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #23 from Jonathan Druart --- The UT patch is rebased (conflict with commit Bug 11699: ModReceiveOrder should take a hashref in parameter), -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 12:40:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 10:40:30 +0000 Subject: [Koha-bugs] [Bug 11733] "gist" system preference inconsistently treated as single-value or multi-value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 12:40:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 10:40:33 +0000 Subject: [Koha-bugs] [Bug 11733] "gist" system preference inconsistently treated as single-value or multi-value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25888|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 29623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29623&action=edit Bug 11733: gist can be multi-valued The gist syspref should always be treated as multi-value. In basketgroup.pl, parcel.pl and invoice.pl it is treated as single-value. The invoice.pl script will be fixed by bug 10613. If the pref contains several values, the first one is the default one (according to the syspref description). Test plan: basketgroup.pl: create a vendor with List prices don't include tax and invoice prices include tax. add 1 basket with 1+ order(s) receive them and check that the total amount on the basket page is the same as on the basketgroup page Verify this is right for other vendor configurations. On parcel.pl, this patch only removes dead code. The $gst variable is not used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 12:41:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 10:41:18 +0000 Subject: [Koha-bugs] [Bug 11733] "gist" system preference inconsistently treated as single-value or multi-value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733 --- Comment #6 from Jonathan Druart --- (In reply to Galen Charlton from comment #4) > I think there is another bug lurking here. The 'gist' contains a list of > decimal values, so dividing the default one by 100 leads to the wrong result > if the default tax rate isn't 0. Actually this code does not work and should simply be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 13:00:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 11:00:07 +0000 Subject: [Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- I don't reproduce the issue on master. Certainly fixed with bug 12168. *** This bug has been marked as a duplicate of bug 12168 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 13:00:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 11:00:07 +0000 Subject: [Koha-bugs] [Bug 12168] Spent and ordered budget values are wrong if deep > 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #11 from Jonathan Druart --- *** Bug 11714 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 13:11:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 11:11:06 +0000 Subject: [Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > I don't reproduce the issue on master. Certainly fixed with bug 12168. > > *** This bug has been marked as a duplicate of bug 12168 *** Sorry, Fridolin wanted to optimize the routine, not fixing a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 13:11:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 11:11:13 +0000 Subject: [Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 13:14:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 11:14:47 +0000 Subject: [Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 13:14:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 11:14:49 +0000 Subject: [Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25305|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 29624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29624&action=edit Bug 11714 - GetBudgetHierarchy needs optimization The method C4::Budgets::GetBudgetHierarchy() retreives from database budgets in an array containing a tree of budgets (parent -> children -> children, ...). The code generating this tree with the SQL results needs optimization because when a lot of budgets exists, it can run during several minutes. This patch rewites the code using a recurive method. Test plan : - Create a active budget "MyBudget" with 1000 - Click "Add found" on this budget - Create a found "Parent" with 1000, set you has owner - Click "Add child found" on found "Parent" - Create a found "Child" with 100, set you has owner - Click "Add child found" on found "Child" - Create a found "Grand-child" with 10, set you has owner | - Create a new acquisition basket - Add a new order with "Child budget" - Select "Child" found and set all costs to 2 - Save order - Add a new order with "Grand-Child budget" - Select "Child" found and set all costs to 2 - Save order - Close basket - Perform the receive of the two orders | - Go to founds of "MyBudget" => You see a table with 3 founds - in "Fund filters", select no library and uncheck "Show my funds only" and click on "Go" => You see a table with "Parent" found - Click on small arrow left of the fund code of "Parent" => You see a new line with "Child" found - Click on small arrow left of the fund code of "Child" => You see a new line with "Grand-Child" found | => You see in "Grand-Child" row "Base-level spent" = 2 and "Total sublevels spent" = 2 => You see in "Child" row "Base-level spent" = 2 and "Total sublevels spent" = 4 This confirms the founds are used in a hierarchie. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 13:15:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 11:15:47 +0000 Subject: [Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 --- Comment #7 from Jonathan Druart --- I rebased the patch and added some changes in order to fix conflicts with bug 12168 and bug 11578. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 13:31:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 11:31:46 +0000 Subject: [Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #8 from Jonathan Druart --- This is not a major anymore, back to normal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 13:55:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 11:55:27 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 13:55:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 11:55:29 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29612|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 29625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29625&action=edit [PASSED QA] Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions Bug 7688 does now allow patrons with serials permissions to edit subscription frequencies/numbering patterns. Test plan: Try to access to serials/subscription-frequencies.pl and serials/subscription-numberpatterns.pl with the "serials" permissions. Signed-off-by: Bernardo Gonzalez Kriegel With patch and only serial permissions can now access frequences and patterns. No koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:14:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:14:37 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:14:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:14:40 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25683|0 |1 is obsolete| | Attachment #26447|0 |1 is obsolete| | Attachment #29622|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 29626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29626&action=edit [PASSED QA] Bug 11744: Cancel a receipt does not delete items created on receiving If items is created on receiving, cancel a receipt should delete them. The code only manage the case if the order is a child of another order (partial). To reproduce: 1/ Set AcqCreateItem to receiving 2/ Order one or more item(s) 3/ Receive the order and verify the item is created 4/ Cancel the receipt 5/ The item is not deleted Test plan: 1/ Apply this patch and do again previous steps. The item should not be deleted at step 5. 2/ Set AcqCreateItem to ordering and verify the item is not deleted. Signed-off-by: marjorie barry-vila Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:14:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:14:58 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #25 from Kyle M Hall --- Created attachment 29627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29627&action=edit [PASSED QA] Bug 11744: A receipt should not be cancelled if holds exist Test plan: 1/ Set acqCreateItem pref to on receiving 2/ Receive 1 of 2 items ordered 3/ Place a hold on the record 4/ Verify you are not able to cancel the receipt. This is not the best way to do that but it is the easy one. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:15:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:15:03 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #26 from Kyle M Hall --- Created attachment 29628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29628&action=edit [PASSED QA] Bug 11744: Add regression tests Before the patch: prove t/db_dependent/Acquisition/CancelReceipt.t returns 1 failure. After the patch, the 2 tests pass. Signed-off-by: marjorie barry-vila Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:18:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:18:14 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #27 from Katrin Fischer --- I lost track of this a bit, should we have a new bug report for comment 18-20? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:18:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:18:36 +0000 Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is NULL when Import MARC records tool is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P5 - low Version|unspecified |master --- Comment #1 from Owen Leonard --- Confirmed in master. I assume libraries are working around this by adding the correct value to items.permanent_location before/during import? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:28:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:28:43 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 --- Comment #16 from Blou --- What do you recommend, Katrin? Moving into next year is not the same as duplicating, but I see where they could collide. We were unaware of the "duplicate" situation, and the features (simply cloning, and renaming) still seem to have value to us (and certainly the sponsor). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:32:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:32:54 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:32:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:32:56 +0000 Subject: [Koha-bugs] [Bug 7025] C4::Items depends on C4::Reserves (which in turn depends on C4::Items...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7025 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- This appears to have been fixed by a patch on Bug 6875. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:32:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:32:56 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29606|0 |1 is obsolete| | Attachment #29607|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 29629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29629&action=edit [PASSED QA] Bug 5304: Use branch codes from the database rather than hardcoded CPL and MPL http://bugs.koha-community.org/show_bug.cgi?id=5304 Signed-off-by: Bernardo Gonzalez Kriegel No commit message No test plan. prove t/db_dependent/Items.t pass No koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:32:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:32:57 +0000 Subject: [Koha-bugs] [Bug 6875] de-nesting C4 packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Bug 6875 depends on bug 7025, which changed state. Bug 7025 Summary: C4::Items depends on C4::Reserves (which in turn depends on C4::Items...) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7025 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:33:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:33:07 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #12 from Kyle M Hall --- Created attachment 29630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29630&action=edit [PASSED QA] [PASSED QA] Bug 5304: GetItemsInfo() - moved issues and serials query from the results loop to the main query Signed-off-by: Bernardo Gonzalez Kriegel No commit message No test plan. No regressions found on opac/staff item display No improvements either, but could be just my test data No koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:33:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:33:27 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29630|[PASSED QA] [PASSED QA] Bug |[PASSED QA] Bug 5304: description|5304: GetItemsInfo() - |GetItemsInfo() - moved |moved issues and serials |issues and serials query |query from the results loop |from the results loop to |to the main query |the main query CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:34:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:34:07 +0000 Subject: [Koha-bugs] [Bug 6875] de-nesting C4 packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #87 from Owen Leonard --- Time to ask again! There are no more open bugs on which this one depends. Can it be considered resolved? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:34:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:34:33 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #13 from Kyle M Hall --- Created attachment 29631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29631&action=edit Bug 5304: GetItemsInfo should return arrayref instead of array -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:34:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:34:54 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:38:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:38:53 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 --- Comment #17 from Katrin Fischer --- Hi Blou, I'd suggest you take a look at Jonathan's feature and talk to him. I think there is an overlap and it would be good to identify, where your feature does more than his patches do and then add those things separately. From the description - I haven't tested your patches - the only missing piece might be giving the new budget a different name in the same step as the duplicating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:39:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:39:43 +0000 Subject: [Koha-bugs] [Bug 12522] Fatal database error when viewing Holds for Bib with no Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12522 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:39:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:39:45 +0000 Subject: [Koha-bugs] [Bug 12522] Fatal database error when viewing Holds for Bib with no Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12522 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29590|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 29632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29632&action=edit [PASSED QA] Bug 12522 - Fatal database error when viewing Holds for Bib with no Items This patch fixes some potential SQL syntax errors, which can cause fatal software errors in Koha when the environmental variable DEBUG is on. _TEST PLAN_ Before applying: 0) Ensure that you don't have "SetEnv DEBUG 1" in your Apache config 1) Create a new bib record 2) Click on the "Holds" tab before creating any items 3) Note the message "Cannot place hold: this record has no items attached." 4) Add "SetEnv DEBUG 1" to your Apache config 5) Restart Apache 6) Refresh your page 7) Note the following Software Error: "DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ')' at line 3 at /koha/lib/C4/Koha.pm line 835. 8) Apply the patch 9) Refresh your page 10) Note the message from Step 3 Thorough tester: 11) Remove "SetEnv DEBUG 1" from your Apache config, restart Apache, and refresh your page. You should see the message from Step 3. Signed-off-by: Bernardo Gonzalez Kriegel Error reproduced, patch fixes it. Tested following test plan, no koha-qa errors. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 14:49:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 12:49:21 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #57 from Owen Leonard --- (In reply to Jonathan Druart from comment #56) > Your patch adds a new button "delete selected", do you think it's a good > idea to have 2 links for the same action? The primary reason for its inclusion is to make it usable with JavaScript off. The secondary benefit is that if you have a large number of results you can perform the delete action after scrolling down the page. Otherwise you have to return to the top. It looks a bit redundant with a small number of results but in my opinion is worth it. You can see the same thing on the lists page (opac-shelves.pl). > I searched for "#selections-toolbar" and I found opac-basket.pl. On the > basket page, the links in the toolbar are displayed (but disabled), and > there is no action button at the bottom. The cart doesn't work at all without JavaScript, so the cart page doesn't need to accommodate users without JavaScript. > Moreover the following links "More > details Send Download Print Empty and close" are clickable but don't work. They work for me. Can you test again and file a separate bug if you can reproduce the problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:02:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:02:02 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #28 from Jonathan Druart --- (In reply to Katrin Fischer from comment #27) > I lost track of this a bit, should we have a new bug report for comment > 18-20? Bug 12555 already opened and linked ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:04:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:04:32 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 --- Comment #18 from Jonathan Druart --- (In reply to Blou from comment #16) You should test the new feature (see bug 12164). It certainly answers to your needs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:07:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:07:38 +0000 Subject: [Koha-bugs] [Bug 12489] Ajax checkout table: no "loading..." popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12489 --- Comment #2 from Kyle M Hall --- FYI, it's there but it seems to be positioned very far down the page, possibly even off the page! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:08:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:08:45 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #29 from Katrin Fischer --- Ah! Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:10:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:10:47 +0000 Subject: [Koha-bugs] [Bug 12558] New: DBIx::Class schema update 07/2014 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Bug ID: 12558 Summary: DBIx::Class schema update 07/2014 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org As Yohann stated, there have been several changes in the DB structure since last update of the Koha::Schema::Result::* classes. Recent DBIC::Schema::Loader (v0.07039) generates better code as Galen expressed in his post to koha-devel: "When I was RM for 3.16, I was using DBIC::Schema::Loader version v0.07025. Yesterday Tomas and I did some checking of classes generated using v0.07039. Among other changes, the newer versions now recognize "set null" as a FK action and default to "restrict" rather than "cascade" if the action is not explicitly specified." "Those are both good changes, so I recommend that we require at least version v0.07039 of DBIC::Schema::Loader. Since that module is /not/ required for production use -- it's only needed for development -- requiring a hire version should not affect packaging signficantly." So we are: - Updating the DBIx::Class schema - Shifting DBIC::Schema::Loader version requirement to v0.07039 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:11:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:11:00 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:16:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:16:25 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yohann.dufour at biblibre.com --- Comment #1 from Tom?s Cohen Arazi --- DBIC::Schema::Loader version requirement to v0.07039 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:18:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:18:41 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:18:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:18:44 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 29633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29633&action=edit Bug 12558: DBIx::Class schema update 07/2014 Needed DBIx::Class schema update to keep sync with current kohastructure.sql. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:18:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:18:51 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 29634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29634&action=edit Bug 12558: Require DBIx::Schema::Loader v0.07039 or higher This patch shifts required DBIx::Schema::Loader required version. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:19:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:19:41 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:19:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:19:44 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29106|0 |1 is obsolete| | Attachment #29107|0 |1 is obsolete| | Attachment #29108|0 |1 is obsolete| | Attachment #29109|0 |1 is obsolete| | Attachment #29110|0 |1 is obsolete| | Attachment #29592|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart --- Created attachment 29635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29635&action=edit Bug 11430: delete search history by id - API changes Bug 10807 adds a search history for authorities and bug 10862 adds the search history on the staff interface. This one allows the user to select the search history lines he wants to delete. This change is done for the OPAC and intranet interface. The user is now allow to delete one or more lines of his/her search history. Test plan (for intranet, opac: bootstrap and prog themes): 1/ launch some search (catalogue and authority) 2/ verify the lines is added to your search history 3/ delete one or more lines of the history and verify they have been deleted 4/ at the OPAC: logout and do again steps 1-3. 5/ prove t/db_dependent/Search/History.t Signed-off-by: sonia BOUIS Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:19:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:19:49 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #59 from Jonathan Druart --- Created attachment 29636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29636&action=edit Bug 11430: UT: add unit tests to delete only selected lines Signed-off-by: sonia BOUIS Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:19:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:19:54 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #60 from Jonathan Druart --- Created attachment 29637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29637&action=edit Bug 11430: OPAC changes Signed-off-by: sonia BOUIS Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:20:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:20:04 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #61 from Jonathan Druart --- Created attachment 29638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29638&action=edit Bug 11430: Intranet changes Signed-off-by: sonia BOUIS Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:20:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:20:09 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #62 from Jonathan Druart --- Created attachment 29639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29639&action=edit Bug 11430: DB changes: Add the primary key for search_history Adds a primary key search_history.id. Signed-off-by: sonia BOUIS Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:20:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:20:15 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #63 from Jonathan Druart --- Created attachment 29640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29640&action=edit Bug 11430 [Follow-up] Search history: Delete selected lines This follow-up for Bug 11430 makes some changes to the template to make it more useful when JavaScript is turned off: - Hide the toolbar containing select all/clear all links if JS is off - Add buttons to submit the forms if the delete link in the toolbar is unavailable (or if the user has scrolled all the way to the bottom of a long list) Also changed: Corrected indentation from 2-space to 4-space, added comments to the markup to help document page structure; changed the class of the delete link to match other similar interfaces. Note: This patch contains whitespace changes. Please diff accordingly. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:22:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:22:11 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #64 from Jonathan Druart --- Last patch set fixes conflict on opac.css file. I added my SO on the last patch. I send this enhancement back in the RM queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:23:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:23:36 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #65 from Jonathan Druart --- (In reply to Owen Leonard from comment #57) > > Moreover the following links "More > > details Send Download Print Empty and close" are clickable but don't work. > > They work for me. Can you test again and file a separate bug if you can > reproduce the problem? It does not work with JS disabled. All is fine with JS enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:34:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:34:01 +0000 Subject: [Koha-bugs] [Bug 12534] PROG/CCSR deprecation: Make getlanguages() theme independent for opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:34:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:34:03 +0000 Subject: [Koha-bugs] [Bug 12534] PROG/CCSR deprecation: Make getlanguages() theme independent for opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29608|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 29641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29641&action=edit [PASSED QA] Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac This patch removes a reference to prog theme on getlanguages() when ENV var HTTP_ACCEPT_LANGUAGE is checked. Changed to use sysprefs to find theme for opac and intranet To test: 1) Apply the patch 2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc 3) Enable those languages for OPAC on I18N prefs 4) Using Firefox, clean all history/cookies 5) Change variable intl.accept_languages (will do several times) a) got to about:config b) search 'lang' c) look for the variable, double click, change to 'de-DE' 6) Go to opac page, must load in german 7) Repeat for each translated lang: clean > change val > reload opac On each case opac must load on configured language 8) Just to test, set variable on untranslated lang, opac page must load on first value of list of enabled languages 9) prove t/Languages.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 15:56:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 13:56:18 +0000 Subject: [Koha-bugs] [Bug 8188] OPAC allow hold date in future requires both OPAC and staff-side preferences to be ON In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8188 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard --- The feature certainly seems to have been designed this way, and the documentation makes it clear that you must have both enabled. Since I don't have a vested interest in changing the behavior I'll consider this invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 16:07:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 14:07:30 +0000 Subject: [Koha-bugs] [Bug 8673] Create new authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8673 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Owen Leonard --- The only part of this bug I can duplicate is the part where saving an empty authority record returns a false duplicate warning against an existing authority. Since this is an edge case which doesn't really cause problems for the user (just a false warning) I don't think this needs to stay open. The other aspects of the bug--nonexistent records, missing records--I couldn't reproduce. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 16:50:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 14:50:13 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Yohann Dufour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 16:50:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 14:50:16 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Yohann Dufour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29633|0 |1 is obsolete| | --- Comment #4 from Yohann Dufour --- Created attachment 29642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29642&action=edit Bug 12558: DBIx::Class schema update 07/2014 Needed DBIx::Class schema update to keep sync with current kohastructure.sql. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Yohann Dufour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 16:50:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 14:50:25 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Yohann Dufour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29634|0 |1 is obsolete| | --- Comment #5 from Yohann Dufour --- Created attachment 29643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29643&action=edit Bug 12558: Require DBIx::Schema::Loader v0.07039 or higher This patch shifts required DBIx::Schema::Loader required version. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Yohann Dufour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:14:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:14:35 +0000 Subject: [Koha-bugs] [Bug 5502] Patron card category search field should be menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5502 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:20:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:20:42 +0000 Subject: [Koha-bugs] [Bug 5502] Patron card category search field should be menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5502 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |oleonard at myacpl.org |u | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:23:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:23:20 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #20 from Jonathan Druart --- Created attachment 29644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29644&action=edit Bug 9810: Add index notforloan for unimarc This patch adds the notforloan index for UNIMARC (GRS-1 and DOM). Not that the original patch does not work out of the box: the notforloan, withdrawn and damaged indexes are not defined in the frameworks and mapping. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:26:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:26:39 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #21 from Jonathan Druart --- (In reply to M. de Rooy from comment #19) > (In reply to Jonathan Druart from comment #18) > > (In reply to Kyle M Hall from comment #17) > > > Jonathan, with no notforloan index, does the feature fail gracefully for > > > unimarc? > > > > I don't get an "internal server error", but the result list is empty. > > Thanks, Jonathan. > Sorry, Kyle, but that means that this cannot pass qa in the current form. We > would introduce more misinformation (no hits) for unimarc users than only > showing a damaged item or so too much. > Could you adjust the follow-up and make this notforloan part non-unimarc > specific? I wouldn't want to see a test (if marc21 else) here. I would prefer to see this patch pushed to master. I will try to provide a patch for bug 11586 soon (that will fix the problem with the last patch). Switch back to need QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:29:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:29:41 +0000 Subject: [Koha-bugs] [Bug 11586] Better default framework for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 --- Comment #3 from Jonathan Druart --- Gaetan, just looking at damaged and withdrawn: the dom file defined 995$1 for damaged and 995$3 for withdrawn (etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml ~l.1565). Who is right? Where can I found a ref? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:29:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:29:47 +0000 Subject: [Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:29:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:29:50 +0000 Subject: [Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29588|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 29645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29645&action=edit [PASSED QA] Bug 12417: adding the units tests of the module Koha::Borrower::Files.pm The module Koha::Borrower::Files.pm was not tested To test: 1/ Execute the command: prove t/db_dependent/Borrower_Files.t 2/ The command has to print: t/db_dependent/Borrower_Files.t .. ok All tests successful. Files=1, Tests=23, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.47 cusr 0.08 csys = 1.60 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Squashed patches. Now test pass No koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:30:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:30:57 +0000 Subject: [Koha-bugs] [Bug 5502] Patron card category search field should be menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5502 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:31:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:31:01 +0000 Subject: [Koha-bugs] [Bug 5502] Patron card category search field should be menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5502 --- Comment #3 from Owen Leonard --- Created attachment 29646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29646&action=edit Bug 5502 - Patron card category search field should be menu When searching for patrons to add to a patron card creator batch there is a text input field for submitting a patron category. This should be a dropdown menu. This patch corrects it. To test, go to Tools -> Patron card creator and click "New batch." - Click the "Add item(s)" button. - Confirm that in the Patron search pop-up window there is a dropdown menu populated with existing patron categories. - Confirm that searches limited by patron category return correct results. - Confirm that the correct patron category is automatically preselected after performing a search limited by category. - Confirm that reordering the table of search results works correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:35:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:35:13 +0000 Subject: [Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:35:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:35:16 +0000 Subject: [Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29589|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 29647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29647&action=edit [PASSED QA] Bug 12470: adding unit tests for the routines CheckValidBarCode and CheckIfIssuedToPatron of the module C4::Circulation.pm The routines CheckValidBarcode and CheckIfIssuedToPatron were not tested Test plan: 1/ Apply the patch 2/ Execute : prove t/db_dependent/Circulation/CheckValidBarcode.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t 3/ The result of the command has to be a success without error or warning : t/db_dependent/Circulation/CheckValidBarcode.t ...... ok t/db_dependent/Circulation/CheckIfIssuedToPatron.t .. ok All tests successful. Files=2, Tests=32, 3 wallclock secs ( 0.04 usr 0.01 sys + 2.88 cusr 0.17 csys = 3.10 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Patches squashed Tests pass, no koha-qa errors Signed-off-by: Kyle M Hall Tests pass using sample data provided with Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:37:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:37:36 +0000 Subject: [Koha-bugs] [Bug 11586] Better default framework for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 --- Comment #4 from Gaetan Boisson --- There is no standard to follow here. So we'll have to pick values, and make they work with the rest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:40:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:40:20 +0000 Subject: [Koha-bugs] [Bug 6896] searching an acq date finds due date instead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6896 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard --- I'm closing this with Nicole's permission because we no longer have enough information to test whether it is still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:40:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:40:41 +0000 Subject: [Koha-bugs] [Bug 12263] SIPServer does not respond correctly to signals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12263 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Yep! (In reply to M. de Rooy from comment #4) > Should the status of this report be already Passed QA? > Looking at the attachment name and two sign-offs.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:47:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:47:27 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:47:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:47:30 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29642|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 29648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29648&action=edit [PASSED QA] Bug 12558: DBIx::Class schema update 07/2014 Needed DBIx::Class schema update to keep sync with current kohastructure.sql. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Yohann Dufour Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:47:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:47:55 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29643|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 29649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29649&action=edit [PASSED QA] Bug 12558: Require DBIx::Schema::Loader v0.07039 or higher This patch shifts required DBIx::Schema::Loader required version. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Yohann Dufour Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:52:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:52:25 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24557|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 29650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29650&action=edit [SIGNED-OFF] Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. Signed-off-by: David Cook I love this patch! It is the best solution to this problem that I've seen. I think it is set up to perfectly handle dates in the notices. Unfortunately, the $dateonly flag is backwards, so the time is stripped from timestamps and 00:00:00 is added to dates without times. I'm adding a follow-up to reverse the setting of this flag. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:52:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:52:39 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24558|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 29651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29651&action=edit [SIGNED-OFF] Bug 11244: (follow-up) Fix $dateonly flag At the moment, $dateonly is set to true when $1 is defined. However, since the regex capture group only includes the time, this flag will only be set when there is a value that includes a time. In effect, this means that timestamps are reduced to dates only, while dates have 00-00-0000 added to them. This patch keeps the logic but reverses the values, so that $dateonly will default to true unless $1 is defined. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 17:53:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 15:53:45 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #25 from Kyle M Hall --- I would consider this such a major bug that we must fix it despite any performance decrease associated with it. (In reply to David Cook from comment #22) > (In reply to paxed from comment #20) > > This needs to be fixed. Patrons getting notices with dates in wrong format > > can cause problems, and will cause complaints... > > I agree. This is the oldest bug in my local bug tracker at the moment, and I > would love to see this get through. > > Honestly, even if it is slower than the past version, I rather have correct > output and slower performance on a job which is run once a day anyway. > > Changing this back to "Signed Off" to see what QA team has to say about this > one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 18:03:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 16:03:11 +0000 Subject: [Koha-bugs] [Bug 12294] Revert BZ9372 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29151|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 29652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29652&action=edit [PASSED QA] Bug 12294 : Cancel replacing carriage return on notices Cancel replacing carriage return with
    in printed html file as
    is needed in model for email notices when html format is checked Test plan : * define an OVERDUE notice with html activated, with
    at each end of line * make sur you've got some borrowers with overdues meeting your notices triggering rules (some with valid email and others without) * run overdue_notices.pl -html to generate html files for borrowers without email Without patch * email notifications are correctly formated as html content, with one
    at each end of line * in html file,
    is duplicated at each end of line With patch * nothing changes for email notification * html file is correctly formatted with only one
    at each end of line Signed-off-by: Bernardo Gonzalez Kriegel Copied test plan from comment. No errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 18:03:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 16:03:08 +0000 Subject: [Koha-bugs] [Bug 12294] Revert BZ9372 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 18:05:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 16:05:30 +0000 Subject: [Koha-bugs] [Bug 4148] Advanced Search not sorting by author In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4148 --- Comment #2 from Owen Leonard --- I still think the above explanation is correct. Does that make this bug invalid (since the search *is* sorting by author) or does that redefine the scope of the bug as "advanced search should include more than just 100a when sorting by author?" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 18:05:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 16:05:51 +0000 Subject: [Koha-bugs] [Bug 12294] Revert BZ9372 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- My only concern with this patch is the fact that libraries have taken into account this bug when crafting notices. However, given that this is a whitespace issue, I think a release note would be adequate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 18:13:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 16:13:41 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #129 from Kyle M Hall --- > I still think the tabs ... should read "Guarantees' checkouts" rather than > "Relatives' checkouts". I did not change that because I think that will only cause patrons to ask "What is a Guarantee?" I think that question should be left to the QA'er. > Also, do you think the secondary checkout tab (Relatives/Gaurentees) should > have a count next to it like the Checked out tab does, for consistency? Or > is that another enhancement? That would be a great addition, but definitely an enhancement outside the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 18:19:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 16:19:44 +0000 Subject: [Koha-bugs] [Bug 3309] Deleting authorized values when data exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3309 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All Version|rel_3_0 |master --- Comment #2 from Owen Leonard --- (In reply to Mirko Tietgen from comment #1) > This seems to still be valid. To reproduce I > - added a value to NOT_LOAN: '-5' with value 'fish' > - set an item to use that value > - deleted the authorizes value. I find that this is still the case -- I'm not blocked from deleting an authorized value which is in use by an item. However I see no related errors in the log. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 18:32:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 16:32:03 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #74 from Paola Rossi --- I've applied the patches against master 3.17.00.009 I've added a vendor. I've added a contact [filling the "Notes" field]. I've saved the vendor. 1) I've edited the vendor. The "Notes" field of the contact is shown empty. 2) I've filled the "Email" field of the contact with such a string : XXXXX I've selected "Save". The system has given no error, instead of sending "Please enter a valid email address" error. 3) I've tried to send late orders. The system has shown: "Email has been sent" but I (I'm the vendor...) have received no mail. On apache' log: [Fri Jul 11 17:09:29] lateorders.pl at line 107: Bad or missing From address: '' It seems SendAlerts line 366 has no mail in $userenv->{emailaddress}. [The "Primary email", "Secondary email" and "Alternate address' email" fields of the patron/login-user are set well.] 4) I've tried to send serials claims. I've "sent a notification". The system has given me no feedback, the subscription has become in "Claimed" status, but I've received no mail. On apache' log: [Fri Jul 11 17:29:43] claims.pl at line 78: Bad or missing From address: '' ---------------------------------------------------------------------------- So I've passed the patch to "Failed QA" status. --------------------------------------------------------------------------- NB. Soon after having saved the vendor "XX", I see: Home > Acquisition > Search for vendor Y, where Y is the id of the aqbookseller "XX". IMO Y is instead of the vendor's name, which can be searched. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 18:57:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 16:57:18 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #24 from Kyle M Hall --- (In reply to Nick Clemens from comment #23) > I got some odd results when testing: > > 1 Added four patrons to the list: > One with a checkout > One with a fine > Two with empty accounts > > Patron modification link seemed to work as expected Excellent! > Patron deletion link said 3 patrons would be deleted, I deleted, it said 3 > were gone, 2 were left in list (one with checkout, one with fine) > > I would be nice on the deletion screen to know who was going to be > deleted/who was deleted, I can't tell from my results which patron (issue or > fine) it was planning to delete. If not a list before deletion, maybe a > results list after the action. Those would be great features, but are general enhancements to the batch patron deletion tool and are outside the scope of this bug report. > I also found that I had two identical lists, both affected by deletion, but > don't know if that is from this patch Any deleted patrons would disappear from all patron lists, so that is to be expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 18:57:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 16:57:31 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 18:59:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 16:59:48 +0000 Subject: [Koha-bugs] [Bug 12377] Add date pickers to serials-edit.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 --- Comment #6 from Kyle M Hall --- Created attachment 29653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29653&action=edit Bug 12377 [QA Followup] - Remove readonly from input -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 19:00:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 17:00:38 +0000 Subject: [Koha-bugs] [Bug 12377] Add date pickers to serials-edit.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Kyle M Hall --- (In reply to Jonathan Druart from comment #4) > Why did you set the readonly attributes on the second input? My bad! Followup to fix issue is attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 19:16:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 17:16:54 +0000 Subject: [Koha-bugs] [Bug 12265] Improve Z39.50 servers administration (incl DBIx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- A couple place in the code you use search instead of fine. For example, I think my $rs=$schema->resultset('Z3950server')->search( { id => $id } ); my $name= $rs->first?$rs->first->name:''; y $cnt=$rs->delete; $template->param( msg_deleted => 1, msg_add => $name ) if $cnt==1; Could be rewritten as my $server = $schema->resultset('Z3950server')->find($id); if ( $server ) { $server->delete(); $template->param( msg_deleted => 1, msg_add => $server->name() ); } Even after calling delete, the object is still perfectly usable, no need to store the name in a separate variable. Marking as failed qa. This is still only suggestion, so feel free to add a followup, or just set status back to "signed off". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 19:21:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 17:21:03 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- I do believe all instances of "keys $params" need to be changed to "keys %$params". koha-qa -v 2 -c 1 testing 1 commit(s) (applied to cb8b0fe 'Bug 12508: Follow up - corrects capit') FAIL C4/Accounts.pm OK pod OK forbidden patterns FAIL valid Type of arg 1 to keys must be hash (not private variable) Compilation failed in require OK critic FAIL C4/Circulation.pm OK pod OK forbidden patterns FAIL valid Type of arg 1 to keys must be hash (not private variable) Compilation failed in require OK critic FAIL C4/Stats.pm OK pod OK forbidden patterns FAIL valid C4/Stats.pm had compilation errors. Type of arg 1 to keys must be hash (not private variable) OK critic FAIL t/db_dependent/Stats.t OK pod OK forbidden patterns FAIL valid Type of arg 1 to keys must be hash (not private variable) Compilation failed in require OK critic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:17:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:17:26 +0000 Subject: [Koha-bugs] [Bug 7156] singleBranchMode description wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7156 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 4941 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:17:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:17:26 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #5 from Owen Leonard --- *** Bug 7156 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:25:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:25:25 +0000 Subject: [Koha-bugs] [Bug 10485] Alphabetize REPORT_GROUP and REPORT_SUBGROUP Menus based on description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10485 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Version|3.10 |master Resolution|--- |FIXED --- Comment #2 from Owen Leonard --- This appears to be fixed in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:27:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:27:46 +0000 Subject: [Koha-bugs] [Bug 8671] Error on creating Patron Card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8671 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- I cannot reproduce this problem in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:33:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:33:42 +0000 Subject: [Koha-bugs] [Bug 12559] New: Wrong message if all cover images deleted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12559 Bug ID: 12559 Summary: Wrong message if all cover images deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org If a record contains a (one or more) local cover image and it is deleted, a wrong message is presented in the UI. To reproduce: - Have LocalCoverImages set to "Display" and AllowMultipleCovers set to "Allow". - Go to the detail page of a record that has no images attached. - The 'Images' tab conveniently shows the following message: "No images have been uploaded..." - Use the "upload" link to add a local cover to the record - Complete the process, and "view final record". - The 'Images' tab shows the added cover. - Delete the cover image using the link below the cover. => FAIL: 'Click on an image...' message still shows instead of 'No images have been...' You can try when more than one cover image, same results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:35:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:35:04 +0000 Subject: [Koha-bugs] [Bug 12559] Wrong message if all cover images deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12559 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:37:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:37:15 +0000 Subject: [Koha-bugs] [Bug 10360] Can't change patron password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10360 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Owen Leonard --- I cannot reproduce this error in 3.10.03 or master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:41:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:41:39 +0000 Subject: [Koha-bugs] [Bug 9866] OPAC advanced search error with Solr enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9866 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #5 from Owen Leonard --- Marking "Wontfix": See Bug 12538 - Solr removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:42:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:42:11 +0000 Subject: [Koha-bugs] [Bug 9868] Staff client catalog search returns no results with Solr enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9868 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Owen Leonard --- Marking "Wontfix": See Bug 12538 - Solr removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:44:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:44:56 +0000 Subject: [Koha-bugs] [Bug 12559] Wrong message if all cover images deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12559 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:45:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:45:00 +0000 Subject: [Koha-bugs] [Bug 12559] Wrong message if all cover images deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12559 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 29654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29654&action=edit Bug 12559: Wrong message if all cover images deleted If a record contains a (one or more) local cover image and it is deleted, a wrong message is presented in the UI. To reproduce: - Have LocalCoverImages set to "Display" and AllowMultipleCovers set to "Allow". - Go to the detail page of a record that has no images attached. - The 'Images' tab conveniently shows the following message: "No images have been uploaded..." - Use the "upload" link to add a local cover to the record - Complete the process, and "view final record". - The 'Images' tab shows the added cover. - Delete the cover image using the link below the cover. => FAIL: 'Click on an image...' message still shows instead of 'No images have been...' To test: - Apply the patch - Repeat the previous steps => SUCCESS : 'No images have been...' Bonus points: previous code didn't show a message at all if the user didn't have permissions to upload local cover images. I've split the message in two: - 'No images have been...' (for everyone) - 'Please upload (link)...' (for those with the right permissions :-D Regards To+ Edit: I used JavaScript to inject the 'No images...' message to aid localization. It can be improved once we fix some stuff in the translation scripts to better support placeholders/variables in the templates. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:45:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:45:54 +0000 Subject: [Koha-bugs] [Bug 10248] No results found message when searching using Solr in Staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10248 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Owen Leonard --- Marking "Wontfix": See Bug 12538 - Solr removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:46:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:46:11 +0000 Subject: [Koha-bugs] [Bug 9870] Error when run rebuild_solr.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9870 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Owen Leonard --- Marking "Wontfix": See Bug 12538 - Solr removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:52:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:52:02 +0000 Subject: [Koha-bugs] [Bug 8459] No results returned when restricting the search to an individual library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8459 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Owen Leonard --- This works for me in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:56:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:56:21 +0000 Subject: [Koha-bugs] [Bug 2889] templates should use loop_context_vars __odd__ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2889 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 |P5 - low Hardware|PC |All Assignee|gcollum at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:58:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:58:13 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use of CGI::scrolling_list |Omnibus: Use of |prevents customization in |CGI::scrolling_list |template |prevents customization in | |template -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:58:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:58:30 +0000 Subject: [Koha-bugs] [Bug 2310] Omnibus: Delete grayed out w/out explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Delete grayed out w/out |Omnibus: Delete grayed out |explanation |w/out explanation -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 20:59:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 18:59:31 +0000 Subject: [Koha-bugs] [Bug 2619] Turning on XSLTResultsDisplay preference turns off item detail display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2619 --- Comment #2 from Katrin Fischer --- I think this bug is interesting in light of our discussion to deprecate the non-XSLT views. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 21:02:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 19:02:28 +0000 Subject: [Koha-bugs] [Bug 2889] templates should use loop_context_vars __odd__ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2889 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW --- Comment #9 from Owen Leonard --- This bug is still valid. I see many instances with something like this: [% IF ( user.toggle ) %] [% ELSE %] [% END %] These can be converted to use [% IF ( loop.odd ) %] (which is already used in many places in the templates) or eliminated because the table is being manipulated by the DataTables plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 21:04:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 19:04:35 +0000 Subject: [Koha-bugs] [Bug 3123] Inventory / Stocktaking template & script errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- I believe this is no longer valid. The inventory tool has changed a lot since this bug was reported and is now using datatables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 21:07:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 19:07:22 +0000 Subject: [Koha-bugs] [Bug 2889] templates should use [% IF ( loop.odd ) %] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|templates should use |templates should use [% IF |loop_context_vars __odd__ |( loop.odd ) %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 21:24:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 19:24:31 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 --- Comment #9 from Galen Charlton --- Created attachment 29656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29656&action=edit Bug 12558: Require DBIx::Schema::Loader v0.07039 or higher This patch shifts required DBIx::Schema::Loader to a newer version to take advantage of improved smarts about foreign key relationships. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Yohann Dufour Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 21:24:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 19:24:26 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29648|0 |1 is obsolete| | Attachment #29649|0 |1 is obsolete| | --- Comment #8 from Galen Charlton --- Created attachment 29655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29655&action=edit Bug 12558: DBIx::Class schema update 07/2014 Update DBIx::Class schema classes to use a newer version of DBIx::Class:Schema::Loader. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Yohann Dufour Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 21:24:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 19:24:36 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 --- Comment #10 from Galen Charlton --- Created attachment 29657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29657&action=edit Bug 12558: (follow-up) remove old versions of schema classes for two tables The newer version of DBIx::Class::Schema::Loader tweaks how it maps plural table names to class names. As a consequence, two (currently-unused) classes are renamed. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 21:24:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 19:24:50 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 21:24:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 19:24:57 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 21:30:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 19:30:04 +0000 Subject: [Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 21:30:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 19:30:29 +0000 Subject: [Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Brendan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 21:31:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 19:31:10 +0000 Subject: [Koha-bugs] [Bug 12558] DBIx::Class schema update 07/2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12558 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 11 22:10:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jul 2014 20:10:29 +0000 Subject: [Koha-bugs] [Bug 10709] only overdue notices & slips can be branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10709 --- Comment #1 from Nicole C. Engard --- Checking in to see if this is a bug or an enhancement that needs better documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 11:43:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 09:43:16 +0000 Subject: [Koha-bugs] [Bug 4000] Budgets table doesn't show tree view for sub-budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4000 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Katrin Fischer --- I believe this was fixed by bug 11578. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 12:12:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 10:12:40 +0000 Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137 --- Comment #5 from Katrin Fischer --- I just tested this in master and it doesn't work for me. I added 2 suggestions to different patron accounts (from staff side) and switched so it should show me all suggestions. Only my suggestion shows in the list for both "Me" and "Anyone". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 12:15:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 10:15:31 +0000 Subject: [Koha-bugs] [Bug 4144] CheckDate() does not pay attention to date format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- Retested on current master, no problems found. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 12:22:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 10:22:30 +0000 Subject: [Koha-bugs] [Bug 4162] Inventory Tool Fails Silently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I tried uploading a .png file, the result looks interesting. This could certainly be improved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 12:23:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 10:23:21 +0000 Subject: [Koha-bugs] [Bug 4176] MIME missing from sys prefs interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4176 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Do we just miss a database update here removing the removed pref from old databases? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 12:28:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 10:28:04 +0000 Subject: [Koha-bugs] [Bug 12560] New: Wrong capitalization on acquisition statistics page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12560 Bug ID: 12560 Summary: Wrong capitalization on acquisition statistics page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Maybe something for a first patch, a tiny capitalization problem: - Reports > Acquisitions statistics - 'Item Type' should be 'Item type' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 12:29:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 10:29:00 +0000 Subject: [Koha-bugs] [Bug 4282] acq stats misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4282 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- The funds vs. budgets problem is fixed in master. I think probably better to move the other points to a feature request bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 12:38:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 10:38:05 +0000 Subject: [Koha-bugs] [Bug 3950] Pending reserve problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- Can't reproduce on master. First the hold showed up, then it vanished from the list after I put it in transfer to its destination. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 12:39:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 10:39:48 +0000 Subject: [Koha-bugs] [Bug 4037] Inventory Tool Missing Item Type Filter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4037 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|normal |enhancement -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 12:43:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 10:43:14 +0000 Subject: [Koha-bugs] [Bug 4833] show all fields when ordering from suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|minor |enhancement -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 12:45:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 10:45:12 +0000 Subject: [Koha-bugs] [Bug 4948] canceling a hold missing steps for existing holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4948 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|normal |enhancement -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:00:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:00:43 +0000 Subject: [Koha-bugs] [Bug 12561] New: Omnibus: Deprecate non-XSLT detail and result views Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Bug ID: 12561 Summary: Omnibus: Deprecate non-XSLT detail and result views Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The deprecation of the non-XSLT views for staff and OPAC were discussed at the Developer meetings on 2 July: http://wiki.koha-community.org/wiki/Development_IRC_meeting,_2_July_2014 This bug is to collect feature differences - features available for non-XSLT views but not for XSLT and other issues that need to be resolved in order to be able to remove the non-XSLT views from Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:00:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:00:50 +0000 Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:01:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:01:13 +0000 Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5229 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:01:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:01:13 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference does not work with XSLT results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12561 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:08:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:08:25 +0000 Subject: [Koha-bugs] [Bug 6875] de-nesting C4 packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #88 from Katrin Fischer --- +1 closing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:19:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:19:54 +0000 Subject: [Koha-bugs] [Bug 6909] Detect duplicates when importing records - not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6909 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- There has been no response from the reporter for over 2 years and a lot of people are using isbn/issn matching successfully, so I am closing this WORKSFORME. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:24:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:24:52 +0000 Subject: [Koha-bugs] [Bug 12562] New: Capitalization: 'Save Report' when saving a new SQL report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12562 Bug ID: 12562 Summary: Capitalization: 'Save Report' when saving a new SQL report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Another easy one for a beginner or first patch: - Reports > New SQL report - 'Save Report' should be 'Save report' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:28:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:28:32 +0000 Subject: [Koha-bugs] [Bug 7023] used saved report page holding on to filter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- Hm, I can't reproduce this on master - Nicole, can you reopen if you can? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:29:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:29:52 +0000 Subject: [Koha-bugs] [Bug 7237] duplicating patron not using patron's branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7237 --- Comment #2 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:31:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:31:01 +0000 Subject: [Koha-bugs] [Bug 7374] can't upload icon for auth values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement --- Comment #2 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:33:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:33:06 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 --- Comment #3 from Katrin Fischer --- Tested on current master: - Patron module main page - [+] is there and working - Patron detail page - [+] is there, but not working correctly. The additional fields don't show up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:36:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:36:39 +0000 Subject: [Koha-bugs] [Bug 12563] New: Capitalization: 'Set Status' on detail pages item's tab Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12563 Bug ID: 12563 Summary: Capitalization: 'Set Status' on detail pages item's tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org And another small thing for a new developer or first patch: - Search for a record in the catalog - Go to the detail page - Switch to the 'items' tab - Look for the 2 'Set Status' buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:38:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:38:49 +0000 Subject: [Koha-bugs] [Bug 7479] Inventory Tool Ignoring Lost Flags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7479 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- Retested on current master, works ok for me now and lots of changes in the module since this was reported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:42:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:42:12 +0000 Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2619 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:42:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:42:12 +0000 Subject: [Koha-bugs] [Bug 2619] Turning on XSLTResultsDisplay preference turns off item detail display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12561 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:44:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:44:28 +0000 Subject: [Koha-bugs] [Bug 7625] normal templates not showing links properly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX --- Comment #3 from Katrin Fischer --- I think this is a WONTFIX now by coding guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines#DEPR1:_non-XSLT_search_results_and_bib_display_templates_deprecated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:48:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:48:51 +0000 Subject: [Koha-bugs] [Bug 11931] Notices do not respect module, code, branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11931 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 7997 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 13:48:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 11:48:51 +0000 Subject: [Koha-bugs] [Bug 7997] can create a notice with the same code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #14 from Katrin Fischer --- *** Bug 11931 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:06:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:06:40 +0000 Subject: [Koha-bugs] [Bug 8359] enter submits acq order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8359 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- Hi Nicole, I tested the order form in master and can't reproduce the problem. I believe it's been fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:06:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:06:40 +0000 Subject: [Koha-bugs] [Bug 8803] modifying order quantity in neworderempty.pl has restrictions implemented in javascript that can be bypassed with the enter key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8803 Bug 8803 depends on bug 8359, which changed state. Bug 8359 Summary: enter submits acq order http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8359 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:07:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:07:27 +0000 Subject: [Koha-bugs] [Bug 8531] Staff hold requests generate silent errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8531 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 8474 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:07:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:07:27 +0000 Subject: [Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors in koha-error_log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474 --- Comment #2 from Katrin Fischer --- *** Bug 8531 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:12:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:12:02 +0000 Subject: [Koha-bugs] [Bug 8540] Several staff client scripts which do not require authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8540 --- Comment #3 from Katrin Fischer --- bug 11715 fixed at least some of those. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:15:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:15:05 +0000 Subject: [Koha-bugs] [Bug 8616] Displaying relator codes in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- There are spaces now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:28:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:28:31 +0000 Subject: [Koha-bugs] [Bug 8539] Library transfer limits page has incorrect permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:28:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:28:34 +0000 Subject: [Koha-bugs] [Bug 8539] Library transfer limits page has incorrect permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 --- Comment #1 from Katrin Fischer --- Created attachment 29658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29658&action=edit Bug 8539: Library transfer limits page has incorrect permission Without this patch the library transfer page required the 'borrowers' permission, which is not quite right for a page in the administration module. This patch changes the permission to 'parameters_remaining_permissions' To test: Verify the page is accessbile with: - superlibrarian - administration (full) - administration, remaining permissions (without manage_circ_rules) Verify the page is not accessible without all of those permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:28:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:28:55 +0000 Subject: [Koha-bugs] [Bug 8539] Library transfer limits page has incorrect permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8539 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:31:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:31:35 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Could this be related to bug 12025? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:34:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:34:32 +0000 Subject: [Koha-bugs] [Bug 6515] Advanced notice days not saved when notice is not activated (email, sms set) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6515 --- Comment #2 from Katrin Fischer --- *** Bug 8763 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:34:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:34:32 +0000 Subject: [Koha-bugs] [Bug 8763] default messaging not saving if you pick digests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8763 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 6515 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:44:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:44:22 +0000 Subject: [Koha-bugs] [Bug 9194] browse search aligned funny in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9194 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX --- Comment #4 from Katrin Fischer --- Marking this WONTFIX, see: http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML5:_Deprecation_of_the_.27prog.27_and_.27CCSR.27_OPAC_themes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:45:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:45:08 +0000 Subject: [Koha-bugs] [Bug 9197] opacnav shows below tabs on opac-user.pl in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9197 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX --- Comment #5 from Katrin Fischer --- Marking this WONTFIX, see: http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML5:_Deprecation_of_the_.27prog.27_and_.27CCSR.27_OPAC_themes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:45:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:45:32 +0000 Subject: [Koha-bugs] [Bug 9199] comments template could use some clean up in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9199 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer --- Marking this WONTFIX, see: http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML5:_Deprecation_of_the_.27prog.27_and_.27CCSR.27_OPAC_themes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:46:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:46:45 +0000 Subject: [Koha-bugs] [Bug 11116] QuoteOfTheDay box overlaps OpacNav text in ccsr under Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11116 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer --- Marking this WONTFIX, see: http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML5:_Deprecation_of_the_.27prog.27_and_.27CCSR.27_OPAC_themes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:47:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:47:18 +0000 Subject: [Koha-bugs] [Bug 9934] OPAC info tooltip doesn't appear in CCSR theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9934 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer --- Marking this WONTFIX, see: http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML5:_Deprecation_of_the_.27prog.27_and_.27CCSR.27_OPAC_themes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:47:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:47:59 +0000 Subject: [Koha-bugs] [Bug 9601] ccsr opac no results found ugly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9601 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer --- Marking this WONTFIX, see: http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML5:_Deprecation_of_the_.27prog.27_and_.27CCSR.27_OPAC_themes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:50:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:50:50 +0000 Subject: [Koha-bugs] [Bug 9220] Unchecking "create SQL reports" prevents staff member from being able to run reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9220 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:51:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:51:13 +0000 Subject: [Koha-bugs] [Bug 8938] Transport cost matrix script and template contain untranslatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8938 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr, | |katrin.fischer at bsz-bw.de Component|System Administration |I18N/L10N -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:51:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:51:54 +0000 Subject: [Koha-bugs] [Bug 8990] Jquery UI images missing in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8990 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Fridolin, can we close this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:52:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:52:47 +0000 Subject: [Koha-bugs] [Bug 9338] 'Empty' patron search no longer returns all patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9338 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Katrin Fischer --- No activity on this for a few years and it's possible to retrieve all patrons by searching for '%' - closing this report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:54:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:54:12 +0000 Subject: [Koha-bugs] [Bug 9337] Alphabet for browsing patrons by last name not visible after performing a patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9337 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- This works on current master, alphabet always remains visible and works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:55:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:55:20 +0000 Subject: [Koha-bugs] [Bug 9080] Encoding on pay fines page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9080 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:55:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:55:20 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9080 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 14:57:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 12:57:37 +0000 Subject: [Koha-bugs] [Bug 9092] Inaccurate Shelf List on Inventory/Stocktaking Tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- I am not sure how to reproduce this bug with the information given and there have been no other reports of missing entries in the shelf lists sinse. Also the module was changed quite a bit since this bug report was written. Resolving this, please reopen with with more information if you still see problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:04:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:04:39 +0000 Subject: [Koha-bugs] [Bug 9237] canceling a receive redirects to a blank receive screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9237 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- The cancel link works nicey on current master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:07:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:07:06 +0000 Subject: [Koha-bugs] [Bug 9333] Confirm close and confirm reopen JavaScript alerts do not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Owen, I think those are probably not in Boostrap - can we close the bug? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:10:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:10:01 +0000 Subject: [Koha-bugs] [Bug 9359] Cannot delete records from baskets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9359 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- Hm, I can't reproduce this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:23:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:23:09 +0000 Subject: [Koha-bugs] [Bug 12564] New: Capitalization: Buttons in inventory tool Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12564 Bug ID: 12564 Summary: Capitalization: Buttons in inventory tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Open the inventory tool, do a search. At the bottom of the result list there are buttons for various actions, 2 of those are: Mark Seen and Continue Continue without Marking They should be: Mark seen and continue Continue without marking -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:27:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:27:22 +0000 Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Still happens in current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:30:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:30:25 +0000 Subject: [Koha-bugs] [Bug 8797] can't delete quote of the day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 --- Comment #7 from Katrin Fischer --- *** Bug 9670 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:30:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:30:25 +0000 Subject: [Koha-bugs] [Bug 9670] can't delete quote of the day that was just added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9670 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #4 from Katrin Fischer --- This looks to be very similar or a duplicate of bug 8797. *** This bug has been marked as a duplicate of bug 8797 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:32:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:32:20 +0000 Subject: [Koha-bugs] [Bug 9847] arrows for child funds not always showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #6 from Katrin Fischer --- I believe this was fixed by bug 11578. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:36:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:36:59 +0000 Subject: [Koha-bugs] [Bug 9963] Inventory tool doing strange things In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9963 --- Comment #2 from Katrin Fischer --- Hi Nicole, bug 7684 has now been pushed, could you check if this bug can be closed? I looked at the video, but I am not sure how to reproduce this and the tool now looks very different using datatables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:42:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:42:39 +0000 Subject: [Koha-bugs] [Bug 10228] cart and list download/email background sloppy in CCSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10228 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer --- Marking this WONTFIX, see: http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML5:_Deprecation_of_the_.27prog.27_and_.27CCSR.27_OPAC_themes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:44:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:44:22 +0000 Subject: [Koha-bugs] [Bug 10122] jQueryUI tabs on my summary page not highlighted in CCSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10122 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX --- Comment #3 from Katrin Fischer --- Marking this WONTFIX, see: http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML5:_Deprecation_of_the_.27prog.27_and_.27CCSR.27_OPAC_themes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:50:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:50:20 +0000 Subject: [Koha-bugs] [Bug 10301] notes not showing on receive page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10301 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Katrin Fischer --- This works ok on current master using the 'internal note'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:52:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:52:24 +0000 Subject: [Koha-bugs] [Bug 10285] Error 500 in staff client displays old start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- This is still valid for master. Maybe we should just show the message and remove all the links to the modules below? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:53:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:53:00 +0000 Subject: [Koha-bugs] [Bug 4162] Inventory Tool Fails Silently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:53:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:53:03 +0000 Subject: [Koha-bugs] [Bug 4162] Inventory Tool Fails Silently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 --- Comment #2 from M. Tompsett --- Created attachment 29659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29659&action=edit Bug 4162 The inventory tool lacks validation for barcodes The inventory tool had no form of validating on what was assumed to be a valid barcode number. To solve this, an extra loop to read before processing was added. This allows to validate length (<=20 which is the current size of the barcode field in the items table) and content (assumed that 0-9a-zA-Z was good enough). The template was modified to accomodate validation messages related to the length and content errors. TEST PLAN --------- 1) Attempt to select a file which does not contain barcodes and is not a text file. -- a horrible lack of validation and spamminess ensues. 2) Apply patch 3) Create three files. a) One containing valid barcodes on each line -- this file should trigger no errors. b) A copy of the first with an extra line of >20 characters (e.g. The Quick Red Fox Jumped Over The Brown Fence) -- this file should trigger the singular error message case. c) A copy of the second with the last line duplicated -- this file should trigger the plural error message case. 4) Attempt each of the three files. 5) Run koha-qa tools. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:53:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:53:23 +0000 Subject: [Koha-bugs] [Bug 4162] Inventory Tool Fails Silently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Assignee|gmcharlt at gmail.com |mtompset at hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 15:54:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 13:54:34 +0000 Subject: [Koha-bugs] [Bug 10224] In transit not working for Silver Hills In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:01:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:01:04 +0000 Subject: [Koha-bugs] [Bug 4162] Inventory Tool Fails Silently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 --- Comment #3 from Katrin Fischer --- > content (assumed that 0-9a-zA-Z was good enough). As we don't enforce any restrictions on the barcode in circ and cataloguing, I think we can't do that here. I have seen libraries using special characters like ? and - in their barcodes and this would make it impossible for them to use the inventory tool. The length restriction seems like a good idea - should be ok to check just the first line of the file maybe? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:03:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:03:53 +0000 Subject: [Koha-bugs] [Bug 10136] misc/translator/translator_doc.html outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Katrin Fischer --- Not sure what's best to do here - should we remove the old files with outdated instructions or try to update them? Should we just add a link in the file pointing to the instructions on the wiki? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:22:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:22:28 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9080 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:22:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:22:28 +0000 Subject: [Koha-bugs] [Bug 9080] Encoding on pay fines page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9080 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:22:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:22:49 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9080 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:22:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:22:49 +0000 Subject: [Koha-bugs] [Bug 9080] Encoding on pay fines page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9080 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11944 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:23:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:23:00 +0000 Subject: [Koha-bugs] [Bug 10180] [master] Diacritics in Z39.50 search results in acquisitions are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 --- Comment #3 from Katrin Fischer --- These problems were found before some encoding changes on master were reverted, adding to the utf-8 clean-up bug for testing with these patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:23:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:23:00 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10180 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:24:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:24:46 +0000 Subject: [Koha-bugs] [Bug 10155] Patron search should remember search options selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10155 --- Comment #2 from Katrin Fischer --- Search type at the top still reverts to the default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:24:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:24:51 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10155 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:24:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:24:51 +0000 Subject: [Koha-bugs] [Bug 10155] Patron search should remember search options selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10155 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9811 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:28:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:28:54 +0000 Subject: [Koha-bugs] [Bug 10158] sorting serial issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10158 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I think 6655 is not related here, as it's not referring to the items tab for serials. On your screenshot, I thin the sorting is by itemtype (little arrow in the header column). Also the first item seems to have no library assigned to it? I think that's the reason it shows up first in the list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:30:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:30:42 +0000 Subject: [Koha-bugs] [Bug 10388] acq edited items showing 'null's In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 --- Comment #2 from Katrin Fischer --- This is still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:36:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:36:01 +0000 Subject: [Koha-bugs] [Bug 10571] IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12561 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:36:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:36:01 +0000 Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10571 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:44:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:44:01 +0000 Subject: [Koha-bugs] [Bug 10702] can't create notices for a specific branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10702 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Part of the problem here is that the page reloads when you change the module after selecting the branch. A first fix to avoid more confusion would be switching the order of the fields and put the module first. A better solution would be to avoid the reloading. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 16:46:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 14:46:16 +0000 Subject: [Koha-bugs] [Bug 10749] patron permissions typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10749 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Perform batch modification of patrons - fixed but cant modify budgets - not fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 18:11:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 16:11:59 +0000 Subject: [Koha-bugs] [Bug 4162] Inventory Tool Fails Silently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29659|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 29660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29660&action=edit Bug 4162 The inventory tool lacks validation for barcodes The inventory tool had no form of validating on what was assumed to be a valid barcode number. To solve this, an extra loop to read before processing was added. This allows to validate length and content (assumed that [:print:] was good enough). The template was modified to accomodate validation messages related to the length and content errors. TEST PLAN --------- 1) Attempt to select a file which does not contain barcodes and is not a text file. -- a horrible lack of validation and spamminess ensues. 2) Apply patch 3) Create three files. a) One containing valid barcodes on each line -- this file should trigger no errors. b) A copy of the first with an extra line of >20 characters (e.g. The Quick Red Fox Jumped Over The Brown Fence^A^B^C) -- this file should trigger the singular error message case. ^A^B^C are actually CTRL-A,CTRL-B,CTRL-C, and it is left as an exercise to the reader to add them to the line. c) A copy of the second with the last line duplicated -- this file should trigger the plural error message case. 4) Attempt each of the three files. 5) Run koha-qa tools. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 18:54:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 16:54:06 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #6 from Katrin Fischer --- Working on testing this with the help of Biblibre. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 19:55:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 17:55:34 +0000 Subject: [Koha-bugs] [Bug 10285] Error 500 in staff client displays old start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 --- Comment #3 from Magnus Enger --- (In reply to Katrin Fischer from comment #2) > This is still valid for master. Maybe we should just show the message and > remove all the links to the modules below? +1 from me. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 20:40:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 18:40:09 +0000 Subject: [Koha-bugs] [Bug 12565] New: Acq: Link to basket in breadcrumbs broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12565 Bug ID: 12565 Summary: Acq: Link to basket in breadcrumbs broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To reproduce: - Start a new basket - Search for an existing record in your catalog - Try to get back to the basket, using the link in the breadcrumbs - Verify it won't work - Look at the link, it will look something like: /cgi-bin/koha/acqui/basket.pl?=55 There is an extra ? that breaks it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 20:51:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 18:51:05 +0000 Subject: [Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323 --- Comment #10 from Katrin Fischer --- I've retested this: I searched for an existing record to create an order line from in acquisitions. My search term was DE-576, which is the MarcOrgCode that appears in most of my records. Without patch, plain master: - QueryParser: Try - Results ARE sorted by biblionumber - QueryParser: Don't try - Results ARE sorted by biblionumber With patch: - Query parser: Try - Results ARE sorted by bilbionumber - Query parser: Don't try - Results ARE sorted by bilbionumber ... I am confused now. Maybe some other setting plays a role here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 21:11:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 19:11:35 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from Katrin Fischer --- Mark was right, with the patch, every search with more than OPACnumSearchResults results will show a counter with OPACnumSearchResults search results. In my case 22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:31:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:31:05 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #72 from Katrin Fischer --- This works ok, but I'd like to see a follow up removing the (N) and (Y) as the keyboard shortcuts don't seem to work - other option of course is to make them work :) But, not a blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:35:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:35:04 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #73 from Katrin Fischer --- Possible enhancements: - Make the cancellation reason searchable - Make it possible to edit the reason later on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:38:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:38:31 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #74 from Katrin Fischer --- Created attachment 29661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29661&action=edit [PASSED QA] Bug 7162: Factorize code for order cancellation Some code was duplicated, all is now in cancelorder.pl Added possibility to provide a reason for cancellation (or other things, this is saved in aqorders.notes) Signed-off-by: Corinne Bulac Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:38:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:38:36 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #75 from Katrin Fischer --- Created attachment 29662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29662&action=edit [PASSED QA] Bug 7162 [Follow-up] Fix referrer URL when coming from parcel.pl Signed-off-by: Corinne Bulac Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:38:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:38:40 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #76 from Katrin Fischer --- Created attachment 29663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29663&action=edit [PASSED QA] Bug 7162; Factorize code for order cancellation (QA fixes) * Remove tab characters in acqui/addorder.pl * Remove FIXME in acqui/cancelorder.pl * Fix typos: "canceled" -> "cancelled", "occured" -> "occurred" * Replace "Click here" link by "OK" * Add a column to aqorders to store cancellation reason instead of having it in aqorders.notes, to avoid having untranslatable strings in database Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:38:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:38:44 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #77 from Katrin Fischer --- Created attachment 29664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29664&action=edit [PASSED QA] Bug 7162: Add unit tests for DelOrder Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:38:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:38:48 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #78 from Katrin Fischer --- Created attachment 29665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29665&action=edit [PASSED QA] Bug 7162: Factorize code for order cancellation (QA fixes) Signed-off-by: Katrin Fischer Passes tests and QA script. Checked cancelling the orders from the basket and from the receive page. Both worked nicely. Cancellation reason is shown on the cancelled order line in the basket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:39:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:39:42 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:39:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:39:45 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28560|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:39:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:39:48 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29536|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:39:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:39:51 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28836|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:39:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:39:54 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28558|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:39:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:39:57 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28559|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 22:50:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 20:50:44 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #79 from Katrin Fischer --- Ah, I am sorry, but the tests are failing. I got the wrong number of tests when I fixed the conflict in that line, but there are also quite a few tests failing. t/db_dependent/Acquisition.t .. Dubious, test returned 8 (wstat 2048, 0x800) Failed 8/91 subtests Test Summary Report ------------------- t/db_dependent/Acquisition.t (Wstat: 2048 Tests: 91 Failed: 8) Failed tests: 17, 19, 22, 24, 28, 30, 34, 36 Non-zero exit status: 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 12 23:35:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jul 2014 21:35:45 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #59 from Katrin Fischer --- Hi Jonathan, thx for providing new patches, this is a fun feature! Starting with a code review: 1) QA script I had this error before I ran the database update: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt OK forbidden patterns FAIL valid_template DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha.columns_settings' doesn't exist at /home/katrin/kohaclone/C4/Utils/DataTables/ColumnsSettings.pm line 34 After the database update QA script was ok. 2) Copyright - update? +# Copyright BibLibre 2013 3) Add new library to About page? jquery.dataTables.colvis.js 4) Capitalization Is Hidden by default Now onto testing: 5) Configuration page Nice accordeon :) Changes save correctly. a) After saving a new configuration, it would be nice if the section you worked in remained open, instead of it jumping back to the first - Acquisitions. b) I am not sure why currency is displayed twice in different font size? 6) Currencies page The table showed according to what I had configured. Changes made with the options on the page were remembered during my session. Table shows as normal with Javascript deactivated. a) The options to toggle/hide could be positioned a bit closer to the table, maybe we could even use an icon later? Just something we could try to improve a bit more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 13 20:31:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jul 2014 18:31:16 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #25 from Nick Clemens --- Understood on all, I was unclear in my comment though, sorry for that I checked off all 4 patrons for deletion, the deletion tool said it would delete 3, and that it had deleted 3, but only 2 were actually deleted. It seemed to work as expected, not deleting patrons with fines or checkouts, but the message to the user was unclear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 00:18:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jul 2014 22:18:38 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 --- Comment #10 from mathieu saby --- Created attachment 29666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29666&action=edit [PATCH 2/2] Bug 11230: dereference hashes in keys (QA followup) This followup replaces $params with %$params in keys function It also fixes some wording -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 00:18:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jul 2014 22:18:48 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 00:21:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jul 2014 22:21:28 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 --- Comment #11 from mathieu saby --- I hope I fixed it. I'm afraid beeing too far from Koha is making me forget my Perl... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 00:35:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jul 2014 22:35:43 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28514|0 |1 is obsolete| | --- Comment #48 from mathieu saby --- Created attachment 29667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29667&action=edit [PATCH 1/2] Bug 10758 - Show bibliographic information of deleted records in acquisitions Indeed, that horrible ">>>HEAD" was breaking everything! It's fixed. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 00:35:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jul 2014 22:35:57 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 00:59:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jul 2014 22:59:25 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #72 from mathieu saby --- (In reply to Levast from comment #70) > we can't understand why we should return on the page of reception to delete > the record already deleted in the basket : > - go on receipt page > - in the line matching this order, you should see instead of the title > "Deleted bibliographic record, can't find title" Hello It is NOT a normal procedure, but a way to fix some mistakes that sometimes happen. When you try to delete a record used in some order, Koha now prevents you to do so with this warning : "Warning: This record is used in 1 order(s). Deleting it could cause serious issues on acquisition module. Are you sure you want to delete this record?". But it is a very recent behavior introduced last year by bug 9780. Before that, a librarian could very easily delete a record used in an order. And technically, it is still possible to do so... So, it happened in some libraries that some orders are linked with deleted records, and Koha does not allow you to suppress these orders, either in baskets (when the basket is open), or in the reception module (when the basket is closed, and the order is pending). The aim of this bug is to allow you to cancel these orders linked with deleted records in the same way as any other orders. I'm going to check if it works well before changing status. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 01:16:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jul 2014 23:16:42 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28516|0 |1 is obsolete| | --- Comment #73 from mathieu saby --- Created attachment 29668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29668&action=edit [PATCH 2/2] Bug 10869 Followup: Unit tests for DelOrder Unit tests need a little rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 01:19:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jul 2014 23:19:31 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #74 from mathieu saby --- I tested the 3 patches again. For me it works as it should work : Without the patches, you cannot cancel an order in a basket page or the reception page if the record used by this order was deleted before (that's not good practice, I agree, but those kind of things happen). With the patches, you can. Could someone test again please ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 02:09:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 00:09:06 +0000 Subject: [Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323 --- Comment #11 from David Cook --- (In reply to Katrin Fischer from comment #10) > I've retested this: > > I searched for an existing record to create an order line from in > acquisitions. My search term was DE-576, which is the MarcOrgCode that > appears in most of my records. > > Without patch, plain master: > - QueryParser: Try > - Results ARE sorted by biblionumber > > - QueryParser: Don't try > - Results ARE sorted by biblionumber > > With patch: > - Query parser: Try > - Results ARE sorted by bilbionumber > > - Query parser: Don't try > - Results ARE sorted by bilbionumber > > ... I am confused now. Maybe some other setting plays a role here? When QueryParser is set to "Don't try", "QueryAutoTruncation" will turn off relevance searching if it's set to "automatically". However, relevance searching shouldn't be affected by "QueryAutoTruncation" when QueryParser is set to "Try". I suspect...that your result might be coincidence, Katrin. With the QueryParser, it applies relevance to your search query as well as adding relevance subqueries for title keyword and title exact. Since you're using "DE-576" as your search term, you'll probably get no hits for title keyword or title exact, so the relevance "bumps" become irrelevant. Then, for the results you do get, I suspect that "DE-576" would only show up once in a record so each record retrieved would have the same relevance score. Since the search term is quite specific, Zebra will probably only return records with that exact search term so you won't get anything "less relevant". tl;dr Katrin, could you try again but using a more vague search term? Something that is likely to appear in a lot of different records with different frequency? Probably a noun. I often like to use "health" or "test" as we have a lot of medical records. I might be wrong, but...I think that's the most logical explanation for your results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 03:36:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 01:36:31 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 03:36:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 01:36:36 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29575|0 |1 is obsolete| | --- Comment #47 from Chris Cormack --- Created attachment 29669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29669&action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup Short: Launch an indexing daemon (rebuild_zebra.pl -daemon) process for each enabled instance. Enabling/disabling the use of the indexer is handled by global configuration variables in /etc/default/koha-common. Also provides command line tools to manage the running indexer daemons for your instances. Long: Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute incremental reindexing, a requirement from our librarians.[1] Using the indexer daemon could remain "experimental" until it gets more testing; so is disabled by default initially. To enable the use of the indexer the user has to tweak the /etc/default/koha-common config file. Specifically the USE_INDEXER_DAEMON variable, which is clearly explained in the file. Frecquency defaults to 5 sec, and can be changed by tweaking the /etc/default/koha-common config file too. This patch uses rebuild_zebra.pl in daemon mode, but it is crafted to allow changing the indexing daemon and passing specific option switches it might need. Regards To+ [1] This is the .deb version of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 04:13:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 02:13:11 +0000 Subject: [Koha-bugs] [Bug 12566] New: Duplicate checks for Self Registered borrowers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12566 Bug ID: 12566 Summary: Duplicate checks for Self Registered borrowers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Borrowers who self register are not checked against existing borrowers for duplication. This may be ok in large libraries who have staff to check the incoming queue rigorously, but for small libraries who want all borrowers to self register, this is a big problem. If a borrower forgets their password or misses the password during self registration, they can create as many accounts as they like with the same information. This can be very confusing for library staff - as the library staff doesn't know which account is the active one, or the borrower may have many active accounts I think this should be a toggleable option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 12:11:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 10:11:52 +0000 Subject: [Koha-bugs] [Bug 12265] Improve Z39.50 servers administration (incl DBIx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12265 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 12:11:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 10:11:55 +0000 Subject: [Koha-bugs] [Bug 12265] Improve Z39.50 servers administration (incl DBIx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12265 --- Comment #7 from M. de Rooy --- Created attachment 29670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29670&action=edit Bug 12265: [QA Follow-up] Replace DBIx search by find This patch replaces DBIx search by find at two places in z3950servers.pl. Furthermore, it adds testing on the results of the find method, passing a not-found-message to the template whenever needed. The function ServerSearch is adjusted to use HashRefInflator instead of manually mapping the columns of result objects. An additional defined-test in _form_data_hashref prevents shifting of names and values in the result hash. Test plan: List all servers. Edit, copy and delete a server. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 12:14:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 10:14:59 +0000 Subject: [Koha-bugs] [Bug 12265] Improve Z39.50 servers administration (incl DBIx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12265 --- Comment #8 from M. de Rooy --- (In reply to Kyle M Hall from comment #6) > A couple place in the code you use search instead of fine. For example, I > think > > my $rs=$schema->resultset('Z3950server')->search( { id => $id } ); > my $name= $rs->first?$rs->first->name:''; > y $cnt=$rs->delete; > $template->param( msg_deleted => 1, msg_add => $name ) if $cnt==1; > > Could be rewritten as > > my $server = $schema->resultset('Z3950server')->find($id); > if ( $server ) { > $server->delete(); > $template->param( msg_deleted => 1, msg_add => $server->name() ); > } > Thanks for QAing. Replaced two occurrences. The third one should be a search. Added a few extra lines for additional testing. I have changed the status back to Signed-off. If you feel that the follow-up needs additional signoff, please set it to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 13:23:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 11:23:10 +0000 Subject: [Koha-bugs] [Bug 12458] Holidays calendar has wrong colors for weekly and yearly repeatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12458 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to 2.12.x, will be in 3.12.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 13:27:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 11:27:07 +0000 Subject: [Koha-bugs] [Bug 12034] MSG_REMOVE_FROM_LIST different wording between OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to 3.12.x, will be in 3.12.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 13:28:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 11:28:03 +0000 Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to 3.12.x, will be in 3.12.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 13:30:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 11:30:24 +0000 Subject: [Koha-bugs] [Bug 12265] Improve Z39.50 servers administration (incl DBIx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12265 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 13:46:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 11:46:26 +0000 Subject: [Koha-bugs] [Bug 12265] Improve Z39.50 servers administration (incl DBIx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 13:46:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 11:46:28 +0000 Subject: [Koha-bugs] [Bug 12265] Improve Z39.50 servers administration (incl DBIx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28718|0 |1 is obsolete| | Attachment #29670|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 29671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29671&action=edit [PASSED QA] Bug 12265: Improve Z39.50 servers administration This patch makes a few tiny improvements on the form, does some housekeeping/tidying up, and replaces SQL code by DBIC statements. In detail: - Adds an id parameter (more precise than searchfield). - With the move from searchfield to id, you can rename a server now. - A Copy button is added to clone a server. - Confirming a delete is moved to javascript. No additional form anymore. - A message about an insert, update or delete is shown in a div dialog alert above the table instead of a separate form. - Remove offset parameter, Next/Prev button and associated logic. - All SQL statements are replaced by DBIC. - Function StringSearch is renamed to DBICified ServerSearch. - Remove tabs from script and template. Adjust some indentation. Test plan: - Test adding, editing and deleting Z3950 servers. - Test searching for a server with the top search box (not table). - Add a server with quotes in the name. Search for it. Edit or delete. Followed tet plan. Patch behaves as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 13:46:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 11:46:40 +0000 Subject: [Koha-bugs] [Bug 12265] Improve Z39.50 servers administration (incl DBIx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12265 --- Comment #10 from Kyle M Hall --- Created attachment 29672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29672&action=edit [PASSED QA] Bug 12265: [QA Follow-up] Replace DBIx search by find This patch replaces DBIx search by find at two places in z3950servers.pl. Furthermore, it adds testing on the results of the find method, passing a not-found-message to the template whenever needed. The function ServerSearch is adjusted to use HashRefInflator instead of manually mapping the columns of result objects. An additional defined-test in _form_data_hashref prevents shifting of names and values in the result hash. Test plan: List all servers. Edit, copy and delete a server. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 13:48:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 11:48:05 +0000 Subject: [Koha-bugs] [Bug 12265] Improve Z39.50 servers administration (incl DBIx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12265 --- Comment #11 from Kyle M Hall --- Created attachment 29673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29673&action=edit [PASSED QA] Bug 12265: [QA Follow-up] - Improve usage of find When finding a row by its primary key, it is not necessary to pass a hashref, only the primary key value itself is required. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 13:48:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 11:48:35 +0000 Subject: [Koha-bugs] [Bug 12265] Improve Z39.50 servers administration (incl DBIx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28281|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 13:49:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 11:49:20 +0000 Subject: [Koha-bugs] [Bug 12517] Download and send list popups broken in bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29443|0 |1 is obsolete| | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:01:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:01:46 +0000 Subject: [Koha-bugs] [Bug 12534] PROG/CCSR deprecation: Make getlanguages() theme independent for opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:02:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:02:11 +0000 Subject: [Koha-bugs] [Bug 12517] Download and send list popups broken in bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:02:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:02:12 +0000 Subject: [Koha-bugs] [Bug 12567] New: Catalog Statistitics wizard's publication year doesn't work for MARC21 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12567 Bug ID: 12567 Summary: Catalog Statistitics wizard's publication year doesn't work for MARC21 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The cataloguing statistics wizard offers a filter on publication year. For a MARC21 installation this filter won't ever work, because MARC21 maps the publication year internally to copyrightdate instead of publicationyear like UNIMARC. To test (in a MARC21 database): - Reports > Statistics wizards > Catalog - Check publication year and another column - Verify that publication year is NULL and the report is only one line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:02:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:02:18 +0000 Subject: [Koha-bugs] [Bug 12567] Catalog Statistitics wizard's publication year doesn't work for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:02:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:02:34 +0000 Subject: [Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:02:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:02:52 +0000 Subject: [Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:03:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:03:16 +0000 Subject: [Koha-bugs] [Bug 12522] Fatal database error when viewing Holds for Bib with no Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12522 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:19:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:19:49 +0000 Subject: [Koha-bugs] [Bug 12265] Improve Z39.50 servers administration (incl DBIx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12265 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:21:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:21:27 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #48 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:34:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:34:17 +0000 Subject: [Koha-bugs] [Bug 12568] New: Improve visibility of successful renewal via opac Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Bug ID: 12568 Summary: Improve visibility of successful renewal via opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:34:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:34:23 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:35:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:35:42 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:35:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:35:44 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 --- Comment #1 from Kyle M Hall --- Created attachment 29674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29674&action=edit Bug 12568 - Improve visibility of successful renewal via opac Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully. Test Plan: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 14:55:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 12:55:06 +0000 Subject: [Koha-bugs] [Bug 12569] New: LibraryThingForLibrariesTabbedView doesn't work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12569 Bug ID: 12569 Summary: LibraryThingForLibrariesTabbedView doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org If you have librarything set to put the info in a tab it shows above the holdings table ... http://catalog.cclsd.org/cgi-bin/koha/opac-detail.pl?biblionumber=316379 It should have a tab of it's own and it used to, but I'm not sure how long ago that was. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 15:01:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 13:01:35 +0000 Subject: [Koha-bugs] [Bug 12570] New: Warnings in t/Biblio.t could be tested Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12570 Bug ID: 12570 Summary: Warnings in t/Biblio.t could be tested Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com To test: - Run prove t/Biblio.t - Warnings printed on STDOUT Those could be catched and its output documented in the unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 15:02:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 13:02:10 +0000 Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 15:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 13:04:03 +0000 Subject: [Koha-bugs] [Bug 12570] Warnings in t/Biblio.t could be tested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12570 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 15:04:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 13:04:07 +0000 Subject: [Koha-bugs] [Bug 12570] Warnings in t/Biblio.t could be tested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12570 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 29675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29675&action=edit Bug 12570: test for carped warnings in t/Biblio.t To test: - Run $ prove t/Biblio.t => Warnings printed to STDOUT - Apply patch - Run $ prove t/Biblio.t => No warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 15:20:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 13:20:30 +0000 Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 --- Comment #3 from Owen Leonard --- Created attachment 29676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29676&action=edit Bug 9667 - Inventory scrolling to top with every click An "onclick" attribute on inventory results links causes the page to scroll to the top each time. This patch updates the click handling to use a progressive-enhancement method. Unrelated changes: I added use of the Branches T:T plugin to output library name instead of branchcode, and put a check around call number to prevent output of empty [] in results. To test, use the inventory tool to check a batch of items. On the results page: - Confirm that branch name is shown instead of code. - Confirm that no [] shows for items without call numbers - Confirm that clicking a title opens a pop-up window showing details for that title. - Confirm that clicking a title opens a pop-up window whether you're on the first page of results or any subsequent page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 15:20:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 13:20:28 +0000 Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 15:50:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 13:50:17 +0000 Subject: [Koha-bugs] [Bug 12571] New: Add ability to customize SIP2 screen messages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12571 Bug ID: 12571 Summary: Add ability to customize SIP2 screen messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com We should add the ability to apply a regular expression to screen messages for the SIP2 server. This would allow libraries to not only customize the screen messages the patron sees, but can also allow screen messages to be translated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 15:50:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 13:50:22 +0000 Subject: [Koha-bugs] [Bug 12571] Add ability to customize SIP2 screen messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12571 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 15:55:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 13:55:03 +0000 Subject: [Koha-bugs] [Bug 12571] Add ability to customize SIP2 screen messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12571 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 15:55:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 13:55:05 +0000 Subject: [Koha-bugs] [Bug 12571] Add ability to customize SIP2 screen messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12571 --- Comment #1 from Kyle M Hall --- Created attachment 29677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29677&action=edit Bug 12571 - Add ability to customize SIP2 screen messages We should add the ability to apply a regular expression to screen messages for the SIP2 server. This would allow libraries to not only customize the screen messages the patron sees, but can also allow screen messages to be translated. Test Plan: 1) Apply this patch 2) Inspect etc/SIPconfig.xml, note the new screen_msg_regex tags that can be nested inside a given login tag. 3) Add one or more screen_msg_regex tags to your own SIP config Recommendation: s/Greetings from Koha./Welcome to your library!/g 4) Restart your SIP2 server 5) Test with a SIP2 machine, or use /misc/sip_cli_emulator.pl 6) Note your new AF fields! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 16:06:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 14:06:00 +0000 Subject: [Koha-bugs] [Bug 12571] Add ability to customize SIP2 screen messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12571 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29677|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 29678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29678&action=edit Bug 12571 - Add ability to customize SIP2 screen messages We should add the ability to apply a regular expression to screen messages for the SIP2 server. This would allow libraries to not only customize the screen messages the patron sees, but can also allow screen messages to be translated. Test Plan: 1) Apply this patch 2) Inspect etc/SIPconfig.xml, note the new screen_msg_regex tags that can be nested inside a given login tag. 3) Add one or more screen_msg_regex tags to your own SIP config Recommendation: s/Greetings from Koha./Welcome to your library!/g 4) Restart your SIP2 server 5) Test with a SIP2 machine, or use /misc/sip_cli_emulator.pl 6) Note your new AF fields! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 16:26:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 14:26:25 +0000 Subject: [Koha-bugs] [Bug 12571] Add ability to customize SIP2 screen messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12571 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29678|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 29679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29679&action=edit Bug 12571 - Add ability to customize SIP2 screen messages We should add the ability to apply a regular expression to screen messages for the SIP2 server. This would allow libraries to not only customize the screen messages the patron sees, but can also allow screen messages to be translated. Test Plan: 1) Apply this patch 2) Inspect etc/SIPconfig.xml, note the new screen_msg_regex tags that can be nested inside a given login tag. 3) Add one or more screen_msg_regex tags to your own SIP config Recommendation: s/Greetings from Koha./Welcome to your library!/g 4) Restart your SIP2 server 5) Test with a SIP2 machine, or use /misc/sip_cli_emulator.pl 6) Note your new AF fields! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 16:31:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 14:31:50 +0000 Subject: [Koha-bugs] [Bug 12572] New: Use jQueryUI Accordion to display message transport types Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Bug ID: 12572 Summary: Use jQueryUI Accordion to display message transport types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org When editing a notice the various message transport type settings could be grouped in a jQueryUI accordion to make the editing view a little simpler. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 16:32:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 14:32:56 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 16:33:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 14:33:25 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #30 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 16:45:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 14:45:00 +0000 Subject: [Koha-bugs] [Bug 12572] Use jQueryUI Accordion to display message transport types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 16:45:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 14:45:03 +0000 Subject: [Koha-bugs] [Bug 12572] Use jQueryUI Accordion to display message transport types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 --- Comment #1 from Owen Leonard --- Created attachment 29680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29680&action=edit Bug 12572 - Use jQueryUI Accordion to display message transport types The notice edit view has separate sections for each of the various message transport types. This patch groups them in a jQueryUI accordion to simplify the view. Also changed: Some label/id pairs have been changed to eliminate duplicate ids. To test, apply the patch an edit any notice under Tools -> Notices & Slips. - The message transport type fields for email, feed, phone, etc. should be correctly grouped in a collapsed accordion. The acccordion should look correct and work correctly. - Clicking the label for any form field should correctly highlight the corresponding field. - Submitting updates to the notice should work correctly for all message transport types. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 17:07:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 15:07:40 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #60 from Owen Leonard --- Overall this looks good to me. I only have a few minor comments: - The plugin should be added to /intranet-tmpl/lib/jquery/plugins instead of to the language-specific directory - The page for columns_settings.tt is "Tables" instead of "Columns settings." - Spelling: Use American English spellings "Catalog" and "Cataloging" on columns_settings.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 17:09:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 15:09:15 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-92BTlbCtXF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #61 from Owen Leonard <oleonard at myacpl.org> --- One more thing: A link to columns configuration should be added to admin-menu.inc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 17:25:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 15:25:15 +0000 Subject: [Koha-bugs] [Bug 12569] LibraryThingForLibrariesTabbedView doesn't work In-Reply-To: <bug-12569-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12569-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12569-70-aM4NWWyyM1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12569 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This this bug been tested in the bootstrap theme using the credentials of the library linked to above? In my test LTFL content is showing up in tabs using the bootstrap theme. However, it may be that some but not all content is in tabs, and the visibility of each category of content probably depends on the library's particular configuration on the LTFL site. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 17:26:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 15:26:18 +0000 Subject: [Koha-bugs] [Bug 12573] New: blinddetail-biblio-search uses wrong comparidon operator Message-ID: <bug-12573-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12573 Bug ID: 12573 Summary: blinddetail-biblio-search uses wrong comparidon operator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The following message appears in the apache errorlog: blinddetail-biblio-search.pl: Argument "\x{61}" isn't numeric in numeric eq (==) at /home/koha/kohaclone/authorities/blinddetail-biblio-search.pl line 89. The program is comparing two strings with a numeric compare which can result in subtle bugs and error messages like the above even when working as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 17:27:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 15:27:35 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-UAjGAmp8jk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25921|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 29681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29681&action=edit Small improvements for the availability informations in the search results list on the OPAC. * Add linebreaks to each location via CSS spans. * Add the text "Call number:" before call numbers hidden by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 17:27:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 15:27:47 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-n9J8tZf5gi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #11 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 29682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29682&action=edit Bug 11881 - Follow-up: Add CSS entries to opac.css (prog) This adds the two classes in the spans into opac.css, and it can be overridden in a custom style sheet as needed. Only for the prog theme. To test, apply both prog patches and simply do a search on the OPAC and check the format of availability informations for each search result. By default it should be unchanged. Override the defaults by adding the following into a custom CSS file: .CommasWithLinebreaks { display: block; # block - line breaks, inline - all one line } .LabelCallNumber { display: inline; # inline - display, none - don't display } The call number will be labelled, and items will have line breaks added in the listing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 17:38:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 15:38:45 +0000 Subject: [Koha-bugs] [Bug 12573] blinddetail-biblio-search uses wrong comparidon operator In-Reply-To: <bug-12573-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12573-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12573-70-JYxyfV90LH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12573 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |colin.campbell at ptfs-europe. | |com Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 29683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29683&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 17:39:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 15:39:19 +0000 Subject: [Koha-bugs] [Bug 12573] blinddetail-biblio-search uses wrong comparidon operator In-Reply-To: <bug-12573-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12573-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12573-70-NegAdqxDia@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12573 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 18:39:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 16:39:24 +0000 Subject: [Koha-bugs] [Bug 12574] New: BiblioDefaultView doesn't affect XSLT results view Message-ID: <bug-12574-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Bug ID: 12574 Summary: BiblioDefaultView doesn't affect XSLT results view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The OPAC XSLT results view needs to be updated to use the BiblioDefaultView system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 18:59:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 16:59:12 +0000 Subject: [Koha-bugs] [Bug 12574] BiblioDefaultView doesn't affect XSLT results view In-Reply-To: <bug-12574-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12574-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12574-70-s3YDa2QQHw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 18:59:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 16:59:15 +0000 Subject: [Koha-bugs] [Bug 12574] BiblioDefaultView doesn't affect XSLT results view In-Reply-To: <bug-12574-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12574-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12574-70-RCv1X89UEQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29684&action=edit Bug 12574 - BiblioDefaultView doesn't affect XSLT results view The OPAC's XSLT results view does not respect the choice set in the BiblioDefaultView system preference. This patch adds a check of the preference to the OPAC's results view for MARC21. To test you must have the OPAC configured to use the XSLT view for search results. Perform any search and test the link to a title's detail page. Switching the values of the BiblioDefaultView should be correctly reflected in the search results links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 18:59:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 16:59:30 +0000 Subject: [Koha-bugs] [Bug 10571] IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT In-Reply-To: <bug-10571-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10571-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10571-70-pk7CswEOtp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10571 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 19:13:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 17:13:28 +0000 Subject: [Koha-bugs] [Bug 10571] IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT In-Reply-To: <bug-10571-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10571-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10571-70-kkfFoF5MT9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10571 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 19:13:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 17:13:31 +0000 Subject: [Koha-bugs] [Bug 10571] IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT In-Reply-To: <bug-10571-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10571-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10571-70-6GjwR7hiNX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10571 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29685&action=edit Bug 10571 - IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT The staff client's XSLT results view does not respect the choice set in the IntranetBiblioDefaultView system preference. This patch adds a check of the preference to the staff client's results view for MARC21. To test you must have the staff client configured to use the XSLT view for search results. Perform any search and test the link to a title's detail page. Switching the value of the IntranetBiblioDefaultView preference should be correctly reflected in the search results links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 20:01:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 18:01:51 +0000 Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views In-Reply-To: <bug-12561-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12561-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12561-70-qHVQVRu3Yy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2619, 5229, 10571 | Depends on| |2619, 5229, 10571 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 20:01:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 18:01:51 +0000 Subject: [Koha-bugs] [Bug 2619] Turning on XSLTResultsDisplay preference turns off item detail display In-Reply-To: <bug-2619-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2619-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2619-70-RYHppGcljf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2619 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12561 Depends on|12561 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 20:01:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 18:01:51 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference does not work with XSLT results In-Reply-To: <bug-5229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5229-70-b4lUG36Q8d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12561 Depends on|12561 | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 20:01:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 18:01:51 +0000 Subject: [Koha-bugs] [Bug 10571] IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT In-Reply-To: <bug-10571-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10571-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10571-70-KEulwhOPDy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10571 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12561 Depends on|12561 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 20:02:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 18:02:26 +0000 Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views In-Reply-To: <bug-12561-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12561-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12561-70-a8rdUfxmOW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12574 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 20:02:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 18:02:26 +0000 Subject: [Koha-bugs] [Bug 12574] BiblioDefaultView doesn't affect XSLT results view In-Reply-To: <bug-12574-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12574-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12574-70-qAF4vqdlis@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12561 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 20:07:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 18:07:00 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-rLgs8pd5VB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- This doesn't work for me. After I submit some renewals and the page reloads I don't see any messages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 21:07:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 19:07:45 +0000 Subject: [Koha-bugs] [Bug 12303] use public reports to generate a new items widget In-Reply-To: <bug-12303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12303-70-KNnjFeda3j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12303 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 21:24:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 19:24:46 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12542-70-zzE1GjIBdv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|tomascohen at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 21:34:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 19:34:01 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: <bug-10519-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10519-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10519-70-1mJ87fjG6x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #41 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 29686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29686&action=edit Bug 10519: (followup) unit tests leave problematic cruft On testing I've found that t/db_dependent/Suggestions.t leaves cruft on the DB. Small followup for that. Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 21:36:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 19:36:44 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: <bug-10519-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10519-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10519-70-13iwegcv2G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #42 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Jacek! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 21:38:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 19:38:59 +0000 Subject: [Koha-bugs] [Bug 12575] New: Add option to delete several issues on page Serial collection Message-ID: <bug-12575-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12575 Bug ID: 12575 Summary: Add option to delete several issues on page Serial collection Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Hi, It would be fine when it comes to weeding to have possibility to delete several issues. Adding a buton radio "Delete issues" next to "Multi receving" on serials-collection.pl ? Actually, we have to open Edit serials and select Delete for every issue. Thanks, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 22:11:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 20:11:31 +0000 Subject: [Koha-bugs] [Bug 7715] Add biblio.subtitle and appropriate mappings to MARC frameworks In-Reply-To: <bug-7715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7715-70-RjVfjgZufu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7715 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 14 23:35:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 21:35:23 +0000 Subject: [Koha-bugs] [Bug 12576] New: search links need style id Message-ID: <bug-12576-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Bug ID: 12576 Summary: search links need style id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 29687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29687&action=edit link color hard to read When on the advanced search the links next to the search box need a class or ID so that they can be styled. For example, the link color in the attached image would be better white, but there is no ID to grab on to like this is on the moresearches box at the top. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 01:47:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jul 2014 23:47:10 +0000 Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click In-Reply-To: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9667-70-rDnuJs3ixc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia at hotmail.com --- Comment #4 from Aleisha Amohia <aleishaamohia at hotmail.com> --- Inventory is still scrolling to top after clicking on the link to an item and branch code is still being shown rather than branch name, so failing QA. However the pop-up window does open showing details when clicked on on any page, and [] shows for items without call numbers, so these work as they should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 02:37:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 00:37:48 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: <bug-6322-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6322-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6322-70-LrjSzHla34@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia at hotmail.com --- Comment #6 from Aleisha Amohia <aleishaamohia at hotmail.com> --- I wasn't able to recreate the bug as all pages mentioned redirected to Error 404 pages with the virtualshelves syspref set to 'Don't allow' (as it should) but also when set to 'Allow' (as it shouldn't). However I don't think the patch was breaking anything. Setting to Failed QA because I was unable to recreate the bug and test the patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 02:47:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 00:47:40 +0000 Subject: [Koha-bugs] [Bug 5502] Patron card category search field should be menu In-Reply-To: <bug-5502-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5502-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5502-70-RCU4VQchXo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5502 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 02:47:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 00:47:51 +0000 Subject: [Koha-bugs] [Bug 5502] Patron card category search field should be menu In-Reply-To: <bug-5502-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5502-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5502-70-sC5nc9hxxD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5502 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29646|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 02:47:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 00:47:57 +0000 Subject: [Koha-bugs] [Bug 5502] Patron card category search field should be menu In-Reply-To: <bug-5502-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5502-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5502-70-BNhHImgRLN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5502 --- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29688&action=edit Bug 5502 - Patron card category search field should be menu When searching for patrons to add to a patron card creator batch there is a text input field for submitting a patron category. This should be a dropdown menu. This patch corrects it. To test, go to Tools -> Patron card creator and click "New batch." - Click the "Add item(s)" button. - Confirm that in the Patron search pop-up window there is a dropdown menu populated with existing patron categories. - Confirm that searches limited by patron category return correct results. - Confirm that the correct patron category is automatically preselected after performing a search limited by category. - Confirm that reordering the table of search results works correctly. Signed-off-by: Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 03:07:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 01:07:44 +0000 Subject: [Koha-bugs] [Bug 12559] Wrong message if all cover images deleted In-Reply-To: <bug-12559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12559-70-OATdTDdvX8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12559 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 03:07:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 01:07:59 +0000 Subject: [Koha-bugs] [Bug 12559] Wrong message if all cover images deleted In-Reply-To: <bug-12559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12559-70-B7qzrkB8DR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12559 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29654|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 03:08:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 01:08:08 +0000 Subject: [Koha-bugs] [Bug 12559] Wrong message if all cover images deleted In-Reply-To: <bug-12559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12559-70-XdOsQEYtdV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12559 --- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29689&action=edit Bug 12559: Wrong message if all cover images deleted If a record contains a (one or more) local cover image and it is deleted, a wrong message is presented in the UI. To reproduce: - Have LocalCoverImages set to "Display" and AllowMultipleCovers set to "Allow". - Go to the detail page of a record that has no images attached. - The 'Images' tab conveniently shows the following message: "No images have been uploaded..." - Use the "upload" link to add a local cover to the record - Complete the process, and "view final record". - The 'Images' tab shows the added cover. - Delete the cover image using the link below the cover. => FAIL: 'Click on an image...' message still shows instead of 'No images have been...' To test: - Apply the patch - Repeat the previous steps => SUCCESS : 'No images have been...' Bonus points: previous code didn't show a message at all if the user didn't have permissions to upload local cover images. I've split the message in two: - 'No images have been...' (for everyone) - 'Please upload (link)...' (for those with the right permissions :-D Regards To+ Edit: I used JavaScript to inject the 'No images...' message to aid localization. It can be improved once we fix some stuff in the translation scripts to better support placeholders/variables in the templates. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 03:17:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 01:17:38 +0000 Subject: [Koha-bugs] [Bug 12536] Incorrect number of irregularity issues In-Reply-To: <bug-12536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12536-70-w39OKNzkjk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12536 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 03:17:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 01:17:50 +0000 Subject: [Koha-bugs] [Bug 12536] Incorrect number of irregularity issues In-Reply-To: <bug-12536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12536-70-cjlLjJzKtz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12536 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29542|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 03:17:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 01:17:56 +0000 Subject: [Koha-bugs] [Bug 12536] Incorrect number of irregularity issues In-Reply-To: <bug-12536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12536-70-2NHGR7NUMN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12536 --- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29690&action=edit Bug 12536 - Incorrect number of irregularity issues Modified: serials/subscription-detail.pl - fix split command Testing: I Apply the patch 0) Select a serial subscription; 1) Click Edit -> Edit subscription; 2) Click Next; 3) Click Test prediction pattern; 4) Select 3 Vols; 5) Save subscription; 6) Select Planing tab; 7) Valide "Irregularity: 3 issues". Signed-off-by: Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 03:33:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 01:33:40 +0000 Subject: [Koha-bugs] [Bug 12519] Convert OPAC list download pop-up to modal dialog In-Reply-To: <bug-12519-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12519-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12519-70-oKlh4E5uV3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12519 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 03:33:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 01:33:50 +0000 Subject: [Koha-bugs] [Bug 12519] Convert OPAC list download pop-up to modal dialog In-Reply-To: <bug-12519-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12519-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12519-70-La9B1wDRZ0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12519 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29460|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 03:33:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 01:33:58 +0000 Subject: [Koha-bugs] [Bug 12519] Convert OPAC list download pop-up to modal dialog In-Reply-To: <bug-12519-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12519-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12519-70-saxfmANnH2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12519 --- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29691&action=edit Bug 12519 - Convert OPAC list download pop-up to modal dialog This patch changes the OPAC list download process so that the download link triggers a modal dialog instead of a pop-up window. This streamlines the process a little bit and makes it work better on mobile devices. The download list page has been altered so that it works better as a standalone page, as it might be seen if JavaScript is disabled. Simple form validation has been added to help prevent submission of the form without choosing a format. To test the virtualshelves system preference must be enabled. - View an existing list in the OPAC and click the "download list" link. - A modal dialog should be displayed with the download form. - Submitting the form without selecting a format should trigger either a browser-based form validation error (in HTML5-supporting browsers) or a JavaScript alert (if your browser doesn't support the "required" attribute. - Choosing a download format and submitting the form should close the dialog and trigger the correct download. - Clicking the "Cancel" link should close the dialog. Test with JavaScript disabled: - Clicking the "download list" link should take you to a page which contains the same form which appeared in the modal dialog. - Submitting the form without selecting a format should trigger either a browser-based form validation error (in HTML5-supporting browsers) or a JavaScript alert (if your browser doesn't support the "required" attribute.. - Choosing a download format and submitting the form should result in the corect download. - Clicking the "Cancel" link should return you to the correct list. Signed-off-by: Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 03:51:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 01:51:39 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: <bug-12285-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12285-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12285-70-vNjkE9lnak@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 03:51:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 01:51:50 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: <bug-12285-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12285-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12285-70-wHzXbh7vXc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29144|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 03:51:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 01:51:57 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: <bug-12285-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12285-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12285-70-818FLwO9PU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29692&action=edit Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 04:03:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 02:03:38 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12224-70-wca0e8x2Wf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 04:03:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 02:03:49 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12224-70-Axvkx5STuP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28194|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 04:03:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 02:03:59 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12224-70-TGz8IMeJUe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29693&action=edit Bug 12224: Allow easy printing of patron check-ins for today This adds a printing option to the staff client patron details page to print a list of items the patron returned today at this branch. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have CHECKINSLIP slip, and have print message there. If not, run updatedatabase.pl 3) Check-in items for a patron. 4) Go to that patron's detail page, and from the Print-menu in the toolbar, select "Print checked-in today -slip" 5) You should get a slip of the patron's checked-in items. 6) Optionally, test Check-ins for the same patron, but in different branches - should only print items for the current branch. 7) Optionally, test Check-ins for the same patron, but returned in different day - should only print items for today. Signed-off-by: Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 06:03:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 04:03:22 +0000 Subject: [Koha-bugs] [Bug 9715] Variouse combinations of QueryAutoTruncate, QueryFuzzy and QueryWeightFields preferences Conflict In-Reply-To: <bug-9715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9715-70-F7DLDXlX4x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 10:21:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 08:21:03 +0000 Subject: [Koha-bugs] [Bug 12377] Add date pickers to serials-edit.pl In-Reply-To: <bug-12377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12377-70-EemODCwAVC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 10:21:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 08:21:06 +0000 Subject: [Koha-bugs] [Bug 12377] Add date pickers to serials-edit.pl In-Reply-To: <bug-12377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12377-70-iVRONq2U4E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28752|0 |1 is obsolete| | Attachment #29653|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29694&action=edit Bug 12377 - Add date pickers to serials-edit.pl There are two date fields when receiving serials on serials-edit.pl, these inputs should have a calendar widget like other date fields in Koha. Test Plan: 1) Apply this patch 2) Recieve a serial 3) Note when clicking on the "Published on" or "Expected on" fields you will now have a calendar popup. Note you can still manually edit the date if you wish to. Signed-off-by: Aleisha <aleishaamohia at hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 10:21:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 08:21:10 +0000 Subject: [Koha-bugs] [Bug 12377] Add date pickers to serials-edit.pl In-Reply-To: <bug-12377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12377-70-DEtqOUxlt5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 --- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29695&action=edit Bug 12377 [QA Followup] - Remove readonly from input Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 10:30:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 08:30:57 +0000 Subject: [Koha-bugs] [Bug 10155] Patron search should remember search options selected In-Reply-To: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10155-70-pBCI8FI3dJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10155 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 10:31:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 08:31:00 +0000 Subject: [Koha-bugs] [Bug 10155] Patron search should remember search options selected In-Reply-To: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10155-70-h9wBlS09LZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10155 --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29696&action=edit Bug 10155: Patron search should remember search type options selected The search type reset to the default. Test plan: 1/ go on the patrons home page 2/ Launch a search in the header and select the second value for "search type" ("contains"). 3/ Verify the search type is set to "contains" on the results page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 10:31:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 08:31:09 +0000 Subject: [Koha-bugs] [Bug 10155] Patron search should remember search options selected In-Reply-To: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10155-70-sQckEPHfp4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10155 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 10:35:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 08:35:53 +0000 Subject: [Koha-bugs] [Bug 10702] can't create notices for a specific branch In-Reply-To: <bug-10702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10702-70-oi1SuzEffq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10702 --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Actually, the reloading permits to refresh the fields list. I think we should keep this behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 10:39:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 08:39:01 +0000 Subject: [Koha-bugs] [Bug 10702] can't create notices for a specific branch In-Reply-To: <bug-10702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10702-70-UCztSiX0pC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10702 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I thnk avoiding the page reload will require more work - like using Ajax to reload only the field list. Switching the field order could help a bit to make it less irritating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 12:22:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 10:22:37 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-tZ6Bh2Puze@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #207 from Jonathan Druart <jonathan.druart at biblibre.com> --- Branch updated against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 12:50:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 10:50:02 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: <bug-7380-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7380-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7380-70-MqBjv3FoK1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 12:50:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 10:50:05 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: <bug-7380-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7380-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7380-70-xPkmhvSA9o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29697&action=edit Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 12:50:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 10:50:32 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: <bug-7380-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7380-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7380-70-163dh1eaoh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |11944 Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 12:50:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 10:50:32 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-6ZkNg9hdCQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7380 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 12:53:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 10:53:14 +0000 Subject: [Koha-bugs] [Bug 12577] New: Search is broke after upgrade from 3.14.7 to 3.16.1 Message-ID: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12577 Bug ID: 12577 Summary: Search is broke after upgrade from 3.14.7 to 3.16.1 Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org I have a server running several Koha instances with marcflavour = 'normarc' off a standard package install. Last night I upgraded from 3.14.7 to 3.16.1 (changed the apt config from oldstable to squeeze). Now searching both in the public catalogue and the staff client fails with this message: Error: Can't call method "raw" on an undefined value at /usr/share/koha/lib/C4/Search.pm line 494. In the log opac-error.log (not sure they are relevant): [Tue Jul 15 12:45:47 2014] [error] [client 84.202.33.22] [Tue Jul 15 12:45:47 2014] opac-search.pl: Use of uninitialized value $error in concatenation (.) or string at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 538., referer: http://esme.priv.bibkat.no/cgi-bin/koha/opac-search.pl?q=lessig [Tue Jul 15 12:45:50 2014] [warn] proxy: No protocol handler was valid for the URL /cgi-bin/koha/opac-view.pl. If you are using a DSO version of mod_proxy, make sure the proxy submodules are included in the configuration using LoadModule. I have tried a full reindex of Zebra, as well as restarting Zebra, but to no avail, alas. This might be another manifestation of Bug 9256. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 12:53:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 10:53:24 +0000 Subject: [Koha-bugs] [Bug 12577] Search is broke after upgrade from 3.14.7 to 3.16.1 In-Reply-To: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12577-70-aH8BN9otX3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12577 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9256 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 12:53:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 10:53:24 +0000 Subject: [Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21 In-Reply-To: <bug-9256-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9256-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9256-70-SnV9ciNNde@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12577 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 12:54:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 10:54:05 +0000 Subject: [Koha-bugs] [Bug 8990] Jquery UI images missing in OPAC In-Reply-To: <bug-8990-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8990-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8990-70-bqQTUN0BOP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8990 Fridolin SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Fridolin SOMERS <fridolyn.somers at biblibre.com> --- (In reply to Katrin Fischer from comment #3) > Fridolin, can we close this? Yes, I close it. I think it is obsolete with new theme bootstrap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 12:55:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 10:55:24 +0000 Subject: [Koha-bugs] [Bug 12577] Search is broke after upgrade from 3.14.7 to 3.16.1 In-Reply-To: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12577-70-F4hB3nOHD1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12577 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=9256 |id=9864 --- Comment #1 from Magnus Enger <magnus at enger.priv.no> --- Sorry, I meant another manifestation of Bug 9864. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 12:55:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 10:55:24 +0000 Subject: [Koha-bugs] [Bug 9864] systematic searching error : can't call method "raw" In-Reply-To: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9864-70-5nRCFSFNOq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9864 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12577 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 12:55:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 10:55:24 +0000 Subject: [Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21 In-Reply-To: <bug-9256-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9256-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9256-70-3JNkDEd9Mm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12577 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 12:56:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 10:56:17 +0000 Subject: [Koha-bugs] [Bug 12577] Search is broken after upgrade from 3.14.7 to 3.16.1 In-Reply-To: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12577-70-k9mvmNubD6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12577 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search is broke after |Search is broken after |upgrade from 3.14.7 to |upgrade from 3.14.7 to |3.16.1 |3.16.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 13:42:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 11:42:17 +0000 Subject: [Koha-bugs] [Bug 9864] systematic searching error : can't call method "raw" In-Reply-To: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9864-70-rsguCItXXr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9864 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #11 from Colin Campbell <colin.campbell at ptfs-europe.com> --- If you're getting the problem it might be interesting to see what the values of term and occ are when its generated. The Search.pm code seems to assume everything will work ok which is not a good assumption to make -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 14:01:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 12:01:38 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-PPSV88HQZg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #80 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29698&action=edit Bug 7162: (follow-up) Add unit tests for DelOrder The unit tests did not take into account the new DB field. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 14:02:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 12:02:13 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-adsVjkNhAo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 14:38:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 12:38:43 +0000 Subject: [Koha-bugs] [Bug 12577] Search is broken after upgrade from 3.14.7 to 3.16.1 In-Reply-To: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12577-70-J7EnqDZlaU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12577 --- Comment #2 from Magnus Enger <magnus at enger.priv.no> --- I tried stopping Zebra for one instance and running it on the command line: $ sudo koha-stop-zebra esme $ sudo zebrasrv -v none,fatal,warn -f /etc/koha/sites/esme/koha-conf.xml This revealed one error: I/O warning : failed to load external entity "/etc/koha/zebradb/normarc-retrieval-info-auth-dom.xml" And /etc/koha/zebradb/normarc-retrieval-info-auth-dom.xml does indeed not exist. Doing this does make the error go away, but searching is still not working (after starting Zebra again, and reindexing): $ sudo ln -s /etc/koha/normarc-retrieval-info-auth-dom.xml /etc/koha/zebradb/normarc-retrieval-info-auth-dom.xml And since this error is related to authorities it should perhaps not affect a regular bib search anyway, on an instance with no authorities? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 16:06:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 14:06:26 +0000 Subject: [Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer In-Reply-To: <bug-8292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8292-70-zVon4MKVh2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 --- Comment #12 from Nicole C. Engard <nengard at gmail.com> --- Just want to note that this happened again recently in Koha 3.14. Are we really discussing? or has this report been left to die? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 16:18:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 14:18:11 +0000 Subject: [Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer In-Reply-To: <bug-8292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8292-70-dAvePhxeoh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 --- Comment #13 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Nicole C. Engard from comment #12) > or has this report been left to die? I don't think that's a helpful thing to say. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 16:54:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 14:54:17 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12542-70-Mjs8pBGzE2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 16:54:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 14:54:19 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12542-70-duVEvufisf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29699&action=edit Bug 12542 - Tabs inconsistency in different circ-menu.inc uses Differences between circ-menu.tt and circ-menu.inc always crop up when a new menu item is added--usually only to circ-menu.inc as happened with Bug 9261. Other sidebar differences are present due to differences in the patron data passed by various patron-related script to their templates. This patch also irons out some of these inconsistencies. To test, apply the patch and check out to a patron whose record has more than just basic data: othername, country, patron attributes, street number, road types, etc. View the following pages and compare the patron data and visible tabs to confirm that they match: circ/circulation.pl?borrowernumber=X members/boraccount.pl?borrowernumber=X members/files.pl?borrowernumber=X members/mancredit.pl?borrowernumber=X members/maninvoice.pl?borrowernumber=X members/member-flags.pl?member=X members/member-password.pl?member=X members/moremember.pl?borrowernumber=X members/notices.pl?borrowernumber=X members/pay.pl?borrowernumber=X members/paycollect.pl?borrowernumber=X members/purchase-suggestions.pl?borrowernumber=X members/readingrec.pl?borrowernumber=X members/routing-lists.pl?borrowernumber=X members/statistics.pl?borrowernumber=X tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&src=circ&object=X The only difference I've found which is not fixed by this patch is the display of extended patron attributes in the sidebar of moremember.pl. This is a piecemeal fix for a problem which really deserves a centralized solution, but at least it gets us back to consistency for the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 16:56:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 14:56:46 +0000 Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click In-Reply-To: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9667-70-cjQn6bSxBh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 16:57:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 14:57:32 +0000 Subject: [Koha-bugs] [Bug 11382] patron left menu on purchase suggestions tab not showing all info In-Reply-To: <bug-11382-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11382-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11382-70-TQqqtuoKSZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11382 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- This problem should be fixed by the patch for Bug 12542 *** This bug has been marked as a duplicate of bug 12542 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 16:57:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 14:57:32 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12542-70-kzXyas0i2K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 11382 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:03:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:03:53 +0000 Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click In-Reply-To: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9667-70-gPJ5uSYF9U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Thanks for testing Aleshia, but I'm not sure why it's not working for you. Everything works for me. Perhaps someone else could take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:04:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:04:31 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12542-70-QNW4GuCqfS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:04:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:04:35 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12542-70-Lt4gOZ31yP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 29700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29700&action=edit [SIGNED OFF] Bug 12542: Tabs inconsistency in different circ-menu.inc uses Differences between circ-menu.tt and circ-menu.inc always crop up when a new menu item is added--usually only to circ-menu.inc as happened with Bug 9261. Other sidebar differences are present due to differences in the patron data passed by various patron-related script to their templates. This patch also irons out some of these inconsistencies. To test, apply the patch and check out to a patron whose record has more than just basic data: othername, country, patron attributes, street number, road types, etc. View the following pages and compare the patron data and visible tabs to confirm that they match: circ/circulation.pl?borrowernumber=X members/boraccount.pl?borrowernumber=X members/files.pl?borrowernumber=X members/mancredit.pl?borrowernumber=X members/maninvoice.pl?borrowernumber=X members/member-flags.pl?member=X members/member-password.pl?member=X members/moremember.pl?borrowernumber=X members/notices.pl?borrowernumber=X members/pay.pl?borrowernumber=X members/paycollect.pl?borrowernumber=X members/purchase-suggestions.pl?borrowernumber=X members/readingrec.pl?borrowernumber=X members/routing-lists.pl?borrowernumber=X members/statistics.pl?borrowernumber=X tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&src=circ&object=X The only difference I've found which is not fixed by this patch is the display of extended patron attributes in the sidebar of moremember.pl. This is a piecemeal fix for a problem which really deserves a centralized solution, but at least it gets us back to consistency for the moment. Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> Going through all tabs shows consistency is back. A mid term solution should implement this in a centralized way. Great job Owen! No koha-qa errors btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:04:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:04:55 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12542-70-s25cPO3OUt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29699|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:09:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:09:05 +0000 Subject: [Koha-bugs] [Bug 12220] bootstrap not responsive on all devices In-Reply-To: <bug-12220-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12220-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12220-70-BJIN0oabYz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 --- Comment #8 from Nicole C. Engard <nengard at gmail.com> --- This would be great in 3.14 and 3.16 as well if it won't break things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:17:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:17:28 +0000 Subject: [Koha-bugs] [Bug 10980] purchase suggestion doesn't always show In-Reply-To: <bug-10980-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10980-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10980-70-ioYI1FrOLJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- I can't reproduce this bug in master using the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:18:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:18:17 +0000 Subject: [Koha-bugs] [Bug 12263] SIPServer does not respond correctly to signals In-Reply-To: <bug-12263-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12263-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12263-70-rKPMBS6s44@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12263 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:18:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:18:34 +0000 Subject: [Koha-bugs] [Bug 12377] Add date pickers to serials-edit.pl In-Reply-To: <bug-12377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12377-70-NCFKb03mDo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:19:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:19:04 +0000 Subject: [Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference In-Reply-To: <bug-11575-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11575-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11575-70-EtY7K0bnvT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:38:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:38:16 +0000 Subject: [Koha-bugs] [Bug 11426] Make HighlightOwnItemsOnOPAC work with XSLT In-Reply-To: <bug-11426-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11426-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11426-70-KIeiBbtzvJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11426 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12561 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:38:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:38:16 +0000 Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views In-Reply-To: <bug-12561-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12561-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12561-70-cWnLyQF5Wi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11426 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:43:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:43:24 +0000 Subject: [Koha-bugs] [Bug 12232] notices boxes overlapping In-Reply-To: <bug-12232-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12232-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12232-70-gOiyGaadbE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12232 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This should be fixed by Bug 12572 - Use jQueryUI Accordion to display message transport types. *** This bug has been marked as a duplicate of bug 12572 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:43:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:43:25 +0000 Subject: [Koha-bugs] [Bug 12572] Use jQueryUI Accordion to display message transport types In-Reply-To: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12572-70-pSkWkaVzri@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 12232 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:48:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:48:57 +0000 Subject: [Koha-bugs] [Bug 6499] OCLC # Indexing & Matching In-Reply-To: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6499-70-pIR0ggOAis@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 --- Comment #6 from Barton Chittenden <barton at bywatersolutions.com> --- Updated test procedure. After patch is applied: 1) Make sure that you have a bib that has MARC21 035$a (and possibly also 035$z) populated. 2) Rebuild zebra: misc/migration_tools/rebuild_zebra.pl -x -b -z 3) Add the following to the intranetuserjs syspref: $(document).ready(function(){ // Add Other Control Number to advanced search if (window.location.href.indexOf("catalogue/search.pl") > -1) { $(".advsearch").append('<option value="Other-control-number,w">Other Control Number</option>'); } } Do an advanced search, select "Other Control Number" from the search menu, then add the Other Control Number in 035$a for the bib specified in step 1. The advanced search should return that biblio record. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:54:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:54:11 +0000 Subject: [Koha-bugs] [Bug 6016] Keyword Mapping Should Work with XSLT turned on In-Reply-To: <bug-6016-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6016-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6016-70-hRKWlGLaao@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6016 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Since the XSLT view can be customized to output specific MARC fields it seems unnecessary to go through Keywords to MARC mapping. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:56:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:56:00 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-hiotYsoJ6M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29537|0 |1 is obsolete| | Attachment #29538|0 |1 is obsolete| | Attachment #29539|0 |1 is obsolete| | Attachment #29540|0 |1 is obsolete| | Attachment #29541|0 |1 is obsolete| | --- Comment #62 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29701&action=edit Bug 10212: Columns configuration for tables This development introduces ColVis into Koha and provides a configuration page for columns visibility. ColVis is a plugin for DataTables. It allows to change the visibility of the columns in the table. * This development adds: - the js and css file for ColVis - a new DB table 'columns_settings' - a new template plugin 'ColumnsSettings' - a new package C4::Utils::DataTables::ColumnsSettings - a new admin page admin/columns_settings.pl * How it works: A yaml file is created (admin/columns_settings.yml) in order to take an inventory of all tables where ColVis is implemented. This file is read to create the list of modules, pages and tables in the configuration page. There are 3 possible keys in the yml: - is_hidden: default is 0 The column will be hidden. - cannot_be_toggled: default is 0. ColVis will allow to hide/show the column. - cannot_be_modified: default is 0 Default values (in the yml) won't be modifiable. When a user changes (or saves) the configuration for one module, all columns are added to the DB table. The values in the DB get the upper hand on the yaml values. * Humm, strange? It seems weird to have 2 storages for the same values. But I think it will be easy to add an entry and maintain the yaml rather than adding a new row (and new entry in updatedatabase script) in the DB. * To go further: We can imagine that the configuration is saved for each user (and not globally like it is made with this patch). This patch cannot be tested as it, you need to apply the "POC" patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:56:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:56:05 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-wY5vvZzQv1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #63 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29702&action=edit Bug 10212: Columns configuration for tables - DB changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:56:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:56:12 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-LY7U76qNw8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #64 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29703&action=edit Bug 10212: Columns configuration for tables - Unit tests test plan: Verify the prove t/db_dependent/ColumnsSettings.t returns green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:56:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:56:20 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-yheSoLIuvX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #65 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29704&action=edit Bug 10212: Columns configuration for tables - Add Colvis files This patch only adds Colvis js and css files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 17:56:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 15:56:26 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-ect0fT7uyq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #66 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29705&action=edit Bug 10212: Columns configuration for tables - POC This patch proves that this feature is useful with a concret use case. Test plan: 1/ Execute the updatedatabase in order to create the new table. 2/ Take a look to the yml structure. 3/ Go on the admin currency page (admin/currency.pl). 4/ Check that you cannot hide the 2 first columns on the table. 5/ Try to hide/show columns. 6/ Go on the columns configuration page (admin/columns_settings.pl). 7/ Only the admin tab are filled with data. Check/uncheck checkboxes and save. 8/ Go on the admin currency page and check that the behavior is what you expected. 9/ Give me some feedback :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:01:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:01:31 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-RzJtM9O0Kj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #67 from Jonathan Druart <jonathan.druart at biblibre.com> --- Katrin and Owen, Thanks for your feedbacks! (In reply to Katrin Fischer from comment #59) > 2) Copyright - update? > +# Copyright BibLibre 2013 Done. > 3) Add new library to About page? > jquery.dataTables.colvis.js Oops, forgot. Will be done soon. > 4) Capitalization > Is Hidden by default Done. > 5) Configuration page > a) After saving a new configuration, it would be nice if the section you > worked in remained open, instead of it jumping back to the first - > Acquisitions. Done. > b) I am not sure why currency is displayed twice in different font size? The first one is the "page name", the second one is the "table name". It will often be the same, but in some case, there will be 2 tables per page. > 6) Currencies page > a) The options to toggle/hide could be positioned a bit closer to the table, > maybe we could even use an icon later? Just something we could try to > improve a bit more. Not sure I am a really bad designer and I will certainly break something if I change the datatable css file. I would prefer to let this job to a css expert. (In reply to Owen Leonard from comment #60) > - The plugin should be added to /intranet-tmpl/lib/jquery/plugins instead of > to the language-specific directory Done. > - The page <title> for columns_settings.tt is "Tables" instead of "Columns > settings." Done. > - Spelling: Use American English spellings "Catalog" and "Cataloging" on > columns_settings.tt Done. (In reply to Owen Leonard from comment #61) > One more thing: A link to columns configuration should be added to > admin-menu.inc. Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:04:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:04:26 +0000 Subject: [Koha-bugs] [Bug 12566] Duplicate checks for Self Registered borrowers In-Reply-To: <bug-12566-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12566-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12566-70-jYpquWCBsm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12566 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |kyle.m.hall at gmail.com Component|OPAC |Patrons Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:06:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:06:26 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-17dZj6cV5z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29230|0 |1 is obsolete| | Attachment #29231|0 |1 is obsolete| | Attachment #29232|0 |1 is obsolete| | Attachment #29233|0 |1 is obsolete| | Attachment #29234|0 |1 is obsolete| | Attachment #29235|0 |1 is obsolete| | Attachment #29236|0 |1 is obsolete| | Attachment #29237|0 |1 is obsolete| | Attachment #29238|0 |1 is obsolete| | Attachment #29239|0 |1 is obsolete| | Attachment #29240|0 |1 is obsolete| | Attachment #29241|0 |1 is obsolete| | Attachment #29242|0 |1 is obsolete| | Attachment #29243|0 |1 is obsolete| | Attachment #29244|0 |1 is obsolete| | Attachment #29245|0 |1 is obsolete| | Attachment #29246|0 |1 is obsolete| | Attachment #29247|0 |1 is obsolete| | Attachment #29248|0 |1 is obsolete| | Attachment #29249|0 |1 is obsolete| | Attachment #29250|0 |1 is obsolete| | Attachment #29251|0 |1 is obsolete| | Attachment #29252|0 |1 is obsolete| | Attachment #29253|0 |1 is obsolete| | Attachment #29254|0 |1 is obsolete| | Attachment #29255|0 |1 is obsolete| | Attachment #29256|0 |1 is obsolete| | Attachment #29257|0 |1 is obsolete| | Attachment #29258|0 |1 is obsolete| | Attachment #29259|0 |1 is obsolete| | Attachment #29260|0 |1 is obsolete| | Attachment #29261|0 |1 is obsolete| | Attachment #29262|0 |1 is obsolete| | Attachment #29263|0 |1 is obsolete| | Attachment #29264|0 |1 is obsolete| | Attachment #29265|0 |1 is obsolete| | --- Comment #426 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29706&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:06:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:06:49 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-P9oikUFBid@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #427 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29707&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:06:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:06:59 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-bZEcNXG4LX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #428 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29708&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:07:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:07:07 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-iR49h0ix5E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #429 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29709&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:07:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:07:16 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-eVhG4adrKT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #430 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29710&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:07:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:07:25 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-SejFcEhm8R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #431 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29711&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:07:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:07:39 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-atcbBI4OOK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #432 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29712&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:07:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:07:48 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-Bg8ADPTfn3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #433 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29713&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:07:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:07:55 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-TjfzeTdr6p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #434 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29714&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:08:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:08:03 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-sxlRvhgCzT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #435 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29715&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:08:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:08:12 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-twdEFZumb1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #436 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29716&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:08:20 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-A4oAvGwtor@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #437 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29717&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:08:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:08:33 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-MDtLx6HM69@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #68 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29718&action=edit Bug 10212: Add Colvis to the about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:09:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:09:40 +0000 Subject: [Koha-bugs] [Bug 10158] sorting serial issues In-Reply-To: <bug-10158-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10158-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10158-70-BUx10KUWoi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10158 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- This this bug still valid? Can you please test in the bootstrap theme? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:48:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:48:29 +0000 Subject: [Koha-bugs] [Bug 5590] error message on holds not consistent In-Reply-To: <bug-5590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5590-70-zNsEYwYQax@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5590 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Please check whether this bug is still valid. I think that I'm unable to reproduce the problem, but I'm not exactly sure if I'm trying to duplicate it correctly. > that one item however is checked out to > the patron already, so it shouldn't be allowed to be placed on hold (I don't > think). I don't think one should expect a hold to be blocked when the title is checked out to that patron. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:54:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:54:42 +0000 Subject: [Koha-bugs] [Bug 9071] Updates adding systempreferences should verify the absence of those preferences prior to attempting to add them In-Reply-To: <bug-9071-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9071-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9071-70-mR0PUXsqO9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Is this bug still valid, and if so should it still be assigned? This sounds like something that might be considered as a coding guideline rather than something to be patched, or was it planned to retroactively fix updatedatabase.pl? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:57:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:57:57 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-v8Z2THLOHK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29706|0 |1 is obsolete| | Attachment #29707|0 |1 is obsolete| | Attachment #29708|0 |1 is obsolete| | Attachment #29709|0 |1 is obsolete| | Attachment #29710|0 |1 is obsolete| | Attachment #29711|0 |1 is obsolete| | Attachment #29712|0 |1 is obsolete| | Attachment #29713|0 |1 is obsolete| | Attachment #29714|0 |1 is obsolete| | Attachment #29715|0 |1 is obsolete| | Attachment #29716|0 |1 is obsolete| | Attachment #29717|0 |1 is obsolete| | --- Comment #438 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29719&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:58:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:58:48 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-bQmykQj47j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #439 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29720&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:58:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:58:54 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-VfLkmMVglm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #440 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29721&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:59:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:59:02 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-SRbVB9MFyt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #441 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29722&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:59:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:59:08 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-AnvKZX1wUA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #442 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29723&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:59:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:59:18 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-MCKbocIHW8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #443 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29724&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:59:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:59:26 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-kFvejgRSFQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #444 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29725&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:59:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:59:34 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-VfE2I31u17@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #445 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29726&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:59:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:59:41 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-QwQLxFtlWc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #446 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29727&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:59:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:59:50 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-h1wlvnqd9l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26033|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 18:59:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 16:59:52 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-ecJQWbipVf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #447 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29728&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 19:00:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 17:00:02 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-74XLt5cZIt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #448 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29729&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 19:00:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 17:00:05 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-mZoevZvnLV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26035|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 19:00:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 17:00:13 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-0qfMvpMiSq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #449 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29730&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 19:00:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 17:00:18 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-7AR7fJ7KEM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26036|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 19:25:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 17:25:58 +0000 Subject: [Koha-bugs] [Bug 12578] New: Patron image caching Message-ID: <bug-12578-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12578 Bug ID: 12578 Summary: Patron image caching Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently, patron images are not cached and it takes a considerable amount of time to retrieve it in the staff client. To reproduce: - Go to a patron's detail page (choose a patron with an image attached) - Enable the browser's network profiling interface - Switch between tabs (Checkouts, Details, Fines, etc) => FAIL: patronimage.pl&borrowernumber=X is retrieved each time [1] I've been told it is intended that each time the patron image is updated it has to instantly load the new one. This could be better handled using a timestamp and the Last-Modified header. [1] In my dev box it took it 1'' to load the single image. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 19:35:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 17:35:42 +0000 Subject: [Koha-bugs] [Bug 8248] Invalid characters entered in bib record cause 500 error In-Reply-To: <bug-8248-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8248-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8248-70-WiYARL8Xm7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8248 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Does anyone know if this bug is still valid, and if so how to reproduce it? I'm not exactly sure what kind of "invalid" characters we're supposed to be finding in the attached PDF. Are non-ascii characters considered "invalid?" FWIW I have no problem entering bibliographic data in cataloging whether it be in Firefox or Internet Explorer 11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 19:40:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 17:40:44 +0000 Subject: [Koha-bugs] [Bug 5732] Adding permissions on viewlog In-Reply-To: <bug-5732-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5732-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5732-70-6Yzbr0DVPl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5732 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Bug 5575 was closed as "WONTFIX." Should this bug follow suit? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 19:41:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 17:41:42 +0000 Subject: [Koha-bugs] [Bug 6875] de-nesting C4 packages In-Reply-To: <bug-6875-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6875-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6875-70-yTthzTC39p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 19:41:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 17:41:43 +0000 Subject: [Koha-bugs] [Bug 7545] can't edit items In-Reply-To: <bug-7545-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7545-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7545-70-jiep0fnIpP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7545 Bug 7545 depends on bug 6875, which changed state. Bug 6875 Summary: de-nesting C4 packages http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 20:22:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 18:22:22 +0000 Subject: [Koha-bugs] [Bug 9071] Updates adding systempreferences should verify the absence of those preferences prior to attempting to add them In-Reply-To: <bug-9071-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9071-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9071-70-oUZedZMQJo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 Chris Nighswonger <cnighswonger at foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #3 from Chris Nighswonger <cnighswonger at foundations.edu> --- (In reply to Owen Leonard from comment #2) > Is this bug still valid, and if so should it still be assigned? AFAIK it manifests in upgrades from older versions. Not sure if it shows up when upgrading from more recent versions. > > This sounds like something that might be considered as a coding guideline > rather than something to be patched, or was it planned to retroactively fix > updatedatabase.pl? It was a hope to code up a routine to be called before each INSERT to verify existence. A coding guidline would be helpful as well. Setting it back to NEW since I'm not in the position to fix it atm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 20:24:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 18:24:18 +0000 Subject: [Koha-bugs] [Bug 6344] Hold priority displayed incorrectly when "Toggle Lowest Priority" option is used In-Reply-To: <bug-6344-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6344-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6344-70-QzRbVNn2CR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6344 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This bug is in master as of 3.17.00.009 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 20:31:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 18:31:25 +0000 Subject: [Koha-bugs] [Bug 3258] routing-preview.pl : button text + redirect issue In-Reply-To: <bug-3258-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3258-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3258-70-NQdoiqipQZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3258 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- This appears to be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 21:01:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 19:01:31 +0000 Subject: [Koha-bugs] [Bug 8807] add Carton support to Koha In-Reply-To: <bug-8807-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8807-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8807-70-hF8PZy3UwT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8807 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Should this bug be "needs signoff?" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 21:18:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 19:18:24 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11211-70-JBkTJT6fOW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Eric B?gin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com --- Comment #11 from Eric B?gin <eric.begin at inLibro.com> --- Jessy, Do you know if and when you'll have time to work again on this feature ? Cheers ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 22:40:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 20:40:57 +0000 Subject: [Koha-bugs] [Bug 12577] Search is broken after upgrade from 3.14.7 to 3.16.1 In-Reply-To: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12577-70-DNc15criyq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12577 --- Comment #3 from Magnus Enger <magnus at enger.priv.no> --- Some more research shows that: - Instances with NORMARC display the problem, instances with MARC21 do not - Both instances with DOM and GRS1 indexing display the problem - Running zebra on the command line with "sudo zebrasrv -v fatal,warn,log -f /etc/koha/sites/esme/koha-conf.xml" shows this when doing a search: 22:38:11-15/07 zebrasrv(1) [session] Session - OK 1 unix:/var/run/koha/esme/bibliosocket 14433 22:38:11-15/07 zebrasrv(1) [request] Auth idPass kohauser - 22:38:11-15/07 zebrasrv(1) [request] Init OK - ID:81 Name:ZOOM-C/YAZ Version:4.0.11 e8ca42e680c5e5a644481e5d0b75a0e57c6d3e92 22:38:11-15/07 zebrasrv(1) [log] dict_lookup_grep: (\x01\x0B)(l(e|\xC3\xA9|\xC3\xA8|\xC3\xAA|\xE1\xBA\xBD|\xC4\x95|\xC4\x99|\xC4\x97|\xC4\x9B|\xC8\x85|\xC8\x87)ss(i|\xC3\xAD|\xC3\xAC|\xC3\xAE|\xE1\xBB\x8B|\xC4\xA9|\xC4\xAD|\xC4\xAF|\xC7\x90|\xC8\x89|\xC8\x8B)g.*) 22:38:11-15/07 zebrasrv(1) [request] Search biblios OK 2 1 1+0 RPN @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 lessig 22:38:11-15/07 zebrasrv(1) [request] Present ERROR 239 1 1+1 22:38:11-15/07 zebrasrv(1) [session] Connection closed by client Looks like the search is OK, but not the "Present" part. Not sure what "Present ERROR 239" means... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 22:49:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 20:49:16 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-RhsK4K37tS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #44 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Jonathan, could you please rebase this to current master? I'm willing to push it, but I didn't notice it before, and now it doesn't apply :-( I tried myself but it wasn't a trivial one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 22:56:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 20:56:22 +0000 Subject: [Koha-bugs] [Bug 12577] Search is broken after upgrade from 3.14.7 to 3.16.1 In-Reply-To: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12577-70-Z7geEi1Odt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12577 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #4 from Colin Campbell <colin.campbell at ptfs-europe.com> --- (In reply to Magnus Enger from comment #3) > Some more research shows that: > > - Instances with NORMARC display the problem, instances with MARC21 do not > > - Both instances with DOM and GRS1 indexing display the problem > > - Running zebra on the command line with "sudo zebrasrv -v fatal,warn,log -f > /etc/koha/sites/esme/koha-conf.xml" shows this when doing a search: > > 22:38:11-15/07 zebrasrv(1) [session] Session - OK 1 > unix:/var/run/koha/esme/bibliosocket 14433 > 22:38:11-15/07 zebrasrv(1) [request] Auth idPass kohauser - > 22:38:11-15/07 zebrasrv(1) [request] Init OK - ID:81 Name:ZOOM-C/YAZ > Version:4.0.11 e8ca42e680c5e5a644481e5d0b75a0e57c6d3e92 > 22:38:11-15/07 zebrasrv(1) [log] dict_lookup_grep: > (\x01\x0B)(l(e|\xC3\xA9|\xC3\xA8|\xC3\xAA|\xE1\xBA\xBD|\xC4\x95|\xC4\x99|\xC4 > \x97|\xC4\x9B|\xC8\x85|\xC8\x87)ss(i|\xC3\xAD|\xC3\xAC|\xC3\xAE|\xE1\xBB\x8B| > \xC4\xA9|\xC4\xAD|\xC4\xAF|\xC7\x90|\xC8\x89|\xC8\x8B)g.*) > 22:38:11-15/07 zebrasrv(1) [request] Search biblios OK 2 1 1+0 RPN @attrset > Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 lessig > 22:38:11-15/07 zebrasrv(1) [request] Present ERROR 239 1 1+1 > 22:38:11-15/07 zebrasrv(1) [session] Connection closed by client > > Looks like the search is OK, but not the "Present" part. Not sure what > "Present ERROR 239" means... That looks familiar. One thing to check if yaz and zebra have been upgraded from indexdata apt repo and the Perl ZOOM module has been installed from CPAN it probably needs rebuilding against the updated libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 23:25:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 21:25:49 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11211-70-F5haSxvjLz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 --- Comment #12 from Jesse Weaver <jweaver at bywatersolutions.com> --- Now that I'm done with school and on-site work for a little while, I'll have some time to get this through. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 23:29:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 21:29:39 +0000 Subject: [Koha-bugs] [Bug 12579] New: Problem when merging authorities through the staff interface Message-ID: <bug-12579-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12579 Bug ID: 12579 Summary: Problem when merging authorities through the staff interface Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: francois.charbonnier at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: fridolyn.somers at biblibre.com Depends on: 11652 The authority merge feature doesn't work after updating Koha to 3.14.07. * Go to the staff interface * Search for any authorities * Click on the merge button * Nothing happen The feature works on 3.14.06 and master. I just tested it. I invastigated a little bit more and checked the release notes for 3.14.07. There is this patch (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652) which is a fix for this feature. Since it works on master, maybe something went wrong when the patch got merge to 3.14.07... I cc fridolyn to have his feeling about this. ;^) Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 23:29:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 21:29:39 +0000 Subject: [Koha-bugs] [Bug 11652] merging authority records does not correct biblios In-Reply-To: <bug-11652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11652-70-vYV2SwIuO0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12579 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 23:45:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 21:45:28 +0000 Subject: [Koha-bugs] [Bug 12295] Javascript error when merging authorities In-Reply-To: <bug-12295-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12295-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12295-70-UQpnYQRknV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com --- Comment #8 from Janusz Kaczmarek <januszop at gmail.com> --- *** Bug 12579 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 15 23:45:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 21:45:28 +0000 Subject: [Koha-bugs] [Bug 12579] Problem when merging authorities through the staff interface In-Reply-To: <bug-12579-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12579-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12579-70-LpSlLn9lZV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12579 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |januszop at gmail.com Resolution|--- |DUPLICATE --- Comment #1 from Janusz Kaczmarek <januszop at gmail.com> --- Have a look at 12295. Bug 11652 has nothing in common with this issue. J. *** This bug has been marked as a duplicate of bug 12295 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 00:06:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jul 2014 22:06:46 +0000 Subject: [Koha-bugs] [Bug 12438] Bad encoding in acquisition basket In-Reply-To: <bug-12438-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12438-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12438-70-S1Ebd2CIXr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Fridolin! Note: I pushed it because I think the duplicated biblio.title has to be removed. It hides the real problem, but as bug 11944 actually solves the problem (tried it), I feel good about it making into the stable branches for a short term solution. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 03:03:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 01:03:38 +0000 Subject: [Koha-bugs] [Bug 12306] notes or statistics of transactions in Circulation In-Reply-To: <bug-12306-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12306-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12306-70-fYsqZsGoYt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12306 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea <liz at catalyst.net.nz> --- Can you make it an "organisation -> professional" type relationship? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 06:09:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 04:09:28 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11211-70-Qti5bknNb0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25556|0 |1 is obsolete| | Attachment #26434|0 |1 is obsolete| | --- Comment #13 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 29731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29731&action=edit Bug 11211 - Move calculation code out of C4::Calendar This patch moves the calculation code out of C4::Calendar, replacing any references to it with Koha::Calendar. Additionally, it moves the administration interface to a single script, tools/calendar.pl. NOTE: This is intended as a bridge to bug 8133, so the UI is a bit awkward, and C4::Calendar has an API designed for adding hours to the calendar. All features should still work, and 8133 will make things better. Test plan: 1) Install the new dependency, Template::Plugin::JavaScript. 2) prove t/db_dependent/Calendar.t t/db_dependent/Holidays.t to verify that the new C4::Calendar API works correctly. 3) prove t/Calendar.t 4) Add, remove and modify events of each type using the administrative interface. In this version, changing a repeating event to "Open" deletes it. 5) Check out items to verify that the calculation code is using the events you just created. 6) If possible, verify that the two affected cronjobs still function correctly. (Merges in old and some new QA fixes.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 06:10:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 04:10:11 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11211-70-QCdXIvNSqP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 06:17:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 04:17:30 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: <bug-11369-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11369-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11369-70-10bnWGn1me@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #25 from David Cook <dcook at prosentient.com.au> --- Sweet! I've encountered this problem a few times recently so it's nice to see it get remedied (in some way). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 06:24:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 04:24:54 +0000 Subject: [Koha-bugs] [Bug 12580] New: DataTables overflow their container elements Message-ID: <bug-12580-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12580 Bug ID: 12580 Summary: DataTables overflow their container elements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, if you have a DataTable (or really any table probably but this is when I'm noticing it) that is wider than maybe 80% of the page, it will overflow its containing div element when you shrink your screen size. Most of us developers probably have wide monitors, so we never notice this, but if you shrink the window or use a narrower (ie older/cheaper) monitor, it'll become obvious quite rapidly. Search for all subscriptions and you'll notice the DataTable running off the right side of the page http://KOHA/cgi-bin/koha/serials/serials-search.pl?searched=1&title_filter= Look at the detail page for a bibliographic record that has a really long URL in an item record http://KOHA/cgi-bin/koha/catalogue/detail.pl?biblionumber=1 -- As Liz has mentioned, this is a problem that plagues many (re: most) web apps. It happens on Bugzilla as well if you narrow your screen. Tables and text-areas will overflow to the right. Even if we make it so that the containing <div> expands to the width of the overflowing table...there will come a point when there are siblings of the parent that won't stretch to the edge of the page. That is, the header will still be too short. I don't know if there really is a good solution to this... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 06:58:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 04:58:43 +0000 Subject: [Koha-bugs] [Bug 12580] DataTables overflow their container elements In-Reply-To: <bug-12580-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12580-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12580-70-gQucr9T2As@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12580 --- Comment #1 from David Cook <dcook at prosentient.com.au> --- An idea might be to add more "Show/hide" column options to more DataTables. This would work nicely: http://datatables.net/examples/api/show_hide.html However, that's in DataTables 1.10, whereas we're using DataTables 1.9 which is now considered legacy. Unfortunately, I couldn't find an equivalent in the legacy docs: http://legacy.datatables.net/ref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 07:14:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 05:14:15 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: <bug-5010-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5010-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5010-70-4M9JEMXoa5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #64 from David Cook <dcook at prosentient.com.au> --- It's worth noting that bug 11575 has been pushed to master, so that might affect this bug. The "OpacProtocol" system preference is probably a good idea. Heck, that might remove the need to do more fancy checking for HTTPS when using reverse proxies and/or Plack. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 09:05:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 07:05:39 +0000 Subject: [Koha-bugs] [Bug 12435] Update MARC21 frameworks to Update No. 18 (April 2014) In-Reply-To: <bug-12435-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12435-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12435-70-hXLna1gtt9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12435 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- (In reply to Bernardo Gonzalez Kriegel from comment #3) > (In reply to David Cook from comment #2) > > > > I'm curious...how do you determine which fields and subfields need to be > > updated? > > > Lately I simply look at the changes. > But at first I parsed LOC web site, building something similar to MARC21 > field list (http://www.loc.gov/marc/bibliographic/ecbdlist.html), > then used a script to check values on database. Cool. So it should be easy enough to maintain a XML file going forward since changes are made by hand? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 09:47:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 07:47:55 +0000 Subject: [Koha-bugs] [Bug 12581] New: /svc/bib endpoint has encoding issues when updating a record Message-ID: <bug-12581-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 Bug ID: 12581 Summary: /svc/bib endpoint has encoding issues when updating a record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: boutrosboutrosboutros at gmail.com QA Contact: testopia at bugs.koha-community.org Updating a record by sending a POST request with the MARCXML data Koha's /svc/bib endpoint can result in mangled characters in the saved record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 09:53:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 07:53:01 +0000 Subject: [Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks In-Reply-To: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12477-70-E7M9x0ehVF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 --- Comment #3 from David Cook <dcook at prosentient.com.au> --- Sorry for my delayed response! Competing priorities... (In reply to Bernardo Gonzalez Kriegel from comment #2) > If the field/subfield is missing, adding it as 'hidden' does not affect > present fw. And you can always preserve liblibrarian/libopac as they are... > except when they change, as in last update (Bug 12435, bib 347$f). > > As in other updates I proposed, I never try to update existing fw, for > the problems that you commented. > It's a tough one. I'm thinking that there should be some mechanism for updating an existing framework. It might need to be triggered by library staff, so that they understand what is being updated, but there should be something there. Otherwise, if you're on Koha for a long time, you'll get stale frameworks. Since Koha used outdated frameworks for a long time, it's possible (re: probable) that many Koha users are using very out of date frameworks that need to be updated in a user-friendly way. > And there is a bigger problem: translations > I haven't done anything with translations, but I'm in favour of anything that makes translations easier. > > We could actually just store this MARC-specific data in the YAML file, and > > then build the Default and other Custom frameworks based on a Perl script, > > which would probably be easier to maintain than the SQL that we maintain now. > > If it's agreed to store fw in other format, I propose we use XML (example > attached). And the reason is translations. > I'm happy to go with XML. I suppose my only reservations are about the brittleness of XML and processing time involved in parsing a huge XML file. I suppose the brittleness shouldn't be a factor...we could validate the XML before committing it and parsing errors are very loud so there probably is no danger there. As for processing time...it's not like installing or updating frameworks would be a frequent operation so lengthy processing time might not matter (if it is even a thing). > We need a way to ease the translation of all configuration and sample data > we have as SQL. I'm working intermittently on this, now I'm stuck with > sample notices, but have worked out most sql files as XML and a script to > build sql from them. And unless we propose another way, we need translated > sql files at web install time. It's not practical that each language other > than english have a lang dir commited to git. > Now that I think about it... are "liblibrarian" and "libopac" the only fields that need to be translated? > Talking again about frameworks, Bug 10963 is waiting for a review :) It looks good! I'll have to look at it soon. -- More thoughts that I'm having... marc_tag_structure: 1) MARC: tagfield, liblibrarian, libopac, repeatable 2) Koha: mandatory, authorised_value, frameworkcode marc_subfield_structure: 1) MARC: tagfield, tagsubfield, liblibrarian, libopac, repeatable, maxlength 2) Koha: mandatory, kohafield, tab, authorised_value, authtypecode, value_builder, isurl, hidden, frameworkcode, seealso, link, defaultvalue I'm wondering if it makes sense to maintain 2 separate sources of data. The first XML file would be the data that comes from the actual MARC specification (denoted by the "MARC:" tag above. The second XML file would be what Koha should do with the incoming data. -- Oooh. Brain wave...we could use XSLT! We'd have a XML file containing the MARC specification data. Then we pass that through an XSLT which adds the relevant "Koha" data. Think about it...in most cases those "Koha" fields are "null" or "". The most important fields are probably "tab" and "hidden". If we use defaults for most cases, but define exceptions in the XSLT on a field/subfield and framework basis...that would be much easier to maintain! I don't know if that paragraph makes sense to anyone else...but I like this idea. It's easier to maintain exceptions rather than a whole comprehensive list, which can be dynamically generated. Bernardo, if you could post an up-to-date XML file with that MARC data I mentioned above, I would be willing to take a look at creating a XSLT that adds the relevant Koha data and produces a final "Koha MARC framework" XML document in the end. >From there...we could use scripts to transform XML to SQL or to parse the XML and do the database updates via Perl. Anyway...just some thoughts for now. Have to run! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 10:01:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 08:01:16 +0000 Subject: [Koha-bugs] [Bug 12581] /svc/bib endpoint has encoding issues when updating a record In-Reply-To: <bug-12581-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12581-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12581-70-OoA9EjGcm0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 --- Comment #1 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> --- Created attachment 29732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29732&action=edit Bug 12581 - Fix encoding issues in /svc/bib endpoint Updating a record by sending a POST request with the MARCXML data Koha's /svc/bib endpoint can result in mangled characters in the saved record. By contrast, the /svc/new_bib endpoint, for creating a new record, correctly fixes theese encoding issues. This patch replicates the fix from svc/new_bib to svc/bib. Test plan * Update a record by sending MARCXML to the /svc/bib endpoint. The record should contain non-latin characters, for example ?,?, ?. * Observe that the returned response, and the record in the database has mangled characters. * Apply the patch * Repeat the first step * Observe that the record now is free from encoding errors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 10:01:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 08:01:41 +0000 Subject: [Koha-bugs] [Bug 12581] /svc/bib endpoint has encoding issues when updating a record In-Reply-To: <bug-12581-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12581-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12581-70-BRXLzmUOPG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 11:02:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 09:02:25 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-1zWZ3zktvX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29422|0 |1 is obsolete| | Attachment #29423|0 |1 is obsolete| | Attachment #29424|0 |1 is obsolete| | Attachment #29425|0 |1 is obsolete| | Attachment #29426|0 |1 is obsolete| | Attachment #29427|0 |1 is obsolete| | Attachment #29428|0 |1 is obsolete| | Attachment #29429|0 |1 is obsolete| | Attachment #29430|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29733&action=edit Bug 12164: Move the budget period clone logic into C4::Budgets Note the typo InsertInTable "aqcudgets", note sure about the existing behavior before this patch! This patch adds a link "Duplicate" in the action list for budget periods (budgets). Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 11:02:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 09:02:30 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-15BBtEFcXA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #46 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29734&action=edit Bug 12164: On cloning budget period, mark original budget as inactive This patch adds a checkbox "mark original budget as inactive" (budget period). If it is checked, the original budget will be marked as inactive. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 11:02:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 09:02:35 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-QG6dVqTdD2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #47 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29735&action=edit Bug 12164: On cloning budget periods, add a "reset all funds" option This patch adds a checkbox "reset all funds" (budgets). If it is checked, the new created budgets (funds) will be reset. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 11:02:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 09:02:39 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-C7jmXOyHI9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #48 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29736&action=edit Bug 12164: Close a budget period (budget) This is the main patch. On closing a budget period, all unreceived orders are moved from the old/previous fiscal year into the new fiscal year. You can rollover funds unused in the previous fiscal year to the new fiscal year. This patch set is based on bug 12168 (bugfix) and can be tested on top of bug 11578 (easier to see the fund structure). The patch set is cut in 6 main patches: - Move the budget period clone logic into C4::Budgets The code is moved from the pl to Budgets.pm and unit tests are provided. The original code should certainly be buggy since a typo existed. - On cloning budget period, mark original budget as inactive Cloning a budget period is already possible in Koha, this patch adds a checkbox to mark as inactive the original budget. That avoids to edit the budget and click the "inactive" checkbox. Both do the same action. - On cloning budget periods, add a "reset all funds" option Same as before, a new checkbox is added on cloning a budget period. If you check it, all fund amounts will be set to 0. Otherwise, no change compared to the existing behavior. - Close a budget period (budget) The goal of this patch set is to move unreceived orders from a budget to another. This patch adds a C4::Budgets::MoveOrders routine which does this job. This action is only possible if the fund structure is the same for both budgets, the budget_code field should be the same. - On closing budget period, move unspent amount Unspent amount will be move from the previous budget structure to the new one. - Add UI report This patch only adds a report when closing a budget is done. Test plan: Wording: below, budget is a "budget period" and fund is a "budget". Prerequisite: Having 1 active budget with some funds (with different levels and different amounts). Order and receive some orders (not all). 1/ Go on the budgets administration page (admin/aqbudgetperiods.pl) and duplicate the structure of this budget ("Duplicate" link in the "Actions" column). 2/ Enter start and end date for this budget and mark the original budget as inactive. 3/ Note that a new budget is created, with the same fund structures (and same value) and that the old one is marked as inactive (see admin/aqbudgets.pl page with patches from bug 11578). 4/ Try to close the new budget: it is not possible, there is no unreceived orders for this budget. 5/ You can close the inactive budget ("Close" link in the "Actions" column). 6/ Verify the number of "Unreceived orders" is correct and select the new budget in the budget list. Click on the "Move remaining unspent funds" if you want to move unspent amounts. 7/ A report view is displayed and show you the ordernumber which have been impacted (grouped by fund). 8/ Try different configuration, depending on the selected checkboxes. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 11:02:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 09:02:44 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-InGEfG4g7D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #49 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29737&action=edit Bug 12164: On closing budget period, move unspent amount On closing a budget (budget period), the user will be presented with an option to move remaining unspent funds from the previous budget to the newly created one - adding to the amounts already entered in those funds. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 11:02:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 09:02:49 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-d7V1qT5Jvw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #50 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29738&action=edit Bug 12164: Add UI report Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 11:02:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 09:02:59 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-nyMFG1tRps@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #51 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29739&action=edit Bug 12164: follow-up: various fixes This follow-up fixes issues raised on bug 12164 comment 17. 1/ The unreceived orders columns should only display "pending" orders 2/ Fix some typo from_budget_period_id vs budget_period_id vs to_budget_period_id Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 11:03:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 09:03:04 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-PfhL9RbdCI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #52 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29740&action=edit Bug 12164: Fix some typos Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 11:03:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 09:03:10 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-WLQkVwrNL4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #53 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29741&action=edit Bug 12164: Fix decimal number display If the funds are not moved, the amount is display like 123.000000. This patch hardcodes the number of decimal numbers to display (2). Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes QA script and tests, especially all acquisition tests. New routines in Budgets.pm: - CloneBudgetPeriod - CloneBudgetHierarchy - MoveOrders OK t/db_dependent/Budgets.t Some of the tests done: 1) Duplicate an existing budget - OK Existing budget is active, duplicate it and mark it inactive - OK Existing budget is inactive, duplicate and mark it inactive 2) Close budget - OK Budget was created without funds - no changes are made - OK Budget was created with funds, all orders moved correctly - moving the available money to the new budget is optional - OK Budget was created with funds, but one fund deleted, all orders moved correctly, one missing fund reported, orders unchanged 3) Partial receiced undone - OK Partial receive from last budget is undone, order lines are correctly recombined and fund is set to the current budget -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 11:04:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 09:04:58 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-vLJpM5Fray@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #54 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Tom?s Cohen Arazi from comment #44) > Jonathan, could you please rebase this to current master? I'm willing to > push it, but I didn't notice it before, and now it doesn't apply :-( > > I tried myself but it wasn't a trivial one. The last patch set fixes the conflict with bug 12482. It was not so easy and I hope I did not forget something. I retested a big part of the feature and all looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 12:21:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 10:21:44 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-YAmIgq2QrJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 12:21:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 10:21:46 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-8rkhPP7MIw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29173|0 |1 is obsolete| | --- Comment #4 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 29742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29742&action=edit Bug 12457: Adding unit tests for Members.pm Adding unit tests for the routines AddMessage, GetMessages, GetMessagesCount and DeleteMessage in t/db_dependent/Members.t Adding unit tests for the routines GetPendingIssues and GetAllIssues in separate files : t/db_dependent/Members/GetPendingIssues.t and t/db_dependent/Members/GetAllIssues.t The routine GetAllIssues has been modified because it does not test if the arguments was defined : - the borrowernumber argument is required - if the order argument is not given, it takes a value by default : 'date_due desc' - the limit argument is optional Test plan: 1/ Apply the patch 2/ Execute : prove t/db_dependent/Members.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/GetPendingIssues.t 3/ The result has to be a success without error or warning : t/db_dependent/Members.t ................... ok t/db_dependent/Members/GetAllIssues.t ...... ok t/db_dependent/Members/GetPendingIssues.t .. ok All tests successful. Files=3, Tests=83, 5 wallclock secs ( 0.06 usr 0.01 sys + 4.68 cusr 0.26 csys = 5.01 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 13:08:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 11:08:39 +0000 Subject: [Koha-bugs] [Bug 12582] New: Control of branch displayed in search results linked to HomeOrHoldingBranch Message-ID: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12582 Bug ID: 12582 Summary: Control of branch displayed in search results linked to HomeOrHoldingBranch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries would like the ability choose to display the home branch on search results while having circulation rules based on the holding branch. This is currently impossible because both the display of the branch in search results, and the selection of the home or holding branch for circulation rules are controlled by the same system preference: HomeOrHoldingBranch. This preference is described as being used only for circulation rules, and makes no mention of its use for display control. The display control should be split off into a separate preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 13:08:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 11:08:43 +0000 Subject: [Koha-bugs] [Bug 12582] Control of branch displayed in search results linked to HomeOrHoldingBranch In-Reply-To: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12582-70-JL7VN96WeA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12582 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 13:47:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 11:47:21 +0000 Subject: [Koha-bugs] [Bug 12582] Control of branch displayed in search results linked to HomeOrHoldingBranch In-Reply-To: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12582-70-rqvePTiYgv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12582 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 13:47:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 11:47:23 +0000 Subject: [Koha-bugs] [Bug 12582] Control of branch displayed in search results linked to HomeOrHoldingBranch In-Reply-To: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12582-70-Sx06GYsA9r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12582 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29743&action=edit Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch Some libraries would like the ability choose to display the home branch on search results while having circulation rules based on the holding branch. This is currently impossible because both the display of the branch in search results, and the selection of the home or holding branch for circulation rules are controlled by the same system preference: HomeOrHoldingBranch. This preference is described as being used only for circulation rules, and makes no mention of its use for display control. The display control should be split off into a separate preference. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note the value of the new system preference StaffSearchResultsDisplayBranch matches the current value of HomeOrHoldingBranch 4) Set the preference to home branch 5) Perform a staff catalog search with results having items with differing home and holding branches. 6) Note the home branch displays 7) Set the preference to holding branch 8) Repeat step 5 9) Note the holding branch displays -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 13:50:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 11:50:04 +0000 Subject: [Koha-bugs] [Bug 12583] New: DelItem takes $dbh in parameter Message-ID: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 Bug ID: 12583 Summary: DelItem takes $dbh in parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Since C4::Context->dbh shares the DB handler, it's useless to pass it to routines. On the way, It would be great to pass the itemnumber for removing an item (the biblionumber should be optional). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 13:50:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 11:50:13 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-2JUovis1aL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 13:52:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 11:52:55 +0000 Subject: [Koha-bugs] [Bug 12582] Control of branch displayed in search results linked to HomeOrHoldingBranch In-Reply-To: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12582-70-0JQ6fn7kaR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12582 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29743|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29744&action=edit Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch Some libraries would like the ability choose to display the home branch on search results while having circulation rules based on the holding branch. This is currently impossible because both the display of the branch in search results, and the selection of the home or holding branch for circulation rules are controlled by the same system preference: HomeOrHoldingBranch. This preference is described as being used only for circulation rules, and makes no mention of its use for display control. The display control should be split off into a separate preference. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note the value of the new system preference StaffSearchResultsDisplayBranch matches the current value of HomeOrHoldingBranch 4) Set the preference to home branch 5) Perform a staff catalog search with results having items with differing home and holding branches. 6) Note the home branch displays 7) Set the preference to holding branch 8) Repeat step 5 9) Note the holding branch displays -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:05:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:05:52 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-XGb1HoNhcX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #54 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29745&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:07:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:07:12 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-dXlWsVXlGh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9303 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:07:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:07:12 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-7XrbCrdLf1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9011 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:09:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:09:02 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-3WNMlvEav9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:09:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:09:04 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-pRcMT8HIAl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29746&action=edit Bug 12583: DelItem prototype - Remove $dbh Since C4::Context->dbh shares the DB handler, it's useless to pass it to routines. Test plan: Try to remove an item from the Koha interface. Verify that unit tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:09:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:09:08 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-7Fzzn3ICk8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29747&action=edit Bug 12583: DelItem prototype - prefer hashref To delete an item, only the itemnumber should be mandatory. The DelItem routine can retrieve the biblionumber from the itemnumber. Test plan: Verify that t/db_dependent/Items/DelItem.t passes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:09:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:09:11 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-e6PQnHY94k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29748&action=edit Bug 12583: DelItem prototype - Add unit tests DelItem should return 1 if the item has been deleted, otherwise 0. Test plan: Verify that t/db_dependent/Items/DelItem.t returns green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:11:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:11:12 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-qjt6W1eg1o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29745|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29749&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:12:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:12:53 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-lBleHCeDXV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29749|0 |1 is obsolete| | --- Comment #56 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29750&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:22:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:22:18 +0000 Subject: [Koha-bugs] [Bug 12577] Search is broken after upgrade from 3.14.7 to 3.16.1 In-Reply-To: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12577-70-FbFZe6XypD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12577 --- Comment #5 from Magnus Enger <magnus at enger.priv.no> --- (In reply to Colin Campbell from comment #4) > That looks familiar. One thing to check if yaz and zebra have been upgraded > from indexdata apt repo and the Perl ZOOM module has been installed from > CPAN it probably needs rebuilding against the updated libraries. I'm pretty sure there are no CPAN'ed modules involved. $ sudo apt-cache policy libnet-z3950-zoom-perl libnet-z3950-zoom-perl: Installed: 1.26-1 Candidate: 1.26-1 Version table: *** 1.26-1 0 500 http://ftp.us.debian.org/debian/ squeeze/main amd64 Packages 100 /var/lib/dpkg/status $ yaz-client -V YAZ version: 4.0.11 e8ca42e680c5e5a644481e5d0b75a0e57c6d3e92 "About Koha" says: Zebra version: Zebra 2.0.44 (C) 1994-2010, Index Data ApS Zebra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. SHA1 ID: 419ad759807269fdfa379799a051ed3a551c6541 Using ICU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:31:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:31:07 +0000 Subject: [Koha-bugs] [Bug 8521] Error in warning message when deleting list In-Reply-To: <bug-8521-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8521-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8521-70-1ZTwdG9lQW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:31:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:31:10 +0000 Subject: [Koha-bugs] [Bug 8521] Error in warning message when deleting list In-Reply-To: <bug-8521-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8521-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8521-70-nElJuZccco@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29751&action=edit Bug 8521 - Error in warning message when deleting list When deleting a list the operation is blocked if there are items still on the list, and the interface shows a warning which includes a count of the items on the list. This count is broken for lists containing more items than the number specified in the numSearchResults system preference. This patch corrects the item count to use an actual count of the total number of results, not the total number of results in the first page of results. The template change to the staff client copies some language logic from the OPAC template for dealing with a single number of list entries. Test in both the OPAC and the staff client. Check the number specified in the numSearchResults system preference and locate or create a list containing more than that number of items. Try to delete the list. You should receive a warning message stating the correct total number of items on the list. Test also with a list which contains fewer than numSearchResults entries, and a list which contains zero entries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:47:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:47:36 +0000 Subject: [Koha-bugs] [Bug 8149] Deleting Records/Biblios Omnibus In-Reply-To: <bug-8149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8149-70-vzTsMXDeak@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8149 Bug 8149 depends on bug 7252, which changed state. Bug 7252 Summary: Lists inaccessible when one or more MARC records listed have been deleted http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7252 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:47:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:47:36 +0000 Subject: [Koha-bugs] [Bug 7252] Lists inaccessible when one or more MARC records listed have been deleted In-Reply-To: <bug-7252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7252-70-p0T8Szk5t9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7252 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- This bug no longer appears in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:58:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:58:34 +0000 Subject: [Koha-bugs] [Bug 12555] Call DelItem on cancelling a receipt In-Reply-To: <bug-12555-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12555-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12555-70-4PyKa7mjM0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12583 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:58:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:58:34 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-k915jG4ebF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12555 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 14:58:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 12:58:42 +0000 Subject: [Koha-bugs] [Bug 12555] Call DelItem on cancelling a receipt In-Reply-To: <bug-12555-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12555-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12555-70-Z56Fd5QHBk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 15:13:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 13:13:17 +0000 Subject: [Koha-bugs] [Bug 12577] Search is broken after upgrade from 3.14.7 to 3.16.1 In-Reply-To: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12577-70-6ofD4TdF4O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12577 --- Comment #6 from Magnus Enger <magnus at enger.priv.no> --- Interesting: I created a new NORMARC instance on the same server, and searching works as expected there. So there must be some difference between the configs of the old and the new instance... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 15:13:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 13:13:42 +0000 Subject: [Koha-bugs] [Bug 12555] Call DelItem on cancelling a receipt In-Reply-To: <bug-12555-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12555-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12555-70-OIuqWKnpWf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 15:13:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 13:13:45 +0000 Subject: [Koha-bugs] [Bug 12555] Call DelItem on cancelling a receipt In-Reply-To: <bug-12555-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12555-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12555-70-9YJok6shgn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29752&action=edit Bug 12555: Call DelItem on cancelling a receipt On cancelling a receipt, the items should be deleted using the C4::Items::DelItem subroutine in order to update zebra and sent the items in the deleteditems table. The entries in aqorders_items will automatically deleted by the DBMS (on delete cascade). Test plan: 0/ Set the AcqCreateItem pref to "on receiving" 1/ Create an order with some items 2/ Receive the items 3/ Note the itemnumber in the items table 4/ Cancel the receipt 5/ Verify the itemnumbers are present in the deleteditems table and the items have been deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 15:14:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 13:14:20 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: <bug-11744-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11744-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11744-70-WoSltNXDxy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #31 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Jonathan Druart from comment #28) > (In reply to Katrin Fischer from comment #27) > > I lost track of this a bit, should we have a new bug report for comment > > 18-20? > > Bug 12555 already opened and linked ;) Patch submitted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 15:18:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 13:18:06 +0000 Subject: [Koha-bugs] [Bug 7462] duplicate patron shows flags In-Reply-To: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7462-70-goK4ybTiov@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 15:18:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 13:18:08 +0000 Subject: [Koha-bugs] [Bug 7462] duplicate patron shows flags In-Reply-To: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7462-70-3Z4JFLjNr7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29753&action=edit Bug 7462 - duplicate patron shows flags When duplicating a patron the form fields for setting patron account flags and restrictions should be hidden as it is when adding a patron. This patch adds the correct logic to the template. To test, duplicate an existing patron: - Confirm that the "Patron account flags" and "Patron restrictions" sections are not visible. - Confirm that saving a duplicated patron works correctly. - Confirm that the edit and new patron entry forms are unaffected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 15:18:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 13:18:23 +0000 Subject: [Koha-bugs] [Bug 7462] duplicate patron shows flags In-Reply-To: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7462-70-wBRP3l2g6H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 15:19:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 13:19:55 +0000 Subject: [Koha-bugs] [Bug 12584] New: koha-conf.xml for package installations get out of sync Message-ID: <bug-12584-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 Bug ID: 12584 Summary: koha-conf.xml for package installations get out of sync Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz koha-conf.xml files for instances created with the Debian packages are never updated/upgraded when the packages are updated. This results in lots of missing stuff in the config files over time. This seems to be the root of the problems I have reported in bug 12577. As an example an old instance has 21 lines i the <config> section, while a fresh instance has 30. Perhaps there could be a script that can - read an existing koha-conf.xml (and back it up) - generate a new file with the old values + placeholders or default values (or interactive questions?) for any missing values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 15:27:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 13:27:29 +0000 Subject: [Koha-bugs] [Bug 12577] Search is broken after upgrade from 3.14.7 to 3.16.1 In-Reply-To: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12577-70-SBFJ0vCcNF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12577 --- Comment #7 from Colin Campbell <colin.campbell at ptfs-europe.com> --- (In reply to Magnus Enger from comment #6) > Interesting: I created a new NORMARC instance on the same server, and > searching works as expected there. So there must be some difference between > the configs of the old and the new instance... The PRESENT error is, I think, generated if an error occurs formatting the result set. I think if you look at the zebra index with yaz-client you search ok but when you ask to view the returned records thats where the error occurs. So in Search.pm it sees there are x records but when it asks for them zebra aborts so you get undefined values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 15:38:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 13:38:30 +0000 Subject: [Koha-bugs] [Bug 7550] Self checkout should limit display of patron image to logged-in patron In-Reply-To: <bug-7550-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7550-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7550-70-Q3ujFsds2k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha.sekjal at gmail.com |koha-bugs at lists.koha-commun | |ity.org --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This bug is still valid in master, the only difference being that the image is now called by borrowernumber instead of card number: <img alt="" src="/cgi-bin/koha/sco/sco-patron-image.pl?borrowernumber=XXXX"> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 15:38:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 13:38:40 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-8Tc3spZOgM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #69 from Jonathan Druart <jonathan.druart at biblibre.com> --- I removed the "in discussion" status. Sent to the RM queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 16:07:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 14:07:41 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-3D3KOyXqI8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Z3950 Enhancements: SRU |Z3950 Search Enhancements: |targets, MARC conversion, |SRU targets and additional |additional XSLT processing |XSLT processing |(umbrella report) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 16:08:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 14:08:14 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-pDxr8IeLrQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26169|0 |1 is obsolete| | Attachment #26170|0 |1 is obsolete| | Attachment #26171|0 |1 is obsolete| | Attachment #26172|0 |1 is obsolete| | --- Comment #37 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 29754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29754&action=edit Bug 6536: Dbrev for Z3950 search improvements Adjusts table z3950servers: Drops unused columns icon, description and position. Moves id column to first position. Renames name to servername, and type to servertype. (This is not only more clear but may eliminate some problems too with DBIx.) Changes recordtype from varchar(45) to enumeration with two members. [The upgrade replaces unknown record types with biblio, although it is very unlikely to find such records.] Adds SRU as servertype enumeration member. Removes opensearch, since it is not used/supported. [The upgrade replaces unknown server types with zed (z3950) (in exceptional cases).] Adds new columns: sru_options, sru_fields, add_xslt. Test plan: Run database update via webinstaller. Check your z3950servers table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 16:18:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 14:18:09 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-mYmqmZxIaN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #38 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 29755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29755&action=edit [DO_NOT_PUSH] Bug 6536: Update DBIx schema of z3950servers for testing This patch adjusts the DBIx schema file for z3950servers table. This can be used for testing this set of patches. When the report is pushed, the RM should update the DBIx schema. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 16:23:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 14:23:05 +0000 Subject: [Koha-bugs] [Bug 12585] New: Tag searching broken if QueryParser is turned on Message-ID: <bug-12585-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12585 Bug ID: 12585 Summary: Tag searching broken if QueryParser is turned on Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/opac-search.pl?tag=foo&q=foo OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org If you try to search by tag in the OPAC with the UseQueryParser system preference turned off you get an error: Can't locate YAML/XS.pm in @INC at (eval 1903) line 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 16:26:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 14:26:12 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-Cczp9hgBp6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #39 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 29756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29756&action=edit Bug 6536: Add a form for SRU Field mapping This form allows you to enter the match between the standard names of the Z3950 search fields and the field names for a specific SRU server. This patch only adds the form; it will be used in a subsequent patch. Test plan: Not needed, but you can call the form by constructing a URL like: cgi-bin/koha/admin/sru_modmapping.pl?mapping=title=1,author=2 You should see the form with title and author filled. Note that you cannot save the information yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 16:30:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 14:30:54 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-CibDgHe4uc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #40 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Please wait: Still four patches coming within some days.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 16:36:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 14:36:54 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11373-70-Bjv3JfI2OP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #6 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> --- Created attachment 29757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29757&action=edit Bug 11373 - Unit tests for Accounts.pm I added unit tests for the modified subs in C4/Accounts.pm. makepartialpayment() WriteOffFee() modified: t/db_dependent/Accounts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 16:38:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 14:38:41 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11373-70-BnpLXf8H7l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |maxime.beaulieu at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 16:51:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 14:51:08 +0000 Subject: [Koha-bugs] [Bug 12586] New: Record matching rules - Required match checks doesn't work with MARCXML Message-ID: <bug-12586-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 Bug ID: 12586 Summary: Record matching rules - Required match checks doesn't work with MARCXML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When trying to Match MARCXML-records from Zebra using Required match checks, C4::Matcher::_passes_required_checks() tries to make a MARC::Record out of MARCXML while thinking it is USMARC. This leads to matching records getting not-matched, and subsequently importing the same records again and again. Very hard to debug or create a test case. I accidentally noticed this while building an automatic acquisitions record overlay mechanism. There are no big errors, simply no match is found, even though a match exists. --------- TEST PLAN --------- 1. Create a Matcher with "Required match checks" in addition to normal checks. 2. Find matches using the C4::Matcher->get_matches() and notice that you don't find matches. 3. Somebody who is actually using this Matcher could help me out here with defining a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:02:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:02:26 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: <bug-12586-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12586-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12586-70-hgWJyRrMLM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 29758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29758&action=edit le patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:02:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:02:38 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: <bug-12586-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12586-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12586-70-U0WDa0GJ2a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:04:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:04:07 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: <bug-12586-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12586-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12586-70-0uwhIsgOyH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Also refactored the Matcher a bit to prevent excessive MARC::Record creation for each "Required match check" for each search results. This probably would cripple any reasonable batch Matching operations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:04:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:04:45 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: <bug-12586-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12586-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12586-70-ezDBFIf5lx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Setting this to needs signoff, because there is no "needs help" -status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:06:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:06:25 +0000 Subject: [Koha-bugs] [Bug 12587] New: Improve output of filter information on patrons with the most checkouts report Message-ID: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12587 Bug ID: 12587 Summary: Improve output of filter information on patrons with the most checkouts report Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/reports/bor_issues_top.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Reports Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org I was looking to see if I could address any of the issues reported in Bug 8126 and saw that handling of filter information could be done better: - Template logic can be introduced to better handle untranslatable strings coming out of the script. - Template plugins can be used to output library and item type names instead of codes. - Template plugin can be used to output dates in the preferred date format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:16:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:16:48 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: <bug-5010-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5010-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5010-70-pQoFpYTjh8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #65 from M. Tompsett <mtompset at hotmail.com> --- Also should be noted a minor rebase is required before fixing. I think it would be optimal if all the OPACBaseURLs passed to the templates were full paths including the https or http accordingly. I am not so sure I think the OpacProtocol system preference idea is the best way to do it, but rather it should be in the OPACBaseURL system preference itself. We shouldn't be hardcoding http or https anywhere. We shouldn't need to check for http or https anywhere. I feel the best solution is the most painful to do: fix every instance of OPACBaseURL use or hardcoded protocols to just use the OPACBaseURL. However, once done, it will just work. That is the way Koha should work. Sadly, there are partial links in some of the included header templates which would cascade to a larger than simpler solution, as far as I recall from last time I checked. Honestly, someone needs to bite the bullet. I don't have time. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:33:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:33:20 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10877-70-Ad5EP7YGJO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- Comment on attachment 29406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29406 Bug 10877 - Add "Order Record" processing Review of attachment 29406: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10877&attachment=29406) ----------------------------------------------------------------- ::: C4/ImportBatch.pm @@ +967,3 @@ > =cut > > sub GetImportBatchRangeDesc { Agreed. There are no unit tests for this. I think it would be extremely difficult to unit test. However, the additions I've made to it are close to trivial. ::: acqui/addorderiso2709.pl @@ +270,5 @@ > my @serials = $input->param('serial'); > my @ind_tag = $input->param('ind_tag'); > my @indicator = $input->param('indicator'); > + > + if ($is_order) { This is so we can pre-set the items to a notforloan value of 'ordered', and to preset the home and holding fields to the current branch, as well as pre-set the itemtype. @@ +295,5 @@ > + GetMarcFromKohaField('items.itype'); > + push( @tags, $itype_field ); > + push( @subfields, $itype_subfield ); > + push( @field_values, $infos->{itype} ); > + warn "ITYPE: " . $infos->{itype}; Will fix! @@ +359,1 @@ > While I agree, I wanted to make as few changes as possible to that subroutine. @@ +450,5 @@ > item_action => $item_action > ); > batch_info($template, $batch); > + > + return \@list; I just thought it sensible to have the sub return something. Considering no caller of the sub takes in the return value, I expect it will be compiled away. I can remove this if you think it prudent. ::: installer/data/mysql/updatedatabase.pl @@ +8565,5 @@ > + $dbh->do("ALTER TABLE import_batches ADD is_order BOOLEAN NOT NULL DEFAULT '0' AFTER comments"); > + print "Upgrade to $DBversion done (Bug 10877 - Add 'Order Record' processing)\n"; > + SetVersion ($DBversion); > + > +} Will fix! ::: koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-add-to-basket.inc @@ +18,4 @@ > <li><a href="/cgi-bin/koha/acqui/z3950_search.pl?booksellerid=[% booksellerid %]&basketno=[% basketno %]">From an external source</a></li> > <li><a href="/cgi-bin/koha/acqui/addorderiso2709.pl?booksellerid=[% booksellerid %]&basketno=[% basketno %]"> From a staged file</a></li> > [% IF ( CAN_user_circulate ) %]<li><a href="/cgi-bin/koha/circ/reserveratios.pl?booksellerid=[% booksellerid %]&basketno=[% basketno %]">From titles with highest hold ratios</a></li>[% END %] > + <li><a href="/cgi-bin/koha/acqui/addorderiso2709.pl?booksellerid=[% booksellerid %]&basketno=[% basketno %]&is_order=1"> From a staged order file</a></li> Will fix! ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt @@ +145,5 @@ > + $("#checkAll").click(); > + > + $("#all_budget_id").hide(); > + $('label[for="all_budget_id"]').hide(); > + [% END %] I believe this is causing issues do to the fact that this patch targeted an earlier version of bug 7180. I will update the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:34:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:34:01 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10877-70-F5srrcKBEe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29406|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29759&action=edit Bug 10877 - Add "Order Record" processing Order Record Processing will allow a library to stage an "order record" file which is a standard marc file with some additional information in it about how to create items automatically ( quantity, itemtype, etc ). The location of these fields is defined in the system preference MarcFieldsToOrder from bug 7180. The workflow is thus: 1) A librarian uploads an "order record" file, and marks the batch as an order file during the staging process. 2) The librarian selects an acquisitions basket and chooses "from a staged order file" 3) From here, the librarian can view all the records that will be created, along with quantity and other data ( from bug 7180 ). The librarian will *not* see the item fields, as those are automatically created using the minimum data needed ( branches, itype ). 4) The librarian hits "save" and the items are automatically generated on order. Later ( using features not directly tied to this feature ), the librarian will receive a new marc batch file with items attached ( including itemnumbers ). The vendor will have this information because it was sent via EDI ( bug 7736 ). The librarian will then use the marc record staging feature to overlay those bare bones item records with the full data ( via bug 7131 ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:35:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:35:14 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10877-70-h5pp79Gi00@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:35:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:35:18 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10877-70-1WZ5fY3bI3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29759|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29760&action=edit Bug 10877 - Add "Order Record" processing Order Record Processing will allow a library to stage an "order record" file which is a standard marc file with some additional information in it about how to create items automatically ( quantity, itemtype, etc ). The location of these fields is defined in the system preference MarcFieldsToOrder from bug 7180. The workflow is thus: 1) A librarian uploads an "order record" file, and marks the batch as an order file during the staging process. 2) The librarian selects an acquisitions basket and chooses "from a staged order file" 3) From here, the librarian can view all the records that will be created, along with quantity and other data ( from bug 7180 ). The librarian will *not* see the item fields, as those are automatically created using the minimum data needed ( branches, itype ). 4) The librarian hits "save" and the items are automatically generated on order. Later ( using features not directly tied to this feature ), the librarian will receive a new marc batch file with items attached ( including itemnumbers ). The vendor will have this information because it was sent via EDI ( bug 7736 ). The librarian will then use the marc record staging feature to overlay those bare bones item records with the full data ( via bug 7131 ). Signed-off-by: Aaron Sakovich <asakovich at hmcpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:55:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:55:51 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10402-70-i9ws8iRGIg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 --- Comment #75 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to Paola Rossi from comment #74) > 1) I've edited the vendor. The "Notes" field of the contact is shown empty. Good catch! Issues 2-4 and the breadcrumbs you mention are outside the scope of this development. The following are true of Koha going back to 3.8 at least (so far as I can tell): 2) you can save an invalid e-mail address 3-4) notices will fail if you don't have an e-mail address set up for your account 5) you will see the vendor ID number rather than the vendor name in breadcrumbs after saving a vendor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:56:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:56:05 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10402-70-POAbHSmCuu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:56:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:56:08 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10402-70-ajRFLjJH2U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29604|0 |1 is obsolete| | --- Comment #76 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 29761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29761&action=edit Bug 10402 follow-up: choose contacts for claims This patch makes it possible to choose a particular contact for acquisitions and serials claims. To test: 1) Select a contact to use for claiming late orders and a contact to use for claiming late issues. 2) Send a claim for a late order and a claim for a late issue. 3) Note that the claims went out to the proper people. 4) Run the unit test with: > prove t/db_dependent/Letters.t 5) Sign off. Note: the claim messages are recorded in the logs in the *Acquisitions* module, not the Letters module as you might expect This patch also fixes several perlcritic violations and centralizes contact-related unit testing in Bookseller.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:59:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:59:27 +0000 Subject: [Koha-bugs] [Bug 12587] Improve output of filter information on patrons with the most checkouts report In-Reply-To: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12587-70-D7LqoZvbKX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12587 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 17:59:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 15:59:30 +0000 Subject: [Koha-bugs] [Bug 12587] Improve output of filter information on patrons with the most checkouts report In-Reply-To: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12587-70-ToKJ0sfDdR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12587 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29762&action=edit Bug 12587 - Improve output of filter information on patrons with the most checkouts report This patch makes some changes to the way filter information is displayed after running the patrons with the most checkouts report. Before this patch several untranslatable English strings would be displayed, and library and item type codes would be shown instead of descriptions. To test, go to Reports -> Patrons checking out the most. Enter values for all the filter options: - Checkout date from - Checkout date to - Checkin date from - Checkin date to - Library - Item type - Patron category When you submit the form and view the results you should see your date submissions formatted according to your selected dateformat system preference. The library name and item type names should be shown instead of codes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 18:12:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 16:12:48 +0000 Subject: [Koha-bugs] [Bug 8276] circ history not sorting right In-Reply-To: <bug-8276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8276-70-BztETKdAp2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Can you retest this? The handling of date sorting has changed since the last comment was added so I'm not sure if this bug is still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 18:13:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 16:13:55 +0000 Subject: [Koha-bugs] [Bug 8481] Items table is showing in opac-MARCdetail.pl but not in MARCdetail.pl In-Reply-To: <bug-8481-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8481-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8481-70-VYWx0xi7DO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8481 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 18:13:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 16:13:56 +0000 Subject: [Koha-bugs] [Bug 8390] Place hold button is missing from the MARC view page In-Reply-To: <bug-8390-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8390-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8390-70-ckcAibbOMC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8390 Bug 8390 depends on bug 8481, which changed state. Bug 8481 Summary: Items table is showing in opac-MARCdetail.pl but not in MARCdetail.pl http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8481 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 18:43:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 16:43:01 +0000 Subject: [Koha-bugs] [Bug 8847] Cataloguing doesn't work after installing ru-RU translation In-Reply-To: <bug-8847-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8847-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8847-70-izKUX4gn5F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8847 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- I'm going to assume this was a local or transient problem since there have been no comments since the original report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 18:49:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 16:49:35 +0000 Subject: [Koha-bugs] [Bug 8940] patron card export - without a batch, will work if... In-Reply-To: <bug-8940-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8940-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8940-70-lE9qxBepX0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8940 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- It sounds to me like this bug describe a problem which only arises if you access directly a script which is meant to be passed specific parameters by the interface. I'm going to consider this invalid unless more details can be provided. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 18:56:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 16:56:12 +0000 Subject: [Koha-bugs] [Bug 8969] Error while adding a repeatable holiday on the tools Calendar In-Reply-To: <bug-8969-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8969-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8969-70-T66d7Z5lEb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8969 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- I can't reproduce this problem in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 19:01:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 17:01:26 +0000 Subject: [Koha-bugs] [Bug 9013] Cart in staff interface displays location pulled from Description (OPAC) In-Reply-To: <bug-9013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9013-70-Q5xvcYn71B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|3.8 |master Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 19:11:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 17:11:50 +0000 Subject: [Koha-bugs] [Bug 9013] Cart in staff interface displays location pulled from Description (OPAC) In-Reply-To: <bug-9013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9013-70-L8MGun9wEr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 19:11:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 17:11:53 +0000 Subject: [Koha-bugs] [Bug 9013] Cart in staff interface displays location pulled from Description (OPAC) In-Reply-To: <bug-9013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9013-70-ULuVHLVzjo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9013 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29763&action=edit Bug 9013 - Cart in staff interface displays location pulled from Description (OPAC) When the cart in the staff client pulls description data for items.location and items.ccode it pulls the value designated for the OPAC--probably a cut-and-paste error when the feature was added to the staff client. This patch removes the 'opac' parameter from GetKohaAuthorisedValues. To test you must have at least one LOC authorized value configured to have different descriptions for staff and OPAC. Locate or edit an item with that shelving location and add that record to the cart in the staff client. When you view the cart, the shelving location description in the "Items" column should show the description for the staff client, not the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 19:37:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 17:37:26 +0000 Subject: [Koha-bugs] [Bug 12577] Search is broken after upgrade from 3.14.7 to 3.16.1 In-Reply-To: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12577-70-oD62gJm0eW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12577 --- Comment #8 from Magnus Enger <magnus at enger.priv.no> --- (In reply to Colin Campbell from comment #7) > The PRESENT error is, I think, generated if an error occurs formatting the > result set. I think if you look at the zebra index with yaz-client you > search ok but when you ask to view the returned records thats where the > error occurs. > So in Search.pm it sees there are x records but when it asks for them zebra > aborts so you get undefined values. Not quite. Searching from yaz-client does work, but so does "show"-ing the records. See http://paste.koha-community.org/103 for an example. But yes, there is something that causes the records not to make it back to the Koha code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 19:48:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 17:48:42 +0000 Subject: [Koha-bugs] [Bug 12588] New: show notes on acq search results Message-ID: <bug-12588-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12588 Bug ID: 12588 Summary: show notes on acq search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org I'm wondering if there is a way to show notes in the summary field of the orders search result page in acquisitions. On the page showing the basket you'll see notes entered for the title /cgi-bin/koha/acqui/basket.pl?basketno=3 But if I search for the title via the orders search I can't see the notes in the summary field /cgi-bin/koha/acqui/histsearch.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:10:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:10:53 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11431-70-c71JcoBjfg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29035|0 |1 is obsolete| | Attachment #29036|0 |1 is obsolete| | Attachment #29037|0 |1 is obsolete| | Attachment #29038|0 |1 is obsolete| | Attachment #29039|0 |1 is obsolete| | Attachment #29404|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29764&action=edit Bug 11431 [1] - Replace existing system with no change in functionality This patch set adds the ability to select which sounds are used for Koha's audio alerts, and which elements trigger those audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Set the various OverrideAudioAlert preferences to different sounds 6) Retest, verify new sounds play 7) Add/remove selectors from the AudioAlertSelector system preferences 8) Observe the difference in audio alert behavior based on your selections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:11:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:11:02 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: <bug-9156-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9156-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9156-70-t0HCvw1rv0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- How do you reproduce this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:11:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:11:10 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11431-70-DIFuhTiPWK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29765&action=edit Bug 11431 [2] - Rename soundon to AudioAlerts, move to it's own preference section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:11:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:11:13 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11431-70-kwO6fvkz6d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29766&action=edit Bug 11431 [3] - Add ability to customize the warning, action, and success sounds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:11:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:11:15 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11431-70-17aMfg6WBQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29767&action=edit Bug 11431 [4] - Add the ability to choose the elements that trigger an audio alert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:11:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:11:18 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11431-70-6Z5CBA7siX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29768&action=edit Bug 11431 [5] - Update sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:11:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:11:21 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11431-70-3pftT4HfOb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29769&action=edit Bug 11431 [6] - Add the ability to specify arbitrary audio alerts This patch further enhances our control over Koha audio alerts by allowing a library to specify custom audio events. A new system preference is added the combines the functions of the Selector and Override systems preferences in a list of selector:sound combinations. These definitions override the default sounds and thus gives the library a way to completely redefine what events trigger and audio alert, and what sounds are played! Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit the new AudioAlertsCustom system preference and enter the following: "body:contains('Check in message')": "IM_notification.ogg" 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:20:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:20:10 +0000 Subject: [Koha-bugs] [Bug 9221] contact note not showing In-Reply-To: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9221-70-vpfU52r7z4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9221 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:20:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:20:16 +0000 Subject: [Koha-bugs] [Bug 9221] contact note not showing In-Reply-To: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9221-70-mx3HqjeUBx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9221 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:20:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:20:45 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: <bug-11622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11622-70-PQfewasB92@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:25:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:25:32 +0000 Subject: [Koha-bugs] [Bug 9221] contact note not showing In-Reply-To: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9221-70-jgbWpS2lIA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9221 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:25:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:25:34 +0000 Subject: [Koha-bugs] [Bug 9221] contact note not showing In-Reply-To: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9221-70-iApPi3eLPu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9221 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29770&action=edit Bug 9221 - contact note not showing The contents of the contact note field are not displayed on the patron detail page in the staff client. This patch corrects this. This patch also corrects the case of the "Contact note" label in the OPAC patron details form (Log in -> Your personal details). To test, apply the patch and edit a patron to add data to the contact note field. Save and view the detail page for that patron. The contents of the contact note field should appear under the alternate address data. In the OPAC the contact note field label should have correct capitalization. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:29:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:29:32 +0000 Subject: [Koha-bugs] [Bug 9792] Layout problem with patron entry form when using Internet Explorer 9 In-Reply-To: <bug-9792-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9792-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9792-70-Irw52ryr8V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9792 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- The problem exists in Internet Explorer 11 as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:42:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:42:55 +0000 Subject: [Koha-bugs] [Bug 12577] Search is broken after upgrade from 3.14.7 to 3.16.1 In-Reply-To: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12577-70-PW8PlKCGe3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12577 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Magnus Enger <magnus at enger.priv.no> --- I was able to fix search by: - Copying koha-conf.xml from a fresh instance to the old instance (and editing stuff related to instancename and passwords) - Copying zebra-biblios-dom.cfg from a fresh instance to the old instance (and editing stuff related to instancename) I think these problems are better pursued as: Bug 12584 - koha-conf.xml for package installations get out of sync Thanks to Tomas, Colin, Katrin et al for helping me troubleshoot! *** This bug has been marked as a duplicate of bug 12584 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:42:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:42:55 +0000 Subject: [Koha-bugs] [Bug 12584] koha-conf.xml for package installations get out of sync In-Reply-To: <bug-12584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12584-70-FgUck5e7If@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 --- Comment #1 from Magnus Enger <magnus at enger.priv.no> --- *** Bug 12577 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:49:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:49:38 +0000 Subject: [Koha-bugs] [Bug 10235] Koha's syspref search fails to find 'local' sysprefs In-Reply-To: <bug-10235-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10235-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10235-70-ANKfDjIHCD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10235 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- It would be nice if, at the very least, a search for local system preferences worked from the local use tab. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 20:58:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 18:58:22 +0000 Subject: [Koha-bugs] [Bug 9378] Translations don't apply? In-Reply-To: <bug-9378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9378-70-YAjt5flxgT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9378 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Here's what I tried: - I had de-DE installed but not enabled. - I went to the i18n/L10n tab and unchecked English(en), checked Deutsch(de-DE) for both OPAC and staff client. - I navigated to a new page in the staff client and found that the German translation was enabled. - I navigated to a new page in the OPAC and found that the German translation was enabled. As far as I can understand this means I can't reproduce the bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 21:02:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 19:02:50 +0000 Subject: [Koha-bugs] [Bug 9408] make test fails on master In-Reply-To: <bug-9408-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9408-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9408-70-haK8tDNH3z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9408 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Jared Camins-Esakov from comment #1) > Those tests fail because the calendar code is broken in master (and 3.10). > There is a patch fixing the problem on bug 9211 The patch for Bug 9211 has been pushed to master so I assume this bug is no longer valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 21:05:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 19:05:42 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-1rDPIUD1tt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 21:07:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 19:07:52 +0000 Subject: [Koha-bugs] [Bug 10383] printable version of bib record doesn't include subtitle in staff client In-Reply-To: <bug-10383-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10383-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10383-70-PXU2aPPK8A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10383 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 21:31:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 19:31:26 +0000 Subject: [Koha-bugs] [Bug 4013] road type missing on search results In-Reply-To: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4013-70-x5Ai7eaJTJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 21:31:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 19:31:35 +0000 Subject: [Koha-bugs] [Bug 4013] road type missing on search results In-Reply-To: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4013-70-3ouYfumV3w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 21:31:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 19:31:58 +0000 Subject: [Koha-bugs] [Bug 4013] road type missing on search results In-Reply-To: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4013-70-4wS3eSBAsK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|oleonard at myacpl.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 21:40:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 19:40:08 +0000 Subject: [Koha-bugs] [Bug 4013] road type missing on search results In-Reply-To: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4013-70-S8pIAkrOpK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 21:40:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 19:40:11 +0000 Subject: [Koha-bugs] [Bug 4013] road type missing on search results In-Reply-To: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4013-70-NiWgR6XMEm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29771&action=edit Bug 4013 - road type missing on search results On the patron search results page there are several patron fields which do not show: street number, road type, and state. This patch adds them. To test, go to Patrons -> Search patrons and perform a search. In the table of patron search results each patron record should display the correct information including street number, road type, and state. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 21:51:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 19:51:06 +0000 Subject: [Koha-bugs] [Bug 4306] Label manage batch listing should show item-level itemtype In-Reply-To: <bug-4306-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4306-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4306-70-sdWI8VrdFK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4306 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 21:55:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 19:55:18 +0000 Subject: [Koha-bugs] [Bug 12588] show notes on acq search results In-Reply-To: <bug-12588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12588-70-wFwa4uLOjq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12588 Suzanne Fayle <sfayle at roseman.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 22:06:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 20:06:43 +0000 Subject: [Koha-bugs] [Bug 12589] New: Manage label batch view should show item type description instead of code Message-ID: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12589 Bug ID: 12589 Summary: Manage label batch view should show item type description instead of code Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/labels/label-edit-batch.pl?op=edit&e lement_id=X OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org When viewing an existing batch of items in the label creator tool the item type code for each item is shown. It should show the description instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 22:11:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 20:11:57 +0000 Subject: [Koha-bugs] [Bug 12589] Manage label batch view should show item type description instead of code In-Reply-To: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12589-70-tKWt9OOaKn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12589 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 22:12:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 20:12:00 +0000 Subject: [Koha-bugs] [Bug 12589] Manage label batch view should show item type description instead of code In-Reply-To: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12589-70-CrauwLg63w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12589 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29772&action=edit Bug 12589 - Manage label batch view should show item type description instead of code When viewing the list of items in an existing label batch the item type code is shown. This patch modifies the template to show the item type description instead. To test, go to Tools -> Labels -> Manage batches. If necessary, create a batch with multiple items of different item types. Edit the batch and confirm that the table of items shows item type description instead of code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 23:55:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 21:55:11 +0000 Subject: [Koha-bugs] [Bug 6668] Marc batch edit will freeze after deselecting all items and saving, In-Reply-To: <bug-6668-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6668-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6668-70-fW9UabODMH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6668 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Bug 6446 and But 6543 referenced above are both closed and I cannot reproduce this problem in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 23:57:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 21:57:24 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-NzB5ldX8zD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #198 from Owen Leonard <oleonard at myacpl.org> --- I see at least a couple of patches on this bug which are not signed off. Should the status be changed to "needs signoff?" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 23:57:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 21:57:30 +0000 Subject: [Koha-bugs] [Bug 12584] koha-conf.xml for package installations get out of sync In-Reply-To: <bug-12584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12584-70-p3BN4DJLPt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 16 23:59:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 21:59:16 +0000 Subject: [Koha-bugs] [Bug 12584] koha-conf.xml for package installations get out of sync In-Reply-To: <bug-12584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12584-70-gT2DwrZ5OO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- The difficulty is knowing if things were added in a new version, pruned from the current version, or manually added to configure a particular feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 01:23:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 23:23:57 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-yZCP5wYOMF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #57 from Nick Clemens <nick at quecheelibrary.org> --- I tested but am not seeing history stored if patron privacy preference is set to 'never' Patron also seems to be able to clear last borrower history using 'Immediate deletion' button Bug says depends on 11891, but that was pushed to master, wanted to check before clearing though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 01:42:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 23:42:38 +0000 Subject: [Koha-bugs] [Bug 9408] make test fails on master In-Reply-To: <bug-9408-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9408-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9408-70-hGCGt5dyjW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9408 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Owen Leonard from comment #4) > (In reply to Jared Camins-Esakov from comment #1) > > Those tests fail because the calendar code is broken in master (and 3.10). > > There is a patch fixing the problem on bug 9211 > > The patch for Bug 9211 has been pushed to master so I assume this bug is no > longer valid. This bug has been solved in 3.12.x, 3.14.x, 3.16.x and master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 01:55:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jul 2014 23:55:04 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-QiGVWS0j3G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> --- A messy little conflict on admin/z3950servers.pl otherwise seems fine. Happy to try sign off again when the conflict is tidied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 02:24:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 00:24:59 +0000 Subject: [Koha-bugs] [Bug 7605] items that not available say availalbe in the staff search results In-Reply-To: <bug-7605-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7605-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7605-70-LnvjvR81zY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7605 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This appears to be fixed in master. The not for loan status appears with details like this: 2 unavailable: Athens [JNF 741.5 Me] Ordered (1) Circulating Coolville [JNF 741.5 Me] Not for Loan (1) Circulating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 02:28:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 00:28:16 +0000 Subject: [Koha-bugs] [Bug 8469] Inconsistent language in reserve status In-Reply-To: <bug-8469-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8469-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8469-70-bKxACO1fiq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8469 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Component|Circulation |Templates Assignee|elliott at bywatersolutions.co |oleonard at myacpl.org |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 02:36:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 00:36:57 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-qFiVyCMrra@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29582|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 29773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29773&action=edit Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 02:37:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 00:37:13 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-TeB4bnjRGw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29583|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 29774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29774&action=edit Bug 11349: Remove unnecesary name translation Since all scripts use the '.tt' sufix for template names there's no need for and regexp that changes from '.tmpl' to '.tt'. Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 02:37:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 00:37:59 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-9S15JojQkC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29584|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 29775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29775&action=edit Bug 11349: Make the QA script happy This patch just adjusts several POD stuff, and in a few cases reorganizes a hash definition in order to use spaces instead of tabs for the QA script to be happy. Nothing important, really. This patch series just changes '.tmpl' for '.tt'. Regards To+ PS beware that running the koha-qa.pl script can take lots of time on this one :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 02:38:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 00:38:27 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-dBnqKHu4mu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 03:02:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 01:02:07 +0000 Subject: [Koha-bugs] [Bug 8603] Patron card creator - 'Barcode Type' doesn't stick in layouts In-Reply-To: <bug-8603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8603-70-I5nVxFlm0X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 03:05:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 01:05:56 +0000 Subject: [Koha-bugs] [Bug 9334] MARC framework import function has incorrect file format warning In-Reply-To: <bug-9334-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9334-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9334-70-h2iSXeYsDv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9334 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 03:07:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 01:07:24 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-Kjn9TPgIum@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 03:07:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 01:07:29 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-snFe1uvhGo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29773|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 29776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29776&action=edit Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 03:07:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 01:07:45 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-Kr9STKPAq2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29774|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 29777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29777&action=edit Bug 11349: Remove unnecesary name translation Since all scripts use the '.tt' sufix for template names there's no need for and regexp that changes from '.tmpl' to '.tt'. Regards To+ Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 03:08:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 01:08:01 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-a7mh5arGbz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29775|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 29778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29778&action=edit Bug 11349: Make the QA script happy This patch just adjusts several POD stuff, and in a few cases reorganizes a hash definition in order to use spaces instead of tabs for the QA script to be happy. Nothing important, really. This patch series just changes '.tmpl' for '.tt'. Regards To+ PS beware that running the koha-qa.pl script can take lots of time on this one :-D Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 03:09:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 01:09:55 +0000 Subject: [Koha-bugs] [Bug 9339] Intranet translation bar display en-GB when en is selected In-Reply-To: <bug-9339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9339-70-4EEU0H2qQS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9339 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 06:40:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 04:40:47 +0000 Subject: [Koha-bugs] [Bug 12590] New: Support deletion of biblio in svc API Message-ID: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12590 Bug ID: 12590 Summary: Support deletion of biblio in svc API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: boutrosboutrosboutros at gmail.com QA Contact: testopia at bugs.koha-community.org The /svc endpoint allows you to create and update biblio records. It should also be possible to delete a biblio. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 06:41:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 04:41:32 +0000 Subject: [Koha-bugs] [Bug 12590] Support deletion of biblio in svc API In-Reply-To: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12590-70-veVsoJIFfT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12590 Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |boutrosboutrosboutros at gmail |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 06:47:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 04:47:24 +0000 Subject: [Koha-bugs] [Bug 12591] New: CRUD operations for Notices should happen in a module not in letters.pl Message-ID: <bug-12591-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12591 Bug ID: 12591 Summary: CRUD operations for Notices should happen in a module not in letters.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, all the CRUD subroutines for Notices/Letters occur in letters.pl, when they should be handled in C4::Letters or a new module in the Koha namespace. I always wondered where the subs for Letters CRUD were...and just happened to stumble across them today. Perhaps Chris will be doing something with this with his Koha::Email module, but I don't know. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 06:59:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 04:59:23 +0000 Subject: [Koha-bugs] [Bug 12555] Call DelItem on cancelling a receipt In-Reply-To: <bug-12555-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12555-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12555-70-UDAUpN5Atr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 09:15:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 07:15:54 +0000 Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt In-Reply-To: <bug-12555-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12555-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12555-70-JQdXj5QeY6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Call DelItem on cancelling |The DelItem subroutine |a receipt |should be called on | |canceling a receipt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 09:24:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 07:24:50 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-zKoeqxSEnk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #11 from David Cook <dcook at prosentient.com.au> --- Here's the start of the solution: Add the following line of code to the OpacSuppression code block: $query = '@not '.$query.' @attr 1=9011 1'; if (C4::Context->preference('OpacSuppression')) { # OPAC suppression by IP address if (C4::Context->preference('OpacSuppressionByIPRange')) { my $IPAddress = $ENV{'REMOTE_ADDR'}; my $IPRange = C4::Context->preference('OpacSuppressionByIPRange'); if ($IPAddress !~ /^$IPRange/) { $query = "($query) not Suppress=1"; } } else { #$query = "($query) not Suppress=1"; $query = '@not '.$query.' @attr 1=9011 1'; } } Now...we can't comment out [$query = "($query) not Suppress=1";]. That's just for demonstration purposes. Unfortunately, we can't use the QP syspref to detect whether we should use the CCL version or the PQF version, because buildQuery can output both depending on the query that is input into it. So...the hack here is to use some regex to detect "@attr" in the outbound query probably. You can get fancier than that. Even better...changing buildQuery, so that it returns what query language it's using! Then no hacking necessary. I can probably do a patch for this sometime when I'm less pressed for time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 09:46:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 07:46:39 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-kPT9DZFjSS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #41 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 29779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29779&action=edit Bug 6536: SRU servers administration This patch makes adjustments in admin/z3950servers in order to insert, edit and delete SRU server records. Test plan: Add, edit, copy and delete SRU server. Check if adding, editing, copying and deleting Z3950 servers still works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 09:50:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 07:50:30 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-1zbZAKjbUU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 --- Comment #12 from David Cook <dcook at prosentient.com.au> --- Hmm, now I'm unsure about my answer due to the order of operations... Example from IndexData (http://www.indexdata.com/yaz/doc/tools.html#PQF) @or "dylan" "zimmerman" @and @or dylan zimmerman when @and when @or dylan zimmerman It seems like you always need to have your operators at the beginning...and that it figures out the order on its own. In the 3rd case, not all the operators are at the beginning, but they are before the "pair" of operands on which they're operating. Here's my query that worked: @not @or @or @or @attr 1=1016 @attr 5=1 @attr 4=6 "e" @attr 9=75 @attr 2=102 @attr 5=1 @attr 4=6 "e" @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "e" @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "e" @attr 1=9011 1 Yet...consider the following: prefixQuery("dinosaur"); CCLQuery("dinosaur"); prefixQuery("@and complete dinosaur"); CCLQuery("complete and dinosaur"); prefixQuery("@and complete @or dinosaur pterosaur"); CCLQuery("complete and (dinosaur or pterosaur)"); prefixQuery("@attr 1=7 0253333490"); CCLQuery("isbn=0253333490"); Even these examples don't make sense but it's probably something like... "e and not e or e or e or suppress=1" Maybe... "e and not (e or e or e or suppress=1)" Which...will hide the suppressed records...but it'll also kill those other "e" subqueries... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 09:56:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 07:56:06 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-4z6bidONm6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #42 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 29780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29780&action=edit Bug 6536: Adjustments for servername and servertype Replaces name by servername, type by servertype for running Z3950 search. Limit search scripts to zed (z3950) servers until sru is supported. Test plan: Perform a Z3950 search in Cataloguing and Acquisition. Verify that it still works as it did. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 10:08:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 08:08:04 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-HA1OXI62wd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 --- Comment #13 from David Cook <dcook at prosentient.com.au> --- I'm looking again at this example: prefixQuery("@and complete @or dinosaur pterosaur"); CCLQuery("complete and (dinosaur or pterosaur)"); And considering the PQF grammar: PQF Grammar complex ::= operator query-struct query-struct. http://www.indexdata.com/yaz/doc/tools.html#PQF If it is "reverse polish notation" (ie RPN)... Then the following: @not @or @or @or @attr 1=1016 @attr 5=1 @attr 4=6 "e" @attr 9=75 @attr 2=102 @attr 5=1 @attr 4=6 "e" @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "e" @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "e" @attr 1=9011 1 Becomes: @attr 1=1016 @attr 5=1 @attr 4=6 "e" @not @attr 9=75 @attr 2=102 @attr 5=1 @attr 4=6 "e" @or @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "e" @or @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "e" @or @attr 1=9011 1 OR kw,wrdl,rt=e and not (kw,wrdl,rt=e or (kw,wrdl,rt=e or (kw,wrdl,rt=e or suppress=1))) Well...there is also relevance ranking in there but I got lazy... I'm not sure how to make the query structure into: (kw,wrdl,rt=e or kw,wrdl,rt=e or kw,wrdl,rt=e or kw,wrdl,rt=e) and not (suppress=1) I know you can do grouping with CCL but how that works with PQF...I have no idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 10:12:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 08:12:12 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-2Br4h3aztY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 --- Comment #14 from David Cook <dcook at prosentient.com.au> --- I see this too in the grammar, but I don't understand how to read grammars well enough to understand: query-struct ::= attr-spec | simple | complex | '@term' term-type query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 10:18:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 08:18:10 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11373-70-kzdoRqAEtg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> --- This last patch does not need a signoff (will be done by QA). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 10:20:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 08:20:42 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-52en86f1yD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 --- Comment #15 from David Cook <dcook at prosentient.com.au> --- I wonder if these are supposed to be equivalent... @and when @or dylan zimmerman becomes... when and (dylan or zimmerman) So what does that mean for the following? @and @or dylan zimmerman when Does it become: 1) "dylan" and "zimmerman" or "when" 2) "dylan" and ("zimmerman" or "when") 3) ("dylan" or "zimmerman") and "when" I suppose the only way is to read YAZ source code or to do more tests... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 10:49:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 08:49:13 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-oVEhz1IZrt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 --- Comment #2 from Juhani Sepp?l? <jseppal at student.uef.fi> --- Created attachment 29781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29781&action=edit Bug 11888: Random password suggestion does not work twice This patch adds a simple ajax-call to pull a new suggested password from the same perl script. To test: 1) Search for a patron and select "Change password" from the moremember-view. 2) In the member-password-view, click on "Click to fill with a randomly generated suggestion". 3) Confirm that you get a new suggested password and click the same link again. 4) Note that you do not get another suggested password - nothing is happening. 5) Apply patch. 6) Repeat steps 1-3 and confirm that you can keep clicking for a new suggested password. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 10:52:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 08:52:09 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-7QHzXO45wf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 10:52:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 08:52:13 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-v7UwdC9Zy2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29776|0 |1 is obsolete| | Attachment #29777|0 |1 is obsolete| | Attachment #29778|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29782&action=edit Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 10:52:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 08:52:17 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-BUlll9hBQ9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 --- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29783&action=edit Bug 11349: Remove unnecesary name translation Since all scripts use the '.tt' sufix for template names there's no need for and regexp that changes from '.tmpl' to '.tt'. Regards To+ Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 10:52:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 08:52:23 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-8nuv7Db7Rj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 --- Comment #14 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29784&action=edit Bug 11349: Make the QA script happy This patch just adjusts several POD stuff, and in a few cases reorganizes a hash definition in order to use spaces instead of tabs for the QA script to be happy. Nothing important, really. This patch series just changes '.tmpl' for '.tt'. Regards To+ PS beware that running the koha-qa.pl script can take lots of time on this one :-D Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 10:52:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 08:52:28 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-T66fct9Grx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 --- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29785&action=edit Bug 11349: (qa follow-up) Fix pod FAIL cataloguing/value_builder/unimarc_field_125.pl FAIL pod *** ERROR: empty =head1 in file cataloguing/value_builder/unimarc_field_125.pl *** ERROR: Spurious text after =cut in file cataloguing/value_builder/unimarc_field_125.pl FAIL cataloguing/value_builder/unimarc_field_126b.pl FAIL pod *** ERROR: empty =head1 in file cataloguing/value_builder/unimarc_field_126b.pl *** ERROR: Spurious text after =cut in file cataloguing/value_builder/unimarc_field_126b.pl FAIL cataloguing/value_builder/unimarc_field_225a.pl FAIL pod *** ERROR: =over on line 40 without closing =back (at head1) in file cataloguing/value_builder/unimarc_field_225a.pl *** ERROR: empty =head1 in file cataloguing/value_builder/unimarc_field_225a.pl Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 10:54:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 08:54:56 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-B04zY9FCoU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Juhani Sepp?l? <jseppal at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jseppal at student.uef.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 10:55:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 08:55:56 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-c366kqTvBF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Juhani Sepp?l? <jseppal at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 11:03:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 09:03:21 +0000 Subject: [Koha-bugs] [Bug 12590] Support deletion of biblio in svc API In-Reply-To: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12590-70-dX3cBJBwYT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12590 --- Comment #1 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> --- Created attachment 29786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29786&action=edit Bug 12590 - Support deletion of biblio in svc API The /svc endpoint allows you to create and update biblio records. This patch extends it so that it is also possible to delete a biblio. Test plan * Create a new biblio by sending a POST request to /svc/new_bib with a marcxml record as request body. Note the biblionumber it gets assigned. * Make some changes to the marcxml record, and update it by sending a POST request to /svc/bib/{bibilonumber} * Observe that the changes are persisted on the biblio record. * Now delete the bilblio by sending a DELETE request to /svc/bib/{biblionumber} * Observe that the biblio is indeed gone from the db. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 11:06:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 09:06:40 +0000 Subject: [Koha-bugs] [Bug 12590] Support deletion of biblio in svc API In-Reply-To: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12590-70-ACoYdzADJb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12590 Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> --- I should maybe add: the deletion uses C4:DelBiblio, so it will fail if the biblio has any items associated with it. This is the intended behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 11:16:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 09:16:34 +0000 Subject: [Koha-bugs] [Bug 12592] New: Minor correction for C4::DelBiblio documentation Message-ID: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12592 Bug ID: 12592 Summary: Minor correction for C4::DelBiblio documentation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: boutrosboutrosboutros at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The function header says that DelBiblio checks to make sure there aren't any issues on any of the items. What the code does, on the other hand, is to check whether biblio has any items attached, and refuses to delete biblio if it has any. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 11:20:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 09:20:04 +0000 Subject: [Koha-bugs] [Bug 12592] Minor correction for C4::DelBiblio documentation In-Reply-To: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12592-70-LSd1hIMH1t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12592 --- Comment #1 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> --- Created attachment 29787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29787&action=edit Bug 12592 - Minor correction for C4::DelBiblio documentation The function header says that DelBiblio checks to make sure there aren't any issues on any of the items. What the code does, on the other hand, is to check whether biblio has any items attached, and refuses to delete biblio if it has any. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 11:20:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 09:20:20 +0000 Subject: [Koha-bugs] [Bug 12592] Minor correction for C4::DelBiblio documentation In-Reply-To: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12592-70-zpX9Ueks5e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12592 Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 11:29:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 09:29:38 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: <bug-10267-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10267-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10267-70-tkjjsxORB5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Templates Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 11:32:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 09:32:46 +0000 Subject: [Koha-bugs] [Bug 7367] General OPAC typo omnibus In-Reply-To: <bug-7367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7367-70-y0EFWWJAwC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #20 from Owen Leonard <oleonard at myacpl.org> --- All the patches on this report have been pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 11:35:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 09:35:25 +0000 Subject: [Koha-bugs] [Bug 7367] General OPAC typo omnibus In-Reply-To: <bug-7367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7367-70-CPOqzpDFYl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367 --- Comment #21 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Owen Leonard from comment #20) > All the patches on this report have been pushed. No need to close this one? Has been reused numerous times.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 11:40:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 09:40:46 +0000 Subject: [Koha-bugs] [Bug 9177] Duplicate patron: Prepopulated fields ar cleared when setting cursor In-Reply-To: <bug-9177-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9177-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9177-70-W9kwrl5A91@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Templates Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This is by design. I think the idea is that you don't click those fields if the data is correct. If the data is incorrect you want to replace it, so clearing is helpful. It's easy to see the downside: If you use the keyboard to navigate through the form you'll end up clearing all the existing data. I don't know that I've ever used the duplicate feature in production, but I would think that downside is pretty significant, not to mention being an accessibility problem for users who can't use a mouse. Is this a feature we really need to keep? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 11:41:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 09:41:13 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-7LIRcEMtqZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> --- I added a new test in qa tests. commit dacebd6ee4c5df57f0b2ee266e8f425feaee176f Author: Jonathan Druart <jonathan.druart at biblibre.com> Date: Thu Jul 17 11:12:38 2014 +0200 template name should not contain .tmpl anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 11:53:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 09:53:48 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-rMe3uzgNdC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #43 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 29788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29788&action=edit Bug 6536: Include SRU searching in Breeding.pm This patch makes it possible to include SRU servers in Z3950 search. It adjusts the Z3950Search routine in Breeding module. It also replaces SQL code with DBIx statements in Breeding.pm/Z3950Search and the associated scripts z3950search.pl in cataloguing and acqui. Test plan: Verify if a normal Z3950 search still works in cataloging/acqui. Add a SRU target. (You could just use Koha's port 9998.) Define sru_options like sru=get. Use that target in a Z3950 search in cataloging and acqui. (Import.) Test sru_fields translation by comparing search results between various settings for some of the fields. For instance, leave title empty and after that set it to the title field of your SRU target. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:19:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:19:42 +0000 Subject: [Koha-bugs] [Bug 9514] 'and' in subject searches causes a problem In-Reply-To: <bug-9514-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9514-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9514-70-lrLOT4VZCC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9514 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5515 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:19:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:19:42 +0000 Subject: [Koha-bugs] [Bug 5515] Leading 'and' in search never returns a result In-Reply-To: <bug-5515-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5515-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5515-70-sNhefCnYSn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5515 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9514 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:21:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:21:22 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-JK0EIoRNW1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:29:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:29:29 +0000 Subject: [Koha-bugs] [Bug 12593] New: search facets die with regex error if biblio has square brackets in fields Message-ID: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 Bug ID: 12593 Summary: search facets die with regex error if biblio has square brackets in fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org It's quite common to have [something] within facet data, and it produces following error: Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE ?ivot i obi?aji narodni ;$/ at /srv/koha//C4/Search.pm line 535. This problem was intoduced in Bug 12151 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:29:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:29:53 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-qC9VxaelGH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12151 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:29:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:29:53 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: <bug-12151-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12151-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12151-70-mCnPVjb7g6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12593 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:32:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:32:29 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-sF0Lup9BDp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:32:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:32:32 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-Z63kfrFYBk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 --- Comment #1 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29789&action=edit Bug 12593 - search facets die with regex error if biblio has square brackets in fields It's quite common to have [something] within facet data, and it produces following error: Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE This problem was intoduced in Bug 12151 but is trivial to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:36:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:36:37 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: <bug-12151-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12151-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12151-70-0PLtH3Cgqc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #23 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Please see Bug 12593 for fix of problem with facets and data with square brackets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:39:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:39:43 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-Be0VGC75LV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #44 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 29790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29790&action=edit Bug 6536: Add XSLT transformation on Z3950 search results Use the stylesheets listed in field add_xslt of z3950servers to transform search results of Z3950/SRU search. Additionally, the template has been changed to make more error messages (or warnings) visible when displaying results. Until now, error message were shown in the results table and when connection errors occurred, no results were displayed at all. Test plan: Create some stylesheets (or see the sample patch on bug 6536). Add these stylesheets to some Z3950/SRU servers. Do Z3950 search and verify the transformations. Do a search with 2 targets; make one target fail (by manipulating its server data). Do you see the connection error and the results for the other target? Generate a XSLT error by modifying one stylesheet. Check search results. You should see warnings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:49:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:49:34 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-mCRD2B1m17@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #45 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 29791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29791&action=edit [SAMPLE XSLT; DO NOT PUSH] Bug 6536: Two simple test XSLT files You could use Add901.xsl or Set003ABC.xsl in field add_xslt of table z3950servers when testing this report. Set003ABC will change field 003 into ABC. And Add901 adds a tag 901. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:52:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:52:28 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-fy6BScHQoe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #46 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- This is ready for signoff now/again. Please let me know if you encounter problems testing this.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:53:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:53:38 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-kqcNDGUOU1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:54:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:54:57 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10877-70-SFEzKMV4zG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #21 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Kyle M Hall from comment #18) > Comment on attachment 29406 [details] [review] > ::: acqui/addorderiso2709.pl > @@ +270,5 @@ > > my @serials = $input->param('serial'); > > my @ind_tag = $input->param('ind_tag'); > > my @indicator = $input->param('indicator'); > > + > > + if ($is_order) { > > This is so we can pre-set the items to a notforloan value of 'ordered', and > to preset the home and holding fields to the current branch, as well as > pre-set the itemtype. Yes but you hard-code arbitrarily these values. Why these 4 values and not others? I would like to get another QA point of view here. Katrin maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 12:58:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 10:58:18 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9811-70-N8L0MeiQyZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #136 from Dobrica Pavlinusic <dpavlin at rot13.org> --- It seems that this patch changes behavior when we search for first name last name combination. In old code, we where able to enter full patron name and get just that patron, while with this change we get all patrons which have same first OR last name. This is quite annoying because for common names we get 300+ results instead of just one. It seems that we should use AND operator for all "standard" fields in C4::Utils::DataTables::Members, but I might be wrong. Comments how to address this are very welcomed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 13:00:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 11:00:39 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-7ieK6kKQxO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 13:09:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 11:09:26 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9811-70-pvjUjX4jc0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #137 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Dobrica Pavlinusic from comment #136) > It seems that we should use AND operator for all "standard" fields in > C4::Utils::DataTables::Members, but I might be wrong. Could you detail, I don't understand. If you search "john doe", which query are you expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 13:13:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 11:13:08 +0000 Subject: [Koha-bugs] [Bug 12594] New: Get rid of z3950random Message-ID: <bug-12594-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12594 Bug ID: 12594 Summary: Get rid of z3950random Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl This field is of no use (since longer time already) and I would like to remove it from Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 13:13:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 11:13:29 +0000 Subject: [Koha-bugs] [Bug 12594] Get rid of z3950random In-Reply-To: <bug-12594-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12594-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12594-70-VUarIKaYVp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12594 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Depends on| |6536 Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 13:13:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 11:13:29 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-w15YNkEwDq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12594 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 13:13:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 11:13:35 +0000 Subject: [Koha-bugs] [Bug 12594] Get rid of z3950random In-Reply-To: <bug-12594-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12594-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12594-70-IZ68GPP0xD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12594 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 13:13:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 11:13:47 +0000 Subject: [Koha-bugs] [Bug 12594] Get rid of z3950random In-Reply-To: <bug-12594-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12594-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12594-70-9wznpnxYCE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12594 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 13:19:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 11:19:56 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9811-70-eukJyuQCmV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #138 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Jonathan Druart from comment #137) > (In reply to Dobrica Pavlinusic from comment #136) > > It seems that we should use AND operator for all "standard" fields in > > C4::Utils::DataTables::Members, but I might be wrong. > > Could you detail, I don't understand. > > If you search "john doe", which query are you expected? Ok, understood looking at the previous code. It should work as it. It's a bug. If you open a bug report, I can submit a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 14:06:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 12:06:19 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-DVK91SQHq6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 --- Comment #23 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 29792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29792&action=edit Bug 8218: Follow-up for some small typos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 14:09:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 12:09:35 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-FJB1Q3Hvsa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #24 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- I would like to suggest an adjustment for this report: The confirm flag is not doing what I would expect it to do. I would expect that after running the sanitize check on the record, confirm would determine if the record gets saved. But looking at the code, I see that you just skip the whole record when confirm is off. Note that the print messages are not that clear too. You say "will be processed" but skip the record. After that you report 0 records to clean. But I knew that I had at least one record.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 14:11:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 12:11:14 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-Pok0s6lmFD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|MARC Authority data support |Command-line Utilities Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 14:20:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 12:20:05 +0000 Subject: [Koha-bugs] [Bug 12325] Marc and Card view in Z39.50 Results doesn't work properly in IE 8 In-Reply-To: <bug-12325-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12325-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12325-70-IBF1kvbijt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12325 --- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- But do we or even should we support IE8 for the staff client? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 14:35:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 12:35:26 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-BtGkiwB8Mp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26755|0 |1 is obsolete| | Attachment #29792|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29793&action=edit Bug 8218 : Add a maintenance script to sanitize biblio records This patch adds: - a new maintenance script batch_sanitize_records - a new subroutine C4::Charset::SanitizeRecord - new unit tests for the new subroutine Test plan: 1/ prove t/db_dependent/Charset.t 2/ Create a record containing "&amp;" (could be follow with as many 'amp;' as you want) in one of its fields and the same for the field linked to biblioitems.url. The url should not be sanitized, it cans contain "&". 3/ Launch the maintenance script with the -h paramters to see how to use it. 4/ Launch the script using the different parameters: --filename=FILENAME --biblionumbers='XXX' --auto-search The auto-search permits to sanitize all records containing "&amp;" in the marcxml field. Use the verbose flag for testing. Without the --confirm flag, nothing is done. 5/ Use the --confirm flag and verify in the biblioitems.marcxml field that the record has been sanitized. 6/ Try the --reindex flag to reindex records which have been modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 14:35:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 12:35:31 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-zVVgNalER3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 --- Comment #26 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29794&action=edit Bug 8218: Follow-up for some small typos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 14:35:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 12:35:38 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: <bug-12403-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12403-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12403-70-ul4JcALtUW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 14:49:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 12:49:24 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-SFHxS4Wqjt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- I tested with an author name including [something] as well as [something So, the second case included an unmatched [ in regex, but I did not get the error (on current master). I see the [ in the facets. Could you please add some more details to reproduce this? Does it depend on specific perl version? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:05:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:05:12 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-PAqHw7J0rc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:05:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:05:15 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-dawwE0TQDX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29793|0 |1 is obsolete| | Attachment #29794|0 |1 is obsolete| | --- Comment #27 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 29795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29795&action=edit Bug 8218 : Add a maintenance script to sanitize biblio records This patch adds: - a new maintenance script batch_sanitize_records - a new subroutine C4::Charset::SanitizeRecord - new unit tests for the new subroutine Test plan: 1/ prove t/db_dependent/Charset.t 2/ Create a record containing "&amp;" (could be follow with as many 'amp;' as you want) in one of its fields and the same for the field linked to biblioitems.url. The url should not be sanitized, it may contain "&". 3/ Launch the maintenance script with the -h parameter to see how to use it. 4/ Launch the script using the different parameters: --filename=FILENAME --biblionumbers='XXX' --auto-search The auto-search permits to sanitize all records containing "&amp;" in the marcxml field. Use the verbose flag for testing. Without the --confirm flag, nothing is done. 5/ Use the --confirm flag and verify in the biblioitems.marcxml field that the record has been sanitized. 6/ Try the --reindex flag to reindex records which have been modified. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:05:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:05:21 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-pxOGKIPN2d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 --- Comment #28 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 29796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29796&action=edit Bug 8218: Follow-up for some small typos Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:06:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:06:39 +0000 Subject: [Koha-bugs] [Bug 12592] Minor correction for C4::DelBiblio documentation In-Reply-To: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12592-70-NK9tleMxim@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12592 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |boutrosboutrosboutros at gmail | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:07:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:07:32 +0000 Subject: [Koha-bugs] [Bug 12592] Minor correction for C4::DelBiblio documentation In-Reply-To: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12592-70-FbxRLVYvfH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12592 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:09:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:09:34 +0000 Subject: [Koha-bugs] [Bug 12592] Minor correction for C4::DelBiblio documentation In-Reply-To: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12592-70-EUVz5nBoLm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12592 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:09:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:09:37 +0000 Subject: [Koha-bugs] [Bug 12592] Minor correction for C4::DelBiblio documentation In-Reply-To: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12592-70-WXqWVn4TJI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12592 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29787|0 |1 is obsolete| | --- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 29797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29797&action=edit Bug 12592 - Minor correction for C4::DelBiblio documentation The function header says that DelBiblio checks to make sure there aren't any issues on any of the items. What the code does, on the other hand, is to check whether biblio has any items attached, and refuses to delete biblio if it has any. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:10:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:10:21 +0000 Subject: [Koha-bugs] [Bug 12592] Minor correction for C4::DelBiblio documentation In-Reply-To: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12592-70-zgNtFRJaBa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12592 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Passing QA right away on this very trivial documentation "one-liner". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:10:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:10:38 +0000 Subject: [Koha-bugs] [Bug 12592] Minor correction for C4::DelBiblio documentation In-Reply-To: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12592-70-IzVH0AeBSg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12592 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:11:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:11:00 +0000 Subject: [Koha-bugs] [Bug 12592] Minor correction for C4::DelBiblio documentation In-Reply-To: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12592-70-gDybO8xM0R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12592 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:17:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:17:27 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-AkTaYZV7jm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29796|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29798&action=edit Bug 8218: Follow-up for some small typos Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:18:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:18:01 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-VyI309I7kR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 --- Comment #30 from Jonathan Druart <jonathan.druart at biblibre.com> --- Thank you Marcel for your follow-up and signoff! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:20:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:20:45 +0000 Subject: [Koha-bugs] [Bug 7367] General OPAC typo omnibus In-Reply-To: <bug-7367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7367-70-2MxJDYibrJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367 --- Comment #22 from Owen Leonard <oleonard at myacpl.org> --- The last patch on this bug was pushed two years ago, so I don't see a need for it to stay open. If new typos are found new bugs can be created. I think omnibus bugs are more important in situations when multiple separate bugs are required to fix a single larger issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:20:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:20:58 +0000 Subject: [Koha-bugs] [Bug 12595] New: Finding a patron witht firstname and surname should display the patron detail Message-ID: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 Bug ID: 12595 Summary: Finding a patron witht firstname and surname should display the patron detail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Before bug 9811, if you searched for "John Doe" and only 1 patron with this firstname/surname existed, the patron detail page was displayed. Now the result lists all patrons with ( firstname=john or doe ) or ( surname=john or doe). Which is quite annoying when you expect only 1 result. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:21:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:21:09 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-aVliAblbmj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |9811 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:21:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:21:09 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9811-70-pk4y3jwD0b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12595 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:21:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:21:48 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9811-70-QQICvmBWHU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12595 | --- Comment #139 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Jonathan Druart from comment #138) > If you open a bug report, I can submit a patch. I opened bug 12595. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:21:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:21:48 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-CirSSKV16B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9811 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:22:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:22:06 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9811-70-nTrWnEtoGs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12595 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:22:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:22:06 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-LJzjLIZ8u2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9811 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:25:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:25:09 +0000 Subject: [Koha-bugs] [Bug 5998] Error "failed to submit form parsererror" and empty staged In-Reply-To: <bug-5998-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5998-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5998-70-xaa57KoSgp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5998 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Bug 8497 has been closed. Is this bug still valid? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:26:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:26:39 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-hiQAD0ZHSZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:26:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:26:42 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-BPYKqFFXz3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29799&action=edit Bug 12595: Search a patron by his/her firstname and surname Before bug 9811, if you searched for "John Doe" and only 1 patron with this firstname/surname existed, the patron detail page was displayed. Now the result lists all patrons with ( firstname=john or doe ) or ( surname=john or doe). Which is quite annoying when you expect only 1 result. Test plan: 0/ Create some patrons like: "John Doe", "Jane Doe", "John Smith". 1/ Search for "John Doe" in the patron search box 2/ Verify you got 2 results 3/ Apply the patch 4/ Search for "John Doe" in the patron search box 5/ Verify you are redirected to the right patron detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:32:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:32:14 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-MipdJ80umd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- First patch Ok, test pass On second patch, first test pass, but the other two fail :( t/db_dependent/Members.t ................... ok t/db_dependent/Members/GetAllIssues.t ...... DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`kohadev`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at t/db_dependent/Members/GetAllIssues.t line 22. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`kohadev`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at t/db_dependent/Members/GetAllIssues.t line 22. # Looks like your test exited with 255 before it could output anything. t/db_dependent/Members/GetAllIssues.t ...... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 16/16 subtests t/db_dependent/Members/GetPendingIssues.t .. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`kohadev`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at t/db_dependent/Members/GetPendingIssues.t line 22. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`kohadev`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at t/db_dependent/Members/GetPendingIssues.t line 22. # Looks like your test exited with 255 before it could output anything. t/db_dependent/Members/GetPendingIssues.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 20/20 subtest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:44:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:44:52 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10877-70-Rasq9vxiP1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 --- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> --- -1 is the standard value for 'ordered' in Koha. This feature is to process order records so the items are by definition ordered and not any other status. Additionally we grab the itemtype from the system preference, and we set the branch selects to the logged in branch. I wouldn't say it's arbitrary. If you have any suggestions on how to better handle this, I'd be open to making changes. As the author of the feature this builds on, I think you are probably in the best position to qa this patch. Kyle (In reply to Jonathan Druart from comment #21) > (In reply to Kyle M Hall from comment #18) > > Comment on attachment 29406 [details] [review] [review] > > ::: acqui/addorderiso2709.pl > > @@ +270,5 @@ > > > my @serials = $input->param('serial'); > > > my @ind_tag = $input->param('ind_tag'); > > > my @indicator = $input->param('indicator'); > > > + > > > + if ($is_order) { > > > > This is so we can pre-set the items to a notforloan value of 'ordered', and > > to preset the home and holding fields to the current branch, as well as > > pre-set the itemtype. > > Yes but you hard-code arbitrarily these values. > Why these 4 values and not others? > I would like to get another QA point of view here. > Katrin maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:56:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:56:29 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-nLzmHKeLUQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 giuseppe.angilella at ct.infn.it changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |giuseppe.angilella at ct.infn. | |it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:58:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:58:02 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-Jl0BKDCpic@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 15:58:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 13:58:06 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-frfuOhfWRz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29789|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 29800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29800&action=edit Bug 12593 - search facets die with regex error if biblio has square brackets in fields It's quite common to have [something] within facet data, and it produces following error: Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE This problem was intoduced in Bug 12151 but is trivial to fix. Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> Good catch. To test: - Created a bibliographic record, linked to an authority record (personal name). Did a search that returned the author as a facet. - Added a [ symbol to the author name. - Repeated the search => FAIL: "Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE" - Apply the patch - Retry the search => SUCCESS: No error, bracket shows correctly. Passes koha-qa.pl too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 16:03:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 14:03:13 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: <bug-12151-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12151-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12151-70-y9w2VcIin2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12593 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 16:03:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 14:03:13 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-aXeruYf8KF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |12151 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 16:09:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 14:09:30 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-YPuBqBAKNN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 16:09:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 14:09:33 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-8WOJtavokI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29799|0 |1 is obsolete| | --- Comment #2 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29801&action=edit Bug 12595: Search a patron by his/her firstname and surname Before bug 9811, if you searched for "John Doe" and only 1 patron with this firstname/surname existed, the patron detail page was displayed. Now the result lists all patrons with ( firstname=john or doe ) or ( surname=john or doe). Which is quite annoying when you expect only 1 result. Test plan: 0/ Create some patrons like: "John Doe", "Jane Doe", "John Smith". 1/ Search for "John Doe" in the patron search box 2/ Verify you got 2 results 3/ Apply the patch 4/ Search for "John Doe" in the patron search box 5/ Verify you are redirected to the right patron detail page. Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 16:10:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 14:10:46 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-Gows0vN0qI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Juhani Sepp?l? <jseppal at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |jseppal at student.uef.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 16:25:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 14:25:38 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-32N0yQrktS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 16:38:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 14:38:42 +0000 Subject: [Koha-bugs] [Bug 12590] Support deletion of biblio in svc API In-Reply-To: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12590-70-NqOwMDKs8H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12590 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 16:56:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 14:56:32 +0000 Subject: [Koha-bugs] [Bug 12596] New: Backdating returns with SpecifiyReturnDate causes fines for items not overdue! Message-ID: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Bug ID: 12596 Summary: Backdating returns with SpecifiyReturnDate causes fines for items not overdue! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When using the backdating of returns feature, an item that is not overdue is treated as being as many days overdue as it is *not* overdue. This is due to the fact that _get_chargeable_units appears to return the difference between the return date and the due date without consideration the return date being earlier than the due date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 16:57:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 14:57:26 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-MucRIWA7Pl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29802&action=edit Bug 12596 - Backdating returns with SpecifiyReturnDate causes fines for items not overdue! When using the backdating of returns feature, an item that is not overdue is treated as being as many days overdue as it is *not* overdue. This is due to the fact that _get_chargeable_units appears to return the difference between the return date and the due date without consideration the return date being earlier than the due date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 17:10:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 15:10:52 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-LJqAS3CFn7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29802|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29803&action=edit Bug 12596 - Backdating returns with SpecifiyReturnDate causes fines for items not overdue! When using the backdating of returns feature, an item that is not overdue is treated as being as many days overdue as it is *not* overdue. This is due to the fact that _get_chargeable_units appears to return the difference between the return date and the due date without consideration the return date being earlier than the due date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 17:48:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 15:48:22 +0000 Subject: [Koha-bugs] [Bug 12592] Minor correction for C4::DelBiblio documentation In-Reply-To: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12592-70-qkqhNBUH3E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12592 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Petter, and congratulations for your fist commit to Koha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 17:57:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 15:57:46 +0000 Subject: [Koha-bugs] [Bug 12590] Support deletion of biblio in svc API In-Reply-To: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12590-70-umotijg955@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12590 --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Petter, I like your patch. As far as I understood, it is used that PUT is used to update an object instead of POST. http://www.ibm.com/developerworks/webservices/library/ws-restful/ http://en.wikipedia.org/wiki/Create,_read,_update_and_delete I haven't checked what previous behaviour was in the svc endpoint, though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 18:20:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 16:20:05 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-xaXiaeDn0o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29804&action=edit Bug 12596 - Unit Test -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 18:20:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 16:20:18 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-rh3Su0ejMv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29803|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29805&action=edit Bug 12596 - Backdating returns with SpecifiyReturnDate causes fines for items not overdue! When using the backdating of returns feature, an item that is not overdue is treated as being as many days overdue as it is *not* overdue. This is due to the fact that _get_chargeable_units appears to return the difference between the return date and the due date without consideration the return date being earlier than the due date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 18:20:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 16:20:45 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-ZibPP0iWaC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 18:23:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 16:23:59 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-IwtNwMu7DU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29805|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29806&action=edit Bug 12596 - Backdating returns with SpecifiyReturnDate causes fines for items not overdue! When using the backdating of returns feature, an item that is not overdue is treated as being as many days overdue as it is *not* overdue. This is due to the fact that _get_chargeable_units appears to return the difference between the return date and the due date without consideration the return date being earlier than the due date. Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/Circulation.t 3) Note the failure 4) Apply the second patch 5) prove t/db_dependent/Circulation.t 6) Note there are no failures -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 18:26:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 16:26:01 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-iBzq94U3Uv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 18:26:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 16:26:07 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-eh25KtXKJx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 18:26:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 16:26:19 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-SEcUDskKTe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 18:59:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 16:59:20 +0000 Subject: [Koha-bugs] [Bug 9339] Intranet translation bar display en-GB when en is selected In-Reply-To: <bug-9339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9339-70-FLmIfIR2XY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9339 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- There are some visual bugs with the language chooser in the staff client at the moment but I don't see this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 19:04:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 17:04:07 +0000 Subject: [Koha-bugs] [Bug 12597] New: Give better visual indication of currently-selected language in the staff client Message-ID: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Bug ID: 12597 Summary: Give better visual indication of currently-selected language in the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org I think in previous versions we did better at indicating which of multiple active translations is currently selected. I would like to improve the style of the language menu in the footer to better highlight the current selection. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 19:38:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 17:38:42 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: <bug-5620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5620-70-eqtZ9g5izd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 --- Comment #4 from Eric B?gin <eric.begin at inLibro.com> --- Kyle, any plan to work on this feature ? We have something similar working for 3.14 that we could adapt for the master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 20:21:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 18:21:03 +0000 Subject: [Koha-bugs] [Bug 12598] New: Allow tools/import_borrowers.pl to be used from the command line. Message-ID: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Bug ID: 12598 Summary: Allow tools/import_borrowers.pl to be used from the command line. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Many libraries have the need to automate the importing of patrons into Koha from external sources. It would be nice if we could use Koha's own import_borrowers.pl to do that from the command line, in the same way as tools/export.pl can be used from both the staff interface and the command line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 20:23:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 18:23:21 +0000 Subject: [Koha-bugs] [Bug 12598] Allow tools/import_borrowers.pl to be used from the command line. In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-vJZzFrju9P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29807&action=edit Bug 12598 - Allow tools/import_borrowers.pl to be used from the command line. Many libraries have the need to automate the importing of patrons into Koha from external sources. It would be nice if we could use Koha's own import_borrowers.pl to do that from the command line, in the same way as tools/export.pl can be used from both the staff interface and the command line. Test Plan: 1) Apply this patch 2) Test importing patrons from staff interface, no changes should be noted. 3) Test importing patrons from command line, options are availble with --help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 20:31:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 18:31:07 +0000 Subject: [Koha-bugs] [Bug 12598] Allow tools/import_borrowers.pl to be used from the command line. In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-pb24JAzDUy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29807|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29808&action=edit Bug 12598 - Allow tools/import_borrowers.pl to be used from the command line. Many libraries have the need to automate the importing of patrons into Koha from external sources. It would be nice if we could use Koha's own import_borrowers.pl to do that from the command line, in the same way as tools/export.pl can be used from both the staff interface and the command line. Test Plan: 1) Apply this patch 2) Test importing patrons from staff interface, no changes should be noted. 3) Test importing patrons from command line, options are availble with --help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 20:32:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 18:32:09 +0000 Subject: [Koha-bugs] [Bug 12598] Allow tools/import_borrowers.pl to be used from the command line. In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-wavHmd52dO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 20:35:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 18:35:33 +0000 Subject: [Koha-bugs] [Bug 12598] Allow tools/import_borrowers.pl to be used from the command line. In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-ovZWHb4IAY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29808|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29809&action=edit Bug 12598 - Allow tools/import_borrowers.pl to be used from the command line. Many libraries have the need to automate the importing of patrons into Koha from external sources. It would be nice if we could use Koha's own import_borrowers.pl to do that from the command line, in the same way as tools/export.pl can be used from both the staff interface and the command line. Test Plan: 1) Apply this patch 2) Test importing patrons from staff interface, no changes should be noted. 3) Test importing patrons from command line, options are availble with --help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 17 22:00:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 20:00:26 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-iWn5HVeFnl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #33 from Chris Cormack <chris at bigballofwax.co.nz> --- The 3rd patch does not apply cleanly, a couple of conflicts. The first 2 apply cleanly and I am happy to sign them off, I wont upload them yet, or it will mess up the order, but if you can rebase, Im happy to try signing off the rest again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 01:06:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 23:06:53 +0000 Subject: [Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks In-Reply-To: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12477-70-heTdjxC0xl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29810&action=edit MARC21 bibliographic XML version Sample MARC21 as XML. There are a file for tags and another for subtags. Also there are complete and simple ones. Complete have all attributes, simple ones with only marc specific values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 01:44:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jul 2014 23:44:22 +0000 Subject: [Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks In-Reply-To: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12477-70-SxGShUUGd2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to David Cook from comment #3) > Sorry for my delayed response! Competing priorities... No problem :) This task will take some time > I'm happy to go with XML. I suppose my only reservations are about the > brittleness of XML and processing time involved in parsing a huge XML file. > I suppose the brittleness shouldn't be a factor...we could validate the XML > before committing it and parsing errors are very loud so there probably is > no danger there. As for processing time...it's not like installing or > updating frameworks would be a frequent operation so lengthy processing time > might not matter (if it is even a thing). I used XML::Simple to load and build sql files from the attached examples. It does not take to much time, and anyway is something to use at install time or when updating frameworks, not frequent tasks :) > > Now that I think about it... are "liblibrarian" and "libopac" the only > fields that need to be translated? Yes, and in EN and ES they are the same text. I wonder if there are libraries using different labels for opac/staff In french UNIMARC frameworks I found that libopac is shortened or empty in most cases. > marc_tag_structure: > 1) MARC: tagfield, liblibrarian, libopac, repeatable > 2) Koha: mandatory, authorised_value, frameworkcode In this case authorised_value... is not used, or can't be used. FW editor allows to set this to an authorised value, supposedly to list allowed values for indicators, but this is not used on editor (there is another bug that mentions this) > marc_subfield_structure: > 1) MARC: tagfield, tagsubfield, liblibrarian, libopac, repeatable, maxlength > 2) Koha: mandatory, kohafield, tab, authorised_value, authtypecode, > value_builder, isurl, hidden, frameworkcode, seealso, link, defaultvalue In this case seealso is not used anymore (or that is implied by http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007#c3) > > Oooh. Brain wave...we could use XSLT! We'd have a XML file containing the > MARC specification data. Then we pass that through an XSLT which adds the > relevant "Koha" data. > > Think about it...in most cases those "Koha" fields are "null" or "". The > most important fields are probably "tab" and "hidden". If we use defaults > for most cases, but define exceptions in the XSLT on a field/subfield and > framework basis...that would be much easier to maintain! > > I don't know if that paragraph makes sense to anyone else...but I like this > idea. It's easier to maintain exceptions rather than a whole comprehensive > list, which can be dynamically generated. > > Bernardo, if you could post an up-to-date XML file with that MARC data I > mentioned above, I would be willing to take a look at creating a XSLT that > adds the relevant Koha data and produces a final "Koha MARC framework" XML > document in the end. > On the attached file there are XMLs for tags and subtags, with/without Koha proper fields. They are at least well formed (xmllint --noout file.xml) There's another thing to take into account: when MySQL 5.6 arrives to new debian/ubuntu versions, we'll have a problem. 5.6 client complains a lot to be used on CLI with password as argument, so Koha installer fails miserably because it uses 'mysql' command to load mandatory/optional values in database. Another reason to find other way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 02:23:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 00:23:08 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-4UTusYSPGk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 --- Comment #16 from David Cook <dcook at prosentient.com.au> --- So I have 5 records: "A", "B", "C", "D", and "E". [As of this writing, all of them return 1 record except D which returns all 5...should've picked a different letter. Oh well.] Every one of them has the value "test" in them as well. -- TEST: @and "a" "b" = No records "a" and "b" -- TEST: @and @or "a" "b" "c" = No records [no] ("a" and "b") or "c" ["a" and "b" = 0. "c" = 1.] [?] "a" and ("b" or "c") ["a" and "b" = 0. "a" and "c" = 0.] [?] ("a" or "b") and "c" ["a" and "c" = 0. "b" and "c" = 0.] [no] "a" or ("b" and "c") ["a" = 1. "b" and "c" = 0.] -- TEST: @and @or "a" "b" "test" = 2 records ("A","B") [?] ("a") or ("b" and "test") ["a" = 1. "b" and "test" = 1. Grand total of 2. [?] ("a" or "b") and "test" ["a" and "test" = 1. "b" and "test" = 1. Grand total of 2. [no] "a" and ("b" or "test") ["a" and "b" = 0. "a" and "test" = 5.] [no] ("a" and "b") or "test" ["a" and "b" = 0. "test" = 5.] -- TEST: @and @or "test" "B" "C" = 1 record ("C") [no] ("test" and "B") or "C" ["test and "B" = 1. "C" = 1. Grand total 2 records of "B" and "C"] [no] "test" and ("B" or "C") ["test" and "B" = 1. "test" and "C" = 1. Grand total 2 records of "B" and "C"] [YES] ("test" or "B") and "C" ["test" and "C" = 1. "B" and "C" = 0.] [no] "test" or ("B" and "C") ["test" = 5. "B" and "C" = 0] -- So...it looks like queries are expanded from the inside out... @and @or "test" "B" "C" ("test" or "b") and "C" Let's do some more tests to double-check this... -- TEST: @not "test" "b" = 4 records ("A","C","D",E") "test" and not "b" -- TEST: @not @or "b" "test" "b" = 4 records ("A","C","D","E") ("b" or "test") and not "b" -- TEST: @not @or "b" "c" "b" = 1 record ("C") ("b" or "c") and not "b" -- TEST: @not @or @or "b" "c" "a" "b" = 2 records ("A","C") (("b" or "c") or "a") and not "b" -- TEST: @not @or @or "b" "c" "a" "e" = 3 records ("A","B","C") (("b" or "c") or "a") and not "e" -- TEST: @not @or @and "b" "c" "a" "e" = 1 record ("A") (("b" and "c") or "a") and not "e" ["b" and "c" = 0. "a" = 1". Not "E"..."A" isn't "E" so it goes through. -- TEST: @not @or @and "b" "c" "a" "a" (("b" and "c") or "a") and not "a" ["b" and "c" = 0. "a" = 1". Not "A"..."A" is "A" so it doesn't make it to the result set.] -- TEST: @or @not @or "b" "c" "c" "e" = 2 records ("B","E") (("b" or "c") and not "c") or "e" ["b" = 1. "c" = 1. But not C...so only B. Or "E". Ergo, "B","E" returned) -- TEST: @or @not "test" "c" "e" = 4 records ("A","B","D","E") ("test" and not "C") or "e" -- TEST: @or @not "test" "c" "c" = 4 records ("A","B","C","D","E") ("test" and not "C") or "C" -- TEST: @not "test" @or "c" "e" = 3 records ("A","B","D") ("test") and not ("c" or "e") -- So...it appears that the Zebra parser takes the right-most operator and puts it after the first operand it encounters to its right... So...let's look at my query again... @not @or @or @or @attr 1=1016 @attr 5=1 @attr 4=6 "e" @attr 9=75 @attr 2=102 @attr 5=1 @attr 4=6 "e" @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "e" @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "e" @attr 1=9011 1 This would become (((@attr 1=1016 @attr 5=1 @attr 4=6 "e" @or @attr 9=75 @attr 2=102 @attr 5=1 @attr 4=6 "e") @or @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "e") @or @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "e") @not @attr 1=9011 1 That should be OK... That means that it will perform 5 sub-queries...4 of them will have OR between them...which produces the result set we want... Then the final sub-query returns a result set for records we don't want, and it acts as a filter to make sure that no suppressed records get through. Voila! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 02:25:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 00:25:58 +0000 Subject: [Koha-bugs] [Bug 12590] Support deletion of biblio in svc API In-Reply-To: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12590-70-L6LdWVMfZE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12590 --- Comment #4 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> --- You're right Tom?s, PUT would be the appropriate HTTP verb to use when updating a resource. So a better layout of the /svc endpoint could be: GET /svc/biblio/{biblionr} -> fetch record POST /svc/biblio -> create record PUT /svc/biblio/{biblionr} -> update record However, that would be a breaking change for people allready using POST /svc/new_bib for creating records, and POST /svc/biblio/{biblionr}?for updating records. Do you know how many actually are using the svc API, and how? Cait mentioned on IRC they use it for ILL. Incidentaly, if there is a momentum for expanding Koha's HTTP APIs, I think Biblibres koha-restfull is a much better basis to build on: http://git.biblibre.com/biblibre/koha-restful/tree/master It's well structured, easily extendable, has clean code and tests. I asked Joubo about their plans for it, and he said they don't plan for it to get included into Koha master (but they use it themselves and will continue to maintain it) IMO it would be an interesting direction for Koha to go if it would expose most of the functionality through REST APIs, and make the templates use the APIs, instead of calling functions directly before rendering, or even worse, custom raw sql queries.. The benefits of this apprach would be: * More content could be fetched asynchronously (we allready see a push in this direction, with recent ajax+datatables enhancements) * Because of this, pages would load faster (even if not all data is populated immideatly) and, more importantly, the browser could cache many of the requests, resulting in less trips to the database. * I also think that this approach makes sense from an architectural point of view, and could lead to better structured and more maintainable code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 02:42:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 00:42:04 +0000 Subject: [Koha-bugs] [Bug 12590] Support deletion of biblio in svc API In-Reply-To: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12590-70-ERWsXGw14x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12590 Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 03:32:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 01:32:32 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: <bug-4969-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4969-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4969-70-yBLXsoAelg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #21 from Liz Rea <liz at catalyst.net.nz> --- We still need a "hide inactive vendors" function. If vendors cannot be deleted because they have associated basket/order/invoices, then they need to be able to be hidden when they are no longer in use. Another option would be to allow deletion of vendors but only with a superlibrarian account and 4x levels of confirmation (i.e. confirm you want to delete all invoices for X vendor (show them). Now confirm you want to delete all orders for this vendor (show them). Now confirm you want to delete all baskets for this vendor (show them). (accept all three) Delete this vendor?) Would probably also need a warning that doing this will upset acquisitions history. All of that seems like a lot of work to simply achieve "my list of vendors is too long and I only use 4 of these 150 vendors I have in my system" so probably better to just do something useful with the inactive flag. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 03:49:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 01:49:22 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-7tVK93QPDA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 --- Comment #17 from David Cook <dcook at prosentient.com.au> --- If I want to check my Koha query again... -- TEST: @not @or @or @or "a" "b" c" "e" "b" = 3 records("A","C","E") ((("a" or "b") or "c") or "e") and not "b" -- Ok...now that we've got this basic concept down...let's try something more advanced. Let's consider the parsing logic again... prefixQuery("@and complete @or dinosaur pterosaur"); CCLQuery("complete and (dinosaur or pterosaur)"); (In hindsight, the above example quite clearly illustrates how operators are applied to operands. The tests helped clarify that though...at least in my mind and hopefully for anyone else reading this who didn't understand before.) So let's look at the grammar again (http://www.indexdata.com/yaz/doc/tools.html#PQF): "simple ::= result-set | term." So a simple query may just be a single term like "A". "complex ::= operator query-struct query-struct." A complex query can have an operator and two query structures...but a query structure is not the same thing as just a term. "query-struct ::= attr-spec | simple | complex | '@term' term-type query" A query structure can itself be a complex query! So we should be able to join multiple complex queries together to form a new complex query. -- TEST: @or @or "a" "b" @or "c" "e" = 4 records ("A","B","C","E") ("a" or "b") or ("c" or "e") -- TEST: @not "test" @or "c" "e" = 3 records ("A","B","D") ("test") and not ("c" or "e") -- So let's add some more complex data... I'm going to add "bull" to "B". -- TEST: @not @or "a" @or @and "b" "bull" "c" "a" = 2 records ("B","C") ("a" or ("b" and "bull") or "c") and not "a" -- TEST: @or "a" @or @and "b" "bull" "c" = 3 records ("A","B","C") ("a" or ("b" and "bull") or "c") -- So something like the following is probably valid in CCL... (kw,wrdl,rt=e or kw,wrdl,rt=e or kw,wrdl,rt=e or kw,wrdl,rt=e) But I bet when it's parsed into RPN it is broken up into pairs like so: (((kw,wrdl,rt=e or kw,wrdl,rt=e) or kw,wrdl,rt=e) or kw,wrdl,rt=e) Because there has to be an order of operations... For instance ("b" and "bull" or "c") would probably be parsed as (("b" and "bull") or "c") rather than ("b" and ("bull" or "c")). -- TEST: (After using "querytype ccl2rpn" and "set_cclfile /koha/etc/zebradb/ccl.properties" in yaz-client) ("b" and "bull" or "c") = 2 records ("B","C") (("b" and "bull") or "c") -- TEST: ("b" and ("bull" or "c")) = 1 record ("B") ------------ So...I'm sure that was more than anyone ever wanted to know about CCL and PQF syntax. But...it proves that my solution will work. Ideally, we should be adding OpacSuppression when the query is being built, rather than after the fact. Ah, we do pass $query_type back from buildQuery. While it's usually null, if it is a PQF query, it will say "pqf". That means it won't be too hard to change our current code to work with QP. At the moment, I'm inclined to agree with Galen about QueryParser not being able to handle negation...although I'll have to look some more. That said, we could add OpacSuppression into the QP query building without requiring it to parse it from a query we put in, so it might not matter too much. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 04:43:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 02:43:21 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-10rrV5C7r4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 --- Comment #18 from David Cook <dcook at prosentient.com.au> --- Ah, I believe that Galen was incorrect. QueryParser indeed does appear to handle negation. QueryParser: [Negation via query_plan.pm] (test) && !(suppress:1) OR (test) && -(suppress:1) OR [Negation via node.pm] (test) && (suppress:!"1") OR (test) && (suppress:-"1") (N.B. When negating at the "node" level, you have to wrap the 1 in quotes to treat it as a phrase or else the ! or - appear to be parsed as part of the operand.) CCL: (test) not (suppress:1) If you think about it, "not" really is "and not", so CCL's "not" is equivalent to "&& !" in QP. ------ Ahh...so I've finally read through Martin's patch. tl;dr Martin, if you change the following: $query = "$query -suppress:1"; to: $query = "($query) && -(suppress:1)"; It should work. [Note: If we wanted to add other fields to disallow, we could throw them inside that disallowed group when using QP as well...] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 07:24:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 05:24:03 +0000 Subject: [Koha-bugs] [Bug 12438] Bad encoding in acquisition basket In-Reply-To: <bug-12438-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12438-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12438-70-DpnYMOQP1F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #8 from David Cook <dcook at prosentient.com.au> --- Beautiful! This patch fixes the problem that I was having! It's worth mentioning that we only had this problem on a Debian Squeeze server. When we dumped the data and loaded it into a Koha instance on an OpenSuse server, we didn't get the <?> replacing the diacritics. It worked perfectly. So...not really sure what was going on there, but I'm just happy at this point to have a fix of the symptom. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 08:46:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 06:46:51 +0000 Subject: [Koha-bugs] [Bug 12599] New: IndependentBranches Holes Message-ID: <bug-12599-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12599 Bug ID: 12599 Summary: IndependentBranches Holes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When IndependentBranches is turned on, you cannot find patrons from other branches using the search interface. However, you can change the argument for the "member" parameter, and access patrons from other branches in this way. That said, you still can't "Edit" or "Delete" patrons from other branches. "Edit" will kick you out of the record and return you to the search screen, while "Delete" tells you that you're being naughty. However... You "can": 1) change their password 2) print summaries 3) renew their registration 4) set permissions 5) export today's checked out barcodes 6) manage fines 7) check things out to them (from the Checkout tab and possibly if there is a perm/preference for checking things out to people from different branches...) 8) view circulation history && statistics 9) view purchase suggestions (and fill out the form...although saving it doesn't appear to do anything) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 08:54:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 06:54:41 +0000 Subject: [Koha-bugs] [Bug 12599] IndependentBranches Holes In-Reply-To: <bug-12599-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12599-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12599-70-tOXrPFbAP5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12599 --- Comment #1 from David Cook <dcook at prosentient.com.au> --- You can also view the checkout history for all items/patrons in the staff client catalogue via "/cgi-bin/koha/catalogue/issuehistory.pl" You can also see all holds at "/cgi-bin/koha/reserve/request.pl". Here you can modify/delete holds for patrons from other branches. You can also change the "Lost", "Damaged" and "Withdrawn" status via "/cgi-bin/koha/catalogue/moredetail.pl" [Note: I have no intention at the moment of fixing any of these problems, as we don't tend to use IndependentBranches. I thought it better to log the issue rather than to leave it be silent though.] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 08:59:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 06:59:58 +0000 Subject: [Koha-bugs] [Bug 12599] IndependentBranches Holes In-Reply-To: <bug-12599-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12599-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12599-70-AKJgCl3dvB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12599 --- Comment #2 from David Cook <dcook at prosentient.com.au> --- I haven't looked at cataloguing/authorities much. Nor have I looked at lists, acquisitions, or serials. Don't know about reports, administration, or tools. They might be harder to lock down on a per branch basis. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 10:17:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 08:17:22 +0000 Subject: [Koha-bugs] [Bug 6567] adding and removing advanced search options In-Reply-To: <bug-6567-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6567-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6567-70-E4r1SnyiLD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6567 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 10:18:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 08:18:08 +0000 Subject: [Koha-bugs] [Bug 5447] Limit search to serials / continuing resources In-Reply-To: <bug-5447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5447-70-JkQcLVmLzW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5447 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 10:29:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 08:29:39 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working! In-Reply-To: <bug-11677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11677-70-d6DIZDbP3X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- We have the same issue when making a keyword search, then faceting by branch, then limiting by availability. Limiting by availability currently seems to display only results for which all items are available, even if one item is checked out, the whole result is filtered. What is needed is a feature to limit by availability for a certain branch, not just general availability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 10:32:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 08:32:51 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-fGaLwoFB26@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 10:42:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 08:42:41 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-f0m36OGZ14@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6567 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 10:42:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 08:42:41 +0000 Subject: [Koha-bugs] [Bug 6567] adding and removing advanced search options In-Reply-To: <bug-6567-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6567-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6567-70-zIevdMiFoP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6567 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9043 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 10:49:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 08:49:58 +0000 Subject: [Koha-bugs] [Bug 12600] New: Duplicated use statement in Search.pm Message-ID: <bug-12600-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Bug ID: 12600 Summary: Duplicated use statement in Search.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org There are two use C4::Charset statements in C4::Search.pm one buried deep in the code for no reason it should be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:02:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:02:04 +0000 Subject: [Koha-bugs] [Bug 12600] Duplicated use statement in Search.pm In-Reply-To: <bug-12600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12600-70-LUu0z2sQ8E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 29811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29811&action=edit Proposed patch Test: search,pm still compiles after patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:03:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:03:00 +0000 Subject: [Koha-bugs] [Bug 12600] Duplicated use statement in Search.pm In-Reply-To: <bug-12600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12600-70-tiOkxGauC8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |trivial --- Comment #2 from Colin Campbell <colin.campbell at ptfs-europe.com> --- amended to flag this as a trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:12:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:12:11 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-tzUGYZgGas@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aanitah at gmail.com --- Comment #47 from Jonathan Druart <jonathan.druart at biblibre.com> --- *** Bug 6567 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:12:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:12:11 +0000 Subject: [Koha-bugs] [Bug 6567] adding and removing advanced search options In-Reply-To: <bug-6567-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6567-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6567-70-vVxAN9C3Oi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6567 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- *** This bug has been marked as a duplicate of bug 9043 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:39:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:39:40 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-BnpFciitI6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #47 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:40:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:40:15 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-wesjjPqa28@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29754|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:40:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:40:22 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-oUSpTCYPK1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29755|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:40:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:40:27 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-9x9PIIJtWN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29756|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:40:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:40:33 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-NXQvnt0WL0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:40:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:40:39 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-tcqk9RJe77@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29780|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:40:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:40:44 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-JTFxuF92n8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29788|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:40:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:40:52 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-5iyzmvUsZn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29790|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:41:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:41:03 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-Bl7h2jvpN4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29791|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:41:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:41:16 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-BevOJ4fI6O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #48 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29812&action=edit Bug 6536: Dbrev for Z3950 search improvements Adjusts table z3950servers: Drops unused columns icon, description and position. Moves id column to first position. Renames name to servername, and type to servertype. (This is not only more clear but may eliminate some problems too with DBIx.) Changes recordtype from varchar(45) to enumeration with two members. [The upgrade replaces unknown record types with biblio, although it is very unlikely to find such records.] Adds SRU as servertype enumeration member. Removes opensearch, since it is not used/supported. [The upgrade replaces unknown server types with zed (z3950) (in exceptional cases).] Adds new columns: sru_options, sru_fields, add_xslt. Test plan: Run database update via webinstaller. Check your z3950servers table. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:41:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:41:20 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-ClO3kbQFbG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #49 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29813&action=edit Bug 6536: Update DBIx schema of z3950servers for testing This patch adjusts the DBIx schema file for z3950servers table. This can be used for testing this set of patches. When the report is pushed, the RM should update the DBIx schema. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:41:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:41:24 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-qwXwRUMRct@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #50 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29814&action=edit Bug 6536: Add a form for SRU Field mapping This form allows you to enter the match between the standard names of the Z3950 search fields and the field names for a specific SRU server. This patch only adds the form; it will be used in a subsequent patch. Test plan: Not needed, but you can call the form by constructing a URL like: cgi-bin/koha/admin/sru_modmapping.pl?mapping=title=1,author=2 You should see the form with title and author filled. Note that you cannot save the information yet. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:41:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:41:28 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-uTCGazs2Ba@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #51 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29815&action=edit Bug 6536: SRU servers administration This patch makes adjustments in admin/z3950servers in order to insert, edit and delete SRU server records. Test plan: Add, edit, copy and delete SRU server. Check if adding, editing, copying and deleting Z3950 servers still works. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:41:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:41:32 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-kj7cFPDgD2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #52 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29816&action=edit Bug 6536: Adjustments for servername and servertype Replaces name by servername, type by servertype for running Z3950 search. Limit search scripts to zed (z3950) servers until sru is supported. Test plan: Perform a Z3950 search in Cataloguing and Acquisition. Verify that it still works as it did. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:41:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:41:36 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-RUSAGIMUMG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #53 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29817&action=edit Bug 6536: Include SRU searching in Breeding.pm This patch makes it possible to include SRU servers in Z3950 search. It adjusts the Z3950Search routine in Breeding module. It also replaces SQL code with DBIx statements in Breeding.pm/Z3950Search and the associated scripts z3950search.pl in cataloguing and acqui. Test plan: Verify if a normal Z3950 search still works in cataloging/acqui. Add a SRU target. (You could just use Koha's port 9998.) Define sru_options like sru=get. Use that target in a Z3950 search in cataloging and acqui. (Import.) Test sru_fields translation by comparing search results between various settings for some of the fields. For instance, leave title empty and after that set it to the title field of your SRU target. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:41:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:41:41 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-IQrHshyoNo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #54 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29818&action=edit Bug 6536: Add XSLT transformation on Z3950 search results Use the stylesheets listed in field add_xslt of z3950servers to transform search results of Z3950/SRU search. Additionally, the template has been changed to make more error messages (or warnings) visible when displaying results. Until now, error message were shown in the results table and when connection errors occurred, no results were displayed at all. Test plan: Create some stylesheets (or see the sample patch on bug 6536). Add these stylesheets to some Z3950/SRU servers. Do Z3950 search and verify the transformations. Do a search with 2 targets; make one target fail (by manipulating its server data). Do you see the connection error and the results for the other target? Generate a XSLT error by modifying one stylesheet. Check search results. You should see warnings. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 11:41:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 09:41:45 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-2txHojRO0E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #55 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 29819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29819&action=edit Bug 6536: Two simple test XSLT files You could use Add901.xsl or Set003ABC.xsl in field add_xslt of table z3950servers when testing this report. Set003ABC will change field 003 into ABC. And Add901 adds a tag 901. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:26:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:26:54 +0000 Subject: [Koha-bugs] [Bug 12601] New: aqorders.budget_id should be a foreign key Message-ID: <bug-12601-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12601 Bug ID: 12601 Summary: aqorders.budget_id should be a foreign key Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org When creating an order, the fund value is mandatory but the DB structure does not show this constraint. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:27:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:27:31 +0000 Subject: [Koha-bugs] [Bug 12602] New: Claim counter in serials Message-ID: <bug-12602-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12602 Bug ID: 12602 Summary: Claim counter in serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: amitddng135 at gmail.com Reporter: amitddng135 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Claim counter in serials like late orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:29:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:29:14 +0000 Subject: [Koha-bugs] [Bug 12601] aqorders.budget_id should be a foreign key In-Reply-To: <bug-12601-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12601-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12601-70-xWCnIdOKxT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12601 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:29:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:29:14 +0000 Subject: [Koha-bugs] [Bug 5334] add explicit foreign key constraints In-Reply-To: <bug-5334-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5334-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5334-70-PFHh2AdmFf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |12601 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- And aqorders.budget_id, see bug 12601. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:31:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:31:21 +0000 Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order In-Reply-To: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4456-70-nnwVe5mL5D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4960 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:31:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:31:21 +0000 Subject: [Koha-bugs] [Bug 4960] No way to enter custom purchase order number In-Reply-To: <bug-4960-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4960-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4960-70-kxPWKqXoBz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4960 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4456 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:32:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:32:12 +0000 Subject: [Koha-bugs] [Bug 11010] Useless column purchaseordernumber in aqorders table In-Reply-To: <bug-11010-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11010-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11010-70-WgYpKJzAXE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |INVALID --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Since bug 4456 will use this field, this bug report is invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:41:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:41:51 +0000 Subject: [Koha-bugs] [Bug 12601] aqorders.budget_id should be a foreign key In-Reply-To: <bug-12601-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12601-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12601-70-Stqxf11yML@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12601 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:41:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:41:54 +0000 Subject: [Koha-bugs] [Bug 12601] aqorders.budget_id should be a foreign key In-Reply-To: <bug-12601-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12601-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12601-70-IFsp12d18F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12601 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29820&action=edit Bug 12601: Add a foreign key for aqorders.budget_id When creating an order, the fund value is mandatory but the DB structure does not show this constraint. The aqorders.budget_id field should be linked to aqbudgets.budget_id. The updatedatabase.pl (entry 3.01.00.077) commented this constraint, certainly for a retro compatibility reason. Actually I found some cases (in production) where aqorders.budget_id is set to "0". To add this constraint, we should add a temporary fund to linked orphan orders. Test plan: 0/ Verify it is not possible to create an order not linked to a fund via the Koha interface. 1/ Using your SQL CLI (or equivalent), create or update 1+ orders and set "0" in the budget_id field. 2/ Execute the updatedabase script. 3/ Verify that your order is linked to a new fund (which is linked to a new budget). 4/ Verify the constraint has correctly been added (show create table aqorders). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:42:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:42:32 +0000 Subject: [Koha-bugs] [Bug 12601] aqorders.budget_id should be a foreign key In-Reply-To: <bug-12601-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12601-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12601-70-eDqsheNJ4M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12601 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Architecture, internals, | |and plumbing Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:42:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:42:38 +0000 Subject: [Koha-bugs] [Bug 12601] aqorders.budget_id should be a foreign key In-Reply-To: <bug-12601-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12601-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12601-70-ajhVncZg83@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12601 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:50:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:50:46 +0000 Subject: [Koha-bugs] [Bug 11007] Useless column cancelledby in aqorders table In-Reply-To: <bug-11007-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11007-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11007-70-Al44cMhlTY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:50:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:50:50 +0000 Subject: [Koha-bugs] [Bug 11007] Useless column cancelledby in aqorders table In-Reply-To: <bug-11007-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11007-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11007-70-KxMsfNF4pO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29821&action=edit Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:50:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:50:58 +0000 Subject: [Koha-bugs] [Bug 11008] Useless column supplierreference in aqorders table In-Reply-To: <bug-11008-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11008-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11008-70-NBAN52J5iy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11007 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:50:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:50:58 +0000 Subject: [Koha-bugs] [Bug 11007] Useless column cancelledby in aqorders table In-Reply-To: <bug-11007-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11007-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11007-70-AvD98pHlv9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:51:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:51:13 +0000 Subject: [Koha-bugs] [Bug 11007] Useless column cancelledby in aqorders table In-Reply-To: <bug-11007-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11007-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11007-70-JZblGqDNQo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:55:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:55:10 +0000 Subject: [Koha-bugs] [Bug 11008] Useless column supplierreference in aqorders table In-Reply-To: <bug-11008-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11008-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11008-70-JRW5VVnwRZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29822&action=edit Bug 11008: Drop column aqorders.supplierreference It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep supplierreference should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:55:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:55:06 +0000 Subject: [Koha-bugs] [Bug 11008] Useless column supplierreference in aqorders table In-Reply-To: <bug-11008-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11008-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11008-70-Cxcan06mbQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:55:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:55:24 +0000 Subject: [Koha-bugs] [Bug 11008] Useless column supplierreference in aqorders table In-Reply-To: <bug-11008-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11008-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11008-70-BHqZXGThdF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 12:56:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 10:56:01 +0000 Subject: [Koha-bugs] [Bug 11007] Useless column cancelledby in aqorders table In-Reply-To: <bug-11007-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11007-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11007-70-5tSumOjkfl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29821|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29823&action=edit Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 13:25:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 11:25:07 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-BBFLdIkb96@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Tom?s Cohen Arazi from comment #3) > To test: > - Created a bibliographic record, linked to an authority record (personal > name). Did a search that returned the author as a facet. > - Added a [ symbol to the author name. > - Repeated the search > => FAIL: "Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE" I didn't reproduce neither. When I relaunch the search, the facet does not appear anymore in the facet list, that's all. I didn't get any error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 13:32:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 11:32:50 +0000 Subject: [Koha-bugs] [Bug 12582] Control of branch displayed in search results linked to HomeOrHoldingBranch In-Reply-To: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12582-70-VDdTXnTbT5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12582 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:01:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:01:02 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-RQQguhVYC4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:01:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:01:04 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-RkECPRkKmK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29800|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29824&action=edit [PASSED QA] Bug 12593 - search facets die with regex error if biblio has square brackets in fields It's quite common to have [something] within facet data, and it produces following error: Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE This problem was intoduced in Bug 12151 but is trivial to fix. Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> Good catch. To test: - Created a bibliographic record, linked to an authority record (personal name). Did a search that returned the author as a facet. - Added a [ symbol to the author name. - Repeated the search => FAIL: "Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE" - Apply the patch - Retry the search => SUCCESS: No error, bracket shows correctly. Passes koha-qa.pl too. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:08:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:08:54 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-k26cQXE5wO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:08:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:08:57 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-7JkM75tVQu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29801|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29825&action=edit [PASSED QA] Bug 12595: Search a patron by his/her firstname and surname Before bug 9811, if you searched for "John Doe" and only 1 patron with this firstname/surname existed, the patron detail page was displayed. Now the result lists all patrons with ( firstname=john or doe ) or ( surname=john or doe). Which is quite annoying when you expect only 1 result. Test plan: 0/ Create some patrons like: "John Doe", "Jane Doe", "John Smith". 1/ Search for "John Doe" in the patron search box 2/ Verify you got 2 results 3/ Apply the patch 4/ Search for "John Doe" in the patron search box 5/ Verify you are redirected to the right patron detail page. Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:15:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:15:46 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12542-70-AVWsaiPqzb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- > This is a piecemeal fix for a problem which really deserves a > centralized solution, but at least it gets us back to consistency for > the moment. I agree. I would be much better in the long run to merge circ-menu.inc and circ-menu.tt, and pass into it a borrower dbic object ( or even have it get that via a TT plugin from just the borrowernumber ). Why do we have two variations of circ-menu? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:27:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:27:32 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12542-70-XUzQ8Xh06t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:27:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:27:35 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12542-70-EJCUaUmUk3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29700|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29826&action=edit [PASSED QA] Bug 12542: Tabs inconsistency in different circ-menu.inc uses Differences between circ-menu.tt and circ-menu.inc always crop up when a new menu item is added--usually only to circ-menu.inc as happened with Bug 9261. Other sidebar differences are present due to differences in the patron data passed by various patron-related script to their templates. This patch also irons out some of these inconsistencies. To test, apply the patch and check out to a patron whose record has more than just basic data: othername, country, patron attributes, street number, road types, etc. View the following pages and compare the patron data and visible tabs to confirm that they match: circ/circulation.pl?borrowernumber=X members/boraccount.pl?borrowernumber=X members/files.pl?borrowernumber=X members/mancredit.pl?borrowernumber=X members/maninvoice.pl?borrowernumber=X members/member-flags.pl?member=X members/member-password.pl?member=X members/moremember.pl?borrowernumber=X members/notices.pl?borrowernumber=X members/pay.pl?borrowernumber=X members/paycollect.pl?borrowernumber=X members/purchase-suggestions.pl?borrowernumber=X members/readingrec.pl?borrowernumber=X members/routing-lists.pl?borrowernumber=X members/statistics.pl?borrowernumber=X tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&src=circ&object=X The only difference I've found which is not fixed by this patch is the display of extended patron attributes in the sidebar of moremember.pl. This is a piecemeal fix for a problem which really deserves a centralized solution, but at least it gets us back to consistency for the moment. Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> Going through all tabs shows consistency is back. A mid term solution should implement this in a centralized way. Great job Owen! No koha-qa errors btw. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:43:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:43:33 +0000 Subject: [Koha-bugs] [Bug 5502] Patron card category search field should be menu In-Reply-To: <bug-5502-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5502-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5502-70-wAd2K7XSQk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5502 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:43:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:43:36 +0000 Subject: [Koha-bugs] [Bug 5502] Patron card category search field should be menu In-Reply-To: <bug-5502-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5502-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5502-70-EMUAO42qB4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5502 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29688|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29827&action=edit [PASSED QA] Bug 5502 - Patron card category search field should be menu When searching for patrons to add to a patron card creator batch there is a text input field for submitting a patron category. This should be a dropdown menu. This patch corrects it. To test, go to Tools -> Patron card creator and click "New batch." - Click the "Add item(s)" button. - Confirm that in the Patron search pop-up window there is a dropdown menu populated with existing patron categories. - Confirm that searches limited by patron category return correct results. - Confirm that the correct patron category is automatically preselected after performing a search limited by category. - Confirm that reordering the table of search results works correctly. Signed-off-by: Aleisha <aleishaamohia at hotmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:49:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:49:57 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12542-70-UxpuqFvYaJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Kyle M Hall from comment #4) > Why do we have two variations of circ-menu? Bug 3498 included the addition with this comment: "Adds a version of the include circ-menu.inc as circ-menu.tt this has the same functionality as the old include but does not require all the borrowers attributes to be passed as global scoped variables" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:51:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:51:08 +0000 Subject: [Koha-bugs] [Bug 12536] Incorrect number of irregularity issues In-Reply-To: <bug-12536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12536-70-OvWkvSFI6n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12536 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:51:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:51:15 +0000 Subject: [Koha-bugs] [Bug 12536] Incorrect number of irregularity issues In-Reply-To: <bug-12536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12536-70-qVc9CNCEB3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12536 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29690|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29828&action=edit [PASSED QA] Bug 12536 - Incorrect number of irregularity issues Modified: serials/subscription-detail.pl - fix split command Testing: I Apply the patch 0) Select a serial subscription; 1) Click Edit -> Edit subscription; 2) Click Next; 3) Click Test prediction pattern; 4) Select 3 Vols; 5) Save subscription; 6) Select Planing tab; 7) Valide "Irregularity: 3 issues". Signed-off-by: Aleisha <aleishaamohia at hotmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:56:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:56:33 +0000 Subject: [Koha-bugs] [Bug 12559] Wrong message if all cover images deleted In-Reply-To: <bug-12559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12559-70-VEbsnMlw85@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12559 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:56:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:56:35 +0000 Subject: [Koha-bugs] [Bug 12559] Wrong message if all cover images deleted In-Reply-To: <bug-12559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12559-70-ITMZe2UpMT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12559 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29689|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29829&action=edit [PASSED QA] Bug 12559: Wrong message if all cover images deleted If a record contains a (one or more) local cover image and it is deleted, a wrong message is presented in the UI. To reproduce: - Have LocalCoverImages set to "Display" and AllowMultipleCovers set to "Allow". - Go to the detail page of a record that has no images attached. - The 'Images' tab conveniently shows the following message: "No images have been uploaded..." - Use the "upload" link to add a local cover to the record - Complete the process, and "view final record". - The 'Images' tab shows the added cover. - Delete the cover image using the link below the cover. => FAIL: 'Click on an image...' message still shows instead of 'No images have been...' To test: - Apply the patch - Repeat the previous steps => SUCCESS : 'No images have been...' Bonus points: previous code didn't show a message at all if the user didn't have permissions to upload local cover images. I've split the message in two: - 'No images have been...' (for everyone) - 'Please upload (link)...' (for those with the right permissions :-D Regards To+ Edit: I used JavaScript to inject the 'No images...' message to aid localization. It can be improved once we fix some stuff in the translation scripts to better support placeholders/variables in the templates. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Aleisha <aleishaamohia at hotmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 14:57:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 12:57:44 +0000 Subject: [Koha-bugs] [Bug 5304] Too many post find queries for items In-Reply-To: <bug-5304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5304-70-MV1yJDHd8Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:22:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:22:41 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-ejJcH1UIvu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #69 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29830&action=edit Bug 10212: Move colvis files to the include file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:25:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:25:53 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: <bug-12493-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12493-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12493-70-YGmru2Shm7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:25:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:25:56 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: <bug-12493-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12493-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12493-70-9aL7HdbiiC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29494|0 |1 is obsolete| | Attachment #29495|0 |1 is obsolete| | Attachment #29568|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29831&action=edit [PASSED QA] Bug 12493: moving the subroutines GetContract and GetContracts from C4::Acquisition.pm to C4::Contract.pm This patch includes: - the subroutines GetContract and GetContracts has been moved from C4::Acquisition.pm to C4::Contract.pm and adapted for a general use - adaptation of acqui/basket.pl, acqui/basketheader.pl, acqui/neworderempty.pl, acqui/supplier.pl and admin/aqcontract.pl - the unit tests for the module C4::Contract.pm Test plan: 1) Apply the patch 2) Execute the unit tests by launching: prove t/db_dependent/Contract.t t/Acquisition/ t/db_dependent/Acquisition/ t/db_dependent/Acquisition.t 3) The command has to be a success : t/db_dependent/Contract.t ................................. ok t/Acquisition/CanUserManageBasket.t ....................... ok t/Acquisition/Invoice.t ................................... ok t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. ok t/db_dependent/Acquisition/GetOrdersByBiblionumber.t ...... ok t/db_dependent/Acquisition/Invoices.t ..................... ok t/db_dependent/Acquisition/OrderFromSubscription.t ........ ok t/db_dependent/Acquisition/TransferOrder.t ................ 1/11 # Transfering order to basket2 t/db_dependent/Acquisition/TransferOrder.t ................ ok t/db_dependent/Acquisition/close_reopen_basket.t .......... ok t/db_dependent/Acquisition.t .............................. ok All tests successful. Files=10, Tests=284, 15 wallclock secs ( 0.11 usr 0.02 sys + 12.88 cusr 0.77 csys = 13.78 CPU) Result: PASS 4) Log on with a superlibrarian permission 5) Go on the page acqui/supplier.pl (Acquisitions > Button "New vendor") 6) Record a vendor with a nonzero "name" 7) Go on the page admin/aqcontract.pl (click on the "Contracts" item in the menu) 8) Click on the button "New" > "Contract" and record a new one 9) Verify the displayed data are correct about the contract 10) "Edit" the contract with different values and verify the data are updated 11) Click on "Delete" in order to delete the contract, verify the displayed data are correct but cancel the operation 12) Click on "New" > "Basket" and verify there is the created contract in field "Contract", then record a basket by selectioning the created contract 13) Verify the contract name displayed is correct 14) Record an active budget and a fund linked to this budget 15) Go on the new basket (Home > Acquisitions > Search the created vendor) 16) Click on "Add to basket" then "From a new (empty) record" and verify the displayed contract name is correct Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Tested with both patches applied. Works as described following test plan, all points (I did 14 first) All test pass No koha-qa errors Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:26:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:26:14 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: <bug-12493-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12493-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12493-70-bmbwnE6Q0X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29832&action=edit [PASSED QA] Bug 12493: unit tests for the module C4::Contract.pm This patch are the unit tests of the previous patch Test plan : Same as the previous patch Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Comments on previous patch Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:27:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:27:07 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: <bug-12493-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12493-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12493-70-HvtLMWPH9R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29833&action=edit [PASSED QA] Bug 12493 : moving the subroutines GetContract and GetContracts from C4::Acquisition.pm to C4::Contract.pm Fix in order to respect the coding guidelines Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Unit tests pass but *ONLY* with but 12487 applied on top. These two bugs must be pushed simultaneously. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:27:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:27:47 +0000 Subject: [Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: <bug-12487-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12487-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12487-70-Tzu7WEPgRS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:27:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:27:49 +0000 Subject: [Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: <bug-12487-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12487-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12487-70-dta8rv12rY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29496|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29834&action=edit [PASSED QA] Bug 12487: SQLHelper replacement - C4::Contract With this patch, the subroutines GetContract, GetContracts, AddContract, ModContract and DelContract uses DBIx::Class instead of C4::SQLHelper Test plan: 1) Apply the patch 2) Execute the unit tests by launching: prove t/db_dependent/Contract.t 3) The command has to be a success : t/db_dependent/Contract.t .. ok All tests successful. Files=1, Tests=43, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.49 cusr 0.05 csys = 1.59 CPU) Result: PASS 4) Log on with a superlibrarian permission 5) Go on the page acqui/supplier.pl (Acquisitions > Button "New vendor") 6) Record a vendor with a nonzero "name" 7) Go on the page admin/aqcontract.pl (click on the "Contracts" item in the menu) 8) Click on the button "New" > "Contract" and record a new one 9) Verify the displayed data are correct about the contract 10) "Edit" the contract with different values and verify the data are updated 11) Click on "Delete" in order to delete the contract, verify the displayed data are correct but cancel the operation 12) Click on "New" > "Basket" and verify there is the created contract in field "Contract", then record a basket by selectioning the created contract 13) Verify the contract name displayed is correct 14) Record an active budget and a fund linked to this budget 15) Go on the new basket (Home > Acquisitions > Search the created vendor) 16) Click on "Add to basket" then "From a new (empty) record" and verify the displayed contract name is correct, then cancel 17) Click on "Delete this basket" 18) Click on "Contracts" (in the left menu) in order to go on aqcontract.pl, then "Delete" the created contract 19) The contract is not displayed anymore in the vendor page Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Work as described following test plan. Tested on top of Bug 12493 Tests pass No koha-qa errors Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:28:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:28:00 +0000 Subject: [Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: <bug-12487-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12487-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12487-70-LOu5RPKy4X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487 --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29835&action=edit [PASSED QA] Bug 12487 [QA Followup] - GetContract must return undef with no params Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:32:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:32:06 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-v99jgVewBJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29701|0 |1 is obsolete| | --- Comment #70 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29836&action=edit [SIGNED-OFF] Bug 10212: Columns configuration for tables This development introduces ColVis into Koha and provides a configuration page for columns visibility. ColVis is a plugin for DataTables. It allows to change the visibility of the columns in the table. * This development adds: - the js and css file for ColVis - a new DB table 'columns_settings' - a new template plugin 'ColumnsSettings' - a new package C4::Utils::DataTables::ColumnsSettings - a new admin page admin/columns_settings.pl * How it works: A yaml file is created (admin/columns_settings.yml) in order to take an inventory of all tables where ColVis is implemented. This file is read to create the list of modules, pages and tables in the configuration page. There are 3 possible keys in the yml: - is_hidden: default is 0 The column will be hidden. - cannot_be_toggled: default is 0. ColVis will allow to hide/show the column. - cannot_be_modified: default is 0 Default values (in the yml) won't be modifiable. When a user changes (or saves) the configuration for one module, all columns are added to the DB table. The values in the DB get the upper hand on the yaml values. * Humm, strange? It seems weird to have 2 storages for the same values. But I think it will be easy to add an entry and maintain the yaml rather than adding a new row (and new entry in updatedatabase script) in the DB. * To go further: We can imagine that the configuration is saved for each user (and not globally like it is made with this patch). This patch cannot be tested as it, you need to apply the "POC" patch. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:32:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:32:17 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-VRrO77KwhC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29702|0 |1 is obsolete| | --- Comment #71 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29837&action=edit [SIGNED-OFF] Bug 10212: Columns configuration for tables - DB changes Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:32:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:32:28 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-Z8RYQgLYb8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29703|0 |1 is obsolete| | --- Comment #72 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29838&action=edit [SIGNED-OFF] Bug 10212: Columns configuration for tables - Unit tests test plan: Verify the prove t/db_dependent/ColumnsSettings.t returns green. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:32:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:32:37 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-HME25KVTPg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29704|0 |1 is obsolete| | --- Comment #73 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29839&action=edit [SIGNED-OFF] Bug 10212: Columns configuration for tables - Add Colvis files This patch only adds Colvis js and css files. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:32:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:32:45 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-3wUxTLVV0l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29705|0 |1 is obsolete| | --- Comment #74 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29840&action=edit [SIGNED-OFF] Bug 10212: Columns configuration for tables - POC This patch proves that this feature is useful with a concret use case. Test plan: 1/ Execute the updatedatabase in order to create the new table. 2/ Take a look to the yml structure. 3/ Go on the admin currency page (admin/currency.pl). 4/ Check that you cannot hide the 2 first columns on the table. 5/ Try to hide/show columns. 6/ Go on the columns configuration page (admin/columns_settings.pl). 7/ Only the admin tab are filled with data. Check/uncheck checkboxes and save. 8/ Go on the admin currency page and check that the behavior is what you expected. 9/ Give me some feedback :) Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:32:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:32:53 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-zSPClXCHTy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29718|0 |1 is obsolete| | --- Comment #75 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29841&action=edit [SIGNED-OFF] Bug 10212: Add Colvis to the about page Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:33:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:33:02 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-er1dC2BxOA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29830|0 |1 is obsolete| | --- Comment #76 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29842&action=edit [SIGNED-OFF] Bug 10212: Move colvis files to the include file Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:33:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:33:32 +0000 Subject: [Koha-bugs] [Bug 12287] Hold priority for new hold incorrect if record has holds in transit In-Reply-To: <bug-12287-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12287-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12287-70-4mLNgBuzHL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12287 --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- I don't think so. That could cause future regressions if new found statuses are added. For example, there used to be a found status of 'F' for 'Finished' ( from before the existence of the old_reserves table iirc ). We never want to include any type of found hold when calculating a new hold's priority, set there is no need to list everything as a special case. (In reply to Jonathan Druart from comment #4) > Don't you think it's safer to test the 'T' value? > Something like > > if ( defined $res->{found} > and ( $res->{found} eq 'W' or $res->{found} eq 'T' ) ) > { > $count--; > } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:34:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:34:45 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-vvMhMeZGQP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #77 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Katrin Fischer from comment #59) > a) The options to toggle/hide could be positioned a bit closer to the table, > maybe we could even use an icon later? I think this could be improved but I don't have a good suggestion right now. I'm going to keep thinking about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:47:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:47:04 +0000 Subject: [Koha-bugs] [Bug 12043] Popup when reserved item checked in at wrong branch should generate transfer slip In-Reply-To: <bug-12043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12043-70-Ue3qiAEqJA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:47:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:47:10 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-YCvfwW8ZIB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12599 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:47:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:47:10 +0000 Subject: [Koha-bugs] [Bug 12599] IndependentBranches Holes In-Reply-To: <bug-12599-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12599-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12599-70-qkGxAbhqsf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12599 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10276 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:49:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:49:55 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: <bug-10648-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10648-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10648-70-cyPxYuIjXz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:49:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:49:59 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: <bug-10648-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10648-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10648-70-RFoacELluF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29581|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29843&action=edit [PASSED QA] Bug 10648 - In records merge greatest field can not be added When merging 2 records (/cgi-bin/koha/cataloguing/merge.pl), the destination record is build using the fields and subfields checked in source records. When a field is checked, the javascript code searches in destination record a field with a greater tag number to insert new field before. When the new field tag number is greater than all existing field tag numbers, the field is not added. This patch corrects this by adding at end if no greater field tag number exists. Also adds a sort of fields by tag number because all mergo code is based on this. Test plan : - Add to a framework a repeatable field with the greater non existing tag number. For example 998. - Edit 2 records with this framework and add them a value in this tag. - Put those records is a list - Go to this list and check the two records - Click on "Merge selected" - Click on next - Go to second source record - Click on the greatest tag number. for example 998. => The field is added at the end of destination record Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 15:51:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 13:51:38 +0000 Subject: [Koha-bugs] [Bug 8276] circ history not sorting right In-Reply-To: <bug-8276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8276-70-8yBYHNsqnf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 --- Comment #4 from Colin Campbell <colin.campbell at ptfs-europe.com> --- On an admittedly small sample dates look ok. Strange behaviour with checked out items .... they always sort as being the earliest if you sort on that column (the sorting value is set to '00-00-0000' The patron's history is more intuitive, these appear as 'checked out' and characters being > numbers always sort as newer. If folk agree that making the two screens consustent is a good idea, I'll submit the patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:05:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:05:16 +0000 Subject: [Koha-bugs] [Bug 12603] New: TestBuilder - Module to simplify the writing of tests Message-ID: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 Bug ID: 12603 Summary: TestBuilder - Module to simplify the writing of tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: yohann.dufour at biblibre.com QA Contact: gmcharlt at gmail.com Hi, With Jonathan Druart, we have been working on a module which allows to simplify the writing of tests by inserting all the foreign keys which are necessary to insert a new entry in the database. For example, if you want to test an order, you have to create a biblio, a bookseller, a budget, etc. With this module, two lines are sufficient to create an order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:10:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:10:03 +0000 Subject: [Koha-bugs] [Bug 12582] Control of branch displayed in search results linked to HomeOrHoldingBranch In-Reply-To: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12582-70-Il5tXM09f7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12582 Jason Robb <jrobb at sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org --- Comment #3 from Jason Robb <jrobb at sekls.org> --- I've tested this and it works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:14:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:14:42 +0000 Subject: [Koha-bugs] [Bug 12582] Control of branch displayed in search results linked to HomeOrHoldingBranch In-Reply-To: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12582-70-bozvLX6PU3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12582 Melissa Lefebvre <melissa at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29744|0 |1 is obsolete| | --- Comment #4 from Melissa Lefebvre <melissa at bywatersolutions.com> --- Created attachment 29844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29844&action=edit Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:14:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:14:53 +0000 Subject: [Koha-bugs] [Bug 12582] Control of branch displayed in search results linked to HomeOrHoldingBranch In-Reply-To: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12582-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12582-70-9skgztBOo8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12582 Melissa Lefebvre <melissa at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melissa at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:26:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:26:53 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12603-70-vFdtsKcwfZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:27:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:27:01 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12603-70-DL8o8X87d2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 --- Comment #1 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 29845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29845&action=edit Bug 12603: creating TestBuilder to simplify tests This patch contains a new module t::lib::TestBuilder which allows to write tests easier and it contains the unit tests of this module. For more information, see the documentation of the module. This module uses the DBIx::Class schema and works with a clean DBIx::Class schema. In order to use it, you have to remove the current circular dependence (existing in the DBIx::Class) by applying the last patch of the bug 11518. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:32:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:32:40 +0000 Subject: [Koha-bugs] [Bug 12604] New: TestBuilder - Refactoring Category.t Message-ID: <bug-12604-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12604 Bug ID: 12604 Summary: TestBuilder - Refactoring Category.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: yohann.dufour at biblibre.com QA Contact: gmcharlt at gmail.com In order to see what the module TestBuilder can bring to the writing of tests, the tests in Category.t have been refactored with the use of TestBuilder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:33:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:33:38 +0000 Subject: [Koha-bugs] [Bug 6542] Degree symbol causes error in cataloging in IE In-Reply-To: <bug-6542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6542-70-Dwf3pFr84a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6542 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Two attempts to reproduce this bug failed. I'm going to consider this fixed. Please re-open if you can provide more details about how to reproduce. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:34:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:34:03 +0000 Subject: [Koha-bugs] [Bug 12605] New: TestBuilder - Refactoring Acquisition/close_reopen_basket.t Message-ID: <bug-12605-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 Bug ID: 12605 Summary: TestBuilder - Refactoring Acquisition/close_reopen_basket.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: yohann.dufour at biblibre.com QA Contact: gmcharlt at gmail.com In order to see what the module TestBuilder can bring to the writing of tests, the tests in Acquisition/close_reopen_basket.t have been refactored with the use of TestBuilder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:34:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:34:37 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12603-70-pyB8NGexKA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |yohann.dufour at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:35:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:35:59 +0000 Subject: [Koha-bugs] [Bug 12606] New: TestBuilder - Refactoring Acquisition/GetOrdersByBiblionumber.t Message-ID: <bug-12606-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12606 Bug ID: 12606 Summary: TestBuilder - Refactoring Acquisition/GetOrdersByBiblionumber.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: yohann.dufour at biblibre.com QA Contact: gmcharlt at gmail.com In order to see what the module TestBuilder can bring to the writing of tests, the tests in Acquisition/GetOrdersByBiblionumber.t have been refactored with the use of TestBuilder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:36:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:36:12 +0000 Subject: [Koha-bugs] [Bug 12606] TestBuilder - Refactoring Acquisition/GetOrdersByBiblionumber.t In-Reply-To: <bug-12606-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12606-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12606-70-TeVMXvqqRs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12606 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |yohann.dufour at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:37:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:37:49 +0000 Subject: [Koha-bugs] [Bug 12607] New: TestBuilder - Refactoring Acquisition/GetBasketsInfosByBookseller.t Message-ID: <bug-12607-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12607 Bug ID: 12607 Summary: TestBuilder - Refactoring Acquisition/GetBasketsInfosByBookseller.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: yohann.dufour at biblibre.com QA Contact: gmcharlt at gmail.com In order to see what the module TestBuilder can bring to the writing of tests, the tests in Acquisition/GetBasketsInfosByBookseller.t have been refactored with the use of TestBuilder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:38:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:38:38 +0000 Subject: [Koha-bugs] [Bug 12604] TestBuilder - Refactoring Category.t In-Reply-To: <bug-12604-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12604-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12604-70-oUV9KWw4TL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12604 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |yohann.dufour at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:38:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:38:46 +0000 Subject: [Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t In-Reply-To: <bug-12605-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12605-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12605-70-RGGsfXBl7j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |yohann.dufour at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:38:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:38:53 +0000 Subject: [Koha-bugs] [Bug 12607] TestBuilder - Refactoring Acquisition/GetBasketsInfosByBookseller.t In-Reply-To: <bug-12607-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12607-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12607-70-QgyVlcLoTa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12607 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |yohann.dufour at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:39:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:39:23 +0000 Subject: [Koha-bugs] [Bug 7809] Edit Items screen should be sorted by home branch instead of holding branch In-Reply-To: <bug-7809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7809-70-eQwJ5pwoCz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7809 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- I think this bug has been made obsolete by the addition of the DataTables plugin to the edit items screen. The table may not have a specific default sort, but it can be sorted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:40:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:40:56 +0000 Subject: [Koha-bugs] [Bug 12608] New: Replace use of DBI with DBIx::Class throughout Koha Message-ID: <bug-12608-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12608 Bug ID: 12608 Summary: Replace use of DBI with DBIx::Class throughout Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Now that we have DBIx::Class, we should use it wherever possible. Long term steps: 1) Replace all DBI inserts and deletes with DBIC creates and deletes 2) Replace all DBI selects with DBIC searches using DBIx::Class::ResultClass::HashRefInflator to return hashrefs for compatibility 3) Move logic from perl modules into Result and ResultSet classes wherever possible and sensible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:41:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:41:02 +0000 Subject: [Koha-bugs] [Bug 12608] Replace use of DBI with DBIx::Class throughout Koha In-Reply-To: <bug-12608-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12608-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12608-70-Ey3KaZTyoS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12608 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:41:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:41:34 +0000 Subject: [Koha-bugs] [Bug 12609] New: Replace use of DBI in C4::Ratings with DBIx::Class Message-ID: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Bug ID: 12609 Summary: Replace use of DBI in C4::Ratings with DBIx::Class Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We should replace the use of DBI in C4::Ratings with DBIC instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:41:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:41:39 +0000 Subject: [Koha-bugs] [Bug 12609] Replace use of DBI in C4::Ratings with DBIx::Class In-Reply-To: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12609-70-YVfsRIsSom@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:42:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:42:33 +0000 Subject: [Koha-bugs] [Bug 12609] Replace use of DBI in C4::Ratings with DBIx::Class In-Reply-To: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12609-70-aDtcg7hcAL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29846&action=edit Bug 12609 - Replace use of DBI in C4::Ratings with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Ratings.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:43:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:43:40 +0000 Subject: [Koha-bugs] [Bug 12609] Replace use of DBI in C4::Ratings with DBIx::Class In-Reply-To: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12609-70-ItHHleGySi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29846|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29847&action=edit Bug 12609 - Replace use of DBI in C4::Ratings with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Ratings.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:44:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:44:37 +0000 Subject: [Koha-bugs] [Bug 12609] Replace use of DBI in C4::Ratings with DBIx::Class In-Reply-To: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12609-70-iHFUKc506B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29847|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29848&action=edit Bug 12609 - Replace use of DBI in C4::Ratings with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Ratings.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:45:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:45:41 +0000 Subject: [Koha-bugs] [Bug 12609] Replace use of DBI in C4::Ratings with DBIx::Class In-Reply-To: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12609-70-Siow8bl7XD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29848|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29849&action=edit Bug 12609 - Replace use of DBI in C4::Ratings with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Ratings.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:46:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:46:50 +0000 Subject: [Koha-bugs] [Bug 12604] TestBuilder - Refactoring Category.t In-Reply-To: <bug-12604-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12604-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12604-70-pnGzOk4WJo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12604 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch Depends on| |12603 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:46:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:46:50 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12603-70-akrsBrLPZO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12604 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:46:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:46:53 +0000 Subject: [Koha-bugs] [Bug 12604] TestBuilder - Refactoring Category.t In-Reply-To: <bug-12604-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12604-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12604-70-CPXJOlgvQO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12604 --- Comment #1 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 29850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29850&action=edit Bug 12604: refactoring Category.t with TestBuilder The tests have been refactored with the module TestBuilder. Test plan: 1/ Apply the patch 12603 2/ The command : prove t/db_dependent/Category.t has to be a success without error or warning : t/db_dependent/Category.t .. ok All tests successful. Files=1, Tests=3, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.05 cusr 0.05 csys = 1.14 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:48:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:48:41 +0000 Subject: [Koha-bugs] [Bug 12401] card view on z searches sometimes throws error In-Reply-To: <bug-12401-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12401-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12401-70-tY8PVoBMZN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12401 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Can you download the record which triggers the error? If you import the record into Koha does it work? If so, is there any visible problem with the imported data? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:53:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:53:46 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-crW5CUhJS0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Eric B?gin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com --- Comment #12 from Eric B?gin <eric.begin at inLibro.com> --- Mark, did you forget to set this bugs as ? Needs Signoff ? ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:56:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:56:28 +0000 Subject: [Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t In-Reply-To: <bug-12605-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12605-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12605-70-uMQqnIvsK8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch Depends on| |12603 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:56:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:56:28 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12603-70-lY70b8AL3J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12605 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 16:56:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 14:56:30 +0000 Subject: [Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t In-Reply-To: <bug-12605-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12605-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12605-70-3vlvdet5oy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 --- Comment #1 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 29851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29851&action=edit Bug 12604: refactoring close_reopen_basket.t with TestBuilder The tests have been refactored with the module TestBuilder. Test plan: 1/ Apply the patch 12603 and the last patch of bug 11518. 2/ The command : prove t/db_dependent/Acquisition/close_reopen_basket.t has to be a success without error or warning : t/db_dependent/Acquisition/close_reopen_basket.t .. ok All tests successful. Files=1, Tests=7, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.71 cusr 0.09 csys = 1.84 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:00:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:00:29 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-2OQvX29Wy3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #13 from M. Tompsett <mtompset at hotmail.com> --- No, because of comment 9 requiring a bootstrap portion of the patch. I just fixed the prog side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:00:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:00:50 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12603-70-tb8gNx9DLM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #2 from Zeno Tajoli <z.tajoli at cineca.it> --- Hi Yohann and Jonathan, I don't understand very well the situation. You find a problem in patch bug 11518 (the FK circular refeence). But the patch was pushedt to master at 29 April 2014. Now it is present on master and on stable (3.16.x). So why do you work on a old bug and you don't create a new bug with your fix. Clearly with a see also to bug 11518. Bye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:05:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:05:57 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-6gJeYMcVr9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 29852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29852&action=edit Bug 12595: (regression tests) Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:06:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:06:08 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12603-70-x8h5EpOj4b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12606 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:06:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:06:08 +0000 Subject: [Koha-bugs] [Bug 12606] TestBuilder - Refactoring Acquisition/GetOrdersByBiblionumber.t In-Reply-To: <bug-12606-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12606-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12606-70-Vst06JAPtr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12606 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch Depends on| |12603 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:06:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:06:10 +0000 Subject: [Koha-bugs] [Bug 12606] TestBuilder - Refactoring Acquisition/GetOrdersByBiblionumber.t In-Reply-To: <bug-12606-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12606-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12606-70-vNK8SuvYN1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12606 --- Comment #1 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 29853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29853&action=edit Bug 12606: refactoring GetOrdersByBiblionumber.t with TestBuilder The tests have been refactored with the module TestBuilder. Test plan: 1/ Apply the patch 12603 and the last patch of bug 11518. 2/ The command : prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t has to be a success without error or warning : t/db_dependent/Acquisition/GetOrdersByBiblionumber.t .. ok All tests successful. Files=1, Tests=4, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.90 cusr 0.09 csys = 2.03 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:15:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:15:24 +0000 Subject: [Koha-bugs] [Bug 12607] TestBuilder - Refactoring Acquisition/GetBasketsInfosByBookseller.t In-Reply-To: <bug-12607-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12607-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12607-70-B7GnVisKvv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12607 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch Depends on| |12603 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:15:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:15:24 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12603-70-FO9Z1ynVMB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12607 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:15:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:15:27 +0000 Subject: [Koha-bugs] [Bug 12607] TestBuilder - Refactoring Acquisition/GetBasketsInfosByBookseller.t In-Reply-To: <bug-12607-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12607-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12607-70-Be8NEOG5t2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12607 --- Comment #1 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 29854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29854&action=edit Bug 12607: refactoring GetBasketsInfosByBookseller.t with TestBuilder The tests have been refactored with the module TestBuilder. Test plan: 1/ Apply the patch 12603 and the last patch of bug 11518. 2/ The command : prove t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t has to be a success without error or warning : t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. ok All tests successful. Files=1, Tests=18, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.71 cusr 0.09 csys = 1.84 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:18:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:18:05 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12603-70-WoCYzeT00t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 --- Comment #3 from Yohann Dufour <yohann.dufour at biblibre.com> --- You can see examples of the TestBuilder abilities in bug 12604, bug 12605, bug 12606, bug 12607 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:21:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:21:36 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-t6t7yG0ilN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29852|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 29855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29855&action=edit Bug 12595: (regression tests) Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:22:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:22:54 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-Z1Peeuk4mi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:22:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:22:58 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-y64VXTKSAY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29856&action=edit Bug 12597 - Give better visual indication of currently-selected language in the staff client There is currently no visual feedback to the user reflecting which of multiple installed translations is currently selected. I think some necessary styling didn't make it into the conversion to Bootstrap menus. This patch attempts to improve things. Most of the changes are to bring back the previous style of highlighting the currently selected language. A new change is the addition of the sub-language code to the display of the menu label if one of that menu item's sub-languages is selected. This patch also removes some obsolete CSS which referred to the old menu system. To test, apply the patch and install or update multiple languages, including at least two sub-languages. In my test I used en, en-GB and de-DE. Clear your browser cache if necessary. Enable all these languages and test the functionality of the language selection menu in the footer. - Non-enabled languages should appear as non-bold links. - When a single language (with no sub-languages) is enabled it should appear as bold text. - When one of multiple sub-languages is enabled that selection in the pop-up menu should appear as bold text. The menu label should show in bold the language code of the selected sub-language. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:28:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:28:45 +0000 Subject: [Koha-bugs] [Bug 11320] Ambiguous message when a duplicate record is detected In-Reply-To: <bug-11320-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11320-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11320-70-scL6sQTjKc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11320 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- (In reply to mathieu saby from comment #0) > "Yes, Edit existing items". This label is correct: Clicking the button takes you to the add/edit item screen for the existing record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:30:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:30:48 +0000 Subject: [Koha-bugs] [Bug 9204] cannot save the record. In-Reply-To: <bug-9204-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9204-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9204-70-DgzPKZ6Wiz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9204 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- No follow-up information about this report so I'm going to assume it was an installation-specific problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:31:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:31:20 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-drafVckHZx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29855|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 29857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29857&action=edit Bug 12595: (regression tests) Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:35:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:35:15 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-g7OSSzlxjD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29857|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29858&action=edit Bug 12595: (regression tests) Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:38:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:38:48 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12603-70-gbA3g6afS5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Zeno Tajoli from comment #2) > I don't understand very well the situation. > You find a problem in patch bug 11518 (the FK circular refeence). Yohann was speaking about the last patch, not pushed. The way to solve the problem is not obvious. Any idea/feedback is welcomed, but not on this report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:39:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:39:44 +0000 Subject: [Koha-bugs] [Bug 9291] don't auto select CCODE In-Reply-To: <bug-9291-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9291-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9291-70-P59LrmxsOH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9291 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- I can reproduce this bug in 3.10.x but not in master as of 3.17.00.009 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:44:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:44:34 +0000 Subject: [Koha-bugs] [Bug 11162] ability to sort items on item edit screen In-Reply-To: <bug-11162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11162-70-SWTihAs5lc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11162 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** This bug has been marked as a duplicate of bug 10901 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:44:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:44:34 +0000 Subject: [Koha-bugs] [Bug 10901] Filters is needed on the add item page In-Reply-To: <bug-10901-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10901-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10901-70-GSRdOXAGjJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10901 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #11 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 11162 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:47:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:47:08 +0000 Subject: [Koha-bugs] [Bug 11597] tab through fields in cataloging. In-Reply-To: <bug-11597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11597-70-cw35bCjl7U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11597 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** This bug has been marked as a duplicate of bug 12380 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:47:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:47:08 +0000 Subject: [Koha-bugs] [Bug 12380] can't tab to save buttons on add item In-Reply-To: <bug-12380-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12380-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12380-70-CldDGGC3QW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ed.veal at bywatersolutions.co | |m --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 11597 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:49:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:49:29 +0000 Subject: [Koha-bugs] [Bug 11029] Marc Language Code in a list In-Reply-To: <bug-11029-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11029-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11029-70-2rCHoNiMD9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11029 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:52:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:52:29 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-efxtBA4hbV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Dobrica! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:52:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:52:49 +0000 Subject: [Koha-bugs] [Bug 12595] Finding a patron witht firstname and surname should display the patron detail In-Reply-To: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12595-70-aonDc5oWxq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12595 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:53:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:53:11 +0000 Subject: [Koha-bugs] [Bug 12559] Wrong message if all cover images deleted In-Reply-To: <bug-12559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12559-70-ADNZTAd0u6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12559 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 17:53:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 15:53:34 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12542-70-ABnNi8mMsw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:03:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:03:52 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-B09vjsH4bq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 --- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> --- It would be good to know how reproduce this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:05:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:05:01 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-uFuniKhnS7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #7) > It would be good to know how reproduce this issue. On comment #3 I explained the steps I used to reproduce it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:23:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:23:11 +0000 Subject: [Koha-bugs] [Bug 7237] duplicating patron not using patron's branch In-Reply-To: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7237-70-WvpfJhzOOn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7237 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|kyle.m.hall at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:27:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:27:41 +0000 Subject: [Koha-bugs] [Bug 7237] duplicating patron not using patron's branch In-Reply-To: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7237-70-DgAH4E8L4K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7237 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:27:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:27:44 +0000 Subject: [Koha-bugs] [Bug 7237] duplicating patron not using patron's branch In-Reply-To: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7237-70-bpjatIzZGt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7237 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29859&action=edit Bug 7237 - duplicating patron not using patron's branch When duplicating a patron the original patron's library should be preselected. To test, apply the patch and choose a patron to duplicate, noting which library is set as their home library. Click the "Duplicate" button and cnofirm that the patron's library is preselected on the patron entry form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:35:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:35:55 +0000 Subject: [Koha-bugs] [Bug 12609] Replace use of DBI in C4::Ratings with DBIx::Class In-Reply-To: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12609-70-39YFWMBaoa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:36:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:36:01 +0000 Subject: [Koha-bugs] [Bug 12609] Replace use of DBI in C4::Ratings with DBIx::Class In-Reply-To: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12609-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12609-70-tBVChyznGO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12608 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:36:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:36:01 +0000 Subject: [Koha-bugs] [Bug 12608] Replace use of DBI with DBIx::Class throughout Koha In-Reply-To: <bug-12608-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12608-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12608-70-5pN8I6vMHx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12608 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12609 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:38:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:38:00 +0000 Subject: [Koha-bugs] [Bug 12610] New: Replace use of DBI in C4::Tags with DBIx::Class Message-ID: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 Bug ID: 12610 Summary: Replace use of DBI in C4::Tags with DBIx::Class Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We should replace the use of DBI in C4::Tags with DBIC instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:39:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:39:15 +0000 Subject: [Koha-bugs] [Bug 12610] Replace use of DBI in C4::Tags with DBIx::Class In-Reply-To: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12610-70-dYv5SVTu94@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:39:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:39:17 +0000 Subject: [Koha-bugs] [Bug 12610] Replace use of DBI in C4::Tags with DBIx::Class In-Reply-To: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12610-70-jlGYxYq3zS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29860&action=edit Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Tags.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:39:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:39:38 +0000 Subject: [Koha-bugs] [Bug 12610] Replace use of DBI in C4::Tags with DBIx::Class In-Reply-To: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12610-70-qPds6CJyxT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12608 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:39:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:39:38 +0000 Subject: [Koha-bugs] [Bug 12608] Replace use of DBI with DBIx::Class throughout Koha In-Reply-To: <bug-12608-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12608-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12608-70-FkhNgMgyXU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12608 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12610 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:39:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:39:48 +0000 Subject: [Koha-bugs] [Bug 12610] Replace use of DBI in C4::Tags with DBIx::Class In-Reply-To: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12610-70-MLfOQVMXAN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:46:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:46:09 +0000 Subject: [Koha-bugs] [Bug 12610] Replace use of DBI in C4::Tags with DBIx::Class In-Reply-To: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12610-70-4RgwD0iQy2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29860|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29861&action=edit Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Tags.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:51:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:51:06 +0000 Subject: [Koha-bugs] [Bug 12610] Replace use of DBI in C4::Tags with DBIx::Class In-Reply-To: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12610-70-z6eIHmsh4c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29861|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29862&action=edit Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Tags.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 18:58:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 16:58:23 +0000 Subject: [Koha-bugs] [Bug 12610] Replace use of DBI in C4::Tags with DBIx::Class In-Reply-To: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12610-70-19cSj3aMoe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 19:05:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 17:05:01 +0000 Subject: [Koha-bugs] [Bug 12610] Replace use of DBI in C4::Tags with DBIx::Class In-Reply-To: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12610-70-k6opBXTBxB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29862|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29863&action=edit Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Tags.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 19:06:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 17:06:50 +0000 Subject: [Koha-bugs] [Bug 12610] Replace use of DBI in C4::Tags with DBIx::Class In-Reply-To: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12610-70-JzTfyeMWeh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 19:17:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 17:17:46 +0000 Subject: [Koha-bugs] [Bug 12608] Replace use of DBI with DBIx::Class throughout Koha In-Reply-To: <bug-12608-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12608-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12608-70-232eLXas3m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12608 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 19:39:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 17:39:35 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working! In-Reply-To: <bug-11677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11677-70-sXvDudrRJC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 --- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 29864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29864&action=edit Bug 11677 - Limit to Only items currently available for loan or reference not working! Worklog entries FYI: (A proper patch follows (unless somebody does it first)) Identified this issue. Looking for a solution. Browsing the Zebra manual for answers on regexp, regexps not supported :( Made it possible to accurately and quickly filter results by holdingbranch and onloan. So "Selecting available" now works when a library is selected as well. This causes normal "Selecting available"-feature to not work in it's mutant form. Need to refactor the default value for items.onloan from NULL to '0000-00-00' to fix it. This row: $availability_limit .= "( ( allrecords,AlwaysMatches='' not onloan,AlwaysMatches='') and (lost,st-numeric=0) )"; #or ( allrecords,AlwaysMatches='' not lost,AlwaysMatches='')) )"; Causes all records in Zebra to be selected and removes records with even one item onloan (even if items would be available)! This is obviously wrong, but because Zebra (and not many other text indexers) cannot deal with (If undef)-search terms, a fix might be to set 952$q (onloan) datetime to 0000-00-00 instead of NULL in the DB. Then we could find Records with items where onloan is 0000-00-00. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 19:40:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 17:40:12 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working! In-Reply-To: <bug-11677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11677-70-N5ImqDuQEi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 --- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Sharing is caring! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:03:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:03:53 +0000 Subject: [Koha-bugs] [Bug 7944] attribute error could be clearer In-Reply-To: <bug-7944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7944-70-oTBkzxE1ev@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7944 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|kyle.m.hall at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:27:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:27:59 +0000 Subject: [Koha-bugs] [Bug 7944] attribute error could be clearer In-Reply-To: <bug-7944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7944-70-xfosQjTLai@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7944 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:28:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:28:03 +0000 Subject: [Koha-bugs] [Bug 7944] attribute error could be clearer In-Reply-To: <bug-7944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7944-70-UGLTQnVdcz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7944 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29865&action=edit Bug 7944 - attribute error could be clearer If you try to create a patron and enter an extended attribute value which is required to be unique but exists in another record the error you receive is not clear. It uses the attribute code instead of the description. This patch adds description to the output. To test you must have ExtendedPatronAttributes enabled. - Edit or create an extended patron attribute and designate it a unique identifier. - Edit a patron and add a value to that attribute. - Edit another patron and try to add the same value. You should get an error which includes both the description of the attribute you tried to modify and the value you submitted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:28:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:28:24 +0000 Subject: [Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms. In-Reply-To: <bug-11961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11961-70-zfft7spaYJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Eric B?gin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com Assignee|fcapovilla at live.ca |eric.begin at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:33:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:33:58 +0000 Subject: [Koha-bugs] [Bug 4030] Patron attribute types cannot be made mandatory In-Reply-To: <bug-4030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4030-70-PPOOOsVNrX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_0 |master --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- This looks like it would be useful to pick up again. Is there a problem with it besides the template issue? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:36:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:36:21 +0000 Subject: [Koha-bugs] [Bug 4030] Patron attribute types cannot be made mandatory In-Reply-To: <bug-4030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4030-70-8r2jNx8F9w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:40:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:40:09 +0000 Subject: [Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser In-Reply-To: <bug-9961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9961-70-tCsUE0Ax9M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 --- Comment #7 from Eric B?gin <eric.begin at inLibro.com> --- Created attachment 29866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29866&action=edit Fix the ProhibitedSubroutinePrototypes QA critical error by removing the ($) from the GetMandatoryFieldZ3950 function -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:41:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:41:54 +0000 Subject: [Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser In-Reply-To: <bug-9961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9961-70-hAXSwMaPpm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Eric B?gin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29866|0 |1 is obsolete| | CC| |eric.begin at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:42:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:42:29 +0000 Subject: [Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser In-Reply-To: <bug-9961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9961-70-a5DLGrDHpb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 --- Comment #8 from Eric B?gin <eric.begin at inLibro.com> --- Comment on attachment 29866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29866 Fix the ProhibitedSubroutinePrototypes QA critical error by removing the ($) from the GetMandatoryFieldZ3950 function Wrong bug number with git bz :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:44:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:44:23 +0000 Subject: [Koha-bugs] [Bug 11929] patron modification error shows borrowernumber In-Reply-To: <bug-11929-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11929-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11929-70-3xFsNi7qbs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11929 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- How do you trigger this kind of error? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:45:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:45:16 +0000 Subject: [Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms. In-Reply-To: <bug-11961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11961-70-Q5sof4scEi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 --- Comment #3 from Eric B?gin <eric.begin at inLibro.com> --- Created attachment 29867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29867&action=edit Fix the ProhibitedSubroutinePrototypes QA critical error by removing the ($) from the GetMandatoryFieldZ3950 function http://bugs.koha-community.org/show_bug.cgi?id=9961 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:46:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:46:02 +0000 Subject: [Koha-bugs] [Bug 3478] Display patron middle initials In-Reply-To: <bug-3478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3478-70-BUgwmWkz6p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3478 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:46:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:46:47 +0000 Subject: [Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms. In-Reply-To: <bug-11961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11961-70-QEwEt4q4RV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Eric B?gin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Eric B?gin <eric.begin at inLibro.com> --- Critical problem fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:53:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:53:45 +0000 Subject: [Koha-bugs] [Bug 9096] Subscription Fee for patrons In-Reply-To: <bug-9096-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9096-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9096-70-wzLukt75iJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9096 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- The enrollment fee is added to the patron account every time they renew their account. In order to accomplish what you want you need to define your patron category with an enrollment period of one month. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:57:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:57:43 +0000 Subject: [Koha-bugs] [Bug 9501] renew patron link next to expiration date In-Reply-To: <bug-9501-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9501-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9501-70-ywDBl6vMfb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9501 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** This bug has been marked as a duplicate of bug 9878 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 20:57:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 18:57:43 +0000 Subject: [Koha-bugs] [Bug 9878] Flag display is inconsistent between circulation.pl and memberentry.pl In-Reply-To: <bug-9878-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9878-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9878-70-1Y246zkPsE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9878 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 9501 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 21:08:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 19:08:24 +0000 Subject: [Koha-bugs] [Bug 9796] ability to delete a patron image In-Reply-To: <bug-9796-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9796-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9796-70-aqHkgCJNHU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9796 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 29868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29868&action=edit Patron image delete link -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 21:08:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 19:08:33 +0000 Subject: [Koha-bugs] [Bug 9796] ability to delete a patron image In-Reply-To: <bug-9796-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9796-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9796-70-5kf9IlNBG6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9796 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 21:14:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 19:14:55 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5685-70-k4q0yeZ1TB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3814|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 21:15:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 19:15:05 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5685-70-TUIJYNJqYX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3860|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 21:15:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 19:15:47 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5685-70-F1arB4RKvc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Failed QA |ASSIGNED Version|3.6 |master Assignee|mark.gavillet at ptfs-europe.c |koha-bugs at lists.koha-commun |om |ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 21:16:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 19:16:04 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5685-70-fZYXWR5kfT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 21:18:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 19:18:09 +0000 Subject: [Koha-bugs] [Bug 11355] PERL5OPTS="-mDevel::Cover" makes t/db_dependent/Search.t fail In-Reply-To: <bug-11355-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11355-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11355-70-4Xz1ubMJtj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11355 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- We don't run the tests like that. And they run fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 21:50:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 19:50:36 +0000 Subject: [Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks In-Reply-To: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12477-70-VFwDHPqotf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29869&action=edit Loader for XML files This new attach has a variant of XML files, with one element to represent data types, and a simple script to load the values into Koha database. I tried $dbh->do() for each value, or a prepare() and then execute(), but is too slow. It builds a single string with all values to insert, similar as the SQL files for frameworks. In my tests the script takes a little more than three times as long as mysql client to load default framework (tags/subtags), but is a difference between ~0.7s and ~2.5s, perhaps acceptable... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 22:24:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 20:24:05 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-qJOOzL2rI4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Eric B?gin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |eric.begin at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 23:33:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 21:33:34 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-VlYQEKeEsC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Cathi Wiggins <cwiggins at ci.arcadia.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cwiggins at ci.arcadia.ca.us --- Comment #3 from Cathi Wiggins <cwiggins at ci.arcadia.ca.us> --- I don't think we need more messages to appear on the screen that then disappear or are ignored, the fact that the renewal was successful just needs to be more clear on the patron's summary tab in the OPAC or the patron's Check Out tab in the Staff Client with the text saying 'RENEWED' instead of 'NOT RENEWABLE'. Also if there must be text below that, then could it say just '1 renewal remaining' or '0 renewal remaining' instead of '1 of 1...' or '0 of 1...' which is confusing and not helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 23:38:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 21:38:27 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-TTScpNrAeJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #130 from Heather Braum <hbraum at nekls.org> --- Kyle, I went to sign off on this patch again using the sandboxes, and got this error that the sandbox wasn't ready: Some problems occurred applying patches from bug 9303: <h1>Something went wrong !</h1>Applying: Bug 9303 [1] - relative's checkouts in the opac - Schema Updates Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Borrower.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Borrower.pm Auto-merging Koha/Schema/Result/Issue.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Issue.pm Auto-merging Koha/Schema/Result/OldIssue.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/OldIssue.pm Failed to merge in the changes. Patch failed at 0001 Bug 9303 [1] - relative's checkouts in the opac - Schema Updates When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 9303 - relative's checkouts in the opac 28153 - Bug 9303 [1] - relative's checkouts in the opac - Schema Updates 28154 - Bug 9303 [2] - relative's checkouts in the opac - Database Updates 28155 - Bug 9303 [3] - relative's checkouts in the opac 29215 - Bug 9303 [4] [QA Followup] 29302 - Bug 9303 [5] [QA Followup 2] 29303 - Bug 9303 [6] [QA Followup 3] - Rename prefs and field 29304 - Bug 9303 [7] [QA Followup 4] - Undo changes to prog and ccsr themes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 18 23:55:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jul 2014 21:55:42 +0000 Subject: [Koha-bugs] [Bug 12435] Update MARC21 frameworks to Update No. 18 (April 2014) In-Reply-To: <bug-12435-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12435-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12435-70-SVevjpQz92@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12435 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to David Cook from comment #4) > Cool. So it should be easy enough to maintain a XML file going forward since > changes are made by hand? Yes. Latest updates are small :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 02:50:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 00:50:17 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-JTpirHvh58@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #68 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29870&action=edit Bug 766: Remove CGI::scrolling_list from aqplan.pl This patch removes 3 occurences on aqplan.pl To test: 1. You need a budget and a found 2. Apply the patch 3. Go to Aquisitions, click on your found 4. Select one of the options on pulldown Planning e.g. "Plan by months" 5. Now to the left there are two boxes, Filter and Export a) Filter: (1) pulldown below 'Select planning type' check that works selecting other values and submit This pulldown showed originally code types, untranslatable BTW. Added a TT block to allow translation and shows legends that match Planning pulldown, but not the order. b) Export: pulldowns for filetype (2) and delimiter (3) Those have originally one value each, and for me Export does not work, before or after patch, but check that pulldown exist. Notes: A) 5.a) I can change de order of main Planning pulldown, is harcoded. The values for Filter pulldown are sorted on aqplan.pl. Is one or the other. If desired, TT block can be moved to includes/budgets-admin-toolbar.inc (where hardcoded Planning lives) B) 5.b) Moved 'Export' legend inside it's box, like Filter. C) Finally: there is something strange, before or after patch. There is an empty option 'Planning by " if you select planning using main pulldown, it disappears if you select planning using Filter (not a mistery, using Planning fills $auth_cats_loop, using Filter submit button does not) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 02:52:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 00:52:12 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-gAlT7PW1OP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Assignee|jonathan.druart at biblibre.co |bgkriegel at gmail.com |m | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 04:13:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 02:13:18 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-Jlur8R1Ppy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #69 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29871&action=edit Bug 766: Remove CGI::scrollinglist from marctagstructure.pl This patch removes the only instance in this file. Don't know if the feature is of some utility, seems that does not work (no use of auth values as indicators on MARC editor) To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic on MARC structure of any fw 4. Clic Edit on any tag 5. On tag editor check the pulldown 'Authorised value', that was replaced 6. Check for regressions: select a value, save, verify the value, change again, etc. Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories Do not we need an AuthorisedValues.pm? (on C4 or Koha) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 05:45:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 03:45:03 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-FUDwYI5Lqe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #70 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29872&action=edit Bug 766: Remove CGI::scrollinglist from authorised_values.pl This patch removes the only instance in this file. Also fixes array sorting, removes some tabs, removes an unneeded $dbh handler (there is a global one). Makes use of C4::Koha::GetAuthorisedValueCategories. To test: 1. Apply the patch 2. Go to Administration > Authorised values 3. Replaced pulldown next to 'Show category' must show all (present & system) categories correctly ordered. 4. Select some and check for regressions, e.g. CCODE, Bsort2, YES_NO no changes must be observed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 12:36:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 10:36:35 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-BiuXhkISHa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #14 from Eric B?gin <eric.begin at inLibro.com> --- Created attachment 29873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29873&action=edit Bug 11881: (Follow-up) Add the CommasWithLinebreaks and LabelCallNumber classes to Bootstrap them and fix the Call number typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 12:41:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 10:41:04 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-ueQB9GuQw5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Eric B?gin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29873|0 |1 is obsolete| | --- Comment #15 from Eric B?gin <eric.begin at inLibro.com> --- Comment on attachment 29873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29873 Bug 11881: (Follow-up) Add the CommasWithLinebreaks and LabelCallNumber classes to Bootstrap them and fix the Call number typo Another patch will follow with all required files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 12:52:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 10:52:49 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-bSfvHBypZ8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #16 from Eric B?gin <eric.begin at inLibro.com> --- Created attachment 29874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29874&action=edit Bug 11881: (Follow-up) Add the CommasWithLinebreaks and LabelCallNumber classes to Bootstrap them and fix the Call number typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 12:55:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 10:55:03 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-YqmQ33vdnE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Eric B?gin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Eric B?gin <eric.begin at inLibro.com> --- Bootstrap is now supported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 14:07:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 12:07:56 +0000 Subject: [Koha-bugs] [Bug 12611] New: Localisation enchancement in installation procedure Message-ID: <bug-12611-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12611 Bug ID: 12611 Summary: Localisation enchancement in installation procedure Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: egpetridis at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I wonder if it would make sense to add an option in the installation window, asking if the specific koha installation will be used to host latin character records only, or if it will also host biblio entries in other, non-latin-charset languages. The installer would then install/enable/parametrise components [ICU] as needed in order to properly accept, index and search such records. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 15:05:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 13:05:59 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-qjWwETgK0r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29874|0 |1 is obsolete| | --- Comment #18 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 29875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29875&action=edit Bug 11881: (Follow-up) Add the CommasWithLinebreaks and LabelCallNumber classes to Bootstrap them and fix the Call number typo rebased to apply cleanly -- Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 19:46:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 17:46:09 +0000 Subject: [Koha-bugs] [Bug 12612] New: Remove CGI::scrolling_list from auth_tag_structure.pl Message-ID: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12612 Bug ID: 12612 Summary: Remove CGI::scrolling_list from auth_tag_structure.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org We need to remove all of them. New related Bug as requested by RM. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 19:52:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 17:52:04 +0000 Subject: [Koha-bugs] [Bug 12612] Remove CGI::scrolling_list from auth_tag_structure.pl In-Reply-To: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12612-70-80fdvIUdnN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12612 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29876&action=edit Bug 12612: Remove CGI::scrolling_list from auth_tag_structure.pl This patch removes the only instance in this file. Don't know if the feature is of some utility, seems that does not work (no use of auth values as indicators on MARC authority editor) To test: 1. Apply the patch 2. Go to Administration > Authority types 3. Clic on MARC structure of any fw 4. Clic Edit on any tag 5. On tag editor check the pulldown 'Authorised value', that was replaced 6. Check for regressions: select a value, save, verify the value, change again, etc. Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 19:54:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 17:54:21 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-aojob2znd5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12612 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 19:54:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 17:54:21 +0000 Subject: [Koha-bugs] [Bug 12612] Remove CGI::scrolling_list from auth_tag_structure.pl In-Reply-To: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12612-70-biaLnSQ7fy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12612 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Blocks| |766 Assignee|oleonard at myacpl.org |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 20:02:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 18:02:53 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-P2HXHESoch@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29871|0 |1 is obsolete| | --- Comment #71 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29877&action=edit Bug 766: Remove CGI::scrollinglist from marctagstructure.pl This patch removes the only instance in this file. Don't know if the feature is of some utility, seems that does not work (no use of auth values as indicators on MARC editor) To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic on MARC structure of any fw 4. Clic Edit on any tag 5. On tag editor check the pulldown 'Authorised value', that was replaced 6. Check for regressions: select a value, save, verify the value, change again, etc. Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories Do not we need an AuthorisedValues.pm? (on C4 or Koha) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 21:43:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 19:43:56 +0000 Subject: [Koha-bugs] [Bug 12613] New: Remove CGI::scrolling_list from koha2marclinks.pl Message-ID: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12613 Bug ID: 12613 Summary: Remove CGI::scrolling_list from koha2marclinks.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org Another one to remove -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 22:03:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 20:03:00 +0000 Subject: [Koha-bugs] [Bug 12613] Remove CGI::scrolling_list from koha2marclinks.pl In-Reply-To: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12613-70-Ro1RQQe3q0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12613 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29878&action=edit Bug 12613: Remove CGI::scrolling_list from koha2marclinks.pl This patch removes all (2) instances from koha2marclinks.pl. Also changes dropdowns width on mapping editor, from an ugly ragged right to a fixed width view. To test: 1. Apply the patch 2. Go to Administration > Koha to MARC mapping 3. Pulldown in this view has been replaced, check for regressions: change table type and press Ok, verify you get Koha fields and tag/subfield appropriate for each table. 4. Now press 'Edit' on any field, go into mapping editor 5. Check that all pulldowns show tag/subtags relevant for each group ( 000s ... 900s ) 6. Check that current mapping is displayed correctly 7. Check for regressions: unmap, remap, press Ok, verify, change again. 8. If you can, check display of mapping editor on several browsers, just in case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 22:08:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 20:08:59 +0000 Subject: [Koha-bugs] [Bug 12613] Remove CGI::scrolling_list from koha2marclinks.pl In-Reply-To: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12613-70-sTlO6hsnZk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12613 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|oleonard at myacpl.org |bgkriegel at gmail.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 22:09:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 20:09:57 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-oKGIsNigkA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12613 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 19 22:09:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 20:09:57 +0000 Subject: [Koha-bugs] [Bug 12613] Remove CGI::scrolling_list from koha2marclinks.pl In-Reply-To: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12613-70-nsQ4G0aFTz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12613 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |766 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 01:57:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jul 2014 23:57:59 +0000 Subject: [Koha-bugs] [Bug 12614] New: Remove CGI::scrolling_list from auth_subfields_structure.pl Message-ID: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Bug ID: 12614 Summary: Remove CGI::scrolling_list from auth_subfields_structure.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org Many to remove in this file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 03:30:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 01:30:24 +0000 Subject: [Koha-bugs] [Bug 12614] Remove CGI::scrolling_list from auth_subfields_structure.pl In-Reply-To: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12614-70-KJ7eqa4sr3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29879&action=edit Bug 12614: Remove CGI::scrolling_list from auth_subfields_structure.pl This patch removes all instances on this file. Even removes some commented out instances. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > Authority types 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 031 5. Clic 'Edit subfields' button Now the tests proper 6. 'Help input' box (editor bottom): Eight(8) scrolling_list removed, they use to feed the four pulldowns, so check each one 'Koha field' is new (for me at last) 'Authorised value', 'Thesaurus' (is this valid/useful here?) 'Plugin' There is a difference between existing subtags and a new subtag, the 'id' of the pulldowns (so the 8 scrolling list removed) Check assign/remove/save/load values, search for regressions If you edit subtag 942, it has a value on kohafield (default fw) I think that this box could be prettified with fixed width for pulldowns. 7. No more functional tests, there are 4 scrolling_list removed that are commented (removed also commented code on tt file), and two instances that are similar to previously removed instances, evidently with no effect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 03:32:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 01:32:43 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-CTnEr06Hqc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12614 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 03:32:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 01:32:43 +0000 Subject: [Koha-bugs] [Bug 12614] Remove CGI::scrolling_list from auth_subfields_structure.pl In-Reply-To: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12614-70-xNe7dz7qDB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Blocks| |766 Assignee|oleonard at myacpl.org |bgkriegel at gmail.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 15:31:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 13:31:54 +0000 Subject: [Koha-bugs] [Bug 12615] New: Remove CGI::scrolling_list from marc_subfields_structure.pl Message-ID: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Bug ID: 12615 Summary: Remove CGI::scrolling_list from marc_subfields_structure.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org Many instances to remove in this file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 18:58:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 16:58:26 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-0jAQS99AMl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I can't get this to work, even with Matthias help it seems. I'd be glad if someone else willing to test could contact Matthias for the required certificate and give this a try. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 19:35:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 17:35:09 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12224-70-9T47PsvHp0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I really like this new feature and it works pretty well already. I have some small things for a follow-up: 1) Entry in the print pull down in circ After checking with a native speaker (I didn't want to suggest something wrong) I think "Print check-in slip" or "Print today's check-in slip" would be better than "Print checked-in today -slip". 2) The new notice template formats the title information quite differently to the "check-out" slip, here for comparison: ISSUESLIP: <checkedout> <p> <<biblio.title>> <br /> Barcode: <<items.barcode>><br /> Date due: <<issues.date_due>><br /> </p> </checkedout> New CHECKINSLIP: <checkedin> <li><<biblio.author>>: <<biblio.title>><br> Barcode: <<items.barcode>><br> </checkedin> Not going to argue about <p> vs. <li>, although I personally prefer the first, but I think the <<biblio.author>>: is problematic. Lots of records don't have a first author in 100 and then the printed information is a bit ugly. If you want t include the author. Maybe just having the title and no : is a bit safer here. But this is not a blocker, just noticing as my example record didn't have an author. 3) Please include the new sample template in the installers for the other languages. Without the template the print will fail and people won't know the code to use for the new notice. Better to have an English template that can be easily modified. 4) Misses unit tests for the new routines... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 19:45:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 17:45:18 +0000 Subject: [Koha-bugs] [Bug 12519] Convert OPAC list download pop-up to modal dialog In-Reply-To: <bug-12519-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12519-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12519-70-L5vEhK2NSR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12519 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 19:45:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 17:45:21 +0000 Subject: [Koha-bugs] [Bug 12519] Convert OPAC list download pop-up to modal dialog In-Reply-To: <bug-12519-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12519-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12519-70-b0VXTRiQ5Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12519 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29691|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29880&action=edit [PASSED QA] Bug 12519 - Convert OPAC list download pop-up to modal dialog This patch changes the OPAC list download process so that the download link triggers a modal dialog instead of a pop-up window. This streamlines the process a little bit and makes it work better on mobile devices. The download list page has been altered so that it works better as a standalone page, as it might be seen if JavaScript is disabled. Simple form validation has been added to help prevent submission of the form without choosing a format. To test the virtualshelves system preference must be enabled. - View an existing list in the OPAC and click the "download list" link. - A modal dialog should be displayed with the download form. - Submitting the form without selecting a format should trigger either a browser-based form validation error (in HTML5-supporting browsers) or a JavaScript alert (if your browser doesn't support the "required" attribute. - Choosing a download format and submitting the form should close the dialog and trigger the correct download. - Clicking the "Cancel" link should close the dialog. Test with JavaScript disabled: - Clicking the "download list" link should take you to a page which contains the same form which appeared in the modal dialog. - Submitting the form without selecting a format should trigger either a browser-based form validation error (in HTML5-supporting browsers) or a JavaScript alert (if your browser doesn't support the "required" attribute.. - Choosing a download format and submitting the form should result in the corect download. - Clicking the "Cancel" link should return you to the correct list. Signed-off-by: Aleisha <aleishaamohia at hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes QA script and tests, works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 20:08:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 18:08:26 +0000 Subject: [Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms. In-Reply-To: <bug-11961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11961-70-2MY5e2cwPj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 26516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26516 [SIGNED-OFF] Add a "Z39.50 search" button to the authority creation and modification pages. Review of attachment 26516: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11961&attachment=26516) ----------------------------------------------------------------- Hi Eric, I have used the splinter review to add my comments. I like this addition, please provide a follow-up. ::: authorities/authorities.pl @@ +344,4 @@ > return int(rand(1000000)); > } > > +=item GetMandatoryFieldZ3950 Hard coding the fields in many places is a problem - please refactor so that it is using the same method as GuessAuthTypeCode. It also needs to be MARC agnostic (support UNIMARC) and have unit tests. ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt @@ +201,4 @@ > <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page %]" size="4" /><input type="submit" name="changepage_goto" onclick="return validate_goto_page();" value="Go" /> > </form> > > +<p><form method="get" action="/cgi-bin/koha/cataloguing/z3950_auth_search.pl"><input type="hidden" name="authid" value="[% authid %]" /><input type="submit" value="Try Another Search"/></form></p> Please fix the capitalization here (I know it was wrong before, but this is a good moment to do it). @@ +214,4 @@ > </div> > [% END %] > <div class="dialog message">Nothing found.</div> > + <p><form method="get" action="/cgi-bin/koha/cataloguing/z3950_auth_search.pl"><input type="hidden" name="authid" value="[% authid %]" /><input type="submit" value="Try Another Search"/></form></p> Also here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 20:08:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 18:08:33 +0000 Subject: [Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms. In-Reply-To: <bug-11961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11961-70-qhVOWS84Uz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 20:29:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 18:29:51 +0000 Subject: [Koha-bugs] [Bug 10308] Authorities linker should handle the "local subject added entry" fields. In-Reply-To: <bug-10308-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10308-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10308-70-vjpzLBkddS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 20:29:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 18:29:53 +0000 Subject: [Koha-bugs] [Bug 10308] Authorities linker should handle the "local subject added entry" fields. In-Reply-To: <bug-10308-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10308-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10308-70-ENsKJOeKXn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29157|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29881&action=edit [PASSED QA] Bug 10308 - local subjects can use authorities too This adds entries for 690-699 to the authorities linker, so they get linked up like everything else. To Test: * make sure your framework doesn't have 690 set up to link to authorities (or it'll get linked as part of cataloguing.) * add a subject with some term to the 690$a field. * add an authority for TOPIC_TERM with the matching term. * make sure zebra is up to date. * run link_bibs_to_authorities.pl over your system. * check that the authority is now linked to your record. * repeat with the other 69x fields if you like. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Tested using 696a (PERSO_NAME). Works as described, no errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> This works as described, but linked authorities won't search correctly when clicking on the link on the detail page, as the 69x $9 is not indexed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 20:48:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 18:48:42 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: <bug-12285-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12285-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12285-70-5t1eOKSaXe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 29692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29692 Bug 12285: Allow easy printing of patron's fines. Review of attachment 29692: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12285&attachment=29692) ----------------------------------------------------------------- Hi Pasi, I have added my comments using Splinter review, hope everything is clear. Again, I really like the idea of this and hope you can provide a follow-up. Addition to Splinter comments: Please include the new notice template in the translated sample_notices.sql as well. Leaving them in English is fine. ::: C4/Members.pm @@ +2406,5 @@ > ); > } > > + > +sub GetBorrowerFines { I am not sure this one is needed - why not use GetMemberAccountRecords? If we are to keep this one, please point out why it's more useful and add unit tests and documentation (POD). @@ +2422,5 @@ > + my $data = $sth->fetchall_arrayref({}); > + return $data; > +} > + > +sub FineSlip { Needs unit tests. ::: installer/data/mysql/en/mandatory/sample_notices.sql @@ +143,5 @@ > Your library.' > ); > + > +INSERT INTO letter (module, code, branchcode, name, is_html, title, content, message_transport_type) > +VALUES ( 'circulation', 'FINESLIP', '', 'Patron fines -slip', '1', 'Fines', '<<borrowers.firstname>> <<borrowers.surname>><br> I think 'Fines and fees slip' would maybe be better. @@ +149,5 @@ > +Fines: <<total.fines>> > +<ul> > +<fines> > +<li><<fines.date_due>>, <<fines.amount>><br> > +Bar code: <<items.barcode>><br> Small typo - barcode, please fix. ::: installer/data/mysql/updatedatabase.pl @@ +8573,5 @@ > +$DBversion = "3.17.00.XXX"; > +if ( CheckVersion($DBversion) ) { > + $dbh->do(" > +INSERT INTO letter (module, code, branchcode, name, is_html, title, content, message_transport_type) > +VALUES ( 'circulation', 'FINESLIP', '', 'Patron fines -slip', '1', 'Fines', '<<borrowers.firstname>> <<borrowers.surname>><br> Please fix the name here too. @@ +8579,5 @@ > +Fines: <<total.fines>> > +<ul> > +<fines> > +<li><<fines.date_due>>, <<fines.amount>><br> > +Bar code: <<items.barcode>><br> Small typo, please fix. ::: koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc @@ +129,4 @@ > [% IF ( CAN_user_borrowers ) %]<li><a id="printsummary" href="#">Print summary</a></li>[% END %] > <li><a id="printslip" href="#">Print slip</a></li> > <li><a id="printquickslip" href="#">Print quick slip</a></li> > + <li><a id="printfineslip" href="#">Print fines</a></li> Maybe print fines and fees? Just a suggestion, not blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 20:48:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 18:48:47 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: <bug-12285-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12285-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12285-70-BKkuAyYLMR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:03:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:03:38 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11373-70-5WJNVOtuPK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am sorry, but this doesn't seem to work for me. I have added various fines and fees to my patron account. Then I chose "Pay amount" and changed the collected from patron value to be higher than the total amount owed. I didn't see anything telling me how much change to give back to the patron. The open fines were paid and the additional money was 'lost'. The same happens for paying individual fines. Please retest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:56:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:56:27 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-4RPsKnEe47@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #78 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29882&action=edit [PASSED QA] Bug 10212: Columns configuration for tables This development introduces ColVis into Koha and provides a configuration page for columns visibility. ColVis is a plugin for DataTables. It allows to change the visibility of the columns in the table. * This development adds: - the js and css file for ColVis - a new DB table 'columns_settings' - a new template plugin 'ColumnsSettings' - a new package C4::Utils::DataTables::ColumnsSettings - a new admin page admin/columns_settings.pl * How it works: A yaml file is created (admin/columns_settings.yml) in order to take an inventory of all tables where ColVis is implemented. This file is read to create the list of modules, pages and tables in the configuration page. There are 3 possible keys in the yml: - is_hidden: default is 0 The column will be hidden. - cannot_be_toggled: default is 0. ColVis will allow to hide/show the column. - cannot_be_modified: default is 0 Default values (in the yml) won't be modifiable. When a user changes (or saves) the configuration for one module, all columns are added to the DB table. The values in the DB get the upper hand on the yaml values. * Humm, strange? It seems weird to have 2 storages for the same values. But I think it will be easy to add an entry and maintain the yaml rather than adding a new row (and new entry in updatedatabase script) in the DB. * To go further: We can imagine that the configuration is saved for each user (and not globally like it is made with this patch). This patch cannot be tested as it, you need to apply the "POC" patch. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes all tests and QA script, more comments on last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:56:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:56:33 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-Lc1J31IZjY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #79 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29883&action=edit [PASSED QA] Bug 10212: Columns configuration for tables - DB changes Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:56:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:56:38 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-I9iZo04f2m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #80 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29884&action=edit [PASSED QA] Bug 10212: Columns configuration for tables - Unit tests test plan: Verify the prove t/db_dependent/ColumnsSettings.t returns green. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:56:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:56:44 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-RfIFm45nNZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #81 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29885&action=edit [PASSED QA] Bug 10212: Columns configuration for tables - Add Colvis files This patch only adds Colvis js and css files. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:56:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:56:49 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-U17nbPqYUf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #82 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29886&action=edit [PASSED QA] Bug 10212: Columns configuration for tables - POC This patch proves that this feature is useful with a concret use case. Test plan: 1/ Execute the updatedatabase in order to create the new table. 2/ Take a look to the yml structure. 3/ Go on the admin currency page (admin/currency.pl). 4/ Check that you cannot hide the 2 first columns on the table. 5/ Try to hide/show columns. 6/ Go on the columns configuration page (admin/columns_settings.pl). 7/ Only the admin tab are filled with data. Check/uncheck checkboxes and save. 8/ Go on the admin currency page and check that the behavior is what you expected. 9/ Give me some feedback :) Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:56:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:56:53 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-D79QQLhFfs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #83 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29887&action=edit [PASSED QA] Bug 10212: Add Colvis to the about page Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:56:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:56:56 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-mKCJaP6u5v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #84 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29888&action=edit [PASSED QA] Bug 10212: Move colvis files to the include file Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes all tests and QA script. Implements the option to change the default columns that appear in a table while giving the user the option to change the columns individually for a session. As an example, this feature is implemented for the currencies table. Works well for all possible combinations in configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:57:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:57:46 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-ngUqDkNUNt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:57:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:57:49 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-NOVQ1kZ761@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29836|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:57:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:57:52 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-0XJctRmHUe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29837|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:57:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:57:56 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-a5ky2HqT5u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29838|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:57:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:57:59 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-usSgbcMfKK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29839|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:58:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:58:02 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-oWf6sandnc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29840|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:58:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:58:05 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-hlvx9FM0MC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29841|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 21:58:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 19:58:08 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-QdTMy5ugl4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29842|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 22:18:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 20:18:54 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-0JiX8jvQcn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #81 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am going to pass this in order to not risk more conflicts - but there is something small that should be fixed in a follow up on a separate bug. The dialog says (Y) and (N) in the submit buttons, but those keyboard shortcuts don't work and should be removed or made working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 22:19:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 20:19:31 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-jlDOGOTWFt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 22:19:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 20:19:35 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-xn25eabyms@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29661|0 |1 is obsolete| | Attachment #29662|0 |1 is obsolete| | Attachment #29663|0 |1 is obsolete| | Attachment #29664|0 |1 is obsolete| | Attachment #29665|0 |1 is obsolete| | Attachment #29698|0 |1 is obsolete| | --- Comment #82 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29889&action=edit [PASSED QA] Bug 7162: Factorize code for order cancellation Some code was duplicated, all is now in cancelorder.pl Added possibility to provide a reason for cancellation (or other things, this is saved in aqorders.notes) Signed-off-by: Corinne Bulac <corinne.hayet at bulac.fr> Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Comments on last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 22:19:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 20:19:54 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-grrKUcFBN5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #83 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29890&action=edit [PASSED QA] Bug 7162 [Follow-up] Fix referrer URL when coming from parcel.pl Signed-off-by: Corinne Bulac <corinne.hayet at bulac.fr> Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 22:20:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 20:20:05 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-rthlGehrDO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #84 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29891&action=edit [PASSED QA] Bug 7162; Factorize code for order cancellation (QA fixes) * Remove tab characters in acqui/addorder.pl * Remove FIXME in acqui/cancelorder.pl * Fix typos: "canceled" -> "cancelled", "occured" -> "occurred" * Replace "Click here" link by "OK" * Add a column to aqorders to store cancellation reason instead of having it in aqorders.notes, to avoid having untranslatable strings in database Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 22:20:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 20:20:23 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-dmqLL2sYmf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #85 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29892&action=edit [PASSED QA] Bug 7162: Add unit tests for DelOrder Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 22:20:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 20:20:35 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-1su6taejsp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #86 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29893&action=edit [PASSED QA] Bug 7162: Factorize code for order cancellation (QA fixes) Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes tests and QA script. Checked cancelling the orders from the basket and from the receive page. Both worked nicely. Cancellation reason is shown on the cancelled order line in the basket. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 22:21:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 20:21:13 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-o1zQen8nl7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #87 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29894&action=edit [PASSED QA] Bug 7162: (follow-up) Add unit tests for DelOrder The unit tests did not take into account the new DB field. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes all tests and QA script. Also all Acquisition related patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 22:38:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 20:38:37 +0000 Subject: [Koha-bugs] [Bug 11842] MARC framework editing is broken when memcache is enabled In-Reply-To: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11842-70-pDnTEcIPq6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11842 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I haven't tried using memcache/caching in ages. What's required to set it up on a git dev installation? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 22:56:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 20:56:24 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: <bug-9156-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9156-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9156-70-bjjN4ruuVS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3426 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think what I'd try is adding a 090 with all the listed subfields to a record. Then set itemcallnumber to 090abvy and create an item from the record. It should pull all subfields. Bug 3426 seems similar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 22:56:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 20:56:24 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: <bug-3426-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3426-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3426-70-YPdFjZbFDX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9156 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:03:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:03:54 +0000 Subject: [Koha-bugs] [Bug 5992] Biblibre various improvements for 3.4 In-Reply-To: <bug-5992-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5992-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5992-70-2ClWNDSdgP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5992 Bug 5992 depends on bug 5633, which changed state. Bug 5633 Summary: import borrower, add command line option http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5633 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:03:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:03:53 +0000 Subject: [Koha-bugs] [Bug 12598] Allow tools/import_borrowers.pl to be used from the command line. In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-YMe2x8WW17@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 5633 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:03:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:03:53 +0000 Subject: [Koha-bugs] [Bug 5633] import borrower, add command line option In-Reply-To: <bug-5633-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5633-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5633-70-EbTlSCSwr5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5633 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- As the patch here is obsoleted, I mark it as duplicate of 12598 that has a new patch. *** This bug has been marked as a duplicate of bug 12598 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:10:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:10:39 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: <bug-5342-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5342-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5342-70-JOVS97XFPc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com --- Comment #66 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 12602 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:10:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:10:39 +0000 Subject: [Koha-bugs] [Bug 12602] Claim counter in serials In-Reply-To: <bug-12602-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12602-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12602-70-ptW1Z5rrDc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12602 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 5342 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:12:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:12:09 +0000 Subject: [Koha-bugs] [Bug 12598] Allow tools/import_borrowers.pl to be used from the command line. In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-UkeMP3Ja0j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Kyle, I think this is a duplicate to bug 5633. There it was pointed out that normal scripts should not be command line scripts at the same time. Could you move this functionality into a separate command line script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:12:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:12:47 +0000 Subject: [Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber In-Reply-To: <bug-12323-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12323-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12323-70-1ZYNTOV6y4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This one is really confusing to me - can someone else give this a try please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:21:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:21:50 +0000 Subject: [Koha-bugs] [Bug 10155] Patron search should remember search options selected In-Reply-To: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10155-70-LOB31e7Loq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10155 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:21:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:21:53 +0000 Subject: [Koha-bugs] [Bug 10155] Patron search should remember search options selected In-Reply-To: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10155-70-6qTazI7a01@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10155 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29696|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29895&action=edit [SIGNED OFF] Bug 10155: Patron search should remember search type options selected The search type reset to the default. Test plan: 1/ go on the patrons home page 2/ Launch a search in the header and select the second value for "search type" ("contains"). 3/ Verify the search type is set to "contains" on the results page. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:22:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:22:51 +0000 Subject: [Koha-bugs] [Bug 10158] sorting serial issues In-Reply-To: <bug-10158-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10158-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10158-70-ZQ1LrLJcIe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10158 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- >From the screenshot I think the problem is a different one, closing WORKSFORME. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:32:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:32:09 +0000 Subject: [Koha-bugs] [Bug 12572] Use jQueryUI Accordion to display message transport types In-Reply-To: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12572-70-4GhpqiR56h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:32:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:32:11 +0000 Subject: [Koha-bugs] [Bug 12572] Use jQueryUI Accordion to display message transport types In-Reply-To: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12572-70-QrWfwH2bkk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29680|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29896&action=edit [SIGNED OFF] Bug 12572 - Use jQueryUI Accordion to display message transport types The notice edit view has separate sections for each of the various message transport types. This patch groups them in a jQueryUI accordion to simplify the view. Also changed: Some label/id pairs have been changed to eliminate duplicate ids. To test, apply the patch an edit any notice under Tools -> Notices & Slips. - The message transport type fields for email, feed, phone, etc. should be correctly grouped in a collapsed accordion. The acccordion should look correct and work correctly. - Clicking the label for any form field should correctly highlight the corresponding field. - Submitting updates to the notice should work correctly for all message transport types. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> This works as subscripted. Something small: the top border of the uncollapsed/opened section doesn't display correctly, but this is working a lot nicer than before, as now changing a message requires a lot less scrolling. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:35:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:35:17 +0000 Subject: [Koha-bugs] [Bug 5590] error message on holds not consistent In-Reply-To: <bug-5590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5590-70-j5V446Tclb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5590 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- There is a system preference for this: AllowHoldsOnPatronsPossessions I think the problem is, that if the record is one with different volumes or serial issues, placing a hold on something the patron has already checked out should be possible. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:39:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:39:05 +0000 Subject: [Koha-bugs] [Bug 4927] OPAC advanced search has two call number entries; remove one? In-Reply-To: <bug-4927-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4927-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4927-70-Aj9YYQsI8Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4927 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This is still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:41:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:41:05 +0000 Subject: [Koha-bugs] [Bug 12538] Solr removal In-Reply-To: <bug-12538-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12538-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12538-70-grV7FvOtdq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Blocks| |10992 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:41:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:41:05 +0000 Subject: [Koha-bugs] [Bug 10992] Error using solr search engine In-Reply-To: <bug-10992-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10992-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10992-70-wTZorzViED@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10992 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12538 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:43:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:43:27 +0000 Subject: [Koha-bugs] [Bug 3673] Pazpar2 integration In-Reply-To: <bug-3673-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3673-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3673-70-ynCeNTXBz6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3673 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 10486 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:43:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:43:27 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10486-70-ObEWhGgtbl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #88 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 3673 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:45:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:45:02 +0000 Subject: [Koha-bugs] [Bug 9793] clear screen option for advanced search In-Reply-To: <bug-9793-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9793-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9793-70-QbUtuCc8Vu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9793 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- There is a 'new search' link, that does refresh the page, but it will also set you back to 'less options' when you had 'more options' activated, which is a bit annoying. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:53:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:53:01 +0000 Subject: [Koha-bugs] [Bug 12616] New: Locale in subscriptions should not default to English when empty Message-ID: <bug-12616-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Bug ID: 12616 Summary: Locale in subscriptions should not default to English when empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The locale field in subscriptions currently defaults to empty, with a note that in this case English will be used automatically. If it really defaults to English, then it would make sense to offer an option to preselect it to the currently selected template language or to a language chosen in configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:53:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:53:32 +0000 Subject: [Koha-bugs] [Bug 12616] Locale in subscriptions should not default to English when empty In-Reply-To: <bug-12616-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12616-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12616-70-WM3T63hwxl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Note: in our 3.16.1 installation it always defaults to "Urdu"... I was not able to reproduce this in master, but have seen it multiple times when testing and presenting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 20 23:53:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 21:53:52 +0000 Subject: [Koha-bugs] [Bug 12616] Locale in subscriptions should not default to English when empty In-Reply-To: <bug-12616-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12616-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12616-70-mmrOsECpmy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com Component|Templates |Serials Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 00:04:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 22:04:17 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-EIdQTzMok7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Bernardo, I'd love to test this - could you rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 00:09:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 22:09:51 +0000 Subject: [Koha-bugs] [Bug 12615] Remove CGI::scrolling_list from marc_subfields_structure.pl In-Reply-To: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12615-70-xyBBXaPc2a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29897&action=edit Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl This patch removes all instances on this file. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 020 5. Clic 'Edit subfields' button Now the tests proper 6. On any subfield, check pulldown 'Managed in tab', was replaced, so test if it works and search for regressions Change, save, load, change again 7. Clic on 'Other options' box Eight(8) scrolling_list removed, they use to feed the four pulldowns, so check each one 'Koha field' is new (for me at last) 'Authorised value', 'Thesaurus' (is this valid/useful here?) 'Plugin' Check assign/remove/save/load values, search for regressions Check adding a new subfield -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 00:10:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 22:10:59 +0000 Subject: [Koha-bugs] [Bug 12615] Remove CGI::scrolling_list from marc_subfields_structure.pl In-Reply-To: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12615-70-J30e8ef5qE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|oleonard at myacpl.org |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 01:46:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jul 2014 23:46:39 +0000 Subject: [Koha-bugs] [Bug 11842] MARC framework editing is broken when memcache is enabled In-Reply-To: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11842-70-GwusLNeQLR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11842 --- Comment #6 from Robin Sheat <robin at catalyst.net.nz> --- (In reply to Katrin Fischer from comment #5) > I haven't tried using memcache/caching in ages. What's required to set it up > on a git dev installation? Install memcache and then add some SetEnv lines to your apache config, e.g. SetEnv MEMCACHED_SERVERS 127.0.0.1:11211 SetEnv MEMCACHED_NAMESPACE koha make sure memcached is actually running, and it should just start working. There's a script that comes with memcache that lets you dump all its contents which is handy to see that it's actually being used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 02:03:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 00:03:16 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-xQoexw5CU9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27687|0 |1 is obsolete| | --- Comment #31 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29898&action=edit Bug 12017 - 1 - Move language description out of database This patch adds identical copies of languages.inc file on include dirs, and modifies include files to process it. To test: 1. No change on current behavior must be observer, any page staff/opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 02:03:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 00:03:24 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-fu7yqf1PPL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27688|0 |1 is obsolete| | --- Comment #32 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29899&action=edit Bug 12017 - 2 - Enable languages on web installer This patch modifies installer/step1.tt to use new language descriptions. Only parameter used is rfc4646 code. To test: 1. Do some fake translations, for example all langs for l in $(cd misc/translator/po; ls *-pref.po | sed 's/-pref.po//'); do mkdir koha-tmpl/intranet-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/bootstrap/$l; mkdir koha-tmpl/opac-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/ccsr/$l; done or make some lang dirs on intranet-tmpl/prog 2. Apply the patch 3. Edit your koha-conf.xml, change database name to a new name, create that database and grant access, reload staff page, log in with database user, you will be redirected to step1 of web installer. 4. Check names and codes for installed languages. Revert to your old database before proceed, but left dirs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 02:03:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 00:03:32 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-i8tPGESjCx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27689|0 |1 is obsolete| | --- Comment #33 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29900&action=edit Bug 12017 - 3 - Change lang display on sysprefs I18N This patch change the display of languages on sysprefs to set translated languages on I18N Only parameter used is rfc4646 subtag To test: 1. Apply the patch 2. Go to I18N syspref, look language descriptions Following steps are for next patch 3. Set a bunch of languages for staff/opac, save, reload Inlude vi-VN for which there is no current description in databasse 4. Set opaclanguagesdisplay to Allow Current display is preserved, native description for languages outside group, and script/region for language groups Only change is languages ordered by rfc4646 subtag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 02:03:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 00:03:38 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-6SJqFGPATt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27690|0 |1 is obsolete| | --- Comment #34 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29901&action=edit Bug 12017 - 4 - Change language changers This patch modifies language changers on staff/opac Only parameter used is rfc4646 To test: 1. Apply the patch 2. Reload staff and opac (prog/ccsr/bootstrap) 3. Check display of language changers 4. Do a real translation and check language change works Do not change language unless you did a real translation Only change in display is showing only regions for sublanguages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 02:03:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 00:03:47 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-cFBadhd3vV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27691|0 |1 is obsolete| | --- Comment #35 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29902&action=edit Bug 12017 - 5 - Change local use syspref type Language This patch changes local use syspref of type Language Currently this type of syspref is not used, and shows currently translated staff languages. It's values can't be changed. To make something useful, this kind of syspref is changed to show all langs and save iso639_2 codes. And they not use descriptions on database, only rfc4646 codes from templates. It's easy to add new kinds that save rfc4646 codes, or only show translated languages. To test: 1. Apply the patch 2. Go to system preferences, local use 3. Define a new syspref, any name/description, type 'Language', Save 4. New syspref is showed as a multiple selection of iso639_2 codes with current lang and native names. Check that 5. Select some values, save, check they are saved and restored 6. Edit, similar view, change values, save, check 7. Delete test syspref Values are stored as ',' separated values Verify in database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 02:03:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 00:03:52 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-hooupfyhuw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27692|0 |1 is obsolete| | --- Comment #36 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29903&action=edit Bug 12017 - 6 - Change syspref AdvancedSearchLanguages Bug 10986 introduces a way of limiting advanced search languages list. It's a good feature, but to fill the preference you need to list iso639_2 codes. And there is no way to get the list of all codes again as before, and language descriptions are taken from database. This patch changes that preference so it's now a Local syspref, to present an interface to set it's value. Also adds another syspref to control if language chooser is limited at all, recovering previous behavior. As per comments on Bug 10986 language list shows translated and native names and is ordered by iso639_2 code To test: 1. Apply the patch 2. Run updatedatabase.pl 3. Go to system preferences, Searching, new syspref LimitAdvancedSearchLanguages, on by default 4. Go to Local use sysprefs, AdvancedSearchLanguages is now here with interface to set it's values 5. Check language limit on advanced search on staff and opac (any theme) 6. Disable limit and chech language list 7. Enable limit and set different languages on syspref, check language list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 02:03:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 00:03:57 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-1vFqluCu8G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27693|0 |1 is obsolete| | --- Comment #37 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29904&action=edit Bug 12017 - 7 - Remove function getFrameworkLanguages [ Note: From now on dependence on language descriptions in database is about to be removed, also some code cleaning.] This must be an old relic, not used anymore. To test: 1. Check use of getFrameworkLanguages egrep -Rl getFrameworkLanguages * No result save for definition file 2. Apply the patch 3. check again, no results Reason for removing this function is that it's not used and tries to send languages descriptions from database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 02:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 00:04:03 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-epOwf9rQRQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27694|0 |1 is obsolete| | --- Comment #38 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29905&action=edit Bug 12017 - 8 - Remove use of getAllLanguages from installer getAllLanguages is only used on installer/install.pl, and some tests. Result parameters are passed to C4/Install.pm, but its use is futile, language check on Installer.pm uses parameters that are not present on return value of getAllLanguages, and returned value fwk_code is undefined To test: 1. Apply the patch 2. Do translated install (eg using de-DE or es-ES) a. translate first, b. then create a new database, c. grant permissions, d. change koha-conf to use new db, e. reload staff, f. proceed to web install, g. select translated language, h. use marc21, i. finish, 3. Login and check that marc frameworks are translated The translated install must proceed without problems. Removed only the very first occurence of template parameter fwk_language because of it's null value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 02:04:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 00:04:09 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-fWgHI4p3e4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27695|0 |1 is obsolete| | --- Comment #39 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29906&action=edit Bug 12017 - 9 - Remove use of language_get_description function This patch removes every use of language_get_description function. This function retrieves lang names from database To test: 1. Functionality removed by this patch do not affect anything, because previous patches are only using rfc4646_subtag value, not values stored in database. 2. Removed import from Templates.pm, not used there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 02:04:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 00:04:15 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-wHdh86HYdt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27696|0 |1 is obsolete| | --- Comment #40 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 29907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29907&action=edit Bug 12017 - 10 - Remove description from getLanguage This patch rewrites getLanguage function. This function is of not much use, but is rewrited to takes its data from language_rfc4646_to_iso639 table. To test: 1. Apply the patch 2. Only place that use this function is t/db_dependent/Languages.t so run the test and check that it pass 3. To compare the output pre and post patch you can run perl -e 'use C4::Languages; use Data::Dumper; $a = getLanguages(); print Dumper $a;' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 02:17:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 00:17:33 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-rw67N41ruI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #41 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Rebased on master :) To test I suggest to apply all patches and then follow each test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 02:19:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 00:19:42 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-Q5HkQrSKLX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #42 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Sorry, Needs Signof -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 08:40:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 06:40:08 +0000 Subject: [Koha-bugs] [Bug 12617] New: Koha should let admins to configure automatically generated password complexity/difficulty Message-ID: <bug-12617-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 Bug ID: 12617 Summary: Koha should let admins to configure automatically generated password complexity/difficulty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jseppal at student.uef.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently, the suggested passwords generated by members/member-password only honor the minimum password length configuration setting - we've had some discussions in my library that we'd want to be able to configure the suggested passwords - not only in terms of length, but also in terms of complexity/difficulty. This could be easily achieved by adding new global configuration setting and refactoring the current password generation to use a standard random string generator library from the cpan - such as Data::Random or something similiar. see also: bug 11888 - I looked into enhancing the password generation while preparing this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 09:28:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 07:28:45 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-pQCuIvdMga@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 09:28:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 07:28:47 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-JTgO7e9CfN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 --- Comment #6 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 29908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29908&action=edit Bug 12457: Allow UT on a non empty database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 09:34:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 07:34:22 +0000 Subject: [Koha-bugs] [Bug 12598] Allow tools/import_borrowers.pl to be used from the command line. In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-2kGJCxVCYY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 09:40:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 07:40:02 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-CbVO66X867@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 09:40:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 07:40:05 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-dPYco50fst@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26311|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 29909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29909&action=edit Bug 10542: Fix QueryParser with OpacSupression OpacSupressions manipulates the query string after the buildQuery call and so breaks with queryParser enabled. This patch adds checks for queryParser and manipulates the query before passing it to buildQuery if it is enabled, but leaves the post buildQuery manipultation when queryParser is disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 09:43:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 07:43:42 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-tyzg3f4cBe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- dcook, thanks for all your efforts on this one. I've made the suggested changes, I think, and am currently proving the process to myself too, but thought it worth posting up this trivial amendment for others to start testing sooner rather than later. I'm now trying to work out all the ways in which this should be tested to repvent a regression... I'm thinking. Testing with and without QP turned on, with and without OpacSupressions turned on, and testing from both the front page search and the advanced search pages. Combinations of all those should close the door on a regression right? Is there anywhere I've missed in terms of sending different queries down the pipe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 09:45:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 07:45:18 +0000 Subject: [Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty In-Reply-To: <bug-12617-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12617-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12617-70-9ms4wdrVRB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 09:49:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 07:49:00 +0000 Subject: [Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks In-Reply-To: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12477-70-vU0jKQhOw1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 --- Comment #7 from David Cook <dcook at prosentient.com.au> --- (In reply to Bernardo Gonzalez Kriegel from comment #6) > Created attachment 29869 [details] > Loader for XML files > > This new attach has a variant of XML files, with one element to represent > data types, and a simple script to load the values into Koha database. > > I tried $dbh->do() for each value, or a prepare() and then execute(), but is > too slow. It builds a single string with all values to insert, similar as > the SQL files for frameworks. > > In my tests the script takes a little more than three times as long as mysql > client to load default framework (tags/subtags), but is a difference between > ~0.7s and ~2.5s, perhaps acceptable... As you said before, the speed shouldn't matter too much if it's only being run during initial install and then during rare subsequent updates. I've been playing today with your XML files, and have been working on a script for updating existing frameworks using Koha::Database/DBIx::Class. The "find_or_new" method is quite useful in that case, as it'll insert new rows and it'll give you a chance to do further actions for rows that already exist (using the primary key as a reference point). At the moment, I have it set up to add missing fields/subfields, and update the "repeatable" column for existing fields if the XML values are different. I'm going to add an option for updating "libopac" and "liblibrarian" as well. I figure some libraries use custom text so they might not necessarily want to override it according to the MARC specification. Anyway... -- I can put together a demo DBIC loader for the default framework XML, but I'm wondering now how we want to handle installing the other sample frameworks. I took a look at bug 10963 and it looks really good. I like the idea you're going with. I'm thinking maybe something like this: http://search.cpan.org/~ribasushi/DBIx-Class-0.08270/lib/DBIx/Class/ResultSet.pm#Multiple_queries my $framework = $schema->resultset('MarcTagStructure')->search({ frameworkcode => '', }); then... $framework->create({ frameworkcode => 'SR' }); $framework->create({ frameworkcode => 'BKS' }); Then probably some updates to change the hidden values. I'm not sure where we would want to store the data about which subfields to hide in which framework though. I suppose we could hard-code it into the script, but it might be nicer to keep that information in a config file. Not 100% sure what the best way to update the hidden column will be...but I think that might be the way to do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 09:51:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 07:51:22 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-bjAbEARceT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Bear with me, I'm adapting the patch to be a bit cleaner, and hopefully catch a few more cases as per dcooks other suggestions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 09:54:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 07:54:51 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-UruErd7vKn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 --- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Tom?s Cohen Arazi from comment #8) > (In reply to Jonathan Druart from comment #7) > > It would be good to know how reproduce this issue. > > On comment #3 I explained the steps I used to reproduce it. I have seen them, but that didn't help me. It seems working for both of you, so I suppose the patch works :) Looking at it, the changes looks consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 09:55:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 07:55:05 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-FYAskd4YEW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29909|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 29910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29910&action=edit Bug 10542: Fix QueryParser with OpacSupression OpacSupressions manipulates the query string after the buildQuery call and so breaks with queryParser enabled. This patch adds checks for queryParser and manipulates the query before passing it to buildQuery if it is enabled, but leaves the post buildQuery manipultation when queryParser is disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 09:56:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 07:56:25 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-qKo3vLhLJl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Next attempt ready.. go forth and destroy.. I mean test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 10:04:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 08:04:26 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-XntUmECBB3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 --- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #9) > (In reply to Tom?s Cohen Arazi from comment #8) > > (In reply to Jonathan Druart from comment #7) > > > It would be good to know how reproduce this issue. > > > > On comment #3 I explained the steps I used to reproduce it. > > I have seen them, but that didn't help me. It seems working for both of you, > so I suppose the patch works :) > Looking at it, the changes looks consistent. I could not reproduce this problem too. Could it be a matter of some sysprefs, or perl version? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 10:05:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 08:05:29 +0000 Subject: [Koha-bugs] [Bug 12287] Hold priority for new hold incorrect if record has holds in transit In-Reply-To: <bug-12287-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12287-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12287-70-aU3VxIQMQb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12287 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 10:05:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 08:05:31 +0000 Subject: [Koha-bugs] [Bug 12287] Hold priority for new hold incorrect if record has holds in transit In-Reply-To: <bug-12287-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12287-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12287-70-zlHqgDYL0G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12287 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28634|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29911&action=edit Bug 12287 - Hold priority for new hold incorrect if record has holds in transit When placing a new hold, the listed priority for the hold will be incorrect if there are any holds with items in transit ( i.e. found = T ). Test Plan: 1) Place 3 holds on a record with at least 2 items 2) Fill one hold so it is marked as waiting 3) Fill on hold so it is marked as in transit 4) Begin placing a new hold 5) Note the expected priority would be 2, but is actually 3 6) Apply this patch 7) Reload the patch, now the expected priority shows correctly Signed-off-by: Coralie Barsacq <c.barsacq at mairie-laciotat.fr> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 10:05:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 08:05:35 +0000 Subject: [Koha-bugs] [Bug 12287] Hold priority for new hold incorrect if record has holds in transit In-Reply-To: <bug-12287-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12287-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12287-70-cI8hhKxcp4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12287 --- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29912&action=edit Bug 12287: At the moment, found is 'W', 'T' or NULL Just add a small comment to avoid any further ambiguity. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 10:08:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 08:08:02 +0000 Subject: [Koha-bugs] [Bug 12287] Hold priority for new hold incorrect if record has holds in transit In-Reply-To: <bug-12287-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12287-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12287-70-PG6xT1cbIV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12287 --- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Kyle M Hall from comment #5) > I don't think so. That could cause future regressions if new found statuses > are added. For example, there used to be a found status of 'F' for > 'Finished' ( from before the existence of the old_reserves table iirc ). We > never want to include any type of found hold when calculating a new hold's > priority, set there is no need to list everything as a special case. Looking at the code in C4/Reserves.pm and reserves/*, the 'found' value is often compared to 'W' or 'T'. Both values are listed explicitly. That's why I supposed it is safer to use the same way. I added a small comment in the line (in order to get return if someone grep found.*W.*T) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 10:44:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 08:44:21 +0000 Subject: [Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber In-Reply-To: <bug-12323-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12323-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12323-70-jrysHrxUPW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28972|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29913&action=edit Bug 12323 [SIGNED OFF] - Acquisitions search results fixed in order of biblionumber The acquisitions search is exhibiting the same behavior as bug 11410. Results are always fixed in order of biblionumber, among other possible issues ( including the ampersand issue ). Test Plan: 1) From an open basket, choose "Add to basket" 2) Run a search for "From an existing record" 3) Note the "View MARC" URLs are fixed in order of biblionumber 4) Apply this patch 5) Refresh the page 6) Note the results are no longer fixed in order of biblionumber Signed-off-by: David Cook <dcook at prosentient.com.au> Works as described. I think the code could be a bit tidier, but I think it makes sense to use buildQuery here. It'll detect CCL, CQL, and PQF queries, as well as parsing a regular keyword search as one would expect when searching the catalogue. It also has the added bonus of performing relevance searching, so long as QueryAutoTruncation is off, and so long as library staff avoid using the "*" truncation wildcard (see bug 12430). While there are simpler ways to fix this acq bug, I think this was probably the best move, as it adds a bit to the consistency of what librarians can expect from their search results. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Same result with and without the patch but I agree with the changes. BuildQuery should be called before SimpleSearch if QP is not used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 10:44:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 08:44:18 +0000 Subject: [Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber In-Reply-To: <bug-12323-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12323-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12323-70-QKepaKikHz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 11:01:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 09:01:33 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-xMFuYnuJb6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jacek Ablewicz <ablewicz at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29005|0 |1 is obsolete| | Attachment #29006|0 |1 is obsolete| | Attachment #29007|0 |1 is obsolete| | --- Comment #48 from Jacek Ablewicz <ablewicz at gmail.com> --- Created attachment 29914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29914&action=edit Bug 9043: [SIGNED OFF] Syspref improvement: add new type "multiple" This patch adds a new type "multiple" for syspref. This new type allows to select several values for one syspref. Signed-off-by: Koha Team Lyon 3 <koha at univ-lyon3.fr> Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 11:01:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 09:01:43 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-h8MkJ2hUur@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #49 from Jacek Ablewicz <ablewicz at gmail.com> --- Created attachment 29915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29915&action=edit Bug 9043: [SIGNED-OFF] Add the dropdown check list jquery plugin Signed-off-by: Koha Team Lyon 3 <koha at univ-lyon3.fr> Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 11:01:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 09:01:53 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-P035SelDwo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #50 from Jacek Ablewicz <ablewicz at gmail.com> --- Created attachment 29916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29916&action=edit Bug 9043: [SIGNED-OFF] Changes to the advanced search page This patch adds 2 new sysprefs: OpacAdvSearchOptions and OpacAdvSearchMoreOptions. These sysprefs are multivalued and you can add or remove some elements on the adv search page. This patch allows to display/hide some entries in the advanced search page at the OPAC. On this way, it is possible to configure the search options to display. Test plan: 1/ Fill OpacAdvSearchOptions with Item types and Languages. Fill OpacAdvSearchMoreOptions with Item types, Languages and Location. On the advanced search page, verify the Location is only displayed for the "More options" view. 2/ Try different settings for these prefs 3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that the "More options" does not displayed additional options. 4/ Remove all entries for the OpacAdvSearchOptions and verify that the "normal view" does not displayed any options. Note that this patch only affects the bootstrap theme. Signed-off-by: Koha Team Lyon 3 <koha at univ-lyon3.fr> Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 11:18:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 09:18:38 +0000 Subject: [Koha-bugs] [Bug 11842] MARC framework editing is broken when memcache is enabled In-Reply-To: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11842-70-xohDgUT4ih@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11842 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28414|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29917&action=edit Bug 11842 - fix framework caching with memcache/plack This changes the existing framework caching, which was using memoisation if memcached was available, and memory in all cases, to use the Koha::Cache system. This uses memcache if possible, and in-memory otherwise. However it also clears the cache when the framework updates, making sure that the changed version will be picked up. Note that the in-memory cache clears itself after 10 seconds, so that if memcached isn't available, this is the longest that old versions will hang around. Test plan: * work through http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11842#c0 and make sure that the erronious result doesn't occur. Note: * The patch on bug 12041 is required for this to work. Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> I confirm the issue and that this patch fixes it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 11:19:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 09:19:02 +0000 Subject: [Koha-bugs] [Bug 11842] MARC framework editing is broken when memcache is enabled In-Reply-To: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11842-70-C8F9e9AmLe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11842 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 11:31:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 09:31:26 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-VuP4KTlD9n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #88 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 29918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29918&action=edit Bug 7162: Remove "(Y)" and "(N)" from buttons text -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 11:35:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 09:35:06 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-JQnWKrts0W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 11:50:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 09:50:42 +0000 Subject: [Koha-bugs] [Bug 11701] Fix C4::Context::Zconn In-Reply-To: <bug-11701-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11701-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11701-70-eKlUaZytVI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11701 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 12:20:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 10:20:46 +0000 Subject: [Koha-bugs] [Bug 12572] Use jQueryUI Accordion to display message transport types In-Reply-To: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12572-70-OI0Kch5ID1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 12:20:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 10:20:57 +0000 Subject: [Koha-bugs] [Bug 12572] Use jQueryUI Accordion to display message transport types In-Reply-To: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12572-70-Ub8oTZbfhf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29896|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29919&action=edit Bug 12572 - Use jQueryUI Accordion to display message transport types The notice edit view has separate sections for each of the various message transport types. This patch groups them in a jQueryUI accordion to simplify the view. Also changed: Some label/id pairs have been changed to eliminate duplicate ids. To test, apply the patch an edit any notice under Tools -> Notices & Slips. - The message transport type fields for email, feed, phone, etc. should be correctly grouped in a collapsed accordion. The acccordion should look correct and work correctly. - Clicking the label for any form field should correctly highlight the corresponding field. - Submitting updates to the notice should work correctly for all message transport types. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> This works as described. Something small: the top border of the uncollapsed/opened section doesn't display correctly, but this is working a lot nicer than before, as now changing a message requires a lot less scrolling. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 12:21:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 10:21:17 +0000 Subject: [Koha-bugs] [Bug 12572] Use jQueryUI Accordion to display message transport types In-Reply-To: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12572-70-TDYOUj8qud@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29920&action=edit Bug 12572: The first tab should be open by default To avoid an extra click, the first tab (email) should be open by default. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 12:48:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 10:48:43 +0000 Subject: [Koha-bugs] [Bug 12371] Links in every patron self-registration email points to a single borrower In-Reply-To: <bug-12371-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12371-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12371-70-GPfhuMGhSk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12371 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Barton: Do you have a borrower with borrowernumber 0 then? You should not have. This just appears to say that there is no borrower yet. Did the self registration email reach the correct address? Note that I reached this report after having a funny experience with selfregistration too. Apparently, there still was a pending self registration in the database, I entered a new one but received the credentials of the other user instead (on the email address of the last added registration). Cannot reproduce it (at least rightaway..) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 13:33:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 11:33:44 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-SE3XXHRtVB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29324|0 |1 is obsolete| | --- Comment #61 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 29921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29921&action=edit [SIGNED-OFF] Bug 8064: Merge several biblios Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 13:34:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 11:34:13 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-ADUjU7VVDQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29325|0 |1 is obsolete| | --- Comment #62 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 29922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29922&action=edit [SIGNED-OFF] Bug 8064: Change the way target record is built. Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 13:34:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 11:34:33 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-zFctW2T0dX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29326|0 |1 is obsolete| | --- Comment #63 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 29923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29923&action=edit [SIGNED-OFF] Bug 8064: Fix issues with control fields and non-repeatable check Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 13:35:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 11:35:00 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-BGi7fRhjOE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29327|0 |1 is obsolete| | --- Comment #64 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 29924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29924&action=edit [SIGNED-OFF] Bug 8064: Little fix for 003, 005, 008 in MARC21 Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 13:35:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 11:35:20 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-4hFi3w3Alp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29328|0 |1 is obsolete| | --- Comment #65 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 29925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29925&action=edit [SIGNED-OFF] Bug 8064: Fix unit tests for createMergeHash Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 13:35:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 11:35:50 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-4Umuxn63FM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 13:51:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 11:51:52 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: <bug-8918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8918-70-DdjQrHx1yt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Fridolin SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #70 from Fridolin SOMERS <fridolyn.somers at biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 (i had forget to change this bug status) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 14:31:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 12:31:12 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-UaHEYadfjQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29926&action=edit Demonstration Video Not sure what's going wrong for you. I just applied the patch to a fresh install and made this video. No changes to the patch were needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 14:32:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 12:32:39 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-hIzb4KcCrH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 15:16:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 13:16:08 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-dueC5VtbVP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 --- Comment #11 from Dobrica Pavlinusic <dpavlin at rot13.org> --- In our case, we have in 440$a "[ ?ivot i obi?aji ;" which is probably a mistake, but does trigger this bug. I don't think we modified any system preferences related to facets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 15:16:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 13:16:48 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9021-70-zYZD1fzRf2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28488|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29927&action=edit Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber at provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber at messaging.sprintpcs.com Verizon phonenumber at vtext.com T-Mobile phonenumber at tmomail.net AT&T phonenumber at txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 15:35:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 13:35:01 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9021-70-416ELvReA6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 15:36:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 13:36:42 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12593-70-j2BXMfJ6rK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 --- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I have Ubuntu 14.04 (amd64). This implies Perl 5.18 and Apache 2.4. For testing the patch I did: > DROP DATABASE koha_devel; > CREATE DATABASE koha_devel; Run the webinstaller (mine is a DOM+MARC21 setup). Selected all the sample data. Added some sample records I have so facets are build. Made a search, Edited a Personal Name authority (appearing on the facets) adding '[' in the middle of the name. Reindexed, launched the search => BROKEN -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 15:48:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 13:48:05 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9805-70-PzhWthaUCv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I personally think that we should re-discuss lost items handling. Will set it as In Discussion, and scheduled it for the next dev meeting. It won't get stalled, just delayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 16:06:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 14:06:59 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-c6EIxuW6zb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29928&action=edit 28846 - Bug 12375 [5] [QA Followup] - Don't assume X Y and Z are used in order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 16:07:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 14:07:36 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-ykjl6Jes6Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29928|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29929&action=edit Bug 12375 [5] [QA Followup] - Don't assume X Y and Z are used in order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 16:13:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 14:13:08 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-quq1Rsrdcc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Julian Maurice from comment #16) > If a numbering pattern uses {X}, {X}{Y} or {X}{Y}{Z}, in this order, then > the updatedatabase works. > But if I have a numbering pattern that uses only {Z} for example, then the Z > part will be stored in serialseq_x (and future serials will have the Z part > in serialseq_z column) > If my numbering pattern uses only {X} and {Z}, the Z part will be in > serialseq_y. > I think this have to be fixed, so failing QA here. Fixed! The attached qa followup should allow the database update to handle these situations. > Also the original serialseq column is not removed. Is it intended ? I think > we should not keep values in database that can be easily generated on the > fly. We need to keep the serialseq column, at least for the time being. Right now the new columns are for reporting. In the future we can also use them to improve the sorting of serials. In the long run we may want to deprecate serialseq, but each library would need to go through all their serials to verify the sequence values are correct before upgrading ( that is, the values may have been migrated from a previous ILS and need to be updated ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 16:15:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 14:15:07 +0000 Subject: [Koha-bugs] [Bug 12572] Use jQueryUI Accordion to display message transport types In-Reply-To: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12572-70-tUV30L4fbm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29920|0 |1 is obsolete| | CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Comment on attachment 29920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29920 Bug 12572: The first tab should be open by default There are several uses where expanding Email doesn't make sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 16:48:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 14:48:47 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-368QkxVoWx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29750|0 |1 is obsolete| | --- Comment #58 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29930&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 16:49:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 14:49:41 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-Wun18RqEpV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11891 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 16:49:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 14:49:41 +0000 Subject: [Koha-bugs] [Bug 11891] Make Koha::Schema use C4::Context->dbh In-Reply-To: <bug-11891-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11891-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11891-70-CZmDF6nR40@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11891 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9011 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 17:33:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 15:33:50 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-2pofpKlaMq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29931&action=edit Bug 9011 [QA Followup 3] - Update database schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 17:37:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 15:37:07 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-drWH9aIKF9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #60 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Nick Clemens from comment #57) > I tested but am not seeing history stored if patron privacy preference is > set to 'never' > Patron also seems to be able to clear last borrower history using 'Immediate > deletion' button Please retest! I believe the issue was caused by the database schema not being updated. > Bug says depends on 11891, but that was pushed to master, wanted to check > before clearing though. I've gone ahead and cleared that blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 17:47:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 15:47:28 +0000 Subject: [Koha-bugs] [Bug 10654] Add feature: export basket in CSV, list of custom formats for various vendors In-Reply-To: <bug-10654-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10654-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10654-70-IjKsrzQY8l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10654 Mike <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 17:53:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 15:53:06 +0000 Subject: [Koha-bugs] [Bug 12618] New: Sending of authority redords via Z39.50 Message-ID: <bug-12618-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12618 Bug ID: 12618 Summary: Sending of authority redords via Z39.50 Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, our National library accept new/edited authority records just via Z39.50. YAZ offer this but Koha not. Is here some chance to implement it? Thanks Mike -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 17:53:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 15:53:14 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-sLL5rbcEZY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28153|0 |1 is obsolete| | Attachment #28154|0 |1 is obsolete| | Attachment #28155|0 |1 is obsolete| | Attachment #29215|0 |1 is obsolete| | Attachment #29302|0 |1 is obsolete| | Attachment #29303|0 |1 is obsolete| | Attachment #29304|0 |1 is obsolete| | --- Comment #131 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29932&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 17:53:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 15:53:28 +0000 Subject: [Koha-bugs] [Bug 12618] Sending of authority redords via Z39.50 In-Reply-To: <bug-12618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12618-70-NZSglFOtIM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12618 Mike <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com Patch complexity|--- |Medium patch Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 17:53:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 15:53:30 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-VROIFCQgSR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #132 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29933&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 17:53:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 15:53:33 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-myIqcm92Bz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #133 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29934&action=edit Bug 9303 [3] - relative's checkouts in the opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 18:13:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 16:13:18 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-f1PoH7p4FT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29932|0 |1 is obsolete| | Attachment #29933|0 |1 is obsolete| | Attachment #29934|0 |1 is obsolete| | --- Comment #134 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29935&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 18:13:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 16:13:32 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-P6guC7zQMS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #135 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29936&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 18:13:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 16:13:36 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-id0THZ98Js@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #136 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29937&action=edit Bug 9303 [3] - relative's checkouts in the opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 18:36:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 16:36:36 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-QkLjVGcC8L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #137 from Kyle M Hall <kyle at bywatersolutions.com> --- Schema updates in master were causing merge conflicts. I've fixed those, and also merged all the followups into the main patch set to make it easier to read for qa. You should be able to sandbox these patches now! Kyle (In reply to Heather Braum from comment #130) > Kyle, I went to sign off on this patch again using the sandboxes, and got > this error that the sandbox wasn't ready: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 19:32:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 17:32:54 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11373-70-o8pyJn2Ki4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #9 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> --- Created attachment 29938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29938&action=edit Bug 11373 - Fixed: 'Change to give back' not displaying. I tested the last patch and found that the case 'amount oustanding == amount paid' was not handled in paycollect.p . The confirmation box should now appear when those values are equal and the amount collected is higher than the amount paid. I have found another problem while testing. When paying all fines or selected fines, the 'The amount collected is greater than the total amount paid.' message would appear even when the entered data was correct. Both issues were adressed in this patch. modified: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt modified: members/paycollect.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 19:50:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 17:50:34 +0000 Subject: [Koha-bugs] [Bug 12598] Allow tools/import_borrowers.pl to be used from the command line. In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-s5DCj3PCg0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 19:50:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 17:50:37 +0000 Subject: [Koha-bugs] [Bug 12598] Allow tools/import_borrowers.pl to be used from the command line. In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-Jzy6FiEMtg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29809|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 29939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29939&action=edit Bug 12598 - Allow tools/import_borrowers.pl to be used from the command line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 19:52:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 17:52:54 +0000 Subject: [Koha-bugs] [Bug 12598] Allow tools/import_borrowers.pl to be used from the command line. In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-0lxRqLrzuz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #5) > Hi Kyle, I think this is a duplicate to bug 5633. > > There it was pointed out that normal scripts should not be command line > scripts at the same time. Could you move this functionality into a separate > command line script? I was not aware of that. Thanks for letting me know! Here is a new variant that is command line only and lives in misc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 22:18:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 20:18:19 +0000 Subject: [Koha-bugs] [Bug 12401] card view on z searches sometimes throws error In-Reply-To: <bug-12401-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12401-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12401-70-RRoipkPyZ5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12401 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Owen Leonard from comment #1) > Can you download the record which triggers the error? If you import the > record into Koha does it work? If so, is there any visible problem with the > imported data? Yes, we can download it. The record works, but the card still can't be viewed after it is imported. I'm thinking there is something either something malformed in the data, or a condition in the record that Koha isn't prepared to handle. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 23:42:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 21:42:17 +0000 Subject: [Koha-bugs] [Bug 12619] New: Shipment cost gets lost on finishing the invoice Message-ID: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 Bug ID: 12619 Summary: Shipment cost gets lost on finishing the invoice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org to reproduce: - Create a new shipment, make sure to add a shipment date - Receive or not receive orders - Finish receiving with the button at the bottom of the page - Verify that shipment date is now empty -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 23:44:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 21:44:29 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-IGyvBAjdxK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 23:44:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 21:44:32 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-Ix9miX1jeD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29804|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 29940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29940&action=edit Bug 12596 - Unit Test Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 23:44:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 21:44:47 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-4AtVoKgr3x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29806|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 29941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29941&action=edit Bug 12596 - Backdating returns with SpecifiyReturnDate causes fines for items not overdue! When using the backdating of returns feature, an item that is not overdue is treated as being as many days overdue as it is *not* overdue. This is due to the fact that _get_chargeable_units appears to return the difference between the return date and the due date without consideration the return date being earlier than the due date. Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/Circulation.t 3) Note the failure 4) Apply the second patch 5) prove t/db_dependent/Circulation.t 6) Note there are no failures Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Fixes some badly named variables also -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 23:49:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 21:49:22 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-ARQwv54upY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 23:49:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 21:49:25 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-Qf13Md4XMA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29910|0 |1 is obsolete| | --- Comment #24 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 29942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29942&action=edit Bug 10542: Fix QueryParser with OpacSupression OpacSupressions manipulates the query string after the buildQuery call and so breaks with queryParser enabled. This patch adds checks for queryParser and manipulates the query before passing it to buildQuery if it is enabled, but leaves the post buildQuery manipultation when queryParser is disabled Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 23:55:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 21:55:00 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-AC5yUI100U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 23:55:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 21:55:05 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-mjitGEcIHr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29918|0 |1 is obsolete| | --- Comment #89 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29943&action=edit [PASSED QA] Bug 7162: Remove "(Y)" and "(N)" from buttons text Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Removes keyboard shortcut hints that don't work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 23:55:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 21:55:21 +0000 Subject: [Koha-bugs] [Bug 12519] Convert OPAC list download pop-up to modal dialog In-Reply-To: <bug-12519-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12519-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12519-70-WDrbrnTJCx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12519 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed as Module Maintainer, Thanks Owen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 21 23:57:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 21:57:38 +0000 Subject: [Koha-bugs] [Bug 11347] PROG/CCSR deprecation: Remove opacsmallimage system-preference In-Reply-To: <bug-11347-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11347-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11347-70-vO6IPuNUgI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 00:07:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 22:07:27 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-IvL1cWCHbS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de --- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Please add a follow-up to include the new jQuery plugin on the About page. Continuing testing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 00:13:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 22:13:00 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-YjpCmloBjt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #52 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think maybe rename location to 'location and availability' like on the advanced search form and to avoid confusion with the locations tab that you can add with AdvancedSearchTypes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 01:22:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 23:22:39 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-cM8QYEO4Cv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from David Cook <dcook at prosentient.com.au> --- I realized last night after getting off IRC that I forgot to mention that we would need to use PQF syntax rather than QP syntax, if using the $query_type to know what type of query we're working with. The following syntax would have to be used "before" buildQuery/parseQuery, as this is QueryParser syntax which is parsed and then transformed into PQF. $query = "($query) && -(suppress:1)" Since the latest patch is adding the OpacSuppression after the query has already been returned from buildQuery as PQF, we need to use the following PQF syntax: $query = '@not '."$query".' @attr 1=9011 1'; -- Otherwise we generate an invalid query that will return 0 records when using QueryParser: ZOOM error 20003 "can't set prefix query" (addinfo: "(@or @or @or @attr 1=1016 @attr 5=1 @attr 4=6 "test" @attr 9=75 @attr 2=102 @attr 5=1 @attr 4=6 "test" @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "test" @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "test") && -(suppress:1)") from diag-set 'ZOOM' -- We also can't use parentheses as those aren't used in PQF either. ZOOM error 20003 "can't set prefix query" (addinfo: "@not (@or @or @or @attr 1=1016 @attr 5=1 @attr 4=6 "test" @attr 9=75 @attr 2=102 @attr 5=1 @attr 4=6 "test" @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "test" @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "test") @attr 1=9011 1") from diag-set 'ZOOM' -- The following query will work as expected though: @not @or @or @or @attr 1=1016 @attr 5=1 @attr 4=6 "test" @attr 9=75 @attr 2=102 @attr 5=1 @attr 4=6 "test" @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "test" @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "test" @attr 1=9011 1 I had to look over those past comments of mine to make sure but if this were CCL it should look like this: (((kw,wrdl,rt=test OR kw,wrdl,rt=test) OR kw,wrdl,rt=test) OR kw,wrdl,rt=test) NOT suppress=1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 01:38:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 23:38:42 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-UI8rMzjax9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 01:38:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jul 2014 23:38:44 +0000 Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries' In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10542-70-bgu3jKRwuH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 --- Comment #26 from David Cook <dcook at prosentient.com.au> --- Created attachment 29944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29944&action=edit Bug 10542 [Follow-up] - QueryParser + OpacSuppression doesn't allow search in 'all libraries' Since we're using the $query_type variable to detect if this pre-built query is PQF, we need to use PQF syntax (rather than QueryParser syntax) when adding to the query. I've made a lot of notes of somewhat incoherent notes on Bugzilla talking about PQF, CCL, and QP syntaxes, but I'm hoping to refine these notes on a wiki page for future reference. _TEST PLAN_ 1) Set 'Suppress in Opac' (ie 942$n) to 1 for one record 2) Re-index Zebra 3) Set 'OpacSuppression' to 'Hide' 4) Set 'UseQueryParser' to 'Do not try' 5) In the staff client, do a search that will return that suppressed record as well as a few records that are NOT suppressed 6) Note that you can return that suppressed record in the staff client 7) Do the same search in the OPAC 8) Note that the suppressed record doesn't appear 9) Set 'UseQueryParser' to 'Try' && re-run the OPAC search 10) Note that no results appear (the logs will probably mention a ZOOM error) 11) Apply patch 12) Re-run the OPAC search 13) Note that the suppressed record doesn't appear, and that the not suppressed records are showing (it's important that you are getting some results...as ZOOM errors are silent in the UI). 14) Set 'UseQueryParser' to 'Do not try' 15) Re-run the search 16) Note that the suppressed record doesn't appear, and that the not suppressed records are showing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 02:04:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 00:04:22 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-Xr6e0ayDDJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #85 from David Cook <dcook at prosentient.com.au> --- Comment on attachment 29882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29882 [PASSED QA] Bug 10212: Columns configuration for tables Review of attachment 29882: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10212&attachment=29882) ----------------------------------------------------------------- ::: C4/Utils/DataTables/ColumnsSettings.pm @@ +66,5 @@ > + for my $c (@$columns) { > + $c->{is_hidden} //= 0; > + $c->{cannot_be_toggled} //= 0; > + > + my $column = $schema->resultset('ColumnsSetting')->search( Have you considered using "update_or_create" instead of these 3 methods? Admittedly, I'm not sure what about the significance of "$column = $column->first;" below. However, if that's the case, I'd suggest "find_or_new" or "find_or_create". http://search.cpan.org/~ribasushi/DBIx-Class-0.08270/lib/DBIx/Class/ResultSet.pm#update_or_create my $column = $schema->resultset('ColumnsSetting')->update_or_create({ module => $c->{module}, page => $c->{page}, tablename => $c->{tablename}, columnname => $c->{columnname}, is_hidden => $c->{is_hidden}, cannot_be_toggled => $c->{cannot_be_toggled}, }); Regardless of whether you choose to go with this method, I think it would be a good idea to add a primary key constraint to your DbiC methods. I haven't looked at the proposed table structure, so I don't know if there are any, but probably a good idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 02:12:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 00:12:29 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-UWC5Js7Oil@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #86 from David Cook <dcook at prosentient.com.au> --- I haven't tested any of these patches, but excited to have a mechanism for controlling column visibility. I thought about adding the ColVis files locally, so I'm happy to see a patch for them to go into Koha proper. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 03:22:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 01:22:42 +0000 Subject: [Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks In-Reply-To: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12477-70-wfiMqDJdkm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 --- Comment #8 from David Cook <dcook at prosentient.com.au> --- Just having a thought about "hidden" values... These are the "hidden" values: -9 => Future use -8 => Flag -7 => OPAC !Intranet !Editor Collapsed -6 => OPAC Intranet !Editor !Collapsed -5 => OPAC Intranet !Editor Collapsed -4 => OPAC !Intranet !Editor !Collapsed -3 => OPAC !Intranet Editor Collapsed -2 => OPAC !Intranet Editor !Collapsed -1 => OPAC Intranet Editor Collapsed 0 => OPAC Intranet Editor !Collapsed 1 => !OPAC Intranet Editor Collapsed 2 => !OPAC !Intranet Editor !Collapsed 3 => !OPAC !Intranet Editor Collapsed 4 => !OPAC Intranet Editor !Collapsed 5 => !OPAC !Intranet !Editor Collapsed 6 => !OPAC Intranet !Editor !Collapsed 7 => !OPAC Intranet !Editor Collapsed 8 => !OPAC !Intranet !Editor !Collapsed 9 => Future use ? URL : if checked, the subfield is an URL, and can be clicked These are their frequencies in "marc21_subtag.xml". "hidden="-9" (0 hits) "hidden="-8" (0 hits) "hidden="-7" (0 hits) "hidden="-6" (3037 hits) "hidden="-5" (59 hits) "hidden="-4" (0 hits) "hidden="-3" (0 hits) "hidden="-2" (0 hits) "hidden="-1" (240 hits) "hidden="9" (0 hits) "hidden="8" (0 hits) "hidden="7" (3 hits) "hidden="6" (4 hits) "hidden="5" (379 hits) "hidden="4" (1 hit) "hidden="3" (0 hits) "hidden="2" (0 hits) "hidden="1" (11 hits) "hidden="0" (225 hits) Some of these don't make all that much sense. For instance, -5 is functionally equivalent to -6. They're both in the OPAC and Intranet, and neither is in the Editor. The Collapsed quality really only applies to the Editor...so we may as well make the subfields with -5 be -6 by default. 6 and 7 are also functionally equivalent...although they're a bit bizarre. I don't know why you'd ever need something to show in the Intranet but not in the OPAC or the Editor. If a field doesn't appear in the Editor, and it gets re-saved...any fields not appearing in the Editor will be destroyed. I figure...if it doesn't appear in the Editor, it probably _doesn't_ need to appear anywhere else. Conversely, it _does_ make sense that fields that appear in the Editor might not show up in the OPAC or the Intranet (as they might be system values or just not relevant for most views). Following that logic, I find -6 to be a bit silly. I'd prefer 5 or 8, which are functionally equivalent. Of course, such distinctions get a bit...pedantic, so I rather just go with 1 "hidden" value for a function. Perhaps "-6" is the best one to use, since it's the most common for fields that we want to hide. Anyway, these are just some thoughts... when it comes to updating frameworks, I'm going to use -6 for the sake of consistency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 03:32:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 01:32:24 +0000 Subject: [Koha-bugs] [Bug 12620] New: Proxy Add-on for Koha z39.50 Message-ID: <bug-12620-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 Bug ID: 12620 Summary: Proxy Add-on for Koha z39.50 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: murphy.daniel.j at edumail.vic.gov.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Hi all, I am new to Koha and have set it up to use in a Victorian School. Great product and congrats on all the community work. With Vic schools we all have to run through an upstream proxy and as such we don't have a 'direct' internet connection. We wish to use the z39.50 module to download information from SCIS however whenever we try to sync it lists network errors(basically implying that there is no internet connection). After a bit of reading and searching the only way to get around this appears to be to use YAZProxy - however I was wondering if there is any way in upcoming releases to have a proxy configuration section. Doing this would make it a more feasible and easier to implement solution for schools in Australia (if not around the world). Any input would be great. Thanks Dan -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 08:29:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 06:29:16 +0000 Subject: [Koha-bugs] [Bug 12590] Support deletion of biblio in svc API In-Reply-To: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12590-70-5nd0uDVmOi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12590 mathieu saby <mathsabypro at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 09:36:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 07:36:33 +0000 Subject: [Koha-bugs] [Bug 12621] New: Z39.50-targets - Record type is untranslatable Message-ID: <bug-12621-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12621 Bug ID: 12621 Summary: Z39.50-targets - Record type is untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When looking at the table of configured Z39.50 targets in administration, the column Record type contains bibliographic or authority. The strings should be translatable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 09:36:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 07:36:43 +0000 Subject: [Koha-bugs] [Bug 12621] Z39.50-targets - Record type is untranslatable In-Reply-To: <bug-12621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12621-70-Srww4kFCdR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12621 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 09:38:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 07:38:58 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-uAXW9tfGnM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29916|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29945&action=edit Bug 9043: [SIGNED-OFF] Changes to the advanced search page This patch adds 2 new sysprefs: OpacAdvSearchOptions and OpacAdvSearchMoreOptions. These sysprefs are multivalued and you can add or remove some elements on the adv search page. This patch allows to display/hide some entries in the advanced search page at the OPAC. On this way, it is possible to configure the search options to display. Test plan: 1/ Fill OpacAdvSearchOptions with Item types and Languages. Fill OpacAdvSearchMoreOptions with Item types, Languages and Location. On the advanced search page, verify the Location is only displayed for the "More options" view. 2/ Try different settings for these prefs 3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that the "More options" does not displayed additional options. 4/ Remove all entries for the OpacAdvSearchOptions and verify that the "normal view" does not displayed any options. Note that this patch only affects the bootstrap theme. Signed-off-by: Koha Team Lyon 3 <koha at univ-lyon3.fr> Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 09:39:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 07:39:04 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-IdEAXS57jz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #54 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29946&action=edit Bug 9043: Add the dropdown check list jquery plugin in the license list. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 09:39:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 07:39:56 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-0sBkINcgMa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #55 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Katrin Fischer from comment #51) > Please add a follow-up to include the new jQuery plugin on the About page. Done. (In reply to Katrin Fischer from comment #52) > I think maybe rename location to 'location and availability' like on the > advanced search form and to avoid confusion with the locations tab that you > can add with AdvancedSearchTypes. Done too, I amended the last patch and just changed the string in opac.pref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 09:47:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 07:47:42 +0000 Subject: [Koha-bugs] [Bug 12622] New: Exporting report as Open Document Spreadsheet results in Perl error when report has no results Message-ID: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Bug ID: 12622 Summary: Exporting report as Open Document Spreadsheet results in Perl error when report has no results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To test: - Run a custom report that produces results - Export as Open Document Spreadsheet - Verify export worked correctly - Run a custom report that produces no results - Export as Open Document Spreadsheet - Verify you see a perl error: Can't use an undefined value as an ARRAY reference at /usr/share/koha/intranet/cgi-bin/reports/guided_reports.pl line 817. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 09:48:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 07:48:17 +0000 Subject: [Koha-bugs] [Bug 12622] Exporting report as Open Document Spreadsheet results in Perl error when report has no results In-Reply-To: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12622-70-dNbTHmdEev@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 09:49:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 07:49:23 +0000 Subject: [Koha-bugs] [Bug 12619] Shipment cost gets lost on finishing the invoice In-Reply-To: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12619-70-MiB9IdY5Zg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Losing data you entered is not nice and could go unnoticed - upping severity a bit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 10:04:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 08:04:18 +0000 Subject: [Koha-bugs] [Bug 12295] Javascript error when merging authorities In-Reply-To: <bug-12295-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12295-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12295-70-H1gZdyZf0C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Fridolin SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolyn.somers at biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 10:07:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 08:07:46 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11023-70-cheSh8plvc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om --- Comment #49 from claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> --- Just to support its integration. We use it a lot in production and for the moment we have to apply it manually, but patchs approved by BibLibre ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 10:10:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 08:10:02 +0000 Subject: [Koha-bugs] [Bug 4068] Accepting a suggestion hides 'pending' tab In-Reply-To: <bug-4068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4068-70-MLhYrMoo4z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4068 Fridolin SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolyn.somers at biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 10:16:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 08:16:03 +0000 Subject: [Koha-bugs] [Bug 12622] Exporting report as Open Document Spreadsheet results in Perl error when report has no results In-Reply-To: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12622-70-Tj1LL5MUWZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart at biblibre.co | |m Depends on| |11679 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 10:16:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 08:16:03 +0000 Subject: [Koha-bugs] [Bug 11679] Add an ods export choice for reports In-Reply-To: <bug-11679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11679-70-trutwh0gTC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12622 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 10:23:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 08:23:27 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-OpmWhGZsg9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #87 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29947&action=edit Bug 10212: Use the update_or_create DBIC method when possible Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 10:25:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 08:25:13 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-FzOK6o05B9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #88 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to David Cook from comment #85) > ::: C4/Utils/DataTables/ColumnsSettings.pm > @@ +66,5 @@ > > + for my $c (@$columns) { > > + $c->{is_hidden} //= 0; > > + $c->{cannot_be_toggled} //= 0; > > + > > + my $column = $schema->resultset('ColumnsSetting')->search( > > Have you considered using "update_or_create" instead of these 3 methods? Hum... don't repeat what you saw ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 10:41:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 08:41:41 +0000 Subject: [Koha-bugs] [Bug 12623] New: SQLHelper replacement - Koha::Borrower::Modifications Message-ID: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12623 Bug ID: 12623 Summary: SQLHelper replacement - Koha::Borrower::Modifications Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: yohann.dufour at biblibre.com QA Contact: testopia at bugs.koha-community.org The module Koha::Borrower::Modifications depends on module C4::SQLHelper. However, the module SQLHelper is obsolete, so the calls for InsertInTable and UpdateInTable have to be replaced by the use of the module DBIx::Class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 10:41:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 08:41:51 +0000 Subject: [Koha-bugs] [Bug 12623] SQLHelper replacement - Koha::Borrower::Modifications In-Reply-To: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12623-70-J7npwBkLYM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12623 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |yohann.dufour at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 10:42:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 08:42:45 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11385-70-BziLOlPt7h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12623 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 10:42:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 08:42:45 +0000 Subject: [Koha-bugs] [Bug 12623] SQLHelper replacement - Koha::Borrower::Modifications In-Reply-To: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12623-70-xGBAGoSRuI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12623 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11385 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 10:52:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 08:52:39 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: <bug-12586-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12586-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12586-70-ydDNUy3Zv6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 --- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 29948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29948&action=edit Bug 12586 - Record matching rules - Required match checks doesn't work with MARCXML When trying to Match MARCXML-records from Zebra using Required match checks, C4::Matcher::_passes_required_checks() tries to make a MARC::Record out of MARCXML while thinking it is USMARC. This leads to matching records getting not-matched, and subsequently importing the same records again and again. Very hard to debug or create a test case. I accidentally noticed this while building an automatic acquisitions record overlay mechanism. There are no big errors, simply no match is found, even though a match exists. Also refactored the Matcher a bit to prevent excessive MARC::Record creation for each "Required match check" for each search results. This probably would cripple any reasonably sized batch Matching operations. --------- TEST PLAN --------- 1. Create a Matcher with "Required match checks" in addition to normal checks. 2. Find matches using the C4::Matcher->get_matches() and notice that you don't find matches. 3. Somebody who is actually using this Matcher could help me out here with defining a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 10:53:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 08:53:06 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: <bug-12586-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12586-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12586-70-MycqojLoVH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29758|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 11:27:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 09:27:48 +0000 Subject: [Koha-bugs] [Bug 12624] New: Getting all search results in C4::Breeding::Z3950Search, instead of pageful Message-ID: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12624 Bug ID: 12624 Summary: Getting all search results in C4::Breeding::Z3950Search, instead of pageful Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Fetching ALL component parts from a remote Z3950 repository is difficult. Also the Z3950Search() function only works directly to templates. This patch changes the Z3950Search() to OPTIONALLY return all search results as a HASH instead of a Template-object. This makes scripting with it a LOT easier! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 11:28:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 09:28:47 +0000 Subject: [Koha-bugs] [Bug 12624] Getting all search results in C4::Breeding::Z3950Search, instead of pageful In-Reply-To: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12624-70-e6Lq3gyaj4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12624 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 29949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29949&action=edit Bug 12624 - Getting all search results in C4::Breeding::Z3950Search, instead of pageful Fetching ALL component parts from a remote Z3950 repository is difficult. Also the Z3950Search() function only works directly to templates. This patch changes the Z3950Search() to OPTIONALLY return all search results as a HASH instead of a Template-object. Previous functionality is left untouched. This makes scripting with it a LOT easier! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 11:29:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 09:29:21 +0000 Subject: [Koha-bugs] [Bug 12624] Getting all search results in C4::Breeding::Z3950Search, instead of pageful In-Reply-To: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12624-70-UORylJuJOM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12624 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 11:29:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 09:29:40 +0000 Subject: [Koha-bugs] [Bug 12624] Getting all search results in C4::Breeding::Z3950Search, instead of pageful In-Reply-To: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12624-70-QJZP7yESYO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12624 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 11:51:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 09:51:55 +0000 Subject: [Koha-bugs] [Bug 12625] New: Delete component parts when deleting the parent from detailed-view Message-ID: <bug-12625-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12625 Bug ID: 12625 Summary: Delete component parts when deleting the parent from detailed-view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl See Bug 11175 for explanation of component parts. This feature automatically deletes all linked component parts when the component parent is deleted using "catalogue/detail.pl -> Edit -> Delete record" Generalizing this to C4::Biblio::DelBiblio() is not a good idea because we don't wan't to delete all component parts when we are for example, merging records :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 11:52:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 09:52:18 +0000 Subject: [Koha-bugs] [Bug 12625] Batch delete component parts when deleting the parent from detailed-view In-Reply-To: <bug-12625-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12625-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12625-70-3ML3RUm5dC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12625 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Delete component parts when |Batch delete component |deleting the parent from |parts when deleting the |detailed-view |parent from detailed-view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 11:53:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 09:53:04 +0000 Subject: [Koha-bugs] [Bug 12625] Batch delete component parts when deleting the parent from detailed-view In-Reply-To: <bug-12625-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12625-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12625-70-ukcIRYsvWe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12625 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 29950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29950&action=edit Bug 12625 - (KD-153) Batch delete component parts when deleting the parent from detailed-view See Bug 11175 for explanation of component parts. This feature automatically deletes all linked component parts when the component parent is deleted using "catalogue/detail.pl -> Edit -> Delete record" Generalizing this to C4::Biblio::DelBiblio() is not a good idea because we don't wan't to delete all component parts when we are for example, merging records :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 11:53:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 09:53:12 +0000 Subject: [Koha-bugs] [Bug 12625] Batch delete component parts when deleting the parent from detailed-view In-Reply-To: <bug-12625-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12625-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12625-70-Jb0UIWJaMJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12625 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11175 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 11:53:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 09:53:12 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views. In-Reply-To: <bug-11175-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11175-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11175-70-CVhD8LKfdP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12625 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 11:53:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 09:53:26 +0000 Subject: [Koha-bugs] [Bug 12625] Batch delete component parts when deleting the parent from detailed-view In-Reply-To: <bug-12625-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12625-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12625-70-6LVbnwYVoF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12625 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 12:09:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 10:09:57 +0000 Subject: [Koha-bugs] [Bug 12623] SQLHelper replacement - Koha::Borrower::Modifications In-Reply-To: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12623-70-hsfGgqka41@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12623 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 12:09:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 10:09:59 +0000 Subject: [Koha-bugs] [Bug 12623] SQLHelper replacement - Koha::Borrower::Modifications In-Reply-To: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12623-70-b4oh7MX62t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12623 --- Comment #1 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 29951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29951&action=edit Bug 12623: SQLHelper replacement - Borrower::Modifications With this patch, the subroutines AddModification and ApproveModifications uses DBIx::Class instead of C4::SQLHelper. Test plan: 1) Apply the patch 2) Execute the unit tests by launching : prove t/db_dependent/Koha_borrower_modifications.t 3) The result has to be a success without error or warning : t/db_dependent/Koha_borrower_modifications.t .. ok All tests successful. Files=1, Tests=14, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.60 cusr 0.08 csys = 1.72 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 12:14:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 10:14:33 +0000 Subject: [Koha-bugs] [Bug 12626] New: SQLHelper replacement - C4::Acquisition Message-ID: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12626 Bug ID: 12626 Summary: SQLHelper replacement - C4::Acquisition Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: yohann.dufour at biblibre.com QA Contact: testopia at bugs.koha-community.org The module C4::Acquisition depends on module C4::SQLHelper. However, the module SQLHelper is obsolete, so the calls for InsertInTable have to be replaced by the use of the module DBIx::Class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 12:14:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 10:14:41 +0000 Subject: [Koha-bugs] [Bug 12626] SQLHelper replacement - C4::Acquisition In-Reply-To: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12626-70-nXNGGL34hk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12626 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |yohann.dufour at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 12:19:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 10:19:37 +0000 Subject: [Koha-bugs] [Bug 12622] Exporting report as Open Document Spreadsheet results in Perl error when report has no results In-Reply-To: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12622-70-ZwkWL1rKY3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 12:19:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 10:19:40 +0000 Subject: [Koha-bugs] [Bug 12622] Exporting report as Open Document Spreadsheet results in Perl error when report has no results In-Reply-To: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12622-70-78iWd5XbWJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 29952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29952&action=edit Bug 12622: Fix export report as ods Bug 11679 introduces an ods export for reports. It looks quite buggy: 1/ You get a Perl error if the report has no results 2/ The ods file contains 1 lines less than the total results. Test plan: After applying this patch, try to export a report which has no results and verify you get an ods file with headers only. Try to export a report which has a least 1 result and verify the generated ods has the right number of lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 12:20:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 10:20:50 +0000 Subject: [Koha-bugs] [Bug 12622] Exporting report as Open Document Spreadsheet results in Perl error when report has no results In-Reply-To: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12622-70-DnAAoEjxC6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 13:18:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 11:18:49 +0000 Subject: [Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks In-Reply-To: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12477-70-9HpgEZknL0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #9 from Jacek Ablewicz <abl at biblos.pk.edu.pl> --- (In reply to David Cook from comment #8) > If a field doesn't appear in the Editor, and it gets re-saved...any fields > not appearing in the Editor will be destroyed. Does it really work that way for biblos MARC frameworks?? If so, that would be a _major_ disaster IMO. I was under the impression that if the certain subfields are set up as "hidden in editor", they still get saved (not getting destroyed on re-save). Also, at least in the manner of speaking, they do appear in editor ;), their contents are just not visible and not editable (AFAIRC authority editor uses "display: none" for that purpose, I'm not sure about biblio editor). > I figure...if it doesn't appear in the Editor, it probably _doesn't_ need to > appear anywhere else. There are some scenarios when we e.g. may want some fields/subfields to be: preserved in the MARC record (control numbers, some linking data for records imported from union catalogues etc.), visible in staff client, but not directly editable by the librarians. Possibility to define (perhaps even greatly) simplified frameworks, intended for some specific editing tasks (= with a lot of existing record fields/subfields hidden on edit) might often come in handy as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 13:51:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 11:51:34 +0000 Subject: [Koha-bugs] [Bug 12626] SQLHelper replacement - C4::Acquisition In-Reply-To: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12626-70-AdLkPoLkcO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12626 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 13:51:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 11:51:36 +0000 Subject: [Koha-bugs] [Bug 12626] SQLHelper replacement - C4::Acquisition In-Reply-To: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12626-70-9NsiCpzcx5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12626 --- Comment #1 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 29953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29953&action=edit Bug 12626: SQLHelper replacement - C4::Acquisition With this patch, the subroutine NewOrder uses DBIx::Class instead of C4::SQLHelper. Test plan: 1) Apply the patch 2) Execute the unit tests by launching : prove t/db_dependent/Acquisition.t 3) The result has to be a success without error or warning : t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=79, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.80 cusr 0.09 csys = 1.94 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 14:52:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 12:52:59 +0000 Subject: [Koha-bugs] [Bug 12627] New: SQLHelper replacement - C4::Suggestions Message-ID: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Bug ID: 12627 Summary: SQLHelper replacement - C4::Suggestions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: yohann.dufour at biblibre.com QA Contact: testopia at bugs.koha-community.org The module C4::Suggestions depends on module C4::SQLHelper. However, the module SQLHelper is obsolete, so the calls in NewSuggestion and UpdateSuggestion have to be replaced by the use of the module DBIx::Class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 14:53:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 12:53:19 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12627-70-OJ3gbk8s6o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |yohann.dufour at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 14:56:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 12:56:04 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-lZf5slUGWA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Yohann Dufour <yohann.dufour at biblibre.com> --- Conflict to solve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 15:37:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 13:37:25 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-NaKXTTBYnp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 15:37:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 13:37:28 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-TUTvKjCwOv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 --- Comment #10 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 29954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29954&action=edit Bug 12445: Improving unit tests for C4::Suggestions.pm Now, the tests used 'is' instead of 'ok', the tests are wrapped in a transaction, adding tests for the routines NewSuggestion, GetSuggestion, ModSuggestion, GetSuggestionFromBiblionumber and GetInfoFromBiblionumber. The tests for the routines DelSuggestionsOlderThan, CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion and GetSuggestionByStatus will be arrived in another patch. Test plan: 1/ Execute the command : prove t/db_dependent/Suggestions.t 2/ The result has to be a success without warning or error : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=32, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.49 cusr 0.08 csys = 1.61 CPU) Result: PASS Signed-off-by: Paola Rossi <paola.rossi at cineca.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 15:39:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 13:39:24 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-Pr05WjiW82@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29103|0 |1 is obsolete| | Attachment #29104|0 |1 is obsolete| | --- Comment #11 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 29955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29955&action=edit Bug 12445: ading unit tests to test the routines : CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion, GetSuggestionByStatus These routines were not tested Test plan: 1/ Execute the command : prove t/db_dependent/Suggestions.t 2/ The result has to be a success without error or warning : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=89, 1 wallclock secs ( 0.05 usr 0.01 sys + 1.52 cusr 0.08 csys = 1.66 CPU) Result: PASS Signed-off-by: Paola Rossi <paola.rossi at cineca.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:37:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:37:22 +0000 Subject: [Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes In-Reply-To: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11346-70-Qxy2Yv8AqD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12539 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:37:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:37:22 +0000 Subject: [Koha-bugs] [Bug 12539] PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm In-Reply-To: <bug-12539-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12539-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12539-70-IWhnpDtB91@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12539 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Blocks| |11346 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:37:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:37:31 +0000 Subject: [Koha-bugs] [Bug 12535] PROG/CCSR Deprecation: Make opac translation theme independent In-Reply-To: <bug-12535-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12535-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12535-70-OzqRUnc7t4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Blocks| |11346 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:37:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:37:31 +0000 Subject: [Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes In-Reply-To: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11346-70-haUBXsVeAK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12535 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:37:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:37:43 +0000 Subject: [Koha-bugs] [Bug 12534] PROG/CCSR deprecation: Make getlanguages() theme independent for opac In-Reply-To: <bug-12534-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12534-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12534-70-RIHZXorg7h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11346 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:37:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:37:43 +0000 Subject: [Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes In-Reply-To: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11346-70-xVkOIbmzAy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12534 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:38:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:38:07 +0000 Subject: [Koha-bugs] [Bug 12513] PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference In-Reply-To: <bug-12513-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12513-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12513-70-oH59SXMq6S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12513 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Blocks| |11346 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:38:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:38:07 +0000 Subject: [Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes In-Reply-To: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11346-70-s9ucOMdzzd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12513 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:38:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:38:21 +0000 Subject: [Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes In-Reply-To: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11346-70-gzcEjchzRQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12512 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:38:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:38:21 +0000 Subject: [Koha-bugs] [Bug 12512] PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference In-Reply-To: <bug-12512-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12512-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12512-70-xxlh7oxzV4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Blocks| |11346 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:38:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:38:29 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-HsOlDkbVBE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:38:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:38:42 +0000 Subject: [Koha-bugs] [Bug 12494] Remove yuipath system preference In-Reply-To: <bug-12494-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12494-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12494-70-emmuTKdCmB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Blocks| |11346 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:38:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:38:42 +0000 Subject: [Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes In-Reply-To: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11346-70-KWeZu0QseU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12494 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:39:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:39:39 +0000 Subject: [Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes In-Reply-To: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11346-70-eaKiMtyeV2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Bug 11346 depends on bug 12534, which changed state. Bug 12534 Summary: PROG/CCSR deprecation: Make getlanguages() theme independent for opac http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:39:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:39:38 +0000 Subject: [Koha-bugs] [Bug 12534] PROG/CCSR deprecation: Make getlanguages() theme independent for opac In-Reply-To: <bug-12534-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12534-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12534-70-BCsFq8W38e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:40:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:40:22 +0000 Subject: [Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation In-Reply-To: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11349-70-ZjFD6maQPa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:40:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:40:22 +0000 Subject: [Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes In-Reply-To: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11346-70-wfSByehLFP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Bug 11346 depends on bug 11349, which changed state. Bug 11349 Summary: PROG/CCSR deprecation: Remove .tmpl -> .tt translation http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:40:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:40:40 +0000 Subject: [Koha-bugs] [Bug 11347] PROG/CCSR deprecation: Remove opacsmallimage system-preference In-Reply-To: <bug-11347-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11347-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11347-70-nHXNdGP1XW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |tomascohen at gmail.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:40:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:40:40 +0000 Subject: [Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes In-Reply-To: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11346-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11346-70-76WzQw49Tq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Bug 11346 depends on bug 11347, which changed state. Bug 11347 Summary: PROG/CCSR deprecation: Remove opacsmallimage system-preference http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:41:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:41:31 +0000 Subject: [Koha-bugs] [Bug 12459] clicking spent on acq main page not showing everything In-Reply-To: <bug-12459-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12459-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12459-70-lvkdXtnhpa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12459 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:46:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:46:31 +0000 Subject: [Koha-bugs] [Bug 11842] MARC framework editing is broken when memcache is enabled In-Reply-To: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11842-70-yuzcFf8Hft@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11842 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Is this bug present in current maste ror just 3.12? Also, does it affect any setup or just Plack? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:49:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:49:42 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11120-70-zv0dxcAXqQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12529 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:49:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:49:42 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12529-70-gJ0HQeOU1i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11120 --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Hi Chris, Did you see bug 11120? It seems you impacted the same code with this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:50:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:50:27 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12627-70-ipGKF0bGOE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12445 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 16:50:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 14:50:27 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-P9Wbn630RU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12627 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 17:04:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 15:04:33 +0000 Subject: [Koha-bugs] [Bug 11842] MARC framework editing is broken when memcache is enabled In-Reply-To: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11842-70-jX781XnPVN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11842 --- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Tom?s Cohen Arazi from comment #8) > Is this bug present in current maste ror just 3.12? Also, does it affect any > setup or just Plack? I tested on master. I didn't reproduce the issue without Plack OR Memcache. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 17:04:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 15:04:57 +0000 Subject: [Koha-bugs] [Bug 11842] MARC framework editing is broken when memcache is enabled In-Reply-To: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11842-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11842-70-f0lgVeYuEQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11842 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 17:19:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 15:19:49 +0000 Subject: [Koha-bugs] [Bug 12619] Shipment date gets lost on finishing the invoice In-Reply-To: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12619-70-FdJkqLRysv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl Summary|Shipment cost gets lost on |Shipment date gets lost on |finishing the invoice |finishing the invoice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 18:05:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 16:05:08 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12529-70-rxGIudvDfg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 29956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29956&action=edit Documentation of some test cases As BSZ has sponsored this feature I already got to test it quite a bit :) Basically we are trying to copy the logic that is used to calculate fines when finescalendar is set to "not including days the library is closed". With the new pref turned to on: No overdue notice will be sent out on a holiday. Also, if the library is closed, the overdue notice will be delayed accordingly. The overdue notice delay can be read as 'days the library is open' instead of 'calendar days'. This way the patron always has the same amount of days he actually can return the items before the next overdue notice is sent. With the new pref off, the current behaviour won't be changed at all. == Example test plan == So for testing I added a fines configuration that would result in my overdue notices being triggered the same day the fine would go up according to the calendar. This way I could check the logic was the same. I tested without the patch and with both possible settings for the new preference. = Configuration = - multiple items on multiple records with the itemtype "Books" - circulation rule: * fine amount: 1.00 * charging interval: 5 * fine grace period: 0 * overdues fines cap: 3.00 - calendar: the library is closed on Saturday and Sunday * Note: Add more holidays later and rerun tests - add 3 different overdue notices, so you can easily see which one has been triggered, I used: * ODUE1, Overdue 1 * ODUE2, Overdue 2 * ODUE3, Overdue 3 - Overdue notice triggers * Start with for the patron category you want to test with: * ODUE1, delay 5 * ODUE2, delay 10 * ODUE3, delay 15 * Note: Change settings later and rerun tests - System preferences * finesCalendar - not including days the library is closed * OverdueNoticeCalendar - ignore calendar (previous behaviour) * Note: compare this to the behaviour without the patch being applied and then swith the pref to confirm the new behaviour * CalculateFinesOnReturn - Don't (for easier without having to waive fines) = Test = - Check out items to a patron with the chosen category. Due dates should be in the past. Note: For some of my tests I checked out 1 item for each day the last 3 weeks or similar. Sometimes it can also be useful to only check out 1 item and see which due dates will trigger the overdue notice exactly. - run fines.pl to create the fines - run overdue_notices.pl -t [-v] - If you want to send the overdue notices, you can also run: process_messagequeue.pl or you can check the generated overdue notices in the patron account (notices tab) or in the database (message_queue table). I ran the scripts 3 times for each scenario I created, once on a branch without the patch and then with the patch and both settings for the new system preference 'OverdueNoticeCalendar'. After each test I truncated the accountlines and message_queue and reran the scripts. I cleaned up and translated some of my test cases, adding those as attachement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 18:12:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 16:12:31 +0000 Subject: [Koha-bugs] [Bug 12619] Shipment date gets lost on finishing the invoice In-Reply-To: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12619-70-TKwxNtsIxW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 --- Comment #2 from Jacek Ablewicz <ablewicz at gmail.com> --- Created attachment 29957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29957&action=edit Bug 12619 - Shipment date gets lost on finishing and/or editing the invoice To reproduce: - Create a new shipment, make sure to add a shipment date - Receive or not receive orders - Finish receiving with the button at the bottom of the page - Verify that shipment date is now empty To test: - reproduce the aforementioned issue - apply patch - confirm that the issue is no longer rerpoductible (= shipment date is not getting lost any longer), and that there are no apparent regresssions of any kind involving invoice shipment date entering and/or editing - sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 18:12:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 16:12:28 +0000 Subject: [Koha-bugs] [Bug 12619] Shipment date gets lost on finishing the invoice In-Reply-To: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12619-70-LZajBWrEZm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 Jacek Ablewicz <ablewicz at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 18:13:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 16:13:50 +0000 Subject: [Koha-bugs] [Bug 12619] Shipment date gets lost on finishing the invoice In-Reply-To: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12619-70-jPOhpJ9gVm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |abl at biblos.pk.edu.pl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 18:46:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 16:46:55 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12529-70-6MntOntBuN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- IMO, this patch should be based on top of bug 11120 (waiting for a signoff for 8 months now) , especially if it does not fix the --date parameter. This patch is more than an enh than a bugfix and the importance of --date should be considered. This parameter is the *only* way to recover unsent overdue notifications (for instance the script has crashed, the server was down, you forgot to add the cronjob, etc.). Actually it is not the only way, you can do it manually. But trust me, this parameter is very useful and it could help anyone at one point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 18:48:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 16:48:10 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12529-70-aTIrBFz2uB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- I have written bz-splitter to avoid this kind of conflicts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 19:32:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 17:32:50 +0000 Subject: [Koha-bugs] [Bug 12628] New: reports/cat_issues_top.pl queries incorrect column Message-ID: <bug-12628-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12628 Bug ID: 12628 Summary: reports/cat_issues_top.pl queries incorrect column Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: micah.bucy at eternalsword.com QA Contact: testopia at bugs.koha-community.org Created attachment 29958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29958&action=edit use issuedate instead of timestamp When trying to filter by Checkout Date range, it mistakenly uses the timestamp column instead of the issuedate column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 19:34:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 17:34:26 +0000 Subject: [Koha-bugs] [Bug 12628] reports/cat_issues_top.pl incorrect checkout range query In-Reply-To: <bug-12628-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12628-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12628-70-XujUbeRTjo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12628 Micah Bucy <micah.bucy at eternalsword.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|reports/cat_issues_top.pl |reports/cat_issues_top.pl |queries incorrect column |incorrect checkout range | |query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 21:42:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 19:42:35 +0000 Subject: [Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks In-Reply-To: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12477-70-sDam8272q4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Jacek Ablewicz from comment #9) > (In reply to David Cook from comment #8) > > > If a field doesn't appear in the Editor, and it gets re-saved...any fields > > not appearing in the Editor will be destroyed. > > Does it really work that way for biblos MARC frameworks?? If so, that would > be a _major_ disaster IMO. > I created a new fw, set hidden = -6 for all subtags. A new record using this fw will only show those tags/subtags that are mandatory. Editing an existing record will show any tag/subtag that have a value, even hidden ones, and on saving no information is loose. I think that default and sample (or simple) frameworks needs only 3 hidden values: visible (0), editable but not visible (2), and hidden (5) [visibility on opac/staff]. (5) could be used for obsoleted/deprecated tags/subtags (e.g. 440), but again you can't hide something in the editor with a value (-6) is the value I was told to use when adding new tags/subtags, they do not display on editor (for new) and produce no functional change, but imported record can show values [opac/staff]. Whichever we use, my thinking is that we need to use a few hidden values as possible, and default FW needs to show as many tags as possible Then sample FW could be built by copying default, and _hiding_ (editor) all but a selected subset of tags. Which subset... I don't care, but it need a certain rationale behind. Not an universal agreement though. But if they have all tags/subs then no information will be loose. That's what we need to ensure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 22 22:59:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 20:59:57 +0000 Subject: [Koha-bugs] [Bug 10188] Top Most-circulated items doesn't count current loans In-Reply-To: <bug-10188-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10188-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10188-70-B86wxtnXih@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 Micah Bucy <micah.bucy at eternalsword.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |micah.bucy at eternalsword.com --- Comment #2 from Micah Bucy <micah.bucy at eternalsword.com> --- Created attachment 29959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29959&action=edit add union This patch depends on my patch http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29958 for bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12628 This adds a union for `old_issues` and `issues`. Filtering that applied to `old_issues` before joins has been applied prior to the union on both `issues` and `old_issues`. Two new variables have been added to accomplish this $strsth2_filter and $strcalc_filter. The union is named as `circulated`. Where appropriate `old_issues` has been replaced with `circulated`. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 00:12:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 22:12:25 +0000 Subject: [Koha-bugs] [Bug 12629] New: Software error when trying to merge records from different frameworks Message-ID: <bug-12629-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12629 Bug ID: 12629 Summary: Software error when trying to merge records from different frameworks Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 29960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29960&action=edit Screen shot of record merge. Software error: Can't use string ("") as a HASH ref while "strict refs" in use at /var/lib/koha/butte/kohaclone/Koha/Util/MARC.pm line 46. To re-create: Choose a bib record that has the default framework. Add a second record using that fast add framework. Merge the records; switch to "Using framework: Default", and choose the original record (i.e. the one that had the default framework) as the merge reference. Clicking 'Next' will trigger the error. See attached screenshot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 00:58:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 22:58:00 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10212-70-TS53Xv0Kp1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #89 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #88) > (In reply to David Cook from comment #85) > > ::: C4/Utils/DataTables/ColumnsSettings.pm > > @@ +66,5 @@ > > > + for my $c (@$columns) { > > > + $c->{is_hidden} //= 0; > > > + $c->{cannot_be_toggled} //= 0; > > > + > > > + my $column = $schema->resultset('ColumnsSetting')->search( > > > > Have you considered using "update_or_create" instead of these 3 methods? > > Hum... don't repeat what you saw ;) Hehe. No worries. I've been reading a lot about DBIC this week, and thought it might be relevant :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 01:02:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jul 2014 23:02:28 +0000 Subject: [Koha-bugs] [Bug 3796] Place a hold on a specific copy allows impossible items In-Reply-To: <bug-3796-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3796-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3796-70-uicOd7fw1G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3796 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> --- It is crucial that this be fixed! We are getting bad information somehow in our reserves table (unmatched item number and bib number). Christopher -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 06:15:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 04:15:54 +0000 Subject: [Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks In-Reply-To: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12477-70-y1VxVLfNSR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 --- Comment #11 from David Cook <dcook at prosentient.com.au> --- (In reply to Bernardo Gonzalez Kriegel from comment #10) > I created a new fw, set hidden = -6 for all subtags. A new record using this > fw will only show those tags/subtags that are mandatory. > Editing an existing record will show any tag/subtag that have a value, even > hidden ones, and on saving no information is loose. Ah, my mistake! That's good! I'm glad that I was wrong! It appears that this is also the case when using Z39.50. I think the problem I may have encountered in the past was losing data when importing a record that contained fields/subfields that didn't exist in that framework. *checks with an example* Aha! Yes! That's what it is! It makes sense...if the field/subfield doesn't exist in the framework, it has no way of including it in the record. I suppose this might be both a pro and a con... When copy-cataloguing, you might only want to import a certain subset of fields, so you'd want to ignore fields not defined in that framework. On the other hand, if you're cataloguing RDA records and you're not familiar with the extra fields and subfields needed for RDA, you'll lose data that you might want to keep when importing. That said, I think the onus needs to be on librarians to properly configure their frameworks for that. I don't know if this distinction is necessarily apparent in Koha. I imagine it's possible that a librarian could create a new framework with a subset of fields, and lose data when importing records because they forgot a field/subfield. But...you could argue the onus is still on the person configuring the framework. If they didn't include the field/subfield, they have no one but themselves to blame for lost data. > I think that default and sample (or simple) frameworks needs only 3 hidden > values: visible (0), editable but not visible (2), and hidden (5) > [visibility on opac/staff]. (5) could be used for obsoleted/deprecated > tags/subtags (e.g. 440), but again you can't hide something in the editor > with a value > > (-6) is the value I was told to use when adding new tags/subtags, they do > not display on editor (for new) and produce no functional change, but > imported record can show values [opac/staff]. That sounds reasonable to me. > Whichever we use, my thinking is that we need to use a few hidden values as > possible, and default FW needs to show as many tags as possible Agreed. > Then sample FW could be built by copying default, and _hiding_ (editor) all > but a selected subset of tags. Which subset... I don't care, but it need a > certain rationale behind. Not an universal agreement though. That also makes sense. I don't know which subset either. While there are cataloguing standards, I find practice is often highly localized, so they'll need to be re-configured by end-users anyway. It might be useful to get input from cataloguers that work with a range of materials for this one. I mostly catalogued books, so I would say Leader,005,008,100(a),245(a,b,c),260(a,b,c) (maybe also 264(a,b,c) as it's used in RDA),300(a),336(a,2),337(a,2),338(a,2),490(a,v,x),500(a),505(a,r,t),520(a,b),700(a,t,d,f). I don't have a lot of experience with serials but it should probably include 773(a,t,d,g,w). Other frameworks would probably benefit from cataloguers with more specialized knowledge and experience. > But if they have all tags/subs then no information will be loose. > That's what we need to ensure Agreed. In that case, what do you think about the Fast Add Framework? It only includes a small collection of fields/subfields. Wouldn't it make more sense to include all the fields, and only show the subset that it currently shows? While I'm somewhat skeptical of the utility of many of the sample frameworks, I think the Fast Add Framework is quite useful. Admittedly, I don't know if it needs to have all the fields, as I doubt one would ever really be importing records into it. I suppose it would be good to have all the fields in case you accidentally switched to the Fast Add Framework and saved a record. That would lose data... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 06:36:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 04:36:31 +0000 Subject: [Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks In-Reply-To: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12477-70-dXnaP8gkC2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 --- Comment #12 from David Cook <dcook at prosentient.com.au> --- As for using DBIx::Class, it's literally this simple: <code> use Koha::Database; use XML::Simple; my $schema = Koha::Database->new()->schema(); my $SimpleXML = new XML::Simple; my $field_file = "../marc21_tag.xml"; my $canonical_field_structure = ''; if ( -e $field_file){ my $canonical_field_structure = $SimpleXML->XMLin($field_file, KeyAttr => []); foreach my $structure (@{$canonical_field_structure->{marc_tag_structure}}){ $schema->resultset("MarcTagStructure")->find_or_create($structure); } } </code> Of course, this is just an example. I'd prefer to use XML::LibXML rather than XML::Simple (especially as XML::Simple itself states that new code should avoid using XML::Simple), and set up the logical structure a bit differently, but yeah...that's it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 07:01:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 05:01:26 +0000 Subject: [Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks In-Reply-To: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12477-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12477-70-fEsQqzsC3s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 --- Comment #13 from David Cook <dcook at prosentient.com.au> --- Created attachment 29961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29961&action=edit DBIC-based framework updater Here is some more complex code that I've devised for updating frameworks. You give it an arrayref of hashrefs, a DBIC resultset, and an arrayref of framework codes. The script will check to see if a row matching the hashref (using the primary key specified in the resultset) exists for each framework. If it exists, it runs an optional "update" callback. If it doesn't exist, it runs an optional "insert" callback (or just inserts it into the database if no callback has been specified). Prior to the database search, the "canon_callback" can be used to modify the hashref for each frameworkcode. In my use case, if I'm loading marc_subfield_structure, I want to change the hidden value to -6 as I'm updating existing frameworks. Of course, if we were loading marc_tag_structure or were installing a framework for the first time, we wouldn't want to do that. I also use the insert/update callbacks to build messages that I sent to the template UI so that the user knows what has been updated. It's not very fast, but DBIC itself says "DBIx::Class is not built for speed, it's built for convenience and ease of use". It certainly is convenient and easy to use :). I have debated the utility of this class a bit. I figure it could be handy when we're installing the sample frameworks, as we could use the "canon_callback" to change the "hidden" value on a per framework and subfield basis. We wouldn't even need the insert/update callbacks. [Note: The DBIx::Class docs do mention that using find_or_create (and thus find_or_new or update_or_create) is subject to a race condition and that it should be run within a transaction. Mind you, lots of what we do in Koha could be subject to a race condition, so I don't know how important it is to get this right at the moment. In any case, there seems to be a few ways of using transactions with DBIC (http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/Manual/Cookbook.pod#TRANSACTIONS). It's not really a big deal when initially installing frameworks, as there shouldn't be anyone to race against, but worth mentioning for updates and in general.] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 07:15:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 05:15:04 +0000 Subject: [Koha-bugs] [Bug 3796] Place a hold on a specific copy allows impossible items In-Reply-To: <bug-3796-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3796-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3796-70-XnFj4zZdJI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3796 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_0 |master Assignee|mjr at software.coop |koha-bugs at lists.koha-commun | |ity.org --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am not sure that the new problem is the same as was reported before. As this is a very old bug, I have removed the assignee and reset the version for now. I think in order to fix this, more information is needed under which circumstances the problem occurs. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 07:35:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 05:35:13 +0000 Subject: [Koha-bugs] [Bug 12630] New: Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! Message-ID: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Bug ID: 12630 Summary: Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com ------------------------- -- REPLICATE LIKE THIS -- ------------------------- 0. Enable AllowHoldDateInFuture-system preference! 1. Select a biblio with some holds. 2. Place a hold with the "Hold starts on date"-attribute set to future. 3. More the specific hold up on the priority queue. 4. Add another normal hold, observe how it is prioritized with the "Hold starts on date"-hold, leaving old holds to the prioritization queue tail. Unfair eh? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 07:45:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 05:45:13 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12630-70-Xuu6MtYX7e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 29962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29962&action=edit Bug 12630 - Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! ------------------------- -- REPLICATE LIKE THIS -- ------------------------- 0. Enable AllowHoldDateInFuture-system preference! 1. Select a biblio with some holds. 2. Place a hold with the "Hold starts on date"-attribute set to future. 3. More the specific hold up on the priority queue. 4. Add another normal hold, observe how it is prioritized with the "Hold starts on date"-hold, leaving old holds to the prioritization queue tail. Unfair eh? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 07:47:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 05:47:24 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12630-70-PxcoBxfXcA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- _ShiftPriorityByDateAndPriority() is not used from anywhere else than AddReserve(). This feture should have no need to even check for reservation date, because it shouldn't alter the priority. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 09:36:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 07:36:32 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12627-70-KLom0bghiR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 09:36:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 07:36:34 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12627-70-ubPg3KKVI0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 --- Comment #1 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 29963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29963&action=edit Bug 12627: SQLHelper replacement - C4::Suggestions With this patch, the subroutines NewSuggestion and ModSuggestion uses DBIx::Class instead of C4::SQLHelper. Moreover, the tests has been adapted to the values returned by DBIx::Class. Test plan: 1) Apply the patch 12445 in order to get the last unit tests for Suggestions 2) Apply the patch 3) Execute the unit tests by launching : prove t/db_dependent/Suggestions.t 4) The result has to be a success without error or warning : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.01 sys + 1.65 cusr 0.09 csys = 1.80 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 09:50:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 07:50:41 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11385-70-5aJGKhxWHM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12626 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 09:50:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 07:50:41 +0000 Subject: [Koha-bugs] [Bug 12626] SQLHelper replacement - C4::Acquisition In-Reply-To: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12626-70-rNoVM9KaNg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12626 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11385 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 09:50:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 07:50:53 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11385-70-JhI9DioYRq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12627 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 09:50:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 07:50:53 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12627-70-iRaVN83ox6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11385 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 10:17:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 08:17:08 +0000 Subject: [Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors in koha-error_log In-Reply-To: <bug-8474-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8474-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8474-70-KaYMN3lQZX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474 --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 29964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29964&action=edit Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem Squashed this rogue variable initialization -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 10:57:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 08:57:54 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11425-70-FhJeU00o7c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #27 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 29965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29965&action=edit Bug 11425: Display location label instead of code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 10:58:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 08:58:19 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11425-70-ANvWOLb8ML@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #28 from Julian Maurice <julian.maurice at biblibre.com> --- The last patch needs a signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 10:59:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 08:59:56 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-kWq7hdmDuN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner <h.meissner.82 at web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29393|0 |1 is obsolete| | --- Comment #34 from Holger Mei?ner <h.meissner.82 at web.de> --- Created attachment 29966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29966&action=edit Bug 11577: Add auto_renew flags to the database - issues.auto_renew - old_issues.auto_renew - issuingrules.auto_renew Default value is zero. To test: 1) Run installer/data/mysql/updatedatabase.pl 2) Create SQL reports like: SELECT * FROM issues LIMIT 0,1 3) Confirm that a column auto_renew was added to each of the three tables. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 10:59:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 08:59:59 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-DU4i6wpmau@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner <h.meissner.82 at web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29394|0 |1 is obsolete| | --- Comment #35 from Holger Mei?ner <h.meissner.82 at web.de> --- Created attachment 29967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29967&action=edit Bug 11577: Add "Automatic renewal" to the circulation and fine rules This patch adds a column "Automatic renewal" to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that "Automatic Renewal" is set to "No" by default and can be switched to "Yes". Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 11:00:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 09:00:03 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-19ENfhCUF4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner <h.meissner.82 at web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29395|0 |1 is obsolete| | --- Comment #36 from Holger Mei?ner <h.meissner.82 at web.de> --- Created attachment 29968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29968&action=edit Bug 11577: Code and intranet template changes This patch adds a checkbox for "Automatic renewal" to the checkout page. CanBookBeRenewed is modified to include two new errors: - auto_renew (renewal shouldn't be done manually) - auto_too_soon (renewal is premature and shouldn't be done manually) To test: 1) Add or edit an issuing rule with "Automatic renewal" and another one without it. 2) Issue at least three items: - automatic renewal by issuing rule - automatic renewal by Checkbox on the checkout page - no automatic renewal 3) Test the following steps for both: Home > Circulation > Checkouts Home > Patrons > Patron details 4) Confirm that issues with automatic renewal cannot be renewed manually, even if there are still renewals left and it's not too soon to renew. 5) Confirm that "Scheduled for automatic renewal" and the remaining renewals are displayed. If no renewals are left "Not renewable" should be displayed. 6) Confirm that issues without automatic renewal behave as usual. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 11:00:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 09:00:07 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-hsIKs7XoFD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner <h.meissner.82 at web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29396|0 |1 is obsolete| | --- Comment #37 from Holger Mei?ner <h.meissner.82 at web.de> --- Created attachment 29969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29969&action=edit Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon' to the renewal interface. To test: 1) Issue two items: - one with automatic renewal and no value for "No renewal before" - another with automatic renewal and a value for "No renewal before" 2) Try to renew: Home > Circulation > Renew 3) Confirm there are error messages explaining that the items have been scheduled for automatic renewal and that one of the renewals is also premature. 4) If global syspref AllowRenewalLimitOverride is set to "Allow" you should be given the option to override. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 11:00:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 09:00:10 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-DSCIt8QtKy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner <h.meissner.82 at web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29397|0 |1 is obsolete| | --- Comment #38 from Holger Mei?ner <h.meissner.82 at web.de> --- Created attachment 29970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29970&action=edit Bug 11577: Expand description of AllowRenewalLimitOverride With the introduction of the new automatic renewal feature global syspref AllowRenewalLimitOverride is expanded in meaning. It now gives the option to override blocks if: - the number of allowed renewals is exceeded - the renewal is premature (No renewal before) - the item is scheduled for automatic renewal - the renewal is premature and the item is scheduled for automatic renewal Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 11:00:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 09:00:14 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-T86PnMUVOl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner <h.meissner.82 at web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29398|0 |1 is obsolete| | --- Comment #39 from Holger Mei?ner <h.meissner.82 at web.de> --- Created attachment 29971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29971&action=edit Bug 11577: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 11:00:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 09:00:17 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-94G8xxN461@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner <h.meissner.82 at web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29399|0 |1 is obsolete| | --- Comment #40 from Holger Mei?ner <h.meissner.82 at web.de> --- Created attachment 29972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29972&action=edit Bug 11577: OPAC prog theme changes This patch makes the prog version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to prog. 2) Test the same things as in previous patch. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 11:00:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 09:00:21 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-HHvr08nDZk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner <h.meissner.82 at web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29400|0 |1 is obsolete| | --- Comment #41 from Holger Mei?ner <h.meissner.82 at web.de> --- Created attachment 29973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29973&action=edit Bug 11577: Add an automatic renewal cronjob This patch adds a new cron script automatic_renewals.pl and a new entry in crontab.example. To test: 1) You need a few issues, some with automatic renewal and some without. 2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl those issues are renewed that meet all of the following criteria: - automatic renewal has been scheduled either by issuing rule or by checkbox on the checkout page - the number of allowed renewals isn't exceeded - renewal isn't premature (No renewal before) 3) Confirm that all other issues are not affected. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 11:00:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 09:00:24 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-UcE0Aqzzzv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner <h.meissner.82 at web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29401|0 |1 is obsolete| | --- Comment #42 from Holger Mei?ner <h.meissner.82 at web.de> --- Created attachment 29974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29974&action=edit Bug 11577: Unit tests This patch fixes a few unit tests that broke because of the new feature. To test: 1) prove t/db_dependent/Circulation.t 2) prove t/db_dependent/Circulation_Issuingrule.t 3) prove t/db_dependent/Circulation_issue.t Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 11:00:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 09:00:28 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-a3mgHlqQcD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #43 from Holger Mei?ner <h.meissner.82 at web.de> --- Created attachment 29975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29975&action=edit Bug 11577: Add Hochschule f?r Gesundheit to contributing institutions Automatic renewal is the second feature sponsored by the hsg. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 11:02:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 09:02:33 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-BnUDSOkymi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner <h.meissner.82 at web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29402|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 11:04:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 09:04:23 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-sKXnM8KF5j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner <h.meissner.82 at web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 11:06:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 09:06:11 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-cy6DQGM2vu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #44 from Holger Mei?ner <h.meissner.82 at web.de> --- Thank you for testing, Chris! :) I rebased and switched back to "Needs signoff". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 11:58:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 09:58:39 +0000 Subject: [Koha-bugs] [Bug 12631] New: Inventory: fix "wrong place" and "item not scanned" statuses Message-ID: <bug-12631-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Bug ID: 12631 Summary: Inventory: fix "wrong place" and "item not scanned" statuses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: matthias.meusburger at biblibre.com QA Contact: testopia at bugs.koha-community.org What's wrong: ------------- The current behavior in the inventory tool for item statuses is wrong on two points: 1) "item not scanned" status: when calling GetItemsForInventory, datelastseen should be used when "compare barcodes list to result" is checked. Otherwise, when loading multiple barcodes files for the same inventory, many items will be marked as "item not scanned" when loading the last barcode file ("compare barcodes list to result" checked) even though they were scanned. 2) "wrong place" status: when searching for wrongly placed items, we should only check for the location (callnumbers, location and branch). To fix this, A new call to GetItemsForInventory has been made with location filters only. Otherwise, any item with a different itemtype for instance will be marked as wrong place even if the location is correct. Test plan: ---------- Providing a strict and precise test plan is quite hard, as it is strongly dependant of your database, but you can check as follow: "item not scanned" status: 1) Split a barcode file in two. 2) Load the first barcode file without checking "compare barcodes list to result". 3) Load the second barcode file with "compare barcodes list to result" checked. 4) Check in the csv report that you have a lot of scanned items with the "item not scanned" status. Then apply the patch, do the same, and check that the false "item not scanned" statuses are gone. "wrong place" status: 1) Load a barcode file with barcode matching an item that has a correct location, but a different itemtype than what you're looking for. 2) Check in the results that this item will be marked as "change item status" and "wrong place". Then apply the patch, do the same, and check that the only status for this item is "change item status", which is correct. Remarks: -------- I'm expecting concerns about the fact that GetItemsForInventory is now called twice instead of once, but keep in mind that inventory is a quite rare operation. Also, I did not manage to find a more efficient way to fix this wrong behavior, suggestions welcome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 12:03:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 10:03:47 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: <bug-12631-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12631-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12631-70-VFveoR1bWz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 --- Comment #1 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- Created attachment 29976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29976&action=edit Inventory: fix "wrong place" and "item not scanned" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 12:06:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 10:06:34 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: <bug-12631-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12631-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12631-70-YwuiFKRjdg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Matthias Meusburger <matthias.meusburger at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 12:53:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 10:53:30 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8148-70-pMdYk35vop@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26024|0 |1 is obsolete| | --- Comment #21 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29977&action=edit Prevent local authentification fallback if an invalid LDAP password was entered. http://bugs.koha-community.org/show_bug.cgi?id=8148 Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 12:53:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 10:53:41 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8148-70-BiNeW7xh2j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26025|0 |1 is obsolete| | --- Comment #22 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29978&action=edit Only update the password if the LDAP password field was mapped. http://bugs.koha-community.org/show_bug.cgi?id=8148 Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 12:53:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 10:53:51 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8148-70-QXnfEdRYH4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26543|0 |1 is obsolete| | --- Comment #23 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29979&action=edit Bug 8148 - LDAP auth_by_bind doesn't fallback to local auth This patch covers LDAP auth_by_bind configuration so that wrong LDAP password will return -1 to C4::Auth so we can abort local auth and prevent users logging in with stale database passwords. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 12:55:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 10:55:51 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8148-70-YudJNDbaoK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Martin, now that Dobrica has signed off on the first 2 and the third is only a tiny change, would you be ok with passing this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 13:22:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 11:22:08 +0000 Subject: [Koha-bugs] [Bug 12624] Getting all search results in C4::Breeding::Z3950Search, instead of pageful In-Reply-To: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12624-70-uILbEX694W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12624 --- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Does this still work on top of bug 6536 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 13:28:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 11:28:28 +0000 Subject: [Koha-bugs] [Bug 12624] Getting all search results in C4::Breeding::Z3950Search, instead of pageful In-Reply-To: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12624-70-v58uZO4akb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12624 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Probably not, thanks for pointing it out. I second that bug 6536 takes precedence over this one. I'll refactor this as needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 13:33:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 11:33:50 +0000 Subject: [Koha-bugs] [Bug 12623] SQLHelper replacement - Koha::Borrower::Modifications In-Reply-To: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12623-70-lFwKXaV1pA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12623 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 13:36:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 11:36:54 +0000 Subject: [Koha-bugs] [Bug 12624] Getting all search results in C4::Breeding::Z3950Search, instead of pageful In-Reply-To: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12624-70-7OW9QuWwfy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12624 --- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Olli-Antti Kivilahti from comment #3) > Probably not, thanks for pointing it out. > > I second that bug 6536 takes precedence over this one. I'll refactor this as > needed. I still wanted to touch that paging stuff some time.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 13:45:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 11:45:50 +0000 Subject: [Koha-bugs] [Bug 12618] Sending of authority records via Z39.50 In-Reply-To: <bug-12618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12618-70-3OQ2cODCwT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12618 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sending of authority |Sending of authority |redords via Z39.50 |records via Z39.50 --- Comment #1 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Please have a look at Koha's koha-conf.xml. You need to uncomment and/or copy some lines referring to port 9999 and authorityserver (copy from publicserver to publicauthserver or so, and make some biblio to auth changes). Check your changes and restart Zebra. If your edits were fine, your Koha/Zebra will now send auth records on port 9999 via Z39.50 and/or SRU. I agree that the default conf file should make this operation somewhat more smoothly as it is now.. But you are allowed to send patches to make that happen :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 13:47:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 11:47:22 +0000 Subject: [Koha-bugs] [Bug 12624] Getting all search results in C4::Breeding::Z3950Search, instead of pageful In-Reply-To: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12624-70-ttW8ogv0aP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12624 --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- You are free to refactor my patch or substitute it with your own if you are in a hurry. Just please submit it here so I can utilize it as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 14:07:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 12:07:07 +0000 Subject: [Koha-bugs] [Bug 12632] New: Hold limits ignored for record level holds with item level itemtypes Message-ID: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Bug ID: 12632 Summary: Hold limits ignored for record level holds with item level itemtypes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The crux of the issue is that if you are using item level itemtypes, but are allowing biblio levels holds, those holds do not have items. So, in CanItemBeReserved, when Koha counts the number of holds to compare against the given rule, it will always give 0 ( except of course for found holds, and the occasional item-level hold ). So the query is saying "link each of these reserves to the reserved item, and count the number of reserves this patron where the itemtype is DVD". However, since these are all record level reserves, there are no items to link to, and so when it looks for all reserves this and item whose itemtype is DVD, it finds zero reserves! I can see a few resolutions to this: 1) Add a system preference ReservesControlTypeLevel to allow a library to select between item and record level itemtypes for hold rules. 2) Use COALESCE(itype,itemtype) to more gracefully select record level itemtypes if the reserve is a record level hold 3) Add a conditional if to our query such that if the reserve has no itemtype, we should join on reserves.biblionumber=items.biblionumber instead of reserves.itemnumber=items.itemnumber, with a 'GROUP BY itemnumber' tacked on. 4) The same as 3, but instead of a conditional, join to items twice, once by itemnumber items_i, once by biblionumber items_b. Group by itemnumber, use COALESCE( items_i.itemtype, items_b.itemtype ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 14:07:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 12:07:13 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-9bCvnBLwOq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 14:26:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 12:26:12 +0000 Subject: [Koha-bugs] [Bug 12623] SQLHelper replacement - Koha::Borrower::Modifications In-Reply-To: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12623-70-DHl07R7ZTX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12623 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29951|0 |1 is obsolete| | --- Comment #2 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 29980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29980&action=edit Bug 12623: SQLHelper replacement - Borrower::Modifications With this patch, the subroutines AddModification and ApproveModifications uses DBIx::Class instead of C4::SQLHelper. Moreover, the tests has been wrapped in a transaction. Test plan: 1) Apply the patch 2) Execute the unit tests by launching : prove t/db_dependent/Koha_borrower_modifications.t 3) The result has to be a success without error or warning : t/db_dependent/Koha_borrower_modifications.t .. ok All tests successful. Files=1, Tests=14, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.60 cusr 0.08 csys = 1.72 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 14:26:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 12:26:10 +0000 Subject: [Koha-bugs] [Bug 12623] SQLHelper replacement - Koha::Borrower::Modifications In-Reply-To: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12623-70-w1wQuCC57e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12623 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 14:28:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 12:28:18 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-8YFyRMMnEy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- My preferences for the solutions from best to worst: 4,2,3,1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 14:43:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 12:43:56 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-S5UyKOlhkB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- This looks good except for a couple of really minor issues: The path to the "loading" image is hard-coded to the prog theme, and the image lacks an alt attribute. <img src="/intranet-tmpl/prog/img/loading.gif" /> ...should be: <img src="[% interface %]/[% theme %]/img/loading.gif" alt="" /> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 14:49:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 12:49:03 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-F9lqT8UsAd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- I see one other thing: <strong>Processing...<strong> The second <strong> should be </strong> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 15:05:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 13:05:10 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-AWMWf1pdjl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 15:06:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 13:06:58 +0000 Subject: [Koha-bugs] [Bug 12629] Software error when trying to merge records from different frameworks In-Reply-To: <bug-12629-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12629-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12629-70-OgxbMS440C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12629 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 15:19:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 13:19:52 +0000 Subject: [Koha-bugs] [Bug 12633] New: SQLHelper replacement - C4::Members Message-ID: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Bug ID: 12633 Summary: SQLHelper replacement - C4::Members Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: yohann.dufour at biblibre.com QA Contact: testopia at bugs.koha-community.org The module C4::Members depends on module C4::SQLHelper. However, the module SQLHelper is obsolete, so the calls for InsertInTable, UpdateInTable and SearchInTable have to be replaced by the use of the module DBIx::Class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 15:20:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 13:20:01 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12633-70-7EvwZ7CiO1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |yohann.dufour at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 15:20:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 13:20:37 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12633-70-9WDzvQkTuy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11385 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 15:20:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 13:20:37 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11385-70-CHpNSbQrEH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12633 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 15:24:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 13:24:14 +0000 Subject: [Koha-bugs] [Bug 12634] New: JavaScript error in Bootstrap OPAC detail page if OPACPopupAuthorsSearch is enabled Message-ID: <bug-12634-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12634 Bug ID: 12634 Summary: JavaScript error in Bootstrap OPAC detail page if OPACPopupAuthorsSearch is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org If OPACPopupAuthorsSearch is enabled, clicking an author on the OPAC detail page triggers a modal dialog where the user can choose which authors should be included in the search. Clicking the submit button in this window triggers a JS error and the search is not performed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 15:46:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 13:46:34 +0000 Subject: [Koha-bugs] [Bug 12635] New: Course reserves item list should use "Checked out" instead of "On Loan" Message-ID: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 Bug ID: 12635 Summary: Course reserves item list should use "Checked out" instead of "On Loan" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Koha uses the phrase "checked out" in the default en translation instead of "on loan." Also incorrect: Capitalization of "Item Lost." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 15:47:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 13:47:06 +0000 Subject: [Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan" In-Reply-To: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12635-70-vDhJsrENZT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |/cgi-bin/koha/course_reserv | |es/course-details.pl?course | |_id=X -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 16:13:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 14:13:28 +0000 Subject: [Koha-bugs] [Bug 12636] New: Batch patron modification should not update with unique patron attributes Message-ID: <bug-12636-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12636 Bug ID: 12636 Summary: Batch patron modification should not update with unique patron attributes Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/modborrowers.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Batch patron modification should not offer to update patron attributes with values which are designated as unique since such attributes are required to be unique to a single patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 16:28:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 14:28:57 +0000 Subject: [Koha-bugs] [Bug 12637] New: UTF-8 problems when creating a patron list from the patron search results page Message-ID: <bug-12637-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Bug ID: 12637 Summary: UTF-8 problems when creating a patron list from the patron search results page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Steps to reproduce: 1. Perform a patron search in the patrons module 2. Select one or more patrons 3. Choose "Add selected patrons to: [ New list ]" 4. Enter a patron list title with UTF-8 characters, ex: "P?tron list five " 5. The list will be created with bad encoding: "P%C3%A0tron%20list%20five%20" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 16:31:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 14:31:44 +0000 Subject: [Koha-bugs] [Bug 12637] UTF-8 problems when creating a patron list from the patron search results page In-Reply-To: <bug-12637-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12637-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12637-70-OgcCfBuy5h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 16:31:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 14:31:44 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-OqnDbRXa1j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12637 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 16:36:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 14:36:26 +0000 Subject: [Koha-bugs] [Bug 12637] UTF-8 problems when creating a patron list from the patron search results page In-Reply-To: <bug-12637-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12637-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12637-70-KNbEAReaaC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Note that creating or editing a patron list via Tools -> Patron lists does not show the same problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 16:40:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 14:40:11 +0000 Subject: [Koha-bugs] [Bug 12638] New: UTF-8 support; C4::Members::AttributeTypes::GetAttributeTypes_hashref should be rewrite Message-ID: <bug-12638-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12638 Bug ID: 12638 Summary: UTF-8 support; C4::Members::AttributeTypes::GetAttributeTypes_hashref should be rewrite Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org If I create a new authorised values list, I use it in Patron attribute types and in the Patron attribute type code I insert something like '???', those special chars create problems to C4::Members::AttributeTypes::GetAttributeTypes_hashref. You can see the problem settinf an new authorised values list, use it in a new Patron attribute type and as code in Patron attribute type code use '???'. Then go to Tool -> Patron lists and create a list After go to Tool -> Batch patron modification and try to use the list that you have create to configure a change in patron. This errot it will block you: Software error: Can't call method "authorised_value_category" on an undefined value at /home/koha/src/tools/modborrowers.pl line 109. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 16:40:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 14:40:58 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-d0735WBswf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12638 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 16:40:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 14:40:58 +0000 Subject: [Koha-bugs] [Bug 12638] UTF-8 support; C4::Members::AttributeTypes::GetAttributeTypes_hashref should be rewrite In-Reply-To: <bug-12638-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12638-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12638-70-FK3ZkUjRCv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12638 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 17:03:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 15:03:22 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-NIKcI26q7F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #208 from Jonathan Druart <jonathan.druart at biblibre.com> --- TODO: add an updatedb entry to change the charset collate to utf8_unicode_ci. Somethink like SET foreign_key_checks = 0; foreach table ALTER TABLE `table` CONVERT TO CHARACTER SET utf8 COLLATE utf8_unicode_ci; end SET foreign_key_checks = 1; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 17:04:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 15:04:06 +0000 Subject: [Koha-bugs] [Bug 12638] UTF-8 support; C4::Members::AttributeTypes::GetAttributeTypes_hashref should be rewrite In-Reply-To: <bug-12638-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12638-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12638-70-edJwpU19TH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12638 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Should be fixed by bug 11944 comment 208. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 17:48:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 15:48:14 +0000 Subject: [Koha-bugs] [Bug 12608] Replace use of DBI with DBIx::Class throughout Koha In-Reply-To: <bug-12608-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12608-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12608-70-Kty5Gu4dXR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12608 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11385 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 17:48:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 15:48:14 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11385-70-VR6y7Fskpp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Blocks| |12608 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 17:57:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 15:57:34 +0000 Subject: [Koha-bugs] [Bug 11978] OverDrive API now prepends http:// to URLs In-Reply-To: <bug-11978-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11978-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11978-70-WR6MJuUwIb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Fridolin SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers at biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 17:59:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 15:59:37 +0000 Subject: [Koha-bugs] [Bug 11855] Tiny code cleanup in members In-Reply-To: <bug-11855-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11855-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11855-70-yZTvPH7DHZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Fridolin SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers at biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:03:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:03:13 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9805-70-FljjmYWnLm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- 11:57:12 AM) cait: next one is a discussion on lot item handling (11:57:27 AM) cait: the bug is bug 9805 (11:57:28 AM) huginn: Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 normal, P5 - low, ---, kyle, In Discussion , Lost items are un-lost if returned, but not if renewed. (11:58:06 AM) cait: tcohen suggests that we change it to allow/disallow reneal of lost items as an option on the circulation conditions page (not necessarily the big table, but a by branch setting on that page) (11:58:25 AM) cait: currently it is about resetting the lost satus (finding he item) when you renew (11:59:18 AM) cait: in my opionion it makes sense to not allow renewal of lost items in the first place, but i am not totally sure how it would impact workflows (11:59:26 AM) khall: that would be a fine solution by me. (11:59:46 AM) oleonard: I would think we would need to both allow/disallow renewal of lost item *and* have a preference about whether the status should be removed upon renewal. (12:00:03 PM) oleonard: However I don't speak based on my library's policy, just in the abstract. (12:00:08 PM) cait: i am a bit worried if a patron canremove the lost status by renewing in the opac (12:00:21 PM) cait: that would be confusing about the replacement fee already charged (12:00:48 PM) barton: good point, cait. (12:00:57 PM) ColinC: Or if you allow phone renewals ... (12:01:00 PM) khall: agreed, it's better to block the renewing of lost items altogether -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:05:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:05:51 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-av8EV5ubcp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #209 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29981&action=edit Bug 11944: Remove all utf8 filter from templates This patch - removes all html_entity usages in tt file which hide utf8 bugs - removes all encode utf8 in tt plugins because we should get correctly marked data from DBIC and other sources directly (cf plugin EncodeUTF8 used in renew.tt) - adds some cleanup in C4::Templates::output: we now use perl utf8 file handler output so we don't need to decode tt variables manually. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:05:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:05:59 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-sqVRDjDv3p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #210 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29982&action=edit Bug 11944: replace use of utf8 with Encode See the wiki page for the explanation. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:07:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:07:32 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-5Ij5fS5KM5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #211 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29983&action=edit Bug 11944: Encoding UTF8 in C4::Templates Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:07:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:07:56 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-TqTTL7KM5g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #212 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29984&action=edit Bug 11944: Set ImplicitUnicode for YAML Before this patch, string for yaml files used in preferences.pl were broken. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:08:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:08:27 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-x7T3WtW8l4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #213 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29985&action=edit Bug 11944: Library name variable should be decoded Test on preferences.pl and on some others pages when mysql is used to store session. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:09:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:09:46 +0000 Subject: [Koha-bugs] [Bug 3796] Place a hold on a specific copy allows impossible items In-Reply-To: <bug-3796-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3796-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3796-70-TxpzVn8Zo8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3796 --- Comment #5 from Christopher Brannon <cbrannon at cdalibrary.org> --- We don't have specifics yet. All we have is the evidence left the table. I think that there should be a check somewhere...a cron job, or something, that checks the validity of the reserves table. Particularly between the item number and bib number. And perhaps against the patron account. There are two problems evident: 1) Mismatched item and bib numbers in the reserves table. 2) Reserves showing in the reserves table, and not showing in the patron account. Most likely because of issue 1. Is it necessary to have a bib number in the reserves table when the item number is recorded for an item level hold? Seems redundant if the bib number is in the items table. That would be the simplest remedy for this issue. So, rather than using the bib number in the reserves table for any holds functions, it could be referenced from the items table. Otherwise, we might need a checkpoint to verify accuracy. As I said, we don't have an answer as to how this is happening. I can think of a few ways it might happen, but I don't think one of them is the case, since it happened to a couple of items with the same patron. One way it could happen is that a patron is reconstructing the URL manually and blending mismatched info. The second way is that a hold is placed on an item. The item record is then turned into a different item and attached to a different bib. OR better yet, an item is created and accidently attached to the wrong bib, and after the hold is placed, the item is moved to the correct bib. It seems that maybe when items are moved from one bib to another, a check should take place to verify any possible holds in the reserves table. I don't know if this helps, but that's my two cents. Christopher -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:12:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:12:55 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-DEddIocz51@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #214 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29986&action=edit Bug 11944: replace uri_escape with uri_escape_utf8 everywhere To reproduce, edit, index notice with utf-8 char and search for it Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:13:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:13:05 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-bbvvATRnuF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #215 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29987&action=edit Bug 11944: Never use decode/encode in TT Plugins The EncodeUTF8 TT plugin is useless, we should NEVER use encode in templates. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:13:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:13:14 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-BHcRo1kDSU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #216 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29988&action=edit Bug 11944: Remove obsolete encoding routines We don't need to decode manually which provide nice performance boost. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:13:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:13:23 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-Tc3SkNvQ69@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #217 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29989&action=edit Bug 11944: TT Plugins should not encode strings Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:13:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:13:41 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-5eQF4Zkn8j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #218 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29990&action=edit Bug 11944: Some refresh don't indicate the charset to use This patch replaces occurrences of META HTTP-EQUIV=Refresh with a redirection. Note: The list of modified files has been got with the following grep: git grep Content-Type | grep -v -i utf | grep Refresh | grep -v translator | grep -v \.js Test plan: 1) admin/auth_tag_structure.pl - Go on an authority MARC framework for an authority type (admin/auth_tag_structure.pl?authtypecode=CO for instance) - Click on the "Add a new tag" button - Fill fields - Save - You should be redirected on the auth_tag_structure.pl page - Try to modify an existing tag - The redirection should be done 2) admin/auth_subfields_structure.pl - From the previous page, click on a "subfields" link - Edit/Add a new subfields - Save - You should be redirected to the subfield list - Delete a subfield - You should be redirected to the subfield list 3) admin/authorised_values.pl - Add/Edit an authorised value - Save - You should be redirected to the authorised value list (with the right category selected) 4) admin/categorie.pl - Add/Edit a patron category - Save - You should be redirected to the category list - Delete a patron category - You should be redirected to the category list 5) admin/koha2marclinks.pl - Go on the Koha to MARC mapping configuration page - Edit a field - Map a field and click on "OK" - You should be redirected to the list 6) admin/marc_subfields_structure.pl - Go on the MARC frameworks page - Click on "MARC structure" for one on the list - Click on "Subfields" for one on the list - Add/Edit a subfield - Save - You should be redirected to the subfield list 7) admin/systempreferences.pl - Go on the system preferences admin page - Click on the "Local use" tab - Add/Edit a pref - Save - You shold be redirected to the Local use preference list 8) serials/subscription-detail.pl - Go on a subscription detail page - Delete the subscription (using Edit > Delete subscription) - You should be redirected on the serials home page Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:13:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:13:50 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-yZ9yElXoat@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #219 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29991&action=edit Bug 11944: FIX Error on editing an authority Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:14:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:14:01 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-j0aeuu701S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #220 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29992&action=edit Bug 11944: Fix encoding issue on searching The search patch should fix non-latin character searches. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:16:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:16:36 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-NIekMNP1MM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #221 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29993&action=edit Bug 11944: Authentication The password should be encoded before hashing. Test plan: - Before applying the patch, create a user with utf-8 in password - apply patches - try to log in - change the password - log out - try to log in Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:17:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:17:01 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-rfSv0NLMaP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #222 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29994&action=edit Bug 11944: Fix fund names encoding on the parcel page On the parcel page, the subtotal values are stored in an hashref. The key was the fund name. The fund name being encoded in utf8, the hashref was broken. This patch replaces this logic creating a key based on an integer. The budget name is now stored in a new "budget_name" key. Note: It also fixes a small ergonomic issue (a td was missing in the tfoot). Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:17:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:17:13 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-T0GMVaaFEq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #223 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29995&action=edit Bug 11944: Fix encoding issue on adding a subscription If frequencies or numbering patterns contain non-latin characters, so output was broken. To reproduce: - Create a frequency and a numbering pattern with non-latin characters - Add a new subscription using these values - The screen should not contain bad encoded characters. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:17:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:17:28 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-wPtRTkhEhL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #224 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29996&action=edit Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:17:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:17:51 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-ZKMQNYY5hJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #225 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29997&action=edit Bug 11944: Fix encoding on sending emails This patch fixes 2 places where mails were badly encoded: 1/ At the opac and the intranet, on sending baskets 2/ At the opac and the intranet, on sending shelf/list Test plan: Shelf/List: - Create a list with non-latin characters in the name. - Add some items containing non-latin characters in their content. - Send the list by email Basket/Cart: - Add some items containing non-latin characters in their content to your cart.. - Send the cart by email Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:20:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:20:23 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-aeAyUnhTyx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #226 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29998&action=edit Bug 11944: Fix encoding issue for the "Did you mean" feature Test plan: 1/ Go on admin/didyoumean.pl and enable the feature for the OPAC 2/ Generate and use the french templates 3/ Launch a search at the OPAC 4/ You should see correctly encoded message Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:22:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:22:29 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-AEequdZOUF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #227 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 29999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29999&action=edit Bug 11944: Fix encoding issue on search history Newly introduced by patches from bug 10807, the string was decoded before to be stored in session. To reproduce: Enable history search Go at the OPAC and log out Search for something with utf-8 Go on your search history The search description should be correctly encoded Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:22:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:22:52 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-ZezyiK89IV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #228 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 30000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30000&action=edit Bug 11944: Remove bad FIXME in guided_report Bug 11679 introduced a FIXME for this but it is wrong. The strings have to be encoded before generating the ods file. However, it is useless to decode column names. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:23:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:23:17 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-2eJyNXKlSV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #229 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 30001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30001&action=edit Bug 11944: Facets and resort Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:23:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:23:50 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-EzWlG3SEve@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #230 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 30002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30002&action=edit Bug 11944: Fix encoding issue in C4::ItemType There is no need to encode strings coming from DB. To reproduce: go on admin/item_circulation_alerts.pl The headers contain bad encoded characters. Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:24:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:24:19 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-n23x5D5IGe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #231 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 30003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30003&action=edit Bug 11944: (follow-up) Remove all utf8 filter from templates This patch removes 2 new occurrences introduced by bug 11351 and bug 10493. Signed-off-by: Magnus Enger <digitalutvikling at gmail.com> Removes a nasty "Template process failed: plugin error - EncodeUTF8: plugin not found at /home/magnus/scripts/kohaclone/C4/Templates.pm line 124" from /cgi-bin/koha/admin/itemtypes.pl Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:24:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:24:50 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-BnNhmZ4Nye@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #232 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 30004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30004&action=edit Revert "Bug 12279: Diacritics in system preference editor broken" This reverts commit 2fa2480447a58f9d5d3f7834bcfdcf62a0a95df3. Conflicts: admin/preferences.pl Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:25:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:25:20 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-XuPD94qm7G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #233 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 30005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30005&action=edit Bug 11944: remove url/uri filter from query_cgi We don't need to pass query_cgi through url (or uri) filter since this will turn query string (correctly escaped inside code) back into two-byte escaped string which CGI( -utf8 ) won't turn back into proper utf-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:25:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:25:55 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-VD2IlbRGfC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #234 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 30006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30006&action=edit Bug 11944: decode uri_unescape data This data is passed into form so it needs to be correctly marked as utf-8 if we want form submit to work correctly This change fixes sort issues which use form submit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 18:45:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 16:45:00 +0000 Subject: [Koha-bugs] [Bug 12629] Software error when trying to merge records from different frameworks In-Reply-To: <bug-12629-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12629-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12629-70-iyvBuNYOSj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12629 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30007&action=edit Bug 12629 - Software error when trying to merge records from different frameworks Test Plan: 1) Choose a bib record that has the default framework. 2) Add a second record using that fast add framework. 3) Merge the records; switch to "Using framework: Default", and choose the original record (i.e. the one that had the default framework) as the merge reference. Clicking 'Next' will trigger the error. 4) Apply this patch 5) Repeat steps 1 - 3, no error should occur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 19:06:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 17:06:08 +0000 Subject: [Koha-bugs] [Bug 12639] New: Z39.50 administration page should use "message" dialog for adds and updates Message-ID: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12639 Bug ID: 12639 Summary: Z39.50 administration page should use "message" dialog for adds and updates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org When a Z39.50 server is added or updated the page outputs a message to the screen using a box styled as "dialog alert." It should use "dialog message" instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 19:12:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 17:12:36 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-yUizlNAi7C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Cathi Wiggins <cwiggins at ci.arcadia.ca.us> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 19:12:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 17:12:51 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-A7aCeGMm7Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29674|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 19:12:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 17:12:59 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-IsHJUj6qvq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 --- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 30008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30008&action=edit Bug 12568 - Improve visibility of successful renewal via opac Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully. Test Plan: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table Signed-off-by: Cathi Wiggins <cwiggins at ci.arcadia.ca.us> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 19:23:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 17:23:29 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: <bug-11887-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11887-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11887-70-Q6QYgsTWOV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25776|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30009&action=edit Bug 11887 - Add script for collections agency reports Some libraries use collections agencies such as Unique Management Services to collection large unpaid balances owed to the library. It would be helpful if Koha had a standard script to generate these reports, rather than forcing each library to create their own solution. This script is written following the guidelines for Unique Management Systems. However, the reports it outputs should be useable by any collections agency. Test Plan: 1) Create the four required patron attributes 2) Create a patron who owes more then 5.00 in fees 3) Run the submission report account_collections.pl -r submission \ -mb 3 -bd $yesterday_iso -ed $tomorrow_iso -f 10 \ -ft $fee_type -fd $fee_desc -c $can-collect-attribute-code \ -i $in-collections-attribute-code -l $last-updated-attribute-code \ -p previous-balance-attribute-code 4) Note the patron is now marked as in collections and has had the collections fee of 10.00 applied 5) Add a new fee to the patron's account 6) Run the update report with the same additional parameters 7) Verify the csv file generated contains that patron 8) Run the sync report with the same additional parameters 9) Note the csv file generated contains that patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 22:06:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 20:06:10 +0000 Subject: [Koha-bugs] [Bug 12640] New: UTF8: problem on serials during display of a search result Message-ID: <bug-12640-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12640 Bug ID: 12640 Summary: UTF8: problem on serials during display of a search result Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org This bug is quite similar to Bug 12638. I insert hellenic chars in frequencies and in numbering patterns I use a bibliographic record with hellenic chars in title. I create a subscription with this biblio and with frequencie and numbering pattern with hellenic char. I try to do a search with ISSN of the biblio (0154-8344). The result is: Software error: Template process failed: undef error - Undefined subroutine &Koha::Template::Plugin::AuthorisedValues::encode called at /home/koha/src/Koha/Template/Plugin/AuthorisedValues.pm line 28. I use sandbox n.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 22:07:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 20:07:53 +0000 Subject: [Koha-bugs] [Bug 12640] UTF8: problem on serials during display of a search result In-Reply-To: <bug-12640-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12640-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12640-70-GHF0fw82ve@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12640 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 22:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 20:08:20 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-iILbNqNd5k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12640 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 22:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 20:08:20 +0000 Subject: [Koha-bugs] [Bug 12640] UTF8: problem on serials during display of a search result In-Reply-To: <bug-12640-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12640-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12640-70-1u4OJ6W2Cq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12640 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:32:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:32:22 +0000 Subject: [Koha-bugs] [Bug 12464] Bootstrap XSLT view no longer displaying 505 correctly formatted In-Reply-To: <bug-12464-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12464-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12464-70-C0sdmZ9RV1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12464 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:32:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:32:32 +0000 Subject: [Koha-bugs] [Bug 12361] No default value for opaccolorstylesheet syspref In-Reply-To: <bug-12361-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12361-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12361-70-9VwVNpBevp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:32:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:32:45 +0000 Subject: [Koha-bugs] [Bug 12455] The module C4/SMS.pm needs more unit tests In-Reply-To: <bug-12455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12455-70-ZZAdEzvUws@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12455 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:32:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:32:54 +0000 Subject: [Koha-bugs] [Bug 12456] The file C4/Maintainance.pm can be removed In-Reply-To: <bug-12456-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12456-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12456-70-vn40nFrQ0d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:33:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:33:39 +0000 Subject: [Koha-bugs] [Bug 12304] Creating a user via LDAP doesn't populate message preferences In-Reply-To: <bug-12304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12304-70-yIMGVBgrwP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12304 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:33:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:33:48 +0000 Subject: [Koha-bugs] [Bug 11857] Number of patrons on a patron list not accurate In-Reply-To: <bug-11857-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11857-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11857-70-9wLdtJjx8V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11857 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:33:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:33:59 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: <bug-10652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10652-70-afH234k3qx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion --- Comment #8 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:34:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:34:06 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: <bug-10652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10652-70-XDu8MaZp3O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:34:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:34:14 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: <bug-10652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10652-70-VOAoDW4XTt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:34:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:34:20 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: <bug-10652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10652-70-FWpwMGlNRJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:34:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:34:29 +0000 Subject: [Koha-bugs] [Bug 12220] bootstrap not responsive on all devices In-Reply-To: <bug-12220-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12220-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12220-70-vfLm9Zmklq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:34:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:34:38 +0000 Subject: [Koha-bugs] [Bug 12451] circulation rule cant be edited if itemtype contains a space character In-Reply-To: <bug-12451-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12451-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12451-70-Jl0ODwoQ2J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12451 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:34:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:34:47 +0000 Subject: [Koha-bugs] [Bug 12409] The test t/db_dependent/Record.t fails with Perl 5.18.2 In-Reply-To: <bug-12409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12409-70-ZEU2iuR7lF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12409 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:34:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:34:56 +0000 Subject: [Koha-bugs] [Bug 12511] Novelist Select not using https in bootstrap In-Reply-To: <bug-12511-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12511-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12511-70-1LuXxEGjgG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:35:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:35:10 +0000 Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in french unimarc_complet default Framework In-Reply-To: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11021-70-SJ6PvqP4je@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt at gmail.com --- Comment #20 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:35:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:35:21 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11030-70-E5z4snEWaD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:35:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:35:29 +0000 Subject: [Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework In-Reply-To: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11030-70-IiqChCZGfw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:35:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:35:39 +0000 Subject: [Koha-bugs] [Bug 9245] Visual Bug under fines tab In-Reply-To: <bug-9245-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9245-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9245-70-PpLALJssKZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:35:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:35:49 +0000 Subject: [Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests In-Reply-To: <bug-12417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12417-70-hI0ukyAaqP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:35:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:35:59 +0000 Subject: [Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests In-Reply-To: <bug-12470-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12470-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12470-70-9qmPfzCExp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 23 23:36:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 21:36:07 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: <bug-11226-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11226-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11226-70-TLpQzfd6YP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 00:17:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 22:17:06 +0000 Subject: [Koha-bugs] [Bug 12641] New: Formally deprecate the GRS-1 indexing mode Message-ID: <bug-12641-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12641 Bug ID: 12641 Summary: Formally deprecate the GRS-1 indexing mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org This is an omnibus bug is for formally deprecating the GRS-1 indexing mode for Zebra, as decided during the 23 July development meeting. The relevant coding guideline is: "The DOM Zebra indexing mode is now the standard supported method for Koha. The GRS-1 indexing mode is deprecated for all record types and MARC flavours. New Koha patches that update index definitions must change the DOM indexing definitions. If a patch is intended to be backported to a maintenance release, changes to GRS-1 index definitions should be kept in a separate patch." Any bugs that would prevent the ultimate removal of the GRS-1 indexing configuration should be entered of blockers of this omnibus. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 01:22:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 23:22:28 +0000 Subject: [Koha-bugs] [Bug 12641] Formally deprecate the GRS-1 indexing mode In-Reply-To: <bug-12641-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12641-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12641-70-xB7TbgHxSn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12641 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 01:35:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 23:35:51 +0000 Subject: [Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree In-Reply-To: <bug-12545-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12545-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12545-70-UhnorOdIHO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook <dcook at prosentient.com.au> --- I saw that there is a Notepad++ plugin (which is what I usually use), so I'd be keen to try this out sometime... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 01:42:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jul 2014 23:42:06 +0000 Subject: [Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree In-Reply-To: <bug-12545-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12545-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12545-70-UKkUSJOUpU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545 --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to David Cook from comment #2) > I saw that there is a Notepad++ plugin (which is what I usually use), so I'd > be keen to try this out sometime... There is, indeed a plugin for it. The key idea is that if anyone works on different projects with different coding guidelines, the Koha-specific config is confined to the project. Also, for people starting, we could add it (installing the necesary plugin) to the list of steps to setup the dev environment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 03:08:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 01:08:07 +0000 Subject: [Koha-bugs] [Bug 12642] New: SMS.t requires a database Message-ID: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Bug ID: 12642 Summary: SMS.t requires a database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: robin at catalyst.net.nz QA Contact: gmcharlt at gmail.com Needs to be moved to db_dependant or builds will be broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 03:33:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 01:33:56 +0000 Subject: [Koha-bugs] [Bug 12642] SMS.t requires a database In-Reply-To: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12642-70-gev4kEI05y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 --- Comment #1 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 30010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30010&action=edit Bug 12642 - move SMS.t to the db_dependant directory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 03:34:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 01:34:45 +0000 Subject: [Koha-bugs] [Bug 12642] SMS.t requires a database In-Reply-To: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12642-70-ImVrNqA4SK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 06:48:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 04:48:45 +0000 Subject: [Koha-bugs] [Bug 11443] Refactoring code sending basket from OPAC/intra In-Reply-To: <bug-11443-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11443-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11443-70-XXSQrajr8e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11443 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea <liz at catalyst.net.nz> --- Using the user editable notice feature for this would be awesome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 06:50:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 04:50:40 +0000 Subject: [Koha-bugs] [Bug 12643] New: Add abstract/table of contents fields to the email cart functionality Message-ID: <bug-12643-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12643 Bug ID: 12643 Summary: Add abstract/table of contents fields to the email cart functionality Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org It would be nice if the cart would send via email the "more details" view instead of the simple view. This more details view should definitely include the abstract and table of contents fields, if available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 06:51:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 04:51:59 +0000 Subject: [Koha-bugs] [Bug 12643] Emailing cart should send more details view instead of simple view In-Reply-To: <bug-12643-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12643-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12643-70-Qv9HtIqgZY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12643 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add abstract/table of |Emailing cart should send |contents fields to the |more details view instead |email cart functionality |of simple view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 06:56:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 04:56:06 +0000 Subject: [Koha-bugs] [Bug 12644] New: Add subtitles to all cart views Message-ID: <bug-12644-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644 Bug ID: 12644 Summary: Add subtitles to all cart views Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org The 245$b should be shown in all views of the cart, if it exists, in both OPAC and Staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 07:09:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 05:09:04 +0000 Subject: [Koha-bugs] [Bug 12645] New: Extend Koha::Template::Plugin::Branches for use in masthead.inc Message-ID: <bug-12645-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12645 Bug ID: 12645 Summary: Extend Koha::Template::Plugin::Branches for use in masthead.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org At the moment, we're creating the OPAC branch pull-down from "BranchesLoop" which is passed from C4::Auth. This seems a bit sub-optimal to me. I figure we should extend the Koha::Template::Plugin::Branches module so that it returns a loop with branch codes and branch names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 08:38:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 06:38:10 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-s5V1O3mdus@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Juhani Sepp?l? <jseppal at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29781|0 |1 is obsolete| | --- Comment #5 from Juhani Sepp?l? <jseppal at student.uef.fi> --- Created attachment 30011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30011&action=edit Bug 11888: Random password suggestion does not work twice This patch adds a simple ajax-call to pull a new suggested password from the same perl script. To test: 1) Search for a patron and select "Change password" from the moremember-view. 2) In the member-password-view, click on "Click to fill with a randomly generated suggestion". 3) Confirm that you get a new suggested password and click the same link again. 4) Note that you do not get another suggested password - nothing is happening. 5) Apply patch. 6) Repeat steps 1-3 and confirm that you can keep clicking for a new suggested password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 08:38:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 06:38:54 +0000 Subject: [Koha-bugs] [Bug 12639] Z39.50 administration page should use "message" dialog for adds and updates In-Reply-To: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12639-70-cHd2aKOGyt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12639 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 08:39:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 06:39:34 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-uMRhKS8qTM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Juhani Sepp?l? <jseppal at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Juhani Sepp?l? <jseppal at student.uef.fi> --- Newest patch corrects the broken page elements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 09:53:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 07:53:31 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: <bug-12631-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12631-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12631-70-1o7FOFwdS4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |matthias.meusburger at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 10:11:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 08:11:35 +0000 Subject: [Koha-bugs] [Bug 12640] UTF8: problem on serials during display of a search result In-Reply-To: <bug-12640-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12640-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12640-70-cjZW8Dr9N3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12640 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- This is fixed by the last patch set submitted by Dobrica. I will update the sandboxes today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 10:27:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 08:27:53 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-wQUj1q7QHS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #235 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30012&action=edit Bug 11944: Convert DB tables to utf8_unicode_ci -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 10:33:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 08:33:48 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-O6ztYek2Kc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #236 from Jonathan Druart <jonathan.druart at biblibre.com> --- The branch kohac/ft/bug_11944 is set to master + all patches from this report. The 2 sandboxes 6 and 16 are up-to-date from this branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 10:43:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 08:43:15 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-sguUyZxNVS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12638 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 10:43:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 08:43:15 +0000 Subject: [Koha-bugs] [Bug 12638] UTF-8 support; C4::Members::AttributeTypes::GetAttributeTypes_hashref should be rewrite In-Reply-To: <bug-12638-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12638-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12638-70-cK3Jdnn6xS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12638 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 | Assignee|jonathan.druart at biblibre.co |gmcharlt at gmail.com |m | --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Jonathan Druart from comment #1) > Should be fixed by bug 11944 comment 208. No, it is not fixed. But it seems to come from the Perl version. The sandboxes are using Perl v5.10, and I use Perl v.5.18. The issue occurs on sandboxes using the master branch. So I consider it is not introduced by bug 11944 and should not be blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 10:43:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 08:43:27 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-7OdqlwqiCP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #237 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #235) > Created attachment 30012 [details] [review] > Bug 11944: Convert DB tables to utf8_unicode_ci You are also doing the same at install time? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 10:44:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 08:44:34 +0000 Subject: [Koha-bugs] [Bug 12278] the amount of each invoice should be displayed in invoices page In-Reply-To: <bug-12278-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12278-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12278-70-v2um3iAoUk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12278 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 10:53:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 08:53:36 +0000 Subject: [Koha-bugs] [Bug 12637] UTF-8 problems when creating a patron list from the patron search results page In-Reply-To: <bug-12637-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12637-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12637-70-sO7awI2eok@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30013&action=edit Bug 12637: UTF-8 problems when creating a patron list Encoding problems appear when creating a patron list from the patron search results page. Test plan: 1. Perform a patron search in the patrons module 2. Select one or more patrons 3. Choose "Add selected patrons to: [ New list ]" 4. Enter a patron list title with UTF-8 characters, ex: "P?tron list five " 5. The list will be created with bad encoding: "P%C3%A0tron%20list%20five%20" 6. Apply the patch and verify there is no bad encoding anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 10:54:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 08:54:16 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-0q0ZxEr39Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12637 See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12637 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 10:54:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 08:54:16 +0000 Subject: [Koha-bugs] [Bug 12637] UTF-8 problems when creating a patron list from the patron search results page In-Reply-To: <bug-12637-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12637-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12637-70-4Ah6qdGHR6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart at biblibre.co | |m See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 | Depends on| |11944 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- This patch works on top of bug 11944. I didn't try against master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 10:54:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 08:54:38 +0000 Subject: [Koha-bugs] [Bug 12646] New: Only "top 20" rows visible in invoices search result Message-ID: <bug-12646-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 Bug ID: 12646 Summary: Only "top 20" rows visible in invoices search result Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: abl at biblos.pk.edu.pl QA Contact: testopia at bugs.koha-community.org Table rows visibility in invoice search results (acqui/invoices.pl) is limited to "top 20" table rows after Bug 12147 has been pushed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 10:55:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 08:55:48 +0000 Subject: [Koha-bugs] [Bug 12147] Column width for action links on invoices too small In-Reply-To: <bug-12147-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12147-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12147-70-DkhHLfWX3R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12646 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 10:55:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 08:55:48 +0000 Subject: [Koha-bugs] [Bug 12646] Only "top 20" rows visible in invoices search result In-Reply-To: <bug-12646-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12646-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12646-70-dqbLllcjVh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12147 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 11:00:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 09:00:49 +0000 Subject: [Koha-bugs] [Bug 12646] Only "top 20" rows visible in invoices search result In-Reply-To: <bug-12646-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12646-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12646-70-nduoVYhwOc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11798 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 11:00:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 09:00:53 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10988-70-cmgfdw6vx4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #16 from Nicholas van Oudtshoorn <vanoudt at gmail.com> --- Created attachment 30014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30014&action=edit New version of the patch - changes how the domain restriction is handled Rather than using the undocumented hl oauth2 parameter, we now manually check to see if an email is in the required domain or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 11:00:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 09:00:49 +0000 Subject: [Koha-bugs] [Bug 11798] Problems with column sorting and row visibility in invoices table In-Reply-To: <bug-11798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11798-70-oPTGwNpPVX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12646 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 11:02:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 09:02:32 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10988-70-rOTHALR1nX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Nicholas van Oudtshoorn <vanoudt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29594|0 |1 is obsolete| | Attachment #30014|0 |1 is obsolete| | --- Comment #17 from Nicholas van Oudtshoorn <vanoudt at gmail.com> --- Created attachment 30015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30015&action=edit Allow Google OAuth2 Login New version of the patch - changes how the domain restriction is handled Rather than using the undocumented hl oauth2 parameter, we now manually check to see if an email is in the required domain or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 11:05:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 09:05:00 +0000 Subject: [Koha-bugs] [Bug 12646] Only "top 20" rows visible in invoices search result In-Reply-To: <bug-12646-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12646-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12646-70-wodU9g0SzL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Are you sure it is caused by bug 12147? The patch removed "bPaginate: false,", so the pagination was already removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 11:10:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 09:10:14 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-nzJULc2EUR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30012|0 |1 is obsolete| | --- Comment #238 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30016&action=edit Bug 11944: Convert DB tables to utf8_unicode_ci -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 11:10:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 09:10:58 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-mSymagb9tM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #239 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to M. de Rooy from comment #237) > (In reply to Jonathan Druart from comment #235) > > Created attachment 30012 [details] [review] [review] > > Bug 11944: Convert DB tables to utf8_unicode_ci > > You are also doing the same at install time? Done in the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 11:14:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 09:14:30 +0000 Subject: [Koha-bugs] [Bug 12647] New: QueryParser fails tests Message-ID: <bug-12647-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12647 Bug ID: 12647 Summary: QueryParser fails tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org QueryParser.t will usually fail using a more current perl. Here are two runs of QueryParser.t using perl 5.18.1 ~/kohaclone$ prove t/QueryParser.t t/QueryParser.t .. 1/? # Failed test 'super simple keyword query' # at t/QueryParser.t line 22. # got: '@attr 1=1003 @attr 4=6 "smith"' # expected: '@or @or @attr 1=1016 @attr 4=6 "smith" @attr 9=20 @attr 2=102 @attr 4=6 "smith" @attr 9=34 @attr 2=102 @attr 4=6 "smith"' # Failed test 'keyword search sorted by acqdate descending' # at t/QueryParser.t line 33. # got: '@or @attr 7=1 @attr 1=32 0 @attr 1=1003 @attr 4=6 "smith"' # expected: '@or @attr 1=32 @attr 7=1 0 @attr 1=1003 @attr 4=6 "smith"' # Looks like you failed 2 tests of 28. t/QueryParser.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/28 subtests Test Summary Report ------------------- t/QueryParser.t (Wstat: 512 Tests: 28 Failed: 2) Failed tests: 6, 17 Non-zero exit status: 2 Files=1, Tests=28, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.17 cusr 0.01 csys = 0.21 CPU) Result: FAIL ~/kohaclone$ prove t/QueryParser.t t/QueryParser.t .. 1/? # Failed test 'super simple keyword query' # at t/QueryParser.t line 22. # got: '@attr 1=4 @attr 4=6 "smith"' # expected: '@or @or @attr 1=1016 @attr 4=6 "smith" @attr 9=20 @attr 2=102 @attr 4=6 "smith" @attr 9=34 @attr 2=102 @attr 4=6 "smith"' # Failed test 'relevance-bumped query' # at t/QueryParser.t line 26. # got: '@attr 1=4 @attr 2=102 @attr 9=20 @attr 4=6 "smith"' # expected: '@attr 1=4 @attr 9=20 @attr 2=102 @attr 4=6 "smith"' # Failed test 'keyword search sorted by acqdate descending' # at t/QueryParser.t line 33. # got: '@or @attr 7=1 @attr 1=32 0 @attr 1=1003 @attr 4=6 "smith"' # expected: '@or @attr 1=32 @attr 7=1 0 @attr 1=1003 @attr 4=6 "smith"' # Looks like you failed 3 tests of 28. t/QueryParser.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/28 subtests Test Summary Report ------------------- t/QueryParser.t (Wstat: 768 Tests: 28 Failed: 3) Failed tests: 6, 10, 17 Non-zero exit status: 3 Files=1, Tests=28, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.18 cusr 0.01 csys = 0.23 CPU) Result: FAIL The nature of the fails suggests that the parser is assuming that elements in a hash are ordered and generating the query from that. While that has never been the case current versions of perl ensure that hash elements are not returned in the same sequence as a predictable one was a security weakness. So if running with a later perl the dequence of elements in the generated query is random -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 12:11:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 10:11:02 +0000 Subject: [Koha-bugs] [Bug 12646] Only "top 20" rows visible in invoices search result In-Reply-To: <bug-12646-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12646-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12646-70-KNADMhxoWP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 --- Comment #2 from Jacek Ablewicz <abl at biblos.pk.edu.pl> --- (In reply to Jonathan Druart from comment #1) > Are you sure it is caused by bug 12147? > The patch removed "bPaginate: false,", so the pagination was already removed. Pretty sure that it was caused by removing "bPaginate: false," (or, at least, that after re-adding it, things seem to be back to normal). I don't really know why it works that way, some DataTables weirdness maybe? My guess is that with all DataTables controls hidden with "sDom: t", pagination in still in efect "under the hood" (but no longer controllable in any way: no way to navigate to next result page or control the amount displayed). Anyway, it got me thinkig about the ergonomics of invoice search in general; maybe reenabling (at least some) datatables controls (instead of turning off "under the hood" pagination like in Bug 11798) would be way better aproach here? I mean, in mid-sized library, there may be hundreds/tousends invoices entered each year; after a relativelly short period of time this page would become less and less usable in it's current form (and also slower - but thats not easy remediable, unless we decide to convert it to ajax/server-side datatable variant ?). Apart from pagination controlls, IMO it would be nice to have a general purpose datatables search box/filter available in this page. Doing some testing right now (with sDom: "t" simply removed): - filtering by "show only subscription" does seem to coexist nicely with general-pupose DT search box (btw, having such a checkbox to show only open invoices would also be a great addition from an ergonomics standpoint) - checkboxes for selecting invoices to be merged are beahving a little weird (invoices to be merged need to be selected on the same result page for the selection to become effecive); no idea how to fix it.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 12:57:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 10:57:52 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-3g6GzLX59k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28898|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30017&action=edit MT8122: Adds Shibboleth authentication - Use the shibbolethAuthentication syspref to enable Shibboleth authentication - Configure the shibbolethLoginAttribute to specify which shibboleth user attribute matches the koha login - Make sure the OPACBaseURL is correctly set MT8122, Follow-up: Adds Shibboleth authentication - Fix logout bug: shibboleth logout now occurs only when the session is a shibboleth one. - Do some refactoring: getting shibboleth username is now done in C4::Auth_with_Shibboleth.pm (get_login_shib function) MT8122, Follow-up: Adds Shibboleth authentication - Adds redirect to opac after logout MT8122, Follow-up: Adds Shibboleth authentication - Shibboleth is not compatible with basic http authentication in C4/Auth.pm. This patch fixes that. MT8122, Follow-up: Adds Shibboleth authentication - Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with multiple vhosts. MT8122, Follow-up: Adds Shibboleth authentication - Adds missing protocol for $ENV{'SERVER_NAME'} Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> http://bugs.koha-community.org/show_bug.cgi?id=8446 Signed-off-by: Jesse Weaver <pianohacker at gmail.com> (ByWater employee.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 12:58:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 10:58:05 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-msmEGaIH3R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28899|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30018&action=edit BUG8446, Follow up: Adds Shibboleth authentication - Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont work if koha is behind a reverse proxy. - To use multiple vhosts, set OpacBaseURL per vhost explicitly with 'SetEnv OpacBaseURL Value' as per Bug 10325 BUG8446, Follow up: Adds Shibboleth authentication - Ensure user is returned to requested page after authentication - Added querystring to the target path in shibboleth URL so that when a user is authenticated he/she is returned to the correct page they requested before authentication. Example where this is important: When a user clicks a direct biblio link of the form - /opac-detail.pl?biblionumber=12345 BUG8446, Follow up: Remove unused imports from scripts - Remove import of deprecated C4::Utils module from shibboleth authentication module: Auth_with_shibboleth.pm Signed-off-by: Jesse Weaver <pianohacker at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 12:58:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 10:58:13 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-z7R37kngv9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28900|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30019&action=edit BUG8446, Follow up: Remove unnecessary sysprefs, move to config Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 12:58:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 10:58:23 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-XxRrIuIZ6w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28901|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30020&action=edit BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implimented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 12:58:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 10:58:29 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-X7nWNqcaWv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28902|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30021&action=edit BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 12:58:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 10:58:35 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-7AbkDuguA4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28903|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30022&action=edit BUG8446, Follow up: Correct paths after file rename -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 12:58:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 10:58:43 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-jg2iYZzXY0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30023&action=edit BUG8446, Follow up: Implimented single sign out - This followup rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implimented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implimentation issue that is well known. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 13:04:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 11:04:19 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-7s3se7MfGa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #58 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- As discussed with Thomas and Katrin I've now tracking this patch set in my public github repository and keeping it rebased appropriately. The latest version of the patch will laways be available at: https://github.com/mrenvoize/Koha/tree/bug_8446 This is basically to make it easier to apply, as not wanting to loose attribution means that squashing the patches to prevent merge conflicts with updatedatabase would be 'bad'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 13:29:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 11:29:20 +0000 Subject: [Koha-bugs] [Bug 12648] New: Link an order with patrons Message-ID: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Bug ID: 12648 Summary: Link an order with patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org A need is to notify 1+ patrons on receiving an order. As baskets, we could link patrons to an order and send them an email when the order is completely received. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 13:29:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 11:29:31 +0000 Subject: [Koha-bugs] [Bug 12648] Link an order with patrons In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12648-70-e3omRlayIY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 13:44:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 11:44:06 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12648-70-zbFAKrPtKj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Link an order with patrons |Link patrons to an order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 13:53:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 11:53:04 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12648-70-NfjJXKhcvh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 13:53:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 11:53:08 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12648-70-z0GRHvArUy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30024&action=edit Bug 12648: Link patrons to an order - DB changes This patch inserts the new notification template into the letters table. It also add the insert statements into the language specific files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 13:53:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 11:53:12 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12648-70-Uq9QoqTzit@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30025&action=edit Bug 12648: Refactoring to prepare user search for reuse A previous enhancement allows to link basket with patrons. Next patches will use the same way to link order with patrons. In order to avoir c/p of code, this patch refactores this part of code. Test plan: 1/ Verify there is no regression on adding/modifying users to a basket. (acqui/basket.pl?basketno=XXX, "Managed by", "Add user"). 2/ Note that you get a friendly message if the user is already present in the list and when the user has correctly been added to the list. 3/ Note that the list uses the member search service (ie. DataTable + serverside processing). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 13:53:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 11:53:18 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12648-70-dTSihlo31Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30026&action=edit Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 13:53:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 11:53:22 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12648-70-SCmpAsz8zO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30027&action=edit Bug 12648: Add unit tests for C4::Acquisition::*OrderUsers Test plan: Verify that unit tests pass with prove t/db_dependent/Acquisition/OrderUsers.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 14:06:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 12:06:47 +0000 Subject: [Koha-bugs] [Bug 11109] import marc21 records in unimarc Koha In-Reply-To: <bug-11109-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11109-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11109-70-ZWXJXj3Wqg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11109 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |DUPLICATE --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 6536 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 14:06:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 12:06:47 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-l0OmUgMTuK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #56 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** Bug 11109 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 14:11:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 12:11:45 +0000 Subject: [Koha-bugs] [Bug 12649] New: Add Croatian language Message-ID: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Bug ID: 12649 Summary: Add Croatian language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 14:12:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 12:12:23 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-pLtUwEaVAy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12017 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 14:12:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 12:12:23 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12017-70-PGs7FQ9ATJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12649 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 14:13:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 12:13:34 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-2dwWblL2Yc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #1 from Dobrica Pavlinusic <dpavlin at rot13.org> --- This patch will conflict with http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 14:26:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 12:26:22 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-MEbB4m51vz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Dobrica Pavlinusic from comment #1) > This patch will conflict with > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Don't worry, nobody has tested it. But also, it does not change database values. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 14:29:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 12:29:39 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-BYDTwHYGPS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #3 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 30028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30028&action=edit Bug 12649 - Add Croatian language -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 14:30:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 12:30:14 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-a9oH2eAaSQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dpavlin at rot13.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 14:36:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 12:36:06 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-Y3a7DMw1Yt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #59 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Finally got this working with Martin's help! Woohooo! Some first remarks: - The link to log in with Shibboleth seems to only appear on the start page, but not for example on the result list. - It would be nice if Shib login also directed you to the patron account, like the normal login does. But maybe it's safer to always redirect to the place the user started from - in case someone logged in to place a hold or similar. Tested ok: >From start page: - OK Shib login with correct username/password - OK Shib logout with correct username/password - OK Koha login - OK Koha logout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 14:58:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 12:58:25 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-WHLY8tzatO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Dobrica Pavlinusic from comment #3) > Created attachment 30028 [details] [review] > Bug 12649 - Add Croatian language It's ready for signing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 15:09:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 13:09:41 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-MPxVPK53UK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30028|0 |1 is obsolete| | --- Comment #5 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 30029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30029&action=edit Bug 12649 - Add Croatian language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 15:10:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 13:10:37 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-QLX3YPXRLS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 15:10:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 13:10:47 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-K7lXqRPNXE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #6 from Dobrica Pavlinusic <dpavlin at rot13.org> --- It is now :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 15:14:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 13:14:29 +0000 Subject: [Koha-bugs] [Bug 12650] New: UTF-8: ACQ, problems after saved a new budget Message-ID: <bug-12650-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12650 Bug ID: 12650 Summary: UTF-8: ACQ, problems after saved a new budget Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org There are problems in budgets about UTF-8. Open ACQ and click on 'Budgets' link on the left. You arrive in Home ? Administration ? Budgets administration, then clik on 'New budget'. In the name of budget I insert the string '????'. I complete data and I save. I return to Home ? Administration ? Budgets administration ( ../cgi-bin/koha/admin/aqbudgetperiods.pl) and now I see '????' instead of '????'. But only after the return. If I go to ACQ home and after I return into Home ? Administration ? Budgets administration, the greeck chars are correct. The problem is present when you came back. I find it on sandbox n.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 15:14:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 13:14:57 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-sNDb9fWKby@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12650 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 15:14:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 13:14:57 +0000 Subject: [Koha-bugs] [Bug 12650] UTF-8: ACQ, problems after saved a new budget In-Reply-To: <bug-12650-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12650-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12650-70-m8QCZ2hwgK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12650 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 15:15:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 13:15:40 +0000 Subject: [Koha-bugs] [Bug 12650] UTF-8: ACQ, problems after saved a new budget In-Reply-To: <bug-12650-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12650-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12650-70-I1IAvq71Ep@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12650 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 15:30:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 13:30:30 +0000 Subject: [Koha-bugs] [Bug 12650] UTF-8: ACQ, problems after saved a new budget In-Reply-To: <bug-12650-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12650-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12650-70-BECCqv20IV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12650 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=11944 |id=12638 Assignee|jonathan.druart at biblibre.co |gmcharlt at gmail.com |m | --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Same as bug 12638 comment 2. I don't reproduce using perl 5.18 and the issue occurs on master using perl 5.10. Does not depend on bug 11944. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 15:30:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 13:30:30 +0000 Subject: [Koha-bugs] [Bug 12638] UTF-8 support; C4::Members::AttributeTypes::GetAttributeTypes_hashref should be rewrite In-Reply-To: <bug-12638-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12638-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12638-70-g6FsduAOEp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12638 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12650 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 15:30:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 13:30:30 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-ULaPj676lh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12650 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 15:38:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 13:38:58 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-uBtf008brm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Dobrica Pavlinusic from comment #6) > It is now :-) Two things: 1) Line 8551 on updatedatbase.pl, a missing ')' SetVersion($DBversion; -> SetVersion($DBversion); file does not run :( 2) There are no changes for these languages it-IT nb-NO uk-UA Save for that, patch works. Don't forget a commit message with test plan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 15:46:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 13:46:54 +0000 Subject: [Koha-bugs] [Bug 12650] UTF-8: ACQ, problems after saved a new budget In-Reply-To: <bug-12650-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12650-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12650-70-Mf1xZQzvz5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12650 --- Comment #2 from Zeno Tajoli <z.tajoli at cineca.it> --- (In reply to Jonathan Druart from comment #1) > Same as bug 12638 comment 2. > > I don't reproduce using perl 5.18 and the issue occurs on master using perl > 5.10. > > Does not depend on bug 11944. I confirm, this bug is aslo present on master without bug 11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 16:16:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 14:16:21 +0000 Subject: [Koha-bugs] [Bug 12638] UTF-8 support; C4::Members::AttributeTypes::GetAttributeTypes_hashref should be rewrite In-Reply-To: <bug-12638-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12638-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12638-70-AofjeTIjpd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12638 --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Given the following script: test.pl #!/usr/bin/perl use Modern::Perl; use Data::Dumper; my $h = {id=>'???', description=>'???'}; warn Dumper $h; 1/ With perl v.5.10 a) perl test.pl $VAR1 = { 'description' => '???', 'id' => '???' }; b) cgi-bin/koha/test.pl displays in the Koha logs: $VAR1 = { 'id' => '\xce\xbb\xce\xbb\xce\xbb', 'description' => '\xce\xbb\xce\xbb\xce\xbb' }; 2/ With perl v.5.18 a) perl test.pl $VAR1 = { 'description' => '???', 'id' => '???' }; b) cgi-bin/koha/test.pl displays in the Koha logs: $VAR1 = { 'description' => '???', 'id' => '???' }; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 16:17:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 14:17:08 +0000 Subject: [Koha-bugs] [Bug 12638] UTF-8 support; C4::Members::AttributeTypes::GetAttributeTypes_hashref should be rewrite In-Reply-To: <bug-12638-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12638-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12638-70-QOrEeS40z3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12638 --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Jonathan Druart from comment #3) I didn't test on the same machine, so it could be something else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 16:18:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 14:18:57 +0000 Subject: [Koha-bugs] [Bug 12651] New: DOM indexing should be the default Message-ID: <bug-12651-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12651 Bug ID: 12651 Summary: DOM indexing should be the default Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org As of bug 12641, DOM has to be the default for every Koha piece. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 16:19:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 14:19:03 +0000 Subject: [Koha-bugs] [Bug 12651] DOM indexing should be the default In-Reply-To: <bug-12651-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12651-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12651-70-2EFymuefuc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12651 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 16:20:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 14:20:07 +0000 Subject: [Koha-bugs] [Bug 12651] DOM indexing should be the default In-Reply-To: <bug-12651-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12651-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12651-70-jt8LSRWTJg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12651 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12641 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 16:20:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 14:20:07 +0000 Subject: [Koha-bugs] [Bug 12641] Formally deprecate the GRS-1 indexing mode In-Reply-To: <bug-12641-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12641-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12641-70-lAyFTp3dfh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12641 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12651 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 16:33:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 14:33:30 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-ly4YB8TMO2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #60 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30030&action=edit BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 16:33:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 14:33:37 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-wxWTqJSo3n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #61 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30031&action=edit BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template ruels so that CAS and Shibboleth can coexist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 16:34:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 14:34:09 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-3he4gUGO1J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Two QA followups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 16:45:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 14:45:30 +0000 Subject: [Koha-bugs] [Bug 12639] Z39.50 administration page should use "message" dialog for adds and updates In-Reply-To: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12639-70-6UjdMqb6kO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12639 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 16:49:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 14:49:48 +0000 Subject: [Koha-bugs] [Bug 12639] Z39.50 administration page should use "message" dialog for adds and updates In-Reply-To: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12639-70-aVLcn455Sd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12639 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 16:49:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 14:49:51 +0000 Subject: [Koha-bugs] [Bug 12639] Z39.50 administration page should use "message" dialog for adds and updates In-Reply-To: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12639-70-s5VVsvYtgG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12639 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30032&action=edit Bug 12639 - Z39.50 administration page should use "message" dialog for adds and updates This patch changes the style of a couple of message boxes to use the "message" style instead of the "alert" style. This better reflects the type and priority of the messages being displayed. To test, got to Administration -> Z39.50 client targets and edit an existing server. The confirmation message should be the blue "message" type. Test again by adding a new server. The confirmation message for this operation should be of the same blue "message" type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 16:57:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 14:57:52 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-TVNIUWrUab@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30033&action=edit BUG8446, Follow up: Added default config to config file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:03:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:03:06 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-NJSChgxtaT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #8 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Thanks for spotting upatedatabase.pl corruption, I missed other languages which doesn't have mandatory subdir, sigh. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:11:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:11:29 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-xtlHf7P3QG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30029|0 |1 is obsolete| | --- Comment #9 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 30034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30034&action=edit Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:20:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:20:27 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8148-70-2xyYUt7NSn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30035&action=edit [PASSED QA] Prevent local authentification fallback if an invalid LDAP password was entered. http://bugs.koha-community.org/show_bug.cgi?id=8148 Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:20:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:20:43 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8148-70-tmClf4dkQu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30036&action=edit [PASSED QA] Only update the password if the LDAP password field was mapped. http://bugs.koha-community.org/show_bug.cgi?id=8148 Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:20:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:20:49 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8148-70-PUAnVvbB2C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30037&action=edit [PASSED QA] Bug 8148 - LDAP auth_by_bind doesn't fallback to local auth This patch covers LDAP auth_by_bind configuration so that wrong LDAP password will return -1 to C4::Auth so we can abort local auth and prevent users logging in with stale database passwords. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:21:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:21:12 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8148-70-cfgPvQNy8V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29977|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:21:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:21:23 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8148-70-vWwjW3964S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29978|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:21:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:21:33 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8148-70-YVLVlWpjfl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29979|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:22:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:22:06 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8148-70-3H1eIfza0Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Happy to pass this now.. thanks for the followup dobrica. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:31:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:31:04 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-9juYE9hURW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30034|0 |1 is obsolete| | --- Comment #10 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 30038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30038&action=edit Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:31:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:31:36 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-oUqEgulFtv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #11 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Last change fixes typo in updatedatabase.pl. I think it's ready now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:32:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:32:52 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-C5qCO8BeWk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30038|0 |1 is obsolete| | --- Comment #12 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 30039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30039&action=edit Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:40:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:40:37 +0000 Subject: [Koha-bugs] [Bug 12652] New: Acquisitions bug Message-ID: <bug-12652-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12652 Bug ID: 12652 Summary: Acquisitions bug Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jesse at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We have two budget years (FY14 and FY15). FY14 is inactive, FY15 is active. Both budgets have the same fund names (i.e. FIC, NONFIC). If I create a basket and add an item from an existing record choosing a particular fund, it charges the item against the FY15 fund. If I create a basket and add an item from a staged file choosing a particular fund, it charges the item against the FY14 fund. This is a bug. Maybe it is matching on the fund name instead of the fund number? We are working around this bug by renaming the FY14 funds making the fund names different. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:46:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:46:51 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: <bug-12194-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12194-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12194-70-BsOd9aKfmn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 17:48:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 15:48:17 +0000 Subject: [Koha-bugs] [Bug 12653] New: PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in tests Message-ID: <bug-12653-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12653 Bug ID: 12653 Summary: PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: oleonard at myacpl.org QA Contact: gmcharlt at gmail.com The following tests contain references to opac-tmpl/prog: xt/single_quotes.t xt/author/valid-templates.t xt/author/icondirectories.t xt/author/translatable-templates.t xt/tt_valid.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 18:01:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 16:01:51 +0000 Subject: [Koha-bugs] [Bug 12654] New: Incorrect quoting in regexp in AuthoritiesMarc Message-ID: <bug-12654-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12654 Bug ID: 12654 Summary: Incorrect quoting in regexp in AuthoritiesMarc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org An incorrect quote of a metacharacter in a regexp in AuthoritiesMarc.pm causes a compile time warning : Useless use of '\'; doesn't escape metacharacter '(' at /home/cc/kohaclone/C4/AuthoritiesMarc.pm line 856. annoyingly this crops up every time the module is compiled (e.g. in runs of rebuildzebra Let's quote correctly and silence the message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 18:18:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 16:18:19 +0000 Subject: [Koha-bugs] [Bug 12655] New: PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in XSLT Message-ID: <bug-12655-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12655 Bug ID: 12655 Summary: PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in XSLT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Several OPAC XSL files in the bootstrap template contain hard-coded paths to the prog theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 18:21:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 16:21:06 +0000 Subject: [Koha-bugs] [Bug 12654] Incorrect quoting in regexp in AuthoritiesMarc In-Reply-To: <bug-12654-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12654-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12654-70-OmVUhQcrzc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12654 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 30040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30040&action=edit Proposed patch use \Q |E to get perl to quote neta characters To test perl -wc AuthoritiesMarc.pm should no longer complain with the error message in the bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 18:33:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 16:33:13 +0000 Subject: [Koha-bugs] [Bug 12655] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in XSLT In-Reply-To: <bug-12655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12655-70-F28yfjfPtH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12655 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 18:50:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 16:50:19 +0000 Subject: [Koha-bugs] [Bug 12655] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in XSLT In-Reply-To: <bug-12655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12655-70-OZf299UtO2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12655 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 18:50:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 16:50:23 +0000 Subject: [Koha-bugs] [Bug 12655] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in XSLT In-Reply-To: <bug-12655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12655-70-dXI58Ybcdr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12655 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30041&action=edit Bug 12655 - PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in XSLT Two XSL files in the bootstrap theme contain hard-coded paths to the prog theme directory. This patch adds a query of the opacthemes system preference and builds the path based on the returned value. To test in a MARC21 system: Create or locate a record which contains a subject which is linked to an authority record. View the detail page for that record in the bootstrap OPAC and confirm that there is a magnifying class icon next to the link for that subject heading. Inspect or right-click the image and "View image" [FF. "Open image in new tab" in Chrome] to verify that the image being shown is from the bootstrap theme directory. Also modified: The NORMARC XSL for the detail page which has been changed in the same way. I did not test it in a NORMARC catalog. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 18:53:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 16:53:30 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-jCiOeYkwvP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #61 from Nick Clemens <nick at quecheelibrary.org> --- Hi Kyle, I tried to test on a sandbox (3.17.00.009) and am getting Error 500 for any checkins I was going to test on my VM (3.17.00.010) but patch needs rebased for current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 19:14:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 17:14:49 +0000 Subject: [Koha-bugs] [Bug 12429] patron seeing fines codes In-Reply-To: <bug-12429-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12429-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12429-70-yALgxrjyyD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 --- Comment #11 from Nicole C. Engard <nengard at gmail.com> --- Are there any plans for this to be in 3.16.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 20:01:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 18:01:23 +0000 Subject: [Koha-bugs] [Bug 12656] New: add a notice that tells patrons when their hold was cancelled because it wasn't picked up in time Message-ID: <bug-12656-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Bug ID: 12656 Summary: add a notice that tells patrons when their hold was cancelled because it wasn't picked up in time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be nice to add a notice that tells patrons when their hold was cancelled because it wasn't picked up in time - not a notice for call cancels, just the one that was done due to a late pickup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 20:30:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 18:30:00 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-fxUNxujMzt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30039|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30042&action=edit [SIGNED-OFF] Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Works, no koha-qa errors. Also tested translating to de-DE and on advanced search opac/staff is listed translated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 20:30:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 18:30:40 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-PZYYGmKSxm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 20:45:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 18:45:08 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-w0AYeL56vl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #138 from Nick Clemens <nick at quecheelibrary.org> --- This needs rebased on master I tested on sandbox and got Error 500 when trying to sign in to patron's account I tested in VM and all seems good after clearing the merge conflict in updatedatabase.pl but I don't know the procedure to submit rebased patches so I will retest and sign off ASAP when rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 20:45:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 18:45:41 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-vnOtWEg7ME@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #55 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 30043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30043&action=edit Bug 12164: (followup) MoveOrders description corrected Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 20:45:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 18:45:46 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-kRI3hI4u8B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #56 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 30044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30044&action=edit Bug 12164: (followup) keys expects a hash parameter As of http://perldoc.perl.org/functions/keys.html we should avoid passing a scalar parameter as it is not backwards compatible with squeezze's Perl version (5.10). Cite: "Starting with Perl 5.14, keys can take a scalar EXPR, which must contain a reference to an unblessed hash or array. The argument will be dereferenced automatically. This aspect of keys is considered highly experimental. The exact behaviour may change in a future version of Perl." Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 20:47:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 18:47:20 +0000 Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received In-Reply-To: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12164-70-zKtHU79Go9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #57 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Jonathan and everyone involved in testing this new feature. Note for the QA people: read the last patch's comment, because we should filter patches including experimental features. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 20:57:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 18:57:56 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-rDbl5e1Mog@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29954|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30045&action=edit [SIGNED-OFF] Bug 12445: Improving unit tests for C4::Suggestions.pm Now, the tests used 'is' instead of 'ok', the tests are wrapped in a transaction, adding tests for the routines NewSuggestion, GetSuggestion, ModSuggestion, GetSuggestionFromBiblionumber and GetInfoFromBiblionumber. The tests for the routines DelSuggestionsOlderThan, CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion and GetSuggestionByStatus will be arrived in another patch. Test plan: 1/ Execute the command : prove t/db_dependent/Suggestions.t 2/ The result has to be a success without warning or error : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=32, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.49 cusr 0.08 csys = 1.61 CPU) Result: PASS Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 20:58:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 18:58:06 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-zHyW7L33MA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29955|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30046&action=edit [SIGNED-OFF] Bug 12445: ading unit tests to test the routines : CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion, GetSuggestionByStatus These routines were not tested Test plan: 1/ Execute the command : prove t/db_dependent/Suggestions.t 2/ The result has to be a success without error or warning : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=89, 1 wallclock secs ( 0.05 usr 0.01 sys + 1.52 cusr 0.08 csys = 1.66 CPU) Result: PASS Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Test pass, no koha-qa errors But now there are 91! prove t/db_dependent/Suggestions.t t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.00 sys + 1.77 cusr 0.10 csys = 1.92 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 21:25:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 19:25:04 +0000 Subject: [Koha-bugs] [Bug 12657] New: PROG/CCSR deprecation: Remove hard-coded theme from debian/* scripts Message-ID: <bug-12657-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12657 Bug ID: 12657 Summary: PROG/CCSR deprecation: Remove hard-coded theme from debian/* scripts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz There are two scripts in debian/ which reference the deprecated opac-tmpl/prog and opac-tmpl/ccsr directories: debian/scripts/koha-translate debian/rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 21:38:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 19:38:09 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-zZTiFHIuz4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 21:51:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 19:51:48 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-lTYsPGNRZe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 21:51:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 19:51:55 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-gaUqgWKpru@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30042|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30047&action=edit [PASSED QA] Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Works, no koha-qa errors. Also tested translating to de-DE and on advanced search opac/staff is listed translated. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Note: This also makes the language show up in the language pull down in advanced search. Because the entry is the last in the file, it will show last in the list. I am noting this here, the list is not really consistently sorted right now and there is work under way to change the way we handle this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 21:58:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 19:58:05 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-uUjIJcCrix@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am sorry, tests fail on my database: t/db_dependent/Suggestions.t .. 1/91 DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/Suggestions.t line 39. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/Suggestions.t line 39. # Looks like you planned 91 tests but ran 2. # Looks like your test exited with 255 just after 2. Can you add some clean up prior to running the tests and switch back to signed off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 22:08:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 20:08:01 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-40xdmgsRbn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am sorry, but the new message is not showing up for me, I have double checked: Patch is applied, looking at bootstrap, looking at English templates... I don't see where this is going wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 22:20:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 20:20:07 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-LJe6kGZPYg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 22:20:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 20:20:10 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-dCqKU8m9tr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28910|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30048&action=edit [PASSED QA] Bug 12398: Fix CAS authentication validation CGI::url_param() also returns deleted parameters so we have to check with CGI::param() too. Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Took a while to get it working, but I can confirm CAS login is not working without this patch, but does with it. Some notes: In order for this to work you have to add http:// in front of your OpacBaseURL. You will also need a CAS test server and install the certificate on your system. Tested with CAS test server provided by Biblibre. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 22:44:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 20:44:30 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-Ovy6qnLqHH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Asked Bernardo to give it a try too - he can't see the new message either. Please take a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 23:06:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 21:06:13 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-oPlxpa1Ent@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Problem seems to be related with '|' to concat/split itemnumbers, Changing that to '_' or ':' works perl -e ' use Data::Dumper; $a="10_20"; @b = split ("_", $a) ; print Dumper \@b;' $VAR1 = [ '10', '20' ]; perl -e ' use Data::Dumper; $a="10"; @b = split ("_", $a) ; print Dumper \@b;' $VAR1 = [ '10' ]; perl -e ' use Data::Dumper; $a="10|20"; @b = split ("|", $a) ; print Dumper \@b;' $VAR1 = [ '1', '0', '|', '2', '0' ]; -------------------> BAD ! perl -e ' use Data::Dumper; $a="10:20"; @b = split (":", $a) ; print Dumper \@b;' $VAR1 = [ '10', '20' ]; Now, when fixed the button/message is a bit large and ugly, that's another problem :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 23:15:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 21:15:59 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-Hnl2NczBoc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 23:16:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 21:16:02 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-UB7ahxANMN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29940|0 |1 is obsolete| | Attachment #29941|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30049&action=edit [PASSED QA] Bug 12596 - Unit Test Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 23:16:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 21:16:31 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-xZvGCS4vCr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30050&action=edit [PASSED QA] Bug 12596 - Backdating returns with SpecifiyReturnDate causes fines for items not overdue! When using the backdating of returns feature, an item that is not overdue is treated as being as many days overdue as it is *not* overdue. This is due to the fact that _get_chargeable_units appears to return the difference between the return date and the due date without consideration the return date being earlier than the due date. Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/Circulation.t 3) Note the failure 4) Apply the second patch 5) prove t/db_dependent/Circulation.t 6) Note there are no failures Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Fixes some badly named variables also Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> In order to test this, you need to activate SpecifyReturnDate. I confirmed the problem and verified that the bug fixes it by running the tests, but also by testing in staff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 23:31:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 21:31:16 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-CfMm2br7oi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 24 23:52:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 21:52:21 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-BoqKvyDywV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 00:05:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 22:05:50 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-P8JqPomskW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #54 from M. Tompsett <mtompset at hotmail.com> --- With the moved to DBIx, the Schema file needs to be created as well. Hence, the change back to ASSIGNED. Sorry. Wasn't me that changed the underlying technologies in mid-stream. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 00:16:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 22:16:47 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC. In-Reply-To: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4045-70-GuoeJvaIVN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 00:16:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 22:16:52 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC. In-Reply-To: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4045-70-pNIUPIk2XL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28492|0 |1 is obsolete| | --- Comment #69 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30051&action=edit Bug 4045 - No check for maximum number of allowed holds. Re-add the system preference maxreserves. All the code using maxreserves is still in place. Though it is not used in the Reserves module, it is used in all the scripts where holds are placed. Also adds a check so that a borrower cannot exceed the maximum number of allowed holds by using the multi-hold feature via the opac. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Set maxreserves to 3, set opactheme to bootstrap 4) Log into the opac as a patron 5) Place 3 holds 6) Attempt to place a 4th hold 7) Note you get an error message and cannot place a forth hold 8) Delete two of those holds 9) Attempt to place 3 or more holds as a multi-hold 10) You should see a warning that you cannot place this many holds 11) Try to anyway 12) You should see an alert to tell you to reduce the number of holds you are placing. 13) Reduce the number for holds you are placing to 2 14) Your holds should now be placed Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 01:48:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 23:48:23 +0000 Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click In-Reply-To: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9667-70-DcHcnk1ASi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Ian Beardslee <ibeardslee at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ibeardslee at gmail.com --- Comment #6 from Ian Beardslee <ibeardslee at gmail.com> --- Created attachment 30052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30052&action=edit Signed patch All good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 01:48:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 23:48:52 +0000 Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click In-Reply-To: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9667-70-12GoyK60MH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Ian Beardslee <ibeardslee at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 01:50:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 23:50:58 +0000 Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click In-Reply-To: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9667-70-hPV772OA8V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Ian Beardslee <ibeardslee at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29676|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 01:52:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jul 2014 23:52:40 +0000 Subject: [Koha-bugs] [Bug 12658] New: Select all options on installer screen Message-ID: <bug-12658-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12658 Bug ID: 12658 Summary: Select all options on installer screen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: seanh at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When installing Koha, there is a screen that asks you which options you want to install. Currently there is a sea of tick boxes, that you need to ninja click in order to tick them all, this can be rather time consuming and prone to error (it is easy to miss one for instance). Proposed resolution =================== * A new hyperlink at the top of the installer that adds a "Select all" option for users with Javascript enabled. * Each label for the checkbox will also get a corresponding <label for""> HTML tag around it, allowing the user to click on the label instead of the tiny checkbox. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 02:43:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 00:43:39 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-JW6sUawv3L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 02:43:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 00:43:42 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-NF21DaUqdw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29746|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30053&action=edit Bug 12583: DelItem prototype - Remove $dbh Since C4::Context->dbh shares the DB handler, it's useless to pass it to routines. Test plan: Try to remove an item from the Koha interface. Verify that unit tests pass. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 02:43:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 00:43:55 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-oho7PBKigi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29747|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30054&action=edit Bug 12583: DelItem prototype - prefer hashref To delete an item, only the itemnumber should be mandatory. The DelItem routine can retrieve the biblionumber from the itemnumber. Test plan: Verify that t/db_dependent/Items/DelItem.t passes Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 02:44:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 00:44:07 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-HzO1UmYBBQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29748|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30055&action=edit Bug 12583: DelItem prototype - Add unit tests DelItem should return 1 if the item has been deleted, otherwise 0. Test plan: Verify that t/db_dependent/Items/DelItem.t returns green Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 03:25:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 01:25:32 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-DphC30vYtE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #146 from David Cook <dcook at prosentient.com.au> --- Created attachment 30056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30056&action=edit Bug 7143: Add Prosentient Systems to contributing companies Better late than never to add the company name to the list of contributing companies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 03:26:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 01:26:15 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-L6MfWwQ7iM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #147 from David Cook <dcook at prosentient.com.au> --- Not sure if I did that right but couldn't change the status...so I'll just leave it as Pushed to Master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:09:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:09:19 +0000 Subject: [Koha-bugs] [Bug 12658] Select all options on installer screen In-Reply-To: <bug-12658-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12658-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12658-70-aVJle4bL4w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12658 Sean Hamlin <seanh at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |seanh at catalyst.net.nz Assignee|koha-bugs at lists.koha-commun |seanh at catalyst.net.nz |ity.org | --- Comment #1 from Sean Hamlin <seanh at catalyst.net.nz> --- Created attachment 30058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30058&action=edit proposed patch Patch attached that implements this. Test steps in patch notes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:09:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:09:17 +0000 Subject: [Koha-bugs] [Bug 12560] Wrong capitalization on acquisition statistics page In-Reply-To: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12560-70-x9RyAz3gaF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12560 Gizmo <natalieb at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |natalieb at catalyst.net.nz --- Comment #1 from Gizmo <natalieb at catalyst.net.nz> --- Created attachment 30057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30057&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:10:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:10:06 +0000 Subject: [Koha-bugs] [Bug 12560] Wrong capitalization on acquisition statistics page In-Reply-To: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12560-70-YEaTiOLXQw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12560 Gizmo <natalieb at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:14:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:14:45 +0000 Subject: [Koha-bugs] [Bug 12659] New: Receive is spelt wrong on subscription history page Message-ID: <bug-12659-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12659 Bug ID: 12659 Summary: Receive is spelt wrong on subscription history page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: natalieb at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Receive is spelt wrong on subscription history page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:20:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:20:11 +0000 Subject: [Koha-bugs] [Bug 12562] Capitalization: 'Save Report' when saving a new SQL report In-Reply-To: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12562-70-zOsIBNQmWB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12562 briann at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |briann at catalyst.net.nz --- Comment #1 from briann at catalyst.net.nz --- Created attachment 30059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30059&action=edit Patch to fix capitalisation on button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:20:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:20:24 +0000 Subject: [Koha-bugs] [Bug 12562] Capitalization: 'Save Report' when saving a new SQL report In-Reply-To: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12562-70-gI9FOkQ2PA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12562 briann at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:22:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:22:40 +0000 Subject: [Koha-bugs] [Bug 12634] JavaScript error in Bootstrap OPAC detail page if OPACPopupAuthorsSearch is enabled In-Reply-To: <bug-12634-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12634-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12634-70-Yvtc9rjSAo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12634 Robert Higgins <robert.higgins at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |robert.higgins at catalyst.net | |.nz --- Comment #1 from Robert Higgins <robert.higgins at catalyst.net.nz> --- Can't replicate (but I'm quite new to Koha). Please add some more detailed replication steps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:27:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:27:27 +0000 Subject: [Koha-bugs] [Bug 12563] Capitalization: 'Set Status' on detail pages item's tab In-Reply-To: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12563-70-swrw9Yz7NN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12563 Evonne <evonne at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |evonne at catalyst.net.nz --- Comment #1 from Evonne <evonne at catalyst.net.nz> --- Created attachment 30060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30060&action=edit patch for bug12563 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:29:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:29:52 +0000 Subject: [Koha-bugs] [Bug 12563] Capitalization: 'Set Status' on detail pages item's tab In-Reply-To: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12563-70-YmC0Qoi8lb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12563 Evonne <evonne at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:37:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:37:04 +0000 Subject: [Koha-bugs] [Bug 12564] Capitalization: Buttons in inventory tool In-Reply-To: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12564-70-rys7LTfnwg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12564 Karl Menzies <karlm at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karlm at catalyst.net.nz --- Comment #1 from Karl Menzies <karlm at catalyst.net.nz> --- Created attachment 30061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30061&action=edit Fixed Capitalisation of Inventory Tools Buttons Capitalisation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:37:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:37:55 +0000 Subject: [Koha-bugs] [Bug 12564] Capitalization: Buttons in inventory tool In-Reply-To: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12564-70-HsixOzMnNy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12564 Karl Menzies <karlm at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Karl Menzies <karlm at catalyst.net.nz> --- To Test to confirm changes are fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:39:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:39:05 +0000 Subject: [Koha-bugs] [Bug 12659] Receive is spelt wrong on subscription history page In-Reply-To: <bug-12659-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12659-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12659-70-PxMN8Tql9E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12659 --- Comment #1 from Gizmo <natalieb at catalyst.net.nz> --- Created attachment 30062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30062&action=edit Fixing mispelling of receive -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:39:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:39:16 +0000 Subject: [Koha-bugs] [Bug 12659] Receive is spelt wrong on subscription history page In-Reply-To: <bug-12659-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12659-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12659-70-xNLiFRVGU5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12659 Gizmo <natalieb at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:40:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:40:19 +0000 Subject: [Koha-bugs] [Bug 12589] Manage label batch view should show item type description instead of code In-Reply-To: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12589-70-VhKDwJUV9i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12589 Robert Higgins <robert.higgins at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29772|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|oleonard at myacpl.org |robert.higgins at catalyst.net | |.nz --- Comment #2 from Robert Higgins <robert.higgins at catalyst.net.nz> --- Created attachment 30063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30063&action=edit Signed off patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:48:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:48:43 +0000 Subject: [Koha-bugs] [Bug 8521] Error in warning message when deleting list In-Reply-To: <bug-8521-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8521-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8521-70-SFdK7mJ5O6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 Ian Beardslee <ibeardslee at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29751|0 |1 is obsolete| | Status|Needs Signoff |Signed Off CC| |ibeardslee at gmail.com Assignee|gmcharlt at gmail.com |ibeardslee at gmail.com --- Comment #2 from Ian Beardslee <ibeardslee at gmail.com> --- Created attachment 30064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30064&action=edit Signed off patch Tested Public and Private lists with 0, 5 & 25 entries, Public with 40 and Private with 45. Working as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:53:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:53:01 +0000 Subject: [Koha-bugs] [Bug 12660] New: Mispelling of Accomodation in two tools templates - in comments Message-ID: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12660 Bug ID: 12660 Summary: Mispelling of Accomodation in two tools templates - in comments Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: briann at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org In koha-tmpl/intranet-tmpl/prog/en/modules/tools there are two templates with the spelling of accomodate wrong in the comments of batchMod-del.tt and batchMod-edit.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 04:55:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 02:55:56 +0000 Subject: [Koha-bugs] [Bug 12576] search links need style id In-Reply-To: <bug-12576-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12576-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12576-70-6yPo3ILocF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Sean Hamlin <seanh at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |seanh at catalyst.net.nz Assignee|oleonard at myacpl.org |seanh at catalyst.net.nz --- Comment #1 from Sean Hamlin <seanh at catalyst.net.nz> --- Created attachment 30065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30065&action=edit proposed patch I have added bootstrap classes to the links, and made them 'btn-default' which means they will appear grey (and less prominent than "Search". I have re-compiled the LESS, and have that in the patch too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 05:01:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 03:01:30 +0000 Subject: [Koha-bugs] [Bug 12657] PROG/CCSR deprecation: Remove hard-coded theme from debian/* scripts In-Reply-To: <bug-12657-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12657-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12657-70-7J4YUwliIe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12657 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 05:03:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 03:03:17 +0000 Subject: [Koha-bugs] [Bug 12660] Mispelling of Accomodation in two tools templates - in comments In-Reply-To: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12660-70-stJ3xD2Kzg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12660 --- Comment #1 from briann at catalyst.net.nz --- Created attachment 30066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30066&action=edit Correct spelling of accomodate in template comments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 05:03:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 03:03:24 +0000 Subject: [Koha-bugs] [Bug 12660] Mispelling of Accomodation in two tools templates - in comments In-Reply-To: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12660-70-melSOCYJHr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12660 briann at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 05:03:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 03:03:41 +0000 Subject: [Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan" In-Reply-To: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12635-70-DjO3v2WwH9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 Robert Higgins <robert.higgins at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |robert.higgins at catalyst.net | |.nz --- Comment #1 from Robert Higgins <robert.higgins at catalyst.net.nz> --- Can't replicate. Please add replication steps. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 05:12:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 03:12:02 +0000 Subject: [Koha-bugs] [Bug 12661] New: Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt Message-ID: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 Bug ID: 12661 Summary: Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: natalieb at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 05:23:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 03:23:15 +0000 Subject: [Koha-bugs] [Bug 12622] Exporting report as Open Document Spreadsheet results in Perl error when report has no results In-Reply-To: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12622-70-NVJnvN71nq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Robert Higgins <robert.higgins at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29952|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|jonathan.druart at biblibre.co |robert.higgins at catalyst.net |m |.nz --- Comment #2 from Robert Higgins <robert.higgins at catalyst.net.nz> --- Created attachment 30067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30067&action=edit Signed off patch Other exported report types seem to work with queries that produce no results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 05:30:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 03:30:49 +0000 Subject: [Koha-bugs] [Bug 12661] Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt In-Reply-To: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12661-70-g3N9rlzlZq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 --- Comment #1 from Gizmo <natalieb at catalyst.net.nz> --- Created attachment 30068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30068&action=edit Fixing capitalisation on "Item Type" error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 05:31:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 03:31:04 +0000 Subject: [Koha-bugs] [Bug 12661] Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt In-Reply-To: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12661-70-o9IOoLRbe7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 Gizmo <natalieb at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 05:32:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 03:32:14 +0000 Subject: [Koha-bugs] [Bug 10220] IDs on checkin columns In-Reply-To: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10220-70-0U0D0k5dRj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10220 Evonne <evonne at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |evonne at catalyst.net.nz --- Comment #1 from Evonne <evonne at catalyst.net.nz> --- Created attachment 30069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30069&action=edit patch for bug 10220 Added ID to check in table, and classes for each column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 05:32:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 03:32:31 +0000 Subject: [Koha-bugs] [Bug 10220] IDs on checkin columns In-Reply-To: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10220-70-ZefFAGzdpG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10220 Evonne <evonne at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 05:37:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 03:37:39 +0000 Subject: [Koha-bugs] [Bug 12642] SMS.t requires a database In-Reply-To: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12642-70-DCfgwd4mlO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 --- Comment #2 from Robin Sheat <robin at catalyst.net.nz> --- This needs to happen for both master and 3.16. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 05:40:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 03:40:30 +0000 Subject: [Koha-bugs] [Bug 12642] SMS.t requires a database In-Reply-To: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12642-70-vq2G3pJZLA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12657 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 05:40:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 03:40:30 +0000 Subject: [Koha-bugs] [Bug 12657] PROG/CCSR deprecation: Remove hard-coded theme from debian/* scripts In-Reply-To: <bug-12657-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12657-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12657-70-DrHeZcnVd2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12657 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 06:02:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 04:02:23 +0000 Subject: [Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery In-Reply-To: <bug-12443-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12443-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12443-70-VbRMN3pV6N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #15 from Robin Sheat <robin at catalyst.net.nz> --- The test case fails to build on Debian testing with: String found where operator expected at t/Search.t line 28, near "subtest "_build_initial_query tests"" (Do you need to predeclare subtest?) syntax error at t/Search.t line 28, near "subtest "_build_initial_query tests"" syntax error at t/Search.t line 158, near "}" Execution of t/Search.t aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 06:04:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 04:04:13 +0000 Subject: [Koha-bugs] [Bug 12581] /svc/bib endpoint has encoding issues when updating a record In-Reply-To: <bug-12581-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12581-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12581-70-mSaRnWnOAz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 06:08:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 04:08:33 +0000 Subject: [Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC In-Reply-To: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12554-70-T40ywMLke5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 06:12:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 04:12:08 +0000 Subject: [Koha-bugs] [Bug 12657] PROG/CCSR deprecation: Remove hard-coded theme from debian/* scripts In-Reply-To: <bug-12657-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12657-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12657-70-5yx4FwQMT0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12657 --- Comment #1 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 30070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30070&action=edit Bug 12657 - remove references to prog and ccsr from the packages To test: * Build a package and install it, and verify that there are no errors. * Play around with koha-translate, adding and removing languages. Note: one reference to prog and ccsr remains in koha-translate. This is to allow it to remove any pre-existing translations on an upgrade. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 06:12:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 04:12:58 +0000 Subject: [Koha-bugs] [Bug 12657] PROG/CCSR deprecation: Remove hard-coded theme from debian/* scripts In-Reply-To: <bug-12657-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12657-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12657-70-Ok21tTSC02@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12657 --- Comment #2 from Robin Sheat <robin at catalyst.net.nz> --- I haven't given this extensive testing yet, just verified that it's possible to build a package from it. I'll look at it a bit closer next week unless someone beats me to it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 06:14:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 04:14:29 +0000 Subject: [Koha-bugs] [Bug 2889] templates should use [% IF ( loop.odd ) %] In-Reply-To: <bug-2889-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2889-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2889-70-xWvtusjL3Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2889 Karl Menzies <karlm at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karlm at catalyst.net.nz --- Comment #10 from Karl Menzies <karlm at catalyst.net.nz> --- Created attachment 30071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30071&action=edit Patch updates template acqui/aqbasketsearch.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 06:29:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 04:29:06 +0000 Subject: [Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery In-Reply-To: <bug-12443-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12443-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12443-70-XqWiq6GPVh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443 --- Comment #16 from David Cook <dcook at prosentient.com.au> --- (In reply to Robin Sheat from comment #15) > The test case fails to build on Debian testing with: > > String found where operator expected at t/Search.t line 28, near "subtest > "_build_initial_query tests"" > (Do you need to predeclare subtest?) > syntax error at t/Search.t line 28, near "subtest "_build_initial_query > tests"" > syntax error at t/Search.t line 158, near "}" > Execution of t/Search.t aborted due to compilation errors. Sounds like Debian testing uses an older version of Test::More than Tomas, me thinks. Same issue below, I imagine: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9142 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 07:21:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 05:21:00 +0000 Subject: [Koha-bugs] [Bug 12639] Z39.50 administration page should use "message" dialog for adds and updates In-Reply-To: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12639-70-hEiOthiUQD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12639 Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30032|0 |1 is obsolete| | --- Comment #2 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> --- Created attachment 30072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30072&action=edit Bug 12639 - Z39.50 administration page should use "message" dialog for adds and updates This patch changes the style of a couple of message boxes to use the "message" style instead of the "alert" style. This better reflects the type and priority of the messages being displayed. To test, got to Administration -> Z39.50 client targets and edit an existing server. The confirmation message should be the blue "message" type. Test again by adding a new server. The confirmation message for this operation should be of the same blue "message" type. Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 07:20:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 05:20:57 +0000 Subject: [Koha-bugs] [Bug 12639] Z39.50 administration page should use "message" dialog for adds and updates In-Reply-To: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12639-70-ile6mDcf6o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12639 Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 08:32:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 06:32:22 +0000 Subject: [Koha-bugs] [Bug 12639] Z39.50 administration page should use "message" dialog for adds and updates In-Reply-To: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12639-70-qRsu4wKDYk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12639 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 08:32:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 06:32:24 +0000 Subject: [Koha-bugs] [Bug 12639] Z39.50 administration page should use "message" dialog for adds and updates In-Reply-To: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12639-70-MPI2z25SdM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12639 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30072|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30073&action=edit [PASSED QA] Bug 12639 - Z39.50 administration page should use "message" dialog for adds and updates This patch changes the style of a couple of message boxes to use the "message" style instead of the "alert" style. This better reflects the type and priority of the messages being displayed. To test, got to Administration -> Z39.50 client targets and edit an existing server. The confirmation message should be the blue "message" type. Test again by adding a new server. The confirmation message for this operation should be of the same blue "message" type. Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros at gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Small template change, tested ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 08:37:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 06:37:01 +0000 Subject: [Koha-bugs] [Bug 12622] Exporting report as Open Document Spreadsheet results in Perl error when report has no results In-Reply-To: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12622-70-rW0j0uvnE2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 08:37:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 06:37:04 +0000 Subject: [Koha-bugs] [Bug 12622] Exporting report as Open Document Spreadsheet results in Perl error when report has no results In-Reply-To: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12622-70-jgaHSlIkwy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30067|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30074&action=edit [PASSED QA] Bug 12622: Fix export report as ods Bug 11679 introduces an ods export for reports. It looks quite buggy: 1/ You get a Perl error if the report has no results 2/ The ods file contains 1 lines less than the total results. Test plan: After applying this patch, try to export a report which has no results and verify you get an ods file with headers only. Try to export a report which has a least 1 result and verify the generated ods has the right number of lines. Signed-off-by: Robert Higgins <robert.higgins at catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Fixes the reported problem, passes all tests and QA script. Added the sign-off line for Robert. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 08:38:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 06:38:19 +0000 Subject: [Koha-bugs] [Bug 12622] Exporting report as Open Document Spreadsheet results in Perl error when report has no results In-Reply-To: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12622-70-knCOYWLfLx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|robert.higgins at catalyst.net |jonathan.druart at biblibre.co |.nz |m --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Resetting Assigned to to Jonathan - as he is the patch writer. Thx for testing Robert! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 08:38:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 06:38:58 +0000 Subject: [Koha-bugs] [Bug 8521] Error in warning message when deleting list In-Reply-To: <bug-8521-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8521-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8521-70-syRhAotzRT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|ibeardslee at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 08:41:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 06:41:15 +0000 Subject: [Koha-bugs] [Bug 8521] Error in warning message when deleting list In-Reply-To: <bug-8521-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8521-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8521-70-PfSglIhiVR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 30064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30064 Signed off patch Review of attachment 30064: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8521&attachment=30064) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt @@ +234,5 @@ > [% IF ( paramsloo.noshelfnumber ) %]<div class="dialog alert">ERROR: No list number given.</div>[% END %] > [% IF ( paramsloo.need_confirm ) %] > <div class="dialog alert">The list <i>[% paramsloo.need_confirm %]</i> is not empty. > + [% IF ( paramsloo.single ) %] > + <br />It has <b>[% paramsloo.count %]</b> entry. The <b> will split up this sentence on translation - is it really necessary here? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 08:45:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 06:45:36 +0000 Subject: [Koha-bugs] [Bug 10220] IDs on checkin columns In-Reply-To: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10220-70-YBbkhQfS0f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10220 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|oleonard at myacpl.org |evonne at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 08:48:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 06:48:27 +0000 Subject: [Koha-bugs] [Bug 10220] IDs on checkin columns In-Reply-To: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10220-70-oISHRhVJvo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10220 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 08:48:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 06:48:30 +0000 Subject: [Koha-bugs] [Bug 10220] IDs on checkin columns In-Reply-To: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10220-70-RVVnhW9PwE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10220 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30069|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30075&action=edit [SIGNED OFF] Bug 10220 IDs on checkin columns Test: go to Circulation > Check in, table has ID and each column has a class. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Adds a class to every th and td element in the check-in table. Works as describe, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 08:49:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 06:49:01 +0000 Subject: [Koha-bugs] [Bug 10220] IDs on checkin columns In-Reply-To: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10220-70-BpfmcLb2qK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10220 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thanks for your patch Evonne! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 09:27:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 07:27:53 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-gy811jHvMs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 09:28:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 07:28:01 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-2LghrRVWNE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 10:55:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 08:55:15 +0000 Subject: [Koha-bugs] [Bug 12662] New: Ajax-based check in does not work for some system preference settings enabled Message-ID: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Bug ID: 12662 Summary: Ajax-based check in does not work for some system preference settings enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: abl at biblos.pk.edu.pl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To reproduce: - enable "InProcessingToShelvingCart" or "ReturnToShelvingCart" system preference, - for a sample patron with 1+ checkouts, try to check in some item[s] using checkboxes in the "Check in" column in the checkouts table which is displayed in the "Check out" or "Details" patron account tabs, - observe that clicking "Renew or return checked items" button only results in ajax "spinning wheel" stuck in infinite loop; check-in operation is not performed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 11:03:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 09:03:05 +0000 Subject: [Koha-bugs] [Bug 12642] SMS.t requires a database In-Reply-To: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12642-70-kbXEdqWVeS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30010|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30076&action=edit Bug 12642: t/SMS.t should not be db dependent SMS.t should not dependent on the DB. Test plan: verify that prove t/SMS.t returns green even if the DB is not there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 11:03:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 09:03:31 +0000 Subject: [Koha-bugs] [Bug 12642] SMS.t requires a database In-Reply-To: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12642-70-vEBDW24eyF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Hi Robin, I proposed a counter patch, could you please have a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 11:06:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 09:06:19 +0000 Subject: [Koha-bugs] [Bug 12662] Ajax-based check in does not work for some system preference settings enabled In-Reply-To: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12662-70-ELnrlGsIxY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Jacek Ablewicz <ablewicz at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 11:06:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 09:06:21 +0000 Subject: [Koha-bugs] [Bug 12662] Ajax-based check in does not work for some system preference settings enabled In-Reply-To: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12662-70-DBTOmVz0GM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 --- Comment #1 from Jacek Ablewicz <ablewicz at gmail.com> --- Created attachment 30077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30077&action=edit Bug 12662 - Ajax-based check in does not work for some system preference settings enabled To reproduce: - enable "InProcessingToShelvingCart" or "ReturnToShelvingCart" system preference, - for a sample patron with 1+ checkouts, try to check in some item[s] using checkboxes in the "Check in" column in the checkouts table which is displayed in the "Check out" or "Details" patron account tabs, - observe that clicking "Renew or return checked items" button only results in ajax "spinning wheel" stuck in infinite loop; check-in operation is not performed. To test: - follow the steps above to reproduce this bug - apply patch - redo the test; ensure that this issue is no longer reproductible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 11:08:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 09:08:13 +0000 Subject: [Koha-bugs] [Bug 12662] Ajax-based check in does not work for some system preference settings enabled In-Reply-To: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12662-70-tH6seaSCcq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |abl at biblos.pk.edu.pl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 11:11:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 09:11:49 +0000 Subject: [Koha-bugs] [Bug 12662] Ajax-based check in does not work for some system preference settings enabled In-Reply-To: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12662-70-JCFmMFH3ap@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11703 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 11:11:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 09:11:49 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: <bug-11703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11703-70-R8GhUcCvxl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12662 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 11:51:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 09:51:53 +0000 Subject: [Koha-bugs] [Bug 12501] Show Dissertation note (MARC21 502) in XSLT results In-Reply-To: <bug-12501-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12501-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12501-70-dA11cb7GMq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12501 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 12:34:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 10:34:05 +0000 Subject: [Koha-bugs] [Bug 12501] Show Dissertation note (MARC21 502) in XSLT results In-Reply-To: <bug-12501-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12501-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12501-70-vP5vussGOq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12501 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 12:34:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 10:34:08 +0000 Subject: [Koha-bugs] [Bug 12501] Show Dissertation note (MARC21 502) in XSLT results In-Reply-To: <bug-12501-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12501-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12501-70-QoiVj3qZSS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12501 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30078&action=edit Bug 12501: Show dissertation note (MARC21 502) in XSLT results Bug 9356 added the dissertation note from MARC21 502 to the staff and OPAC detail pages. This patch adds it to the result list. 1) Catalog a record with 502 Examples: http://www.loc.gov/marc/bibliographic/bd502.html 2) Verify your note shows up on the detail pages in staff and OPAC 3) Verfiy note also shows up on the result pages in staff and OPAC The dissertation note can be hidden using the following CSS: OpacUserCSS: display:none; } IntranetUserCSS: display:none; } 4) Verify CSS works and all looks like before... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 12:43:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 10:43:55 +0000 Subject: [Koha-bugs] [Bug 12662] Ajax-based check in does not work for some system preference settings enabled In-Reply-To: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12662-70-owW7rYAEAr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 12:43:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 10:43:57 +0000 Subject: [Koha-bugs] [Bug 12662] Ajax-based check in does not work for some system preference settings enabled In-Reply-To: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12662-70-1ZLDskFtJO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30077|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30079&action=edit Bug 12662 - Ajax-based check in does not work for some system preference settings enabled To reproduce: - enable "InProcessingToShelvingCart" or "ReturnToShelvingCart" system preference, - for a sample patron with 1+ checkouts, try to check in some item[s] using checkboxes in the "Check in" column in the checkouts table which is displayed in the "Check out" or "Details" patron account tabs, - observe that clicking "Renew or return checked items" button only results in ajax "spinning wheel" stuck in infinite loop; check-in operation is not performed. To test: - follow the steps above to reproduce this bug - apply patch - redo the test; ensure that this issue is no longer reproductible. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 12:44:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 10:44:01 +0000 Subject: [Koha-bugs] [Bug 12662] Ajax-based check in does not work for some system preference settings enabled In-Reply-To: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12662-70-WRDraGyewx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30080&action=edit Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled ModItem is needed too. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 12:44:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 10:44:51 +0000 Subject: [Koha-bugs] [Bug 12662] Ajax-based check in does not work for some system preference settings enabled In-Reply-To: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12662-70-idcCPnnNU7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Before your patch, I got [Fri Jul 25 12:41:22 2014] checkin: Undefined subroutine &main::GetItem called at /home/koha/src/svc/checkin line 58. And after: [Fri Jul 25 12:42:09 2014] checkin: Undefined subroutine &main::ModItem called at /home/koha/src/svc/checkin line 68. :) But after yours and mine, only warnings... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 12:59:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 10:59:21 +0000 Subject: [Koha-bugs] [Bug 12589] Manage label batch view should show item type description instead of code In-Reply-To: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12589-70-AJEfiHZqJA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12589 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 12:59:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 10:59:24 +0000 Subject: [Koha-bugs] [Bug 12589] Manage label batch view should show item type description instead of code In-Reply-To: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12589-70-LlLzMAsHsF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12589 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30063|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30081&action=edit Bug 12589 - Manage label batch view should show item type description instead of code When viewing the list of items in an existing label batch the item type code is shown. This patch modifies the template to show the item type description instead. To test, go to Tools -> Labels -> Manage batches. If necessary, create a batch with multiple items of different item types. Edit the batch and confirm that the table of items shows item type description instead of code. Signed-off-by: Robert Higgins <robert.higgins at catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 13:04:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 11:04:00 +0000 Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click In-Reply-To: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9667-70-Ngypz3Tqo8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30052|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30082&action=edit Bug 9667 - Inventory scrolling to top with every click An "onclick" attribute on inventory results links causes the page to scroll to the top each time. This patch updates the click handling to use a progressive-enhancement method. Unrelated changes: I added use of the Branches T:T plugin to output library name instead of branchcode, and put a check around call number to prevent output of empty [] in results. To test, use the inventory tool to check a batch of items. On the results page: - Confirm that branch name is shown instead of code. - Confirm that no [] shows for items without call numbers - Confirm that clicking a title opens a pop-up window showing details for that title. - Confirm that clicking a title opens a pop-up window whether you're on the first page of results or any subsequent page. Signed-off-by: Ian Beardslee <ian at catalyst.net.nz> Tested in Firefox and Chromium. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 13:03:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 11:03:57 +0000 Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click In-Reply-To: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9667-70-UgdPWsgip7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 13:09:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 11:09:57 +0000 Subject: [Koha-bugs] [Bug 10220] IDs on checkin columns In-Reply-To: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10220-70-iTTW0oGOqz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10220 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 13:10:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 11:10:00 +0000 Subject: [Koha-bugs] [Bug 10220] IDs on checkin columns In-Reply-To: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10220-70-xFP1u3UHfX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10220 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30075|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30083&action=edit Bug 10220 IDs on checkin columns Test: go to Circulation > Check in, table has ID and each column has a class. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Adds a class to every th and td element in the check-in table. Works as describe, no regressions found. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Amended patch: Replace some tab with spaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 13:33:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 11:33:08 +0000 Subject: [Koha-bugs] [Bug 12535] PROG/CCSR Deprecation: Make opac translation theme independent In-Reply-To: <bug-12535-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12535-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12535-70-KuT7aL0wak@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29534|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30084&action=edit Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent This patch makes opac translation files theme independent A side effect is that current prog translation file is renamed. But the renaming is not added, that gives a patch of ~60M! Current list of languages are now obtained from pref files. To test: 1) Apply the patch 2) For your preferred language, rename opac prog file from 'xx-YY-i-opac-t-prog-v-3006000.po' to 'xx-YY-opac-prog.po' 3) Update that language, there must be no errors cd misc/translation ./translate update xx-YY [-v] Check updated po files 4) Install any language, there must be no errors ./translate install xx-YY Check prog theme for that language 5) Create translation files. Remove a language or create new lang files ./translate create zz-WW ls -l po/zz-WW*po check there are 3 files (and *~) for opac 6) Check updated pod for LangInstaler.pm and translate script When PROG/CCSR themes are removed, I'll add a Bug to remove corresponding files. Perhaps RM could add a followup to rename all files, cd misc/translator/po for old in $(ls *opac-t*); do new=$(echo $old | sed 's/-i-opac-t-prog-v-3006000/-opac-prog/'); git mv $old $new; done Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 13:52:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 11:52:18 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-nQixAVllsF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> --- Ok, it works well now, but it generates a lot of warnings Use of uninitialized value $indexes[1] in hash element at installer/data/mysql/updatedatabase.pl line 8605. Use of uninitialized value $indexes[2] in hash element at installer/data/mysql/updatedatabase.pl line 8605. ... line 8605 for me is... ( undef, $enumeration_data{ $indexes[0] }, # <= ... here $enumeration_data{ $indexes[1] }, $enumeration_data{ $indexes[2] } ) = split( /__SPLIT__/, $serialseq ); Could you fix that, please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 13:53:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 11:53:55 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-L0U04pyjFu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30085&action=edit Bug 12568 [QA Followup] - Use ':' as separator instead of '|' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 13:57:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 11:57:20 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-iAByrOt9UI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #9) > Problem seems to be related with '|' to concat/split itemnumbers, > Changing that to '_' or ':' works Thanks for finding that out! Followup attached! > > Now, when fixed the button/message is a bit large and ugly, that's another > problem :) Well, the idea *is* to make the renewal very prominent ; ) This is also the standard bootstrap style alert which we have been preferring in the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:00:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:00:55 +0000 Subject: [Koha-bugs] [Bug 12663] New: SCOUserCSS and SCOUserJS ignored on selfcheck login page. Message-ID: <bug-12663-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Bug ID: 12663 Summary: SCOUserCSS and SCOUserJS ignored on selfcheck login page. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org The two preferences: SCOUserCSS and SCOUserJS --- Do not apply to the selfcheck login page. To reproduce: * Make changes using above prefs * GOTO selfcheck module: http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl If you have not logged in, your changes will not be visible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:01:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:01:55 +0000 Subject: [Koha-bugs] [Bug 12060] Indentation issues allow markup errors in header.inc In-Reply-To: <bug-12060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12060-70-6ShIOsqIRl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12060 Fridolin SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers at biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:06:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:06:18 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-KGb0KXK9dv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Kyle M Hall from comment #11) > Well, the idea *is* to make the renewal very prominent ; ) This is also the > standard bootstrap style alert which we have been preferring in the > bootstrap theme. Yes, and it looks better on a screen as wide as that of your video :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:07:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:07:54 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-6rM92laM8s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> --- > 1/ There is a lack of unit tests here. I'll add some. > 2/ I don't understand the interest of the stringify param, it's just a 1 > line join. That's cruft from previous versions of the feature. I'll find and remove those. > 3/ QA Followup 2 could be squashed with the main patch for the readability. Will do! > 4/ Clone is a new dependency. But that could be avoid. I think something like > my $clone = { %$hash_ref }; > does the same think. I'll take a look at that. > 5/ How to be sure your changes are exhaustive? Everywhere > IndependentBranches is used, that's it? Yep! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:11:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:11:54 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: <bug-11226-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11226-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11226-70-S7hlpz05nh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 --- Comment #10 from Fridolin SOMERS <fridolyn.somers at biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:34:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:34:39 +0000 Subject: [Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery In-Reply-To: <bug-12443-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12443-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12443-70-5FvIbeOhMc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443 --- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to David Cook from comment #16) > (In reply to Robin Sheat from comment #15) > > The test case fails to build on Debian testing with: > > > > String found where operator expected at t/Search.t line 28, near "subtest > > "_build_initial_query tests"" > > (Do you need to predeclare subtest?) > > syntax error at t/Search.t line 28, near "subtest "_build_initial_query > > tests"" > > syntax error at t/Search.t line 158, near "}" > > Execution of t/Search.t aborted due to compilation errors. > > Sounds like Debian testing uses an older version of Test::More than Tomas, > me thinks. > > Same issue below, I imagine: > > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9142 I don't think it is the same problem, as we have subtests in: db_dependent/Koha.t db_dependent/Biblio.t db_dependent/Items.t db_dependent/Search.t Search.t and they are not failing in Debian 6, Debian 7, Ubuntu 12.04 and Ubuntu 14.04. Can anyone try those on Debian testing please? Also, we definitely would benefit of a Debian testing node. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:47:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:47:29 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12603-70-RrhP3dLEwJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:47:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:47:32 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12603-70-6woMQTweum@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29845|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30086&action=edit [SIGNED-OFF] Bug 12603: creating TestBuilder to simplify tests This patch contains a new module t::lib::TestBuilder which allows to write tests easier and it contains the unit tests of this module. For more information, see the documentation of the module. This module uses the DBIx::Class schema and works with a clean DBIx::Class schema. In order to use it, you have to remove the current circular dependence (existing in the DBIx::Class) by applying the last patch of the bug 11518. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:47:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:47:44 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12603-70-EcaaIEFdSM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30087&action=edit [SIGNED-OFF] Bug 12603 [QA Followup] * Fix syntax error * Remove Schema files for nonexistant tables * Fix circular dependency * Makes unpushed followup for bug 11518 unnessary Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:51:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:51:10 +0000 Subject: [Koha-bugs] [Bug 12604] TestBuilder - Refactoring Category.t In-Reply-To: <bug-12604-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12604-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12604-70-Dy35C7XP7z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12604 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:51:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:51:13 +0000 Subject: [Koha-bugs] [Bug 12604] TestBuilder - Refactoring Category.t In-Reply-To: <bug-12604-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12604-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12604-70-uaDn0HG73t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12604 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29850|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30088&action=edit [SIGNED-OFF] Bug 12604: refactoring Category.t with TestBuilder The tests have been refactored with the module TestBuilder. Test plan: 1/ Apply the patch 12603 2/ The command : prove t/db_dependent/Category.t has to be a success without error or warning : t/db_dependent/Category.t .. ok All tests successful. Files=1, Tests=3, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.05 cusr 0.05 csys = 1.14 CPU) Result: PASS Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:55:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:55:05 +0000 Subject: [Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t In-Reply-To: <bug-12605-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12605-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12605-70-asPIkpQ4Qb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:55:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:55:11 +0000 Subject: [Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t In-Reply-To: <bug-12605-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12605-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12605-70-gptsKihVpH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29851|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30089&action=edit [SIGNED-OFF] Bug 12604: refactoring close_reopen_basket.t with TestBuilder The tests have been refactored with the module TestBuilder. Test plan: 1/ Apply the patch 12603 and the last patch of bug 11518. 2/ The command : prove t/db_dependent/Acquisition/close_reopen_basket.t has to be a success without error or warning : t/db_dependent/Acquisition/close_reopen_basket.t .. ok All tests successful. Files=1, Tests=7, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.71 cusr 0.09 csys = 1.84 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=12605 Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:56:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:56:37 +0000 Subject: [Koha-bugs] [Bug 12606] TestBuilder - Refactoring Acquisition/GetOrdersByBiblionumber.t In-Reply-To: <bug-12606-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12606-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12606-70-04nnjymHS0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12606 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:56:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:56:39 +0000 Subject: [Koha-bugs] [Bug 12606] TestBuilder - Refactoring Acquisition/GetOrdersByBiblionumber.t In-Reply-To: <bug-12606-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12606-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12606-70-7C355q598F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12606 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29853|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30090&action=edit [SIGNED-OFF] Bug 12606: refactoring GetOrdersByBiblionumber.t with TestBuilder The tests have been refactored with the module TestBuilder. Test plan: 1/ Apply the patch 12603 and the last patch of bug 11518. 2/ The command : prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t has to be a success without error or warning : t/db_dependent/Acquisition/GetOrdersByBiblionumber.t .. ok All tests successful. Files=1, Tests=4, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.90 cusr 0.09 csys = 2.03 CPU) Result: PASS Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:58:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:58:39 +0000 Subject: [Koha-bugs] [Bug 12607] TestBuilder - Refactoring Acquisition/GetBasketsInfosByBookseller.t In-Reply-To: <bug-12607-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12607-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12607-70-sabGFCGqEJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12607 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 14:58:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 12:58:41 +0000 Subject: [Koha-bugs] [Bug 12607] TestBuilder - Refactoring Acquisition/GetBasketsInfosByBookseller.t In-Reply-To: <bug-12607-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12607-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12607-70-ombXtTLqRN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12607 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29854|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30091&action=edit [SIGNED-OFF] Bug 12607: refactoring GetBasketsInfosByBookseller.t with TestBuilder The tests have been refactored with the module TestBuilder. Test plan: 1/ Apply the patch 12603 and the last patch of bug 11518. 2/ The command : prove t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t has to be a success without error or warning : t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. ok All tests successful. Files=1, Tests=18, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.71 cusr 0.09 csys = 1.84 CPU) Result: PASS Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:02:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:02:17 +0000 Subject: [Koha-bugs] [Bug 12623] SQLHelper replacement - Koha::Borrower::Modifications In-Reply-To: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12623-70-UTa8sQpjCS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12623 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29980|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30092&action=edit [SIGNED-OFF] Bug 12623: SQLHelper replacement - Borrower::Modifications With this patch, the subroutines AddModification and ApproveModifications uses DBIx::Class instead of C4::SQLHelper. Moreover, the tests has been wrapped in a transaction. Test plan: 1) Apply the patch 2) Execute the unit tests by launching : prove t/db_dependent/Koha_borrower_modifications.t 3) The result has to be a success without error or warning : t/db_dependent/Koha_borrower_modifications.t .. ok All tests successful. Files=1, Tests=14, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.60 cusr 0.08 csys = 1.72 CPU) Result: PASS Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:02:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:02:12 +0000 Subject: [Koha-bugs] [Bug 12623] SQLHelper replacement - Koha::Borrower::Modifications In-Reply-To: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12623-70-wWRW7pJ041@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12623 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:04:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:04:45 +0000 Subject: [Koha-bugs] [Bug 12626] SQLHelper replacement - C4::Acquisition In-Reply-To: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12626-70-0rWmjqqJsn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12626 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:04:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:04:47 +0000 Subject: [Koha-bugs] [Bug 12626] SQLHelper replacement - C4::Acquisition In-Reply-To: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12626-70-5bX9hWAyKH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12626 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29953|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30093&action=edit [SIGNED-OFF] Bug 12626: SQLHelper replacement - C4::Acquisition With this patch, the subroutine NewOrder uses DBIx::Class instead of C4::SQLHelper. Test plan: 1) Apply the patch 2) Execute the unit tests by launching : prove t/db_dependent/Acquisition.t 3) The result has to be a success without error or warning : t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=79, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.80 cusr 0.09 csys = 1.94 CPU) Result: PASS Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:13:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:13:05 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-I4rAHoc9ry@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:13:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:13:09 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-UDAIPjuzcC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30094&action=edit Bug 12445 [QA Followup] - Clear issues table before clearing borrrowers table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:14:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:14:19 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12627-70-7FCRS9JLpV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:14:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:14:21 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12627-70-llU4q5lmYb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29963|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30095&action=edit [SIGNED-OFF] Bug 12627: SQLHelper replacement - C4::Suggestions With this patch, the subroutines NewSuggestion and ModSuggestion uses DBIx::Class instead of C4::SQLHelper. Moreover, the tests has been adapted to the values returned by DBIx::Class. Test plan: 1) Apply the patch 12445 in order to get the last unit tests for Suggestions 2) Apply the patch 3) Execute the unit tests by launching : prove t/db_dependent/Suggestions.t 4) The result has to be a success without error or warning : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.01 sys + 1.65 cusr 0.09 csys = 1.80 CPU) Result: PASS Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:23:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:23:06 +0000 Subject: [Koha-bugs] [Bug 12626] SQLHelper replacement - C4::Acquisition In-Reply-To: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12626-70-SyVCmKrySo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12626 --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- I got: DBIx::Class::Row::new(): No such column 'origquantityrec' on Koha::Schema::Result::Aqorder at /home/koha/src/C4/Acquisition.pm line 1278 On creating an order via the acquisition module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:23:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:23:20 +0000 Subject: [Koha-bugs] [Bug 12626] SQLHelper replacement - C4::Acquisition In-Reply-To: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12626-70-jv2FxIrgFW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12626 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:29:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:29:42 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-srEhW4jwEk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:29:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:29:46 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-QeGjfArfls@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30045|0 |1 is obsolete| | Attachment #30046|0 |1 is obsolete| | Attachment #30094|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30096&action=edit Bug 12445: Improving unit tests for C4::Suggestions.pm Now, the tests used 'is' instead of 'ok', the tests are wrapped in a transaction, adding tests for the routines NewSuggestion, GetSuggestion, ModSuggestion, GetSuggestionFromBiblionumber and GetInfoFromBiblionumber. The tests for the routines DelSuggestionsOlderThan, CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion and GetSuggestionByStatus will be arrived in another patch. Test plan: 1/ Execute the command : prove t/db_dependent/Suggestions.t 2/ The result has to be a success without warning or error : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=32, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.49 cusr 0.08 csys = 1.61 CPU) Result: PASS Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:29:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:29:50 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-Ys3GOkv9Ac@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 --- Comment #17 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30097&action=edit Bug 12445: ading unit tests to test the routines : CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion, GetSuggestionByStatus These routines were not tested Test plan: 1/ Execute the command : prove t/db_dependent/Suggestions.t 2/ The result has to be a success without error or warning : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=89, 1 wallclock secs ( 0.05 usr 0.01 sys + 1.52 cusr 0.08 csys = 1.66 CPU) Result: PASS Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Test pass, no koha-qa errors But now there are 91! prove t/db_dependent/Suggestions.t t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.00 sys + 1.77 cusr 0.10 csys = 1.92 CPU) Result: PASS Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:29:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:29:55 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-pb4JEnwH6B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 --- Comment #18 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30098&action=edit Bug 12445 [QA Followup] - Clear issues table before clearing borrrowers table Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:30:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:30:26 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-ZDKe5Xcscr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #19 from Jonathan Druart <jonathan.druart at biblibre.com> --- This one is ready to QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:31:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:31:51 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-jMwQO07izk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:31:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:31:54 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-9Hl2AsF2q8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28843|0 |1 is obsolete| | Attachment #28844|0 |1 is obsolete| | Attachment #28845|0 |1 is obsolete| | Attachment #28846|0 |1 is obsolete| | Attachment #29929|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30099&action=edit Bug 12375 [1] - Update database Signed-off-by: Paul Landers <paul.landers at ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:32:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:32:08 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-XCzqlXopMo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30100&action=edit Bug 12375 [2] - Update Serial schema file Signed-off-by: Paul Landers <paul.landers at ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:32:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:32:10 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-D6xr451Ivx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30101&action=edit Bug 12375 [3] - Store serials enumeration data in separate fields Signed-off-by: Paul Landers <paul.landers at ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:32:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:32:13 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-vnDjIaX1AN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30102&action=edit Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue Currently, all serials enumeration data is stored in conglomerated fashion in serial.serialseq. This makes it extremely difficult to do any reporting based on the individual sequence values due to this fact. In addition to the formatted version of the sequence, we should be storing the individual values as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a new subscription, and add serials to it. The new x y and z fields should be populated with the same data the replaces {X} {Y} and {Z} in the enumeration field. 4) Inspect some existing serials. The update script will have made a best effort to recover the existing enumeration data to store in separate fields. Signed-off-by: Paul Landers <paul.landers at ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:32:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:32:16 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-DxGjHCJpFz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30103&action=edit Bug 12375 [5] [QA Followup] - Don't assume X Y and Z are used in order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:32:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:32:18 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-8YPAm2b9CS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30104&action=edit Bug 12375 [6] [QA Followup] - Supress warnings for undefined indexes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:33:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:33:48 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-OrmZjq7KNE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> --- This new followup should suppress those warnings. Please give it a try! (In reply to Julian Maurice from comment #20) > Ok, it works well now, but it generates a lot of warnings > > Use of uninitialized value $indexes[1] in hash element at > installer/data/mysql/updatedatabase.pl line 8605. > Use of uninitialized value $indexes[2] in hash element at > installer/data/mysql/updatedatabase.pl line 8605. > ... > > line 8605 for me is... > > ( > undef, > $enumeration_data{ $indexes[0] }, # <= ... here > $enumeration_data{ $indexes[1] }, > $enumeration_data{ $indexes[2] } > ) = split( /__SPLIT__/, $serialseq ); > > Could you fix that, please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:39:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:39:05 +0000 Subject: [Koha-bugs] [Bug 7817] Items Permanent location (shelving location) is set to NULL when item is edited In-Reply-To: <bug-7817-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7817-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7817-70-fKlHpaSsCh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7817 --- Comment #18 from Jonathan Druart <jonathan.druart at biblibre.com> --- You can obsolete my patch if nobody wants it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:42:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:42:36 +0000 Subject: [Koha-bugs] [Bug 12662] Ajax-based check in does not work for some system preference settings enabled In-Reply-To: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12662-70-PrSq27j4ij@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30079|0 |1 is obsolete| | Attachment #30080|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30105&action=edit [PASSED QA] Bug 12662 - Ajax-based check in does not work for some system preference settings enabled To reproduce: - enable "InProcessingToShelvingCart" or "ReturnToShelvingCart" system preference, - for a sample patron with 1+ checkouts, try to check in some item[s] using checkboxes in the "Check in" column in the checkouts table which is displayed in the "Check out" or "Details" patron account tabs, - observe that clicking "Renew or return checked items" button only results in ajax "spinning wheel" stuck in infinite loop; check-in operation is not performed. To test: - follow the steps above to reproduce this bug - apply patch - redo the test; ensure that this issue is no longer reproductible. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:42:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:42:46 +0000 Subject: [Koha-bugs] [Bug 12662] Ajax-based check in does not work for some system preference settings enabled In-Reply-To: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12662-70-rHwZqxvgRE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30106&action=edit [PASSED QA] Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled ModItem is needed too. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:43:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:43:40 +0000 Subject: [Koha-bugs] [Bug 12662] Ajax-based check in does not work for some system preference settings enabled In-Reply-To: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12662-70-eOvYDAsbZu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:49:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:49:20 +0000 Subject: [Koha-bugs] [Bug 9221] contact note not showing In-Reply-To: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9221-70-gMykfqDX9M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9221 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:49:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:49:22 +0000 Subject: [Koha-bugs] [Bug 9221] contact note not showing In-Reply-To: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9221-70-v4PADU5pkl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9221 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29770|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30107&action=edit Bug 9221 - contact note not showing The contents of the contact note field are not displayed on the patron detail page in the staff client. This patch corrects this. This patch also corrects the case of the "Contact note" label in the OPAC patron details form (Log in -> Your personal details). To test, apply the patch and edit a patron to add data to the contact note field. Save and view the detail page for that patron. The contents of the contact note field should appear under the alternate address data. In the OPAC the contact note field label should have correct capitalization. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:52:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:52:10 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-kkEXQheu0E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #28 from Julian Maurice <julian.maurice at biblibre.com> --- Great! Thanks. koha-qa is only complaining about a trailing whitespace in updatedatabase.pl which I'll fix in a follow-up patch. Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:52:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:52:23 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-WzmiUSZYeh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #29 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30108&action=edit Bug 12375: QA followup - remove trailing whitespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:59:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:59:13 +0000 Subject: [Koha-bugs] [Bug 7237] duplicating patron not using patron's branch In-Reply-To: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7237-70-hlLNVEDbEb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7237 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 15:59:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 13:59:20 +0000 Subject: [Koha-bugs] [Bug 7237] duplicating patron not using patron's branch In-Reply-To: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7237-70-p9SADtz6B7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7237 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29859|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30109&action=edit Bug 7237 - duplicating patron not using patron's branch When duplicating a patron the original patron's library should be preselected. To test, apply the patch and choose a patron to duplicate, noting which library is set as their home library. Click the "Duplicate" button and cnofirm that the patron's library is preselected on the patron entry form. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:00:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:00:43 +0000 Subject: [Koha-bugs] [Bug 12536] Incorrect number of irregularity issues In-Reply-To: <bug-12536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12536-70-MOKcyi5FYC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12536 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:01:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:01:06 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12528-70-a9H5R8CaAs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:01:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:01:18 +0000 Subject: [Koha-bugs] [Bug 12523] Add patron email in Holds awaiting pickup circulation rapport. In-Reply-To: <bug-12523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12523-70-mE0qyKvgCV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12523 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:01:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:01:25 +0000 Subject: [Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work In-Reply-To: <bug-12505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12505-70-WiXsKjTqQc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:01:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:01:41 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: <bug-12446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12446-70-8AYFEflYMI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:02:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:02:06 +0000 Subject: [Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms. In-Reply-To: <bug-11961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11961-70-zVPBZeJSDG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:02:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:02:15 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-g7AWkK5mkD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:02:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:02:37 +0000 Subject: [Koha-bugs] [Bug 11443] Refactoring code sending basket from OPAC/intra In-Reply-To: <bug-11443-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11443-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11443-70-t7Qbq8zxyt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11443 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:02:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:02:45 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-BIuaoFUb4z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:02:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:02:47 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-ajE6Ujsp0M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30053|0 |1 is obsolete| | Attachment #30054|0 |1 is obsolete| | Attachment #30055|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30110&action=edit [PASSED QA] Bug 12583: DelItem prototype - Remove $dbh Since C4::Context->dbh shares the DB handler, it's useless to pass it to routines. Test plan: Try to remove an item from the Koha interface. Verify that unit tests pass. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:02:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:02:48 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11373-70-2Mihm6QimO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:02:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:02:58 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11211-70-oh1u8xH4Yt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:03:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:03:04 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-kVgylbnOXo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30111&action=edit [PASSED QA] Bug 12583: DelItem prototype - prefer hashref To delete an item, only the itemnumber should be mandatory. The DelItem routine can retrieve the biblionumber from the itemnumber. Test plan: Verify that t/db_dependent/Items/DelItem.t passes Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:03:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:03:05 +0000 Subject: [Koha-bugs] [Bug 11140] Centralize all sending of email to one subroutine In-Reply-To: <bug-11140-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11140-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11140-70-zKXmRBl7Ld@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11140 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:03:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:03:07 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-sGlJGRCdRM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30112&action=edit [PASSED QA] Bug 12583: DelItem prototype - Add unit tests DelItem should return 1 if the item has been deleted, otherwise 0. Test plan: Verify that t/db_dependent/Items/DelItem.t returns green Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:03:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:03:15 +0000 Subject: [Koha-bugs] [Bug 11092] Need a processing fee and billing fee on late notices. In-Reply-To: <bug-11092-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11092-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11092-70-lygM0OPv9Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:03:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:03:24 +0000 Subject: [Koha-bugs] [Bug 11062] Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) In-Reply-To: <bug-11062-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11062-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11062-70-t5oQ5DO3Xj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:03:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:03:31 +0000 Subject: [Koha-bugs] [Bug 11055] Add 'minutes' as a load period unit In-Reply-To: <bug-11055-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11055-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11055-70-4xyIuD25JX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11055 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:03:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:03:43 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-xlyP08XeRs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- Looks great! We should do this for DelItemCheck as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:04:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:04:07 +0000 Subject: [Koha-bugs] [Bug 10618] Acq claim email not formatting correctly and missing information In-Reply-To: <bug-10618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10618-70-IkMhY6l940@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10618 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:04:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:04:28 +0000 Subject: [Koha-bugs] [Bug 10393] To add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX In-Reply-To: <bug-10393-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10393-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10393-70-iCBfzRU6ny@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10393 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:04:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:04:17 +0000 Subject: [Koha-bugs] [Bug 10435] To add some shortcuts to acquisitions main screen e.g. Receive Shipment and Filter Box In-Reply-To: <bug-10435-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10435-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10435-70-wRUF49suRh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10435 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:04:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:04:45 +0000 Subject: [Koha-bugs] [Bug 10192] Add {ISBN13} as new parameter to OPACSearchForTitleIn In-Reply-To: <bug-10192-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10192-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10192-70-dalltWDKU0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10192 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:04:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:04:52 +0000 Subject: [Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface In-Reply-To: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10083-70-V3msHuRE7w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:05:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:05:09 +0000 Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english templates In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9218-70-LZmVhvbE9B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:05:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:05:26 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: <bug-8133-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8133-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8133-70-OhWXlU9mrK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:05:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:05:42 +0000 Subject: [Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number generation In-Reply-To: <bug-7911-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7911-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7911-70-aEwd7gcguB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:05:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:05:58 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: <bug-7498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7498-70-r7gcnJnYyO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:07:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:07:35 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-0es78edOmv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:07:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:07:52 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: <bug-5620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5620-70-k7yRkLDvX6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:09:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:09:09 +0000 Subject: [Koha-bugs] [Bug 3935] Schedule tasks periodically In-Reply-To: <bug-3935-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3935-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3935-70-HBx45vphJ4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:09:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:09:23 +0000 Subject: [Koha-bugs] [Bug 3059] generate password with forgot password link In-Reply-To: <bug-3059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3059-70-2qreJKVSEB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3059 Francois Charbonnier <francois.charbonnier at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:10:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:10:52 +0000 Subject: [Koha-bugs] [Bug 12453] Do not use by default Host-Item-Number in UNIMARC In-Reply-To: <bug-12453-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12453-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12453-70-GcW21s3q76@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12453 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:14:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:14:48 +0000 Subject: [Koha-bugs] [Bug 10155] Patron search should remember search options selected In-Reply-To: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10155-70-gMPS7aZfDR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10155 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:14:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:14:50 +0000 Subject: [Koha-bugs] [Bug 10155] Patron search should remember search options selected In-Reply-To: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10155-70-HAKRPsWgoe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10155 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29895|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30113&action=edit [PASSED QA] Bug 10155: Patron search should remember search type options selected The search type reset to the default. Test plan: 1/ go on the patrons home page 2/ Launch a search in the header and select the second value for "search type" ("contains"). 3/ Verify the search type is set to "contains" on the results page. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Works as described. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:17:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:17:45 +0000 Subject: [Koha-bugs] [Bug 4013] road type missing on search results In-Reply-To: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4013-70-7k7NlIyEgL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:17:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:17:48 +0000 Subject: [Koha-bugs] [Bug 4013] road type missing on search results In-Reply-To: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4013-70-xiMB5WhyFg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29771|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30114&action=edit Bug 4013 - road type missing on search results On the patron search results page there are several patron fields which do not show: street number, road type, and state. This patch adds them. To test, go to Patrons -> Search patrons and perform a search. In the table of patron search results each patron record should display the correct information including street number, road type, and state. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:21:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:21:57 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12633-70-sPi9No37VG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:22:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:22:00 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12633-70-g9yLa4nnur@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 --- Comment #1 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 30115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30115&action=edit Bug 12633: SQLHelper replacement - C4::Members With this patch, the subroutines AddMember and Search uses DBIx::Class instead of C4::SQLHelper. In order to replace SQLHelper in the Search subroutine, 2 subroutines has been added, it seems a lot : replace 1 line with 2 subroutines, but in fact these 2 subroutines replace all the hidden work done by the SQLHelper. Test plan: 1) Apply the patch 12457 in order to get the last unit tests for Members 2) Apply the patch 3) Execute the unit tests by launching : prove t/db_dependent/Members.t 4) The result has to be a success without error or warning : t/db_dependent/Members.t .. ok All tests successful. Files=1, Tests=55, 2 wallclock secs ( 0.04 usr 0.01 sys + 2.27 cusr 0.09 csys = 2.41 CPU) Result: PASS 5) Sign in the intranet. 6) Verify you can add a member in the intranet. 7) Test of members/guarantor_search.pl : Edit a member which belongs to the cateogry type 'C' (Child), click on 'Set to patron' and verify the search of an adult member is correct. 8) Test of patroncards/members-search.pl : Go to Tools > Patron card creator > New batch > "Add item(s)" and verify the search of a member is correct. 9) Test of serials/member-search.pl : Go on the page serials/member-search.pl and verify the search of a member is correct. 10) Test of reserve/request.pl : Go on a biblio details then "Holds" and verify the search of a member is correct. 11) Test of circ/circulation.pl : Go on Circulation > Checkouts and verify the search of a member is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:24:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:24:35 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-ERuNP3Jmbp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:24:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:24:38 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-0OHsOGJdY0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29094|0 |1 is obsolete| | Attachment #29742|0 |1 is obsolete| | Attachment #29908|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30116&action=edit Bug 12457: Removal warning in t/db_dependent/Members.t When I execute prove t/db_dependent/Members.t, this warning appears twice : "Argument "Test" isn't numeric in modulus (%) at /home/yohann/koha/C4/Context.pm line 1256." The warning is due to a invalid use of the routine set_userenv Test plan: 1/ Execute : prove t/db_dependent/Members.t 2/ The warning appears twice : "Argument "Test" isn't numeric in modulus (%) at /home/yohann/koha/C4/Context.pm line 1256." 3/ Apply the patch 4/ Execute : prove t/db_dependent/Members.t 5/ The result has to be a success without error or warning : t/db_dependent/Members.t .. ok All tests successful. Files=1, Tests=26, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.50 cusr 0.08 csys = 1.63 CPU) Result: PASS Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:24:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:24:43 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-QQHWHnGN15@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 --- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30117&action=edit Bug 12457: Adding unit tests for Members.pm Adding unit tests for the routines AddMessage, GetMessages, GetMessagesCount and DeleteMessage in t/db_dependent/Members.t Adding unit tests for the routines GetPendingIssues and GetAllIssues in separate files : t/db_dependent/Members/GetPendingIssues.t and t/db_dependent/Members/GetAllIssues.t The routine GetAllIssues has been modified because it does not test if the arguments was defined : - the borrowernumber argument is required - if the order argument is not given, it takes a value by default : 'date_due desc' - the limit argument is optional Test plan: 1/ Apply the patch 2/ Execute : prove t/db_dependent/Members.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/GetPendingIssues.t 3/ The result has to be a success without error or warning : t/db_dependent/Members.t ................... ok t/db_dependent/Members/GetAllIssues.t ...... ok t/db_dependent/Members/GetPendingIssues.t .. ok All tests successful. Files=3, Tests=83, 5 wallclock secs ( 0.06 usr 0.01 sys + 4.68 cusr 0.26 csys = 5.01 CPU) Result: PASS Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Amended patch: perltidy on t/db_dependent/Members/* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:24:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:24:47 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-Rt3Wk0twoi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 --- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30118&action=edit Bug 12457: Allow UT on a non empty database Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:25:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:25:58 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-pwFtj56zoI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> --- I SO on it because these patches only add unit tests and should be integrate asap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:26:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:26:49 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12633-70-UyMTml6vrh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30115|0 |1 is obsolete| | --- Comment #2 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 30119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30119&action=edit Bug 12633: SQLHelper replacement - C4::Members With this patch, the subroutines AddMember and Search uses DBIx::Class instead of C4::SQLHelper. In order to replace SQLHelper in the Search subroutine, 2 subroutines has been added, it seems a lot : replace 1 line with 2 subroutines, but in fact these 2 subroutines replace all the hidden work done by the SQLHelper. Test plan: 1) Apply the patch 12457 in order to get the last unit tests for Members 2) Apply the patch 3) Execute the unit tests by launching : prove t/db_dependent/Members.t 4) The result has to be a success without error or warning : t/db_dependent/Members.t .. ok All tests successful. Files=1, Tests=55, 2 wallclock secs ( 0.04 usr 0.01 sys + 2.27 cusr 0.09 csys = 2.41 CPU) Result: PASS 5) Sign in the intranet. 6) Verify you can add a member in the intranet. 7) Test of members/guarantor_search.pl : Edit a member which belongs to the cateogry type 'C' (Child), click on 'Set to patron' and verify the search of an adult member is correct. 8) Test of patroncards/members-search.pl : Go to Tools > Patron card creator > New batch > "Add item(s)" and verify the search of a member is correct. 9) Test of serials/member-search.pl : Go on the page serials/member-search.pl and verify the search of a member is correct. 10) Test of reserve/request.pl : Go on a biblio details then "Holds" and verify the search of a member is correct. 11) Test of circ/circulation.pl : Go on Circulation > Checkouts and verify the search of a member is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:34:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:34:37 +0000 Subject: [Koha-bugs] [Bug 12615] Remove CGI::scrolling_list from marc_subfields_structure.pl In-Reply-To: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12615-70-jm5Key3Dyy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #1) > 'Koha field' is new (for me at last) Actually it should be in the "Advanced constraints" tab. With your patch, I get the "Koha field" in the last tab "Other options (choose one)" but I get "Koha link:HASH(0xc9b9ca8)" in the "Advanced constraints". Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:36:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:36:10 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-uayS70onhA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:36:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:36:13 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-k4Uqx4YHwZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29795|0 |1 is obsolete| | Attachment #29798|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30120&action=edit [PASSED QA] Bug 8218 : Add a maintenance script to sanitize biblio records This patch adds: - a new maintenance script batch_sanitize_records - a new subroutine C4::Charset::SanitizeRecord - new unit tests for the new subroutine Test plan: 1/ prove t/db_dependent/Charset.t 2/ Create a record containing "&amp;" (could be follow with as many 'amp;' as you want) in one of its fields and the same for the field linked to biblioitems.url. The url should not be sanitized, it may contain "&". 3/ Launch the maintenance script with the -h parameter to see how to use it. 4/ Launch the script using the different parameters: --filename=FILENAME --biblionumbers='XXX' --auto-search The auto-search permits to sanitize all records containing "&amp;" in the marcxml field. Use the verbose flag for testing. Without the --confirm flag, nothing is done. 5/ Use the --confirm flag and verify in the biblioitems.marcxml field that the record has been sanitized. 6/ Try the --reindex flag to reindex records which have been modified. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:36:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:36:28 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-81HzlqxTjx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 --- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30121&action=edit [PASSED QA] Bug 8218: Follow-up for some small typos Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:38:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:38:28 +0000 Subject: [Koha-bugs] [Bug 12613] Remove CGI::scrolling_list from koha2marclinks.pl In-Reply-To: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12613-70-MJ6hSeC4sy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12613 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:38:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:38:32 +0000 Subject: [Koha-bugs] [Bug 12613] Remove CGI::scrolling_list from koha2marclinks.pl In-Reply-To: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12613-70-FYMfuGx8G0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12613 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29878|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30122&action=edit Bug 12613: Remove CGI::scrolling_list from koha2marclinks.pl This patch removes all (2) instances from koha2marclinks.pl. Also changes dropdowns width on mapping editor, from an ugly ragged right to a fixed width view. To test: 1. Apply the patch 2. Go to Administration > Koha to MARC mapping 3. Pulldown in this view has been replaced, check for regressions: change table type and press Ok, verify you get Koha fields and tag/subfield appropriate for each table. 4. Now press 'Edit' on any field, go into mapping editor 5. Check that all pulldowns show tag/subtags relevant for each group ( 000s ... 900s ) 6. Check that current mapping is displayed correctly 7. Check for regressions: unmap, remap, press Ok, verify, change again. 8. If you can, check display of mapping editor on several browsers, just in case. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> I have tested with Firefox/Iceweasel only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:39:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:39:48 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: <bug-11230-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11230-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11230-70-mifVkWTgfa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:39:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:39:51 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: <bug-11230-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11230-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11230-70-nfAVCTUPUk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29158|0 |1 is obsolete| | Attachment #29666|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30123&action=edit [PASSED QA] Bug 11230 - Refactor C4::Stats::UpdateStats and add UT This patch - refactors C4::Stats::UpdateStats (it now takes a hashref as unique parameter, instead of a list of parameters) - add UT for it - change the calls made to this sub in C4::Accounts and C4::Circulation Additionnaly it also - adds POD to C4::Stats::TotalPaid - adds some comments to C4::Stats::TotalPaid (I think I found some errors in it) To test : 1. run "prove t/db_dependant/Stats.t -v" 2. make some circulation operations (checkout, checkin, renew, localuse) check the operations are rightly recorded in Statistics table (with a SQL query like "SELECT * FROM statistics WHERE datetime LIKE "2013-11-15%", if you run your test on the 15th november) 3. make some fine payments operations (writeoff, payment) check the operations are rightly recorded in Statistics table (with a SQL query like "SELECT * FROM statistics WHERE datetime LIKE "2013-11-15%", if you run your test on the 15th november) Note that there is probably an issue to fix in Accounts.pm : the user is saved instead of the branch. But this is not the purpose of this patch, so I kept the previous behavior for the moment. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Work, test pass, isse/return/writeoff recorded on statistics Removed a "=back" to make happy koha-qa No other errors Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:40:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:40:02 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: <bug-11230-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11230-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11230-70-vSZOvzjxTh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30124&action=edit [PASSED QA] Bug 11230: dereference hashes in keys (QA followup) This followup replaces $params with %$params in keys function It also fixes some wording Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:40:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:40:39 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: <bug-11244-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11244-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11244-70-BxthCzSjBB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:46:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:46:46 +0000 Subject: [Koha-bugs] [Bug 12612] Remove CGI::scrolling_list from auth_tag_structure.pl In-Reply-To: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12612-70-rlM13EFYHJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12612 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 16:46:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 14:46:49 +0000 Subject: [Koha-bugs] [Bug 12612] Remove CGI::scrolling_list from auth_tag_structure.pl In-Reply-To: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12612-70-EJiqoooRxh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12612 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29876|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30125&action=edit Bug 12612: Remove CGI::scrolling_list from auth_tag_structure.pl This patch removes the only instance in this file. Don't know if the feature is of some utility, seems that does not work (no use of auth values as indicators on MARC authority editor) To test: 1. Apply the patch 2. Go to Administration > Authority types 3. Clic on MARC structure of any fw 4. Clic Edit on any tag 5. On tag editor check the pulldown 'Authorised value', that was replaced 6. Check for regressions: select a value, save, verify the value, change again, etc. Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:01:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:01:04 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: <bug-11244-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11244-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11244-70-xDWUjjJtpg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:01:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:01:07 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: <bug-11244-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11244-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11244-70-qV0EGVITEJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29650|0 |1 is obsolete| | Attachment #29651|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30126&action=edit Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. Signed-off-by: David Cook <dcook at prosentient.com.au> I love this patch! It is the best solution to this problem that I've seen. I think it is set up to perfectly handle dates in the notices. Unfortunately, the $dateonly flag is backwards, so the time is stripped from timestamps and 00:00:00 is added to dates without times. I'm adding a follow-up to reverse the setting of this flag. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:01:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:01:12 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: <bug-11244-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11244-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11244-70-TVZW1uxKHp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #27 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30127&action=edit Bug 11244: (follow-up) Fix $dateonly flag At the moment, $dateonly is set to true when $1 is defined. However, since the regex capture group only includes the time, this flag will only be set when there is a value that includes a time. In effect, this means that timestamps are reduced to dates only, while dates have 00-00-0000 added to them. This patch keeps the logic but reverses the values, so that $dateonly will default to true unless $1 is defined. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:02:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:02:36 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12596-70-5yeTXb8I9l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:02:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:02:36 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: <bug-11244-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11244-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11244-70-VQoWZZyDuB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #28 from Jonathan Druart <jonathan.druart at biblibre.com> --- Kyle passed QA on the first patch, I pass QA on the second one. So the bug report is passed QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:04:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:04:43 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11331-70-OtyIwPOa5W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Fridolin SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Assignee|sophie.meynieux at biblibre.co |fridolyn.somers at biblibre.co |m |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers at biblibre.com> --- I'm on a patch developpement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:09:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:09:42 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: <bug-12395-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12395-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12395-70-NZxpyBvH6z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28943|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30128&action=edit [PASSED QA] Bug 12395: Save order line's creator New MySQL column: aqorders.createdby Creator's name is displayed on order's receive pages (acqui/orderreceive.pl and acqui/parcel.pl) On acqui/orderreceive.pl it replace the name of basket's creator On acqui/parcel.pl, to avoid adding more data in the table of pending orders, it is shown in a popup like MARC and Card views Test plan: 1/ Run updatedatabase.pl 2/ Create a new order and go to the receipt page (acqui/parcel.pl) 3/ Click on "Order" link in column "More" (previously "View record") 4/ A javascript popup should appear with your name in it. Close the popup. 5/ Click on "Receive" link 6/ Your name should appear in front of "Created by" label, to the right of the page. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:10:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:10:12 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: <bug-12395-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12395-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12395-70-IEDtprmaNy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30129&action=edit Bug 12395 [QA Followup] * Rename createdby to created_by * Fix GPL versioning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:10:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:10:22 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: <bug-12395-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12395-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12395-70-AZoeHs54qp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:13:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:13:19 +0000 Subject: [Koha-bugs] [Bug 12614] Remove CGI::scrolling_list from auth_subfields_structure.pl In-Reply-To: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12614-70-tFkjrnguOw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:13:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:13:23 +0000 Subject: [Koha-bugs] [Bug 12614] Remove CGI::scrolling_list from auth_subfields_structure.pl In-Reply-To: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12614-70-fvhN3fd5IP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29879|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 30130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30130&action=edit Bug 12614: Remove CGI::scrolling_list from auth_subfields_structure.pl This patch removes all instances on this file. Even removes some commented out instances. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > Authority types 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 031 5. Clic 'Edit subfields' button Now the tests proper 6. 'Help input' box (editor bottom): Eight(8) scrolling_list removed, they use to feed the four pulldowns, so check each one 'Koha field' is new (for me at last) 'Authorised value', 'Thesaurus' (is this valid/useful here?) 'Plugin' There is a difference between existing subtags and a new subtag, the 'id' of the pulldowns (so the 8 scrolling list removed) Check assign/remove/save/load values, search for regressions If you edit subtag 942, it has a value on kohafield (default fw) I think that this box could be prettified with fixed width for pulldowns. 7. No more functional tests, there are 4 scrolling_list removed that are commented (removed also commented code on tt file), and two instances that are similar to previously removed instances, evidently with no effect. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Not sure about the new Koha field entry... All works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:21:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:21:08 +0000 Subject: [Koha-bugs] [Bug 12413] Offline circulation; link to get desktop application broken In-Reply-To: <bug-12413-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12413-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12413-70-qbctWRS9dg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12413 David Roberts <david.roberts at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from David Roberts <david.roberts at ptfs-europe.com> --- It looks like this link has now been fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:34:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:34:11 +0000 Subject: [Koha-bugs] [Bug 12664] New: UTF-8: Opac suggestion. Title '=?UTF-8?Q?=CF=89t55=20=C3=A8=C3=A8=20teas?=' gives an error Message-ID: <bug-12664-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12664 Bug ID: 12664 Summary: UTF-8: Opac suggestion. Title '?t55 ?? teas' gives an error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org Testing bug 11944 on sandbox 6 I try to write a suggestion from Opac. I try to insert '?t55 ?? teas' as title. When I click "Submit yout suggestion" I see: Software error: Cannot decode string with wide characters at /usr/lib/perl/5.10/Encode.pm line 174. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:34:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:34:46 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-l8RmvF1hEV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12664 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 17:34:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 15:34:46 +0000 Subject: [Koha-bugs] [Bug 12664] UTF-8: Opac suggestion. Title '=?UTF-8?Q?=CF=89t55=20=C3=A8=C3=A8=20teas?=' gives an error In-Reply-To: <bug-12664-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12664-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12664-70-gXoDjc0oYG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12664 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 19:36:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 17:36:58 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8148-70-RJUNkWRzrt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen at gmail.com --- Comment #29 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Please provide regression tests for this to be included in master. I'd accept it gets PASSED-QA straight on the presence of those tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 22:18:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 20:18:57 +0000 Subject: [Koha-bugs] [Bug 12615] Remove CGI::scrolling_list from marc_subfields_structure.pl In-Reply-To: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12615-70-8cAMkf28W6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29897|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30131&action=edit Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl This patch removes all instances on this file. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 020 5. Clic 'Edit subfields' button Now the tests proper 6. On any subfield, check pulldown 'Managed in tab', was replaced, so test if it works and search for regressions Change, save, load, change again 7. Clic on 'Advanced constraints' (2) scrolling list removed At the bottom, check 'Koha link', was changed Check assign/remove/save/load values, search for regressions 8. Clic on 'Other options' box Eight(6) scrolling_list removed, they use to feed three pulldowns, so check each one 'Authorised value', 'Thesaurus' 'Plugin' Check assign/remove/save/load values, search for regressions Check adding a new subfield -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 22:20:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 20:20:56 +0000 Subject: [Koha-bugs] [Bug 12615] Remove CGI::scrolling_list from marc_subfields_structure.pl In-Reply-To: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12615-70-eal0yu0yTp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Jonathan Druart from comment #2) > > Actually it should be in the "Advanced constraints" tab. > With your patch, I get the "Koha field" in the last tab "Other options > (choose one)" but I get "Koha link:HASH(0xc9b9ca8)" in the "Advanced > constraints". > > Marked as Failed QA. Oops, FQA is absolutely correct! Fixed now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 23:54:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 21:54:53 +0000 Subject: [Koha-bugs] [Bug 12560] Wrong capitalization on acquisition statistics page In-Reply-To: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12560-70-N5VdMu40wR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12560 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30057|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30132&action=edit [SIGNED-OFF] Bug 12560: Fixing capitalisation of Item Type To test: Go to reports>Statistics Wizard>Acquisition Notice item type has incorrect capitalisation Apply Patch Refresh page Notice it is now fixed Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Work as described koha-qa complains for a tab on line 220, fixed. Natali, don't forget to assign the bug to yourself :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 23:56:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 21:56:24 +0000 Subject: [Koha-bugs] [Bug 12560] Wrong capitalization on acquisition statistics page In-Reply-To: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12560-70-oEN3qMpVf3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12560 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com Patch complexity|--- |String patch Assignee|oleonard at myacpl.org |natalieb at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 23:59:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 21:59:50 +0000 Subject: [Koha-bugs] [Bug 12572] Use jQueryUI Accordion to display message transport types In-Reply-To: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12572-70-A19ZkcxuMx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 25 23:59:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 21:59:57 +0000 Subject: [Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery In-Reply-To: <bug-12443-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12443-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12443-70-r4NvFG5Bri@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443 --- Comment #18 from Robin Sheat <robin at catalyst.net.nz> --- When I said testing, I meant squeeze. I forgot that I build it inside a chroot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 00:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 22:04:03 +0000 Subject: [Koha-bugs] [Bug 12562] Capitalization: 'Save Report' when saving a new SQL report In-Reply-To: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12562-70-wUTCc8L8JV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12562 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30059|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30133&action=edit [SIGNED-OFF] Bug 12562: fix capitalisation of Save Report button Test: go to reports and then create report from SQL the Save button has wrong capitalisaion of Report add patch refresh should see button being Saved report Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Work as described, no koha-qa errors Brian, don't forget to assign the bug to yourself and set patch complexity :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 00:04:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 22:04:47 +0000 Subject: [Koha-bugs] [Bug 12562] Capitalization: 'Save Report' when saving a new SQL report In-Reply-To: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12562-70-nUA2TUdhb1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12562 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com Patch complexity|--- |String patch Assignee|oleonard at myacpl.org |briann at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 00:10:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 22:10:34 +0000 Subject: [Koha-bugs] [Bug 12563] Capitalization: 'Set Status' on detail pages item's tab In-Reply-To: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12563-70-lr8i5owLuK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12563 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30060|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30134&action=edit [SIGNED-OFF] Bug 12563: capitalisation on detail pages item's tab Test: go to a record in the catalog, go to detail page, switch to 'items' tab, look for the 2 'Set status' buttons, check capitalisation should be lower case for second word. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Works as described, no koha-qa errors Evonne, assign the patch to yourself :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 00:10:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 22:10:57 +0000 Subject: [Koha-bugs] [Bug 12563] Capitalization: 'Set Status' on detail pages item's tab In-Reply-To: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12563-70-N0IibSRa72@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12563 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com Patch complexity|--- |String patch Assignee|oleonard at myacpl.org |evonne at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 00:30:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 22:30:10 +0000 Subject: [Koha-bugs] [Bug 12564] Capitalization: Buttons in inventory tool In-Reply-To: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12564-70-TIRwCP3Fni@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12564 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30061|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30135&action=edit [SIGNED-OFF] Bug 12564: Fixing capitalisation buttons in inventory tool To Test 1/ Do a search in the inventory tool - view capitilsation errors in lower Buttons 2/ Apply patch 3/ Redo search in the inventory tool 4/ Confirm capitisations errors are fixed Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Work as described, no koha-qa errors Fixed capitalization (and typo) on patch bug description :) Karl, don't forget to assign the bug to yourself :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 00:32:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 22:32:25 +0000 Subject: [Koha-bugs] [Bug 12564] Capitalization: Buttons in inventory tool In-Reply-To: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12564-70-jDGdGIuIKH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12564 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com Patch complexity|--- |String patch Assignee|oleonard at myacpl.org |karlm at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 00:59:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jul 2014 22:59:55 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-v3Egp3e6is@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I'm not sure about CAS specific stuff, but there are problems with this patch: - No regression tests. - Koha's code usually expects OPACBaseUrl not to contain "http://" in front of it. So, something's wrong. Could you please at least provide a sample call to the function where all the assertions (like "url_param() returns the deleted params too"). Think of a black box test. My feeling is that CAS working with this patch is a side effect of another problem. I am open to comments and willing to push this ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 02:02:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 00:02:20 +0000 Subject: [Koha-bugs] [Bug 12655] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in XSLT In-Reply-To: <bug-12655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12655-70-JSahz2LE7T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12655 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- This works for you? Not for me :( First 'opacthemes' need to be added to C4/XSLT.pm list of usable sysprefs Second I think the proper syntax is <xsl:element name="img"> <xsl:attribute name="src">/opac-tmpl/<xsl:value-of select="$theme"/>/images/filefind.png</xsl:attribute> <xsl:attribute name="style">vertical-align:middle</xsl:attribute> <xsl:attribute name="height">15</xsl:attribute> <xsl:attribute name="width">15</xsl:attribute> </xsl:element> With your patch i got "http://.../opac-tmpl/%24theme/images/filefind.png" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:00:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:00:45 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-SHb9Wc0fbn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23064|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30136&action=edit Bug 6149: Follow-up - Stopwords for Result Highlighting (opac-results-grouped) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:00:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:00:59 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-GfGXtW8AmE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #61 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30137&action=edit Bug 6149 - Stopwords for Result Highlighting This patch adds a system preference to control stopwords used to prevent operators and other 'minor' words from being highlighted in search results when the OpacHighlightWords syspref is enabled Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> Works as advertised, I fixed the updatedatabase to use XXX so it won't clash as much Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Fixed a conflict in updatedatabase.pl. Also fixed tabs in opac-detail.tt Feature passes all tests and QA script now. Tested in intranet and OPAC with different words and searches. Works on results pages and OPAC detail page. Highlighting and unhighlighting still works correctly. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:01:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:01:08 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-h70NqGmpLg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23065|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30138&action=edit Bug 6149: Follow-up - Operator highlighted in search results - changed sample words to and|or|not in sysprefs.sql and updatedatabase - changed systempreference name from OpacHighlightedStopwords to HighlightedStopwords, as it also works for the staff results page Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:01:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:01:18 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-bhy5H78q2Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26051|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30139&action=edit Bug 6149 - RM followup. Gloabal replaced HightedStopWords syspref with NotHightedWords for clarification purposes. Hopefully this is a bit better and still not too verbose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:06:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:06:37 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-QCw6SRCoBi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #64 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Re-based upon current master, though with the imminent removal of CCSR and prog I'm thinking I should factor those two bits of the patch out now. I still intend, but have no idea if I'll ever get around to it, to factor out the highlighting code so it's more easily applied across templates with just an include. I'd also like to update the jquery plugin (either to v4 from v3.. or to http://bartaz.github.io/sandbox.js/jquery.highlight.html fork), and add some ajax cleverness so that instead of having to create a list of stopwords (though that may still be useful for some other cases) we could get a more accurate set of search terms without operators back from the search script itself) I don't see why this one should get held up much further though.. it still works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:21:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:21:23 +0000 Subject: [Koha-bugs] [Bug 12639] Z39.50 administration page should use "message" dialog for adds and updates In-Reply-To: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12639-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12639-70-3BP0yCcAaT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12639 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:21:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:21:47 +0000 Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click In-Reply-To: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9667-70-uwPV95Qkrr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:23:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:23:25 +0000 Subject: [Koha-bugs] [Bug 12583] DelItem takes $dbh in parameter In-Reply-To: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12583-70-O3mv0YBTvN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12583 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Jonathan! P.S. I renamed the unit tests file. I'll propose a discussion on naming schemas and arrangement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:26:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:26:02 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-JBvvBw3BgW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23025|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:26:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:26:12 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-6hvwTeMmrZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23066|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:26:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:26:22 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-aGEU9vugoV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30136|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:26:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:26:33 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-y9mGLYTmRg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:26:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:26:43 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-IKWbODylMS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30138|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:26:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:26:52 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-UfFrkjntdD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30139|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:27:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:27:36 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-sOQQ7q0h2J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #65 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30140&action=edit Bug 6149 - Stopwords for Result Highlighting This patch adds a system preference to control stopwords used to prevent operators and other 'minor' words from being highlighted in search results when the OpacHighlightWords syspref is enabled Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> Works as advertised, I fixed the updatedatabase to use XXX so it won't clash as much Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Fixed a conflict in updatedatabase.pl. Also fixed tabs in opac-detail.tt Feature passes all tests and QA script now. Tested in intranet and OPAC with different words and searches. Works on results pages and OPAC detail page. Highlighting and unhighlighting still works correctly. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:27:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:27:41 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-mG1rzNbP37@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #66 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30141&action=edit Bug 6149: Follow-up [defaults] - Stopwords for Result Highlighting - changed sample words to and|or|not in sysprefs.sql and updatedatabase - changed systempreference name from OpacHighlightedStopwords to HighlightedStopwords, as it also works for the staff results page Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:27:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:27:46 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-wqrd80LuRU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #67 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30142&action=edit Bug 6149: Follow-up [bootstrap] - Stopwords for Result Highlighting - Added functionality to new bootstrap theme Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:27:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:27:51 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-l1LRI3DgD3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #68 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30143&action=edit Bug 6149: Follow-up [grouped] - Stopwords for Result Highlighting - Added functionaility to opac-results-grouped page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 15:27:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 13:27:56 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6149-70-CqO7XGMj7M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #69 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30144&action=edit Bug 6149 - Follow-up [syspref] - Stopwords for Result Highlighting - global replaced HightedStopWords syspref with NotHightedWords for clarification purposes. Hopefully this is a bit better and still not too verbose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 16:13:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 14:13:37 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-jD3zw3faAc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30145&action=edit Bug 12649: followup to add Croatian into french -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 16:17:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 14:17:20 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-CKJpqkfjOs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 16:17:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 14:17:38 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-9Pb9CdWRTu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 17:54:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 15:54:46 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-S9D7suThcZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #2 from Marc V?ron <veron at veron.ch> --- Patch does not apply: Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Failed to merge in the changes. Version: 3.17.00.010 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 18:13:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 16:13:10 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-EfgD0pYp8n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 --- Comment #7 from Marc V?ron <veron at veron.ch> --- Created attachment 30146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30146&action=edit [Signed-off] Bug 11888: Random password suggestion does not work twice This patch adds a simple ajax-call to pull a new suggested password from the same perl script. To test: 1) Search for a patron and select "Change password" from the moremember-view. 2) In the member-password-view, click on "Click to fill with a randomly generated suggestion". 3) Confirm that you get a new suggested password and click the same link again. 4) Note that you do not get another suggested password - nothing is happening. 5) Apply patch. 6) Repeat steps 1-3 and confirm that you can keep clicking for a new suggested password. Patch works as expected. Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 18:13:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 16:13:57 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-5VyRckDCE1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30011|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 18:14:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 16:14:19 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-C6NpRE6OSx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 18:24:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 16:24:42 +0000 Subject: [Koha-bugs] [Bug 12661] Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt In-Reply-To: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12661-70-CiJM7LqYqP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron <veron at veron.ch> --- The patch changes Catalog by Item Type to: Catalog by Item type I think it should be: Catalog by item type Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 18:31:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 16:31:04 +0000 Subject: [Koha-bugs] [Bug 12660] Mispelling of Accomodation in two tools templates - in comments In-Reply-To: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12660-70-AQ9MJKrCY6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12660 --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 30147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30147&action=edit [Signed-off] Bug 12660:Correct mispelling of accomodate in comments View the file in your git checkout to see the misspelling of accomodate do the patch view the files again to see the correct spelling accommodate Patch behaves as expected. Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 18:31:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 16:31:35 +0000 Subject: [Koha-bugs] [Bug 12660] Mispelling of Accomodation in two tools templates - in comments In-Reply-To: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12660-70-eKv50x1Qld@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12660 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 18:31:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 16:31:53 +0000 Subject: [Koha-bugs] [Bug 12660] Mispelling of Accomodation in two tools templates - in comments In-Reply-To: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12660-70-SWJml5YhJA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12660 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30066|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 18:38:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 16:38:39 +0000 Subject: [Koha-bugs] [Bug 12061] tmpl_process3.pl new features In-Reply-To: <bug-12061-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12061-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12061-70-8cKlpaQFcx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12061 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28737|0 |1 is obsolete| | --- Comment #33 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30148&action=edit Bug 12061 - tmpl_process3.pl - Include/exclude file by name This patch adds options to include/exclude files by matching their names. Also modifies current code to check only filenames (not dirs) Checking is case insensitive !! NOTE: The difference between -f and -m is subtle, but important. They differs mainly on update,: -f do a merge, -m a replace To test after patch: A) Include only 'normarc' 1. create cd misc/translator perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s normarc.po -r -m normarc - check provenance of strings egrep "^#:" normarc.po | cut -d":" -f2 | sort | uniq - only files with normarc in their names must be present 2. update perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s normarc.po -r -m normarc - repeat check 3. install mkdir test perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/bootstrap/en -o ./test -s normarc.po -r -m normarc - check name of created files rm -rf test normarc.po B) Exclude 4. create perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s xnormarc.po -r -n normarc - check provenance egrep "^#:" xnormarc.po | cut -d":" -f2 | sort | uniq | grep -i normarc - there must be no results 5. update perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s xnormarc.po -r -n normarc - check provenance 6. install mkdir test perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/bootstrap/en -o ./test -s xnormarc.po -r -n normarc - check files find test | grep -i normarc - there must be no results You can also try another combination, use for example "-m patron -m user -m bottom" (or use -n) or mixed "-m marc -n normarc", do create/install and look filenames http://bugs.koha-community.org/show_bug.cgi?id=12292 Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 18:52:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 16:52:57 +0000 Subject: [Koha-bugs] [Bug 12521] Arrangement of divs on opac-advsearch.tt In-Reply-To: <bug-12521-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12521-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12521-70-S3yONDkQFj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 30149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30149&action=edit [Signed-off] Bug 12521 - Change layout a bit of the opac advanced search To test: Load up the advanced search and make sure it displays properly, with all of the elements within the main div, and only one container-fluid. Patch behaves as expected. Advanced search looks much better now. Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 18:53:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 16:53:58 +0000 Subject: [Koha-bugs] [Bug 12521] Arrangement of divs on opac-advsearch.tt In-Reply-To: <bug-12521-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12521-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12521-70-nR9Z9SIz1n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29461|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 18:55:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 16:55:39 +0000 Subject: [Koha-bugs] [Bug 12521] Arrangement of divs on opac-advsearch.tt In-Reply-To: <bug-12521-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12521-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12521-70-ArdULlMxLQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 19:06:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 17:06:48 +0000 Subject: [Koha-bugs] [Bug 12061] tmpl_process3.pl new features In-Reply-To: <bug-12061-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12061-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12061-70-KWVBJupAQ8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12061 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #34 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Jonathan Druart from comment #9) ... > It looks to be the same behavior as the -f option. After all, it is not the same behavior! This code on 'update' is the main difference if ( @filenames ) { my ($tmph3, $tmpfile3) = tmpnam(); $st = system("msgcat $str_file $tmpfile2 > $tmpfile3"); $st = system("msgmerge ".($quiet?'-q':'')." -s $str_file $tmpfile3 -o - | msgattrib --no-obsolete -o $str_file") unless $st; } else { $st = system("msgmerge ".($quiet?'-q':'')." -s $str_file $tmpfile2 -o - | msgattrib --no-obsolete -o $str_file"); } '-f' is the right choice to use when a file is modified and one updates translation file to reflect that. But that is not the behavior that I want, PO file must reflect exactly the contents of source dir on create & update. I retained Fridolin sign, he signed a previous version with both (-n and -m) new options, the code is slightly different but closer to the version that you QAed. Left as signed for your consideration, but only changed the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 19:27:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 17:27:56 +0000 Subject: [Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees In-Reply-To: <bug-12448-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12448-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12448-70-BegX3gM9WD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #34 from Marc V?ron <veron at veron.ch> --- Sorry, it doesn't apply on current master (3.17.00.010) Applying: Bug 12448 - Ask for confirmation when checking out an item with rental fees Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Failed to merge in the changes. Patch failed at 0001 Bug 12448 - Ask for confirmation when checking out an item with rental fees -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 19:38:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 17:38:45 +0000 Subject: [Koha-bugs] [Bug 12354] Prevent reserving items based on item field values In-Reply-To: <bug-12354-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12354-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12354-70-C5fz89scxd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12354 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #2 from Marc V?ron <veron at veron.ch> --- Good feature! ...but patch doesn't apply: Applying: Bug 12354 - Prevent reserving items based on item field values Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Reserves.pm Failed to merge in the changes. Patch failed at 0001 Bug 12354 - Prevent reserving items based on item field values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 19:57:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 17:57:39 +0000 Subject: [Koha-bugs] [Bug 12521] Arrangement of divs on opac-advsearch.tt In-Reply-To: <bug-12521-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12521-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12521-70-t1jGhzKs9k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 mathieu saby <mathsabypro at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #3 from mathieu saby <mathsabypro at gmail.com> --- Hello Has anybody ran a UX survey on this page? I have always thought this page was rather unfriendly for average users, but no real proof of that. Mathieu Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 23:26:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 21:26:16 +0000 Subject: [Koha-bugs] [Bug 12570] Warnings in t/Biblio.t could be tested In-Reply-To: <bug-12570-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12570-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12570-70-ztYoVIkCDs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12570 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29675|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30150&action=edit [SIGNED-OFF] Bug 12570: test for carped warnings in t/Biblio.t To test: - Run $ prove t/Biblio.t => Warnings printed to STDOUT - Apply patch - Run $ prove t/Biblio.t => No warnings Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> No more warnings. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 23:26:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 21:26:32 +0000 Subject: [Koha-bugs] [Bug 12570] Warnings in t/Biblio.t could be tested In-Reply-To: <bug-12570-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12570-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12570-70-JCldsclZA5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12570 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 23:31:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 21:31:23 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-57dDtvt9o3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30056|0 |1 is obsolete| | --- Comment #148 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30151&action=edit [SIGNED-OFF] Bug 7143: Add Prosentient Systems to contributing companies Better late than never to add the company name to the list of contributing companies. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Entry added. No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 23:32:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 21:32:06 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-tfvhYu8zvd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 23:52:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 21:52:44 +0000 Subject: [Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC In-Reply-To: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12554-70-6jqUsRZFQP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29619|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30152&action=edit [SIGNED-OFF] Bug 12554: Fix GetMarcPrice for NORMARC When doing aquisitions and ordering from external z3950 targes, the item price is not inferred from the MARC record when the NORMARC framework is set. This patch makes GetMarcPrice treat NORMARC the same as MARC21. Test plan * Setup Koha with NORMARC framework * Add a norwegian z3950 search target (ex: z3950.bibsys.no:2100, database=BIBSYS) * Create a new basket, and add order to basket from external source * Search for a tile (ex: ISBN 8205341834) from the bibsys z3950 server * Click to order the title * Observe that vendor price is not set * Apply patch, repeat search for same book * Order, and observe the vendor price is filled in from the MARC record http://bugs.koha-community.org/show_bug.cgi?id=12554 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Works as described. No errors. Tested changing marcflavour syspref to NORMARC, and following test plan, bug exist and is fixed. Changed bug description on patch, too long :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 26 23:52:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 21:52:55 +0000 Subject: [Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC In-Reply-To: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12554-70-MQLoOlL35X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 00:05:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 22:05:16 +0000 Subject: [Koha-bugs] [Bug 12600] Duplicated use statement in Search.pm In-Reply-To: <bug-12600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12600-70-2qeza4ZOcG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29811|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30153&action=edit [SIGNED-OFF] Bug 12600: remove duplicate use statement from code A use C4::Charset was added deep in the body of the code we have already imported it at the top of the file (the by convention normal place) As use is executed at compile time specifying it in the code body does not serve a useful purpose and detracts from the readability of an already overly complex subroutine. Remove the superfluous statement also removed the tabs introduced to the surrounding lines by the same commit Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Search still works, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 00:05:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 22:05:34 +0000 Subject: [Koha-bugs] [Bug 12600] Duplicated use statement in Search.pm In-Reply-To: <bug-12600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12600-70-WGev8JrGQj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 01:12:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 23:12:50 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12167-70-HUxvx26Tsg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Tested on Ubuntu 12.04 and 14.04 Patch 1: for me is correct, but it pass before AND after. Why it should fail? Patch 2: why CAST? Usually I use date(timestamp) for this. Anyway, on current master (and both Ubuntu vers) my news display normally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 01:19:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 23:19:42 +0000 Subject: [Koha-bugs] [Bug 7462] duplicate patron shows flags In-Reply-To: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7462-70-7mtGZIaXSk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29753|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30154&action=edit [SIGNED-OFF] Bug 7462 - duplicate patron shows flags When duplicating a patron the form fields for setting patron account flags and restrictions should be hidden as it is when adding a patron. This patch adds the correct logic to the template. To test, duplicate an existing patron: - Confirm that the "Patron account flags" and "Patron restrictions" sections are not visible. - Confirm that saving a duplicated patron works correctly. - Confirm that the edit and new patron entry forms are unaffected. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Works ok, all three points confirmed No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 01:19:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jul 2014 23:19:57 +0000 Subject: [Koha-bugs] [Bug 7462] duplicate patron shows flags In-Reply-To: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7462-70-x2aXLPclJZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 03:08:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 01:08:21 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12167-70-nveUGmBU5p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 --- Comment #4 from M. Tompsett <mtompset at hotmail.com> --- Patch 1 - patch 1 the logic is wrong, this is a required fixed. It's broken logic that works without really testing what it should be. Patch 2 - Since MySQL has updated again, it has since corrected itself on Ubuntu, but I haven't retested recently. So it may not be necessary. I'll retest this later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 03:41:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 01:41:10 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12167-70-R5Tu5trLRU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to M. Tompsett from comment #4) > Patch 1 - patch 1 the logic is wrong, this is a required fixed. It's broken > logic that works without really testing what it should be. I agree, and your solution is correct. My only point from your test plan is that it can't fail > Patch 2 - Since MySQL has updated again, it has since corrected itself on > Ubuntu, but I haven't retested recently. So it may not be necessary. I'll > retest this later. Again, I think is correct, or better than current code I only mention that my news are displayed, and curious about the use of CAST. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 05:04:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 03:04:32 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12167-70-5MHtI33Z9p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- CAST is ANSI SQL. I was trying to make sure to avoid MySQLisms. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 08:04:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 06:04:35 +0000 Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber In-Reply-To: <bug-9921-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9921-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9921-70-2hQB2rwCEQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 giuseppe.angilella at ct.infn.it changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |giuseppe.angilella at ct.infn. | |it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 16:24:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 14:24:10 +0000 Subject: [Koha-bugs] [Bug 12294] Revert BZ9372 In-Reply-To: <bug-12294-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12294-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12294-70-vYOUwYBl06@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Sophie! Note: I'll add a reference to this in the release notes as Kyle proposed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 21:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 19:00:09 +0000 Subject: [Koha-bugs] [Bug 12634] JavaScript error in Bootstrap OPAC detail page if OPACPopupAuthorsSearch is enabled In-Reply-To: <bug-12634-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12634-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12634-70-djijU3bKt7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 21:00:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 19:00:15 +0000 Subject: [Koha-bugs] [Bug 12634] JavaScript error in Bootstrap OPAC detail page if OPACPopupAuthorsSearch is enabled In-Reply-To: <bug-12634-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12634-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12634-70-XtS94tkkbR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 21:02:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 19:02:51 +0000 Subject: [Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan" In-Reply-To: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12635-70-0GjGFwnqKB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think the problem is a missing step-by-step that would be helpful for testers without knowledge of the course reserves module. I am switching back to new - in discussion is more for general disagreements about the approach of a fix or similar. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 21:02:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 19:02:57 +0000 Subject: [Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan" In-Reply-To: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12635-70-j9XW2qFSHf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 22:37:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 20:37:48 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12167-70-hVyuF50xP3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Ok then. Would you mind to change test plan on both patches? I can sign them, but only as they change for good some code. But I see nothing as described in current test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 22:54:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 20:54:26 +0000 Subject: [Koha-bugs] [Bug 11140] Centralize all sending of email to one subroutine In-Reply-To: <bug-11140-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11140-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11140-70-HpTCPDurxQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11140 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:12:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:12:36 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-4MMcpEaGAX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:12:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:12:40 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-rUCLRAgEjS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30151|0 |1 is obsolete| | --- Comment #149 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30155&action=edit [PASSED QA] Bug 7143: Add Prosentient Systems to contributing companies Better late than never to add the company name to the list of contributing companies. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Entry added. No errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Tiny template addition, no problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:15:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:15:52 +0000 Subject: [Koha-bugs] [Bug 12564] Capitalization: Buttons in inventory tool In-Reply-To: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12564-70-Nn5f5C13DN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12564 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:15:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:15:55 +0000 Subject: [Koha-bugs] [Bug 12564] Capitalization: Buttons in inventory tool In-Reply-To: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12564-70-nU4CcSq9SQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12564 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30135|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30156&action=edit [PASSED QA] Bug 12564: Fixing capitalisation buttons in inventory tool To Test 1/ Do a search in the inventory tool - view capitalisation errors in lower Buttons 2/ Apply patch 3/ Redo search in the inventory tool 4/ Confirm capitalisation errors are fixed Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Work as described, no koha-qa errors Fixed capitalization (and typo) on patch bug description :) Karl, don't forget to assign the bug to yourself :) Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Small template change, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:19:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:19:03 +0000 Subject: [Koha-bugs] [Bug 12563] Capitalization: 'Set Status' on detail pages item's tab In-Reply-To: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12563-70-Vmulcs3CUh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12563 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:19:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:19:06 +0000 Subject: [Koha-bugs] [Bug 12563] Capitalization: 'Set Status' on detail pages item's tab In-Reply-To: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12563-70-7ycbrhHJUI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12563 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30134|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30157&action=edit [PASSED QA] Bug 12563: capitalisation on detail pages item's tab Test: go to a record in the catalog, go to detail page, switch to 'items' tab, look for the 2 'Set status' buttons, check capitalisation should be lower case for second word. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Works as described, no koha-qa errors Evonne, assign the patch to yourself :) Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Small template change, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:19:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:19:39 +0000 Subject: [Koha-bugs] [Bug 12521] Arrangement of divs on opac-advsearch.tt In-Reply-To: <bug-12521-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12521-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12521-70-0mtrrea0YD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 --- Comment #4 from Liz Rea <liz at catalyst.net.nz> --- Not that I am aware of. Generally, a UX survey of the OPAC would be a good thing to do. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:21:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:21:56 +0000 Subject: [Koha-bugs] [Bug 12562] Capitalization: 'Save Report' when saving a new SQL report In-Reply-To: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12562-70-S6jJfSoszI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12562 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:21:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:21:59 +0000 Subject: [Koha-bugs] [Bug 12562] Capitalization: 'Save Report' when saving a new SQL report In-Reply-To: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12562-70-JIJG2oJG6j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12562 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30133|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30158&action=edit [PASSED QA] Bug 12562: fix capitalisation of Save Report button Test: go to reports and then create report from SQL the Save button has wrong capitalisaion of Report add patch refresh should see button being Saved report Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Work as described, no koha-qa errors Brian, don't forget to assign the bug to yourself and set patch complexity :) Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Small template change, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:24:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:24:00 +0000 Subject: [Koha-bugs] [Bug 12560] Wrong capitalization on acquisition statistics page In-Reply-To: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12560-70-boIJXiBiuG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12560 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:24:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:24:02 +0000 Subject: [Koha-bugs] [Bug 12560] Wrong capitalization on acquisition statistics page In-Reply-To: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12560-70-gFx5KOY5Ap@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12560 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30132|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30159&action=edit [PASSED QA] Bug 12560: Fixing capitalisation of Item Type To test: Go to reports>Statistics Wizard>Acquisition Notice item type has incorrect capitalisation Apply Patch Refresh page Notice it is now fixed Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Work as described koha-qa complains for a tab on line 220, fixed. Natali, don't forget to assign the bug to yourself :) Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Small change, no problems found :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:27:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:27:00 +0000 Subject: [Koha-bugs] [Bug 12660] Mispelling of Accomodation in two tools templates - in comments In-Reply-To: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12660-70-JF6qAeDT6C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12660 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30160&action=edit [PASSED QA] Bug 12660:Correct mispelling of accomodate in comments View the file in your git checkout to see the misspelling of accomodate do the patch view the files again to see the correct spelling accommodate Patch behaves as expected. Signed-off-by: Marc V?ron <veron at veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Fixes typos to correct spelling. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:27:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:27:22 +0000 Subject: [Koha-bugs] [Bug 12660] Mispelling of Accomodation in two tools templates - in comments In-Reply-To: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12660-70-KFAY2ycdoE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12660 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:27:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:27:23 +0000 Subject: [Koha-bugs] [Bug 12660] Mispelling of Accomodation in two tools templates - in comments In-Reply-To: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12660-70-ofrKyUhyVx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12660 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30147|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:29:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:29:24 +0000 Subject: [Koha-bugs] [Bug 12521] Arrangement of divs on opac-advsearch.tt In-Reply-To: <bug-12521-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12521-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12521-70-Y0vKPVqGgn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org Assignee|oleonard at myacpl.org |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:34:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:34:09 +0000 Subject: [Koha-bugs] [Bug 12600] Duplicated use statement in Search.pm In-Reply-To: <bug-12600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12600-70-Z1LwtTHSu5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:34:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:34:11 +0000 Subject: [Koha-bugs] [Bug 12600] Duplicated use statement in Search.pm In-Reply-To: <bug-12600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12600-70-pP3pCt1QKL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30153|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30161&action=edit [PASSED QA] Bug 12600: remove duplicate use statement from code A use C4::Charset was added deep in the body of the code we have already imported it at the top of the file (the by convention normal place) As use is executed at compile time specifying it in the code body does not serve a useful purpose and detracts from the readability of an already overly complex subroutine. Remove the superfluous statement also removed the tabs introduced to the surrounding lines by the same commit Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Search still works, no errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:38:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:38:01 +0000 Subject: [Koha-bugs] [Bug 7462] duplicate patron shows flags In-Reply-To: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7462-70-7HX67bJJtT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:38:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:38:04 +0000 Subject: [Koha-bugs] [Bug 7462] duplicate patron shows flags In-Reply-To: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7462-70-PVkIOsixWs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30154|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30162&action=edit [PASSED QA] Bug 7462 - duplicate patron shows flags When duplicating a patron the form fields for setting patron account flags and restrictions should be hidden as it is when adding a patron. This patch adds the correct logic to the template. To test, duplicate an existing patron: - Confirm that the "Patron account flags" and "Patron restrictions" sections are not visible. - Confirm that saving a duplicated patron works correctly. - Confirm that the edit and new patron entry forms are unaffected. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Works ok, all three points confirmed No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Works as described, small template change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:47:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:47:31 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-6lPAzO8hKq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Juhani, thx for the patch. :) Just a note: Sometimes the length of the generated password is minPasswordLength+1. It never seems to be shorter or longer and it happens before and after the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:48:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:48:50 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-IofPzfRMsI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30163&action=edit [PASSED QA] Bug 11888: Random password suggestion does not work twice This patch adds a simple ajax-call to pull a new suggested password from the same perl script. To test: 1) Search for a patron and select "Change password" from the moremember-view. 2) In the member-password-view, click on "Click to fill with a randomly generated suggestion". 3) Confirm that you get a new suggested password and click the same link again. 4) Note that you do not get another suggested password - nothing is happening. 5) Apply patch. 6) Repeat steps 1-3 and confirm that you can keep clicking for a new suggested password. Patch works as expected. Signed-off-by: Marc V?ron <veron at veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes all tests and QA script. Works as desribed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:51:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:51:03 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-g3BNn63wsk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 27 23:51:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 21:51:08 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-pdfTN8ey21@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30146|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:02:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:02:44 +0000 Subject: [Koha-bugs] [Bug 4013] road type missing on search results In-Reply-To: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4013-70-sz66jF5Xxs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm I think this isn't quite right. My AV ROADTYPE entry looks like this: STR Stra?e Stra?e The form allows me to select "Stra?e". So far so good. But then in the patron result list, STR is displayed. >From the old database update I think that displaying the code is wrong here, as it should be a migrated numeric(?) id for older installations. + my $av_added = $dbh->do(q| + INSERT INTO authorised_values(category, authorised_value, lib, lib_opac) + SELECT 'ROADTYPE', roadtypeid, road_type, road_type + FROM roadtype; + |); The patron detail page displays the description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:08:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:08:53 +0000 Subject: [Koha-bugs] [Bug 9221] contact note not showing In-Reply-To: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9221-70-TWxfhJYRKM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9221 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:08:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:08:56 +0000 Subject: [Koha-bugs] [Bug 9221] contact note not showing In-Reply-To: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9221-70-a1lfr5Q9nO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9221 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30107|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30164&action=edit [PASSED QA] Bug 9221 - contact note not showing The contents of the contact note field are not displayed on the patron detail page in the staff client. This patch corrects this. This patch also corrects the case of the "Contact note" label in the OPAC patron details form (Log in -> Your personal details). To test, apply the patch and edit a patron to add data to the contact note field. Save and view the detail page for that patron. The contents of the contact note field should appear under the alternate address data. In the OPAC the contact note field label should have correct capitalization. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:18:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:18:35 +0000 Subject: [Koha-bugs] [Bug 7237] duplicating patron not using patron's branch In-Reply-To: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7237-70-3rhUDpepCb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7237 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:18:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:18:38 +0000 Subject: [Koha-bugs] [Bug 7237] duplicating patron not using patron's branch In-Reply-To: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7237-70-RSfAQWlkmA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7237 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30109|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30165&action=edit [PASSED QA] Bug 7237 - duplicating patron not using patron's branch When duplicating a patron the original patron's library should be preselected. To test, apply the patch and choose a patron to duplicate, noting which library is set as their home library. Click the "Duplicate" button and cnofirm that the patron's library is preselected on the patron entry form. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Works as described, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:27:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:27:59 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-DHdkJkgOnN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30096|0 |1 is obsolete| | Attachment #30097|0 |1 is obsolete| | Attachment #30098|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30166&action=edit [PASSED QA] Bug 12445: Improving unit tests for C4::Suggestions.pm Now, the tests used 'is' instead of 'ok', the tests are wrapped in a transaction, adding tests for the routines NewSuggestion, GetSuggestion, ModSuggestion, GetSuggestionFromBiblionumber and GetInfoFromBiblionumber. The tests for the routines DelSuggestionsOlderThan, CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion and GetSuggestionByStatus will be arrived in another patch. Test plan: 1/ Execute the command : prove t/db_dependent/Suggestions.t 2/ The result has to be a success without warning or error : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=32, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.49 cusr 0.08 csys = 1.61 CPU) Result: PASS Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:27:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:27:56 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-ch3KNoeRa2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:29:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:29:09 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-ad6k18m9ji@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30167&action=edit [PASSED QA] Bug 12445: ading unit tests to test the routines : CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion, GetSuggestionByStatus These routines were not tested Test plan: 1/ Execute the command : prove t/db_dependent/Suggestions.t 2/ The result has to be a success without error or warning : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=89, 1 wallclock secs ( 0.05 usr 0.01 sys + 1.52 cusr 0.08 csys = 1.66 CPU) Result: PASS Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Test pass, no koha-qa errors But now there are 91! prove t/db_dependent/Suggestions.t t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.00 sys + 1.77 cusr 0.10 csys = 1.92 CPU) Result: PASS Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:29:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:29:22 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-PNgY9WZkVq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30168&action=edit [PASSED QA] Bug 12445 [QA Followup] - Clear issues table before clearing borrrowers table Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> All tests pass, even more now than before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:33:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:33:26 +0000 Subject: [Koha-bugs] [Bug 12570] Warnings in t/Biblio.t could be tested In-Reply-To: <bug-12570-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12570-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12570-70-FVhdKSC1uU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12570 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:39:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:39:03 +0000 Subject: [Koha-bugs] [Bug 12570] Warnings in t/Biblio.t could be tested In-Reply-To: <bug-12570-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12570-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12570-70-LdGgm88GvL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12570 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:39:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:39:05 +0000 Subject: [Koha-bugs] [Bug 12570] Warnings in t/Biblio.t could be tested In-Reply-To: <bug-12570-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12570-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12570-70-0iLvc79QHW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12570 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30150|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30169&action=edit [PASSED QA] Bug 12570: test for carped warnings in t/Biblio.t To test: - Run $ prove t/Biblio.t => Warnings printed to STDOUT - Apply patch - Run $ prove t/Biblio.t => No warnings Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> No more warnings. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:42:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:42:41 +0000 Subject: [Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC In-Reply-To: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12554-70-n1u725Mof5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:42:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:42:43 +0000 Subject: [Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC In-Reply-To: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12554-70-7zB9buYQxx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30152|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30170&action=edit [PASSED QA] Bug 12554: Fix GetMarcPrice for NORMARC When doing aquisitions and ordering from external z3950 targes, the item price is not inferred from the MARC record when the NORMARC framework is set. This patch makes GetMarcPrice treat NORMARC the same as MARC21. Test plan * Setup Koha with NORMARC framework * Add a norwegian z3950 search target (ex: z3950.bibsys.no:2100, database=BIBSYS) * Create a new basket, and add order to basket from external source * Search for a tile (ex: ISBN 8205341834) from the bibsys z3950 server * Click to order the title * Observe that vendor price is not set * Apply patch, repeat search for same book * Order, and observe the vendor price is filled in from the MARC record http://bugs.koha-community.org/show_bug.cgi?id=12554 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Works as described. No errors. Tested changing marcflavour syspref to NORMARC, and following test plan, bug exist and is fixed. Changed bug description on patch, too long :) Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Patch adds a check for NORMARC to provide the same functionality as for MARC21. No regressions found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 00:48:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 22:48:39 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-Wq6Ux5Rhgo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am sorry, but GetPendingIssues.t still fails for me: $ perl t/db_dependent/Members/GetPendingIssues.t 1..20 DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`items`, CONSTRAINT `items_ibfk_3` FOREIGN KEY (`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at t/db_dependent/Members/GetPendingIssues.t line 21. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`items`, CONSTRAINT `items_ibfk_3` FOREIGN KEY (`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at t/db_dependent/Members/GetPendingIssues.t line 21. # Looks like your test exited with 255 before it could output anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 01:01:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jul 2014 23:01:48 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: <bug-11230-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11230-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11230-70-CIR14yY4vj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 03:50:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 01:50:44 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12167-70-8OlStGI06a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 --- Comment #8 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30171&action=edit Bug 12167 - Invalid results check for opac_news test C4/NewsChannels.pm has a function GetNewsToDisplay at the end of the file. It returns an array reference (i.e. one result). t/db_dependent/NewsChannels.t has a test which expects two values. This is likely a cut and paste error on my part. Notice get_opac_news returns an array of two things. TEST PLAN --------- 1) prove -v t/db_dependent/NewsChannels.t -- magically the wrong condition still passes. 2) apply this first patch only. 3) prove -v t/db_dependent/NewsChannels.t -- notice the second result value is UNDEFINED. -- notice the first result is an array reference. -- and the last test passes, because unless somehow the array reference was less than 2, it will pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 03:50:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 01:50:52 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12167-70-giVsuzP7qg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27825|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30172&action=edit Bug 12167 - Bad expected results and condition check for GetNewsToDisplay This corrected the results expected to a single array reference. It then determines that it is defined and an array reference. And lastly, correct the logic that was supposed to check for valid results. TEST PLAN --------- 1) Apply patch 1 and 2. 2) prove -v t/db_dependent/NewsChannels.t -- all tests should pass -- note the test changes to verify correctly what should be tested for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 03:51:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 01:51:06 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12167-70-49pIhsFviV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27826|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30173&action=edit Bug 12167 - Clean up GetNewsToDisplay This bug started out as a result of busting while in transitions of MySQL were happening in Ubuntu. However, I figured this fix should remove backtick MySQLisms as per http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL6:_Backticks And clean up GetNewsToDisplay a bit. TEST PLAN --------- 1) News should function fine before applying any patches. 2) Apply all patches. 3) prove -v t/db_dependent/NewsChannels.t -- expecting all happy results. -- note the removal of backticks and the assumed typecasting of a timestamp to date. -- specified opac_news.timestamp to make sure that it would more likely parse as a fieldname and not as a keyword. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 03:55:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 01:55:19 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12167-70-Rv47qnMmm2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30171|0 |1 is obsolete| | --- Comment #11 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30174&action=edit Bug 12167 - Invalid results check for opac_news test C4/NewsChannels.pm has a function GetNewsToDisplay at the end of the file. It returns an array reference (i.e. one result). t/db_dependent/NewsChannels.t has a test which expects two values. This is likely a cut and paste error on my part. Notice get_opac_news returns an array of two things. TEST PLAN --------- 1) prove -v t/db_dependent/NewsChannels.t -- magically the wrong condition still passes. 2) apply this first patch only. 3) prove -v t/db_dependent/NewsChannels.t -- notice the second result value is UNDEFINED. -- notice the first result is an array reference. -- and the last test passes, because unless somehow the array reference was less than 2, it will pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 03:55:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 01:55:23 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12167-70-0DT7xsnWab@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30172|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30175&action=edit Bug 12167 - Bad expected results and condition check for GetNewsToDisplay This corrected the results expected to a single array reference. It then determines that it is defined and an array reference. And lastly, correct the logic that was supposed to check for valid results. TEST PLAN --------- 1) Apply patch 1 and 2. 2) prove -v t/db_dependent/NewsChannels.t -- all tests should pass -- note the test changes to verify correctly what should be tested for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 03:55:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 01:55:28 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12167-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12167-70-9zsD3XhSKQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30173|0 |1 is obsolete| | --- Comment #13 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30176&action=edit Bug 12167 - Clean up GetNewsToDisplay This bug started out as a result of busting while in transitions of MySQL were happening in Ubuntu. However, I figured this fix should remove backtick MySQLisms as per http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL6:_Backticks And clean up GetNewsToDisplay a bit. TEST PLAN --------- 1) News should function fine before applying any patches. 2) Apply all patches. 3) prove -v t/db_dependent/NewsChannels.t -- expecting all happy results. -- note the removal of backticks and the assumed typecasting of a timestamp to date. -- specified opac_news.timestamp to make sure that it would more likely parse as a fieldname and not as a keyword. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 05:54:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 03:54:12 +0000 Subject: [Koha-bugs] [Bug 12642] SMS.t requires a database In-Reply-To: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12642-70-mo3zSmBXQF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30076|0 |1 is obsolete| | --- Comment #5 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 30177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30177&action=edit Bug 12642: t/SMS.t should not be db dependent SMS.t should not dependent on the DB. Test plan: verify that prove t/SMS.t returns green even if the DB is not there. Signed-off-by: Robin Sheat <robin at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 05:54:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 03:54:43 +0000 Subject: [Koha-bugs] [Bug 12642] SMS.t requires a database In-Reply-To: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12642-70-N56X6KFZxk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Robin Sheat <robin at catalyst.net.nz> --- Looks good to me, and a better solution than mine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 06:06:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 04:06:38 +0000 Subject: [Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery In-Reply-To: <bug-12443-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12443-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12443-70-YAsf1tD1gX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443 --- Comment #19 from Robin Sheat <robin at catalyst.net.nz> --- FYI, it fails in my squeeze chroot, but it passes in testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 07:29:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 05:29:50 +0000 Subject: [Koha-bugs] [Bug 12657] PROG/CCSR deprecation: Remove hard-coded theme from debian/* scripts In-Reply-To: <bug-12657-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12657-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12657-70-y2RTK48tuh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12657 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 07:29:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 05:29:54 +0000 Subject: [Koha-bugs] [Bug 12657] PROG/CCSR deprecation: Remove hard-coded theme from debian/* scripts In-Reply-To: <bug-12657-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12657-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12657-70-9d5OREzUCO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12657 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30070|0 |1 is obsolete| | --- Comment #3 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 30178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30178&action=edit Bug 12657 - remove references to prog and ccsr from the packages To test: * Build a package and install it, and verify that there are no errors. * Play around with koha-translate, listing, adding, and removing languages. Note: one reference to prog and ccsr remains in koha-translate. This is to allow it to remove any pre-existing translations on an upgrade. Note 2: prog translations are still being installed, I think this is due to the underlying translation system doing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 07:58:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 05:58:23 +0000 Subject: [Koha-bugs] [Bug 12642] SMS.t requires a database In-Reply-To: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12642-70-6yYXDtbPws@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|chris at bigballofwax.co.nz |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:01:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:01:00 +0000 Subject: [Koha-bugs] [Bug 12642] SMS.t requires a database In-Reply-To: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12642-70-yfxOsjTfPQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:01:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:01:02 +0000 Subject: [Koha-bugs] [Bug 12642] SMS.t requires a database In-Reply-To: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12642-70-aynWTEswi1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30177|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30179&action=edit [PASSED QA] Bug 12642: t/SMS.t should not be db dependent SMS.t should not dependent on the DB. Test plan: verify that prove t/SMS.t returns green even if the DB is not there. Signed-off-by: Robin Sheat <robin at catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Turned off MySQL, tests still pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:09:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:09:08 +0000 Subject: [Koha-bugs] [Bug 12613] Remove CGI::scrolling_list from koha2marclinks.pl In-Reply-To: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12613-70-4cYJ4mHDzQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12613 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:09:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:09:12 +0000 Subject: [Koha-bugs] [Bug 12613] Remove CGI::scrolling_list from koha2marclinks.pl In-Reply-To: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12613-70-Oy7BgCndqX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12613 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30122|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30180&action=edit [PASSED QA] Bug 12613: Remove CGI::scrolling_list from koha2marclinks.pl This patch removes all (2) instances from koha2marclinks.pl. Also changes dropdowns width on mapping editor, from an ugly ragged right to a fixed width view. To test: 1. Apply the patch 2. Go to Administration > Koha to MARC mapping 3. Pulldown in this view has been replaced, check for regressions: change table type and press Ok, verify you get Koha fields and tag/subfield appropriate for each table. 4. Now press 'Edit' on any field, go into mapping editor 5. Check that all pulldowns show tag/subtags relevant for each group ( 000s ... 900s ) 6. Check that current mapping is displayed correctly 7. Check for regressions: unmap, remap, press Ok, verify, change again. 8. If you can, check display of mapping editor on several browsers, just in case. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> I have tested with Firefox/Iceweasel only. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes all tests and QA script. Also tested in Chromium. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:13:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:13:59 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-UFhXRGnHYl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:14:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:14:02 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-fRvl66A5fJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30008|0 |1 is obsolete| | Attachment #30085|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30181&action=edit [PASSED QA] Bug 12568 - Improve visibility of successful renewal via opac Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully. Test Plan: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table Signed-off-by: Cathi Wiggins <cwiggins at ci.arcadia.ca.us> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes tests and QA script. Makes successful renewals more visible to the user in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:14:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:14:16 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-VamS1Qvbi2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30182&action=edit [PASSED QA] Bug 12568 [QA Followup] - Use ':' as separator instead of '|' Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:16:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:16:44 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7560-70-NzqXEFZ1nc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:17:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:17:29 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7560-70-q7axNIe6g7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:26:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:26:39 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-IWGWHeIQ49@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #56 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- There are 2 small things: - we might want to rename "Itemtypes" as it could also be locations or collections for a library. But I am not sure what would be a better name :( - the font size and script of the new plugin created pull down seems a bit off and some styling to make it fit better into the page would be nice. Overall this works as it should and I think those 2 small things could be resolved in a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:31:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:31:01 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-9FOTOheq0f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:31:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:31:05 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-NJolo36KrI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29914|0 |1 is obsolete| | Attachment #29915|0 |1 is obsolete| | Attachment #29945|0 |1 is obsolete| | Attachment #29946|0 |1 is obsolete| | --- Comment #57 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30183&action=edit [PASSED QA] Bug 9043: [SIGNED OFF] Syspref improvement: add new type "multiple" This patch adds a new type "multiple" for syspref. This new type allows to select several values for one syspref. Signed-off-by: Koha Team Lyon 3 <koha at univ-lyon3.fr> Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:31:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:31:20 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-Scb0K4BrAZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #58 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30184&action=edit [PASSED QA] Bug 9043: [SIGNED-OFF] Add the dropdown check list jquery plugin Signed-off-by: Koha Team Lyon 3 <koha at univ-lyon3.fr> Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:31:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:31:34 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-7RTURl21xQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #59 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30185&action=edit [PASSED QA] Bug 9043: [SIGNED-OFF] Changes to the advanced search page This patch adds 2 new sysprefs: OpacAdvSearchOptions and OpacAdvSearchMoreOptions. These sysprefs are multivalued and you can add or remove some elements on the adv search page. This patch allows to display/hide some entries in the advanced search page at the OPAC. On this way, it is possible to configure the search options to display. Test plan: 1/ Fill OpacAdvSearchOptions with Item types and Languages. Fill OpacAdvSearchMoreOptions with Item types, Languages and Location. On the advanced search page, verify the Location is only displayed for the "More options" view. 2/ Try different settings for these prefs 3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that the "More options" does not displayed additional options. 4/ Remove all entries for the OpacAdvSearchOptions and verify that the "normal view" does not displayed any options. Note that this patch only affects the bootstrap theme. Signed-off-by: Koha Team Lyon 3 <koha at univ-lyon3.fr> Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:32:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:32:09 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-gnM3OhGYOp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #60 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30186&action=edit [PASSED QA] Bug 9043: Add the dropdown check list jquery plugin in the license list. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes all tests and QA scipt. Note: - We might want to rename "Itemtypes" as it could also be locations or collections for a library. But I am not sure what would be a better name. - The font size and script of the new plugin created pull down seems a bit off and some styling to make it fit better into the page would be nice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:38:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:38:15 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-4bvmDUryzm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 --- Comment #10 from Juhani Sepp?l? <jseppal at student.uef.fi> --- (In reply to Katrin Fischer from comment #8) > Hi Juhani, thx for the patch. :) > > Just a note: Sometimes the length of the generated password is > minPasswordLength+1. It never seems to be shorter or longer and it happens > before and after the patch. Hi, I noticed this behaviour as well while looking at creating this small fix. As mentioned here: Bug 12617 (shameless ad), we've had some discussion at our library about being able to have more configuration choices with regards to patron passwords and I've done some preliminary work on changing the current custom password generation to use a cpan library for easy configurability and so forth. We also have a damning limitation with some of the appliances used by customers where the devices only have numeric keys for password input... Things I'm looking at: - Making generated password complexity configurable - Allow admins to enforce a separate password policy for regular patrons and employees (for example) I would be interested in hearing any thoughts related to this and whether any of this would be useful in the community (we have some specific requirements here after all). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 08:51:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 06:51:09 +0000 Subject: [Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty In-Reply-To: <bug-12617-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12617-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12617-70-S3lMTjiVfw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 09:18:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 07:18:25 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-7B0fqHIfQp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 09:24:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 07:24:43 +0000 Subject: [Koha-bugs] [Bug 10904] would like to limit patron update request management by branch In-Reply-To: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10904-70-alSJxATEHa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I'm sort of in agreement with both sides here... I've been thinking for a while that the IndependantBranches syspref should really be a granular preference, probably with it's own tab under the prefs pages as it could well grow rather quickly! A heirachical structure much like the current permissions system would make great sense. However, I also agree with Galens defaults and the idea that there should be some coding guidelines to enforce such a standard structure, so long as within that dropdown he mentions there's the top 'option', not default, but first selectable option is to allow 'no filtering', i.e. 'All Libraries' to allow 'pro users' to still 'get things done' quickly. Just my two cents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 09:27:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 07:27:48 +0000 Subject: [Koha-bugs] [Bug 2237] Auto-populate 'userid' and 'password' fields with other field values, when adding user In-Reply-To: <bug-2237-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2237-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2237-70-Z4TMFiKoPj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2237 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 09:34:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 07:34:21 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-zDAk85hyXt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30118|0 |1 is obsolete| | --- Comment #12 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 30187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30187&action=edit Bug 12457: Allow UT on a non empty database Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 09:34:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 07:34:47 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-n6UBnlnVEs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 09:36:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 07:36:11 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-EvFv8PoLaT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Jacek Ablewicz <abl at biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 09:58:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 07:58:21 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8148-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8148-70-IbPrqwn8EX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 --- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Apologies Tomas, I should have noticed the lack of tests and pushed back before it hit your pile. The patches have been around for a while now, and I only re-checked the 'new stuff' when I did QA.. Woops -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 10:40:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 08:40:09 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-QfsPzckTkv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12633 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 10:40:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 08:40:09 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12633-70-6gqZAwMi2r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12457 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 10:40:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 08:40:57 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: <bug-7021-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7021-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7021-70-sypsWJPOaA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #22 from mathieu saby <mathsabypro at gmail.com> --- Hello Olli-Anti Bug 11230 has been pushed, so if you still want to work on that, could you - assign 7021 to yourself - refactor your patch - change the status to need signoff? I will have some time to sign it before september. Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 10:41:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 08:41:11 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: <bug-7021-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7021-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7021-70-Rowdr6i0jG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 mathieu saby <mathsabypro at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11230 | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 10:41:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 08:41:11 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: <bug-11230-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11230-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11230-70-WFq0KgdhvY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 mathieu saby <mathsabypro at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7021 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 10:42:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 08:42:38 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: <bug-7021-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7021-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7021-70-bL5F9Cmv7H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #23 from mathieu saby <mathsabypro at gmail.com> --- (also, could you provide a test plan for your patch?) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 11:20:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 09:20:56 +0000 Subject: [Koha-bugs] [Bug 12626] SQLHelper replacement - C4::Acquisition In-Reply-To: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12626-70-JxZJOxGINJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12626 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 11:20:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 09:20:58 +0000 Subject: [Koha-bugs] [Bug 12626] SQLHelper replacement - C4::Acquisition In-Reply-To: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12626-70-JbfE9ka75r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12626 --- Comment #4 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 30188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30188&action=edit Bug 12626: SQLHelper replacement - C4::Acquisition With this patch, the subroutine NewOrder uses DBIx::Class instead of C4::SQLHelper. Test plan: 1) Apply the patch 2) Execute the unit tests by launching : prove t/db_dependent/Acquisition.t 3) The result has to be a success without error or warning : t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=79, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.80 cusr 0.09 csys = 1.94 CPU) Result: PASS 4) Log in the koha intranet and create a new order in the acquition module 5) The creation has to be a success Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 11:21:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 09:21:31 +0000 Subject: [Koha-bugs] [Bug 12626] SQLHelper replacement - C4::Acquisition In-Reply-To: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12626-70-08Shv1p9Ot@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12626 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30093|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 12:46:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 10:46:57 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-JO5jJIqfy1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29812|0 |1 is obsolete| | Attachment #29813|0 |1 is obsolete| | Attachment #29815|0 |1 is obsolete| | Attachment #29816|0 |1 is obsolete| | Attachment #29817|0 |1 is obsolete| | Attachment #29818|0 |1 is obsolete| | --- Comment #57 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30189&action=edit Bug 6536: Dbrev for Z3950 search improvements Adjusts table z3950servers: Drops unused columns icon, description and position. Moves id column to first position. Renames name to servername, and type to servertype. (This is not only more clear but may eliminate some problems too with DBIx.) Changes recordtype from varchar(45) to enumeration with two members. [The upgrade replaces unknown record types with biblio, although it is very unlikely to find such records.] Adds SRU as servertype enumeration member. Removes opensearch, since it is not used/supported. [The upgrade replaces unknown server types with zed (z3950) (in exceptional cases).] Adds new columns: sru_options, sru_fields, add_xslt. Test plan: Run database update via webinstaller. Check your z3950servers table. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 12:47:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 10:47:02 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-0sQOSZEw8i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #58 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30190&action=edit Bug 6536: Update DBIx schema of z3950servers for testing This patch adjusts the DBIx schema file for z3950servers table. This can be used for testing this set of patches. When the report is pushed, the RM should update the DBIx schema. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 12:47:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 10:47:07 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-PgnLVyLIuV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #59 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30191&action=edit Bug 6536: SRU servers administration This patch makes adjustments in admin/z3950servers in order to insert, edit and delete SRU server records. Test plan: Add, edit, copy and delete SRU server. Check if adding, editing, copying and deleting Z3950 servers still works. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 12:47:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 10:47:11 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-bV45OCgrXe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #60 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30192&action=edit Bug 6536: Adjustments for servername and servertype Replaces name by servername, type by servertype for running Z3950 search. Limit search scripts to zed (z3950) servers until sru is supported. Test plan: Perform a Z3950 search in Cataloguing and Acquisition. Verify that it still works as it did. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 12:47:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 10:47:16 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-SUabyKkFPl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #61 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30193&action=edit Bug 6536: Include SRU searching in Breeding.pm This patch makes it possible to include SRU servers in Z3950 search. It adjusts the Z3950Search routine in Breeding module. It also replaces SQL code with DBIx statements in Breeding.pm/Z3950Search and the associated scripts z3950search.pl in cataloguing and acqui. Test plan: Verify if a normal Z3950 search still works in cataloging/acqui. Add a SRU target. (You could just use Koha's port 9998.) Define sru_options like sru=get. Use that target in a Z3950 search in cataloging and acqui. (Import.) Test sru_fields translation by comparing search results between various settings for some of the fields. For instance, leave title empty and after that set it to the title field of your SRU target. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 12:47:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 10:47:21 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-vzVH68p04g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #62 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30194&action=edit Bug 6536: Add XSLT transformation on Z3950 search results Use the stylesheets listed in field add_xslt of z3950servers to transform search results of Z3950/SRU search. Additionally, the template has been changed to make more error messages (or warnings) visible when displaying results. Until now, error message were shown in the results table and when connection errors occurred, no results were displayed at all. Test plan: Create some stylesheets (or see the sample patch on bug 6536). Add these stylesheets to some Z3950/SRU servers. Do Z3950 search and verify the transformations. Do a search with 2 targets; make one target fail (by manipulating its server data). Do you see the connection error and the results for the other target? Generate a XSLT error by modifying one stylesheet. Check search results. You should see warnings. Signed-off-by: Giuseppe Angilella <giuseppe.angilella at ct.infn.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 12:48:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 10:48:13 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-0fKoReidqr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29819|Bug 6536: Two simple test |[DO_NOT_PUSH] Bug 6536: Two description|XSLT files |simple test XSLT files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 12:54:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 10:54:23 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6536-70-t500lbuemN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #63 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Rebased some patches in this series. The order has been slightly adjusted. The first two patches (in the current order) only add new files and are on top now. This should not do any harm imho.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 13:33:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 11:33:29 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-PQr2WQKLgc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om Depends on| |11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 13:33:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 11:33:29 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-Nvjnwwyr0U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11844 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 13:58:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 11:58:34 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: <bug-11319-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11319-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11319-70-8vKNIM32YV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #31 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Planning QA for this week -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 13:59:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 11:59:54 +0000 Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC In-Reply-To: <bug-11847-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11847-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11847-70-LX3ldQ1kyx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> --- This needs some work as bug 11169 do not introduce the new tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 13:59:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 11:59:57 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: <bug-11319-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11319-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11319-70-9ibD40Ufoz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #32 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Planning to QA this after 11319 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 14:00:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 12:00:27 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: <bug-11319-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11319-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11319-70-z9XZWrW2Cu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #33 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to M. de Rooy from comment #32) > Planning to QA this after 11319 Somehow a backspace got in between :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 14:00:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 12:00:51 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: <bug-11413-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11413-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11413-70-vHSmpt46qM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #25 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Planning to QA this after 11319 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 14:26:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 12:26:09 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11425-70-NeG9VvY8iZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27975|0 |1 is obsolete| | --- Comment #29 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30195&action=edit Bug 11425: Add item search form in staff interface Item search is available at catalogue/itemsearch.pl (link is in catalogue/search.pl) It only uses SQL (not Zebra) * Use DataTables and server-side processing to be able to filter on individual columns after the first search is done. * Allow to export results in CSV * With Javascript disabled, search form still works (and CSV export too) There is the possibility to define "Custom search fields" in a new admin page admin/items_search_fields.pl (link is in admin/admin-home.pl) A custom item search field is defined by: * a name: its unique identifier * a label: the text displayed to the user * a MARC field/subfield: the field/subfield to query (it uses ExtractValue) * an authorised values list (optional): if defined the list is displayed in the search form New Perl dependency: Template::Plugin::JSON::Escape Test plan: 1/ Apply the patch and run updatedatabase.pl 2/ Go to advanced search (staff interface), then click on "Go to item search" 3/ Play with the search form! :) In the 3rd fieldset you can add as many fields as you want and combine them with boolean operators (AND, OR). You can use SQL jokers characters (%, _) You can output to screen (in a DataTables table) or to a CSV file. 4/ In the DataTables table, play with filters and try sorting columns. 5/ Disable Javascript (with Firefox: extensions NoScript or YesScript, or in about:config 'javascript.enabled' = false 6/ Reload the search page and do some searches on screen output. (there is no sorting or filtering features, but there is still pagination) 7/ Try again CSV output. 8/ You can re-enable Javascript. 9/ Go to Administration > Items search fields 10/ Add a new field. Example for title (in UNIMARC): Name: title Label: Title MARC field: 200 MARC subfield: a Authorised values category: None (add another field with an authorised values category to see the difference). 11/ As you are there try to update and delete some fields. 12/ Go back to items search form. You can see in the 3rd fieldset that your fields have appeared in the selects. 13/ Try searching on them. 14/ I think you're done :) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Work as described. Good new option. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 14:26:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 12:26:15 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11425-70-O5hlHWwYWR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27976|0 |1 is obsolete| | --- Comment #30 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30196&action=edit Bug 11425: Add unit tests package Koha::Item::Search::Field function C4::SQLHelper::GetColumns function C4::Items::SearchItems Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Tests run without error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 14:26:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 12:26:22 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11425-70-3fpP6etMIN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27977|0 |1 is obsolete| | --- Comment #31 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30197&action=edit Bug 11425: Add filter on items.notforloan column and display the 'Processing ...' box when datatables is loading new data. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Nice box -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 14:26:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 12:26:33 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11425-70-GBsH8xkoad@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27978|0 |1 is obsolete| | --- Comment #32 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30198&action=edit Bug 11425: Get column names using DBIX Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 14:26:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 12:26:41 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11425-70-x1dYwAl1OI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27979|0 |1 is obsolete| | --- Comment #33 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30199&action=edit Bug 11425: QA fixes - Reword 'joker' to 'wildcard' - Explain what wildcards do - Reword 'Modify' to 'Edit' Also fix jQuery plugin columnFilter path Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 14:26:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 12:26:52 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11425-70-Q53aqSxwya@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29965|0 |1 is obsolete| | --- Comment #34 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30200&action=edit Bug 11425: Display location label instead of code Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Minor conflicts solved Last three patches signed No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 14:27:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 12:27:42 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11425-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11425-70-A2N6C97XNC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 14:31:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 12:31:15 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11385-70-03kPWXRjt3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 14:31:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 12:31:17 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11385-70-IQ7rG5oHEv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 --- Comment #1 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 30201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30201&action=edit Bug 11385: SQLHelper removed This patch removes the SQLHelper module, which has been replaced by DBIx::Class. Test plan : 1) Apply the patchs : - Contract : 12493 (UT), 12487 - Borrower::Modifications : 12623 - Acquisition : 12626 - Suggestions : 12445 (UT), 12627 - Members : 12457(UT), 12633 2) Verify there are no uses of SQLHelper with : git grep "SQLHelper" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:10:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:10:46 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-gHBtaIxpcG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29134|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30202&action=edit Bug 9000 [1] - Update rss.pl to use Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:10:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:10:43 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-ql2XoZG4wL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:10:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:10:58 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-9FdhrlArIA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30203&action=edit Bug 9000 [2] - Update included examples -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:11:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:11:01 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-VxM6ivZS26@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30204&action=edit Bug 9000 [3] - Change conf key from tmpl to template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:12:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:12:29 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-MhJbiWBlBQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30205&action=edit Bug 9000 [4] - Update to GPL v3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:13:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:13:49 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-IPXSeZyFnj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30204|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30206&action=edit Bug 9000 [3] - Change conf key from tmpl to template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:13:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:13:57 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-uJ2kf2hcSe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30205|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30207&action=edit Bug 9000 [4] - Update to GPL v3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:15:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:15:50 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-P8rB28WXSG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:17:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:17:43 +0000 Subject: [Koha-bugs] [Bug 12665] New: style ids on self checkout Message-ID: <bug-12665-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12665 Bug ID: 12665 Summary: style ids on self checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be great if you could style the self checkout page different from the main opac: cgi-bin/koha/sco/sco-main.pl A simple body id tag would probably do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:18:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:18:07 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: <bug-11887-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11887-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11887-70-swvmhrSd9L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30009|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30208&action=edit Bug 11887 - Add script for collections agency reports Some libraries use collections agencies such as Unique Management Services to collection large unpaid balances owed to the library. It would be helpful if Koha had a standard script to generate these reports, rather than forcing each library to create their own solution. This script is written following the guidelines for Unique Management Systems. However, the reports it outputs should be useable by any collections agency. Test Plan: 1) Create the four required patron attributes 2) Create a patron who owes more then 5.00 in fees 3) Run the submission report account_collections.pl -r submission \ -mb 3 -bd $yesterday_iso -ed $tomorrow_iso -f 10 \ -ft $fee_type -fd $fee_desc -c $can-collect-attribute-code \ -i $in-collections-attribute-code -l $last-updated-attribute-code \ -p previous-balance-attribute-code 4) Note the patron is now marked as in collections and has had the collections fee of 10.00 applied 5) Add a new fee to the patron's account 6) Run the update report with the same additional parameters 7) Verify the csv file generated contains that patron 8) Run the sync report with the same additional parameters 9) Note the csv file generated contains that patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:33:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:33:11 +0000 Subject: [Koha-bugs] [Bug 12665] style ids on self checkout In-Reply-To: <bug-12665-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12665-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12665-70-dWtHW2qr4m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12665 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Nevermind, there is a separate css field in the db for this - I knew that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:39:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:39:45 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-6rk8mFuboo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 --- Comment #10 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- Hi, About OPACBaseURL, as already stated in bug 7770 : To my opinion, http:// should not be added automatically, for one simple reason: it just might not be http:// ! OPAC might be using https, and in that case, automatic prefill would be wrong. When talking about CAS, some CAS servers won't allow authentication for http services, only for https one, so we have to be able to use https for the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:49:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:49:29 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-7EV1cDaLbv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- OpacBaseUrl is kind of an annoying system preference - lots of bugs about it. If the CAS code only allows for https://, maybe it could be part of the CAS code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 16:49:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 14:49:51 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10402-70-1GqVa55eWM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Paola Rossi <paola.rossi at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #77 from Paola Rossi <paola.rossi at cineca.it> --- Thanks, Jared. I've tried to apply the patches against master 3.17.00.010. Applying: Bug 10402: Use an object for contacts Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Auto-merging acqui/uncertainprice.pl Auto-merging acqui/supplier.pl So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:03:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:03:27 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10402-70-yxIiaPB8NK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29600|0 |1 is obsolete| | --- Comment #78 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 30209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30209&action=edit Bug 10402: Use an object for contacts In preparation for adding the ability to handle multiple contacts, this patch moves booksellers' contacts into their own class, C4::Bookseller::Contact. To test: 1) Apply patch. 2) Run database update. 3) Edit a bookseller, making sure to add a contact. 4) View the bookseller's information, making sure the contact information is there. 5) Run the unit test: > prove t/db_dependent/Bookseller.t Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:03:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:03:41 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10402-70-SGZ14FIWPS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29601|0 |1 is obsolete| | --- Comment #79 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 30210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30210&action=edit Bug 10402: Move contacts to separate table This patch normalizes the data structures used for bookseller contacts. To test: 1) Repeat tests described on previous patch. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:03:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:03:52 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10402-70-gXUjEQsJpJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29602|0 |1 is obsolete| | --- Comment #80 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 30211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30211&action=edit Bug 10402: Add ability to enter multiple contacts Some vendors may have more than one contact. For example, a technical contact and a billing contact, or a contact for journals and a contact for monographs. Rather than require that each contact be either made into a separate vendor or recorded somewhere outside of Koha, it would be really useful of Koha had the ability to add multiple additional contacts to vendors in the Acquisitions module. To test: 1) Apply patch. 2) Edit a bookseller, making sure to add a contact. 3) View the bookseller's information, making sure the contact information is there. 4) Run the unit test: > prove t/db_dependent/Bookseller.t 5) Add multiple contacts to a vendor, see that they show up. 6) Delete one contact from a vendor with multiple contacts, see that the result is correct. 7) Sign off. Note: This test plan can supersede that on the previous two patches, as all functionality of the previous two patches is required by this one. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:04:03 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10402-70-oeS8NI9KAd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29603|0 |1 is obsolete| | --- Comment #81 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 30212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30212&action=edit Bug 10402 [Template follow-up] Add multiple contacts for vendors This template-only follow-up tweaks the button labels and restructures the vendor view layout a little bit to make it more amenable to multiple contacts: - Add spaces after button icons - Change "Add contact" to "Add another contact" in hopes of making it less ambiguous whether clicking it will submit the whole form. - Eliminate duplicate headers on the vendor view page by making the contact name the subheading for each individual contact. To test, view details for vendors with one or more contacts, and try editing to add additional contacts. Everything should look good and work correctly. Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:04:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:04:26 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10402-70-Nw2GvwlHh4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:04:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:04:28 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10402-70-hqIRfizffO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29761|0 |1 is obsolete| | --- Comment #82 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 30213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30213&action=edit Bug 10402 follow-up: choose contacts for claims This patch makes it possible to choose a particular contact for acquisitions and serials claims. To test: 1) Select a contact to use for claiming late orders and a contact to use for claiming late issues. 2) Send a claim for a late order and a claim for a late issue. 3) Note that the claims went out to the proper people. 4) Run the unit test with: > prove t/db_dependent/Letters.t 5) Sign off. Note: the claim messages are recorded in the logs in the *Acquisitions* module, not the Letters module as you might expect This patch also fixes several perlcritic violations and centralizes contact-related unit testing in Bookseller.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:18:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:18:53 +0000 Subject: [Koha-bugs] [Bug 12432] Saved reports tabs not working In-Reply-To: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12432-70-K0FcthLb50@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:26:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:26:59 +0000 Subject: [Koha-bugs] [Bug 12432] Saved reports tabs not working In-Reply-To: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12432-70-BMhaO82wED@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:27:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:27:01 +0000 Subject: [Koha-bugs] [Bug 12432] Saved reports tabs not working In-Reply-To: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12432-70-suB33vrAHk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30214&action=edit Bug 12432 - Saved reports tabs not working In release 3.14.05.000 the tabs on the Saved Reports page worked correctly but after upgrading to 3.16.00.000 the tabs stop working. Visually the tabs change but the table of reports is not filtered. There are no errors reported in the browser console. Test Plan: 1) Attempt to filter saved reports by group tabs 2) Note no matter the tab you select, all reports appear 3) Apply this patch 4) Repeat step 1 5) Note the reports are now filtered correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:28:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:28:03 +0000 Subject: [Koha-bugs] [Bug 12432] Saved reports tabs not working In-Reply-To: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12432-70-T1MJPKmr8I@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All Version|unspecified |master OS|Windows |All -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:28:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:28:13 +0000 Subject: [Koha-bugs] [Bug 12432] Saved reports tabs not working In-Reply-To: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12432-70-g07FyMRUzj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:29:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:29:17 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-5upXM2j7uQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Cheers for this Kyle, I've raised it with our guys to test and go forth and sign-off. Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:35:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:35:27 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11126-70-kq44pGA7F1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28181|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30215&action=edit Bug 11126 - Make the holds system optionally give precedence to local holds This feature will allow libraries to specify that, when an item is returned, a local hold may be given priority for fulfillment even though it is of lower priority in the list of unfilled holds. This feature has three settings: * LocalHoldsPriority, which enables the feature * LocalHoldsPriorityPatronControl, which selects for either tha patron's home library, or the patron's pickup library for the hold * LocalHoldsPriorityItemControl, which selects for either the item's holding library, or home library. So, this feature can "give priority for filling holds to patrons whose (home library|pickup library) matches the item's (home library|holding library)" Test Plan: 1) Apply this patch 2) Run t/db_dependent/Holds/LocalHoldsPriority.t Signed-off-by: Joel Sasse <jsasse at plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:35:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:35:36 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11126-70-pX5j3gVDfc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28182|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30216&action=edit Bug 11126 [QA Followup] - Make reserves returned by _Findgroupreserve sorted by priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:40:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:40:25 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: <bug-12194-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12194-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12194-70-M0XUoYfcNj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 --- Comment #1 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 30217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30217&action=edit Bug 12194 - add more tests for pdf creation When run with KEEP_PDF enviroment variable it will keep test.pdf for manual inspection. This can be used to verify that ttf font configuration is complete like: KEEP_PDF=1 KOHA_CONF=/etc/koha/sites/srvgit/koha-conf.xml prove t/Creators.t sample of utf-8 text, font name and type will be on bottom of second page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:40:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:40:59 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: <bug-12194-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12194-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12194-70-t34hkBtqXq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |dpavlin at rot13.org |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:42:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:42:35 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: <bug-12194-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12194-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12194-70-rTT5G6dsyU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Dobrica Pavlinusic <dpavlin at rot13.org> --- I can't reproduce this. I can only suspect that you are really missing all ttf definitions in koha-conf.xml, so I expanded this test to verify that all fonts are available on system. Can you give it a try? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:45:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:45:25 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7710-70-czTEE03Am3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #63 from Kyle M Hall <kyle at bywatersolutions.com> --- That is correct, multiple bib-level holds, or multiple item-level holds on different items, but not multiple item-level holds on the same item. (In reply to David Cook from comment #58) > One quick question... > > The premise that that this patch will allow multiple holds per record per > borrower. > > Does that mean that they can place multiple item-level holds or multiple > bib-level holds or both? > > I assume it would just be multiple item-level holds, but I figured I would > ask anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:45:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:45:41 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7710-70-qqL0QSQfWw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:45:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:45:45 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7710-70-O7rk36q28r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27429|0 |1 is obsolete| | --- Comment #64 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30218&action=edit Bug 7710 - multiple holds per title Adds the ability to allow multiple holds on the same record for the same borrower. Adds new system preference MaxHoldsPerRecord, which controls how many holds one person can have on items for the same record. Test Plan: 1) Apply patch for Bug 9394 2) Apply this patch 3) Run updatedatabase.pl 4) Attempt to place 2 holds for the same patron on the same record, you should not be able to ( default is 1 per record ) 5) Set MaxHoldsPerRecord to 3 6) Attempt to place multiple holds for one patron on one record, you should be able to place 3 holds for one patron on a given record. A 4th hold should result in a message stating the patron has placed the max number of holds allowed on this record. Signed-off-by: Maxime Pelletier <maxime.pelletier at libeo.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:54:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:54:43 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-mP0Kr7W2Sp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Hmm.. bug 8952 and bug 11575, both pushed the master are doing 'stuff' to the prefix in opacbaseurl.. I think it worth looking at those here. For Shibboleth, it is recognised practice to throw away not https requests at the IdP end for security reasons.. so for this reason I've forced https in my patches there.. I don't know if that's the case for CAS but maybe worth considering. As for the bigger problem.. the two bugs above seem to come close at least to fixing that mentioned in bug 7770. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 17:59:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 15:59:01 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-APgW2LMstI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #61 from Owen Leonard <oleonard at myacpl.org> --- I'm concerned about adding a jQuery plugin dependency that comes with this disclaimer: "DDCL IS NO LONGER ACTIVELY SUPPORTED It has not been rebuilt in over 2 years and is stuck on jQuery release 1.7. However, if anybody feels they can devote time to maintaining and developing DDCL, then feel free to get in contact." We are still in the process of updating or replacing existing plugins which block an upgrade of jQuery in Koha. I don't think it's a good idea to add another one. Are there any alternatives we could consider? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 18:01:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 16:01:12 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-lDIaSzeCfY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30202|0 |1 is obsolete| | --- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30219&action=edit [SIGNED-OFF] Bug 9000 [1] - Update rss.pl to use Template Toolkit Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Tested using script with sample conf files RSS feeds generated are 'well formed' xml Some koha-qa errors fixed in followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 18:01:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 16:01:20 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-6bC4eB1UCP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30203|0 |1 is obsolete| | --- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30220&action=edit [SIGNED-OFF] Bug 9000 [2] - Update included examples Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 18:01:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 16:01:29 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-0FdWmkjcwY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30206|0 |1 is obsolete| | --- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30221&action=edit [SIGNED-OFF] Bug 9000 [3] - Change conf key from tmpl to template Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 18:01:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 16:01:38 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-R0Mh1JmHVG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30207|0 |1 is obsolete| | --- Comment #22 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30222&action=edit [SIGNED-OFF] Bug 9000 [4] - Update to GPL v3 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 18:02:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 16:02:12 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-vz3dsrSAFY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #23 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30223&action=edit Bug 9000: Followup to fix tabs & closing TT directive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 18:02:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 16:02:40 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-8rv3q2riUP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 18:08:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 16:08:01 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-oFNnaH4uk6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 18:08:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 16:08:19 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-UiKC6paN0e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 18:19:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 16:19:38 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-XjHmqUgEfn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 18:19:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 16:19:40 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-oBsVOVE7Bd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30224&action=edit Bug 12597 - Give better visual indication of currently-selected language in the staff client There is currently no visual feedback to the user reflecting which of multiple installed translations is currently selected. I think some necessary styling didn't make it into the conversion to Bootstrap menus. This patch attempts to improve things. Most of the changes are to bring back the previous style of highlighting the currently selected language. A new change is the addition of the sub-language code to the display of the menu label if one of that menu item's sub-languages is selected. This patch also removes some obsolete CSS which referred to the old menu system. To test, apply the patch and install or update multiple languages, including at least two sub-languages. In my test I used en, en-GB and de-DE. Clear your browser cache if necessary. Enable all these languages and test the functionality of the language selection menu in the footer. - Non-enabled languages should appear as non-bold links. - When a single language (with no sub-languages) is enabled it should appear as bold text. - When one of multiple sub-languages is enabled that selection in the pop-up menu should appear as bold text. The menu label should show in bold the language code of the selected sub-language. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 18:25:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 16:25:38 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: <bug-12194-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12194-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12194-70-Zjd6KPrMfS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 --- Comment #3 from Dobrica Pavlinusic <dpavlin at rot13.org> --- After reading comments on bug 8375, I see what the problem is, so I will prepare patch for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 18:43:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 16:43:05 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12529-70-uQDFE5OJJj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29507|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30225&action=edit Bug 12529: Add a syspref to make overdue notices respect holidays Test Plan Set up some overdue triggers, for example 5,10,15 Set up some holidays Create some items that are past due (one due 5 days, 10 days ago etc) Run the overdue notices script (misc/cronjobs/overdue_notices.pl) Notice holidays are ignored Apply the patch, Switch the OverdueNoticeCalendar syspref to Use calendar Run the overdue notices again Notice holidays are now taken into account Sponsored-by: BSZ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 19:14:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 17:14:53 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12529-70-kyrvwuqmvc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30225|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30226&action=edit Bug 12529: Add a syspref to make overdue notices respect holidays Test Plan Set up some overdue triggers, for example 5,10,15 Set up some holidays Create some items that are past due (one due 5 days, 10 days ago etc) Run the overdue notices script (misc/cronjobs/overdue_notices.pl) Notice holidays are ignored Apply the patch, Switch the OverdueNoticeCalendar syspref to Use calendar Run the overdue notices again Notice holidays are now taken into account Sponsored-by: BSZ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 19:15:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 17:15:03 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12529-70-vMbrDUP3js@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30227&action=edit Bug 12529 [QA Followup] - Remove trailing whitespace -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 20:10:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 18:10:05 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-o7JrzeWnub@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #62 from Owen Leonard <oleonard at myacpl.org> --- I haven't tested it but this looks interesting: http://wenzhixin.net.cn/p/multiple-select/docs/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 20:29:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 18:29:27 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: <bug-11703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11703-70-x3CLwv5rEU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29472|0 |1 is obsolete| | Attachment #29473|0 |1 is obsolete| | Attachment #29474|0 |1 is obsolete| | Attachment #29475|0 |1 is obsolete| | Attachment #29476|0 |1 is obsolete| | Attachment #29477|0 |1 is obsolete| | Attachment #29478|0 |1 is obsolete| | Attachment #29479|0 |1 is obsolete| | Attachment #29480|0 |1 is obsolete| | Attachment #29493|0 |1 is obsolete| | --- Comment #183 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30228&action=edit Bug 11703 - Convert checkouts table to ajax datatable [3.16.x] When a patron has many checked out items, circulation.pl can take a very long time to load ( on the order of minutes in some cases ). This is primarily due to the processing of the previous checkouts list. If we convert to this table to a datatable that fetches its data via ajax, we can make circulation.pl far more responsive. The same should be done with relative's checkouts as well. Test Plan: 1) Apply this patch 2) Observe that the checkouts and relatives' checkouts tables are now loaded asynchronously 3) Observe and verify the renew and return actions are now ajax based and function in a manner equivilent to how they used to. This bug had quite a few followups, so I squashed all of them into one change so that code is easier to follow. Original commit messages are below: Bug 11703 - Use the ajax datatables on patron details page Bug 11703 - Convert holds tables to ajax datatables Bug 11703 [QA Followup 1] - Center bProcessing message over table Bug 11703 [QA Followup 2] - Remove icons from checkout and clear buttons Bug 11703 [QA Followup 3] - Remove references to UseTablesortForCirc Bug 11703 [QA Followup 4] - Add back in Today's checkouts/Previous checkouts rows Bug 11703 [QA Followup 5] Bug 11703 [QA Followup 6] - Move strings to an include file for translation purposes Bug 11703 [QA Followup 7] - Fix issues spotted by koha-qa.pl Bug 11703 [QA Followup 8] - Speed up api/checkouts.pl as much as possible Bug 11703 [QA Followup 9] - Move scripts from api directory to svc directory Bug 11703 [QA Followup 10] - Fix errors caused by rebase Bug 11703 [QA Followup 11] - Prevent multiple fetchs from ajax source Bug 11703 [QA Followup 12] - Fix problem detected by koha-qa.pl Bug 11703 [QA Followup 13] - Removed uneccessary data from renewal box during renewal Bug 11703 [QA Followup 14] - Fix table column span Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes all tests and QA script. Test plan on bug report: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703#c98 Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> Bug 11703 [QA Followup] * Bold record title, fix table width * Change output_pref_due to output_pref * Retain functionality of IssuesDefaultSortOrder system preferences * Use datatables.inc in circulation.tt * Fix up holds table details * Add plugin to about * fix relatives' checkouts * add too_many string * remove dead syspref from db * Sort relatives' checkouts and holds tables client side * Provide context for translation of strings * Fix unterminated string literal, add missing paren * Add replacement of _AUTHOR_ with title's author for holds * Format prices correctly * Format checkout dates correctly Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> Bug 11703 [QA Followup] - Use format instead of replace for string translation Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> Bug 11703 [QA Followup] - Use interface instead of themelang for checkboxes plugin Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> Bug 11703 [QA Followup] - Restore showing earliest renewal date for 'too early' renewals Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> Bug 11703: (qa-followup) fix update database entry Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> Bug 11703 [QA Followup] - Stop IE from caching ajax request Signed-off-by: Britta Cramer <britta.cramer at inm-gmbh.de> Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> Bug 11703 [QA Followup] - Allow keyboard navigation of tabs Signed-off-by: Britta Cramer <britta.cramer at inm-gmbh.de> Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> Bug 11703 [QA Followup] - Change "No data available in table" to "Loading..." Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> Bug 11703: (qa followup) consistency in svc This patch removes the trailing .pl from the introduced svc scripts. Also removes a leftover (wrong license text) Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 21:22:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 19:22:21 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-sEBWOHd2F2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30219|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30229&action=edit [PASSED QA] Bug 9000 [1] - Update rss.pl to use Template Toolkit Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Tested using script with sample conf files RSS feeds generated are 'well formed' xml Some koha-qa errors fixed in followup Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 21:22:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 19:22:29 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-YaFpgg9Z3x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30220|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30230&action=edit [PASSED QA] Bug 9000 [2] - Update included examples Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 21:22:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 19:22:38 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-SuHXAl6nmV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30221|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30231&action=edit [PASSED QA] Bug 9000 [3] - Change conf key from tmpl to template Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 21:22:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 19:22:47 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-04U8RoAw25@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30222|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30232&action=edit [PASSED QA] Bug 9000 [4] - Update to GPL v3 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 21:22:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 19:22:54 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-gi6Pgf4Ig5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30223|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30233&action=edit [PASSED QA] Bug 9000: Followup to fix tabs & closing TT directive Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 21:25:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 19:25:10 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-emgZvUs8mk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Happy to pass QA on this.. thanks so much for getting to this Kyle, and beating my team to sign-off Bernardo meaning I could QA. I took the initiative of taking Bernardo's patch straight to QA as it was simply a white-space fix to make git not complain ;) Go forth and push fair RM ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 21:30:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 19:30:32 +0000 Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9043-70-CUTWnfqfLx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #63 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Owen, thx for taking a look and finding this. I hope we find a solution that won't block the update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 21:43:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 19:43:49 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12630-70-fjeQfr3Wdi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Is this the same as bug 10883? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 22:33:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 20:33:27 +0000 Subject: [Koha-bugs] [Bug 8126] Funkiness with Patrons w/ Most Checkouts Report In-Reply-To: <bug-8126-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8126-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8126-70-q3ko24C5U7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8126 Agnes Rivers-Moore <arm at hanover.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca --- Comment #1 from Agnes Rivers-Moore <arm at hanover.ca> --- Hanover Library (Ontario) - single library site. Confirming we get more than the requested number of responses from this report. Usually twice as many or close to twice as many rows in the report as expected. The later rows have very low checkout numbers, people with 1 to 4 checkouts only, so this is not simply the limit to x rows failing - it is including patrons that are not near the "top" users, and could possibly be the lowest users. I hope this may help figure out what is going on. Agnes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 22:39:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 20:39:42 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-151jfsA8B1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #60 from M. Tompsett <mtompset at hotmail.com> --- Also, it fails to apply cleanly now. Make sure to rebase. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 22:55:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 20:55:55 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-lbzPMsv93q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am sorry Yohann, but this still fails for me: $ perl t/db_dependent/Members/GetAllIssues.t 1..16 DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/Members/GetAllIssues.t line 20. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/Members/GetAllIssues.t line 20. # Looks like your test exited with 255 before it could output anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:10:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:10:19 +0000 Subject: [Koha-bugs] [Bug 12614] Remove CGI::scrolling_list from auth_subfields_structure.pl In-Reply-To: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12614-70-2tvJ9pu9hI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:10:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:10:23 +0000 Subject: [Koha-bugs] [Bug 12614] Remove CGI::scrolling_list from auth_subfields_structure.pl In-Reply-To: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12614-70-wpaLQtGrFl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30130|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30234&action=edit [PASSED QA] Bug 12614: Remove CGI::scrolling_list from auth_subfields_structure.pl This patch removes all instances on this file. Even removes some commented out instances. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > Authority types 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 031 5. Clic 'Edit subfields' button Now the tests proper 6. 'Help input' box (editor bottom): Eight(8) scrolling_list removed, they use to feed the four pulldowns, so check each one 'Koha field' is new (for me at last) 'Authorised value', 'Thesaurus' (is this valid/useful here?) 'Plugin' There is a difference between existing subtags and a new subtag, the 'id' of the pulldowns (so the 8 scrolling list removed) Check assign/remove/save/load values, search for regressions If you edit subtag 942, it has a value on kohafield (default fw) I think that this box could be prettified with fixed width for pulldowns. 7. No more functional tests, there are 4 scrolling_list removed that are commented (removed also commented code on tt file), and two instances that are similar to previously removed instances, evidently with no effect. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Not sure about the new Koha field entry... All works as expected. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> All works as expected. About Koha field: I think it makes sense to have it in the form, so you can configure the fields for new authority types. In my database I have mappings on authtypecode and authid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:15:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:15:14 +0000 Subject: [Koha-bugs] [Bug 12429] patron seeing fines codes In-Reply-To: <bug-12429-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12429-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12429-70-C8oJVdOufo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #12 from Barton Chittenden <barton at bywatersolutions.com> --- Couple of small issues still need to be addressed: * The code 'FFOR' is still not expanded. * There is a space between the fine decription and the following comma, so Fine , To kill a mockingbird / 10/23/2013 23:59 View item To kill a mockingbird / should read Fine, To kill a mockingbird / 10/23/2013 23:59 View item To kill a mockingbird / -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:17:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:17:29 +0000 Subject: [Koha-bugs] [Bug 12612] Remove CGI::scrolling_list from auth_tag_structure.pl In-Reply-To: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12612-70-o0IHyyDivM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12612 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:17:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:17:32 +0000 Subject: [Koha-bugs] [Bug 12612] Remove CGI::scrolling_list from auth_tag_structure.pl In-Reply-To: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12612-70-7QylHDii7r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12612 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30125|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30235&action=edit [PASSED QA] Bug 12612: Remove CGI::scrolling_list from auth_tag_structure.pl This patch removes the only instance in this file. Don't know if the feature is of some utility, seems that does not work (no use of auth values as indicators on MARC authority editor) To test: 1. Apply the patch 2. Go to Administration > Authority types 3. Clic on MARC structure of any fw 4. Clic Edit on any tag 5. On tag editor check the pulldown 'Authorised value', that was replaced 6. Check for regressions: select a value, save, verify the value, change again, etc. Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Works as expected, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:20:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:20:47 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-rpxeAcIplY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 --- Comment #4 from Marc V?ron <veron at veron.ch> --- Created attachment 30236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30236&action=edit [Signed-off] Bug 12597 - Give better visual indication of currently-selected language in the staff client There is currently no visual feedback to the user reflecting which of multiple installed translations is currently selected. I think some necessary styling didn't make it into the conversion to Bootstrap menus. This patch attempts to improve things. Most of the changes are to bring back the previous style of highlighting the currently selected language. A new change is the addition of the sub-language code to the display of the menu label if one of that menu item's sub-languages is selected. This patch also removes some obsolete CSS which referred to the old menu system. To test, apply the patch and install or update multiple languages, including at least two sub-languages. In my test I used en, en-GB and de-DE. Clear your browser cache if necessary. Enable all these languages and test the functionality of the language selection menu in the footer. - Non-enabled languages should appear as non-bold links. - When a single language (with no sub-languages) is enabled it should appear as bold text. - When one of multiple sub-languages is enabled that selection in the pop-up menu should appear as bold text. The menu label should show in bold the language code of the selected sub-language. Tested with de-DE and de-CH, works as expected Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:21:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:21:17 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-rIaKED5Upz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30224|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:21:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:21:28 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-Hq3xbRyfGP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:29:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:29:50 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12627-70-YRLhVnCe7u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:29:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:29:54 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12627-70-McrvZS2j6D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30095|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30237&action=edit [PASSED QA] Bug 12627: SQLHelper replacement - C4::Suggestions With this patch, the subroutines NewSuggestion and ModSuggestion uses DBIx::Class instead of C4::SQLHelper. Moreover, the tests has been adapted to the values returned by DBIx::Class. Test plan: 1) Apply the patch 12445 in order to get the last unit tests for Suggestions 2) Apply the patch 3) Execute the unit tests by launching : prove t/db_dependent/Suggestions.t 4) The result has to be a success without error or warning : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.01 sys + 1.65 cusr 0.09 csys = 1.80 CPU) Result: PASS Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Tests pass, no problems found. Patch applies on top of bug 12445. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:33:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:33:40 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12627-70-n92fKjFq74@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am sorry, but running the tests proved to be not enough. This patch breaks adding a suggestion from the staff interface (didn't test OPAC). DBIx::Class::Row::new(): No such column 'EUR' on Koha::Schema::Result::Suggestion at /home/katrin/kohaclone/C4/Suggestions.pm line 435 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:40:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:40:17 +0000 Subject: [Koha-bugs] [Bug 12666] New: Offline Circulation has poor HTML Message-ID: <bug-12666-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 Bug ID: 12666 Summary: Offline Circulation has poor HTML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com While attempting to generate a test plan for a patch for bug 10446 related to offline circulation, I noticed the HTML was poor. This cleans it up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:56:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:56:15 +0000 Subject: [Koha-bugs] [Bug 12666] Offline Circulation has poor HTML In-Reply-To: <bug-12666-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12666-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12666-70-Hk2yYVGnoe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 28 23:56:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 21:56:17 +0000 Subject: [Koha-bugs] [Bug 12666] Offline Circulation has poor HTML In-Reply-To: <bug-12666-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12666-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12666-70-qljRnDkOzu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30238&action=edit Bug 12666 - Fix poor HTML from circ/offline.tt In koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt - Cleaned up the HTML's missing </div>'s - Corrected the autobuffer attribute to the newer preload one - Added   into empty title, since it will get replaced TEST PLAN --------- 1) Run the circ/offline.pl page source through an HTML validator -- should get a few warnings 2) Apply patch 3) Recheck page source (confirm your page isn't cached!) -- should be clean -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 00:10:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jul 2014 22:10:24 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: <bug-10446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10446-70-DJ9p5pq3QX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 --- Comment #12 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30239&action=edit Bug 10446 - Follow up fix As per comment #11 by Jonathan Druart, I just fixed the items in question. Plus, I noted a typographical error in the updatedatabase.pl message (10466 vs. 10446) TEST PLAN --------- 1) Apply the patch 2) Ensure the Circulation system preference, AllowOfflineCirculation, is enabled. 3) Home -> Circulation -> Built-in offline circulation interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 04:44:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 02:44:52 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: <bug-10446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10446-70-lCYaTgoI9c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 --- Comment #13 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30240&action=edit Bug 10446 - System preference maxoutstanding is poorly named The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds, but the name does not describe its behavior very well. String changes only, no functional changes made. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the new system preference FeesBlockHoldsAmount's value matches the previous value of maxoutstanding. 4) Set FeesBlockHoldsAmount to $10 5) Attempt to place an OPAC hold for a patron owing less than $10 This attempt should succeed. 6) Attempt to place an OPAC hold for a patron owing more than $10 This attempt should fail Rebased by Mark Tompsett Signed-off-by: Srdjan <srdjan at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 04:45:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 02:45:10 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: <bug-10446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10446-70-jW94OxA0Mv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30239|0 |1 is obsolete| | --- Comment #14 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30241&action=edit Bug 10446 - Follow up fix As per comment #11 by Jonathan Druart, I just fixed the items in question. Plus, I noted a typographical error in the updatedatabase.pl message (10466 vs. 10446) TEST PLAN --------- 1) Apply the patch 2) Ensure the Circulation system preference, AllowOfflineCirculation, is enabled. 3) Home -> Circulation -> Built-in offline circulation interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 04:49:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 02:49:07 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: <bug-10446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10446-70-oLnOhMrEEu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26618|0 |1 is obsolete| | CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 04:56:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 02:56:30 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: <bug-10446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10446-70-gu7qOfxLxv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 --- Comment #15 from M. Tompsett <mtompset at hotmail.com> --- Sorry for an incomplete test plan, but I'm not sure how to use the offline circulation. But it should be similar to steps 2-6 elsewhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 05:00:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 03:00:31 +0000 Subject: [Koha-bugs] [Bug 10498] Place Hold on Order In-Reply-To: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10498-70-k39qSdJQMX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #9 from M. Tompsett <mtompset at hotmail.com> --- This needs a rebase/rework, because this no longer applies cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 05:05:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 03:05:36 +0000 Subject: [Koha-bugs] [Bug 12432] Saved reports tabs not working In-Reply-To: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12432-70-jayAH3Wsur@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Christopher Brannon <cbrannon at cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 05:05:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 03:05:48 +0000 Subject: [Koha-bugs] [Bug 12432] Saved reports tabs not working In-Reply-To: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12432-70-jLMITZBqhf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30214|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 05:05:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 03:05:55 +0000 Subject: [Koha-bugs] [Bug 12432] Saved reports tabs not working In-Reply-To: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12432-70-LXNKNxLWTS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 --- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 30242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30242&action=edit Bug 12432 - Saved reports tabs not working In release 3.14.05.000 the tabs on the Saved Reports page worked correctly but after upgrading to 3.16.00.000 the tabs stop working. Visually the tabs change but the table of reports is not filtered. There are no errors reported in the browser console. Test Plan: 1) Attempt to filter saved reports by group tabs 2) Note no matter the tab you select, all reports appear 3) Apply this patch 4) Repeat step 1 5) Note the reports are now filtered correctly Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 05:10:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 03:10:22 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10900-70-6LTyqP4zEj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27729|0 |1 is obsolete| | --- Comment #30 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30243&action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep "::set_userenv" `find .` grep "\->set_userenv" `find .` The first grep demonstrated that the smaller change is from :: to -> as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use ->) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. REBASED Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 05:10:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 03:10:37 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10900-70-nXvXBunqgD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28183|0 |1 is obsolete| | --- Comment #31 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30244&action=edit Bug 10900 - Follow up, since more has been added to master Booksellers.t and Koha_template_plugin_Branches.t both had function calls to ::set_userenv added to them. This patch handles those additions. TEST PLAN --------- 1) Branch a new git branch 2) prove -v t/db_dependent/Bookseller.t -- It should work. 3) prove -v t/db_dependent/Koha_template_plugin_Branches.t -- It should work. 4) Apply only the first patch. 5) Repeat steps 2 and 3. -- They should both FAIL! 6) Apply the second patch as well. 7) Repeat steps 2 and 3. -- The should both work. REBASED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 05:18:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 03:18:44 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10937-70-ThXecW77LR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #35 from M. Tompsett <mtompset at hotmail.com> --- Sorry, doesn't apply cleanly. Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 05:25:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 03:25:26 +0000 Subject: [Koha-bugs] [Bug 10498] Place Hold on Order In-Reply-To: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10498-70-FxNlOW7ktZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 Amit <amitddng135 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #10 from Amit <amitddng135 at gmail.com> --- Hi Tompsett, I am working on same will rebase patch and send. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 06:25:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 04:25:36 +0000 Subject: [Koha-bugs] [Bug 12619] Shipment date gets lost on finishing the invoice In-Reply-To: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12619-70-EsbRkMCpjI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 06:25:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 04:25:46 +0000 Subject: [Koha-bugs] [Bug 12619] Shipment date gets lost on finishing the invoice In-Reply-To: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12619-70-qGqKdV6phP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 06:25:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 04:25:53 +0000 Subject: [Koha-bugs] [Bug 12619] Shipment date gets lost on finishing the invoice In-Reply-To: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12619-70-FadvdizrUW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 --- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 30245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30245&action=edit Bug 12619 - Shipment date gets lost on finishing and/or editing the invoice To reproduce: - Create a new shipment, make sure to add a shipment date - Receive or not receive orders - Finish receiving with the button at the bottom of the page - Verify that shipment date is now empty To test: - reproduce the aforementioned issue - apply patch - confirm that the issue is no longer rerpoductible (= shipment date is not getting lost any longer), and that there are no apparent regresssions of any kind involving invoice shipment date entering and/or editing - sign off Signed-off-by: Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 06:44:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 04:44:35 +0000 Subject: [Koha-bugs] [Bug 12587] Improve output of filter information on patrons with the most checkouts report In-Reply-To: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12587-70-OkgpZiGZBJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12587 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 06:44:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 04:44:46 +0000 Subject: [Koha-bugs] [Bug 12587] Improve output of filter information on patrons with the most checkouts report In-Reply-To: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12587-70-X5SeUyJPvC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12587 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 06:44:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 04:44:54 +0000 Subject: [Koha-bugs] [Bug 12587] Improve output of filter information on patrons with the most checkouts report In-Reply-To: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12587-70-vp5Dgnuoye@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12587 --- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 30246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30246&action=edit Bug 12587 - Improve output of filter information on patrons with the most checkouts report This patch makes some changes to the way filter information is displayed after running the patrons with the most checkouts report. Before this patch several untranslatable English strings would be displayed, and library and item type codes would be shown instead of descriptions. To test, go to Reports -> Patrons checking out the most. Enter values for all the filter options: - Checkout date from - Checkout date to - Checkin date from - Checkin date to - Library - Item type - Patron category When you submit the form and view the results you should see your date submissions formatted according to your selected dateformat system preference. The library name and item type names should be shown instead of codes. Signed-off-by: Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 07:02:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 05:02:34 +0000 Subject: [Koha-bugs] [Bug 12661] Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt In-Reply-To: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12661-70-J5irENppAj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 07:02:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 05:02:44 +0000 Subject: [Koha-bugs] [Bug 12661] Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt In-Reply-To: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12661-70-QGDEtWJgBr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30068|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 07:02:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 05:02:51 +0000 Subject: [Koha-bugs] [Bug 12661] Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt In-Reply-To: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12661-70-EOKCnsRz3N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 --- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 30247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30247&action=edit Bug 12661: Fixing capitalisation from "Item Type" to "Item type" To fix go to help>reports>manager Find capitalisation error "Item Type" Change to "Item type" Signed-off-by: Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 07:42:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 05:42:53 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-CUQRICdSpl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer CC| |chris at bigballofwax.co.nz --- Comment #15 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to MM_OPAC/bug_12568 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:01:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:01:38 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-JkCnETSwAq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29966|0 |1 is obsolete| | --- Comment #45 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30248&action=edit Bug 11577: Add auto_renew flags to the database - issues.auto_renew - old_issues.auto_renew - issuingrules.auto_renew Default value is zero. To test: 1) Run installer/data/mysql/updatedatabase.pl 2) Create SQL reports like: SELECT * FROM issues LIMIT 0,1 3) Confirm that a column auto_renew was added to each of the three tables. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:02:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:02:08 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-3B5J5DFIfm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29967|0 |1 is obsolete| | --- Comment #46 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30249&action=edit Bug 11577: Add "Automatic renewal" to the circulation and fine rules This patch adds a column "Automatic renewal" to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that "Automatic Renewal" is set to "No" by default and can be switched to "Yes". Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:02:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:02:49 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-thQz891z0N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29968|0 |1 is obsolete| | --- Comment #47 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30250&action=edit Bug 11577: Code and intranet template changes This patch adds a checkbox for "Automatic renewal" to the checkout page. CanBookBeRenewed is modified to include two new errors: - auto_renew (renewal shouldn't be done manually) - auto_too_soon (renewal is premature and shouldn't be done manually) To test: 1) Add or edit an issuing rule with "Automatic renewal" and another one without it. 2) Issue at least three items: - automatic renewal by issuing rule - automatic renewal by Checkbox on the checkout page - no automatic renewal 3) Test the following steps for both: Home > Circulation > Checkouts Home > Patrons > Patron details 4) Confirm that issues with automatic renewal cannot be renewed manually, even if there are still renewals left and it's not too soon to renew. 5) Confirm that "Scheduled for automatic renewal" and the remaining renewals are displayed. If no renewals are left "Not renewable" should be displayed. 6) Confirm that issues without automatic renewal behave as usual. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:03:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:03:04 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-V9K59PWwMs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29969|0 |1 is obsolete| | --- Comment #48 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30251&action=edit Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon' to the renewal interface. To test: 1) Issue two items: - one with automatic renewal and no value for "No renewal before" - another with automatic renewal and a value for "No renewal before" 2) Try to renew: Home > Circulation > Renew 3) Confirm there are error messages explaining that the items have been scheduled for automatic renewal and that one of the renewals is also premature. 4) If global syspref AllowRenewalLimitOverride is set to "Allow" you should be given the option to override. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:03:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:03:23 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-KIgYjZx9My@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29970|0 |1 is obsolete| | --- Comment #49 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30252&action=edit Bug 11577: Expand description of AllowRenewalLimitOverride With the introduction of the new automatic renewal feature global syspref AllowRenewalLimitOverride is expanded in meaning. It now gives the option to override blocks if: - the number of allowed renewals is exceeded - the renewal is premature (No renewal before) - the item is scheduled for automatic renewal - the renewal is premature and the item is scheduled for automatic renewal Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:03:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:03:39 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-vOgsGcFEXW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29971|0 |1 is obsolete| | --- Comment #50 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30253&action=edit Bug 11577: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:03:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:03:53 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-IMMmiHBZmk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29972|0 |1 is obsolete| | --- Comment #51 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30254&action=edit Bug 11577: OPAC prog theme changes This patch makes the prog version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to prog. 2) Test the same things as in previous patch. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:04:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:04:06 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-mOJqicSw5x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29973|0 |1 is obsolete| | --- Comment #52 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30255&action=edit Bug 11577: Add an automatic renewal cronjob This patch adds a new cron script automatic_renewals.pl and a new entry in crontab.example. To test: 1) You need a few issues, some with automatic renewal and some without. 2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl those issues are renewed that meet all of the following criteria: - automatic renewal has been scheduled either by issuing rule or by checkbox on the checkout page - the number of allowed renewals isn't exceeded - renewal isn't premature (No renewal before) 3) Confirm that all other issues are not affected. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:04:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:04:21 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-ubUfy1yqN5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29974|0 |1 is obsolete| | --- Comment #53 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30256&action=edit Bug 11577: Unit tests This patch fixes a few unit tests that broke because of the new feature. To test: 1) prove t/db_dependent/Circulation.t 2) prove t/db_dependent/Circulation_Issuingrule.t 3) prove t/db_dependent/Circulation_issue.t Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:04:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:04:35 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-MOX4ymGoHW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #54 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30257&action=edit Bug 11577: Add Hochschule f?r Gesundheit to contributing institutions Automatic renewal is the second feature sponsored by the hsg. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:05:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:05:03 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-tNYVBpWFCH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:05:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:05:07 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-PJ5lbAdu8L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #55 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30258&action=edit Bug 11577 : Fixing a tiny typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:27:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:27:53 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12630-70-xlUM8R7EXj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> --- Comment on attachment 29962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29962 Bug 12630 - Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! Review of attachment 29962: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12630&attachment=29962) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +1982,3 @@ > =cut > > sub _ShiftPriorityByDateAndPriority { Doesn't make a lot of sense to leave this function name as it is, since it's not doing anything with the date any more. Also the POD is now wrong. This also means that a hold with a newer date, will not be placed before older date. Which is changing the functionality. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:33:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:33:30 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12528-70-3vIRwkvYjD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 30259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30259&action=edit [Signed-off] Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Modified: installer/data/mysql/sysprefs.sql -OPACEnhancedMessagingPreferences preference added koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -OPACEnhancedMessagingPreferences preference added koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -access to message setting changed Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. Patch behaves as expected Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:34:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:34:11 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12528-70-SiZhGak2y7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:34:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:34:33 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12528-70-SDh1hHHGa1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29505|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:46:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:46:04 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9805-70-0Z4H7rp8B1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:52:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:52:16 +0000 Subject: [Koha-bugs] [Bug 12136] Problem in opac-topissues.pl if AdvancedSearchTypes has multiple values (separated by pipes) In-Reply-To: <bug-12136-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12136-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12136-70-ZUJLJCOM8S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12136 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|veron at veron.ch |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:53:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:53:19 +0000 Subject: [Koha-bugs] [Bug 12615] Remove CGI::scrolling_list from marc_subfields_structure.pl In-Reply-To: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12615-70-kUGQWIsJCG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:53:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:53:22 +0000 Subject: [Koha-bugs] [Bug 12615] Remove CGI::scrolling_list from marc_subfields_structure.pl In-Reply-To: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12615-70-t08OcZZBGo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30131|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30260&action=edit Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl This patch removes all instances on this file. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 020 5. Clic 'Edit subfields' button Now the tests proper 6. On any subfield, check pulldown 'Managed in tab', was replaced, so test if it works and search for regressions Change, save, load, change again 7. Clic on 'Advanced constraints' (2) scrolling list removed At the bottom, check 'Koha link', was changed Check assign/remove/save/load values, search for regressions 8. Clic on 'Other options' box Eight(6) scrolling_list removed, they use to feed three pulldowns, so check each one 'Authorised value', 'Thesaurus' 'Plugin' Check assign/remove/save/load values, search for regressions Check adding a new subfield Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:55:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:55:11 +0000 Subject: [Koha-bugs] [Bug 12453] Do not use by default Host-Item-Number in UNIMARC In-Reply-To: <bug-12453-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12453-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12453-70-yYeo6lupmh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12453 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 08:55:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 06:55:14 +0000 Subject: [Koha-bugs] [Bug 12453] Do not use by default Host-Item-Number in UNIMARC In-Reply-To: <bug-12453-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12453-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12453-70-kiYQ0qKj3r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12453 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29040|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30261&action=edit Bug 12453 - Do not use by default Host-Item-Number in UNIMARC Actually, in default UNIMARC install, 461$9 is indexed as Host-Item-Number, meaning it is used for analytical itemnumber. But most UNIMARC catalog use the analytical relation using unimarc_field_4XX.pl plugin on 461$a. In fact, this plugin is defined in default UNIMARC frameworks. If Host-Item-Number is defined but 461$9 is used for something else, it will lead to odd bugs. For example, records containing analytical items can not be deleted. This patch comments the 461$9 indexing in UNIMARC zebra config. Test plan : - Create a fresh UNIMARC install - Create a record with 461$9 containing a value - Index the record - Perform a search on Host-Item-Number : ccl=Host-Item-Number,alwaysmatches='' => Without the patch you get a result => With the patch you get no result Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 09:01:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 07:01:49 +0000 Subject: [Koha-bugs] [Bug 12654] Incorrect quoting in regexp in AuthoritiesMarc In-Reply-To: <bug-12654-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12654-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12654-70-EFF5PQP0o7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12654 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 09:01:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 07:01:53 +0000 Subject: [Koha-bugs] [Bug 12654] Incorrect quoting in regexp in AuthoritiesMarc In-Reply-To: <bug-12654-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12654-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12654-70-Mc4jh1Risx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12654 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30040|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30262&action=edit Bug 12654 Correct incorrectly quoted regexp A compile time warning was being generated because \ does not quote { Replace the plethora of \ before meta and presumed meta characters by \Q \E which gets perl to generate all the necessary escapes, we can assume it knows its regex engine as well or better than the human programmer Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 09:04:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 07:04:28 +0000 Subject: [Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree In-Reply-To: <bug-12545-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12545-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12545-70-bOmuYgRx5n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 09:04:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 07:04:31 +0000 Subject: [Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree In-Reply-To: <bug-12545-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12545-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12545-70-RI58TEgUtN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29587|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 30263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30263&action=edit Bug 12545: Add EditorConfig.org file to the source tree This patch adds a .editorconfig file to the source tree, that enforces some of our coding guidelines. Some editors try to detect the desired configurations from the currently opened file. As we have tons of old code that doesn't follow our current coding guidelines, this can lead to unintended QA problmes. To test: - Apply the patch - Verify the .editorconfig file is in the top-level directory - See the .editorconfig file expresses our coding guidelines Regards To+ Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 09:06:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 07:06:08 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11577-70-O123qYjhap@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Mei?ner <h.meissner.82 at web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 09:20:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 07:20:03 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11331-70-WTP4lSjTmE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Fridolin SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 09:20:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 07:20:05 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11331-70-mthpAMV4EN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Fridolin SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23265|0 |1 is obsolete| | --- Comment #6 from Fridolin SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 30264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30264&action=edit Bug 11331 - CSV export for viewlog.pl is missing newlines When you try to export the result of tools/viewlog.pl in csv, file cannot be correctly loaded : - newline is missing after each record, - strings should be enclosed in "" - columns are not the same as for screen output This patch corrects this by using like other export Text::CSV. Adds a header line made with the keys of first data. For that, all data values are initialiszed with empty string. Test plan : - Use a database with some logs, see sysprefs /cgi-bin/koha/admin/preferences.pl?tab=logs - Go to export page /cgi-bin/koha/tools/viewlog.pl - Select a module - Click on "To a file" and choose a file name - Click on "Submit" - Open file => Without this patch : newline is missing, multi-lines cells are not enclosed in "", there are no column headings => Without this patch : each line is a data line, complexe cells are enclosed in "", there are column headings - Test the export of all modules to see that all headings are necessary - Check the output to screen in the browser -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 09:20:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 07:20:21 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11331-70-TpRe5NsJmM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 --- Comment #7 from Fridolin SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 30265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30265&action=edit Bug 11331 - CSV export for viewlog.pl is missing newlines - followup Perl formatting and cleaning. Also corrects the HTML of restults table in viewlog.tt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 09:20:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 07:20:54 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11331-70-EbHYEqq6gb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Fridolin SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |/cgi-bin/koha/tools/viewlog | |.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 09:35:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 07:35:18 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-WXw0Ik3gW5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 --- Comment #13 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- Katrin, the koha CAS code (client-side) allows to use http or https, what I said is that some CAS servers only allow https. But I think we should keep both in koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 10:20:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 08:20:34 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12630-70-5DF3kLntv1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- (In reply to Chris Cormack from comment #4) > This also means that a hold with a newer date, will not be placed before > older date. Which is changing the functionality. I understood that this feature is only to activate a hold after a certain period of time, not to make it automatically target an item (be top priority) when the date arrives. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 10:22:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 08:22:00 +0000 Subject: [Koha-bugs] [Bug 10883] OPACAllowHoldDateInFuture can let a patron jump to the top of the holds list In-Reply-To: <bug-10883-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10883-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10883-70-NY4l7R6EaL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10883 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |olli-antti.kivilahti at jns.fi Resolution|--- |DUPLICATE --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- *** This bug has been marked as a duplicate of bug 12630 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 10:22:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 08:22:00 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12630-70-odknKpUojS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- *** Bug 10883 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 10:26:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 08:26:40 +0000 Subject: [Koha-bugs] [Bug 10883] OPACAllowHoldDateInFuture can let a patron jump to the top of the holds list In-Reply-To: <bug-10883-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10883-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10883-70-blPMNmZ6cb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10883 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Sorry jumped to conclusion. This is not the same issue as bug 12630 but VERY similar. Bug 12630 is about issues after re-prioritization. This is about setting the future date to past. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 10:26:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 08:26:48 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: <bug-8918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8918-70-KZH0raJCBz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi Depends on| |12630 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 10:26:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 08:26:48 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12630-70-zfxLWQIz5k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8918 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 10:26:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 08:26:57 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: <bug-8918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8918-70-qnTkDvP8Zn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|12630 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 10:26:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 08:26:57 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12630-70-B7UL9WTsnJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|8918 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 10:27:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 08:27:20 +0000 Subject: [Koha-bugs] [Bug 10883] OPACAllowHoldDateInFuture can let a patron jump to the top of the holds list In-Reply-To: <bug-10883-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10883-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10883-70-v0s1evI0JN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10883 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12630 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 10:27:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 08:27:20 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12630-70-2J9rHB3dCV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10883 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 10:28:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 08:28:37 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12630-70-BId73bNyeq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- This bug doesn't exactly depend on Bug 10883 but is linked to it by similarity. Maybe a joint patch? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 10:47:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 08:47:41 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-BrQE1COPUn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30187|0 |1 is obsolete| | --- Comment #14 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 30266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30266&action=edit Bug 12457: Allow UT on a non empty database Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 10:47:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 08:47:59 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-aJpjbOKB18@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 11:02:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 09:02:14 +0000 Subject: [Koha-bugs] [Bug 12667] New: Stray dollar ($) -sign in opac-reserve.pl Message-ID: <bug-12667-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12667 Bug ID: 12667 Summary: Stray dollar ($) -sign in opac-reserve.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org A dollar sign is hard-coded in opac-reserve.pl and becomes apparent when trying to place a reservation when one has "too_much_oweing" or too much fines. Removing the dollar sign so we just get <"K?ytt?maksujen katto ylitetty. Et voi tehd? varauksia. Sinulla on maksamattomia maksuja 9.50."> instead of <"K?ytt?maksujen katto ylitetty. Et voi tehd? varauksia. Sinulla on maksamattomia maksuja $9.50."> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 11:02:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 09:02:29 +0000 Subject: [Koha-bugs] [Bug 12668] New: Stray dollar ($) -sign in opac-reserve.pl Message-ID: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668 Bug ID: 12668 Summary: Stray dollar ($) -sign in opac-reserve.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org A dollar sign is hard-coded in opac-reserve.pl and becomes apparent when trying to place a reservation when one has "too_much_oweing" or too much fines. Removing the dollar sign so we just get <"K?ytt?maksujen katto ylitetty. Et voi tehd? varauksia. Sinulla on maksamattomia maksuja 9.50."> instead of <"K?ytt?maksujen katto ylitetty. Et voi tehd? varauksia. Sinulla on maksamattomia maksuja $9.50."> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 11:03:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 09:03:01 +0000 Subject: [Koha-bugs] [Bug 12667] Stray dollar ($) -sign in opac-reserve.pl In-Reply-To: <bug-12667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12667-70-qqCAdExqQC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12667 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- *** This bug has been marked as a duplicate of bug 12668 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 11:03:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 09:03:01 +0000 Subject: [Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl In-Reply-To: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12668-70-2sdHpXZQbQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- *** Bug 12667 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 11:26:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 09:26:32 +0000 Subject: [Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl In-Reply-To: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12668-70-ZFA81GSHWR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668 --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 30267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30267&action=edit Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl A dollar sign is hard-coded in opac-reserve.pl and becomes apparent when trying to place a reservation when one has "too_much_oweing" or too much fines. Removing the dollar sign so we just get <"K?ytt?maksujen katto ylitetty. Et voi tehd? varauksia. Sinulla on maksamattomia maksuja 9.50."> instead of <"K?ytt?maksujen katto ylitetty. Et voi tehd? varauksia. Sinulla on maksamattomia maksuja $9.50."> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 11:26:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 09:26:57 +0000 Subject: [Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl In-Reply-To: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12668-70-xyfvVoozt4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 11:44:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 09:44:54 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-bfJ0DZe6T2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 12:27:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 10:27:10 +0000 Subject: [Koha-bugs] [Bug 12669] New: "Template process failed: undef error - Invalid local time for date in time zone" Message-ID: <bug-12669-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Bug ID: 12669 Summary: "Template process failed: undef error - Invalid local time for date in time zone" Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: rolando.isidoro at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Created attachment 30268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30268&action=edit Error backtrace When accessing "Serial collection" for a given subscription the "Invalid local time for date in time zone" error message will show if any of the dates (publisheddate or planneddate) in the subscription is in fact a day where a timezone offset occurred at 00:00:00. Ex:. Date 1979-04-01 and timezone Europe/Lisbon. The day existed, but the 00:00:00 hour didn't, since after 1979-03-31 23:59:59 came 1979-04-01 01:00:00 source: http://www.timeanddate.com/time/change/portugal/lisbon?year=1979) I've debugged the issue and found out that it occurs when applying the KohaDates filter (lib/Koha/Template/Plugin/KohaDates.pm, specifically in the dt_from_string call @ line 32) in the serials collection template (intranet/htdocs/intranet-tmpl/prog/en/modules/serials/serials-collection.tt). The expected result would be for the dates to show up correctly since we're dealing with days and not timestamps, so 1979-04-01 should be valid even though 1979-04-01 00:00:00 isn't for the Europe/Lisbon timezone. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 14:08:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 12:08:15 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12627-70-uwwFKX0aY2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 --- Comment #5 from Yohann Dufour <yohann.dufour at biblibre.com> --- Created attachment 30269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30269&action=edit Bug 12627: SQLHelper replacement - C4::Suggestions With this patch, the subroutines NewSuggestion and ModSuggestion use DBIx::Class instead of C4::SQLHelper. Moreover, the tests and the .pl have been adapted. Test plan: 1) Apply the patch 12445 in order to get the last unit tests for Suggestions. 2) Apply the patch. 3) Execute the unit tests by launching : prove t/db_dependent/Suggestions.t 4) The result has to be a success without error or warning : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.01 sys + 1.65 cusr 0.09 csys = 1.80 CPU) Result: PASS 5) Log in the intranet, create a suggestion and verify the created suggestion. 6) Edit a suggestion from the intranet and verify the suggestion is correctly modified. 7) Log in the OPAC and verify you can add a suggestion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 14:08:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 12:08:13 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12627-70-3H0ugCvAkv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 14:09:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 12:09:41 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12627-70-whKqZzcE0Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Yohann Dufour <yohann.dufour at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30237|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 14:35:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 12:35:30 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: <bug-12176-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12176-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12176-70-V11q9tdmXr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27927|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30270&action=edit Bug 12176 - Remove HTML from additem.pl This patch removes HTML code from additem.pl To test: 1. Chech no regressions on Add/Edit/Save items 2. Update translation files for a language, check new string "Tag editor" on staff PO file 3. Check it pass xt/tt_valid.t Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 15:43:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 13:43:33 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-gDxxK8G4lG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29719|0 |1 is obsolete| | Attachment #29720|0 |1 is obsolete| | Attachment #29721|0 |1 is obsolete| | Attachment #29722|0 |1 is obsolete| | Attachment #29723|0 |1 is obsolete| | Attachment #29724|0 |1 is obsolete| | Attachment #29725|0 |1 is obsolete| | Attachment #29726|0 |1 is obsolete| | Attachment #29727|0 |1 is obsolete| | Attachment #29728|0 |1 is obsolete| | Attachment #29729|0 |1 is obsolete| | Attachment #29730|0 |1 is obsolete| | --- Comment #450 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30271&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 15:44:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 13:44:01 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-eP7PNUpdz4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #451 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30272&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 15:44:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 13:44:08 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-5kPUZomCCG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #452 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30273&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 15:44:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 13:44:15 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-UyVva95nWe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #453 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30274&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 15:44:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 13:44:22 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-LYGB6tJDfS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #454 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30275&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 15:44:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 13:44:30 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-BM8sHRoqh4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #455 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30276&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 15:44:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 13:44:38 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-5UIvhXdlko@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #456 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30277&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 15:44:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 13:44:45 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-a7P5LxJsAt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #457 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30278&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 15:44:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 13:44:51 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-bDyiJwZ1ae@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #458 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30279&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 15:44:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 13:44:58 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-jkALD9QYPI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #459 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30280&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 15:45:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 13:45:05 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-phbaPMKGj0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #460 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30281&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 15:45:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 13:45:12 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-rKxmFmbELs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #461 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30282&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:06:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:06:16 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-kNFeUxrhyx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30017|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30283&action=edit MT8122: Adds Shibboleth authentication - Use the shibbolethAuthentication syspref to enable Shibboleth authentication - Configure the shibbolethLoginAttribute to specify which shibboleth user attribute matches the koha login - Make sure the OPACBaseURL is correctly set MT8122, Follow-up: Adds Shibboleth authentication - Fix logout bug: shibboleth logout now occurs only when the session is a shibboleth one. - Do some refactoring: getting shibboleth username is now done in C4::Auth_with_Shibboleth.pm (get_login_shib function) MT8122, Follow-up: Adds Shibboleth authentication - Adds redirect to opac after logout MT8122, Follow-up: Adds Shibboleth authentication - Shibboleth is not compatible with basic http authentication in C4/Auth.pm. This patch fixes that. MT8122, Follow-up: Adds Shibboleth authentication - Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with multiple vhosts. MT8122, Follow-up: Adds Shibboleth authentication - Adds missing protocol for $ENV{'SERVER_NAME'} Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> http://bugs.koha-community.org/show_bug.cgi?id=8446 Signed-off-by: Jesse Weaver <pianohacker at gmail.com> (ByWater employee.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:06:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:06:35 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-BOr0rk5Qz3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30018|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30284&action=edit BUG8446, Follow up: Adds Shibboleth authentication - Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont work if koha is behind a reverse proxy. - To use multiple vhosts, set OpacBaseURL per vhost explicitly with 'SetEnv OpacBaseURL Value' as per Bug 10325 BUG8446, Follow up: Adds Shibboleth authentication - Ensure user is returned to requested page after authentication - Added querystring to the target path in shibboleth URL so that when a user is authenticated he/she is returned to the correct page they requested before authentication. Example where this is important: When a user clicks a direct biblio link of the form - /opac-detail.pl?biblionumber=12345 BUG8446, Follow up: Remove unused imports from scripts - Remove import of deprecated C4::Utils module from shibboleth authentication module: Auth_with_shibboleth.pm Signed-off-by: Jesse Weaver <pianohacker at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:06:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:06:26 +0000 Subject: [Koha-bugs] [Bug 10883] OPACAllowHoldDateInFuture can let a patron jump to the top of the holds list In-Reply-To: <bug-10883-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10883-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10883-70-2gaDHG3lfU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10883 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:06:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:06:48 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-4M5Y2dr1wV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30019|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30285&action=edit BUG8446, Follow up: Remove unnecessary sysprefs, move to config Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:07:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:07:07 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-tVBA6bX3LH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30020|0 |1 is obsolete| | Attachment #30021|0 |1 is obsolete| | Attachment #30022|0 |1 is obsolete| | Attachment #30023|0 |1 is obsolete| | Attachment #30030|0 |1 is obsolete| | Attachment #30031|0 |1 is obsolete| | Attachment #30033|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30286&action=edit BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implimented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. BUG8446, Follow up: Correct paths after file rename BUG8446, Follow up: Implimented single sign out - This followup rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implimented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implimentation issue that is well known. BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template ruels so that CAS and Shibboleth can coexist. BUG8446, Follow up: Added default config to config file BUG8446, Follow up: Embelished perldoc documentation - Updated perldoc to correct detail about configuring shibboleth authentication. - Updated perldoc to include subroutines and their respective functions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:08:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:08:31 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12630-70-gN2kxrYIGZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Looks good, but the sub _ShiftPriorityByDateAndPriority should be renamed if you are removing the date part. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:12:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:12:21 +0000 Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well! In-Reply-To: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12630-70-DDpRVe3f1N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Also: FAIL C4/Reserves.pm OK pod FAIL forbidden patterns forbidden pattern: tab char (line 166) OK valid OK critic -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:15:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:15:06 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-t9qEgUecUa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:15:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:15:15 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-fVDI7tgyK8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29935|0 |1 is obsolete| | Attachment #29936|0 |1 is obsolete| | Attachment #29937|0 |1 is obsolete| | --- Comment #139 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30287&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:17:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:17:03 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-Q39172qTEc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #140 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30288&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:17:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:17:09 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-SjuwMcTI2q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #141 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30289&action=edit Bug 9303 [3] - relative's checkouts in the opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:28:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:28:18 +0000 Subject: [Koha-bugs] [Bug 12670] New: Show materials label instead of code Message-ID: <bug-12670-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670 Bug ID: 12670 Summary: Show materials label instead of code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In catalogue/detail.pl, if items.materials is linked to an authorised values list, show label instead of code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:28:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:28:41 +0000 Subject: [Koha-bugs] [Bug 12670] Show materials label instead of code In-Reply-To: <bug-12670-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12670-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12670-70-Y5F3BKtCsI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30290&action=edit Bug 12670: Show materials label instead of code In catalogue/detail.pl, if items.materials is linked to an authorised values list, show label instead of code. Test plan: 1/ Create an authorised values list 'MATERIALS' with some values 2/ In default MARC biblio framework, link an item subfield to 'items.materials', and to the AV list 'MATERIALS' 3/ Edit an item and give a value for this subfield 4/ Go to biblio record detail page (catalogue/detail.pl) 5/ In the items table, the authorised value label should be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:28:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:28:52 +0000 Subject: [Koha-bugs] [Bug 12670] Show materials label instead of code In-Reply-To: <bug-12670-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12670-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12670-70-DI9GuLlLYP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:43:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:43:42 +0000 Subject: [Koha-bugs] [Bug 12671] New: Guess next serial date when there are several issues per unit Message-ID: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 Bug ID: 12671 Summary: Guess next serial date when there are several issues per unit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:44:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:44:13 +0000 Subject: [Koha-bugs] [Bug 12642] SMS.t requires a database In-Reply-To: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12642-70-Ifup9HuM9q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:44:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:44:43 +0000 Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are several issues per unit In-Reply-To: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12671-70-XmUKG6BzoI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30291&action=edit Bug 12671: Refactor GetNextDate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:44:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:44:46 +0000 Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are several issues per unit In-Reply-To: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12671-70-62zY5hkxyr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30292&action=edit Bug 12671: Guess next serial date when there are several issues per unit This guess uses the following algorithm 1/ Get the number of days remaining from first issue of this unit of time until the end of the unit of time (using 7 days for week, 28 for month and 365 for year) 2/ Divide it by the number of issues per unit 3/ Take the integer part of the result, this is the number of days to add to previous serial published date This patch also try to guess the date of the first issue of a unit of time. Before that, it was: - for week: monday of week - for month: 1st day of month - for year: 1st day of year Now it uses firstacquidate. Example: firstacquidate = 1970-01-07 (wednesday) unit = week issuesperunit = 2 (2 issues per week) From wednesday to sunday, there are 4 days so we add 2 days to get the next date. The next dates should be: - 1970-01-09 (+ 2 days) - 1970-01-14 (wednesday of next week) - 1970-01-16 (+ 2 days) - ... and so on Test plan: 1/ Go to numbering pattern creation page (Serials -> Manager numbering patterns -> New numbering pattern) 2/ In "Test prediction pattern" fieldset, set subscription length to 50 issues (this avoid to compute the next 1000 dates, which can take time) 3/ Fill first issue publication date 4/ Choose the frequency you want to test 5/ click on "Test pattern" button 6/ Check that the dates are correct 7/ Repeat steps 3-7 until you think you have tested enough cases Interesting frequencies to test: - 1/day - 1/week - 2/week - 6/week (firstacquidate should be monday or tuesday, or the generated dates will be the same for all the week) - 1/month - 2/month - 3/month - 1/year - 2/year - 3/year -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:45:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:45:51 +0000 Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are several issues per unit In-Reply-To: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12671-70-F9HclnHT9p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:48:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:48:43 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-skZ1cvIuny@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #142 from Christopher Brannon <cbrannon at cdalibrary.org> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 9303: <h1>Something went wrong !</h1>Applying: Bug 9303 [1] - relative's checkouts in the opac - Database Updates fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9303 [1] - relative's checkouts in the opac - Database Updates When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 9303 - relative's checkouts in the opac 30287 - Bug 9303 [1] - relative's checkouts in the opac - Database Updates 30288 - Bug 9303 [2] - relative's checkouts in the opac - Schema Updates 30289 - Bug 9303 [3] - relative's checkouts in the opac Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:49:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:49:32 +0000 Subject: [Koha-bugs] [Bug 12622] Exporting report as Open Document Spreadsheet results in Perl error when report has no results In-Reply-To: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12622-70-HhK90BCNn9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:49:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:49:45 +0000 Subject: [Koha-bugs] [Bug 12614] Remove CGI::scrolling_list from auth_subfields_structure.pl In-Reply-To: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12614-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12614-70-DS5aAfT3NC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:50:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:50:01 +0000 Subject: [Koha-bugs] [Bug 12613] Remove CGI::scrolling_list from koha2marclinks.pl In-Reply-To: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12613-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12613-70-b9Zohu8Y96@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12613 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:50:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:50:17 +0000 Subject: [Koha-bugs] [Bug 12612] Remove CGI::scrolling_list from auth_tag_structure.pl In-Reply-To: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12612-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12612-70-7lDEcbG5ga@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12612 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:51:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:51:12 +0000 Subject: [Koha-bugs] [Bug 12570] Warnings in t/Biblio.t could be tested In-Reply-To: <bug-12570-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12570-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12570-70-CDsx981wZ3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12570 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:51:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:51:59 +0000 Subject: [Koha-bugs] [Bug 12564] Capitalization: Buttons in inventory tool In-Reply-To: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12564-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12564-70-0F7iK7RgrK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12564 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Karl, and congratulations for your first commit! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:52:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:52:24 +0000 Subject: [Koha-bugs] [Bug 12563] Capitalization: 'Set Status' on detail pages item's tab In-Reply-To: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12563-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12563-70-aWLQLx21rH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12563 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Evonne, and congratulations for your first commit! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:52:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:52:56 +0000 Subject: [Koha-bugs] [Bug 12562] Capitalization: 'Save Report' when saving a new SQL report In-Reply-To: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12562-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12562-70-SP1ZE7Shgp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12562 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Brian, and congratulations for your first commit! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:53:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:53:24 +0000 Subject: [Koha-bugs] [Bug 12560] Wrong capitalization on acquisition statistics page In-Reply-To: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12560-70-0q3Ix1a2Zk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12560 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Natalie, and congratulations for your first commit! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 16:53:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 14:53:49 +0000 Subject: [Koha-bugs] [Bug 12649] Add Croatian language In-Reply-To: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12649-70-yH5DXESLvm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Dobrica! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 17:29:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 15:29:43 +0000 Subject: [Koha-bugs] [Bug 12571] Add ability to customize SIP2 screen messages In-Reply-To: <bug-12571-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12571-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12571-70-m9Er0O0TOc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12571 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Jason Burds <jburds at dubuque.lib.ia.us> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 17:30:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 15:30:03 +0000 Subject: [Koha-bugs] [Bug 12571] Add ability to customize SIP2 screen messages In-Reply-To: <bug-12571-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12571-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12571-70-AkONyxFfpc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12571 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29679|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 17:30:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 15:30:10 +0000 Subject: [Koha-bugs] [Bug 12571] Add ability to customize SIP2 screen messages In-Reply-To: <bug-12571-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12571-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12571-70-fkGr7s5d9o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12571 --- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 30293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30293&action=edit Bug 12571 - Add ability to customize SIP2 screen messages We should add the ability to apply a regular expression to screen messages for the SIP2 server. This would allow libraries to not only customize the screen messages the patron sees, but can also allow screen messages to be translated. Test Plan: 1) Apply this patch 2) Inspect etc/SIPconfig.xml, note the new screen_msg_regex tags that can be nested inside a given login tag. 3) Add one or more screen_msg_regex tags to your own SIP config Recommendation: s/Greetings from Koha./Welcome to your library!/g 4) Restart your SIP2 server 5) Test with a SIP2 machine, or use /misc/sip_cli_emulator.pl 6) Note your new AF fields! Signed-off-by: Jason Burds <jburds at dubuque.lib.ia.us> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 17:49:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 15:49:09 +0000 Subject: [Koha-bugs] [Bug 12574] BiblioDefaultView doesn't affect XSLT results view In-Reply-To: <bug-12574-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12574-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12574-70-a7RlvVye6X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> --- Owen, Unless there is some aspect of this feature I am not setting right or that doesn't work in sandbox, I am not seeing any difference with the patch applied. I set OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to default, and see that those are working. I have set BiblioDefaultView to "in their MARC form.", but it still defaults to normal view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 17:56:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 15:56:49 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: <bug-12669-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12669-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12669-70-HCtrnu6J2o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 --- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Possibly if passed a date only string the timezone should default to 'floating' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 18:05:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 16:05:23 +0000 Subject: [Koha-bugs] [Bug 12571] Add ability to customize SIP2 screen messages In-Reply-To: <bug-12571-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12571-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12571-70-tyYhIGAjad@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12571 --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- I assisted Jason Burds with the testing of this patch. We used the sandbox for sign-off so he wouldn't need to create an account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 18:12:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 16:12:54 +0000 Subject: [Koha-bugs] [Bug 4888] pre-set of field indicators value In-Reply-To: <bug-4888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4888-70-NlCcdqgIoV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 Mike <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 18:13:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 16:13:39 +0000 Subject: [Koha-bugs] [Bug 6069] Multiple level budget list on suggestions In-Reply-To: <bug-6069-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6069-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6069-70-zbgKF1atfR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6069 Mike <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 18:31:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 16:31:59 +0000 Subject: [Koha-bugs] [Bug 12672] New: GetMARCISBN should return the corresponding subfield Message-ID: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Bug ID: 12672 Summary: GetMARCISBN should return the corresponding subfield Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Currently, if you call GetMARCISBN for a record that contains another subfield than $a (for example 020$c in MARC21) GetMARCISN returns all the subfields appended. As the function is used for visualization purposes, it should be fixed to only show the ISBN subfield. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 18:32:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 16:32:06 +0000 Subject: [Koha-bugs] [Bug 12672] GetMARCISBN should return the corresponding subfield In-Reply-To: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12672-70-6teemD46Uw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 18:40:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 16:40:05 +0000 Subject: [Koha-bugs] [Bug 11872] Lost overdue items should not generate fines In-Reply-To: <bug-11872-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11872-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11872-70-eeXL4N7HF5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 18:40:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 16:40:08 +0000 Subject: [Koha-bugs] [Bug 11872] Lost overdue items should not generate fines In-Reply-To: <bug-11872-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11872-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11872-70-CMobfYdI83@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25830|0 |1 is obsolete| | Attachment #29228|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30294&action=edit Bug 11872 - Lost overdue items should not generate fines An item can be marked as lost by longoverdue.pl, but left checked out to the patron. In this case, the item will continue to accrue fines. Test Plan: 1) Check out an item and back date it so it is overdue and should generate fines. 2) Mark the item as lost by either using longoverdue.pl, or just by setting itemlost to 1 by directly accessing the database 3) Run fines.pl 4) Note the overdue generated a fine 5) Repeat steps 1-2 6) Apply this patch 7) Run fines.pl 8) Note a fine was not generated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 18:41:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 16:41:21 +0000 Subject: [Koha-bugs] [Bug 11872] Lost overdue items should not generate fines In-Reply-To: <bug-11872-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11872-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11872-70-I79eMl4ptZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6) > Otherwise, a routine named "Getoverdues" should return all overdues (even > lost items). In this case you could remove the lost items in the 2 scripts > calling this routine. I agree, I've submitted an alternative patch that uses this path to resolution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 19:00:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 17:00:48 +0000 Subject: [Koha-bugs] [Bug 12672] GetMARCISBN should return the corresponding subfield In-Reply-To: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12672-70-N6MCjyw7xD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 30296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30296&action=edit Bug 12672: GetMarcISBN should return the corresponding subfield The current GetMarcISBN implementation returns an array of ISBN in which all subfields of a ISBN field occurence are appended. For example, in MARC21, if you have $a and $c defined, they will be appended for output. This happens for $z. To reproduce: - Run the regression tests attached to this bug. To test: - Apply the patch, regression tests pass. - Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 19:00:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 17:00:45 +0000 Subject: [Koha-bugs] [Bug 12672] GetMARCISBN should return the corresponding subfield In-Reply-To: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12672-70-T5h6HBJD7O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 30295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30295&action=edit Bug 12672: (regression test) GetMarcISBN should return the corresponding subfield Run: $ prove -v t/db_dependent/Biblio.t => FAIL: GetMarcISBN doesn't return the expected value for ISBN in MARC21, NORMARC and UNIMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 19:01:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 17:01:01 +0000 Subject: [Koha-bugs] [Bug 12672] GetMARCISBN should return the corresponding subfield In-Reply-To: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12672-70-zNuob061gv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 19:06:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 17:06:02 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-0be7BEoMCG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #143 from Nick Clemens <nick at quecheelibrary.org> --- Tested on VM, patch applied cleanly. Test plan: 1 - Apply patch and run updatedatabase.pl 2 - Create three patrons A, B, and C. A is guarantor for B and C 3 - Checkout one item to each B and C 4 - Set AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - option appears on B and C's 'Your personal details' tab in OPAC and not on A's 5 - Set OPACPrivacy to allow - the guarantor option moves to the privacy tab for B & C, still not visible for A 6 - Set Allow guarantor to view.... For B, then C, then both, appears as expected on 'Relatives checkouts' tab for borrower A 7 - Set AllowPatronToSetCheckoutsVisibilityForGuarantor to Don't & set AllowStaffToSetCheckoutsVisibilityForGuarantor to allow - option is removed from B&C, A can still see their checkouts. Staff can view B's checkouts on C's account and vice versa. Patron A can see checkouts for B&C. Staff can edit the option for patrons B &C's accounts but not on A's account 8 - Set AllowStaffToSetCheckoutsVisibilityForGuarantor to Don't - Patron A can no longer see B or C's checkouts, staff can see B&C's checkouts on each others accounts and both B&C on A's account 9 - Set both New prefs on and both staff and patrons can edit and view as expected. Toggle OPACPrivacy and the patron option moves I think I hit all the relevant combinations and did not run into any bugs. The only minor error I see is that all patrons now have the 'Show checkouts to guarantor' flag listed under 'Library Use' whether or not the preferences are on or whether or not they have guarantors. If they don't have a guarantor you can see the option but not edit it regardless of the AllowStaff... syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 19:26:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 17:26:19 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-EEElRrwcV6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 19:26:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 17:26:22 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-QWSLdyfMvf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30287|0 |1 is obsolete| | Attachment #30288|0 |1 is obsolete| | Attachment #30289|0 |1 is obsolete| | --- Comment #144 from Nick Clemens <nick at quecheelibrary.org> --- Created attachment 30297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30297&action=edit [SIGNED OFF] Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens <nick at quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 19:27:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 17:27:31 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-jGKcJtELTY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30297|0 |1 is obsolete| | --- Comment #145 from Nick Clemens <nick at quecheelibrary.org> --- Created attachment 30298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30298&action=edit [SIGNED OFF] Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens <nick at quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 19:27:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 17:27:44 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-oveljzHNEE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #146 from Nick Clemens <nick at quecheelibrary.org> --- Created attachment 30299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30299&action=edit [SIGNED OFF] Bug 9303 [2] - relative's checkouts in the opac - Schema Updates Signed-off-by: Nick Clemens <nick at quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 19:27:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 17:27:52 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-PHr4ygaJ3C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #147 from Nick Clemens <nick at quecheelibrary.org> --- Created attachment 30300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30300&action=edit [SIGNED OFF] Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Nick Clemens <nick at quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 19:59:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 17:59:59 +0000 Subject: [Koha-bugs] [Bug 12673] New: Remove CGI::scrolling_list from C4::Items.pm Message-ID: <bug-12673-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 Bug ID: 12673 Summary: Remove CGI::scrolling_list from C4::Items.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org One instance in this file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 20:13:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 18:13:17 +0000 Subject: [Koha-bugs] [Bug 12673] Remove CGI::scrolling_list from C4::Items.pm In-Reply-To: <bug-12673-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12673-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12673-70-JN71PsNzyf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30301&action=edit Bug 12673: Remove CGI::scrolling_list from C4::Items.pm This patch removes only instance in this file To test: 1. Apply the patch 2. (Esay way) Put on staff URL /cgi-bin/koha/services/itemrecorddisplay.pl?biblionumber=N&itemnumber=M 3. Code replaced corresponds to pulldowns, verify information is correct (check with another item edit view) PrepareItemrecordDisplay() in Items.pm is filled with chunks of HTML code that must be put on TT file. For now scrolling_list is the only removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 20:14:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 18:14:04 +0000 Subject: [Koha-bugs] [Bug 12673] Remove CGI::scrolling_list from C4::Items.pm In-Reply-To: <bug-12673-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12673-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12673-70-TAQwfaM3rc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|oleonard at myacpl.org |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 20:54:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 18:54:26 +0000 Subject: [Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC In-Reply-To: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12554-70-w39s7GSfZn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 30302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30302&action=edit Bug 12554: (regression test) C4::Biblio::GetMarcPrice does not handle NORMARC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 20:54:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 18:54:48 +0000 Subject: [Koha-bugs] [Bug 12672] GetMARCISBN should return the corresponding subfield In-Reply-To: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12672-70-UfL1bWL2hl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12554 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 20:54:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 18:54:48 +0000 Subject: [Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC In-Reply-To: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12554-70-i1wIrJ3HWt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |12672 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 20:55:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 18:55:00 +0000 Subject: [Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC In-Reply-To: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12554-70-5uT7V7yRfT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 20:57:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 18:57:45 +0000 Subject: [Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC In-Reply-To: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12554-70-skClaDCCgt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I'm sorry I blocked this, but writing the regression tests lead to another bug, which is solved at bug 12672. Unit tests couldn't be written without that patch because they would make the GetMarcISBN tests fail (adding subfield $c to 020 or its UNIMARC counterpart). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:05:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:05:53 +0000 Subject: [Koha-bugs] [Bug 12672] GetMarcISBN should return the corresponding subfield In-Reply-To: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12672-70-JsUtTSCsEV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|GetMARCISBN should return |GetMarcISBN should return |the corresponding subfield |the corresponding subfield -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:07:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:07:41 +0000 Subject: [Koha-bugs] [Bug 12674] New: GetMarcISSN should not return empty ISSN Message-ID: <bug-12674-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Bug ID: 12674 Summary: GetMarcISSN should not return empty ISSN Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Currently, GetMarcISSN returns an array of all present ISSN on a specific record. Unlike the GetMarcISBN counterpart, it doesn't filter empty ISSNs out. To reproduce, run the attached regression test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:07:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:07:58 +0000 Subject: [Koha-bugs] [Bug 12674] GetMarcISSN should not return empty ISSN In-Reply-To: <bug-12674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12674-70-GROWgdcG4l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12554 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:07:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:07:58 +0000 Subject: [Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC In-Reply-To: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12554-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12554-70-Cf5Da2GC7V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12674 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:08:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:08:02 +0000 Subject: [Koha-bugs] [Bug 12674] GetMarcISSN should not return empty ISSN In-Reply-To: <bug-12674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12674-70-ilg77VC18b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:08:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:08:54 +0000 Subject: [Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan" In-Reply-To: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12635-70-GaRohkNjS2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:10:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:10:31 +0000 Subject: [Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan" In-Reply-To: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12635-70-HV0fnjoUCD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:10:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:10:34 +0000 Subject: [Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan" In-Reply-To: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12635-70-HwtuqEpsa9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30303&action=edit Bug 12635 - Course reserves item list should use "Checked out" instead of "On Loan" When viewing the list of items on a course reserve list, if the item is checked out it is indicated by the phrase "On Loan." The default templates should always use "checked out" instead of "on loan." Also corrected: the capitalization of "Item Lost." To test, Course Reserves must be enabled and you must have an existing course reserves with items on it, one of which should be checked out. View the list of items on that Course Reserve and confirm that the table says "Checked out." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:16:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:16:19 +0000 Subject: [Koha-bugs] [Bug 12674] GetMarcISSN should not return empty ISSN In-Reply-To: <bug-12674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12674-70-UI7xveZatz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:16:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:16:21 +0000 Subject: [Koha-bugs] [Bug 12674] GetMarcISSN should not return empty ISSN In-Reply-To: <bug-12674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12674-70-gdyzBlmLz5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 30304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30304&action=edit Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN Proves GetMarcISSN returns empty ISSNs in the results array. To reproduce: - Run $ prove -v t/db_dependent/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:16:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:16:28 +0000 Subject: [Koha-bugs] [Bug 12674] GetMarcISSN should not return empty ISSN In-Reply-To: <bug-12674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12674-70-1CdojXmo1l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 30305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30305&action=edit Bug 12674: GetMarcISSN should not return empty ISSN This patch makes GetMarcISSN test for empty subfield before pushing to the result array. To test: - Run the regression test => FAILS for all MARC flavours - Apply the patch - Run the regression test => SUCCESS: tests pass - Sign off Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:38:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:38:05 +0000 Subject: [Koha-bugs] [Bug 4013] road type missing on search results In-Reply-To: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4013-70-VrZxPPGu2H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:41:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:41:31 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-D6ad7Oq7yY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #150 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Latest patch pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:42:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:42:16 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-xknc45WiO8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #30 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Kyle!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 21:42:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 19:42:42 +0000 Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12445-70-KpiyHJpxaP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 22:02:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 20:02:21 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9805-70-yRAzfC5ibl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 22:14:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 20:14:22 +0000 Subject: [Koha-bugs] [Bug 12675] New: Remove CGI::scrolling_list from labeledMARCdetail.pl Message-ID: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12675 Bug ID: 12675 Summary: Remove CGI::scrolling_list from labeledMARCdetail.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org One instance in this file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 22:20:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 20:20:05 +0000 Subject: [Koha-bugs] [Bug 12675] Remove CGI::scrolling_list from labeledMARCdetail.pl In-Reply-To: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12675-70-nfY2mrYLtM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12675 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30306&action=edit Bug 12675: Remove CGI::scrolling_list from labeledMARCdetail.pl This patch removes only instance in this file. Also updates getframework POD on C4/Koha.pm, adds new GetFrameworksLoop() func on same file from suggested code, but with ordered result. To test: 1. Apply the patch 2. Enable viewLabeledMARC syspref 3. On staff, search for a record, goto detail view 4. Clic on Labeled MARC 5. Framework pulldown was replaced, check changing framework. A bug was fixed, because selecting any fw and then Default tries to load values from 'Default' fw code, which does not exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 22:21:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 20:21:12 +0000 Subject: [Koha-bugs] [Bug 12675] Remove CGI::scrolling_list from labeledMARCdetail.pl In-Reply-To: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12675-70-I3BITnQMUU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12675 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|oleonard at myacpl.org |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- This still needs a unit test, trying to figure out how to write it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 22:33:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 20:33:54 +0000 Subject: [Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees In-Reply-To: <bug-12448-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12448-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12448-70-8C2Y9SuOGQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448 Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29371|0 |1 is obsolete| | Attachment #29372|0 |1 is obsolete| | Attachment #29373|0 |1 is obsolete| | Attachment #29374|0 |1 is obsolete| | Attachment #29543|0 |1 is obsolete| | --- Comment #35 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> --- Created attachment 30307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30307&action=edit Bug 12448 - New patch for master v3.17.00.010 Squashed commit of everything there was before. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 22:40:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 20:40:02 +0000 Subject: [Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees In-Reply-To: <bug-12448-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12448-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12448-70-8aoMMYtA1h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448 Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 22:59:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 20:59:41 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10937-70-iB3usWjSH2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28626|0 |1 is obsolete| | Attachment #29383|0 |1 is obsolete| | --- Comment #36 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> --- Created attachment 30308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30308&action=edit Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master. Other patches are now obsolete, this is a squashed patch. Merge conflicts were resolved. Sponsored-by: Vanier college -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:09:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:09:48 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-g1PBcvDfHc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:09:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:09:50 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-qLWeEvpcl5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30116|0 |1 is obsolete| | Attachment #30117|0 |1 is obsolete| | Attachment #30266|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30309&action=edit [PASSED QA] Bug 12457: Removal warning in t/db_dependent/Members.t When I execute prove t/db_dependent/Members.t, this warning appears twice : "Argument "Test" isn't numeric in modulus (%) at /home/yohann/koha/C4/Context.pm line 1256." The warning is due to a invalid use of the routine set_userenv Test plan: 1/ Execute : prove t/db_dependent/Members.t 2/ The warning appears twice : "Argument "Test" isn't numeric in modulus (%) at /home/yohann/koha/C4/Context.pm line 1256." 3/ Apply the patch 4/ Execute : prove t/db_dependent/Members.t 5/ The result has to be a success without error or warning : t/db_dependent/Members.t .. ok All tests successful. Files=1, Tests=26, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.50 cusr 0.08 csys = 1.63 CPU) Result: PASS Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> All new and old tests pass now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:10:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:10:09 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-wU1EkMo1w1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30310&action=edit [PASSED QA] Bug 12457: Adding unit tests for Members.pm Adding unit tests for the routines AddMessage, GetMessages, GetMessagesCount and DeleteMessage in t/db_dependent/Members.t Adding unit tests for the routines GetPendingIssues and GetAllIssues in separate files : t/db_dependent/Members/GetPendingIssues.t and t/db_dependent/Members/GetAllIssues.t The routine GetAllIssues has been modified because it does not test if the arguments was defined : - the borrowernumber argument is required - if the order argument is not given, it takes a value by default : 'date_due desc' - the limit argument is optional Test plan: 1/ Apply the patch 2/ Execute : prove t/db_dependent/Members.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/GetPendingIssues.t 3/ The result has to be a success without error or warning : t/db_dependent/Members.t ................... ok t/db_dependent/Members/GetAllIssues.t ...... ok t/db_dependent/Members/GetPendingIssues.t .. ok All tests successful. Files=3, Tests=83, 5 wallclock secs ( 0.06 usr 0.01 sys + 4.68 cusr 0.26 csys = 5.01 CPU) Result: PASS Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Amended patch: perltidy on t/db_dependent/Members/* Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:10:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:10:45 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-Jbfx4JpqBT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30311&action=edit [PASSED QA] Bug 12457: Allow UT on a non empty database Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:24:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:24:22 +0000 Subject: [Koha-bugs] [Bug 12654] Incorrect quoting in regexp in AuthoritiesMarc In-Reply-To: <bug-12654-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12654-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12654-70-TcmchSLz9C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12654 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:24:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:24:25 +0000 Subject: [Koha-bugs] [Bug 12654] Incorrect quoting in regexp in AuthoritiesMarc In-Reply-To: <bug-12654-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12654-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12654-70-wlMbmm91nc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12654 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30262|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30312&action=edit [PASSED QA] Bug 12654 Correct incorrectly quoted regexp A compile time warning was being generated because \ does not quote { Replace the plethora of \ before meta and presumed meta characters by \Q \E which gets perl to generate all the necessary escapes, we can assume it knows its regex engine as well or better than the human programmer Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Verified change reading the perldoc and also checked that ./misc/link_bibs_to_authorities.pl is no longer showing the warn and still works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:26:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:26:57 +0000 Subject: [Koha-bugs] [Bug 12661] Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt In-Reply-To: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12661-70-aoe1I3f0ld@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|nengard at gmail.com |natalieb at catalyst.net.nz Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:28:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:28:27 +0000 Subject: [Koha-bugs] [Bug 12661] Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt In-Reply-To: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12661-70-MoLWW0RhIH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:28:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:28:32 +0000 Subject: [Koha-bugs] [Bug 12661] Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt In-Reply-To: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12661-70-2TVGRwnVhr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30247|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30313&action=edit [PASSED QA] Bug 12661: Fixing capitalisation from "Item Type" to "Item type" To fix go to help>reports>manager Find capitalisation error "Item Type" Change to "Item type" Signed-off-by: Aleisha <aleishaamohia at hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:33:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:33:40 +0000 Subject: [Koha-bugs] [Bug 12432] Saved reports tabs not working In-Reply-To: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12432-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12432-70-c6BW67blJg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think there is still a bug there - when you switch back from say 'Acquisitions' to 'All' - it's empty. I have 2 reports, one has no group and the other is 'Acquisitions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:38:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:38:52 +0000 Subject: [Koha-bugs] [Bug 12619] Shipment date gets lost on finishing the invoice In-Reply-To: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12619-70-zjTBUmDE47@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:38:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:38:55 +0000 Subject: [Koha-bugs] [Bug 12619] Shipment date gets lost on finishing the invoice In-Reply-To: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12619-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12619-70-2OvqmXDcyO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30245|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30314&action=edit [PASSED QA] Bug 12619 - Shipment date gets lost on finishing and/or editing the invoice To reproduce: - Create a new shipment, make sure to add a shipment date - Receive or not receive orders - Finish receiving with the button at the bottom of the page - Verify that shipment date is now empty To test: - reproduce the aforementioned issue - apply patch - confirm that the issue is no longer rerpoductible (= shipment date is not getting lost any longer), and that there are no apparent regresssions of any kind involving invoice shipment date entering and/or editing - sign off Signed-off-by: Aleisha <aleishaamohia at hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes tests and QA script, fixes the issues, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:44:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:44:27 +0000 Subject: [Koha-bugs] [Bug 12615] Remove CGI::scrolling_list from marc_subfields_structure.pl In-Reply-To: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12615-70-07gSrbvqCC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:44:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:44:30 +0000 Subject: [Koha-bugs] [Bug 12615] Remove CGI::scrolling_list from marc_subfields_structure.pl In-Reply-To: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12615-70-wvHPzFXowl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30260|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30315&action=edit [PASSED QA] Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl This patch removes all instances on this file. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 020 5. Clic 'Edit subfields' button Now the tests proper 6. On any subfield, check pulldown 'Managed in tab', was replaced, so test if it works and search for regressions Change, save, load, change again 7. Clic on 'Advanced constraints' (2) scrolling list removed At the bottom, check 'Koha link', was changed Check assign/remove/save/load values, search for regressions 8. Clic on 'Other options' box Eight(6) scrolling_list removed, they use to feed three pulldowns, so check each one 'Authorised value', 'Thesaurus' 'Plugin' Check assign/remove/save/load values, search for regressions Check adding a new subfield Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes all tests and QA script, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:45:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:45:37 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12528-70-SvsKAsKlcf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |simith.doliveira at inlibro.co |ity.org |m Severity|new feature |enhancement --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Simith, please remember to assign patches to yourself :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 29 23:58:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jul 2014 21:58:12 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12528-70-CSpRtpYZJn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I really like this, as I have been asked to hide the message settings quite often and right now there is no solution the user can't get around. But there is a problem with this patch there: it just deactivates the visibility of the tab in the templates, but it doesn't block accessing the message settings page if you know the URL. I know we have fixed that for other pages in patron account, could you take a look and try to fix this? Database update looks good, the new condition could be added to the existing [%IF ...%], but not a blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 03:02:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 01:02:21 +0000 Subject: [Koha-bugs] [Bug 12325] Marc and Card view in Z39.50 Results doesn't work properly in IE 8 In-Reply-To: <bug-12325-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12325-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12325-70-C3lVZO0Stx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12325 --- Comment #3 from David Cook <dcook at prosentient.com.au> --- (In reply to M. de Rooy from comment #2) > But do we or even should we support IE8 for the staff client? I don't see why not. We don't "officially" support any browser. While IE isn't popular amongst developers, it's used out in the real world. While I might be one of the few willing to report and fix bugs that surface for IE users, I don't think that makes the patches any less useful or desirable for the Koha codebase. If I were adding an IE-specific hack, I could understand some reluctance to include it into the codebase. However, in this case, I'm not adding hacks, doing browser detection, or even feature detection (which I think is actually pretty good to do anyway). I'm removing a line of code that probably shouldn't be there regardless of what browser is executing it. I'm also fixing the display of in-line links for all browser, although I suppose I could've done a separate patch for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 07:27:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 05:27:00 +0000 Subject: [Koha-bugs] [Bug 12587] Improve output of filter information on patrons with the most checkouts report In-Reply-To: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12587-70-q44VERdOFp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12587 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30246|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30316&action=edit [PASSED QA] Bug 12587 - Improve output of filter information on patrons with the most checkouts report This patch makes some changes to the way filter information is displayed after running the patrons with the most checkouts report. Before this patch several untranslatable English strings would be displayed, and library and item type codes would be shown instead of descriptions. To test, go to Reports -> Patrons checking out the most. Enter values for all the filter options: - Checkout date from - Checkout date to - Checkin date from - Checkin date to - Library - Item type - Patron category When you submit the form and view the results you should see your date submissions formatted according to your selected dateformat system preference. The library name and item type names should be shown instead of codes. Signed-off-by: Aleisha <aleishaamohia at hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Improves translatability of the filters output after running the report and the readability of them (removing codes). Note: it would be nice if the read-only would be removed from the date fields, as forcing people to use the date widget is a known accessibility issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 07:26:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 05:26:58 +0000 Subject: [Koha-bugs] [Bug 12587] Improve output of filter information on patrons with the most checkouts report In-Reply-To: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12587-70-G7D17cqkdD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12587 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 07:28:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 05:28:01 +0000 Subject: [Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees In-Reply-To: <bug-12448-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12448-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12448-70-tj9oOtFkt1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|koha-bugs at lists.koha-commun |maxime.beaulieu at inlibro.com |ity.org | --- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Maxime, please remember to assign bugs to yourself, when you are working on them/providing patches, thx! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 07:40:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 05:40:41 +0000 Subject: [Koha-bugs] [Bug 12589] Manage label batch view should show item type description instead of code In-Reply-To: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12589-70-BqYwfcVlDG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12589 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Owen, could you provide a follow-up, making the report name on the reports start page match the table heading and the navigation? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 07:41:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 05:41:30 +0000 Subject: [Koha-bugs] [Bug 12589] Manage label batch view should show item type description instead of code In-Reply-To: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12589-70-WGyJyEtVZB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12589 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am so bad with numbers... ignore the last comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 07:41:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 05:41:48 +0000 Subject: [Koha-bugs] [Bug 12587] Improve output of filter information on patrons with the most checkouts report In-Reply-To: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12587-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12587-70-jlwW0RasGR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12587 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Owen, could you provide a follow-up, making the report name on the reports start page match the table heading and the navigation? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 07:58:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 05:58:35 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11126-70-s1p08wFc7U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Planning to work on this in the next few days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 08:07:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 06:07:07 +0000 Subject: [Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan" In-Reply-To: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12635-70-m3BOEPG0MH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 --- Comment #4 from Marc V?ron <veron at veron.ch> --- Created attachment 30317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30317&action=edit [Signed-off] Bug 12635 - Course reserves item list should use "Checked out" instead of "On Loan" When viewing the list of items on a course reserve list, if the item is checked out it is indicated by the phrase "On Loan." The default templates should always use "checked out" instead of "on loan." Also corrected: the capitalization of "Item Lost." To test, Course Reserves must be enabled and you must have an existing course reserves with items on it, one of which should be checked out. View the list of items on that Course Reserve and confirm that the table says "Checked out." Table in staff client displays "Checked out" / "Item lost" Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 08:07:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 06:07:46 +0000 Subject: [Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan" In-Reply-To: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12635-70-PUv6BcyK03@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30303|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 08:08:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 06:08:00 +0000 Subject: [Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan" In-Reply-To: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12635-70-aouiHEE8LD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 09:02:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 07:02:31 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-2xqDMgBnH2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Matthias, I was only trying to suggest a possible solution here. Tomas is right in that the CAS code requires the OpacBaseURL parameter to be filled out differently than other places in Koha expect it to be and also different to documentation. I am not sure if it won't break other things actually. I passed it anyway, because I felt that this problem was introduced earlier and was not part of the problem that the patch was trying to solve and I didn't want to leave the CAS authentication broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 09:55:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 07:55:07 +0000 Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch In-Reply-To: <bug-12162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12162-70-RwrBVLYuj1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 --- Comment #10 from Marc V?ron <veron at veron.ch> --- (In reply to Katrin Fischer from comment #8) > (...) Additionally to the branchcode it would be > nice to have the currently selected language. That would allow to trigger > the visibility of text with CSS, while you have to use jQuery to do that > right now. We have already a language indicator in the html tag: lang="de-DE" This makes it possible to youse the :lang selector in your CSS. Example: body:lang(de-DE) {background-color: green;} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 09:59:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 07:59:32 +0000 Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch In-Reply-To: <bug-12162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12162-70-JacXjlrEgI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Ah, I didn't know that you could do that with the attribute from the html tag. Thx for the tip! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 10:05:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 08:05:07 +0000 Subject: [Koha-bugs] [Bug 12676] New: Display Lost AV description on OPAC detail pages Message-ID: <bug-12676-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12676 Bug ID: 12676 Summary: Display Lost AV description on OPAC detail pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The lost status in the OPAC detail page always displays as 'lost' and doesn't seem to ever display the description from the authorized value. I can imagine libraries not wanting to see the internal status of a lost item - but as we can differentiate between OPAC and staff description, I think it would be good to leaave to the library to decide. In order to not suddenly display unwanted informtion, maybe we could set the OPAC description for the lost values to 'lost' in a database update? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 10:12:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 08:12:17 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-XsNOZTtZqK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Hi Matthias, Katrin, So.. the requirement to include http/https in the OpacBaseURL is not a regression caused by this patch. I personally still feel it's wrong, but I can't see it as a reason to fail this particular patch. However, agreeing with Tomas's original point. Could you/julian provide some test code that proves the original assumption regarding url_param not taking note of deleted params? Neither me, nor Tomas could prove this in our tests so we're not really sure that this patch fixes the issue as coincidence, or is actually solving the problem outright. As for the OPACBaseURL stuff, we should move that conversation to one of the other related bugs and maybe open a further bug to remind us that it should also be resolved for the CAS case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 10:13:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 08:13:50 +0000 Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch In-Reply-To: <bug-12162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12162-70-x8KySE4Exv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27811|0 |1 is obsolete| | --- Comment #12 from Marc V?ron <veron at veron.ch> --- Comment on attachment 27811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27811 Bug 12162 - Add class="branchcode" to body tag to make OPAC CSS-styleable per branch Proof of concept obsoleted. New patch will follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 10:36:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 08:36:43 +0000 Subject: [Koha-bugs] [Bug 12676] Display Lost AV description on OPAC detail pages In-Reply-To: <bug-12676-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12676-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12676-70-OtaMyAvtvK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12676 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Argh. It already displays the OPAC description - it turns out, if you leave the OPAC description empty, it will always show 'lost', but once you put something in there, the description is displayed perfectly fine. Sorry! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 11:14:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 09:14:08 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-Ic0GsipDve@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Jeremy Evans <Jeremy.evans at nibsc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Jeremy.evans at nibsc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 11:18:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 09:18:55 +0000 Subject: [Koha-bugs] [Bug 9368] specific behavior of yr and acqdate indexes In-Reply-To: <bug-9368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9368-70-ygk6LMsAdj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9368 Fridolin SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 11:18:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 09:18:57 +0000 Subject: [Koha-bugs] [Bug 9368] specific behavior of yr and acqdate indexes In-Reply-To: <bug-9368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9368-70-10kU7jsE90@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9368 Fridolin SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16268|0 |1 is obsolete| | Attachment #26652|0 |1 is obsolete| | Attachment #28916|0 |1 is obsolete| | --- Comment #18 from Fridolin SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 30318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30318&action=edit Bug 9368 [ALTERNATE] - specific behavior of yr and acqdate indexes This patch fixes the "Publication date" and "Acquisition date" searches when using non-QueryParser and QueryParser searches. It adds structure attributes to the template, which is consistent with how phrase searching is currently handled. It removes unnecessary code from Search.pm, adds some necessary code which is consistent with existing code, and adds a lot of explanatory comments. _TEST PLAN_ Before applying: 0) Turn off QueryParser 1) Try a "Publication date" or "Acquisition date" search from the staff client advanced search. 2) Note that even though the description on the result page makes it seem like you're doing an index-specific search, you're actually doing a keyword search. You can verify this by checking the 008 from positions 7 to 10 for "Publication date" or "Date accessioned" on items for "Acquisition date". 3) Turn on QueryParser 4) Try doing the searches from Step 1. 5) A "Publication date" search should probably produce zero results After applying patch: 6) Keep QueryParser on 7) Try doing the searches from Step 1. 8) Notice that you're actually getting results consistent with your search (ie the 008/7-10 shows the date you searched for, and there is a "Date accessioned" in items which matches your search) 9) Turn off QueryParser 10) Note that your results are exactly the same as step 8 (N.B. this is because QueryParser is falling back to non-QP mode instead of producing a bad query.) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 11:21:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 09:21:37 +0000 Subject: [Koha-bugs] [Bug 9368] specific behavior of yr and acqdate indexes In-Reply-To: <bug-9368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9368-70-SHJrggQ3TZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9368 --- Comment #19 from Fridolin SOMERS <fridolyn.somers at biblibre.com> --- Works great, thanks David. I've tested search on year range (yr:1999-2001) and using next/previous page in results. Everything is ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 11:43:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 09:43:10 +0000 Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch In-Reply-To: <bug-12162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12162-70-OMI5lYBFBQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 --- Comment #13 from Marc V?ron <veron at veron.ch> --- Created attachment 30319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30319&action=edit Bug 12162 Add class="branchcode" to body tag to make OPAC CSS-styleable per branch New proof of concept, with opac-main.tt only (in bootstrap), not for signing-off. It shows how branchcode class would be inserted. If no branch is selected, body tag is: <body id="opac-main" class="branch-"> If e.g. branch FFL is selected, body tag is <body id="opac-main" class="branch-FFL "> Examples to test styling in OpacUserCSS: /*No branch, default*/ .branch- { background-color: orange; border: 10px solid green; } /*Branch FFL*/ .branch-FFL { background-color: yellow; border: 10px solid pink; } To see what files would have to be changed: Go to folder: koha-tmpl/opac-tmpl/bootstrap/en git grep "<body" Comments welcome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 12:38:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 10:38:07 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-1EIG1vfTUY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #68 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- Tested ok : - CAS and Shibboleth template coexistence (even though login won't work because of the OPACBaseURL protocol issue, but that is another problem, see bug 12398 and bug 7770). - Shib login / logout (with single sign out) - koha login / logout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 13:07:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 11:07:20 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-6Y9VXpuk1i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30271|0 |1 is obsolete| | --- Comment #462 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30320&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 13:08:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 11:08:00 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-dA7uJjigdk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30272|0 |1 is obsolete| | --- Comment #463 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30321&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 13:08:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 11:08:07 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-TeMB1VXneb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30273|0 |1 is obsolete| | --- Comment #464 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30322&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 13:08:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 11:08:14 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-PoGxTFiabL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30274|0 |1 is obsolete| | --- Comment #465 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30323&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 13:08:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 11:08:20 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-wsJbSv6A2i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30275|0 |1 is obsolete| | --- Comment #466 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30324&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 13:08:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 11:08:29 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-rf1gfEbv0T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30276|0 |1 is obsolete| | --- Comment #467 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30325&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 13:08:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 11:08:35 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-0yMvvoi9cM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30277|0 |1 is obsolete| | --- Comment #468 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30326&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 13:08:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 11:08:45 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-lSniscwHHH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30278|0 |1 is obsolete| | --- Comment #469 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30327&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 13:08:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 11:08:55 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-exi2j8G7ad@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30279|0 |1 is obsolete| | --- Comment #470 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30328&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 13:09:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 11:09:02 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-AnJcV8i2bN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30280|0 |1 is obsolete| | --- Comment #471 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30329&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 13:09:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 11:09:09 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-86Wjz2fIqK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30281|0 |1 is obsolete| | --- Comment #472 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30330&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 13:09:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 11:09:22 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-72R8gdGT9L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30282|0 |1 is obsolete| | --- Comment #473 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30331&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 14:03:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 12:03:50 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-ApnoRCpBer@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 --- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30332&action=edit Bug 12398: Add test for C4::Auth_with_cas::_url_with_get_params Run `prove t/Auth_with_cas.t` to run the test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 14:04:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 12:04:26 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-WmdH7qSCK0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 14:21:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 12:21:32 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-HG6ugvJWYz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 14:44:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 12:44:59 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-qszPQKKYc6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Back to signed off, the QA team should mark it passed-qa as soon as the test is tidied so I push it. FTR: I'd put the test in the t/db_dependent dir, and use something like this for the test description (missing in the current one): is(C4::Auth_with_cas::_url_with_get_params($cgi), "$opac_base_url/cgi-bin/koha/opac-user.pl?bar=baz", "_url_with_get_params should return URL without deleted parameters (Bug 12398)"); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 14:46:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 12:46:43 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: <bug-11244-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11244-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11244-70-XkQO3mmBGO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #29 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Can anyone write a regression test for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 14:47:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 12:47:47 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-nVZ40Rw6ex@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 --- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30333&action=edit Bug 12398: Use mocks to make the test "database independent" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 14:49:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 12:49:17 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-cS1BwHFwdz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30333|0 |1 is obsolete| | --- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30334&action=edit Bug 12398: Use mocks to make the test "database independent" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 15:08:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 13:08:19 +0000 Subject: [Koha-bugs] [Bug 11640] Extending the use of the new routine CalculatePriority In-Reply-To: <bug-11640-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11640-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11640-70-ZTvKBg41nL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11640 Bug 11640 depends on bug 8918, which changed state. Bug 8918 Summary: ILS-DI: HoldTitle and HoldItem do not calculate rank of hold http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 15:08:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 13:08:18 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: <bug-8918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8918-70-w32iDW73I5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 15:10:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 13:10:00 +0000 Subject: [Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP In-Reply-To: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9000-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9000-70-Gd6Cpjglof@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #31 from Nicole C. Engard <nengard at gmail.com> --- Hi all, Can someone help me out here and tell me if/how this changes this section of the manual? http://manual.koha-community.org/3.16/en/opacenhancedcontent.html#customrss Thanks! Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 15:48:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 13:48:50 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-MSwbbLyN4L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30286|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30335&action=edit BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implimented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. BUG8446, Follow up: Correct paths after file rename BUG8446, Follow up: Implimented single sign out - This followup rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implimented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implimentation issue that is well known. BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template ruels so that CAS and Shibboleth can coexist. BUG8446, Follow up: Added default config to config file BUG8446, Follow up: Embelished perldoc documentation - Updated perldoc to correct detail about configuring shibboleth authentication. - Updated perldoc to include subroutines and their respective functions. BUG8446, Follow up: Enable configuration of match field - Added clearer, more flexible, configuration of shibboleth attribute to koha borrower field matching for authenticaion - Correcting of documentation to make it more clear to the current implimentation - Minor refactoring of code to reduce some code duplication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 15:52:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 13:52:18 +0000 Subject: [Koha-bugs] [Bug 12615] Remove CGI::scrolling_list from marc_subfields_structure.pl In-Reply-To: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12615-70-7sh769wQ8l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 15:52:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 13:52:56 +0000 Subject: [Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm In-Reply-To: <bug-12493-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12493-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12493-70-vHlRSLIVjM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 15:54:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 13:54:30 +0000 Subject: [Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class In-Reply-To: <bug-12487-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12487-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12487-70-6IV6kMmyEB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Yohann for all this effort on the unit tests front! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 15:59:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 13:59:57 +0000 Subject: [Koha-bugs] [Bug 12238] tools/export.pl: file list of ids as input parameter In-Reply-To: <bug-12238-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12238-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12238-70-uciJJCn6Th@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12238 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- *** Bug 8346 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 15:59:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 13:59:57 +0000 Subject: [Koha-bugs] [Bug 8346] batch export marc using file of bib numbers In-Reply-To: <bug-8346-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8346-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8346-70-b3ZkC6md8b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8346 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 12238 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:12:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:12:55 +0000 Subject: [Koha-bugs] [Bug 9221] contact note not showing In-Reply-To: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9221-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9221-70-7CkqApSSw4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9221 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:14:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:14:59 +0000 Subject: [Koha-bugs] [Bug 12661] Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt In-Reply-To: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12661-70-vvo2AfozJR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Natalie! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:15:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:15:22 +0000 Subject: [Koha-bugs] [Bug 12654] Incorrect quoting in regexp in AuthoritiesMarc In-Reply-To: <bug-12654-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12654-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12654-70-et5Bj0hrM1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12654 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:27:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:27:03 +0000 Subject: [Koha-bugs] [Bug 4013] road type missing on search results In-Reply-To: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4013-70-n5JFKqGhKG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:27:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:27:06 +0000 Subject: [Koha-bugs] [Bug 4013] road type missing on search results In-Reply-To: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4013-70-iErrqiOK9b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30114|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30336&action=edit Bug 4013 [Revised] road type missing on search results On the patron search results page there are several patron fields which do not show: street number, road type, and state. This patch adds them. To test, go to Patrons -> Search patrons and perform a search. In the table of patron search results each patron record should display the correct information including street number, road type, and state. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:34:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:34:06 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: <bug-10697-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10697-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10697-70-J3Y7Kk6HIQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Chris Cormack from comment #9) > I had a go at resolving this conflict, but can't, Katrin can you take a look > please I too have tried and failed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:35:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:35:30 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7290-70-j10KQgNyo0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28405|0 |1 is obsolete| | --- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30337&action=edit Bug 7290: More granular permissions for order receiving Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:35:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:35:43 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7290-70-J6omuBh2G9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28406|0 |1 is obsolete| | --- Comment #33 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30338&action=edit Bug 7290: Fix constraint name in updatedatabase.pl Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:35:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:35:58 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7290-70-SFZOyfFzsf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28407|0 |1 is obsolete| | --- Comment #34 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30339&action=edit Bug 7290: Use basket branch instead of order line branch Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:36:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:36:11 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7290-70-z9EQd3KbLc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 --- Comment #35 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30340&action=edit Bug 7290: QA fixes 1) Use the new isSuperlibrarian instead of $userflags->{superlibrarian} 2) Update the database update comment 3) Fix capitalization of "Duplicate Barcode" 4) Add comments in t/Acquisition/CanUserReceiveBasket.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:36:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:36:28 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: <bug-10697-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10697-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10697-70-nCmk6Otevq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this needs to be redone probably... should we put a big fat NOTE in the docs of GetReserveStatus meanwhile? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:36:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:36:39 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7290-70-4agWdZqEDv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:40:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:40:55 +0000 Subject: [Koha-bugs] [Bug 12574] BiblioDefaultView doesn't affect XSLT results view In-Reply-To: <bug-12574-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12574-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12574-70-traCXntls0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Could someone take another look at this? It works for me and I'm not sure what might be going wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:46:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:46:48 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: <bug-7292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7292-70-toc4HSoR9i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28484|0 |1 is obsolete| | --- Comment #39 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30341&action=edit Bug 7292: New permission for claims (database changes only) Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:47:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:47:02 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: <bug-7292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7292-70-jetWZrXcgt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28485|0 |1 is obsolete| | --- Comment #40 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30342&action=edit Bug 7292: More granular permissions for claiming orders Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:47:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:47:15 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: <bug-7292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7292-70-IWZGQGBiHX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28486|0 |1 is obsolete| | --- Comment #41 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30343&action=edit Bug 7292: Add new permission to users that have 'order_receive' permission Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:47:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:47:31 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: <bug-7292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7292-70-VuVf7Avfvq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28487|0 |1 is obsolete| | --- Comment #42 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30344&action=edit Bug 7292: German translation for new 'claim for all' permission Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:47:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:47:41 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: <bug-7292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7292-70-wkQhKKt8JV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #43 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30345&action=edit Bug 7292: Use IsSuperLibrarian() instead of $userflags->{superlibrarian} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:48:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:48:37 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: <bug-7292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7292-70-dPb23ocpLG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 16:54:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 14:54:33 +0000 Subject: [Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests In-Reply-To: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12457-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12457-70-qFeRC1BIN4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com Version|unspecified |master --- Comment #18 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 17:04:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 15:04:58 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: <bug-11319-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11319-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11319-70-MxMjzPOm6i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #34 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Started QA on this one; will have some comments tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 17:06:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 15:06:15 +0000 Subject: [Koha-bugs] [Bug 12672] GetMarcISBN should return the corresponding subfield In-Reply-To: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12672-70-9C20ed07nT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30295|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30346&action=edit [SIGNED-OFF] Bug 12672: (regression test) GetMarcISBN should return the corresponding subfield Run: $ prove -v t/db_dependent/Biblio.t => FAIL: GetMarcISBN doesn't return the expected value for ISBN in MARC21, NORMARC and UNIMARC Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Test fails, no koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 17:06:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 15:06:24 +0000 Subject: [Koha-bugs] [Bug 12672] GetMarcISBN should return the corresponding subfield In-Reply-To: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12672-70-mEHUjDgKlC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30296|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30347&action=edit [SIGNED-OFF] Bug 12672: GetMarcISBN should return the corresponding subfield The current GetMarcISBN implementation returns an array of ISBN in which all subfields of a ISBN field occurence are appended. For example, in MARC21, if you have $a and $c defined, they will be appended for output. This happens for $z. To reproduce: - Run the regression tests attached to this bug. To test: - Apply the patch, regression tests pass. - Sign off Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Now test pass, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 17:07:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 15:07:02 +0000 Subject: [Koha-bugs] [Bug 12672] GetMarcISBN should return the corresponding subfield In-Reply-To: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12672-70-unFVFb8wPW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 17:11:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 15:11:35 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12528-70-lNvJmTafK9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #5 from simith.doliveira at inlibro.com --- Created attachment 30348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30348&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Modified: installer/data/mysql/sysprefs.sql -OPACEnhancedMessagingPreferences preference added koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -OPACEnhancedMessagingPreferences preference added koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -access to message setting changed Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 17:27:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 15:27:04 +0000 Subject: [Koha-bugs] [Bug 11888] Random password suggestion does not work twice In-Reply-To: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11888-70-r9EypwFJKe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Juhani! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 17:27:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 15:27:38 +0000 Subject: [Koha-bugs] [Bug 11905] when editing item, cursor is positioning in search box and not to item In-Reply-To: <bug-11905-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11905-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11905-70-mV2xg9HEH4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11905 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 17:37:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 15:37:13 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12528-70-tJlofaj1FQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30348|0 |1 is obsolete| | --- Comment #6 from simith.doliveira at inlibro.com --- Created attachment 30349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30349&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Modified: installer/data/mysql/sysprefs.sql -OPACEnhancedMessagingPreferences preference added koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -OPACEnhancedMessagingPreferences preference added koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -access to message setting changed Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 17:38:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 15:38:50 +0000 Subject: [Koha-bugs] [Bug 12677] New: Use Bootstrap "label" style for inline OPAC renewal messages Message-ID: <bug-12677-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677 Bug ID: 12677 Summary: Use Bootstrap "label" style for inline OPAC renewal messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Bug 12568 adds more prominent renewal messages to the OPAC user's list of checkouts. I would prefer that the messages be styled with a style which is better suited to an inline message. The "alert" style is more suited to block-level messages. With some CSS tweaks the Bootstrap "label" style would work well I think: http://getbootstrap.com/2.3.2/components.html#labels-badges -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 17:45:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 15:45:57 +0000 Subject: [Koha-bugs] [Bug 12677] Use Bootstrap "label" style for inline OPAC renewal messages In-Reply-To: <bug-12677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12677-70-NmkDzRigLz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12568 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 17:45:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 15:45:57 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-m65YNiNzmZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12677 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 17:46:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 15:46:01 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12528-70-EIxpjobt8T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from simith.doliveira at inlibro.com --- Fix done, Url access blocked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 18:09:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 16:09:42 +0000 Subject: [Koha-bugs] [Bug 7817] Items Permanent location (shelving location) is set to NULL when item is edited In-Reply-To: <bug-7817-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7817-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7817-70-7gKH7yXeNh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7817 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 18:09:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 16:09:45 +0000 Subject: [Koha-bugs] [Bug 7817] Items Permanent location (shelving location) is set to NULL when item is edited In-Reply-To: <bug-7817-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7817-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7817-70-rP0SyDC80C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7817 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29093|0 |1 is obsolete| | --- Comment #19 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30350&action=edit [SIGNED-OFF] Bug 7817: A DB field without a default mapping is set to a default value on editing If an item is edited and a field is not mapped to Koha, it is to 0 or NULL (depending on the default value defined). This patch adds a check on the mapping before editing the item. If there is no mapping, the DB value is not erased. Test plan: 1/ Edit an item and fill a value for a field 2/ Unmap this field 3/ Edit the item 4/ Verify that the value is not erased (using the MySQL CLI) Signed-off-by: Owen Leonard <oleonard at myacpl.org> This works as described in the test plan. After unmapping the field edits to the item did not result in loss of the data in that field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 18:27:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 16:27:11 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-DoTdydEocu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #72 from Owen Leonard <oleonard at myacpl.org> --- Some comments about attachment 29870, attachment 29872, and attachment 29877: Although not necessarily required by the HTML5 standard, we do still follow XHTML-style rule for markup. That means that instead of <option value="foo" selected> We need to write <option value="foo" selected="selected"> And values should be quoted: <option value="foo"> And not <option value=foo> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 19:00:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 17:00:36 +0000 Subject: [Koha-bugs] [Bug 12574] BiblioDefaultView doesn't affect XSLT results view In-Reply-To: <bug-12574-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12574-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12574-70-AxOHoAE8gH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 --- Comment #4 from Christopher Brannon <cbrannon at cdalibrary.org> --- Owen, On the chance that I did something wrong in my testing, I tested again. Here is what I found: I found that I was refreshing my search after changing settings, and realized that the view was coded in the URL, so I wasn't going to see any changes. My fault. With today's test, I set OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to default, and see that those are working. I have set BiblioDefaultView to "in their MARC form.", an it works. This is just off a fresh installed master and without your patch installed. Please confirm the problem exists in master. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 19:25:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 17:25:50 +0000 Subject: [Koha-bugs] [Bug 10155] Patron search should remember search options selected In-Reply-To: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10155-70-5LEaRJ5IfL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10155 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 19:26:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 17:26:07 +0000 Subject: [Koha-bugs] [Bug 7462] duplicate patron shows flags In-Reply-To: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7462-70-dkUKqx5uiY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 19:26:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 17:26:40 +0000 Subject: [Koha-bugs] [Bug 7237] duplicating patron not using patron's branch In-Reply-To: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7237-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7237-70-ATQeq1BBss@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7237 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 19:52:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 17:52:31 +0000 Subject: [Koha-bugs] [Bug 12662] Ajax-based check in does not work for some system preference settings enabled In-Reply-To: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12662-70-tNauvRgBGw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Jacek" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 19:58:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 17:58:46 +0000 Subject: [Koha-bugs] [Bug 12678] New: Link 780 & 785 fields to another records using $w Message-ID: <bug-12678-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12678 Bug ID: 12678 Summary: Link 780 & 785 fields to another records using $w Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It should be possible to create links between records for MARC21 fields 780 and 785. The referenced record id should be saved in the $w subfield. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 20:40:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 18:40:32 +0000 Subject: [Koha-bugs] [Bug 12678] Link 780 & 785 fields to another records using $w In-Reply-To: <bug-12678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12678-70-aGcdf4yKEK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12678 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 20:45:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 18:45:48 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: <bug-6864-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6864-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6864-70-Sj4ahf9uCB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Eric B?gin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com --- Comment #22 from Eric B?gin <eric.begin at inLibro.com> --- I think this may be a duplicate of 10951 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 20:54:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 18:54:32 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: <bug-6864-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6864-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6864-70-iGbVE3VbbY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #23 from M. Tompsett <mtompset at hotmail.com> --- 10951 is only partially what this was supposed to cover, as far as I can tell. This should be reworked to use the system preference in 10951. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 21:14:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 19:14:47 +0000 Subject: [Koha-bugs] [Bug 12584] koha-conf.xml for package installations get out of sync In-Reply-To: <bug-12584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12584-70-p4w4QGG5bW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 --- Comment #3 from Magnus Enger <magnus at enger.priv.no> --- Here's a quick and dirty script to update instances one by one, based on template config files. It might work for you if your configs are more or less identical except for instance names and passwords, and not full of per-instance tweaks: https://github.com/MagnusEnger/fix-koha-conf/ Please read the README (and the code) carefully before trying this! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 21:55:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 19:55:34 +0000 Subject: [Koha-bugs] [Bug 12679] New: replace record via z39.50 for authorities Message-ID: <bug-12679-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12679 Bug ID: 12679 Summary: replace record via z39.50 for authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Would be nice if there was a 'replace via Z39.50' for authorities like there is for bibs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 22:09:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 20:09:57 +0000 Subject: [Koha-bugs] [Bug 9163] Cataloguing validation workflow In-Reply-To: <bug-9163-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9163-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9163-70-2qh7t5UszT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #28 from Nick Clemens <nick at quecheelibrary.org> --- I'd be happy to test and get this moving again but needs rebase Applying: BUG 9163 - Cataloguing validation workflow Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging cataloguing/addbooks.pl Auto-merging cataloguing/addbiblio.pl Failed to merge in the changes. Patch failed at 0001 BUG 9163 - Cataloguing validation workflow When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/BUG-9163---Cataloguing-validation-workflow-_DFxmQ.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 22:20:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 20:20:17 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: <bug-12026-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12026-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12026-70-j4AC1gpomI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28408|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30351&action=edit [SIGNED OFF] BUG12026: Adds auto-provisioning to shibboleth - Adds the option to map shibboleth attributes to koha user columns and allows mapping to auto create non-existant users Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 22:20:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 20:20:25 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: <bug-12026-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12026-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12026-70-U1kNFWczLB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30352&action=edit BUG 12026, Follow up: Added Documentation BUG 12026, Follow up: Updated to work with match point selection - The base bug that this patch enhances has added the ability to choose your match point in the configuration file. This patch adds code to take that change into account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 22:21:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 20:21:51 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-KeZua0wVWU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30283|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30353&action=edit MT8122: Adds Shibboleth authentication - Use the shibbolethAuthentication syspref to enable Shibboleth authentication - Configure the shibbolethLoginAttribute to specify which shibboleth user attribute matches the koha login - Make sure the OPACBaseURL is correctly set MT8122, Follow-up: Adds Shibboleth authentication - Fix logout bug: shibboleth logout now occurs only when the session is a shibboleth one. - Do some refactoring: getting shibboleth username is now done in C4::Auth_with_Shibboleth.pm (get_login_shib function) MT8122, Follow-up: Adds Shibboleth authentication - Adds redirect to opac after logout MT8122, Follow-up: Adds Shibboleth authentication - Shibboleth is not compatible with basic http authentication in C4/Auth.pm. This patch fixes that. MT8122, Follow-up: Adds Shibboleth authentication - Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with multiple vhosts. MT8122, Follow-up: Adds Shibboleth authentication - Adds missing protocol for $ENV{'SERVER_NAME'} Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> http://bugs.koha-community.org/show_bug.cgi?id=8446 Signed-off-by: Jesse Weaver <pianohacker at gmail.com> (ByWater employee.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 22:21:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 20:21:59 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-QHFrlq01RX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30284|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30354&action=edit BUG8446, Follow up: Adds Shibboleth authentication - Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont work if koha is behind a reverse proxy. - To use multiple vhosts, set OpacBaseURL per vhost explicitly with 'SetEnv OpacBaseURL Value' as per Bug 10325 BUG8446, Follow up: Adds Shibboleth authentication - Ensure user is returned to requested page after authentication - Added querystring to the target path in shibboleth URL so that when a user is authenticated he/she is returned to the correct page they requested before authentication. Example where this is important: When a user clicks a direct biblio link of the form - /opac-detail.pl?biblionumber=12345 BUG8446, Follow up: Remove unused imports from scripts - Remove import of deprecated C4::Utils module from shibboleth authentication module: Auth_with_shibboleth.pm Signed-off-by: Jesse Weaver <pianohacker at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 22:22:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 20:22:05 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-Ef2pZk8jxZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30285|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30355&action=edit BUG8446, Follow up: Remove unnecessary sysprefs, move to config Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 22:22:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 20:22:12 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-kFAMUiUtsr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30335|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30356&action=edit BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implemented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. BUG8446, Follow up: Correct paths after file rename BUG8446, Follow up: Implemented single sign out - This follow up rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implemented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implementation issue that is well known. BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template rules so that CAS and Shibboleth can coexist. BUG8446, Follow up: Added default config to config file BUG8446, Follow up: Embellished perldoc documentation - Updated perldoc to correct detail about configuring shibboleth authentication. - Updated perldoc to include subroutines and their respective functions. BUG8446, Follow up: Enable configuration of match field - Added clearer, more flexible, configuration of shibboleth attribute to koha borrower field matching for authentication - Correcting of documentation to make it more clear to the current implementation - Minor refactoring of code to reduce some code duplication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 22:32:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 20:32:59 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-LgXjWuduTr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #74 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Right.. I think we're finally there guys! This last update to the final patch takes care of a configuration issue Matthias spotted whereby the config would be parsed incorrectly. To enable forward compatibility with bug 12026 (preventing us having to handle a nasty breaking config change when pushing that patch) and to bring the config in line with that of the way the ldap config currently works the minimum xml required has changed from: <usesshibboleth>1</usesshibboleth> <shibboleth> <matchpoint>userid</matchpoint> <mapping> <userid>uid</userid> </mapping> </shibboleth> to: <usesshibboleth>1</usesshibboleth> <shibboleth> <matchpoint>userid</matchpoint> <mapping> <userid is="uid"></userid> </mapping> </shibboleth> I'm told this is more 'standard' amongst this kind of xml based mapping file and am happy going with it. It also allows for a future form to look like the below without breaking compatibility: <usesshibboleth>1</usesshibboleth> <shibboleth> <matchpoint>userid</matchpoint> <mapping> <userid is="uid" regex="s/@school.ac.uk//g"></userid> <firstname is="fn">default</firstname> </mapping> </shibboleth> The above will hopefully give you a brief glimpse into what I'm thinking for enhancing bug 12026 once this is pushed. Cheers for everyone efforts so far! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 22:58:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 20:58:35 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-MjA8m0AEVy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am sorry, but the patch fails for me when I turn off MySQL. bumblebee:~/kohaclone (91-12398-cas) $ perl t/Auth_with_cas.t 1..1 DBI connect('dbname=koha;host=localhost;port=3306','katrin',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /home/katrin/kohaclone/C4/Context.pm line 802. Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /home/katrin/kohaclone/C4/Context.pm line 802. Compilation failed in require at t/Auth_with_cas.t line 7. BEGIN failed--compilation aborted at t/Auth_with_cas.t line 7. # Looks like your test exited with 255 before it could output anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 23:01:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 21:01:38 +0000 Subject: [Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan" In-Reply-To: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12635-70-lLFsTjrmT7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30357&action=edit [PASSED QA] Bug 12635 - Course reserves item list should use "Checked out" instead of "On Loan" When viewing the list of items on a course reserve list, if the item is checked out it is indicated by the phrase "On Loan." The default templates should always use "checked out" instead of "on loan." Also corrected: the capitalization of "Item Lost." To test, Course Reserves must be enabled and you must have an existing course reserves with items on it, one of which should be checked out. View the list of items on that Course Reserve and confirm that the table says "Checked out." Table in staff client displays "Checked out" / "Item lost" Signed-off-by: Marc V?ron <veron at veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> String change, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 23:02:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 21:02:04 +0000 Subject: [Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan" In-Reply-To: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12635-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12635-70-NbwnlmRhvm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 23:07:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 21:07:10 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-En9tHXKI3I@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 dmin <daniel.minuck at gov.mb.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.minuck at gov.mb.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 23:15:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 21:15:30 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-r9BDB6sbtu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30358&action=edit [PASSED QA] Bug 12597 - Give better visual indication of currently-selected language in the staff client There is currently no visual feedback to the user reflecting which of multiple installed translations is currently selected. I think some necessary styling didn't make it into the conversion to Bootstrap menus. This patch attempts to improve things. Most of the changes are to bring back the previous style of highlighting the currently selected language. A new change is the addition of the sub-language code to the display of the menu label if one of that menu item's sub-languages is selected. This patch also removes some obsolete CSS which referred to the old menu system. To test, apply the patch and install or update multiple languages, including at least two sub-languages. In my test I used en, en-GB and de-DE. Clear your browser cache if necessary. Enable all these languages and test the functionality of the language selection menu in the footer. - Non-enabled languages should appear as non-bold links. - When a single language (with no sub-languages) is enabled it should appear as bold text. - When one of multiple sub-languages is enabled that selection in the pop-up menu should appear as bold text. The menu label should show in bold the language code of the selected sub-language. Tested with de-DE and de-CH, works as expected Signed-off-by: Marc V?ron <veron at veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Works as expected, passes all tests. No problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 23:15:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 21:15:51 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-twISCvG5Er@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 23:15:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 21:15:52 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-xO02wzKAwW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 23:16:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 21:16:17 +0000 Subject: [Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client In-Reply-To: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12597-70-K7LBvN87lm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I like this, can we do something similar for the Boostrap OPAC as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 23:27:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 21:27:39 +0000 Subject: [Koha-bugs] [Bug 12672] GetMarcISBN should return the corresponding subfield In-Reply-To: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12672-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12672-70-fLuvar9sjr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmc at esilibrary.com, | |jcamins at cpbibliography.com, | |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, I am not sure about removing $z - invalid/cancelled ISBN. Adding Jared and Galen in cc, looking for opinions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 23:52:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 21:52:47 +0000 Subject: [Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8 In-Reply-To: <bug-12174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12174-70-LGlRrJtguk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 23:52:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 21:52:50 +0000 Subject: [Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8 In-Reply-To: <bug-12174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12174-70-LHYO1wjU77@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29137|0 |1 is obsolete| | Attachment #29138|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30359&action=edit [PASSED QA] Bug 12174 - Zotero connection with Koha: problem with UTF-8 This patch solves the bug for UTF-8 output. MARC-8 works only if you save it as a file. In fact the standard Internet stack (browser, web server, etc.) doesn't know anything about MARC-8 or it's ISO base (ISO 2022). To test the bug: -- without the patch use Zotero on a recent Koha install with Apache. You can use PTFS sandboxes. You can't use Biblibre sandboxes, they use Ngix. -- Test a record with special chars. -- Install the patch -- Catch (using Zotero) the same record. -- Test all directly download from Opac. -- To check MARC-8, use a tool that support it. For example MarcEdit. http://bugs.koha-community.org/show_bug.cgi?id=12174 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Work as described Tested with zotero add-on for firefox. Before patch bad diacritics, after patch ok Record exported as MARC-8, transformed using yaz-iconv -f marc8 -t utf-8 bib.marc8 > bib.utf8 yaz-marcdump -i marc -o line bib.utf8, checking accents, also comparing with direct utf-8 export No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Tested with Zotero in Firefox and with yaz-iconv as suggested by Bernardo, no problems found. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 30 23:53:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 21:53:16 +0000 Subject: [Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8 In-Reply-To: <bug-12174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12174-70-reo2FpsCp0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30360&action=edit [PASSED QA] Bug 12174 follow-up of the patch (a missing print statement) http://bugs.koha-community.org/show_bug.cgi?id=12174 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 00:01:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 22:01:32 +0000 Subject: [Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl In-Reply-To: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12668-70-NhT2x6TTou@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668 --- Comment #3 from Marc V?ron <veron at veron.ch> --- Created attachment 30361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30361&action=edit [Signed-off] Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl A dollar sign is hard-coded in opac-reserve.pl and becomes apparent when trying to place a reservation when one has "too_much_oweing" or too much fines. Removing the dollar sign so we just get <"K?ytt?maksujen katto ylitetty. Et voi tehd? varauksia. Sinulla on maksamattomia maksuja 9.50."> instead of <"K?ytt?maksujen katto ylitetty. Et voi tehd? varauksia. Sinulla on maksamattomia maksuja $9.50."> Patch removes hard coded $ sign. Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 00:02:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 22:02:21 +0000 Subject: [Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl In-Reply-To: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12668-70-h4uOPCpWiM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30267|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 00:02:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 22:02:37 +0000 Subject: [Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl In-Reply-To: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12668-70-m3DYIsxZy8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 00:02:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 22:02:51 +0000 Subject: [Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl In-Reply-To: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12668-70-2MTVEJYFtQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 00:12:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 22:12:15 +0000 Subject: [Koha-bugs] [Bug 11140] Centralize all sending of email to one subroutine In-Reply-To: <bug-11140-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11140-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11140-70-Z9enas25m6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11140 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 00:30:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 22:30:38 +0000 Subject: [Koha-bugs] [Bug 12634] JavaScript error in Bootstrap OPAC detail page if OPACPopupAuthorsSearch is enabled In-Reply-To: <bug-12634-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12634-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12634-70-Ytumj4122w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12634 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 00:36:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 22:36:25 +0000 Subject: [Koha-bugs] [Bug 3935] Schedule tasks periodically In-Reply-To: <bug-3935-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3935-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3935-70-7iHgxiwmc5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 00:40:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jul 2014 22:40:40 +0000 Subject: [Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl In-Reply-To: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12668-70-qHZkYFpcgk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 06:44:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 04:44:49 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-uxE4Z6QMcF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26878|0 |1 is obsolete| | --- Comment #212 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30362&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: <OPACBaseURL>/cgi-bin/koha/opac-retrieve-file.pl?id=<SHA-1 of the file> So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain at biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 06:44:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 04:44:59 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-lGeoozMr16@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26879|0 |1 is obsolete| | --- Comment #213 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30363&action=edit Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain <paul.poulain at biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 06:45:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 04:45:07 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-rJCmarbCj0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26880|0 |1 is obsolete| | --- Comment #214 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30364&action=edit Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.7 65.0 66.7 100.0 100.0 0.2 86.4 Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 06:45:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 04:45:15 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-L8d1EiKLI9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26881|0 |1 is obsolete| | --- Comment #215 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30365&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 06:45:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 04:45:23 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-hIfQBLPQpV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26882|0 |1 is obsolete| | --- Comment #216 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30366&action=edit Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 06:45:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 04:45:30 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-uDFDIyeARJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26883|0 |1 is obsolete| | --- Comment #217 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30367&action=edit Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 06:45:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 04:45:37 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-ZuuZyVByyy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26884|0 |1 is obsolete| | --- Comment #218 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30368&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 06:45:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 04:45:47 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-frIcYGOpkI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27114|0 |1 is obsolete| | --- Comment #219 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30369&action=edit Bug 6874 - License Text Update This updates the license text for - C4/UploadedFiles.pm - cataloguing/value_builder/upload.pl - opac/opac-retrieve-file.pl to GPL v3 as per the http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence text. TEST PLAN --------- 1) Don't apply this patch as part of 6874. 2) Run the koha qa test tool. -- It will FAIL for those three file. 3) Apply this patch 4) Run the koha qa test tool. -- License problem is corrected, no FAILs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 06:45:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 04:45:54 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-dLwpgwfmlu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27155|0 |1 is obsolete| | --- Comment #220 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30370&action=edit Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, particularly the OPAC system preference: OpacProtocol. This is used to generate the http or https for the OPACBaseURL. This now checks for proper configuration of the system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 06:46:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 04:46:02 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-DGFOhczdwY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27225|0 |1 is obsolete| | --- Comment #221 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 30371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30371&action=edit Bug 6874 - id based on contents, filename, and directory. This patch corrects the inability to upload the same file to a different directory, or even a renamed file to the same directory. By including the filename and directory as part of the $id SHA generation, only identical files in the same directory with the same file name will generate the same $id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 06:47:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 04:47:51 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-TBBh1TogDG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #222 from M. Tompsett <mtompset at hotmail.com> --- I rebased this. However, I am feeling, I may have to bite the bullet and just fix all the hardcoded http references in Koha across the board for bug 5010, so that OPACBaseURL can include https:// or http:// nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:10:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:10:33 +0000 Subject: [Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl In-Reply-To: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12668-70-2t6O7S0X7n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 30372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30372&action=edit [PASSED QA] Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl A dollar sign is hard-coded in opac-reserve.pl and becomes apparent when trying to place a reservation when one has "too_much_oweing" or too much fines. Removing the dollar sign so we just get <"K?ytt?maksujen katto ylitetty. Et voi tehd? varauksia. Sinulla on maksamattomia maksuja 9.50."> instead of <"K?ytt?maksujen katto ylitetty. Et voi tehd? varauksia. Sinulla on maksamattomia maksuja $9.50."> Patch removes hard coded $ sign. Signed-off-by: Marc V?ron <veron at veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> The dollar sign is gone and the message still displays correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:11:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:11:15 +0000 Subject: [Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl In-Reply-To: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12668-70-sPlO0Wgzt9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:11:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:11:17 +0000 Subject: [Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl In-Reply-To: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12668-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12668-70-6aIifDoIBz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30361|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:23:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:23:47 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12027-70-3KulLIxeHz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30373&action=edit BUG 12027: Added shibboleth authentication to the staff client - This patch adds shibboleth authentication to the staff client. - Depending upon how your url structure works, you may or may not need a second native shibboleth service provider profile configured for this to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:31:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:31:12 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12027-70-ovXtcMIwWM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:31:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:31:15 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12027-70-ks10rckAVa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30373|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30374&action=edit BUG 12027: Added shibboleth authentication to the staff client - This patch adds shibboleth authentication to the staff client. - Depending upon how your url structure works, you may or may not need a second native shibboleth service provider profile configured for this to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:34:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:34:13 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12027-70-nML1vbRDsb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30374|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30375&action=edit BUG 12027: Added shibboleth authentication to the staff client - This patch adds shibboleth authentication to the staff client. - Depending upon how your url structure works, you may or may not need a second native shibboleth service provider profile configured for this to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:37:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:37:46 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: <bug-12026-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12026-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12026-70-HKog8VyJVJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30352|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30376&action=edit BUG 12026, Follow up: Added Documentation BUG 12026, Follow up: Updated to work with match point selection - The base bug that this patch enhances has added the ability to choose your match point in the configuration file. This patch adds code to take that change into account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:46:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:46:15 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12027-70-iNetG74Mpa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30375|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 30377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30377&action=edit BUG 12027: Added shibboleth authentication to the staff client - This patch adds shibboleth authentication to the staff client. - Depending upon how your url structure works, you may or may not need a second native shibboleth service provider profile configured for this to work. http://bugs.koha-community.org/show_bug.cgi?id=12026 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:57:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:57:33 +0000 Subject: [Koha-bugs] [Bug 12680] New: Shibboleth adaptive config Message-ID: <bug-12680-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12680 Bug ID: 12680 Summary: Shibboleth adaptive config Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org I wish to enhance the shibboleth system such that you can adapt the config used depending upon some attribute returned from the identity provider. Use case: Given an academic institution, such a place may have rather differing information on record for students as opposed to staff. I've had instances where the mapping between attributes and koha fields has differed wildly between these two groups. Given the there is probably an attribute that can differentiate between the two, then we should be able to use that to load a set of mapping specific to that usergroup. Example intended implementation. <usesshibboleth>1</usesshiboleth> <shibboleth selector="affiliation" value="student"> <matchpoint>userid<matchpoint> <mapping> <userid is="uid"></userid> </mapping> </shibboleth> <shibboleth selector="affiliation" value="staff"> <matchpoint>cardnumber<matchpoint> <mapping> <cardnumber is="libraryID"></cardnumber> </mapping> </shibboleth> So, in the above example config, the intention would be for koha to look for an 'affiliation' attribute first and foremost, and then depending upon it's value (student or staff) load the corresponding configuration and continue as per normal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:58:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:58:45 +0000 Subject: [Koha-bugs] [Bug 12680] Shibboleth adaptive config In-Reply-To: <bug-12680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12680-70-OTzdHRynrn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12680 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8446 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:58:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:58:45 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-uyTkz4bbHP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12680 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:59:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:59:08 +0000 Subject: [Koha-bugs] [Bug 12680] Shibboleth adaptive config In-Reply-To: <bug-12680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12680-70-o55sI4suy2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12680 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12026, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12027 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:59:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:59:08 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: <bug-12026-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12026-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12026-70-gTFkgoXLYG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12680 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 08:59:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 06:59:08 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12027-70-SOq6whAXrg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12680 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 09:01:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 07:01:47 +0000 Subject: [Koha-bugs] [Bug 12681] New: Shibboleth attributes may contain lists Message-ID: <bug-12681-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12681 Bug ID: 12681 Summary: Shibboleth attributes may contain lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org In koha, a shibboleth attribute is always assumed to be a singular value; however an attribute may actually contain a semi-colon separated list of values in a string. We should handle this in koha somehow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 09:01:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 07:01:57 +0000 Subject: [Koha-bugs] [Bug 12681] Shibboleth attributes may contain lists In-Reply-To: <bug-12681-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12681-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12681-70-bbzznabKoZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12681 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8446 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 09:01:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 07:01:57 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-ipFX0XN00z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12681 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 09:07:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 07:07:29 +0000 Subject: [Koha-bugs] [Bug 12682] New: Shibboleth attribute manipulation Message-ID: <bug-12682-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12682 Bug ID: 12682 Summary: Shibboleth attribute manipulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org As koha administrators, we are often not in control of the form in which we will receive an attribute from a shibboleth identity provider. This envisaged enhancement would add the ability to define very simple string manipulations to an attribute in the koha config file. Example of enhanced config: <usesshibboleth>1</usesshibboleth> <shibboleth> <matchpoint>userid</matchpoint> <mapping> <userid is="email" regex="s/@student.university.ac.uk//g"></userid> </mapping> </shibboleth> In the above example, we want to match koha userid to the 'stuff before the @' in the users email attribute. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 09:08:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 07:08:09 +0000 Subject: [Koha-bugs] [Bug 12682] Shibboleth attribute manipulation In-Reply-To: <bug-12682-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12682-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12682-70-GxFdmOFB8i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12682 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8446 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 09:08:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 07:08:09 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-E4X7kvUgdh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12682 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 09:11:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 07:11:11 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-urnHVATBCt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 --- Comment #21 from Julian Maurice <julian.maurice at biblibre.com> --- This is due to C4::Context->preference being called in C4::Auth_with_cas outside of any functions (it gets called on "use"). Rather than writing a workaround for this, I will move the test in t/db_dependent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 09:12:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 07:12:13 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-VWtgdDDJIL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30334|0 |1 is obsolete| | --- Comment #22 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30378&action=edit Bug 12398: Move t/Auth_with_cas.t to t/db_dependent/Auth_with_cas.t This patch obsoletes the previous one with mocks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 09:12:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 07:12:39 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12398-70-JUxEEwUmHo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 10:46:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 08:46:35 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-zZ6mMtwLjS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28974|0 |1 is obsolete| | --- Comment #64 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30379&action=edit Bug 8296: Add descriptive (text) published date field for serials Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 10:46:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 08:46:47 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-QsQYm0vX9c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28975|0 |1 is obsolete| | --- Comment #65 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30380&action=edit Bug 8296: set input maxlength to the same of sql field length Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 10:46:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 08:46:59 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-OFso3EeaXh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28976|0 |1 is obsolete| | --- Comment #66 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30381&action=edit Bug 8296: Follow up for QA Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 10:47:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 08:47:10 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-V1CVheI8oV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28977|0 |1 is obsolete| | --- Comment #67 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30382&action=edit Bug 8296: Don't fill text field automatically Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 10:47:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 08:47:21 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-UVLLGXc97f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #68 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30383&action=edit Bug 8296: Display publisheddatetext in OPAC bootstrap theme and remove modifications for OPAC prog theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 10:47:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 08:47:48 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-3iFIyBjTYl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 11:07:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 09:07:51 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10402-70-ShvhR01utU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Paola Rossi <paola.rossi at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #83 from Paola Rossi <paola.rossi at cineca.it> --- Today I've tried to apply against 3.17.00.011 Applying: Bug 10402: Use an object for contacts Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging acqui/supplier.pl So I pass the patch to "Patch doesn't apply" status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 11:15:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 09:15:00 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-xykO29Gm8r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #75 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- Tested ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 11:20:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 09:20:38 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-b3GMO0ZIKx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Matthias Meusburger <matthias.meusburger at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30356|0 |1 is obsolete| | --- Comment #76 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- Created attachment 30384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30384&action=edit BUG8446, Follow up: Improve local login fallback Signed-off patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 11:21:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 09:21:46 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-dxIU5AvVe3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Matthias Meusburger <matthias.meusburger at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 11:24:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 09:24:57 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8446-70-kdQkS6DXRg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #77 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Matthias, can you add your sign off line to the other patches too please? And thx for signing off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 11:31:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 09:31:28 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-GxGrX0zgLY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29357|0 |1 is obsolete| | --- Comment #27 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30385&action=edit Bug 8995: Show OpenURL links in OPAC search results Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 11:31:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 09:31:39 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-mefSevJaAh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29358|0 |1 is obsolete| | --- Comment #28 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30386&action=edit Bug 8995: Use uri_escape_utf8 instead of uri_escape Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 11:31:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 09:31:49 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-adh6NuKi7e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29359|0 |1 is obsolete| | --- Comment #29 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30387&action=edit Bug 8995: Show OpenURL links in bootstrap theme Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 11:31:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 09:31:55 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-k692f4koOx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #30 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30388&action=edit Bug 8995: Add OpenURL link to OPAC bootstrap XSLT files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 11:32:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 09:32:01 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-lnIOEdfMQU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #31 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30389&action=edit Bug 8995: Change meaning and name of syspref OPACHideOpenURLForItemTypes OPACHideOpenURLForItemTypes is now named OPACOpenURLItemTypes and do the exact opposite as before: it shows OpenURL link only if the biblio itemtype is in the syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 11:43:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 09:43:01 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-2zOVjAlVl7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #25) > I'm disappointed, because I made a lot of tests and everything is OK except > I can't see the openurl link when I Set sysprefs OPACXSLTDetailsDisplay and > OPACXSLTResultsDisplay to "default". > It works very well when this sysprefs are empty (tested with two different > open resolvers with electronic journals and ebooks.) Fixed by attachment 30388 > Two more remarks : > I agree with David Cook (Comment 18) : we usually use open url for 2 item > types, it would be easier to list only those two and not all the others. Fixed by attachment 30389 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 11:43:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 09:43:56 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-ysLLXW2aBm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #33 from Julian Maurice <julian.maurice at biblibre.com> --- > It is possible to open the link in a new tab (I activate the syspref > OPACOpenInNewWindow, but there is no difference) I wasn't aware of OpacOpenInNewWindow syspref, I will take a look to see what I can do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 12:07:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 10:07:58 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-TyRhJhP5EZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #34 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 30390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30390&action=edit Bug 8995: Consider OPACURLOpenInNewWindow for OpenURL links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 13:06:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 11:06:03 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: <bug-11319-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11319-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11319-70-wyCJyfaQWl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #35 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- QA Comment: In general these patches look good to me. I have the impression that this feature still needs some work however. Here are some comments to start with: [1] The last patch (template mods) adds the restriction: A move/copy/update should have a subfield. If I want to update control field 003 to some text, it should be possible. There is no subfield. (Blocker.) It also says: move/copy source and dest should have either a subfield or not. I agree that it is normal behavior. But suppose that I want to copy some field to a controlfield? This is somewhat unlikely, but it would not be wrong. (No blocker since I do not have a real application for it at hand.) [2] Some code in the third patch for update_field: + if ( not $subfieldName or $subfieldName eq '' ) { + # FIXME I'm not sure the actual implementation is correct. + die "This action is not implemented yet"; + #_update_field({ record => $record, field => $fieldName, values => \@values }); This actually is the situation I was referring to (I want to update a control field without subfield). At this moment you are blocking an update without subfield in the interface. This makes it hard to reach this die statement.. [3] Just looking at some code in SimpleMarc.pm, I notice the following: field_equals just picks the first field value and runs the regex. If I do not pass a subfield, it does not run the regex over the whole field just one subfield. If I pass a subfield and the record contains repeated subfields, it just checks the first one. This is not the behavior that I would (intuitively) expect from the interface. Note that your patch does not really touch that part of code, but you do touch the routine. Is improving that functionality not even more important than passing a hashref? [4] BTW See some warnings in the log: [Wed Jul 30 16:37:51 2014] stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at Template/Provider.pm line 964., referer: /cgi-bin/koha/tools/stage-marc-import.pl [Wed Jul 30 16:37:51 2014] stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at Template/Provider.pm line 964., referer: /cgi-bin/koha/tools/stage-marc-import.pl [Wed Jul 30 16:53:18 2014] marc_modification_templates.pl: Use of uninitialized value in string eq at tools/marc_modification_templates.pl line 70., referer: /cgi-bin/koha/tools/marc_modification_templates.pl?template_id=3&op=delete_action&mmta_id=8 [Wed Jul 30 16:53:31 2014] marc_modification_templates.pl: Use of uninitialized value $template_id in string eq at C4/MarcModificationTemplates.pm line 84., referer: /cgi-bin/koha/tools/marc_modification_templates.pl Setting status to Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 13:13:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 11:13:31 +0000 Subject: [Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b In-Reply-To: <bug-12465-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12465-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12465-70-OWKrYDYOT6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #6 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- QA: Taking a look :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 13:19:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 11:19:37 +0000 Subject: [Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b In-Reply-To: <bug-12465-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12465-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12465-70-36GfR9wwhM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 --- Comment #7 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30391&action=edit Bug 12465: Improve display of MARC21 710 in intranet and OPAC Currently, 710$a and $b and $b will not display correctly. This patch tries to improve the display adding the missing space between both subfields. Please test. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Tested, work as described on staff & opac for 710 detailed view. Add space and punctuation. No errors. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 13:24:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 11:24:57 +0000 Subject: [Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b In-Reply-To: <bug-12465-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12465-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12465-70-zAVbtB97j5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 --- Comment #8 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- QA Comment: This patch improves the situation. Before $a and $b were glued together. Now we have a space in between everywhere for subfields a-b-c-d-n. I am not saying that we already reached the ideal solution. Just listing multiple $b's after $a with a space (and even more subfields possible) may probably not always be so clear. But I do not have "the better solution" at hand for this moment :) Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 13:25:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 11:25:04 +0000 Subject: [Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b In-Reply-To: <bug-12465-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12465-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12465-70-nAt1fQIK2A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 13:26:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 11:26:19 +0000 Subject: [Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b In-Reply-To: <bug-12465-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12465-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12465-70-dtlXbTq1XV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 13:30:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 11:30:35 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9180-70-8dPv2yQK2v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl --- Comment #26 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- QA: Taking a look -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 13:36:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 11:36:30 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9180-70-P7SZUSQLxy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch --- Comment #27 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Changing complexity: Changing a routine in a module (Overdues) is generally not considered trivial. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:00:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:00:46 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9180-70-lHLUsfTeba@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:00:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:00:48 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9180-70-1m8CqkORo7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29548|0 |1 is obsolete| | --- Comment #28 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30392&action=edit Bug 9180: All branches should be returned if a default rule exists The C4::Overdues::GetBranchcodesWithOverdueRules routine has a bug. If a default rule *and* a specific rule exist, only the branchcode for the specific rule is returned. Test plan: prove t/db_dependent/Overdues.t and verify the unit tests are consistent. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:13:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:13:33 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8687-70-AzxBsMhGBr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira at inlibro.co | |m Assignee|fcapovilla at live.ca |simith.doliveira at inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:14:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:14:27 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10402-70-IVuDWHXkDJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #84 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to Paola Rossi from comment #83) > Today I've tried to apply against 3.17.00.011 > > Applying: Bug 10402: Use an object for contacts > Using index info to reconstruct a base tree... > Falling back to patching base and 3-way merge... > Auto-merging acqui/supplier.pl > > So I pass the patch to "Patch doesn't apply" status This message doesn't mean that the patch doesn't apply. It's just telling you that there were other changes made to acqui/supplier.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:14:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:14:53 +0000 Subject: [Koha-bugs] [Bug 12407] phone label or data switched In-Reply-To: <bug-12407-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12407-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12407-70-PMkI1MZxCn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 --- Comment #8 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30393&action=edit Bug 12407 - phone label or data switched Fix for switched phone numbers on patron details page. This patch fixes switched phone numbers on patron details page and also makes phone number labels more uniform. To Test: 1. Apply the patch. 2. Create/modify a patron entering some unique data into the "Secondary phone:" and "Other phone:" fields (different data for each). 3. Save the patron record. 4. Go to the patrons details page and make sure the data entered into the "Secondary phone:" field is displaying next to the "Secondary phone:" label and that the data entered into the "Other phone:" field is displaying next to the "Other phone:" label. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:15:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:15:10 +0000 Subject: [Koha-bugs] [Bug 12407] phone label or data switched In-Reply-To: <bug-12407-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12407-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12407-70-HzEowmazTR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:28:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:28:31 +0000 Subject: [Koha-bugs] [Bug 12407] phone label or data switched In-Reply-To: <bug-12407-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12407-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12407-70-UXoORdVZlt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 --- Comment #9 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30394&action=edit Bug 12407: [QA Follow-up] Rename Other Phone to Mobile in staff Touches three member templates. Changes label Other into Mobile. This is consistent with database field name and OPAC. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:31:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:31:23 +0000 Subject: [Koha-bugs] [Bug 12407] phone label or data switched In-Reply-To: <bug-12407-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12407-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12407-70-syoH3U2b4b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- QA Comment: Looks good to me. With reference to bug 8760, I added a QA follow-up to rename Other to Mobile in three member templates. Also note that the field names in the database such as phonepro for secondary phone do not make it easier. Will put a note on the other report too. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:31:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:31:43 +0000 Subject: [Koha-bugs] [Bug 12407] phone label or data switched In-Reply-To: <bug-12407-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12407-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12407-70-h0xKTEjgwK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #11 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- *** Bug 8760 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:31:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:31:43 +0000 Subject: [Koha-bugs] [Bug 8760] Phone number Field tags are reversed in patron record In-Reply-To: <bug-8760-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8760-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8760-70-vlHEWwYxKV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |m.de.rooy at rijksmuseum.nl Resolution|--- |DUPLICATE --- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- *** This bug has been marked as a duplicate of bug 12407 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:32:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:32:34 +0000 Subject: [Koha-bugs] [Bug 12407] phone label or data switched In-Reply-To: <bug-12407-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12407-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12407-70-lUiGrVMWKL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:42:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:42:02 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8735-70-o65Y7mwhF5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28660|0 |1 is obsolete| | Attachment #28661|0 |1 is obsolete| | Attachment #28662|0 |1 is obsolete| | Attachment #28663|0 |1 is obsolete| | --- Comment #40 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30395&action=edit Bug 8735 - Expire holds waiting only on days the library is open Signed-off-by: Leila <koha.aixmarseille at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:42:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:42:09 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8735-70-7ZjwW2aXyX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 --- Comment #41 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30396&action=edit Bug 8735 - Expire holds waiting only on days the library is open - Followup - Switch from C4::Calendar to Koha::Calendar Test Plan: 1) Set ExpireReservesMaxPickUpDelay 2) Set ReservesMaxPickUpDelay to 1 3) Place a hold, set it to waiting 4) Using the MySQL console, modify the waiting date and set it to the day before yesterday. 5) Set today as a holiday for the pickup branch in question. 6) Run misc/cronjobs/holds/cancel_expired_holds.pl 7) The hold should remain unchanged 8) Remove today as a holiday 9) Run misc/cronjobs/holds/cancel_expired_holds.pl again 10) The hold should now be canceled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:42:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:42:15 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8735-70-UtllSJtVim@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 --- Comment #42 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30397&action=edit Bug 8735 [QA Followup] - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:42:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:42:20 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8735-70-BBsgXMz9ia@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 --- Comment #43 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30398&action=edit Bug 8735 [QA Followup 2] - Remove extra period, add bug number to db update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:42:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:42:47 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8735-70-OJGyf2HcSO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 --- Comment #44 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Trivial rebase. Will take a look now for QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:43:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:43:02 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8735-70-CC7Q32PSsG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 14:43:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 12:43:13 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8735-70-YC08Yc7qvp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 15:14:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 13:14:50 +0000 Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6113-70-0V0ObEseYl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply --- Comment #27 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- This patch just created an issue for us in conjunction with Bug 12624. It was very useful in our initial migration but after that it will be worthless. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 15:16:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 13:16:25 +0000 Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6113-70-xykLteNQBo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113 --- Comment #28 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- BTW the issue was existing biblios getting overwritten by new records from staging tables. So if C4::Biblio::_koha_add_biblio() returns an error, the rest of the instructions are carried out normally, eg. ModBiblio, which overwrites the existing marc record even if the "adding new record to a reserved biblionumber" just failed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 15:37:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 13:37:01 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8735-70-CCEX4VHeAt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 --- Comment #46 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30400&action=edit Bug 8735 - Expire holds waiting only on days the library is open - Followup - Switch from C4::Calendar to Koha::Calendar Test Plan: 1) Set ExpireReservesMaxPickUpDelay 2) Set ReservesMaxPickUpDelay to 1 3) Place a hold, set it to waiting 4) Using the MySQL console, modify the waiting date and set it to the day before yesterday. 5) Set today as a holiday for the pickup branch in question. 6) Run misc/cronjobs/holds/cancel_expired_holds.pl 7) The hold should remain unchanged 8) Remove today as a holiday 9) Run misc/cronjobs/holds/cancel_expired_holds.pl again 10) The hold should now be canceled Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 15:36:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 13:36:57 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8735-70-w3bEPlKbOP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30395|0 |1 is obsolete| | Attachment #30396|0 |1 is obsolete| | Attachment #30397|0 |1 is obsolete| | Attachment #30398|0 |1 is obsolete| | --- Comment #45 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30399&action=edit Bug 8735 - Expire holds waiting only on days the library is open Signed-off-by: Leila <koha.aixmarseille at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 15:37:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 13:37:09 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8735-70-ubcUPJu0m3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 --- Comment #48 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30402&action=edit Bug 8735 [QA Followup 2] - Remove extra period, add bug number to db update Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 15:37:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 13:37:05 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8735-70-pMLnU7dce2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 --- Comment #47 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 30401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30401&action=edit Bug 8735 [QA Followup] - Add Unit Tests Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 15:37:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 13:37:30 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8735-70-dQsLd5bhb3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 15:39:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 13:39:48 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8687-70-PaW35zTZfl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 15:40:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 13:40:18 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8687-70-GDHBAW1IWt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 15:40:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 13:40:32 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8687-70-bPU0jKH1EB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 15:42:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 13:42:40 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8687-70-UlOsuxJ5gk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 --- Comment #23 from simith.doliveira at inlibro.com --- Created attachment 30403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30403&action=edit Bug 8687 - Improvements in overdue_notices.pl Improvements in the overdue_notices.pl script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 15:43:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 13:43:16 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8687-70-Ebb8d6n6KV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23229|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 15:43:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 13:43:46 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8687-70-GbGaHYThGq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 16:05:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 14:05:14 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-xcjFrApbNt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29870|0 |1 is obsolete| | --- Comment #73 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30404&action=edit Bug 766: Remove CGI::scrolling_list from aqplan.pl This patch removes 3 occurences on aqplan.pl To test: 1. You need a budget and a found 2. Apply the patch 3. Go to Aquisitions, click on your found 4. Select one of the options on pulldown Planning e.g. "Plan by months" 5. Now to the left there are two boxes, Filter and Export a) Filter: (1) pulldown below 'Select planning type' check that works selecting other values and submit This pulldown showed originally code types, untranslatable BTW. Added a TT block to allow translation and shows legends that match Planning pulldown, but not the order. b) Export: pulldowns for filetype (2) and delimiter (3) Those have originally one value each, and for me Export does not work, before or after patch, but check that pulldown exist. Notes: A) 5.a) I can change de order of main Planning pulldown, is harcoded. The values for Filter pulldown are sorted on aqplan.pl. Is one or the other. If desired, TT block can be moved to includes/budgets-admin-toolbar.inc (where hardcoded Planning lives) B) 5.b) Moved 'Export' legend inside it's box, like Filter. C) Finally: there is something strange, before or after patch. There is an empty option 'Planning by " if you select planning using main pulldown, it disappears if you select planning using Filter (not a mistery, using Planning fills $auth_cats_loop, using Filter submit button does not) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 16:05:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 14:05:22 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-m4QVS2bgJZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29872|0 |1 is obsolete| | --- Comment #74 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30405&action=edit Bug 766: Remove CGI::scrollinglist from authorised_values.pl This patch removes the only instance in this file. Also fixes array sorting, removes some tabs, removes an unneeded $dbh handler (there is a global one). Makes use of C4::Koha::GetAuthorisedValueCategories. To test: 1. Apply the patch 2. Go to Administration > Authorised values 3. Replaced pulldown next to 'Show category' must show all (present & system) categories correctly ordered. 4. Select some and check for regressions, e.g. CCODE, Bsort2, YES_NO no changes must be observed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 16:05:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 14:05:29 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-9VhvpvggdV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29877|0 |1 is obsolete| | --- Comment #75 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30406&action=edit Bug 766: Remove CGI::scrollinglist from marctagstructure.pl This patch removes the only instance in this file. Don't know if the feature is of some utility, seems that does not work (no use of auth values as indicators on MARC editor) To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic on MARC structure of any fw 4. Clic Edit on any tag 5. On tag editor check the pulldown 'Authorised value', that was replaced 6. Check for regressions: select a value, save, verify the value, change again, etc. Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories Do not we need an AuthorisedValues.pm? (on C4 or Koha) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 16:08:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 14:08:06 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-MRQdSO2sn4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #76 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Owen Leonard from comment #72) > That means that instead of <option value="foo" selected> > We need to write <option value="foo" selected="selected"> > > And values should be quoted: <option value="foo"> > And not <option value=foo> Thanks Owen, fixed now. I'll add a followup to some others that have been pushed, and fix also others awaiting sings. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 16:17:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 14:17:16 +0000 Subject: [Koha-bugs] [Bug 12673] Remove CGI::scrolling_list from C4::Items.pm In-Reply-To: <bug-12673-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12673-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12673-70-4giopUrAKH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30301|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30407&action=edit Bug 12673: Remove CGI::scrolling_list from C4::Items.pm This patch removes only instance in this file To test: 1. Apply the patch 2. (Esay way) Put on staff URL /cgi-bin/koha/services/itemrecorddisplay.pl?biblionumber=N&itemnumber=M 3. Code replaced corresponds to pulldowns, verify information is correct (check with another item edit view) PrepareItemrecordDisplay() in Items.pm is filled with chunks of HTML code that must be put on TT file. For now scrolling_list is the only removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 16:29:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 14:29:09 +0000 Subject: [Koha-bugs] [Bug 12675] Remove CGI::scrolling_list from labeledMARCdetail.pl In-Reply-To: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12675-70-SGQQZUX0g6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12675 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30306|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30408&action=edit Bug 12675: Remove CGI::scrolling_list from labeledMARCdetail.pl This patch removes only instance in this file. Also updates getframework POD on C4/Koha.pm, adds new GetFrameworksLoop() func on same file from suggested code, but with ordered result. To test: 1. Apply the patch 2. Enable viewLabeledMARC syspref 3. On staff, search for a record, goto detail view 4. Clic on Labeled MARC 5. Framework pulldown was replaced, check changing framework. A bug was fixed, because selecting any fw and then Default tries to load values from 'Default' fw code, which does not exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 16:31:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 14:31:40 +0000 Subject: [Koha-bugs] [Bug 12675] Remove CGI::scrolling_list from labeledMARCdetail.pl In-Reply-To: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12675-70-RKVw1OWyMp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12675 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30409&action=edit Bug 12675: Add unit test to GetFrameworksLoop to test: 1. Apply the patch 2. Run the test, prove t/db_dependent/Koha.t 3. Check that it pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:04:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:04:49 +0000 Subject: [Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8 In-Reply-To: <bug-12174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12174-70-6S9dk1iV8i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Zeno! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:05:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:05:09 +0000 Subject: [Koha-bugs] [Bug 12683] New: Use NOLoginInstructions to customize text for OPAC user/pass information Message-ID: <bug-12683-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 Bug ID: 12683 Summary: Use NOLoginInstructions to customize text for OPAC user/pass information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P4 Component: OPAC Assignee: simith.doliveira at inlibro.com Reporter: simith.doliveira at inlibro.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:05:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:05:49 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12568-70-6pugXybGiv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed by Module Maintainer |Pushed to Master CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:07:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:07:31 +0000 Subject: [Koha-bugs] [Bug 12683] Use NoLoginInstructions to customize text for OPAC user/pass information In-Reply-To: <bug-12683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12683-70-3kLnZCr19j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira at inlibro.co | |m Summary|Use NOLoginInstructions to |Use NoLoginInstructions to |customize text for OPAC |customize text for OPAC |user/pass information |user/pass information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:10:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:10:20 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: <bug-12669-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12669-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12669-70-QBhGMf4Hx6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 --- Comment #2 from Rolando Isidoro <rolando.isidoro at gmail.com> --- Hey Colin, following on your comment I tried to fix the problem on my own and I think I narrowed it to 1 code entry: $dt->set_time_zone( C4::Context->tz ); @ https://github.com/digibib/koha-work/blob/master/Koha/DateUtils.pm#L126 Since my knowledge regarding Koha's codebase is limited I now have doubts on how to proceed, but I think it would be as simple as replacing that line for: my $tz = $dateonly ? DateTime::TimeZone->new(name => 'floating') : C4::Context->tz; $dt->set_time_zone( $tz ); What's your take on this solution? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:24:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:24:18 +0000 Subject: [Koha-bugs] [Bug 12507] Don't show News in Staff and opac in 3.16.0 / 3.16.1 In-Reply-To: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12507-70-vzYjw06ATB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- I can confirm this bug. There is no error message in the logs! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:28:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:28:59 +0000 Subject: [Koha-bugs] [Bug 12507] Don't show News in Staff and opac in 3.16.0 / 3.16.1 In-Reply-To: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12507-70-IdPHtIOim5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:29:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:29:02 +0000 Subject: [Koha-bugs] [Bug 12507] Don't show News in Staff and opac in 3.16.0 / 3.16.1 In-Reply-To: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12507-70-9fCrsDCOth@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30410&action=edit Bug 12507 - Don't show News in Staff and opac -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:29:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:29:12 +0000 Subject: [Koha-bugs] [Bug 12507] Don't show News in Staff and opac in 3.16.0 / 3.16.1 In-Reply-To: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12507-70-bOrwnU0Ty7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:29:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:29:56 +0000 Subject: [Koha-bugs] [Bug 12507] Don't show News in Staff and opac in 3.16.0 / 3.16.1 In-Reply-To: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12507-70-8Rp1pdZvoQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- I have no idea how to trigger this bug, but the tester can at least prove it does not cause a regression, I think that should be enough! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:31:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:31:55 +0000 Subject: [Koha-bugs] [Bug 12507] News does not always display in staff or OPAC In-Reply-To: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12507-70-PAPj6Ldkjw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |--- Assignee|kyle at bywatersolutions.com |koha-bugs at lists.koha-commun | |ity.org Summary|Don't show News in Staff |News does not always |and opac in 3.16.0 / 3.16.1 |display in staff or OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:34:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:34:26 +0000 Subject: [Koha-bugs] [Bug 12507] News does not always display in staff or OPAC In-Reply-To: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12507-70-AWuFzm6Ln2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30410|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30411&action=edit Bug 12507 - News does not always display in staff or OPAC News will not display on the last day of each month due to the way the date is calculated in the SQL code for grabbing news. Test Plan: 1) Create a news item that should display 2) Change your server's date to the last day of the month 3) Note you can no longer see that news item 4) Apply this patch 5) Note you can now see your news item again -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:37:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:37:25 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: <bug-12669-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12669-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12669-70-rxBgvG0qmB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 --- Comment #3 from Rolando Isidoro <rolando.isidoro at gmail.com> --- It looks like there is another code entry that needs correction: my $dt = dt_from_string( $text, 'iso' ); @ https://github.com/digibib/koha-work/blob/master/Koha/Template/Plugin/KohaDates.pm#L32 becomes: my $tz = DateTime::TimeZone->new(name => 'floating') unless $config->{with_hours}; my $dt = dt_from_string( $text, 'iso', $tz ); With these 2 fixes in place the "Serial collection" page is rendered correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:49:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:49:20 +0000 Subject: [Koha-bugs] [Bug 12507] News does not always display in staff or OPAC In-Reply-To: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12507-70-C5LM7R4WUZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:49:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:49:24 +0000 Subject: [Koha-bugs] [Bug 12507] News does not always display in staff or OPAC In-Reply-To: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12507-70-rAPdTmM9i3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30411|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30412&action=edit [SIGNED-OFF] Bug 12507 - News does not always display in staff or OPAC News will not display on the last day of each month due to the way the date is calculated in the SQL code for grabbing news. Test Plan: 1) Create a news item that should display 2) Change your server's date to the last day of the month 3) Note you can no longer see that news item 4) Apply this patch 5) Note you can now see your news item again Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:51:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:51:29 +0000 Subject: [Koha-bugs] [Bug 12507] News does not always display in staff or OPAC In-Reply-To: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12507-70-oKhWo7rHNw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Tools Hardware|PC |All Version|3.16 |master Assignee|koha-bugs at lists.koha-commun |gmcharlt at gmail.com |ity.org | OS|Linux |All -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:53:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:53:12 +0000 Subject: [Koha-bugs] [Bug 12507] News does not always display in staff or OPAC In-Reply-To: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12507-70-stlp3M0pRg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 17:58:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 15:58:39 +0000 Subject: [Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age In-Reply-To: <bug-11630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11630-70-tMYvM7gCE2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #11 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Just rebasing our production branch to 3.16.x and wanted to thank you guys for your great work in getting this through! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 18:26:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 16:26:44 +0000 Subject: [Koha-bugs] [Bug 12675] Remove CGI::scrolling_list from labeledMARCdetail.pl In-Reply-To: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12675-70-reQoOD4fn1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12675 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30409|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30413&action=edit Bug 12675: Add unit test to GetFrameworksLoop to test: 1. Apply the patch 2. Run the test, prove t/db_dependent/Koha.t 3. Check that it pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 18:27:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 16:27:43 +0000 Subject: [Koha-bugs] [Bug 12675] Remove CGI::scrolling_list from labeledMARCdetail.pl In-Reply-To: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12675-70-11Ux9uKEQn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12675 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Ready to sign -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 18:39:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 16:39:11 +0000 Subject: [Koha-bugs] [Bug 12684] New: Linking authorities to 65X field adds "7" as second indicator. Message-ID: <bug-12684-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12684 Bug ID: 12684 Summary: Linking authorities to 65X field adds "7" as second indicator. Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: verolencinas at yahoo.com.ar QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Linking an authority to a subject field (65X mostly) copies the value "7" as second indicator. According to the MARC 21 Format for Bibliographic Data (http://www.loc.gov/marc/bibliographic/bd650.html) second indicator = 7 means that the source of the subject heading is recorded in subfield $2 (in coded form). That means that every time a cataloger links an authority record he or she has to change this indicator or to add the applicable code in subfield $2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 18:39:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 16:39:58 +0000 Subject: [Koha-bugs] [Bug 12685] New: search history page missing help file Message-ID: <bug-12685-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12685 Bug ID: 12685 Summary: search history page missing help file Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org patch to come. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 18:42:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 16:42:03 +0000 Subject: [Koha-bugs] [Bug 12507] News does not always display in staff or OPAC In-Reply-To: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12507-70-xk0VwdXtbj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 --- Comment #7 from MetaBiblioteca Colombia <felipe.gomez3 at gmail.com> --- Many Thanks for this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 18:42:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 16:42:52 +0000 Subject: [Koha-bugs] [Bug 12685] search history page missing help file In-Reply-To: <bug-12685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12685-70-wbFCZQedBS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12685 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 18:42:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 16:42:54 +0000 Subject: [Koha-bugs] [Bug 12685] search history page missing help file In-Reply-To: <bug-12685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12685-70-cbJkOJwNSV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12685 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 30414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30414&action=edit Bug 12685: Add help file for staff search history This patch adds a missing help file for the staff search history page. To test: * Turn on EnableSearchHistory * Do a search in the catalog * Click your username in the top right and choose 'search history' * Click 'help' in the top right * Confirm that help file is there * note: link to manual won't work until after 2014-08-01 in the USA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:02:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:02:06 +0000 Subject: [Koha-bugs] [Bug 12683] Use NoLoginInstructions to customize text for OPAC user/pass information In-Reply-To: <bug-12683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12683-70-cPBoRQKF5I@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 --- Comment #1 from simith.doliveira at inlibro.com --- Created attachment 30415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30415&action=edit Bug 12683 - Use NoLoginInstructions to customize text for OPAC user/pass information Enable staff to setting a text for OPAC user/pass information Modified: C4/Auth.pm koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -add a text to the popup login page koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-main.tt -add a text to the main login page Testing: I Apply the patch 0) Search NoLoginInstructions preference 1) Add/modify a text 2) Open OPAC main page 3) Validate the text added under Login button 4) Click in "Log in to your account" link 5) Validate the text added under input password (popup) Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:02:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:02:56 +0000 Subject: [Koha-bugs] [Bug 12683] Use NoLoginInstructions to customize text for OPAC user/pass information In-Reply-To: <bug-12683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12683-70-5km3yv17Ub@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com, | |francois.charbonnier at inlibr | |o.com, | |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:03:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:03:15 +0000 Subject: [Koha-bugs] [Bug 12683] Use NoLoginInstructions to customize text for OPAC user/pass information In-Reply-To: <bug-12683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12683-70-AVQ8uix8Vc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:22:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:22:04 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-81Dbl5z9zR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30320|0 |1 is obsolete| | Attachment #30321|0 |1 is obsolete| | Attachment #30322|0 |1 is obsolete| | Attachment #30323|0 |1 is obsolete| | Attachment #30324|0 |1 is obsolete| | Attachment #30325|0 |1 is obsolete| | Attachment #30326|0 |1 is obsolete| | Attachment #30327|0 |1 is obsolete| | Attachment #30328|0 |1 is obsolete| | Attachment #30329|0 |1 is obsolete| | Attachment #30330|0 |1 is obsolete| | Attachment #30331|0 |1 is obsolete| | --- Comment #474 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30416&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:22:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:22:34 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-v9cR4GFq1P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #475 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30417&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:22:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:22:42 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-nmf8GnZwQT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #476 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30418&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:22:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:22:49 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-u0ifFr7ihc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #477 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30419&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:22:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:22:56 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-b047xGE0DZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #478 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30420&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:23:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:23:08 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-5uuq7feALL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #479 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30421&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:23:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:23:17 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-fKY6yFMzeS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #480 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30422&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:23:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:23:27 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-sIPnJHeLWd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #481 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30423&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:23:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:23:35 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-H8e8yvUML2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #482 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30424&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:23:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:23:42 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-OQ038yy58k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #483 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30425&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:23:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:23:55 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-4hsPSymtFV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #484 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30426&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:24:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:24:02 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-N8XtmB8PlN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #485 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 30427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30427&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:38:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:38:50 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-Lj40G92nym@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30404|0 |1 is obsolete| | --- Comment #77 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30428&action=edit [SIGNED-OFF] Bug 766: Remove CGI::scrolling_list from aqplan.pl This patch removes 3 occurences on aqplan.pl To test: 1. You need a budget and a found 2. Apply the patch 3. Go to Aquisitions, click on your found 4. Select one of the options on pulldown Planning e.g. "Plan by months" 5. Now to the left there are two boxes, Filter and Export a) Filter: (1) pulldown below 'Select planning type' check that works selecting other values and submit This pulldown showed originally code types, untranslatable BTW. Added a TT block to allow translation and shows legends that match Planning pulldown, but not the order. b) Export: pulldowns for filetype (2) and delimiter (3) Those have originally one value each, and for me Export does not work, before or after patch, but check that pulldown exist. Notes: A) 5.a) I can change de order of main Planning pulldown, is harcoded. The values for Filter pulldown are sorted on aqplan.pl. Is one or the other. If desired, TT block can be moved to includes/budgets-admin-toolbar.inc (where hardcoded Planning lives) B) 5.b) Moved 'Export' legend inside it's box, like Filter. C) Finally: there is something strange, before or after patch. There is an empty option 'Planning by " if you select planning using main pulldown, it disappears if you select planning using Filter (not a mistery, using Planning fills $auth_cats_loop, using Filter submit button does not) Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:50:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:50:33 +0000 Subject: [Koha-bugs] [Bug 12685] search history page missing help file In-Reply-To: <bug-12685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12685-70-QGJAh4mg40@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12685 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30414|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30429&action=edit [SIGNED-OFF] Bug 12685: Add help file for staff search history This patch adds a missing help file for the staff search history page. To test: * Turn on EnableSearchHistory * Do a search in the catalog * Click your username in the top right and choose 'search history' * Click 'help' in the top right * Confirm that help file is there * note: link to manual won't work until after 2014-08-01 in the USA Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Work as described, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 19:51:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 17:51:13 +0000 Subject: [Koha-bugs] [Bug 12685] search history page missing help file In-Reply-To: <bug-12685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12685-70-hTzrq4qGlA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12685 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 20:49:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 18:49:37 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-rVuA2JgAyz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30405|0 |1 is obsolete| | --- Comment #78 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30430&action=edit [SIGNED-OFF] Bug 766: Remove CGI::scrollinglist from authorised_values.pl This patch removes the only instance in this file. Also fixes array sorting, removes some tabs, removes an unneeded $dbh handler (there is a global one). Makes use of C4::Koha::GetAuthorisedValueCategories. To test: 1. Apply the patch 2. Go to Administration > Authorised values 3. Replaced pulldown next to 'Show category' must show all (present & system) categories correctly ordered. 4. Select some and check for regressions, e.g. CCODE, Bsort2, YES_NO no changes must be observed Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 20:50:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 18:50:06 +0000 Subject: [Koha-bugs] [Bug 12686] New: Make more selected option XHTML complian Message-ID: <bug-12686-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12686 Bug ID: 12686 Summary: Make more selected option XHTML complian Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org Need to be <option ... selected="selected">...</option> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 20:52:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 18:52:37 +0000 Subject: [Koha-bugs] [Bug 12686] Make more selected option XHTML complian In-Reply-To: <bug-12686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12686-70-pIGJANOTzC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12686 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30431&action=edit Bug 12686: Make more selected option XHTML compliant This patch fixes several occurrences of selected options that do not follow XHTML style rule for markup. To test: 1. Apply the patch 2. There are no functional changes at all, only a more strict markup Changed all cases I can found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 20:55:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 18:55:40 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-pobJ7u2742@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 20:55:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 18:55:50 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-6dbDovxQsb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30406|0 |1 is obsolete| | --- Comment #79 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30432&action=edit [SIGNED-OFF] Bug 766: Remove CGI::scrollinglist from marctagstructure.pl This patch removes the only instance in this file. Don't know if the feature is of some utility, seems that does not work (no use of auth values as indicators on MARC editor) To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic on MARC structure of any fw 4. Clic Edit on any tag 5. On tag editor check the pulldown 'Authorised value', that was replaced 6. Check for regressions: select a value, save, verify the value, change again, etc. Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories Do not we need an AuthorisedValues.pm? (on C4 or Koha) Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 20:55:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 18:55:55 +0000 Subject: [Koha-bugs] [Bug 12686] Make more selected option XHTML complian In-Reply-To: <bug-12686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12686-70-TVfZafiS6I@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12686 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30431|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30433&action=edit Bug 12686: Make more selected option XHTML compliant This patch fixes several occurrences of selected options that do not follow XHTML style rule for markup. To test: 1. Apply the patch 2. There are no functional changes at all, only a more strict markup Changed all cases I can found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 20:56:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 18:56:21 +0000 Subject: [Koha-bugs] [Bug 12686] Make more selected option XHTML complian In-Reply-To: <bug-12686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12686-70-nTdYXbjCNR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12686 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|oleonard at myacpl.org |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 21:07:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 19:07:21 +0000 Subject: [Koha-bugs] [Bug 12673] Remove CGI::scrolling_list from C4::Items.pm In-Reply-To: <bug-12673-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12673-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12673-70-az9zcSE3Yt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 21:07:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 19:07:25 +0000 Subject: [Koha-bugs] [Bug 12673] Remove CGI::scrolling_list from C4::Items.pm In-Reply-To: <bug-12673-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12673-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12673-70-Ig61uFwNFQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30407|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30434&action=edit [SIGNED-OFF] Bug 12673: Remove CGI::scrolling_list from C4::Items.pm This patch removes only instance in this file To test: 1. Apply the patch 2. (Esay way) Put on staff URL /cgi-bin/koha/services/itemrecorddisplay.pl?biblionumber=N&itemnumber=M 3. Code replaced corresponds to pulldowns, verify information is correct (check with another item edit view) PrepareItemrecordDisplay() in Items.pm is filled with chunks of HTML code that must be put on TT file. For now scrolling_list is the only removed. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 21:23:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 19:23:05 +0000 Subject: [Koha-bugs] [Bug 12686] Make more selected option XHTML complian In-Reply-To: <bug-12686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12686-70-Pj2msDue5K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12686 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 21:23:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 19:23:07 +0000 Subject: [Koha-bugs] [Bug 12686] Make more selected option XHTML complian In-Reply-To: <bug-12686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12686-70-cAyERFxlpy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12686 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30433|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30435&action=edit [SIGNED-OFF] Bug 12686: Make more selected option XHTML compliant This patch fixes several occurrences of selected options that do not follow XHTML style rule for markup. To test: 1. Apply the patch 2. There are no functional changes at all, only a more strict markup Changed all cases I can found. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 21:35:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 19:35:34 +0000 Subject: [Koha-bugs] [Bug 12675] Remove CGI::scrolling_list from labeledMARCdetail.pl In-Reply-To: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12675-70-qXAozk3LYU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12675 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30408|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30436&action=edit [SIGNED-OFF] Bug 12675: Remove CGI::scrolling_list from labeledMARCdetail.pl This patch removes only instance in this file. Also updates getframework POD on C4/Koha.pm, adds new GetFrameworksLoop() func on same file from suggested code, but with ordered result. To test: 1. Apply the patch 2. Enable viewLabeledMARC syspref 3. On staff, search for a record, goto detail view 4. Clic on Labeled MARC 5. Framework pulldown was replaced, check changing framework. A bug was fixed, because selecting any fw and then Default tries to load values from 'Default' fw code, which does not exists. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 21:40:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 19:40:09 +0000 Subject: [Koha-bugs] [Bug 12675] Remove CGI::scrolling_list from labeledMARCdetail.pl In-Reply-To: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12675-70-aB0Womtihg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12675 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 21:40:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 19:40:13 +0000 Subject: [Koha-bugs] [Bug 12675] Remove CGI::scrolling_list from labeledMARCdetail.pl In-Reply-To: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12675-70-esQhqIvYID@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12675 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30413|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 30437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30437&action=edit [SIGNED-OFF] Bug 12675: Add unit test to GetFrameworksLoop to test: 1. Apply the patch 2. Run the test, prove t/db_dependent/Koha.t 3. Check that it pass Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 21:43:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 19:43:04 +0000 Subject: [Koha-bugs] [Bug 12535] PROG/CCSR Deprecation: Make opac translation theme independent In-Reply-To: <bug-12535-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12535-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12535-70-ecsqwt2Bkd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 21:46:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 19:46:31 +0000 Subject: [Koha-bugs] [Bug 12687] New: Remove CGI::scrolling_list from circulation.pl Message-ID: <bug-12687-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12687 Bug ID: 12687 Summary: Remove CGI::scrolling_list from circulation.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org One instance in this file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 21:53:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 19:53:16 +0000 Subject: [Koha-bugs] [Bug 12687] Remove CGI::scrolling_list from circulation.pl In-Reply-To: <bug-12687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12687-70-FSiPVUSCEy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12687 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 30438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30438&action=edit Bug 12687: Remove CGI::scrolling_list from circulation.pl This patch removes the only instance in this file To test: 1. Apply the patch 2. Search for patrons on staff CheckOut, use a string that gives multiple results 3. Results are displayed on a select, that was replaced. 4. Check for regressions: select a patron and press 'Select', or do double click on a patron name, verify you go to patron's checkout tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 21:54:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 19:54:03 +0000 Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-M5Uar0KSJd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12687 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 21:54:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 19:54:03 +0000 Subject: [Koha-bugs] [Bug 12687] Remove CGI::scrolling_list from circulation.pl In-Reply-To: <bug-12687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12687-70-hJcpFxFogJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12687 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Blocks| |766 Assignee|oleonard at myacpl.org |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 22:07:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 20:07:20 +0000 Subject: [Koha-bugs] [Bug 12539] PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm In-Reply-To: <bug-12539-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12539-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12539-70-IfEsB2Su79@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12539 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 31 23:36:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Jul 2014 21:36:28 +0000 Subject: [Koha-bugs] [Bug 12539] PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm In-Reply-To: <bug-12539-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12539-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12539-70-6xS6UKAcUt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12539 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> --- Yeah, this breaks themes, which im not sure we need to do. We can remove the ccsr and prog themes from the distribution, and change the syspref without breaking it for everyone who has their own custom theme going. I don't think we need to remove the ability to have more than one theme just to deprecate prog and ccsr I would not like to see this patch pushed as it stands My 2 cents -- You are receiving this mail because: You are watching all bug changes.