[Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
The issue is that the extra message is incorrect! However, I think maybe my
first patch was too aggressive. I'm going to file a new patch that only affects
the "Too many holds" and "No items are available" sections.

(In reply to Katrin Fischer from comment #7)
> I am not sure about this patch - if there are multiple reasons why a hold is
> not possible, should we not display all of them instead of giving one reason
> preference of another? It seems like this patch will make the error message
> less accurate (elsif instead of if)?
> 
> +        [% ELSIF ( maxreserves ) %]
> +          <li><strong>Too many holds: </strong> <a
> href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber
> %]">[% borrowerfirstname %] [% borrowersurname %] </a> has too many
> holds.</li>
> +        [% ELSIF ( alreadyreserved ) %]
> +          <li><a
> href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber
> %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>already has a
> hold</strong> on this item </li>
> +        [% ELSIF ( alreadypossession ) %]

-- 
You are receiving this mail because:
You are watching all bug changes.