[Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I feel like it would be better to check for the preference first, so the
database is only queried for the rental fee, if it's needed. What do you think?
This is the code from the squashed patches: 

+    #
+    # CHECK IF THERE IS RENTAL CHARGES. RENTAL MUST BE CONFIRMED BY THE
BORROWER
+    #
+    my ($rentalCharge) = GetIssuingCharges( $item->{'itemnumber'},
$borrower->{'borrowernumber'} );
+    my $rentalConfirmation =
C4::Context->preference("RentalFeesCheckoutConfirmation");
+
+    if ( $rentalConfirmation && $rentalCharge != 0 )
+    {
+        $rentalCharge = sprintf("%.02f", $rentalCharge);
+        $needsconfirmation{RENTALCHARGE} = $rentalCharge;
+    }

For the pref description I think maybe it should be:
ask/don't ask 'for confirmation' instead of 'a confirmation'. 
But as I am not a native speaker myself, you might want to check that with one
:)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.