[Koha-bugs] [Bug 12409] The test t/db_dependent/Record.t fails with Perl 5.18.2
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sun Jul 6 21:04:53 CEST 2014
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12409
Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28848|0 |1
is obsolete| |
--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 29529
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29529&action=edit
[PASSED QA] Bug 12409: Fix fields order on exporting to bibtex
The C4::Record::marc2bibtex subroutine supposes hashref keys are sorted
which is wrong with perl 5.18
Note that the t/db_dependent/Record.t fails without this patch.
Test plan (for perl >= 5.18 only):
1/ prove t/db_dependent/Record.t should return green
2/ Try to export a record to bibtex and verify the order is correct
(should be author, title, year, published, etc.).
http://bugs.koha-community.org/show_bug.cgi?id=12409
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Wrong Bug number on heading.
Work as described, test pass, no koha-qa errors.
The problem is to think that a hash returns
keys in a particular order, that's not true
and no matter which perl version.
Code as was left is... misleading.
Comments talks about a hash, which is no more.
On array asignment "a => b" is equivalent to "a, b",
but the former is usually used on hashes, so a
replacement of '=>' by ',' could clarify what are we storing.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Fixing the comments in a follow-up patch.
Tests pass now without problems and records export ok.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list