[Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 29494
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29494
[SIGNED-OFF] Bug 12493: moving the subroutines GetContract and GetContracts
from C4::Acquisition.pm to C4::Contract.pm

Review of attachment 29494:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12493&attachment=29494)
-----------------------------------------------------------------

::: C4/Acquisition.pm
@@ +363,5 @@
>      my @rows;
>      for my $basket (@$baskets) {
>          my @orders     = GetOrders( $$basket{basketno} );
> +        my $contract   = GetContract({
> +            contractnumber => $$basket{contractnumber}

I know this line existed before, but see here for future reference:
http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL5:_Disagreements

And maybe fix in a follow up?

::: C4/Contract.pm
@@ +21,1 @@
>  use strict;

When using Modern::Perl you can delete the use strict; and use warnings; lines
here.

-- 
You are receiving this mail because:
You are watching all bug changes.