[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 29156
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29156
[SIGNED-OFF] Bug 11399: batch Rebuild Items Tables

Review of attachment 29156:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11399&attachment=29156)
-----------------------------------------------------------------

2 small things from code review:

::: misc/batchRebuildItemsTables.pl
@@ +1,4 @@
> +#!/usr/bin/perl
> +use 5.10.0;
> +use strict;
> +use warnings;

Please switch to: use Modern::Perl; :)

@@ +94,5 @@
> +    }
> +}
> +
> +$dbh->do("UPDATE systempreferences SET value=$CataloguingLog WHERE variable='CataloguingLog'");
> +$dbh->do("UPDATE systempreferences SET value=$dontmerge where variable='dontmerge'");

Please switch to using placeholders instead of variables.

-- 
You are receiving this mail because:
You are watching all bug changes.