[Koha-bugs] [Bug 10877] Add "Order Record" processing

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877

--- Comment #17 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 29406
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29406
Bug 10877 - Add "Order Record" processing

Review of attachment 29406:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10877&attachment=29406)
-----------------------------------------------------------------

::: C4/ImportBatch.pm
@@ +967,3 @@
>  =cut
>  
>  sub GetImportBatchRangeDesc {

You should provide unit test here, but it seems to be quite difficult here (no
test exists for this module).

::: acqui/addorderiso2709.pl
@@ +270,5 @@
>              my @serials      = $input->param('serial');
>              my @ind_tag   = $input->param('ind_tag');
>              my @indicator = $input->param('indicator');
> +
> +            if ($is_order) {

Could you detail why you process these 4 fields?

@@ +295,5 @@
> +                  GetMarcFromKohaField('items.itype');
> +                push( @tags,         $itype_field );
> +                push( @subfields,    $itype_subfield );
> +                push( @field_values, $infos->{itype} );
> +                warn "ITYPE: " . $infos->{itype};

useless warn

@@ +359,1 @@
>  

hum, good candidate for an hashref param.

@@ +450,5 @@
>                          item_action => $item_action
>                      );
>      batch_info($template, $batch);
> +
> +    return \@list;

Why did you change this return?

::: installer/data/mysql/updatedatabase.pl
@@ +8565,5 @@
> +    $dbh->do("ALTER TABLE import_batches ADD is_order BOOLEAN NOT NULL DEFAULT '0' AFTER comments");
> +   print "Upgrade to $DBversion done (Bug 10877 - Add 'Order Record' processing)\n";
> +   SetVersion ($DBversion);
> +
> +}

FAIL   pod
                *** WARNING: =head2 without preceding higher level  in file
installer/data/mysql/updatedatabase.pl

Just add an blank line before =head1

::: koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-add-to-basket.inc
@@ +18,4 @@
>          <li><a href="/cgi-bin/koha/acqui/z3950_search.pl?booksellerid=[% booksellerid %]&basketno=[% basketno %]">From an external source</a></li>
>          <li><a href="/cgi-bin/koha/acqui/addorderiso2709.pl?booksellerid=[% booksellerid %]&basketno=[% basketno %]"> From a staged file</a></li>
>          [% IF ( CAN_user_circulate ) %]<li><a href="/cgi-bin/koha/circ/reserveratios.pl?booksellerid=[% booksellerid %]&basketno=[% basketno %]">From titles with highest hold ratios</a></li>[% END %]
> +        <li><a href="/cgi-bin/koha/acqui/addorderiso2709.pl?booksellerid=[% booksellerid %]&basketno=[% basketno %]&is_order=1"> From a staged order file</a></li>

Maybe should be put just after "from a staged file"?

::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
@@ +145,5 @@
> +            $("#checkAll").click();
> +
> +            $("#all_budget_id").hide();
> +            $('label[for="all_budget_id"]').hide();
> +        [% END %]

I don't understand the trick here.
Please check because the behavior is buggy (try to check/uncheck "Show all
fund", the fund list will become empty).

-- 
You are receiving this mail because:
You are watching all bug changes.