[Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
I do believe all instances of "keys $params" need to be changed to "keys
%$params".

koha-qa -v 2 -c 1
testing 1 commit(s) (applied to cb8b0fe 'Bug 12508: Follow up - corrects
capit')

 FAIL   C4/Accounts.pm
   OK     pod
   OK     forbidden patterns
   FAIL   valid
                Type of arg 1 to keys must be hash (not private variable)
                Compilation failed in require
   OK     critic

 FAIL   C4/Circulation.pm
   OK     pod
   OK     forbidden patterns
   FAIL   valid
                Type of arg 1 to keys must be hash (not private variable)
                Compilation failed in require
   OK     critic

 FAIL   C4/Stats.pm
   OK     pod
   OK     forbidden patterns
   FAIL   valid
                C4/Stats.pm had compilation errors.
                Type of arg 1 to keys must be hash (not private variable)
   OK     critic

 FAIL   t/db_dependent/Stats.t
   OK     pod
   OK     forbidden patterns
   FAIL   valid
                Type of arg 1 to keys must be hash (not private variable)
                Compilation failed in require
   OK     critic

-- 
You are receiving this mail because:
You are watching all bug changes.