[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

--- Comment #65 from M. Tompsett <mtompset at hotmail.com> ---
Also should be noted a minor rebase is required before fixing.

I think it would be optimal if all the OPACBaseURLs passed to the templates
were full paths including the https or http accordingly.

I am not so sure I think the OpacProtocol system preference idea is the best
way to do it, but rather it should be in the OPACBaseURL system preference
itself. We shouldn't be hardcoding http or https anywhere. We shouldn't need to
check for http or https anywhere.

I feel the best solution is the most painful to do: fix every instance of
OPACBaseURL use or hardcoded protocols to just use the OPACBaseURL. However,
once done, it will just work. That is the way Koha should work.

Sadly, there are partial links in some of the included header templates which
would cascade to a larger than simpler solution, as far as I recall from last
time I checked. Honestly, someone needs to bite the bullet. I don't have time.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.