[Koha-bugs] [Bug 10877] Add "Order Record" processing

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
-1 is the standard value for 'ordered' in Koha. This feature is to process
order records so the items are by definition ordered and not any other status.
Additionally we grab the itemtype from the system preference, and we set the
branch selects to the logged in branch. I wouldn't say it's arbitrary. If you
have any suggestions on how to better handle this, I'd be open to making
changes. As the author of the feature this builds on, I think you are probably
in the best position to qa this patch.

Kyle

(In reply to Jonathan Druart from comment #21)
> (In reply to Kyle M Hall from comment #18)
> > Comment on attachment 29406 [details] [review] [review]
> > ::: acqui/addorderiso2709.pl
> > @@ +270,5 @@
> > >              my @serials      = $input->param('serial');
> > >              my @ind_tag   = $input->param('ind_tag');
> > >              my @indicator = $input->param('indicator');
> > > +
> > > +            if ($is_order) {
> > 
> > This is so we can pre-set the items to a notforloan value of 'ordered', and
> > to preset the home and holding fields to the current branch, as well as
> > pre-set the itemtype.
> 
> Yes but you hard-code arbitrarily these values.
> Why these 4 values and not others?
> I would like to get another QA point of view here.
> Katrin maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.