[Koha-bugs] [Bug 12287] Hold priority for new hold incorrect if record has holds in transit

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12287

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Kyle M Hall from comment #5)
> I don't think so. That could cause future regressions if new found statuses
> are added. For example, there used to be a found status of 'F' for
> 'Finished' ( from before the existence of the old_reserves table iirc ). We
> never want to include any type of found hold when calculating a new hold's
> priority, set there is no need to list everything as a special case.

Looking at the code in C4/Reserves.pm and reserves/*, the 'found' value is
often compared to 'W' or 'T'. Both values are listed explicitly. That's why I
supposed it is safer to use the same way.
I added a small comment in the line (in order to get return if someone grep
found.*W.*T)

-- 
You are receiving this mail because:
You are watching all bug changes.