[Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue!

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 30050
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30050&action=edit
[PASSED QA] Bug 12596 - Backdating returns with SpecifiyReturnDate causes fines
for items not overdue!

When using the backdating of returns feature, an item that is not
overdue is treated as being as many days overdue as it is *not* overdue.
This is due to the fact that _get_chargeable_units appears to return the
difference between the return date and the due date without
consideration the return date being earlier than the due date.

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/Circulation.t
3) Note the failure
4) Apply the second patch
5) prove t/db_dependent/Circulation.t
6) Note there are no failures

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Fixes some badly named variables also

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
In order to test this, you need to activate SpecifyReturnDate.
I confirmed the problem and verified that the bug fixes it
by running the tests, but also by testing in staff.

-- 
You are receiving this mail because:
You are watching all bug changes.