[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Yohann Dufour <yohann.dufour at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30115|0                           |1
        is obsolete|                            |

--- Comment #2 from Yohann Dufour <yohann.dufour at biblibre.com> ---
Created attachment 30119
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30119&action=edit
Bug 12633: SQLHelper replacement - C4::Members

With this patch, the subroutines AddMember and Search uses DBIx::Class instead
of C4::SQLHelper.
In order to replace SQLHelper in the Search subroutine, 2 subroutines has been
added, it seems a lot : replace 1 line with 2 subroutines, but in fact these 2
subroutines replace all the hidden work done by the SQLHelper.

Test plan:
1) Apply the patch 12457 in order to get the last unit tests for Members

2) Apply the patch

3) Execute the unit tests by launching :
prove t/db_dependent/Members.t

4) The result has to be a success without error or warning :
t/db_dependent/Members.t .. ok
All tests successful.
Files=1, Tests=55,  2 wallclock secs ( 0.04 usr  0.01 sys +  2.27 cusr  0.09
csys =  2.41 CPU)
Result: PASS

5) Sign in the intranet.

6) Verify you can add a member in the intranet.

7) Test of members/guarantor_search.pl :
Edit a member which belongs to the cateogry type 'C' (Child), click on 'Set to
patron' and verify the search of an adult member is correct.

8) Test of patroncards/members-search.pl :
Go to Tools > Patron card creator > New batch > "Add item(s)" and verify the
search of a member is correct.

9) Test of serials/member-search.pl :
Go on the page serials/member-search.pl and verify the search of a member is
correct.

10) Test of reserve/request.pl :
Go on a biblio details then "Holds" and verify the search of a member is
correct.

11) Test of circ/circulation.pl :
Go on Circulation > Checkouts and verify the search of a member is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.