[Koha-bugs] [Bug 12398] CAS authentication not working

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |tomascohen at gmail.com

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I'm not sure about CAS specific stuff, but there are problems with this patch:

- No regression tests.
- Koha's code usually expects OPACBaseUrl not to contain "http://" in front of
it. So, something's wrong.

Could you please at least provide a sample call to the function where all the
assertions (like "url_param() returns the deleted params too"). Think of a
black box test.

My feeling is that CAS working with this patch is a side effect of another
problem.

I am open to comments and willing to push this ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.