[Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jul 28 00:27:59 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30096|0                           |1
        is obsolete|                            |
  Attachment #30097|0                           |1
        is obsolete|                            |
  Attachment #30098|0                           |1
        is obsolete|                            |

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 30166
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30166&action=edit
[PASSED QA] Bug 12445: Improving unit tests for C4::Suggestions.pm

Now, the tests used 'is' instead of 'ok', the tests are wrapped in a
transaction, adding tests for the routines NewSuggestion, GetSuggestion,
ModSuggestion, GetSuggestionFromBiblionumber and GetInfoFromBiblionumber.

The tests for the routines DelSuggestionsOlderThan, CountSuggestion,
ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion
and GetSuggestionByStatus will be arrived in another patch.

Test plan:
1/ Execute the command : prove t/db_dependent/Suggestions.t
2/ The result has to be a success without warning or error :
t/db_dependent/Suggestions.t .. ok
All tests successful.
Files=1, Tests=32,  2 wallclock secs ( 0.03 usr  0.01 sys +  1.49 cusr  0.08
csys =  1.61 CPU)
Result: PASS

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list