[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30095|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 30237
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30237&action=edit
[PASSED QA] Bug 12627: SQLHelper replacement - C4::Suggestions

With this patch, the subroutines NewSuggestion and ModSuggestion uses
DBIx::Class instead of C4::SQLHelper.
Moreover, the tests has been adapted to the values returned by DBIx::Class.

Test plan:
1) Apply the patch 12445 in order to get the last unit tests for Suggestions

2) Apply the patch

3) Execute the unit tests by launching :
prove t/db_dependent/Suggestions.t

4) The result has to be a success without error or warning :
t/db_dependent/Suggestions.t .. ok
All tests successful.
Files=1, Tests=91,  2 wallclock secs ( 0.05 usr  0.01 sys +  1.65 cusr  0.09
csys =  1.80 CPU)
Result: PASS

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Tests pass, no problems found.
Patch applies on top of bug 12445.

-- 
You are receiving this mail because:
You are watching all bug changes.