[Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jul 29 23:09:50 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30116|0                           |1
        is obsolete|                            |
  Attachment #30117|0                           |1
        is obsolete|                            |
  Attachment #30266|0                           |1
        is obsolete|                            |

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 30309
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30309&action=edit
[PASSED QA] Bug 12457: Removal warning in t/db_dependent/Members.t

When I execute prove t/db_dependent/Members.t, this warning appears twice :
"Argument "Test" isn't numeric in modulus (%) at
/home/yohann/koha/C4/Context.pm line 1256."

The warning is due to a invalid use of the routine set_userenv

Test plan:
1/ Execute : prove t/db_dependent/Members.t
2/ The warning appears twice :
"Argument "Test" isn't numeric in modulus (%) at
/home/yohann/koha/C4/Context.pm line 1256."
3/ Apply the patch
4/ Execute : prove t/db_dependent/Members.t
5/ The result has to be a success without error or warning :
t/db_dependent/Members.t .. ok
All tests successful.
Files=1, Tests=26,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.50 cusr  0.08
csys =  1.63 CPU)
Result: PASS

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
All new and old tests pass now.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list