[Koha-bugs] [Bug 8446] Shibboleth authentication patch

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

--- Comment #74 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Right.. I think we're finally there guys!

This last update to the final patch takes care of a configuration issue
Matthias spotted whereby the config would be parsed incorrectly.

To enable forward compatibility with bug 12026 (preventing us having to handle
a nasty breaking config change when pushing that patch) and to bring the config
in line with that of the way the ldap config currently works the minimum xml
required has changed from:

<usesshibboleth>1</usesshibboleth>
<shibboleth>
  <matchpoint>userid</matchpoint>
  <mapping>
    <userid>uid</userid>
  </mapping>
</shibboleth>

to:

<usesshibboleth>1</usesshibboleth>
<shibboleth>
  <matchpoint>userid</matchpoint>
  <mapping>
    <userid is="uid"></userid>
  </mapping>
</shibboleth>

I'm told this is more 'standard' amongst this kind of xml based mapping file
and am happy going with it.

It also allows for a future form to look like the below without breaking
compatibility:

<usesshibboleth>1</usesshibboleth>
<shibboleth>
  <matchpoint>userid</matchpoint>
  <mapping>
    <userid is="uid" regex="s/@school.ac.uk//g"></userid>
    <firstname is="fn">default</firstname>
  </mapping>
</shibboleth>

The above will hopefully give you a brief glimpse into what I'm thinking for
enhancing bug 12026 once this is pushed.

Cheers for everyone efforts so far!

-- 
You are receiving this mail because:
You are watching all bug changes.