From bugzilla-daemon at bugs.koha-community.org Sun Jun 1 15:56:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jun 2014 13:56:58 +0000
Subject: [Koha-bugs] [Bug 12339] New: catalogue/search.pl biblio
availability counts items not on hold as on hold
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12339
Bug ID: 12339
Summary: catalogue/search.pl biblio availability counts items
not on hold as on hold
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Searching
Assignee: gmcharlt at gmail.com
Reporter: olli-antti.kivilahti at jns.fi
QA Contact: testopia at bugs.koha-community.org
To replicate the issue:
Make a search in catalogue/search.pl.
Find a Record with lots of holds. (and less than 20 items, otherwise counts are
not accurate)
Items which should be available,
are counted as unavailable in the 'availability'-portion in the Record result
details of catalogue/search.pl
if the biblio has holds in the Reserved-status.
This is easily fixed by not making a biblio-level holds lookup when determining
individual Item's availability.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jun 1 16:12:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jun 2014 14:12:27 +0000
Subject: [Koha-bugs] [Bug 12339] catalogue/search.pl biblio availability
counts items not on hold as on hold
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12339
--- Comment #1 from Olli-Antti Kivilahti ---
Created attachment 28585
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28585&action=edit
Patch for this bug
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jun 1 16:22:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jun 2014 14:22:41 +0000
Subject: [Koha-bugs] [Bug 2465] availability of a reserved book
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2465
Olli-Antti Kivilahti changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |olli-antti.kivilahti at jns.fi
--- Comment #3 from Olli-Antti Kivilahti ---
Created attachment 28586
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28586&action=edit
Patch for this bug, finally!
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jun 1 16:39:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jun 2014 14:39:31 +0000
Subject: [Koha-bugs] [Bug 2465] availability of a reserved book
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2465
--- Comment #4 from Katrin Fischer ---
Hi Olli, can you please include a test plan in your commit message and switch
the status of this bug to 'needs sign-off'?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jun 1 17:00:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jun 2014 15:00:09 +0000
Subject: [Koha-bugs] [Bug 2465] availability of a reserved book
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2465
--- Comment #5 from Olli-Antti Kivilahti ---
I think my patch isn't for this bug actually :)
Now that I reread it twice it looks like this issue here is about the detailed
view.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jun 1 17:00:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jun 2014 15:00:38 +0000
Subject: [Koha-bugs] [Bug 2465] availability of a reserved book
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2465
Olli-Antti Kivilahti changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28586|0 |1
is obsolete| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jun 1 17:01:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jun 2014 15:01:11 +0000
Subject: [Koha-bugs] [Bug 2465] availability of a reserved book
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2465
--- Comment #6 from Olli-Antti Kivilahti ---
BTW. We are going live tomorrow, just wanted to tell :)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jun 1 17:13:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jun 2014 15:13:02 +0000
Subject: [Koha-bugs] [Bug 2465] availability of a reserved book
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2465
--- Comment #7 from Katrin Fischer ---
Good luck! :)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jun 1 18:16:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jun 2014 16:16:35 +0000
Subject: [Koha-bugs] [Bug 11958] classification sources help file has typo
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11958
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28584|0 |1
is obsolete| |
--- Comment #6 from Bernardo Gonzalez Kriegel ---
Created attachment 28587
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28587&action=edit
[SIGNED-OFF] Fix typon in classification source help The Classification Sources
help file said the source was in the 942$2 but it's in the 952$2 and 94$2 so
this patch fixes that.
To test:
* Go to Admin > Classification Sources
* Click Help
* Confirm the Help file is right now
http://bugs.koha-community.org/show_bug.cgi?id=11958
Signed-off-by: Bernardo Gonzalez Kriegel
String change, no errors.
Note: Perhaps change "Authorized Values ..." for "Authorized values ..."
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jun 1 18:17:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jun 2014 16:17:01 +0000
Subject: [Koha-bugs] [Bug 11958] classification sources help file has typo
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11958
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jun 1 20:12:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jun 2014 18:12:57 +0000
Subject: [Koha-bugs] [Bug 12190] move creators preference to tools tab
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12190
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
Hi Nicole, the patch included a string change and I think was therefore held
back until after the 3.16 release. It's not in 3.16.0.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 05:38:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 03:38:20 +0000
Subject: [Koha-bugs] [Bug 12190] move creators preference to tools tab
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12190
--- Comment #7 from Nicole C. Engard ---
Thanks!! I'll save it for the 3.18 manual.
Nicole
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 09:54:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 07:54:14 +0000
Subject: [Koha-bugs] [Bug 11292] barcode scanner clicking 'save'
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #13 from M. de Rooy ---
(In reply to Galen Charlton from comment #12)
> Marcel, have you tested /all/ of the interfaces that this patch touches? By
> changing cataloging.js and matching on .input_marceditor, a bunch of forms
> are affected, not just the main cataloging editor:
I noticed that it impacts more than the editor (biblio/items); I additionally
looked at the acquisition forms for that reason. (Hopefully, the one who signed
off, did some testing too :)
But for consistency, I certainly do not mind further improvements here.
Especially if the author could amend or send a follow-up. But if not, there is
no reason imo to block this patch for that reason.
BTW I additionally checked now: authorities.pl, serials-edit.pl and
batchMod.pl. No problems encountered.
Back to Passed QA.
Kyle: Could you please respond about your possibilities to amend/adjust in
light of the above?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 10:06:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 08:06:29 +0000
Subject: [Koha-bugs] [Bug 12043] Popup when reserved item checked in at
wrong branch should generate transfer slip
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043
--- Comment #4 from Benjamin Rokseth ---
Thanks for the feedback!
You obsoleted the attachment without uploading a new, I don't know it that was
intended? It can easily be undone by 'show obsolete', clicking 'details' next
to the bug, then 'edit details', and unchecking the obsolete box.
>Currently if someone comes in asking for a book on the transfer shelf we can >easily see if it is available or transferring for a hold, this change means we >have to double check.
>I don't know if it would be possible for TRANSFERSLIP to include the reason for >the transfer, or if my concerns are shared by anyone else but I wanted to >mention them.
In our library the transferred items are always checked in when arriving at the
destination to check for holds, and if a hold is present for the item, a hold
note (with reserve id) is printed and a 'hold is ready' message is sent to
borrower by sms or email. I don't know how other libraries handle this, but
wouldn't always an item need to be checked in at destination? Maybe I'm missing
something.
Anyway, there will probably be some followup on this one.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 10:23:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 08:23:29 +0000
Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 10:23:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 08:23:32 +0000
Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27905|0 |1
is obsolete| |
Attachment #27906|0 |1
is obsolete| |
Attachment #27907|0 |1
is obsolete| |
Attachment #27908|0 |1
is obsolete| |
Attachment #27909|0 |1
is obsolete| |
Attachment #27910|0 |1
is obsolete| |
--- Comment #10 from Jonathan Druart ---
Created attachment 28588
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28588&action=edit
Bug 12164: Move the budget period clone logic into C4::Budgets
Note the typo InsertInTable "aqcudgets", note sure about the existing
behavior before this patch!
This patch adds a link "Duplicate" in the action list for budget
periods (budgets).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 10:23:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 08:23:36 +0000
Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164
--- Comment #11 from Jonathan Druart ---
Created attachment 28589
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28589&action=edit
Bug 12164: On cloning budget period, mark original budget as inactive
This patch adds a checkbox "mark original budget as inactive" (budget
period).
If it is checked, the original budget will be marked as inactive.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 10:23:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 08:23:40 +0000
Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164
--- Comment #12 from Jonathan Druart ---
Created attachment 28590
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28590&action=edit
Bug 12164: On cloning budget periods, add a "reset all funds" option
This patch adds a checkbox "reset all funds" (budgets).
If it is checked, the new created budgets (funds) will be reset.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 10:23:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 08:23:49 +0000
Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164
--- Comment #14 from Jonathan Druart ---
Created attachment 28592
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28592&action=edit
Bug 12164: On closing budget period, move unspent amount
On closing a budget (budget period), the user will be presented with an
option to move remaining unspent funds from the previous budget to the
newly created one - adding to the amounts already entered in those
funds.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 10:23:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 08:23:45 +0000
Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164
--- Comment #13 from Jonathan Druart ---
Created attachment 28591
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28591&action=edit
Bug 12164: Close a budget period (budget)
This is the main patch.
On closing a budget period, all unreceived orders are moved from the
old/previous fiscal year into the new fiscal year.
You can rollover funds unused in the previous fiscal year to the new
fiscal year.
This patch set is based on bug 12168 (bugfix) and can be tested on top
of bug 11578 (easier to see the fund structure).
The patch set is cut in 6 main patches:
- Move the budget period clone logic into C4::Budgets
The code is moved from the pl to Budgets.pm and unit tests are provided.
The original code should certainly be buggy since a typo existed.
- On cloning budget period, mark original budget as inactive
Cloning a budget period is already possible in Koha, this patch adds a
checkbox to mark as inactive the original budget. That avoids to edit
the budget and click the "inactive" checkbox. Both do the same action.
- On cloning budget periods, add a "reset all funds" option
Same as before, a new checkbox is added on cloning a budget period. If
you check it, all fund amounts will be set to 0. Otherwise, no change
compared to the existing behavior.
- Close a budget period (budget)
The goal of this patch set is to move unreceived orders from a budget to
another. This patch adds a C4::Budgets::MoveOrders routine which does
this job.
This action is only possible if the fund structure is the same for both
budgets, the budget_code field should be the same.
- On closing budget period, move unspent amount
Unspent amount will be move from the previous budget structure to the
new one.
- Add UI report
This patch only adds a report when closing a budget is done.
Test plan:
Wording: below, budget is a "budget period" and fund is a "budget".
Prerequisite: Having 1 active budget with some funds (with different
levels and different amounts). Order and receive some orders (not all).
1/ Go on the budgets administration page (admin/aqbudgetperiods.pl) and
duplicate the structure of this budget ("Duplicate" link in the
"Actions" column).
2/ Enter start and end date for this budget and mark the original budget
as inactive.
3/ Note that a new budget is created, with the same fund structures (and
same value) and that the old one is marked as inactive (see
admin/aqbudgets.pl page with patches from bug 11578).
4/ Try to close the new budget: it is not possible, there is no
unreceived orders for this budget.
5/ You can close the inactive budget ("Close" link in the "Actions"
column).
6/ Verify the number of "Unreceived orders" is correct and select the
new budget in the budget list. Click on the "Move remaining unspent
funds" if you want to move unspent amounts.
7/ A report view is displayed and show you the ordernumber which have
been impacted (grouped by fund).
8/ Try different configuration, depending on the selected checkboxes.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 10:23:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 08:23:52 +0000
Subject: [Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164
--- Comment #15 from Jonathan Druart ---
Created attachment 28593
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28593&action=edit
Bug 12164: Add UI report
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 10:47:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 08:47:50 +0000
Subject: [Koha-bugs] [Bug 10784] SMS-related code needs improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10784
Benjamin Rokseth changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |benjamin.rokseth at kul.oslo.k
| |ommune.no
--- Comment #1 from Benjamin Rokseth ---
Adding to Magnus' findings:
all scripts under sms/ seems to concern some Turkish SMS reply service,
probably renew or reserve by SMS. However, they should hardly be part of Koha
main branch.
At least this should be a module under C4::SMS/Koha::SMS.
Also it might be in order to be able to pass various parameters to the chosen
SMS::Send driver from setting 'SMSSendDriver'.
Now the various drivers need to hardcode settings such as url, username,
password, etc.
I don't know what would be best practice, but maybe a setting such as
'SMSSendOptions' where options could be separated with '|'
e.g. 'url=http://smsservice.com|username=john|password=smith'
The drivers available at cpan:
http://search.cpan.org/search?query=sms%3A%3Asend&mode=all
uses a long range of options,
url,user,username,password,ssl,apikey,login,method, etc. It would be impossible
to include all in C4::SMS, but a generic option hash passed to the driver would
work, as per the Send::SMS doc:
Params with a leading underscore are "private" driver-specific options and will
be passed through to the driver unchanged.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 11:38:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 09:38:53 +0000
Subject: [Koha-bugs] [Bug 12340] New: Checkboxes are shown for nonexistent
SMS transports
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12340
Bug ID: 12340
Summary: Checkboxes are shown for nonexistent SMS transports
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs at lists.koha-community.org
Reporter: pasi.kallinen at pttk.fi
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
Delete some SMS transports from the database:
delete from message_transports where message_transport_type='sms' and
letter_code != 'HOLD';
Check patron messaging prefs in OPAC: Only the hold notice SMS has a checkbox.
Check patron messaging prefs in the staff client: Every SMS transport has a
checkbox.
Should only show the checkboxes for existing transports.
I haven't tested, but the same may happen for the other transports too.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 12:23:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 10:23:08 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
upgrade
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729
--- Comment #26 from Pongtawat ---
I did some test by starting with phrases-icu.xml and change it towards
words-icu.xml. Here is what I got:
1. Adding the first two transliterate rules in words-icu.xml to
phrases-icu.xml.
--> Stack Smashed.
2. Changing this line:
to
Now it index fine.
So, if I just add the WhiteSpace remove rule to phrases-icu.xml, what effect it
will cause?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 12:29:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 10:29:07 +0000
Subject: [Koha-bugs] [Bug 12341] New: Untranslatable strings in
file-upload.inc
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12341
Bug ID: 12341
Summary: Untranslatable strings in file-upload.inc
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs at lists.koha-community.org
Reporter: pasi.kallinen at pttk.fi
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
$("#fileuploadfailed").text("Upload failed -- no permission to upload files");
$("#fileuploadfailed").text("Upload failed -- unable to store file on server");
$("#fileuploadfailed").text("Upload failed -- database in maintenance state");
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 12:36:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 10:36:39 +0000
Subject: [Koha-bugs] [Bug 12342] New: Patron registration datepicker
dropdown shows only 10 years
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342
Bug ID: 12342
Summary: Patron registration datepicker dropdown shows only 10
years
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs at lists.koha-community.org
Reporter: pasi.kallinen at pttk.fi
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
Registering a new patron, click on the date of birth -date picker, the year
dropdown only shows 10 years (eg. 2004 - 2014). It should show 20 years, to
catch most patrons to be registered.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 12:56:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 10:56:00 +0000
Subject: [Koha-bugs] [Bug 12336] Author of reserved book is not displayed in
opac-user.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12336
--- Comment #1 from Viktor Sarge ---
Created attachment 28594
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28594&action=edit
Fix for author of reserved book not displaying in Opac 12336
This patch adds a line in opac-user.pl passing author info to opac-user.tt
Thanks to cait for helping me out and showing me how to solve this with half
the amount of code.
Test plan:
* Reserve a book.
* Go to the opac and log in as the patron you reserved the book for.
* Apply the patch with change to opac-user.pl
* Revisit the opac and refresh it.
* See if author now shows up
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 12:56:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 10:56:18 +0000
Subject: [Koha-bugs] [Bug 12343] New: TransformKohaToMarc() is adding MARC
subfields in random order
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12343
Bug ID: 12343
Summary: TransformKohaToMarc() is adding MARC subfields in
random order
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: gmcharlt at gmail.com
Reporter: abl at biblos.pk.edu.pl
QA Contact: testopia at bugs.koha-community.org
This function iterates through it's argument - which is a hashref - using
'each'. Perl is not guaranteed to return hash keys in any particular order (not
to mention that in more recent perl versions, explicit hash key order
randomization is to be expected).
As a consequence:
1) For biblio records added via acquisition (order from a new/empty record,
order
from a suggestion), freshly created MARC biblio records doesn't always have 260
$b and 260 $c stored in the proper order
2) Holdings data exported for zebra indexing as 952 fields may have subfields
generated in more-or-less random order. While it probably (?) does not affect
zebra indexing/searching in any significant way, end result is prone to be
somehow ugly (which can be a potential issue e.g. for people running Z39.50
server) and is not guaranteed to be consistent; different records - or even
different items in the same record, can have 952 subfields generated in
indiscriminate order.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 13:00:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 11:00:12 +0000
Subject: [Koha-bugs] [Bug 12336] Author of reserved book is not displayed in
opac-user.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12336
Viktor Sarge changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 13:03:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 11:03:42 +0000
Subject: [Koha-bugs] [Bug 12343] TransformKohaToMarc() is adding MARC
subfields in random order
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12343
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #1 from M. de Rooy ---
Vaguely remember some earlier discussion about this.. You did not find any
references to this in older reports? :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 13:30:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 11:30:44 +0000
Subject: [Koha-bugs] [Bug 12344] New: Multi transport types for issues and
checkins
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344
Bug ID: 12344
Summary: Multi transport types for issues and checkins
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Notices
Assignee: koha-bugs at lists.koha-community.org
Reporter: benjamin.rokseth at kul.oslo.kommune.no
QA Contact: testopia at bugs.koha-community.org
This bug relates to bug #9016 - multi transport types already pushed to master
(3.16).
If a patron has enabled notice for checkin/checkout other than email, the
message transport type (e.g. sms) is ignored in the notice generation.
The affected method is C4::Circulation::SendCirculationAlert
Generation of notice (C4::Letters::GetPreparedLetter) is done before the check
for borrower's chosen transport types
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 13:36:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 11:36:33 +0000
Subject: [Koha-bugs] [Bug 11292] barcode scanner clicking 'save'
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292
--- Comment #14 from Kyle M Hall ---
I am more than willing to make adjustments if necessary. However, I'm not
grokking what the inconsistency in this case is. Should be make noEnterSubmit
apply to forms Koha-wide, and have a provision to allow it ( i.e.
allowEnterSubmit )?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:03:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:03:26 +0000
Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577
Holger Mei?ner changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28454|0 |1
is obsolete| |
--- Comment #13 from Holger Mei?ner ---
Created attachment 28595
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28595&action=edit
Bug 11577: Add auto_renew flags to the database
- issues.auto_renew
- old_issues.auto_renew
- issuingrules.auto_renew
Default value is zero.
To test:
1) Run installer/data/mysql/updatedatabase.pl
2) Create SQL reports like:
SELECT * FROM issues LIMIT 0,1
3) Confirm that a column auto_renew was added to each of the three tables.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:03:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:03:29 +0000
Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577
Holger Mei?ner changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28426|0 |1
is obsolete| |
--- Comment #14 from Holger Mei?ner ---
Created attachment 28596
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28596&action=edit
Bug 11577: Add "Automatic renewal" to the circulation and fine rules
This patch adds a column "Automatic renewal" to the circulation and
fine rules table.
To test:
1) Add or edit some issuing rules.
2) Confirm that "Automatic Renewal" is set to "No" by default and
can be switched to "Yes".
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:03:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:03:32 +0000
Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577
Holger Mei?ner changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28427|0 |1
is obsolete| |
--- Comment #15 from Holger Mei?ner ---
Created attachment 28597
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28597&action=edit
Bug 11577: Code and intranet template changes
This patch adds a checkbox for "Automatic renewal" to the checkout page.
CanBookBeRenewed is modified to include two new errors:
- auto_renew (renewal shouldn't be done manually)
- auto_too_soon (renewal is premature and shouldn't be done manually)
To test:
1) Add or edit an issuing rule with "Automatic renewal" and another
one without it.
2) Issue at least three items:
- automatic renewal by issuing rule
- automatic renewal by Checkbox on the checkout page
- no automatic renewal
3) Test the following steps for both:
Home > Circulation > Checkouts
Home > Patrons > Patron details
4) Confirm that issues with automatic renewal cannot be renewed manually,
even if there are still renewals left and it's not too soon to renew.
5) Confirm that "Automatic renewal" and the remaining renewals are
displayed. If no renewals are left "Not renewable" should be displayed.
6) Confirm that issues without automatic renewal behave as usual.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:03:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:03:35 +0000
Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577
Holger Mei?ner changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28428|0 |1
is obsolete| |
--- Comment #16 from Holger Mei?ner ---
Created attachment 28598
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28598&action=edit
Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page
This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon'
to the renewal interface.
To test:
1) Issue two items:
- one with automatic renewal and no value for "No renewal before"
- another with automatic renewal and a value for "No renewal before"
2) Try to renew:
Home > Circulation > Renew
3) Confirm there are error messages explaining that the items have been
sheduled for automatic renewal and that one of the renewals is also
premature.
4) If global syspref AllowRenewalLimitOverride is set to "Allow" you
should be given the option to override.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:03:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:03:38 +0000
Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577
Holger Mei?ner changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28429|0 |1
is obsolete| |
--- Comment #17 from Holger Mei?ner ---
Created attachment 28599
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28599&action=edit
Bug 11577: Expand description of AllowRenewalLimitOverride
With the introduction of the new automatic renewal feature global syspref
AllowRenewalLimitOverride is expanded in meaning. It now gives the option
to override blocks if:
- the number of allowed renewals is exceeded
- the renewal is premature (No renewal before)
- the item is sheduled for automatic renewal
- the renewal is premature and the item is sheduled for automatic renewal
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:03:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:03:41 +0000
Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577
Holger Mei?ner changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28430|0 |1
is obsolete| |
--- Comment #18 from Holger Mei?ner ---
Created attachment 28600
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28600&action=edit
Bug 11577: OPAC bootstrap theme changes
This patch makes opac-user.pl and the bootstrap version of opac-user.tt
handle the new renewal errors "auto_renew" and "auto_too_soon".
To test:
1) Set global syspref "opacthemes" to bootstrap.
2) Set global syspref "OpacRenewalAllowed" to Allow.
3) Test the same things as in previous patch, this time for the OPAC
summary page.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:03:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:03:45 +0000
Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577
Holger Mei?ner changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28431|0 |1
is obsolete| |
--- Comment #19 from Holger Mei?ner ---
Created attachment 28601
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28601&action=edit
Bug 11577: OPAC prog theme changes
This patch makes the prog version of opac-user.tt handle the new
renewal errors "auto_renew" and "auto_too_soon".
To test:
1) Set global syspref "opacthemes" to prog.
2) Test the same things as in previous patch.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:03:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:03:48 +0000
Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577
Holger Mei?ner changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28432|0 |1
is obsolete| |
--- Comment #20 from Holger Mei?ner ---
Created attachment 28602
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28602&action=edit
Bug 11577: Add an automatic renewal cronjob
This patch adds a new cron script automatic_renewals.pl and a new
entry in crontab.example.
To test:
1) You need a few issues, some with automatic renewal and some without.
2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl
those issues are renewed that meet all of the following criteria:
- automatic renewal has been sheduled either by issuing rule or by
checkbox on the checkout page
- the number of allowed renewals isn't exceeded
- renewal isn't premature (No renewal before)
3) Confirm that all other issues are not affected.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:03:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:03:54 +0000
Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577
--- Comment #22 from Holger Mei?ner ---
Created attachment 28604
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28604&action=edit
Bug 11577: Add Hochschule f?r Gesundheit to contributing institutions
Automatic renewal is the second feature sponsored by the hsg.
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:03:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:03:51 +0000
Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577
Holger Mei?ner changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28433|0 |1
is obsolete| |
--- Comment #21 from Holger Mei?ner ---
Created attachment 28603
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28603&action=edit
Bug 11577: Unit tests
This patch fixes a few unit tests that broke because of the new feature.
To test:
1) prove t/db_dependent/Circulation.t
2) prove t/db_dependent/Circulation_Issuingrule.t
3) prove t/db_dependent/Circulation_issue.t
Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:13:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:13:30 +0000
Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577
Holger Mei?ner changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28434|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:37:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:37:02 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
checkins
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344
--- Comment #1 from Benjamin Rokseth ---
Created attachment 28605
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28605&action=edit
This small patch corrects the order of generating notices for issues and
returns (checkout/checkin) so that borrower's notices are rendered correctly
(for sms,email,etc.)
Test plan:
1) Edit SMSSendDriver syspref to use driver 'Test'
2) Edit CHECKOUT template for sms to 'SMS test'
3) select SMS for test patron's messaging prefs for item checkout
4) checkout an item
5) check the table message_queue, verify that template sms is
not used (message content is not 'SMS test')
6) apply patch, make new checkout
7) check that message_queue table now has a correctly generated
notice with 'SMS test'
For a real world test use a real SMS::Send driver and run the
cronjob process-message-queue.pl to send messages immediately.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:38:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:38:39 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
checkins
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344
Benjamin Rokseth changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28605|0 |1
is obsolete| |
--- Comment #2 from Benjamin Rokseth ---
Created attachment 28606
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28606&action=edit
Bug 12344 - Multi transport types for issues and checkins
This small patch corrects the order of generating notices for issues and
returns (checkout/checkin) so that borrower's notices are rendered correctly
(for sms,email,etc.)
Test plan:
1) Edit SMSSendDriver syspref to use driver 'Test'
2) Edit CHECKOUT template for sms to 'SMS test'
3) select SMS for test patron's messaging prefs for item checkout
4) checkout an item
5) check the table message_queue, verify that template sms is
not used (message content is not 'SMS test')
6) apply patch, make new checkout
7) check that message_queue table now has a correctly generated
notice with 'SMS test'
For a real world test use a real SMS::Send driver and run the
cronjob process-message-queue.pl to send messages immediately.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:39:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:39:06 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
checkins
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344
Benjamin Rokseth changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:42:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:42:37 +0000
Subject: [Koha-bugs] [Bug 12308] show all title subfields on the holds list
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12308
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:42:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:42:40 +0000
Subject: [Koha-bugs] [Bug 12308] show all title subfields on the holds list
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12308
--- Comment #5 from Jonathan Druart ---
Created attachment 28607
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28607&action=edit
Bug 12308 - show all title subfields on the holds list
The patron summary page in the bootstrap OPAC does not show subtitle in
the list of checkouts, overdues, or holds. This patch corrects this.
To test, set your OPAC theme to bootstrap and log in to the OPAC as a
user who has items checked out, items overdue, and items on hold. At
least one of each of those should be a title which has a subtitle as
defined in Administration -> Keyword to MARC mapping. Subtitles should
appear correctly under the "Checked out," "Overdue," and "Holds" tabs.
Signed-off-by: Nicole C. Engard
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:42:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:42:58 +0000
Subject: [Koha-bugs] [Bug 12308] show all title subfields on the holds list
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12308
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28582|0 |1
is obsolete| |
CC| |jonathan.druart at biblibre.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 14:57:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 12:57:42 +0000
Subject: [Koha-bugs] [Bug 9069] Make it possible to import MARC21
authorities from VIAF into Koha
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9069
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |veron at veron.ch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:07:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:07:27 +0000
Subject: [Koha-bugs] [Bug 11292] barcode scanner clicking 'save'
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292
--- Comment #15 from M. de Rooy ---
(In reply to Kyle M Hall from comment #14)
> I am more than willing to make adjustments if necessary. However, I'm not
> grokking what the inconsistency in this case is. Should be make
> noEnterSubmit apply to forms Koha-wide, and have a provision to allow it (
> i.e. allowEnterSubmit )?
To my understanding: the inconsistency is two ways to handle the same. You
define a separate keyboard handler, but elsewhere the class name noEnterSubmit
is picked up by a global keyboard handler (see staff-global.js).
It would be more consistent to do the same in cataloging.js.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:23:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:23:17 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in french
unimarc_complet default Framework
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021
Gaetan Boisson changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28520|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:23:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:23:59 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in french
unimarc_complet default Framework
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021
--- Comment #14 from Gaetan Boisson ---
Ok i will use bug 11586 to propose futher changes then.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:24:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:24:15 +0000
Subject: [Koha-bugs] [Bug 11586] Better defaults for UNIMARC items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586
Gaetan Boisson changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |11021, 11030
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:24:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:24:15 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in french
unimarc_complet default Framework
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021
Gaetan Boisson changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |11586
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:24:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:24:15 +0000
Subject: [Koha-bugs] [Bug 11030] Add 359,
947 and 969 fields in french unimarc_complete framework
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030
Gaetan Boisson changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |11586
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:41:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:41:30 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in french
unimarc_complet default Framework
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021
--- Comment #15 from Gaetan Boisson ---
Created attachment 28608
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28608&action=edit
Bug 11021: Suppress unneeded fields in unimarc_complet default Framework
First patch, for "complete" framework, used by academic libray
900, 901, 910, 918, 920,950,960,970,980,987 fields were useless. I removed
them.
I kept only the fields mentionned in Sudoc documentation
http://documentation.abes.fr/sudoc/formats/loc/index.htm
916 field is not cited in that page, but it belongs to Sudoc format.
I kept also 2 fields specific to Electre in 2013 :
902 niveau de lecture (Electre)
903 indexation (Electre)
I also added to the name of the 9XX fields I kept the mention (Sudoc) /
(Electre) / (Koha), so it could be easier for librarians to know what is the
purpose and the origin of each field
I don't make an updatedatabase, because some libraries could still be using
these fields for good or bad reasons.
To test :
1) take a fresh Koha with unimarc marcflavor
2) in web installer, select french language, unimarc marflavor and "Grilles de
catalogage compl?tes".
3) check default framework in Administration > MARC Frameworks : it should be
without 900,901,910,918,920,950,970,980,987
Signed-off-by: Gaetan Boisson
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:42:50 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:42:50 +0000
Subject: [Koha-bugs] [Bug 11586] Better defaults for UNIMARC items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586
--- Comment #2 from Gaetan Boisson ---
More changes will be proposed to correct the default framework.
This patch will focus on French UNIMARC only.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:43:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:43:12 +0000
Subject: [Koha-bugs] [Bug 11586] Better default framework for UNIMARC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586
Gaetan Boisson changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Better defaults for UNIMARC |Better default framework
|items |for UNIMARC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:43:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:43:57 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in french
unimarc_complet default Framework
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021
Gaetan Boisson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:47:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:47:35 +0000
Subject: [Koha-bugs] [Bug 12345] New: Can't Clear Reading History for
Anonymous patron
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12345
Bug ID: 12345
Summary: Can't Clear Reading History for Anonymous patron
Change sponsored?: ---
Product: Koha
Version: 3.14
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: barton at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
When logged in to OPAC as anonymous patron (as set in AnonymousPatron syspref),
I can navigate to 'Your reading history' (...
cgi-bin/koha/opac-readingrecord.pl) and see items that have been checked out.
Clicking on 'your privacy' (... cgi-bin/koha/opac-privacy.pl), then clicking on
'immediate deletion' and 'OK' results in the message 'Your reading history has
been deleted.', But when I navigate back to the reading history page, items
have not been deleted, even when I refresh the page.
I was able to delete the search history when logged in as the patron with
borrowernumber 1.
User permissions are the same for borrowernumber 1 and the anonymous patron
(borrower number 39969).
mysql> select * from user_permissions where borrowernumber='39969';
Empty set (0.00 sec)
mysql> select * from user_permissions where borrowernumber='1';
Empty set (0.00 sec)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:48:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:48:05 +0000
Subject: [Koha-bugs] [Bug 12043] Popup when reserved item checked in at
wrong branch should generate transfer slip
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at biblibre.co
| |m
--- Comment #5 from Jonathan Druart ---
(In reply to Benjamin Rokseth from comment #4)
> Thanks for the feedback!
>
> You obsoleted the attachment without uploading a new, I don't know it that
> was intended? It can easily be undone by 'show obsolete', clicking 'details'
> next to the bug, then 'edit details', and unchecking the obsolete box.
It's my fault, git-bz has not been updated on sandboxes.
I did it this morning, this issue should not appear anymore.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:49:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:49:03 +0000
Subject: [Koha-bugs] [Bug 12043] Popup when reserved item checked in at
wrong branch should generate transfer slip
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26896|1 |0
is obsolete| |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:50:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:50:15 +0000
Subject: [Koha-bugs] [Bug 12043] Popup when reserved item checked in at
wrong branch should generate transfer slip
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26896|0 |1
is obsolete| |
--- Comment #6 from Jonathan Druart ---
Created attachment 28609
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28609&action=edit
Bug 12043 - Popup when reserved item checked in at wrong branch should generate
transfer slip
This patch corrects some wrong popups in Returns.tt handling transfers
of reserved items.
Instead of using hold-transfer-slip.pl with param transfer=1 (which
seems to be silently ignored) it uses transfer-slip.pl with
itemnumber and destination branch, which allows for printing correct
slips.
It also removes the non-used param $tranfer in hold-transfer-slip.pl.
Test plan:
( see cases in bug description )
1) Make a reservation on item with homebranch A to branch B
2) checkin item at its homebranch A
3) press 'Print slip and confirm transfer'
4) verify that slip uses template RESERVESLIP
5) apply patch
6) repeat steps 1-3
7) verify that slip now uses template TRANSFERSLIP
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:50:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:50:29 +0000
Subject: [Koha-bugs] [Bug 12043] Popup when reserved item checked in at
wrong branch should generate transfer slip
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |benjamin.rokseth at kul.oslo.k
|ity.org |ommune.no
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:54:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:54:16 +0000
Subject: [Koha-bugs] [Bug 11958] classification sources help file has typo
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11958
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:54:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:54:18 +0000
Subject: [Koha-bugs] [Bug 11958] classification sources help file has typo
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11958
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28587|0 |1
is obsolete| |
--- Comment #7 from Jonathan Druart ---
Created attachment 28610
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28610&action=edit
Bug 11958: Fix typon in classification source help
The Classification Sources help file said the source was in the 942$2 but it's
in the 952$2 and 94$2 so this patch fixes that.
To test:
* Go to Admin > Classification Sources
* Click Help
* Confirm the Help file is right now
Signed-off-by: Bernardo Gonzalez Kriegel
String change, no errors.
Note: Perhaps change "Authorized Values ..." for "Authorized values ..."
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:56:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:56:31 +0000
Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27381|0 |1
is obsolete| |
Attachment #28415|0 |1
is obsolete| |
--- Comment #11 from Jonathan Druart ---
Created attachment 28611
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28611&action=edit
Bug 12041 - improve Koha::Cache
This makes Koha::Cache behave better by default. It will use memcached
if available to do shared caching, if that's not available it will fall
back to in-memory caching. It also allows for a singleton accessor to
allow a single cache to be shared within a process.
* Added tests to confirm UTF8-cleanness.
* Added minor fixups to stop warnings.
Test plan:
* The t/Cache.t file runs successfully with and without the
MEMCACHED_SERVERS envvar set (and memcached running in the
environment.)
Signed-off-by: Brendan Gallagher
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:56:35 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:56:35 +0000
Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041
--- Comment #12 from Jonathan Druart ---
Created attachment 28612
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28612&action=edit
Bug 12041 - POD fixing followup
This fixes a minor POD error detected, and also adds the Koha/ directory
to the regular test case so that the in-repo tests can find these
things.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:56:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:56:39 +0000
Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041
--- Comment #13 from Jonathan Druart ---
Created attachment 28613
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28613&action=edit
Bug 12041: UT - Get rid of warnings
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:57:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:57:08 +0000
Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 15:57:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 13:57:14 +0000
Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:08:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:08:49 +0000
Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967
--- Comment #18 from Jonathan Druart ---
Robin, don't you think the $branch_limit variable should be part of the cache
key?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:29:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:29:28 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in french
unimarc_complet default Framework
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021
--- Comment #16 from mathieu saby ---
thank you ;-)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:34:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:34:46 +0000
Subject: [Koha-bugs] [Bug 12279] Diacritics in system preference editor
broken
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12279
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:34:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:34:49 +0000
Subject: [Koha-bugs] [Bug 12279] Diacritics in system preference editor
broken
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12279
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28557|0 |1
is obsolete| |
--- Comment #19 from Jonathan Druart ---
Created attachment 28614
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28614&action=edit
Bug 12279: Diacritics in system preference editor broken
Temporary fix into preferences.pl.
Bug 11944 should provide the real fix..
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:37:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:37:17 +0000
Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl
smartmatch operator
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151
--- Comment #6 from Tom?s Cohen Arazi ---
Created attachment 28616
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28616&action=edit
Bug 12151: Remove use of smartmatch operator in tools/batchMod.pl
The '~~' smartmatch operator is used to compare MARC::Field->subfield(code)
(i.e. a string) and the text element of each MARC::Field->subfields() which
is also plain text.
Substituting '~~' for 'eq' should be harmless then.
Regards
To+
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:37:12 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:37:12 +0000
Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl
smartmatch operator
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151
--- Comment #5 from Tom?s Cohen Arazi ---
Created attachment 28615
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28615&action=edit
Bug 12151: Remove uses of smartmatch operator from Koha/Solr/QueryBuilder.pm
Just that.
Regards
To+
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:45:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:45:46 +0000
Subject: [Koha-bugs] [Bug 12279] Diacritics in system preference editor
broken
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12279
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #20 from Tom?s Cohen Arazi ---
Patch pushed to the master branch.
Thanks Marcel!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:48:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:48:24 +0000
Subject: [Koha-bugs] [Bug 12280] "Others..." reason for suggestions not
showing in Bootstrap OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12280
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:48:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:48:27 +0000
Subject: [Koha-bugs] [Bug 12280] "Others..." reason for suggestions not
showing in Bootstrap OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12280
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28577|0 |1
is obsolete| |
--- Comment #3 from Jonathan Druart ---
Created attachment 28617
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28617&action=edit
Bug 12280 - "Others..." reason for suggestions not showing in Bootstrap OPAC
If you accept or reject a suggestion using the "Others..." option and
entering a reason manually, the text is not showing up in the Bootstrap
OPAC theme as it does in CCSR and prog. This patch corrects the problem.
This patch also adds a missing [% USE AuthorisedValues %] which would
cause errors if the template tried to display a custom suggestion status
as defined in the SUGGEST_STATUS authorized value category.
To test, accept or reject a suggestion and specify a custom reason. View
that suggestion in the Bootstrap OPAC and confirm that the custom reason
is displayed.
Signed-off-by: Nicole C. Engard
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:50:54 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:50:54 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
syspref
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21221|1 |0
is obsolete| |
CC| |jonathan.druart at biblibre.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:53:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:53:05 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
syspref
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21221|0 |1
is obsolete| |
--- Comment #15 from Jonathan Druart ---
Created attachment 28618
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28618&action=edit
Bug 10554 - Add more options to 'AllowSelfCheckReturns' syspref
This patch modifies the options of AllowSelfCheckReturns syspref
from a 2 option selection
- 'allow patrons', dont allow patrons'
to a 3 option selection
- 'allow all patrons', 'allow non-blocked patrons' , allow no patrons'
currently, a problem with the syspref behavior in Koha is that enabling the
'AllowSelfCheckReturns' syspref does *not* allow patrons with a 'block' to
return items via the SCO. (this is apparently by design, and not a bug)
however, some libraries do want to allow patrons to return items via the SCO
even if they have a 'block'
this patch adds this additional behavior, by adding a new option to the
syspref, but also retaining the existing syspref behavior
after the patch, there are 2 allow options
- 'Allow all' allows all patrons to return items (including blocked patrons)
- 'Allow non-blocked' allows only non-blocked patrons to return items
(note: this is the current 'allow' behavior)
the patch correctly 'upgrades' existing 'allow' selection to the new 'Allow
non-blocked' value. so, any existing 'allow' selection works as before
----------
to test these 3 syspref options...
1/
- set syspref to 'dont allow'
- issue an item to a patron
- attempt to return item via SCO, return should FAIL
2/
- set syspref to 'allow all'
- issue an item to a patron
- attempt to return item via SCO, return should SUCCEED
3/
- set syspref to 'allow nonblocked'
- issue an item to a patron
- attempt to return item via SCO, return should SUCCEED
- issue an item to a patron, with a returndate of '2001-01-01'
(important: this will create an overdue item, that will put a 'block' on this
patron's account)
- attempt to return item via SCO, return should FAIL
Signed-off-by: Mason James
Signed-off-by: Pierre Lorgue
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:53:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:53:40 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
syspref
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554
--- Comment #16 from Jonathan Druart ---
I added the signoff line.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:58:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:58:29 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
syspref
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #17 from Jonathan Druart ---
Mason,
Could you please answer to Mark's comment please?
Marked as Failed QA.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 16:59:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 14:59:32 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
syspref
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554
--- Comment #18 from Jonathan Druart ---
Comment on attachment 28618
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28618
Bug 10554 - Add more options to 'AllowSelfCheckReturns' syspref
Review of attachment 28618:
--> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10554&attachment=28618)
-----------------------------------------------------------------
::: installer/data/mysql/updatedatabase.pl
@@ +8555,5 @@
> +if ( CheckVersion($DBversion) ) {
> +
> + #get current value
> + my $sth = $dbh->prepare("SELECT * from systempreferences where variable = 'AllowSelfCheckReturns'");
> + $sth->execute;
Should be replaced with $dbh->selectcol_arrayref
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 17:01:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 15:01:16 +0000
Subject: [Koha-bugs] [Bug 3092] Data values storage and use 100 bug meta-bug
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3092
giuseppe.angilella at ct.infn.it changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |giuseppe.angilella at ct.infn.
| |it
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 17:21:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 15:21:47 +0000
Subject: [Koha-bugs] [Bug 12086] Hold priorities incorrect,
when waiting status was reversed
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086
--- Comment #16 from Jonathan Druart ---
Comment on attachment 27428
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27428
[SIGNED-OFF] Bug 12086 - Hold priorities incorrect, when waiting status was
reversed
Review of attachment 27428:
--> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12086&attachment=27428)
-----------------------------------------------------------------
Why don't you use t/db_dependent/Holds.t?
::: t/db_dependent/Holds_12086.t
@@ +1,2 @@
> +#!/usr/bin/perl
> +
Are you sure we want 1 file per bug?
This is a new way to do. Maybe should you sent an email to the list to get
other opinions.
@@ +15,5 @@
> +
> +BEGIN {
> + use FindBin;
> + use lib $FindBin::Bin;
> +}
Why do you use FindBin?
@@ +40,5 @@
> +my ($bibnum, $title, $bibitemnum) = create_helper_biblio();
> +
> +# Helper item for that biblio.
> +diag("Creating item instance for testing.");
> +my $item_barcode = '99999999999999999999';
Hum, yes but why not "my_barcode"? :)
@@ +48,5 @@
> +my @borrowernumbers;
> +foreach (1..$borrowers_count) {
> + my $borrowernumber = AddMember(
> + firstname => 'my firstname',
> + surname => 'my surname ' . $_,
Please don't use the variable loop $_ to avoid futures errors.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 17:23:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 15:23:13 +0000
Subject: [Koha-bugs] [Bug 12086] Hold priorities incorrect,
when waiting status was reversed
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |jonathan.druart at biblibre.co
| |m
--- Comment #17 from Jonathan Druart ---
Kyle, could you please answer my questions please?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 17:24:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 15:24:05 +0000
Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for
overdues
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180
--- Comment #21 from Jonathan Druart ---
This one is major, please test.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 17:41:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 15:41:51 +0000
Subject: [Koha-bugs] [Bug 12266] The z39.50 authority search to create new
auth record works randomly
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12266
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 - low |P3
CC| |veron at veron.ch
--- Comment #1 from Marc V?ron ---
Hi to all,
With Koha version 3.17.00.007 (Current Master), I get no Z39.50 search at all.
With 3.14.01.000 it works as expected.
Tested with Firefox 29.01 on Win 7. All popups allowed.
Same behaviour with Chrome 35.0.1916.114 m
To reproduce:
Step 1)
------
Go to .../cgi-bin/koha/authorities/authorities-home.pl
Result:
Error in console:
Time: 02.06.2014 16:03:24
Error: SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the
JSON data
Source: .../cgi-bin/koha/authorities/authorities-home.pl
Line: 126
This line reads:
alreadySelected = JSON.parse(alreadySelected);
Step 2)
------
Click "New from Z39.50"
Result:
Popup window should open but nothing happens.
URL changes to
.../cgi-bin/koha/authorities/authorities-home.pl#
(same as in Zeno's remarks)
3 identical warnings in console:
Time: 02.06.2014 16:07:24
Warning: Empty string passed to getElementById().
Source: .../intranet-tmpl/lib/jquery/jquery.js
Line: 2
--
I change importance to P3 (Seriously broken, but not high impact)
Oh, found:
There are two lines:
if (alreadySelected !== null)
but this works only when the variable alreadySelected is defined.
I add a test for defined - the Popup works. (However it's puzzling that the
same code worked with 3.14)
Patch follows.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 17:42:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 15:42:40 +0000
Subject: [Koha-bugs] [Bug 12137] Extend CalendarFirstDayOfWeek to be any day
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12137
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27560|0 |1
is obsolete| |
--- Comment #5 from M. Tompsett ---
Created attachment 28619
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28619&action=edit
Bug 12137 - Extend CalendarFirstDayOfWeek to be any day
Mubassir Ahsan asked on the Koha mailing list:
Is there any option to set Saturday as the first day of
the week? Please help me.
CalendarFirstDayOfWeek is currently either Sunday|Monday.
By converting it to 0|1|2|3|4|5|6
(Sunday, Monday, ..., Saturday), we can allow any day of the
week to be the first day of the week in the date picker.
TEST PLAN
---------
1) Backup DB
2) In mysql:
> DELETE FROM systempreferences;
> SOURCE .../installer/data/mysql/sysprefs.sql
> SELECT variable,value FROM systempreferences;
-- It should say 'CalendarFirstDayOfWeek' and '0'
May say '1' if you are using Norwegian.
3) Restore your DB
4) .../installer/data/mysql/updatedatabase.pl
-- If your previous value for 'CalendarFirstDayOfWeek' was
'Sunday', it should be '0'. For 'Monday', it should be '1'.
5) Test an installation with 'de-DE' as the language.
-- The default value should be '1'.
6) Test an installation with 'nb-NO' as the language.
-- The default value should be '1'.
7) In the staff client, confirm that any day of the week is
available in the I18N/L10N system preferences for the
CalendarFirstDayOfWeek dropdown.
-- I'm aware they aren't in order, but I'm after
functionality, not finesse.
8) In another tab, go to a staff place that has a datepicker.
For example, Home -> Tools -> Inventory/stocktaking
9) For each possible value in the CalendarFirstDayOfWeek,
go to the other tab, refresh the page after updating the
system preference, and click the datepicker icon.
-- The date picker should then start on the selected
day of the week.
10) Log into OPAC
-- This may require setting: opacuserlogin to 'Allow'.
11) Click the personal details tab on the left.
12) There is a date picker for the date of birth.
-- The date picker should then start on the selected
day of the week.
13) Run koha QA test tools.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 18:19:04 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 16:19:04 +0000
Subject: [Koha-bugs] [Bug 12266] The z39.50 authority search to create new
auth record works randomly
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12266
--- Comment #2 from Marc V?ron ---
Created attachment 28620
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28620&action=edit
Bug 12266 - The z39.50 authority search to create new auth record works
randomly
Test scenario:
Make sure that Z39.50 servers for authorities are defined (e.g. form Library of
Congress)
Go to Authorities
Click on "Z39.50 search"
Without patch it can happen that the popup window for Z39.50 does not show up
Apply patch
Reload page
Click again on "Z39.50 search"
Pop up window should now display as expected.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 18:20:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 16:20:48 +0000
Subject: [Koha-bugs] [Bug 12266] The z39.50 authority search to create new
auth record works randomly
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12266
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 18:24:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 16:24:59 +0000
Subject: [Koha-bugs] [Bug 11522] self registration formatting
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
--- Comment #8 from Kyle M Hall ---
Patch pushed to 3.12.x, will be in 3.12.13
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 18:25:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 16:25:20 +0000
Subject: [Koha-bugs] [Bug 11476] Opac self registration title pull down
offers 2 empty options
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11476
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
--- Comment #6 from Kyle M Hall ---
Patch pushed to 3.12.x, will be in 3.12.13
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 18:25:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 16:25:47 +0000
Subject: [Koha-bugs] [Bug 11554] Capitalization fix in patron account on
fines tab
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11554
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
--- Comment #7 from Kyle M Hall ---
Patch pushed to 3.12.x, will be in 3.12.13
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 18:38:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 16:38:59 +0000
Subject: [Koha-bugs] [Bug 12279] Diacritics in system preference editor
broken
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12279
Galen Charlton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
--- Comment #21 from Galen Charlton ---
Pushed to 3.16.x.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 18:44:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 16:44:39 +0000
Subject: [Koha-bugs] [Bug 12346] New: False patron modification alerts on
members-home.pl
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346
Bug ID: 12346
Summary: False patron modification alerts on members-home.pl
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs at lists.koha-community.org
Reporter: kyle at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Due to the way members-home.pl handles the variable $branch, the number of
patron modifications listed on members-home.pl may differ from the number
listed on mainpage.pl. When the librarian clicks this link, he or she may see a
different number than was listed, or none at all!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 18:44:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 16:44:44 +0000
Subject: [Koha-bugs] [Bug 12346] False patron modification alerts on
members-home.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 18:45:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 16:45:26 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084
Pablo AB changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pablo.bianchi at gmail.com
--- Comment #13 from Pablo AB ---
(In reply to Kyle M Hall from comment #6)
> Position 05 of the leader in MARC 21 indicates the record's status.
> A lower case ?d? indicates that the record is to be deleted
> (http://www.loc.gov/marc/authority/adleader.html).
JFTR, that link talks about authority records, but for biblio records is the
same:
http://www.loc.gov/marc/bibliographic/bdleader.html
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 18:49:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 16:49:42 +0000
Subject: [Koha-bugs] [Bug 12346] False patron modification alerts on
members-home.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 18:49:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 16:49:44 +0000
Subject: [Koha-bugs] [Bug 12346] False patron modification alerts on
members-home.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346
--- Comment #1 from Kyle M Hall ---
Created attachment 28621
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28621&action=edit
Bug 12346 - False patron modification alerts on members-home.pl
Due to the way members-home.pl handles the variable $branch, the number
of patron modifications listed on members-home.pl may differ from the
number listed on mainpage.pl. When the librarian clicks this link, he or
she may see a different number than was listed, or none at all!
Test Plan:
1) Create a number of modification request for BranchA
2) Log into the staff intranet and set your branch to BranchB
3) Note the modifications alert to does display on mainpage.pl
4) Click the "Patrons" link to take you to members-home.pl
5) Note the modifictions alert does display on this page
6) Apply this patch
7) Reload members-home.pl, note the alert no longer displays
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 20:16:20 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 18:16:20 +0000
Subject: [Koha-bugs] [Bug 12347] New: Search performance improvements
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12347
Bug ID: 12347
Summary: Search performance improvements
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: gmcharlt at gmail.com
Reporter: tomascohen at gmail.com
QA Contact: testopia at bugs.koha-community.org
As-of code introduced by bug 11096, the current C4::Search::getRecords and
C4::Search::searchResults code creates MARC::Record objects for search results
twice. This makes searching slower than before.
Code should be refactored in order to create the MARC::Record objects for the
first time, and reuse it afterwards.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 20:27:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 18:27:18 +0000
Subject: [Koha-bugs] [Bug 12336] Author of reserved book is not displayed in
opac-user.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12336
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 20:27:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 18:27:21 +0000
Subject: [Koha-bugs] [Bug 12336] Author of reserved book is not displayed in
opac-user.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12336
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28594|0 |1
is obsolete| |
--- Comment #2 from Magnus Enger ---
Created attachment 28622
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28622&action=edit
Bug 12336 - [SIGNED-OFF] Author of reserved book is not displayed in
opac-user.pl
This patch adds a line in opac-user.pl passing author info to opac-user.tt
Thanks to cait for helping me out and showing me how to solve this with half
the amount of code.
Test plan:
* Reserve a book.
* Go to the opac and log in as the patron you reserved the book for.
* Apply the patch with change to opac-user.pl
* Revisit the opac and refresh it.
* See if author now shows up
Signed-off-by: Magnus Enger
Created a hold. Author is not shown n the public catalogue before
applying the patch, but it does show after applying the patch. Way
to go, Viktor!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 20:36:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 18:36:42 +0000
Subject: [Koha-bugs] [Bug 12347] Search performance improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12347
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 20:36:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 18:36:45 +0000
Subject: [Koha-bugs] [Bug 12347] Search performance improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12347
--- Comment #1 from Tom?s Cohen Arazi ---
Created attachment 28623
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28623&action=edit
Bug 12347: Performance improvements in Search.pm
Short: some costly stuff is done twice, this patch refactors that to make it
more reasonable.
Long: Bug 11096 introduced a noticeable overhead to the facet building stage
of the getRecords code. This patch leverages it by propagating the MARC::Record
objects created upon facet building, and reusing them in the
C4::Search::searchResults
function.
To test:
- Search for a term on master
- Apply the patch
- Same results
Unit tests reflecting API change in a separate patch.
Regards
To+
Sponsored-by: Universidad Nacional de Cordoba
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 22:06:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 20:06:33 +0000
Subject: [Koha-bugs] [Bug 12348] New: unique barcodes should be mandatory
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12348
Bug ID: 12348
Summary: unique barcodes should be mandatory
Change sponsored?: ---
Product: Koha
Version: 3.14
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: barton at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Partner has an item that shows 'check-in failed' in the 'Check-in' column in
circulation.pl. When the item is brought up in holdings, there is no link to
click on to allow editing.
All library interaction with items (check-in, check-out, item edit) require bar
codes, but there are no integrity checks in Koha (in the database or perl code)
to ensure that all items must have barcodes. This leads to support issues when
partners create items that do not have barcodes, then cannot do anything with
them. Ideally, I would think that items.barcode should be defined as
`barcode` varchar(20) NOT NULL
If this isn't possible for historical reasons, then an effort should be made to
deprecate the practice of allowing NULL barcodes by emitting obnoxious warning
messages stating that NULL bar codes will not be allowed in future versions of
Koha.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 22:13:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 20:13:18 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
advanced search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937
--- Comment #31 from Blou ---
Created attachment 28624
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28624&action=edit
Bug 10937 - Add unit tests.
Modified t/db_dependant/Koha.t to test the two new functions from C4/Koha.pm.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 22:14:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 20:14:52 +0000
Subject: [Koha-bugs] [Bug 12348] unique barcodes should be mandatory
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12348
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #1 from Katrin Fischer ---
Hi Barton, I disagree here. I think the bug here is not that the item has no
barcode, but that it seems to cause problems for you.
We use items without barcodes when there is not really an item, like when the
library wants to add items for electronic resources or 'bound with' items,
where only one item exists, but other items on other records link to the real
one.
There are also libraries that have no barcodes on migration and add barcodes as
the items are checked out for the first time.
We also have introduced a new feature just one version ago to make it possible
to check out items without barcodes: itemBarcodeFallbackSearch
If you want to prevent libraries from adding items without barcodes, an option
could be to make the subfield mandatory in all frameworks.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 22:32:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 20:32:13 +0000
Subject: [Koha-bugs] [Bug 12343] TransformKohaToMarc() is adding MARC
subfields in random order
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12343
--- Comment #2 from Jacek Ablewicz ---
(In reply to M. de Rooy from comment #1)
> Vaguely remember some earlier discussion about this.. You did not find any
> references to this in older reports? :)
I performed several bugzilla searches, but no luck - they do not seem to yield
anything relevant. Also, according to http://splitter.koha-community.org/,
there are no C4/Biblio.pm patches for this issue currently awaiting in the
queue (?).
I'm wondering which approach might be best for fixing this:
- just sort (or reverse sort) the darn hash keys - that's a simple one; results
would be perhaps not particularly well-sorted, but at least they will be sorted
consistently ;)
- sort by field tags & subfield codes (but this function is apparently pretty
sensitive performance-wise ?)
- make it to accept arrayref instead of (or in addition to) hashref as an
argument, so the subfield order would be preserved - but that would not be all
that helpfull for item/holding data subfields which come from the database in
the hashref form.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jun 2 23:42:55 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 21:42:55 +0000
Subject: [Koha-bugs] [Bug 12308] show all title subfields on the holds list
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12308
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |chris at bigballofwax.co.nz
--- Comment #6 from Chris Cormack ---
Pushed to master in my role as module maintainer for the OPAC.
Thanks Owen
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jun 3 00:03:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 22:03:32 +0000
Subject: [Koha-bugs] [Bug 12349] New: patron name on suggestions should be
linked
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12349
Bug ID: 12349
Summary: patron name on suggestions should be linked
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
URL: /cgi-bin/koha/suggestion/suggestion.pl?#ASKED
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Acquisitions
Assignee: koha-bugs at lists.koha-community.org
Reporter: nengard at gmail.com
QA Contact: testopia at bugs.koha-community.org
It would be great if patron names on suggestions were linked to their patron
record.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jun 3 00:32:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 22:32:33 +0000
Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967
Robin Sheat changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |ASSIGNED
--- Comment #19 from Robin Sheat ---
(In reply to Jonathan Druart from comment #18)
> Robin, don't you think the $branch_limit variable should be part of the
> cache key?
Yes, you're totally right. I'll make a followup.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jun 3 00:36:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 22:36:19 +0000
Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967
--- Comment #20 from Robin Sheat ---
BTW you've probably noticed already, but when I say:
This patch depends on the caching changes of 9967.
I actually mean:
This patch depends on the caching changes of 12041.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jun 3 00:45:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 22:45:14 +0000
Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967
Robin Sheat changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jun 3 00:45:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 22:45:17 +0000
Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967
--- Comment #21 from Robin Sheat ---
Created attachment 28625
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28625&action=edit
Bug 9967 - include $branch_limit in the cache key
Make the caching more correct. Also removes a warn that got left behind.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jun 3 00:47:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 22:47:53 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
advanced search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jun 3 00:47:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 22:47:57 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
advanced search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28579|0 |1
is obsolete| |
Attachment #28624|0 |1
is obsolete| |
--- Comment #32 from M. Tompsett ---
Created attachment 28626
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28626&action=edit
Bug 10937 - Option to hide and group itemtypes from advanced search
It's possible to hide the records and the items, but the
advanced search form is a bit trickier. It would be nice if
we could specify which itemtypes are offered as search options
in the OPAC advanced search form.
To solve this, two new columns will be added in the item type.
1) Display in OPAC
Default : Yes
Set to NO to hide and itemtype in the opac's advanced search.
2) Search category
The search category allows library to group some similar
itemtypes in a single checkbox in the opac. The categories are
defined in an Authorized value.
For Example, itemtypes DVD, VHS could use the Video category.
Searching for Video in the OPAC would returns the DVD and VHS
items.
As C4/Koha was modified, a set of subtests were added to confirm
the changes in t/db_dependent/Koha.t. The two new routines add
a grouping functionality into the OPAC Advanced Search
Item type display area.
Initial coding by philippe.blouin at inlibro.com with
mtompset at hotmail.com providing extra testing, patching,
squashing, and rebasing.
CURRENT TEST PLAN
------------------
0) Back up database, so you can reset and retest easily. ;)
1) Apply the patch
2) Run Koha QA tool.
3) prove -v t/db_dependent/Koha.t
-- all tests should pass.
4) run ./installer/data/mysql/updatedatabase.pl to add the
two columns to itemtypes
-- Does a meaningful message get printed?
Are the columns added?
"DESCRIBE itemtypes;" should list hideinopac and
searchcategory.
5) You need to add a category to group your item types:
a) In Intranet/Koha Admin/Authorized values,
select DOCTYPECAT in the 'Show category:' dropdown
i) If you do not have a DOCTYPECAT category, create one.
b) Click button "New authorized value for DOCTYPECAT"
c) Enter
Authorized value: HARDWARE
Description : Hardware
Description (OPAC): Hardware
6) Group your items under that new category
a) In Intranet/Koha Admin/Item types, choose (at least)
two item types and for each:
- Click action/Edit on the right column
- Third row (below Description) is the Search category
list box, select Hardware
- click Save changes at the bottom
7) Select at least one item to be hidden in the OPAC search
a) In Intranet/Koha Admin/Item types (again), choose a
different item type:
- Click action/Edit
- Click the checkbox "Hide in OPAC" below the list of
icons.
8) Go test your modifications
a) Go to OPAC/Adv search.
b) Validate that all items modified above (hidden or grouped)
do not appear in Item type list
c) Validate that new item type Hardware does appear instead.
d) Select item Hardware, start Search.
e) Validate returned items are the of the two types that were
grouped into the Hardware category in step 4.
Sponsored-by: Vanier college
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jun 3 01:03:09 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jun 2014 23:03:09 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
advanced search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937
--- Comment #33 from M. Tompsett ---
Comment on attachment 28626
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28626
Bug 10937 - Option to hide and group itemtypes from advanced search
Review of attachment 28626:
--> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10937&attachment=28626)
-----------------------------------------------------------------
::: C4/Koha.pm
@@ +278,5 @@
>
> +=head2 GetItemTypesCategorized
> +
> +Returns item types but grouped by category if available.
> +The categories must be part of Authorized Values (DOCTYPECAT)
The perldoc on these new functions is lacking.
@@ +320,5 @@
> +=head2 GetItemTypesByCategory
> +
> + $category = category filter
> +
> +Returns the itemtypes that are grouped into the category.
The perldoc is valid, but horrible.
::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
@@ +127,5 @@
> + [% END %]
> +
> + (Options are defined as the authorized values for the DOCTYPECAT category)
> +
> + [% ELSE %]
Can you explain why there is an IF/ELSE case?
::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
@@ +141,5 @@
>
>
> [% FOREACH itemtypeloo IN advsearchloo.code_loop %]
> + [% IF ((!itemtypeloo.searchcategory) AND (itemtypeloo.cat == 0)) OR (itemtypeloo.cat == 1) %]
> +