[Koha-bugs] [Bug 10784] SMS-related code needs improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10784

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

--- Comment #1 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Adding to Magnus' findings:

all scripts under sms/ seems to concern some Turkish SMS reply service,
probably renew or reserve by SMS. However, they should hardly be part of Koha
main branch.
At least this should be a module under C4::SMS/Koha::SMS.

Also it might be in order to be able to pass various parameters to the chosen
SMS::Send driver from setting 'SMSSendDriver'.

Now the various drivers need to hardcode settings such as url, username,
password, etc.

I don't know what would be best practice, but maybe a setting such as
'SMSSendOptions' where options could be separated with '|'

e.g. 'url=http://smsservice.com|username=john|password=smith'

The drivers available at cpan:
http://search.cpan.org/search?query=sms%3A%3Asend&mode=all

uses a long range of options,
url,user,username,password,ssl,apikey,login,method, etc. It would be impossible
to include all in C4::SMS, but a generic option hash passed to the driver would
work, as per the Send::SMS doc: 

Params with a leading underscore are "private" driver-specific options and will
be passed through to the driver unchanged.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.