[Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21221|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 28618
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28618&action=edit
Bug 10554 - Add more options to 'AllowSelfCheckReturns' syspref

This patch modifies the options of AllowSelfCheckReturns syspref

from a 2 option selection
 - 'allow patrons', dont allow patrons'

to a 3 option selection
 - 'allow all patrons', 'allow non-blocked patrons' , allow no patrons'

currently, a problem with the syspref behavior in Koha is that enabling the
'AllowSelfCheckReturns' syspref does *not* allow patrons with a 'block' to
return items via the SCO. (this is apparently by design, and not a bug)

however, some libraries do want to allow patrons to return items via the SCO
even if they have a 'block'

this patch adds this additional behavior, by adding a new option to the
syspref, but also retaining the existing syspref behavior

after the patch, there are 2 allow options
 - 'Allow all' allows all patrons to return items (including blocked patrons)
 - 'Allow non-blocked' allows only non-blocked patrons to return items
     (note: this is the current 'allow' behavior)

the patch correctly 'upgrades' existing 'allow' selection to the new 'Allow
non-blocked' value. so, any existing 'allow' selection works as before

----------

to test these 3 syspref options...

1/
- set syspref to 'dont allow'
- issue an item to a patron
- attempt to return item via SCO,  return should FAIL

2/
- set syspref to 'allow all'
- issue an item to a patron
- attempt to return item via SCO, return should SUCCEED

3/
- set syspref to 'allow nonblocked'
- issue an item to a patron
- attempt to return item via SCO, return should SUCCEED

- issue an item to a patron, with a returndate of '2001-01-01'
(important: this will create an overdue item, that will put a 'block' on this
patron's account)
- attempt to return item via SCO, return should FAIL

Signed-off-by: Mason James <mtj at kohaaloha.com>

Signed-off-by: Pierre Lorgue <pierre.lorgue at ens-cachan.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.