[Koha-bugs] [Bug 12266] The z39.50 authority search to create new auth record works randomly

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12266

Marc Véron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
                 CC|                            |veron at veron.ch

--- Comment #1 from Marc Véron <veron at veron.ch> ---
Hi to all,

With Koha version 3.17.00.007 (Current Master), I get no Z39.50 search at all.
With 3.14.01.000 it works as expected.

Tested with Firefox 29.01 on Win 7. All popups allowed.
Same behaviour with Chrome 35.0.1916.114 m

To reproduce:

Step 1)
------
Go to .../cgi-bin/koha/authorities/authorities-home.pl

Result:
Error in console: 
Time: 02.06.2014 16:03:24
Error: SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the
JSON data
Source: .../cgi-bin/koha/authorities/authorities-home.pl
Line: 126
This line reads:
alreadySelected = JSON.parse(alreadySelected);

Step 2)
------
Click "New from Z39.50"

Result:
Popup window should open but nothing happens.
URL changes to 
.../cgi-bin/koha/authorities/authorities-home.pl#
(same as in Zeno's remarks)

3 identical warnings in console:
Time: 02.06.2014 16:07:24
Warning: Empty string passed to getElementById().
Source: .../intranet-tmpl/lib/jquery/jquery.js
Line: 2

--

I change importance to P3 (Seriously broken, but not high impact)

Oh, found: 
There are two lines: 
if (alreadySelected !== null)
but this works only when the variable alreadySelected is defined. 

I add a test for defined - the Popup works. (However it's puzzling that the
same code worked with 3.14)

Patch follows.

-- 
You are receiving this mail because:
You are watching all bug changes.