[Koha-bugs] [Bug 11801] In transit hold items incorrectly labeled as "Waiting to be pulled" on request.pl
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Jun 4 20:36:30 CEST 2014
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801
--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Jonathan Druart from comment #7)
> Since I disagree with the idea to call Koha::Database directly from pl
> scripts, I disagree with this patch :)
> Moreover, in my opinion it is useless to get the transfer using DBIC, we
> have a C4::Circulation::GetTransfers routine.
>
> The patch works as expected :)
>
> Galen and/or others QAers, could you please take a position on that?
I have no problem invoking Koha::Database directly from scripts. Not every bit
of database access needs to be wrapped in middleware. However, I will say that
if I were doing it via DBIC, I would probably add an at_destination method to
the Koha::Schema::Result::Reserves class.
That said, I have a stronger aversion to having multiple ways of asking the
same question. GetTransfers() gets the job done.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list