[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jun 11 12:35:00 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405

--- Comment #1 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 28773
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28773&action=edit
Bug 12405 - Search links on callnumber fails on intranet results page

On intranet results page, the callnumber of items is a search like :
/cgi-bin/koha/catalogue/search.pl?idx=callnum&q=[% result.itemcallnumber
|url %]

The callnumber should be URI-escaped to avoid special URI characters like & , ?
...
If the callnumber contains some CCL words or parenthesis, the search will fail,
it should be wrapped with double-quotes.

This patch adds this to catalogue/results.pl and catalogue/shelves.pl :
- uri TT filter instead of url
- adds double-quotes using there URI code %22 since its in a HTML attribute
using double-quotes

Test plan :
- Edit an item callnumber with : & ABC 123
- Index zebraqueue
- Perform a search returning this item
- Click on the callnumber
=> Without this patch you get no result, because URL parameters are :
idx=callnum&q=& ABC 123
=> With this patch you get results
- Set syspref QueryWeightFields off (because this is no bug if on)
- Edit an item callnumber with : AB(C) AND OR
- Index zebraqueue
- Perform a search returning this item
- Click on the callnumber
=> Without this patch you get no result, because the search contains CCL words
"OR" and "AND"
=> With this patch you get results

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list