[Koha-bugs] [Bug 12343] TransformKohaToMarc() is adding MARC subfields in random order

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jun 11 13:35:36 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12343

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 28719
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28719
Bug 12343 - TransformKohaToMarc() is adding MARC subfields in random order

Review of attachment 28719:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12343&attachment=28719)
-----------------------------------------------------------------

::: C4/Biblio.pm
@@ +2194,4 @@
>      while ( my ($name, $value) = each %$hash ) {
>          next unless my $dtm = $db_to_marc->{''}->{$name};
>          next unless ( scalar( @$dtm ) );
> +        my ($tag, $letter) = @$dtm; $tag .= '';

Please prefer 1 instruction by line.

@@ +2198,2 @@
>          foreach my $value ( split(/\s?\|\s?/, $value, -1) ) {
> +            $value eq '' && next;

Please prefer
  next if $value eq '';
of
  if ( $value eq '' ) {
    next;
  }

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list