[Koha-bugs] [Bug 12266] The z39.50 authority search to create new auth record works randomly

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jun 11 16:16:49 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12266

Marc Véron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12295

--- Comment #7 from Marc Véron <veron at veron.ch> ---
Hi Zeno,

After the latest pull (3.17.00.007, including Bug 12295), the z39.50 search
window pops up as expected.

However I have a question:

Original code:
    var alreadySelected = $.cookie('auth_to_merge');
    if (alreadySelected !== null) {
    (...)
    }

if-statement in Patch for Bug 12295:
    if (alreadySelected !== undefined)

if-statement in Patch for Bug 12266:
    if ((typeof alreadySelected !== 'undefined') && (alreadySelected !== null))

Question:
For some reason there was a test for null in the original code. 
Is it ever possible that $.cookie('auth_to_merge') results to null? If yes, I
suppose that it should be tested as well.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list