[Koha-bugs] [Bug 11270] Search Result highlighting should be refactored

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jun 18 22:15:09 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 23039
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23039
Bug 11270: Refactor hit highliginting code

Review of attachment 23039:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11270&attachment=23039)
-----------------------------------------------------------------

Please split the bootstrap and prog patches into two seperate patch files. It
is my understanding, which could be flawed, but given that 3.18 is likely to
deprecate prog/cssr, you want to not include prog/cssr patches in master.

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
@@ -356,5 @@
> -		    $("td").highlight(q_array[x]);
> -	    }
> -    }
> -    $(".highlight_toggle").toggle();
> -}

The two functions were in this code, and are moved to opac-highlight.inc, but
there is no include in this file. How are these functions still provided?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list