[Koha-bugs] [Bug 12451] circulation rule cant be edited if itemtype contains a space character

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12451

--- Comment #1 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 28979
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28979&action=edit
Bug 12451 - circulation rule cant be edited if itemtype contains a space
character

When an itemtype description contains a space character like " Book" (often
used to set this itemtype as first in sorted lists), the edition of an existing
circulation rule does not work, it selects the default itemtype.
Same for patron category.

It's because the JavaScript code performs a trim on value existing in table
itm = itm.replace(/^\s*|\s*$/g,'');
This patch adds trim on select options in editing line.

Test plan :
- Create an itemtype with a leading or trailling space in description : ie "
Book"
- Go to cgi-bin/koha/admin/smart-rules.pl
- Create a rule with this itemtype, Unit=hours and Hard due date=Exactly on
31/12/2015 (any date)
- Click on Edit on this rule line
=> Without this patch, the default itemtype is selected in edition line
=> With this patch, the correct itemtype is selected in edition line
Check others selects are ok :
- Create a rule with Unit=hours and Hard due date=Exactly on 31/12/2015 (any
date)
- Click on Edit on this rule line
=> The correct options are selected
Same tests with a patron category containing a leading or trailling space in
description

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.