[Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Maxime,
   Functionally, the patch works as described.  A few issues need to be
addressed.

First, to maintain consistent behavior, I think the default for the
RentalFeesCheckoutConfirmation preference should be Don't Ask.

Next, below is the message that popped up:

Please confirm checkout

    The patron has a debt of 3.00
    Rental charge for this item : 5,00 $


Need the currency symbol ($) in front of what the patron already owes.

Add period at the end of the first sentence.

Change comma to decimal in the rental charge.

Move currency symbol on charge to the front of price.  ($5.00)

Remove space before colon.

Ideally, the message should be formatted to look like this:

Please confirm checkout

    The patron has a debt of $3.00.
    Rental charge for this item: $5.00

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.