[Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jun 24 22:18:38 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230

--- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to mathieu saby from comment #6)
> Thanks for signing 
> 
> What do you think of the point 
> "Note that there is probably an issue to fix in Accounts.pm : the user is
> saved instead of the branch. But this is not the purpose of this patch, so I
> kept the previous behavior for the moment." 
> 
> Do you agree ? If so, I suppose it deserves a new bug
> It could be easy to fix, but I did not try to write a patch, because I did
> not know if it would be necessary and possible to fix the wrong data already
> stored in statistics table.
> (and additionnaly I've got no time for that...)

Hi Mathieu, You are right, and the removed comment said so.
But looking into the code, seems that the logic was to record somehow
what staff user did the payment. But there is a 'usercode' column in
statistics table, that seems to be the right place for that info.

A new bug is the right thing to do, maybe a mail to koha-devel first.
Old data... is unfixable.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list