[Koha-bugs] [Bug 12481] New: Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481

            Bug ID: 12481
           Summary: Staff client detail-view "next" link is greyed out
                    when the last search result of any results page is
                    clicked or navigated into
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: jseppal at student.uef.fi
          Reporter: jseppal at student.uef.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at biblibre.com
            Blocks: 12261

When doing a staff client catalog search with more than 1 page of results and
clicking the last result on any search result page, the top-left navigation
button for "next" is greyed out.

The expected behaviour would be to move into the next page of results. The
"next" navigation should only be prevented when the very last search result is
selected in the detail-view. 

As suggested in the linked bug 12261, this is a regression from my attempt to
fix the issue with the navigation letting the user moving out of bound in
relation to the result array. As suggested in bug 12261, the original cause was
in part due to the total number of results not being carried in the search
cookie. Secondly, the offset value that was being used in the navigation checks
shouldn't be used in there (the checks for allowing movement within the
results) because the cookie value is only updated upon a result click and not
when the user is navigating using the detail-view.

I wrongly submitted a patch to bug 12261 since it was already pushed. The patch
brings the total number of search results available (as I think it was
orignally planned, since the non-existing value was being used) to the
browser.js which handles the navigation and makes use of that.

I marked this as blocking 12261 - not sure if this is right...

-- 
You are receiving this mail because:
You are watching all bug changes.