[Koha-bugs] [Bug 11005] Centralize the UseBranchTransferLimits-check under one function

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22320|0                           |1
        is obsolete|                            |

--- Comment #14 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 29269
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29269&action=edit
Bug 11005 [ENH] - Centralize the UseBranchTransferLimits-check under one
function

Created a C4::Circulation::CanItemBeTransferred() as a more convenient branch
transfer check
than the previous multiline if-else mess. This is a more pleasant and readable
approach to generalizing
branch transfer checks accross Koha.
Includes a error message as the return value so the precise reasons for denial
need not be constructed
when needed.

Also a small fix to branchtransfers.pl to make a warning happen only during
debugging.

Unit tests included which test the new C4 function.

--
Rebased by chrisc at catalyst.net.nz fixing conflict.
This patch mixes whitespace clean up and functional changes, however if you
view it with
git show -w

You can see just the actual changes.

Currently is failing the tests on my dev set up


Current status: Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.