[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org

--- Comment #6 from Nick Clemens <nick at quecheelibrary.org> ---
Pardon if I am confused, but CanBooksBeReserved can return three different
reasons  [alreadyreserved, maxreseres, noholdableitems]

But the check in request.pl checks for alreadyreserved and assumes maxreserves
otherwise

   my $alreadyreserved = 0;
190            $maxreserves = 1;    
191        my ($can_book_be_reserved, $reasons) =
192          CanBookBeReserved( $borrowerinfo->{borrowernumber}, $biblionumber
);
193    
194        unless ($can_book_be_reserved) {
195            if ($reasons->{alreadyreserved}) {
196                $alreadyreserved = 1;
197                $biblioloopiter{warn} = 1;
198                $biblioloopiter{alreadyres} = 1;
199            } else {
200                $maxreserves = 1;
201            }

This seems to be the same issue as Bug 10912

To my mind, maxreserves shouldn't be flagged unless the patron is over their
number of reserves.

-- 
You are receiving this mail because:
You are watching all bug changes.