From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 00:15:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Feb 2014 23:15:16 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #54 from Galen Charlton --- Close, but there is a serious issue left: a regression on bug 2060. In particular, this patch regresses on the ability to properly display authority record batches. Instead of linking to the authority details page for imported records, for example, it links to the *bibliographic* details page. Sorting by citation for authority batches is also broken -- GetImportRecordsRange() is asked to sort by title when it should be sorting by authorized_heading. By the way, it would be preferable to me if GetImportRecordsRange() did not rely on dbh_quote_identifier() to sanitize the sorting column, which at present is passed directly from a CGI parameter. It should instead set $order_by to one of a known set of values, similar to how you deal with $order_by_direction. A much more minor issue: tools/batch_records_ajax.pl asserts that it's both GPL2 and GPL3+. Please squash your QA follow-ups (but not Owen's) when you resubmit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 09:35:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 08:35:12 +0000 Subject: [Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 --- Comment #5 from Katrin Fischer --- Created attachment 25749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25749&action=edit Bug 11828: Follow up - add new option to OrderPdfFormat This depends on bug 11459. To test: - Apply patch for 11459 - Apply patches for 11828 - Check appearance of the OrderPdfFormat system preference It will offer a pull down with options, including "German 2-page" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 09:35:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 08:35:36 +0000 Subject: [Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 10:21:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 09:21:08 +0000 Subject: [Koha-bugs] [Bug 11459] [Signed-Off] OrderPdfFormat pref description could be more verbose In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #18 from Marc V?ron --- Thanks, Galen. I did not set it to "Signed off" because it was "In Discussion". Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 11:02:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 10:02:58 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |MOVED --- Comment #13 from M. de Rooy --- I will move this code to bug 9032. Close this report now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 11:02:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 10:02:59 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 Bug 10389 depends on bug 10441, which changed state. Bug 10441 Summary: UT: Testing AddShare in VirtualShelves.t http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 11:03:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 10:03:16 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10389 | Depends on|9032 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 11:03:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 10:03:16 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10441 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 11:03:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 10:03:16 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10441 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 11:04:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 10:04:23 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |MOVED --- Comment #9 from M. de Rooy --- I will move this code to bug 9032. Close this report now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 11:04:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 10:04:46 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9032 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 11:04:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 10:04:46 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10389 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 11:07:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 10:07:08 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #39 from M. de Rooy --- Hope to revive this development next week by rebasing, making the requested QA changes and including work from the former dependency bug 10389 and bug 10441. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 11:07:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 10:07:24 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Share a list (part 1: send |Share a list |the invitation) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 11:39:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 10:39:59 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #73 from M. de Rooy --- (In reply to Galen Charlton from comment #72) > Pushed to master, along with a follow-up that does some trivial tidying of > the code. Thanks, Galen. Let us leave the cuddled else-discussions outside Koha, but moving to the other camp is quite hard :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 15:54:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 14:54:39 +0000 Subject: [Koha-bugs] [Bug 11212] Using non english characters in patron category description causes double encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11212 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 16:09:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 15:09:47 +0000 Subject: [Koha-bugs] [Bug 11212] Using non english characters in patron category description causes double encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11212 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9897 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 16:09:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 15:09:47 +0000 Subject: [Koha-bugs] [Bug 9897] members/member.pl double encoded utf-8 strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9897 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11212 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 16:13:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 15:13:26 +0000 Subject: [Koha-bugs] [Bug 9897] members/member.pl double encoded utf-8 strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9897 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 22:23:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 21:23:00 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 22:23:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 21:23:03 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19736|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 22:23:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 21:23:05 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19936|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 1 22:23:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Mar 2014 21:23:07 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20505|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 2 02:01:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Mar 2014 01:01:18 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #76 from Tom?s Cohen Arazi --- Yay! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 2 06:28:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Mar 2014 05:28:24 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- There's a merge problem. I'll let the original author rebase before I sign off, rather than me sign off on my rebase of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 2 09:31:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Mar 2014 08:31:42 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I think this change could be something not everyone will agree to as it sounds like the items line will take up a lot more space for bigger consortia with lots of libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 2 16:12:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Mar 2014 15:12:25 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #3 from M. Tompsett --- Yes, the substitution of a comma for a line break does increase vertical spacing. However, I personally find it more visually appealing and less of a giant blur from one into another. The vertical spacing increases *IF* there are multiple branches with the same biblio. A single branch would not experience any visual difference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 2 22:47:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Mar 2014 21:47:45 +0000 Subject: [Koha-bugs] [Bug 7234] koha-common Debian package should include koha-sites.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7234 --- Comment #7 from Robin Sheat --- Created attachment 25750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25750&action=edit Bug 7234: koha-common Debian package should include koha-sites.conf This patch adds a sample koha-sites.conf file, which will be included by the koha-common package in /etc/koha (where it belongs). It is fixed to include the current defaults (DOM indexing for both biblios and authorities, disabled use of memcached, and good defaults for a normal setup if enabled). All options are commented for ease of use by average users. To test - verify that the defaults are sane (let me know if it needs to be fixed). - build the package and verify that the file gets installed. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mark Tompsett Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 2 22:48:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Mar 2014 21:48:13 +0000 Subject: [Koha-bugs] [Bug 7234] koha-common Debian package should include koha-sites.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7234 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25721|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 2 22:48:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Mar 2014 21:48:42 +0000 Subject: [Koha-bugs] [Bug 7234] koha-common Debian package should include koha-sites.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7234 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Robin Sheat --- I like that, it's good :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 2 23:19:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Mar 2014 22:19:00 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove does not remove the stuff in /var/lib/koha/ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 --- Comment #3 from Robin Sheat --- (In reply to Mirko Tietgen from comment #2) > +1 for the purge option. I expected koha-remove to remove ?everything? and > got a lot of errors for existing register files when doing koha-restore. Then we should really have koha-create/koha-restore understand that these things could happen and to check for them first, doing something appropriately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 2 23:23:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Mar 2014 22:23:19 +0000 Subject: [Koha-bugs] [Bug 11418] cannot delete a course In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11418 Isaac changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isaacbrodsky at live.com --- Comment #3 from Isaac --- Tested in 3.14.04, deleting courses seemed to work fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 08:50:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 07:50:00 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 --- Comment #4 from Fridolin SOMERS --- (In reply to M. Tompsett from comment #3) > You confused debarred (from borrowers) with expiration (from > borrower_debarments). Oh. Is the patch wrong or is only the upgrade text wrong ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 09:23:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 08:23:05 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 --- Comment #5 from Katrin Fischer --- Comment on attachment 25637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25637 Bug 11846 - Correct database update for debarments with 9999-12-31 Review of attachment 25637: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11846&attachment=25637) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +8019,5 @@ > > +$DBversion = "3.15.00.XXX"; > +if ( CheckVersion($DBversion) ) { > + $dbh->do(q{ > + UPDATE borrower_debarments SET debarred = NULL WHERE debarred = '9999-12-31' This line is not right, as there is no debarred as a date in borrower_debarments. Please fix and test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:08:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:08:29 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23415|0 |1 is obsolete| | Attachment #23416|0 |1 is obsolete| | Attachment #23417|0 |1 is obsolete| | Attachment #23418|0 |1 is obsolete| | Attachment #24650|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 25751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25751&action=edit Bug 11319: Koha::SimpleMARC should take a hashref for parameters In order to avoid a long list of parameters, it should be better to pass all of them into a hashref. This patch does not add or modify a behavior. Test plan: Verify the unit tests still pass - prove t/SimpleMARC.t - prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:08:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:08:38 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #15 from Jonathan Druart --- Created attachment 25752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25752&action=edit Bug 11319: Add UT for the fields management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:08:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:08:43 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #16 from Jonathan Druart --- Created attachment 25753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25753&action=edit Bug 11319: Add the field management for Koha::SimpleMARC Currently the Koha::SimpleMARC module call a "field" a "subfield". And the way to manage field is not implemented for all routines. This patch does not modify the API. The routine's names are kept. It just creates 2 privates routines for each action (e.g. delete_field will call _delete_field if the action affects field and _delete_subfield if the action affects subfields). Before this patch the move action was authorised by the interface but caused an error if executed. Note: I don't see the meaning for the add/update action if no subfield is given. So the call without subfield raises an error. Test plan: - apply all patches - create or modify an existent template - try at least the correct behavior for the following actions: * delete subfield and field * add new subfield to an existing field * add new subfield to an nonexisting field * move a subfield * move an entire field * copy a subfield * copy an entire field - import a biblio and use this template - verify the imported biblio matches actions defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:08:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:08:48 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #17 from Jonathan Druart --- Created attachment 25754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25754&action=edit Bug 11319: Add specific UT for nonexistent field/subfield This patch only adds unit tests for the copy and move actions. They test if the action does not create a field/subfield if the source did not exist. Also it adds a unit tests for the existing behavior (in order not to lost it): we can use the '^' and the '$' character in regex for substituing. For example: Copy 245$a to 245$a with the regex s/^/BEGIN / This will add the string "BEGIN " at the beginning of the 245$a fields. To test: prove t/SimpleMARC.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:08:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:08:53 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #18 from Jonathan Druart --- Created attachment 25755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25755&action=edit Bug 11319: Template modifications This patch add template modifications for the restrictions: - the source field is always mandatory - on move and copy, the source and destination subfield should be both filled or blank. - on move and copy, the destination subfield should be filled. - on update, the subfield value should be filled. Test plan: Verify you are not able to create/modify template actions according to these restrictions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:09:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:09:24 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:09:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:09:50 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #19 from Jonathan Druart --- Fix conflict with bug 11478. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:12:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:12:24 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 --- Comment #5 from M. de Rooy --- Created attachment 25756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25756&action=edit Bug 8262: Special kohaadmin cannot create lists Since kohaadmin has no borrower number, it cannot create lists. A database error is logged, but the user is not notified. This patch alerts the user (kohaadmin). In the incidental case that a normal user gets a database error, he is notified too that the list could not be created. Test plan: This patch should be applied on top of 9032 patches. Login as kohaadmin under opac and staff. Create a list in opac and staff. Check the message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:12:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:12:29 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 --- Comment #6 from M. de Rooy --- Created attachment 25757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25757&action=edit Bug 8262: Follow-up for bootstrap theme Provide a warning under bootstrap when kohaadmin tries to create a list. Test plan: Login as special kohaadmin. Create a list in OPAC with bootstrap theme. Check the message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:13:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:13:27 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9032 --- Comment #7 from M. de Rooy --- I have built this upon patches for bug 9032. Please wait testing this until I submitted these patches. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:13:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:13:27 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8262 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:21:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:21:37 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23622|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 25758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25758&action=edit Bug 11413: Change the field number logic This patch series is a bugfix for the Marc modification templates tool. Bug description: If you want to do an action (delete/update/move/...) on a multivalued field and if a condition is defined on the same field, it is highly probable the resulted record will not be what you expect. For example: Deleting All (or the first) fields 650 if 245$a="Bad title" works with the current code. BUT if you want to delete All (or the first) fields 650 with a condition on 650$9=42, and if at least one field matches the condition : - if you have selected all, all fields 650 will be deleted, even the ones who do not match the condition. - if you have selected first, the first 650 field will be deleted, even if it does not match the condition. The expected behavior is to delete the fields matching the condition (and not all the 650 fields). What this patch does: This patch introduces 2 changes in the logic of Koha::SimpleMARC. The first change is a change of the prototypes for the 2 routines field_exists and field_equals. Now they return the "field number" of the matching fields. The second change is the type of the "n" parameter for all routines using it in Koha::SimpleMARC. Before this patch, the "n" parameter was a boolean in most cases. If 0, the action was done on all fields, if 1 on the first one only. Now it is possible to specify the "field numbers" (so the array of field numbers which is returned by field_exists or field_equals) for all routines which had the n parameter. Test plan for the patch series: Note: This test plan describes a specific example, feel free to create your own one. 0/ Define a marc modification template with the following action: Delete field 245 if 245$9 = 42 1/ choose and export a record with several 245 fields. For ex: 245 $a The art of computer programming $c Donald E. Knuth. $9 41 245 $a Bad title $c Bad author $9 42 2/ import it using the Stage MARC for import tool. 3/ verify the imported record does not contain any 245 field. 4/ apply all the patches from this bug report 5/ do again steps 2 and 3 6/ verify the imported record contains only one 245 field, the one with 245$9=41 7/ verify the unit tests passed: prove t/SimpleMARC.t prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:21:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:21:53 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23623|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 25759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25759&action=edit Bug 11413: UT to show up the issue These UT reflect this change: - deletion of the field 245 if 245$a='Bad title' - move of the 650 field to 651 if 650$9=499 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:22:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:22:01 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23624|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 25760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25760&action=edit Bug 11413: Reflect the changes to the interface Test plan: - add/edit an action on the marc modification templates tools - choose an action and define a condition - define the source field as same as the condition field - verify the All/1st dropdown list is changed to Every/1st -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 10:23:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 09:23:36 +0000 Subject: [Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #13 from Jonathan Druart --- Fix conflict with bug 11478. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 11:42:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 10:42:56 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #94 from Olli-Antti Kivilahti --- (In reply to Jonathan Druart from comment #92) > If some transport type are not relevant for someone, he cans completely > remove the mtt in the message_transport_types table. > > I don't see a proper way to implement what you propose. For instance, on > tools/overduerules.pl, all notices and mtt are listed. We could imagine a > tricky js stuff for disabling/enabling mtt function of the notice selected. > But is it really useful? Well this feature probably should be documented in the manual, but I don't think a feature is needed to add/remove $mtt's. If in the manual we had the information just discussed about adding/removing $mtt's via SQL, that would be enough. Also descriptions about which $mtt's are in use and instructions on writing your own cronjobs to handle them is a good solution. Atleast for us the print notice sending process is pretty complex and making a suitable UI for defining that process in a unified way might be quite difficult. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 12:00:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 11:00:24 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #2 from Olli-Antti Kivilahti --- -- Merge issues: -- --------------------- git pull git bz apply [9016 10832 10833 10845 11208] So far so good! So then we get the merge error :( http://pastebin.com/PrxXt4t4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 12:48:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 11:48:22 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25700|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25761&action=edit Bug 11867: MTT: Manage *_PHONE notices The *_PHONE notices (HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE) should be "merged" into the main code (i.e. HOLD, PREDUE and OVERDUE). Test plan: 1/ Make sure you have HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE notices 2/ Execute the update DB entry 3/ Verify the 3 notices have been merged into "phone" template of the HOLD, PREDUE and OVERDUE notices 4/ Verify there is no regression in the Talking Tech feature (how?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 12:48:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 11:48:38 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10845 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 12:48:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 11:48:38 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11867 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 13:53:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 12:53:57 +0000 Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22030|0 |1 is obsolete| | --- Comment #20 from Mirko Tietgen --- Created attachment 25762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25762&action=edit Bug 9972 Add/ change some zebra indexes (MARC21) This patch adds :w and :p versions to the index for ?Lexile number? (it has only :n so far) and adds indexes for 653 (Index term uncontrolled), 655 (Index term Genre/Form), 041 (language-audio) and 041 (language-subtitle). It also adds the ?curriculum?-index to Search.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 14:02:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 13:02:27 +0000 Subject: [Koha-bugs] [Bug 11868] Multi transport types: disable sms and phone if not in use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11868 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |olli-antti.kivilahti at jns.fi --- Comment #2 from Olli-Antti Kivilahti --- No merge issues here, which is great! For me the sms and phone checkboxes are disabled even if I have the SMSSendDriver = InaFinland::Driver && TalkingTechItivaPhoneNotification = 1. Sometimes these systempreferences are not updated in the DB, but I checked for that as well. I activated both and it shows in DB as well. Still sms and phone remain disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 14:22:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 13:22:33 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 --- Comment #6 from M. Tompsett --- Thank you for clarifying the problem, Katrin. That line. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 14:30:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 13:30:35 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #4 from Olli-Antti Kivilahti --- Merging ok! Maybe someone with TalkingTechItiva in use might be better suited to sign this task off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 14:38:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 13:38:30 +0000 Subject: [Koha-bugs] [Bug 11868] Multi transport types: disable sms and phone if not in use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11868 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25701|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25763&action=edit Bug 11868: MTT: disable sms and phone if not in use On both pages "Notices and slips" and "Overdue rules", it would be great to disable sms and phone if there are not in use. Test plan: 1/ Edit a notice 2/ Enable/disable the SMSSendDriver pref and verify the sms block is enabled/disabled. 3/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone block is enabled/disabled. 4/ Go on tools/overdues.pl 5/ Enable/disable the SMSSendDriver pref and verify the sms checkboxes are enabled/disabled. 6/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone checkboxes are enabled/disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 14:39:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 13:39:10 +0000 Subject: [Koha-bugs] [Bug 11868] Multi transport types: disable sms and phone if not in use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11868 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Jonathan Druart --- I forgot the [% USE Koha %]. It should be fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 14:44:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 13:44:17 +0000 Subject: [Koha-bugs] [Bug 11868] Multi transport types: disable sms and phone if not in use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11868 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25763|0 |1 is obsolete| | --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 25764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25764&action=edit Bug 11868: MTT: disable sms and phone if not in use On both pages "Notices and slips" and "Overdue rules", it would be great to disable sms and phone if there are not in use. Test plan: 1/ Edit a notice 2/ Enable/disable the SMSSendDriver pref and verify the sms block is enabled/disabled. 3/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone block is enabled/disabled. 4/ Go on tools/overdues.pl 5/ Enable/disable the SMSSendDriver pref and verify the sms checkboxes are enabled/disabled. 6/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone checkboxes are enabled/disabled. Signed-off-by: Olli-Antti Kivilahti --------------- Testing report: --------------- Followed the test plan. Reviewed the code modifications. Feature works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 14:44:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 13:44:36 +0000 Subject: [Koha-bugs] [Bug 11868] Multi transport types: disable sms and phone if not in use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11868 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 15:00:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 14:00:21 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23225|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 25765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25765&action=edit MT8122: Adds Shibboleth authentication - Use the shibbolethAuthentication syspref to enable Shibboleth authentication - Configure the shibbolethLoginAttribute to specify which shibboleth user attribute matches the koha login - Make sure the OPACBaseURL is correctly set MT8122, Follow-up: Adds Shibboleth authentication - Fix logout bug: shibboleth logout now occurs only when the session is a shibboleth one. - Do some refactoring: getting shibboleth username is now done in C4::Auth_with_Shibboleth.pm (get_login_shib function) MT8122, Follow-up: Adds Shibboleth authentication - Adds redirect to opac after logout MT8122, Follow-up: Adds Shibboleth authentication - Shibboleth is not compatible with basic http authentication in C4/Auth.pm. This patch fixes that. MT8122, Follow-up: Adds Shibboleth authentication - Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with multiple vhosts. MT8122, Follow-up: Adds Shibboleth authentication - Adds missing protocol for $ENV{'SERVER_NAME'} Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 15:00:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 14:00:28 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23226|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 25766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25766&action=edit BUG8446, Follow up: Adds Shibboleth authentication - Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont work if koha is behind a reverse proxy. - To use multiple vhosts, set OpacBaseURL per vhost explicitly with 'SetEnv OpacBaseURL Value' as per Bug 10325 BUG8446, Follow up: Adds Shibboleth authentication - Ensure user is returned to requested page after authentication - Added querystring to the target path in shibboleth URL so that when a user is authenticated he/she is returned to the correct page they requested before authentication. Example where this is important: When a user clicks a direct biblio link of the form - /opac-detail.pl?biblionumber=12345 BUG8446, Follow up: Remove unused imports from scripts - Remove import of deprecated C4::Utils module from shibboleth authentication module: Auth_with_shibboleth.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 15:03:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 14:03:14 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #22 from Martin Renvoize --- Rebased upon master and added a follow-up to remove unused imports from Auth_with_shibboleth.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 16:00:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 15:00:38 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #21 from Jonathan Druart --- Created attachment 25767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25767&action=edit Bug 11023: FIX - condition on biblioitems table does not work If a rule contains a condition on the biblioitems table, the match won't work. This patch fixes this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 16:40:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 15:40:25 +0000 Subject: [Koha-bugs] [Bug 11877] Eliminate use of deprecated jQuery .live() method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 --- Comment #3 from Jonathan Druart --- Comment on attachment 25744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25744 Bug 11877 - Eliminate use of deprecated jQuery .live() method Review of attachment 25744: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11877&attachment=25744) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt @@ +40,4 @@ > } > return valid; > }); > + $("body").on("click","#renewselected_link",function(){ IS there a reason to prefer this way instead of: $("#renewselected_link").on("click", function(){ ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 16:50:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 15:50:54 +0000 Subject: [Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22356|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen --- Created attachment 25768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25768&action=edit Bug 11130 Change pl Place-publication index for Marc21 According to ccl.properties, the pl Place-publication index is supposed to include 008/15-17 and 260$a. In record.abs, we have the index include all 260 fields. This patch removes the index for the whole field 260, leaving only $a (and 008/15-17). 11130 follow-up: DOM indexing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 16:53:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 15:53:41 +0000 Subject: [Koha-bugs] [Bug 10999] koha-restore --force option to just overwrite easily a Koha instance with an older backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10999 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |mirko at abunchofthings.net Resolution|--- |DUPLICATE --- Comment #1 from Mirko Tietgen --- *** This bug has been marked as a duplicate of bug 9754 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 16:53:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 15:53:41 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove does not remove the stuff in /var/lib/koha/ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi at gmail.com --- Comment #4 from Mirko Tietgen --- *** Bug 10999 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 16:55:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 15:55:36 +0000 Subject: [Koha-bugs] [Bug 11418] cannot delete a course In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11418 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 16:58:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 15:58:14 +0000 Subject: [Koha-bugs] [Bug 7234] koha-common Debian package should include koha-sites.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7234 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 17:10:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 16:10:30 +0000 Subject: [Koha-bugs] [Bug 11883] New: News Editor Changing Koha URLs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11883 Bug ID: 11883 Summary: News Editor Changing Koha URLs Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org I edited the HTML in a news item to link to a Koha page and the wysiwyg editor keeps changing it!!! (I tried in the visual interface and the HTML) I put in this URL: http://mykohasite.com/cgi-bin/koha/circ/circulation-home.pl and the editor changes it to: http://mykohasite.com/cgi-bin/circ/circulation-home.pl It takes out the /koha I tested on 3.12 and master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 17:13:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 16:13:49 +0000 Subject: [Koha-bugs] [Bug 6710] lists of lists in Alpha order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6710 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 18:57:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 17:57:10 +0000 Subject: [Koha-bugs] [Bug 11877] Eliminate use of deprecated jQuery .live() method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 --- Comment #4 from Owen Leonard --- > IS there a reason to prefer this way instead of: > $("#renewselected_link").on("click", function(){ ".click(function(){" is an shortcut for ".on("click",function(){", so most of the time the two are completely interchangeable. In this case we need to use ".on()" because we're attaching an event to an element which has not yet been created. The use of ".on()" quoted above means, "For all existing and future instances of '#renewselected_link' which are descendents of "body," attach this click handler." http://api.jquery.com/on/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 19:01:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 18:01:30 +0000 Subject: [Koha-bugs] [Bug 11884] New: SlipCSS should be CSS not a file Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11884 Bug ID: 11884 Summary: SlipCSS should be CSS not a file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com SlipCSS looks for a path to a file. It would be better if it was like the UserCSS fields for Intranet and OPAC so that the average user can just enter CSS in that field instead of needing access to a web server to upload their CSS file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 19:02:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 18:02:16 +0000 Subject: [Koha-bugs] [Bug 11884] SlipCSS and NoticeCSS should be CSS not a file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11884 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SlipCSS should be CSS not |SlipCSS and NoticeCSS |a file |should be CSS not a file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 19:02:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 18:02:22 +0000 Subject: [Koha-bugs] [Bug 11884] SlipCSS and NoticeCSS should be CSS not a file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11884 --- Comment #1 from Nicole C. Engard --- Same for NoticeCSS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 19:37:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 18:37:38 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #4 from Owen Leonard --- This sounds like the kind of change that could be better handled by using a custom XSL stylesheet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 19:48:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 18:48:26 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #5 from M. Tompsett --- You're probably right, Owen. Though, you'd have to keep re-patching, if the default templates shifted for security reasons. Which is probably why they want it in the default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 19:58:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 18:58:17 +0000 Subject: [Koha-bugs] [Bug 9517] Change slipcss syspref to be editable from interface like intranetusercss In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9517 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 11884 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 19:58:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 18:58:17 +0000 Subject: [Koha-bugs] [Bug 11884] SlipCSS and NoticeCSS should be CSS not a file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11884 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Katrin Fischer --- *** Bug 9517 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 20:03:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 19:03:22 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #6 from Katrin Fischer --- There are system preferences for defining your own custom XSLT paths to be used for OPAC and staff, so repatching won't be needed. Of course, you will have to add new features to your custom files or add your changes to a copy of the default again, but updates won't overwrite your changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 21:55:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 20:55:36 +0000 Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25762|0 |1 is obsolete| | --- Comment #21 from Chris Cormack --- Created attachment 25769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25769&action=edit Bug 9972 Add/ change some zebra indexes (MARC21) This patch adds :w and :p versions to the index for ?Lexile number? (it has only :n so far) and adds indexes for 653 (Index term uncontrolled), 655 (Index term Genre/Form), 041 (language-audio) and 041 (language-subtitle). It also adds the ?curriculum?-index to Search.pm. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 3 21:56:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Mar 2014 20:56:22 +0000 Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 08:20:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 07:20:09 +0000 Subject: [Koha-bugs] [Bug 11877] Eliminate use of deprecated jQuery .live() method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- I found a problem with step 2: How to repruduce: Click on "Change password" It displays the form "Change unsername and/or password for e.g. Edna Acosta Field "New username" is filled with usernumber (?): 23529001000463 (Would expect the user name here, not the number - but I think this is not related to this bug?) Then I click on "Click to fill with randoly generated password" Password fields are filled with new value, e.g. 'xcJ' (OK) Then I clear the password fields and click again for password suggestion Result: Password fields stay empty. (Would expect new suggstion.) Console says: "Kein Element gefunden (No element found)" file:///C:/Users/ApDAta/Roaming/Mozilla/Firefox/o1dv3kga.default/clipdat2.rdf I tested with Chrome as well, same behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 08:37:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 07:37:51 +0000 Subject: [Koha-bugs] [Bug 11885] New: Inconsistent HTML in MARC Details Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Bug ID: 11885 Summary: Inconsistent HTML in MARC Details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 25770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25770&action=edit Make MARC Details tab HTML consistent In Catalog > MARC Details, the HTML in the different tabs is slightly inconsistent and doesn't differentiate different elements, making CSS styling complicated or impossible: * tab 0 has

whereas all the other tabs have just

* all other tabs wrap the subfield character in tags, except for tab 0 * the MARC tag title is a single div with the tag, the indicators and the field description. Attached patch folds all the tab outputs into a single TT BLOCK, which is then reused. It also marks the separate parts of the tag title in their own spans. The output should be nearly identical to previous behaviour, minus a dash from the tag title descriptions - it was used to separate the tag from the description. The description can now be styled separately from the tag itself, so the dash can be added with CSS, if necessary. To test: 1) Look at some MARC details in the staff client, noting the contents of each tab. 2) Install patch 3) Compare the MARC details output to what was shown in step 1. Should be the same, minus a dash in each of the tag title descriptions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 08:45:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 07:45:48 +0000 Subject: [Koha-bugs] [Bug 11877] Eliminate use of deprecated jQuery .live() method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 --- Comment #6 from Marc V?ron --- Problem with step 2 exists without patch as well. Will sign off on this patch and file an other bug for step 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 08:46:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 07:46:54 +0000 Subject: [Koha-bugs] [Bug 11877] Eliminate use of deprecated jQuery .live() method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25744|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 25771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25771&action=edit Bug 11877 - Eliminate use of deprecated jQuery .live() method As of jQuery 1.9 the .live() method has been removed. A few templates contain JavaScript which uses it. It can be easily replaced with .on(). This patch makes the correction. To test, apply the patch and test the following pages: - In the staff client, Administration -> OAI sets configuration: Define mappings for an existing set. You should be able to add rows by clicking the "OR" button. You should be able to delete or clear any line by clicking the "Delete" link. - In the staff client, view the details for any patron and click the "Change password" button: In the change password form click the link to fill the password fields with a random password. This link should work correctly. - If necessary enable OpacRenewalAllowed in system preferences. Log in to the OPAC as a patron who has checkouts. On the patron summary page (opac-user.pl) look for the "renew selected" and "renew all" links at the top of the table of checkouts. Both these links should work correctly. Test in prog and bootstrap themes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 08:53:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 07:53:25 +0000 Subject: [Koha-bugs] [Bug 11877] Eliminate use of deprecated jQuery .live() method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 --- Comment #8 from Marc V?ron --- Created attachment 25772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25772&action=edit [Signed-off] Bug 11877 - Eliminate use of deprecated jQuery .live() method As of jQuery 1.9 the .live() method has been removed. A few templates contain JavaScript which uses it. It can be easily replaced with .on(). This patch makes the correction. To test, apply the patch and test the following pages: - In the staff client, Administration -> OAI sets configuration: Define mappings for an existing set. You should be able to add rows by clicking the "OR" button. You should be able to delete or clear any line by clicking the "Delete" link. - In the staff client, view the details for any patron and click the "Change password" button: In the change password form click the link to fill the password fields with a random password. This link should work correctly. - If necessary enable OpacRenewalAllowed in system preferences. Log in to the OPAC as a patron who has checkouts. On the patron summary page (opac-user.pl) look for the "renew selected" and "renew all" links at the top of the table of checkouts. Both these links should work correctly. Test in prog and bootstrap themes. Followed test plan. Same behaviour as without patch, i.e. patch OK Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 08:53:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 07:53:45 +0000 Subject: [Koha-bugs] [Bug 11877] Eliminate use of deprecated jQuery .live() method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25771|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 08:54:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 07:54:00 +0000 Subject: [Koha-bugs] [Bug 11877] Eliminate use of deprecated jQuery .live() method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 09:01:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 08:01:54 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 09:02:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 08:02:22 +0000 Subject: [Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 10:04:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 09:04:46 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #3 from Jacek Ablewicz --- Bug 10855 as a whole does not apply at the moment (may need a little rebase ?), so I tried to test this patch with Koha/AdditionalField.pm alone extracted from 10855. Found some problems: 1) if order line is deleted, additional fields for this order will stay in the database 2) in case order gets transferred to another basket, additional fields will remain associated with initial order record (now "cancelled" after the transfer); shouldn't they rather got re-associated with the newly created order record (the clone of the original) instead? 3) non-latin character encoding: similar issues as in 10855 (see also Bug 11302 - Template::output should deal with object). Regarding 3), I have working solution for bug 10855 (essentially, it's a more conservative take than Jonathan patch in 11302 - should be less regression-prone; still needs some testing), but it doesn't quite work for this particular patch. I guess it's because new sub GetValues() doesn't encode it's output, which introduces yet another (different kind of) encoding problem in cases where there are non-latin characters present e.g. in authorized values descriptions (?). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 11:54:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 10:54:21 +0000 Subject: [Koha-bugs] [Bug 11886] New: MARC Detail page shows ISBN label for non-book materials Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11886 Bug ID: 11886 Summary: MARC Detail page shows ISBN label for non-book materials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com MARC21slim2intranetDetail.xsl checks only for presence of field 020 when it decides whether to show the label "ISBN:", it really should check whether the 020a exists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 12:11:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 11:11:18 +0000 Subject: [Koha-bugs] [Bug 11531] Cannot add new libraries to the transport cost if previously used. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11531 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 12:11:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 11:11:22 +0000 Subject: [Koha-bugs] [Bug 11531] Cannot add new libraries to the transport cost if previously used. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11531 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24229|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 25773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25773&action=edit Bug 11531 - Cannot add new libraries to the transport cost if previously used. If you are using the transport cost matrix, and you create a new library, you cannot edit the fields for this library! Test Plan: 1) Enable the transport cost matrix 2) Set some transport cost values in the matrix 3) Save the matrix 4) Create a new library 5) View the transport cost matrix again 6) Note the uneditable fields for the new branch 7) Apply this patch 8) View the transport cost matrix again 9) Note you can now edit the fields for the new branch Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 12:21:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 11:21:08 +0000 Subject: [Koha-bugs] [Bug 11484] Add option to purge z39.50 search records from import table to cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 12:21:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 11:21:12 +0000 Subject: [Koha-bugs] [Bug 11484] Add option to purge z39.50 search records from import table to cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23978|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 25774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25774&action=edit Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl It would be good to be able to specifically target import records from z39.50 for cleanup. Test Plan: 1) Apply this patch 2) Import one or more batch record sets into Koha 3) Perform some z39.50 searches 4) Run this command: misc/cronjobs/cleanup_database.pl -v --z3950 5) Verify that only z39.50 records were deleted Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 12:31:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 11:31:41 +0000 Subject: [Koha-bugs] [Bug 5739] Check out waiting holds directly from "hold waiting" alerts on circulation screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 12:31:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 11:31:44 +0000 Subject: [Koha-bugs] [Bug 5739] Check out waiting holds directly from "hold waiting" alerts on circulation screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24535|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25775&action=edit Bug 5739 - Show the barcode of the waiting item on the circulation page To test: 1. place a hold for a borrower 2. mark the hold waiting for that borrower 3. view that borrower's circulation page 4. without the patch, no barcode will be displayed under "hold waiting for..." With it, the barcode will be linked to the item. Signed-off-by: Jonathan Druart Amended patch: fix qa issues (tabs and trailing spaces) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 14:23:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 13:23:30 +0000 Subject: [Koha-bugs] [Bug 11887] New: Add script for collections agency reports Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 Bug ID: 11887 Summary: Add script for collections agency reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries use collections agencies such as Unique Management Services to collection large unpaid balances owed to the library. It would be helpful if Koha had a standard script to generate these reports, rather than forcing each library to create their own solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 14:23:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 13:23:40 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 14:23:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 13:23:50 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 14:33:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 13:33:21 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 --- Comment #1 from Kyle M Hall --- Created attachment 25776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25776&action=edit Bug 11887 - Add script for collections agency reports Some libraries use collections agencies such as Unique Management Services to collection large unpaid balances owed to the library. It would be helpful if Koha had a standard script to generate these reports, rather than forcing each library to create their own solution. This script is written following the guidelines for Unique Management Systems. However, the reports it outputs should be useable by any collections agency. Test Plan: 1) Create the four required patron attributes 2) Create a patron who owes more then 5.00 in fees 3) Run the submission report account_collections.pl -r submission \ -mb 3 -bd $yesterday_iso -ed $tomorrow_iso -f 10 \ -ft $fee_type -fd $fee_desc -c $can-collect-attribute-code \ -i $in-collections-attribute-code -l $last-updated-attribute-code \ -p previous-balance-attribute-code 4) Note the patron is now marked as in collections and has had the collections fee of 10.00 applied 5) Add a new fee to the patron's account 6) Run the update report with the same additional parameters 7) Verify the csv file generated contains that patron 8) Run the sync report with the same additional parameters 9) Note the csv file generated contains that patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 14:33:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 13:33:19 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 14:34:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 13:34:15 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11887 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 14:34:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 13:34:15 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6427 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 14:46:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 13:46:04 +0000 Subject: [Koha-bugs] [Bug 11888] New: Random password suggestion does not work twice Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Bug ID: 11888 Summary: Random password suggestion does not work twice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To reproduce: Step 1: In the staff client, view the details for any patron and click the "Change password" button: In the change password form click Result: New password displays (OK) Step 2: Delete new passwords from fields. Click again link to fill the password fields again with a random password. Result: Nothing happens. Expected: New password suggestion in password fields. Console says: "Kein Element gefunden (No element found)" file:///C:/Users/ApDAta/Roaming/Mozilla/Firefox/o1dv3kga.default/clipdat2.rdf I tested with Chrome as well, same behaviour. Workaround: Choose new password manually or reload form and click link to fill the password fields with a random password. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:24:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:24:51 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24826|0 |1 is obsolete| | Attachment #24827|0 |1 is obsolete| | Attachment #24828|0 |1 is obsolete| | Attachment #24829|0 |1 is obsolete| | Attachment #24830|0 |1 is obsolete| | Attachment #24831|0 |1 is obsolete| | Attachment #24832|0 |1 is obsolete| | Attachment #24833|0 |1 is obsolete| | Attachment #24834|0 |1 is obsolete| | Attachment #24835|0 |1 is obsolete| | Attachment #24836|0 |1 is obsolete| | Attachment #24837|0 |1 is obsolete| | Attachment #24838|0 |1 is obsolete| | Attachment #24839|0 |1 is obsolete| | Attachment #24840|0 |1 is obsolete| | Attachment #24841|0 |1 is obsolete| | Attachment #24842|0 |1 is obsolete| | Attachment #24843|0 |1 is obsolete| | Attachment #24844|0 |1 is obsolete| | --- Comment #220 from Kyle M Hall --- Created attachment 25777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25777&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:25:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:25:10 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #221 from Kyle M Hall --- Created attachment 25778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25778&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:25:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:25:16 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #222 from Kyle M Hall --- Created attachment 25779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25779&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:25:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:25:21 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #223 from Kyle M Hall --- Created attachment 25780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25780&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:25:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:25:26 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #224 from Kyle M Hall --- Created attachment 25781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25781&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:25:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:25:31 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #225 from Kyle M Hall --- Created attachment 25782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25782&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:25:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:25:36 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #226 from Kyle M Hall --- Created attachment 25783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25783&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:25:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:25:41 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #227 from Kyle M Hall --- Created attachment 25784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25784&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:25:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:25:46 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #228 from Kyle M Hall --- Created attachment 25785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25785&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:25:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:25:52 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #229 from Kyle M Hall --- Created attachment 25786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25786&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:25:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:25:58 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #230 from Kyle M Hall --- Created attachment 25787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25787&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:26:04 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #231 from Kyle M Hall --- Created attachment 25788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25788&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:26:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:26:09 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #232 from Kyle M Hall --- Created attachment 25789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25789&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:26:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:26:14 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #233 from Kyle M Hall --- Created attachment 25790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25790&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:26:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:26:22 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #234 from Kyle M Hall --- Created attachment 25791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25791&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:26:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:26:27 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #235 from Kyle M Hall --- Created attachment 25792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25792&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:26:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:26:32 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #236 from Kyle M Hall --- Created attachment 25793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25793&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:26:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:26:39 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #237 from Kyle M Hall --- Created attachment 25794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25794&action=edit Bug 6427 [Part 18] - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:26:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:26:45 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #238 from Kyle M Hall --- Created attachment 25795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25795&action=edit Bug 6427 [Part 19] - Add full debit and credit table Print and Download features -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:56:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:56:47 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25777|0 |1 is obsolete| | --- Comment #239 from Kyle M Hall --- Created attachment 25796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25796&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:57:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:57:07 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25778|0 |1 is obsolete| | --- Comment #240 from Kyle M Hall --- Created attachment 25797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25797&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:57:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:57:27 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25779|0 |1 is obsolete| | Attachment #25780|0 |1 is obsolete| | Attachment #25781|0 |1 is obsolete| | Attachment #25782|0 |1 is obsolete| | Attachment #25783|0 |1 is obsolete| | Attachment #25784|0 |1 is obsolete| | Attachment #25785|0 |1 is obsolete| | Attachment #25786|0 |1 is obsolete| | Attachment #25787|0 |1 is obsolete| | Attachment #25788|0 |1 is obsolete| | Attachment #25789|0 |1 is obsolete| | Attachment #25790|0 |1 is obsolete| | Attachment #25791|0 |1 is obsolete| | Attachment #25792|0 |1 is obsolete| | Attachment #25793|0 |1 is obsolete| | Attachment #25794|0 |1 is obsolete| | Attachment #25795|0 |1 is obsolete| | Attachment #25796|0 |1 is obsolete| | Attachment #25797|0 |1 is obsolete| | --- Comment #241 from Kyle M Hall --- Created attachment 25798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25798&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:57:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:57:40 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #242 from Kyle M Hall --- Created attachment 25799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25799&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:57:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:57:46 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #243 from Kyle M Hall --- Created attachment 25800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25800&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:57:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:57:51 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #244 from Kyle M Hall --- Created attachment 25801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25801&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:57:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:57:58 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #245 from Kyle M Hall --- Created attachment 25802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25802&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:58:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:58:06 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #246 from Kyle M Hall --- Created attachment 25803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25803&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:58:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:58:12 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #247 from Kyle M Hall --- Created attachment 25804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25804&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:58:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:58:18 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #248 from Kyle M Hall --- Created attachment 25805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25805&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:58:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:58:24 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #249 from Kyle M Hall --- Created attachment 25806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25806&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:58:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:58:30 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #250 from Kyle M Hall --- Created attachment 25807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25807&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:58:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:58:36 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #251 from Kyle M Hall --- Created attachment 25808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25808&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:58:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:58:42 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #252 from Kyle M Hall --- Created attachment 25809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25809&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:58:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:58:47 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #253 from Kyle M Hall --- Created attachment 25810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25810&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:58:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:58:53 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #254 from Kyle M Hall --- Created attachment 25811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25811&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:58:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:58:59 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #255 from Kyle M Hall --- Created attachment 25812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25812&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:59:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:59:12 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #256 from Kyle M Hall --- Created attachment 25813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25813&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:59:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:59:18 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #257 from Kyle M Hall --- Created attachment 25814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25814&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:59:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:59:25 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #258 from Kyle M Hall --- Created attachment 25815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25815&action=edit Bug 6427 [Part 18] - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 15:59:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 14:59:31 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #259 from Kyle M Hall --- Created attachment 25816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25816&action=edit Bug 6427 [Part 19] - Add full debit and credit table Print and Download features -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:00:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:00:00 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20033|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:00:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:00:11 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20034|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:00:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:00:14 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20038|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:01:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:01:10 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19377|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:01:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:01:12 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19378|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:01:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:01:15 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19934|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:01:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:01:17 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19935|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:08:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:08:12 +0000 Subject: [Koha-bugs] [Bug 11889] New: Disown a list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Bug ID: 11889 Summary: Disown a list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:09:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:09:45 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #260 from Kyle M Hall --- Thanks for letting me know! I've rolled the fixes for these 2 issues into the main patch set since they are still not signed off, rather than post a qa followup. (In reply to Rafal Kopaczka from comment #219) > I've looked quickly at this patch, got 2 issues (or not, correct me if I'm > wrong): > > 1/ In part 4 patch, there is reference to js file that don't exist in > repository, next parts also don't contain this file. > Bug-6427-Part-04.patch:93:+ > > 2/ In part 3, function format_without_symbol don't handle properly, national > currencies without leading symbol (eg PLN). It truncate always first > character even if it's a number. > return substr( $self->format( $amount, FMT_SYMBOL ), 1 ); > We can't assume that format always return symbol before number. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:12:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:12:42 +0000 Subject: [Koha-bugs] [Bug 11890] New: Control-Click/Command-Click to open a link in a new tab not consistently working Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Bug ID: 11890 Summary: Control-Click/Command-Click to open a link in a new tab not consistently working Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: ed.veal at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Control-Click (PC) or Command-Click normally opens any link in a web browser into a new tab. After the 3.14 upgrade, we have discovered inconsistency in links not always having this behavior anymore on search.pl and detail.pl. This has been replicated on Master as well. On search.pl, control-clicking or command-clicking on the title links opens the link in the same window. You have to actually right-click on the link and tell the browser to open the link in a new tab. The linked author field in the search results, the call numbers, the facets on the left-hand side of the screen, the links at the top -- all will open in a new tab with the control-click or command-click option. On detail.pl, if the back to search results/next record/previous record links are present, control-clicking or command-clicking the normal/MARC/ISBD/Items/Holds/Checkout History/Barcode links open the information on the same screen. If you switch to one of the other tabs, the back to search results link is gone, and this keyboard shortcut works again. I do not see this same behavior in the OPAC. Disabling all javascript causes it to return to normal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:15:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:15:14 +0000 Subject: [Koha-bugs] [Bug 4397] display problems (umlauts, =?UTF-8?Q?=20=C3=9F?=) with scan index in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 --- Comment #4 from Marc V?ron --- Created attachment 25817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25817&action=edit [Signed-off] Bug 4397: Scan index search results broken for non-latin characters The Zoom specification defines that a ScanSet should provide a way to retrieve terms suitable for displaying and another one for using on further searches [1]. The Net::Z3950::ZOOM implementation actually provides both [2] but we where using the wrong one. Using $scanset->display_term(...) instead of $scanset->term(...) fixes the problem. To test: - Do a index scan search (advanced search > more options > check 'index scan') - Notice non-latin characters are replaced by one or more '@' symbols. - Apply the patch - Re-do the search, everything shows as it should. - Try to follow any of the terms (clicking on them) and notice that it actually gives you relevant results (i.e. is not searching for @!!!!). - Sign off :-D Regards To+ [1] http://zoom.z3950.org/api/zoom-1.4.html#3.6.3 [2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#term()_/_display_term() Sponsored-by: Universidad Nacional de Cordoba Followed test plan. Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:15:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:15:47 +0000 Subject: [Koha-bugs] [Bug 4397] display problems (umlauts, =?UTF-8?Q?=20=C3=9F?=) with scan index in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25742|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:16:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:16:00 +0000 Subject: [Koha-bugs] [Bug 4397] display problems (umlauts, =?UTF-8?Q?=20=C3=9F?=) with scan index in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:19:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:19:19 +0000 Subject: [Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Jonathan Druart --- Switch back to Signed off, I need help from QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:31:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:31:51 +0000 Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:31:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:31:55 +0000 Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22349|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 25818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25818&action=edit Bug 11127: OPAC suggestion: the delete link is active when no suggestion selected To reproduce: 1/ go on opac-suggestions.pl 2/ create a suggestion 3/ click on the delete link without checking any checkbox The form is submitted with a message "The selected suggestions have been deleted.". Test plan: 0/ enable the bootstrap theme 1/ after applying the patch, click on delete without any checkbox checked, a js alert should occur. 2/ check at least a cb and click on the delete link. The deletion should work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:32:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:32:13 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #2 from Marc V?ron --- Created attachment 25819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25819&action=edit [Signed-off] Add a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. http://bugs.koha-community.org/show_bug.cgi?id=11882 This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * You should be redirected to the "Check in" page, where a dialog will give you more informations on the hold, and let you print a reservation slip. Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:32:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:32:51 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25748|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:33:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:33:31 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 16:50:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 15:50:35 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- Wanted to test, patch does not apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:03:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:03:10 +0000 Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for items "Waiting" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774 --- Comment #10 from Heather Braum --- In 3.14 this issue is no longer present. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:13:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:13:30 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 --- Comment #1 from Marc V?ron --- Created attachment 25820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25820&action=edit [Signed-off] Select the barcode index by default then searching for label items. http://bugs.koha-community.org/show_bug.cgi?id=11880 Test case: * Go to "Tools -> Label creator -> Manage batches" * Click on the "New batch" button * Click on the "Add item(s)" button * A search window should open. The "Barcode" value should be selected in the the selectbox. Followed test case. Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:13:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:13:55 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25746|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:14:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:14:05 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:20:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:20:43 +0000 Subject: [Koha-bugs] [Bug 11854] Syspref BorrowerMandatoryField is being ignored post-upgrade to 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11854 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org --- Comment #3 from Heather Braum --- It was an old patron category with a space in the code that caused this issue in the end. The category was deleted and the issue is now fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:21:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:21:37 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Wanted to test. Patch does not apply. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:23:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:23:23 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:23:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:23:28 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18868|0 |1 is obsolete| | Attachment #18869|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 25821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25821&action=edit Bug 9366: On cataloguing each user can easily display tags or not If the syspref hide_marc is set to "don't display", tags are not shown by default. This patch adds a checkbox to hide/show tags directly on the cataloguing page. The value is stored in a cookie. Test plan: Enable/disable the sysprefs hide_marc and advancedMARCeditor in order to check if the display is according with what the user want. Reload the page and verify the value is kept. The first value of the cookie is retrieved from the hide_marc pref. Bonus: This patch removes the link "Show MARCtag documentation links" if the syspref advancedMARCeditor is enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:25:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:25:56 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #30 from Jonathan Druart --- (In reply to Katrin Fischer from comment #28) > Some comments on this: I took all your comments into account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:26:04 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |fcapovilla at live.ca |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:27:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:27:57 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #11 from Kyle M Hall --- (In reply to Katrin Fischer from comment #10) > Hi Kyle, could you please add the pref? Failing for now so it shows up in > your queue :) This already has a system preference, AllowRenewalIfOtherItemsAvailable! Is there something else that needs to be taken care of? Also, since this is being consider bug-ish, I think maybe we should enable the feature by default. I'll post a followup for that. If you don't think that's a good idea you can just deprecate the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:29:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:29:11 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:29:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:29:14 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #12 from Kyle M Hall --- Created attachment 25822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25822&action=edit Bug 11634 [QA Followup] - Enable by default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:37:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:37:30 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #13 from Galen Charlton --- (In reply to Kyle M Hall from comment #11) > (In reply to Katrin Fischer from comment #10) > > Hi Kyle, could you please add the pref? Failing for now so it shows up in > > your queue :) > > This already has a system preference, AllowRenewalIfOtherItemsAvailable! Is > there something else that needs to be taken care of? AllowRenewalIfOtherItemsAvailable is the minimum, IMO, as I would prefer it as a per-library setting, but as a YASP, it suffices for now. > Also, since this is being consider bug-ish, I think maybe we should enable > the feature by default. I'll post a followup for that. If you don't think > that's a good idea you can just deprecate the patch. I think we've just exposed a difference in library practices, because I know of libraries that absolutely do not want renewals to be allowed if there are pending requests, and who would very much consider it a bug if they were suddenly allowed following an upgrade. Consequently, I will /not/ be pushing the follow-up as it stands now, as it changes existing behavior upon upgrade. I am neutral on the question of the default value for this one for new installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:42:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:42:24 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25822|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:43:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:43:13 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #14 from Kyle M Hall --- (In reply to Galen Charlton from comment #13) Thanks for the comments! I've depped my followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:44:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:44:04 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Galen Charlton --- Setting to failed QA, nonetheless; such a change to the holds API needs unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:53:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:53:18 +0000 Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #9 from Marc V?ron --- Created attachment 25823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25823&action=edit [Signed-off] Bug 11127: OPAC suggestion: the delete link is active when no suggestion selected To reproduce: 1/ go on opac-suggestions.pl 2/ create a suggestion 3/ click on the delete link without checking any checkbox The form is submitted with a message "The selected suggestions have been deleted.". Test plan: 0/ enable the bootstrap theme 1/ after applying the patch, click on delete without any checkbox checked, a js alert should occur. 2/ check at least a cb and click on the delete link. The deletion should work. Followed test plan. Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:53:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:53:39 +0000 Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25818|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 17:53:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 16:53:58 +0000 Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 18:20:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 17:20:53 +0000 Subject: [Koha-bugs] [Bug 11878] Eliminate use of deprecated jQuery .toggle() method usage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 18:20:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 17:20:55 +0000 Subject: [Koha-bugs] [Bug 11878] Eliminate use of deprecated jQuery .toggle() method usage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 --- Comment #1 from Owen Leonard --- Created attachment 25824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25824&action=edit Bug 11878 - Eliminate use of deprecated jQuery .toggle() method usage jQuery's .toggle() method can no longer be used to trigger a pair of specified functions. .toggle() can only be used to change the visibility of an element. This patch fixes a few places in Koha where the deprecated functionality was used. To test, apply the patch and clear your browser cache. - View the system preferences page in the staff client. Clicking a heading ("Appearance" under OPAC preferences, for instance) should collapse that section. Clicking again should expand it. - View the MARC detail page for a record in the OPAC. Clicking the "view plain" link should display the plain MARC view. Clicking the "view labeled" view should return to the original view. Test in both prog and bootstrap themes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 18:47:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 17:47:56 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matted-34813 at mypacks.net --- Comment #44 from wajasu --- I got it to work by changing the command definition in tools/scheduler.pl my $command = "export KOHA_CONF=\"$CONFIG_NAME\"; export PERL5LIB=" . $base . "; " . $base . "/misc/cronjobs/runreport.pl "; $command = $command . "--format=$format " if $format; $command = $command . "--to='$email' " if $email; $command = $command . $report if $report; AND also added www-data, which was defined in /etc/apache2/envvars (APACHE_RUN_USER) to the /etc/at.allow and no more permission problem I had created an sql report, and did not test email, though without email the report output was seen in the mail box for the www-data user. (su - www-data and then 'mail' and p for print. ) I am just documenting my cursory findings. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 18:59:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 17:59:22 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #16 from Kyle M Hall --- Created attachment 25825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25825&action=edit Bug 11634 [QA Followup] - Unit Tests These new unit tests will fail due to the fact that Koha::Database uses a separate dbh handle than C4::Context->dbh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 19:27:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 18:27:11 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #17 from Kyle M Hall --- Created attachment 25826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25826&action=edit Make Koha::Database use C4::Context->dbh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 19:28:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 18:28:28 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25826|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 25827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25827&action=edit Make Koha::Database use C4::Context->dbh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 19:32:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 18:32:27 +0000 Subject: [Koha-bugs] [Bug 11891] New: Make Koha::Schema use C4::Context->dbh Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11891 Bug ID: 11891 Summary: Make Koha::Schema use C4::Context->dbh Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Right now there is no connection between the database handles used by C4::Context::dbh and Koha::Datbase/Schema. This makes it impossible to use transactions in unit tests to temporarily modify the database to test subroutines that take advantage of Koha::Database. This patch fixes that issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 19:32:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 18:32:32 +0000 Subject: [Koha-bugs] [Bug 11891] Make Koha::Schema use C4::Context->dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11891 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 19:34:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 18:34:15 +0000 Subject: [Koha-bugs] [Bug 11891] Make Koha::Schema use C4::Context->dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11891 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 19:34:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 18:34:18 +0000 Subject: [Koha-bugs] [Bug 11891] Make Koha::Schema use C4::Context->dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11891 --- Comment #1 from Kyle M Hall --- Created attachment 25828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25828&action=edit Bug 11891 - Make Koha::Schema use C4::Context->dbh Right now there is no connection between the database handles used by C4::Context::dbh and Koha::Datbase/Schema. This makes it impossible to use transactions in unit tests to temporarily modify the database to test subroutines that take advantage of Koha::Database. This patch fixes that issue. Test Plan: 1) Apply the patch for bug 11634 2) prove t/db_dependent/Circulation.t should fail 3) Apply this patch 4) prove t/db_dependent/Circulation.t should not fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 19:35:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 18:35:49 +0000 Subject: [Koha-bugs] [Bug 11891] Make Koha::Schema use C4::Context->dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11891 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25828|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 25829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25829&action=edit Bug 11891 - Make Koha::Schema use C4::Context->dbh Right now there is no connection between the database handles used by C4::Context::dbh and Koha::Datbase/Schema. This makes it impossible to use transactions in unit tests to temporarily modify the database to test subroutines that take advantage of Koha::Database. This patch fixes that issue. Test Plan: 1) Apply the patch for bug 11634 2) prove t/db_dependent/Circulation.t should fail 3) Apply this patch 4) prove t/db_dependent/Circulation.t should not fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 19:36:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 18:36:52 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25827|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 19:37:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 18:37:03 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Depends on| |11891 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 19:37:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 18:37:03 +0000 Subject: [Koha-bugs] [Bug 11891] Make Koha::Schema use C4::Context->dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11891 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11634 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 19:38:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 18:38:39 +0000 Subject: [Koha-bugs] [Bug 11891] Make Koha::Schema use C4::Context->dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11891 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |gmcharlt at gmail.com --- Comment #3 from Galen Charlton --- I'm immediately putting this into discussion, as I'm exploring the reverse: letting DBIC manage the storage handlers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 19:40:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 18:40:22 +0000 Subject: [Koha-bugs] [Bug 11872] Lost overdue items should not generate fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25720|0 |1 is obsolete| | CC| |matted-34813 at mypacks.net --- Comment #3 from wajasu --- Created attachment 25830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25830&action=edit [SIGNED-OFF] Bug 11872 - Lost overdue items should not generate fines 1-Checked out item backdated 5 months. 2-Ran longoverdue.pl --lost 90=2 --confirm to get the itemlost flag set. 3-Ran fines.pl -v to get fines accrued. (So at this point in UI I saw $146 FU fine, and $5.00 Rental.) 4-Payed fines and checked in item. 5-Applied patch. 6 Did steps 1-3 At this point only saw $5.00 Rental, but no accrued fines. Correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 19:40:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 18:40:41 +0000 Subject: [Koha-bugs] [Bug 11872] Lost overdue items should not generate fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 20:04:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 19:04:10 +0000 Subject: [Koha-bugs] [Bug 11878] Eliminate use of deprecated jQuery .toggle() method usage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25824|0 |1 is obsolete| | CC| |matted-34813 at mypacks.net --- Comment #2 from wajasu --- Created attachment 25831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25831&action=edit [SIGNED-OFF] Bug 11878 - Eliminate use of deprecated jQuery .toggle() method usage Performed test plan. Worked fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 20:07:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 19:07:51 +0000 Subject: [Koha-bugs] [Bug 11878] Eliminate use of deprecated jQuery .toggle() method usage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 --- Comment #3 from wajasu --- Did a qucik search to see if other .toggle usage was present, and got these results, so if they don't need to be addressed, we could change the status to signed off, otherwise things will wait for further followup patches. It may depend on the jquery update only needing to be done for OPAC. 12:45:28 {bug11878 %} ~/prj/kohaclone$ find . -name "*.js" -exec grep -Hn ".toggle()" {} \; Some places where toggle is in our source tree after the 1st patch applied: ./koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/js/bootstrap.js:1814: this.options.toggle && this.toggle() ./koha-tmpl/opac-tmpl/bootstrap/js/script.js:54: $(".menu-collapse").toggle(); ./koha-tmpl/intranet-tmpl/prog/en/js/pages/batchMod.js:15: $("#itemst td:nth-child("+valCookie[i]+"),#itemst th:nth-child("+valCookie[i]+")").toggle(); ./koha-tmpl/intranet-tmpl/prog/en/js/pages/batchMod.js:29: $("#itemst td:nth-child("+hide+"),#itemst th:nth-child("+hide+")").toggle(); ./koha-tmpl/intranet-tmpl/prog/en/js/pages/batchMod.js:65: $("#itemst td:nth-child("+show+"),#itemst th:nth-child("+show+")").toggle(); ./koha-tmpl/intranet-tmpl/prog/en/js/acq.js:863: $("#plan td:nth-child("+hide+"),#plan th:nth-child("+hide+")").toggle(); ./koha-tmpl/intranet-tmpl/prog/en/js/acq.js:872: $("#plan td:nth-child("+show+"),#plan th:nth-child("+show+")").toggle(); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 20:12:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 19:12:47 +0000 Subject: [Koha-bugs] [Bug 11878] Eliminate use of deprecated jQuery .toggle() method usage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 --- Comment #4 from Owen Leonard --- (In reply to wajasu from comment #3) > Did a qucik search to see if other .toggle usage was present, and got these > results, so if they don't need to be addressed, we could change the status ... > ./koha-tmpl/intranet-tmpl/prog/en/js/acq.js:872: $("#plan > td:nth-child("+show+"),#plan th:nth-child("+show+")").toggle(); No, these do not need to be addressed: '.toggle(function, function, ... ) removed: This is the "click an element to run the specified functions" signature of .toggle(). It should not be confused with the "change the visibility of an element" of .toggle() which is not deprecated.' My patch fixes all the instances which I know to be problematic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 20:51:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 19:51:08 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #19 from Galen Charlton --- Comment on attachment 25148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25148 Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds Review of attachment 25148: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11634&attachment=25148) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +2516,5 @@ > + # Get all other reserves that could have been filled by this item > + my @borrowernumbers; > + while (1) { > + my ( $reserve_found, $reserve, undef ) = > + C4::Reserves::CheckReserves( $itemnumber, undef, undef, I'm not convinced that CheckReserves() is a sufficient test -- IsAvailableForItemLevelRequest() may need to be checked as well. Otherwise, damaged, lost, and withdrawn items could "count" as available for filling the hold when that is not actually the case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 22:03:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 21:03:39 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 22:16:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 21:16:23 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 4 23:53:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 22:53:26 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 --- Comment #6 from Liz Rea --- Owen, No, I looked in master and that jquery file is there in the css for bootstrap, but not in the less, and it's called jquery.css. If it's not supposed to be there, I'll happily remove it. However, the newest attached patch left it alone. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 00:04:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 23:04:25 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 00:04:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Mar 2014 23:04:29 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25040|0 |1 is obsolete| | --- Comment #7 from Liz Rea --- Created attachment 25832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25832&action=edit Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 10:11:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 09:11:33 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Bot Control|--- |Ignore this bug --- Comment #10 from Jonathan Druart --- This patch applies cleanly on top of bug 7180. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 10:17:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 09:17:41 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Jonathan Druart --- Back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 10:44:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 09:44:27 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 --- Comment #8 from Marc V?ron --- To test: Verify the bootstrap theme still works as it should. -- MV: OK In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory -- MV:OK verify that all CSS files have been minified --MV: Not minified files found in koha-tmpl/opac-tmpl/bootstrap/css datatable.css opac.css opac-old.css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 11:09:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 10:09:16 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 11:09:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 10:09:20 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #22 from Jonathan Druart --- Created attachment 25833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25833&action=edit Bug 11023: Use DBIx-Class to retrieve column names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 11:10:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 10:10:35 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #23 from Jonathan Druart --- (In reply to Kyle M Hall from comment #18) > QA Issue: biblioitems_columns doesn't seem like it belongs in Items.pm, you > could easily use DBIx::Class to get the columns names: > http://search.cpan.org/~frew/DBIx-Class-0.08121/lib/DBIx/Class/ResultSource. > pm#columns > so no need for a special subroutine! Done in the last patch. I kept the subroutines because I use the column names in 2 different places. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 11:34:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 10:34:02 +0000 Subject: [Koha-bugs] [Bug 11404] add out-of-the-box support for Apache 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404 --- Comment #9 from Benjamin Rokseth --- Dear Tom?s, Sorry for the late reply! all I can say is there seems still to be dependency issues and mpm_event gives the following errors: vagrant at vagrant-saucy64:~$ sudo a2enmod mpm_event Considering conflict mpm_worker for mpm_event: Considering conflict mpm_prefork for mpm_event: Considering conflict mpm_itk for mpm_event: Enabling module mpm_event. which disables the 'AssignUserID' variable and fails apache: AH00526: Syntax error on line 13 of /etc/apache2/sites-enabled/knakk.conf: Invalid command 'AssignUserID', perhaps misspelled or defined by a module not included in the server configuration Action 'configtest' failed. swapping the mpm_event module with mpm_itk makes everything work: http://mpm-itk.sesse.net/ Hope you find a more robust solution! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 11:39:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 10:39:57 +0000 Subject: [Koha-bugs] [Bug 10319] C4::SocialData is badly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- The C4::SocialData module is not specific to Babeltheque. The only specific script is misc/cronjobs/social_data/update_social_data.pl I developed the SocialData module in order it may used by another content vendor. The only thing to do is to call update_data with a csv file containing different values (number of critic, number of videos, etc.). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 11:40:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 10:40:14 +0000 Subject: [Koha-bugs] [Bug 11892] New: Add controls on overdue notices configuration Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11892 Bug ID: 11892 Summary: Add controls on overdue notices configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In overdue notices configuration : cgi-bin/koha/tools/overduerules.pl. When a rule is set without notice, the line can have delay empty or letter on "No notice". It would be more clear to add a control that forces to set both delay empty and letter on "No notice" to disable a rule. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 11:41:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 10:41:43 +0000 Subject: [Koha-bugs] [Bug 4530] Circulation & fines rules aren't always applied from most specific to less specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 12:10:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 11:10:56 +0000 Subject: [Koha-bugs] [Bug 11755] Argument 'booksellerid' not properly handled in orderreceive.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 12:10:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 11:10:59 +0000 Subject: [Koha-bugs] [Bug 11755] Argument 'booksellerid' not properly handled in orderreceive.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 --- Comment #1 from Jonathan Druart --- Created attachment 25834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25834&action=edit Bug 11755: SearchOrders does not return booksellerid The SearchOrders routine should return the booksellerid. Booksellerid was returned before bug 10723. Quick test plan: Go on orderreceive.pl and verify that the vendor link is correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 12:11:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 11:11:18 +0000 Subject: [Koha-bugs] [Bug 11755] Argument 'booksellerid' not properly handled in orderreceive.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 12:49:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 11:49:22 +0000 Subject: [Koha-bugs] [Bug 11891] Make Koha::Schema use C4::Context->dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11891 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from M. de Rooy --- (In reply to Galen Charlton from comment #3) > I'm immediately putting this into discussion, as I'm exploring the reverse: > letting DBIC manage the storage handlers. I would think too that we should move in the direction from C4 to Koha instead of the other way around. Let C4::Context ask a handle from the DBIC based classes during the transition phase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:07:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:07:43 +0000 Subject: [Koha-bugs] [Bug 11891] Make Koha::Schema use C4::Context->dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11891 --- Comment #5 from Kyle M Hall --- I also agree that is a more sensible long term approach than this one. (In reply to M. de Rooy from comment #4) > (In reply to Galen Charlton from comment #3) > > I'm immediately putting this into discussion, as I'm exploring the reverse: > > letting DBIC manage the storage handlers. > > I would think too that we should move in the direction from C4 to Koha > instead of the other way around. Let C4::Context ask a handle from the DBIC > based classes during the transition phase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:31:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:31:52 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:31:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:31:56 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #2 from Jonathan Druart --- Created attachment 25835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25835&action=edit Bug 11699: Notes entered when receiving are not saved Test plan: 1/ Create an order with 2 items 2/ Receive 1 item and enter a note for the order 3/ Verify the note is correctly saved 4/ Receive the second item and enter a note for the order 5/ Verify the note is correctly saved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:32:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:32:02 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #3 from Jonathan Druart --- Created attachment 25836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25836&action=edit Bug 11699: ModReceiveOrder should take a hashref in parameter Test plan: prove t/db_dependent/Acquisition.t prove t/db_dependent/Acquisition/Invoices.t prove t/db_dependent/Acquisition/OrderFromSubscription.t all should return green. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:32:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:32:14 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #20 from Kyle M Hall --- Created attachment 25837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25837&action=edit Bug 11634 [QA Followup 2] - Implement check for IsAvailableForItemLevelRequest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:32:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:32:36 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Version|3.12 |master Severity|critical |major --- Comment #4 from Jonathan Druart --- Not sure this is critical. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:32:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:32:40 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:34:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:34:38 +0000 Subject: [Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10363 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:34:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:34:38 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9967 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:48:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:48:22 +0000 Subject: [Koha-bugs] [Bug 11493] Batch Item Modification not handling unicode characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11493 --- Comment #1 from Jonathan Druart --- Created attachment 25838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25838&action=edit Bug 11493: Revert "Bug 6869 Batch item modification fails whit accented characters" This reverts commit c9905750e53e2e1615842ac696d5eeb0a8ac07fc. Test plan: 1/ Open a bib record with more than 1 item , 2/ Select all items 3/ Chose Modify selected items 4/ put you "? ? ?" in notes 5/ Verify the items have been updated correctly 6/ put you "???" in notes 7/ Verify the items have been updated correctly 8/ put you "? ? ? ???" in notes 9/ Verify the items have been updated correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:49:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:49:15 +0000 Subject: [Koha-bugs] [Bug 11493] Batch Item Modification not handling unicode characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11493 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart at biblibre.co | |m Version|3.14 |master See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6869 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:49:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:49:15 +0000 Subject: [Koha-bugs] [Bug 6869] Batch item modification fails if accented characters are used in the modification form. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6869 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11493 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:50:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:50:02 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:50:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:50:06 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #13 from Kyle M Hall --- Created attachment 25839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25839&action=edit Bug 11625 [QA Followup 2] - Don't default to branch specific rules if only one branch exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:51:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:51:20 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25839|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 25840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25840&action=edit Bug 11625 [QA Followup 2] - Don't default to branch specific rules if only one branch exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:53:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:53:28 +0000 Subject: [Koha-bugs] [Bug 9046] Items are not exported with the tools/export.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #19 from Jonathan Druart --- ping Kyle, it seems the next action if for you :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:54:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:54:11 +0000 Subject: [Koha-bugs] [Bug 11878] Eliminate use of deprecated jQuery .toggle() method usage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 --- Comment #5 from Marc V?ron --- Created attachment 25841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25841&action=edit [Signed-off] Bug 11878 - Eliminate use of deprecated jQuery .toggle() method usage jQuery's .toggle() method can no longer be used to trigger a pair of specified functions. .toggle() can only be used to change the visibility of an element. This patch fixes a few places in Koha where the deprecated functionality was used. To test, apply the patch and clear your browser cache. - View the system preferences page in the staff client. Clicking a heading ("Appearance" under OPAC preferences, for instance) should collapse that section. Clicking again should expand it. - View the MARC detail page for a record in the OPAC. Clicking the "view plain" link should display the plain MARC view. Clicking the "view labeled" view should return to the original view. Test in both prog and bootstrap themes. Signed-off-by: wajasu Followed test plan. Works fine. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:54:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:54:40 +0000 Subject: [Koha-bugs] [Bug 11878] Eliminate use of deprecated jQuery .toggle() method usage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25831|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:54:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:54:53 +0000 Subject: [Koha-bugs] [Bug 11878] Eliminate use of deprecated jQuery .toggle() method usage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:56:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:56:25 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 13:56:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 12:56:28 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 --- Comment #6 from Kyle M Hall --- Created attachment 25842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25842&action=edit Bug 11747 [QA Followup] - Don't default to branch specific rules if only one branch exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 14:24:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 13:24:36 +0000 Subject: [Koha-bugs] [Bug 11366] Acq basket group "No group" untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Severity|enhancement |minor --- Comment #2 from Fridolin SOMERS --- I set this as bug minor. I have a patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 14:38:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 13:38:31 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25515|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 25843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25843&action=edit Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. Edit: Rebased on current master. Note that the change to opac-auth-detail.tt is because the page never has more than one tab, hence doesn't need the "active" designation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 14:39:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 13:39:53 +0000 Subject: [Koha-bugs] [Bug 11893] New: Get rid of warning from IsSuperLibrarian Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11893 Bug ID: 11893 Summary: Get rid of warning from IsSuperLibrarian Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Add a new patron. Do not set permissions yet. You will see lots of warnings like: Use of uninitialized value in modulus (%) at /usr/share/koha/testclone/C4/Context.pm line 1254. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 14:44:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 13:44:55 +0000 Subject: [Koha-bugs] [Bug 11893] Get rid of warning from IsSuperLibrarian In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11893 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 14:44:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 13:44:57 +0000 Subject: [Koha-bugs] [Bug 11893] Get rid of warning from IsSuperLibrarian In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11893 --- Comment #1 from M. de Rooy --- Created attachment 25844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25844&action=edit Bug 11893: Get rid of warning from IsSuperLibrarian Test plan: [1] Do not yet apply this patch [2] Add a patron. Do not set permissions. [3] Login with this patron in OPAC. [4] Check the log for warning on Context.pm line 1254. [5] Apply patch. [6] Login again. No warning anymore? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 14:48:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 13:48:38 +0000 Subject: [Koha-bugs] [Bug 11366] Acq basket group "No group" untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 14:48:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 13:48:41 +0000 Subject: [Koha-bugs] [Bug 11366] Acq basket group "No group" untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 --- Comment #3 from Fridolin SOMERS --- Created attachment 25845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25845&action=edit Bug 11366 - Acq basket group "No group" untranslatable in Acq baskets, there's a pull-down for basket groups. One of the entries in that pull-down is "No group", which is untranslatable. This string is hard-coded in perl. This patch removes the string from perl to set it has first option in select. To allow it to be default value, the option "Add new group" is moved to last position. Test plan : - Go to a closed aquisition basket in no basket group : cgi-bin/koha/acqui/basket.pl?basketno=x => You see "No group" selected in combobox "Basket group" - Cick on this combobox => You see "No group", then existing basket groups and then "Add new group" - Select a basket group and click on "change basket group" => You see the basket group name in combobox Use translation, for example fr-FR - go to src/misc/translator - run : perl translate update fr-FR => You find in PO file : #: intranet-tmpl/prog/en/modules/acqui/basket.tt:365 #, fuzzy, c-format msgid "No group" msgstr "Nom de groupe" - remove ", fuzzy" and correct translation : "Pas de groupe" - run : perl translate install fr-FR - Go to translated aquisition basket page => You see translated option in combobox -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 14:54:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 13:54:09 +0000 Subject: [Koha-bugs] [Bug 11893] Get rid of warning from IsSuperLibrarian In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11893 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:04:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:04:19 +0000 Subject: [Koha-bugs] [Bug 11755] Argument 'booksellerid' not properly handled in orderreceive.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 --- Comment #2 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #1) > Created attachment 25834 [details] [review] > Bug 11755: SearchOrders does not return booksellerid > > The SearchOrders routine should return the booksellerid. > > Booksellerid was returned before bug 10723. > Patch does resolve all the issues mentioned; I'm a little worried about an impact it will have on issue 2), though.. Situation regarding tax recalculation code in finishreceive.pl seems to be somehow like that: - in 3.10 & 3.12 branches, this code block was, and still is working like intended, - it got broken in 3.14 and up (since bug 10723) resulting in price values in all newly received orders being inconsistently saved in the database (at least for those cases where listincgst xor invoiceincgst != 1) ? As a side effect, some bug reports currently sitting in the queue which regard various problems with tax calculations in Koha will probably need to be retested / reevaluated. Still, IMO pushing this patch first (and ASAP) will be a huge change in the right direction. I wonder if there may be some way to retroactively correct wrongly calculated price values which may already got stored in aqorders table, for those people using 3.14 right now in production environment? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:21:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:21:40 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11755 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:21:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:21:40 +0000 Subject: [Koha-bugs] [Bug 11755] Argument 'booksellerid' not properly handled in orderreceive.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10613 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:21:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:21:58 +0000 Subject: [Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:22:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:22:05 +0000 Subject: [Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 --- Comment #2 from Jonathan Druart --- Created attachment 25846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25846&action=edit Bug 8258: Use patron branchcode notice for DUEDGST and PREDUEDGST If a notice is defined for the branchcode of the patron, it should be used. Without this patch, the notice used is the one defined for all libraries. Test plan: 1/ Set the advanced notice for a patron using digest. 2/ Check one item out to this patron (backdate the return date according the days in advance value). 3/ launch advance_notices.pl -c 4/ Verify the notice used is the default one. 5/ Define a notice for the library of the patron for PREDUEDGST 6/ launch advance_notices.pl -c 7/ Verify the notice used is the one previously defined. 8/ Check one item out to this patron (date due = today) 9/ launch advance_notices.pl -c 10/ Verify the notice used is the default one. 11/ Define a notice for the library of the patron for DUEDGST 12/ launch advance_notices.pl -c 13/ Verify the notice used is the one previously defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:23:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:23:27 +0000 Subject: [Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|p.thrasher at dover.nh.gov |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:27:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:27:54 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #40 from M. de Rooy --- Created attachment 25847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25847&action=edit Bug 9032: Share a list (database revision for notices) Adds notice SHARE_INVITE in updatedatabase and sample_notices. [Amendation: also adds SHARE_ACCEPT notice.] Test plan: Install or upgrade and verify that you have the new notice under Tools. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Amended the patch to add the second notice SHARE_ACCEPT. Tested upgrade with updatestructure step of web installer. Tested install by deleting all notices and running sample_notices.sql NOTE: Will add the notices to the other sql files in the other language directories as soon as this set of patches is ready to be pushed in order to reduce the need to rebase them constantly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:28:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:28:31 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #41 from M. de Rooy --- Created attachment 25848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25848&action=edit Bug 9032: Followup for new dependency Email::Valid Just adds this dependency to PerlDependencies module. Note from Robin: libemail-valid-perl is in squeeze already. Test plan: You should see Email::Valid now under About/Perl modules. If Email::Valid is not yet installed on your system, please do so. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:32:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:32:49 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10302 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:32:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:32:49 +0000 Subject: [Koha-bugs] [Bug 10302] order from staged showing inactive funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10302 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7180, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10875 --- Comment #2 from Jonathan Druart --- This will certainly fixed by bug 7180 and bug 10875. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:32:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:32:49 +0000 Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds" is missing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10302 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:34:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:34:15 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #42 from M. de Rooy --- Created attachment 25849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25849&action=edit Bug 9032: Share a list (part 1: send the invitation) Adds a Share button for OPAC private lists. Allows you to send an invitation to share a list. Checks on validity of email addresses (with Email::Valid). Test plan: 1) Sharing depends on syspref and login. Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. 2) Try to share a public list or a list you do not own. Find a security hole in the interface. Or hack the shareshelf URL and replace the shelfnumber with a public list number. 3) Enter no email address or invalid ones (no domain, forbidden chars). If you enter no address, submit should not work. If you enter only wrong addresses (separated by: ,:; ), you get a message. 4) Test if sending the invitation works. Share one of your private lists. Enter your own email address. After your proc_message_queue cronjob ran, you should have an email. Check also if you see a new record in the virtualshelfshares table. Note that the followup patch handles the second part of accepting this share. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased. Small amendation: rewording on email notification in template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:38:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:38:09 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #15 from Jacek Ablewicz --- (In reply to Jacek Ablewicz from comment #12) > Less usual combinations (no/yes, yes/no) might be a different story - I > believe invoice.pl may need an additional small change like that: > > 185c185 > > if ( $bookseller->{'invoiceincgst'} ) { > --- > < if ( $bookseller->{'listincgst'} ) { > > to behave properly for "no/yes" and "yes/no" (???). Previously we tried to test it (in 3.14 and master, with above small change included, and without it), still getting some rather weird results for "no/yes" and "yes/no" settings.. Getting bug 11755 into account (which explains at least some of this "weirdness"), question is - how should this bug be retested before sign-off: with 11755 applied first, or maybe not? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:38:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:38:53 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #43 from M. de Rooy --- Created attachment 25850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25850&action=edit Bug 9032 [Template follow-up] Share a list (part 1: send the invitation) This patch makes a few changes to the "share a list" template: - We don't use tables for layout of forms. This patch corrects the display of the share form to use Koha standard form markup. - Revise the confirmation message displayed after a list is shared to be more readable. - Add a link back to private lists to the confirmation message. - Add T:T markup to make this page display the left-hand navigation which is shown on other patron-related pages when a user is logged in. To test, apply this patch on top of other patches pending for Bug 9032 and confirm that the list share form looks correct and works correctly. Confirm that share confirmation page reads well. Signed-off-by: Marcel de Rooy Rebased March 5, 2014. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:39:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:39:54 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #44 from M. de Rooy --- Created attachment 25851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25851&action=edit Bug 9032: [QA Follow-up] Plackify opac-shareshelf.pl Plackified opac-shareshelf by moving global my variables into hashref. Slightly changed base64ord and base64chr functions to more generic ones. Test plan: Verify if sending an share invitation still works (under prog theme). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:40:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:40:01 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11755 --- Comment #16 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #15) > how should this > bug be retested before sign-off: with 11755 applied first, or maybe not? Yes, of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:40:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:40:01 +0000 Subject: [Koha-bugs] [Bug 11755] Argument 'booksellerid' not properly handled in orderreceive.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10613 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:41:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:41:26 +0000 Subject: [Koha-bugs] [Bug 7456] itypes with similar codes throw off search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7456 --- Comment #4 from Nicole C. Engard --- The same is true for shelving locations by the way - it seems that any similar codes are searched together. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:44:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:44:06 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #45 from M. de Rooy --- Created attachment 25852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25852&action=edit Bug 9032: Share a list (accept invitation and remove a share) This patch handles: [1] The response (acceptance) by the invited person. If he accepts this share, the private list of the sender will be shown under Your lists on the shelves page. In OPAC 'Your private lists' has been renamed to Your lists (just as in Staff). The Type column shows Private or Shared for these lists; a list appears as Shared as soon as an invitation has been accepted. The owner has the options to Edit, Delete or Share; the invited person does not have these options on the shared list. [2] Removing an accepted share. If a user accepted a share, he should also be able to remove it again. The Remove Share button is visible on OPAC when viewing Your lists or a particular shared list. Note: AddShare has been extended to return a possible database error. If the share invite could not be added, a mail will not be sent. Test plan (for prog theme): Enable pref OpacAllowSharingPrivateLists User 1 creates new private list P1, perms: D-A-D, adds 2 items, sends share User 1 checks your lists display: is P1 Private with Edit button? User 2 accepts share: sees P1, but cannot add or delete items User 2 checks your lists display again: P1 shows Shared without Edit? User 1 checks your lists display again: P1 shows Shared with Edit? User 2 tries to accept share again: should fail now User 3 tries to accept share: should also fail User 3 tries again, modifies shelfnumber and/or key in url: should also fail User 2 creates new private list P2, perms: A-A-A, no items, sends share User 2 checks your lists display: P2 shows Private with Edit? User 1 accepts, adds one item User 1 checks your lists display: P2 shows Shared without Edit? User 2 checks your lists display: P2 shows Shared with Edit? User 2 deletes item of user 1 (allowed) User 2 deletes list P2 User 1 checks your lists display in opac or staff: P2 is gone? User 1 creates private list P3, sends a share. User 1 creates private list P4, adds one item, sends a share. User 2 accepts the share for P3. User 2 checks the shelves display, and removes share P3. User 2 accepts the share for P4. User 2 views shelf P4 with one item and confirms Remove share on that form. User 2 checks shelves display again. Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Combined changes for AcceptShare and RemoveShare. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:48:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:48:03 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #46 from M. de Rooy --- Created attachment 25853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25853&action=edit Bug 9032: Unit tests for sharing lists This patch combines some work from report 10389 and 10441. With thanks to Srdjan and Jonathan Druart for their contributions. Adds tests for AddShare, AcceptShare, IsSharedList, RemoveShare. This patch also restores the inadvertently deleted DelShelf tests in bug 10499. Test plan: Run the test VirtualShelves.t Signed-off-by: Marcel de Rooy Rebased and squashed on March 4, 2013. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:50:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:50:12 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #47 from M. de Rooy --- Before changing the status, I will still add at lease one patch. This is to handle the bootstrap theme. Still thinking about one additional point too.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:51:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:51:09 +0000 Subject: [Koha-bugs] [Bug 11845] set overlay and import status translatable in addorderiso2709.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11845 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Nathalie CHATILLON -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:51:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:51:23 +0000 Subject: [Koha-bugs] [Bug 11845] set overlay and import status translatable in addorderiso2709.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11845 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25633|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 15:51:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 14:51:29 +0000 Subject: [Koha-bugs] [Bug 11845] set overlay and import status translatable in addorderiso2709.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11845 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 25854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25854&action=edit Bug 11845 - set overlay and import status translatable in addorderiso2709.tt In addorderiso2709.tt, the text for overlay and import status come from database and is not translatable. Same as Bug 10170. Test plan : - Go to acquisition module - Display an open basket - Click on "From a staged file" - Look at table => Without patch, you see codes in "Status" column : staged, imported, ... => With patch, you see descriptions in "Status" column : Staged, Imported, ... - Click on a "Add orders" - Look at table => Without patch, you see codes in "Match?" column : no_match, auto_match, ... => With patch, you see descriptions in "Match?" column : No match, Match found, ... Signed-off-by: Nathalie CHATILLON -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:05:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:05:30 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24465|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:05:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:05:38 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:09:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:09:08 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #28 from Martin Renvoize --- Created attachment 25855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25855&action=edit [SIGNED OFF] Bug 7413: Add issuingrules.norenewalbefore to database Currently multiple renewals can be done in immediate succsession. To optionally prevent this, a new parameter "No renewal before" is introduced. This patch adds issuingrules.norenewalbefore to the database. Default value is NULL. To test: 1) Run installer/data/mysql/updatedatabase.pl 2) Create a SQL report like: SELECT * FROM issuingrules 3) Confirm that norenewalbefore was added after renewalperiod. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:09:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:09:15 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #30 from Martin Renvoize --- Created attachment 25857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25857&action=edit [SIGNED OFF] Bug 7413: Code and intranet template changes This patch modifies CanBookBeRenewed, so that based on issuingrules.norenewalbefore a new error "too_soon" can be returned. Also adds a new subroutine GetSoonestRenewDate. To test: 1) Create an issuing rule with "No renewal before" set to value X and "Unit" set to days. 2) Test the following steps for both: Home > Patron > Patron details Home > Circulation > Checkouts 3) On the checkout page, test for today's issues as well as previous issues. (Check something out on one day and something else on the next day, then do the testing.) 4) Confirm that items can't be renewed if current date is more than X days before due date. 5) Confirm that the date and time of the soonest possible renewal are displayed in the format specified by global sysprefs "dateformat" and "TimeFormat". 6) Confirm that items can be renewed if "No renewal before" is undefined or current date is X or less days before due date. 7) Confirm that if the number of allowed renewals is exceeded "Not renewable" is displayed, no matter what "No renewal before" is set to. 8) Test the same things with "Unit" set to hours. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:09:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:09:12 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #29 from Martin Renvoize --- Created attachment 25856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25856&action=edit [SIGNED OFF] Bug 7413: Add "No renewal before" to the circulation and fine rules This patch adds a column "No renewal before" to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that an empty entry, zero and non-numerical values for "No renewal before" are saved as undefined. 3) Confirm that numerical values can be entered and saved. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:09:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:09:19 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #31 from Martin Renvoize --- Created attachment 25858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25858&action=edit [SIGNED OFF] Bug 7413: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal error "too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:09:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:09:22 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #32 from Martin Renvoize --- Created attachment 25859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25859&action=edit [SIGNED OFF] Bug 7413: OPAC prog theme changes This patch makes the prog version of opac-user.tt handle the new renewal error "too_soon". To test: 1) Set global syspref "opacthemes" to prog. 2) Test the same things as in previous patch. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:09:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:09:26 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #33 from Martin Renvoize --- Created attachment 25860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25860&action=edit [SIGNED OFF] Bug 7413: Unit test This patch makes the new parameter norenewalbefore known to unit test Circulation_Issuingrule.t. To test: 1) Before applying the patch: prove t/db_dependent/Circulation_Issuingrule.t 2) Notice that the test fails with: $got->{norenewalbefore} = undef $expected->{norenewalbefore} = Does not exist 3) Apply the patch. 4) Run test again and it should pass. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:10:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:10:30 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25247|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:10:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:10:45 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25248|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:11:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:11:00 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25249|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:11:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:11:11 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25250|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:11:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:11:22 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25251|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:11:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:11:34 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25252|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:12:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:12:34 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #34 from Martin Renvoize --- Nice work Holger, all works as expected and you've delivered nicely with the follow-ups. Signing off, lets see what they make of it at QA ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:42:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:42:05 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:42:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:42:11 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 --- Comment #3 from Owen Leonard --- Created attachment 25861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25861&action=edit Bug 11570 - Upgrade jQueryUI to latest version in the staff client This patch upgrades the version of jQueryUI included in the Koha staff client from v1.8.23 to v.1.10.4. The upgrade introduces a few minor API changes which require the updates in this patch: - In CSS, the term "active" is used instead of "selected" - Autocomplete functions use slightly changed parameters Changes to the default jQueryUI CSS allows us to remove some instances of "!important" from jQueryUI-related CSS in the staff client's main CSS file. To test: Testing changes to autocomplete: - Enable the CircAutocompl system preference. Try searching in the header's "Check out" tab. Autocomplete should look correct and function correctly. - In Circulation -> Overdues: The patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Course reserves -> Course -> Edit: Searching for an instructor - In the unimarc_field_210c_bis.pl plugin: 1. Link the publisher name field in your MARC structure to the unimarc_field_210c_bis.pl plugin. 2. Open a MARC record for editing and click the "tag editor" link to launch the plugin. 3. Type the first few letters of a publisher which exists in your database. You should get an autocomplete menu of publishers which match your search. 4. Select one and click the "choose" button to fill the field in the MARC editor. - Tools -> Patron lists: Add a list or choose an existing list and add patrons. Perform a search for a patron. - Placing a hold: After choose a title and clicking "Place hold," search for a patron. - Tags management: The sidebar filter for "reviewer" should let you search by patron name. Other jQueryUI widget changes: - Check tabs appearance in header search, biblio detail, cataloging, and circulation patron fines pages. To confirm other jQueryUI widgets still function correctly: - Check accordion (collapsing sections) in Patrons -> Patrons requesting modifications and the MARC subfield structure edit screen. - Check datepickers, especially in Circulation with the added timepicker. Test a linked datepicker, for example in Reports -> Stats wizards -> Circulation where the value in one date field affects what dates are available in the matching field. - Check the calendar interface in Tools -> Calendar To confirm that the new jQueryUI default CSS is more flexible (fixing Bug 11042), add the following CSS to your IntranetUserCSS system preference and confirm that the header search active tab border color changes (hash mark escaped so that it will appear in commit msg): \#header_search ul.ui-tabs-nav li.ui-tabs-active { background-color: #FFFFF1; border: 1px solid #800000; border-top: 0 !important; top: -2px; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:55:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:55:39 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #48 from M. de Rooy --- Created attachment 25862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25862&action=edit Bug 9032: Consistent behavior when deleting lists DelShelf deletes a list regardless whether it is private, shared or public. HandleDelBorrower had another approach, trying to save shared and public lists by setting the owner to NULL. This patch makes both routines behave consistent. A new report 11889 has been opened to discuss the 'disowning' feature. Test plan: Create a list P1 with user1 that allows adding by other users. Add a patron (user2). Login as user2 and create some lists, add some items. Let user2 add some entries to P1 too. Delete patron user2. Verify that his lists are gone, but his entries in P1 are kept (nullified). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:56:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:56:42 +0000 Subject: [Koha-bugs] [Bug 11866] Staff side course reserves too restrictive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11866 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:56:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:56:44 +0000 Subject: [Koha-bugs] [Bug 11866] Staff side course reserves too restrictive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11866 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25699|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 25863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25863&action=edit [SIGNED-OFF] Bug 11866 - Staff side course reserves too restrictive A librarian with no course reserves permissions cannot view course reserves from the staff intranet, yet can from the OPAC. This doesn't make much sense. Librarians should not require any course reserves permissions to view courses and reserves from the staff intranet. Test Plan: 1) Log into staff intranet as a librarian with no course reserves permissions 2) Note you cannot view course reserves 3) Apply this patch 4) Note you can now view course reserves 5) Verify you cannot modify courses or course reserves Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:58:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:58:59 +0000 Subject: [Koha-bugs] [Bug 11866] Staff side course reserves too restrictive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11866 --- Comment #4 from Owen Leonard --- Created attachment 25864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25864&action=edit Bug 11866 [Follow-up] Staff side course reserves too restrictive This follow-up patch adds a check for the "UseCourseReserves" system preference to the display of the Course reserves menu item in the header. To test, view the "More" menu with the "UseCourseReserves" system preference on and off. The menu item should appear and disappear accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 16:59:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 15:59:18 +0000 Subject: [Koha-bugs] [Bug 11866] Staff side course reserves too restrictive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11866 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:18:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:18:08 +0000 Subject: [Koha-bugs] [Bug 11713] Use new DataTables include in course reserves templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11713 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:18:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:18:12 +0000 Subject: [Koha-bugs] [Bug 11713] Use new DataTables include in course reserves templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11713 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25146|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 25865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25865&action=edit Bug 11713 - Use new DataTables include in course reserves templates This patch modifies two course reserves templates to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Also included: - Adds a sorting filter on the course reserves detail table to excluding articles from sorting. - Corrects the styling of toolbar buttons (buttons should have btn and btn-small classes). To test you must have UseCourseReserves enabled and have multiple existing courses, at least one of which should have items on reserve. 1. View the list of courses. Table sorting should work correctly. The "new course" button should look consistent with other staff client toolbar buttons. 2. View the list of reserves on a course. - Toolbar buttons should look consistent with other staff client toolbar buttons. - Sorting should work correctly, excluding sorting on the Edit, Remove, and "Other course reserves" columns. - Titles on reserve which begin with an article should be sorted correctly with article excluded - Test sorting with item-level_itypes on and off. - Test sorting using a patron whose permissions include various combinations of add_reserves and delete_reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:25:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:25:57 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22577|0 |1 is obsolete| | Attachment #22578|0 |1 is obsolete| | Attachment #22579|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 25866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25866&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:26:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:26:07 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #36 from Kyle M Hall --- Created attachment 25867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25867&action=edit Bug 9011 - Add the ability to store the last patron to return an item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:26:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:26:43 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9303, 11891 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:26:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:26:43 +0000 Subject: [Koha-bugs] [Bug 11891] Make Koha::Schema use C4::Context->dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11891 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9011 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:26:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:26:43 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9011 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:26:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:26:56 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:28:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:28:27 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25866|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall --- Created attachment 25868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25868&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:28:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:28:36 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25867|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall --- Created attachment 25869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25869&action=edit Bug 9011 - Add the ability to store the last patron to return an item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:30:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:30:31 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25868|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall --- Created attachment 25870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25870&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:30:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:30:44 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25869|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall --- Created attachment 25871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25871&action=edit Bug 9011 - Add the ability to store the last patron to return an item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:37:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:37:11 +0000 Subject: [Koha-bugs] [Bug 11894] New: Funds toolbar menu items greyed out without explanation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11894 Bug ID: 11894 Summary: Funds toolbar menu items greyed out without explanation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Under some circumstances items in the budgets/funds toolbar menu are greyed out without explanation. Either an explanatory tooltip should be added or the menu items should be hidden from those without the correct permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:45:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:45:36 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:45:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:45:39 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #41 from Kyle M Hall --- Created attachment 25872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25872&action=edit Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:48:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:48:03 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #42 from Kyle M Hall --- This new patch set re-engineers the entire feature. It ditches the new fields and instead simply retains the borrowernumber for the last old_issue for each patron, even if the would have been anonymized. Upon the next return of the item, that patron is then anonymized if the patron's privacy is set to 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 17:48:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 16:48:51 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25872|0 |1 is obsolete| | --- Comment #43 from Kyle M Hall --- Created attachment 25873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25873&action=edit Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 19:55:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 18:55:52 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24665|0 |1 is obsolete| | CC| |matted-34813 at mypacks.net --- Comment #13 from wajasu --- Created attachment 25874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25874&action=edit SIGNED-OFF Bug-8168-Fixing-header-of-non-csv-files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 19:59:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 18:59:36 +0000 Subject: [Koha-bugs] [Bug 11895] New: Keep stats on reserves Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11895 Bug ID: 11895 Summary: Keep stats on reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be nice if Koha tracked that an item was on reserve at some point and when it was on reserve it checked out X times. Versus the data of all of it's checkouts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 19:59:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 18:59:46 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24681|0 |1 is obsolete| | --- Comment #14 from wajasu --- Created attachment 25875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25875&action=edit SIGNED-OFF-Bug-8168-Use-semicolon-as-default-delimit Tested both patches. Observed behavior of what was written to message_queue after running overdue_notices.pl with some overdue checked out books. Default delimeter of semicolon is aligned with sysprefs value; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 20:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 19:00:09 +0000 Subject: [Koha-bugs] [Bug 8168] ersatz CSV header in attachment of overdue notices sent to administrator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 20:40:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 19:40:11 +0000 Subject: [Koha-bugs] [Bug 11896] New: add tools for compiling LESS files Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11896 Bug ID: 11896 Summary: add tools for compiling LESS files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org There should be Makefile targets added for compiling CSS files for the Bootstrap theme from LESS files. The general idea is that during installation, the compilation would occur automatically. There should also be a script available, which would presumably be invoked by the Makefile targets, so that users of Git-mode installations can recompile at any time. This is meant as a tool for installation and distribution of changes -- it is not necessarily expected that users (yet) would be editing the LESS files as part of customizations; instead, relying on *UserCSS and external stylesheets would still be the norm. This may change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 20:40:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 19:40:35 +0000 Subject: [Koha-bugs] [Bug 11896] add tools for compiling LESS files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11896 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11601 --- Comment #1 from Galen Charlton --- Link to some notes that Owen wrote up: http://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 20:40:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 19:40:35 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11896 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 20:49:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 19:49:04 +0000 Subject: [Koha-bugs] [Bug 11896] add tools for compiling LESS files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11896 --- Comment #2 from Galen Charlton --- One suggestion by Owen is using Grunt as part of the toolchain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 21:01:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 20:01:39 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 21:12:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 20:12:11 +0000 Subject: [Koha-bugs] [Bug 11896] add tools for compiling LESS files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11896 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- My worry is the "let's add this technology" may raise the bar required for development and testing. A nice link on how to use the technology would be required for those willing to test but not knowledgeable in these arcane mystical things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 21:51:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 20:51:59 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25832|0 |1 is obsolete| | --- Comment #9 from Liz Rea --- Created attachment 25876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25876&action=edit Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 21:52:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 20:52:20 +0000 Subject: [Koha-bugs] [Bug 8619] Remove hidelostitems syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8619 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 22:55:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 21:55:06 +0000 Subject: [Koha-bugs] [Bug 11725] Longoverdue cron job seems to not want to charge anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11725 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Liz Rea --- I'm thinking that this might have been my user error - we'll assume so for now. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 5 22:57:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Mar 2014 21:57:24 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #17 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #16) > (In reply to Jacek Ablewicz from comment #15) > > how should this > > bug be retested before sign-off: with 11755 applied first, or maybe not? > > Yes, of course. I did some Q&D tests with 11755 applied (figuratively speaking - right now, 11755 apparently does not apply for current master? - for testing purposes I just altered C3/Acquisition.pm manually). So far, so good: 11755 patch seems to be f*ing golden - prices w/ & wo/ tax now being handled properly on the invoice page, for all "yes/yes", "no/no", "yes/no" and "no/yes" listpriceincgst/invoiceincgst setting combinations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 01:08:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 00:08:23 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #13 from M. Tompsett --- I just realized that I would prefer the system preference to be right beside (above preferably) the OPACBaseURL system preference. Because, the text of the OPACBaseURL probably needs tweaking too. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 01:39:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 00:39:22 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #14 from M. Tompsett --- mtompset at ubuntu:~/kohaclone$ git bz apply 5010 Bug 5010 - Incomplete links in carts and lists sent from the staff client 23436 - Bug 5010: Send list emails with complete links back into the catalog 23457 - Bug 5010: Fix incomplete links in carts and lists sent from the staff client Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 5010: Send list emails with complete links back into the catalog Applying: Bug 5010: Fix incomplete links in carts and lists sent from the staff client /home/mtompset/kohaclone/.git/rebase-apply/patch:58: trailing whitespace. $dbh->do(q{INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES /home/mtompset/kohaclone/.git/rebase-apply/patch:80: trailing whitespace. choices: warning: 2 lines add whitespace errors. Using index info to reconstruct a base tree... :58: trailing whitespace. $dbh->do(q{INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES :80: trailing whitespace. choices: warning: 2 lines applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging basket/sendbasket.pl Ugly but it applies. :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 01:48:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 00:48:19 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 01:48:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 00:48:23 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23436|0 |1 is obsolete| | --- Comment #15 from M. Tompsett --- Created attachment 25877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25877&action=edit [SIGNED OFF] Bug 5010: Send list emails with complete links back into the catalog This patch adapts the way the links in the cart email in OPAC are generated for the list emails. The OpacBaseURL variable is generated from code in Auth.pm. To test: - Create a list - Email yourself the list Note: Email is sent directly and not via messagequeue table - Verify the links back into the catalog are missing http(s):// - Apply the patch - Email yourself the list again - Verify the links are now ok and working Note: The way Auth.pm generates the OpacBaseURL is not correct, as it does not take into account the OpacBaseURL system preference. This patch makes both emails sent from OPAC rely on the same code and is an improvement over the current behaviour. Tested both together using steps similar to larger test plan. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 01:49:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 00:49:20 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25877|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Created attachment 25878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25878&action=edit [SIGNED OFF] Bug 5010: Send list emails with complete links back into the catalog This patch adapts the way the links in the cart email in OPAC are generated for the list emails. The OpacBaseURL variable is generated from code in Auth.pm. To test: - Create a list - Email yourself the list Note: Email is sent directly and not via messagequeue table - Verify the links back into the catalog are missing http(s):// - Apply the patch - Email yourself the list again - Verify the links are now ok and working Note: The way Auth.pm generates the OpacBaseURL is not correct, as it does not take into account the OpacBaseURL system preference. This patch makes both emails sent from OPAC rely on the same code and is an improvement over the current behaviour. Tested both together using steps similar to larger test plan. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 01:49:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 00:49:40 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23457|0 |1 is obsolete| | --- Comment #17 from M. Tompsett --- Created attachment 25879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25879&action=edit [SIGNED OFF] Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new system preference: PublicCatalogUsesSSL. To test: - Create a list - Send yourself the list from the staff interface - Verify that the links are http:// - Put some records into your cart - Send yourself the cart from the staff interface - Verify that the links are missing http(s):// in front of them - Apply patch - Run database update - Verify that the default setting for PublicCatalogUsesSSL is 'doesn't use' - Resent both emails - Verfiy the catalog links are now both http:// links - Change system preference setting to 'uses' - Resent both emails - Verify the catalog links are now https:// links NOTE: My cart didn't have a 'In online catalog:' line on master. My list had http:// on master. System preference affected both cart and list sending. System preference necessary, because there is no way to determine http or https in the middle of an email. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 04:39:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 03:39:39 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 Christopher Vella changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at calyx.net.au --- Comment #4 from Christopher Vella --- Hi everyone I have been investigating this issue today for one of Calyx's clients. I decided to do a bit of reading up on the issue of spam protection. reCAPTCHA was the first solution that came to mind, however valid points about accessibility issues have already been made. What about the possibility of implementing a negative captcha? That way OPACs remain accessible. It would also mean we don't have to deal with the false positive detection of suggestions (as with analytical spam detection). The only downside I can see with this would be a bruteforce tool that tries ignoring particular fields or a custom coded spam bot (which seems very unlikely considering the value of the target). I also like the http://visualcaptcha.net/ project. Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 04:51:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 03:51:58 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #18 from M. Tompsett --- Don't forget to read comment #13. :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 06:43:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 05:43:06 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 --- Comment #10 from Marc V?ron --- Created attachment 25880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25880&action=edit [Signed-off] Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified Followed test plan. OK. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 06:43:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 05:43:31 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25876|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 06:43:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 05:43:41 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 07:27:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 06:27:10 +0000 Subject: [Koha-bugs] [Bug 11893] Get rid of warning from IsSuperLibrarian In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11893 --- Comment #2 from Marc V?ron --- Created attachment 25881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25881&action=edit [Signed-off] Bug 11893: Get rid of warning from IsSuperLibrarian Test plan: [1] Do not yet apply this patch [2] Add a patron. Do not set permissions. [3] Login with this patron in OPAC. [4] Check the log for warning on Context.pm line 1254. [5] Apply patch. [6] Login again. No warning anymore? Followed test plan. Patch is OK. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 07:27:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 06:27:33 +0000 Subject: [Koha-bugs] [Bug 11893] Get rid of warning from IsSuperLibrarian In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11893 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25844|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 07:27:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 06:27:45 +0000 Subject: [Koha-bugs] [Bug 11893] Get rid of warning from IsSuperLibrarian In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11893 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 07:54:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 06:54:16 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25478|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 25882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25882&action=edit Bug 11797 - Odd number of elements in hash This was discovered when someone triggered an authority search on an authority record that was missing what is assumed the default subfield for a given field. It, however, also can be triggered in an OPAC authority search by looking at the record that lacks the default subfield for a given field. TEST PLAN --------- 1) Create an authority record with 180$x and NOT 180$v. See C4::AuthoritiesMarc::BuildSummary in the 1.. foreach loop for known tags and default values. The default subfields are the first letter of the $subfields_to_report string. 2) Trigger the bug: Method 1: /cgi-bin/koha/opac-authoritiesdetail.pl?authid=# Where # is the authority id of your tweaked record. The error occurs in Normal view. Method 2: Home -> Cataloging -> + New record -> Click the 'Tag Editor' on 100$a ... 3) Notice there is an error log entry. 4) Apply the patch 5) Attempt to trigger the bug again 6) Error log entry is not generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 08:05:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 07:05:59 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #9 from Marc V?ron --- Comment #1 talks about staff client, but this bug cleans up printing from OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 08:08:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 07:08:14 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #10 from Marc V?ron --- Created attachment 25883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25883&action=edit [Signed-off] Bug 11574 - Clean up lists interface for printing Removes extraneous stuff from prints - toolbars, breadcrumbs, etc. To test: 1. make a list 2. print it to a file (from OPAC), observe wasted paper 3. apply patch 4. print list, compare 5. if you like it, sign off. ;) Patch cleans up OPAC list printing as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 08:08:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 07:08:46 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25044|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 08:08:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 07:08:55 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 08:12:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 07:12:53 +0000 Subject: [Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25882|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 25884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25884&action=edit Bug 11797 - Odd number of elements in hash This was discovered when someone triggered an authority search on an authority record that was missing what is assumed the default subfield for a given field. It, however, also can be triggered in an OPAC authority search by looking at the record that lacks the default subfield for a given field. TEST PLAN --------- 1) Create an authority record with 180$x and NOT 180$v. See C4::AuthoritiesMarc::BuildSummary in the 1.. foreach loop for known tags and default values. The default subfields are the first letter of the $subfields_to_report string. 2) Trigger the bug: Method 1: /cgi-bin/koha/opac-authoritiesdetail.pl?authid=# Where # is the authority id of your tweaked record. The error occurs in Normal view. Method 2: Home -> Cataloging -> + New record -> Click the 'Tag Editor' on 100$a Editing of $a to $b and back may be required. 3) Notice there is an error log entry. 4) Apply the patch 5) Attempt to trigger the bug again 6) That specific error log entry is not generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 08:22:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 07:22:57 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #10 from M. Tompsett --- *** Bug 11893 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 08:22:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 07:22:57 +0000 Subject: [Koha-bugs] [Bug 11893] Get rid of warning from IsSuperLibrarian In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11893 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED CC| |mtompset at hotmail.com Resolution|--- |DUPLICATE --- Comment #3 from M. Tompsett --- *** This bug has been marked as a duplicate of bug 11587 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 08:25:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 07:25:39 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 08:26:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 07:26:49 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 08:38:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 07:38:28 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Merge conflict in t/db_dependent/Acquisition.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 08:55:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 07:55:05 +0000 Subject: [Koha-bugs] [Bug 9578] Error when search and sort not on relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9578 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Steps to reproduce the error: In OPAC go to Advanced Search Choose "Title" in first "Search for:" end enter fgdfgdfgdggdg (Exam 70-433) Display "More options" Set "Sort by" to "Title (A-Z)" Click "Search" at bootom of page Result: Error: Can't call method "sort" on an undefined value at /usr/share/kohaclone/C4/Search.pm line 430. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 09:12:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 08:12:08 +0000 Subject: [Koha-bugs] [Bug 9578] Error when search and sort not on relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9578 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Version|3.8 |master Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 09:21:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 08:21:27 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #19 from Katrin Fischer --- Afaik the prefs sort alphabetically within the groups, so putting it right above OPACBaseURL would not be possible without renaming. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 09:39:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 08:39:51 +0000 Subject: [Koha-bugs] [Bug 11897] New: Stock Rotation for Koha Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Bug ID: 11897 Summary: Stock Rotation for Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We intend on writing a stock rotation module for Koha. We aim to add a batch process to automate rotation with a staff client page under tools to manage rotas/schedules. Once a rota is configured, and your staff user has the right permissions to allocate items, then an additional tab will appear on biblio records allowing the management of of which rota, if any, individual items belong to. This is different to the rotating collections work as it is designed around rotating individual items upon an automated schedule, however some of the code in that area may be re-factored to allow sharing between the two features. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 09:43:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 08:43:02 +0000 Subject: [Koha-bugs] [Bug 11755] Argument 'booksellerid' not properly handled in orderreceive.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25834|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 25885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25885&action=edit Bug 11755: SearchOrders does not return booksellerid The SearchOrders routine should return the booksellerid. Booksellerid was returned before bug 10723. Quick test plan: Go on orderreceive.pl and verify that the vendor link is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 09:44:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 08:44:13 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #18 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #17) > I did some Q&D tests with 11755 applied (figuratively speaking - right now, > 11755 apparently does not apply for current master? - for testing purposes I > just altered C3/Acquisition.pm manually). I rebased it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 09:47:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 08:47:29 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #19 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #17) > So far, so good: 11755 patch seems to be f*ing golden - prices w/ & wo/ tax > now being handled properly on the invoice page, for all "yes/yes", "no/no", > "yes/no" and "no/yes" listpriceincgst/invoiceincgst setting combinations. Great! May you sign it off then? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 10:00:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 09:00:00 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25862|0 |1 is obsolete| | --- Comment #49 from M. de Rooy --- Created attachment 25886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25886&action=edit Bug 9032: Consistent behavior when deleting lists DelShelf deletes a list regardless whether it is private, shared or public. HandleDelBorrower had another approach, trying to save shared and public lists by setting the owner to NULL. This patch makes both routines behave consistent. A new report 11889 has been opened to discuss the 'disowning' feature. NOTE: I did not add a db revision here to handle possible cases of lists without owner in the current data. Such public (or shared) lists can still be used without any problem. Bug 11889 and a new planned report for a lists management tool will address this topic further on. After that, all goals of umbrella report 7310 should be realized. Test plan: Create a list P1 with user1 that allows adding by other users. Add a patron (user2). Login as user2 and create some lists, add some items. Let user2 add some entries to P1 too. Delete patron user2. Verify that his lists are gone, but his entries in P1 are kept (nullified). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 10:12:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 09:12:04 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #1 from Martin Renvoize --- Created attachment 25887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25887&action=edit Technical Spec I've uploaded a detailed spec which from which we are basing the work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 10:16:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 09:16:27 +0000 Subject: [Koha-bugs] [Bug 2865] Acquisitions: GST not calculating correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2865 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #9 from Jonathan Druart --- This one is too old. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 10:19:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 09:19:10 +0000 Subject: [Koha-bugs] [Bug 8465] CancelReserve sub is doing wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8465 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #3 from Christophe Croullebois --- this bug is no longer valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 10:23:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 09:23:02 +0000 Subject: [Koha-bugs] [Bug 7495] Tax calculations problem for new orders. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7495 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21128|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 10:23:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 09:23:28 +0000 Subject: [Koha-bugs] [Bug 7495] Tax calculations problem for new orders. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7495 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #8 from Jonathan Druart --- I don't reproduce this bug on master. Please reopen it if I am wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 11:00:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 10:00:29 +0000 Subject: [Koha-bugs] [Bug 11733] "gist" system preference inconsistently treated as single-value or multi-value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733 --- Comment #3 from Jonathan Druart --- Created attachment 25888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25888&action=edit Bug 11733: gist can be multi-valued The gist syspref should always be treated as multi-value. In basketgroup.pl, parcel.pl and invoice.pl it is treated as single-value. The invoice.pl script will be fixed by bug 10613. If the pref contains several values, the first one is the default one (according to the syspref description). Test plan: No regression should be found on displaying total basketgroup for a vendor with 'list prices' don't include tax and 'invoice prices' include tax. No regression should be found on generating pdf. If no gstrate is defined for the vendor, the gstrate used should be the first one defined in the gist syspref. On parcel.pl, this patch only removes dead code. The $gst variable is not used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 11:00:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 10:00:49 +0000 Subject: [Koha-bugs] [Bug 11733] "gist" system preference inconsistently treated as single-value or multi-value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 11:08:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 10:08:37 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19788|0 |1 is obsolete| | --- Comment #20 from Jacek Ablewicz --- Created attachment 25889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25889&action=edit [SIGNED-OFF] Bug 10613: The gst rate is not correctly calculated on the invoice page. Test plan: Defined a gst rate on creating an order, receive it and check that all prices are correctly calculated. /!\ Behavior change function of supplier parameters (Include/Don't include tax for list prices and invoice prices) Notes: patch tested with Bug 11755 applied first; confirmed that: - price calculations are correct for all combinations of listincgst/invoiceincgst settings in the vendor record - unitprice (aka "Actual cost") is taken into account on the invoice page instead of rrp/ecost, like it should. Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 11:09:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 10:09:16 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22389|0 |1 is obsolete| | --- Comment #21 from Jacek Ablewicz --- Created attachment 25890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25890&action=edit [SIGNED-OFF] Bug 10613: FIX typo supplierid vs booksellerid GetInvoiceDetails returns a hashref with a key named booksellerid, not supplierid. The bookseller was not retrieved from the DB and the listincgst value was always false. Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 11:10:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 10:10:18 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 11:22:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 10:22:45 +0000 Subject: [Koha-bugs] [Bug 11742] Overdue notice/status triggers displaying the wrong notice for default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 12:57:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 11:57:42 +0000 Subject: [Koha-bugs] [Bug 9578] Error when search and sort not on relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9578 --- Comment #4 from Marc V?ron --- Created attachment 25891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25891&action=edit [Signed-off] Bug 9578 - Error when search and sort not on relevance When searching with a sort (means not by relevance) and there is an error in Zebra connexion (server is down or query is wrong), you get the message : Error : Can't call method "sort" on an undefined value at /home/kohaadmin/src/C4/Search.pm line 405. This patch corrects by not performing sort if no results. Steps to reproduce the error without patch: In OPAC go to Advanced Search Choose "Title" in first "Search for:" end enter fgdfgdfgdggdg (Exam 70-433) Display "More options" Set "Sort by" to "Title (A-Z)" Click "Search" at bootom of page Result: Error: Can't call method "sort" on an undefined value at /usr/share/kohaclone/C4/Search.pm line 430. Test plan : - Set OPACdefaultSortField on something else than relevance - Perform a simple search with a wrong CCL query. For example : ccl=( and ) => You get the messge : No results found ... Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 12:58:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 11:58:22 +0000 Subject: [Koha-bugs] [Bug 9578] Error when search and sort not on relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9578 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 12:58:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 11:58:35 +0000 Subject: [Koha-bugs] [Bug 9578] Error when search and sort not on relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9578 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 13:53:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 12:53:24 +0000 Subject: [Koha-bugs] [Bug 11742] Overdue notice/status triggers displaying the wrong notice for default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 13:53:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 12:53:28 +0000 Subject: [Koha-bugs] [Bug 11742] Overdue notice/status triggers displaying the wrong notice for default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742 --- Comment #1 from Jonathan Druart --- Created attachment 25892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25892&action=edit Bug 11742: A letter code should be unique. This patch is a dirty way to fix a design issue on notices. Currently the code assumes that a letter code is unique. Which is wrong, the primary key is module, code, branchcode. But the C4::Letters::GetLetters routine returns a hashref with letter code in keys => only 1 per letter code is returned. I tried to fix the API but it is more complicated than I thought. Test plan: Try to duplicate a letter code using edit, add and copy actions. If you manage to do it, please describe how you did. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 13:56:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 12:56:50 +0000 Subject: [Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #20 from M. Tompsett --- Okay, but you put it in a completely different section. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 14:02:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 13:02:52 +0000 Subject: [Koha-bugs] [Bug 10702] can't create notices for a specific branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10702 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- I cannot reproduce on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 14:11:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 13:11:54 +0000 Subject: [Koha-bugs] [Bug 11898] New: the js accordion when editing marc frameworks is broken for the t tab Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11898 Bug ID: 11898 Summary: the js accordion when editing marc frameworks is broken for the t tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: gaetan.boisson at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To reproduce : find a field with a t subfield (700) edit a marc framework with this subfield click on Advanced constraints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 14:12:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 13:12:19 +0000 Subject: [Koha-bugs] [Bug 11898] the js accordion when editing marc frameworks is broken for the t tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11898 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 14:47:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 13:47:11 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- I tried to apply it but got: mtompset at ubuntu:~/kohaclone$ git bz apply 11699 Bug 11699 - notes entered when receiving are not saved 25835 - Bug 11699: Notes entered when receiving are not saved 25836 - Bug 11699: ModReceiveOrder should take a hashref in parameter Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11699: Notes entered when receiving are not saved fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11699: Notes entered when receiving are not saved When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11699-Notes-entered-when-receiving-are-not-sav-IBUgWg.patch Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 14:47:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 13:47:59 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #50 from M. de Rooy --- Created attachment 25893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25893&action=edit Bug 9032: Follow-up for bootstrap theme Adds new template opac-shareshelf.tt. Modifies template opac-shelves.tt: Share button, Remove Share button, label "Your lists" instead of "Your private lists", list category Shared. Test plan: Verify if the Share a list-features work in bootstrap by: [1] Switch to bootstrap. Go to Lists. [2] Share one of your private lists. [3] Login as another user and accept the invitation. [4] Remove the share again. [5] Check if Share and Remove share do not popup for public lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 14:53:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 13:53:01 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #51 from M. de Rooy --- This is ready for signoff again. Note that some of the patches already had a signoff. Some have been amended while rebasing (as noted). Some patches are new. In other words: Please help to get this further. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 14:53:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 13:53:54 +0000 Subject: [Koha-bugs] [Bug 11755] Argument 'booksellerid' not properly handled in orderreceive.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 --- Comment #4 from Marc V?ron --- Created attachment 25894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25894&action=edit [Signed-off] Bug 11755: SearchOrders does not return booksellerid The SearchOrders routine should return the booksellerid. Booksellerid was returned before bug 10723. Quick test plan: Go on orderreceive.pl and verify that the vendor link is correct. Followed test plan. Vendor link is now correct. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 14:54:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 13:54:17 +0000 Subject: [Koha-bugs] [Bug 11755] Argument 'booksellerid' not properly handled in orderreceive.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25885|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 14:54:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 13:54:30 +0000 Subject: [Koha-bugs] [Bug 11755] Argument 'booksellerid' not properly handled in orderreceive.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 14:59:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 13:59:33 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25835|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 25895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25895&action=edit Bug 11699: Notes entered when receiving are not saved Test plan: 1/ Create an order with 2 items 2/ Receive 1 item and enter a note for the order 3/ Verify the note is correctly saved 4/ Receive the second item and enter a note for the order 5/ Verify the note is correctly saved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:00:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:00:18 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25836|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 25896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25896&action=edit Bug 11699: ModReceiveOrder should take a hashref in parameter Test plan: prove t/db_dependent/Acquisition.t prove t/db_dependent/Acquisition/Invoices.t prove t/db_dependent/Acquisition/OrderFromSubscription.t all should return green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:00:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:00:32 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:02:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:02:10 +0000 Subject: [Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 --- Comment #6 from Marc V?ron --- Created attachment 25897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25897&action=edit [Signed-off] Bug 11828: Follow up - add new option to OrderPdfFormat This depends on bug 11459. To test: - Apply patch for 11459 - Apply patches for 11828 - Check appearance of the OrderPdfFormat system preference It will offer a pull down with options, including "German 2-page" Followed test plan. Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:02:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:02:32 +0000 Subject: [Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25749|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:02:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:02:42 +0000 Subject: [Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:15:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:15:38 +0000 Subject: [Koha-bugs] [Bug 11493] Batch Item Modification not handling unicode characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11493 --- Comment #2 from Marc V?ron --- Created attachment 25898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25898&action=edit [Signed-off] Bug 11493: Revert "Bug 6869 Batch item modification fails whit accented characters" This reverts commit c9905750e53e2e1615842ac696d5eeb0a8ac07fc. Test plan: 1/ Open a bib record with more than 1 item , 2/ Select all items 3/ Chose Modify selected items 4/ put you "? ? ?" in notes 5/ Verify the items have been updated correctly 6/ put you "???" in notes 7/ Verify the items have been updated correctly 8/ put you "? ? ? ???" in notes 9/ Verify the items have been updated correctly Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:16:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:16:03 +0000 Subject: [Koha-bugs] [Bug 11493] Batch Item Modification not handling unicode characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11493 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25838|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:16:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:16:12 +0000 Subject: [Koha-bugs] [Bug 11493] Batch Item Modification not handling unicode characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11493 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:20:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:20:17 +0000 Subject: [Koha-bugs] [Bug 5901] Make virtualshelves permissions more granular In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5901 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from M. de Rooy --- It looks like most of the issues mentioned on this report have been dealt with in the meantime. If virtualshelves is off, opac users have no lists. Imo this pref could be an opac pref, why not allow staff users always to create lists? If the pref is off, a public list is only partially visible on staff side. I think we should just enable the functionality in staff "everywhere"; if you do not use it, no problem. If virtualshelves is on, we can now control the creation of public lists by opac users with a specific pref. Patrons can create private lists. Sharing lists (bug 9032) is controlled by another pref. The permissions per list allow you to control adding items or not. Comment4 of Magnus remains. Probably we could turn this into: Control the creation of public lists per user category instead of the generic pref. I would suggest to open a new report for that one, if it is really needed. Comments welcome. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:22:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:22:52 +0000 Subject: [Koha-bugs] [Bug 5901] Make virtualshelves permissions more granular In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5901 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #7 from Katrin Fischer --- Hi Marcel, I had started to work on this, lost my branch, got lost in the logic of the virtualshelves code and never got to return to it :( I think having a fresh start with a new bug describing exactly the now needed changes would be good. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:22:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:22:53 +0000 Subject: [Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310 Bug 7310 depends on bug 5901, which changed state. Bug 5901 Summary: Make virtualshelves permissions more granular http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5901 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:23:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:23:54 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:27:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:27:15 +0000 Subject: [Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10679 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:27:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:27:15 +0000 Subject: [Koha-bugs] [Bug 10679] Lists interface offers delete option when user doesn't have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7310 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:40:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:40:13 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #95 from Jonathan Druart --- Created attachment 25899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25899&action=edit Bug 9016: FIX GetLetters should return all letters GetLetters only returns letters with a mtt = email. It should return all letter codes in the DB. The message_transport_type parameter is never used. To reproduce the issue: Create a notice with a sms template and no email template. Go on the overdue rules configucation page. The notice does not appear in the notice list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:42:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:42:07 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25895|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 25900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25900&action=edit [SIGNED OFF] Bug 11699: Notes entered when receiving are not saved Revised test plan: 1/ Create an order with 2 items 2/ Receive 1 item and enter a note for the order 3/ Verify the note is not saved The note should be visible on the Mod Order Details screen, but it isn't there. 4/ Apply patch 5/ Receive the second item and enter a note for the order 6/ Verify the note is correctly saved The note is visible on the Mod Order Details screen. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:42:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:42:58 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:43:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:43:00 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25896|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 25901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25901&action=edit [SIGNED OFF] Bug 11699: ModReceiveOrder should take a hashref in parameter Test plan: prove t/db_dependent/Acquisition.t prove t/db_dependent/Acquisition/Invoices.t prove t/db_dependent/Acquisition/OrderFromSubscription.t all should return green. NOTE: Any error messages are the same between master and this patch, and are unrelated to the added/revised tests. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 15:51:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 14:51:17 +0000 Subject: [Koha-bugs] [Bug 11742] Overdue notice/status triggers displaying the wrong notice for default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742 --- Comment #2 from Jonathan Druart --- I am not really fond of this patch (especially as it will break the bug 9016 integration). Feel free to provide something else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 16:06:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 15:06:26 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 16:08:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 15:08:19 +0000 Subject: [Koha-bugs] [Bug 10472] Receipt by line or invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10472 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 16:10:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 15:10:24 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 --- Comment #8 from Owen Leonard --- Existing warnings in the staff client use the term "database administrator account." I think this patch should use the same phrase, instead of "special administrator account." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 16:30:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 15:30:50 +0000 Subject: [Koha-bugs] [Bug 11769] Use validation plugin when creating new MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 --- Comment #2 from Marc V?ron --- Created attachment 25902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25902&action=edit [Signed-off] Bug 11769 - Use validation plugin when creating new MARC framework The page for adding a new MARC framework includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> MARC bibliographic framework -> New framework. Try submitting the form without entering a tag number. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing framework should also work correctly. Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 16:31:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 15:31:29 +0000 Subject: [Koha-bugs] [Bug 11769] Use validation plugin when creating new MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25295|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 16:31:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 15:31:42 +0000 Subject: [Koha-bugs] [Bug 11769] Use validation plugin when creating new MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 16:38:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 15:38:21 +0000 Subject: [Koha-bugs] [Bug 11806] Use validation plugin when creating new OAI set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11806 --- Comment #2 from Marc V?ron --- Created attachment 25903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25903&action=edit [Signed-off] Bug 11806 - Use validation plugin when creating new OAI set The form for adding a new OAI indicates that two fields are required but does nothing to enforce this rule. This can be handled client-side with HTML5 validation attributes and Koha's built-in validation plugin. This patch implements this. To test, apply the patch and go to Administration -> OAI sets configuration -> New set. Try submitting the form without entering a setSpec and/or setName. Doing so should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing set should also work correctly. Followed test plan. Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 16:39:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 15:39:00 +0000 Subject: [Koha-bugs] [Bug 11806] Use validation plugin when creating new OAI set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11806 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25525|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 16:39:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 15:39:08 +0000 Subject: [Koha-bugs] [Bug 11806] Use validation plugin when creating new OAI set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11806 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 16:49:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 15:49:44 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #67 from Marc V?ron --- Attachment 22301: Merge conflict in sco-main.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:00:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:00:22 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #15 from Marc V?ron --- Patch "delete search history by id - API changes" does not apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:05:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:05:40 +0000 Subject: [Koha-bugs] [Bug 11899] New: Force staff to choose option for filling a hold Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11899 Bug ID: 11899 Summary: Force staff to choose option for filling a hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If a staff member checks in an item on hold, then checks in another item without confirming the hold, the hold will not be filled. There needs to be a block before another transaction. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:07:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:07:10 +0000 Subject: [Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #12 from Marc V?ron --- Merge conflict in opac/svc/report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:14:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:14:16 +0000 Subject: [Koha-bugs] [Bug 11900] New: OPAC cart can confuse patrons Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900 Bug ID: 11900 Summary: OPAC cart can confuse patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The ?cart? feature is confusing to our patrons ? many think that they can check out from there or that they have put an item on hold. We would like the ability to change the name of the ?cart? feature or to add an explanation of this feature to the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:14:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:14:46 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #13 from Jonathan Druart --- Created attachment 25904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25904&action=edit Bug 766: Move GetAuthvalueDropbox to C4::Koha GetAuthvalueDropbox is in C4::Budgets, this does not make sense. Only acqui/fetch_sort_dropbox.pl call GetAuthvalueDropbox without using C4::Koha. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:14:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:14:54 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #14 from Jonathan Druart --- Created attachment 25905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25905&action=edit Bug 766: Create a plugin routine to build dropdown list On this way, dropdown list could be generated from the templates. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:15:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:15:00 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #15 from Jonathan Druart --- Created attachment 25906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25906&action=edit Bug 766: Use the method plugin to generate sort dropdown list - memberentry Now we can use the method plugin from the memberentry form. Test plan: 1/ Create a patron and verify sort1 and sort2 dropdown list are correctly generated. 2/ Select values. 3/ Save. 4/ Edit the patron and verify the selected values are displayed. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:15:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:15:09 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #16 from Jonathan Druart --- Created attachment 25907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25907&action=edit Bug 766: Cleaning: buildCGISort is not in use anymore buildCGISort can be deleted. Test plan: git grep buildCGISort should return no result. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:16:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:16:54 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m --- Comment #17 from Jonathan Druart --- What about something like that? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:18:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:18:16 +0000 Subject: [Koha-bugs] [Bug 11901] New: Change old reference to "shelf" to "list" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11901 Bug ID: 11901 Summary: Change old reference to "shelf" to "list" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When removing items from a list, the message asks ?Are you sure you want to remove these records from the shelf?? That is confusing, the names should match so we know what we?re removing them from. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:20:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:20:14 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #187 from Jonathan Druart --- Created attachment 25908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25908&action=edit Bug 7180: fetch_sort_dropbox.pl is not in use anymore Test plan: git grep fetch_sort_dropbox should return no result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:20:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:20:41 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #18 from Jonathan Druart --- Note: Bug 7180 already removes some call to CGI::scrolling_list. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:32:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:32:47 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #16 from Jonathan Druart --- Did you apply dependencies before applying these ones? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:35:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:35:25 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:40:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:40:23 +0000 Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for improved usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671 --- Comment #7 from Marc V?ron --- Created attachment 25909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25909&action=edit [Signed-off] Bug 11671 - Restructure patron lists add form for improved usability Non-standard interface features have the potential to cause confusion. This patch brings various aspects of the patron lists add page into conformity with other staff client pages. - Add "select all/clear all" links for the checkboxes - Add a "remove selected" to the top of the table (see also Lists) - Split functionality of add from from delete form - Hide "Add patrons" button until at least one patron has been selected - Remove non-standard trash can icon from table's checkbox column - Exclude checkbox column from table sorting - Add confirmation to deletion actions - Improve breadcrumb specificity - Add title-string sorting to date column to accommodate sorting for all date format types To test, apply the patch and create a patron list. 1. Search for and select patrons for the list. Selecting a patron should trigger the display of an "Add patrons" button. 2. Click "Add patrons" and confirm that the add process completes correctly. 3. Search for and select a patron and also check the box next to an existing patron. Click "Add patrons" and confirm that no patron is removed. 4. Check that the "select all" and "clear all" links work correctly. 5. Select patrons on the list and click the "Remove selected" link. You should be prompted to confirm your choice. 4.a. Click cancel and confirm that the deletion process aborts. 4.b. Click OK and confirm that the deletion process completes. 6. Repeat step 4 with the "Remove selected patrons" at the bottom of the page. 7. Confirm that the page title and breadcrumbs correctly show the list name. 8. Switch between us and metric dateformat settings and confirm that table sorting by date is correct in both cases. Followed test plan. Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:40:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:40:50 +0000 Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for improved usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25536|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:41:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:41:01 +0000 Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for improved usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:41:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:41:50 +0000 Subject: [Koha-bugs] [Bug 11902] New: When finished receiving, redirect to the vendor. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11902 Bug ID: 11902 Summary: When finished receiving, redirect to the vendor. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When doing invoices in acquisitions, once you finish one invoice you no longer are automatically put back to the vendor you were working in. You have to go back and type the vendor name again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:42:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:42:06 +0000 Subject: [Koha-bugs] [Bug 11902] When finished receiving, redirect to the vendor. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11902 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 17:46:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 16:46:06 +0000 Subject: [Koha-bugs] [Bug 11903] New: Different quick searches for different item editors Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11903 Bug ID: 11903 Summary: Different quick searches for different item editors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When editing items in batch from a bib record, you see a regular search box at the top of the screen. When editing individual items, you see a cataloging search. We should see a normal search for both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 18:16:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 17:16:04 +0000 Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900 --- Comment #1 from Owen Leonard --- We have been down this road before: Bug 3719. Perhaps one alternative is a custom translation? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 19:31:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 18:31:20 +0000 Subject: [Koha-bugs] [Bug 11904] New: Proposal for a uniform way to send messages to user interface Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Bug ID: 11904 Summary: Proposal for a uniform way to send messages to user interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org I find quite horrible that for sending a message to user interface we have to do something like that: $template->param(there_was_an_error_during_checkout => 1); then in template: [% IF there_was_an_error_during_checkout = 1 %]

There was an error during checkout
[% END %] or even worse, having to add a parameter in the URL we want to redirect to. So here is a proposal for a uniform way to send messages to user interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 19:33:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 18:33:07 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #1 from Julian Maurice --- Created attachment 25910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25910&action=edit Bug 11904: New module Koha::Messages This patch provides a uniform way to send messages to user interface. It uses CGI::Session to store messages and allow to render them thanks to a Template::Toolkit plugin (Koha::Template::Plugin::Messages) and a template include file (messages.inc) This patch doesn't introduce the new template include file anywhere. It will require additional patches to make it work. To use it, simply call messages_set() in a Perl script or module, then put [% INCLUDE 'messages.inc' %] at the right place in the right template file. See POD documentation of Koha::Messages for more information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 19:33:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 18:33:11 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #2 from Julian Maurice --- Created attachment 25911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25911&action=edit Bug 11904: Unit tests for Koha::Messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 19:33:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 18:33:14 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #3 from Julian Maurice --- Created attachment 25912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25912&action=edit Bug 11904: Example usage of new module Koha::Messages Test plan: 1/ Go to members/moremember.pl 2/ Click on "More" -> "Renew patron" and confirm 3/ A message should appear "Patron's account has been renewed until ..." 4/ In a shell, go to misc/translator and run ./translate create fr-FR (or ./translate update fr-FR) ./translate install fr-FR (you can use your own language of course) 5/ Edit po/fr-FR-messages.po and translate the string "Patron's account has been renewed until ..." 6/ In staff interface change language to French and renew patron once again. 7/ The translated message should appear. Needs patches from bugs 8044 and 11848 for string translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 19:34:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 18:34:27 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Julian Maurice --- Note: These patches don't introduce the new template include file anywhere. It will requires additional patches to make it work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 19:36:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 18:36:18 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25397|0 |1 is obsolete| | --- Comment #4 from Fr?d?rick Capovilla --- Created attachment 25913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25913&action=edit New version of the patch, fixes merge conflict and a small bug. Here is a new version of the patch, fixing the merge conflict and a small bug we found with the biblio titles. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 20:01:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 19:01:57 +0000 Subject: [Koha-bugs] [Bug 11325] Focus not on "Add Item" in Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 20:08:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 19:08:54 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22315|1 |0 is obsolete| | CC| |mtompset at hotmail.com --- Comment #13 from M. Tompsett --- Comment on attachment 22315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22315 Bug 8000 - Override emails of every message sent from Koha Changes are in here that somehow got lost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 20:11:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 19:11:09 +0000 Subject: [Koha-bugs] [Bug 11905] New: when editing item, cursor is positioning in search box and not to item Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11905 Bug ID: 11905 Summary: when editing item, cursor is positioning in search box and not to item Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 25914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25914&action=edit search box edit item Hi, In 3.12 (or 3.10), a catalog search box has been added to edit item page. When i click on edit, cursor is positioning in search box and not to the item i want to edit. If i have 100 items, i have to scroll to the end of the page. Anyone can test it? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 20:16:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 19:16:26 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #5 from Marc V?ron --- Created attachment 25915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25915&action=edit [Signed-off]Add the "Orders by budget" report. http://bugs.koha-community.org/show_bug.cgi?id=11371 How I tested: Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 20:17:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 19:17:00 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25913|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 20:17:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 19:17:28 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 20:22:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 19:22:39 +0000 Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #17 from Marc V?ron --- (In reply to Jonathan Druart from comment #16) > Did you apply dependencies before applying these ones? Ah, no, sorry! Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 21:13:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 20:13:54 +0000 Subject: [Koha-bugs] [Bug 11906] New: Bad display of utf-8 chars in Patron lists (Datatable) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 Bug ID: 11906 Summary: Bad display of utf-8 chars in Patron lists (Datatable) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 25916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25916&action=edit Bad display of utf-8 chars In patron lists patron names and other texts display ???? if they have umlauts and other utf-8 chars. Something like ?????????? Skj?ld?ttur dispays as ?????????? Skj?ld?ttur See screenshot attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 21:28:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 20:28:05 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22315|0 |1 is obsolete| | Attachment #24784|0 |1 is obsolete| | --- Comment #14 from Blou --- Created attachment 25917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25917&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 21:35:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 20:35:20 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 --- Comment #1 from Marc V?ron --- I tried the solution from Bug 11290 In ...patron_lists/list.tt something like: [% p.borrowernumber.surname |html_entity %] It works for Skj?ld?ttur, but not for ?????????? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 22:18:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 21:18:46 +0000 Subject: [Koha-bugs] [Bug 11901] Change old reference to "shelf" to "list" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11901 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Could we avoid using items? That has caused some confusion in translations in the past :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 22:53:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 21:53:20 +0000 Subject: [Koha-bugs] [Bug 11907] New: Status in search.pl doesn't match status in detail.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11907 Bug ID: 11907 Summary: Status in search.pl doesn't match status in detail.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org The search.pl page only shows the name of the category for a status, such as DAMAGED or LOST, rather than the specific status used from those categories. You see the true status of these items in the detail.pl page, but it would be preferable to see the same status EVERYWHERE, or at least have the option to see it the same everywhere. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 23:00:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 22:00:18 +0000 Subject: [Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 23:00:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 22:00:22 +0000 Subject: [Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16830|0 |1 is obsolete| | --- Comment #13 from Chris Cormack --- Created attachment 25918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25918&action=edit Bug 9915 : Allow sql_params to be passed to a report using the svc interface Test plan: 1/ Make a public report that contains sql parameters 2/ Test it from the staff side 3/ Hit the url like cgi-bin/koha/svc/report?id=1&sql_params=chris&sql_params=chris2 4/ Test you get json Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 23:01:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 22:01:09 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 23:01:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 22:01:14 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #15 from M. Tompsett --- Created attachment 25919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25919&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 23:22:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 22:22:44 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #16 from M. Tompsett --- Created attachment 25920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25920&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 23:23:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 22:23:30 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #17 from M. Tompsett --- I'm working on an improvement to this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 23:33:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 22:33:58 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25747|0 |1 is obsolete| | --- Comment #7 from Fr?d?rick Capovilla --- Created attachment 25921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25921&action=edit New version of the patch. Rebase on current master. Here is a new version of the patch. In the end, we think this new view is easier to read and understand for patrons, and this is why we are sharing this patch. Also, I won't hide updates would be a lot easier for us if we didn't have to reapply our patch everytime we want to update Koha. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 23:42:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 22:42:42 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25745|0 |1 is obsolete| | --- Comment #3 from Fr?d?rick Capovilla --- Created attachment 25922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25922&action=edit New version of the patch. Rebase on current master. Patch updated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 23:42:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 22:42:51 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 6 23:43:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Mar 2014 22:43:04 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 04:29:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 03:29:42 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #18 from M. Tompsett --- Created attachment 25923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25923&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 04:56:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 03:56:24 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25917|0 |1 is obsolete| | --- Comment #19 from M. Tompsett --- Created attachment 25924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25924&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 04:56:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 03:56:35 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25919|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Created attachment 25925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25925&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 04:56:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 03:56:43 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25920|0 |1 is obsolete| | --- Comment #21 from M. Tompsett --- Created attachment 25926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25926&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This was generated by running ./misc/devel/update_dbix_class_files.pl using appropriate -db_name=... -db_user=... -db_passwd=... parameters. This file is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 04:56:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 03:56:51 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25923|0 |1 is obsolete| | --- Comment #22 from M. Tompsett --- Created attachment 25927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25927&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 05:14:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 04:14:11 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 05:14:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 04:14:14 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25927|0 |1 is obsolete| | --- Comment #23 from M. Tompsett --- Created attachment 25928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25928&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 05:36:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 04:36:23 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #24 from M. Tompsett --- (In reply to Jonathan Druart from comment #10) > I have a concern: we can't know if the user has been notified or if the > email used was the SendAllEmailsTo content. > It could cause problem on debugging if the pref is available on a production > server. > I don't have a suggestion (except adding a new column in the message_queue > table (which is quite ugly). This is why I generated the last two patches. I added some not quite perfect testing for the first patch too. However, the testing becomes nicer when all four patches are applied. I did not add in the Email validation library as Marcel suggested in comment #7. I did not centralize anything. I don't know if Kyle was intending to imply that not centralizing it would mean this patch wouldn't make it past QA in comment #9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 05:56:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 04:56:22 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #25 from M. Tompsett --- I forgot to mention: prove -v t/db_dependent/Letters.t This should effectively test all the changes in C4::Letters. Testing of: - basket/sendbasket.pl - misc/cronjobs/runreport.pl - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - virtualshelves/sendshelf.pl - C4::Letters::SendAlerts will require arcane librarian/koha knowledge. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 06:44:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 05:44:48 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #8 from M. Tompsett --- Changes to koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl 2008: 13 2009: 14 2010: 14 2011: 10 2012: 9 2013: 6 2014: 1 It would seem to me that the amount the template is changing is going down, but with it changing every 1-2 months, I can understand why the change is desired in master. Is there a way to system preference the line break vs. comma in XSLT? Perhaps that would be more acceptable, and default to comma given that is the current behaviour. I changed this to in discussion, because as far as I can tell this patch won't make it past QA, because of the comma vs. line break difference and because perhaps a system preference thought may save this desired line break functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 08:46:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 07:46:04 +0000 Subject: [Koha-bugs] [Bug 10647] OPAC MARC plain view only working for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 08:54:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 07:54:44 +0000 Subject: [Koha-bugs] [Bug 10647] OPAC MARC plain view only working for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 --- Comment #2 from Magnus Enger --- I can confirm this bug. Clicking on the "view plain" link gives a Ajaxy "spinning wheel" and a "Loading..." message for a second or two, then a yellow warning saying "Sorry, plain view is temporarily unavailable." I get this in the opac-error.log: opac-showmarc.pl: Could not create file parser context for file "/usr/share/koha/opac/htdocs/opac-tmpl/prog/en/xslt/NORMARCslim2OPACMARCdetail.xsl": No such file or directory at /usr/share/koha/opac/cgi-bin/opac/opac-showmarc.pl line 80, referer: http://kurs.demo.bibkat.no/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=18 ...which seems to confirm that a missing XSLT file is the culprit. And I'm also seeing a ton of 500 errors in my Apache logs (from bots) for pages like this: /cgi-bin/koha/opac-showmarc.pl?id=10611&viewas=html ...which is what that Ajax call is trying to fetch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 09:07:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 08:07:03 +0000 Subject: [Koha-bugs] [Bug 11503] Several typos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #17 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 09:10:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 08:10:15 +0000 Subject: [Koha-bugs] [Bug 11509] koha-create should print better usage information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Fridolin SOMERS --- "wrong parameter count" patch pushed to 3.14.x, will be in 3.14.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 09:16:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 08:16:45 +0000 Subject: [Koha-bugs] [Bug 11381] IDreamBooks too close to title on bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11381 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 09:17:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 08:17:04 +0000 Subject: [Koha-bugs] [Bug 10647] OPAC MARC plain view only working for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 09:17:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 08:17:09 +0000 Subject: [Koha-bugs] [Bug 10647] OPAC MARC plain view only working for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 --- Comment #3 from Magnus Enger --- Created attachment 25929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25929&action=edit Bug 10647 - Make OPAC MARC plain view work for all flavours of MARC On "MARC view" in the OPAC, clicking on "Plain view" does not work for UNIMARC and NORMARC. To test: - Make sure you have a UNIMARC or NORMARC setup - Go to the "MARC view" of a record in the OPAC - Click on "view plain" and observe the "Sorry, plain view is temporarily unavailable." error message - Apply the patch - Click on "view plain" and observe that a plain view of the MARC record is now displayed - Sign off I have only tested this on NORMARC, it might be good if someone can test on UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 09:17:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 08:17:46 +0000 Subject: [Koha-bugs] [Bug 10647] OPAC MARC plain view only working for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 09:18:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 08:18:06 +0000 Subject: [Koha-bugs] [Bug 10647] Make OPAC MARC plain view work for all flavours of MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC MARC plain view only |Make OPAC MARC plain view |working for MARC21 |work for all flavours of | |MARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 09:20:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 08:20:57 +0000 Subject: [Koha-bugs] [Bug 11505] Untranslatable table headers in Label batch manager In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 09:50:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 08:50:06 +0000 Subject: [Koha-bugs] [Bug 10647] Make OPAC MARC plain view work for all flavours of MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 09:58:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 08:58:35 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #35 from Holger Mei?ner --- Thank you, Martin! If there's anything you need tested, let me know and I'll see what I can do. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 10:52:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 09:52:45 +0000 Subject: [Koha-bugs] [Bug 7274] Fix formatting of actual cost on order receive page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7274 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 13:45:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 12:45:39 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #261 from Kyle M Hall --- Created attachment 25930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25930&action=edit Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 13:59:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 12:59:05 +0000 Subject: [Koha-bugs] [Bug 10647] Make OPAC MARC plain view work for all flavours of MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 13:59:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 12:59:09 +0000 Subject: [Koha-bugs] [Bug 10647] Make OPAC MARC plain view work for all flavours of MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25929|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS --- Created attachment 25931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25931&action=edit Bug 10647 - Make OPAC MARC plain view work for all flavours of MARC On "MARC view" in the OPAC, clicking on "Plain view" does not work for UNIMARC and NORMARC. To test: - Make sure you have a UNIMARC or NORMARC setup and OPACXSLTDetailsDisplay not empty - Go to the "MARC view" of a record in the OPAC - Click on "view plain" and observe the "Sorry, plain view is temporarily unavailable." error message - Apply the patch - Click on "view plain" and observe that a plain view of the MARC record is now displayed - Sign off I have only tested this on NORMARC, it might be good if someone can test on UNIMARC. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 14:00:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 13:00:42 +0000 Subject: [Koha-bugs] [Bug 10647] Make OPAC MARC plain view work for all flavours of MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 --- Comment #5 from Fridolin SOMERS --- Signed and added "OPACXSLTDetailsDisplay not empty" in test plan. Very old and ugly bug, thanks Magnus :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 14:28:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 13:28:37 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #262 from Kyle M Hall --- Created attachment 25932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25932&action=edit Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 14:29:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 13:29:41 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #263 from Kyle M Hall --- Created attachment 25933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25933&action=edit Bug 6427 [Part 21] - Fix ILSDI::Services -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 14:30:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 13:30:01 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25932|0 |1 is obsolete| | --- Comment #264 from Kyle M Hall --- Created attachment 25934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25934&action=edit Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 14:39:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 13:39:42 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 --- Comment #7 from Fridolin SOMERS --- Indeed. I correct my patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 14:43:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 13:43:05 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |tomascohen at gmail.com --- Comment #2 from Tom?s Cohen Arazi --- I'm sorry to say I cannot reproduce the problem right now. I'm pretty sure this is related to some data being defaulted to ISO because of not explicitly marking as UTF8 (so is more related to latin+diacritics than non-latin) and hence breaking places where there is actual UTF-8 data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 14:45:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 13:45:17 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 --- Comment #16 from Fridolin SOMERS --- In last patch, "General searchid in browser.js", i mean "Generate ...". :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 15:08:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 14:08:07 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #10 from Kyle M Hall --- Created attachment 25935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25935&action=edit Bug 11563 [QA Followup] - Disable add noEnterSubmit to pulldowns When using Chrome on Mac OS X, form submits are triggered by hitting enter when focused on a select. This is not an issue with any other combincation of browser and operating system that I am aware of. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 16:30:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 15:30:42 +0000 Subject: [Koha-bugs] [Bug 11908] New: update22to30.pl falls to create `labels` table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11908 Bug ID: 11908 Summary: update22to30.pl falls to create `labels` table Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org Due to specifying 14 as the width of the datatype TIMESTAMP, the table creation fails with the following output: Adding labels table... DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(14) NOT NULL,PRIMARY KEY (labelid)' at line 5 at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/update22to30.pl line 3165. Error : DBI::st=HASH(0x2640c40)->errstr ------------- Additional Info: Encountered while moving a Koha 2.2.5 db to 3.14 and MySQL 4.1.11 to MySQL 5.5.35-0+wheezy1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 16:30:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 15:30:56 +0000 Subject: [Koha-bugs] [Bug 11908] update22to30.pl falls to create `labels` table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11908 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 16:42:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 15:42:58 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #55 from Kyle M Hall --- Created attachment 25936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25936&action=edit Bug 10558 [QA Follow-up 8] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 16:46:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 15:46:50 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 16:46:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 15:46:53 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22064|0 |1 is obsolete| | Attachment #22065|0 |1 is obsolete| | Attachment #22066|0 |1 is obsolete| | Attachment #22067|0 |1 is obsolete| | Attachment #22068|0 |1 is obsolete| | Attachment #23993|0 |1 is obsolete| | Attachment #23995|0 |1 is obsolete| | Attachment #25936|0 |1 is obsolete| | --- Comment #56 from Kyle M Hall --- Created attachment 25937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25937&action=edit Bug 10558 [QA Follow-up] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 16:48:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 15:48:26 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #57 from Kyle M Hall --- (In reply to Galen Charlton from comment #54) > Close, but there is a serious issue left: a regression on bug 2060. > > In particular, this patch regresses on the ability to properly display > authority record batches. Instead of linking to the authority details page > for imported records, for example, it links to the *bibliographic* details > page. Fixed! > Sorting by citation for authority batches is also broken -- > GetImportRecordsRange() is asked to sort by title when it should be sorting > by authorized_heading. Fixed! > By the way, it would be preferable to me if GetImportRecordsRange() did not > rely on dbh_quote_identifier() to sanitize the sorting column, which at > present is passed directly from a CGI parameter. It should instead set > $order_by to one of a known set of values, similar to how you deal with > $order_by_direction. Fixed! > A much more minor issue: tools/batch_records_ajax.pl asserts that it's both > GPL2 and GPL3+. Fixed! > Please squash your QA follow-ups (but not Owen's) when you resubmit. Done! New fixes published in followup 8 for easy analysis. All followups squashed and resubmitted as one patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 16:53:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 15:53:55 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25714|0 |1 is obsolete| | --- Comment #4 from Fr?d?rick Capovilla --- Created attachment 25938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25938&action=edit New version of the patch. Rebase on current master and fixed. Here is a new version of the patch, fixing comment 1 and 3 of your code review. For the self-registration, the text is duplicated because the old version includes "or" and a period, which is not needed for the custom text since the link cannot be included inside of it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 17:27:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 16:27:24 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- Sorry. I missed mentioning that you forgot to update installer/data/mysql/sysprefs.sql as well. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 17:37:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 16:37:23 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #26 from Kyle M Hall --- Created attachment 25939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25939&action=edit Bug 8000 [QA Followup] - Change mis-used qw to q -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 17:40:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 16:40:39 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #6 from M. Tompsett --- Comment on attachment 25938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25938 New version of the patch. Rebase on current master and fixed. Review of attachment 25938: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6864&attachment=25938) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-main.tt @@ +64,5 @@ > > +
> +
> + [% opacbelowloginbox %] > +
I like the id, but I'm not sure I see a need for this functionality. ::: opac/opac-main.pl @@ +56,4 @@ > $template->param( > koha_news => $all_koha_news, > koha_news_count => $koha_news_count, > + opacbelowloginbox => C4::Context->preference("OpacBelowLoginBox"), So you really want something under the login area in the right side of the OPAC screen? I think it is ugly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 17:41:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 16:41:51 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Kyle M Hall --- I think it would either be best to either use Data::Validate::Email to validate the email address or just remove the simple email validation altogether. Since this validation isn't exactly valid it seems like a bit of a step backwards. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 17:45:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 16:45:38 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #7 from M. Tompsett --- If you do want something under the login area displayed on the main screen, perhaps it would be shorter or different than the other login area reached by clicking 'Log in to your account'? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:01:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:01:23 +0000 Subject: [Koha-bugs] [Bug 11869] Add more informations to the member printing pages. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25726|0 |1 is obsolete| | --- Comment #6 from Fr?d?rick Capovilla --- Created attachment 25940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25940&action=edit New version of the patch. Here is a new version of the patch. The code in moremember-receipt.tt was removed, since the new version of the slip is now configurable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:03:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:03:30 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #4 from Kyle M Hall --- Created attachment 25941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25941&action=edit Bug 11879 [QA Followup] - Fix patch to follow modern coding guidelines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:07:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:07:30 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24581|0 |1 is obsolete| | Attachment #24582|0 |1 is obsolete| | Attachment #24583|0 |1 is obsolete| | Attachment #24584|0 |1 is obsolete| | Attachment #24585|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 25942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25942&action=edit Bug 10827: Regression tests The unit tests in the file db_dependent/Reserves/priorities.t describe the issue. To reproduce using the interface: - Create 3 patrons A, B and C - Check an item out to A - Place a hold on this item for B and C - Check the item in - Confirm the hold - Verify the hold list: The item is waiting for B and C has a priority 2 - Delete the hold for B - Now you can see the item is not waiting for C. He has not been notified neither. If you apply all patches from this bug, at the next ste, the item is marked as waiting for C and C has been notified when the hold for B has been deleted. /!\Important note: This patch only manages item-level holds! The commented UT is for biblio-level holds. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:07:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:07:49 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #24 from Kyle M Hall --- Created attachment 25943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25943&action=edit Bug 10827: Change prototype for ModReserveAffect This patch only changes the prototype for C4::Reserves::ModReserveAffect. This modification will allow to simplify future changes. No change should be expected with this patch. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:07:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:07:53 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #25 from Kyle M Hall --- Created attachment 25944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25944&action=edit Bug 10827: Check if the item should be transfered in ModReserveAffect Before this patch, ModReserveAffect should know if the item have to be transfered. Now it is checked in the routine. Moreover, it is possible to pass an item key in parameters. If it is not given, the item's information is retrieved from GetBiblioFromItemNumber. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:07:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:07:57 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #26 from Kyle M Hall --- Created attachment 25945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25945&action=edit Bug 10827: Update item-level holds if deletion If a lower level priority hold is deleted, the next on the list should be marked as 'waiting' and the patron notified. This patch only affects item-level holds. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:08:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:08:01 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #27 from Kyle M Hall --- Created attachment 25946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25946&action=edit Bug 10827: destBranch tt param is useless With previous changes, the destBranch passed to the template become useless and can be removed. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:08:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:08:16 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:11:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:11:07 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #8 from M. Tompsett --- Comment on attachment 25938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25938 New version of the patch. Rebase on current master and fixed. Review of attachment 25938: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6864&attachment=25938) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-main.tt @@ +64,5 @@ > > +
> +
> + [% opacbelowloginbox %] > +
With PatronSelfRegistration turned on, it gets uglier. The div is in the wrong place. It should be above line 61, I think. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:29:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:29:53 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Fr?d?rick Capovilla --- Changing status to "Needs Signoff" so another round of QA can be done with zebra reindexations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:31:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:31:12 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Instead of having all this code in the perl scripts, wouldn't it be far simpler to to check C4::Context->userenv->{number} and display a warning that this account can't create a list? A TT plugin for userenv access could simplify this even more. I think a UserEnv sub that returned whatever $userenv->{$key} could easily be added to the Koha TT plugin. In addition, the code assumes that any failure should generate this message, which may not always be the case. I'd say that's a qa blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:59:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:59:04 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:59:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:59:08 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22574|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 25947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25947&action=edit Bug 9180: All branches should be returned if a default rule exists The C4::Overdues::GetBranchcodesWithOverdueRules routine has a bug. If a default rule *and* a specific rule exist, only the branchcode for the specific rule is returned. Test plan: prove t/db_dependent/Overdues.t and verify the unit tests are consistent. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 18:59:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 17:59:50 +0000 Subject: [Koha-bugs] [Bug 11869] Add more informations to the member printing pages. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 --- Comment #7 from M. Tompsett --- This looks better, but I was wondering if you could also tweak issueloo.date_due to also pipe through $KohaDates. It displays ugly, and since we're tweaking the summary, we might as well fix that too. After all, [% USE KohaDates %] was added. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:01:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:01:06 +0000 Subject: [Koha-bugs] [Bug 11866] Staff side course reserves too restrictive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11866 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25864|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 25948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25948&action=edit [SIGNED-OFF] Bug 11866 [Follow-up] Staff side course reserves too restrictive This follow-up patch adds a check for the "UseCourseReserves" system preference to the display of the Course reserves menu item in the header. To test, view the "More" menu with the "UseCourseReserves" system preference on and off. The menu item should appear and disappear accordingly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:01:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:01:15 +0000 Subject: [Koha-bugs] [Bug 11866] Staff side course reserves too restrictive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11866 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:02:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:02:42 +0000 Subject: [Koha-bugs] [Bug 11713] Use new DataTables include in course reserves templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11713 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:02:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:02:45 +0000 Subject: [Koha-bugs] [Bug 11713] Use new DataTables include in course reserves templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11713 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25865|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 25949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25949&action=edit Bug 11713 - Use new DataTables include in course reserves templates This patch modifies two course reserves templates to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Also included: - Adds a sorting filter on the course reserves detail table to excluding articles from sorting. - Corrects the styling of toolbar buttons (buttons should have btn and btn-small classes). To test you must have UseCourseReserves enabled and have multiple existing courses, at least one of which should have items on reserve. 1. View the list of courses. Table sorting should work correctly. The "new course" button should look consistent with other staff client toolbar buttons. 2. View the list of reserves on a course. - Toolbar buttons should look consistent with other staff client toolbar buttons. - Sorting should work correctly, excluding sorting on the Edit, Remove, and "Other course reserves" columns. - Titles on reserve which begin with an article should be sorted correctly with article excluded - Test sorting with item-level_itypes on and off. - Test sorting using a patron whose permissions include various combinations of add_reserves and delete_reserves Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:08:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:08:17 +0000 Subject: [Koha-bugs] [Bug 11908] update22to30.pl falls to create `labels` table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11908 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:12:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:12:41 +0000 Subject: [Koha-bugs] [Bug 11909] New: Fix hidelostitems, OpacHiddenItems total count, prog them facet display Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 Bug ID: 11909 Summary: Fix hidelostitems, OpacHiddenItems total count, prog them facet display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: matted-34813 at mypacks.net QA Contact: testopia at bugs.koha-community.org hidelostitems hides the biblio when all items are lost. - we just want to hide the items, not the biblio. - one can use the Availability Refine your search to hide the biblios, so that functionality provides the feature, without a default hiding of biblios. opac-search.pl search results calculates wrong "total" so that Number of results found indicator is off, and is misreported, as well as breaks auto-redirect to details when ONLY one result is returned, with various combinations of usage of hidelostitems, and OpacHiddenItems. facets "Refine your serach" displays in "prog" theme when no search results returned. - this seemd fine in bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:33:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:33:56 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25924|0 |1 is obsolete| | --- Comment #28 from Blou --- Created attachment 25950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25950&action=edit Bug 8000 - Override emails of every message sent from Koha This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:36:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:36:18 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #29 from Blou --- Created attachment 25951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25951&action=edit Bug 8000 - Validate allEmailsTo email address before using it This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:37:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:37:22 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:38:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:38:45 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25924|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:41:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:41:52 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #30 from Blou --- in adding the new patch to validate the emails, I kept the same "patch name" and it overrode the previous one with the same name. So I 1) canceled the new "Override emails.,.." patch 2) submitted again the new one (under new name) 3) un-obsoleted the main one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:42:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:42:24 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:50:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:50:19 +0000 Subject: [Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:50:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:50:22 +0000 Subject: [Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25846|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 25952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25952&action=edit Bug 8258: Use patron branchcode notice for DUEDGST and PREDUEDGST If a notice is defined for the branchcode of the patron, it should be used. Without this patch, the notice used is the one defined for all libraries. Test plan: 1/ Set the advanced notice for a patron using digest. 2/ Check one item out to this patron (backdate the return date according the days in advance value). 3/ launch advance_notices.pl -c 4/ Verify the notice used is the default one. 5/ Define a notice for the library of the patron for PREDUEDGST 6/ launch advance_notices.pl -c 7/ Verify the notice used is the one previously defined. 8/ Check one item out to this patron (date due = today) 9/ launch advance_notices.pl -c 10/ Verify the notice used is the default one. 11/ Define a notice for the library of the patron for DUEDGST 12/ launch advance_notices.pl -c 13/ Verify the notice used is the one previously defined. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:53:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:53:24 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:57:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:57:14 +0000 Subject: [Koha-bugs] [Bug 10837] Exporting serial claims does not work if no notice defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10837 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 19:57:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 18:57:17 +0000 Subject: [Koha-bugs] [Bug 10837] Exporting serial claims does not work if no notice defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10837 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23773|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 25953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25953&action=edit Bug 10837: Exporting serial claims does not work if no notice defined On the serial claims page, it is possible to export (using a csv profile) or claim 1+ serials. The checkboxes are not shown if the claiming notice is not defined. So it is not possible to export claims. Test plan: - delete your notice "claimissues" - go on the serial claims page - verify that you are able to export them as CSV Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:00:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:00:58 +0000 Subject: [Koha-bugs] [Bug 11366] Acq basket group "No group" untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:01:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:01:01 +0000 Subject: [Koha-bugs] [Bug 11366] Acq basket group "No group" untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25845|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 25954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25954&action=edit Bug 11366 - Acq basket group "No group" untranslatable in Acq baskets, there's a pull-down for basket groups. One of the entries in that pull-down is "No group", which is untranslatable. This string is hard-coded in perl. This patch removes the string from perl to set it has first option in select. To allow it to be default value, the option "Add new group" is moved to last position. Test plan : - Go to a closed aquisition basket in no basket group : cgi-bin/koha/acqui/basket.pl?basketno=x => You see "No group" selected in combobox "Basket group" - Cick on this combobox => You see "No group", then existing basket groups and then "Add new group" - Select a basket group and click on "change basket group" => You see the basket group name in combobox Use translation, for example fr-FR - go to src/misc/translator - run : perl translate update fr-FR => You find in PO file : #: intranet-tmpl/prog/en/modules/acqui/basket.tt:365 #, fuzzy, c-format msgid "No group" msgstr "Nom de groupe" - remove ", fuzzy" and correct translation : "Pas de groupe" - run : perl translate install fr-FR - Go to translated aquisition basket page => You see translated option in combobox Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:04:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:04:29 +0000 Subject: [Koha-bugs] [Bug 11550] Add a couple of unit tests for C4::Acq::GetOrder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:04:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:04:31 +0000 Subject: [Koha-bugs] [Bug 11550] Add a couple of unit tests for C4::Acq::GetOrder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25686|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 25955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25955&action=edit Bug 11550: Add UT for C4::Acquisition::GetOrder If GetOrder is called with a nonexistent ordernumber or without any ordernumber, it should return undef. Test plan: prove t/db_dependent/Acquisition.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:08:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:08:59 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:09:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:09:03 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22387|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 25956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25956&action=edit Bug 11139 - opac-topissues does not work with CCODE When OPAC most populars uses collection code, it does not work. There are never results. This patch corrects two points: - SQL query uses 'ccode' as collection code authorised values category, it is CCODE uppercase - The constraint category='CCODE' must be inside join detween items and authorised_values, in this case items.ccode may be NULL Test plan : On a catalogue where items.ccode is defined and uses CCODE authorised values : - Set syspref AdvancedSearchTypes = ccode - Go to opac-topissues.pl - If no results, select "No limit" in "of the last:" and submit => You get results - Select in results a biblio and remove items.ccode from all its items - Refresh opac-topissues.pl (check "All collections" is selected in "Limit to:") => The biblio is still in results Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:25:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:25:59 +0000 Subject: [Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:26:04 +0000 Subject: [Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25918|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 25957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25957&action=edit Bug 9915 : Allow sql_params to be passed to a report using the svc interface Test plan: 1/ Make a public report that contains sql parameters 2/ Test it from the staff side 3/ Hit the url like cgi-bin/koha/svc/report?id=1&sql_params=chris&sql_params=chris2 4/ Test you get json Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:27:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:27:27 +0000 Subject: [Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 --- Comment #15 from Kyle M Hall --- >From a QA perspective, should this be using placeholders rather than quote? I know I've had a finger wagged at be once or twice for using quote and/or quote_identifier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:32:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:32:57 +0000 Subject: [Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 --- Comment #16 from Chris Cormack --- (In reply to Kyle M Hall from comment #15) > From a QA perspective, should this be using placeholders rather than quote? > I know I've had a finger wagged at be once or twice for using quote and/or > quote_identifier. Perhaps, but it is using the exact same code as the reports engine on the staff side, so that it gives the same behaviour. I don't like to mix refactoring and new features on the same bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:33:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:33:52 +0000 Subject: [Koha-bugs] [Bug 11231] notes should be reservenotes in pendingreserves.pl and reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:33:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:33:54 +0000 Subject: [Koha-bugs] [Bug 11231] notes should be reservenotes in pendingreserves.pl and reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24325|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 25958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25958&action=edit Bug 11231 - notes should be reservenotes in pendingreserves.pl and reserveratios.pl notes have been removed as they were not displaying in the first place. 1.apply patch 2.verify that both reports work Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:34:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:34:27 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |matted-34813 at mypacks.net --- Comment #1 from wajasu --- Created attachment 25959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25959&action=edit Bug 11909 - Fix hidelostitems, OpacHiddenItems total count, prog theme facet display This patch is combined because testing all three as they interact may be complicated enough and the changes are minimal. - Stopped hiding biblio when an item is lost. - Inspected all items to determine if all are hidden to "hide" a biblio. (I left it so that if a non-hidden item exists, such as another branches' item is not hidden, the biblio will still show.) - Tweaked prog theme to only show facets if the search results count > 0 Bugs that may be affected: 8462 - hopefully can be obsoleted by this 9966 - can be obsoleted (4004 not found with single result for OpacHiddenItems) 8416 - hopefully can be obsoleted by this. OpacHiddenItems is orthogonal to hidelostitems, and this patch separates function more. 3194 - obsolete. I think we want to see the biblio these days. And facets display provides the further filtering functionality these days. 11489 - obsolete - no 404 not found errors anymore Other bugs to consider 3030, 11677 Testing: (Sometimes requires periodic rebuild_zebra.pl -a -b -r as Search search_results might affect what gets indexed.) I had a blank test DB with DOM, and default reference test data loaded. I used Z3950 to catalog 3 biblios and set the title to have something unique (like xyzzy). I would typically search for "xzzy" all the time. You can run or watch zerbasrv -f KOHA_CONF to see how many results are returned and observe the further filtering by hidden/lost items. Out of the three cataloged, I added two items from library CPL to one, One with a CPL and MPL item, and One with a MPL only. I also would navigate to admin and change lost status of various items and switch to another tab and runthe search. Note: You might need to rebuld zebra in some cases, that is whay i suggested a small size database. If you already have a large DB with known branches and lost items, you can just query for things, comparing to the query results in the staff client. I did not test multiple pages/paging of results, since the patch seemed minimal, but someone else could. Note: I though about the hiding of biblios for OpacHiddenItems across federated/multiple server searches, and I did not address that case. But that is a more complex scenario. Reading different bugs about hiding biblios for all items being lost, with differing opinons, I chose to provide the biblios and rely on the faceted availability to futher filter those out. Hope thats a good compromise. We could add a syspref for availability to default differently if folks want that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:39:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:39:41 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 --- Comment #2 from wajasu --- For branch hiding typically would add: homebranch: [MPL] to OpacHiddenItems. Used homebranch: [CPL,MPL] to get all my branches hidden. You could use holdingbranch, and other rules. Be aware, of your logged in user in the OPAC, and anonymous user. I'm not sure about how the home branch is cached. Sometimes things get no results because you might not get OpacHiddenItems correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:42:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:42:13 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- I've been unable to test this because I cannot apply the patches for 11848, but I think this is a most excellent idea! It reminds me of stash for Perl Catalyst. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:51:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:51:11 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:51:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:51:14 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25861|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 25960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25960&action=edit Bug 11570 - Upgrade jQueryUI to latest version in the staff client This patch upgrades the version of jQueryUI included in the Koha staff client from v1.8.23 to v.1.10.4. The upgrade introduces a few minor API changes which require the updates in this patch: - In CSS, the term "active" is used instead of "selected" - Autocomplete functions use slightly changed parameters Changes to the default jQueryUI CSS allows us to remove some instances of "!important" from jQueryUI-related CSS in the staff client's main CSS file. To test: Testing changes to autocomplete: - Enable the CircAutocompl system preference. Try searching in the header's "Check out" tab. Autocomplete should look correct and function correctly. - In Circulation -> Overdues: The patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Course reserves -> Course -> Edit: Searching for an instructor - In the unimarc_field_210c_bis.pl plugin: 1. Link the publisher name field in your MARC structure to the unimarc_field_210c_bis.pl plugin. 2. Open a MARC record for editing and click the "tag editor" link to launch the plugin. 3. Type the first few letters of a publisher which exists in your database. You should get an autocomplete menu of publishers which match your search. 4. Select one and click the "choose" button to fill the field in the MARC editor. - Tools -> Patron lists: Add a list or choose an existing list and add patrons. Perform a search for a patron. - Placing a hold: After choose a title and clicking "Place hold," search for a patron. - Tags management: The sidebar filter for "reviewer" should let you search by patron name. Other jQueryUI widget changes: - Check tabs appearance in header search, biblio detail, cataloging, and circulation patron fines pages. To confirm other jQueryUI widgets still function correctly: - Check accordion (collapsing sections) in Patrons -> Patrons requesting modifications and the MARC subfield structure edit screen. - Check datepickers, especially in Circulation with the added timepicker. Test a linked datepicker, for example in Reports -> Stats wizards -> Circulation where the value in one date field affects what dates are available in the matching field. - Check the calendar interface in Tools -> Calendar To confirm that the new jQueryUI default CSS is more flexible (fixing Bug 11042), add the following CSS to your IntranetUserCSS system preference and confirm that the header search active tab border color changes (hash mark escaped so that it will appear in commit msg): \#header_search ul.ui-tabs-nav li.ui-tabs-active { background-color: #FFFFF1; border: 1px solid #800000; border-top: 0 !important; top: -2px; } Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:54:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:54:11 +0000 Subject: [Koha-bugs] [Bug 11850] Bulkmarcimport does not append in logfile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:54:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:54:13 +0000 Subject: [Koha-bugs] [Bug 11850] Bulkmarcimport does not append in logfile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 --- Comment #3 from Kyle M Hall --- Created attachment 25961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25961&action=edit Bug 11850: Fix bulkmarcimport -l option to append to the logfile Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:54:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:54:47 +0000 Subject: [Koha-bugs] [Bug 11850] Bulkmarcimport does not append in logfile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 --- Comment #4 from Kyle M Hall --- >From a QA standpoint, if this is controversial, maybe there should be a flag to choose between append vs overwrite for file logging. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:58:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:58:55 +0000 Subject: [Koha-bugs] [Bug 11860] Display subscription callnumber in OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11860 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 20:58:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 19:58:57 +0000 Subject: [Koha-bugs] [Bug 11860] Display subscription callnumber in OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11860 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25690|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 25962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25962&action=edit Bug 11860: Display subscription callnumber in OPAC detail page Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 21:07:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 20:07:25 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 --- Comment #10 from M. de Rooy --- (In reply to Kyle M Hall from comment #9) > Instead of having all this code in the perl scripts, wouldn't it be far > simpler to to check C4::Context->userenv->{number} and display a warning > that this account can't create a list? > > A TT plugin for userenv access could simplify this even more. I think a > UserEnv sub that returned whatever $userenv->{$key} could easily be added to > the Koha TT plugin. > > In addition, the code assumes that any failure should generate this message, > which may not always be the case. I'd say that's a qa blocker. All this code is only a few lines (the AddShelf line is an improvement in any case). But I would not oppose a warning in the template either. A better message would be fine. The actual warning is now: List could not be created (which is pretty generic :) Between brackets, a reminder Do not use kohaadmin (which will be in this case btw a frequent cause). No blockers for me. How do we get this further now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 7 21:29:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 20:29:04 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #31 from M. Tompsett --- It would seem that Kyle recommended Data::Validate::Email in comment 27 and Marcel recommended Email::Valid in comment 7. Email::Valid is far more active than Data::Validate::Email. Just thought I'd point out the activity. Is there a preference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 00:09:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Mar 2014 23:09:54 +0000 Subject: [Koha-bugs] [Bug 11910] New: Adding a zebra index should be a configuration change. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11910 Bug ID: 11910 Summary: Adding a zebra index should be a configuration change. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: bartonski at gmail.com QA Contact: testopia at bugs.koha-community.org There are several web pages documenting how to add a zebra index to koha, e.g. http://wiki.koha-community.org/wiki/MRenvoize/zebra Unfortunately, these changes must be made either to configuration files which are part of the Koha distribution (e.g. bib1.att, record.abs, ccl.properties and pqf.properties.) or to C4::Search.pm. As such, adding zebra indexes at a package site risks losing modifications upon upgrade. I suggest that the files - bib1.att - record.abs - ccl.properties - pqf.properties As well as any files required for DOM indexing be placed in a configuration directory, e.g. /etc/koha/sites/* or $HOME/koha-dev/etc. In order to be searchable, the index name must be added to @indexes in C4::Search.pm::getIndexes(). At the very least, there should be a way of adding extra indexes to the arrayref returned by getIndexes() without editing source code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 01:12:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 00:12:25 +0000 Subject: [Koha-bugs] [Bug 11911] New: purchase suggestions permission can be bypassed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Bug ID: 11911 Summary: purchase suggestions permission can be bypassed Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If I don?t give an account a permission to the purchase suggestions, but they have a copy of the link, such as http://mysite/cgi-bin/koha/suggestion/suggestion.pl?displayby=STATUS&branchcode=__ANY__, they can go straight into the feature without permission. Shouldn?t the suggestion.pl be checking permissions upon loading? Do most pages function in this manner? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 05:15:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 04:15:18 +0000 Subject: [Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |matted-34813 at mypacks.net Assignee|gmcharlt at gmail.com |matted-34813 at mypacks.net --- Comment #1 from wajasu --- Created attachment 25963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25963&action=edit Bug 2946 - Lost items (hidden in Normal View) still show up in the MARC View in OPAC Coded this old bug against master. Test Plan: 0) set hidelostitems syspref to "Dont show" 1) find/build a biblio with items. 2) from detail page select MARC view and scroll to bottom to see Holdings. 3) go edit the item as lost. 4) from detail page select MARC view and scroll to bottom to see Holdings. (lost item should be gone. And if no other items, no holdings table shown. 5) toggle hidelost items syspref and view again to see lost items appear/disappear 6) you can click plain text view to see that as well Hope you don't mind my changing bug to version: master, since its been so long, and its still an issue in pre 3.14 days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 05:15:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 04:15:40 +0000 Subject: [Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_0 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 06:47:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 05:47:23 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- We've dialogued on this. Awaiting some tweaks. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 10:26:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 09:26:05 +0000 Subject: [Koha-bugs] [Bug 11848] Make Koha::I18N easier to use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11904 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 10:26:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 09:26:05 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11904 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 10:26:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 09:26:05 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8044, 11848 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 11:53:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 10:53:16 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20369|0 |1 is obsolete| | --- Comment #55 from Julian Maurice --- Comment on attachment 20369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20369 Bug 8044: Translate basket CSV column names using Koha::I18N > Note: this patch is not needed anymore. Bug 10935 fixes the translatable > issue on csv headers. But the module and others patches is still needed to > translate some others strings (in C4::SIP::* for instance). So I'm marking it as obsolete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 11:53:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 10:53:54 +0000 Subject: [Koha-bugs] [Bug 11850] Bulkmarcimport does not append in logfile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I think this can't go in as it is. On #koha an optional flag was discussed: http://irc.koha-community.org/koha/2014-02-26#i_1471750 Setting to "In Discussion". I am tending to make this new behaviour depending on a command line option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 11:55:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 10:55:34 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 11:59:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 10:59:06 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20366|0 |1 is obsolete| | --- Comment #56 from Julian Maurice --- Created attachment 25964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25964&action=edit Bug 8044: First draft for Koha localization using Locale::Maketext Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 11:59:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 10:59:33 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20367|0 |1 is obsolete| | --- Comment #57 from Julian Maurice --- Created attachment 25965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25965&action=edit Bug 8044 follow-up: Fix warning and error messages in translate.pl Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 11:59:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 10:59:58 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20368|0 |1 is obsolete| | --- Comment #58 from Julian Maurice --- Created attachment 25966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25966&action=edit Bug 8044 follow-up: Add copyright block and use Modern::Perl Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 12:00:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 11:00:34 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20370|0 |1 is obsolete| | --- Comment #59 from Julian Maurice --- Created attachment 25967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25967&action=edit Bug 8044: QA Followup to silence koha-qa Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 12:04:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 11:04:13 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 --- Comment #6 from Julian Maurice --- (In reply to Kyle M Hall from comment #5) > I've been unable to test this because I cannot apply the patches for 11848, > but I think this is a most excellent idea! It reminds me of stash for Perl > Catalyst. Did you apply the patches for 8044 first ? I just rebased them on master, so they all apply nicely if you apply them in this order: 8044, 11848, 11904. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 21:07:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 20:07:39 +0000 Subject: [Koha-bugs] [Bug 11698] can't create a budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|critical |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 21:48:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 20:48:36 +0000 Subject: [Koha-bugs] [Bug 11875] URL is poorly formed when searching on authid for author In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11875 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Joy, did you check a matching authority exists? The links from the magnifying glasses work fine for me, as long as I have a matching authority. Only when there is no matching authority for the id i get the 404. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 21:50:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 20:50:33 +0000 Subject: [Koha-bugs] [Bug 4397] display problems (umlauts, =?UTF-8?Q?=20=C3=9F?=) with scan index in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 --- Comment #5 from Katrin Fischer --- I have problems applying this patch with git bz... $ git bz apply 4397 Traceback (most recent call last): File "/usr/sbin/git-bz", line 2609, in do_apply(*args) File "/usr/sbin/git-bz", line 1688, in do_apply print "Bug %d - %s" % (bug.id, bug.short_desc) UnicodeEncodeError: 'ascii' codec can't encode character u'\xdf' in position 38: ordinal not in range(128) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 8 21:51:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Mar 2014 20:51:18 +0000 Subject: [Koha-bugs] [Bug 4397] display problems (umlauts, =?UTF-8?Q?=20=C3=9F?=) with scan index in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 --- Comment #6 from Katrin Fischer --- But works fine using wget and git am -iu3... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 9 22:28:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Mar 2014 21:28:26 +0000 Subject: [Koha-bugs] [Bug 11912] New: GetMarcISBN wrongly prepends a space to ISBNs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11912 Bug ID: 11912 Summary: GetMarcISBN wrongly prepends a space to ISBNs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 9 22:43:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Mar 2014 21:43:06 +0000 Subject: [Koha-bugs] [Bug 11912] GetMarcISBN wrongly prepends a space to ISBNs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11912 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 9 22:43:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Mar 2014 21:43:10 +0000 Subject: [Koha-bugs] [Bug 11912] GetMarcISBN wrongly prepends a space to ISBNs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11912 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 25968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25968&action=edit Bug 11912: (regression tests) GetMarcISBN wrongly prepends a space to ISBNs This patch makes the tests run in both MARC21 and UNIMARC contexts. It previously run only for MARC21. It mocks what needs to be mocked. To test, run - prove t/db_dependent/Biblio.t => Notice the first ISBN has a space in front of it and those tests fails. Thanks for any feedback To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 9 22:43:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Mar 2014 21:43:16 +0000 Subject: [Koha-bugs] [Bug 11912] GetMarcISBN wrongly prepends a space to ISBNs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11912 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 25969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25969&action=edit Bug 11912: GetMarcISBN wrongly prepends a space to ISBNs This patch makes the logic inside GetMarcISBN simpler and fixes the issue. To test: - Run the regression tests: prove -v t/db_dependent/Biblio.t => FAIL - Apply the patch - Run: prove -v t/db_dependent/Biblio.t => SUCCESS - Verify that opac-detail.pl and catalogue/detail.pl look as usual regarding ISBN - Sign off Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 01:41:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 00:41:42 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #38 from M. Tompsett --- I want to make sure I understand this. Let's say I enable patron self registration. And self registration puts them into BranchA. Let's say I mark BranchA as part of a group which also includes BranchB. Should not a patron with all staff permissions (not super librarian) in BranchB, be able to edit the patron which belongs to BranchA such that they are moved to BranchB? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 04:35:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 03:35:12 +0000 Subject: [Koha-bugs] [Bug 11913] New: Attributes generate error log during member entry Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11913 Bug ID: 11913 Summary: Attributes generate error log during member entry Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com SHOW_BCODE (or any other patron attribute) which is NULL will generate errors similar to: [Sun Mar 09 23:30:50 2014] [error] [client 192.168.45.23] [Sun Mar 9 23:30:50 2014] memberentry.pl: Use of uninitialized value $_ in hash element at /home/mtompset/kohaclone/members/memberentry.pl line 814. [Sun Mar 09 23:30:50 2014] [error] [client 192.168.45.23] [Sun Mar 9 23:30:50 2014] memberentry.pl: Use of uninitialized value in anonymous hash ({}) at /home/mtompset/kohaclone/members/memberentry.pl line 814. This is in part due to a poor way of copying the hash. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 04:37:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 03:37:28 +0000 Subject: [Koha-bugs] [Bug 11913] Attributes generate error log during member entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11913 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 04:37:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 03:37:30 +0000 Subject: [Koha-bugs] [Bug 11913] Attributes generate error log during member entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11913 --- Comment #1 from M. Tompsett --- Created attachment 25970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25970&action=edit Bug 11913 - Attributes generate error log during member entry In member/memberentry.pl, there were two lines like: my $newentry = { map { $_ => $entry->{$_} } %$entry }; These were in the 'sub patron_attributes_form'. They have been changed to: my $newentry = { %$entry }; Of course, indentation does not reflect actual indentation. They were discovered while testing another bug, which required editing a member record. TEST PLAN --------- 1) Make sure you have the SHOW_BCODE attribute. 2) Go edit a member. 3) Clear the SHOW_BCODE value. 4) Save. 5) Edit again. 6) Check the error log file. 7) apply patch. 8) Change the value for SHOW_BCODE (Yes/No) 9) Save. 10) Edit again. (tests change 1) 11) Clear the SHOW_BCODE 12) Save. 13) Edit again. (tests change 2) 14) Check the error log file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 04:38:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 03:38:31 +0000 Subject: [Koha-bugs] [Bug 11913] Attributes generate error log during member entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11913 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 04:38:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 03:38:37 +0000 Subject: [Koha-bugs] [Bug 11913] Attributes generate error log during member entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11913 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 08:54:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 07:54:52 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 08:54:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 07:54:56 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25756|0 |1 is obsolete| | Attachment #25757|0 |1 is obsolete| | --- Comment #11 from M. de Rooy --- Created attachment 25971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25971&action=edit Bug 8262: Special kohaadmin cannot create lists Since kohaadmin has no borrower number, it cannot create lists. A database error is logged, but the user is not notified. This patch alerts the user (kohaadmin). In the incidental case that a normal user gets a database error, he is notified too that the list could not be created. Test plan (for prog and bootstrap): This patch should be applied on top of 9032 patches. Login as kohaadmin. Create a list in opac and staff. Check the message. Login as a normal user. Force a database error on list creation (I renamed category in the table with alter table change column..) You should have a different error message. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 08:57:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 07:57:58 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 --- Comment #12 from M. de Rooy --- New patch includes the bootstrap change too now. Thanks Owen and Kyle for suggestions. Made the template varname generic and the error message dependent of loggedinuser. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 09:14:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 08:14:43 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11889 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 09:14:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 08:14:43 +0000 Subject: [Koha-bugs] [Bug 11889] Disown a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9032 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 09:24:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 08:24:37 +0000 Subject: [Koha-bugs] [Bug 11889] Disown a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #1 from M. de Rooy --- Please see bug 9032 also. One of the last patches on that report made Koha behavior consistent when deleting a list or deleting a patron. But what if we would like to keep public lists or shared lists when deleting a patron that owned these lists? We could add a syspref that controlled this. If enabled, we could allow owner NULL for public and shared lists if the patron is deleted, or if the patron deletes one of those lists. (Instead of the NULL value, we could also move them to a designated patron for this purpose.) In the attachment some code that shows what should go into HandleDelBorrower. Similar changes should be made to DelShelf. What do you think? Is this a welcome feature or is it confusing and should we just delete these lists? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 09:25:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 08:25:42 +0000 Subject: [Koha-bugs] [Bug 11889] Disown a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #2 from M. de Rooy --- Created attachment 25972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25972&action=edit Example code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 09:25:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 08:25:59 +0000 Subject: [Koha-bugs] [Bug 11889] Disown a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 09:26:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 08:26:00 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 --- Comment #28 from Jonathan Druart --- (In reply to Kyle M Hall from comment #27) > Signed-off-by: Kyle M Hall Do you finally agree with this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 09:51:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 08:51:48 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 09:51:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 08:51:52 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23092|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 25973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25973&action=edit Bug 11148: Two routines are useless in Koha::DateUtils There are 2 useless routines in the Koha::DateUtils module:output_pref_due and format_sqlduedatetime. We can call output_pref and format_datetime with dateonly = 0. format_sqlduedatetime is only used in one place: opac-reserve.pl Test plan: 1/ Verify on the opac-reserve.pl page that the date is correctly displayed for for onloan items (you should use the "specific copy" feature). 2/ Launch prove t/DateUtils.t UT file and verify all UT pass. Signed-off-by: Marcel de Rooy Due date on opac-reserve shown correctly. Unit tests pass. Did a grep on both function names. Signed-off-by: Kyle M Hall No references to subs found. Passes koha-qa.pl, t and xt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 09:51:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 08:51:57 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23253|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 25974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25974&action=edit Bug 11148: Add a as_due_date parameter to the output_pref routine This parameter is a boolean, if true, the hours won't be displayed if the time is 23:59 (24hr format) or 11:59 PM (12hr format). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 09:52:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 08:52:04 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24219|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 25975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25975&action=edit Bug 11148: Previous patch delete usefull unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 09:52:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 08:52:59 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 --- Comment #21 from Jonathan Druart --- Last patches fix conflicts with bug 11468. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 10:19:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 09:19:32 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer at bsz-bw.de |jonathan.druart at biblibre.co | |m QA Contact|koha.sekjal at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 10:36:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 09:36:15 +0000 Subject: [Koha-bugs] [Bug 11914] New: Ordering from suggestions: fund (budget id) is not retained; price calculations not working Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 Bug ID: 11914 Summary: Ordering from suggestions: fund (budget id) is not retained; price calculations not working Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: abl at biblos.pk.edu.pl QA Contact: testopia at bugs.koha-community.org When order is being created from purchase suggestion: - Budget/fund stored in suggestion record (if any) is not retained on order page, system always defaults to 'Select a fund' even if some fund was already chosen for a suggestion on the earlier stage. - If there was a price given to, and stored within suggestion record, initial prices calculations on order page are not working properly ('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank). As a workaround - to force correct price recalculation - user needs to manually alter and then re-alter some price-related fields (e.g, quantity or vendor price). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 10:57:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 09:57:09 +0000 Subject: [Koha-bugs] [Bug 11915] New: Need to still edit the title Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11915 Bug ID: 11915 Summary: Need to still edit the title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 10:57:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 09:57:19 +0000 Subject: [Koha-bugs] [Bug 11915] Need to still edit the title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11915 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:04:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:04:23 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:04:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:04:26 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25843|0 |1 is obsolete| | --- Comment #4 from Jesse Maseto --- Created attachment 25976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25976&action=edit [SIGNED-OFF] Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. Edit: Rebased on current master. Note that the change to opac-auth-detail.tt is because the page never has more than one tab, hence doesn't need the "active" designation. Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:06:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:06:05 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 --- Comment #5 from Jesse Maseto --- Created attachment 25977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25977&action=edit Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. Edit: Rebased on current master. Note that the change to opac-auth-detail.tt is because the page never has more than one tab, hence doesn't need the "active" designation. Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:06:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:06:55 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25977|0 |1 is obsolete| | CC| |jesse at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:07:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:07:07 +0000 Subject: [Koha-bugs] [Bug 11914] Ordering from suggestions: fund (budget id) is not retained; price calculations not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |abl at biblos.pk.edu.pl |ity.org | Severity|major |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:07:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:07:29 +0000 Subject: [Koha-bugs] [Bug 11914] Ordering from suggestions: fund (budget id) is not retained; price calculations not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 --- Comment #1 from Jacek Ablewicz --- Created attachment 25978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25978&action=edit Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working When order is being created from purchase suggestion: - Budget/fund stored in suggestion record (if any) is not retained on order page, system always defaults to 'Select a fund' even if some fund was already chosen for a suggestion on the earlier stage. - If there was a price given to, and stored within suggestion record, initial prices calculations on order page are not working properly ('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank). As a workaround - to force correct price recalculation - user needs to manually alter and then re-alter some price-related fields (e.g., quantity or vendor price). This patch fixes both issues. Test plan: 1) create a suggestion: choose some buget, enter something in 'Price' and 'Quantity' fields, 2) try to make an order from this suggestion, to confirm/replicate aforementioned problems, 3) apply patch, 4) make an order from previously created suggestion again, observe that both issues are now resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:08:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:08:14 +0000 Subject: [Koha-bugs] [Bug 11914] Ordering from suggestions: fund (budget id) is not retained; price calculations not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:15:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:15:36 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:18:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:18:36 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #45 from Zeno Tajoli --- This patch is on master but is not for tah actal stable version (3.14) because in fact is a new feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:26:04 +0000 Subject: [Koha-bugs] [Bug 11914] Ordering from suggestions: fund (budget id) is not retained; price calculations not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4833 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:26:04 +0000 Subject: [Koha-bugs] [Bug 4833] show all fields when ordering from suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11914 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:44:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:44:30 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #21 from Katrin Fischer --- Jonathan, I have a problem in the QA script I am not sure how to fix - could you take a look please? FAIL serials/serials-edit.pl OK pod OK forbidden patterns FAIL valid "my" variable $dbh masks earlier declaration in same scope OK critic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:44:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:44:49 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:52:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:52:12 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25236|0 |1 is obsolete| | --- Comment #36 from Jesse Weaver --- Created attachment 25979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25979&action=edit Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC This adds a new page to the OPAC that can search several Z39.50 targets using Pazpar2. Test plan: 1) Apply patches. 2) Update database. 3) Add one or more Z39.50 targets, using the Administration -> External targets screen. Note that not all targets support keyword search, but here are some that do: * Library of Congress: lx2.loc.gov, 210, LCDB, none, none, MARC21, UTF-8 * BNF2: z3950.bnf.fr, 2211, TOUT, Z3950, Z3950_BNF, UNIMARC, UTF-8 4) Perform a search on the OPAC, check to see if the "external targets" notice pops up at the top. 5) Click on the results link near that message. 6) This should bring back results from all enabled targets, all of which should be clickable to bring up a detailed view of the record. (Rebased version.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:52:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:52:34 +0000 Subject: [Koha-bugs] [Bug 11822] Show claimed serials on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11822 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jesse at bywatersolutions.com --- Comment #1 from Jesse Maseto --- I am unable to apply this patch. -Jesse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:58:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:58:13 +0000 Subject: [Koha-bugs] [Bug 11916] New: Borrower Imports Refactor/Rewrite Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11916 Bug ID: 11916 Summary: Borrower Imports Refactor/Rewrite Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The borrower imports script driving the staff client import tool has a large number of bugs attached to it to add features. I propose a refactor to aid in this work. I have been working on a brach to factor out the import code into a module, and add a new command line script under misc to enable regular background user imports. The git branch is available here: https://github.com/mrenvoize/Koha/tree/borrowerImports It is very much a work in progress, though allot of the base code is written. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 11:59:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 10:59:59 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 12:00:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 11:00:08 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20538|0 |1 is obsolete| | Attachment #24635|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 25980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25980&action=edit Bug 7677: UT: add unit tests for GetPreviousSerialid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 12:00:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 11:00:17 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #23 from Jonathan Druart --- Created attachment 25981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25981&action=edit BZ7677: New areas in subscriptions and new functions when receiving. When enabling the makePreviousSerialAvailable syspref, the previously received serial's itemtype is set as defined in the subscription. (Please note that the item-level_itypes syspref must be set to specific item.) It is also made available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 12:00:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 11:00:18 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 12:00:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 11:00:22 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25976|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 25982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25982&action=edit [PASSED QA] Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. Edit: Rebased on current master. Note that the change to opac-auth-detail.tt is because the page never has more than one tab, hence doesn't need the "active" designation. Signed-off-by: Jesse Maseto Signed-off-by: Katrin Fischer Tested in prog and bootstrap. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 12:00:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 11:00:23 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #24 from Jonathan Druart --- Created attachment 25983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25983&action=edit Bug 7677: FIX QA issues FAIL C4/Serials.pm FAIL forbidden patterns forbidden pattern: trailing space char (line 1501) forbidden pattern: trailing space char (line 921) FAIL serials/serials-edit.pl FAIL valid "my" variable $dbh masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 12:49:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 11:49:01 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24086|0 |1 is obsolete| | --- Comment #58 from Koha Team Lyon 3 --- Created attachment 25984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25984&action=edit Bug 9593 Prices not imported correctly from a staged file patch updated and rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 12:49:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 11:49:21 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:09:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:09:34 +0000 Subject: [Koha-bugs] [Bug 11802] Patron purchase suggestions page requires some corrections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11802 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:09:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:09:37 +0000 Subject: [Koha-bugs] [Bug 11802] Patron purchase suggestions page requires some corrections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11802 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25511|0 |1 is obsolete| | --- Comment #2 from Jesse Maseto --- Created attachment 25985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25985&action=edit [SIGNED-OFF] Bug 11802 - Patron purchase suggestions page requires some corrections This patch corrects some errors with the staff client's patron purchase suggestions page (members/purchase-suggestions.pl). To test, apply the patch and make sure the patronimages system preference is enabled. - View the purchase suggestions page for a patron whose record has a patron image attached. The image should appear in the left-hand sidebar. - View the page for a patron who has submitted no purchase suggestions. The message should be styled correctly. - The toolbar on the page should look correct and work correctly. Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:24:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:24:10 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25220|0 |1 is obsolete| | Attachment #25221|0 |1 is obsolete| | Attachment #25261|0 |1 is obsolete| | Attachment #25262|0 |1 is obsolete| | Attachment #25263|0 |1 is obsolete| | Attachment #25264|0 |1 is obsolete| | Attachment #25271|0 |1 is obsolete| | Attachment #25272|0 |1 is obsolete| | Attachment #25289|0 |1 is obsolete| | Attachment #25290|0 |1 is obsolete| | Attachment #25292|0 |1 is obsolete| | Attachment #25391|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 25986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25986&action=edit Bug 11703 - Convert checkouts table to ajax datatable When a patron has many checked out items, circulation.pl can take a very long time to load ( on the order of minutes in some cases ). This is primarily due to the processing of the previous checkouts list. If we convert to this table to a datatable that fetches its data via ajax, we can make circulation.pl far more responsive. The same should be done with relative's checkouts as well. Test Plan: 1) Apply this patch 2) Observe that the checkouts and relatives' checkouts tables are now loaded asynchronously 3) Observe and verify the renew and return actions are now ajax based and function in a manner equivilent to how they used to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:24:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:24:45 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:26:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:26:14 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #26 from Kyle M Hall --- Created attachment 25987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25987&action=edit Bug 11703 - Use the ajax datatables on patron details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:26:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:26:17 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #27 from Kyle M Hall --- Created attachment 25988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25988&action=edit Bug 11703 - Convert holds tables to ajax datatables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:26:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:26:19 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #28 from Kyle M Hall --- Created attachment 25989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25989&action=edit Bug 11703 [QA Followup 1] - Center bProcessing message over table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:26:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:26:23 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #29 from Kyle M Hall --- Created attachment 25990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25990&action=edit Bug 11703 [QA Followup 2] - Remove icons from checkout and clear buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:26:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:26:26 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #30 from Kyle M Hall --- Created attachment 25991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25991&action=edit Bug 11703 [QA Followup 3] - Remove references to UseTablesortForCirc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:26:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:26:29 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #31 from Kyle M Hall --- Created attachment 25992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25992&action=edit Bug 11703 [QA Followup 4] - Add back in Today's checkouts/Previous checkouts rows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:26:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:26:32 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #32 from Kyle M Hall --- Created attachment 25993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25993&action=edit Bug 11703 [QA Followup 5] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:26:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:26:35 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #33 from Kyle M Hall --- Created attachment 25994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25994&action=edit Bug 11703 [QA Followup 6] - Move strings to an include file for translation purposes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:26:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:26:39 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #34 from Kyle M Hall --- Created attachment 25995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25995&action=edit Bug 11703 [QA Followup 7] - Fix issues spotted by koha-qa.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:26:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:26:42 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #35 from Kyle M Hall --- Created attachment 25996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25996&action=edit Bug 11703 [QA Followup 8] - Speed up api/checkouts.pl as much as possible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:26:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:26:45 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #36 from Kyle M Hall --- Created attachment 25997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25997&action=edit Bug 11703 [QA Followup 9] - Move scripts from api directory to svc directory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:26:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:26:48 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #37 from Kyle M Hall --- Created attachment 25998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25998&action=edit Bug 11703 [QA Followup 10] - Fix errors caused by rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 13:50:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 12:50:21 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25998|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall --- Created attachment 25999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25999&action=edit Bug 11703 [QA Followup 10] - Fix errors caused by rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:10:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:10:12 +0000 Subject: [Koha-bugs] [Bug 11731] Typo "tranports" in installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11731 --- Comment #1 from Jesse Maseto --- Created attachment 26000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26000&action=edit Bug 11731 - Fixed typo in message_transport_types.txt file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:10:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:10:40 +0000 Subject: [Koha-bugs] [Bug 11731] Typo "tranports" in installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11731 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jesse at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:14:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:14:15 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 --- Comment #3 from Owen Leonard --- I had a similar problem with patron lists and was pointed to this: http://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_tarball#Tweaking_my.cnf Making that change fixed it for me. Is that the correct solution, or is that a stopgap for a problem we need to address globally? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:17:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:17:06 +0000 Subject: [Koha-bugs] [Bug 11802] Patron purchase suggestions page requires some corrections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:17:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:17:10 +0000 Subject: [Koha-bugs] [Bug 11802] Patron purchase suggestions page requires some corrections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25985|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 26001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26001&action=edit Bug 11802 - Patron purchase suggestions page requires some corrections This patch corrects some errors with the staff client's patron purchase suggestions page (members/purchase-suggestions.pl). To test, apply the patch and make sure the patronimages system preference is enabled. - View the purchase suggestions page for a patron whose record has a patron image attached. The image should appear in the left-hand sidebar. - View the page for a patron who has submitted no purchase suggestions. The message should be styled correctly. - The toolbar on the page should look correct and work correctly. Signed-off-by: Jesse Maseto Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:19:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:19:19 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #37 from Jesse Weaver --- Created attachment 26002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26002&action=edit Bug 10486 - QA followup: fix issues with pazpar2 configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:24:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:24:35 +0000 Subject: [Koha-bugs] [Bug 11917] New: upload patron image can raise a software error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11917 Bug ID: 11917 Summary: upload patron image can raise a software error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:25:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:25:09 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #4 from sandboxes at biblibre.com --- Patch tested with a sandbox, by juliette levast -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:25:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:25:18 +0000 Subject: [Koha-bugs] [Bug 11802] Patron purchase suggestions page requires some corrections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- While testing this patch, I found a bug on uploading a picture for a patron, see bug 11917. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:25:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:25:27 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25115|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:25:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:25:32 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25116|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:25:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:25:37 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25117|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:25:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:25:43 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #5 from sandboxes at biblibre.com --- Created attachment 26003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26003&action=edit Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:25:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:25:46 +0000 Subject: [Koha-bugs] [Bug 11917] upload patron image can raise a software error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11917 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:25:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:25:46 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #6 from sandboxes at biblibre.com --- Created attachment 26004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26004&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:25:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:25:49 +0000 Subject: [Koha-bugs] [Bug 11917] upload patron image can raise a software error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11917 --- Comment #1 from Jonathan Druart --- Created attachment 26005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26005&action=edit Bug 11917: upload image - catch error if cardnumber does not exist. On uploading a patron image, if the given cardnumber does not exist, a software error is raised DBD::mysql::st execute failed: Column 'borrowernumber' cannot be null at /home/koha/src/C4/Members.pm line 1916. Test plan: go on tools/picture-upload.pl, choose an image and put a cardnumber which does not exist in DB. With the patch, you should get a friendly error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:25:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:25:49 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 26006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26006&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:29:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:29:33 +0000 Subject: [Koha-bugs] [Bug 11695] Typo: "Tree-character alphabetic code" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11695 --- Comment #1 from Jesse Maseto --- Created attachment 26007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26007&action=edit Bug 11695 - FIxed typo in marc21_field_008.xml: "Tree-character alphabetic code", to "Three-character alphabetic code" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:29:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:29:52 +0000 Subject: [Koha-bugs] [Bug 11695] Typo: "Tree-character alphabetic code" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11695 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jesse at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:30:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:30:54 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Lemaire changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lemairesonia at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:31:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:31:03 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 --- Comment #4 from Tom?s Cohen Arazi --- (In reply to Owen Leonard from comment #3) > I had a similar problem with patron lists and was pointed to this: > > http://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_tarball#Tweaking_my.cnf > > Making that change fixed it for me. Is that the correct solution, or is that > a stopgap for a problem we need to address globally? If the problem is environment settings-related (having MySQL set correctly is a pre-requisite for running Koha), this bug should be marked as invalid. I can volunteer to write something to check MySQL configuration sanity so we can (at least) ask users reporting this problems to visit about > system check to see if there's any problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:32:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:32:05 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23270|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart --- Created attachment 26008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26008&action=edit Bug 7673 : New patron permissions This patch adds the following permissions: - editcatalogue.limited_item_edition: Limit item modification to barcode, status and note - editcatalogue.delete_all_items: Delete all items at once - tools.items_limited_batchmod: Limit batch item modification to item status The SubfieldsToAllowForLimitedEdition syspref is used to define which subfields can be edited when the editcatalogue.limited_item_edition permission is enabled. In the same way, the SubfieldsToAllowForLimitedBatchmod is used to define which subfields can be edited when the tools.items_limited_batchmod permission is enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:32:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:32:11 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23271|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart --- Created attachment 26009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26009&action=edit Bug 7673: QA Followup: trailing whitespace and perlcritic issues This patch fixes the following qa issues: FAIL cataloguing/additem.pl FAIL forbidden patterns forbidden pattern: trailing space char (line 833) FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). FAIL tools/batchMod.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:56:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:56:51 +0000 Subject: [Koha-bugs] [Bug 11866] Staff side course reserves too restrictive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11866 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:56:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:56:55 +0000 Subject: [Koha-bugs] [Bug 11866] Staff side course reserves too restrictive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11866 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25863|0 |1 is obsolete| | Attachment #25948|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 26010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26010&action=edit Bug 11866 - Staff side course reserves too restrictive A librarian with no course reserves permissions cannot view course reserves from the staff intranet, yet can from the OPAC. This doesn't make much sense. Librarians should not require any course reserves permissions to view courses and reserves from the staff intranet. Test Plan: 1) Log into staff intranet as a librarian with no course reserves permissions 2) Note you cannot view course reserves 3) Apply this patch 4) Note you can now view course reserves 5) Verify you cannot modify courses or course reserves Signed-off-by: Owen Leonard Bug 11866 [Follow-up] Staff side course reserves too restrictive This follow-up patch adds a check for the "UseCourseReserves" system preference to the display of the Course reserves menu item in the header. To test, view the "More" menu with the "UseCourseReserves" system preference on and off. The menu item should appear and disappear accordingly. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:57:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:57:03 +0000 Subject: [Koha-bugs] [Bug 11866] Staff side course reserves too restrictive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11866 --- Comment #7 from Jonathan Druart --- Created attachment 26011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26011&action=edit Bug 11866: FIX ergonomic issue If a user does not have course_reserve permission, a an empty toolbar is displayed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 14:58:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 13:58:04 +0000 Subject: [Koha-bugs] [Bug 11866] Staff side course reserves too restrictive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11866 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- I squashed 2 first patches for a better readability and submit a small fix for an ergonomic issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 15:33:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 14:33:18 +0000 Subject: [Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946 cedric.vita at dracenie.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cedric.vita at dracenie.com --- Comment #2 from cedric.vita at dracenie.com --- The patch applies. Test plan, the points 1 to 5 are OK but 6 still does not work. (messag: Sorry, plain view is temporarily unavailable.) (Test sandbox) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 15:36:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 14:36:27 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #9 from Owen Leonard --- QA issues: - The patch only changes prog, not bootstrap - "Call Number" is incorrectly capitalized. If we want to avoid custom XSLT the compromise would be to add markup and classes to the XSL so that the these snippets of text can be styled and/or hidden as desired: - Wrap the individual library lines in a span which can be made "display:block" in custom CSS. - Wrap the "cal number" text in a span which is hidden by default in the CSS. Use custom CSS to show it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 15:50:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 14:50:03 +0000 Subject: [Koha-bugs] [Bug 11866] Staff side course reserves too restrictive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11866 --- Comment #9 from Owen Leonard --- (In reply to Jonathan Druart from comment #7) > If a user does not have course_reserve permission, a an empty toolbar is > displayed. I think I fixed this in my patch for Bug 11713 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 15:51:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 14:51:56 +0000 Subject: [Koha-bugs] [Bug 11328] Show local cover images in staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 15:51:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 14:51:59 +0000 Subject: [Koha-bugs] [Bug 11328] Show local cover images in staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25681|0 |1 is obsolete| | --- Comment #5 from Brendan Gallagher --- Created attachment 26012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26012&action=edit [PASSED-QA] Bug 11328 - Show local cover images in staff client search results Local cover images do not appear in staff client search results. This patch adds them. To test, enable the LocalCoverImages system preference and add at least one cover image to a title. Perform a search which will return results that include your title. Confirm that the local cover image is displayed. Search results should also display correctly with and without AmazonCoverImages enabled as well as with LocalCoverImages disabled. Signed-off-by: wajasu Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 15:55:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 14:55:08 +0000 Subject: [Koha-bugs] [Bug 10090] the ordered and spent page display the itemtype code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #10 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Broust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 15:55:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 14:55:21 +0000 Subject: [Koha-bugs] [Bug 10090] the ordered and spent page display the itemtype code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19061|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 15:55:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 14:55:27 +0000 Subject: [Koha-bugs] [Bug 10090] the ordered and spent page display the itemtype code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090 --- Comment #11 from sandboxes at biblibre.com --- Created attachment 26013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26013&action=edit Bug 10090: Add itemtype description instead of code On ordered.pl and spent.pl, the itemtype codes are displayed, instead of descriptions. Links for the ordernumber should be changed. In ordered.pl, we are redirected to the receive page. In spent.pl, the links are deleted. Signed-off-by: Broust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 15:56:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 14:56:34 +0000 Subject: [Koha-bugs] [Bug 11860] Display subscription callnumber in OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11860 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25962|0 |1 is obsolete| | --- Comment #4 from Brendan Gallagher --- Created attachment 26014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26014&action=edit [PASSED-QA]Bug 11860: Display subscription callnumber in OPAC detail page Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 15:56:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 14:56:31 +0000 Subject: [Koha-bugs] [Bug 11860] Display subscription callnumber in OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11860 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:02:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:02:37 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #39 from Kyle M Hall --- Created attachment 26015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26015&action=edit Bug 10276 [QA Followup 3] - Fix inability to change patron's branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:03:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:03:20 +0000 Subject: [Koha-bugs] [Bug 11866] Staff side course reserves too restrictive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11866 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master, along with a follow-up that ensures that a user must have at least the 'catalogue' permission to view the staff-side page. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:05:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:05:19 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #31 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Joel Aloi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:05:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:05:39 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25821|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:05:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:05:48 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #32 from sandboxes at biblibre.com --- Created attachment 26016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26016&action=edit Bug 9366: On cataloguing each user can easily display tags or not If the syspref hide_marc is set to "don't display", tags are not shown by default. This patch adds a checkbox to hide/show tags directly on the cataloguing page. The value is stored in a cookie. Test plan: Enable/disable the sysprefs hide_marc and advancedMARCeditor in order to check if the display is according with what the user want. Reload the page and verify the value is kept. The first value of the cookie is retrieved from the hide_marc pref. Bonus: This patch removes the link "Show MARCtag documentation links" if the syspref advancedMARCeditor is enabled. Signed-off-by: Joel Aloi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:07:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:07:11 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #38 from Jesse Weaver --- Created attachment 26017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26017&action=edit Bug 10486 - QA followup: Remove given/when, update license and datatables QA script note: There are several failures related to [% interface %] versus opac-tmpl. According to a discussion with Owen Leonard on IRC, these can be ignored in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:11:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:11:00 +0000 Subject: [Koha-bugs] [Bug 11912] GetMarcISBN wrongly prepends a space to ISBNs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11912 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 26018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26018&action=edit Bug 11912: (refactoring followup) GetMarcISBN should implement its advertised API The current implementation of GetMarcISBN contradicts the documented API. It currently returns an array of hashes with only one key (marcisbn) which doesn't add any value to it. I chose to fix GetMarcISBN to honour the API instead of changing the docs, because it seems a really silly change. To test: - Run: prove t/db_dependent/Biblio.t => SUCCESS - catalogue/detail.pl should correctly show ISBNs. - opac/opac-detail.pl should correctly show ISBNs in both prog and bootstrap. - opac-opac-sendshelf.pl should correctly show ISBNs in the email. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:13:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:13:08 +0000 Subject: [Koha-bugs] [Bug 11802] Patron purchase suggestions page requires some corrections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11802 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:16:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:16:22 +0000 Subject: [Koha-bugs] [Bug 11912] GetMarcISBN wrongly prepends a space to ISBNs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11912 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26018|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 26019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26019&action=edit Bug 11912: (refactoring followup) GetMarcISBN should implement its advertised API The current implementation of GetMarcISBN contradicts the documented API. It currently returns an array of hashes with only one key (marcisbn) which doesn't add any value to it. I chose to fix GetMarcISBN to honour the API instead of changing the docs, because it seems a really silly change. To test: - Run: prove t/db_dependent/Biblio.t => SUCCESS - catalogue/detail.pl should correctly show ISBNs. - opac/opac-detail.pl should correctly show ISBNs in both prog and bootstrap. - opac-opac-sendshelf.pl should correctly show ISBNs in the email. - Sign off :-D Edit: forgot to git add some templates. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:18:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:18:07 +0000 Subject: [Koha-bugs] [Bug 11328] Show local cover images in staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11328 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:26:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:26:19 +0000 Subject: [Koha-bugs] [Bug 11860] Display subscription callnumber in OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11860 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master, along with a follow-up standardizing the labels on that page to be "call number" rather than "callnumber". Thanks, Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:27:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:27:06 +0000 Subject: [Koha-bugs] [Bug 11915] Extending the use of Koha/XSLT_Handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11915 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Need to still edit the |Extending the use of |title |Koha/XSLT_Handler -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:27:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:27:28 +0000 Subject: [Koha-bugs] [Bug 11915] Extending the use of Koha/XSLT_Handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11915 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11826 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:27:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:27:28 +0000 Subject: [Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11915 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:28:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:28:03 +0000 Subject: [Koha-bugs] [Bug 11915] Extending the use of Koha/XSLT_Handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11915 --- Comment #1 from M. de Rooy --- Using the Koha::XSLT_Handler in C4/XSLT.pm, showmarc and opac-showmarc, and Record.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:28:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:28:24 +0000 Subject: [Koha-bugs] [Bug 11915] Extending the use of Koha/XSLT_Handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11915 --- Comment #2 from M. de Rooy --- Created attachment 26020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26020&action=edit Bug 11915: Using the XSLT handler in C4/XSLT module Incorporate the new object into C4/XSLT module. The handler object needed one adjustment to allow for passing URLs. Removed the GetURI function; it is no longer needed. Added some documentation lines. Moved a file-level lexical upwards in the code for visibility. Removed some tabs (on two lines). Note: The handler could perhaps be moved up to the Context module, or be saved in a global ('our') variable. But I would rather not do that now, making testing not too complex at this moment. Test plan: Enable XSLT preferences for opac and intranet. Check result and detail pages. Check individual list display (virtual shelves). Force an XSLT error by editing one of your xsl files. Check the corresponding display. Put an URL in one the XSLT prefs (could just be to your own server). Check the display. Signed-off-by: Marcel de Rooy Running XSLTParse4Display in a loop showed no significant performance change. One pass cost me around 0.012 sec (except for the first pass). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:28:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:28:29 +0000 Subject: [Koha-bugs] [Bug 11915] Extending the use of Koha/XSLT_Handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11915 --- Comment #3 from M. de Rooy --- Created attachment 26021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26021&action=edit Bug 11915: Use xslt handler object in showmarc, Record.pm Modifies showmarc and opac-showmarc to use new xslt handler. Removes cardview.pl as obsolete script. Modifies C4/Record.pm and a typo in the test Record.t. Test plan: [1] catalogue/showmarc: Go to Cataloging. Search. Click Card. [2] opac-showmarc: Go to opac detail, MARC view. Open URL for plain view in new tab. Change URL: Change viewas=html to viewas=card [3] Verify that there are no references in the codebase to cardview.pl [4] C4/Record.pm: Run the Record.t test in db_dependent. This test uses marc2modsxml, triggering the change. Additional: export to MODS from opac-detail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:30:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:30:00 +0000 Subject: [Koha-bugs] [Bug 11915] Extending the use of Koha/XSLT_Handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11915 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from M. de Rooy --- Ready for signoff. Please have a look first at byg 11826 :) Note: oai.pl and unapi are still on my list.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:30:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:30:12 +0000 Subject: [Koha-bugs] [Bug 11794] opacSerialDefaultTab being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11794 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:38:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:38:39 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #25 from Koha Team AMU --- If we look at the Description http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677#c0 Points 0, 1, 3 and 4 are OK. But Point 2 KO. Nota : There's a link with BZ10855 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 because some new areas of the subscription must appear in the item record fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:43:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:43:04 +0000 Subject: [Koha-bugs] [Bug 11850] Bulkmarcimport does not append in logfile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25666|0 |1 is obsolete| | Attachment #25961|0 |1 is obsolete| | --- Comment #6 from Matthias Meusburger --- Created attachment 26022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26022&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:43:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:43:34 +0000 Subject: [Koha-bugs] [Bug 11850] Bulkmarcimport does not append in logfile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:43:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:43:57 +0000 Subject: [Koha-bugs] [Bug 11850] Bulkmarcimport does not append in logfile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 --- Comment #7 from Matthias Meusburger --- The new proposed patch adds a -append option to add to the logfile. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:50:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:50:45 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille at gmail.com --- Comment #114 from Koha Team AMU --- Before testing again this patch, would it be possible to include 2 observations : - koha should be able to combine both an authorized value and a marc value (995 for unimarc or 952 for marc21) for new fields (not only one of them) - koha should add the following condition: if "create an item record when receiving this serial" is selected in the subscription form, the value of the new subcription fields is duplicated in item record field (952 if marc21 952 or 995 if UNIMARC) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:52:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:52:04 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #58 from Galen Charlton --- Pushed to master, along with a tiny follow-up. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:54:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:54:40 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #115 from Koha Team AMU --- Caution : 10855 et 7677 should be compatible http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:57:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:57:09 +0000 Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #12 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Broust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:57:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:57:22 +0000 Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24113|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:57:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:57:28 +0000 Subject: [Koha-bugs] [Bug 11515] Encoding problem with OpacBrowseResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 --- Comment #13 from sandboxes at biblibre.com --- Created attachment 26023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26023&action=edit Bug 11515 - Encoding problem with OpacBrowseResults When OpacBrowseResults syspref is on, the detail page contains a results browser. When search terms contains non-ASCII character, the search query is not well encoded in this browser. This patch adds the URI-coding to search terms into session to avoid any encoding problem with diacritics and URI specific characters like ?,& ... So that TT parameter 'busc' is already URI encoded and can be used to recreate seach URL. Test plan : - Set OpacBrowseResults on - At OPAC, perform a search with a diacritique. For example 'd?j?' - Go to detail page of a result => You see browser under "Browser results" - Click on "Back to results" => You get same results and same search term with correct encoding Signed-off-by: Broust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 16:57:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 15:57:45 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #39 from Dobrica Pavlinusic --- This patch works for me well, but I dislike it's size: since code was moving from api to svc patch is very complex to review (I did read through it). I would prefer is we can squash it somewhat before it gets into master, but if nobody else objects on it I will sign it off as-is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:06:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:06:56 +0000 Subject: [Koha-bugs] [Bug 11587] IsSuperLibrarian generates warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:07:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:07:24 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 --- Comment #8 from Martin Renvoize --- Created attachment 26024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26024&action=edit [SIGNED OFF] Prevent local authentification fallback if an invalid LDAP password was entered. http://bugs.koha-community.org/show_bug.cgi?id=8148 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:07:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:07:27 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 --- Comment #9 from Martin Renvoize --- Created attachment 26025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26025&action=edit [SIGNED OFF] Only update the password if the LDAP password field was mapped. http://bugs.koha-community.org/show_bug.cgi?id=8148 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:07:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:07:50 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:08:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:08:14 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25523|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:08:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:08:30 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25522|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:09:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:09:51 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 --- Comment #10 from Martin Renvoize --- Works as expected for me, and code looks reasonable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:22:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:22:42 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25722|0 |1 is obsolete| | --- Comment #40 from M. Tompsett --- Created attachment 26026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26026&action=edit [SIGNED OFF] Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:22:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:22:57 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25723|0 |1 is obsolete| | --- Comment #41 from M. Tompsett --- Created attachment 26027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26027&action=edit [SIGNED OFF] Bug 10276i [QA Followup] - Extend IndependentBranches to support groups of libraries Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:23:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:23:11 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25724|0 |1 is obsolete| | --- Comment #42 from M. Tompsett --- Created attachment 26028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26028&action=edit [SIGNED OFF] Bug 10276i [QA Followup 2] - Remove stringify, use placeholders for db queries Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:23:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:23:26 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26015|0 |1 is obsolete| | --- Comment #43 from M. Tompsett --- Created attachment 26029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26029&action=edit [SIGNED OFF] Bug 10276 [QA Followup 3] - Fix inability to change patron's branch Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:34:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:34:06 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #44 from M. Tompsett --- TEST PLAN (I used) ------------------- 1) Back up DB 2) Drop the koha database, create a blank one. 3) Apply the patch 4) Run the koha qa test tool: koha-qa.pl -v 2 -c 4 5) Do the web install from the staff client (everything less patrons and branches). 6) Run the test: prove -v t/db_dependent/Branch.t 7) Log into Koha staff client with system user 8) Create three branches: BRA, BRB, BRC 9) Create an independent group: AB 10) Make sure BRA and BRB are in AB, but BRC is not. 11) Create two users: staff with everything checked and not super librarian, and patron. Put them in BRB and BRA respectively. 12) Change IndependentBranches to 'Prevent' (turn it on). 12) Log out of system user 13) Log in as staff user. 14) Can staff user find both himself and the other patron? -- this should be true 15) view the other patron, and edit -- this should be allowed, since BRB and BRA are in the same group. 16) move the patron from BRA into BRB and click save. -- this should work. 17) view the other patron, and edit 18) This time, move the patron to BRC and click save. -- this should work. It's bad to do, but it should work. 19) Try to find the other patron. -- this should be possible now, because BRC is not in group. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:38:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:38:12 +0000 Subject: [Koha-bugs] [Bug 11918] New: typo on authorized value page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11918 Bug ID: 11918 Summary: typo on authorized value page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org "... authorized value must to be displayed ..." (the word to needs to be removed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:39:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:39:30 +0000 Subject: [Koha-bugs] [Bug 11695] Typo: "Tree-character alphabetic code" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11695 --- Comment #2 from Owen Leonard --- Besides viewing the diff and confirming the correction is there more that needs to be done to test this? No test plan is provided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:39:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:39:59 +0000 Subject: [Koha-bugs] [Bug 11695] Typo: "Tree-character alphabetic code" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11695 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jesse at bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:41:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:41:09 +0000 Subject: [Koha-bugs] [Bug 11918] typo on authorized value page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11918 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:41:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:41:19 +0000 Subject: [Koha-bugs] [Bug 11918] typo on authorized value page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11918 --- Comment #1 from Nicole C. Engard --- Created attachment 26030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26030&action=edit [BUG 11918] Fix typo on authorized values This is a small string patch. On Authorized values this patch fixes the wording next to the library limit. To test: Visit Authorized Values Click 'Add new' or 'Edit' next to a value Make sure that the text next to the library filter is right -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:44:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:44:32 +0000 Subject: [Koha-bugs] [Bug 11695] Typo: "Tree-character alphabetic code" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11695 --- Comment #3 from Jesse Maseto --- Right. Just a confirmation that the typo has been corrected. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:47:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:47:56 +0000 Subject: [Koha-bugs] [Bug 11695] Typo: "Tree-character alphabetic code" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11695 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:48:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:48:01 +0000 Subject: [Koha-bugs] [Bug 11695] Typo: "Tree-character alphabetic code" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11695 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26007|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 26031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26031&action=edit [SIGNED-OFF] Bug 11695 - FIxed typo in marc21_field_008.xml: "Tree-character alphabetic code", to "Three-character alphabetic code" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:49:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:49:05 +0000 Subject: [Koha-bugs] [Bug 11224] C4::Acquisition need more UT, and more robust ones. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11224 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master, along with follow-ups to: - tidy the code - incorporate the test for bug 11777 - remove the unused bits from the UT for bug 10723 and mark the test that now checks the same functionality Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:52:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:52:54 +0000 Subject: [Koha-bugs] [Bug 9854] Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #4 from Galen Charlton --- Setting this to blocked until such time as 8375 passes QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:56:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:56:16 +0000 Subject: [Koha-bugs] [Bug 11713] Use new DataTables include in course reserves templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11713 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 17:56:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 16:56:19 +0000 Subject: [Koha-bugs] [Bug 11713] Use new DataTables include in course reserves templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11713 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25949|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 26032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26032&action=edit Bug 11713 - Use new DataTables include in course reserves templates This patch modifies two course reserves templates to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Also included: - Adds a sorting filter on the course reserves detail table to excluding articles from sorting. - Corrects the styling of toolbar buttons (buttons should have btn and btn-small classes). To test you must have UseCourseReserves enabled and have multiple existing courses, at least one of which should have items on reserve. 1. View the list of courses. Table sorting should work correctly. The "new course" button should look consistent with other staff client toolbar buttons. 2. View the list of reserves on a course. - Toolbar buttons should look consistent with other staff client toolbar buttons. - Sorting should work correctly, excluding sorting on the Edit, Remove, and "Other course reserves" columns. - Titles on reserve which begin with an article should be sorted correctly with article excluded - Test sorting with item-level_itypes on and off. - Test sorting using a patron whose permissions include various combinations of add_reserves and delete_reserves Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 18:00:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 17:00:36 +0000 Subject: [Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- In my test I get no listing of holdings at all on opac-MARCdetail.pl after applying the patch even though there are some items which should not be hidden. Also, is there a reason to leave in this commented-out line? #warn "subf:$i $sf_def->{kohafield} $sf_def->{lib} $subf[$i][0]"; # see errlog to learn the mappings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 18:03:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 17:03:46 +0000 Subject: [Koha-bugs] [Bug 11917] upload patron image can raise a software error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11917 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 18:05:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 17:05:42 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #265 from Rafal Kopaczka --- Created attachment 26033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26033&action=edit opac screen (In reply to Kyle M Hall from comment #260) > Thanks for letting me know! I've rolled the fixes for these 2 issues into > the main patch set since they are still not signed off, rather than post a > qa followup. There are still issues with different currencies in "Amount to pay:" box. Previous is fixed, so there are new bugs :) 1/ For EUR and many other currencies, decimal separator is comma not dot. When page is loaded everything looks fine, but after any checkbox change, when amount is recalculated by javascript decimal part is cut off. Also for PLN, initial value in amount to pay box is ended with "PLN" chars. 2/ Not bug, but it would be nice to display title for manual created invoice, of course when barcode is filled. Now on Pay Fines page, only description and notes for manual fines are displayed. 3/ In OPAC: after expanding payment details there are many undefined value, I'm not sure if this should be empty or values aren't fetched properly? I'll attach some screens if something is unclear :) Nb. UTF-8 encoding from screens is IIRC, some other bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 18:08:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 17:08:51 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #266 from Rafal Kopaczka --- Created attachment 26034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26034&action=edit Pay Fines Well, sum for decimal didn't go well... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 18:11:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 17:11:31 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #267 from Rafal Kopaczka --- Created attachment 26035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26035&action=edit Currencies Different separators, for currencies. BTW is it possible to upload multiple attachment by 1 message? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 18:14:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 17:14:39 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26034|0 |1 is obsolete| | --- Comment #268 from Rafal Kopaczka --- Created attachment 26036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26036&action=edit Pay Fines (In reply to Rafal Kopaczka from comment #266) > Created attachment 26034 [details] > Pay Fines > > Well, sum for decimal didn't go well... better content type :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 18:16:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 17:16:51 +0000 Subject: [Koha-bugs] [Bug 11917] upload patron image can raise a software error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11917 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- I'm not sure if I'm doing something wrong, but I get the same results before and after the patch. I see a warning box that says "Patron image failed to upload." In the table of results I see "ERROR: Image not imported because the database returned an error. Please refer to the error log for more details." I'm not sure what this patch is supposed to change, but I wonder if we able to make the error message specific? Something about the card number not being found? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 18:18:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 17:18:58 +0000 Subject: [Koha-bugs] [Bug 11731] Typo "tranports" in installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11731 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jesse at bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 18:27:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 17:27:18 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #10 from Nicole C. Engard --- What did I do wrong? nengard at kohavm:~/kohaclone$ git bz apply 11699 Bug 11699 - notes entered when receiving are not saved 25900 - [SIGNED OFF] Bug 11699: Notes entered when receiving are not saved 25901 - [SIGNED OFF] Bug 11699: ModReceiveOrder should take a hashref in parameter Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11699: Notes entered when receiving are not saved Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Acquisition.pm Auto-merging t/db_dependent/Acquisition.t CONFLICT (content): Merge conflict in t/db_dependent/Acquisition.t Failed to merge in the changes. Patch failed at 0001 Bug 11699: Notes entered when receiving are not saved When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/SIGNED-OFF-Bug-11699-Notes-entered-when-receiving--I7IJ4M.patch nengard at kohavm:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 18:50:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 17:50:08 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #69 from Galen Charlton --- Pushed to master. Thanks, Julian and Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 18:57:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 17:57:34 +0000 Subject: [Koha-bugs] [Bug 10415] Add course reserves to staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10415 --- Comment #3 from Galen Charlton --- (In reply to Nicole C. Engard from comment #2) > I vote : > > http://thenounproject.com/noun/stack-of-books/#icon-No11494 I vote for this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 18:58:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 17:58:16 +0000 Subject: [Koha-bugs] [Bug 11713] Use new DataTables include in course reserves templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11713 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 19:20:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 18:20:47 +0000 Subject: [Koha-bugs] [Bug 11919] New: staff should be able to place (and capture) holds on items that cannot fill hold requests for patrons Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11919 Bug ID: 11919 Summary: staff should be able to place (and capture) holds on items that cannot fill hold requests for patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The discussion in bug 10452 pointed out that there are cases (such as damaged items) where staff members may want to be able to place and capture holds on items that would not fill hold requests for patrons. Examples of various degrees of plausibility include: - tech services staff wanting to place holds on damaged items in order to bring them back home for repair. - tech services staff wanting to claim lost and missing items that happen to come back - ditto for withdrawn items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 19:21:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 18:21:11 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, Kyle! I've opened bug 11919 for the topic of handling staff-generated holds on items that shouldn't fill hold requests for patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 19:47:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 18:47:50 +0000 Subject: [Koha-bugs] [Bug 10955] Add ability to skip deletions in zebraqueue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Kyle! If the underlying issue in zebraidx never gets resolved, I think a better course for us in the long run is to introduce a soft-deletion mechanism -- basically, something like the current OPAC suppression mechanism, but which marks records as being logically deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 20:08:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 19:08:00 +0000 Subject: [Koha-bugs] [Bug 11555] Make "All" one of the default options for datatables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11555 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 20:08:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 19:08:35 +0000 Subject: [Koha-bugs] [Bug 11605] DT: default entry is 20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11605 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- Pushed to master, along with a follow-up that extends the defaults to the new staged MARC record management table. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 20:22:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 19:22:48 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 20:43:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 19:43:17 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #28 from Galen Charlton --- Comment on attachment 22817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22817 Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Review of attachment 22817: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7802&attachment=22817) ----------------------------------------------------------------- ::: C4/Koha.pm @@ +1431,4 @@ > # Fall through... we also return a random quote as a catch-all if all else fails > } > else { > + $query = 'SELECT * FROM quotes WHERE timestamp LIKE CONCAT(CAST(now() AS date),\'%\') ORDER BY timestamp DESC LIMIT 0,1'; Ironically, PostgreSQL will happily accept CURRENT_DATE (without the parentheses). It won't accept "LIMIT 0,1". It also won't like trying to compare a timestamp to a string datatype. Closer to the mark (as in, I've actually tested this on both MariaDB and Pg is "select * from quotes where cast(now() as date) = cast(timestamp as date) limit 1 offset 0;" A broader point: I don't think that the point should be to search-and-replace fragments of non-portable SQL. Actually ensuring that the output is portable would be more on target. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 20:45:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 19:45:10 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #29 from Galen Charlton --- Comment on attachment 22816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22816 Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Review of attachment 22816: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7802&attachment=22816) ----------------------------------------------------------------- ::: misc/cronjobs/longoverdue.pl @@ +130,5 @@ > SELECT items.itemnumber, borrowernumber, date_due > FROM issues, items > WHERE items.itemnumber = issues.itemnumber > + AND DATE_SUB(CAST(now() AS date), INTERVAL ? DAY) > date_due > + AND DATE_SUB(CAST(now() AS date), INTERVAL ? DAY) <= date_due DATE_SUB() is not portable to PostgreSQL. As implied by my previous comment, I'm much more interested in seeing patches that provably improve portability of the SQL, not ones that just search-and-replace. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 20:48:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 19:48:33 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt at gmail.com --- Comment #30 from Galen Charlton --- (In reply to Jonathan Druart from comment #16) > I don't have the time to provide unit tests for all modified routines. And I don't have the inclination to push a patch series that touches a bunch of routines without adequate test coverage, particularly (as my two immediately previous comments indicate) as it includes at least one case where it has the effective of making it harder to tell that a particular SQL statement is not portable. Setting to failed QA. Feel free to resubmit a partial patch that covers routines that have test cases, and feel free to write UTs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 20:54:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 19:54:52 +0000 Subject: [Koha-bugs] [Bug 11170] The pending order list should only display orders to receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 --- Comment #6 from Galen Charlton --- Comment on attachment 23728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23728 Bug 11170: The pending order list should only display orders to receive Review of attachment 23728: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11170&attachment=23728) ----------------------------------------------------------------- Failing on account of the lack of documentation and unit test coverage for the new parameter to SearchOrders(). ::: C4/Acquisition.pm @@ +1665,4 @@ > my $basketgroupname = $params->{basketgroupname}; > my $owner = $params->{owner}; > my $pending = $params->{pending}; > + my $ordered = $params->{ordered}; There is neither POD nor unit test coverage of this new option. @@ +1695,5 @@ > + $query .= q{ AND (quantity > quantityreceived OR quantityreceived is NULL)}; > + } > + if ( $ordered ) { > + $query .= q{ AND (quantity > quantityreceived OR quantityreceived is NULL)} > + unless $pending; The logic here is unnecessarily convoluted. Please restructure so that only one Boolean test controls whether the "AND (quantity > quantityreceived OR quantityreceived is NULL)" clause gets added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 20:55:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 19:55:00 +0000 Subject: [Koha-bugs] [Bug 11170] The pending order list should only display orders to receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 20:55:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 19:55:15 +0000 Subject: [Koha-bugs] [Bug 11875] URL is poorly formed when searching on authid for author In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11875 --- Comment #2 from Joy Nelson --- Hi Katrin- Yes, I did check this. It is a clean install and I loaded bibs and authorities. I then linked the two using the linker script. I see the 100$9 contains the correct authid for the authority record. When I hover on the magnifying glass the url encapsulates the authid in quotes which when clicked fails (404). Thanks, joy (In reply to Katrin Fischer from comment #1) > Hi Joy, did you check a matching authority exists? The links from the > magnifying glasses work fine for me, as long as I have a matching authority. > Only when there is no matching authority for the id i get the 404. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 21:12:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 20:12:15 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #11 from M. Tompsett --- I blame bug 11224. Though, I haven't honestly confirmed that to be the problem point, but it looks like it without checking. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 21:20:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 20:20:56 +0000 Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 --- Comment #14 from Galen Charlton --- Comment on attachment 23815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23815 [PASSED QA] Bug 7288: Allow to display only subscriptions in the invoices table Review of attachment 23815: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7288&attachment=23815) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +2504,4 @@ > my $dbh = C4::Context->dbh; > my $query = qq{ > SELECT aqinvoices.*, aqbooksellers.name AS suppliername, > + aqorders.subscriptionid, This does not handle the case where a single invoice has more than one order with a subscription very well. In particular, only one subscription would (arbitrarily) be displayed. If the goal is to be able to link to all subscriptions on a given invoice, it's not sufficient to display just one. If the goal is more simply to just be able to filter the invoice search for invoices that have one or more subscriptions, then it would be better calculate a Boolean flag. Either way, as the patch stands now it is likely to cause confusion for libraries that have invoices that cover multiple subscriptions -- which is very, very common in the US, at least. Failing QA. When you resubmit, I would also appreciate if you wrote a unit test for the change in the core routine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 21:21:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 20:21:05 +0000 Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 21:23:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 20:23:21 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #45 from M. Tompsett --- Oops... this should NOT be possible now, because BRC is not in group. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 21:27:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 20:27:17 +0000 Subject: [Koha-bugs] [Bug 11359] Add cardnumber and phonenumber columns to the branch overdues circulation report. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11359 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Fr?d?rick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 21:41:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 20:41:35 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #43 from Galen Charlton --- Comment on attachment 23928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23928 [PASSED QA] Bug 8773 - Start per-instance koha-index-daemon in .deb setup Review of attachment 23928: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8773&attachment=23928) ----------------------------------------------------------------- ::: debian/koha-common.default @@ +4,5 @@ > + > +# If you want to use the koha-index-daemon script that is part of the > +# Koha::Contrib::Tamil package instead of the cronjob, set USE_INDEXER_DAEMON > +# to "yes". More information can be found here: > +# http://wiki.koha-community.org/wiki/PackagesIndexDaemon The Tamil indexer is not part of Koha core, and given that bugs 11078 and 6435 have been pushed, the indexer that /is/ is core can now act as a respectable daemon. Consequently, I'm not inclined to push this as is. Please resubmit a version that uses rebuild_zebra.pl as the default indexer. Setting to in discussion, but I will need a very good reason to budge on sticking with rebuild_zebra.pl -daemon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 21:41:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 20:41:44 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 21:44:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 20:44:39 +0000 Subject: [Koha-bugs] [Bug 11680] tax rate changes on edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11680 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- Im confused by the last 2 comments, is this ready for signoff? Or should it be in discussion? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 21:46:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 20:46:23 +0000 Subject: [Koha-bugs] [Bug 11914] Ordering from suggestions: fund (budget id) is not retained; price calculations not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 21:46:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 20:46:26 +0000 Subject: [Koha-bugs] [Bug 11914] Ordering from suggestions: fund (budget id) is not retained; price calculations not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25978|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 26037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26037&action=edit Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working When order is being created from purchase suggestion: - Budget/fund stored in suggestion record (if any) is not retained on order page, system always defaults to 'Select a fund' even if some fund was already chosen for a suggestion on the earlier stage. - If there was a price given to, and stored within suggestion record, initial prices calculations on order page are not working properly ('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank). As a workaround - to force correct price recalculation - user needs to manually alter and then re-alter some price-related fields (e.g., quantity or vendor price). This patch fixes both issues. Test plan: 1) create a suggestion: choose some buget, enter something in 'Price' and 'Quantity' fields, 2) try to make an order from this suggestion, to confirm/replicate aforementioned problems, 3) apply patch, 4) make an order from previously created suggestion again, observe that both issues are now resolved. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 22:04:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 21:04:38 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #19 from Galen Charlton --- Comment on attachment 25905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25905 Bug 766: Create a plugin routine to build dropdown list Review of attachment 25905: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=766&attachment=25905) ----------------------------------------------------------------- I can't say I quite like this approach, as, well, it prevents customization in the templates by embedding HTML in the code. :) I think a Template Toolkit include that accepts parameters would be better. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 22:16:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 21:16:24 +0000 Subject: [Koha-bugs] [Bug 3445] action_logs table needs some thought In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3445 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 22:17:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 21:17:57 +0000 Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- Setting to blocked until such time as bug 10807 passes QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 22:18:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 21:18:07 +0000 Subject: [Koha-bugs] [Bug 11731] Typo "tranports" in installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11731 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 22:18:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 21:18:11 +0000 Subject: [Koha-bugs] [Bug 11731] Typo "tranports" in installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11731 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26000|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 26038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26038&action=edit Bug 11731 - Fixed typo in message_transport_types.txt file. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 22:32:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 21:32:15 +0000 Subject: [Koha-bugs] [Bug 11516] OPAC highlight lost in results browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Fridolin! I should point out one edit in particular I made to the commit message: I removed the statement that highlighting does not work when using XSLT -- it works for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 22:41:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 21:41:27 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt at gmail.com --- Comment #55 from Galen Charlton --- Think on the name of the sysprefs: HighlightedStopWords. A user could be excused for thinking that it was the name of stopwords that /should/ be highlighted. So could a developer maintaining this in the future. WordsNotToHighlightInSearchResults is closer to the mark, although I'm open to a less verbose way of saying it. In any event, please resubmit with a better name. I have no other serious objection to the patch, though if you think of searching for titles like "Harry potter and the goblet of fire", I don't really consider it much of a win. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 22:47:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 21:47:27 +0000 Subject: [Koha-bugs] [Bug 11465] Show counts and amounts on OPAC your summary tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11465 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 23:04:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 22:04:54 +0000 Subject: [Koha-bugs] [Bug 11920] New: staff pages should default to requiring "catalogue" permission Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11920 Bug ID: 11920 Summary: staff pages should default to requiring "catalogue" permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org To reduce the risk of issues like the oversight repaired by commit e9903d7 [1], get_template_and_user() should be modified so that if flagsrequired is not supplied, permissions should default to { catalogue => 1 } when the type is "intranet". [1] http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e9903d760e41410bf871053ccccf00c3a037862d -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 23:08:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 22:08:50 +0000 Subject: [Koha-bugs] [Bug 11921] New: memcached configuration should be moved back to koha-conf.xml Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 Bug ID: 11921 Summary: memcached configuration should be moved back to koha-conf.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org The configuration settings for specifying the memcached server should be moved back to koha-conf.xml. The current scheme of passing that information via an environment variable breaks badly on Plack without requiring significant machinations -- and if you're using Plack, there is no need to cache the base Koha configuration information in memcached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 23:13:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 22:13:16 +0000 Subject: [Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #1 from Chris Cormack --- I agree totally, the config file is a much more logical place to have this. It would allow command line scripts and cron jobs to also make use of caching. Not only plack. With Koha::Cache we are able to make use of a lot of caching mechanism, not just memcached, having examples of these commented out in the koha-conf.xml would make it much easier for others to use them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 23:17:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 22:17:33 +0000 Subject: [Koha-bugs] [Bug 11647] Subscribe to email notification for serials needs user login In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 --- Comment #4 from Sophie MEYNIEUX --- Created attachment 26041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26041&action=edit Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list To test : 1) Search for a subscription with patron notification active 2) If you're not logged in, a message warns you that you must log in to subscribe to notification on new issues 3) If you log in, and have not yet subscribed to this routing list, you've got a link to subscribe 4) once you have subscribed, you've got a ling to unsubscribe 5) if you log out, you've got a message saying you must log in to subscribe 6) if you log in with another user, you've got the link to subscribe or unsubscribe depending on if he has already subscribed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 23:19:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 22:19:18 +0000 Subject: [Koha-bugs] [Bug 11647] Subscribe to email notification for serials needs user login In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Sophie MEYNIEUX --- Add a follow up to deal with Katrin objection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 23:24:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 22:24:45 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #37 from Chris Cormack --- (In reply to Kyle M Hall from comment #29) > While I agree that we should try to add unit tests, these patches do not add > any new perl subroutines. There are many existing modules that do not have > unit tests. > > > Also unit tests are required. Course you said that as a developer who didn't want to write tests, not a member of the QA team eh ? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 10 23:25:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 22:25:59 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Galen Charlton --- I think it is stretching just a bit too far to have 1 out of six patches being signed off resulting in an overall bug status of signed off. Also, follow-up 5 doesn't seem to apply. More to the point, the collections.colbranchcode column is too narrow. It should be varchar(10) and a FK linking to the branches table. Failing QA on that basis; I further request that you change the status to needs signoff, not signed off, when you submit a follow-up. Also, given the age of the original code and the fact that it has not be in general use, there's even more call to write unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 00:19:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 23:19:29 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Galen Charlton --- Pushed to master, along with a follow-up that keeps the caching of the DB driver code within the object, not the package. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 00:19:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Mar 2014 23:19:43 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 --- Comment #21 from Galen Charlton --- Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 04:48:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 03:48:09 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 04:48:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 03:48:26 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25600|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 04:48:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 03:48:31 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25619|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 04:48:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 03:48:37 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 26042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26042&action=edit Bug 11719 - Use new DataTables include in serials templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all serials-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Serials search results (serials/serials-search.pl): Perform a search which will return more than one subscription. The expiration date column is now sorted using the "title-string" filter for sorting based on the unformatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. - Serials collection (serials/serials-collection.pl): View the serial colection page for an existing subscription. The table of issues should be sorted correctly. - Serial claims (serials/claims.pl): The "since" and "claim date" columns have been modified to use the title-string filter for sorting based on the unformatted date. C4::Serials.pm::GetLateOrMissingIssues has been modified to pass an unformatted date along with the formatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. Signed-off-by: Aleisha Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 04:48:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 03:48:41 +0000 Subject: [Koha-bugs] [Bug 11719] Use new DataTables include in serials templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11719 --- Comment #8 from sandboxes at biblibre.com --- Created attachment 26043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26043&action=edit Bug 11719 [Follow-up] Use new DataTables include in serials templates This patch corrects column sorting configuration to avoid an error when sorting on the call number column. Also changed: removed obsolete UK sort mention. To test, search for serial subscriptions. Test sorting on all columns in the results table with and without the RoutingSerials preference enabled. Sorting should work correctly without error. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 05:17:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 04:17:30 +0000 Subject: [Koha-bugs] [Bug 11918] typo on authorized value page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11918 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26030|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 26044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26044&action=edit Bug 11918 : Fix typo on authorized values This is a small string patch. On Authorized values this patch fixes the wording next to the library limit. To test: Visit Authorized Values Click 'Add new' or 'Edit' next to a value Make sure that the text next to the library filter is right -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 05:22:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 04:22:10 +0000 Subject: [Koha-bugs] [Bug 11918] typo on authorized value page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11918 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #3 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 05:22:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 04:22:23 +0000 Subject: [Koha-bugs] [Bug 11918] typo on authorized value page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11918 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26044|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 05:22:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 04:22:29 +0000 Subject: [Koha-bugs] [Bug 11918] typo on authorized value page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11918 --- Comment #4 from sandboxes at biblibre.com --- Created attachment 26045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26045&action=edit Bug 11918 : Fix typo on authorized values This is a small string patch. On Authorized values this patch fixes the wording next to the library limit. To test: Visit Authorized Values Click 'Add new' or 'Edit' next to a value Make sure that the text next to the library filter is right Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 05:47:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 04:47:19 +0000 Subject: [Koha-bugs] [Bug 11869] Add more informations to the member printing pages. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia at hotmail.com --- Comment #8 from Aleisha Amohia --- The 'print summary' part works. The 'print slip' part says it should show an address but doesn't, however an address shows in 'print summary'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 08:49:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 07:49:17 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #12 from mathieu saby --- See also bug 9416 Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 08:50:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 07:50:06 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #13 from mathieu saby --- And see also bug 10928 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 08:50:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 07:50:55 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #14 from mathieu saby --- the last one is probably a duplicate. I thought the issue was fixed, but it is probably not the case Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:08:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:08:21 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:13:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:13:31 +0000 Subject: [Koha-bugs] [Bug 11917] upload patron image can raise a software error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11917 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:13:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:13:36 +0000 Subject: [Koha-bugs] [Bug 11917] upload patron image can raise a software error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11917 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26005|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 26046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26046&action=edit Bug 11917: upload image - catch error if cardnumber does not exist. On uploading a patron image, if the given cardnumber does not exist, a software error is raised DBD::mysql::st execute failed: Column 'borrowernumber' cannot be null at /home/koha/src/C4/Members.pm line 1916. Test plan: SET DEBUG=1 in your apache configuration go on tools/picture-upload.pl, choose an image and put a cardnumber which does not exist in DB. With the patch, you should get a friendly error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:15:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:15:17 +0000 Subject: [Koha-bugs] [Bug 11917] upload patron image can raise a software error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11917 --- Comment #4 from Jonathan Druart --- It appends when DEBUG=0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:32:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:32:30 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #116 from Jonathan Druart --- (In reply to Koha Team AMU from comment #115) > Caution : 10855 et 7677 should be compatible > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 No I disagree, in a first time this feature can be pushed as it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:42:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:42:40 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25594|0 |1 is obsolete| | --- Comment #7 from Magnus Enger --- Created attachment 26047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26047&action=edit Bug 11352 - Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete Batch patron deletion/anonymization tool has some issues: 1) If 'dateformat' setting in I18N/L10N system preferences is set to anything other then 'iso' (eg. 'metric'), bulk deletion when using 'expiration date is before' criterion is not working properly. Date entered in this field will be efectivelly ignored (or possibly sometimes wrongly interpreted as different date, in other format) on the final patron deletion stage. This may result in deleting (or moving to trash) more borrower records then intended. 2) Bulk/batch patron deletion should skip borrowers with nonzero account balance (ones with oustanding fines or credits) 3) This tool shouldn't offer to choose as deletion criterion those patron categories which have category_type set to 'S' (= staff patron categories) This patch fixes abovementioned problems. It also adds an option to "test run" patron batch deletion, and makes this option the default choice in "warning" stage. Test plan: - prepare test database with some patron records (at least 2, the more the better) set up in such a way that they will be vulnerable to issues 1 & 2 - confirm issues 1,2 - restore test database - apply patch - ensure issues 1 & 2 are no longer present - first by using new "test run" option: for #1, record counts in "warning" stage and "final" stage should be now the same; for #2, observe that patron records with nonzero balance are now excluded from deletion - redo the tests, this time choosing "delete permanently" and "move to trash" instead of "test run" - test #3 by changing "Category type" to "S" in some test patron categories - after that, those categories should no longer be choosable as deletion criteria. Signed-off-by: Magnus Enger Tested with dateformat = dd/mm/yyyy. I tested with two expired patrons, one with fines and one without. Before the patch a lot of unexpected patrons were deleted along with the expected ones. After applying the patch only the expired patron was deleted, not the one with fines. The test run and the "real" run reported correct numbers. The patch also makes sure no patron categories with category_type = S are suggested for batch deletion. Note: The ergonomics of the "Batch delete/anonymize" tool is hardly optimal, but this patch fixes a real, data-loosing bug, so let's deal with the ergonomics later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:44:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:44:06 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:49:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:49:05 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 francois.pichenot at ovh.fr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |francois.pichenot at ovh.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:50:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:50:12 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 francois.pichenot at ovh.fr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |francois.pichenot at ovh.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:55:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:55:25 +0000 Subject: [Koha-bugs] [Bug 11918] typo on authorized value page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11918 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:55:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:55:29 +0000 Subject: [Koha-bugs] [Bug 11918] typo on authorized value page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11918 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26045|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 26048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26048&action=edit [PASSED QA] Bug 11918 : Fix typo on authorized values This is a small string patch. On Authorized values this patch fixes the wording next to the library limit. To test: Visit Authorized Values Click 'Add new' or 'Edit' next to a value Make sure that the text next to the library filter is right Signed-off-by: Aleisha Signed-off-by: Katrin Fischer Text change, works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:55:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:55:41 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #40 from Dobrica Pavlinusic --- Aside from cosmetic notes, I have funny smell about this patch. When I open the page, I can see 6 ajax requests which seem to return same JSON data. First three of them return 302 and other three return 200. However, only difference is in sEcho parameter for which I can't find use in code itself. My worry is that we are creating too much unneeded requests to the server. Below are relevant lines from access log: 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET /cgi-bin/koha/svc/checkouts.pl?sEcho=1&iColumns=12&sColumns=&iDisplayStart=0&iDisplayLength=-1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3=itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnumber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10=function&mDataProp_11=function&sSearch=&bRegex=false&sSearch_0=&bRegex_0=false&bSearchable_0=true&sSearch_1=&bRegex_1=false&bSearchable_1=true&sSearch_2=&bRegex_2=false&bSearchable_2=true&sSearch_3=&bRegex_3=false&bSearchable_3=true&sSearch_4=&bRegex_4=false&bSearchable_4=true&sSearch_5=&bRegex_5=false&bSearchable_5=true&sSearch_6=&bRegex_6=false&bSearchable_6=true&sSearch_7=&bRegex_7=false&bSearchable_7=true&sSearch_8=&bRegex_8=false&bSearchable_8=true&sSearch_9=&bRegex_9=false&bSearchable_9=true&sSearch_10=&bRegex_10=false&bSearchable_10=true&sSearch_11=&bRegex_11=false&bSearchable_11=true&iSortCol_0=0&sSortDir_0=desc&iSortingCols=1&bSortable_0=true&bSorta ble_1=tr ue&bSortable_2=true&bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=true&bSortable_7=false&bSortable_8=false&bSortable_9=false&bSortable_10=false&bSortable_11=false&borrowernumber=1 HTTP/1.1" 302 558 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET /cgi-bin/koha/svc/checkouts.pl?sEcho=2&iColumns=12&sColumns=&iDisplayStart=0&iDisplayLength=-1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3=itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnumber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10=function&mDataProp_11=function&sSearch=&bRegex=false&sSearch_0=&bRegex_0=false&bSearchable_0=true&sSearch_1=&bRegex_1=false&bSearchable_1=true&sSearch_2=&bRegex_2=false&bSearchable_2=true&sSearch_3=&bRegex_3=false&bSearchable_3=true&sSearch_4=&bRegex_4=false&bSearchable_4=true&sSearch_5=&bRegex_5=false&bSearchable_5=true&sSearch_6=&bRegex_6=false&bSearchable_6=true&sSearch_7=&bRegex_7=false&bSearchable_7=true&sSearch_8=&bRegex_8=false&bSearchable_8=true&sSearch_9=&bRegex_9=false&bSearchable_9=true&sSearch_10=&bRegex_10=false&bSearchable_10=true&sSearch_11=&bRegex_11=false&bSearchable_11=true&iSortCol_0=0&sSortDir_0=desc&iSortingCols=1&bSortable_0=true&bSorta ble_1=tr ue&bSortable_2=true&bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=true&bSortable_7=false&bSortable_8=false&bSortable_9=false&bSortable_10=false&bSortable_11=false&borrowernumber=1 HTTP/1.1" 302 558 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET /cgi-bin/koha/svc/checkouts.pl?sEcho=3&iColumns=12&sColumns=&iDisplayStart=0&iDisplayLength=-1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3=itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnumber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10=function&mDataProp_11=function&sSearch=&bRegex=false&sSearch_0=&bRegex_0=false&bSearchable_0=true&sSearch_1=&bRegex_1=false&bSearchable_1=true&sSearch_2=&bRegex_2=false&bSearchable_2=true&sSearch_3=&bRegex_3=false&bSearchable_3=true&sSearch_4=&bRegex_4=false&bSearchable_4=true&sSearch_5=&bRegex_5=false&bSearchable_5=true&sSearch_6=&bRegex_6=false&bSearchable_6=true&sSearch_7=&bRegex_7=false&bSearchable_7=true&sSearch_8=&bRegex_8=false&bSearchable_8=true&sSearch_9=&bRegex_9=false&bSearchable_9=true&sSearch_10=&bRegex_10=false&bSearchable_10=true&sSearch_11=&bRegex_11=false&bSearchable_11=true&iSortCol_0=0&sSortDir_0=desc&iSortCol_1=0&sSortDir_1=desc&iSortingC ols=2&bS ortable_0=true&bSortable_1=true&bSortable_2=true&bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=true&bSortable_7=false&bSortable_8=false&bSortable_9=false&bSortable_10=false&bSortable_11=false&borrowernumber=1 HTTP/1.1" 302 564 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET /intranet-tmpl/prog/img/ascdesc.gif HTTP/1.1" 304 - 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET /cgi-bin/koha/svc/checkouts.pl?sEcho=1&iColumns=12&iDisplayStart=0&iDisplayLength=-1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3=itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnumber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10=function&mDataProp_11=function&bRegex=false&bRegex_0=false&bSearchable_0=true&bRegex_1=false&bSearchable_1=true&bRegex_2=false&bSearchable_2=true&bRegex_3=false&bSearchable_3=true&bRegex_4=false&bSearchable_4=true&bRegex_5=false&bSearchable_5=true&bRegex_6=false&bSearchable_6=true&bRegex_7=false&bSearchable_7=true&bRegex_8=false&bSearchable_8=true&bRegex_9=false&bSearchable_9=true&bRegex_10=false&bSearchable_10=true&bRegex_11=false&bSearchable_11=true&iSortCol_0=0&sSortDir_0=desc&iSortingCols=1&bSortable_0=true&bSortable_1=true&bSortable_2=true&bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=true&bSortable_7=false&bSortable_8=false&bSortable_9=false&bSo rtable_1 0=false&bSortable_11=false&borrowernumber=1 HTTP/1.1" 200 1939 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET /cgi-bin/koha/svc/checkouts.pl?sEcho=2&iColumns=12&iDisplayStart=0&iDisplayLength=-1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3=itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnumber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10=function&mDataProp_11=function&bRegex=false&bRegex_0=false&bSearchable_0=true&bRegex_1=false&bSearchable_1=true&bRegex_2=false&bSearchable_2=true&bRegex_3=false&bSearchable_3=true&bRegex_4=false&bSearchable_4=true&bRegex_5=false&bSearchable_5=true&bRegex_6=false&bSearchable_6=true&bRegex_7=false&bSearchable_7=true&bRegex_8=false&bSearchable_8=true&bRegex_9=false&bSearchable_9=true&bRegex_10=false&bSearchable_10=true&bRegex_11=false&bSearchable_11=true&iSortCol_0=0&sSortDir_0=desc&iSortingCols=1&bSortable_0=true&bSortable_1=true&bSortable_2=true&bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=true&bSortable_7=false&bSortable_8=false&bSortable_9=false&bSo rtable_1 0=false&bSortable_11=false&borrowernumber=1 HTTP/1.1" 200 1940 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET /cgi-bin/koha/svc/checkouts.pl?sEcho=3&iColumns=12&iDisplayStart=0&iDisplayLength=-1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3=itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnumber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10=function&mDataProp_11=function&bRegex=false&bRegex_0=false&bSearchable_0=true&bRegex_1=false&bSearchable_1=true&bRegex_2=false&bSearchable_2=true&bRegex_3=false&bSearchable_3=true&bRegex_4=false&bSearchable_4=true&bRegex_5=false&bSearchable_5=true&bRegex_6=false&bSearchable_6=true&bRegex_7=false&bSearchable_7=true&bRegex_8=false&bSearchable_8=true&bRegex_9=false&bSearchable_9=true&bRegex_10=false&bSearchable_10=true&bRegex_11=false&bSearchable_11=true&iSortCol_0=0&sSortDir_0=desc&iSortCol_1=0&sSortDir_1=desc&iSortingCols=2&bSortable_0=true&bSortable_1=true&bSortable_2=true&bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=true&bSortable_7=false&bSortable_ 8=false& bSortable_9=false&bSortable_10=false&bSortable_11=false&borrowernumber=1 HTTP/1.1" 200 1940 Patch is quite huge, so it's possible that I missed something obvious, so I would really appreciate clarification on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:55:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:55:59 +0000 Subject: [Koha-bugs] [Bug 11170] The pending order list should only display orders to receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:56:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:56:03 +0000 Subject: [Koha-bugs] [Bug 11170] The pending order list should only display orders to receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 --- Comment #7 from Jonathan Druart --- Created attachment 26049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26049&action=edit Bug 11170: Fix an unnecessarily convoluted logic This patch also adds POD and UT. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:57:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:57:36 +0000 Subject: [Koha-bugs] [Bug 11170] The pending order list should only display orders to receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 --- Comment #8 from Jonathan Druart --- (In reply to Galen Charlton from comment #6) > Failing on account of the lack of documentation and unit test coverage for > the new parameter to SearchOrders(). POD and UT added. > The logic here is unnecessarily convoluted. Yes, true! Fixed. Switch back to needs SO if you think it is needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:59:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:59:19 +0000 Subject: [Koha-bugs] [Bug 11731] Typo "tranports" in installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11731 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 09:59:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 08:59:22 +0000 Subject: [Koha-bugs] [Bug 11731] Typo "tranports" in installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11731 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26038|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 26050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26050&action=edit [PASSED QA] Bug 11731 - Fixed typo in message_transport_types.txt file. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer String change, all good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:09:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:09:53 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:09:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:09:56 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #56 from Martin Renvoize --- Created attachment 26051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26051&action=edit Bug 6149 - RM followup. Gloabal replaced HightedStopWords syspref with NotHightedWords for clarification purposes. Hopefully this is a bit better and still not too verbose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:12:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:12:43 +0000 Subject: [Koha-bugs] [Bug 11913] Attributes generate error log during member entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11913 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:12:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:12:47 +0000 Subject: [Koha-bugs] [Bug 11913] Attributes generate error log during member entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11913 --- Comment #2 from Magnus Enger --- Created attachment 26052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26052&action=edit Bug 11913 - [SIGNED-OFF] Attributes generate error log during member entry In member/memberentry.pl, there were two lines like: my $newentry = { map { $_ => $entry->{$_} } %$entry }; These were in the 'sub patron_attributes_form'. They have been changed to: my $newentry = { %$entry }; Of course, indentation does not reflect actual indentation. They were discovered while testing another bug, which required editing a member record. TEST PLAN --------- 1) Make sure you have the SHOW_BCODE attribute. 2) Go edit a member. 3) Clear the SHOW_BCODE value. 4) Save. 5) Edit again. 6) Check the error log file. 7) apply patch. 8) Change the value for SHOW_BCODE (Yes/No) 9) Save. 10) Edit again. (tests change 1) 11) Clear the SHOW_BCODE 12) Save. 13) Edit again. (tests change 2) 14) Check the error log file. Signed-off-by: Magnus Enger Tested with the SHOW_BCODE attribute, setting it to empty, Yes and No. The patch removes the error log messages, as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:14:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:14:44 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #57 from Martin Renvoize --- Submitted followup as requested. I think the name is suitable descriptive whilst not being overly verbose now, though am happy to change if advised. I agree, it's a pretty trivial solution, and could probabylbe implimetned more thoroughly given a rewrite of the highlighter itself... but it does solves the imediate problem for a number of our customers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:16:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:16:12 +0000 Subject: [Koha-bugs] [Bug 11695] Typo: "Tree-character alphabetic code" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11695 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:16:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:16:25 +0000 Subject: [Koha-bugs] [Bug 11695] Typo: "Tree-character alphabetic code" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11695 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26031|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 26053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26053&action=edit [PASSED QA] Bug 11695 - FIxed typo in marc21_field_008.xml: "Tree-character alphabetic code", to "Three-character alphabetic code" Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Trees are nice, but Three is better here. String change, works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:22:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:22:32 +0000 Subject: [Koha-bugs] [Bug 11922] New: Add SHOW_BCODE patron attribute for Norwegian web installer Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922 Bug ID: 11922 Summary: Add SHOW_BCODE patron attribute for Norwegian web installer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The Norwegian web installer needs nb-NO/optional/patron_atributes.sql and .txt to stay in sync with other languages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:28:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:28:13 +0000 Subject: [Koha-bugs] [Bug 11552] After a transfer, allow to search on the original order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11552 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:28:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:28:15 +0000 Subject: [Koha-bugs] [Bug 11552] After a transfer, allow to search on the original order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11552 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25031|0 |1 is obsolete| | --- Comment #6 from Brendan Gallagher --- Created attachment 26054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26054&action=edit [PASSED-QA]Bug 11552; After a transfer, allow to search on the original order line If an order is transferred from a basket to another, it should be possible to retrieve it with the original ordernumber. Test plan: - transfer an order - note the original ordernumber and the new one - receive the order and, on the parcel page, try to find your order with the original ordernumber and the new one. Signed-off-by: sonia bouis Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:31:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:31:14 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Stefano Bargioni changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bargioni at pusc.it --- Comment #38 from Stefano Bargioni --- I signed off the patch, with a little extra fix. Function check_mandatory() -in file koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/merge.tt- states that subfield '@' of tags 003, 005, 008 are missing. I changed if (subfieldcode == 'lib' || subfieldcode == 'mandatory' || subfieldcode == 'repeatable' || subfieldcode == 'tab') { continue; } to if (subfieldcode == 'lib' || subfieldcode == 'mandatory' || subfieldcode == 'repeatable' || subfieldcode == 'tab' || subfieldcode == '@') { continue; } This fix solved the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:33:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:33:33 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Stefano Bargioni changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24078|0 |1 is obsolete| | --- Comment #39 from Stefano Bargioni --- Created attachment 26055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26055&action=edit Bug 8064: Merge several biblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:35:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:35:07 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Stefano Bargioni changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24079|0 |1 is obsolete| | --- Comment #40 from Stefano Bargioni --- Created attachment 26056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26056&action=edit Bug 8064: Change the way target record is built. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:35:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:35:46 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Stefano Bargioni changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24080|0 |1 is obsolete| | --- Comment #41 from Stefano Bargioni --- Created attachment 26057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26057&action=edit Bug 8064: Fix issues with control fields and non-repeatable check -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:37:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:37:15 +0000 Subject: [Koha-bugs] [Bug 10090] the ordered and spent page display the itemtype code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer --- The description displays nicely, but I think changing the links is not quite right. I will try to explain: Ordered: on the 'Ordered' page the link now goes directly to the receive page, but it's missing the invoiceid and the biblionumber, so the display is not quite right and receiving it like this would cause problems because of the missing invoice. Spent: Removing the link seems ok to me, because of the reason given above. One thing we could do would be link to the invoice it was received in. Maybe just change the descriptions with this bug, and leave improving the links to a separate one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:37:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:37:26 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #42 from Stefano Bargioni --- Created attachment 26058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26058&action=edit 8064-Little fix for 003 005 008 in MARC21 This patch adds one line to the check_mandatory function -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:40:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:40:07 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |magnus at enger.priv.no --- Comment #5 from Magnus Enger --- The second patch (from Kyle) has a problem: $ git bz apply 11879 Bug 11879 - Add a new borrower field : main contact method. 25922 - New version of the patch. Rebase on current master. 25941 - Bug 11879 [QA Followup] - Fix patch to follow modern coding guidelines Apply? [(y)es, (n)o, (i)nteractive] y Applying: Add the "Main contact method" field in borrower informations. Applying: Bug 11879 [QA Followup] - Fix patch to follow modern coding guidelines fatal: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11879 [QA Followup] - Fix patch to follow modern coding guidelines The copy of the patch that failed is found in: /home/magnus/scripts/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11879-QA-Followup---Fix-patch-to-follow-modern-D5v_Ji.patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:44:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:44:39 +0000 Subject: [Koha-bugs] [Bug 11811] tools/import_borrowers.pl doesn't support utf-8 encoded CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11811 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:44:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:44:42 +0000 Subject: [Koha-bugs] [Bug 11811] tools/import_borrowers.pl doesn't support utf-8 encoded CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11811 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25629|0 |1 is obsolete| | --- Comment #8 from Dobrica Pavlinusic --- Created attachment 26059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26059&action=edit Bug 11811 - tools/import_borrowers.pl utf-8 support for CSV Decode utf-8 characters in CSV file and perform canonical decomposition followed by canonical composition. Use case for this is XLS file converted into CSV which includes utf-8 characters which display correctly in interface but are not searchable in Koha's patrons search since browser does same decomposition as this code does. Test scenario: 1. go to Tools > Import patrons 2. create patrons using attached example files which include both variants of my surname. You will have to fill in branchcode and categorycode according to configuration of Koha instance which is used in web form since those values are not included in CSV 3. import patrons and verify then utf-8 characters are correct and that you get just one results when searching for my surname (cardnumber ITI-00000151832). You can just copy/paste my surname from example file (any of them) since browser does similar decomposition as this code. 4. apply this patch and repeat import of patrons, selecting option to overwrite existing records 5. verify that after searching for my surname you get two borrowers (cardnumbers ITI-00000151831 and ITI-00000151832) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:48:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:48:55 +0000 Subject: [Koha-bugs] [Bug 11811] tools/import_borrowers.pl doesn't support utf-8 encoded CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11811 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25628|0 |1 is obsolete| | --- Comment #9 from Dobrica Pavlinusic --- Created attachment 26060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26060&action=edit CSV file referenced in test scenario I removed sign off from this patch because just decoding utf-8 didn't solve our initial problem completely. Since it might be challenge to create both variants of unicode encoding, I'm attaching this file which includes my surname "Pavlinu?i?" in both formats. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:52:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:52:28 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 michot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nmichot at voila.fr --- Comment #29 from michot --- We test today on sandbox and everything seems OK : - request with 9 results, one of them with 2 items - we mark one of the 2 items "lost" - we enable prefsystem hidelostitems = "don't show" - we search again on opac - the lost item is hidden, in the list of results and on the biblio view - the facets are displayed We try another request with only one result and do the same process : - we have the message "No results found " and no facets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:56:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:56:06 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #30 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Michot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:56:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:56:23 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:56:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:56:28 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24733|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:56:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:56:34 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #31 from sandboxes at biblibre.com --- Created attachment 26061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26061&action=edit Bug 11489 - OPAC search results in 404 error when the only search result is supressed If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. Test Plan: 1) Catalog a record/item such that it is the only result for some search e.g. Give it the title 'zxcvb' 2) Enable hidelostitems 3) Mark this item as lost 4) Perform an OPAC search that should result in a redirect to this record 5) Notice you a redirected to a 404 error 6) Apply this patch 7) Repeat step 4 8) Note you new get a "No results found!" page instead Signed-off-by: Christopher Brannon Signed-off-by: Michot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:56:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:56:38 +0000 Subject: [Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #32 from sandboxes at biblibre.com --- Created attachment 26062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26062&action=edit Bug 11489: Show facets only if there is result to display If all results are hidden, the facets are displayed. With this patch, the facets are hidden too. Signed-off-by: Mark Tompsett Signed-off-by: Michot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 10:56:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 09:56:40 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Magnus Enger --- Marking this "Failed QA" based on Chris' comments. See coding guideline "PERL17: Unit tests are required". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:03:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:03:50 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- Jonathan, could you please rebase? I am a bit confused by the merge conflict in Acquisition.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:06:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:06:09 +0000 Subject: [Koha-bugs] [Bug 10777] runreport.pl allows for sending html reports via email, but mimetype is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:06:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:06:12 +0000 Subject: [Koha-bugs] [Bug 10777] runreport.pl allows for sending html reports via email, but mimetype is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25603|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 26063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26063&action=edit [PASSED QA] Bug 10777 - Send html reports with the proper Content-Type The misc/cronjobs/runreport.pl allows for sending html reports via email. The problem is that the Content-Type isn't set to text/html, which means that the generated html email isn't displayed properly. This patch set the Content-Type, and also adds a tiny bit of CSS to potentially alternate row colours (just to make long reports a bit easier on the eye!) TEST PLAN ---------- 1. Run the script similar to this: ./misc/cronjobs/runreport.pl --format=html --to=YOUREMAIL --subject="Bad Formatting!" REPORTNUMBER 2. Look at the email - the html code should by visible and ugly. 3. apply the patch 4. Run the script again. 5. Look at the email - the data should look nicer now. Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:08:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:08:06 +0000 Subject: [Koha-bugs] [Bug 10777] runreport.pl allows for sending html reports via email, but mimetype is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Code looks good, functions still work as expected with no regressions, qa scripts all pass as expected. Nice tirvial patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:14:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:14:05 +0000 Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Hi Jonathan, I like the idea and it works nicely :) The only thing I am a bit concerned about is reusing the message from the cart. I think right now they are always in the template even if the cart is turned off, but that might change at some point. Also the message might read a bit nicer as "No suggestion has been selected" - as item is also a bit confusing for translations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:15:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:15:00 +0000 Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when using QueryWeightFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:15:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:15:05 +0000 Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when using QueryWeightFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22028|0 |1 is obsolete| | --- Comment #9 from Jesse Maseto --- Created attachment 26064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26064&action=edit Attachment to Bug 11069 - increase title ranking in relevance when using QueryWeightFields [SIGNED-OFF] Bug 11069 - increase title ranking in relevance when using QueryWeightFields When using QueryWeightFields to add ranking on a search without index, the search actually uses: - rank 1 : Title-cover,ext : exact title-cover - rank 2 : ti,ext : exact title - rank 3 : Title-cover,phr : phrase title-cover - rank >7 : queries without index This relevance sets title as phrase in priority and then any index. This patch adds title as words list before search on any index, so that records with all searched terms in title, even not well ordered, are more relevant. Test plan : - Enable QueryWeightFields syspref - Perform a search, with sort by relevance, with two words ofen contained in title, but never one near the other. For example : 'History France' => Records with both words in title are first. For example : "Histoire de France" and "La France : 100 ans d'histoire" Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:18:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:18:38 +0000 Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:18:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:18:45 +0000 Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 --- Comment #15 from Jonathan Druart --- Created attachment 26065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26065&action=edit Bug 7288: Set a boolean if the invoice if linked to subscriptions If an invoice is linked to subscription, we need to set a boolean to true in order to filter them in the interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:19:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:19:11 +0000 Subject: [Koha-bugs] [Bug 11755] Argument 'booksellerid' not properly handled in orderreceive.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Jonathan - tests failed. There are a lot of new additions to the Acquisitions.t Besides that - the patch does do what it advertize - so once tests past :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:20:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:20:18 +0000 Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 --- Comment #16 from Jonathan Druart --- (In reply to Galen Charlton from comment #14) > Failing QA. When you resubmit, I would also appreciate if you wrote a unit > test for the change in the core routine. It is quite difficult to provide good unit tests here. To test if an invoice is linked to subscription, we should create a subscription (so a budget, a frequency, etc.). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:20:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:20:19 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #41 from Kyle M Hall --- Dobrica, sEcho is a parameter datatables sends when using an ajax source. It is expected that the contents of the parameter be sent back just as it was received. Kyle (In reply to Dobrica Pavlinusic from comment #40) > Aside from cosmetic notes, I have funny smell about this patch. > > When I open the page, I can see 6 ajax requests which seem to return same > JSON data. First three of them return 302 and other three return 200. > > However, only difference is in sEcho parameter for which I can't find use in > code itself. My worry is that we are creating too much unneeded requests to > the server. > > Below are relevant lines from access log: > > 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET > /cgi-bin/koha/svc/checkouts. > pl?sEcho=1&iColumns=12&sColumns=&iDisplayStart=0&iDisplayLength=- > 1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3= > itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnum > ber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10= > function&mDataProp_11=function&sSearch=&bRegex=false&sSearch_0=&bRegex_0=fals > e&bSearchable_0=true&sSearch_1=&bRegex_1=false&bSearchable_1=true&sSearch_2=& > bRegex_2=false&bSearchable_2=true&sSearch_3=&bRegex_3=false&bSearchable_3=tru > e&sSearch_4=&bRegex_4=false&bSearchable_4=true&sSearch_5=&bRegex_5=false&bSea > rchable_5=true&sSearch_6=&bRegex_6=false&bSearchable_6=true&sSearch_7=&bRegex > _7=false&bSearchable_7=true&sSearch_8=&bRegex_8=false&bSearchable_8=true&sSea > rch_9=&bRegex_9=false&bSearchable_9=true&sSearch_10=&bRegex_10=false&bSearcha > ble_10=true&sSearch_11=&bRegex_11=false&bSearchable_11=true&iSortCol_0=0&sSor > tDir_0=desc&iSortingCols=1&bSortable_0=true&bSortable_1=true&bSortable_2=true > &bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=true&bSortabl > e_7=false&bSortable_8=false&bSortable_9=false&bSortable_10=false&bSortable_11 > =false&borrowernumber=1 HTTP/1.1" 302 558 > 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET > /cgi-bin/koha/svc/checkouts. > pl?sEcho=2&iColumns=12&sColumns=&iDisplayStart=0&iDisplayLength=- > 1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3= > itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnum > ber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10= > function&mDataProp_11=function&sSearch=&bRegex=false&sSearch_0=&bRegex_0=fals > e&bSearchable_0=true&sSearch_1=&bRegex_1=false&bSearchable_1=true&sSearch_2=& > bRegex_2=false&bSearchable_2=true&sSearch_3=&bRegex_3=false&bSearchable_3=tru > e&sSearch_4=&bRegex_4=false&bSearchable_4=true&sSearch_5=&bRegex_5=false&bSea > rchable_5=true&sSearch_6=&bRegex_6=false&bSearchable_6=true&sSearch_7=&bRegex > _7=false&bSearchable_7=true&sSearch_8=&bRegex_8=false&bSearchable_8=true&sSea > rch_9=&bRegex_9=false&bSearchable_9=true&sSearch_10=&bRegex_10=false&bSearcha > ble_10=true&sSearch_11=&bRegex_11=false&bSearchable_11=true&iSortCol_0=0&sSor > tDir_0=desc&iSortingCols=1&bSortable_0=true&bSortable_1=true&bSortable_2=true > &bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=true&bSortabl > e_7=false&bSortable_8=false&bSortable_9=false&bSortable_10=false&bSortable_11 > =false&borrowernumber=1 HTTP/1.1" 302 558 > 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET > /cgi-bin/koha/svc/checkouts. > pl?sEcho=3&iColumns=12&sColumns=&iDisplayStart=0&iDisplayLength=- > 1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3= > itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnum > ber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10= > function&mDataProp_11=function&sSearch=&bRegex=false&sSearch_0=&bRegex_0=fals > e&bSearchable_0=true&sSearch_1=&bRegex_1=false&bSearchable_1=true&sSearch_2=& > bRegex_2=false&bSearchable_2=true&sSearch_3=&bRegex_3=false&bSearchable_3=tru > e&sSearch_4=&bRegex_4=false&bSearchable_4=true&sSearch_5=&bRegex_5=false&bSea > rchable_5=true&sSearch_6=&bRegex_6=false&bSearchable_6=true&sSearch_7=&bRegex > _7=false&bSearchable_7=true&sSearch_8=&bRegex_8=false&bSearchable_8=true&sSea > rch_9=&bRegex_9=false&bSearchable_9=true&sSearch_10=&bRegex_10=false&bSearcha > ble_10=true&sSearch_11=&bRegex_11=false&bSearchable_11=true&iSortCol_0=0&sSor > tDir_0=desc&iSortCol_1=0&sSortDir_1=desc&iSortingCols=2&bSortable_0=true&bSor > table_1=true&bSortable_2=true&bSortable_3=true&bSortable_4=true&bSortable_5=t > rue&bSortable_6=true&bSortable_7=false&bSortable_8=false&bSortable_9=false&bS > ortable_10=false&bSortable_11=false&borrowernumber=1 HTTP/1.1" 302 564 > 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET > /intranet-tmpl/prog/img/ascdesc.gif HTTP/1.1" 304 - > 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET > /cgi-bin/koha/svc/checkouts. > pl?sEcho=1&iColumns=12&iDisplayStart=0&iDisplayLength=- > 1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3= > itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnum > ber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10= > function&mDataProp_11=function&bRegex=false&bRegex_0=false&bSearchable_0=true > &bRegex_1=false&bSearchable_1=true&bRegex_2=false&bSearchable_2=true&bRegex_3 > =false&bSearchable_3=true&bRegex_4=false&bSearchable_4=true&bRegex_5=false&bS > earchable_5=true&bRegex_6=false&bSearchable_6=true&bRegex_7=false&bSearchable > _7=true&bRegex_8=false&bSearchable_8=true&bRegex_9=false&bSearchable_9=true&b > Regex_10=false&bSearchable_10=true&bRegex_11=false&bSearchable_11=true&iSortC > ol_0=0&sSortDir_0=desc&iSortingCols=1&bSortable_0=true&bSortable_1=true&bSort > able_2=true&bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=tr > ue&bSortable_7=false&bSortable_8=false&bSortable_9=false&bSortable_10=false&b > Sortable_11=false&borrowernumber=1 HTTP/1.1" 200 1939 > 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET > /cgi-bin/koha/svc/checkouts. > pl?sEcho=2&iColumns=12&iDisplayStart=0&iDisplayLength=- > 1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3= > itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnum > ber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10= > function&mDataProp_11=function&bRegex=false&bRegex_0=false&bSearchable_0=true > &bRegex_1=false&bSearchable_1=true&bRegex_2=false&bSearchable_2=true&bRegex_3 > =false&bSearchable_3=true&bRegex_4=false&bSearchable_4=true&bRegex_5=false&bS > earchable_5=true&bRegex_6=false&bSearchable_6=true&bRegex_7=false&bSearchable > _7=true&bRegex_8=false&bSearchable_8=true&bRegex_9=false&bSearchable_9=true&b > Regex_10=false&bSearchable_10=true&bRegex_11=false&bSearchable_11=true&iSortC > ol_0=0&sSortDir_0=desc&iSortingCols=1&bSortable_0=true&bSortable_1=true&bSort > able_2=true&bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=tr > ue&bSortable_7=false&bSortable_8=false&bSortable_9=false&bSortable_10=false&b > Sortable_11=false&borrowernumber=1 HTTP/1.1" 200 1940 > 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET > /cgi-bin/koha/svc/checkouts. > pl?sEcho=3&iColumns=12&iDisplayStart=0&iDisplayLength=- > 1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3= > itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnum > ber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10= > function&mDataProp_11=function&bRegex=false&bRegex_0=false&bSearchable_0=true > &bRegex_1=false&bSearchable_1=true&bRegex_2=false&bSearchable_2=true&bRegex_3 > =false&bSearchable_3=true&bRegex_4=false&bSearchable_4=true&bRegex_5=false&bS > earchable_5=true&bRegex_6=false&bSearchable_6=true&bRegex_7=false&bSearchable > _7=true&bRegex_8=false&bSearchable_8=true&bRegex_9=false&bSearchable_9=true&b > Regex_10=false&bSearchable_10=true&bRegex_11=false&bSearchable_11=true&iSortC > ol_0=0&sSortDir_0=desc&iSortCol_1=0&sSortDir_1=desc&iSortingCols=2&bSortable_ > 0=true&bSortable_1=true&bSortable_2=true&bSortable_3=true&bSortable_4=true&bS > ortable_5=true&bSortable_6=true&bSortable_7=false&bSortable_8=false&bSortable > _9=false&bSortable_10=false&bSortable_11=false&borrowernumber=1 HTTP/1.1" > 200 1940 > > > Patch is quite huge, so it's possible that I missed something obvious, so I > would really appreciate clarification on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:25:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:25:26 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 francois.pichenot at ovh.fr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |francois.pichenot at ovh.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:26:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:26:53 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:27:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:27:01 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25971|0 |1 is obsolete| | --- Comment #13 from Jesse Maseto --- Created attachment 26066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26066&action=edit Attachment to Bug 8262 - Special kohaadmin cannot create lists [SIGNED-OFF] Bug 8262: Special kohaadmin cannot create lists Since kohaadmin has no borrower number, it cannot create lists. A database error is logged, but the user is not notified. This patch alerts the user (kohaadmin). In the incidental case that a normal user gets a database error, he is notified too that the list could not be created. Test plan (for prog and bootstrap): This patch should be applied on top of 9032 patches. Login as kohaadmin. Create a list in opac and staff. Check the message. Login as a normal user. Force a database error on list creation (I renamed category in the table with alter table change column..) You should have a different error message. Signed-off-by: Marcel de Rooy Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:27:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:27:10 +0000 Subject: [Koha-bugs] [Bug 11711] Use new DataTables include in circ templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11711 Alex changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |alex.sassmannshausen at gmail. | |com --- Comment #2 from Alex --- Hello Owen, During my review of the patch I came across what looks like a regression: - After applying the patch - 'Holds Awaiting Pickup' report loads with glitches - Sort by date will not work - Sort by title fixes the glitches and sorts OK. - Firebug in my version of Firefox reports 3 JS errors every time date sort is attempted Before the patch the page renders fine and the sorts work. As this is my first review, please let me know if I need to provide additional information. Best wishes, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:28:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:28:12 +0000 Subject: [Koha-bugs] [Bug 9163] Cataloguing validation workflow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163 francois.pichenot at ovh.fr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |francois.pichenot at ovh.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:34:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:34:21 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:34:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:34:28 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24095|0 |1 is obsolete| | --- Comment #83 from Jonathan Druart --- Created attachment 26067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26067&action=edit Bug 9811: Patron search improvement This patch add DataTables using server-side processing for the patrons search. It adds: - 1 module C4/Utils/DataTables/Members.pm - 2 services svc/members/search and svc/members/add_to_list - 1 template members/tables/members_results.tt - 1 new practice which is to add template for DataTables in a subdirectory named 'tables'. Impacted scripts: members/members-home.pl and members/members.pl To go further: We can imagine that all patrons searches use the same service with no big changes: 1 little template creates a JSON file and to implement DataTables on the template page, that's all. Amended patch: Since bug 10565 has been pushed, these patches don't apply cleanly. I had to rewrite a part of the patron list feature. I removed the choice to add all resultant patrons from a search. I think this choice is useless with this patch: we are able to display the number of patrons we want and to select all of them. Test plan: - Check that there is no regression on searching patrons. - Try filters on the left of the screen. - Try to sort each column. - Try the "Browse by last name" links. - Check that the "Clear" button clears yours filters. - Try with IndependantBranches ON and OFF. - Verify this feature does not break the patron list feature (cf bug 10565). Signed-off-by: Cedric Vita Signed-off-by: Katrin Fischer Passes all tests and QA script, couldn't find any regressions or problems. Some notes left on the bug. Bug 9811: Add unit tests for C4::Utils::DT::Members Signed-off-by: Katrin Fischer Bug 9811: QA followup - removes 2 tabs - removes mysqlisms - add sort on borrowernotes - fix wrong capitalization - cat => Category Signed-off-by: Katrin Fischer Thx for fixing these! Bug 9811 - multilines notes brakes JSON In new patron search feature, the search results are fetched using Ajax and returned in JSON format. The JSON is created by TT using koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt. One of the fields is the borrower notes. When this notes contains several lines, the JSON is broken. This patch uses TT fileters to consert in notes linefeeds into HTML line break (html_line_break) and then remove linefeeds (collapse). Test plan : - perform a member search that does not return a borrower with a circ note - edit one of the borrowers returned by this search - enter serveral lines of text in "Circulation note" and save - reperform the member search => circ note is well displayed on several lines Bug 9811: use count(primary_key) instead of count(*) Bug 9811: A limit clause should be always added. By default, we want to retrieve 20 first results. Bug 9811: Load the page without any data. Displaying the first 20 patrons is not useful. With this patch, the table is hidden and no record is retrieved by default. On the same way, the existing side effect on redirect disappears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:34:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:34:39 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24111|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart --- Created attachment 26068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26068&action=edit Bug 9811: FIX branches loop was not correctly set The branches loop was not set with the values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:49:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:49:58 +0000 Subject: [Koha-bugs] [Bug 9856] Add TTF font path in a syspref instead of hardcoding, for labels printing (bug 8375) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9856 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |dpavlin at rot13.org Resolution|--- |INVALID --- Comment #1 from Dobrica Pavlinusic --- Latest version of bug 8375 (which is signed off) moves configuration of true type fonts into koha-conf.xml which is better place, since configuration of true type fonts isn't really user modifiable and should be done by system administrators anyway, so I'm closing this patch and removing dependency on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:49:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:49:58 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bug 8375 depends on bug 9856, which changed state. Bug 9856 Summary: Add TTF font path in a syspref instead of hardcoding, for labels printing (bug 8375) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9856 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:51:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:51:26 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha at univ-lyon3.fr --- Comment #18 from Koha Team Lyon 3 --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 10860:

Something went wrong !

Applying: Bug 10860: In-House Use Using index info to reconstruct a base tree... :1171: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging C4/Circulation.pm Auto-merging C4/Items.pm Auto-merging circ/circulation.pl CONFLICT (content): Merge conflict in circ/circulation.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/datatables.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/pages/circulation.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc Failed to merge in the changes. Patch failed at 0001 Bug 10860: In-House Use When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 10860 - In-House Use 22461 - Bug 10860: In-House Use Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-10860-In-House-Use-_cegfo.patch . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:51:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:51:28 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #43 from Zeno Tajoli --- Stefano signed off for MARC21 records. So now the patch is working for Unimarc and MARC21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:51:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:51:59 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #43 from Dobrica Pavlinusic --- bug 9856 is obsoleted by moving ttf paths into kona-conf.xml which is better place since it involves system paths so it should be under control of system administrators as opposed to end users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:54:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:54:14 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:54:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:54:19 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #2 from Jesse Weaver --- Created attachment 26069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26069&action=edit Bug 11559 - Supporting changes for Rancor * Extends login screen to pass along #hash * Adds JSONP support to C4::Service * Allows XSLT filename to be extracted * Extends humanmsg to allow per-message classes * Fixes XSLT namespace for in-browser rendering and * Adds proper charset to results of svc/bib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:54:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:54:32 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #3 from Jesse Weaver --- Created attachment 26070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26070&action=edit Bug 11559 - New libraries for Rancor Adds the following JS libraries: * CodeMirror - extensible text editor * FileSaver - shim for saving files * jquery.hotkeys - some functionality not supported by shortcuts * jquery.lightbox_me - for modal popovers * pz2 - library for connecting to pazpar2 * require - dependency resolver and module loader -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:54:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:54:43 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #4 from Jesse Weaver --- Created attachment 26071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26071&action=edit Bug 11559 - Rancor: professional cataloging interface Test plan: 1. Apply patches for bug 10486 and this bug. 2. Reinstall patches for pazpar2. 3. Switch back and forth between basic and advanced editor, and verify that preference is saved (by workstation, not user. 4. Enter in a record (with all required fields). 5. Save to ISO2709, MARCXML and catalog, verify that all three match. 6. Import a MARCXML and ISO2709 record, and verify that the record is correct after import. 7. Run keyword and advanced searches with a variety of Z39.50 servers to check that searching is correct, and try to both import records as new records and substitute them for the contents of existing records. 8. Create, edit and delete macros, verifying that they are autosaved. 9. Try running macros (example follows). 10. Try enabling and disabling fixed-field widgets and customizing fonts, and test the editor afterwards. Example macro: goto field 003 copy field data insert new field 040 data= goto subfield end insert new subfield a data= goto subfield a paste -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:56:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:56:52 +0000 Subject: [Koha-bugs] [Bug 11699] notes entered when receiving are not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > Jonathan, could you please rebase? I am a bit confused by the merge conflict > in Acquisition.t. me too... :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 11:59:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 10:59:54 +0000 Subject: [Koha-bugs] [Bug 10571] IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10571 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com --- Comment #3 from Gaetan Boisson --- Could it be linked to bug 8405 - add IntranetBiblioDefaultView and BiblioDefaultView to XSLT.pm? http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8405 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:00:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:00:17 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Lemaire changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #35 from Lemaire --- limited_item_edition : ok, but you can still delete all items. This should not be possible because it's not selected. delete_all_items : ok items_limited_batchmod : not ok. The fields don't appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:03:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:03:04 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:03:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:03:08 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24634|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 26072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26072&action=edit Bug 11395: DB: Add permission tools_records_batchmod -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:04:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:04:17 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #5 from paxed --- Quickly eyeballing the code, this doesn't seem to be translatable: prompt("Please enter the name of the new macro.") And what about the z3950Labels -array? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:04:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:04:40 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha at univ-lyon3.fr --- Comment #117 from Koha Team Lyon 3 --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 10855:

Something went wrong !

Applying: Bug 10855: Add the new package Koha::AdditionalField Applying: Bug 10855: Add unit tests for the new package Koha::AdditionalField Applying: Bug 10855: interface configuration for adding new fields to subscriptions Applying: Bug 10855: New fields on adding/updating a subscription Applying: Bug 10855: Search subscriptions by additional fields Applying: Bug 10855: Search subscriptions by additional fields on the claim page fatal: sha1 information is lacking or useless (C4/Serials.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10855: Search subscriptions by additional fields on the claim page When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 10855 - Additional fields for subscriptions 23594 - Bug 10855: Add the new package Koha::AdditionalField 23595 - Bug 10855: Add unit tests for the new package Koha::AdditionalField 23596 - Bug 10855: interface configuration for adding new fields to subscriptions 23597 - Bug 10855: New fields on adding/updating a subscription 23598 - Bug 10855: Search subscriptions by additional fields 24452 - Bug 10855: Search subscriptions by additional fields on the claim page 24453 - Bug 10855: Squash several fixes 24454 - Bug 10855: Fix QA issues 24455 - Bug 10855: FIX bad conflict merge 24456 - Bug 10855: search with exact match if linked to an AV 24569 - Bug 10855: Update database entry 24570 - Bug 10855: Additional marc fields are not inserted Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-10855-Search-subscriptions-by-additional-field-VvngGr.patch . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:06:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:06:26 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- I think I found a problem with the way the item is deleted - it seems it's missing some of the checks it shoudl do before deleting. What I did: - received 1 out of 2 items ordered - placed a hold on the record - undid the receipt - item was deleted, hold didn't show up any longer... but: - repeated the receipt - the hold showed up again as it hadn't been cancelled before, but was invisible from the GUI. Next I tried with a checkout: - checked out the created item - undid the receipt - the item was not deleted (which is good), but there was also no warning I wonder if this is more like a missing feature than a real bug, as it might need some more thought to make it completely work. My thought is, that some of the same checks for deleting an order with items (when using AcqCreateItem = on order is used) might also apply here. I can think of holds and issues for now. For a hold we could raise a warning, that it will be cancelled if there ar no other items on the record. For an issue the item should be left and maybe undoing the receipt be denied? Not sure what would happen if you undid it and then later received it again - would it create a second item? I also tested for AcqCreateItem = on order that the items would not be touched, which is good :) But something for another bug - maybe we shoudl put a note, that the changes made to the items on receive won't be undone by undoing the receipt? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:07:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:07:39 +0000 Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:07:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:07:43 +0000 Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #11 from Jonathan Druart --- Created attachment 26073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26073&action=edit Bug 11127: Define a specific message for suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:08:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:08:38 +0000 Subject: [Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha at univ-lyon3.fr --- Comment #5 from Koha Team Lyon 3 --- he sandbox you've requested is not ready. Some problems occurred applying patches from bug 11169:

Something went wrong !

Applying: Bug 11169: Display acquition details at the OPAC Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Acquisition.pm Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging opac/opac-detail.pl CONFLICT (content): Merge conflict in opac/opac-detail.pl Failed to merge in the changes. Patch failed at 0001 Bug 11169: Display acquition details at the OPAC When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11169 - OPAC: Display an acquisition details tab 22594 - Bug 11169: Display acquition details at the OPAC 22595 - Bug 11169: [Bootstrap] Display acquition details at the OPAC 25657 - Bug 11169: Hide the date_due column Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-11169-Display-acquition-details-at-the-OPAC-CZbyQZ.patch . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:10:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:10:09 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #24 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Broust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:10:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:10:36 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25202|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:10:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:10:40 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25203|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:10:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:10:46 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25655|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:10:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:10:51 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25656|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 11 12:11:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Mar 2014 11:11:00 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 --- Comment #25 from sandboxes at biblibre.com --- Created attachment 26074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26074&action=edit Bug 10865 [Revised] Don't show list permissions when adding public lists/sharing lists is not allowed If patron creation of public lists is disallowed by the OpacAllowPublicListCreation system preference the "category" option should be hidden altogether instead of showing a > + > + This variable is not retrieve in the pl file. Is it useless? ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt @@ +172,5 @@ > [% END %] > + [% IF ( AcqEnableFiles && files ) %] > +
> +

Files attached to invoice

> + Please use Datatable for this table. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 11:47:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 10:47:35 +0000 Subject: [Koha-bugs] [Bug 3050] Add an option to upload scanned invoices. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 11:48:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 10:48:30 +0000 Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |h.meissner.82 at web.de --- Comment #4 from Holger Mei?ner --- Those letters look so similar. I increased the font size and did a screenshot before and after, to be sure. :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 12:01:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 11:01:26 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart at biblibre.co | |m --- Comment #63 from Jonathan Druart --- Mark, could you please rebase the last patch please? fatal: sha1 information is lacking or useless (C4/NewsChannels.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7567 - Use, Display, Filter News by Branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 12:21:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 11:21:19 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26458|0 |1 is obsolete| | --- Comment #77 from M. de Rooy --- Created attachment 26509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26509&action=edit Bug 9032: QA Follow-up: Loop variable and Cancel button To satisfy QA needs: Use loop variable instead of $_ in opac-shareshelf.pl Adds Cancel button to Invite form (prog and bootstrap) in opac-shareshelf.tt. Likewise adds Return link under an error message in opac-shareshelf.tt. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 12:25:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 11:25:44 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #78 from M. de Rooy --- (In reply to Katrin Fischer from comment #76) > I think there are not enough changes to the sample notices to expect a lot > of merge problems in that area. I'd prefer to have the patch ready when > Galen reviews this, so there are no additional dependencies that can get > lost or forgotten. Also the patch should be tested. OK Katrin. I'll still try to do it.. We should have changed this.. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 12:47:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 11:47:29 +0000 Subject: [Koha-bugs] [Bug 10870] can't create a profile for patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10870 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr at software.coop --- Comment #1 from MJ Ray (software.coop) --- I just debugged this on the koha email list. edit-profile.pl isn't checking whether it got back an object or a scalar (probably -1 to indicate unsatisfactory @params) from the new() call and so it tries to call methods on a scalar result which results in this error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 13:37:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 12:37:51 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25325|0 |1 is obsolete| | --- Comment #64 from M. Tompsett --- Created attachment 26510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26510&action=edit Bug 7567 - Use, Display, Filter News by Branch With the branch parameter added to key functions in C4/NewsChannels.pm, function calls in C4/Members.pm, mainpage.pl, opac/opac-main.pl, tools/koha-news.pl, and t/db_dependent/NewsChannels.t were needed. Some license texts were updated. Templates were modified to display, allow for entry and editing of the branches selected. TEST PLAN --------- 1) Having logged into the staff client, is the news displaying correctly? Have you entered a news item which should not display for this branch of logged in user? 2) Find a patron (with some items checked out?) 3) Print a slip - News which is labelled 'All Branches' or for the same branch as the one printing the slip should display on the slip. - THIS DOES NOT AFFECT QUICK SLIPS 4) Home -> Tools -> News - Can you edit a news item? - Does the change save correctly? - Can you filter based on location and branch correctly? - Can you add a new entry correctly? - Can you delete an entry correctly? 5) Open an OPAC client. - Does only the news for all branches display? 6) Log into the OPAC client. - Does the news for all branches and the specific branch display? 7) prove -v t/db_dependent/NewsChannels.t - Does it run and all succeed? - Does the code seem to catch the required cases? 8) Comparing the patched and unpatched versions of files affected, are the license changes missing anything? Signed-off-by: Chris Cormack 1..10 ok 1 - use C4::NewsChannels; ok 2 - Correctly failed on no parameter! ok 3 - Successfully added the first dummy news item! ok 4 - Successfully added the second dummy news item! ok 5 - Correctly failed on no parameter! ok 6 - Successfully updated second dummy news item! ok 7 - Successfully tested get_opac_new id1 (0)! ok 8 - Successfully tested get_opac_new id2 (0)! ok 9 - Successfully tested get_opac_news for LIB1! ok 10 - Successfully tested GetNewsToDisplay for LIB1! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 13:38:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 12:38:00 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25333|0 |1 is obsolete| | --- Comment #65 from M. Tompsett --- Created attachment 26511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26511&action=edit Bug 7567 - Schema update for opac_news This was generated by: Reset hard to master. Restore old DB Apply the patches for 7567 ./installer/data/mysql/updatedatabase.pl ./misc/devel/update_dbix_class_files.pl -db_name=... -db_user=... -db_passwd=... git add Koha/Schema/Results/OpacNews.pm This should provide the necessary changes to the schema files for Koha 3.16 and forward. Had to generate under Debian, because Ubuntu's was broken by comparison. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 13:43:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 12:43:49 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #66 from M. Tompsett --- Switching to 'signed off' since the last two are only a rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 14:32:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 13:32:33 +0000 Subject: [Koha-bugs] [Bug 11631] Make translation toolchain ignore useless translatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 26512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26512&action=edit Bug 11631 - Followup to extend and compile pattern This followup extendes and compile the pattern to test for useless strings To test: Same procedure as signed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 14:33:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 13:33:54 +0000 Subject: [Koha-bugs] [Bug 11631] Make translation toolchain ignore useless translatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #7 from Bernardo Gonzalez Kriegel --- > Who does the patch? :) Done! Now this need a sign :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 16:09:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 15:09:39 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #79 from M. de Rooy --- Created attachment 26513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26513&action=edit Bug 9032: QA Follow-up: Adding notices to foreign installer files Adds the notices SHARE_INVITE and SHARE_ACCEPT to sample_notices.sql for the foreign language installer files in installer/data/mysql. Signed-off-by: Marcel de Rooy I tested each installer file by deleting all notices from letter, running the file and counting the records. I did so with and without this patch. The results below show that in each case two notices were added as expected. Note that the English file contains 25 notices including the two new ones. BEFORE THIS PATCH: de-DE/mandatory/sample_notices.sql: 23 notices es-ES/mandatory/sample_notices.sql: 18 notices fr-FR/1-Obligatoire/sample_notices.sql: 18 notices it-IT/necessari/notices.sql: 21 notices nb-NO/1-Obligatorisk/sample_notices.sql: 23 notices pl-PL/mandatory/sample_notices.sql: 18 notices ru-RU/mandatory/sample_notices.sql: 18 notices uk-UA/mandatory/sample_notices.sql: 17 notices AFTER THIS PATCH: de-DE/mandatory/sample_notices.sql: 25 notices es-ES/mandatory/sample_notices.sql: 20 notices fr-FR/1-Obligatoire/sample_notices.sql: 20 notices it-IT/necessari/notices.sql: 23 notices nb-NO/1-Obligatorisk/sample_notices.sql: 25 notices pl-PL/mandatory/sample_notices.sql: 20 notices ru-RU/mandatory/sample_notices.sql: 20 notices uk-UA/mandatory/sample_notices.sql: 19 notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 16:56:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 15:56:20 +0000 Subject: [Koha-bugs] [Bug 11982] New: Show local cover images in the biblio details page in the intranet. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Bug ID: 11982 Summary: Show local cover images in the biblio details page in the intranet. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: fcapovilla at live.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 26514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26514&action=edit Show local cover image in the intranet biblio details page. This patch adds local cover images to the biblio details page in the intranet. This patch also fixes a small problem when using Amazon and Local covers at the same time : If the image is found locally, but not on Amazon, the "No cover image" was shown under the local image in the virtual shelves on the OPAC. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 16:58:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 15:58:49 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 19:36:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 18:36:46 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 19:47:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 18:47:51 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #23 from Tom?s Cohen Arazi --- I'd like to add that the default behaviour for facets is to limit them to 20... The indexdata folks explained to me that a higher count can be hardcoded in the configuration file. For instance: will set the limit to 100. It is worth mentioning that Zebra tokenizes data for indexing purposes, and also lower cases it. Thus, to have facets work as we use them now (they show the exact data that is on the record) then :0 should be used. With :p : sang tegneserier amerikanske 25458100 02 klaver spillefilmer amerikanske 28231100 filmer komedie 2040551600 sang klaver 02 filmer romantisk 2040551900 tidsskrifter norske 13171900 barnehager tidsskrifter 372 2105 15283900 basketball 796 323 d5 10329200 litteratur historie og kritikk 809 d5 10045100 malerkunst historie generelt 759 d5 750 z 24632900 sporreboker 793 73 d5 12683600 sprak 400 d5 2041875500 tegneserier science fiction bs 26382800 So we should define facets like this: The element set in the call should be the same and will get this results: Z> elem zebra::facet::subject:0:100 Z> s Sent presentRequest (1+1). Records: 1 Record type: XML Sang Tegneserier, Amerikanske 25458100 02 Klaver Spillefilmer, Amerikanske 28231100 Filmer Komedie 2040551600 Sang Klaver 02 Filmer Romantisk 2040551900 Tidsskrifter, Norske 13171900 Barnehager Tidsskrifter 372.2105 15283900 Basketball 796.323 d5 10329200 Litteratur Historie og kritikk 809 d5 10045100 Malerkunst Historie Generelt 759 d5 750 z 24632900 Spr?k 400 d5 2041875500 Sp?rreb?ker 793.73 d5 12683600 Tegneserier Science fiction BS 26382800 --- And I'm sure we'll be getting better results in the encoding front, because Zebra should be returning the exact data we sent for indexing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 20:25:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 19:25:22 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #24 from Tom?s Cohen Arazi --- (In reply to David Cook from comment #20) > Latest trial... > > Facets seem to work great with my package install but not with my tarball > dev install. ... > +I7 > +I7 > > > > -- > > Will have to look into possible causes for this... David, the problem with your setup is that you inadvertedly set ICU for the :0 index which you shouldn't. Just set: icuchain words-icu.xml for 'index w' and 'index p'. We are using the :0 index for display purposes, so no comparisson or order definition is in place. I think it is time to start coding :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 20:54:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 19:54:17 +0000 Subject: [Koha-bugs] [Bug 11946] add table sorters to label and patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 21 22:08:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Mar 2014 21:08:38 +0000 Subject: [Koha-bugs] [Bug 10788] Add a Linked Data/RDF browser to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10788 --- Comment #1 from Magnus Enger --- Work in progress is now available here: https://github.com/MagnusEnger/kohawork/tree/bug10788-ldbrowse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 03:49:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 02:49:45 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Nicole C. Engard --- Created attachment 26515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26515&action=edit 2 images After applying the patch I uploaded a local cover image. It does show on the detail page, but it still shows the 'no image' icon from amazon as well. Normally, I'd be fine with that, but since you mentioned that this patch fixed that I thought I should point it out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 03:50:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 02:50:06 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 03:53:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 02:53:35 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nengard at gmail.com --- Comment #4 from Nicole C. Engard --- After applying this patch all info in the enumchron column in the staff client disappeared for me ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 03:53:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 02:53:52 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 03:57:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 02:57:37 +0000 Subject: [Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 03:57:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 02:57:40 +0000 Subject: [Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26461|0 |1 is obsolete| | --- Comment #1 from Nicole C. Engard --- Created attachment 26516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26516&action=edit [SIGNED-OFF] Add a "Z39.50 search" button to the authority creation and modification pages. This button lets you replace existing authorities using a Z39.50 search. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Nicole C. Engard All tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 03:59:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 02:59:30 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 04:00:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 03:00:50 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Assignee|oleonard at myacpl.org |fcapovilla at live.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 04:24:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 03:24:40 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 --- Comment #5 from M. Tompsett --- Comment on attachment 20790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20790 Bug 10823 - add class info to enumchron data in detail.tt, for better styling Review of attachment 20790: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10823&attachment=20790) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ +513,5 @@ > + [% END %] > + [% IF ( itemloo.serialseq ) %] > +
-- [% itemloo.serialseq %]
> + [% END %] > + [% IF ( itemloo.publisheddate ) %] These say 'itemloo' vs. 'item' in the previous code. This is why it disappeared for Nicole. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 04:56:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 03:56:31 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #67 from M. Tompsett --- For the record, it was bug 11736 that triggered this required rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 08:56:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 07:56:00 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 09:48:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 08:48:27 +0000 Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This patch fixes the English sql file, but the wrong string still appears in the translated SQL files: installer/data/mysql/de-DE/mandatory/subtag_registry.sql 86 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/es-ES/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/it-IT/necessari/subtag_registry.sql 76 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/nb-NO/1-Obligatorisk/subtag_registry.sql 95 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/pl-PL/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/ru-RU/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/uk-UA/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); We really should only maintain the language files once, as they contain all the translations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 09:51:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 08:51:18 +0000 Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9056 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 09:51:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 08:51:18 +0000 Subject: [Koha-bugs] [Bug 9056] Add more translations to table language_descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9056 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11973 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 09:51:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 08:51:43 +0000 Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11568 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 09:51:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 08:51:43 +0000 Subject: [Koha-bugs] [Bug 11568] Wrong language code in de-DE/mandatory/subtag_registry.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11973 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 09:52:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 08:52:13 +0000 Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11393 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 09:52:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 08:52:13 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11973 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 09:58:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 08:58:32 +0000 Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 --- Comment #6 from Katrin Fischer --- Created attachment 26517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26517&action=edit [PASSED QA] Bug 11973 - Fix Armenian language description This patch fix Armenian language description To test: 1) Do a fake translation to Armenian, mkdir koha-tmpl/intranet-tmpl/prog/hy-Armn 2) Go to Administration > System preferences > I18N/L10N 3) Armenian description looks like the second string in Bug description 4) Apply the patch 5) Run updatedatabase.pl 6) Reload page, now description look as first string in Bug description (it's the sixth letter, similar to 't') Ammended patch, wrong column. Signed-off-by: Holger Mei?ner Signed-off-by: Katrin Fischer Patch fixes the English sample file for translations and includes a database update to correct the string in existing installations. Passes all tests and QA script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 09:58:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 08:58:53 +0000 Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 09:58:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 08:58:54 +0000 Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26508|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:01:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:01:07 +0000 Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 --- Comment #7 from Katrin Fischer --- I have added some other related bugs. My suggestion would be, that we first fix the English file as reference and then either - copy the corrected English file for all translated installers - or better: move it out of the language specific installer directories (like syspref.sql) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:05:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:05:32 +0000 Subject: [Koha-bugs] [Bug 11957] sample_only_param_tables.sql is not usable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:05:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:05:35 +0000 Subject: [Koha-bugs] [Bug 11957] sample_only_param_tables.sql is not usable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26449|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 26518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26518&action=edit [PASSED QA] Bug 11957: sample_only_param_tables.sql is not usable This sql file tries to insert data into nonexistent tables. It is useless and can be removed. Test plan: git grep sample_only_param_tables should not return any result. NOTE: This is basically a git rm. Simple patch. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer File is not used by the installers and it wouldn't work with today's Koha for trying to insert data into non-existant tables and tables with different structure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:16:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:16:55 +0000 Subject: [Koha-bugs] [Bug 11865] Show basket creator's name in pending orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11865 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- This works as described, but I worry about adding more and more information to all the acquisition tables, because I think it can be counter productive to ergonomy and make them harder to use. In this case the patch doesn't add a link to another patch with more information, like the recent patches for adding the basket group numbers to more places, but it adds a very specific information. The table won't be sortable, the information will repeat for every order line from that basket. For a small library, it might even be always the same information repeated all over. If you need to find out, who ordered a book, you can do a right click on the basket number link and open it in a new tab. There all the information about the basket will be displayed clearly - the name of the staff person who ordered it, when it was ordered, for which branch, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:18:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:18:16 +0000 Subject: [Koha-bugs] [Bug 11865] Show basket creator's name in pending orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11865 --- Comment #4 from Katrin Fischer --- ... by 'the table won't be sortable' I meant: the column will not be sortable by the staff member who created the order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:20:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:20:46 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #66 from Katrin Fischer --- I think by accident some patches got on this bug report, that don't belong here - tidying up a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:21:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:21:19 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25091|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:21:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:21:22 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25092|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:21:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:21:26 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25093|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:21:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:21:30 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25094|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:21:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:21:33 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25095|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:31:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:31:06 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|paul.poulain at biblibre.com | --- Comment #67 from Katrin Fischer --- ... now it looks a lot less scary already. The QA script complains about a few small things: FAIL reports/issues_stats.pl FAIL pod *** ERROR: =over on line 45 without closing =back at line EOF in file reports/issues_stats.pl FAIL forbidden patterns forbidden pattern: tab char (line 628) OK valid OK critic FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt FAIL forbidden patterns forbidden pattern: tab char (line 75) OK tt_valid OK valid_template Please provide a follow up for the POD and include the tab fixes. Also - are there patches missing? I can't find the new tests in t/db_dependent/Biblio.t the comments talk about. and some of the other changes mentioned. Julian, could you please check the patches are all there and complete for testing? Please also point me the correct test plan I should be using, thx. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:38:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:38:51 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #22 from Katrin Fischer --- My feeling is, that we need to centralize the code doing all the calculations in acq, as the tax calculation has proven to be an endless source of pain and confusion. That said... going to QA this and hoping for an improvement :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:45:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:45:43 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer --- Looking at this a bit more, I think I might have found a small mistake. With both patches applied: In acqui/invoice.pl: 103 my $bookseller = GetBookSellerFromId($details->{booksellerid}); 151 suppliername => $details->{'suppliername'}, Jonathan, could you check please? There is no "Need Feedback" status, so setting "Failed QA". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 10:48:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 09:48:01 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #24 from Katrin Fischer --- Hm also: FAIL acqui/invoice.pl OK pod OK forbidden patterns FAIL valid Useless use of private variable in void context OK critic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 11:28:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 10:28:33 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #108 from Katrin Fischer --- I am sorry, there is a conflict I can't resolve in this patch series: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 6739 - expired patrons not blocked from opac actions - Followup 2 fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 6739 - expired patrons not blocked from opac actions - Followup 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 12:39:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 11:39:44 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #25 from Jacek Ablewicz --- (In reply to Katrin Fischer from comment #23) > 151 suppliername => $details->{'suppliername'}, IMO this part is fine (GetInvoiceDetails() does return 'suppliername' and it seems to work like intended, at least for me), but this one: 152 supplierid => $details->{'supplierid'}, is indeed not; as a result, link via "Vendor: " name is leading to nowhere. Which I should've spotted before signing-off :(. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 13:42:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 12:42:28 +0000 Subject: [Koha-bugs] [Bug 11957] sample_only_param_tables.sql is not usable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11957 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 13:52:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 12:52:39 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #6 from Katrin Fischer --- Comment on attachment 25915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25915 [Signed-off]Add the "Orders by budget" report. Review of attachment 25915: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11371&attachment=25915) ----------------------------------------------------------------- Hi Frederick, I know this has been in the loop for a while already, but I found some things that I feel should be addressed. I hope my comments are understandable. I. The QA script points out some things: QA SCRIPT testing 1 commit(s) (applied to 7408fa5 'Bug 8168: (follow-up) Use semicolon a') OK C4/Budgets.pm OK pod OK forbidden patterns OK valid OK critic FAIL reports/orders_by_budget.pl OK pod FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 10) FAIL valid Scalar value @filtered_budgets[0] better written as $filtered_budgets[0] FAIL critic I/O layer ":utf8" used at line 154, column 9. Use ":encoding(UTF-8)" to get strict validation. FAIL t/db_dependent/Acquisition.t OK pod FAIL forbidden patterns forbidden pattern: tab char (line 135) forbidden pattern: tab char (line 136) forbidden pattern: tab char (line 134) forbidden pattern: tab char (line 137) OK valid OK critic FAIL t/db_dependent/Budgets.t OK pod FAIL forbidden patterns forbidden pattern: tab char (line 68) forbidden pattern: tab char (line 67) forbidden pattern: tab char (line 58) forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 50) forbidden pattern: tab char (line 57) OK valid OK critic FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt FAIL forbidden patterns forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 99) forbidden pattern: tab char (line 88) forbidden pattern: tab char (line 90) forbidden pattern: tab char (line 95) forbidden pattern: tab char (line 98) forbidden pattern: tab char (line 100) forbidden pattern: tab char (line 58) forbidden pattern: tab char (line 101) forbidden pattern: tab char (line 15) forbidden pattern: tab char (line 62) forbidden pattern: tab char (line 61) forbidden pattern: tab char (line 77) forbidden pattern: tab char (line 83) forbidden pattern: tab char (line 78) forbidden pattern: tab char (line 57) forbidden pattern: tab char (line 96) forbidden pattern: tab char (line 14) forbidden pattern: tab char (line 82) forbidden pattern: tab char (line 107) forbidden pattern: tab char (line 80) forbidden pattern: tab char (line 89) forbidden pattern: tab char (line 59) OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt FAIL forbidden patterns forbidden pattern: tab char (line 65) OK tt_valid OK valid_template Please fix those. II. Testing the interface 1) I think the budgets should be funds in the interface, or fund (budget) for the pull down list. 2) There is a small display issue with the legend 'Filters' on the first fieldset. The legend shows inside the elemend, instead of above. 3) The list could be improved, showing only funds with orders. But that would be an enhancement. 4) Lots of the date and currency formatting could be handled in the template. But it works and dateformat is honored. III Code review Generally I think there is a bit of confusion about the terminology, visible in the interface and in the naming and documentation of the new routines. The hierarchies in Koha speak are something like: basket group - basket - order/order line budget - fund - child funds I have tried to point those out and also found a few other things: ::: C4/Budgets.pm @@ +476,4 @@ > } > > # ------------------------------------------------------------------- > +sub GetBudgetPeriodDescription { 1) Please add complete documentation to the new routine - I know Budget.pm is a bit sparse on that, but it's still worth not making it worse :) (minor) 2) Please also document the return values (see also below) (minor) @@ +725,5 @@ > +=head2 GetBudgetReport > + > + &GetBudgetReport(); > + > +Get one specific budget for reports without cancelled baskets. 3) Documentation could be a bit more clear: Get all orders for a specific fund, without cancelled orders. @@ +739,5 @@ > + FROM aqbudgets b > + INNER JOIN aqorders o > + ON b.budget_id = o.budget_id > + WHERE b.budget_id=? > + AND (o.datecancellationprinted IS NULL OR o.datecancellationprinted='0000-00-00') 4) The SQL could make use of the new orderstatus column in aqorders to filter out the cancelled orders now. (minor) @@ +755,5 @@ > +=head2 GetBudgetsReport > + > + &GetBudgetsReport(); > + > +Get all budgets for reports without cancelled baskets. 5) This seems to be mostly a copy of GetActiveBudgetsReport but for the Active bit. Why not move those into one and use a parameter? Suggestion for improving the description: Get all but cancelled orders for all funds. @@ +779,5 @@ > + } > + return @results; > +} > + > +=head2 GetActiveBudgets 6) I think the name doesn't fit the use of the routine. GetActiveBudgets will give you inactive budgets when you call it with parameter 0? ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt @@ +35,5 @@ > + > + > + > + > + 7) Tiny thing: capitalization (trivial) ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt @@ +61,4 @@ >

Other

>
    >
  • Items lost
    • > +
  • Orders by budget
    • 8) Should be orders by fund. ::: reports/orders_by_budget.pl @@ +174,5 @@ > + print '"Total RRP"' . $sep; > + print '"Total cost"' . $sep; > + print '"Entry date"' . $sep; > + print '"Date received"' . $sep; > + print '"Notes"' . "\n"; 9) These headers won't be translatable. It's an old problem we have solved recently using a TT include. Take a look at the other CSV export options in acquisitions especially. Could be an enhancement. @@ +204,5 @@ > + } > +} > +else { > + # Set file export choices > + my $CGIextChoice = CGI::scrolling_list( 10) CGI::scrolling_list shouldn't be used in new scripts, as we are trying to get rid of it totally - see bug 766. @@ +212,5 @@ > + -size => 1, > + -multiple => 0 > + ); > + > + my $CGIsepChoice = GetDelimiterChoices; 11) I am not sure there, but avoiding CGIsepChoice might also be preferrable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 13:53:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 12:53:14 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 13:54:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 12:54:13 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #26 from Katrin Fischer --- Hi Jacek, thx for checking :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 13:58:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 12:58:49 +0000 Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 14:53:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 13:53:19 +0000 Subject: [Koha-bugs] [Bug 11983] New: code to select patrons to purge needs to be centralized Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Bug ID: 11983 Summary: code to select patrons to purge needs to be centralized Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org The patch for bug 11352 introduces a routine in tools/cleanborrowers.pl called skip_borrowers_with_nonzero_balance. This filters out patrons who have active fine balances so that the patron purge does not inadvertently delete/trash them. This logic should be put in a central routine, e.g., perhaps in GetBorrowersToExpunge(). At present, misc/cronjobs/delete_patrons.pl also has logic to not purge patrons with fine balances, but it implements it differently. Having two different implementations of the same functionality is not great, but I (in my role as 3.16 RM) allowed it because of the potential for data loss that the patch for bug 11352 fixed. However, this situation should not be allowed to persist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 14:53:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 13:53:31 +0000 Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11352 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 14:53:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 13:53:31 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11983 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 14:55:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 13:55:04 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 --- Comment #11 from Galen Charlton --- I've opened another follow-up bug (bug 11983) regarding the fact that this patron introduces a /second/ implementation of logic to exclude patrons that have non-zero fine-balances (the other is in the patron deletion cronjob) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 14:56:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 13:56:42 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Jacek! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 15:50:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 14:50:20 +0000 Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | --- Comment #2 from Bernardo Gonzalez Kriegel --- Not only that text is not translated. Also file description is missing in english. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 16:03:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 15:03:58 +0000 Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 26519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26519&action=edit Bug 10818 - System preference OAI-PMH:ConfFile isn't translatable This patch correct english display for OAI-PMH:ConfFile syspref, and makes it's strings translatable To test: 1) On Administration > System preferences > Web Services OAI-PMH:ConfFile syspref doesn't have description before file box. Text after that box is not translated. 2) Choose your prefered language, xx-YY, update po files cd misc/translator perl translate update xx-YY 3) Look into xx-YY-pref.po for any occurence of "YAML", there is none 4) Apply the patch 5) Update po files again 6) Look into xx-YY-pref.po, now there are 2 entries 7) Also reload page from 1) and check for text before file box. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 16:04:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 15:04:22 +0000 Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 18:13:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 17:13:51 +0000 Subject: [Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 18:25:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 17:25:52 +0000 Subject: [Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 26520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26520&action=edit Bug 11639 - Untranslatable strings in 007 builder This patch modifies marc21_field_007.tt to make some missing strings translatable To test: 1) Using your preferred language, xx-YY, updatepo files cd misc/translator perl translate update xx-YY 2) Check that missing strings are NOT present egrep -i "exact bit depth|pad with zero|use up to 6" po/xx-YY-i-staff-t-prog-v-3006000.po 3) Apply the patch 4) repeat 1) 5) Repeat 2), check that missing strings are present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 18:27:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 17:27:45 +0000 Subject: [Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 18:57:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 17:57:10 +0000 Subject: [Koha-bugs] [Bug 11646] Untranslatable confirm popup in field 006 and 008 builders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 18:58:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 17:58:08 +0000 Subject: [Koha-bugs] [Bug 11646] Untranslatable confirm popup in field 006 and 008 builders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 26521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26521&action=edit Bug 11646 - Untranslatable confirm popup in field 006 and 008 builders This patch MARC21 modifies value builders 006 and 008 to make confirm popup translatable To test: 1) Update po files for your preferred language, xx-YY cd misc/translator; perl translate update xx-YY 2) Check that confirm string is NOT present egrep -B3 "Show values for|material type\?" po/xx-YY*po 3) Apply the patch 4) Repeat 1) 5) Repeat 2), now the strings are present Also check that english or translated popup is right -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 18:58:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 17:58:38 +0000 Subject: [Koha-bugs] [Bug 11646] Untranslatable confirm popup in field 006 and 008 builders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 18:59:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 17:59:51 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 22 19:53:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Mar 2014 18:53:42 +0000 Subject: [Koha-bugs] [Bug 11631] Make translation toolchain ignore useless translatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26512|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 26522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26522&action=edit Bug 11631 - Followup to extend and compile pattern This followup extendes and compile the pattern to test for useless strings To test: Same procedure as signed patch Ammended patch, there is already a place for this check -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 06:01:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 05:01:56 +0000 Subject: [Koha-bugs] [Bug 11984] New: Show number of item(s) on order in the catalogue holdings without having to create item records Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11984 Bug ID: 11984 Summary: Show number of item(s) on order in the catalogue holdings without having to create item records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org In OPAC/staff catalogue, show number of item(s) on order without having to create item record(s). We have opted to create item record only when receive ordered goods, because this allowed us to cancel an order, without also having to delete linked item record(s). Currently item record(s) must be created in order for such information to be presented in OPAC or staff catalogue. Ideally, "On Order" information should be presented similarly to number of reservation(s) attached to each catalogue record, such as: [Qty] on order; or [Qty] on order for [Holding Library 1]; [Qty] on order for [Holding Library 2], etc. Perhaps we then specify whether to show a grand quantity total on order, or quantity breakdown for each holding library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 06:21:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 05:21:36 +0000 Subject: [Koha-bugs] [Bug 11985] New: Auto insert MARC 005 (Date and Time of Latest Transaction) detail when saving new catalog record Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11985 Bug ID: 11985 Summary: Auto insert MARC 005 (Date and Time of Latest Transaction) detail when saving new catalog record Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Automatically insert detail for MARC 005 (Date and Time of Latest Transaction) when saving a new catalog record. Currently, a pop-up message may appears when MARC 005 is left blank as you save a new catalog record. Clear this message, and it automatic insert necessary detail into this field. This should be improved, so user don't have to click into MARC 005 (to insert detail) field as part of cataloguing activity. It should automatically get inserted when the record is saved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 18:37:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 17:37:05 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #28 from Katrin Fischer --- Hi Bernardo, what is the next step here now that bug 11330 got pushed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 19:33:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 18:33:08 +0000 Subject: [Koha-bugs] [Bug 11986] New: Tags searching doesn't work in OPAC if biblio DOM indexing is being used Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11986 Bug ID: 11986 Summary: Tags searching doesn't work in OPAC if biblio DOM indexing is being used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: abl at biblos.pk.edu.pl QA Contact: testopia at bugs.koha-community.org For biblio DOM indexing (which, AFAIRC, is now default setting for new installations), tags "searching" in OPAC doesn't work properly. Clicking on any tag in OPAC (within "Tag cloud", or within "Tags from this library: " in any given biblio) leads to 404 error in browser, and ERROR DECODING RECORD - :1: parser error : Start tag expected, '<' not found ... at /home/koha/devkohaclone/C4/Search.pm line 1724. in error.log. I guess underlying cause for this error is this kludge in opac/opac-search.pl: 504: my @marclist = (map {$_->{marc}} @biblist ); 506: $results_hashref->{biblioserver}->{RECORDS} = \@marclist; which doesn't work any longer in cases when retrieval format being used for biblio records may now be not neceserilly marc, but also xml / marcxml. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 19:34:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 18:34:21 +0000 Subject: [Koha-bugs] [Bug 5993] tags not searchable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5993 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11986 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 19:34:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 18:34:21 +0000 Subject: [Koha-bugs] [Bug 11986] Tags searching doesn't work in OPAC if biblio DOM indexing is being used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11986 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5993 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 20:04:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 19:04:19 +0000 Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|gmcharlt at gmail.com |fcapovilla at live.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 20:59:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 19:59:26 +0000 Subject: [Koha-bugs] [Bug 11939] Sample of currencies with a working active value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 20:59:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 19:59:29 +0000 Subject: [Koha-bugs] [Bug 11939] Sample of currencies with a working active value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26380|0 |1 is obsolete| | Attachment #26440|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 26523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26523&action=edit [PASSED QA] Bug 11939 - Better default for currencies This patch offers a better default for currencies, with USA dollar as default active currency. To test the patch: 1)Install master without the patch, during web installation select 'parameters.sql' file 2)Finish install and go to Administration -Currencies & Exchange rates 3)No active currency 4)Install master with this patch, during web installation select 'parameters.sql' file 5)Finish install and go to Administration -Currencies & Exchange rates 6)Now USA dollar is the active currency http://bugs.koha-community.org/show_bug.cgi?id=11939 NOTE: This does solve the problem of everything being NULL for active, and lacking an active value. It also corrects the description of the optional item to check related to currencies. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 20:59:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 19:59:49 +0000 Subject: [Koha-bugs] [Bug 11939] Sample of currencies with a working active value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 --- Comment #14 from Katrin Fischer --- Created attachment 26524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26524&action=edit [PASSED QA] Bug 11939: Add active currency for all data files Revised Test Plan ----------------- The following SQL commands were used to test this. installer/data/mysql/en/optional/parameters.sql is part of the first patch and didn't really need testing again. installer/data/mysql/de-DE/optional/parameters.sql is not part of the patch, but since I was playing with the script, which is also attached here, it was included for good measure. use kohadata; SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/pl-PL/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/es-ES/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/de-DE/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/en/optional/parameters.sql Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 20:59:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 19:59:53 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #29 from Bernardo Gonzalez Kriegel --- Hi Katrin, I will look into this again and try to make a new patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 21:09:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 20:09:25 +0000 Subject: [Koha-bugs] [Bug 11914] Ordering from suggestions: fund (budget id) is not retained; price calculations not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 21:09:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 20:09:28 +0000 Subject: [Koha-bugs] [Bug 11914] Ordering from suggestions: fund (budget id) is not retained; price calculations not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26037|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 26525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26525&action=edit [PASSED QA] Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working When order is being created from purchase suggestion: - Budget/fund stored in suggestion record (if any) is not retained on order page, system always defaults to 'Select a fund' even if some fund was already chosen for a suggestion on the earlier stage. - If there was a price given to, and stored within suggestion record, initial prices calculations on order page are not working properly ('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank). As a workaround - to force correct price recalculation - user needs to manually alter and then re-alter some price-related fields (e.g., quantity or vendor price). This patch fixes both issues. Test plan: 1) create a suggestion: choose some buget, enter something in 'Price' and 'Quantity' fields, 2) try to make an order from this suggestion, to confirm/replicate aforementioned problems, 3) apply patch, 4) make an order from previously created suggestion again, observe that both issues are now resolved. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 21:36:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 20:36:32 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 21:36:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 20:36:36 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26066|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 26526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26526&action=edit [PASSED QA] Bug 8262: Special kohaadmin cannot create lists Since kohaadmin has no borrower number, it cannot create lists. A database error is logged, but the user is not notified. This patch alerts the user (kohaadmin). In the incidental case that a normal user gets a database error, he is notified too that the list could not be created. Test plan (for prog and bootstrap): This patch should be applied on top of 9032 patches. Login as kohaadmin. Create a list in opac and staff. Check the message. Login as a normal user. Force a database error on list creation (I renamed category in the table with alter table change column..) You should have a different error message. Signed-off-by: Marcel de Rooy Signed-off-by: Jesse Maseto Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 21:51:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 20:51:43 +0000 Subject: [Koha-bugs] [Bug 9578] Error when search and sort not on relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9578 --- Comment #5 from Katrin Fischer --- Created attachment 26527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26527&action=edit [PASSED QA] Bug 9578 - Error when search and sort not on relevance When searching with a sort (means not by relevance) and there is an error in Zebra connexion (server is down or query is wrong), you get the message : Error : Can't call method "sort" on an undefined value at /home/kohaadmin/src/C4/Search.pm line 405. This patch corrects by not performing sort if no results. Steps to reproduce the error without patch: In OPAC go to Advanced Search Choose "Title" in first "Search for:" end enter fgdfgdfgdggdg (Exam 70-433) Display "More options" Set "Sort by" to "Title (A-Z)" Click "Search" at bootom of page Result: Error: Can't call method "sort" on an undefined value at /usr/share/kohaclone/C4/Search.pm line 430. Test plan : - Set OPACdefaultSortField on something else than relevance - Perform a simple search with a wrong CCL query. For example : ccl=( and ) => You get the messge : No results found ... Patch behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Adds another check to prevent a bad Zebra error message. Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 21:52:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 20:52:18 +0000 Subject: [Koha-bugs] [Bug 9578] Error when search and sort not on relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 21:52:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 20:52:20 +0000 Subject: [Koha-bugs] [Bug 9578] Error when search and sort not on relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25891|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 22:07:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 21:07:20 +0000 Subject: [Koha-bugs] [Bug 11986] Tags searching doesn't work in OPAC if biblio DOM indexing is being used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11986 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 22:08:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 21:08:22 +0000 Subject: [Koha-bugs] [Bug 11986] Tags searching doesn't work in OPAC if biblio DOM indexing is being used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11986 --- Comment #1 from Jacek Ablewicz --- Created attachment 26528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26528&action=edit Bug 11986 - Tags searching doesn't work in OPAC if biblio DOM indexing is being used This patch fixes the following issue: in installations that are using zebra DOM indexing for bibliographic records, tag searching in OPAC doesn't work properly (clicking on any tag in OPAC leads to "404 error"). To test: ensure that with patch applied: 1) problems with tag searching get resolved for [some] test configuration with biblio DOM indexing enabled, 2) there are no apparent tag-searching-related regressions in OPAC, in some yet another test installation configured with legacy (grs1) indexing mode for biblios. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 22:08:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 21:08:55 +0000 Subject: [Koha-bugs] [Bug 11986] Tags searching doesn't work in OPAC if biblio DOM indexing is being used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11986 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 22:09:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 21:09:15 +0000 Subject: [Koha-bugs] [Bug 11986] Tags searching doesn't work in OPAC if biblio DOM indexing is being used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11986 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 22:25:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 21:25:19 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Owen, I am having difficulties testing the overdues report - I don't have a filter for patron attributes showing up. The pref is enabled and the user showing up in the report has patron attributes linked to authorized values set. - In Circulation -> Overdues: The patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 23 23:52:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 22:52:26 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #25 from David Cook --- (In reply to Tom?s Cohen Arazi from comment #24) > (In reply to David Cook from comment #20) > > Latest trial... > > > > Facets seem to work great with my package install but not with my tarball > > dev install. > ... > > +I7 > > +I7 > > > > > > > > -- > > > > Will have to look into possible causes for this... > > David, the problem with your setup is that you inadvertedly set ICU for the > :0 index which you shouldn't. > > Just set: > > icuchain words-icu.xml > > for 'index w' and 'index p'. > > We are using the :0 index for display purposes, so no comparisson or order > definition is in place. > > I think it is time to start coding :-D Thanks for all that info, Tomas! You're the best! However, I don't believe that I have ICU set for the :0 index. I only have icuchain words-icu.xml set up for 'index w' and 'index p'. Here's what I have in my default.idx for "index 0": # Null map index (no mapping at all) # Used if structure=key (@attr 4=3) index 0 completeness 0 position 1 charmap @ Here's the diagnostic message I get when I try to use "index 0": Records: 1 Diagnostic message(s) from database: [25] Specified element set name not valid for specified database -- v2 addinfo '' I get the same message when I try with my non-ICU system :/. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 00:14:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 23:14:00 +0000 Subject: [Koha-bugs] [Bug 11357] biblio.size value not correctly displayed in list emails sent from OPAC and intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11357 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Consider looking at bug 10466. As far as I can tell, TT will give you the size of the hash rather than the value only if the size value is undefined. If it is defined, it will give you the size value. However, since the size column is often null in the database, you'll often get the size of the hash rather than a blank value. Here's a relevant section from 10466: "This bug has been identified in the opac-search.pl, search.pl and addbooks.pl pages before...". The patch with the bug also touches C4/VirtualShelves/Page.pm. I'm not sure what the best course of action is. If the database had a blank value rather than a null value, it would probably prevent this problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 00:39:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Mar 2014 23:39:33 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #26 from Tom?s Cohen Arazi --- (In reply to David Cook from comment #25) > (In reply to Tom?s Cohen Arazi from comment #24) > > (In reply to David Cook from comment #20) > > > Latest trial... > > > > > > Facets seem to work great with my package install but not with my tarball > > > dev install. > > ... > > > +I7 > > > +I7 > > > > > > > > > > > > -- > > > > > > Will have to look into possible causes for this... > > > > David, the problem with your setup is that you inadvertedly set ICU for the > > :0 index which you shouldn't. > > > > Just set: > > > > icuchain words-icu.xml > > > > for 'index w' and 'index p'. > > > > We are using the :0 index for display purposes, so no comparisson or order > > definition is in place. > > > > I think it is time to start coding :-D > > Thanks for all that info, Tomas! You're the best! > > However, I don't believe that I have ICU set for the :0 index. I only have > icuchain words-icu.xml set up for 'index w' and 'index p'. Here's what I > have in my default.idx for "index 0": > > # Null map index (no mapping at all) > # Used if structure=key (@attr 4=3) > index 0 > completeness 0 > position 1 > charmap @ > > Here's the diagnostic message I get when I try to use "index 0": > > Records: 1 > Diagnostic message(s) from database: > [25] Specified element set name not valid for specified database -- v2 > addinfo '' > > I get the same message when I try with my non-ICU system :/. What I did was: -added some :0 use in zebradb/retrieval-info-bib-dom.xml like: - Edited marc_defs/marc21/biblios/biblio-koha-indexdefs.xml and added an occurence of Subject:0 after every Subject:p this could be narrowed down later (we might not need facets for all thsoe fields), but I wanted to make sure :0 contained the same as :p for subject, for testing purposes. - Run xsltproc ~/koha-dev/etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl biblio-koha-indexdefs.xml > biblio-zebra-indexdefs.xsl to regenerate the xsl file, - Then reindex :-( And then search using: Z> format xml Z> elem zebra::facet::subject:0:100 I also had zebra::facet::subject:p defined to compare the results over the same search. Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 01:56:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 00:56:47 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #27 from David Cook --- (In reply to Tom?s Cohen Arazi from comment #26) > (In reply to David Cook from comment #25) > > (In reply to Tom?s Cohen Arazi from comment #24) > > > (In reply to David Cook from comment #20) > > > > Latest trial... > > > > > > > > Facets seem to work great with my package install but not with my tarball > > > > dev install. > > > ... > > > > +I7 > > > > +I7 > > > > > > > > > > > > > > > > -- > > > > > > > > Will have to look into possible causes for this... > > > > > > David, the problem with your setup is that you inadvertedly set ICU for the > > > :0 index which you shouldn't. > > > > > > Just set: > > > > > > icuchain words-icu.xml > > > > > > for 'index w' and 'index p'. > > > > > > We are using the :0 index for display purposes, so no comparisson or order > > > definition is in place. > > > > > > I think it is time to start coding :-D > > > > Thanks for all that info, Tomas! You're the best! > > > > However, I don't believe that I have ICU set for the :0 index. I only have > > icuchain words-icu.xml set up for 'index w' and 'index p'. Here's what I > > have in my default.idx for "index 0": > > > > # Null map index (no mapping at all) > > # Used if structure=key (@attr 4=3) > > index 0 > > completeness 0 > > position 1 > > charmap @ > > > > Here's the diagnostic message I get when I try to use "index 0": > > > > Records: 1 > > Diagnostic message(s) from database: > > [25] Specified element set name not valid for specified database -- v2 > > addinfo '' > > > > I get the same message when I try with my non-ICU system :/. > > What I did was: > > -added some :0 use in zebradb/retrieval-info-bib-dom.xml like: > > > > - Edited marc_defs/marc21/biblios/biblio-koha-indexdefs.xml and added an > occurence of > > Subject:0 > after every > Subject:p > > this could be narrowed down later (we might not need facets for all thsoe > fields), but I wanted to make sure :0 contained the same as :p for subject, > for testing purposes. > > - Run > xsltproc ~/koha-dev/etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl > biblio-koha-indexdefs.xml > biblio-zebra-indexdefs.xsl > > to regenerate the xsl file, > > - Then reindex :-( > > And then search using: > Z> format xml > Z> elem zebra::facet::subject:0:100 > > I also had zebra::facet::subject:p defined to compare the results over the > same search. > > Regards > To+ I believe that I've done the same thing and am getting that error instead :(. I'll try again though just to make sure :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 02:32:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 01:32:25 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #28 from David Cook --- Thanks again, Tomas! I'm accustomed to using the GRS-1 filter, so I forgot about transforming the XML into XSL for DOM indexing. Problem solved! Yay! That's great information about appending "100" to the element to get a longer facet list as well! I don't know if we would necessarily want more than 20 results per facet, but it's nice to have the configurability to change it. However, I would recommend "not" hardcoding "zebra::facet::subject:0:100" into zebradb/retrieval-info-bib-dom.xml. Try just using "" in "zebradb/retrieval-info-bib-dom.xml". It's a much more flexible configuration. It lets you change "100" to "50" or whatever just by using the "elements" command in YAZ. You can also chain facets in elements so that you can run 1 query but get the facets for 5 different elements. (e.g. elements zebra::facet::title:0:100,subject:0:25,itype:0:30) [Sidenote: I see my earlier comments about index case sensitivity aren't correct, at least when using the config.] Yes, I think we've found a solution! Time to start writing code! The only obstacle I see now is determining which indexes need the "index 0". I suppose all the fields currently used for facets...plus pubdate. This will also be an obstacle in terms of having configurable facets. Using "" in the Zebra config would let you spin a query with any facets we want, but relying on that "index 0" will determine which results return usable data... Still...very exciting! I imagine it would be useful to write something a bit abstract for getting facets, so that we can make it easier to plugin other indexers like Solr and ElasticSearch... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 03:33:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 02:33:01 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #29 from David Cook --- PS Is that your way of saying that you're working on this project, Tomas? ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 05:31:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 04:31:08 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 --- Comment #5 from M. Tompsett --- The fix: my $newentry = { %$entry }; takes the hash and generates a copy. This is what: my $newentry = { map { $_ => $entry->{$_} } %$entry }; is supposed to do, but it does it wrong. It could be fixed by making it: my $newentry = { map { $_ => $entry->{$_} } keys %$entry }; However, mapping and access functions to copy are much likely to be slower than just straight copying. Instead of copying { k1 => v1, k2 => v2, ..., kn => vn } The broken code generates { k1 => v1, v1 => undef, k2 => v2, v2 => undef, ... kn => vn, vn => undef } This can create some weird errors if the value of any of those keys is undef. This is also twice the size of the hash. And yes, this fix should be applied to the other line as well. Hope this clarifies, Katrin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 05:38:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 04:38:33 +0000 Subject: [Koha-bugs] [Bug 11505] Untranslatable table headers in Label batch manager In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.12.x will be in 3.12.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 05:42:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 04:42:11 +0000 Subject: [Koha-bugs] [Bug 11502] Branch filter in "Holds To Pull" is too fuzzy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.12.x will be in 3.12.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 05:44:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 04:44:35 +0000 Subject: [Koha-bugs] [Bug 9210] Automatic carriage return are missing in print letters generated for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #23 from Chris Cormack --- Pushed to 3.12.x will be in 3.12.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 06:38:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 05:38:50 +0000 Subject: [Koha-bugs] [Bug 11987] New: Add date ranges to patron and cataloguing stat wizards Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11987 Bug ID: 11987 Summary: Add date ranges to patron and cataloguing stat wizards Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org It would be nice if the patron and cataloguing statistics wizards had more date range options. For instance, patrons could add the "dateenrolled" and "dateexpiry" options. Likewise, cataloguing could have a "datecreated" filter added. At the moment, the stat wizard code looks a bit convoluted and fragile to me. I took a look at adding "dateenrolled" to a 3.8 instance, but the result was being picked up by the "sort" filters instead, so I'm reporting the enhancement idea and putting my work on ice for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 08:31:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 07:31:38 +0000 Subject: [Koha-bugs] [Bug 11985] Auto insert MARC 005 (Date and Time of Latest Transaction) detail when saving new catalog record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11985 --- Comment #1 from M. de Rooy --- Did you see bug 5374? Check the code in ModBiblioMarc.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 08:48:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 07:48:30 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #30 from Paul Poulain --- (In reply to David Cook from comment #29) > PS Is that your way of saying that you're working on this project, Tomas? ;) For now, he's honeymooning ;-) (should be back around april, 15th) > I imagine it would be useful to write something a bit abstract for getting > facets, so that we can make it easier to plugin other indexers like Solr and > ElasticSearch... Of course ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 09:58:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 08:58:53 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Assignee|frederic at tamil.fr |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 10:16:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 09:16:06 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 10:16:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 09:16:39 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #27 from Jonathan Druart --- Created attachment 26529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26529&action=edit Bug 10613: FIX QA issues This patch fixes the following QA issue: FAIL acqui/invoice.pl FAIL valid Useless use of private variable in void context It fixes also the booksellerid variable (supplierid is not used anymore in the template). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 10:18:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 09:18:33 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #28 from Jonathan Druart --- (In reply to Katrin Fischer from comment #24) > FAIL acqui/invoice.pl > FAIL valid > Useless use of private variable in void context (In reply to Jacek Ablewicz from comment #25) > 152 supplierid => $details->{'supplierid'}, > > is indeed not; as a result, link via "Vendor: " name is leading to nowhere. > Which I should've spotted before signing-off :(. Good catches! Fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 10:42:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 09:42:18 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 26530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26530&action=edit Bug 7939 - Separate po files for different MARC dialects [PRELIMINAR - not in final form but can be tested] This patch implements separate PO files for different MARC dialects. To do so it depends on correct filenames, i.e. it will build PO files using files with/without "unimarc|normarc|marc21" on their names. Prominent changes: A) tmpl_process3.pl three new options: exclude or include certain filenames and a new source dir that can have multiple values B) LangInstaller.pm added definitions to create or update nn-NO-{MARCFLAVOR}.po and a little modification on install procedure C) Standarization of filenames OPAC prog po file is now xx-YY-opac-prog.po STAFF po file is now xx-YY-staff-prog.po MARC dialects po files are xx-YY-marc-{MARCFLAVOUR}.po To test: 1) Update po files for your preferred language, ej. nn-NO cd misc/translator perl translate update nn-NO (do it twice if there are warnings) 2) Do some copying/renaming cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-UNIMARC.po cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-NORMARC.po cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-MARC21.po mv po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-staff-prog.po mv po/nn-NO-i-opac-t-prog-v-3006000.po po/nn-NO-opac-prog.po (most MARC dialect strings are on staff) 3) Apply the patch 4) Update again to fix translation files, verbose perl translate update nn-NO -v 5) Install language, verbose, verify translations perl translate install nn-NO -v More tests to come. To be continued... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 10:44:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 09:44:11 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 --- Comment #3 from Bernardo Gonzalez Kriegel --- (In reply to Magnus Enger from comment #0) > I think it would be a good idea to have separate po files for MARC21, > UNIMARC and NORMARC (value builders and XSLT). > > See also Bug 7934. Hi Magnus, do you want to try? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 12:16:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 11:16:53 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #29 from Julian Maurice --- Created attachment 26531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26531&action=edit Bug 7679: Various fixes for circulation statistics wizard - use SQL TRIM functions to avoid having '' and ' ' considered as different values - use Text::Unaccent to remove accents from columns or rows values when accessing %table. This is required as MySQL consider as equals two strings that differ only by their accents when using GROUP BY clause. - Exclude '' values from the list of columns or rows. Otherwise we could have a row 'UNKNOWN VALUE' and a row 'NULL' which both have the same values in their cells. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 12:18:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 11:18:20 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #30 from Julian Maurice --- Hopefully, I easily reproduced your problems. This patch fixed them for me, so I hope it will work for you too :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 13:19:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 12:19:57 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #31 from paxed --- (In reply to Julian Maurice from comment #29) > Created attachment 26531 [details] [review] > Bug 7679: Various fixes for circulation statistics wizard > > - use Text::Unaccent to remove accents from columns or rows values when > accessing %table. This is required as MySQL consider as equals two > strings that differ only by their accents when using GROUP BY clause. In some languages some of these "accented" letters are separate letters of the alphabet, and should not be "unaccented". For example, in Finnish, ? (latin capital a with diaeresis) should not be turned into A. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 14:02:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 13:02:40 +0000 Subject: [Koha-bugs] [Bug 11946] add table sorters to label and patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 --- Comment #1 from Owen Leonard --- Created attachment 26532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26532&action=edit Bug 11946 - add table sorters to label and patron card batches When viewing batches of titles in the label creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. To test, go to Tools -> Labels -> Manage label batches. View an existing batch or create a new batch and populate it with items. Table sorting controls should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 14:02:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 13:02:37 +0000 Subject: [Koha-bugs] [Bug 11946] add table sorters to label and patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 14:39:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 13:39:18 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #77 from M. de Rooy --- I hope this patch will not cause a lot of trouble for non-package users. At least I am struggling now with getting dom indexing to work in master. In 3.14.4 [without this patch], it worked right away. I would not recommend to push this to stable too quickly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 14:51:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 13:51:59 +0000 Subject: [Koha-bugs] [Bug 11988] New: Display basket group close date on late orders Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11988 Bug ID: 11988 Summary: Display basket group close date on late orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 14:52:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 13:52:12 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #78 from Katrin Fischer --- Hi Marcel, all my tests were done on a dev installation and it seemed to work ok there, but I didn't test the very last iteration I think. Can you give some more details about the problems you are facing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 14:52:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 13:52:20 +0000 Subject: [Koha-bugs] [Bug 11988] Display basket group close date on late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |11708 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 14:52:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 13:52:20 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11988 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 14:57:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 13:57:44 +0000 Subject: [Koha-bugs] [Bug 11988] Display basket group close date on late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 14:57:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 13:57:47 +0000 Subject: [Koha-bugs] [Bug 11988] Display basket group close date on late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11988 --- Comment #1 from Jonathan Druart --- Created attachment 26533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26533&action=edit Bug 11988: Display aqbasketgroup.closeddate on late orders table Test plan: Display the late orders table and verify the basket group close date is correctly displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 15:17:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 14:17:55 +0000 Subject: [Koha-bugs] [Bug 11723] Message "A refund has been applied" on all lost item returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11723 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 15:51:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 14:51:19 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #17 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #16) > (In reply to Fridolin SOMERS from comment #11) > > In this case, shall we add noEnterSubmit on select also ? > > I think it does not impact other browser/OS combination. > > It is not what the last patch does? No, this patch corrects behaviors for elements with "noEnterSubmit" class. But this class in actually only set on "input" elements : $("fieldset.rows input").addClass("noEnterSubmit"); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 16:14:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 15:14:26 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #29 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #28) > > FAIL valid > > Useless use of private variable in void context IMO 126: my %row = %{ $order, $line }; was actually a little better ;), being equivalent of: my %row = %$line; and it tested just fine in that form ("Useles use: " warning aside). Looks like merging %$line with %order is 100% redundant (%$line is allways the superset of %$order). > > 152 supplierid => $details->{'supplierid'}, > Fixed. Not fully yet - vendor link still doesn't work; there is no 'supplierid' key in $details->{}, we have 'booksellerid' instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 16:42:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 15:42:42 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #18 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #17) > But this class in actually only set on "input" elements : > $("fieldset.rows input").addClass("noEnterSubmit"); No, the *last* patch does the following : - $("fieldset.rows input").addClass("noEnterSubmit"); + $("fieldset.rows input,select").addClass("noEnterSubmit"); :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 16:59:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 15:59:09 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #19 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #18) > (In reply to Fridolin SOMERS from comment #17) > > But this class in actually only set on "input" elements : > > $("fieldset.rows input").addClass("noEnterSubmit"); > > No, the *last* patch does the following : > - $("fieldset.rows input").addClass("noEnterSubmit"); > + $("fieldset.rows input,select").addClass("noEnterSubmit"); > > :) Ohhhhhh, sorry I had not seen this patch. @Kyle : I think the JQuery selector is not correct : $("fieldset.rows input,select").addClass("noEnterSubmit"); should be : $("fieldset.rows input, fieldset.rows select").addClass("noEnterSubmit"); Also, the pages mancredit.tt and maninvoice.tt are also using noEnterSubmit class. They should have the same JS code no ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 17:00:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 16:00:28 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 17:00:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 16:00:35 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25889|0 |1 is obsolete| | Attachment #25890|0 |1 is obsolete| | Attachment #26529|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 26534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26534&action=edit Bug 10613: The gst rate is not correctly calculated on the invoice page. Test plan: Defined a gst rate on creating an order, receive it and check that all prices are correctly calculated. /!\ Behavior change function of supplier parameters (Include/Don't include tax for list prices and invoice prices) Notes: patch tested with Bug 11755 applied first; confirmed that: - price calculations are correct for all combinations of listincgst/invoiceincgst settings in the vendor record - unitprice (aka "Actual cost") is taken into account on the invoice page instead of rrp/ecost, like it should. Amended patch: Don't change the supplierid/booksellerid parameter. Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 17:00:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 16:00:43 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #31 from Jonathan Druart --- Created attachment 26535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26535&action=edit Bug 10613: FIX typo supplierid vs booksellerid GetInvoiceDetails returns a hashref with a key named booksellerid, not supplierid. The bookseller was not retrieved from the DB and the listincgst value was always false. Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 17:00:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 16:00:50 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #32 from Jonathan Druart --- Created attachment 26536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26536&action=edit Bug 10613: FIX QA issues This patch fixes the following QA issue: FAIL acqui/invoice.pl FAIL valid Useless use of private variable in void context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 17:01:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 16:01:26 +0000 Subject: [Koha-bugs] [Bug 11989] New: Holds Queue Scheduling Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11989 Bug ID: 11989 Summary: Holds Queue Scheduling Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be great to see a transfer schedule set in place so that Koha could take into account days where items are not transferred in and out of a library, and take that into consideration along with the cost matrix. Some libraries only do transfers 1 or 2 times a week, where others transfer 5-7 times a week, or even more. For example: Patron at Library A requests item On Monday: Library B has item, and is best suited according to the cost matrix. Library C has item, and is next best suited according to the cost matrix. What the cost matrix doesn't take into account is that Library B won't transfer any items out until Thursday. Library C transfers daily. So, what happens? The request goes to Library B's queue, and sits in a bin until Thursday. The patron doesn't get the item until Friday, or possibly Monday. However, if transfer days were taken into consideration, the patron could get the item from Library C in a day or two, and the item at Library B doesn't have to sit in a bin for a week. The queue needs to first look at what libraries are transferring, either that day, or the day before (depending on the time of day the holds are pulled and processed and when transfers are picked up), and of those libraries that are close to transfer, then be assessed by the cost matrix. Also, if an item isn't processed at that library (maybe they missed the window), it is reassessed the next day. Perhaps it didn't get pulled and scanned before transfers that day. Now another library might be a better candidate. Of course the transfer schedule, the buffer (how soon before transfer does the library become eligible), and daily reassessment should all be preferences to be set. Anyway, this would be a good addition to the holds queue system. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 17:03:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 16:03:41 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #33 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #29) > and it tested just fine in that form ("Useles use: " warning aside). Looks > like merging %$line with %order is 100% redundant (%$line is allways the > superset of %$order). Yes, you are right, sorry for that. > > > > 152 supplierid => $details->{'supplierid'}, > > Fixed. > > Not fully yet - vendor link still doesn't work; there is no 'supplierid' key > in $details->{}, we have 'booksellerid' instead. I amended the first patch, which introduced this mistake. Thanks Jacek for your vigilance! The last patch needs a signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 18:40:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 17:40:51 +0000 Subject: [Koha-bugs] [Bug 7425] Export Bibliographic Holdings fails if no item records attached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7425 Elaine Bradtke changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |3.14 --- Comment #2 from Elaine Bradtke --- Koha 3.14.03 Further experiences with this problem. Exporting a subset of the catalog selected by item type produces 0 records (these are item types that do not have item records attached). Exporting the whole catalogue as MARC, with items attached fails, the resulting file appears to only contain biblios with items. None of the biblios without items were exported. If I export the whole catalogue without items attached, then it will export all the records. Testing the export as XML: Exporting a subset of records selected by item type still produces 0 records (these are item types that do not have item records attached. Exporting the whole catalog, with items attached produces the expected number of records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 24 20:12:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Mar 2014 19:12:08 +0000 Subject: [Koha-bugs] [Bug 11441] Ability to globally remove authorities with no bibliographic record linked. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11441 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 02:09:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 01:09:45 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #29 from Nicole C. Engard --- Peggy found an error - well we found an error when Peggy reported a problem so I'm marking this as Failed QA until it's fixed. That patch for the ISBN normalizing was throwing the error if the record contained NULL for the isbn field. Kyle can explain/fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 02:56:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 01:56:53 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26530|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 26537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26537&action=edit Bug 7939 - Separate po files for different MARC dialects [PRELIMINAR 2 - not in final form but can be tested] This patch implements separate PO files for different MARC dialects. It depends on correct filenames, i.e. it will build PO files using files with/without "unimarc|normarc|marc21" on their names. Prominent changes: A) tmpl_process3.pl three new options: exclude or include certain filenames and a new source dir that can have multiple values (I opted to add this last feature and not change current source dir in order not to brake current usage) Minor change on use of msgmerge, now there are no backup files (*~) and obsoleted translations are removed (to produce smaller files) [this can be on another bug, is not strictly related with the pourpose of this bug] B) LangInstaller.pm added definitions to create or update nn-NO-{MARCFLAVOR}.po and modification on install procedure to handle multiple target dirs C) Standarization of filenames OPAC prog po file is now xx-YY-opac-prog.po STAFF po file is now xx-YY-staff-prog.po MARC dialects po files are xx-YY-marc-{MARCFLAVOUR}.po [again, renaming not related, can be in it's own bug] To test: 1) Update po files for your preferred language, ej. nn-NO cd misc/translator perl translate update nn-NO (do it twice if there are warnings) 2) Do some copying/renaming cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-UNIMARC.po cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-NORMARC.po cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-MARC21.po mv po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-staff-prog.po mv po/nn-NO-i-opac-t-prog-v-3006000.po po/nn-NO-opac-prog.po (most MARC dialect strings are on staff, so we use that as basis) 3) Apply the patch 4) Update again to fix translation files, verbose perl translate update nn-NO -v 5) Install language, verbose, verify translations perl translate install nn-NO -v 6) Create translation files rm po/nn-NO* perl translate create nn-NO we must have this list: po/nn-NO-marc-MARC21.po po/nn-NO-marc-NORMARC.po po/nn-NO-marc-UNIMARC.po po/nn-NO-opac-bootstrap.po po/nn-NO-opac-ccsr.po po/nn-NO-opac-prog.po po/nn-NO-pref.po po/nn-NO-staff-help.po po/nn-NO-staff-prog.po [staff-help could be more properly staff-prog-help, another rename] Additional tests: 7) Number of msgids 7.a) Before patch and after upgrade, extract and count msgids for i in $(ls po/nn-NO-*po); \ do msginit -i $i -o nn-old.po --no-translator --no-wrap --locale=nn_NO; \ egrep ^msgid nn-old.po >> old; \ done sort new | uniq | tee s-old | wc -l > n-old s-old: have all msgids n-old: number of msgids 7.b) After patch and after creation of new files Repeat procedure, diferent files (s-new, n-new) 7.c) Compare (diff s-old snew), they are the same (save for a strange UNIMARC char in my case) 8) Installed dirs/files 8.a) List of EN dirs/files cd koha-tmpl find | egrep "/en/" > en 8.b) List of nn-NO dirs/files. After patch and language install cd koha-tmpl find | egrep "/nn-NO/" | sed 's|/nn-NO/|/en/|' > nn 8.c) Compare (diff en nn), they are the same (save for a bogus help/nn-NO dir, without files. Working for a solution) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 03:05:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 02:05:45 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 --- Comment #5 from Bernardo Gonzalez Kriegel --- On point 7.a), an error, must be sort old | uniq | tee s-old | wc -l > n-old -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 04:29:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 03:29:58 +0000 Subject: [Koha-bugs] [Bug 11801] In transit hold items incorrectly labeled as "Waiting to be pulled" on request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 04:31:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 03:31:39 +0000 Subject: [Koha-bugs] [Bug 11990] New: Holds ratio report sorts wrong Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11990 Bug ID: 11990 Summary: Holds ratio report sorts wrong Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 26538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26538&action=edit Screenshot showing the wrong sorting The "holds" column in the holds ratio report sorts lexicographically rather than numerically. It probably should also sort in reverse by default, so the things with more holds show at the top. See screenshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 04:51:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 03:51:56 +0000 Subject: [Koha-bugs] [Bug 11991] New: "Item is already waiting" message after in-transit item on hold checked in Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11991 Bug ID: 11991 Summary: "Item is already waiting" message after in-transit item on hold checked in Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 26539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26539&action=edit Screenshot of the hold found (item is already waiting message) When an item on hold that is in transit to another branch is checked in at the library it is transiting to, the confirmation message appears with the text, "hold found (item is already waiting)..." with the confirm/print and confirm buttons. [see attachment for the message screenshot] I don't think the "item is already waiting" text is correct or useful here, as the item just arrived at the library. Is that text purposeful? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 04:52:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 03:52:04 +0000 Subject: [Koha-bugs] [Bug 11991] "Item is already waiting" message after in-transit item on hold checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11991 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.14 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 05:09:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 04:09:55 +0000 Subject: [Koha-bugs] [Bug 11992] New: detail.pl display issue after item on hold & in transit is checked in Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11992 Bug ID: 11992 Summary: detail.pl display issue after item on hold & in transit is checked in Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 26540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26540&action=edit Screenshot of detail.pl item statuses after item is checked in before confirm button When an item on hold is in transit to a library, and is checked in upon receiving it, BEFORE the confirm button is clicked, but AFTER the item is checked in, the detail.pl page shows this status for the item: "Item-level hold for [patron] for delivery at [library name] (placed date)." [attached screenshot "Screenshot of detail.pl item statuses after item is checked in before confirm button"] The item status no longer shows that the item is in transit, even though the confirm button hasn't been clicked yet. Until that confirm button is clicked, I think that status should remain, "In transit from [library a] to [library b] since [date] item-level hold for [patron] for delivery at [library b] (placed [date])". [attached screenshot of item in transit on detail-pl] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 05:10:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 04:10:21 +0000 Subject: [Koha-bugs] [Bug 11992] detail.pl display issue after item on hold & in transit is checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11992 --- Comment #1 from Heather Braum --- Created attachment 26541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26541&action=edit Screenshot of item in transit on detail-pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 05:29:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 04:29:31 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #45 from Robin Sheat --- Too late to do much about it now, but this doesn't follow: http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL14:_Exports and arguably the next one too. We should try to avoid littering the namespace with default exports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:05:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:05:22 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:05:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:05:27 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25637|0 |1 is obsolete| | --- Comment #8 from Fridolin SOMERS --- Created attachment 26542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26542&action=edit Bug 11846 - Correct database update for debarments with 9999-12-31 The borrowers with infinite debarments have borrowers.debarred with '9999-12-31'. Database update for this bug contained : INSERT INTO borrower_debarments ( borrowernumber, expiration, comment ) SELECT borrowernumber, debarred, debarredcomment FROM borrowers WHERE debarred IS NOT NULL For borrowers where borrowers.debarred is '9999-12-31', this value is copied into borrower_debarments.expiration. This is not correct because borrower_debarments.expiration must be NULL for infinite debarments. This patch corrects update 3.13.00.035 and also adds an update for databases already updated. Test plan : - Use a database with verison 3.13.00.000 - Set a borrower as restricted for ever (leave until empty) - Use sources to master + patch - Perform updatedatabase - Look at borrower details, tab "Restrictions" => Without patch, you see Expiration 31/12/9999 => With patch, you see Expiration Infinite -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:13:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:13:43 +0000 Subject: [Koha-bugs] [Bug 9163] Cataloguing validation workflow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #26 from Fridolin SOMERS --- (In reply to Doug Kingston from comment #24) > When using the sandbox to try and test this, I tried searching for 'test' > before proceeding with the test plan and got this error message: > Error: Can't call method "raw" on an undefined value at > /home/koha/src/C4/Search.pm line 490. This is a known bug, it means there is no results, for a search with a sort order not on relevance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:19:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:19:47 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Martin Renvoize --- Well spotted Dobrica, I missed the alternate configuration. I also agree that some documentation would be wise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:37:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:37:34 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m Version|master |3.12 Severity|critical |major --- Comment #13 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:38:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:38:06 +0000 Subject: [Koha-bugs] [Bug 9163] Cataloguing validation workflow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #27 from paxed --- (In reply to Fridolin SOMERS from comment #26) > (In reply to Doug Kingston from comment #24) > > When using the sandbox to try and test this, I tried searching for 'test' > > before proceeding with the test plan and got this error message: > > Error: Can't call method "raw" on an undefined value at > > /home/koha/src/C4/Search.pm line 490. > This is a known bug, it means there is no results, for a search with a sort > order not on relevance. Indeed: See bug 9578 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:40:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:40:22 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:40:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:40:25 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26147|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 26543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26543&action=edit [SIGNED OFF] Bug 8148 - LDAP auth_by_bind doesn't fallback to local auth This patch covers LDAP auth_by_bind configuration so that wrong LDAP password will return -1 to C4::Auth so we can abort local auth and prevent users logging in with stale database passwords. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:41:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:41:32 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 --- Comment #18 from Martin Renvoize --- I'm happy that with Dobrica's amendment this catches all cases now. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:41:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:41:47 +0000 Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:43:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:43:49 +0000 Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:46:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:46:21 +0000 Subject: [Koha-bugs] [Bug 11476] Opac self registration title pull down offers 2 empty options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11476 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Patch pushed to 3.14.x, will be in 3.14.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:51:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:51:34 +0000 Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972 --- Comment #24 from Martin Renvoize --- Ah yes, I remember the talk now, I was there. Happy to pass QA on this now then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:56:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:56:43 +0000 Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972 --- Comment #25 from Martin Renvoize --- Created attachment 26544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26544&action=edit [PASSED QA] Bug 9972 Add/ change some zebra indexes (MARC21) This patch adds :w and :p versions to the index for ?Lexile number? (it has only :n so far) and adds indexes for 653 (Index term uncontrolled), 655 (Index term Genre/Form), 041 (language-audio) and 041 (language-subtitle). It also adds the ?curriculum?-index to Search.pm. Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:57:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:57:01 +0000 Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 09:57:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 08:57:20 +0000 Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:05:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:05:53 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #4 from Martin Renvoize --- I look forward to it, and will happily test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:06:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:06:31 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:06:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:06:36 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #20 from Jonathan Druart --- Created attachment 26545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26545&action=edit Bug 11563: (followup) Disable add noEnterSubmit to pulldowns Test plan: To test on modified pages: - Press enter when cursor is on input or select and verify the form is not submitted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:11:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:11:19 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #14 from Fridolin SOMERS --- I've changed importance by mistake -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:23:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:23:11 +0000 Subject: [Koha-bugs] [Bug 11993] New: Untranslatable confirm popup in request.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 Bug ID: 11993 Summary: Untranslatable confirm popup in request.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr request.tt has the following untranslatable confirm popup: "Are you sure you want to delete this hold?" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:40:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:40:05 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:40:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:40:14 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25158|0 |1 is obsolete| | Attachment #25159|0 |1 is obsolete| | Attachment #25160|0 |1 is obsolete| | Attachment #25161|0 |1 is obsolete| | Attachment #25162|0 |1 is obsolete| | Attachment #25231|0 |1 is obsolete| | Attachment #25232|0 |1 is obsolete| | Attachment #25233|0 |1 is obsolete| | --- Comment #109 from Jonathan Druart --- Created attachment 26546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26546&action=edit Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set "Block expired patrons" to "Don't block" 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set "Block expired patrons" to "Follow system preference BlockExpiredPatronOpacActions" 9) Set the system preference BlockExpiredPatronOpacActions to "Block" 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to "Don't block" 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall Signed-off-by: Melia Meggs Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:40:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:40:24 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #110 from Jonathan Druart --- Created attachment 26547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26547&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:40:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:40:31 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #111 from Jonathan Druart --- Created attachment 26548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26548&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:40:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:40:38 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #112 from Jonathan Druart --- Created attachment 26549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26549&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Installer fixes : - in kohastructure.sql, category.BlockExpiredPatronOpacActions default value is -1, sets the same in updatedatabase.pl - in syspref comment, replaces "opac actions such as placing a hold or reserve" by "opac actions such as placing holds or renrw books" - A 'YesNo' does not have 'yes' as value in database, it is '1'. - corrects small typo "categori" and syspref name case Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:40:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:40:45 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #113 from Jonathan Druart --- Created attachment 26550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26550&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening

    instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : instead of , maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. => Verified all actions work as expected. => Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) => OK, both actions are blocked. b) category: use syspref (default) syspref: don't block => OK, both actions possible. c) category: block syspref: don't block => OK, both actions are blocked. d) category: block syspref: block => OK, both actions are blocked. e) category: don't block sypref: block => OK, both actions possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:40:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:40:52 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #114 from Jonathan Druart --- Created attachment 26551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26551&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 5 - Fixes a typo in one of the OPAC messages: "you account" - Fixes the updatedatabase script to use 1 instead of yes for the system preference default matching the sysprefs.sql file. - Fixes capitalization "Don't Block" in system preference description. - Adding . to the end of the warning, when renewals are blocked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:40:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:40:58 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #115 from Jonathan Druart --- Created attachment 26552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26552&action=edit Bug 6739: FIX conflicts with some others bugs. see comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:41:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:41:05 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #116 from Jonathan Druart --- Created attachment 26553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26553&action=edit Bug 6739: template changes for the bootstrap theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 10:41:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 09:41:47 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #117 from Jonathan Druart --- (In reply to Katrin Fischer from comment #108) > I am sorry, there is a conflict I can't resolve in this patch series: Patches rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 11:10:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 10:10:22 +0000 Subject: [Koha-bugs] [Bug 11988] Display basket group close date on late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26533|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 26554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26554&action=edit Bug 11988: Display aqbasketgroup.closeddate on late orders table Test plan: Display the late orders table and verify the basket group close date is correctly displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 11:47:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 10:47:12 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26334|0 |1 is obsolete| | --- Comment #9 from Julian Maurice --- Created attachment 26555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26555&action=edit Bug 11425: Add item search form in staff interface Rebased on master Fixed bug number in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 11:47:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 10:47:26 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26335|0 |1 is obsolete| | --- Comment #10 from Julian Maurice --- Created attachment 26556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26556&action=edit Bug 11425: Add unit tests Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 11:47:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 10:47:39 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #11 from Julian Maurice --- Created attachment 26557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26557&action=edit Bug 11425: Add filter on items.notforloan column and display the 'Processing ...' box when datatables is loading new data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 11:48:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 10:48:54 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Julian Maurice --- (In reply to Pascale Nalon from comment #7) > test on sandbox and then : > Software error: > > Template process failed: plugin error - JSON.Escape: plugin not found at > /home/koha/src/C4/Templates.pm line 132. > For help, please send mail to the webmaster > (webmaster at matrice-koha36-sandbox), giving this error message and the time > and date of the error. This development has additional dependencies which are not installed on sandboxes. Please tell me which sandbox you are using and I will install the required dependencies on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 11:49:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 10:49:44 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 11:56:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 10:56:12 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 11:56:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 10:56:16 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26536|0 |1 is obsolete| | --- Comment #34 from Jacek Ablewicz --- Created attachment 26558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26558&action=edit Bug 10613: FIX QA issues This patch fixes the following QA issue: FAIL acqui/invoice.pl FAIL valid Useless use of private variable in void context Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 12:02:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 11:02:47 +0000 Subject: [Koha-bugs] [Bug 11473] View log template has malformed conditionals, and logging info incorrect/inconsistent/unexpected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11473 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #15 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 12:07:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 11:07:05 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #35 from Jacek Ablewicz --- Btw, the patches don't have [SIGNED-OFF] added in headers (I signed off the 3rd one without it too, for the sake of consistency). I don't know if this is really important or not - if yes, I'll try to re-sign-off all 3 patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 12:15:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 11:15:03 +0000 Subject: [Koha-bugs] [Bug 11581] HTTP 404s generated badly in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11581 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolin SOMERS --- Indeed. I think there should be HTML static pages for all HTTP error codes. They should be used in both apache configuration and in GCI output (maybe adding methods into C4::Output). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 12:18:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 11:18:45 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #13 from Fridolin SOMERS --- Patches pushed to 3.14.x, will be in 3.14.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 12:24:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 11:24:15 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #36 from Katrin Fischer --- Hi Jacek, it's not a problem as long as the status is correct "Signed off" it will show up in our searches :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 13:09:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 12:09:27 +0000 Subject: [Koha-bugs] [Bug 11994] New: Add option for installing a search plugin for Koha Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 Bug ID: 11994 Summary: Add option for installing a search plugin for Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org One of our libraries has asked about a search plugin for Koha and I did some experimenting. The needed xml could look something like this: Short name Longer description UTF-8 I also found different options to make this visible to the user: A link using Javascript, similar to what Bugzila itself offers on the start page: Search Plugin This seems to work nicely in Firefox and IE. Another option is using a link tag in the header. This will offer to install the plugin when you open the pull down of your search targets. It seems to only work in Firefox and not in IE. Example: http://swb2.bsz-bw.de/ I thought maybe it would be nice to offer a plugin by default, using Koha's OpacBaseURL and LibraryName system preferences to fill out the required fields. This could be helpful for libraries with hosted Koha solutions that don't have the option to create an .xml file and store it on a web server themselves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 13:51:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 12:51:16 +0000 Subject: [Koha-bugs] [Bug 11995] New: Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 Bug ID: 11995 Summary: Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Serials Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Bug 7688 changes the prototype for GetNextDate. The serialsUpdate.pl cronjob script has not been updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 13:52:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 12:52:15 +0000 Subject: [Koha-bugs] [Bug 11995] Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 --- Comment #1 from Julian Maurice --- Created attachment 26559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26559&action=edit Bug 11995: Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl Bug 7688 changes the prototype for GetNextDate. The serialsUpdate.pl cronjob script has not been updated. Test plan: Before applying the patch: 1/ Check that the following SQL query returns something: SELECT serial.* FROM serial LEFT JOIN subscription ON (subscription.subscriptionid = serial.subscriptionid) WHERE serial.status = 1 AND DATE_ADD(planneddate, INTERVAL CAST(graceperiod AS SIGNED) DAY) < NOW() AND subscription.closed = 0; 2/ Run misc/cronjobs/serialsUpdate.pl -v It should die with an error message like this: Can't use string ("2011-03-05") as a HASH ref while "strict refs" in use 3/ Apply the patch 4/ Run misc/cronjobs/serialsUpdate.pl -v It should exit normally and print messages like this: Serial issue with id=XX updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 13:52:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 12:52:24 +0000 Subject: [Koha-bugs] [Bug 11995] Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 13:59:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 12:59:19 +0000 Subject: [Koha-bugs] [Bug 11994] Add option for installing a search plugin for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #1 from Katrin Fischer --- The URL to the favicon could be taken from Koha's system preferences as well: http://example.com/favicon.ico -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 14:55:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 13:55:19 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 --- Comment #9 from M. Tompsett --- Thanks for the fix. However, you still didn't address my question in comment 2. "why even fix the old one?" If it upgrades incorrectly (because you upgrade an older one), the current one will fix it. If it already upgraded incorrectly (because you upgrade after the back patch fix), the current one will fix it. I see no reason to change historical versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 15:28:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 14:28:14 +0000 Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Is there a reason not to fix the old update? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 15:48:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 14:48:39 +0000 Subject: [Koha-bugs] [Bug 11701] Fix C4::Context::Zconn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11701 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 15:54:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 14:54:40 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #21 from Christopher Brannon --- I can't sign off on this. I tested memberentry.pl, and the class is not added: mancredit.pl also fails: It does not look like the jquery is applying the modification. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:05:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:05:36 +0000 Subject: [Koha-bugs] [Bug 11939] Sample of currencies with a working active value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #15 from Galen Charlton --- Pushed to master. Thanks, Jonathan and Zeno! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:08:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:08:51 +0000 Subject: [Koha-bugs] [Bug 11996] New: default active currencies for ru-RU and uk-UA are probably wrong Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11996 Bug ID: 11996 Summary: default active currencies for ru-RU and uk-UA are probably wrong Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com As of the patch for bug 11939, the default currencies for Russia (ru-RU) and Ukraine (uk-UA) are "GRN". As near as I can tell, nowadays it should be the RUB (ruble) for Russia and the UAH (hryvnia) for Ukraine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:11:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:11:19 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #22 from Christopher Brannon --- I think the correct code would read: $("fieldset input, fieldset select").addClass("noEnterSubmit"); The .row misdirects the selector. I've tested this, and this applies correctly. However, I am not a patch writer. I'll leave that to you guys. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:17:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:17:56 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #23 from Jonathan Druart --- The class noEnterSubmit should be added to input and select elements in the form. Not on the submit button/input. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:29:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:29:01 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #24 from Christopher Brannon --- Well, ignore my comments. For some reason, it wasn't working at first. Now it is. Sorry guys. Don't know why this happens. I can confirm it works now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:32:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:32:12 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #25 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:32:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:32:33 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26443|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:32:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:32:39 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26444|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:32:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:32:45 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26445|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:32:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:32:51 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26545|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:32:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:32:58 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #26 from sandboxes at biblibre.com --- Created attachment 26560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26560&action=edit Bug 11563 - Class noEnterSubmit no longer functioning For some reason, even if an input as the class noEnterSubmit, the code found in staff-global.js for preventing submission when hitting the enter key is no longer triggered. This is because this class is added using JavaScript in $(document).ready() and the keypress event listerning is also set using $(document).ready(). This patch corrects by using JQuery live() with will set event listerning event for HTML generated with JavaScript. Alos sets noEnterSubmit to use the checkEnter(e) function, containing a more correct code. Also corrects a small bug, for IE, window.event must be used, not event alone (even if IE is not supported for intranet). Test plan : - Flush browser cache (Crtl+F5) to update js files - Go to patron creation : members/memberentrygen.tt - Type a text in all mandatory inputs - Type some caracters in a non mandatory input - Press Enter key => Without patch : the form is submitted => With patch : the form is not submitted - Try to set several lines in a textarea => It works (checks that in this case enter key is allowed) - Test other pages usign noEnterSubmit class : cataloguing/additem.tt course_reserves/course.tt members/mancredit.tt members/maninvoice.tt patron_lists/list.tt Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:33:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:33:03 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #27 from sandboxes at biblibre.com --- Created attachment 26561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26561&action=edit Bug 11563 [QA Followup] - Change .live() to .on() The jquery event handler .live() has been deprecated. It is recommended that .on() be used instead. Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:33:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:33:08 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #28 from sandboxes at biblibre.com --- Created attachment 26562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26562&action=edit Bug 11563 [QA Followup] - Disable add noEnterSubmit to pulldowns When using Chrome on Mac OS X, form submits are triggered by hitting enter when focused on a select. This is not an issue with any other combincation of browser and operating system that I am aware of. Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 16:33:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 15:33:12 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #29 from sandboxes at biblibre.com --- Created attachment 26563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26563&action=edit Bug 11563: (followup) Disable add noEnterSubmit to pulldowns Test plan: To test on modified pages: - Press enter when cursor is on input or select and verify the form is not submitted. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 18:18:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 17:18:42 +0000 Subject: [Koha-bugs] [Bug 11997] New: Download / export lists of records coding and format errors Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997 Bug ID: 11997 Summary: Download / export lists of records coding and format errors Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Either from OPAC and Intranet, while exporting lists with formats "MARC" (OPAC) / "Iso2709" (on Intranet; different name to same thing) the downloaded file named "shelf.iso2709" is on latin1 instead of utf8, never reporting this, and also it seems very buggy: $ yaz-marcdump -f latin1 -t utf8 -i marc -o line "shelf.iso2709" | head -n30 [...] 245 00 $a Introducci?n general a la inform?tica : $b perif?ricos y redes locales / $c Mario Carlos Ginzburg; ilustrado por Rafael Ginzburg (Separator but not at end of field length=134) 250 a4 $ ed. (Separator but not at end of field length=11) 260 aB $e nos Aires : $b Mario Carlos Ginzburg, $c 2006 (Separator but not at end of field length=51) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 18:28:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 17:28:33 +0000 Subject: [Koha-bugs] [Bug 11946] add table sorters to label and patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26532|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 26564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26564&action=edit Bug 11946 - add table sorters to label and patron card batches When viewing batches of titles in the label creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. To test, go to Tools -> Labels -> Manage label batches. View an existing batch or create a new batch and populate it with items. Table sorting controls should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 18:29:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 17:29:23 +0000 Subject: [Koha-bugs] [Bug 11946] add table sorters to label and patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 18:29:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 17:29:26 +0000 Subject: [Koha-bugs] [Bug 11946] add table sorters to label and patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26564|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard --- Created attachment 26565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26565&action=edit [SIGNED-OFF] Bug 11946 - add table sorters to label and patron card batches When viewing batches of titles in the label creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. To test, go to Tools -> Labels -> Manage label batches. View an existing batch or create a new batch and populate it with items. Table sorting controls should work correctly. Signed-off-by: Nicole C. Engard Solves 1/2 of this bug which is to add the sorters to labels, the original request was to add this to patron cards as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 18:30:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 17:30:33 +0000 Subject: [Koha-bugs] [Bug 11946] add table sorters to label and patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 --- Comment #4 from Nicole C. Engard --- More accurately, I asked to get the sorter added to patron cards and when I reported the issue here I said patron cards and labels in the title. So if there can be a follow up to add this to the patron cards that would be awesome! Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 19:23:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 18:23:17 +0000 Subject: [Koha-bugs] [Bug 11978] OverDrive API now prepends http:// to URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Patch complexity|Trivial patch |--- Severity|enhancement |major --- Comment #2 from Jesse Weaver --- Raising importance, as this blocks clicking of links in any OPAC using OverDrive. Good candidate for a maintenance patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 19:25:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 18:25:08 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 --- Comment #9 from Jesse Weaver --- Yes, that's the plan. If the interface is truly unusable as it stands, I'll submit a followup to make it better, but otherwise the plan is to get in 8133 as soon as possible afterwards. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 19:29:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 18:29:21 +0000 Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding and format errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997 --- Comment #1 from Pablo AB --- Selecting 8859-1 (latin1) while staging records for import doesn't fix the issue. A workaround was to: yaz-iconv -f latin1 -t utf8 shelf.iso2709 > shelf.iso2709-utf This "fix" the file and then yaz-marcdump shelf.iso2709-utf gives the expected output. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 20:45:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 19:45:50 +0000 Subject: [Koha-bugs] [Bug 11292] barcode scanner clicking 'save' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:36:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:36:36 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #38 from Brendan Gallagher --- (In reply to Holger Mei?ner from comment #37) > Hello Brendan, > > thanks for looking at this patch! > > (In reply to Brendan Gallagher from comment #36) > > I do have one comment and maybe you can test this. If you set the "Loan > > period" to say 4 day loan and you set the "No renewal before" to 5 days, > > shouldn't you always be able to renew the material? > > Yes, you should definitely be able to renew. I'm unable to reproduce this > problem. When I check something out with a loan period of 4 days and "No > renewal before" set to 5, I can renew immediately. > > I have no idea what might cause this problem for you. > > Could you supply a screenshot of the checkout page? What exactly is > displayed in the columns "Due date" and "Renew"? Hmm... Holger - I am not able to repeat the problem I saw earlier. Let me do a little more testing and see if I can repeat it. hang with me a few... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:51:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:51:13 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26560|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer --- Created attachment 26566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26566&action=edit Bug 11563 - Class noEnterSubmit no longer functioning For some reason, even if an input as the class noEnterSubmit, the code found in staff-global.js for preventing submission when hitting the enter key is no longer triggered. This is because this class is added using JavaScript in $(document).ready() and the keypress event listerning is also set using $(document).ready(). This patch corrects by using JQuery live() with will set event listerning event for HTML generated with JavaScript. Alos sets noEnterSubmit to use the checkEnter(e) function, containing a more correct code. Also corrects a small bug, for IE, window.event must be used, not event alone (even if IE is not supported for intranet). Test plan : - Flush browser cache (Crtl+F5) to update js files - Go to patron creation : members/memberentrygen.tt - Type a text in all mandatory inputs - Type some caracters in a non mandatory input - Press Enter key => Without patch : the form is submitted => With patch : the form is not submitted - Try to set several lines in a textarea => It works (checks that in this case enter key is allowed) - Test other pages usign noEnterSubmit class : cataloguing/additem.tt course_reserves/course.tt members/mancredit.tt members/maninvoice.tt patron_lists/list.tt Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:51:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:51:18 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #31 from Katrin Fischer --- Created attachment 26567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26567&action=edit [PASSED QA] Bug 11563 [QA Followup] - Change .live() to .on() The jquery event handler .live() has been deprecated. It is recommended that .on() be used instead. Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:51:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:51:21 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #32 from Katrin Fischer --- Created attachment 26568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26568&action=edit [PASSED QA] Bug 11563 [QA Followup] - Disable add noEnterSubmit to pulldowns When using Chrome on Mac OS X, form submits are triggered by hitting enter when focused on a select. This is not an issue with any other combincation of browser and operating system that I am aware of. Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:51:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:51:26 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #33 from Katrin Fischer --- Created attachment 26569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26569&action=edit [PASSED QA] Bug 11563: (followup) Disable add noEnterSubmit to pulldowns Test plan: To test on modified pages: - Press enter when cursor is on input or select and verify the form is not submitted. Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:58:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:58:21 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #34 from Katrin Fischer --- Created attachment 26570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26570&action=edit [PASSED QA] Bug 11563 - Class noEnterSubmit no longer functioning For some reason, even if an input as the class noEnterSubmit, the code found in staff-global.js for preventing submission when hitting the enter key is no longer triggered. This is because this class is added using JavaScript in $(document).ready() and the keypress event listerning is also set using $(document).ready(). This patch corrects by using JQuery live() with will set event listerning event for HTML generated with JavaScript. Alos sets noEnterSubmit to use the checkEnter(e) function, containing a more correct code. Also corrects a small bug, for IE, window.event must be used, not event alone (even if IE is not supported for intranet). Test plan : - Flush browser cache (Crtl+F5) to update js files - Go to patron creation : members/memberentrygen.tt - Type a text in all mandatory inputs - Type some caracters in a non mandatory input - Press Enter key => Without patch : the form is submitted => With patch : the form is not submitted - Try to set several lines in a textarea => It works (checks that in this case enter key is allowed) - Test other pages usign noEnterSubmit class : cataloguing/additem.tt course_reserves/course.tt members/mancredit.tt members/maninvoice.tt patron_lists/list.tt Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Works as described, tested in Firefox and Chromium. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:58:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:58:26 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26567|0 |1 is obsolete| | --- Comment #35 from Katrin Fischer --- Created attachment 26571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26571&action=edit [PASSED QA] Bug 11563 [QA Followup] - Change .live() to .on() The jquery event handler .live() has been deprecated. It is recommended that .on() be used instead. Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:58:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:58:30 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26568|0 |1 is obsolete| | --- Comment #36 from Katrin Fischer --- Created attachment 26572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26572&action=edit [PASSED QA] Bug 11563 [QA Followup] - Disable add noEnterSubmit to pulldowns When using Chrome on Mac OS X, form submits are triggered by hitting enter when focused on a select. This is not an issue with any other combincation of browser and operating system that I am aware of. Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:58:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:58:35 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26569|0 |1 is obsolete| | --- Comment #37 from Katrin Fischer --- Created attachment 26573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26573&action=edit [PASSED QA] Bug 11563: (followup) Disable add noEnterSubmit to pulldowns Test plan: To test on modified pages: - Press enter when cursor is on input or select and verify the form is not submitted. Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:59:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:59:28 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:59:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:59:30 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26561|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:59:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:59:33 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26562|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:59:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:59:37 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26563|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 21:59:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 20:59:40 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26566|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 22:09:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 21:09:36 +0000 Subject: [Koha-bugs] [Bug 11292] barcode scanner clicking 'save' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I just tested 11563 for QA, but it doesn't fix this specific problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 23:40:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 22:40:23 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #37 from Katrin Fischer --- Working on this again... it IS confusing, will need some more time for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 23:47:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 22:47:20 +0000 Subject: [Koha-bugs] [Bug 8394] No physical item for this record on records after mysqldump and zebra rebuild In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8394 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |liz at catalyst.net.nz Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 23:47:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 22:47:44 +0000 Subject: [Koha-bugs] [Bug 8393] No physical item for this record for stage marc imported records with items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8393 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |liz at catalyst.net.nz Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 25 23:47:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Mar 2014 22:47:45 +0000 Subject: [Koha-bugs] [Bug 8394] No physical item for this record on records after mysqldump and zebra rebuild In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8394 Bug 8394 depends on bug 8393, which changed state. Bug 8393 Summary: No physical item for this record for stage marc imported records with items http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8393 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 05:12:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 04:12:54 +0000 Subject: [Koha-bugs] [Bug 11988] Display basket group close date on late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11988 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 05:12:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 04:12:59 +0000 Subject: [Koha-bugs] [Bug 11988] Display basket group close date on late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11988 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26554|0 |1 is obsolete| | --- Comment #3 from David Cook --- Created attachment 26574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26574&action=edit Bug 11988: Display aqbasketgroup.closeddate on late orders table Test plan: Display the late orders table and verify the basket group close date is correctly displayed. Signed-off-by: David Cook Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 05:50:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 04:50:29 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #26 from David Cook --- This feature seems a bit bizarre to me. In my experience, library staff periodically gather up materials lying around, and check them in as an "in-house use" before re-shelving. This is useful in that it shows that someone used it (at least once) even if they didn't actually check it out from the library. However, this feature doesn't seem to be that type of "in-house use". If I understand correctly, this would actually be a check-out to a patron? The idea being that they're not allowed to take it out of the library? That it would be due back at the desk before the library closes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:04:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:04:22 +0000 Subject: [Koha-bugs] [Bug 11998] New: Syspref caching issues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Bug ID: 11998 Summary: Syspref caching issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Sysprefs are cached in process, which is a problem when you have multiple plack workers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:04:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:04:40 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |7172 Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:04:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:04:40 +0000 Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11998 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:09:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:09:11 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #1 from Robin Sheat --- Created attachment 26575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26575&action=edit Bug 11998 - timeout for syspref caching This adds a 30 second timeout for syspref caching so that when run under plack, you don't end up with different workers having different ideas of what the sysprefs are for too long. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:10:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:10:52 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #2 from Robin Sheat --- There will be some followups to this: improve the way sysprefs are saved by admin/systempreferences.pl, and to enable storing of sysprefs in memcache in preference to the in-process cache, if it's available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:16:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:16:55 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #11 from David Cook --- I'm not certain about the utility of this patch... What happens if an item has a hold, can't be checked out to that patron, etc.? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:18:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:18:21 +0000 Subject: [Koha-bugs] [Bug 11859] Add edition and publication year to PDF templates in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:24:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:24:11 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- I think I would prefer to pursue bug 10486 as it should work with any Z39.50 target. Also, this patch appears to duplicate a lot of Z39.50 searching code. Seeing that I already made a copy of a lot of the code with the Z39.50 authority search, I think we should be looking to minimize boilerplate/duplicated code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:40:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:40:55 +0000 Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- I think I can see why a library might want an "Acquisition Details" tab, but it seems a bit...transparent? I don't know if all libraries would want all the details of their orders to show up in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:43:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:43:24 +0000 Subject: [Koha-bugs] [Bug 11769] Use validation plugin when creating new MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- I should remember to take a look at this tomorrow... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:53:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:53:23 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #14 from David Cook --- Looks OK at a glance, but the updatedatabase.pl is for Koha 3.13, so you'll want to update that. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:56:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:56:06 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #12 from David Cook --- *pinging Joy* I've been thinking about sending in a patch for wrapping the call number, but I should probably wait until this is sorted out first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:57:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:57:08 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:58:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:58:08 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #12 from David Cook --- We have the same local enhancement. This would be another one that could benefit from using a WYSIWYG editor on the syspref. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 07:59:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 06:59:55 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #46 from David Cook --- I'm even all right with benign dictatorship saying how it's going to be from here on out, but it would be good to have firm guidelines in place... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 08:07:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 07:07:43 +0000 Subject: [Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #6 from David Cook --- 008/15-17 is actually a bit more variable than "country". Sometimes, it's country but other times it's actually state/province (http://www.loc.gov/marc/bibliographic/bd008a.html). In any case, it's in a coded format, which is probably useless to all except the most hardcore human users. Good call on "pl Place-publication" being 260$a instead of the whole of 260. That said, you'll also want to include 264$a...but only when the 2nd indicator of 264 is set to 1 (http://www.loc.gov/marc/bibliographic/bd264.html). You have to love RDA... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 08:08:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 07:08:06 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 --- Comment #15 from Chris Cormack --- Pushed to 3.12.x will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 08:14:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 07:14:51 +0000 Subject: [Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- Pushed to 3.12.x will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 08:15:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 07:15:49 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #19 from David Cook --- I'm quite interested in linking records, so I might have to take a look at this one. I haven't reviewed the code or applied the patch yet, but how might this fare with a high number of child records? In the case of a journal with article component parts, you might have dozens, hundreds, or more child records for each parent. I wonder if this would be handled better by an AJAX call and using the relational database instead of XML records. In any case, I'll take a look later, but just a thought... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 08:30:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 07:30:35 +0000 Subject: [Koha-bugs] [Bug 8991] Add a script to delete old orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #20 from David Cook --- I agree with Galen and Katrin. I don't think that many libraries would find this script useful. In fact, from a regulatory financial perspective, it could be extremely problematic. Libraries aren't always known for keeping the best accounting records, so acquisitions data is often the only record. If it disappears, there could be trouble as one of the key components of the audit trail vanishes. >From an archival/records management perspective, it doesn't make sense to erase these records. These data are records. If they aren't 'active' or relevant anymore, they should be exported into some type of "semi-active" or "inactive" state. As Galen suggests, an output of the purge should be kept. Going back to the regulatory perspective, when the time comes to officially dispose of the records, the archived output can be deleted. I think that probably makes the most sense. Of course, I might be biased, as I'm the one saying it :p. I could maybe see this being set up as a cronjob on an instance by instance basis, but definitely not setup as a default cronjob. I imagine there would be quite a few furious acquisitions librarians otherwise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 08:47:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 07:47:08 +0000 Subject: [Koha-bugs] [Bug 10482] add items limit and sort to rebuild zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10482 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- Bug 11096 should take care of the record size problem. As for limiting the number of items...I'm not sure that an arbitrary cut off is the best idea, as it will lead to unexpected/unpredictable results. Off the top of my head, it should also create problems with search. The barcode (i.e. "bc") and call number indexes being the ones that spring immediately to mind. I haven't put too much thought into it at this point, but...this patch seems like it would introduce a lot of (sometimes silent) problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 09:19:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 08:19:13 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #12 from Jonathan Druart --- (In reply to David Cook from comment #11) > I'm not certain about the utility of this patch... I tried to explain the goal of the patch in the description of this report. > What happens if an item has a hold, can't be checked out to that patron, > etc.? This patch catches errors/warnings using the same tests as the "normal" checkout. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 09:29:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 08:29:54 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #27 from Jonathan Druart --- (In reply to David Cook from comment #26) > If I understand correctly, this would actually be a check-out to a patron? > The idea being that they're not allowed to take it out of the library? That > it would be due back at the desk before the library closes? Yes, exactly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 09:32:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 08:32:56 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #28 from Katrin Fischer --- Hm, maybe it's more like a 'reading room' use then? Not sure if that's the right term in English, but I think we have something similar here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 09:39:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 08:39:24 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #20 from Olli-Antti Kivilahti --- Thank you for your comment! AJAX might be a better option. You are free to submit any changes. The complexity of such goes way over what we can develop given our timeframe. For us this feature works relatively well since we only have a couple of hundred records in our database with over 100 component parts. I can totally see the caching issues, but returning only a subset of a search query from Zebra is beyond my competence. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 10:05:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 09:05:25 +0000 Subject: [Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413 --- Comment #39 from Holger Mei?ner --- There is of course one thing that may be a bit confusing and depends on the chosen unit. If you use hours, a loan period of 4 and norenewalbefore 4, you can renew instantly. If you use days, a loan period of 4 and norenewalbefore 4, you can't. Unless the checkout is just before midnight. Because the time of the due date is always set to 23:59. And the functionality is based solely on the exact datetime of the due date. This might not always be desired or expected, but I guess it's better than making assumptions about what libraries want instead. And it won't break, if at some point in the future someone introduces a patch that makes it possible to set a different time for the due date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 10:07:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 09:07:48 +0000 Subject: [Koha-bugs] [Bug 11995] Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |7688 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 10:07:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 09:07:48 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11995 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 10:50:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 09:50:40 +0000 Subject: [Koha-bugs] [Bug 11916] Borrower Imports Refactor/Rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11916 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 11:04:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 10:04:25 +0000 Subject: [Koha-bugs] [Bug 10482] add items limit and sort to rebuild zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10482 --- Comment #5 from Fridolin SOMERS --- (In reply to David Cook from comment #4) > Bug 11096 should take care of the record size problem. Indeed. But this is only an indexing option, not mandatory to use. It is made to cut off if there is a huge number of items, like more than 100. It corrects a problem and makes indexing faster. So why not adding it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 12:02:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 11:02:20 +0000 Subject: [Koha-bugs] [Bug 11269] Latest MARC::Record makes visible some wrong usage of field->subfield in C4::Search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11269 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- @Galen, The module MARC::Record should also be fixed no ? Test if $code_wanted is not undef in subfield(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 12:45:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 11:45:56 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 13:08:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 12:08:56 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Jonathan Druart --- Jesse, Could you please: - execute db dependent unit tests into a transaction. - change the prototype for routines in C4::Calendar with more than 1 parameter (using hashref). - remove unused routines in Koha::Calendar (at least single_holidays). Do you think this patch should be integrated into 3.16 or it is useless and it could be wait for the next release (since bug 8133 is not ready yet)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 13:54:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 12:54:44 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #68 from Jonathan Druart --- QA comment: 1) + $template->param( $lang => 1 ) if $lang; Why ? Seems not used in template. But maybe I am wrong. 2) - # $query.= "LIMIT 0, " . $limit; + # $query.= 'LIMIT 0, ' . $limit; Could be removed 3) + if ($lang && $branchcode) { + $query .= " WHERE (opac_news.lang='' OR opac_news.lang=?)"; + $query .= " AND (opac_news.branchcode IS NULL OR opac_news.branchcode=?)"; + push @values,$lang; + push @values,$branchcode; + } + elsif ($lang) { + $query .= " WHERE (opac_news.lang='' OR opac_news.lang=?)"; + push @values,$lang; + } + elsif ($branchcode) { + $query .= " WHERE (opac_news.branchcode IS NULL OR opac_news.branchcode=?)"; + push @values,$branchcode; + } Maybe the following is more readable: $query .= " WHERE 1 "; if ( $lang ) { $query .= "AND (opac_news.lang='' OR opac_news.lang=?)"; push @values, $lang } and same for $branchcode 4) s/branch/library in templates 5) in opac-main.tt - [% IF ( koha_news_count ) %]

    + [% IF ( koha_news_count ) %] Why? It will produce an empty div. 6) Some QA issues (minor): FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt FAIL forbidden patterns forbidden pattern: tab char (line 233) forbidden pattern: tab char (line 169) forbidden pattern: tab char (line 227) forbidden pattern: tab char (line 229) forbidden pattern: tab char (line 228) forbidden pattern: tab char (line 225) forbidden pattern: tab char (line 167) forbidden pattern: tab char (line 231) FAIL koha-tmpl/opac-tmpl/prog/en/modules/opac-main.tt FAIL forbidden patterns forbidden pattern: tab char (line 25) 7) It would be great to pass a hashref to get_opac_news Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 14:36:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 13:36:37 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #79 from M. de Rooy --- (In reply to Katrin Fischer from comment #78) > Hi Marcel, all my tests were done on a dev installation and it seemed to > work ok there, but I didn't test the very last iteration I think. Can you > give some more details about the problems you are facing? OK. It seems to work fine. I was struggling with marcxml as element set name. But in a clean master it must work. I do not think that marcxml is an element set name (as we did use F for full in the old situation, which is more of an element set name, although we did not actually differentiate it from B [brief] at all). Just omitting the element set name here, could be even better. (I will submit some code in this direction on bug 9612 soon. May include it..) So no reasons for me anymore to postpone pushing this to stable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:40:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:40:46 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #37 from Koha Team AMU --- I create a patron with theses permissions selected : - edit_catalogue - edit_items - limited_item_edition with SubfieldsToAllowForLimitedEdition syspref definied (995$f 995$o 995$u) - tools.items_batchmod - tools.items_limited_batchmod with SubfieldsToAllowForLimitedBatchmod syspref defined (995$o) - fast_cataloging - delete_all_items not selected 1/ I can modify the items' subfields definied, but it's only possible in the items of the default's framework and not with items from the fast cataloging framework. In fact i just can modify the subfield definied by the syspref SubfieldsToAllowForLimitedEdition. In the fast cataloging's framework we don't need the same subfields like in the default's framework (we need only 995$b $c $e $f $h $k $m $n $o $u). 2/ I can still delete all items. This should not be possible because it's not selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:43:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:43:16 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26537|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 26576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26576&action=edit Bug 7939 - Separate po files for different MARC dialects This patch implements separate PO files for different MARC dialects. It depends on correct filenames, i.e. it will build PO files using files with/without "unimarc|normarc|marc21" on their names. Prominent changes: A) tmpl_process3.pl three new options: exclude or include certain filenames and a new source dir that can have multiple values (I opted to add this last feature and not change current source dir in order not to brake current usage) Minor change on use of msgmerge, added use of msgattrib. Now there are no backup files (*~) and obsoleted translations are removed (to produce smaller files) [this can be on another bug, is not strictly related with the pourpose of this bug] B) LangInstaller.pm Added definitions to create or update xx-YY-{MARCFLAVOR}.po, minor change to create and install procedure, and modification of install procedure to handle multiple target dirs. Updated documentation. C) Standarization of filenames OPAC prog po file is now xx-YY-opac-prog.po STAFF po file is now xx-YY-staff-prog.po MARC dialects po files are xx-YY-marc-{MARCFLAVOUR}.po [again, renaming not related, can be in it's own bug] To test: 1) Update po files for your preferred language, ej. nn-NO cd misc/translator perl translate update nn-NO (do it twice if there are warnings) 2) Do some copying/renaming cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-UNIMARC.po cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-NORMARC.po cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-MARC21.po mv po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-staff-prog.po mv po/nn-NO-i-opac-t-prog-v-3006000.po po/nn-NO-opac-prog.po (most MARC dialect strings are on staff, so we use that as basis) 3) Apply the patch 4) Update again to fix translation files, verbose perl translate update nn-NO -v 5) Install language, verbose, verify translations perl translate install nn-NO -v 6) Create translation files rm po/nn-NO* perl translate create nn-NO we must have this list: po/nn-NO-marc-MARC21.po po/nn-NO-marc-NORMARC.po po/nn-NO-marc-UNIMARC.po po/nn-NO-opac-bootstrap.po po/nn-NO-opac-ccsr.po po/nn-NO-opac-prog.po po/nn-NO-pref.po po/nn-NO-staff-help.po po/nn-NO-staff-prog.po [staff-help could be more properly staff-prog-help, another rename] Additional tests: 7) Number of msgids 7.a) Before patch and after upgrade, extract and count msgids for i in $(ls po/nn-NO-*po); \ do msginit -i $i -o nn-old.po --no-translator --no-wrap --locale=nn_NO; \ egrep ^msgid nn-old.po >> old; \ done sort old | uniq | tee s-old | wc -l > n-old s-old: have all msgids n-old: number of msgids 7.b) After patch and after creation of new files Repeat procedure, diferent files (s-new, n-new) 7.c) Compare (diff s-old snew), they are the same (save for a strange UNIMARC char in my case, but it's present on corresponding PO file) 8) Installed dirs/files 8.a) List of EN dirs/files cd koha-tmpl find | egrep "/en/" > en 8.b) List of nn-NO dirs/files. After patch and language install cd koha-tmpl find | egrep "/nn-NO/" | sed 's|/nn-NO/|/en/|' > nn 8.c) Compare (diff en nn), they are the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:44:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:44:47 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:51:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:51:54 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:52:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:52:00 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26292|0 |1 is obsolete| | Attachment #26293|0 |1 is obsolete| | Attachment #26294|0 |1 is obsolete| | Attachment #26295|0 |1 is obsolete| | Attachment #26296|0 |1 is obsolete| | Attachment #26297|0 |1 is obsolete| | Attachment #26298|0 |1 is obsolete| | Attachment #26299|0 |1 is obsolete| | Attachment #26300|0 |1 is obsolete| | Attachment #26351|0 |1 is obsolete| | Attachment #26509|0 |1 is obsolete| | Attachment #26513|0 |1 is obsolete| | --- Comment #80 from Jonathan Druart --- Created attachment 26577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26577&action=edit Bug 9032: Share a list (part 1: send the invitation) Adds a Share button for OPAC private lists. Allows you to send an invitation to share a list. Checks on validity of email addresses (with Email::Valid). Test plan: 1) Sharing depends on syspref and login. Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. 2) Try to share a public list or a list you do not own. Find a security hole in the interface. Or hack the shareshelf URL and replace the shelfnumber with a public list number. 3) Enter no email address or invalid ones (no domain, forbidden chars). If you enter no address, submit should not work. If you enter only wrong addresses (separated by: ,:; ), you get a message. 4) Test if sending the invitation works. Share one of your private lists. Enter your own email address. After your proc_message_queue cronjob ran, you should have an email. Check also if you see a new record in the virtualshelfshares table. Note that the followup patch handles the second part of accepting this share. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased. Small amendation: rewording on email notification in template. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:52:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:52:16 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #81 from Jonathan Druart --- Created attachment 26578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26578&action=edit Bug 9032: Followup for new dependency Email::Valid Just adds this dependency to PerlDependencies module. Note from Robin: libemail-valid-perl is in squeeze already. Test plan: You should see Email::Valid now under About/Perl modules. If Email::Valid is not yet installed on your system, please do so. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:52:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:52:24 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #82 from Jonathan Druart --- Created attachment 26579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26579&action=edit Bug 9032 [Template follow-up] Share a list (part 1: send the invitation) This patch makes a few changes to the "share a list" template: - We don't use tables for layout of forms. This patch corrects the display of the share form to use Koha standard form markup. - Revise the confirmation message displayed after a list is shared to be more readable. - Add a link back to private lists to the confirmation message. - Add T:T markup to make this page display the left-hand navigation which is shown on other patron-related pages when a user is logged in. To test, apply this patch on top of other patches pending for Bug 9032 and confirm that the list share form looks correct and works correctly. Confirm that share confirmation page reads well. Signed-off-by: Marcel de Rooy Rebased March 5, 2014. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:52:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:52:32 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #83 from Jonathan Druart --- Created attachment 26580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26580&action=edit Bug 9032: [QA Follow-up] Plackify opac-shareshelf.pl Plackified opac-shareshelf by moving global my variables into hashref. Slightly changed base64ord and base64chr functions to more generic ones. Test plan: Verify if sending an share invitation still works (under prog theme). Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:52:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:52:39 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #84 from Jonathan Druart --- Created attachment 26581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26581&action=edit Bug 9032: Share a list (accept invitation and remove a share) This patch handles: [1] The response (acceptance) by the invited person. If he accepts this share, the private list of the sender will be shown under Your lists on the shelves page. In OPAC 'Your private lists' has been renamed to Your lists (just as in Staff). The Type column shows Private or Shared for these lists; a list appears as Shared as soon as an invitation has been accepted. The owner has the options to Edit, Delete or Share; the invited person does not have these options on the shared list. [2] Removing an accepted share. If a user accepted a share, he should also be able to remove it again. The Remove Share button is visible on OPAC when viewing Your lists or a particular shared list. Note: AddShare has been extended to return a possible database error. If the share invite could not be added, a mail will not be sent. Test plan (for prog theme): Enable pref OpacAllowSharingPrivateLists User 1 creates new private list P1, perms: D-A-D, adds 2 items, sends share User 1 checks your lists display: is P1 Private with Edit button? User 2 accepts share: sees P1, but cannot add or delete items User 2 checks your lists display again: P1 shows Shared without Edit? User 1 checks your lists display again: P1 shows Shared with Edit? User 2 tries to accept share again: should fail now User 3 tries to accept share: should also fail User 3 tries again, modifies shelfnumber and/or key in url: should also fail User 2 creates new private list P2, perms: A-A-A, no items, sends share User 2 checks your lists display: P2 shows Private with Edit? User 1 accepts, adds one item User 1 checks your lists display: P2 shows Shared without Edit? User 2 checks your lists display: P2 shows Shared with Edit? User 2 deletes item of user 1 (allowed) User 2 deletes list P2 User 1 checks your lists display in opac or staff: P2 is gone? User 1 creates private list P3, sends a share. User 1 creates private list P4, adds one item, sends a share. User 2 accepts the share for P3. User 2 checks the shelves display, and removes share P3. User 2 accepts the share for P4. User 2 views shelf P4 with one item and confirms Remove share on that form. User 2 checks shelves display again. Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Combined changes for AcceptShare and RemoveShare. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:52:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:52:45 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #85 from Jonathan Druart --- Created attachment 26582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26582&action=edit Bug 9032: Unit tests for sharing lists This patch combines some work from report 10389 and 10441. With thanks to Srdjan and Jonathan Druart for their contributions. Adds tests for AddShare, AcceptShare, IsSharedList, RemoveShare. This patch also restores the inadvertently deleted DelShelf tests in bug 10499. Test plan: Run the test VirtualShelves.t Signed-off-by: Marcel de Rooy Rebased and squashed on March 4, 2013. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:52:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:52:52 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #86 from Jonathan Druart --- Created attachment 26583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26583&action=edit Bug 9032: Consistent behavior when deleting lists DelShelf deletes a list regardless whether it is private, shared or public. HandleDelBorrower had another approach, trying to save shared and public lists by setting the owner to NULL. This patch makes both routines behave consistent. A new report 11889 has been opened to discuss the 'disowning' feature. NOTE: I did not add a db revision here to handle possible cases of lists without owner in the current data. Such public (or shared) lists can still be used without any problem. Bug 11889 and a new planned report for a lists management tool will address this topic further on. After that, all goals of umbrella report 7310 should be realized. Test plan: Create a list P1 with user1 that allows adding by other users. Add a patron (user2). Login as user2 and create some lists, add some items. Let user2 add some entries to P1 too. Delete patron user2. Verify that his lists are gone, but his entries in P1 are kept (nullified). Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:52:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:52:59 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #87 from Jonathan Druart --- Created attachment 26584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26584&action=edit Bug 9032: Follow-up for bootstrap theme Adds new template opac-shareshelf.tt. Modifies template opac-shelves.tt: Share button, Remove Share button, label "Your lists" instead of "Your private lists", list category Shared. Test plan: Verify if the Share a list-features work in bootstrap by: [1] Switch to bootstrap. Go to Lists. [2] Share one of your private lists. [3] Login as another user and accept the invitation. [4] Remove the share again. [5] Check if Share and Remove share do not popup for public lists. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:53:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:53:06 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #88 from Jonathan Druart --- Created attachment 26585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26585&action=edit Bug 9032: Share a list (database revision for notices) Adds notice SHARE_INVITE in updatedatabase and sample_notices. [Amendation: also adds SHARE_ACCEPT notice.] Test plan: Install or upgrade and verify that you have the new notice under Tools. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Amended the patch to add the second notice SHARE_ACCEPT. Tested upgrade with updatestructure step of web installer. Tested install by deleting all notices and running sample_notices.sql NOTE: Will add the notices to the other sql files in the other language directories as soon as this set of patches is ready to be pushed in order to reduce the need to rebase them constantly. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:53:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:53:14 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #89 from Jonathan Druart --- Created attachment 26586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26586&action=edit Bug 9032: QA Follow-up: Send cookie with redirect Small fix to resolve a problem Dobrica noted on the report. If you had to login when accepting the share, the cookie was not passed back to the server when redirecting to shelf display. Signed-off-by: Marcel de Rooy Accepted a share while logged in and while not logged in. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:53:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:53:22 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #90 from Jonathan Druart --- Created attachment 26587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26587&action=edit Bug 9032: QA Follow-up: Loop variable and Cancel button To satisfy QA needs: Use loop variable instead of $_ in opac-shareshelf.pl Adds Cancel button to Invite form (prog and bootstrap) in opac-shareshelf.tt. Likewise adds Return link under an error message in opac-shareshelf.tt. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 15:53:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 14:53:30 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #91 from Jonathan Druart --- Created attachment 26588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26588&action=edit Bug 9032: QA Follow-up: Adding notices to foreign installer files Adds the notices SHARE_INVITE and SHARE_ACCEPT to sample_notices.sql for the foreign language installer files in installer/data/mysql. Signed-off-by: Marcel de Rooy I tested each installer file by deleting all notices from letter, running the file and counting the records. I did so with and without this patch. The results below show that in each case two notices were added as expected. Note that the English file contains 25 notices including the two new ones. BEFORE THIS PATCH: de-DE/mandatory/sample_notices.sql: 23 notices es-ES/mandatory/sample_notices.sql: 18 notices fr-FR/1-Obligatoire/sample_notices.sql: 18 notices it-IT/necessari/notices.sql: 21 notices nb-NO/1-Obligatorisk/sample_notices.sql: 23 notices pl-PL/mandatory/sample_notices.sql: 18 notices ru-RU/mandatory/sample_notices.sql: 18 notices uk-UA/mandatory/sample_notices.sql: 17 notices AFTER THIS PATCH: de-DE/mandatory/sample_notices.sql: 25 notices es-ES/mandatory/sample_notices.sql: 20 notices fr-FR/1-Obligatoire/sample_notices.sql: 20 notices it-IT/necessari/notices.sql: 23 notices nb-NO/1-Obligatorisk/sample_notices.sql: 25 notices pl-PL/mandatory/sample_notices.sql: 20 notices ru-RU/mandatory/sample_notices.sql: 20 notices uk-UA/mandatory/sample_notices.sql: 19 notices Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:13:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:13:39 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #69 from M. Tompsett --- (In reply to Jonathan Druart from comment #68) > + $template->param( $lang => 1 ) if $lang; > Why ? Seems not used in template. But maybe I am wrong. Because I was thinking it may exist in an earlier version of the template, and was hoping that this could get backported, not just into master. I didn't search earlier versions, though I think you are correct about it not being necessary in master. I'll add a patch for that. > 2) > - # $query.= "LIMIT 0, " . $limit; > + # $query.= 'LIMIT 0, ' . $limit; > Could be removed However, the parameter $limit was not removed, and so I'd like to leave it to show how it was used. It may come in handy if some libraries go news-happy, and we need to add a system preference to specify the limit on the amount of news displayed. > 3) > Maybe the following is more readable: > > $query .= " WHERE 1 "; > if ( $lang ) { > $query .= "AND (opac_news.lang='' OR opac_news.lang=?)"; > push @values, $lang > } > > and same for $branchcode Agreed. > 4) s/branch/library in templates > > 5) in opac-main.tt > - [% IF ( koha_news_count ) %] >
    > + [% IF ( koha_news_count ) %] > > Why? It will produce an empty div. Empty divs can still be styled without generating errors in javascript. And empty divs should not cause massive screen variation over the existing output. > Some QA issues (minor): > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt > FAIL forbidden patterns > forbidden pattern: tab char (line 233) > forbidden pattern: tab char (line 169) > forbidden pattern: tab char (line 227) > forbidden pattern: tab char (line 229) > forbidden pattern: tab char (line 228) > forbidden pattern: tab char (line 225) > forbidden pattern: tab char (line 167) > forbidden pattern: tab char (line 231) > > > FAIL koha-tmpl/opac-tmpl/prog/en/modules/opac-main.tt > FAIL forbidden patterns > forbidden pattern: tab char (line 25) Oh fiddlesticks! Patching. > 7) It would be great to pass a hashref to get_opac_news I don't see the number of parameters on get_opac_news growing past 3. Once you hit that fourth parameter, that seems like the point in time to consider making the parameter a hashref. Hope this addresses your concerns. I'll have a revision up shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:19:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:19:13 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > Hi Owen, > > I am having difficulties testing the overdues report - I don't have a filter > for patron attributes showing up. The pref is enabled and the user showing > up in the report has patron attributes linked to authorized values set. > > - In Circulation -> Overdues: The patron attribute authorized value > filter (must have patron attributes enabled, and a patron attribute > defined which uses authorized values. Do you have the "Searchable" flag set for this patron attribute? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:21:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:21:02 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #92 from M. de Rooy --- Thanks for QA, Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:21:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:21:36 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 --- Comment #7 from Katrin Fischer --- Hi Jonathan, thanks - I think that was the problem. If you want to take a look here, please do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:23:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:23:25 +0000 Subject: [Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |director at plaistowlibrary.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:24:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:24:41 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |director at plaistowlibrary.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:37:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:37:12 +0000 Subject: [Koha-bugs] [Bug 11999] New: Add two checks in CanBookBeReserved and CanItemBeReserved Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Bug ID: 11999 Summary: Add two checks in CanBookBeReserved and CanItemBeReserved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com - Check if borrower already has reserved the same biblio (or item). - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:37:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:37:52 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #1 from Julian Maurice --- Created attachment 26589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26589&action=edit Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved - Check if borrower already has reserved the same biblio (or item). - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) This patch makes CanBookBeReserved and CanItemBeReserved to return a another variable, a hashref that describes why it cannot be reserved. It changes all calls to these functions and removes code in Perl scripts that is not needed anymore. The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower 3/ Try to hold the same biblio/item with the same borrower through ILS-DI and note that you can Apply the patch 4/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 5/ Try to hold the same biblio/item with the same borrower through ILS-DI. You shouldn't be able to do that. 6/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:38:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:38:01 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:38:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:38:56 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #2 from Julian Maurice --- Increasing severity from enh to normal, as the patch fixes a bug in ILS-DI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:54:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:54:30 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #70 from Jonathan Druart --- (In reply to M. Tompsett from comment #69) > > 7) It would be great to pass a hashref to get_opac_news > > I don't see the number of parameters on get_opac_news growing past 3. Once > you hit that fourth parameter, that seems like the point in time to consider > making the parameter a hashref. In my opinion, the trigger is when we have a call with undef: + my ( $opac_news_count, $opac_news ) = &get_opac_news( undef, $lang, $branchcode ); It is not blocker for my QA point of view. Maybe for the RM point of view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:56:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:56:14 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25316|0 |1 is obsolete| | --- Comment #71 from M. Tompsett --- Created attachment 26590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26590&action=edit Bug 7567 - Testing for C4/NewsChannel.pm Testing was lacking, this tests every function call. As a side effect, this moved the stub of a test file from t/NewsChannels.t to t/db_dependent/NewsChannels.t, since the table opac_news must exist. Signed-off-by: Chris Cormack Passes all 8 tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:56:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:56:25 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25317|0 |1 is obsolete| | --- Comment #72 from M. Tompsett --- Created attachment 26591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26591&action=edit Bug 7567 - Update License and use Modern::Perl Grabbed the current license from http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence and changed the use strict; use warnings; into a use Modern::Perl instead. TEST PLAN --------- 1) Log into staff client. - Does news look okay? 2) Apply patch 3) Refresh staff client. - Does news look the same? Signed-off-by: Chris Cormack Safe no op action -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:56:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:56:33 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25318|0 |1 is obsolete| | --- Comment #73 from M. Tompsett --- Created attachment 26592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26592&action=edit Bug 7567 - Update License tools/koha-news.pl Updated license text using http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence for the base text. TEST PLAN --------- 1) less tools/koha-news.pl 2) apply patch 3) less tools/koha-news.pl - was any contributor information lost? Signed-off-by: Chris Cormack Safe no op action -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:56:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:56:48 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25319|0 |1 is obsolete| | --- Comment #74 from M. Tompsett --- Created attachment 26593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26593&action=edit Bug 7567 - Clean up sample news files Some files had truncate. Some files had foreign key checks. Other files had foreign key checks disabled. Some files gave the column names expressly, and others assumed the fields in a particular order. Everything was modified to: - not truncate - not say utf8 (because it should already be by default) - not disable foreign key checks (because it should work) - expressly name the fields (adding fields shouldn't break it) TEST PLAN --------- 0) Backup opac_news if you care about your news. 1) open mysql client 2) use the koha database 3) Run the following script TRUNCATE opac_news; source ~/kohaclone/installer/data/mysql/uk-UA/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/it-IT/necessari/sample_news.sql source ~/kohaclone/installer/data/mysql/de-DE/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/nb-NO/2-Valgfritt/sample_news.sql source ~/kohaclone/installer/data/mysql/en/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/pl-PL/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/es-ES/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/ru-RU/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/fr-FR/2-Optionel/sample_news.sql - Were there errors? - Did everything add nicely? - Not likely, by expressly stating the idnew field, the news items in some files would not be added. 4) apply patch 5) try running the script again - Were there errors? - Did everything add nicely? 6) Log into the staff client 7) Tools->News - Do you see the news items added? Signed-off-by: Chris Cormack Much needed clean up, making for much more robust and less error prone sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:57:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:57:05 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25320|0 |1 is obsolete| | --- Comment #75 from M. Tompsett --- Created attachment 26594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26594&action=edit Bug 7567 - Undefined $lang triggers warning Changed: $template->param( $lang => 1, opac_news => $opac_news, opac_news_count => $opac_news_count, ); Into: $template->param( opac_news => $opac_news, opac_news_count => $opac_news_count, ); $template->param( $lang => 1 ) if $lang; Because $lang is not defined when you come immediately into Home -> Tools -> News. TEST PLAN --------- 1) log into staff client 2) Tools -> News 3) Check koha error log - Expecting to see an error like: koha-news.pl: Problem = a value of 1 has been passed to param without key 4) Apply patch 5) Home -> Tools -> News 6) Check koha error log - No error generated Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:57:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:57:20 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25321|0 |1 is obsolete| | --- Comment #76 from M. Tompsett --- Created attachment 26595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26595&action=edit Bug 7567 - Correct Filtering and Default dropdown values In the staff client, when you went to Home -> Tools -> News the default 'Display location' is 'All'. Everything is correctly displayed. However, if you change the filter it filters the table correctly, but does not set the dropdown value to match. This patch corrects this. TEST PLAN --------- 1) Home -> Tools -> News 2) Change 'Display location' value and click 'Filter'. - Is the 'Display location' value the same now? (no) - Are the correct values displayed? 3) Click 'New entry' - Is it anything other than 'All'? (no, and is this correct?) 4) Click 'Cancel' 5) Click 'Edit' for various news items with different locations. - Does the 'Display location' get proper set? (no) 6) Apply patch 7) Change the 'Display location' value and click 'Filter'. - Does the 'Display location' value stay the same? (this should be correct now) - Are the correct values displayed? 8) Change the 'Display location' value to 'All' and click 'Filter'. - Does everything display? 9) Change the 'Display location' value and click 'Filter'. 10) Click 'New entry' - Does it match what the filter was? (should match now) 11) Click 'Cancel' 12) Click 'Edit' for various news items with different locations. - Does the 'Display location' get proper set? (this should be correct now) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:57:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:57:32 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25322|0 |1 is obsolete| | --- Comment #77 from M. Tompsett --- Created attachment 26596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26596&action=edit Bug 7567 - Removed finish calls "When all the data has been fetched from a SELECT statement, the driver will automatically call finish for you. So you should not call it explicitly except when you know that you've not fetched all the data from a statement handle and the handle won't be destroyed soon." (http://search.cpan.org/~timb/DBI-1.627/DBI.pm#finish) All the $sth variables were scoped within the functions, and would be destroyed immediately. Additionally, there was one after a SELECT, for only a single idnew, and so it was not necessary. TEST PLAN --------- 1) prove -v t/db_dependent/NewsChannels.t 2) apply patch 3) prove -v t/db_dependent/NewsChannels.t Signed-off-by: Chris Cormack ok 1 - use C4::NewsChannels; ok 2 - Successfully added the first dummy news item! ok 3 - Successfully added the second dummy news item! ok 4 - Successfully updated second dummy news item! ok 5 - Successfully tested get_opac_new id1! ok 6 - Successfully tested get_opac_new id2! ok 7 - Successfully tested get_opac_news! ok 8 - Successfully tested GetNewsToDisplay! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:57:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:57:54 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25323|0 |1 is obsolete| | --- Comment #78 from M. Tompsett --- Created attachment 26597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26597&action=edit Bug 7567 - Too many parameters and tiny bugs Changed the add and update functions to use a hash reference for the parameter, so that adding or subtracting parameters should be easier. Added some POD for the add_opac_news and upd_opac_news functions, so that developers would know how to call it. The hashref changes resulted in being able to return 0 for failure and 1 for success. This meant adding a couple tests to the test file. And while testing, there was some sort of logic problem with the matter of '' being all, but selecting all only showed things set for all, and excluded particular languages, or other interfaces. Signed-off-by: Chris Cormack 1..10 ok 1 - use C4::NewsChannels; ok 2 - Correctly failed on no parameter! ok 3 - Successfully added the first dummy news item! ok 4 - Successfully added the second dummy news item! ok 5 - Correctly failed on no parameter! ok 6 - Successfully updated second dummy news item! ok 7 - Successfully tested get_opac_new id1 (0)! ok 8 - Successfully tested get_opac_new id2 (0)! ok 9 - Successfully tested get_opac_news! ok 10 - Successfully tested GetNewsToDisplay! My only nitpick here is the variable naming ... hashref is a really bad name for a variable. But I will sign off, because apart from that it is a good clean up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:58:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:58:04 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25324|0 |1 is obsolete| | --- Comment #79 from M. Tompsett --- Created attachment 26598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26598&action=edit Bug 7567 - Added branchcode to opac_news This patch merely adds branchcode varchar(10) DEFAULT NULL to the opac_news table. TEST PLAN --------- 1) backup your kohadata base if you care about the data. 2) use the koha database 3) describe opac_news; 4) show create table opac_news; -- No branchcode constraint will exist. 5) apply the patch 6) upgrade the database (either staff client or script) 7) use the koha database 8) describe opac_news; 9) show create table opac_news; -- The branchcode constraint should be listed. 10) drop that koha database 11) create the koha database 12) use the koha database 13) source ~/kohaclone/installer/data/mysql/kohastructure.sql -- there should be no errors in creating the database. 14) describe opac_news; 15) show create table opac_news; -- The branchcode constraint should be listed. 16) restore your koha database if you backed it up. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:58:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:58:17 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26510|0 |1 is obsolete| | --- Comment #80 from M. Tompsett --- Created attachment 26599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26599&action=edit Bug 7567 - Use, Display, Filter News by Branch With the branch parameter added to key functions in C4/NewsChannels.pm, function calls in C4/Members.pm, mainpage.pl, opac/opac-main.pl, tools/koha-news.pl, and t/db_dependent/NewsChannels.t were needed. Some license texts were updated. Templates were modified to display, allow for entry and editing of the branches selected. TEST PLAN --------- 1) Having logged into the staff client, is the news displaying correctly? Have you entered a news item which should not display for this branch of logged in user? 2) Find a patron (with some items checked out?) 3) Print a slip - News which is labelled 'All Branches' or for the same branch as the one printing the slip should display on the slip. - THIS DOES NOT AFFECT QUICK SLIPS 4) Home -> Tools -> News - Can you edit a news item? - Does the change save correctly? - Can you filter based on location and branch correctly? - Can you add a new entry correctly? - Can you delete an entry correctly? 5) Open an OPAC client. - Does only the news for all branches display? 6) Log into the OPAC client. - Does the news for all branches and the specific branch display? 7) prove -v t/db_dependent/NewsChannels.t - Does it run and all succeed? - Does the code seem to catch the required cases? 8) Comparing the patched and unpatched versions of files affected, are the license changes missing anything? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 16:58:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 15:58:27 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26511|0 |1 is obsolete| | --- Comment #81 from M. Tompsett --- Created attachment 26600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26600&action=edit Bug 7567 - Schema update for opac_news This was generated by: Reset hard to master. Restore old DB Apply the patches for 7567 ./installer/data/mysql/updatedatabase.pl ./misc/devel/update_dbix_class_files.pl -db_name=... -db_user=... -db_passwd=... git add Koha/Schema/Results/OpacNews.pm This should provide the necessary changes to the schema files for Koha 3.16 and forward. Had to generate under Debian, because Ubuntu's was broken by comparison. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 17:01:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 16:01:16 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #82 from M. Tompsett --- (In reply to Jonathan Druart from comment #70) > (In reply to M. Tompsett from comment #69) > > > 7) It would be great to pass a hashref to get_opac_news > > > > I don't see the number of parameters on get_opac_news growing past 3. Once > > you hit that fourth parameter, that seems like the point in time to consider > > making the parameter a hashref. > > In my opinion, the trigger is when we have a call with undef: > + my ( $opac_news_count, $opac_news ) = &get_opac_news( undef, $lang, > $branchcode ); > > It is not blocker for my QA point of view. Maybe for the RM point of view. Perhaps the problem isn't undef, but rather it probably should be 0, even though it isn't used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 17:01:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 16:01:17 +0000 Subject: [Koha-bugs] [Bug 7107] 'used in' column on analytics not populating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7107 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |director at plaistowlibrary.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 17:40:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 16:40:20 +0000 Subject: [Koha-bugs] [Bug 7425] Export Bibliographic Holdings fails if no item records attached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7425 --- Comment #3 from Elaine Bradtke --- The value of syspref item-level_itypes is what governs this. It appears to default to specific item - which then gives the above results. (Admin > System preferences > Cataloguing) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 17:41:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 16:41:14 +0000 Subject: [Koha-bugs] [Bug 7425] Export Bibliographic Holdings fails if no item records attached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7425 Elaine Bradtke changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Elaine Bradtke --- The value of syspref item-level_itypes is what governs this. It appears to default to specific item - which then gives the above results. (Admin > System preferences > Cataloguing) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 17:58:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 16:58:12 +0000 Subject: [Koha-bugs] [Bug 11694] Improve handling of individual hold suspension in Bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11694 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Owen! I've pushed the QA follow-up, although I would have preferred that the issue had stayed on bug 11702, as problems saving the suspension date in the database aren't dependent on the shape of the form. I also note that I've been completely unable to reproduce the issue reported in bug 11702, and I strongly suspect that there is some kind of MySQL configuration issue or DateTime version issue is at play that really ought to be completely characterized. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 17:59:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 16:59:41 +0000 Subject: [Koha-bugs] [Bug 8632] suspend in opac jumping to bottom of page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8632 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Galen Charlton --- I do not see this in master, and I assume that whatever caused the issue was either transient (e.g., cached JavaScript) or was fixed. Closing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:02:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:02:37 +0000 Subject: [Koha-bugs] [Bug 8965] warning for "clear date" link for suspended holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8965 --- Comment #1 from Galen Charlton --- The patch for bug 11694 changes the wording to "Clear date to suspend indefinitely" on the Bootstrap OPAC, and I think it makes sense to adopt this for the staff side. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:06:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:06:31 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #26 from Christopher Brannon --- Kyle, I'm curious about this development. Please forgive my ignorance on this, if this has already been discussed somewhere. Since the phone is utilizing an e-mail address already, why not just put the phone e-mail address in place of the e-mail address in the patron account, and have a setting next to the e-mail field to switch between standard and brief, where this setting would switch from the normal notice template to a shorter notice template. For example, instead of using the HOLD template, if brief is selected next to the e-mail field, then the HOLD (BRIEF) template would be used. Just a thought. Maybe I am missing something more complex? Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:12:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:12:51 +0000 Subject: [Koha-bugs] [Bug 12000] New: staff users can set hold suspension dates to occur in the past Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 Bug ID: 12000 Summary: staff users can set hold suspension dates to occur in the past Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In the hold request management page, the datepicker lets staff users set the hold resumption date in the past. This doesn't seem useful: - if automatic hold un-suspension is enabled, the hold will flip back to unsuspended the next time the cronjob runs - if the user means to suspend a hold indefinitely, the way to do it is to not set a specific resumption date This issue also affects the datepicker for the resumption date on the checkout page. It does NOT affect the datepicker on the patron details page, which lets the staff user only pick dates in the future. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:19:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:19:29 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26590|0 |1 is obsolete| | --- Comment #83 from M. Tompsett --- Created attachment 26601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26601&action=edit Bug 7567 - Testing for C4/NewsChannel.pm Testing was lacking, this tests every function call. As a side effect, this moved the stub of a test file from t/NewsChannels.t to t/db_dependent/NewsChannels.t, since the table opac_news must exist. Signed-off-by: Chris Cormack Passes all 8 tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:19:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:19:37 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26591|0 |1 is obsolete| | --- Comment #84 from M. Tompsett --- Created attachment 26602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26602&action=edit Bug 7567 - Update License and use Modern::Perl Grabbed the current license from http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence and changed the use strict; use warnings; into a use Modern::Perl instead. TEST PLAN --------- 1) Log into staff client. - Does news look okay? 2) Apply patch 3) Refresh staff client. - Does news look the same? Signed-off-by: Chris Cormack Safe no op action -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:19:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:19:44 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26592|0 |1 is obsolete| | --- Comment #85 from M. Tompsett --- Created attachment 26603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26603&action=edit Bug 7567 - Update License tools/koha-news.pl Updated license text using http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence for the base text. TEST PLAN --------- 1) less tools/koha-news.pl 2) apply patch 3) less tools/koha-news.pl - was any contributor information lost? Signed-off-by: Chris Cormack Safe no op action -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:19:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:19:55 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26593|0 |1 is obsolete| | --- Comment #86 from M. Tompsett --- Created attachment 26604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26604&action=edit Bug 7567 - Clean up sample news files Some files had truncate. Some files had foreign key checks. Other files had foreign key checks disabled. Some files gave the column names expressly, and others assumed the fields in a particular order. Everything was modified to: - not truncate - not say utf8 (because it should already be by default) - not disable foreign key checks (because it should work) - expressly name the fields (adding fields shouldn't break it) TEST PLAN --------- 0) Backup opac_news if you care about your news. 1) open mysql client 2) use the koha database 3) Run the following script TRUNCATE opac_news; source ~/kohaclone/installer/data/mysql/uk-UA/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/it-IT/necessari/sample_news.sql source ~/kohaclone/installer/data/mysql/de-DE/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/nb-NO/2-Valgfritt/sample_news.sql source ~/kohaclone/installer/data/mysql/en/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/pl-PL/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/es-ES/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/ru-RU/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/fr-FR/2-Optionel/sample_news.sql - Were there errors? - Did everything add nicely? - Not likely, by expressly stating the idnew field, the news items in some files would not be added. 4) apply patch 5) try running the script again - Were there errors? - Did everything add nicely? 6) Log into the staff client 7) Tools->News - Do you see the news items added? Signed-off-by: Chris Cormack Much needed clean up, making for much more robust and less error prone sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:20:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:20:16 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26594|0 |1 is obsolete| | --- Comment #87 from M. Tompsett --- Created attachment 26605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26605&action=edit Bug 7567 - Undefined $lang triggers warning Changed: $template->param( $lang => 1, opac_news => $opac_news, opac_news_count => $opac_news_count, ); Into: $template->param( opac_news => $opac_news, opac_news_count => $opac_news_count, ); $template->param( $lang => 1 ) if $lang; Because $lang is not defined when you come immediately into Home -> Tools -> News. TEST PLAN --------- 1) log into staff client 2) Tools -> News 3) Check koha error log - Expecting to see an error like: koha-news.pl: Problem = a value of 1 has been passed to param without key 4) Apply patch 5) Home -> Tools -> News 6) Check koha error log - No error generated Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:20:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:20:34 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26595|0 |1 is obsolete| | --- Comment #88 from M. Tompsett --- Created attachment 26606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26606&action=edit [NEEDS SIGN OFF] Bug 7567 - Correct Filtering and Default dropdown values In the staff client, when you went to Home -> Tools -> News the default 'Display location' is 'All'. Everything is correctly displayed. However, if you change the filter it filters the table correctly, but does not set the dropdown value to match. This patch corrects this. TEST PLAN --------- 1) Home -> Tools -> News 2) Change 'Display location' value and click 'Filter'. - Is the 'Display location' value the same now? (no) - Are the correct values displayed? 3) Click 'New entry' - Is it anything other than 'All'? (no, and is this correct?) 4) Click 'Cancel' 5) Click 'Edit' for various news items with different locations. - Does the 'Display location' get proper set? (no) 6) Apply patch 7) Change the 'Display location' value and click 'Filter'. - Does the 'Display location' value stay the same? (this should be correct now) - Are the correct values displayed? 8) Change the 'Display location' value to 'All' and click 'Filter'. - Does everything display? 9) Change the 'Display location' value and click 'Filter'. 10) Click 'New entry' - Does it match what the filter was? (should match now) 11) Click 'Cancel' 12) Click 'Edit' for various news items with different locations. - Does the 'Display location' get proper set? (this should be correct now) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:20:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:20:52 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26596|0 |1 is obsolete| | --- Comment #89 from M. Tompsett --- Created attachment 26607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26607&action=edit Bug 7567 - Removed finish calls "When all the data has been fetched from a SELECT statement, the driver will automatically call finish for you. So you should not call it explicitly except when you know that you've not fetched all the data from a statement handle and the handle won't be destroyed soon." (http://search.cpan.org/~timb/DBI-1.627/DBI.pm#finish) All the $sth variables were scoped within the functions, and would be destroyed immediately. Additionally, there was one after a SELECT, for only a single idnew, and so it was not necessary. TEST PLAN --------- 1) prove -v t/db_dependent/NewsChannels.t 2) apply patch 3) prove -v t/db_dependent/NewsChannels.t Signed-off-by: Chris Cormack ok 1 - use C4::NewsChannels; ok 2 - Successfully added the first dummy news item! ok 3 - Successfully added the second dummy news item! ok 4 - Successfully updated second dummy news item! ok 5 - Successfully tested get_opac_new id1! ok 6 - Successfully tested get_opac_new id2! ok 7 - Successfully tested get_opac_news! ok 8 - Successfully tested GetNewsToDisplay! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:21:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:21:17 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26597|0 |1 is obsolete| | --- Comment #90 from M. Tompsett --- Created attachment 26608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26608&action=edit [NEEDS SIGN OFF] Bug 7567 - Too many parameters and tiny bugs Changed the add and update functions to use a hash reference for the parameter, so that adding or subtracting parameters should be easier. Added some POD for the add_opac_news and upd_opac_news functions, so that developers would know how to call it. The hashref changes resulted in being able to return 0 for failure and 1 for success. This meant adding a couple tests to the test file. And while testing, there was some sort of logic problem with the matter of '' being all, but selecting all only showed things set for all, and excluded particular languages, or other interfaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:21:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:21:35 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26598|0 |1 is obsolete| | --- Comment #91 from M. Tompsett --- Created attachment 26609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26609&action=edit Bug 7567 - Added branchcode to opac_news This patch merely adds branchcode varchar(10) DEFAULT NULL to the opac_news table. TEST PLAN --------- 1) backup your kohadata base if you care about the data. 2) use the koha database 3) describe opac_news; 4) show create table opac_news; -- No branchcode constraint will exist. 5) apply the patch 6) upgrade the database (either staff client or script) 7) use the koha database 8) describe opac_news; 9) show create table opac_news; -- The branchcode constraint should be listed. 10) drop that koha database 11) create the koha database 12) use the koha database 13) source ~/kohaclone/installer/data/mysql/kohastructure.sql -- there should be no errors in creating the database. 14) describe opac_news; 15) show create table opac_news; -- The branchcode constraint should be listed. 16) restore your koha database if you backed it up. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:21:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:21:53 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26599|0 |1 is obsolete| | --- Comment #92 from M. Tompsett --- Created attachment 26610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26610&action=edit [NEEDS SIGN OFF] Bug 7567 - Use, Display, Filter News by Branch With the branch parameter added to key functions in C4/NewsChannels.pm, function calls in C4/Members.pm, mainpage.pl, opac/opac-main.pl, tools/koha-news.pl, and t/db_dependent/NewsChannels.t were needed. Some license texts were updated. Templates were modified to display, allow for entry and editing of the branches selected. TEST PLAN --------- 1) Having logged into the staff client, is the news displaying correctly? Have you entered a news item which should not display for this branch of logged in user? 2) Find a patron (with some items checked out?) 3) Print a slip - News which is labelled 'All Branches' or for the same branch as the one printing the slip should display on the slip. - THIS DOES NOT AFFECT QUICK SLIPS 4) Home -> Tools -> News - Can you edit a news item? - Does the change save correctly? - Can you filter based on location and branch correctly? - Can you add a new entry correctly? - Can you delete an entry correctly? 5) Open an OPAC client. - Does only the news for all branches display? 6) Log into the OPAC client. - Does the news for all branches and the specific branch display? 7) prove -v t/db_dependent/NewsChannels.t - Does it run and all succeed? - Does the code seem to catch the required cases? 8) Comparing the patched and unpatched versions of files affected, are the license changes missing anything? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:22:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:22:07 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26600|0 |1 is obsolete| | --- Comment #93 from M. Tompsett --- Created attachment 26611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26611&action=edit Bug 7567 - Schema update for opac_news This was generated by: Reset hard to master. Restore old DB Apply the patches for 7567 ./installer/data/mysql/updatedatabase.pl ./misc/devel/update_dbix_class_files.pl -db_name=... -db_user=... -db_passwd=... git add Koha/Schema/Results/OpacNews.pm This should provide the necessary changes to the schema files for Koha 3.16 and forward. Had to generate under Debian, because Ubuntu's was broken by comparison. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:27:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:27:51 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:27:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:27:55 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #94 from M. Tompsett --- Created attachment 26612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26612&action=edit [NEED SIGN OFF] Bug 7567 - Remove excess line The template parameter { $lang => 1 } does not seem used in master. It is unconfirmed whether this is used in earlier versions of Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:42:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:42:43 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #95 from M. Tompsett --- The difficulty of a multi-patch bug fix is changing just parts after a code review. Only the ones with [NEEDS SIGN OFF] are changed compared to earlier versions which Chris Cormack signed off. These changes include: - chopping an unused template parameter (comment #68 - point 1) - simplifying the lang/branchcode query building logic (comment #68 - point 3) - using Library or Libraries instead of Branch or Braches in the template (comment #68 - point 4) - white space fixes (comment #68 - point 6) - renaming a variable from hashref to parameters (comment #55) To recap the other comments by Jonathan Druart: comment #68 - point 2: parameter is still there, and left for historical and future expansion purposes. comment #68 - point 5: empty div's can be styled without breaking javascript. comment #68 - point 7: it probably should be 0, but left undef, so obvious change was only the addition of branch code. I figure 4+ parameters deserve a hashref as a parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 18:43:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 17:43:47 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #96 from M. Tompsett --- SIDE COMMENT: Bug 7731 was likely the motivation for comment #68 point 4. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 19:05:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 18:05:46 +0000 Subject: [Koha-bugs] [Bug 12000] staff users can set hold suspension dates to occur in the past In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 19:05:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 18:05:49 +0000 Subject: [Koha-bugs] [Bug 12000] staff users can set hold suspension dates to occur in the past In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 --- Comment #1 from Galen Charlton --- Created attachment 26613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26613&action=edit Bug 12000: ensure that hold resumption dates can be set only to future dates This patch makes the datepickers for the hold resumption date (AKA the hold suspend until date) field only permit dates in the future to be selected in the staff interface checkout page and hold list pages. This makes these pages consistent with the OPAC and the patron details page in the staff interface. To test: [1] Ensure that AutoResumeSuspendedHolds and SuspendHoldsIntranet are enabled. [2] Go to the checkout page for a patron that has at least one hold request. [3] Verify that the datepicker for the hold suspend until date field only permits choosing a date in the future. [4] Go to the page listing hold requests for a title. [5] Verify that the datepicker for the hold suspend until date fields only permit choosing a date in the future. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 19:13:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 18:13:59 +0000 Subject: [Koha-bugs] [Bug 5621] Google Translation for indian languages. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5621 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 19:27:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 18:27:13 +0000 Subject: [Koha-bugs] [Bug 12001] New: GetMemberAccountRecords slows down display of patron details and checkout pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Bug ID: 12001 Summary: GetMemberAccountRecords slows down display of patron details and checkout pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org For patrons who have a large number of fines (whether they're paid off or not), the current implementation of GetMemberAccountRecords is needlessly slow, as it retrieves the title and author for every fine record that is linked to an item. This is particularly noticeable in setups where the database server is accessed over the network instead of a local socket. This is particularly obnoxious because the majority of callers of GetMemberAccountRecords() are only interested in the total fine balance, and toss away the detailed information. GetMemberDetails() is a good example -- and consequently, there are several contexts where it would be preferable to use GetMember() rather than GetMemberDetails(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 20:09:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 19:09:25 +0000 Subject: [Koha-bugs] [Bug 11958] classification sources help file has typo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11958 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Actually, the classification source a column (cn_source) in *both* the items and biblioitems tables. Consequently, it gets mapped to *both* the 942$2 and 952$2. Consequently, the patch as proposed is incomplete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 20:20:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 19:20:05 +0000 Subject: [Koha-bugs] [Bug 11877] Eliminate use of deprecated jQuery .live() method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 20:22:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 19:22:12 +0000 Subject: [Koha-bugs] [Bug 11806] Use validation plugin when creating new OAI set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11806 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 20:26:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 19:26:08 +0000 Subject: [Koha-bugs] [Bug 11878] Eliminate use of deprecated jQuery .toggle() method usage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 20:32:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 19:32:05 +0000 Subject: [Koha-bugs] [Bug 11738] Use new DataTables include in batch patron modification template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 21:01:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 20:01:30 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 --- Comment #8 from Galen Charlton --- Actually... those MySQL configuration changes aren't necessary in order to fix the problem. Something like this suffices: diff --git a/Koha/Database.pm b/Koha/Database.pm index 12758bf..ef1e2db 100644 --- a/Koha/Database.pm +++ b/Koha/Database.pm @@ -55,7 +55,7 @@ sub _new_schema { my $db_passwd = $context->config("pass"); my $schema = Koha::Schema->connect( "DBI:$db_driver:dbname=$db_name;host=$db_host;port=$db_port", - $db_user, $db_passwd ); + $db_user, $db_passwd, { mysql_enable_utf8 => 1 } ); return $schema; } This wouldn't be the final version of this patch, as we wouldn't want to pass msyql_enable_utf8 to a Pg database, and we would have to make sure that binary data (e.g., images stored in the database) don't get mangled, but I think something like this patch would be more reliable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 21:04:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 20:04:59 +0000 Subject: [Koha-bugs] [Bug 11671] Restructure patron lists add form for improved usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 21:45:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 20:45:15 +0000 Subject: [Koha-bugs] [Bug 12002] New: Koha does not pick up installed languages when running under Plack Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12002 Bug ID: 12002 Summary: Koha does not pick up installed languages when running under Plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr I took a database from an existing package install and dumped it into an installation running under Plack (which is a gitified package-install, to be exact). After doing this, when I go to the I18N tab of the systempreferences I do not see any other languages than "en" as options for the "language" and "opaclanguages" sysprefs. Translations are installed on the server: $ sudo koha-translate -i nb-NO Error: the selected language is already installed. Try --update if you want to re-install it. Updating the translations does not have any effect. I have this in the db: mysql> select variable, value from systempreferences where variable = 'language' or variable = 'opaclanguages'; +---------------+------------------------------------+ | variable | value | +---------------+------------------------------------+ | language | sv-SE,en | | opaclanguages | sv-SE,en,fr-FR,de-DE,es-ES,ar-Arab | +---------------+------------------------------------+ I restarted MySQL and memcached, without any effect. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 21:47:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 20:47:40 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 21:47:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 20:47:43 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 --- Comment #9 from Galen Charlton --- Created attachment 26614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26614&action=edit Bug 12001: regression test for using DBIC to store & fetch UTF8 strings This patch adds a regression test for verifying that a DBIx::Class schema object initialized by Koha database sets up the database connection to correct store and retrieve UTF8 values as Perl utf8 strings. To test: [1] Apply this patch. [2] Run prove -v t/db_dependent/Koha_Database.t [3] The test should fail. [4] Apply the main patch for this bug, then do step 2 again. [5] The test should pass. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 21:47:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 20:47:51 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 --- Comment #10 from Galen Charlton --- Created attachment 26615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26615&action=edit Bug 11906: ensure that Koha::Database uses UTF8 mode when connecting to databases This patch fixes an issue whereby the DBIx::Class schema objects were not connecting to the underlying database in UTF8 mode. This most visibility manifested as patron list pages not displaying diacritics correctly. To test: [1] Create a patron list, and make sure that it contains at least one patron whose name or patron category description contains a non-ASCII character. [2] View the list contents; the diacritics should appear mangled. [3] Apply the patch. [4] View the patron list again. This time, the diacritics should be displayed correctly. Note that Apache will also log "list.pl: Wide character in print ...", but this is the lesser of two evils. [5] Verify that prove -v t/db_dependent/Koha_Database.t passes. [6] (extra credit) Verify that t/db_dependent/Koha_Database.t passes when connect to a PostgreSQL database. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 22:10:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 21:10:47 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26614|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 26616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26616&action=edit Bug 11906: regression test for using DBIC to store & fetch UTF8 strings This patch adds a regression test for verifying that a DBIx::Class schema object initialized by Koha database sets up the database connection to correct store and retrieve UTF8 values as Perl utf8 strings. To test: [1] Apply this patch. [2] Run prove -v t/db_dependent/Koha_Database.t [3] The test should fail. [4] Apply the main patch for this bug, then do step 2 again. [5] The test should pass. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 22:18:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 21:18:12 +0000 Subject: [Koha-bugs] [Bug 12002] Koha does not pick up installed languages when running under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12002 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | --- Comment #1 from Robin Sheat --- I'm working on fixes for plack for the staff client, so I'll look into this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 22:22:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 21:22:11 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 22:22:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 21:22:15 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26615|0 |1 is obsolete| | --- Comment #12 from Chris Cormack --- Created attachment 26617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26617&action=edit Bug 11906: ensure that Koha::Database uses UTF8 mode when connecting to databases This patch fixes an issue whereby the DBIx::Class schema objects were not connecting to the underlying database in UTF8 mode. This most visibility manifested as patron list pages not displaying diacritics correctly. To test: [1] Create a patron list, and make sure that it contains at least one patron whose name or patron category description contains a non-ASCII character. [2] View the list contents; the diacritics should appear mangled. [3] Apply the patch. [4] View the patron list again. This time, the diacritics should be displayed correctly. Note that Apache will also log "list.pl: Wide character in print ...", but this is the lesser of two evils. [5] Verify that prove -v t/db_dependent/Koha_Database.t passes. [6] (extra credit) Verify that t/db_dependent/Koha_Database.t passes when connect to a PostgreSQL database. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 22:36:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 21:36:27 +0000 Subject: [Koha-bugs] [Bug 12003] New: Next issues for irregular pattern not correctly predicted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12003 Bug ID: 12003 Summary: Next issues for irregular pattern not correctly predicted Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com To test: 1) Create a subscription in the serials module. Make sure to choose: Frequency = Irregular 2) Test the prediction pattern, publication date will show as 'unknown' 3) Save the subscription 4) Check the created issue - it will show a published date and a planned date, but those should be 'unknown' 5) Receive the issue and check the next generated issue, it will have dates set 6) Generate a next issue, it will also be created with dates set This is a regression to how this worked previously and should be fixed. Also prediction pattern and actual behaviour don't match now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 22:36:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 21:36:33 +0000 Subject: [Koha-bugs] [Bug 12003] Next issues for irregular pattern not correctly predicted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12003 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7688 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 22:36:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 21:36:33 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12003 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 22:37:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 21:37:05 +0000 Subject: [Koha-bugs] [Bug 12003] Next issues for irregular pattern not correctly predicted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12003 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11637 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 22:37:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 21:37:05 +0000 Subject: [Koha-bugs] [Bug 11637] No way to prevent a prediction date for the next issue in serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11637 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12003 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 22:37:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 21:37:55 +0000 Subject: [Koha-bugs] [Bug 11637] No way to prevent a prediction date for the next issue in serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11637 --- Comment #9 from Katrin Fischer --- Done - bug 12003 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 23:16:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 22:16:25 +0000 Subject: [Koha-bugs] [Bug 5273] Publication Details for serial subscriptions not showing when in item record edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- I am not sure I fully understand your bug report, the behaviour seems normal to me. When you create real items with your subscription the serial enumeration will be in 952$h for UNIMARC. You can change the visibility and description of this field in your cataloguing frameworks. After adding them in the serials module, you can change the items like any normal item in the cataloguing module. Koha will also always keep track of the issues of the subscription itself. This information can only be changed in the serials module. I am closing this WORKSFORME, please reopen if I am mistaken. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 23:26:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 22:26:59 +0000 Subject: [Koha-bugs] [Bug 3982] History Start Date Not Populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3982 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- All 4 dates are now set automatically on creating a subscription and updated on renewal. I think this covers this bug report, so closing the bug fixed. Note: I am not entirely sure populating those fields with the same date is the originally intended behaviour - but there are other bug reports about the manual history that will be a better place to discuss behaviour. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 23:29:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 22:29:37 +0000 Subject: [Koha-bugs] [Bug 11843] Manual subscription history doesn't seem to work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master Severity|major |blocker --- Comment #2 from Katrin Fischer --- Thinking more about this, I think it's a blocker for the possibility of losing data by an unexpected change of behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 23:38:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 22:38:20 +0000 Subject: [Koha-bugs] [Bug 11977] no way to edit manual history on serials anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11977 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi Nicole, I think this is a duplicate of bug 11295 - you can still edit, but we have some behaviour changes there. The edit link is now hidden on the subscription detail page. I think maybe we should make an new bug on how to improve the interface - like moving the edit link to a more prominent spot. I also filed bug 11843 about the manual history, which I think is a bigger problem. *** This bug has been marked as a duplicate of bug 11295 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 23:38:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 22:38:20 +0000 Subject: [Koha-bugs] [Bug 11295] Serials manual history can no longer be added or edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11295 --- Comment #7 from Katrin Fischer --- *** Bug 11977 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 23:48:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 22:48:25 +0000 Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull down In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Still valid in current master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 23:56:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 22:56:50 +0000 Subject: [Koha-bugs] [Bug 4217] Serials should keep a record of date claimed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4217 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- You can see the date an issue was claimed now, when you check for claimed issues. I am marking this duplicate of bug 5342, which has patches for more improvements including a claims counter. *** This bug has been marked as a duplicate of bug 5342 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 23:56:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 22:56:50 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #62 from Katrin Fischer --- *** Bug 4217 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 23:58:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 22:58:43 +0000 Subject: [Koha-bugs] [Bug 12004] New: Regional preference on holds Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12004 Bug ID: 12004 Summary: Regional preference on holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I would like to suggest a feature beyond ticket 11126, where holds are prioritized first for owning libraries, then regional libraries, and then finally all libraries, with each instance adhering to the transport cost matrix. In other words: If Item X does not fill holds for all libraries until A) all holds for patrons from the owning library are satisfied, and then B) holds from all libraries from that library's defined region are satisfied. Christopher Brannon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 23:59:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 22:59:12 +0000 Subject: [Koha-bugs] [Bug 12004] Regional preference on holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12004 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11126 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 26 23:59:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 22:59:12 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12004 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:02:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:02:03 +0000 Subject: [Koha-bugs] [Bug 6932] Javascript errors in irregular pattern check update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6932 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.12 --- Comment #2 from Katrin Fischer --- I think I ran into this bug - in IE it's not possible to select the issues to receive when you receive less items than the pattern would predict. I am not sure what to do about this bug, as the problem will only exist in versions pre 3.14, predating the partial serials rewrite. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:03:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:03:17 +0000 Subject: [Koha-bugs] [Bug 8668] remove character limit on serials notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8668 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- This is still valid in current master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:04:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:04:01 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #10 from Katrin Fischer --- *** Bug 8668 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:04:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:04:01 +0000 Subject: [Koha-bugs] [Bug 8668] remove character limit on serials notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8668 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10215 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:04:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:04:38 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 --- Comment #11 from Katrin Fischer --- Still valid in current master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:06:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:06:33 +0000 Subject: [Koha-bugs] [Bug 8852] branch not showing in serials results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- Library name shows in the subscription result list now, closing this as fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:06:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:06:44 +0000 Subject: [Koha-bugs] [Bug 8852] branch not showing in serials results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:09:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:09:38 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sending empty vendor or |Sending empty vendor or |biblio when adding |biblio when adding |subscriptions gives error |subscriptions gives wrong | |error --- Comment #1 from Katrin Fischer --- The message is now: You must choose a first publication date. This doesn't make much sense as the field is on the second page of the form and can't be accessed without filling out other mandatory fields first. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:13:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:13:13 +0000 Subject: [Koha-bugs] [Bug 7415] can't select irregularity in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7415 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- I think this could be fixed by the patch for 6932 - I have seen the same behaviour in IE. But problem should only exist on 3.12 and older versions, because of the partial serial rewrite in 3.14 that changed the interface to checkboxes. *** This bug has been marked as a duplicate of bug 6932 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:13:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:13:13 +0000 Subject: [Koha-bugs] [Bug 6932] Javascript errors in irregular pattern check update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6932 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #3 from Katrin Fischer --- *** Bug 7415 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:16:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:16:22 +0000 Subject: [Koha-bugs] [Bug 10219] No way for patron to unsubscribe from subscription alert in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10219 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- This works for me on current master. I can subscribe and unsubscribe, the links show accordingly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:19:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:19:13 +0000 Subject: [Koha-bugs] [Bug 9203] limit pull down broken when adding biblio to subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9203 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #4 from Katrin Fischer --- The form now always offers itemtype and collection code searching in separate pull downs - closing as fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:21:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:21:31 +0000 Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:32:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:32:35 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 --- Comment #10 from Srdjan Jankovic --- Created attachment 26618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26618&action=edit Bug 10446 - System preference maxoutstanding is poorly named The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds, but the name does not describe its behavior very well. String changes only, no functional changes made. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the new system preference FeesBlockHoldsAmount's value matches the previous value of maxoutstanding. 4) Set FeesBlockHoldsAmount to $10 5) Attempt to place an OPAC hold for a patron owing less than $10 This attempt should succeed. 6) Attempt to place an OPAC hold for a patron owing more than $10 This attempt should fail Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:34:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:34:11 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19903|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:34:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:34:33 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26618|Bug 10446 - System |[SIGNED-OFF] Bug 10446 - description|preference maxoutstanding |System preference |is poorly named |maxoutstanding is poorly | |named -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 00:42:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Mar 2014 23:42:38 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24412|0 |1 is obsolete| | --- Comment #6 from Srdjan Jankovic --- Created attachment 26619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26619&action=edit bug_11184: correct attribute cloning for the maint screen To test - Patron details entry page: * Have ExtendedPatronAttributes enabled. Check that "Additional attributes and identifiers" section behaves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 04:42:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 03:42:32 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 04:42:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 03:42:59 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #25 from David Cook --- Looking forward to this one going in. It would be a great help... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 05:07:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 04:07:13 +0000 Subject: [Koha-bugs] [Bug 11993] Untranslatable confirm popup in request.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 26620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26620&action=edit Bug 11993 - Untranslatable confirm popup in request.tt This patch makes confirm popup text translatable. It implements a similar function as used on OPAC deleteConfirm() and a JS var message. This funcion, or variants, can also be found on other files on intranet, I think that the only valid places are staff-global.js and help-top.inc Redefinitions of this function: prog/en/modules/serials/subscription-frequencies.tt:6 prog/en/modules/tools/marc_modification_templates.tt:158 prog/en/modules/virtualshelves/shelves.tt:92 Last case is a little different To test: 1) I'm at lost, don't know how to produce the situation in which this message appear, perhaps when staff personel tries to cancel a hold in transit If you know how, please tell me and I will resubmit with a better test plan. 2) Check the string is not present on staff PO file 3) Apply the patch 4) Update translation files (cd misc/translator; perl translate update xx-YY) 5) Verify the string is now present -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 05:08:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 04:08:01 +0000 Subject: [Koha-bugs] [Bug 11993] Untranslatable confirm popup in request.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel at gmail.com Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 05:47:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 04:47:23 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #3 from Robin Sheat --- Created attachment 26621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26621&action=edit Bug 11998 - move most syspref db access into Context.pm There was a lot of direct database access in systempreferences.pl. This moves a lot of it into C4::Context so that it'll interact with caching better, and to centralise common functions and logging in one place. Test plan: * Make sure that creating, editing, deleting local use preferences works * Make sure that other system preferences still function normally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:07:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:07:23 +0000 Subject: [Koha-bugs] [Bug 6735] Note about range isn't showing range In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6735 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Katrin Fischer --- History start and end date are now set automatically, closing this. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:08:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:08:35 +0000 Subject: [Koha-bugs] [Bug 7344] first issue publication date should be required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7344 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- The first issue publication date is required now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:10:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:10:20 +0000 Subject: [Koha-bugs] [Bug 7592] year/month pattern In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7592 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- It is now possible to create frequencies with the month and day names. Closing fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:14:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:14:36 +0000 Subject: [Koha-bugs] [Bug 7827] After creating a new biblio to be used in a subscription, the subscription entry form should be populated with the biblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7827 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- This is still valid for current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:17:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:17:17 +0000 Subject: [Koha-bugs] [Bug 8249] can't add extra issues to prediction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Still valid in current master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:21:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:21:00 +0000 Subject: [Koha-bugs] [Bug 9590] serial notes wrong on search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9590 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- The subscription search result list now shows both notes from the subscription in the form: Public (Nonpublic) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:24:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:24:06 +0000 Subject: [Koha-bugs] [Bug 10658] test pattern showing wrong data on advanced predictions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10658 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- This appears to be fixed with bug 7688. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:26:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:26:51 +0000 Subject: [Koha-bugs] [Bug 10916] confusing notes on serial results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- I have checked this on current master and the 500$a of my serial record does no longer show in the serials subscription result list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:27:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:27:30 +0000 Subject: [Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #26 from David Cook --- A few additional thoughts... 1) A follow-up should probably be added for a few other OPAC scripts like opac-basket.pl, opac-sendbasket.pl, opac-sendshelf.pl, etc., since these will all show the unfiltered MARC record. 2) It would be nice to see a future version of this that filters for both the OPAC and the staff client. Passing a "context" in and checking the 'hidden' values against a hashref of hashrefs might be a quick way of doing that: my $display = { opac => { 0 => 1, -1 => 1, -2 => 1, -3 => 1, -4 => 1, -5 => 1, -6 => 1, -7 => 1, }, intranet => { -6 => 1, -5 => 1, -1 => 1, 0 => 1, 1 => 1, 4 => 1, 6 => 1, 7 => 1, }, }; 3) I've added a few notes in Splinter Review for ways I think that the filter sub could be improved. Since this has already passed QA, I'll just leave them as notes. If it's too late to make changes, I'll probably send a patch with some of them after it's pushed in any case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:31:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:31:43 +0000 Subject: [Koha-bugs] [Bug 5340] bulk subscription renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5340 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 7910 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:31:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:31:43 +0000 Subject: [Koha-bugs] [Bug 7910] Batch renewal of serials and order creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 --- Comment #5 from Katrin Fischer --- *** Bug 5340 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:39:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:39:44 +0000 Subject: [Koha-bugs] [Bug 11681] invoice not showing right price with tax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11681 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #5 from Katrin Fischer --- There is another bug with patches - Nicole, could you check if the other bug fixes your problem? Another set of eyes would be good. *** This bug has been marked as a duplicate of bug 10613 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:39:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:39:44 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #38 from Katrin Fischer --- *** Bug 11681 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 07:40:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 06:40:28 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 08:06:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 07:06:43 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 09:38:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 08:38:03 +0000 Subject: [Koha-bugs] [Bug 12005] New: Zebra searches sometimes fail silently under Plack Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005 Bug ID: 12005 Summary: Zebra searches sometimes fail silently under Plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org When Koha is running under Plack, Zebra searches can sometimes fail silently. What you will see is that a search that should return some hits suddenly returns 0 hits. The next search can work as normal again. The failed search will not be logged. A quick and dirty fix can be found here: http://git.catalyst.net.nz/gw?p=koha.git;a=commitdiff;h=459c750e4b0aa0fe5dba601e423e78070383b97b;hp=2c9581f75fdb1f76e60c83f86e253cb4dfe04597 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 09:45:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 08:45:23 +0000 Subject: [Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 10:15:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 09:15:57 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Blocks| |11944 QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #13 from Jonathan Druart --- Galen, We had this patch for bug 11944, so I completely agree with it! Actually it is not on bug 11944, it seems it disappears on rebasing/squashing patches :-/ I still have the patch on a local branch and the difference is: 1/ We added $schema->storage->on_connect_do('SET NAMES utf8'); in Koha::Database::_new_schema Which is stupid! From the mysql doc: "if you turn the flag on after connecting, you will need to issue the command SET NAMES utf8 to get the same effect." 2/ We did not propose unit tests, so ++ :) 3/ We removed the Koha::Template::Plugin::EncodeUTF8 uses in circ/renew.pl This plugin is now useless. I will submit a followup on QAing, feel free to ask open a new specific report for it. Marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 10:15:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 09:15:57 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11906 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 10:16:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 09:16:52 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26616|0 |1 is obsolete| | Attachment #26617|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 26622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26622&action=edit Bug 11906: regression test for using DBIC to store & fetch UTF8 strings This patch adds a regression test for verifying that a DBIx::Class schema object initialized by Koha database sets up the database connection to correct store and retrieve UTF8 values as Perl utf8 strings. To test: [1] Apply this patch. [2] Run prove -v t/db_dependent/Koha_Database.t [3] The test should fail. [4] Apply the main patch for this bug, then do step 2 again. [5] The test should pass. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 10:16:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 09:16:57 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 --- Comment #15 from Jonathan Druart --- Created attachment 26623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26623&action=edit Bug 11906: ensure that Koha::Database uses UTF8 mode when connecting to databases This patch fixes an issue whereby the DBIx::Class schema objects were not connecting to the underlying database in UTF8 mode. This most visibility manifested as patron list pages not displaying diacritics correctly. To test: [1] Create a patron list, and make sure that it contains at least one patron whose name or patron category description contains a non-ASCII character. [2] View the list contents; the diacritics should appear mangled. [3] Apply the patch. [4] View the patron list again. This time, the diacritics should be displayed correctly. Note that Apache will also log "list.pl: Wide character in print ...", but this is the lesser of two evils. [5] Verify that prove -v t/db_dependent/Koha_Database.t passes. [6] (extra credit) Verify that t/db_dependent/Koha_Database.t passes when connect to a PostgreSQL database. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 10:17:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 09:17:02 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 --- Comment #16 from Jonathan Druart --- Created attachment 26624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26624&action=edit Bug 11906: The EncodeUTF8 TT Plugin is useless Now, the data from the DB, return by Koha::Database, have the utf-8 flag turn on. It becomes useless to encode them at the template level. The EncodeUTF8 plugin can be removed too. Test plan: 1/ Check out a book with a title containing non-latin characters. 2/ On circ/renew.pl, renew the item. 3/ In some case, you have a warning box, to override a limit. It should not contain broken strings. If you confirm, you get a "Item renewed" box, it should not contain broken strings. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 10:17:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 09:17:17 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 10:46:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 09:46:02 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #5 from M. de Rooy --- Created attachment 26625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26625&action=edit Bug 9612: SRU response for DOM indexing This patch makes changes to koha-conf.xml by removing the fallback section from biblioserver and authserver. The information is in a include file on the same server (no need to fall back) and moreover, some information is not up-to-date and should be moved elsewhere. The patch also simplifies the DOM retrieval-info files for auth and bib. And eliminates superfluous F and usmarc from the dom-config files. (I felt the urge to remove marcxml too, but left it for now; see also the second patch.) For reference, look at the marcxml example files of Zebra. NOTE: This patch does not deal with the Debian package installs. In the same way koha-conf-site.xml.in, and *-retrieval-info-* could be adjusted. Test plan: [1] Run at least a dev install in order to copy the new files to your Zebra folders. Choose for DOM indexing. Enable the SRU server on port 9998 (small edit in koha-conf.xml). [2] Restart Zebra and reindex -a -b -x. [3] Verify if a search from Koha still functions as expected. Check the SRU output on port 9998. NOTE: If you do not pass recordSchema, you should get back a marc response now (instead of index schema). Bonus: Add your server as a Z3950 target to another Koha install. And perform a Z3950 search from the other server to your new install. Bonus: Check response from the auth and biblio socket via yaz-client. [4] Reindex again with -a -b but without -x. [5] Repeat Koha search, SRU response (Z3950, yaz-client). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 10:46:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 09:46:07 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #6 from M. de Rooy --- Created attachment 26626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26626&action=edit Bug 9612: Zconn parameters and elementSetName in _new_Zconn This patch makes a few adjustments in C4::Context::Zconn. It does no longer pass the (ignored) auth, syntax parameters to _new_Zconn. Note that auth was not completely ignored in theory, but we never pass auth=1 [while not having user/password in koha-conf]. Furthermore, it removes the elementSetName for dom indexing. Using marcxml here does not make a difference. It only adds a constraint on what is in the dom-config files. (It could probably be removed there now..) Two cosmetic code changes: Removes unused label retry. And moved 'servername' into the database name option. Test plan: When using Zebra with dom indexing, do a biblio and authority search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 10:48:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 09:48:31 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 --- Comment #17 from Jonathan Druart --- (In reply to Jonathan Druart from comment #13) > 3/ We removed the Koha::Template::Plugin::EncodeUTF8 uses in circ/renew.pl > This plugin is now useless. > I will submit a followup on QAing, feel free to ask open a new specific > report for it. Forget that, it does not work with translated template (the ENCODING flag is not set yet to 'UTF-8' at the template level). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 10:48:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 09:48:43 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26624|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 10:50:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 09:50:21 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 --- Comment #7 from M. de Rooy --- Have been testing this in quite some variants. The final patches have been tested again with Makefile for both dom as well as grs1 for completeness. In the commit message I have indicated that similar changes can be made to the debian template files. (I have not attached a patch, since I cannot test that one.) Note that the changes proposed here should imo not disrupt the package install as seen from a code perspective. I am asking Robin to confirm this. After that the status can be set to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 11:08:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 10:08:04 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #11 from Jonathan Druart --- git grep maxoutstanding returns circ/offline.pl:$template->{'VARS'}->{'maxoutstanding'} = circ/offline.pl: C4::Context->preference('maxoutstanding') || 0; koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt: if (parseInt(patron.fine) > [% maxoutstanding %]) { They should be fixed too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 11:22:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 10:22:50 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkopaczka at afm.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 11:23:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 10:23:36 +0000 Subject: [Koha-bugs] [Bug 12002] Koha does not pick up installed languages when running under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12002 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 11:23:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 10:23:54 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 11:23:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 10:23:57 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26619|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 26627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26627&action=edit bug_11184: correct attribute cloning for the maint screen To test - Patron details entry page: * Have ExtendedPatronAttributes enabled. Check that "Additional attributes and identifiers" section behaves. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 11:43:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 10:43:18 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #106 from M. de Rooy --- Still applies. I will try to pick up now where I left this.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 12:35:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 11:35:25 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #8 from Jonathan Druart --- QA comment: All work as expected, no regression found. I just found 2 small differences: 1/ on the patron headers, 1px alignment change: The text "Check out", "Check in", "Search the catalog" in tabs were 1px higher than with the patch (take a magnifying glass to see the difference! :)) 2/ The accordion has now a border on bottom of the title. See screenshots. In my opinion, it is not blocker. That could be fix later if needed. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 12:35:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 11:35:47 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25960|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 26628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26628&action=edit Bug 11570 - Upgrade jQueryUI to latest version in the staff client This patch upgrades the version of jQueryUI included in the Koha staff client from v1.8.23 to v.1.10.4. The upgrade introduces a few minor API changes which require the updates in this patch: - In CSS, the term "active" is used instead of "selected" - Autocomplete functions use slightly changed parameters Changes to the default jQueryUI CSS allows us to remove some instances of "!important" from jQueryUI-related CSS in the staff client's main CSS file. To test: Testing changes to autocomplete: - Enable the CircAutocompl system preference. Try searching in the header's "Check out" tab. Autocomplete should look correct and function correctly. - In Circulation -> Overdues: The patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Course reserves -> Course -> Edit: Searching for an instructor - In the unimarc_field_210c_bis.pl plugin: 1. Link the publisher name field in your MARC structure to the unimarc_field_210c_bis.pl plugin. 2. Open a MARC record for editing and click the "tag editor" link to launch the plugin. 3. Type the first few letters of a publisher which exists in your database. You should get an autocomplete menu of publishers which match your search. 4. Select one and click the "choose" button to fill the field in the MARC editor. - Tools -> Patron lists: Add a list or choose an existing list and add patrons. Perform a search for a patron. - Placing a hold: After choose a title and clicking "Place hold," search for a patron. - Tags management: The sidebar filter for "reviewer" should let you search by patron name. Other jQueryUI widget changes: - Check tabs appearance in header search, biblio detail, cataloging, and circulation patron fines pages. To confirm other jQueryUI widgets still function correctly: - Check accordion (collapsing sections) in Patrons -> Patrons requesting modifications and the MARC subfield structure edit screen. - Check datepickers, especially in Circulation with the added timepicker. Test a linked datepicker, for example in Reports -> Stats wizards -> Circulation where the value in one date field affects what dates are available in the matching field. - Check the calendar interface in Tools -> Calendar To confirm that the new jQueryUI default CSS is more flexible (fixing Bug 11042), add the following CSS to your IntranetUserCSS system preference and confirm that the header search active tab border color changes (hash mark escaped so that it will appear in commit msg): \#header_search ul.ui-tabs-nav li.ui-tabs-active { background-color: #FFFFF1; border: 1px solid #800000; border-top: 0 !important; top: -2px; } Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 12:38:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 11:38:01 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 --- Comment #10 from Jonathan Druart --- Created attachment 26629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26629&action=edit with path -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 12:38:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 11:38:23 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 --- Comment #11 from Jonathan Druart --- Created attachment 26630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26630&action=edit without patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 12:39:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 11:39:38 +0000 Subject: [Koha-bugs] [Bug 11570] Upgrade jQueryUI to latest version in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11042 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 12:39:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 11:39:38 +0000 Subject: [Koha-bugs] [Bug 11042] Color issue for selected tab under search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11570 Resolution|--- |MOVED --- Comment #5 from Jonathan Druart --- I confirm this is fixed by bug 11570. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:24:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:24:25 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:24:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:24:31 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26601|0 |1 is obsolete| | Attachment #26602|0 |1 is obsolete| | Attachment #26603|0 |1 is obsolete| | Attachment #26604|0 |1 is obsolete| | Attachment #26605|0 |1 is obsolete| | Attachment #26606|0 |1 is obsolete| | Attachment #26607|0 |1 is obsolete| | Attachment #26608|0 |1 is obsolete| | Attachment #26609|0 |1 is obsolete| | Attachment #26610|0 |1 is obsolete| | Attachment #26611|0 |1 is obsolete| | Attachment #26612|0 |1 is obsolete| | --- Comment #97 from Jonathan Druart --- Created attachment 26631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26631&action=edit Bug 7567 - Testing for C4/NewsChannel.pm Testing was lacking, this tests every function call. As a side effect, this moved the stub of a test file from t/NewsChannels.t to t/db_dependent/NewsChannels.t, since the table opac_news must exist. Signed-off-by: Chris Cormack Passes all 8 tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:24:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:24:42 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #98 from Jonathan Druart --- Created attachment 26632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26632&action=edit Bug 7567 - Update License and use Modern::Perl Grabbed the current license from http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence and changed the use strict; use warnings; into a use Modern::Perl instead. TEST PLAN --------- 1) Log into staff client. - Does news look okay? 2) Apply patch 3) Refresh staff client. - Does news look the same? Signed-off-by: Chris Cormack Safe no op action Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:24:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:24:51 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #99 from Jonathan Druart --- Created attachment 26633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26633&action=edit Bug 7567 - Update License tools/koha-news.pl Updated license text using http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence for the base text. TEST PLAN --------- 1) less tools/koha-news.pl 2) apply patch 3) less tools/koha-news.pl - was any contributor information lost? Signed-off-by: Chris Cormack Safe no op action Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:25:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:25:00 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #100 from Jonathan Druart --- Created attachment 26634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26634&action=edit Bug 7567 - Clean up sample news files Some files had truncate. Some files had foreign key checks. Other files had foreign key checks disabled. Some files gave the column names expressly, and others assumed the fields in a particular order. Everything was modified to: - not truncate - not say utf8 (because it should already be by default) - not disable foreign key checks (because it should work) - expressly name the fields (adding fields shouldn't break it) TEST PLAN --------- 0) Backup opac_news if you care about your news. 1) open mysql client 2) use the koha database 3) Run the following script TRUNCATE opac_news; source ~/kohaclone/installer/data/mysql/uk-UA/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/it-IT/necessari/sample_news.sql source ~/kohaclone/installer/data/mysql/de-DE/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/nb-NO/2-Valgfritt/sample_news.sql source ~/kohaclone/installer/data/mysql/en/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/pl-PL/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/es-ES/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/ru-RU/optional/sample_news.sql source ~/kohaclone/installer/data/mysql/fr-FR/2-Optionel/sample_news.sql - Were there errors? - Did everything add nicely? - Not likely, by expressly stating the idnew field, the news items in some files would not be added. 4) apply patch 5) try running the script again - Were there errors? - Did everything add nicely? 6) Log into the staff client 7) Tools->News - Do you see the news items added? Signed-off-by: Chris Cormack Much needed clean up, making for much more robust and less error prone sql Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:25:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:25:11 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #101 from Jonathan Druart --- Created attachment 26635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26635&action=edit Bug 7567 - Remove excess line The template parameter { $lang => 1 } does not seem used in master. It is unconfirmed whether this is used in earlier versions of Koha. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:25:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:25:19 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #102 from Jonathan Druart --- Created attachment 26636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26636&action=edit Bug 7567 - Correct Filtering and Default dropdown values In the staff client, when you went to Home -> Tools -> News the default 'Display location' is 'All'. Everything is correctly displayed. However, if you change the filter it filters the table correctly, but does not set the dropdown value to match. This patch corrects this. TEST PLAN --------- 1) Home -> Tools -> News 2) Change 'Display location' value and click 'Filter'. - Is the 'Display location' value the same now? (no) - Are the correct values displayed? 3) Click 'New entry' - Is it anything other than 'All'? (no, and is this correct?) 4) Click 'Cancel' 5) Click 'Edit' for various news items with different locations. - Does the 'Display location' get proper set? (no) 6) Apply patch 7) Change the 'Display location' value and click 'Filter'. - Does the 'Display location' value stay the same? (this should be correct now) - Are the correct values displayed? 8) Change the 'Display location' value to 'All' and click 'Filter'. - Does everything display? 9) Change the 'Display location' value and click 'Filter'. 10) Click 'New entry' - Does it match what the filter was? (should match now) 11) Click 'Cancel' 12) Click 'Edit' for various news items with different locations. - Does the 'Display location' get proper set? (this should be correct now) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:25:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:25:29 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #103 from Jonathan Druart --- Created attachment 26637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26637&action=edit Bug 7567 - Removed finish calls "When all the data has been fetched from a SELECT statement, the driver will automatically call finish for you. So you should not call it explicitly except when you know that you've not fetched all the data from a statement handle and the handle won't be destroyed soon." (http://search.cpan.org/~timb/DBI-1.627/DBI.pm#finish) All the $sth variables were scoped within the functions, and would be destroyed immediately. Additionally, there was one after a SELECT, for only a single idnew, and so it was not necessary. TEST PLAN --------- 1) prove -v t/db_dependent/NewsChannels.t 2) apply patch 3) prove -v t/db_dependent/NewsChannels.t Signed-off-by: Chris Cormack ok 1 - use C4::NewsChannels; ok 2 - Successfully added the first dummy news item! ok 3 - Successfully added the second dummy news item! ok 4 - Successfully updated second dummy news item! ok 5 - Successfully tested get_opac_new id1! ok 6 - Successfully tested get_opac_new id2! ok 7 - Successfully tested get_opac_news! ok 8 - Successfully tested GetNewsToDisplay! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:25:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:25:38 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #104 from Jonathan Druart --- Created attachment 26638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26638&action=edit Bug 7567 - Too many parameters and tiny bugs Changed the add and update functions to use a hash reference for the parameter, so that adding or subtracting parameters should be easier. Added some POD for the add_opac_news and upd_opac_news functions, so that developers would know how to call it. The hashref changes resulted in being able to return 0 for failure and 1 for success. This meant adding a couple tests to the test file. And while testing, there was some sort of logic problem with the matter of '' being all, but selecting all only showed things set for all, and excluded particular languages, or other interfaces. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:25:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:25:47 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #105 from Jonathan Druart --- Created attachment 26639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26639&action=edit Bug 7567 - Added branchcode to opac_news This patch merely adds branchcode varchar(10) DEFAULT NULL to the opac_news table. TEST PLAN --------- 1) backup your kohadata base if you care about the data. 2) use the koha database 3) describe opac_news; 4) show create table opac_news; -- No branchcode constraint will exist. 5) apply the patch 6) upgrade the database (either staff client or script) 7) use the koha database 8) describe opac_news; 9) show create table opac_news; -- The branchcode constraint should be listed. 10) drop that koha database 11) create the koha database 12) use the koha database 13) source ~/kohaclone/installer/data/mysql/kohastructure.sql -- there should be no errors in creating the database. 14) describe opac_news; 15) show create table opac_news; -- The branchcode constraint should be listed. 16) restore your koha database if you backed it up. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:25:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:25:55 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #106 from Jonathan Druart --- Created attachment 26640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26640&action=edit Bug 7567 - Use, Display, Filter News by Branch With the branch parameter added to key functions in C4/NewsChannels.pm, function calls in C4/Members.pm, mainpage.pl, opac/opac-main.pl, tools/koha-news.pl, and t/db_dependent/NewsChannels.t were needed. Some license texts were updated. Templates were modified to display, allow for entry and editing of the branches selected. TEST PLAN --------- 1) Having logged into the staff client, is the news displaying correctly? Have you entered a news item which should not display for this branch of logged in user? 2) Find a patron (with some items checked out?) 3) Print a slip - News which is labelled 'All Branches' or for the same branch as the one printing the slip should display on the slip. - THIS DOES NOT AFFECT QUICK SLIPS 4) Home -> Tools -> News - Can you edit a news item? - Does the change save correctly? - Can you filter based on location and branch correctly? - Can you add a new entry correctly? - Can you delete an entry correctly? 5) Open an OPAC client. - Does only the news for all branches display? 6) Log into the OPAC client. - Does the news for all branches and the specific branch display? 7) prove -v t/db_dependent/NewsChannels.t - Does it run and all succeed? - Does the code seem to catch the required cases? 8) Comparing the patched and unpatched versions of files affected, are the license changes missing anything? Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:26:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:26:06 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #107 from Jonathan Druart --- Created attachment 26641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26641&action=edit Bug 7567 - Schema update for opac_news This was generated by: Reset hard to master. Restore old DB Apply the patches for 7567 ./installer/data/mysql/updatedatabase.pl ./misc/devel/update_dbix_class_files.pl -db_name=... -db_user=... -db_passwd=... git add Koha/Schema/Results/OpacNews.pm This should provide the necessary changes to the schema files for Koha 3.16 and forward. Had to generate under Debian, because Ubuntu's was broken by comparison. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:26:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:26:14 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #108 from Jonathan Druart --- Created attachment 26642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26642&action=edit Bug 7567: QA followup: FIX SQL query The WHERE clause should not erase $query. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:26:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:26:23 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #109 from Jonathan Druart --- Created attachment 26643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26643&action=edit Bug 7567: QA followup: remove useless $parameters hashref This hashref is useless, it is only used once. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 13:27:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 12:27:53 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #110 from Jonathan Druart --- (In reply to M. Tompsett from comment #95) > The difficulty of a multi-patch bug fix is changing just parts after a code > review. Only the ones with [NEEDS SIGN OFF] are changed compared to earlier > versions which Chris Cormack signed off. It is why it is preferable not to modify signed off patches. It is really hard for QAers to know what changes you introduced. Next time, prefer a followup, QAer can squash patches. I squashed 2 patches Bug 7567 - Undefined $lang triggers warning [NEED SIGN OFF] Bug 7567 - Remove excess line into Bug 7567 - Remove excess line And I provided 2 followups: 1/ Fix the sql query on getting rows from DB 2/ remove an unnecessary variable. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 14:35:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 13:35:31 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #111 from Owen Leonard --- Created attachment 26644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26644&action=edit Bug 7567 - Modify DataTables configuration This follow-up corrects a JavaScript error by converting the sorting configuration to be class-based (http://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference). I have also changed the DataTables configuration to allow for pagination and JS-based filtering. To test, apply the patch and view the list of News items. Your browser should report no JavaScript errors. Table sorting, pagination, and filtering should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 14:37:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 13:37:41 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26333|0 |1 is obsolete| | --- Comment #25 from Benjamin Rokseth --- Created attachment 26645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26645&action=edit Bug 8868: Remove CancelReserveFromId CancelReserve does the same job. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 14:46:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 13:46:38 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 26646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26646&action=edit Bug 11393 - Language menu not show up as name for Thai (th-THA was shown) The problem is with the name of PO files Currently Koha expect, among other variants, that PO filenames began with (using as example *-pref.po): {lang}-pref.po {lang}-{region}-pref.po {lang}-{scrip}-pref.po {lang}-{script}-{region}-pref.po and expect 2 chars for lang and region, and 4 for script So the problem with Thai translation files are that it's names do not match that convention. This patch only rename Thai files as th-THA-* to th-TH-*. In that way language description is right. translate script use that chars to make dirs, and use dirs to find description. To test: 1) Go to I18N/L10N sysprefs 2) Install th-THA language (or simply mkdir koha-tmpl/intranet-tmpl/prog/th-THA) 3) Reload page, wrong description 4) Apply patch 5) Install th-TH language (or simply mkdir koha-tmpl/intranet-tmpl/prog/th-TH) 6) Reload page, right description 7) If you want do "mkdir koha-tmpl/intranet-tmpl/prog/th-Thai", reload, also right description To the reporter of this Bug: the rename of the folder is a good workaround, when this patch is pushed to stable I'll rename Thai files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 14:47:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 13:47:37 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel at gmail.com Patch complexity|--- |Trivial patch Version|3.12 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 14:50:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 13:50:14 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26644|0 |1 is obsolete| | --- Comment #112 from Jonathan Druart --- Created attachment 26647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26647&action=edit Bug 7567 - Modify DataTables configuration This follow-up corrects a JavaScript error by converting the sorting configuration to be class-based (http://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference). I have also changed the DataTables configuration to allow for pagination and JS-based filtering. To test, apply the patch and view the list of News items. Your browser should report no JavaScript errors. Table sorting, pagination, and filtering should work correctly. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 14:50:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 13:50:49 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #113 from Jonathan Druart --- (In reply to Owen Leonard from comment #111) > Created attachment 26644 [details] [review] Good catch Owen, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 15:03:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 14:03:16 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Benjamin Rokseth --- Might be the two patches should be squashed into one, but I leave it for QA to decide. Regarding authentication, I personally would like to see a more united work on a RESTful API ? la http://git.biblibre.com/?p=koha-restful, rather than the /svc which only addresses marc records and /ils-di which has some patron and holds calls. Perhaps it could also implement a basic session authentication, api-key, or such. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 15:06:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 14:06:54 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #107 from M. de Rooy --- Follow-up QA Comment: Good/promising feature. Looks good, but with some comments: 1) This patch series provides some groundwork for subsequent changes in follow-up reports. This means that not everything this patch seems to offer now, is actually used. For instance, you can edit sms notices now or click phone in overdue rules, but this will not produce any results. Given that I am told that these changes are still coming in the follow-up reports, this should just be considered as temporary confusion. I note however that marking these options as not-in-use-yet (somehow..) and releasing them further on in the process would have had my (personal) preference. 2) At the last transport_type of tools/letter.pl a counter is displayed like: Message body: 11/160. It was not evident at the start for me that it meant 11 chars from max 160. No blocker, but could be improved later? 3) When adding a new notice the first time, I was forced to add subject and contents for each transport type (Which I did not really like). BUT then I tried to reproduce this once again, and I couldn't. (Caching problem?) So no blocker. But I discovered one small thing: If I enter code and name on the top, and do not fill anything further. The program seems to accept that and save, but actually it just ignores what I typed. Maybe we should catch that situation. No blocker btw. And another more annoying one (maybe more theoretical indeed): Fill in code, name and the SECOND mtt. Now it will save one letter (including the name). But it will not pickup the name again when editing this notice. (One of the last patches dealt with something similar.) 4) In this report overdue notices are still handled by transport type email only. The commit message in one of the patches suggests otherwise. As I understand, the next patch series (10832) takes care of it. 5) On Overdue rules, I can enter a delay value and select a notice without selecting a transport type. The action is saved, but reads to me that Koha will not do anything with it. Should we warn the user here? No blocker for now. But could be improved. 6) From a commit message: "if you insert a new line in your message_transport_types table, the overdues configuration table did not displayed an header." How would you add such a type? Just via sql? I understood that the interface will not offer such a functionality. I think that it is great that the interface immediately shows me overdue rules and notices for the new type. But on the other hand, we could discuss how sensible it really is to do so. No blocker, but an interesting discussion :) 7) Just noting that tools/overduerules.pl contains sql code and you also add some. (Admin scripts are marked as an exception...) Changed tests pass. No complaints from qa tools. I am inclined to pass QA, but do you have a quick fix for some of the stuff under point 3? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 15:30:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 14:30:07 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #108 from Jonathan Druart --- (In reply to M. de Rooy from comment #107) > Follow-up QA Comment: Thanks! > Good/promising feature. Looks good, but with some comments: > > 1) This patch series provides some groundwork for subsequent changes in > follow-up reports. > This means that not everything this patch seems to offer now, is actually > used. Actually it does not make sense to push this patch set alone. All patches from linked reports should be pushed at the same time. > 2) At the last transport_type of tools/letter.pl a counter is displayed > like: Message body: 11/160. > It was not evident at the start for me that it meant 11 chars from max 160. > No blocker, but could be improved later? Hum, what do you propose? > 3) When adding a new notice the first time, I was forced to add subject and > contents for each transport type (Which I did not really like). > BUT then I tried to reproduce this once again, and I couldn't. (Caching > problem?) > So no blocker. > But I discovered one small thing: If I enter code and name on the top, and > do not fill anything further. The program seems to accept that and save, but > actually it just ignores what I typed. Maybe we should catch that situation. > No blocker btw. > And another more annoying one (maybe more theoretical indeed): Fill in code, > name and the SECOND mtt. Now it will save one letter (including the name). > But it will not pickup the name again when editing this notice. (One of the > last patches dealt with something similar.) I will try to have a look at this too. > 4) In this report overdue notices are still handled by transport type email > only. > The commit message in one of the patches suggests otherwise. > As I understand, the next patch series (10832) takes care of it. Same as 1). Patches from bug 10832 should be pushed at the same time as this one. > 5) On Overdue rules, I can enter a delay value and select a notice without > selecting a transport type. The action is saved, but reads to me that Koha > will not do anything with it. Should we warn the user here? > No blocker for now. But could be improved. I will try to provide a followup. > 6) From a commit message: "if you insert a new line in your > message_transport_types table, the overdues configuration table did not > displayed an header." Yes, Olli found this problem on testing the patch. I agreed with him, it is an issue and fixed it. It was in order to avoid further issues. > How would you add such a type? Just via sql? I understood that the interface > will not offer such a functionality. > I think that it is great that the interface immediately shows me overdue > rules and notices for the new type. But on the other hand, we could discuss > how sensible it really is to do so. No blocker, but an interesting > discussion :) I think it is more flexible to display all mtt existing in DB rather than dealing with "authorized" mtt in templates. > 7) Just noting that tools/overduerules.pl contains sql code and you also add > some. (Admin scripts are marked as an exception...) Hum, yes... I didn't try to refactor this code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 15:38:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 14:38:41 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #109 from M. de Rooy --- (In reply to Jonathan Druart from comment #108) > > 2) At the last transport_type of tools/letter.pl a counter is displayed > > like: Message body: 11/160. > > It was not evident at the start for me that it meant 11 chars from max 160. > > No blocker, but could be improved later? > > Hum, what do you propose? I have no perfect solution at hand, but maybe just adding 11/160 characters would already be more clear? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 15:45:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 14:45:07 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Galen Charlton --- Great minds, and all that. Pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 16:09:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 15:09:52 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #110 from Jonathan Druart --- Created attachment 26648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26648&action=edit Bug 9016: (followup) FIX letter name is not displayed on editing a letter If the name is not in email, the name is not correctly retrieved. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 16:09:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 15:09:59 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #111 from Jonathan Druart --- Created attachment 26649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26649&action=edit Bug 9016: Add some validation on the letter form 1/ Code and Name are mandatory. 2/ At least 1 template should be filled on saving. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 16:19:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 15:19:29 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #112 from Jonathan Druart --- Created attachment 26650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26650&action=edit Bug 9016: Improve number of characters display when mtt=sms Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 16:23:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 15:23:43 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #113 from Jonathan Druart --- (In reply to M. de Rooy from comment #107) > 3) When adding a new notice the first time, I was forced to add subject and > contents for each transport type (Which I did not really like). > BUT then I tried to reproduce this once again, and I couldn't. (Caching > problem?) > So no blocker. > But I discovered one small thing: If I enter code and name on the top, and > do not fill anything further. The program seems to accept that and save, but > actually it just ignores what I typed. Maybe we should catch that situation. > No blocker btw. > And another more annoying one (maybe more theoretical indeed): Fill in code, > name and the SECOND mtt. Now it will save one letter (including the name). > But it will not pickup the name again when editing this notice. (One of the > last patches dealt with something similar.) Done. > 5) On Overdue rules, I can enter a delay value and select a notice without > selecting a transport type. The action is saved, but reads to me that Koha > will not do anything with it. Should we warn the user here? > No blocker for now. But could be improved. Not trivial. Javascript code to write will be horrible... In my opinion, it's a lot of ugly code for a small added value. (In reply to M. de Rooy from comment #109) > I have no perfect solution at hand, but maybe just adding 11/160 characters > would already be more clear? Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 16:41:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 15:41:26 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 16:46:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 15:46:33 +0000 Subject: [Koha-bugs] [Bug 12006] New: help.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12006 Bug ID: 12006 Summary: help.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org help.pl doesn't contain information on Branch Limitations for the LOC table. Add New Authorized Value New authorized values can be added to any existing or new category. To add a value: Click 'New authorized value for ...' Enter a code for your Authorized Value into the 'Authorized value' field Important: Authorized value is limited to 80 characters and cannot have spaces or special characters other than underscores and hyphens in it. Use the Description field for the actual value that will be displayed. If you want something different to show in the OPAC, enter a 'Description (OPAC)' If you would like to limit this authorized value category to only specific libraries you can choose them from the 'Branches limitation' menu. To have it show for all libraries just choose 'All branches' at the top of the list. If you have StaffAuthorisedValueImages and/or AuthorisedValueImages set to show images for authorized values you can choose the image under 'Choose an icon' Click 'Save' The new value will appear in the list along with existing values See the full documentation for Authorized Values in the manual (online). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 16:50:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 15:50:19 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #138 from Jonathan Druart --- Created attachment 26651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26651&action=edit Bug 10855: FIX encoding issues. This commit should be reverted when bug 11944 (or replacement) will be fixed. One day, maybe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 16:51:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 15:51:46 +0000 Subject: [Koha-bugs] [Bug 12007] New: http://manual.koha-community.org/3.12/en/basicparams.html#authorizedvalues needs more info Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12007 Bug ID: 12007 Summary: http://manual.koha-community.org/3.12/en/basicparams.h tml#authorizedvalues needs more info Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org "If you would like to limit this authorized value category to only specific libraries you can choose them from the 'Branches limitation' menu. To have it show for all libraries just choose 'All branches' at the top of the list." Please update information to explain that limiting branches doesn't affect items that already have the location being edited in use will be unaffected. Please explain that this only affects setting the location. If the location is set by another library that uses it, it will still appear in the record, regardless of your library. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 16:52:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 15:52:30 +0000 Subject: [Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005 --- Comment #1 from Jacek Ablewicz --- (In reply to Magnus Enger from comment #0) > A quick and dirty fix can be found here: Works for me (3.14.5, apache + mod_perl). Or at least it seems to - hard to tell for sure, as this nasty bug does recur in semi-random fashion. Sometimes the 1st failed search occurs after a couple of minutes after server restart, and sometimes it works seemingly fine for hours.. I got an impression that as long as all processes/workers are relativelly busy, this issue is much harder to reproduce. Also it seems to happen somehow more often / earlier in plack + starman test configuration (or maybe it is just a coincidence). This Q&D fix is kind of ugly, though ;). It does quickly result in a lot of accumulated zebra processes (never to be used again, with postponed death sentences). Wouldn't it be better to destroy the Zconn connection as soon as possible when it is no longer needed? Sadly, ZOOM::Connection object does not automatically disconnect on DESTROY() like DBI does; I guess some kind of wrapper class may be needed to solve this. Also I wonder what kind of performance impact this (= not caching zebra connections at all) may have in plain CGI installations. Perhaps some plack-related fixes in the code should be controlled by new configuration setting (preferably in koha-conf.xml) which will indicate that system is, or is not running in persistent environment (and what kind: plack/*, mod_perl/persistent, mod_perl/semi-persistent ..). Btw, bug 11701 (pushed yesterday) got me thinking: looks like Zconn caching was not plack compatible at all. May it be somehow related to this bug (especially sync vs async thing)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 17:40:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 16:40:00 +0000 Subject: [Koha-bugs] [Bug 9368] specific behavior of yr and acqdate indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9368 --- Comment #12 from Fridolin SOMERS --- Created attachment 26652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26652&action=edit Bug 9368 - do not change if QueryParser -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 17:39:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 16:39:55 +0000 Subject: [Koha-bugs] [Bug 9368] specific behavior of yr and acqdate indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9368 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 17:42:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 16:42:26 +0000 Subject: [Koha-bugs] [Bug 9368] specific behavior of yr and acqdate indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9368 --- Comment #13 from Fridolin SOMERS --- @Jared Here is the follow-up to change code only if not QP on. "Bug 9368 - do not change if QueryParser" needs signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 19:19:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 18:19:29 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #139 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #138) > Bug 10855: FIX encoding issues. 1) still needs ca 100 '| html_entity' to be added in various templates (just kidding, only 10 or so ;) 2) it's not plack compatible ("Variable "$additional_fields" will not stay shared at /home/koha/devkohaclone/serials/subscription-add.pl line 439") - I guess it's just a typo in: sub insert_additional_fields { my ( $additional_fiels, $biblionumber, $subscriptionid ) = @_; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 20:12:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 19:12:21 +0000 Subject: [Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |director at plaistowlibrary.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 20:42:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 19:42:32 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #184 from M. Tompsett --- Someone asked about how to test and why I have my name on so many things. I thought perhaps posting this might help people find the test plan and some background details. > Also, why many commits have only your sign? > Why is your sign at all? Because I didn?t write all the first part. I tested it, because we wanted the same functionality. > It's also difficult to test something without a clear test plan. Yes, yes, it is. I started... Comment 109. Comment 123. Katrin makes similar comments regarding the test plan being difficult or lacking in Comment 128. Comment 131. Comment 142. Which all cumulated into what you are looking for: Comment 175 I only wrote the last patch, which is not signed off. And in my mind, it is the only thing stopping this from reaching QA. > Could you add a description of what to test, before and after patch Before, Koha does not host files, and 856$u needs to point to some external source. After, Koha?s tag editor lets you upload a file and have a URL automatically generated to point to that newly hosted file. I hope this helps someone decide to take the plunge and test this. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 21:05:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 20:05:53 +0000 Subject: [Koha-bugs] [Bug 12008] New: hold notice can be deleted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12008 Bug ID: 12008 Summary: hold notice can be deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Okay this is a strange one. 1. Create a new HOLD notice template for a branch (not for all libraries) 2. Delete that new HOLD notice you created 3. Recreate the HOLD notice template for that branch 4. The HOLD notice for all libraries disappears and in the database the message_transports.branchcode field for HOLD now has the branchcode before it was blank. This causes issues with sending of HOLD notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 22:02:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 21:02:27 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #185 from M. de Rooy --- (In reply to M. Tompsett from comment #184) > I hope this helps someone decide to take the plunge and test this. :) Looking back at the history of this patch, I definitely admire the perseverance of Julian and Mark to get this into Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 22:23:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 21:23:19 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #8 from Robin Sheat --- These shouldn't break the package install, but the changes to koha-conf.xml won't be reflected there, so the bug will probably exist. It'd be good to change debian/templates/koha-conf-site.xml.in to match, and possibly also koha-create (as it looks like some of the parts for the file come from there.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 23:15:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 22:15:34 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #13 from Jesse Weaver --- Created attachment 26653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26653&action=edit Bug 11559 - QA followup: fix several interface and backend issues Switches to Bootstrap modals, and removes the now-unused jquery.lightbox_me and jquery.hotkeys plugins. CodeMirror was switched to a minified version (require already was, pz2 is a custom version, and filesaver is so small that it wouldn't offer much benefit). Also shows proper errors for failure to access Pazpar2 and when a user attempts to transition a Z39.50 record from the basic to the advanced editor. Finally, the alert log is now kept in a dropdown on the toolbar rather than the default location. (Also, a translation issue with the page title was fixed.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 23:15:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 22:15:27 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 23:17:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 22:17:56 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26653|0 |1 is obsolete| | --- Comment #14 from Jesse Weaver --- Created attachment 26654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26654&action=edit Bug 11559 - QA followup: fix several interface and backend issues Switches to Bootstrap modals, and removes the now-unused jquery.lightbox_me and jquery.hotkeys plugins. CodeMirror was switched to a minified version (require already was, pz2 is a custom version, and filesaver is so small that it wouldn't offer much benefit). Also shows proper errors for failure to access Pazpar2 and when a user attempts to transition a Z39.50 record from the basic to the advanced editor. Finally, the alert log is now kept in a dropdown on the toolbar rather than the default location. (Also, a translation issue with the page title was fixed.) I totally forgot a small but important change, reuploading. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 27 23:42:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Mar 2014 22:42:48 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matted-34813 at mypacks.net --- Comment #31 from wajasu --- Idea: To determine which indexes get the additional index:0, we could: provide a UI(similiar to msaby's suggestion that allows us to select an index by grabbing the nodes from biblios-koha-indexdefs.xml, and search replacing index:p with index:pindex:0 (control_field, data_field, sub_field savy UI is possible) That would at least let the selection be flexible according to the current configuration, though that file must be located for "koha packages"(TBD). We could roll out with things initially matching today's facets, and let them select predefined profiles at some point(future feature). The facet selection UI should highlight configured(non-disabled) facets that are may not exist anymore in the biblios-koha-indexdefs.xml, to aid debugging when that file is subsequently modified (admin or future koha update). When querying the chosen facets, it might be worth querying the whole list at once and if it fails, querying each sequentially such that if one fails, we just don't supply that label to the UI and log the failing facet, refering them to the facet config UI to reconcile. But things continue to run. It might be worth looking into generating retreival-info-bib-grs1-faceted.xml and biblios-koha-indexdefs-faceted.xml and launching xsltproc to generate biblio-zebra-indexdefs-faceted.xsl, without touching the original configs. Facets could be disabled to enable non-faceted searching until the issue is resolved. We might also employ xi:include and fallback in koha-conf.xml to use the faceted file(s) which could be generated/removed by the facet config UI. Thus leaving koha-conf.xml flexible. Mapping tags to new indexes that go in biblios-koha-indexdefs.xml can possibly be a separate effort. Of course this is all very zebra focused. But the idea is to restrict free form editing (for security) and allow newly introduced indexes to roll out without concern of breaking updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 01:17:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 00:17:19 +0000 Subject: [Koha-bugs] [Bug 12009] New: Sometimes a koha-common restart won't restart zebra Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12009 Bug ID: 12009 Summary: Sometimes a koha-common restart won't restart zebra Change sponsored?: --- Product: Koha Version: master Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz I saw this: $ sudo /etc/init.d/koha-common restart [sudo] password for robin: Restarting Koha ILS: daemonexecutablenameStopping Zebra server for nzica SIP server for nzica not running. Stopping Starman for nzica Zebra already running for instance nzica. starting starman for nzica Starting Starman for nzica on port 5002 The "Zebra already running" is a problem, and suggests there may be cases where zebra takes a moment to shut down. It should have a waiting phase where we ensure that the process is really gone before we proceed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 02:52:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 01:52:42 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #32 from David Cook --- (In reply to wajasu from comment #31) > Idea: To determine which indexes get the additional index:0, we could: > provide a UI(similiar to msaby's suggestion that allows us to select an > index by grabbing the nodes from biblios-koha-indexdefs.xml, > and search replacing > index:p with > index:pindex:0 > (control_field, data_field, sub_field savy UI is possible) > I think that this is a bad idea. 1) I'm not 100% sure, but I think that many installs of Koha run multiple sites using one set of Zebra configs. At least, that's how it appears to work on package installs. I suppose you could have this be an additive process that checks if "index:0" exists and if not, you can add it, when you want to use that index. That wouldn't screw with other people's indexing too much. But I'm not sure allowing the web server to write files in /etc/koha/ is the best idea. 2) Increasingly, I'm becoming less sure that librarians themselves actually need web access to this type of configuration. I think it is a good idea to have configurable facets, but perhaps having a separate file for this would be best. A sysadmin could then edit it as needed. > When querying the chosen facets, it might be worth querying the whole list > at once and if it fails, querying each sequentially such that if one fails, > we just don't supply that label to the UI and log the failing facet, > refering them to the facet config UI to reconcile. But things continue to > run. > I don't follow you 100% here. I originally thought that you meant we could query zebra for our chosen facets, and if that failed, that we could choose do each individually. That would probably make sense so that facets didn't entirely bust for one badly configured facet. > It might be worth looking into generating > retreival-info-bib-grs1-faceted.xml and biblios-koha-indexdefs-faceted.xml > and launching xsltproc to generate biblio-zebra-indexdefs-faceted.xsl, > without touching the original configs. Facets could be disabled to enable > non-faceted searching until the issue is resolved. > > We might also employ xi:include and fallback in koha-conf.xml to use the > faceted file(s) which could be generated/removed by the facet config UI. > xmlns:xi="http://www.w3.org/2001/XInclude"> > > Thus leaving koha-conf.xml flexible. > > Mapping tags to new indexes that go in biblios-koha-indexdefs.xml can > possibly be a separate effort. > I really think this is getting overly complex. This would likely take quite a bit of code just to add a web UI that most librarians will probably (and should probably) never touch. -- I think the best idea is probably to add "index:0" for our current range of facets, and add it to a few other desired facets (such as pubdate). We put the list of indexes in a file, make sure that those indexes are sent off to Zebra when doing a facet query, and that's that. If a web UI is really necessary, perhaps reading the list of indexes out of that file would make sense. Perhaps the file would be unnecessary and we could just read out the "index:0" facets from the Zebra config, but I would be hesitant about adding them in... ...especially since adding "index:0" and sending a facet query referencing that new index:0 before doing a full re-index will break the facets (if sent as one combined query and not lots of separate ones). -- I'm not saying I have a perfect idea in mind, but I think... we shouldn't try to be too fancy or convoluted. Simple and elegant. We provide a set of default facets, and if folks want to add their own, we leave them with good enough instructions to do so. I really don't want to be dynamically messing with files that should be static. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 07:22:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 06:22:24 +0000 Subject: [Koha-bugs] [Bug 12010] New: ReservesNeedReturns breaks 'Hold Filled' functionality Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12010 Bug ID: 12010 Summary: ReservesNeedReturns breaks 'Hold Filled' functionality Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If you have the system preference "ReservesNeedReturns" turned on, notices for "Holds Filled" won't be generated because the logic thinks that it has already sent one. As far as I can tell, "notificationdate" doesn't even appear to be used. That seems like it would be an excellent place to record the date that a notice was sent out... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 07:23:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 06:23:23 +0000 Subject: [Koha-bugs] [Bug 12011] New: ReservesNeedReturns breaks 'Hold Filled' functionality Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12011 Bug ID: 12011 Summary: ReservesNeedReturns breaks 'Hold Filled' functionality Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If you have the system preference "ReservesNeedReturns" turned on, notices for "Holds Filled" won't be generated because the logic thinks that it has already sent one. As far as I can tell, "notificationdate" doesn't even appear to be used. That seems like it would be an excellent place to record the date that a notice was sent out... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 07:26:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 06:26:00 +0000 Subject: [Koha-bugs] [Bug 12011] ReservesNeedReturns breaks 'Hold Filled' functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12011 --- Comment #1 from David Cook --- Ack. Sorry. Problem in my description. I mean if "ReservesNeedReturns" is turned "OFF" it will create problems, because $found will automatically be 'W' which will turn on $already_on_shelf, which means that _koha_notify_reserve is never triggered in Reserves.pm... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 09:03:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 08:03:49 +0000 Subject: [Koha-bugs] [Bug 12012] New: Updating Zebra config files for debian packages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12012 Bug ID: 12012 Summary: Updating Zebra config files for debian packages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Bug 9612 updates koha-conf.xml and some Zebra config files for DOM indexing in order to resolve the default SRU response and do some cleanup. These changes should be applied to the debian template files as well for package installs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 09:04:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 08:04:20 +0000 Subject: [Koha-bugs] [Bug 12012] Updating Zebra config files for debian packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12012 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 09:04:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 08:04:31 +0000 Subject: [Koha-bugs] [Bug 12012] Updating Zebra config files for debian packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12012 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 09:04:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 08:04:46 +0000 Subject: [Koha-bugs] [Bug 12012] Updating Zebra config files for debian packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12012 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9612 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 09:04:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 08:04:46 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 09:06:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 08:06:04 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from M. de Rooy --- (In reply to Robin Sheat from comment #8) > These shouldn't break the package install, but the changes to koha-conf.xml > won't be reflected there, so the bug will probably exist. It'd be good to > change debian/templates/koha-conf-site.xml.in to match, and possibly also > koha-create (as it looks like some of the parts for the file come from > there.) Thanks. I will open up a new report for that road. Bug 12012. In the meantime this is ready for signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 09:07:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 08:07:23 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #33 from Paul Poulain --- (In reply to David Cook from comment #32) > (In reply to wajasu from comment #31) > > Idea: To determine which indexes get the additional index:0, we could: > > provide a UI(similiar to msaby's suggestion that allows us to select an > > index by grabbing the nodes from biblios-koha-indexdefs.xml, > > and search replacing > > index:p with > > index:pindex:0 > > (control_field, data_field, sub_field savy UI is possible) > > > > I think that this is a bad idea. Agreed with most of your points. One of the reason being that it's impossible to have everything made by the librarian (any change require rebuilding zebra DB, plus some/many config file change. and yes, it's not a good idea to let the webserver write in /etc ...). So I prefer to have everything made by a sysadmin. When we worked on Solr, we made indexes accessible by the web interface, but it's something shipped with Solr. That's not the case for Zebra. > We put the list of indexes in a file, make sure that those indexes are sent > off to Zebra when doing a facet query, and that's that. Zebra is highly sensitive on how the config files are written. I'm not sure you can have :0 indexes in a separate file. AFAIK, when you double declare a line, only the last one is taken into account. So: melm 245$a Title:w,Title:p melm 245$a Title:0 would result in Title:0 being the only index. Which is not what we want. > Simple and elegant. We provide a set of default facets, and if folks want to > add their own, we leave them with good enough instructions to do so. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 09:17:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 08:17:11 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26260|0 |1 is obsolete| | --- Comment #140 from Jonathan Druart --- Created attachment 26655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26655&action=edit Bug 10855: Additional marc fields are not inserted In subscription-add.pl, the code for inserting additional_fields is not the same for updating and inserting. This patch refactores this code in code to do the same tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 09:20:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 08:20:05 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #141 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #139) > 1) still needs ca 100 '| html_entity' to be added in various templates (just > kidding, only 10 or so ;) I would prefer another solution too. > 2) it's not plack compatible ("Variable "$additional_fields" will not stay > shared at /home/koha/devkohaclone/serials/subscription-add.pl line 439") - I > guess it's just a typo in: > > sub insert_additional_fields { > my ( $additional_fiels, $biblionumber, $subscriptionid ) = @_; Thanks for the catch! Sorry for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:10:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:10:10 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:10:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:10:15 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25415|0 |1 is obsolete| | Attachment #25416|0 |1 is obsolete| | Attachment #25417|0 |1 is obsolete| | Attachment #25418|0 |1 is obsolete| | Attachment #25419|0 |1 is obsolete| | Attachment #25420|0 |1 is obsolete| | Attachment #25421|0 |1 is obsolete| | Attachment #25422|0 |1 is obsolete| | Attachment #25606|0 |1 is obsolete| | Attachment #26182|0 |1 is obsolete| | Attachment #26216|0 |1 is obsolete| | Attachment #26233|0 |1 is obsolete| | Attachment #26648|0 |1 is obsolete| | Attachment #26649|0 |1 is obsolete| | Attachment #26650|0 |1 is obsolete| | --- Comment #114 from M. de Rooy --- Created attachment 26656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26656&action=edit Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:10:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:10:24 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #115 from M. de Rooy --- Created attachment 26657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26657&action=edit Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:10:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:10:30 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #116 from M. de Rooy --- Created attachment 26658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26658&action=edit Bug 9016: FIX GetMessageTransportTypes returns an arrayref, not hashref Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:10:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:10:35 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #117 from M. de Rooy --- Created attachment 26659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26659&action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:10:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:10:41 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #118 from M. de Rooy --- Created attachment 26660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26660&action=edit Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:10:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:10:46 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #119 from M. de Rooy --- Created attachment 26661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26661&action=edit Bug 9016: QA Followup Fix tab characters and POD. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:10:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:10:51 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #120 from M. de Rooy --- Created attachment 26662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26662&action=edit Bug 9016: Fix some translate issues On tools/letter.pl and tools/overduerules.pl, some strings were not translatable. This patch should fix that. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:10:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:10:56 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #121 from M. de Rooy --- Created attachment 26663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26663&action=edit Bug 9016 [QA Followup] - Add insertAtCaret library to about page Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:11:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:11:02 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #122 from M. de Rooy --- Created attachment 26664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26664&action=edit Bug 9016: (follow-up) qa fixes * Fixes POD of GetMessageTransportTypes. * Removes the useless map in GetMessageTransportTypes. * Textual: "You must specify a title and a content" -> "Please specify title and content". * Reintroduces << and >> around the field name. * Change message for the update DB entry. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:11:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:11:14 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #124 from M. de Rooy --- Created attachment 26666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26666&action=edit Bug 9016: FIX additional mtt's name should be displayed in header if you insert a new line in your message_transport_types table, the overdues configuration table did not displayed an header. Signed-off-by: Olli-Antti Kivilahti Yes sir works great! Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:11:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:11:08 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #123 from M. de Rooy --- Created attachment 26665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26665&action=edit Bug 9016: FIX GetLetters should return all letters GetLetters only returns letters with a mtt = email. It should return all letter codes in the DB. The message_transport_type parameter is never used. To reproduce the issue: Create a notice with a sms template and no email template. Go on the overdue rules configucation page. The notice does not appear in the notice list. Signed-off-by: Olli-Antti Kivilahti --------------- Testing report: --------------- Testing this subroutine from a test stub. Calling the method without arguments and with argument 'circulation' and 'circulat'. Works as supposed to. Related Bug 11931 discovered but not within the scope of this featureset. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:11:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:11:19 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #125 from M. de Rooy --- Created attachment 26667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26667&action=edit Bug 9016: FIX letter name is not displayed on editing a letter On editing a letter, the letter name is not displayed. So if you save it, the letter name is erased with an empty string. Signed-off-by: Olli-Antti Kivilahti Tested by setting the "Name"-field in letter.pl, saving, re-editing and verifying that the email is present in the letter's "Name"-field. The letter "Name" is replicated for each template in the DB, but that doesn't incur any performance penalty. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:11:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:11:24 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #126 from M. de Rooy --- Created attachment 26668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26668&action=edit Bug 9016: (followup) FIX letter name is not displayed on editing a letter If the name is not in email, the name is not correctly retrieved. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:11:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:11:27 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25068|0 |1 is obsolete| | --- Comment #17 from Julian Maurice --- Created attachment 26669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26669&action=edit Bug 7290: More granular permissions for order receiving Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:11:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:11:29 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #127 from M. de Rooy --- Created attachment 26670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26670&action=edit Bug 9016: Add some validation on the letter form 1/ Code and Name are mandatory. 2/ At least 1 template should be filled on saving. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:11:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:11:34 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 --- Comment #18 from Julian Maurice --- Created attachment 26671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26671&action=edit Bug 7290: Fix constraint name in updatedatabase.pl Set the same constraint name as in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:11:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:11:35 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #128 from M. de Rooy --- Created attachment 26672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26672&action=edit Bug 9016: Improve number of characters display when mtt=sms Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:11:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:11:40 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #129 from M. de Rooy --- Created attachment 26673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26673&action=edit Bug 9016: [QA Follow-up] Remove warning from content.length test If the letter.content is undef, the content.length test in the letter template will trigger warning: Argument "" isn't numeric in numeric gt (>). This patch eliminates that warning. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:12:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:12:50 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 --- Comment #6 from Rafal Kopaczka --- Created attachment 26674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26674&action=edit Bug 9481 (follow up) change parameter order in routine Small change in parameters order. Because other routines in C4::Overudes gets first itemnumber then borrowernumber, changed this to stay consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:13:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:13:23 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Julian Maurice --- A problem in updatedatabase.pl made it failed to insert the new column aqorders.branch. That's why the branch was not saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:14:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:14:15 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 --- Comment #7 from Rafal Kopaczka --- Created attachment 26675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26675&action=edit Bug 9481 QA follow-up Add unit test Add unit test for GetItemCharges in C4::Overdues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:20:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:20:15 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 --- Comment #20 from Katrin Fischer --- Hi Julian, there has been a lot of discussion about an aqorders.branch column, see bug 11001. I am not sure, which was the conclusion right now, but it seems that it was dropped - comment 7. Why not use the branch from the staff patron who created the order? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:41:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:41:11 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:57:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:57:57 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 --- Comment #21 from Julian Maurice --- Hi Katrin, thanks for pointing the discussion. I will remove code that add this column and will use basket branch instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 10:58:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 09:58:22 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 --- Comment #22 from Julian Maurice --- Created attachment 26676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26676&action=edit Bug 7290: Use basket branch instead of order line branch and remove aqorders.branch from updatedatabase.pl and kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:20:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:20:47 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #26 from Julian Maurice --- Created attachment 26677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26677&action=edit Bug 7292: Add new permission to users that have 'order_receive' permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:21:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:21:16 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:23:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:23:11 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 --- Comment #27 from Julian Maurice --- You're right Katrin, this patch modify updatedatabase.pl to add automatically the new permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:34:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:34:40 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #68 from Julian Maurice --- (In reply to Katrin Fischer from comment #66) > I think by accident some patches got on this bug report, that don't belong > here - tidying up a bit. In fact, all patches from sandboxes at biblibre.com were sent by error on this bug (they are about issues_stats.pl, but this bug is about catalogue_stats.pl) I will resubmit patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:35:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:35:00 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25096|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:35:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:35:05 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25097|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:35:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:35:13 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25098|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:35:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:35:20 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25099|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:35:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:35:26 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25100|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:42:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:42:23 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #69 from Julian Maurice --- Created attachment 26678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26678&action=edit Bug 7683: Cataloguing statistics wizard improvements - Add 3 options for cells value - Titles count "COUNT (biblionumber)" - Items count "COUNT (itemnumber)" (current behavior) - Deleted items count "COUNT (deleteditems.itemnumber)" - Add to selectable rows, colums and filters: - items.notforloan - items.materials - items.statisticvalue For each of these fields, retrieve the label in the default cataloging framework. If no MARC field is mapped to the field in question, it does not show this line in the wizard. If the MARC field is associated with a list of authorized values, it displays a dropdown list for the filter, otherwise it displays a text field. - Add to selectable rows, columns and filters: - items.dateaccessioned (creation date) - deleteditems.timestamp (deletion date) (Only if the third option (eg count deleted items) is selected) - Add unit tests for GetMarcSubfieldStructureFromKohaField Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:42:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:42:29 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #70 from Julian Maurice --- Created attachment 26679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26679&action=edit Bug 7683 [Follow-up] Move unit tests in t/db_dependent/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:42:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:42:36 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #71 from Julian Maurice --- Created attachment 26680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26680&action=edit Bug 7683: Remove use of items.statisticvalue and DHTMLcalendar() Also fix indexes of @filters array -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:42:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:42:42 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #72 from Julian Maurice --- Created attachment 26681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26681&action=edit Bug 7683: Remove dead code about dewey and lccn filters $hasdewey and $haslccn were hardcoded to 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:42:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:42:47 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #73 from Julian Maurice --- Created attachment 26682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26682&action=edit Bug 7683: Fix a shift in date filter indexes Date filter indexes are 13, 14, 15, 16, not 14, 15, 16, 17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 11:45:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 10:45:13 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #74 from Julian Maurice --- I squashed some patches (the first is a squash of all signed-off patches) but everything is here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 12:25:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 11:25:48 +0000 Subject: [Koha-bugs] [Bug 12003] Next issues for irregular pattern not correctly predicted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12003 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |julian.maurice at biblibre.com Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 14:10:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 13:10:43 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Pablo L?pez Liotti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paliotti at mdp.edu.ar --- Comment #3 from Pablo L?pez Liotti --- In that state of development is this ? I am searching for some solution to bring Koha a patrons capture image capability. Anybody is using this or anything other way? Thanks. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 15:01:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 14:01:42 +0000 Subject: [Koha-bugs] [Bug 12003] Next issues for irregular pattern not correctly predicted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12003 --- Comment #1 from Julian Maurice --- Created attachment 26683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26683&action=edit Bug 12003: Do not calculate next pubdate for irregular subscriptions Show 'Unknown' when planneddate and publisheddate cannot be calculated Also fixes SQL query in misc/cronjobs/serialsUpdate.pl that was still using "periodicity != 32" to exclude irregular subscriptions from results Test plan: 1) Create a subscription in the serials module. Make sure to choose: Frequency = Irregular 2) Test the prediction pattern, first publication date is set to "First issue publication date" field, others will show as 'unknown' 3) Save the subscription 4) Check the created issue - it will show a published date and a planned date (same as "First issue publication date" field) 5) Receive the issue and check the next generated issue, planned date and published date should show as 'Unknown' 6) Generate a next issue, planned date and published date should also show as 'Unknown' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 15:01:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 14:01:58 +0000 Subject: [Koha-bugs] [Bug 12003] Next issues for irregular pattern not correctly predicted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12003 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 15:16:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 14:16:56 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 --- Comment #8 from Holger Mei?ner --- Created attachment 26684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26684&action=edit Bug 9481 (follow-up) - change parameter order in routine Only small change in parameters order. Because other routines in C4::Overudes gets first itemnumber then borrowernumber, changed this to stay consistent. Signed-off-by: Holger Mei?ner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 15:17:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 14:17:00 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 --- Comment #9 from Holger Mei?ner --- Created attachment 26685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26685&action=edit Bug 9481 (QA follow-up) - Add unit test for GetItemCharges in C4::Overdues. Signed-off-by: Holger Mei?ner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 15:18:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 14:18:48 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26674|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 15:18:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 14:18:50 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26675|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 15:19:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 14:19:57 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 15:42:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 14:42:16 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22623|1 |0 is patch| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 15:50:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 14:50:22 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 --- Comment #4 from Owen Leonard --- I don't know if the attached patch is functional in any way--it was attached as a .docx Word document, which doesn't make any kind of sense. The "patch" looks like it was made against an older version of Koha, so even if you could pull out the changes you'd have to re-implement the solution. Anyway, the offered solution relies on a Flash file, and there's no way a Flash dependency is going to get into Koha. Perhaps it would work as a local customization. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 15:51:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 14:51:05 +0000 Subject: [Koha-bugs] [Bug 10936] Standardnumber doubled up in Advanced search - more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10936 --- Comment #11 from Jesse Maseto --- Created attachment 26686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26686&action=edit Bug 10936 This patch removes the dupilcate "Standard Number" option under the more options of the opac advanced search correctly following updates from Katrin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 15:52:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 14:52:07 +0000 Subject: [Koha-bugs] [Bug 10936] Standardnumber doubled up in Advanced search - more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10936 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26322|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 15:52:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 14:52:31 +0000 Subject: [Koha-bugs] [Bug 10936] Standardnumber doubled up in Advanced search - more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10936 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 16:14:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 15:14:24 +0000 Subject: [Koha-bugs] [Bug 11386] Mandatory fields in subscription add form should use standard formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11386 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 16:14:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 15:14:45 +0000 Subject: [Koha-bugs] [Bug 11860] Display subscription callnumber in OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11860 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 16:15:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 15:15:04 +0000 Subject: [Koha-bugs] [Bug 11861] Add ISSN column in serials claims table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11861 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 16:17:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 15:17:03 +0000 Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 16:17:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 15:17:05 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Bug 10857 depends on bug 10952, which changed state. Bug 10952 Summary: Store anonymous search history in session http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 16:36:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 15:36:27 +0000 Subject: [Koha-bugs] [Bug 12013] New: Long loan period slows checkouts Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12013 Bug ID: 12013 Summary: Long loan period slows checkouts Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: library at stas.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com For circulation.pl and sco.pl, long loan periods cause the pages to take an extrememly long time to load. Checkout times per item slow to tens of seconds. Loading of the patron record in the SCO takes tens of seconds to minutes. ----------- Example: Our professors need to be able to borrow books for an indefinite period, sometimes several years (e.g. for textbooks). To accomplish this we originally set the loan period to 9999 days. The rest of our religious community can borrow for 1 year (loan period set to 365 days). On the staff client and self-checkout, the community would have checkout times of a couple to 10 seconds. Professors would take 30-60 second for each item checkout, and the SCO would take 60-90 seconds to even load their record, then 30-60 seconds per checkout. Changing only their loan period to match the rest of the community (365 days) made checkouts take at most seconds, so the difficulty is this variable and how these scripts use this variable. --------- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 16:50:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 15:50:13 +0000 Subject: [Koha-bugs] [Bug 12014] New: Make self-checkout listing match circulation.pl pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12014 Bug ID: 12014 Summary: Make self-checkout listing match circulation.pl pages Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: library at stas.org QA Contact: testopia at bugs.koha-community.org Circulation.pl differentiates between recent checkouts and past checkouts, placing the most recent at the top for ease of viewing and checking. The self-checkout places instead places all checkout items together, not sorting by date/time of checkout. It would be good if these matched, as this feature of circulation.pl is useful for checking that the item was correctly issued. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 18:15:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 17:15:00 +0000 Subject: [Koha-bugs] [Bug 7023] used saved report page holding on to filter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7023 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 19:16:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 18:16:41 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 20:15:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 19:15:07 +0000 Subject: [Koha-bugs] [Bug 12000] staff users can set hold suspension dates to occur in the past In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 20:15:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 19:15:15 +0000 Subject: [Koha-bugs] [Bug 12000] staff users can set hold suspension dates to occur in the past In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 --- Comment #2 from Owen Leonard --- Created attachment 26687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26687&action=edit [SIGNED-OFF] Bug 12000: ensure that hold resumption dates can be set only to future dates This patch makes the datepickers for the hold resumption date (AKA the hold suspend until date) field only permit dates in the future to be selected in the staff interface checkout page and hold list pages. This makes these pages consistent with the OPAC and the patron details page in the staff interface. To test: [1] Ensure that AutoResumeSuspendedHolds and SuspendHoldsIntranet are enabled. [2] Go to the checkout page for a patron that has at least one hold request. [3] Verify that the datepicker for the hold suspend until date field only permits choosing a date in the future. [4] Go to the page listing hold requests for a title. [5] Verify that the datepicker for the hold suspend until date fields only permit choosing a date in the future. Signed-off-by: Galen Charlton Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 28 20:41:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Mar 2014 19:41:44 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Owen Leonard --- Based at least on comment 13 I think this should be marked as "Failed QA." -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 29 03:07:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 02:07:23 +0000 Subject: [Koha-bugs] [Bug 12015] New: google map of branches and availability Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12015 Bug ID: 12015 Summary: google map of branches and availability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Would be neat to have a google map below the holdings table that showed you the branches that had the items you wanted and a count of how many items were at each branch. This would be a mashup of the marcxml, the branch data, and google maps I would think. That way you could click on a marker on the map to see that branch's info and get directions etc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 29 05:09:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 04:09:27 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- git checkout -b bug_11393 origin/master cd misc/translator perl translate install th-THA (ignoring lots of warnings/errors) staff client -> home -> koha administration -> global system preferences -> I18N/L10N check both th-THA's save reload the page lang menu appears on bottom. apply the patch reload the page -- still th-THA rm -rf ../../koha-tmpl/intranet-tmpl/prog/th-THA/ rm -rf ../../koha-tmpl/opac-tmpl/bootstrap/th-THA/ rm -rf ../../koha-tmpl/opac-tmpl/ccsr/th-THA/ rm -rf ../../koha-tmpl/opac-tmpl/prog/th-THA/ perl translate install th-TH (ignoring lots of warnings/errors) reload the page -- now th-TH and correct description. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 29 05:29:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 04:29:21 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #3 from M. Tompsett --- Comment on attachment 26589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26589 Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved Review of attachment 26589: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11999&attachment=26589) ----------------------------------------------------------------- ::: C4/ILSDI/Services.pm @@ +609,4 @@ > my $title = $$biblio{title}; > > # Check if the biblio can be reserved > + my ($canbookbereserved) = CanBookBeReserved($borrowernumber, $biblionumber); The change in interface that passes back reasons is lost, when you don't include a variable for it. Also, it makes this look like a pointless variable. I suppose it's just hard to read and not really incorrect. @@ +686,5 @@ > return { code => 'RecordNotFound' } if $$item{biblionumber} ne $$biblio{biblionumber}; > > # Check for item disponibility > + my ($canitembereserved) = C4::Reserves::CanItemBeReserved( $borrowernumber, $itemnumber ); > + my ($canbookbereserved) = C4::Reserves::CanBookBeReserved( $borrowernumber, $biblionumber ); Why is there a C4::Reserves::CanBookBeReserved call here, but a CanBookBeReserved in the earlier code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 29 06:41:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 05:41:43 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 --- Comment #3 from Bernardo Gonzalez Kriegel --- Hi Marc, If you translate first with th-THA files it fails, because those filenames do not match the lang If you raname first and then translate all is right, I think :) What do you find wrong? Regards, Bernardo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 29 12:58:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 11:58:59 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 --- Comment #4 from M. Tompsett --- (In reply to Bernardo Gonzalez Kriegel from comment #3) > If you translate first with th-THA files it fails, because those filenames > do not match the lang. yes. > If you [rename] first and then translate all is right, I think :) yes. > What do you find wrong? I was it expecting it to fix my mistaken installation of th-THA. Is that what it should do? Some code in updatedatabase.pl (though probably the wrong place for it) could easily check for and rename the directories if they exist. After all, that is what the original reporter said was the solution for the scenario. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 29 13:12:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 12:12:57 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #4 from Julian Maurice --- > The change in interface that passes back reasons is lost, when you don't > include a variable for it. Also, it makes this look like a pointless > variable. I suppose it's just hard to read and not really incorrect. I don't understand. CanBookBeReserved now returns a list so the return value is affected to a list. Why does the variable look pointless ? I just don't need the $reasons here, so I don't retrieve it. > Why is there a C4::Reserves::CanBookBeReserved call here, but a > CanBookBeReserved in the earlier code? I don't know, but it was like that before the patch, so I didn't change this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 29 14:01:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 13:01:49 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Bernardo Gonzalez Kriegel --- (In reply to M. Tompsett from comment #4) > I was it expecting it to fix my mistaken installation of th-THA. Is that > what it should do? > > Some code in updatedatabase.pl (though probably the wrong place for it) > could easily check for and rename the directories if they exist. > > After all, that is what the original reporter said was the solution for the > scenario. Well, I know that this patch is pointless as a solution to the reporter problem. The real solution is not only change names or update database for current installs, we need to rename some dirs on current installation and that is beyond of what we can do (or I are willing to do) I will rename all th-THA* -> th-TH files on translation server, that will be included on next release or update of master (perhaps if Bug 7939 pass), and this becomes moot. The intent of this patch was to update th names on master, to show that in that way it solves the problem. Normal releases do not change or update translation files on master. If you think that is not enough, I'll put it to sleep. Thank you for testing :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 29 16:36:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 15:36:37 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Brooksml changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jerry at brookslibraryvt.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 29 17:06:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 16:06:47 +0000 Subject: [Koha-bugs] [Bug 12016] New: After upgrading, APACHE is running but browser cannot connect Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12016 Bug ID: 12016 Summary: After upgrading, APACHE is running but browser cannot connect Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: hissheep4 at gmail.com QA Contact: testopia at bugs.koha-community.org Since upgrading to this new release (3.14.5) on Thursday 28th March, (No changes were made to the config file - We only ran the upgrade, reindexed Zebra and restarted APACHE server) a) we can ping the server, b) resolve the hostname, c) there are no errors output when starting the APACHE server, d) the config file for APACHE has no syntax errors, e) the virtual host for KOHA is set as active, f) the port is set to port 80, BUT even trying to navigate to the localhost from a local web browser it fails to connect to the http server. Any ideas welcome -- Please help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 29 17:14:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 16:14:57 +0000 Subject: [Koha-bugs] [Bug 12016] After upgrading, APACHE is running but browser cannot connect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12016 --- Comment #1 from JB --- Sometimes it works for a minute or two and actually does manage to search the database, but within a couple minutes it's back to the same problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 29 17:23:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 16:23:15 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 --- Comment #2 from JB --- We were really wanting to prevent them from changing the preferences because we don't print any paper reports for checkout etc. If we protect them from making changes as we would like to do, we are also unable to access this information to set their preferences because it does not even display in the patron record. Therefore, we have to allow the patrons access to this information and then just manually change it ourselves anytime a patron self registers. I've set the emailing to come to me when anyone self registers so that I will find their record and update the preferences. Most patrons don't know much about the preferences and the difference between "email" and "digest". I do understand this is just a minor problem as I can get around it. I'm very thankful to those wonderful programmers who make all the updates and keep everything running smoothly!! Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 29 18:28:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 17:28:14 +0000 Subject: [Koha-bugs] [Bug 12016] After upgrading, APACHE is running but browser cannot connect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12016 JB changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |trivial --- Comment #2 from JB --- I have changed the importance to trivial, because I just do not have enough information about this, as it seems like sporadically things are starting to work. If I click on a shortcut to log into the staff client instead of "topsides". We use Koha on Firefox and Safari browsers and both are experiencing these errors. I'm not sure if this is a cache problem or an incompatible framework due to a framework change. I don't know how to delete a bug report, so I'm downgrading it until I have more information to make this easier to debug or if we determine that this is our fault and not a general Koha type bug we will try to delete it. Sorry for the inconvenience. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 30 00:25:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 23:25:43 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 30 00:25:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 23:25:46 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26646|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 26688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26688&action=edit [SIGNED OFF] Bug 11393 - Language menu not show up as name for Thai (th-THA was shown) The problem is with the name of PO files Currently Koha expect, among other variants, that PO filenames began with (using as example *-pref.po): {lang}-pref.po {lang}-{region}-pref.po {lang}-{scrip}-pref.po {lang}-{script}-{region}-pref.po and expect 2 chars for lang and region, and 4 for script So the problem with Thai translation files are that it's names do not match that convention. This patch only rename Thai files as th-THA-* to th-TH-*. In that way language description is right. translate script use that chars to make dirs, and use dirs to find description. To test: 1) Go to I18N/L10N sysprefs 2) Install th-THA language (or simply mkdir koha-tmpl/intranet-tmpl/prog/th-THA) 3) Reload page, wrong description 4) Apply patch 5) Install th-TH language (or simply mkdir koha-tmpl/intranet-tmpl/prog/th-TH) 6) Reload page, right description 7) If you want do "mkdir koha-tmpl/intranet-tmpl/prog/th-Thai", reload, also right description To the reporter of this Bug: the rename of the folder is a good workaround, when this patch is pushed to stable I'll rename Thai files Signed-off-by: Mark Tompsett This does not correct existing problems which need human intervention. It does, however, allow for a correct installation of Thai after the patch is made. If we really want a patch for fixing an existing install. I wrote it, but have not tested it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 30 00:28:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 23:28:31 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 --- Comment #7 from M. Tompsett --- Created attachment 26689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26689&action=edit Bug 11393 - Untested patch for doing the human intervention part. This is intentionally going to be obsoleted, but attached to the bug so it could be referenced, if needed. File::Copy is already a dependency, and File::Find is a core module as far as I can tell. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 30 00:30:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Mar 2014 23:30:09 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26689|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Comment on attachment 26689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26689 Bug 11393 - Untested patch for doing the human intervention part. Intentionally obsoleted, because I don't think it is wanted at this time, nor is it preferred. However, I do want it somewhere accessible if someone would like to see my attempt. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 30 01:46:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Mar 2014 00:46:03 +0000 Subject: [Koha-bugs] [Bug 12017] New: Move language description out of database Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bug ID: 12017 Summary: Move language description out of database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Language descriptions are stored in database using this tables language_descriptions language_rfc4646_to_iso639 language_subtag_registry Those tables are filled at install time using en/mandatory/subtag_registry.sql or translated variants. As with any string stored in database, it's difficult to update and synchronize those files. I propose to use language descriptions out of database using standard templates files. Then these can be translated in a standard way, and as a bonus save many access to the database -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 30 01:46:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Mar 2014 00:46:21 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 30 04:48:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Mar 2014 02:48:23 +0000 Subject: [Koha-bugs] [Bug 11869] Add more informations to the member printing pages. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 30 04:48:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Mar 2014 02:48:26 +0000 Subject: [Koha-bugs] [Bug 11869] Add more informations to the member printing pages. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25940|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 26690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26690&action=edit [SIGNED OFF] Bug 11869 - Add more informations to the account printing page This patch adds additional informations to the "Print summary" and the "Print receipt" templates. Additional informations in "Print summary" : * Registration date * Expiration date * Library * Category * Fines and payments TEST PLAN --------- 1) Go to a patron. 2) Make sure they have something checked out. 3) Manually add a fine. 4) Under the 'Print' button click 'Print summary' -- the resulting preview should: a) have the first for things listed above, and b) have a new fines and payments section. Signed-off-by: Mark Tompsett NOTE: The due date of the check out is not part of this patch, and so I signed off. Similarly, anything required for slips is configurable elsewhere now and thus comment 1 does not accurately reflect the intent of this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 30 07:04:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Mar 2014 05:04:56 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 26691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26691&action=edit Bug 12017 - Move language description out of database This patch moves language descriptions from database into template files, to ease the translation process. As pointed out on comment #5 of Bug 9056 [1], present implementation needs many queries to database, and more important, it's very difficult to scale so that every language could properly name any other language. So, at the cost of loose some native descriptions, that can be added or replace english ones, I propose to use only the rfc4646 subtag (it's in the name of translation files or translated directories) to find the proper name for language/region/script using blocks of template files It's more work for translators To test: 1) Do some fake translations, for example all langs for l in $(cd misc/translator/po; ls *-pref.po | sed 's/-pref.po//'); do mkdir koha-tmpl/intranet-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/bootstrap/$l; mkdir koha-tmpl/opac-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/ccsr/$l; done 2) Go to Administration > System preferences > I18N/L10N Preety mess! 3) Enable some random languages, some in groups (fr|en) on staff/opac. Enable OPAC changelanguage 4) Reload page, look at the bottom for language changer Also open a OPAC view, look for language changer Do NOT change languages 5) Apply the patch 6) Reload STAFF page, some cosmetic changes on lang display and language changer 7) Reload OPAC page, similar view of language changer 8) Change OPAC theme (prog|ccsr) and check again On prog and ccsr the result is not preety, but works 9) Now to business: Translations. Update language files for one of the active languages, say de-DE (cd misc/translator; perl translate update de-DE; perl translate update de-DE; perl translate install de-DE) 10) Change language to German (DE), reload STAFF page, some of the strings are already translated!!! 11) Check that there are many references to 'language.inc' files on PO files egrep "language.inc" misc/translator/po/de-DE-*po 12) Sign! Note: I'm imposing a sort order on results, by subtag, that could slow things a little (almos nothing if there are few languages). Could be removed. Note2: I put every string between it's own In that way each string is taken individually to translate instead of a solitary line filled with '%s' Note3: Of course if this pass it needs a lot of followups to eventually remove language tables, but that needs more analysis, there are more funcions on C4/Languages.pm that use the tables. But it's a first step. Also more followups are needed to update or complete languages/regions/scripts [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9056#c5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 30 07:05:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Mar 2014 05:05:54 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 30 07:24:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Mar 2014 05:24:59 +0000 Subject: [Koha-bugs] [Bug 9056] Add more translations to table language_descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9056 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Hi, could someone take a look at Bug 12017 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 30 07:46:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Mar 2014 05:46:15 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #34 from wajasu --- OK, David and Paul. I'll code a facet query in our current search for a set of expected facets, as we use today, plus pubdate, or others added with followup patches. I'll query for all in one go. If that fails, then might try individual queries as a fallback. Maybe even keep the current code as a fallback. If sysadmin updates the configs, then we get the enhanced behavior. We can NYTprof and see impact. If a discernable impact, we could add syspref "ZebraNativeFaceting" on/off. Let me attempt to throw something simple together before i forget how all this zebra search stuff works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 00:00:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Mar 2014 22:00:33 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24992|0 |1 is obsolete| | --- Comment #58 from mathieu saby --- Created attachment 26692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26692&action=edit [PATCH] Bug 10869: Allow the deletion of order line if the record is deleted This patch fixes 2 issues : (medium issue) It is not possible to delete an order in a basket if the biblio record is deleted. (minor issue) There is a useless hyperlink around "Deleted bibliographic notice", and "notice" is a frenchism for "record" Biblionumber was passed to the function as 1st parameter, which made impossible to suppress an order whose associated biblio record was suppressed. Moreover, the biblionumber is not needed to get and suppress the order, but only to suppress items, in a second step. Change made to Acquisitions::DelOrder: - I changed the order of the 2 parameters: now $ordernumber as 1st parameter and $biblionumber as 2d parameter - I renamed $bibnum to $biblionumber - I removed $biblionumber from the main SQL query of the function - I suppressed useless $sth->finish - if no $biblionumber is provided, Koha does not try to suppress the items linked created by acq process Change made to the calls to Acquisitions::DelOrder in Koha's code, to change the order of the parameters - in addorder.pl - in basket.pl - in UT t/db_dependant/Acquisition.t Change made in template basket.tt. This bug was signed off by Cedric some time ago, but it needs a second sign off, because I had to made some little changes. To test : 1. Fill a basket with some records (some records with items or holds, some without items) 2. Supress one of the record 3. In the basket (refresh the screen) check that "Deleted bibliographic notice" line was replaced with "Deleted bibliographic record", without hyperlink arround 4. Delete this order with the link "Delete order" to the right column of the table 5. Check there is a new line in the "Deleted orders" table 6. Check there is no regression : delete an other order (one with no item), then check you cannot delete an order with an item (like before patch) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 00:21:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Mar 2014 22:21:13 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25003|0 |1 is obsolete| | --- Comment #59 from mathieu saby --- Created attachment 26693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26693&action=edit [PATCH 2/2] Bug 10869 Followup: Unit tests for DelOrder [The best would be to add a second sign-off to this patch, as I had to to a little change, to take into account the recent rewrite of t/db_dependent/Acquisition.t: $ordernumber3 is now $ordernumbers[2] Mathieu Saby] DelOrder now returns undef if no ordernumber passed. This patch also adds unit tests for DelOrder. Test plan: A. With syspref AcqCreateItem = on placing an order 1. Fill a basket with some orders (some records with already existing items or holds, some without items). New items linked with the order will be created 2. Keep the basket open 3. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 4. In the basket, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 5. After deleting the order, check there is a new line in the "Deleted orders" table 6. Regression test : try to delete other orders, and check the deletion of the order implies the deletion of items created when ordering a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. After you have deleted it, the items created when ordering must have been deleted. 7. Add some other orders to your basket (some records with already existing items or holds, some without items). New items linked with the order will be created 8. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 9. Close the basket 10. Go on receipt page 11. Search the orders of your basket 12. In receipt page, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 13. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. After you have deleted it, the items created when ordering must have been deleted. B. With syspref AcqCreateItem = on receiving an order 1. Fill a basket with some orders (some records with already existing items or holds, some without items). 2. Keep the basket open 3. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 4. In the basket, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 5. After deleting the order, check there is a new line in the "Deleted orders" table 6. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. 7. Add some other orders to your basket (some records with already existing items or holds, some without items). 8. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 9. Close the basket 10. Go on receipt page 11. Search the orders of your basket 12. In receipt page, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 13. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. And to test the UT: prove t/db_dependent/Acquisition.t Signed-off-by: Marcel de Rooy Amended the patch as to removing biblio parameter in DelOrder. There is no need to remove the parameter if you will search for biblionumber later on. Deleting records in aqorders_items is discussed on bug 11617. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 00:21:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Mar 2014 22:21:25 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 00:22:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Mar 2014 22:22:44 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #60 from mathieu saby --- I had to make some little changes to the main patch and to the followup, so the best would be to test again those patch and add new sign-off. I know Sonia Bouis from Lyon3 was interested with this bug. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 00:49:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Mar 2014 22:49:30 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #16 from David Cook --- (In reply to nicolas from comment #13) > The SysPref is present in the database (we looked for > MembershipExpiryDaysNotice in PHPMyAdmin), but not in the Administration > interface... Are you sure? Again, I haven't applied the actual patch, but it looks like it should be in the Patrons tab in the Global System Preferences. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 02:09:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 00:09:31 +0000 Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 --- Comment #9 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #7) > I have added some other related bugs. My suggestion would be, that we first > fix the English file as reference and then either > - copy the corrected English file for all translated installers > - or better: move it out of the language specific installer directories > (like syspref.sql) I did a patch for your last suggestion, changed Installer.pm and did a install to test it. It worked Later I changed my mind and did Bug 12017. I think it's better to have languages descriptions out of database, at last for translations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 03:01:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 01:01:18 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 26694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26694&action=edit Bug 12017 - Followup - Sort and update lang/script/regions lists This followup sorts and updates language/regions/scripts lists As far as I know there all languages, scripts and regions, included some not yet present on master. To test with previous patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 05:09:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 03:09:35 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #3 from Bernardo Gonzalez Kriegel --- Note4: In the former procedure having something like this in subtag_registry.sql was useless INSERT INTO language_descriptions(subtag, type, lang, description) VALUES ( 'zh', 'language', 'zh', '中文'); INSERT INTO language_descriptions(subtag, type, lang, description) VALUES( 'zh', 'language', 'en', 'Chinese'); INSERT INTO language_descriptions(subtag, type, lang, description) VALUES( 'zh', 'language', 'fr', 'Chinois'); INSERT INTO language_descriptions(subtag, type, lang, description) VALUES( 'zh', 'language', 'de', 'Chinesisch'); (I mean the translations) because the former procedure will always use native representation if present (zh - ??), then current language (ej. in de - Chinesisch ), then english version as last resort (Chinese) I can reintroduce native versions, hardcoded so nobody tries to translate them, and mimic former procedure, but in that case I don't see the point to translate names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 05:14:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 03:14:58 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #22 from Srdjan Jankovic --- Created attachment 26695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26695&action=edit bug_11213: Include XSLT processing for searchResults() test * Added template paths to temp test dir, so XSLT templates can be picked up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 05:47:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 03:47:01 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hi Bernardo, my impression was that the translations where used to build the langauage sarch pull down on advanced search, but I am not sure if that changed at some point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 05:48:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 03:48:16 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 --- Comment #13 from David Cook --- Actually, a quick glance at this code makes me think that we're adding "more" arbitrary numbers into the label printer... I would need to take a further look but I think it would be an idea to look at Chris Nighswonger's idea of using C4::Creators::PDF->StrWidth which uses PDF::Reuse's prStrWidth method for calculating string width. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 05:55:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 03:55:46 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #23 from Srdjan Jankovic --- Created attachment 26696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26696&action=edit bug_11213: C4::VirtualShelves::Page::shelf_contents() * Extracted shelf items processing from shelfpage() into a separate sub shelf_contents() in order to be able to test it * Added tests for shelf_contents() witx XSLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 05:57:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 03:57:30 +0000 Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 05:57:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 03:57:33 +0000 Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26519|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 26697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26697&action=edit Bug 10818 - System preference OAI-PMH:ConfFile isn't translatable This patch correct english display for OAI-PMH:ConfFile syspref, and makes it's strings translatable To test: 1) On Administration > System preferences > Web Services OAI-PMH:ConfFile syspref doesn't have description before file box. Text after that box is not translated. 2) Choose your prefered language, xx-YY, update po files cd misc/translator perl translate update xx-YY 3) Look into xx-YY-pref.po for any occurence of "YAML", there is none 4) Apply the patch 5) Update po files again 6) Look into xx-YY-pref.po, now there are 2 entries 7) Also reload page from 1) and check for text before file box. Signed-off-by: Mark Tompsett NOTE: I had to use install and not update, but the idea is the same. Having fixed the English po files, the other language po files (I used fr-FR) correctly generates text before the system preference text box. It's still English, but that is expected, as far as I know, since the French po files are lacking the translation for the strings. This corrects two problems at the same time, not just the original bug problem. 1) Missing text before system preference text box. 2) Missing string to translate in the po file. Where (2) is the original problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 06:42:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 04:42:11 +0000 Subject: [Koha-bugs] [Bug 10936] Standardnumber doubled up in Advanced search - more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10936 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Severity|enhancement |minor --- Comment #12 from M. Tompsett --- I decided to attempt a grep: $ grep -l "Standard number" `find . -name "*.tt"` ./koha-tmpl/intranet-tmpl/prog/en/modules/labels/search.tt ./koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt ./koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt ./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt ./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt This problem exists in: ./koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt ./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt Please attach a fix for prog as well. This will allow for back ports to previous versions. I changed this to a minor bug, not an enhancement. Please check the bug level in the future. Enhancement is the current default (BAD!!!!!). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 07:16:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 05:16:52 +0000 Subject: [Koha-bugs] [Bug 10936] Standardnumber doubled up in Advanced search - more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10936 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26686|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 26698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26698&action=edit [SIGNED OFF] Bug 10936 - 'Standard number' doubled up in Advanced search This patch removes the dupilcate 'Standard number' option under the more options of the opac advanced search correctly following updates from Katrin. TEST PLAN --------- 1) Set opacthemes system preference to bootstrap 2) In OPAC, click 'Advanced search' 3) Click 'More options' 4) Check the Keywords dropdown for duplicate 'Standard number' 5) Apply patch 6) Refresh page, and make sure 'More options' is clicked still 7) Check the Keywords dropdown for duplicate 'Standard number' -- it's not this time. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 07:18:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 05:18:04 +0000 Subject: [Koha-bugs] [Bug 10936] Standardnumber doubled up in Advanced search - more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10936 --- Comment #14 from M. Tompsett --- I have left this as 'Needs Signoff', since I'm waiting for a prog theme patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 09:03:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 07:03:39 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #35 from Paul Poulain --- (In reply to wajasu from comment #34) > We can NYTprof and see impact. If a discernable impact, we could add > syspref "ZebraNativeFaceting" on/off. mmm... Why would we want to have this syspref OFF ? Currently, the facets are wrong (at least incomplete), slow to calculate. With this patch they will become more reliable & faster. So ... If we implement this, that could be a requirement for upgrade (to check/update zebra configuration). For libraries using package, it's automatic. For others, they are supposed to know what they're doing, they're able to update the config. This already happened (for example the bug 3087) > Let me attempt to throw something simple together before i forget how all > this zebra search stuff works. +1 ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 10:34:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 08:34:24 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |h.meissner.82 at web.de --- Comment #14 from Holger Mei?ner --- Applying: Bug 8995: Show OpenURL links in OPAC search results Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl Auto-merging opac/opac-detail.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACResults.xsl Auto-merging koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 8995: Show OpenURL links in OPAC search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 11:01:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 09:01:34 +0000 Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 --- Comment #5 from Katrin Fischer --- I think the step Mark was missing is 5.5 reinstall the templates. :) Bernardo, thx a lot for tackling all those translation problems! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 11:05:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 09:05:53 +0000 Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 11:11:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 09:11:36 +0000 Subject: [Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26697|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 26699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26699&action=edit [PASSED QA] Bug 10818 - System preference OAI-PMH:ConfFile isn't translatable This patch correct english display for OAI-PMH:ConfFile syspref, and makes it's strings translatable To test: 1) On Administration > System preferences > Web Services OAI-PMH:ConfFile syspref doesn't have description before file box. Text after that box is not translated. 2) Choose your prefered language, xx-YY, update po files cd misc/translator perl translate update xx-YY 3) Look into xx-YY-pref.po for any occurence of "YAML", there is none 4) Apply the patch 5) Update po files again 6) Look into xx-YY-pref.po, now there are 2 entries 7) Also reload page from 1) and check for text before file box. Signed-off-by: Mark Tompsett NOTE: I had to use install and not update, but the idea is the same. Having fixed the English po files, the other language po files (I used fr-FR) correctly generates text before the system preference text box. It's still English, but that is expected, as far as I know, since the French po files are lacking the translation for the strings. This corrects two problems at the same time, not just the original bug problem. 1) Missing text before system preference text box. 2) Missing string to translate in the po file. Where (2) is the original problem. Signed-off-by: Katrin Fischer Works for me as described, only changes YAML pref file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 11:31:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 09:31:32 +0000 Subject: [Koha-bugs] [Bug 12000] staff users can set hold suspension dates to occur in the past In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 11:31:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 09:31:35 +0000 Subject: [Koha-bugs] [Bug 12000] staff users can set hold suspension dates to occur in the past In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26613|0 |1 is obsolete| | Attachment #26687|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 26700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26700&action=edit [PASSED QA] Bug 12000: ensure that hold resumption dates can be set only to future dates This patch makes the datepickers for the hold resumption date (AKA the hold suspend until date) field only permit dates in the future to be selected in the staff interface checkout page and hold list pages. This makes these pages consistent with the OPAC and the patron details page in the staff interface. To test: [1] Ensure that AutoResumeSuspendedHolds and SuspendHoldsIntranet are enabled. [2] Go to the checkout page for a patron that has at least one hold request. [3] Verify that the datepicker for the hold suspend until date field only permits choosing a date in the future. [4] Go to the page listing hold requests for a title. [5] Verify that the datepicker for the hold suspend until date fields only permit choosing a date in the future. Signed-off-by: Galen Charlton Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Works as described, passes all tests and QA script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 11:53:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 09:53:05 +0000 Subject: [Koha-bugs] [Bug 11946] add table sorters to label and patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 11:53:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 09:53:09 +0000 Subject: [Koha-bugs] [Bug 11946] add table sorters to label and patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26565|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 26701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26701&action=edit [PASSED QA] Bug 11946 - add table sorters to label and patron card batches When viewing batches of titles in the label creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. To test, go to Tools -> Labels -> Manage label batches. View an existing batch or create a new batch and populate it with items. Table sorting controls should work correctly. Signed-off-by: Nicole C. Engard Solves 1/2 of this bug which is to add the sorters to labels, the original request was to add this to patron cards as well. Signed-off-by: Katrin Fischer Works as described, passes all tests and QA script. Template could be improved forther by showing the itemtype description instead of the code in the table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 12:04:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 10:04:44 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 12:06:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 10:06:03 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26627|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 26702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26702&action=edit [PASSED QA] Bug 11184: correct attribute cloning for the maint screen To test - Patron details entry page: * Have ExtendedPatronAttributes enabled. Check that "Additional attributes and identifiers" section behaves. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Tested with different types of patron attributes: - repeatable - linked to an authorized value - free text Tested editing, adding, removing one of multiple, adding multiple, etc. No regressions found. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 12:09:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 10:09:09 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26702|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 26703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26703&action=edit [PASSED QA] Bug 11184: correct attribute cloning for the maint screen To test - Patron details entry page: * Have ExtendedPatronAttributes enabled. Check that "Additional attributes and identifiers" section behaves. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Tested with different types of patron attributes: - repeatable - linked to an authorized value - free text Tested editing, adding, removing one of multiple, adding multiple, etc. No regressions found. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 13:46:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 11:46:44 +0000 Subject: [Koha-bugs] [Bug 7981] Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #1 from Benjamin Rokseth --- Seems to me HomeOrHoldingBranchReturn SysPref is a residue or at least not any more in use. Circulation rules in 'Default checkout, hold and return policy' seems to be the preferred setting. At least they are honored in C4::Circulation. This also affects SIP transactions as returns gets no return branch. I will make a small patch to remove syspref HomeOrHoldingBranchReturn and make C4::Circulation::AddReturn return message about transfer branch on checkin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 14:09:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 12:09:13 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #38 from Jonathan Druart --- Created attachment 26704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26704&action=edit Bug 7673: The delete all items link should only be displayed if delete_all_items is set This test had been lost in a rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 14:09:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 12:09:57 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #39 from Jonathan Druart --- Created attachment 26705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26705&action=edit Bug 7673: Add permission delete_all_items if user has edit_items The delete_all_items permission should be added to users having the edit_items permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 16:21:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 14:21:52 +0000 Subject: [Koha-bugs] [Bug 11946] add table sorters to label batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Summary|add table sorters to label |add table sorters to label |and patron card batches |batches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 16:22:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 14:22:19 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #17 from Zeno Tajoli --- I insert a list of test for this bug: -- Install it on a marc21/english setup -- Import from files and from z39.50 greek/cyrillic records -- Index them in zebra, try searches and factes -- Catalogue update/display of record with greek/cyrillic chars -- Indexing update rsults -- libraries with greek/cyrillic names -- Try extra fields for patron with special chars [with system preference ExtendedPatronAttribute on 'YES'] -- Greek/cyrillic chars in ACQ budget/ordee/vendor -- Greek/cyrillic chars in letters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 16:24:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 14:24:57 +0000 Subject: [Koha-bugs] [Bug 12018] New: add table sorting to patron card batches Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018 Bug ID: 12018 Summary: add table sorting to patron card batches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label printing Assignee: cnighswonger at foundations.edu Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org Table sorting should be added to the list of records in the patron card batch. Bug 11946 should be viewed for more details and a screenshot; I opened this bug since the patch that was pushed for 11946 only covered the item label batches part of the original bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 16:25:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 14:25:32 +0000 Subject: [Koha-bugs] [Bug 11946] add table sorters to label batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton --- Pushed to master. Since the patch covered only half of the request, I've opened a new bug, bug 12018, for the patron card portion. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 16:27:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 14:27:46 +0000 Subject: [Koha-bugs] [Bug 12000] staff users can set hold suspension dates to occur in the past In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 17:52:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 15:52:06 +0000 Subject: [Koha-bugs] [Bug 12018] add table sorting to patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12018 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 17:54:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 15:54:47 +0000 Subject: [Koha-bugs] [Bug 11973] Fix Armenian language description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 --- Comment #10 from Katrin Fischer --- Hi Bernardo, thx a lot for looking into this. I think one of the reasons it wasn't moved to the templates was that we don't want to translate, but show the native description for languages - not sure how to do that with the translation system. Also in advanced search we show the native and the translated description together. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 18:05:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 16:05:52 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 18:05:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 16:05:57 +0000 Subject: [Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26688|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 26706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26706&action=edit [PASSED QA] Bug 11393 - Language menu not show up as name for Thai (th-THA was shown) The problem is with the name of PO files Currently Koha expect, among other variants, that PO filenames began with (using as example *-pref.po): {lang}-pref.po {lang}-{region}-pref.po {lang}-{script}-pref.po {lang}-{script}-{region}-pref.po and expect 2 chars for lang and region, and 4 for script So the problem with Thai translation files are that it's names do not match that convention. This patch only rename Thai files as th-THA-* to th-TH-*. In that way language description is right. translate script use that chars to make dirs, and use dirs to find description. To test: 1) Go to I18N/L10N sysprefs 2) Install th-THA language (or simply mkdir koha-tmpl/intranet-tmpl/prog/th-THA) 3) Reload page, wrong description 4) Apply patch 5) Install th-TH language (or simply mkdir koha-tmpl/intranet-tmpl/prog/th-TH) 6) Reload page, right description 7) If you want do "mkdir koha-tmpl/intranet-tmpl/prog/th-Thai", reload, also right description To the reporter of this Bug: the rename of the folder is a good workaround, when this patch is pushed to stable I'll rename Thai files Signed-off-by: Mark Tompsett This does not correct existing problems which need human intervention. It does, however, allow for a correct installation of Thai after the patch is made. If we really want a patch for fixing an existing install. I wrote it, but have not tested it. Signed-off-by: Katrin Fischer As pointed out by Mark, this does not fix existing installations. Putting a note in the release notes might be something we can do here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 18:08:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 16:08:06 +0000 Subject: [Koha-bugs] [Bug 11763] Consolidate fund action links into menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #5 from Katrin Fischer --- The dependent bug still needs a sign off - hoping to get back to this soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 18:20:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 16:20:55 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- I think this patch is incomplete - AdvancedSearchTypes is no longer a switch, but can have multiple values: loc - NOT OK, the itemtype pull down still shows, but it's empty ccode - OK, collections show itemtypes - OK, itemtypes show ccode|itemtpyes - NOT OK, pull down empty itemtypes|loc - NOT OK, pull down empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 19:23:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 17:23:37 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2597 Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 19:23:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 17:23:37 +0000 Subject: [Koha-bugs] [Bug 2597] No way to do mouseless cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2597 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11559 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 19:29:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 17:29:53 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 19:29:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 17:29:58 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26162|0 |1 is obsolete| | Attachment #26163|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer --- Created attachment 26707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26707&action=edit [PASSED QA] Bug 10694 - Allow arbitrary backdating of returns Sometimes libraries need to backdate returns further back in time than Koha's dropbox mode will allow. The returns backdating will check in an item as if it had been returned on the specified date, and will reduce any fine accordingly. Test Plan: 1) Apply this patch 2) Check out an item, and backdate the due date by 1 month or so * This issue needs to generate a fine 3) Run fines.pl to generate the fine 4) Browse to returns.pl 5) Specify a return date of the day after the specified due date 6) Check the borrowers issue history, you should see the backdated return date, rather than today's date 7) Check the fine, it should be reduced to a fine for a single day overdue, rather than the previous larger fine. Signed-off-by: Kyle M Hall Signed-off-by: Barbara Knibbs Signed-off-by: Petter Goksoyr Asen Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 19:41:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 17:41:32 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 --- Comment #34 from Katrin Fischer --- Created attachment 26708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26708&action=edit [PASSED QA] Bug 10694 - Allow arbitrary backdating of returns - QA Followup Bug 10694 - Allow arbitrary backdating of returns - QA Followup 2 Bug 10694 - Allow arbitrary backdating of returns - QA Followup 3 Signed-off-by: Petter Goksoyr Asen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 19:43:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 17:43:05 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 --- Comment #35 from Katrin Fischer --- Couldn't find any critical problems with this, but still some ideas for possible enhancements: - It would be nice there was some feedback about a reduced fine when returning the item - Also, currently the return date is not visible in the returns table, so you can't check which date you used for returning something. I'd suggest adding the return date when the specifyreturndate feature is enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 19:47:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 17:47:03 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #36 from Katrin Fischer --- Hm, I think I missed something here - we should have some unit tests for the changes to AddReturn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 20:21:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 18:21:44 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 20:21:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 18:21:47 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20790|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 26709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26709&action=edit Bug 10823 - add class info to enumchron data in detail.tt, for better styling By adding div tags, styling ability can be improved. This included serialseq and pubdate classes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 20:22:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 18:22:07 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10825 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 20:22:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 18:22:07 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10823 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 20:34:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 18:34:41 +0000 Subject: [Koha-bugs] [Bug 12019] New: funds displayed on acquisition home show funds of all branches Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Bug ID: 12019 Summary: funds displayed on acquisition home show funds of all branches Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org Created attachment 26710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26710&action=edit funds Hi, In 3.12, funds displayed on acquisition home show funds of all branches. In 3.8, funds of librarian's branch were displayed. Is this an enhancement? I forgot a sys pref? See the capture. Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 20:43:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 18:43:15 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 --- Comment #7 from M. Tompsett --- Did I miss the "ball in my court" signal? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 20:46:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 18:46:34 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Marjorie, some ideas: - do you have superlibrarian permission? - are your funds 'limited to' the library? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 20:56:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 18:56:40 +0000 Subject: [Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823 --- Comment #7 from Katrin Fischer --- Comment on attachment 26709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26709 Bug 10823 - add class info to enumchron data in detail.tt, for better styling Hm, why a div and not a span? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 21:30:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 19:30:48 +0000 Subject: [Koha-bugs] [Bug 11786] Improve RDFa schema.org mappings in prog and bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11786 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25546|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 26711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26711&action=edit Bug 11786: Improve RDFa structured data schema.org mappings This patch updates both the prog and bootstrap themes to provide better schema.org mappings for catalogue elements in the following ways: * More granular author attributes (one "author" property per author in records with multiple contributors; wrap in a Person or Organization type instead of using a simple literal value) * Use "byArtist" instead of "author" for music recordings to respect schema.org preferences * Use alternateName instead of alternativeHeadline, as the former is a better parallel to the "name" property Signed-off-by: Dan Scott Signed-off-by: Chris Cormack Only covers MARC21, but that is no reason not to move it forward -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 21:30:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 19:30:44 +0000 Subject: [Koha-bugs] [Bug 11786] Improve RDFa schema.org mappings in prog and bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11786 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 21:32:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 19:32:09 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #2 from Marjorie Barry-Vila --- Thanks Katrin. Yes, i have superlibrarian permissions and funds are limited to each branch. May i test something else? Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 21:48:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 19:48:49 +0000 Subject: [Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #15 from Katrin Fischer --- Hi Jonathan, I have tested this again and it works as described. But I am a bit worried still - before the patch you could undo a receipt any time, being aware that the items would not be deleted. Now you can undo and the items will be deleted, which is nice. But if there is a hold on the record, you can't undo until you cancel he hold. This could be a problem for a very popular book with multiple holds and multiple copies outside of the order. Then you'd have to cancel all of them, to reenter them again after undoing the receipt. Could showing an alert: 'There is at least 1 hold on this record, please delete items manually' be an option? Or a check on remaining items? If no items remain you shouldn't be able to undo the receipt without fixing it. If there is an item and it's not an item level hold on your ordered item, you could. I am not feeling very sure about this, maybe we could get the bug reporter's (Marjorie?) and some others opinion on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 21:52:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 19:52:39 +0000 Subject: [Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019 --- Comment #3 from Katrin Fischer --- Maybe try removing your superlibrairan flag for a test? And keep all other permissions? I think that could be the difference, that a superlibriarian can always see the funds now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 22:25:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 20:25:04 +0000 Subject: [Koha-bugs] [Bug 11786] Improve RDFa schema.org mappings in prog and bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 22:25:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 20:25:08 +0000 Subject: [Koha-bugs] [Bug 11786] Improve RDFa schema.org mappings in prog and bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26711|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 26712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26712&action=edit [PASSED QA] Bug 11786: Improve RDFa structured data schema.org mappings This patch updates both the prog and bootstrap themes to provide better schema.org mappings for catalogue elements in the following ways: * More granular author attributes (one "author" property per author in records with multiple contributors; wrap in a Person or Organization type instead of using a simple literal value) * Use "byArtist" instead of "author" for music recordings to respect schema.org preferences * Use alternateName instead of alternativeHeadline, as the former is a better parallel to the "name" property Signed-off-by: Dan Scott Signed-off-by: Chris Cormack Only covers MARC21, but that is no reason not to move it forward Signed-off-by: Katrin Fischer Passes all tests. Looked at the source code of a few records in both prog and bootstrap and took a look at the properties using http://www.google.com/webmasters/tools/richsnippets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 22:27:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 20:27:02 +0000 Subject: [Koha-bugs] [Bug 11869] Add more informations to the member printing pages. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |fcapovilla at live.ca |ity.org | --- Comment #11 from Katrin Fischer --- Hi Fr?d?rick, please assign bugs you have patches for to yourself, thx! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 22:30:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 20:30:14 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #39 from Katrin Fischer --- Ok, this gives me a headache :( Can I get a consolidated test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 22:37:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 20:37:51 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #118 from Katrin Fischer --- Applies now and passes QA script, more testing later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 31 23:23:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Mar 2014 21:23:45 +0000 Subject: [Koha-bugs] [Bug 11292] barcode scanner clicking 'save' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 --- Comment #3 from jdemuth at roseville.ca.us --- I wrote a script and put in the the intranetusersjs field that removes the noEnterSubmit function from specific fields. This is now allowing us to scan barcodes without it try to save automatically because of the carriage return set in the scanners. //Remove noEnterSubmit from fields - JD $(document).ready(function(){ $("#userid").removeClass("noEnterSubmit"); $("#cardnumber").removeClass("noEnterSubmit"); $("#subfield952p637072").removeClass("noEnterSubmit"); }); -- You are receiving this mail because: You are watching all bug changes.
BasketBasket byTitleCurrencyVendor Price