[Koha-bugs] [Bug 11885] New: Inconsistent HTML in MARC Details

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885

            Bug ID: 11885
           Summary: Inconsistent HTML in MARC Details
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at pttk.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 25770
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25770&action=edit
Make MARC Details tab HTML consistent

In Catalog > MARC Details, the HTML in the different tabs is slightly
inconsistent and doesn't differentiate different elements, making CSS styling
complicated or impossible:

* tab 0 has <p class="subfield_line"> whereas all the other tabs have just <p>

* all other tabs wrap the subfield character in <b> tags, except for tab 0

* the MARC tag title is a single div with the tag, the indicators and the field
description.


Attached patch folds all the tab outputs into a single TT BLOCK, which is then
reused. It also marks the separate parts of the tag title in their own spans.
The output should be nearly identical to previous behaviour, minus a dash from
the tag title descriptions - it was used to separate the tag from the
description. The description can now be styled separately from the tag itself,
so the dash can be added with CSS, if necessary.


To test:
1) Look at some MARC details in the staff client, noting the contents of each
tab.
2) Install patch
3) Compare the MARC details output to what was shown in step 1. Should be the
same, minus a dash in each of the tag title descriptions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.