[Koha-bugs] [Bug 6427] Rewrite of the accounts system

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #260 from Kyle M Hall <kyle at bywatersolutions.com> ---
Thanks for letting me know! I've rolled the fixes for these 2 issues into the
main patch set since they are still not signed off, rather than post a qa
followup.

(In reply to Rafal Kopaczka from comment #219)
> I've looked quickly at this patch, got 2 issues (or not, correct me if I'm
> wrong):
> 
> 1/ In part 4 patch, there is reference to js file that don't exist in
> repository, next parts also don't contain this file. 
> Bug-6427-Part-04.patch:93:+<script type="text/javascript" src="[% interface
> %]/[% theme %]/en/js/strings.js"></script>
> 
> 2/ In part 3, function format_without_symbol don't handle properly, national
> currencies without leading symbol (eg PLN). It truncate always first
> character even if it's a number. 
> return substr( $self->format( $amount, FMT_SYMBOL ), 1 );
> We can't assume that format always return symbol before number.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.