[Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634

--- Comment #19 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 25148
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25148
Bug 11634 - Allow renewal of item with unfilled holds if other available items
can fill those holds

Review of attachment 25148:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11634&attachment=25148)
-----------------------------------------------------------------

::: C4/Circulation.pm
@@ +2516,5 @@
> +        # Get all other reserves that could have been filled by this item
> +        my @borrowernumbers;
> +        while (1) {
> +            my ( $reserve_found, $reserve, undef ) =
> +              C4::Reserves::CheckReserves( $itemnumber, undef, undef,

I'm not convinced that CheckReserves() is a sufficient test --
IsAvailableForItemLevelRequest() may need to be checked as well.  Otherwise,
damaged, lost, and withdrawn items could "count" as available for filling the
hold when that is not actually the case.

-- 
You are receiving this mail because:
You are watching all bug changes.