[Koha-bugs] [Bug 11755] Argument 'booksellerid' not properly handled in orderreceive.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 5 15:04:19 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755

--- Comment #2 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #1)
> Created attachment 25834 [details] [review]
> Bug 11755: SearchOrders does not return booksellerid
> 
> The SearchOrders routine should return the booksellerid.
> 
> Booksellerid was returned before bug 10723.
> 

Patch does resolve all the issues mentioned; I'm a little worried about an
impact it will have on issue 2), though.. Situation regarding tax recalculation
code in finishreceive.pl seems to be somehow like that:

- in 3.10 & 3.12 branches, this code block was, and still is working like
intended,
- it got broken in 3.14 and up (since bug 10723) resulting in price values in
all newly received orders being inconsistently saved in the database (at least
for those cases where listincgst xor invoiceincgst != 1) ?

As a side effect, some bug reports currently sitting in the queue which regard
various problems with tax calculations in Koha will probably need to be
retested / reevaluated. Still, IMO pushing this patch first (and ASAP) will be
a huge change in the right direction.

I wonder if there may be some way to retroactively correct wrongly calculated
price values which may already got stored in aqorders table, for those people
using 3.14 right now in production environment?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list