[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 7 16:48:26 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #57 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Galen Charlton from comment #54)
> Close, but there is a serious issue left: a regression on bug 2060.
> 
> In particular, this patch regresses on the ability to properly display
> authority record batches.  Instead of linking to the authority details page
> for imported records, for example, it links to the *bibliographic* details
> page.

Fixed!

> Sorting by citation for authority batches is also broken --
> GetImportRecordsRange() is asked to sort by title when it should be sorting
> by authorized_heading.

Fixed!

> By the way, it would be preferable to me if GetImportRecordsRange() did not
> rely on dbh_quote_identifier() to sanitize the sorting column, which at
> present is passed directly from a CGI parameter.  It should instead set
> $order_by to one of a known set of values, similar to how you deal with
> $order_by_direction.

Fixed!

> A much more minor issue: tools/batch_records_ajax.pl asserts that it's both
> GPL2 and GPL3+.

Fixed!

> Please squash your QA follow-ups (but not Owen's) when you resubmit.

Done! New fixes published in followup 8 for easy analysis. All followups
squashed and resubmitted as one patch.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list