[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22387|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 25956
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25956&action=edit
Bug 11139 - opac-topissues does not work with CCODE

When OPAC most populars uses collection code, it does not work.
There are never results.

This patch corrects two points:
 - SQL query uses 'ccode' as collection code authorised values category, it is
CCODE uppercase
 - The constraint category='CCODE' must be inside join detween items and
authorised_values, in this case items.ccode may be NULL

Test plan :
On a catalogue where items.ccode is defined and uses CCODE authorised values :
- Set syspref AdvancedSearchTypes = ccode
- Go to opac-topissues.pl
- If no results, select "No limit" in "of the last:" and submit
=> You get results
- Select in results a biblio and remove items.ccode from all its items
- Refresh opac-topissues.pl (check "All collections" is selected in "Limit
to:")
=> The biblio is still in results

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.