[Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909

wajasu <matted-34813 at mypacks.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |matted-34813 at mypacks.net

--- Comment #1 from wajasu <matted-34813 at mypacks.net> ---
Created attachment 25959
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25959&action=edit
Bug 11909 - Fix hidelostitems, OpacHiddenItems total count, prog theme facet
display

This patch is combined because testing all three as they interact may be
complicated enough and the changes are minimal.

- Stopped hiding biblio when an item is lost.
- Inspected all items to determine if all are hidden to "hide" a biblio.
  (I left it so that if a non-hidden item exists, such as another branches'
item is not hidden, the biblio will still show.)
- Tweaked prog theme to only show facets if the search results count > 0

Bugs that may be affected: 
8462 - hopefully can be obsoleted by this
9966 - can be obsoleted (4004 not found with single result for OpacHiddenItems)
8416 - hopefully can be obsoleted by this. OpacHiddenItems is orthogonal to
hidelostitems, and this patch separates function more.
3194 - obsolete.  I think we want to see the biblio these days. And facets
display provides the further filtering functionality these days. 
11489 - obsolete - no 404 not found errors anymore
Other bugs to consider 3030, 11677

Testing:
(Sometimes requires periodic rebuild_zebra.pl -a -b -r  as Search
search_results might affect what gets indexed.) 

I had a blank test DB with DOM, and default reference test data loaded.
I used Z3950 to catalog 3 biblios and set the title to have something unique
(like xyzzy).  I would typically search for "xzzy" all the time.
You can run or watch zerbasrv -f KOHA_CONF to see how many results are returned
and observe the further filtering by hidden/lost items.

Out of the three cataloged, I added two items from library CPL to one, One with
a CPL and MPL item, and One with a MPL only.  I also would navigate to admin
and change lost status of various items and switch to another tab and runthe
search. Note: You might need to rebuld zebra in some cases, that is whay i
suggested a small size database.

If you already have a large DB with known branches and lost items, you can just
query for things, comparing to the query results in the staff client.

I did not test multiple pages/paging of results, since the patch seemed
minimal, but someone else could.

Note: I though about the hiding of biblios for OpacHiddenItems across
federated/multiple server searches, and I did not address that case.  But that
is a more complex scenario.

Reading different bugs about hiding biblios for all items being lost, with
differing opinons, I chose to provide the biblios and rely on the faceted
availability to futher filter those out.  Hope thats a good compromise. We
could add a syspref for availability to default differently if folks want that.

-- 
You are receiving this mail because:
You are watching all bug changes.