[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Mar 10 20:54:52 CET 2014
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170
--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 23728
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23728
Bug 11170: The pending order list should only display orders to receive
Review of attachment 23728:
--> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11170&attachment=23728)
-----------------------------------------------------------------
Failing on account of the lack of documentation and unit test coverage for the
new parameter to SearchOrders().
::: C4/Acquisition.pm
@@ +1665,4 @@
> my $basketgroupname = $params->{basketgroupname};
> my $owner = $params->{owner};
> my $pending = $params->{pending};
> + my $ordered = $params->{ordered};
There is neither POD nor unit test coverage of this new option.
@@ +1695,5 @@
> + $query .= q{ AND (quantity > quantityreceived OR quantityreceived is NULL)};
> + }
> + if ( $ordered ) {
> + $query .= q{ AND (quantity > quantityreceived OR quantityreceived is NULL)}
> + unless $pending;
The logic here is unnecessarily convoluted. Please restructure so that only
one Boolean test controls whether the "AND (quantity > quantityreceived OR
quantityreceived is NULL)" clause gets added.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list