[Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

--- Comment #14 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 23815
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23815
[PASSED QA] Bug 7288: Allow to display only subscriptions in the invoices table

Review of attachment 23815:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7288&attachment=23815)
-----------------------------------------------------------------

::: C4/Acquisition.pm
@@ +2504,4 @@
>      my $dbh = C4::Context->dbh;
>      my $query = qq{
>          SELECT aqinvoices.*, aqbooksellers.name AS suppliername,
> +          aqorders.subscriptionid,

This does not handle the case where a single invoice has more than one order
with a subscription very well.  In particular, only one subscription would
(arbitrarily) be displayed.

If the goal is to be able to link to all subscriptions on a given invoice, it's
not sufficient to display just one.  If the goal is more simply to just be able
to filter the invoice search for invoices that have one or more subscriptions,
then it would be better calculate a Boolean flag.

Either way, as the patch stands now it is likely to cause confusion for
libraries that have invoices that cover multiple subscriptions -- which is
very, very common in the US, at least.

Failing QA.  When you resubmit, I would also appreciate if you wrote a unit
test for the change in the core routine.

-- 
You are receiving this mail because:
You are watching all bug changes.