[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> ---
Dobrica, sEcho is a parameter datatables sends when using an ajax source. It is
expected that the contents of the parameter be sent back just as it was
received.

Kyle

(In reply to Dobrica Pavlinusic from comment #40)
> Aside from cosmetic notes, I have funny smell about this patch.
> 
> When I open the page, I can see 6 ajax requests which seem to return same
> JSON data. First three of them return 302 and other three return 200.
> 
> However, only difference is in sEcho parameter for which I can't find use in
> code itself. My worry is that we are creating too much unneeded requests to
> the server.
> 
> Below are relevant lines from access log:
> 
> 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET
> /cgi-bin/koha/svc/checkouts.
> pl?sEcho=1&iColumns=12&sColumns=&iDisplayStart=0&iDisplayLength=-
> 1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3=
> itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnum
> ber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10=
> function&mDataProp_11=function&sSearch=&bRegex=false&sSearch_0=&bRegex_0=fals
> e&bSearchable_0=true&sSearch_1=&bRegex_1=false&bSearchable_1=true&sSearch_2=&
> bRegex_2=false&bSearchable_2=true&sSearch_3=&bRegex_3=false&bSearchable_3=tru
> e&sSearch_4=&bRegex_4=false&bSearchable_4=true&sSearch_5=&bRegex_5=false&bSea
> rchable_5=true&sSearch_6=&bRegex_6=false&bSearchable_6=true&sSearch_7=&bRegex
> _7=false&bSearchable_7=true&sSearch_8=&bRegex_8=false&bSearchable_8=true&sSea
> rch_9=&bRegex_9=false&bSearchable_9=true&sSearch_10=&bRegex_10=false&bSearcha
> ble_10=true&sSearch_11=&bRegex_11=false&bSearchable_11=true&iSortCol_0=0&sSor
> tDir_0=desc&iSortingCols=1&bSortable_0=true&bSortable_1=true&bSortable_2=true
> &bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=true&bSortabl
> e_7=false&bSortable_8=false&bSortable_9=false&bSortable_10=false&bSortable_11
> =false&borrowernumber=1 HTTP/1.1" 302 558
> 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET
> /cgi-bin/koha/svc/checkouts.
> pl?sEcho=2&iColumns=12&sColumns=&iDisplayStart=0&iDisplayLength=-
> 1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3=
> itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnum
> ber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10=
> function&mDataProp_11=function&sSearch=&bRegex=false&sSearch_0=&bRegex_0=fals
> e&bSearchable_0=true&sSearch_1=&bRegex_1=false&bSearchable_1=true&sSearch_2=&
> bRegex_2=false&bSearchable_2=true&sSearch_3=&bRegex_3=false&bSearchable_3=tru
> e&sSearch_4=&bRegex_4=false&bSearchable_4=true&sSearch_5=&bRegex_5=false&bSea
> rchable_5=true&sSearch_6=&bRegex_6=false&bSearchable_6=true&sSearch_7=&bRegex
> _7=false&bSearchable_7=true&sSearch_8=&bRegex_8=false&bSearchable_8=true&sSea
> rch_9=&bRegex_9=false&bSearchable_9=true&sSearch_10=&bRegex_10=false&bSearcha
> ble_10=true&sSearch_11=&bRegex_11=false&bSearchable_11=true&iSortCol_0=0&sSor
> tDir_0=desc&iSortingCols=1&bSortable_0=true&bSortable_1=true&bSortable_2=true
> &bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=true&bSortabl
> e_7=false&bSortable_8=false&bSortable_9=false&bSortable_10=false&bSortable_11
> =false&borrowernumber=1 HTTP/1.1" 302 558
> 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET
> /cgi-bin/koha/svc/checkouts.
> pl?sEcho=3&iColumns=12&sColumns=&iDisplayStart=0&iDisplayLength=-
> 1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3=
> itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnum
> ber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10=
> function&mDataProp_11=function&sSearch=&bRegex=false&sSearch_0=&bRegex_0=fals
> e&bSearchable_0=true&sSearch_1=&bRegex_1=false&bSearchable_1=true&sSearch_2=&
> bRegex_2=false&bSearchable_2=true&sSearch_3=&bRegex_3=false&bSearchable_3=tru
> e&sSearch_4=&bRegex_4=false&bSearchable_4=true&sSearch_5=&bRegex_5=false&bSea
> rchable_5=true&sSearch_6=&bRegex_6=false&bSearchable_6=true&sSearch_7=&bRegex
> _7=false&bSearchable_7=true&sSearch_8=&bRegex_8=false&bSearchable_8=true&sSea
> rch_9=&bRegex_9=false&bSearchable_9=true&sSearch_10=&bRegex_10=false&bSearcha
> ble_10=true&sSearch_11=&bRegex_11=false&bSearchable_11=true&iSortCol_0=0&sSor
> tDir_0=desc&iSortCol_1=0&sSortDir_1=desc&iSortingCols=2&bSortable_0=true&bSor
> table_1=true&bSortable_2=true&bSortable_3=true&bSortable_4=true&bSortable_5=t
> rue&bSortable_6=true&bSortable_7=false&bSortable_8=false&bSortable_9=false&bS
> ortable_10=false&bSortable_11=false&borrowernumber=1 HTTP/1.1" 302 564
> 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET
> /intranet-tmpl/prog/img/ascdesc.gif HTTP/1.1" 304 -
> 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET
> /cgi-bin/koha/svc/checkouts.
> pl?sEcho=1&iColumns=12&iDisplayStart=0&iDisplayLength=-
> 1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3=
> itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnum
> ber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10=
> function&mDataProp_11=function&bRegex=false&bRegex_0=false&bSearchable_0=true
> &bRegex_1=false&bSearchable_1=true&bRegex_2=false&bSearchable_2=true&bRegex_3
> =false&bSearchable_3=true&bRegex_4=false&bSearchable_4=true&bRegex_5=false&bS
> earchable_5=true&bRegex_6=false&bSearchable_6=true&bRegex_7=false&bSearchable
> _7=true&bRegex_8=false&bSearchable_8=true&bRegex_9=false&bSearchable_9=true&b
> Regex_10=false&bSearchable_10=true&bRegex_11=false&bSearchable_11=true&iSortC
> ol_0=0&sSortDir_0=desc&iSortingCols=1&bSortable_0=true&bSortable_1=true&bSort
> able_2=true&bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=tr
> ue&bSortable_7=false&bSortable_8=false&bSortable_9=false&bSortable_10=false&b
> Sortable_11=false&borrowernumber=1 HTTP/1.1" 200 1939
> 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET
> /cgi-bin/koha/svc/checkouts.
> pl?sEcho=2&iColumns=12&iDisplayStart=0&iDisplayLength=-
> 1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3=
> itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnum
> ber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10=
> function&mDataProp_11=function&bRegex=false&bRegex_0=false&bSearchable_0=true
> &bRegex_1=false&bSearchable_1=true&bRegex_2=false&bSearchable_2=true&bRegex_3
> =false&bSearchable_3=true&bRegex_4=false&bSearchable_4=true&bRegex_5=false&bS
> earchable_5=true&bRegex_6=false&bSearchable_6=true&bRegex_7=false&bSearchable
> _7=true&bRegex_8=false&bSearchable_8=true&bRegex_9=false&bSearchable_9=true&b
> Regex_10=false&bSearchable_10=true&bRegex_11=false&bSearchable_11=true&iSortC
> ol_0=0&sSortDir_0=desc&iSortingCols=1&bSortable_0=true&bSortable_1=true&bSort
> able_2=true&bSortable_3=true&bSortable_4=true&bSortable_5=true&bSortable_6=tr
> ue&bSortable_7=false&bSortable_8=false&bSortable_9=false&bSortable_10=false&b
> Sortable_11=false&borrowernumber=1 HTTP/1.1" 200 1940
> 193.198.212.4 - - [11/Mar/2014:09:44:07 +0100] "GET
> /cgi-bin/koha/svc/checkouts.
> pl?sEcho=3&iColumns=12&iDisplayStart=0&iDisplayLength=-
> 1&mDataProp_0=function&mDataProp_1=function&mDataProp_2=function&mDataProp_3=
> itemtype&mDataProp_4=issuedate&mDataProp_5=branchname&mDataProp_6=itemcallnum
> ber&mDataProp_7=function&mDataProp_8=price&mDataProp_9=function&mDataProp_10=
> function&mDataProp_11=function&bRegex=false&bRegex_0=false&bSearchable_0=true
> &bRegex_1=false&bSearchable_1=true&bRegex_2=false&bSearchable_2=true&bRegex_3
> =false&bSearchable_3=true&bRegex_4=false&bSearchable_4=true&bRegex_5=false&bS
> earchable_5=true&bRegex_6=false&bSearchable_6=true&bRegex_7=false&bSearchable
> _7=true&bRegex_8=false&bSearchable_8=true&bRegex_9=false&bSearchable_9=true&b
> Regex_10=false&bSearchable_10=true&bRegex_11=false&bSearchable_11=true&iSortC
> ol_0=0&sSortDir_0=desc&iSortCol_1=0&sSortDir_1=desc&iSortingCols=2&bSortable_
> 0=true&bSortable_1=true&bSortable_2=true&bSortable_3=true&bSortable_4=true&bS
> ortable_5=true&bSortable_6=true&bSortable_7=false&bSortable_8=false&bSortable
> _9=false&bSortable_10=false&bSortable_11=false&borrowernumber=1 HTTP/1.1"
> 200 1940
> 
> 
> Patch is quite huge, so it's possible that I missed something obvious, so I
> would really appreciate clarification on this.

-- 
You are receiving this mail because:
You are watching all bug changes.