[Koha-bugs] [Bug 10859] Alert if a patron already has an issue for the same biblio

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Mar 11 15:16:22 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 25366
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25366
[Signed-off] Bug 10859: Alert if a borrower already has an issue for the same
biblio

Review of attachment 25366:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10859&attachment=25366)
-----------------------------------------------------------------

Hi Julian,

some notes from me - could you take a look please?

::: C4/Circulation.pm
@@ +1051,5 @@
> +        my $is_a_subscription = C4::Serials::CountSubscriptionFromBiblionumber($biblionumber);
> +        unless ($is_a_subscription) {
> +            my $issues = GetIssues( {
> +                borrowernumber => $borrower->{borrowernumber},
> +                biblionumber   => $biblionumber,

I like that it excludes items that belong to serials. Could we add this to the
system preference description for documentation?

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ +341,5 @@
> +            - pref: AllowMultipleIssuesOnABiblio
> +              choices:
> +                  yes: Allow
> +                  no: "Don't allow"
> +            - patrons to check out multiple items from the same biblio.

Not a native speaker, but maybe:

Allow/Don't allow patrons to check out multiple items from the same record,
except for records with subscriptions.

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ +271,5 @@
>  [% END %]
> +
> +[% IF BIBLIO_ALREADY_ISSUED %]
> +  <li>
> +    Borrower has already an issue on another item from this biblio.

I think we prefer 'patron', 'check out' and 'record' in the interface, so maybe
we could say:

Patron has already checked out another item from this record.

::: t/db_dependent/Circulation/GetIssues.t
@@ +97,5 @@
> +        DelBranch($branchcode);
> +    }
> +};
> +
> +done_testing;

The tests are failing for me :( 

prove t/db_dependent/Circulation/GetIssues.t
t/db_dependent/Circulation/GetIssues.t .. Undefined subroutine &main::GetIssues
called at t/db_dependent/Circulation/GetIssues.t line 61.
t/db_dependent/Circulation/GetIssues.t .. Dubious, test returned 255 (wstat
65280, 0xff00)
No subtests run 

I also notice that you don't use the 'new rollback transactions trick'. I think
if you added this to your tests, you could also avoid having to cleanup as the
database in the ind. It will just go back to the state it was in before the
tests were run. I think you can find an example in Reserves.t and also some
other test files.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list