[Koha-bugs] [Bug 11302] Template::output should deal with object

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 12 11:01:43 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23154|0                           |1
        is obsolete|                            |

--- Comment #7 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 26151
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26151&action=edit
Bug 11302: Template::output should deal with objects

If a ref is not HASH or ARRAY, C4::Template::output assumes it
is a scalar. Which is wrong, it could be an object.

Note: this is yet another / alternative take on the problem,
with only bare minimum changes made to the code base, so
this (counter-)patch - while not pretty - hopefully should be
less regression-prone. Right now, the only white-listed object
this patch deals with is 'Koha::AdditionalField' introduced
by bug 10855. In case it tests OK, without any regressions, we can
add another objects (C4::Category etc.) later on.

Test plan:
1) apply bug 10855 first; observe that non-ascii characters
(in authorized category names or additional field labels) are not
properly handled,
2) apply patch,
3) ensure that encoding of non-ascii characters for features added
by 10855 got fixed,
4) there should be no character-encoding-related regressions
of any kind appearing anywhere in the system.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list