[Koha-bugs] [Bug 11917] upload patron image can raise a software error

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11917

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #6 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
I appreciate the idea behind the patch, but do not really see the actual
benefits of this code. Without DEBUG=1 (as we assume in normal operation), I do
not see any difference.
I think that the routine in Members, PutPatronImage, should be addressed in
this report. It combines the insert into patronimage with the select on
cardnumber. It could check cardnumber first.
Note that if I see "There is a database error. See the log", I would rather see
the error message right away. And the message is passed back by PutPatronImage.

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.