[Koha-bugs] [Bug 11912] GetMarcISBN wrongly prepends a space to ISBNs

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 13 15:29:11 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11912

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26277|0                           |1
        is obsolete|                            |

--- Comment #8 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 26288
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26288&action=edit
[SIGNED-OFF] Bug 11912: (refactoring followup) GetMarcISBN should implement its
advertised API

The current implementation of GetMarcISBN contradicts the documented API.
It currently returns an array of hashes with only one key (marcisbn) which
doesn't add any value to it.

I chose to fix GetMarcISBN to honour the API instead of changing the docs,
because it seems a really silly change.

To test:
- Run:
  prove t/db_dependent/Biblio.t
=> SUCCESS
- catalogue/detail.pl should correctly show ISBNs.
- opac/opac-detail.pl should correctly show ISBNs in both prog and bootstrap.
- opac-opac-sendshelf.pl should correctly show ISBNs in the email.
- Sign off :-D

Edit: forgot to git add some templates and fixing the unit tests.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list