[Koha-bugs] [Bug 11848] Make Koha::I18N easier to use

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
> You are using interface as both a get and set, correct?
Correct!

> Why not // instead?
> Also, interface is defined. This line is pointless.
C4::Context->interface # getter only
C4::Context->interface('') # getter and setter, set to opac because '' is a
defined but false value

> perhaps a lc or uc may be useful? maybe some validation of the value?
> What if you haven't set the interface and you get undef? It would seem the
> default assumption is 'opac'. Perhaps add a "// 'opac'"?
Sure. I will provide a patch for these issues. But not immediately, maybe next
week.

Thanks for the review! :)

-- 
You are receiving this mail because:
You are watching all bug changes.