[Koha-bugs] [Bug 11960] New: GetMemberDetails is unnecessarily called in CanBookBeRenewed

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 19 16:38:05 CET 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11960

            Bug ID: 11960
           Summary: GetMemberDetails is unnecessarily called in
                    CanBookBeRenewed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

C4::Circulation::CanBookBeRenewed calls C4::Members::GetMemberDetails to
retrieve categorycode and branchcode.

- categorycode is used to retrieve the issuing rule
- the borrower information is passed to C4::Circulation::_GetCircControlBranch.
Which only uses the branchcode parameter.

GetMemberDetails does a lot of useless calls/queries (patronflags, account,
etc.)

This call could be replaced with a call to C4::Members::GetMember

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list